[engine] add a [damage_type] special/ability who modify the type of attack used

[Lord-Knightmare]

Another (less important and more complicated) feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time.

You can already do this via EventWML but having an easier to use [damage_style] can be very convenient as well.

[newfrenchy83]

i added https://github.com/wesnoth/wesnoth/pull ... 99614d4e10 commit for what [damage_type] choose between primary type or secondary type depending resistance of opponent to each type without have specifie in[filter_oppoent]formula that what will be redundant. i also added code for both type showed in report bar :

double typeshowed in report unit

and in attac_prediction windows

double type showed in window

If concept intessting please return comment.

[newfrenchy83]

Another (less important and more complicated) feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time.

You can already do this via EventWML but having an easier to use [damage_style] can be very convenient as well.

I hesitate between three possible behaviors for [damage_type]
1) the purely substitutional approach, damage_type replaces the type of the attack by another when the conditions are met.
2) a semi-substitutive approach: the replacement can only be done if the adversary is more vulnerable to the type imposed by [damage_type] than to the original type (this avoids programming a [damage_type] for each original type to be checked ), for the player and the wml developer, it remains more intuitive than the last option below and applicable in the mainline
3) the approach mentioned above, feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time. interesting for extension developers who use wml to achieve this approach

I can program two options out of the three but I have to choose which one will be excluded for me it will be the 1st ([effect]set_type already exists.

I therefore invite those who read this topic to share their opinion with me.

[Ravana]

2) seems most useful for me.

[Pentarctagon]

(3) would likely have implications for things that need to calculate predicted damage (the AI, the damage calculations window, etc). I haven't looked, but I wouldn't expect them to be able to currently handle an attack that deals multiple types of damage at the same time.

[Lord-Knightmare]

Another (less important and more complicated) feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time.

You can already do this via EventWML but having an easier to use [damage_style] can be very convenient as well.

I hesitate between three possible behaviors for [damage_type]
1) the purely substitutional approach, damage_type replaces the type of the attack by another when the conditions are met.
2) a semi-substitutive approach: the replacement can only be done if the adversary is more vulnerable to the type imposed by [damage_type] than to the original type (this avoids programming a [damage_type] for each original type to be checked ), for the player and the wml developer, it remains more intuitive than the last option below and applicable in the mainline
3) the approach mentioned above, feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time. interesting for extension developers who use wml to achieve this approach

I can program two options out of the three but I have to choose which one will be excluded for me it will be the 1st ([effect]set_type already exists.

I therefore invite those who read this topic to share their opinion with me.

All three seem good to me. I have uses for each.

[newfrenchy83]

I hesitate between three possible behaviors for [damage_type]
1) the purely substitutional approach, damage_type replaces the type of the attack by another when the conditions are met.
2) a semi-substitutive approach: the replacement can only be done if the adversary is more vulnerable to the type imposed by [damage_type] than to the original type (this avoids programming a [damage_type] for each original type to be checked ), for the player and the wml developer, it remains more intuitive than the last option below and applicable in the mainline
3) the approach mentioned above, feature would be to have mixed damage, e.g. a fire sword that does 50% blade and 50% fire damage at the same time. interesting for extension developers who use wml to achieve this approach

I can program two options out of the three but I have to choose which one will be excluded for me it will be the 1st ([effect]set_type already exists.

I therefore invite those who read this topic to share their opinion with me.

i make my choices: this will be 1) by default and 2) with cumulative=yes