[solved] [engine] min_value for [resistance]

[white_haired_uncle]

[resistance] takes a max_value, but does not have a min_value (or max_negative_value, which may be a little easier to understand).

LotI has an ability called adamant, which triples resistances, but only up max_value=80%. However, it also has a penetration special, which has an effect to lower resistance of adjacent units. Therefore, it is possible to lower an enemy's resistance to say -60 which would then be tripled to -180% if that unit had adamant. It seems to me only fair that it should at least be possible to cap negative resistance effect to -80% if you're going to cap positive resistance effect at 80%. Of course, the author may not want those to match, so IMO max and min should be separate arguments (as opposed to making max an absolute value such that max/min always match).

[Ravana]

This is not about min_value, it is about order of operations. Even mainline steadfast will double weaknesses when weakness is caused by another ability.

[white_haired_uncle]

I'm fine with multiplying weakness. That's not it this is about.

The issue is that the effect is capped on the positive side, but not the negative, hence min (max_negative) value.

[newfrenchy83]

i push a PR https://github.com/wesnoth/wesnoth/pull/8133 for use max_value and min_value attribute in all abilities or pecials who return numerical value

[white_haired_uncle]

thank you

[newfrenchy83]

PR not yet commited, don't thanck me too fast