[solved] two [grid] tags

[Ravana]

viewtopic.php?p=677611

[white_haired_uncle]

Hmm. I can look at

Code: Select all

                dialog.my_tb.on_modified = function() 
                        if dialog.my_tb.text == " " then dialog:close() end

and it's pretty clear what's going to happen.

After reading through that thread several times, I think I see what utils.handle_event_commands is supposed to do (though good luck finding it on the wiki unless you know exactly what to search for). And I have absolutely no idea how that example is going to cause the gui to close because the user hit the space bar.

Might be incredibly useful, once you figure it out, but I wouldn't call it simplified. And perhaps it is simple if you already know what it is and how to use it, but just to look at it for the first time, not so much.

[Ravana]

wml-utils part is reference how to test this code, it has nothing to do with dialogs.

[Celtic_Minstrel]

(though good luck finding it on the wiki unless you know exactly what to search for).

Why is that? Is there something that could be done to make it easier to find?

[ZombieKnight]

Ehm... I've been LONG looking for something like dialog.on_key.space = dialog:close()

[ZombieKnight]

Btw
Turned out that implementing speaker(non-narrator)
Isn't so simple...
How does message store unit and how to make it again in lua custom_dialog?

[white_haired_uncle]

(though good luck finding it on the wiki unless you know exactly what to search for).

Why is that? Is there something that could be done to make it easier to find?

Based on this:

# lua wesnoth.require("wml-utils").handle_event_commands(wml.load("~add-ons/EventLoader/action.cfg"))

I did a wiki search for 'handle_event_commands' which came back with nothing. I then did a search on brave for 'handle_event_commands site:wesnoth.org'
which got me to https://wiki.wesnoth.org/LuaAPI/wml-uti ... t_commands. Back to the wiki, I found that I could find that page only if I searched for 'utils.handle_event_commands'.

https://wiki.wesnoth.org/LuaAPI/wml-utils says

All examples on this page will assume it has been loaded by:

local utils = wesnoth.require "wml-utils"

which I think is the problem. I would change the documentation to use just handle_event_commands, and then add the require and use utils.handle_event_commands in the examples.

[Ravana]

That is why I created https://wiki.wesnoth.org/Template:Lua_Functions for https://wiki.wesnoth.org/LuaAPI as documentation where you can actually use search.

I say again that handle_event_commands has nothing to do with current topic about grids and closing. It is way how to run wml such as [lua] midscenario with debug command.

[Celtic_Minstrel]

It is way how to run wml such as [lua] midscenario with debug command.

Or rather, it is the function to run arbitrary ActionWML for any reason whatsoever.

[white_haired_uncle]

It is way how to run wml such as [lua] midscenario with debug command.

Or rather, it is the function to run arbitrary ActionWML for any reason whatsoever.

Arbitrary ActionWML which could be stored in a file and read (repeatedly) at runtime, allowing you to change WML without the whole F5-restart stuff? That was the impression I got from the linked thread.

wml-utils part is reference how to test this code, it has nothing to do with dialogs.

Okay, that makes more sense. You removed the callback that dealt with hitting the space bar to close (click_dismiss doesn't do that, does it, just mouse click I thought?), and added the wml-utils, so I assumed that the wml-utils... somehow was a replacement for the callback which confused me to no end.