A Song of Fire: SP Campaign Feedback and Reviews

[Konrad2]

S1
Can anything be done about my allied ai? As you can see, they don't really like sending their units forward at the enemy, instead they cluster around their castle. Which is at odds with what my allied leader said, defeating the enemy as fast as they can.

S2
to be in trouble -> to be in trouble.

S4
dwarves again -> dwarves again.

S6b
to a... old friend. -> to an... old friend.

S9 Bitter Return
For some reason
"It hurts! Myra, save me…!"
is displayed as
It hurts! Myra, save me

My best guess is: Since "…" is apparently one character instead of three dots, wesnoth doesn't display it and for some reason everything following it isn't displayed either..?


The 'stronger melee blows' AMLA on Veela, a Runeforger (a unit without ANY melee attack)... please remove it.

[Lord-Knightmare]

Can anything be done about my allied ai? As you can see, they don't really like sending their units forward at the enemy, instead they cluster around their castle. Which is at odds with what my allied leader said, defeating the enemy as fast as they can.

Should they rush to enemy keep? I guess I can do that. Will take me 20 secs.

S2
to be in trouble -> to be in trouble.

S4
dwarves again -> dwarves again.

S6b
to a... old friend. -> to an... old friend.

S9 Bitter Return
For some reason
"It hurts! Myra, save me…!"
is displayed as
It hurts! Myra, save me

My best guess is: Since "…" is apparently one character instead of three dots, wesnoth doesn't display it and for some reason everything following it isn't displayed either..?

Typos...and yeah..some text editors like notepad/textedit/MSword auto-replace ... with a special version of this which is not recognized by the client. I guess they have to found and replaced with MSR

How the heck can you upload so many replay files in one post? Unfair. Give me more replay posting limiter.

[Lord-Knightmare]

New version out now. The music pack dependency is not available yet. I dont like uploading such a chonky addon and I play with no game music..so it's fine.

Code: Select all

V 1.0.5.78
- General
    --> S1: made AI Ally more aggressive
    --> S2, S4, S6B, S9: text typo fixes.
    --> Units:
        --> Hero: Akashia
            Deva's Fury has attack-only special now.
            This fixes her degraded functionality when she gains it
            It was apparent that this was the her goto retaliation attack and this made her
            a walking defeat-condition during late game. So, making it offense-only.
        --> Hero: Veela
            Removed Melee AMLA...I mean why...revan...just why?

[gnombat]

Typos...and yeah..some text editors like notepad/textedit/MSword auto-replace ... with a special version of this which is not recognized by the client. I guess they have to found and replaced with MSR

The problem was probably that the file was not using the UTF-8 encoding - the ellipsis character should work if the file is UTF-8.

It looks like there are several files not using UTF-8:

Code: Select all

$ for i in `find . -name '*.cfg'`; do iconv -f utf-8 -t utf-8 $i > /dev/null; done

iconv: ./scenarios/05_Forest_Ablaze.cfg:316:157: cannot convert

iconv: ./scenarios/10_The_Wilderness.cfg:808:55: cannot convert

iconv: ./scenarios/11_Legend_Of_The_Water_Dragon.cfg:1046:42: cannot convert

iconv: ./scenarios/14_The_Sky_Dragon_Descends.cfg:1356:44: cannot convert

iconv: ./scenarios/15_Farewell_b.cfg:308:27: cannot convert

iconv: ./units/Saurian_Seer.cfg:19:130: cannot convert

iconv: ./utils/intros.cfg:543:140: cannot convert

[Lord-Knightmare]

iconv: ./scenarios/05_Forest_Ablaze.cfg:316:157: cannot convert

iconv: ./scenarios/10_The_Wilderness.cfg:808:55: cannot convert

iconv: ./scenarios/11_Legend_Of_The_Water_Dragon.cfg42: cannot convert

iconv: ./scenarios/14_The_Sky_Dragon_Descends.cfg44: cannot convert

iconv: ./scenarios/15_Farewell_b.cfg:308:27: cannot convert

iconv: ./units/Saurian_Seer.cfg:19:130: cannot convert

iconv: ./utils/intros.cfg:543:140: cannot convert

Arigatou Ozaimasu. I shall re-encode the aforementioned files. Also, Saurian Seer unit is shipped with WoL so I will just delete it from ASoF now. No need for duplicates

[Lord-Knightmare]

I updated some files encoding to utf-8. for now.

Update: this massive campaign is immune to wmllint as running it breaks several dialogue formatting due to usage of asterisk and other special symbols. Ouch.
Not sure about wmlindent. Need to run this tomorrow to check.

[Konrad2]

Any chance you can make my allied leaders in 'The Sky Dragon Descends' less suicidal? (Mind you, I'm fine with the way their units behave. Just not a fan of their leaders rushing out.)

[Lord-Knightmare]

Any chance you can make my allied leaders in 'The Sky Dragon Descends' less suicidal? (Mind you, I'm fine with the way their units behave. Just not a fan of their leaders rushing out.)

Just the elf and trolls leaders? Sure. I guess it's a not a problem for them to keep camp.

[Lord-Knightmare]

Code: Select all

V 1.0.5.80
--> S14: Made allied AI leaders non-suicidal

New update! Order up!

[oooo]

The version 1.0.5.80 has some strange characters. For example, 11_Legend_Of_The_Water_Dragon.cfg includes U+FFFD (REPLACEMENT CHARACTER) instead of ⁢U+2026 (HORIZONTAL ELLIPSIS).

The old version by revansurik seems to be encoded by WINDOWS-1252, so probably we can use "iconv -f WINDOWS-1252 -t UTF-8 old > new".

[Konrad2]

S19 Fires of Hope
It says at the beginning of the scenario that I won't be able to recall any dwarves. But I still can recall Thunder- and Dragonguards. (Which makes sense storywise (the dwarves are needed to cut down trees) but it doesn't mash with the message.)

flee this continent, uh? -> flee this continent, huh?

Other stuff
Alenya (Elvish Enchantress) has an AMLA that makes her glossamer attack magical. The result is an attack with the specials slow, slow, magical.

Also, she doesn't have a sprite for when she heals, so she turns invisible when she heals a unit.

Ravyan (Flagbearer) has the 'leadership (lvl2/3) when he is a lvl 2/3 unit.

Tarkan (lvl 3 Hannk unit) has leadership (lvl 3).

Scythe Charioteer (Hannuk) and its advancement lack an image for the scythe attack.

[Lord-Knightmare]

It says at the beginning of the scenario that I won't be able to recall any dwarves. But I still can recall Thunder- and Dragonguards. (Which makes sense storywise (the dwarves are needed to cut down trees) but it doesn't mash with the message.)

I remember you playing this so many times...why bring up this now?

Ravyan (Flagbearer) has the 'leadership (lvl2/3) when he is a lvl 2/3 unit.

Tarkan (lvl 3 Hannk unit) has leadership (lvl 3).

I feel like that's the case...I mean level 3 leadership for level 3 unit XD
What are you even trying to communicate?

flee this continent, uh? -> flee this continent, huh?

Other stuff
Alenya (Elvish Enchantress) has an AMLA that makes her glossamer attack magical. The result is an attack witt the specials slow, slow, magical.

Also, she doesn't have a sprite for when she heals, so she turns invisible when she heals a unit.

I can patch in a follow-up release tomorrow maybe or tonight. Depends on how efficiently I can type HW

[Lord-Knightmare]

The version 1.0.5.80 has some strange characters. For example, 11_Legend_Of_The_Water_Dragon.cfg includes U+FFFD (REPLACEMENT CHARACTER) instead of ⁢U+2026 (HORIZONTAL ELLIPSIS).

The old version by revansurik seems to be encoded by WINDOWS-1252, so probably we can use "iconv -f WINDOWS-1252 -t UTF-8 old > new".

Is there any way to just...well...mass-encode it all to common utf-8? From VScode preferably? Unless given clear/concise instructions, I won't change anything if it's too time consuming.

[Konrad2]

It says at the beginning of the scenario that I won't be able to recall any dwarves. But I still can recall Thunder- and Dragonguards. (Which makes sense storywise (the dwarves are needed to cut down trees) but it doesn't mash with the message.)

I remember you playing this so many times...why bring up this now?

That on the other hand I can't remember.

Ravyan (Flagbearer) has the 'leadership (lvl2/3) when he is a lvl 2/3 unit.

Tarkan (lvl 3 Hannk unit) has leadership (lvl 3).

I feel like that's the case...I mean level 3 leadership for level 3 unit XD
What are you even trying to communicate?

I'm not saying that they have the leadership ability (like a normal unit), instead they have the 'leadership lvlx' ability. For no reason. It looks weird.

Spoiler:

tarkan.png (82.6 KiB) Viewed 606 times

flagbearer.png (76.56 KiB) Viewed 606 times

Intros (THE_WILL_OF_THE_NAIAD_STORY)

loll.png (1.15 KiB) Viewed 599 times

This has happened at multiple places in the intro file.

S20 Ring of Fire
S21 Will of the Naiad
S21 Will of the Naiad b
Pls do not recreate the Naiad every scenario, it's not pretty. :C

Militant (celestials)
no image for any of its attacks.

Liliel (a hero unit) demands upkeep.

S24 The Sun Path (wait what, how many scenarios already? ._.)
before the minotaurs of those darn blood-suckers get to her first!" -> before the minotaurs or those darn blood-suckers get to her first!"

[oooo]

Is there any way to just...well...mass-encode it all to common utf-8? From VScode preferably? Unless given clear/concise instructions, I won't change anything if it's too time consuming.

The newest version that is not corrupted seems to be 1.0.5.78, but some files are already converted to UTF-8 encoded? The attached shell script file can convert the remain files:
run "/bin/sh ./conv_special_char.txt A_Song_of_Fire" on add-ons directory.

I don't know about VScode, sorry.

In 1.0.5.78, the following files are not encoded by UTF-8:
scenarios/05_Forest_Ablaze.cfg
scenarios/10_The_Wilderness.cfg
scenarios/11_Legend_Of_The_Water_Dragon.cfg
scenarios/14_The_Sky_Dragon_Descends.cfg
scenarios/15_Farewell_b.cfg
units/Saurian_Seer.cfg
utils/intros.cfg

Edit: The diff file is attached.