--- Log opened Thu Nov 06 00:00:20 2008 20081106 00:00:30 uhm, how is "update add-ons" supposed to work on 1.5? 20081106 00:00:57 looks a bit scary to me, but I clicked anyway and it refused to do any work for me =/ 20081106 00:21:44 -!- Elvish_Pillage2 [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20081106 00:23:43 -!- Elvish_Pillager [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20081106 00:24:47 -!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has quit [Read error: 104 (Connection reset by peer)] 20081106 00:45:12 -!- grrrX [n=_@p57BBC0DC.dip.t-dialin.net] has quit ["Ex-Chat"] 20081106 01:07:16 -!- [Relic] [n=[Relic]@adsl-76-229-220-201.dsl.milwwi.sbcglobal.net] has joined #wesnoth-dev 20081106 01:08:19 <[Relic]> Hello :) 20081106 01:23:18 -!- Elvish_Pillage2 [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has quit ["Hi! I'm a quit message virus vaccine. If you see a quit message virus, don't replace your quit message with it!"] 20081106 01:52:35 -!- Sapient [n=sapien-x@c-71-59-35-203.hsd1.ga.comcast.net] has joined #wesnoth-dev 20081106 01:58:32 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has joined #wesnoth-dev 20081106 02:42:39 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has quit ["GO, GET TO THE CHOPPAH!!!"] 20081106 02:42:50 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has joined #wesnoth-dev 20081106 02:54:24 ai0867 * r30632 /trunk/data/campaigns/Legend_of_Wesmere/about.cfg: * Update LoW credits. 20081106 02:56:56 thanks AI0867 20081106 02:57:26 anyone knows what happened to fendrin? 20081106 03:00:27 nope 20081106 03:00:39 I just took a look at 12546 20081106 03:00:45 the cause is pretty obvious 20081106 03:00:57 there's integer casting *EVERYWHERE* in the math parts of set_variable 20081106 03:01:10 "0.5" is assigned as a string 20081106 03:01:14 then to multiply it 20081106 03:01:27 it's first run through atof, then cast to integer 20081106 03:01:49 cast to double, multiplied with the atof(value) 20081106 03:01:52 then cast to int and stored 20081106 03:02:00 it's ridiculous 20081106 03:02:53 with 'add', atof is used for the original, atoi for the addition, but the first is cast to integer before the operation takes place 20081106 03:03:19 I think we should start with specifying what [set_variable] *should* do though 20081106 03:04:41 shikadibot: seen fendrin 20081106 03:04:42 esr: fendrin quit IRC with message: "Remote closed the connection" 1 week 3 days 8h 14m 33s ago. 20081106 03:04:55 Hrm. 20081106 03:05:51 fendrin struck me as being pretty reliable. I wonder what happened to him? 20081106 03:19:27 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has quit [] 20081106 04:47:18 -!- Psyche^ [n=Psyche@e177230184.adsl.alicedsl.de] has joined #wesnoth-dev 20081106 04:48:30 -!- Patterner [n=Psyche@e177226144.adsl.alicedsl.de] has quit [Read error: 60 (Operation timed out)] 20081106 04:48:30 -!- Psyche^ is now known as Patterner 20081106 04:55:33 -!- Ivanovic_ [n=ivanovic@dtmd-4db20988.pool.einsundeins.de] has joined #wesnoth-dev 20081106 05:12:07 -!- Ivanovic [n=ivanovic@dtmd-4db23d17.pool.einsundeins.de] has quit [Read error: 110 (Connection timed out)] 20081106 05:13:31 -!- Ivanovic_ is now known as Ivanovic 20081106 05:22:44 <[Relic]> big ogg files :( 20081106 05:33:11 <[Relic]> 1.5 and 1.5.5+svn don't work :( 20081106 05:42:51 -!- Netsplit niven.freenode.net <-> irc.freenode.net quits: suokko 20081106 05:45:45 -!- Netsplit over, joins: suokko 20081106 05:59:38 -!- [Relic] [n=[Relic]@adsl-76-229-220-201.dsl.milwwi.sbcglobal.net] has quit ["Leaving"] 20081106 06:05:19 -!- Sapient [n=sapien-x@c-71-59-35-203.hsd1.ga.comcast.net] has quit [] 20081106 06:58:42 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has joined #wesnoth-dev 20081106 07:50:40 -!- crimson_penguin [n=ben@64.201.60.220] has quit ["Leaving"] 20081106 08:16:37 -!- mordante [n=chatzill@roadie.xs4all.nl] has joined #wesnoth-dev 20081106 08:16:59 morning 20081106 09:11:25 nice cleanups Rh0nda :) 20081106 09:32:14 -!- loonybot [n=loonybot@79.139.247.220] has joined #wesnoth-dev 20081106 09:32:40 -!- loonycyborg [n=sergey@79.139.247.220] has joined #wesnoth-dev 20081106 10:14:05 -!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev 20081106 10:15:42 mordante: needed 20081106 10:16:21 :) yes but there's a difference between what needs to be done and what gets done ;) 20081106 10:16:31 * mordante looks at his long todo list ;) 20081106 10:17:04 Just watched a ThomasD podcast about cleaning up - somehow that motivated me strangely 20081106 10:17:36 * Rh0nda . o O ( yes, whoever watches those to - that's an *ancient* one ... ) 20081106 10:18:43 I haven't seen it and no idea who ThomasD is 20081106 10:20:42 One of the rappers from the german combo Die fantastischen Vier 20081106 10:26:08 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has quit [] 20081106 10:27:10 ah that tells me more, I heard some of their songs on the radio and I think I even heard an interview with them on the radio 20081106 10:38:54 -!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"] 20081106 11:10:34 -!- zookeeper [n=l@dsl-tkubrasgw1-fe11fa00-51.dhcp.inet.fi] has joined #wesnoth-dev 20081106 11:35:48 mordante: Is there anything on that todo list you could offload to me? I'm going to be out of projects once I finish updating the scenario-music lists in mainline -- everything else I want to do is blocked on the AI bug. 20081106 11:44:59 esr not really, most involve widgets or some more complex C++ items, but if you're bored I can remind you of one of your own ideas ;) 20081106 11:45:10 Which one? 20081106 11:46:18 #include cleanup see test whether an #include in a .hpp is really needed and if so test whether the .cpp doesn't include it 20081106 11:46:51 I can think of some more complex parts of it as well 20081106 11:47:30 eg test whether a forward class definition can also be used instead of the #include 20081106 11:47:59 Yeah, I did put some thought into that. I started writing Python script called "deheader" that would search for removable header filles. 20081106 11:48:05 and test if an #include is needed, whether it's really needed or just needed due to the fact that the included header pulls in other headers 20081106 11:48:48 There are actually some not completely trivial problems in logic anf graph theory there :-) 20081106 11:48:58 it would be a great tool to have and not only for wesnoth 20081106 11:49:12 I didn't say it would be an easy problem ;) 20081106 11:49:36 I don't do "easy" problems. Hrrmph. :-) :-) 20081106 11:49:48 good since it's not easy :) 20081106 11:49:57 But you 20081106 11:50:17 are right, that would be a good thing to put some attention on. 20081106 11:50:42 :) 20081106 11:51:04 I think some other projects would probably be also interested in the tool 20081106 11:53:55 Likely. 20081106 11:54:47 they need it, it's another step in Wesnoth world domintion ;) 20081106 11:57:42 -!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has joined #wesnoth-dev 20081106 11:57:42 * esr looks at his deheader prototype 20081106 11:57:59 -!- Elvish_Pillager [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20081106 12:02:03 :) 20081106 12:07:06 mordante: I forgoy how far I actually got with this. It's working. 20081106 12:07:24 nice 20081106 12:08:39 mordante: http://rafb.net/p/Asywqx74.html 20081106 12:11:25 esr I think you should blacklist the "global.hpp" test since it's MSVC specific 20081106 12:11:41 That's a really simple implementation. Where it gets complicated is when headers are conditionally included based on a complition symbol, as we do in (for example) filesystem.cpp. 20081106 12:12:23 You mean global.hpp is only used in Windows? 20081106 12:13:29 yes it's still needed for MSVC 9 but a lot of MSVC 6 cruft has been removed 20081106 12:14:30 did deheader also look at video.hpp? both video.cpp and video.hpp include events.hpp, which indeed is required 20081106 12:14:47 in video.hpp 20081106 12:15:11 Well, I implemented a switch to ignore headers with names matching a specified regexp. Let's test it. 20081106 12:16:33 It didn't look at video.hpp. It doesn't try to analyze header files yet. 20081106 12:16:48 The ignore switch works. 20081106 12:18:14 but it did already find one real positive :) 20081106 12:18:35 events.hpp? 20081106 12:18:59 yes which can be removed from video.cpp since it's required in video.hpp 20081106 12:19:49 Why don't you consider and friends positives? 20081106 12:19:51 btw I think cleaning up the headers should be the most important especially for headers which are included in other headers 20081106 12:20:37 since I can't review them here (can't compile at the moment) 20081106 12:21:01 but vector seems to be used, but probably pulled in by another header as well 20081106 12:47:21 -!- Elvish_Pillager [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has quit ["Hi! I'm a quit message virus vaccine. If you see a quit message virus, don't replace your quit message with it!"] 20081106 13:20:03 -!- onto [n=cplamper@p50878805.dip0.t-ipconnect.de] has joined #wesnoth-dev 20081106 13:31:13 -!- onto [n=cplamper@p50878805.dip0.t-ipconnect.de] has quit [] 20081106 14:51:25 -!- kthakore2 [n=kthakore@CPE001310a1899c-CM001868e2ad12.cpe.net.cable.rogers.com] has joined #wesnoth-dev 20081106 15:49:47 -!- BenUrban [n=benurban@c-68-49-10-243.hsd1.md.comcast.net] has joined #wesnoth-dev 20081106 16:11:43 -!- kthakore2 [n=kthakore@CPE001310a1899c-CM001868e2ad12.cpe.net.cable.rogers.com] has quit ["Leaving"] 20081106 16:28:52 -!- stikonas [n=and@ctv-213-164-99-167.vinita.lt] has joined #wesnoth-dev 20081106 16:58:12 -!- crimson_penguin [n=ben@64.201.60.220] has joined #wesnoth-dev 20081106 17:17:28 -!- crimson_pingvin [n=ben@64.201.60.220] has joined #wesnoth-dev 20081106 17:25:22 -!- crimson_penguin [n=ben@64.201.60.220] has quit [Read error: 110 (Connection timed out)] 20081106 17:39:08 -!- fendrin [n=fabi@g227024182.adsl.alicedsl.de] has joined #wesnoth-dev 20081106 17:47:03 -!- Rh0nda changed the topic of #wesnoth-dev to: 1.4.6 released, will announce soon | List 1.6 features here: http://www.wesnoth.org/wiki/Wesnoth1.6Features | 55 bugs, 210 feature requests, 9 patches | logs: http://wesnoth.org/irclogs | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com, or for images: http://imagebin.org/index.php?page=add 20081106 18:35:18 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has joined #wesnoth-dev 20081106 18:44:34 -!- grzywacz [n=grzywacz@moinmoin/developer/karol] has joined #wesnoth-dev 20081106 18:50:40 -!- crimson_pingvin is now known as crimson_penguin 20081106 18:53:55 -!- Psyche^ [n=Psyche@f054003102.adsl.alicedsl.de] has joined #wesnoth-dev 20081106 18:55:59 -!- Patterner [n=Psyche@e177230184.adsl.alicedsl.de] has quit [Read error: 60 (Operation timed out)] 20081106 18:56:00 -!- Psyche^ is now known as Patterner 20081106 19:00:10 -!- EdB [n=EdB@40.153.82-79.rev.gaoland.net] has joined #wesnoth-dev 20081106 19:03:55 -!- miq [n=miq@krlh-5d83a296.pool.einsundeins.de] has joined #wesnoth-dev 20081106 19:26:36 -!- noy [n=Noy@d75-157-43-119.bchsia.telus.net] has quit [] 20081106 20:18:04 -!- EdB [n=EdB@40.153.82-79.rev.gaoland.net] has quit ["Konversation terminated!"] 20081106 20:20:18 -!- Dragonking_ [n=dk@chello084010045237.chello.pl] has joined #wesnoth-dev 20081106 20:43:41 -!- Sapient [n=patrickp@agentek.com] has joined #wesnoth-dev 20081106 20:52:37 -!- Shadow_Master_ [n=shadowm@unaffiliated/shadowmaster/x-275924] has joined #wesnoth-dev 20081106 20:53:47 -!- Shadow_Master_ [n=shadowm@unaffiliated/shadowmaster/x-275924] has quit [Client Quit] 20081106 21:08:28 -!- Elvish_Pillager [n=eli@66-189-12-131.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20081106 21:19:23 -!- fendrin_ [n=fabi@e180231181.adsl.alicedsl.de] has joined #wesnoth-dev 20081106 21:34:03 -!- fendrin [n=fabi@g227024182.adsl.alicedsl.de] has quit [Read error: 110 (Connection timed out)] 20081106 21:42:54 I'm off bye 20081106 21:44:19 -!- mordante [n=chatzill@roadie.xs4all.nl] has quit ["ChatZilla 0.9.83 [Firefox 3.0.3/2008092417]"] 20081106 21:55:18 -!- CIA-43 [n=CIA@208.69.182.149] has quit [] 20081106 22:03:08 -!- Sapient [n=patrickp@agentek.com] has quit ["Leaving."] 20081106 22:38:43 -!- CIA-41 [n=CIA@208.69.182.149] has joined #wesnoth-dev 20081106 22:40:37 -!- zookeeper [n=l@dsl-tkubrasgw1-fe11fa00-51.dhcp.inet.fi] has quit [] 20081106 22:58:15 freim? ;-) 20081106 22:59:09 -!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has quit [Success] 20081106 23:13:25 -!- Dragonking_ [n=dk@chello084010045237.chello.pl] has quit [] 20081106 23:14:38 -!- miq [n=miq@krlh-5d83a296.pool.einsundeins.de] has quit [Remote closed the connection] 20081106 23:39:08 -!- Espreon [n=Espreon@c-76-117-239-33.hsd1.pa.comcast.net] has joined #wesnoth-dev 20081106 23:40:50 fendrin_: Are you here? 20081106 23:49:08 -!- grrrX [n=_@p57BBFFD4.dip.t-dialin.net] has joined #wesnoth-dev 20081106 23:49:48 esr: Which rules did I break? 20081106 23:50:09 ... 20081106 23:51:34 You put a #define with no tag where it needed and #enddef. This blew up wmllint and broke the campaign. In future, you should test your changes with wmllint and wmlscope before committing; this will save you from much embarassment. 20081106 23:51:49 s/and #enddef/an #enddef/ 20081106 23:52:48 esr: I was not embarrassed though... Hmmm... this is another reason I should start proofreading... 20081106 23:53:19 * Espreon unfortunately does not proofread anything... which is bad. 20081106 23:54:12 Espreon: OK, it will save you from other devs wanting to hit you with a tire-iron. 20081106 23:54:36 Nah... I am sure they would wanna do more than that. 20081106 23:54:42 * Espreon looks at Shadow_Master. 20081106 23:55:15 esr: Oh my... that was a silly mistake... 20081106 23:56:03 * Espreon now feels a bit embarrassed. 20081106 23:57:59 As you should. 20081106 23:59:14 I do stuff like that occasionally, but because I wmllint my changes, it never gets into the repo and nobody else has to clean up after it. Take a lesson from this. --- Log closed Fri Nov 07 00:00:19 2008