--- Log opened Wed Feb 25 00:00:03 2009
--- Day changed Wed Feb 25 2009
20090225 00:00:03< Shadow_Master> sure. When I feel like doing another release due to such a tiny thing.
20090225 00:00:12-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Read error: 110 (Connection timed out)]
20090225 00:00:12< Shadow_Master> I'll let players have the doubt of not knowing the Epilogue for now.
20090225 00:00:41< CIA-70> soliton * r33091 /trunk/src/campaign_server/campaign_server.cpp: remove obsolete parameter
20090225 00:01:04< ilor_> Sirp: network_worker.cpp:307 gets hit before the error
20090225 00:01:44< Noyga> n8
20090225 00:01:47-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"]
20090225 00:02:19< Sirp> ilor_: IIRC on my system it uses poll rather than select, and I don't think I tested select very much
20090225 00:02:36< ilor_> Sirp: if I break at line 285 and step to the next two lines, it works
20090225 00:05:08< ilor_> in fact any breakpoint a bit before the select() call makes it work
20090225 00:06:14-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)]
20090225 00:08:09-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 00:09:36-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 110 (Connection timed out)]
20090225 00:10:24< ilor_> Sirp: I'm off now, hope you can find whatever's causing the problem
20090225 00:10:29< ilor_> see you all
20090225 00:10:38< Sirp> ilor_: okay......bye for now
20090225 00:10:56-!- ilor_ [n=user@wesnoth/developer/ilor] has quit []
20090225 00:15:41< Shadow_Master> sudo apt-get install apache2-doc
20090225 00:16:17< Shadow_Master> grar.
20090225 00:18:02< grzywacz> That period is the saving grace of your password.
20090225 00:18:06< grzywacz> :p
20090225 00:18:11< YogiHH> night everyone
20090225 00:18:22< grzywacz> n8 YogiHH 
20090225 00:18:34-!- YogiHH [i=YogiHH@wesnoth/developer/yogihh] has quit ["Bye folks"]
20090225 00:21:12-!- shikadibot [n=sh314001@wesnoth/bot/shikadibot] has joined #wesnoth-dev
20090225 00:21:21-!- shikadibot [n=sh314001@wesnoth/bot/shikadibot] has quit [Client Quit]
20090225 00:23:17-!- not_CIA [n=CIA@190.22.66.0] has joined #wesnoth-dev
20090225 00:23:28-!- not_CIA [n=CIA@190.22.66.0] has quit [Client Quit]
20090225 00:24:25-!- shikadibot [n=uid1001@wesnoth/bot/shikadibot] has joined #wesnoth-dev
20090225 00:25:18-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090225 00:25:21-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 00:30:15-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection]
20090225 00:48:19-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Client Quit]
20090225 00:49:02-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection]
20090225 00:51:18< Shadow_Master> n8
20090225 00:51:21-!- Shadow_Master [n=imorelle@wesnoth/developer/shadowmaster] has quit ["There's a bug in my soup."]
20090225 00:51:46-!- BenUrban [n=benurban@c-68-49-10-243.hsd1.md.comcast.net] has joined #wesnoth-dev
20090225 00:54:19< Turuk_> hmm
20090225 00:54:28-!- shikadibot [n=uid1001@wesnoth/bot/shikadibot] has quit [Read error: 60 (Operation timed out)]
20090225 00:56:17< Turuk_> Sapient, busy?
20090225 00:56:25< Turuk_> not even here bah
20090225 00:59:36< Soliton> details.
20090225 01:01:25-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit [Remote closed the connection]
20090225 01:10:35-!- JW1 [n=X@dhcp66-158-5-10.kentlaw.edu] has joined #wesnoth-dev
20090225 01:12:18-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20090225 01:15:39-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090225 01:16:46-!- Sapient [n=sapien-x@c-24-126-133-155.hsd1.ga.comcast.net] has joined #wesnoth-dev
20090225 01:16:49-!- Elvish_Pillager [n=eli@66-189-40-122.dhcp.oxfr.ma.charter.com] has quit ["Hi! I'm a quit message virus vaccine. If you see a quit message virus, don't replace your quit message with it!"]
20090225 01:16:57< Sapient> Turuk_: thou hast summoned me?
20090225 01:17:11< Turuk_> :O 
20090225 01:17:12< Turuk_> creepy
20090225 01:17:18< Turuk_> Ah, just a few notes for your post
20090225 01:17:31< Sapient> p.m. pls
20090225 01:17:33< Turuk_> But I just posted them as you were *gasp* doing something RL
20090225 01:17:39< Sapient> oh ok
20090225 01:17:40< Turuk_> Well, I figured you could read and delete
20090225 01:23:40-!- Turuk_ is now known as Turuk
20090225 01:35:59< Soliton> looks like windows users are screwed this release: http://www.wesnoth.org/forum/viewtopic.php?p=342006#p342006
20090225 01:37:36< happygrue> hmm, maybe it has something to do with the shortcut flag on the windows package.
20090225 01:38:05< Soliton> no, see discussion above.
20090225 01:38:37< happygrue> ah
20090225 01:38:49< happygrue> I had not put 2 and 2 together
20090225 01:39:12< Soliton> it seemed to only effect addon downloads but nobody tested mp much yet probably.
20090225 01:39:35< Sapient> well, that sucks :(
20090225 01:39:47< happygrue> I guess special emphasis on the BETA for this release ;)
20090225 01:41:19< Soliton> we should probably just advise windows users to stay with 1.5.10.
20090225 01:41:46< Soliton> they're basically compatible anyway.
20090225 01:42:13< Soliton> or get loonycyborg to build another windows version with that one commit reverted.
20090225 01:46:37< Soliton> Sapient: nice moderator tips, btw.
20090225 01:47:06-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 01:47:12< happygrue> Sapient: yes, that will be helpful for new mods.
20090225 01:47:34-!- JW1 [n=X@dhcp66-158-5-10.kentlaw.edu] has quit []
20090225 01:47:41-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 01:48:08< Sapient> thanks
20090225 01:50:30-!- Turuk is now known as TURUK_THE_MACRO_
20090225 01:51:14-!- TURUK_THE_MACRO_ is now known as Turuk
20090225 01:52:38< Sapient> cya later, have fun.
20090225 01:52:38-!- Sapient [n=sapien-x@wesnoth/developer/sapient] has left #wesnoth-dev []
20090225 01:59:35-!- ikarius [n=ross@smtp.gridironsystems.com] has quit []
20090225 01:59:44-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["night all"]
20090225 02:27:09-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit [Remote closed the connection]
20090225 02:44:20-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 02:46:03< CIA-70> soliton * r33092 /trunk/src/ (9 files in 2 dirs): give server moderators the option to observe any game (server still needs to allow it)
20090225 02:55:47< happygrue> Soliton: nice.  What does "server still needs to allow it" mean?
20090225 02:56:52< Soliton> means the server currently doesn't allow anyone to observe unobservable games..
20090225 02:57:03< happygrue> ah
20090225 02:57:30-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 02:57:49< happygrue> so this is part 1 of 2 then...?  I hope?
20090225 03:03:10-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 03:06:46-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Excess Flood]
20090225 03:07:35-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev
20090225 03:13:33-!- AndreLuiz is now known as AndreLuiz_
20090225 03:14:46< Soliton> if you try to quit a replay mid-attack the attacked unit disappears instead.
20090225 03:15:57-!- ikarius [n=ross@216.27.182.3] has joined #wesnoth-dev
20090225 03:18:23-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 03:32:07-!- Sirp_ [n=me@c-71-198-3-104.hsd1.ca.comcast.net] has joined #wesnoth-dev
20090225 03:37:20-!- Acht [n=chatzill@dialup-4.225.110.141.Dial1.Cincinnati1.Level3.net] has quit ["au demain"]
20090225 04:06:55-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 04:21:53-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 04:25:54-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit [Client Quit]
20090225 04:28:32< Turuk> So quiet and peaceful
20090225 04:28:41-!- Dragonking [n=dk@wesnoth/developer/dragonking] has quit []
20090225 04:28:43-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 04:29:42< CIA-70> soliton * r33093 /trunk/src/server/game.cpp: simplify and correct is_on_team()
20090225 04:32:53-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit [Client Quit]
20090225 04:33:36< Soliton> i guess i will also allow mods to join games they're banned in.
20090225 04:34:01< Soliton> not sure if i should protect them from being kicked.
20090225 04:42:18-!- Ivanovic_ [n=ivanovic@dtmd-4db2a3d7.pool.einsundeins.de] has joined #wesnoth-dev
20090225 04:48:48< happygrue> Soliton: the only situation that I can imagine where we would care about that would be if a host is being quite abusive, and the other players want some kind of in-game moderation... but I am not sure if we care about that?
20090225 04:50:26< happygrue> if host and all players are happy in the game (with an allowed title) then it seems we don't need to do anything there.
20090225 04:51:21< Soliton> and if the host is being unreasonable you can just kick him.
20090225 04:53:44 * happygrue nods
20090225 04:59:38-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)]
20090225 05:01:24-!- Ivanovic_ is now known as Ivanovic
20090225 05:08:00< CIA-70> soliton * r33094 /trunk/src/server/ (game.cpp game.hpp server.cpp): allow server moderators to always join a game
20090225 05:11:25< happygrue> :)
20090225 05:29:14-!- happygrue [n=Wintermu@wesnoth/developer/wintermute] has quit ["grok 'noth!"]
20090225 06:05:24-!- Ivanovic [n=ivanovic@dtmd-4db2a3d7.pool.einsundeins.de] has quit [Read error: 104 (Connection reset by peer)]
20090225 06:05:34-!- Ivanovic [n=ivanovic@dtmd-4db2a3d7.pool.einsundeins.de] has joined #wesnoth-dev
20090225 06:13:06-!- Turuk_ [n=Turuk@FUSE-WS1-208-102-202-188.fuse.net] has joined #wesnoth-dev
20090225 06:20:35-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out]
20090225 06:20:53-!- [Relic] [n=[Relic]@adsl-76-229-202-137.dsl.milwwi.sbcglobal.net] has quit ["Leaving"]
20090225 06:33:58-!- Turuk_ is now known as Turuk
20090225 07:00:09-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit ["Leaving"]
20090225 07:25:56< CIA-70> soliton * r33095 /trunk/src/server/ (ban.cpp ban.hpp): make ban matching with masks work again... i hope
20090225 08:10:34-!- silene [n=plouf@ASte-Genev-Bois-152-1-84-160.w86-218.abo.wanadoo.fr] has joined #wesnoth-dev
20090225 08:23:51-!- noy [n=Noy@wesnoth/developer/noy] has quit ["GO, GET TO THE CHOPPAH!!!"]
20090225 08:44:11-!- ilor [n=user@atx173.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20090225 09:16:10-!- silene1 [n=plouf@ASte-Genev-Bois-152-1-100-143.w86-203.abo.wanadoo.fr] has joined #wesnoth-dev
20090225 09:16:35-!- Sirp_ [n=me@c-71-198-3-104.hsd1.ca.comcast.net] has quit ["leaving"]
20090225 09:16:45-!- silene [n=plouf@wesnoth/developer/silene] has quit [Read error: 110 (Connection timed out)]
20090225 09:30:15-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090225 09:32:58-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Remote closed the connection]
20090225 09:33:28-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20090225 09:35:50-!- Dragonking [n=dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20090225 09:50:26-!- silene1 [n=plouf@ASte-Genev-Bois-152-1-100-143.w86-203.abo.wanadoo.fr] has quit ["Leaving."]
20090225 10:06:42-!- loonybot [n=loonybot@79.139.247.150] has joined #wesnoth-dev
20090225 10:07:17-!- loonycyborg [n=sergey@79.139.247.150] has joined #wesnoth-dev
20090225 10:21:16< loonycyborg> Soliton: What commit causes windows networking problems? I think they warrant a rerelease.
20090225 10:25:11< ilor> loonycyborg: look at the log around last midnight
20090225 10:25:35< ilor> I'm off for classes, bye
20090225 10:25:50-!- ilor [n=user@atx173.neoplus.adsl.tpnet.pl] has quit []
20090225 10:28:29< loonycyborg> wesbot: log r32989
20090225 10:28:31< wesbot> dave * r32989 : attempt to fix crash bug when cancelling a download
20090225 10:28:31< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=32989
20090225 10:52:08< Rhonda> Sirp, Ivanovic: Shall I just answer to them directly, Ccing you? Shall I use @w.o as mail address? ;)
20090225 10:55:36-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20090225 11:02:00-!- Ivanovic_ontour [n=nils@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20090225 11:15:47-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090225 11:16:19-!- isaac_ [n=isaac@173.Red-79-154-223.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20090225 11:31:46-!- isaac [n=isaac@debian/developer/isaac] has quit [Read error: 110 (Connection timed out)]
20090225 12:15:48-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["KVIrc 3.4.2 Shiny http://www.kvirc.net/"]
20090225 12:16:21-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection]
20090225 12:33:10-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Remote closed the connection]
20090225 12:33:52-!- Ivanovic [n=ivanovic@dtmd-4db2a3d7.pool.einsundeins.de] has joined #wesnoth-dev
20090225 13:00:24-!- isaac_ is now known as isaac
20090225 13:21:51-!- loonybot [n=loonybot@79.139.247.150] has joined #wesnoth-dev
20090225 13:22:24-!- loonycyborg [n=sergey@79.139.247.150] has joined #wesnoth-dev
20090225 13:27:55< esr> The build is broken!  With freshly updated trunk, compilation fails in src/gui/dialogs/mp_cmd_wrapper.cpp, failing omn some unknown structure of class member 'authenticated'.
20090225 13:30:32-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Read error: 104 (Connection reset by peer)]
20090225 13:33:02< loonycyborg> Works for me with r33088.
20090225 13:33:53< loonycyborg> Though don't expect me to update until upload is finished.
20090225 13:34:21< loonycyborg> Since it makes everything else time out.
20090225 13:36:17< Soliton> i wonder why it compiled for me.
20090225 13:37:25< loonycyborg> *times out
20090225 13:39:45< loonycyborg> esr: What compiler version?
20090225 13:40:21< CIA-70> soliton * r33096 /trunk/src/gui/dialogs/mp_cmd_wrapper.cpp: forgot to update one file in r33092
20090225 13:40:22< Soliton> esr: should be fixed now.
20090225 13:43:42< esr> Fix confirmed.
20090225 13:45:28 * loonycyborg really likes git add -u
20090225 13:50:35-!- jorda [n=jorda@75.207.219.87.dynamic.jazztel.es] has joined #wesnoth-dev
20090225 13:51:19-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20090225 13:54:07-!- Ivanovic_ontour [n=nils@wesnoth/developer/ivanovic] has quit [Remote closed the connection]
20090225 14:03:05-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)]
20090225 14:06:13-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit ["Battle for Wesnoth: http://www.wesnoth.org/"]
20090225 14:06:51-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20090225 14:09:07-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Client Quit]
20090225 14:09:43-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20090225 14:12:08-!- Sapient [n=patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev
20090225 14:18:38-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)]
20090225 14:18:53-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090225 14:37:15< CIA-70> soliton * r33097 /trunk/src/server/ban.cpp: in case the internet goes mad...
20090225 14:43:34-!- thespaceinvader [n=chatzill@91.108.177.73] has joined #wesnoth-dev
20090225 14:46:59-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"]
20090225 15:29:44< Ivanovic> hiho
20090225 15:34:07< Sapient> moin moin
20090225 15:40:52< loonycyborg> Ivanovic: I've uploaded another installer to sf(with network breaking commit reverted)
20090225 15:49:37< Ivanovic> loonycyborg: okay, will update the frontpage, have you already posted in the forums about this?
20090225 15:51:47< loonycyborg> I first want to download it and test under wine.
20090225 15:52:22< loonycyborg> And its download speed is *very* slow now.
20090225 15:55:00 * Ivanovic recommends mesh solutions as rather fast mirror...
20090225 15:55:01< Ivanovic> ;)
20090225 15:58:39-!- Jarek102 [n=Jarek102@195.68.232.250] has joined #wesnoth-dev
20090225 16:03:50< CIA-70> ivanovic * r33098 /trunk/ (12 files in 11 dirs): updated Polish translation
20090225 16:12:58-!- Ivanovic_ontour [n=nils@dtmd-4db2a3d7.pool.einsundeins.de] has joined #wesnoth-dev
20090225 16:13:05-!- Ivanovic_ontour [n=nils@wesnoth/developer/ivanovic] has quit [Remote closed the connection]
20090225 16:35:29-!- AI0867__ [n=ai@83.149.71.245] has joined #wesnoth-dev
20090225 16:36:40< Ivanovic> loonycyborg: so are your tests done?
20090225 16:36:44< Ivanovic> can i update the frontpage?
20090225 16:42:03< loonycyborg> No. When I say that the download is *really* slow, I mean that :P
20090225 16:42:56< loonycyborg> What's the point in updating the from page when users aren't yet likely to download it in reasonable time?
20090225 16:44:33< Rhonda> network breaking commit? Where what how?
20090225 16:44:42< Ivanovic> Rhonda: windows only
20090225 16:44:57< Ivanovic> that commit fixed a crash for all other versions
20090225 16:45:06< Ivanovic> on windows it results in the addon server not working anymore...
20090225 16:45:08< Rhonda> Ah.
20090225 16:45:47< Rhonda> I've just started to upload the first third of my work to Debian servers and almost thought it was wasted time ...  %-/
20090225 16:47:17< AI0867> yogiHH: I ran the two python AIs against eachother on the official mp server
20090225 16:47:23< Ivanovic> without the http part almost nobody understands the link anyway, so better have it in the topic (and drop by now useless stuff instead)
20090225 16:47:39< AI0867> I will test it with C++ AIs when I get home
20090225 16:47:58< Ivanovic> zookeeper: you have seen https://gna.org/bugs/index.php?13057 ?
20090225 16:48:09< Ivanovic> some utbs bug, no idea if you really are responsible for it...
20090225 16:58:05-!- crimson_penguin [n=ben@64.201.60.220] has joined #wesnoth-dev
20090225 17:06:24-!- jorda is now known as ettin
20090225 17:09:07-!- Tigge [n=tigge@bacchus.olf.sgsnet.se] has quit [Read error: 104 (Connection reset by peer)]
20090225 17:11:31-!- Sapient [n=patrickp@wesnoth/developer/sapient] has left #wesnoth-dev []
20090225 17:13:57-!- Tigge [n=tigge@bacchus.olf.sgsnet.se] has joined #wesnoth-dev
20090225 17:22:21< zookeeper> Ivanovic, i have, am not, but i might still take a look at it
20090225 17:23:41< Ivanovic> okay
20090225 17:50:33-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Read error: 110 (Connection timed out)]
20090225 17:53:01-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090225 18:01:31-!- ikarius [n=ross@216.27.182.3] has quit []
20090225 18:15:04-!- stikonas [n=and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090225 18:17:51-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 54 (Connection reset by peer)]
20090225 18:19:30-!- Turuk_ [n=Turuk@FUSE-WS1-208-102-202-188.fuse.net] has joined #wesnoth-dev
20090225 18:26:08-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)]
20090225 18:35:56-!- Baufo [n=thomas@62-47-147-18.adsl.highway.telekom.at] has joined #wesnoth-dev
20090225 18:39:34-!- cjhopman [n=chris@wireless299.cs.wisc.edu] has joined #wesnoth-dev
20090225 18:39:36-!- ikarius [n=ross@smtp.gridironsystems.com] has joined #wesnoth-dev
20090225 18:51:04-!- elias [n=elias@allegro/developer/allefant] has joined #wesnoth-dev
20090225 18:55:51-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev
20090225 19:00:30-!- happygrue [n=George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20090225 19:06:53-!- elias__ [n=elias@80-121-75-182.adsl.highway.telekom.at] has joined #wesnoth-dev
20090225 19:08:15-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090225 19:08:50-!- elias [n=elias@allegro/developer/allefant] has quit [Nick collision from services.]
20090225 19:08:53-!- elias__ is now known as elias
20090225 19:09:47-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Read error: 110 (Connection timed out)]
20090225 19:12:08-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20090225 19:31:26-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20090225 19:31:50< grzywacz> evening
20090225 19:34:07-!- noy [n=Noy@d75-157-52-251.bchsia.telus.net] has joined #wesnoth-dev
20090225 19:34:09-!- EdB [n=EdB@110.12.95-79.rev.gaoland.net] has joined #wesnoth-dev
20090225 19:41:59-!- Jarek102 [n=Jarek102@195.68.232.250] has left #wesnoth-dev ["Leaving"]
20090225 19:48:54-!- VladimirSlavik [n=chatzill@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20090225 19:51:38< loonycyborg> Ivanovic: It's downloaded at last, and downloading addons work even under wine :P
20090225 19:53:33-!- alink [n=alink@78.129.18.215] has joined #wesnoth-dev
20090225 19:53:53< alink> hi
20090225 20:07:41-!- happygrue [n=George@wesnoth/developer/wintermute] has quit ["grok 'noth!"]
20090225 20:09:00-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090225 20:12:12-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Remote closed the connection]
20090225 20:13:07-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20090225 20:15:37-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Client Quit]
20090225 20:16:22-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20090225 20:17:16-!- boucman [n=rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20090225 20:17:45-!- malumalu [n=malu@hnvr-4dbbf1c8.pool.einsundeins.de] has joined #wesnoth-dev
20090225 20:25:10-!- EdB [n=EdB@110.12.95-79.rev.gaoland.net] has quit ["Konversation terminated!"]
20090225 20:26:32-!- elias [n=elias@allegro/developer/allefant] has quit ["Leaving"]
20090225 20:30:43< zookeeper> esr, err, "This feels passing strange!" in LoW doesn't strike me as obviously correct english...
20090225 20:32:12< thespaceinvader> zookeeper: it's an archaic phraseology, but it is correct i think
20090225 20:32:45< zookeeper> right, ok
20090225 20:36:41-!- Turuk_ [n=Turuk@FUSE-WS1-208-102-202-188.fuse.net] has quit [Read error: 60 (Operation timed out)]
20090225 20:41:29-!- Dragonking [n=dk@wesnoth/developer/dragonking] has quit []
20090225 20:41:36-!- Dragonking [n=dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20090225 20:44:07-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090225 20:56:19-!- Gallifax [n=Gallifax@pD9EA5512.dip.t-dialin.net] has joined #wesnoth-dev
20090225 21:04:37-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20090225 21:05:11< silene> hi
20090225 21:05:38-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090225 21:08:50-!- nital_away is now known as nital
20090225 21:10:34< Ivanovic> loonycyborg: so the frontpage should now be altered to display the new version?
20090225 21:10:44< Ivanovic> including an 'update' entry to the news or without?
20090225 21:10:45< loonycyborg> Yes.
20090225 21:11:53< Ivanovic> loonycyborg: you have pinged Sirp already to tell him that his fix broke addon downloads for windows users?
20090225 21:12:09< loonycyborg> He already knows according to logs.
20090225 21:12:24< Ivanovic> okay, was not sure about this
20090225 21:14:29< Ivanovic> loonycyborg: uhm, it is correct that the binary got ~700kb smaller?
20090225 21:14:34< Ivanovic> what have you stripped out?
20090225 21:15:17< loonycyborg> Nothing.
20090225 21:16:10< Ivanovic> that really is interesting
20090225 21:16:21< Ivanovic> but since yu downloaded the file to check it should be fine
20090225 21:18:41-!- malumalu_ [n=malu@hnvr-4dbbf1c8.pool.einsundeins.de] has joined #wesnoth-dev
20090225 21:19:58< Ivanovic> loonycyborg: okay, updated the frontpage as well as the downloads page
20090225 21:20:01< esr> zookeeper: "This feels passing strange!" - It's true, "passing" is no longer used this way as an adjectival intensifier in modern English.  But "passing strange" was common in Shakespeare and still in live use as late as the ealy 19th century.
20090225 21:20:08< Ivanovic> you should maybe add a comment in the release announcement thread about this, too
20090225 21:21:34< esr> zookeeper: Might be it's a touch too archaic for the house style I've been developing, which is based on Edwardian fantasy from c. 1900.  But I'm not going to mess with it during a string freeze,
20090225 21:22:32-!- alink [n=alink@78.129.18.215] has quit [Remote closed the connection]
20090225 21:22:35< Ivanovic> esr: good choice!!!
20090225 21:22:54< esr> Ivanovic: Huh?  Good choice of what?
20090225 21:23:25< boucman> knowing Ivanovic, he's thinking of the "don't mess with the freeze" part
20090225 21:23:29< Ivanovic> "But I'm not going to mess with it during a string freeze,"
20090225 21:23:33< boucman> :)
20090225 21:23:37< esr> Ah.  Probably.
20090225 21:24:29-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Read error: 60 (Operation timed out)]
20090225 21:27:41-!- stikonas [n=and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090225 21:32:00-!- malumalu [n=malu@hnvr-4dbbf1c8.pool.einsundeins.de] has quit [Read error: 110 (Connection timed out)]
20090225 21:38:19-!- Elvish_Pillager [n=eli@66-189-40-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090225 21:44:18-!- VladimirSlavik [n=chatzill@wesnoth/translator/VladimirSlavik] has left #wesnoth-dev []
20090225 22:12:51-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090225 22:15:40-!- Dragonking [n=dk@wesnoth/developer/dragonking] has quit [Read error: 110 (Connection timed out)]
20090225 22:19:24-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Remote closed the connection]
20090225 22:22:35-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090225 22:25:58-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"]
20090225 22:26:56-!- ilor [n=user@atx173.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20090225 22:27:53-!- malumalu_ [n=malu@hnvr-4dbbf1c8.pool.einsundeins.de] has quit ["Verlassend"]
20090225 22:34:06< Rhonda> Sirp, Ivanovic: I take it that my response to the mail was good enough for you?
20090225 22:34:22< Ivanovic> sure
20090225 22:34:30< Sirp> Rhonda: yes, though I didn't know you were going to send it, so I had already sent a response of my own.
20090225 22:34:39< Sirp> but I don't think we contradicted each other, so that is good. :)
20090225 22:35:36< Rhonda> heh
20090225 22:37:16< Ivanovic> Sirp: just to make 100% sure: you know that your fixes for aborting addon downloads (which worked really well on my box ;) ) broke downloading addons on windows, right?
20090225 22:38:10< Sirp> Ivanovic: yes.
20090225 22:38:14< Ivanovic> zookeeper: can you handle this one, too? https://gna.org/bugs/index.php?13068
20090225 22:38:20< Sirp> Ivanovic: was there sometime by which you'd like this fixed?
20090225 22:38:32< Sirp> Ivanovic: ideally someone on Windows can look at fixing it....because it's going to be really hard for me...
20090225 22:38:44< Ivanovic> Sirp: i prefer "soon" since atm the bug with addon downloads is open again, right?
20090225 22:38:45-!- jorda [n=jorda@168.207.219.87.dynamic.jazztel.es] has joined #wesnoth-dev
20090225 22:38:58< Ivanovic> the fix for windows so far was "revert the commit"
20090225 22:39:06< Sirp> Ivanovic: okay.....
20090225 22:39:40< Ivanovic> (with other words: not too nice...)
20090225 22:39:58< Sirp> well, I don't have access to a Windows box, so testing and resolving this......will be problematic
20090225 22:40:10-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)]
20090225 22:40:19< Ivanovic> Sirp: maybe loonycyborg can help you?
20090225 22:40:24< loonycyborg> Sirp: I guess ilor will have to do that :)
20090225 22:40:31< Sirp> okay.... :)
20090225 22:40:35< Sirp> I can beg ilor for help.....
20090225 22:40:46< Sirp> ilor: around?
20090225 22:40:51< Ivanovic> loonycyborg: was the commit reverted in trunk, or is it still in and windows users got to "hand convert"?
20090225 22:40:52< ilor> Sirp: yeah
20090225 22:41:03< Ivanovic> ilor: this one is for you: https://gna.org/bugs/index.php?13059
20090225 22:41:03 * loonycyborg isn't very good at network stuff.
20090225 22:41:12< ilor> Sirp: it would be easier if I actually knew how select worked
20090225 22:41:22-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 60 (Operation timed out)]
20090225 22:41:26-!- YogiHH [i=YogiHH@c225200.adsl.hansenet.de] has joined #wesnoth-dev
20090225 22:41:27< loonycyborg> Ivanovic: It wasn't reverted AFAICT.
20090225 22:41:39< Ivanovic> that is: rev32989 caused the problem (windows only)
20090225 22:41:40< loonycyborg> ilor: Or was it?
20090225 22:41:58< Ivanovic> loonycyborg: i am not sure, so i prefer asking
20090225 22:42:00< Ivanovic> ;)
20090225 22:42:00< Sirp> ilor: sure, do you want me to explain to you?
20090225 22:42:21< ilor> Sirp: if you have the time it'd be great
20090225 22:43:18< Sirp> ilor: okay, so basically select() is a call which you give a bunch of sockets to, and a timeout, and it will "sleep" until either (1) one or more sockets is ready for reading/writing; or (2) the timeout expires.
20090225 22:43:36< Sirp> in our case, we actually just give select the one socket that we're interested in reading data from
20090225 22:43:45< ilor> ok, a blocking call
20090225 22:44:16< Sirp> ilor: right. select() is the main way to implement a server in Unix. You get all your sockets and call select() on them, and then you'll return when one of them is sending you data and you can handle that....
20090225 22:44:16< ilor> it's a separate network thread in wesnoth doing that?
20090225 22:44:34-!- Dragonking [n=dk@chello084010009007.chello.pl] has joined #wesnoth-dev
20090225 22:44:39< Sirp> ilor: yes. In our case we are receiving data from the add on server, so this seperate network thread is receiving data....
20090225 22:44:41-!- stikonas [n=stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090225 22:44:53< Sirp> before it would wait up to 60 seconds in select() and after that, timeout
20090225 22:45:09< Sirp> ilor: the problem was, if the person presses cancel, we actually want it to stop the thread immediately and close the connection.
20090225 22:45:41< Sirp> the problem is our select() call had a 60 second timeout, after which it'd say "ohhhh my connection was cancelled"...meaning Wesnoth could hang for up to 60 seconds when you pressed cancel
20090225 22:46:07< ilor> ok I'm with you so far
20090225 22:46:13< Sirp> ilor: so the idea of my change was to make it so we'd set the timeout from select to only 100ms, and so it'd sleep for 100ms, then wake up, and then check to see if it's been cancelled
20090225 22:46:33< ilor> and cancelled is a flag the cancel button sets?
20090225 22:46:39< ilor> ok I get it
20090225 22:46:44< Sirp> but if there is no data, and it hasn't been cancelled, it'd just go back into another call to select(), looping like this, 100ms at a time, until a total of 60 seconds goes by
20090225 22:47:13< Sirp> ilor: so that is the change I made. Why it doesn't work on Windows, I don't know. My testing was mostly with poll() though rather than select() and then I did a mostly-copy-and-paste into the select() code
20090225 22:47:40-!- Gallifax [n=Gallifax@pD9EA5512.dip.t-dialin.net] has quit ["We be chillin - IceChat style"]
20090225 22:47:57< Sirp> ilor: if you have the time/compulsion/interest/masochism to look into it and try to put print statements and work out why it's not working, tha'td be great...otherwise I'll try to enable select() on my Linux compile and see if I can repro and fix...tonight.
20090225 22:48:32< ilor> Sirp I'm trying it in a debugger.. seems fishy
20090225 22:49:46< Sirp> ilor: okay. Remember with a debugger it might act weird...
20090225 22:49:52< ilor> it does.
20090225 22:50:17-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 22:52:47< Sirp> printf-style debugging might work better...
20090225 22:54:10< ilor> yeah. you spend time learning gdb or what not but at some point it's still good ol' printf
20090225 22:55:27< silene> what's the issue?
20090225 22:57:16-!- Baufo [n=thomas@wesnoth/developer/baufo] has quit ["Leaving"]
20090225 22:57:48< Sirp> silene: some network code having trouble on Windows.
20090225 22:58:16< ilor> Sirp: it looks like the second select() errors out (returns -1)
20090225 22:58:49< Sirp> ilor: ahhhh, okay.
20090225 22:59:27< ilor> Sirp: I'm going through the docs to see if there's a way to get more info about the erorr
20090225 22:59:38< Sirp> ilor: look at errno
20090225 22:59:38< silene> errno
20090225 22:59:40< Sirp> it should have information
20090225 22:59:46< ilor> msdn says WSAGetLastError
20090225 22:59:49-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit []
20090225 22:59:57< ilor> it's windows, remember, it's "special"
20090225 23:00:37< loonycyborg> select is not windows-specific, so strerror(errno) os more likely to work.
20090225 23:00:48< loonycyborg> s/os/is
20090225 23:01:13< ilor> WSAEINVAL 10022 Invalid argument.
20090225 23:01:14< ilor> Some invalid argument was supplied (for example, specifying an invalid level to the setsockopt function). In some instances, it also refers to the current state of the socket—for instance, calling accept on a socket that is not listening.
20090225 23:01:22< ilor> that's the one, anyway
20090225 23:01:40< Sirp> ilor: so what did it return the first time select() was called?
20090225 23:01:41< silene> is it the code in netwok_worker.cpp? isn't just wrong because you assume the timeout structure is left unchanged?
20090225 23:01:44< ilor> Sirp: 0
20090225 23:01:59< zookeeper> Ivanovic, maybe
20090225 23:02:18-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
20090225 23:02:37< Sirp> ilor: okay.
20090225 23:02:54-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has quit [Client Quit]
20090225 23:02:56< Sirp> ilor: I guess you could try moving the building of readfds inside the do...while, to directly above the select(), rebuilding it each time
20090225 23:03:48< Sirp> ilor: ohhh actually I just noticed that select() may update tv to note how much time was left
20090225 23:03:51< Sirp> so maybe it's update it to 0
20090225 23:03:57< silene> in particular, please move the timeval settings, the system is allowed to modify it to pass information back to the prgoram
20090225 23:04:12< Sirp> ilor: so try moving the initialization of tv to right above the select.
20090225 23:04:15< Sirp> yes, what silene said. :)
20090225 23:04:35< ilor> msdn: When select returns, the contents of the TIMEVAL structure are not altered
20090225 23:04:53< silene> ilor: including in case of error?
20090225 23:05:20< ilor> I printed the contents and they are the same at the second call
20090225 23:06:14< Sirp> readfds is modified on Linux though
20090225 23:06:21< Sirp> so maybe it's modified on Windows too?
20090225 23:06:31< Sirp> so can you re-initialize readfds too?
20090225 23:06:32< ilor> trying resetting readfs each time now
20090225 23:06:37< Sirp> okay
20090225 23:07:03< ilor> gotcha
20090225 23:07:26< ilor> Sirp, silene: that was it, resetting readfs
20090225 23:07:30< silene> msdn says "Don't forget to reset the fd_set:s between select calls. Otherwise select() will return SOCKET_ERROR and raise WSAEINVAL through WSAGetLastError()."
20090225 23:07:34< Sirp> ilor: okay cool, thank you.
20090225 23:07:59< Sirp> ilor: can you commit that? Also please do move the timeval init directly above the select() because some platforms may modify timeval
20090225 23:08:17< ilor> silene: ahh, in the communiy content on the very bottom of the page where I didn't look :D
20090225 23:09:16< silene> yes, that's quite strage the documentation itself does not mention it
20090225 23:14:29< CIA-70> ilor * r33099 /trunk/src/network_worker.cpp: fix add-on networking issue in windows (and possibly other platforms using select) (bug #13059)
20090225 23:14:55< ilor> Sirp, Ivanovic: ^
20090225 23:15:06< Sirp> ilor: thanks for your help. :)
20090225 23:15:18< ilor> Sirp: thanks for your expertise :)
20090225 23:15:24< ilor> silene: thanks too
20090225 23:15:26< Ivanovic> great
20090225 23:15:36< Sirp> ilor: if it was "expertise" I don't think I'd have messed it up in the first place. :)
20090225 23:15:58< ilor> zookeeper: BTW, errno didn't work (it was "no error") ;)
20090225 23:16:01< silene> Ivanovic: is there no 1.5.11 tag or is my repository borked?
20090225 23:16:24< ilor> argh it was loonycyborg
20090225 23:16:31< Ivanovic> http://svn.gna.org/viewcvs/wesnoth?rev=33066&view=rev
20090225 23:16:33< ilor> I hate it when I confuse people
20090225 23:16:39< Ivanovic> there *is* a tag
20090225 23:16:40< Ivanovic> ;)
20090225 23:17:07< silene> great! (and not so great it doesn't appear here)
20090225 23:17:16-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090225 23:17:25< loonycyborg> silene: Are you using git-svn?
20090225 23:17:30-!- YogiHH [i=YogiHH@wesnoth/developer/yogihh] has quit ["Bye folks"]
20090225 23:18:06< silene> loonycyborg: yes; and my mistake, the fetch had somehow failed, it works now
20090225 23:22:19-!- BenUrban [n=benurban@c-68-49-10-243.hsd1.md.comcast.net] has joined #wesnoth-dev
20090225 23:25:43-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090225 23:29:13-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit ["On the road again"]
20090225 23:31:37-!- Sapient [n=sapien-x@c-24-126-133-155.hsd1.ga.comcast.net] has joined #wesnoth-dev
20090225 23:31:43< Sapient> yo
20090225 23:31:54< Sapient> silene: you had a question about spawned events?
20090225 23:32:32< Sapient> if an event is spawned from a variable then it's memory is managed by vconfig
20090225 23:33:37< silene> how do you tell vconfig to take ownership of a config object and to delete when it's no longer used?
20090225 23:33:39-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit ["Leaving"]
20090225 23:33:40< Sapient> vconfig(&cfg,&cfg) creates a copy of cfg which is managed by the vconfig class
20090225 23:34:18< silene> why pass it twice the same argument?
20090225 23:34:37< Sapient> I plan to make that constructor private and add a simpler syntax for the public constructor such as vconfig(&cfg,true)
20090225 23:35:50< Sapient> the reason it is passed twice is because config* type is used as the cache_key as well as the pointer to the contents
20090225 23:37:18< Sapient> a hack or a clever simplification depending on your perspective I guess ;)
20090225 23:37:37-!- ilor_ [n=user@auc111.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20090225 23:38:52< silene> i'm a bit confused, is there a case where you would like the key of the cache to not be the object itself?
20090225 23:39:47< Sapient> when you write vconfig(&cfg,&cfg) it will recognize that &cfg is not already a memory-managed cache key and it will put a copy of cfg on the heap then store a pointer to that as the cache key
20090225 23:40:39< Sapient> silene: if cfg itself were the cache key then operator== would be very costly indeed
20090225 23:40:56< Sapient> so lookups would take ages
20090225 23:41:18< loonycyborg> Why should it be costly?
20090225 23:42:07< Sapient> loonycyborg: you don't understand why cfg==cfg is costly... or cfg.hash() > cfg.hash() is costly... or what?
20090225 23:42:21< Sapient> the cfg can be very large
20090225 23:42:31-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20090225 23:42:31< silene> Sapient: are you telling me that if i register an object, erase it, create a new object, register it, then it won't be stored because it happens to have the same address as the older one?
20090225 23:42:46< Sapient> no you don't get it
20090225 23:42:47< loonycyborg> I only understand that you can override operator== to be as fast as you wish.
20090225 23:43:31< Sapient> silene, the second &cfg which is the cache_key is replaced straightaway with the real cache_key (on the heap)
20090225 23:43:39< Sapient> look at the constructor
20090225 23:45:41< silene> hmm... i see; but then, is it actually useful to look in the cache if an object is already there when creating a vconfig object? i don't see how it could be there
20090225 23:46:00< Sapient> if I write vcfg(&cfg,&cfg); then (vcfg.cache_key_ != &cfg), however (*vcfg.cache_key_ == cfg)
20090225 23:46:24< Sapient> yes, it is useful
20090225 23:47:02< Sapient> because when a memory-managed vconfig returns a child vconfig it can re-use the same key
20090225 23:47:46< Sapient> however, at that point (*vcfg.cache_key_ != *vcfg.cfg_)
20090225 23:47:50-!- ilor [n=user@atx173.neoplus.adsl.tpnet.pl] has quit [Connection timed out]
20090225 23:48:52-!- nital is now known as nital_away
20090225 23:48:54< silene> so a child vconfig has not its own key but the key of its parent?
20090225 23:49:03< Sapient> exactly
20090225 23:49:26< Sapient> it doesn't perform any pruning
20090225 23:49:46< Sapient> I felt that would be overly complex
20090225 23:49:51< silene> is it on purpose that operator= performs several copies on the row?
20090225 23:50:08 * Sapient checks
20090225 23:50:35< Ivanovic> time for me to head off to bed, n8
20090225 23:51:27< Sapient> silene: which operator== ?
20090225 23:51:28< Sapient> vconfig& vconfig::operator=(const vconfig cfg)
20090225 23:51:37< Sapient> or vconfig& vconfig::operator=(const config* cfg)
20090225 23:52:17< silene> the first one, its argument is passed by copy
20090225 23:52:28< Sapient> ah, that is tradition
20090225 23:52:46< silene> ???
20090225 23:52:57< Sapient> traditionally vconfigs have always been passed by value because they were such lightweight objects with just a cfg_ member
20090225 23:53:06< Sapient> but it would make sense to change that now
20090225 23:53:46< Sapient> I didn't bother changing it because I'm lazy and it is still a fairly lightweight class
20090225 23:53:52< silene> because the whole body of the function is useless if you pass the argument by copy
20090225 23:54:11< Sapient> oh? good catch
20090225 23:54:38< Sapient> hmm
20090225 23:54:48< Sapient> I think it still works...
20090225 23:54:55< Sapient> just it performs extra effort
20090225 23:55:07-!- boucman [n=rosen@wesnoth/developer/boucman] has quit [Remote closed the connection]
20090225 23:55:09< Sapient> I agree that it should be passed by reference, regardless
20090225 23:56:04-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090225 23:56:57< Sapient> so feel free to change that if you want
20090225 23:57:00< Sapient> or I will
20090225 23:58:09< silene> i'm compiling on another branch right now, so i can't; but if it isn't done tomorrow, i will
20090225 23:58:13< Sapient> one of the reasons I left all the pass-by-value vconfig code laying around was so that the memory management code would get more rigorous testing ;)
20090225 23:58:35< silene> :-)
20090225 23:58:35< Sapient> so that is how I justified my laziness 
20090225 23:58:48-!- Corvvs [n=michaelm@pool-71-163-212-41.washdc.east.verizon.net] has joined #wesnoth-dev
--- Log closed Thu Feb 26 00:00:04 2009