--- Log opened Tue Apr 14 00:00:49 2009
20090414 00:04:59-!- boucman [n=rosen@wesnoth/developer/boucman] has quit [Remote closed the connection]
20090414 00:06:54-!- cjhopman_ [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090414 00:11:07< Sapient> Shadow_Master / Mordante / silene : ah, yes... the expired string of tstring reference; I remember that issue well
20090414 00:11:53< Sapient> the problem is when I write:    const std::string& temp = vcfg["foo"];
20090414 00:12:46< Sapient> the lifespan of temp would have been guaranteed if it were a t_string
20090414 00:13:11-!- cyber_11 [n=muratcan@78.165.114.202] has joined #wesnoth-dev
20090414 00:13:39< Sapient> but since it is a reference to a member inside the t_string, this leads to UB
20090414 00:13:55< Sapient> in MSVC++6 it will work fine
20090414 00:14:26< Sapient> but for most gnu compilers you will get a segfault
20090414 00:15:01< Sapient> whenever you next try to use temp
20090414 00:15:15-!- cjhopman_ [n=chris@wesnoth/developer/cjhopman] has quit ["Konversation terminated!"]
20090414 00:15:59< Sapient> the local variables in game_events code was changed back and forth from "const string" to "string const&" many times before this was realized
20090414 00:16:43< Sapient> this was dubbed the great evil of t_string
20090414 00:19:07-!- Reisiger [n=Reisiger@adsl-84-227-169-168.adslplus.ch] has quit ["Verlassend"]
20090414 00:21:20< Sapient> specifically, tstring::operator const std::string&() const { return str(); }
20090414 00:22:13-!- oak_ [n=oakus@c02--112b.kn.vutbr.cz] has quit [Read error: 110 (Connection timed out)]
20090414 00:26:10-!- Sapient [n=sapien-x@wesnoth/developer/sapient] has quit []
20090414 00:30:45< corn> that's interesting
20090414 00:31:00< corn> according to the stats dump, more apple users play wesnoth than all other platforms combined
20090414 00:33:50< loonycyborg> That's because most windows users are blocked by firewall :P
20090414 00:33:57-!- Sirp [n=me@wesnoth/developer/dave] has joined #wesnoth-dev
20090414 00:34:03< corn> stats data is sent over port 80
20090414 00:34:07< loonycyborg> Stats from them that is..
20090414 00:34:08< corn> fw wouldn't block it
20090414 00:34:27< corn> actually, maybe it would
20090414 00:34:32< loonycyborg> Windows firewall is based on apps, not ports.
20090414 00:34:32< dfranke> corn: yes, it would...
20090414 00:34:39< dfranke> ^^^ what he said
20090414 00:34:45< corn> oh
20090414 00:35:52< dfranke> The Windows security framework wishes to annoy the hell out of you.  Cancel or allow?
20090414 00:37:39< corn> http://cornmander.com:9090/platform/
20090414 00:37:52< corn> unspecified is probably windows
20090414 00:37:53< corn> er
20090414 00:37:54< corn> linux
20090414 00:38:55< corn> what are *all* the platforms wesnoth can run on
20090414 00:39:12< corn> I am gonna submit a patch for upload_log.cpp that will make it report more than just windows and apple
20090414 00:39:38< Sirp> corn: where is the source to your interface?
20090414 00:39:46< corn> ah, 1 sec
20090414 00:39:50< corn> I'll tar up the latest version
20090414 00:40:20< dfranke> corn: it's not really a closed set... there are probably all kinds of UNIX variants that aren't officially supported yet work fairly easily.
20090414 00:41:01< dfranke> corn: on anything vaguely POSIXy you can probably gather the system type from uname(2).
20090414 00:41:08< corn> http://cornmander.com/wesstats.tar.gz
20090414 00:41:38< corn> dfranke: I would rather try to identify at compile time, since that's how it's currently being done
20090414 00:42:04< corn> I could just identify POSIX compliant systems by whatever macro definition they have
20090414 00:43:12< Sirp> corn: btw do you have a plan for fast 'aggregation'? e.g. how are you going to show a report of platforms used without doing a full table scan of the MySQL DB?
20090414 00:44:04< corn> select a random subset of the rows
20090414 00:45:17< dfranke> heh... in college, my database prof's research area was approximate query answers.
20090414 00:46:07< corn> I can scan 10k rows in 1/10th of a second or less
20090414 00:46:37< dfranke> how are you going to make sure they're a random subset though?
20090414 00:46:45< corn> so I would first find out the length of the table, then do 10k SELECTS with a RAND() mixed in
20090414 00:46:54< corn> there is a SQL rand function
20090414 00:46:56< dfranke> that's not a scan then.
20090414 00:47:00< dfranke> that's 10,000 seeks.
20090414 00:47:05< corn> true
20090414 00:47:17< corn> I could shuffle the tables in a cronjob nightly
20090414 00:47:33< corn> and then I would just select the first 10k rows
20090414 00:47:42< dfranke> that could work.
20090414 00:47:45< Crab_> corn: won't it be better to aggregate nightly ?
20090414 00:48:06< corn> Crab_: too many possibilities for filters
20090414 00:48:08< dfranke> Crab_: I think we want to answer a wider space of possible queries than we want to do every night.
20090414 00:48:21< corn> right now you can say for example find all the data for version X on scenario Y
20090414 00:48:29< corn> there is no way to pregenerate that much info
20090414 00:49:07< corn> for example on this page there are 5 fields
20090414 00:49:08< corn> http://cornmander.com:9090/gold/
20090414 00:49:14< corn> some of them have 10+ elements
20090414 00:49:31< corn> so you would need x*y*z*a*b
20090414 00:49:40< corn> things done every night
20090414 00:49:42< dfranke> so yeah, a nightly 'UPDATE foo SET r=RAND()' and a clustered index on r seems like a plan.
20090414 00:50:49< Crab_> ok
20090414 00:50:58< corn> anyway, the defines I've found in the source code are for amiga, beos, apple, and win32
20090414 00:51:27< dfranke> I've seen one for OS/2 :-)
20090414 00:51:40< corn> ah yeah
20090414 00:51:42< corn> game.cpp has it
20090414 00:52:19< dfranke> but if anyone is playing on OS/2, I do want to collect statistics on them...
20090414 00:52:31< corn> heh
20090414 00:52:32< dfranke> but only to make it easier to round them up for extermination :-)
20090414 00:52:53< corn> I followed the mplayer dev list for a while and not too long ago someone submitted a HUGE series of patches to get mplayer to compile on os/x
20090414 00:52:57< corn> er
20090414 00:52:58< corn> os/2
20090414 00:53:01< corn> os/21
20090414 00:53:11< corn> it seems like a substantial people in korea use it
20090414 00:53:13< corn> for whatever reason
20090414 00:53:23< dfranke> strange.
20090414 00:54:37< dfranke> I have a friend whom I've known since elementary school whose parents were both OS/2 developers.
20090414 00:54:55< dfranke> but they've long since moved elsewhere in the company.
20090414 00:55:33< corn> heh
20090414 00:55:36< corn> ibm is a big company
20090414 00:55:40< corn> hey guys, can you do this
20090414 00:55:45< corn> touch foo.c
20090414 00:55:49< corn> gcc -dM -E foo.c
20090414 00:55:51-!- Jetrel [n=Jetrel@wesnoth/artist/jetrel] has joined #wesnoth-dev
20090414 00:55:52< corn> and pastebin the result
20090414 00:56:05< corn> it will give you all the internal definitions of GCC
20090414 00:56:20< dfranke> what platform do you want it for?
20090414 00:56:23< corn> all
20090414 00:56:27-!- Jetrel [n=Jetrel@wesnoth/artist/jetrel] has left #wesnoth-dev []
20090414 00:56:33< corn> I just did it on my x86_64 machine
20090414 00:56:36< corn> ubuntu linux
20090414 00:56:47< corn> I found out that there is a __linux and a __linux__ define
20090414 00:57:22< dfranke> this seems like a bad approach.
20090414 00:57:35< dfranke> I'd make it gcc-dependent.
20090414 00:57:40< dfranke> It'd*
20090414 01:00:45< corn> you suggest going with uname?
20090414 01:01:17-!- Mythological [i=Mytholog@77.28.89.213] has joined #wesnoth-dev
20090414 01:01:56< dfranke> uname seems like the right thing for distinguishing among POSIXes, yes.
20090414 01:05:03< corn> what define should I check for? _POSIX_SOURCE?
20090414 01:06:15< dfranke> corn: that sounds right, but I'd look up the semantics carefully first.
20090414 01:06:59< dfranke> corn: how about just checking for the existance of sys/utsname.h?
20090414 01:07:42< corn> how do I check for the existance of an include file?
20090414 01:07:46< corn> oh
20090414 01:07:53< corn> I am dumb :p
20090414 01:08:11< corn> check _SYS_UTSNAME_H?
20090414 01:08:32< corn> seems like a chicken and egg problem though, because it wouldn't be defined unless you included the file first
20090414 01:08:39< dfranke> no, you'd need to do it from the build system, I think.
20090414 01:08:41< corn> and you can't include unless you're on a POSIX compliant system
20090414 01:09:00< corn> are there any existing checks like that?
20090414 01:09:12< dfranke> I think so.
20090414 01:10:13< corn> I see checks on env["PLATFORM"]
20090414 01:10:27< corn> all of them have to do with checking whether or not the platform is windows
20090414 01:10:56< corn> is it ok to say that any platform besides windows is posix compliant?
20090414 01:13:31-!- Gnutoo [n=gnutoo@host216-163-dynamic.51-79-r.retail.telecomitalia.it] has quit [Read error: 113 (No route to host)]
20090414 01:14:20-!- cjhopman_ [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090414 01:14:33< dfranke> not sure.
20090414 01:17:31< corn> portability is a pain ):
20090414 01:29:20< AnMaster> Bus error
20090414 01:29:26< AnMaster> never seen that before
20090414 01:29:37< AnMaster> alas ulimit was wrong so it didn't dump core
20090414 01:29:41< AnMaster> nor can I reproduce it
20090414 01:29:44< AnMaster> but strange
20090414 01:34:44-!- cyber_11 [n=muratcan@78.165.114.202] has quit []
20090414 01:36:24-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Read error: 104 (Connection reset by peer)]
20090414 01:37:00< AnMaster> <corn> is it ok to say that any platform besides windows is posix compliant? <-- BeOS? DOS? OS/2? TOPS-20? MULTICS?
20090414 01:37:14< AnMaster> probably wesnoth doesn't support those anyway
20090414 01:37:37< AnMaster> oh forgot AmigaOS in that listing
20090414 01:41:02< CIA-30> esr * r34888 /trunk/data/campaigns/ (5 files in 3 dirs): Text tweaks, walkthrough and todo updates.
20090414 01:42:24-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["ChatZilla 0.9.84 [Firefox 3.0.8/2009032609]"]
20090414 01:43:31< Sirp> corn/ dfranke (sorry I was afk): but what if e.g. we want to see if anyone has played some really obscure scenario that hardly anyone plays? What if 10k samples aren't enough?
20090414 01:43:53< loonycyborg> AnMaster: I saw some BeOS specific code in filesystem.cpp.
20090414 01:44:45< Sirp> what about a solution where we aggregated and then resorted to a full table scan for complex queries?
20090414 01:50:55< corn> that sounds like a fair solution
20090414 01:51:46< corn> it's easy to count the number of entries for a particular scenario, you could just check that before you grab the aggregate data
20090414 01:54:05-!- BenUrban [n=benurban@c-68-49-10-243.hsd1.md.comcast.net] has joined #wesnoth-dev
20090414 01:57:36-!- molgrum [n=molgrum@c83-249-53-163.bredband.comhem.se] has quit ["Lämnar"]
20090414 02:04:17-!- ikarius [n=ross@smtp.gridironsystems.com] has quit []
20090414 02:05:24< corn> can you guys check out https://gna.org/patch/?1149 ? I want that patch to go through before I submit the next one (improve platform detection) just incase there is some overlap
20090414 02:06:02< CIA-30> crab * r34889 /trunk/data/ai/scenarios/ (5 files in 2 dirs): 
20090414 02:06:02< CIA-30> Used lua scripting to make AI Arena independent from test situations.
20090414 02:06:02< CIA-30> Special thanks to silene for hints on using lua.
20090414 02:07:30< corn> also, what are the rules for the copyright at the top of source files? at what point can I add a copyright claim for myself if working on an existing file?
20090414 02:19:57< dfranke> corn: http://www.bell-labs.com/project/aqua/
20090414 02:20:18< AnMaster> <loonycyborg> AnMaster: I saw some BeOS specific code in filesystem.cpp. <-- I thought SDL didn't work on BeOS?
20090414 02:20:30< AnMaster> maybe I misremembered
20090414 02:21:22< dfranke> corn: check some of those research papers for inspiration on approximate queries, maybe.
20090414 02:22:43-!- alink_ [n=alink@78.129.18.215] has joined #wesnoth-dev
20090414 02:23:15< dfranke> aargh!  nm... all the links are broken :-(
20090414 02:26:28< loonycyborg> AnMaster: http://www.libsdl.org/faq.php?action=listentries&category=1#54 <- BeOS is one of supported platforms.
20090414 02:26:42< AnMaster> ok, must have misremembered then
20090414 02:27:06< AnMaster> loonycyborg, is it still tested on beos?
20090414 02:27:45< loonycyborg> No idea. Neither about wesnoth nor about SDL :P
20090414 02:27:56< Shadow_Master> AnMaster: here now
20090414 02:30:11-!- alink_ [n=alink@78.129.18.215] has quit [Read error: 104 (Connection reset by peer)]
20090414 02:30:22< Shadow_Master> I just woke up - and had some nightmares with suokko wrecking the game engine
20090414 02:30:31< Shadow_Master> not pretty.
20090414 02:31:16-!- alink_ [n=alink@78.129.18.215] has joined #wesnoth-dev
20090414 02:33:53-!- cjhopman_ is now known as cjhopman
20090414 02:34:38< Crab_> Question: why ai.cpp is threated differently than other AI .cpp files in src/SConscript ?
20090414 02:36:04< loonycyborg> Crab_: That's an artefact since removal of python ais.
20090414 02:36:20< loonycyborg> IIRC
20090414 02:36:22< Shadow_Master> artifact?
20090414 02:36:44< Shadow_Master> they're different words? :o
20090414 02:36:51< loonycyborg> Nope.
20090414 02:37:10< loonycyborg> It's just 4:36 here :P
20090414 02:37:12< Crab_> loonycyborg: thanks.  I'm preparing to move ai files into /src/ai, so I'm editing all buildfiles I know of atm.
20090414 02:38:08< Turuk> Technically the British spell it artefact.... ;)
20090414 02:38:14< Shadow_Master> loonycyborg: at least you don't have _that_ kind of nightmares
20090414 02:38:22< Turuk> Maybe loonycyborg is secretly British
20090414 02:38:37< Shadow_Master> I'm still trying to remove the suokko-commit-flood image from my mind
20090414 02:38:50-!- alink [n=alink@wesnoth/developer/alink] has quit [Read error: 110 (Connection timed out)]
20090414 02:46:07< Polarina> Try removing all comments from source files in the trunk.
20090414 02:46:17< Shadow_Master> Polarina, are you pondering what I'm pondering?
20090414 02:46:24< Polarina> Shadow_Master: It depends. :P
20090414 02:47:12< Polarina> Shadow_Master: Are you pondering about silencing me again?
20090414 02:47:38< Shadow_Master> No.
20090414 02:47:47< Polarina> Ok, then I'm not following you.
20090414 02:48:20 * Turuk shares a ponder with Shadow_Master
20090414 02:48:23< Shadow_Master> Then I'll have to silence you.
20090414 02:48:26< Shadow_Master> :P
20090414 02:48:34< Polarina> Shadow_Master: xD
20090414 02:48:43< Turuk> Don't silence her, she's being good.
20090414 02:49:02< Shadow_Master>  we need more protection against spambots it seems
20090414 02:49:17< Shadow_Master> Turuk: the last one, how many posts made?
20090414 02:49:20< Polarina> What about CAPTCHA on all page requests?
20090414 02:49:28< Turuk> 16
20090414 02:49:37< Turuk> and Polarina, please no
20090414 02:49:38< Shadow_Master> just one less than the one I destroyed
20090414 02:49:48< Turuk> Forums that do that become much too tedious
20090414 02:49:57 * Shadow_Master throws packet sugar at Polarina ----------> #
20090414 02:49:58< Turuk> Or the ones that require a CAPTCHA every time you search
20090414 02:50:28 * Polarina responds with a IMCP packet.
20090414 02:51:00< Shadow_Master> * sugar packet . lolwut
20090414 02:51:25< Shadow_Master> Turuk: nonetheless, it seems to be known that phpBB3's captchas aren't optimal
20090414 02:51:34< Turuk> Indeed
20090414 02:51:45< Polarina> No CAPTCHAs are optimal. All known methods have been broken.
20090414 02:51:50< Shadow_Master> there's lik, a whole section in the wikipedia article dedicated to it
20090414 02:52:51< Polarina> It redirects to Ngelik?
20090414 02:53:22< Shadow_Master> it's been discussed in the past about adding some sort of miniquestionnarie to the registration page, but AFAIR nobody got to a conclusion
20090414 02:53:53< Polarina> "Who's the current president of Kazakhstan?" is a good mini-question.
20090414 02:54:13< Polarina> People who know how to use Wikipedia will succeed that test.
20090414 02:55:22< Turuk> Spell Wesnoth backwards
20090414 02:55:31< Shadow_Master> "Question (if you are not a bot, reply "ABC")
20090414 02:55:44< Shadow_Master> replace "Question" and "ABC" with something elaborated, of course
20090414 02:56:11< Polarina> "How do you pronounce Coloneal?"
20090414 02:56:12< shikadibot> Shadow_Master: ABC
20090414 02:56:20< Crab_> Polarina: google succeeds on that Who's the current president of Kazakhstan?" test too ) without human intervention )
20090414 02:56:29< Turuk> coloneal?
20090414 02:56:30< Turuk> what?
20090414 02:56:35< Shadow_Master> and as shikadibot demonstrates, this still fails on this scenario: http://en.wikipedia.org/wiki/CAPTCHA#Human_solvers
20090414 02:56:48< Polarina> Crab_: :O
20090414 02:56:59< Crab_> Polarina: enter that into google )
20090414 02:57:14< Shadow_Master> Crab_: your eyes!?
20090414 02:57:19< Polarina> Crab_: :O
20090414 02:57:22< Crab_> and note that it has *additional result* at the top 
20090414 02:57:40< Crab_> Shadow_Master: I'm sleepy ) so eyes are closed )
20090414 02:57:48< loonycyborg> Shadow_Master: Even human solvers will fail on a wesnoth-specific question :P
20090414 02:58:06< Shadow_Master> yeah, that's why they never reached a conclusion
20090414 02:58:39< Polarina> "Are you a human? (bots, please don't lie)"
20090414 02:58:42< loonycyborg> "What is the damage peasant deals with a pitchfork during the day?"
20090414 02:59:11< Shadow_Master> loonycyborg: and that brings us to a sad side-effect
20090414 02:59:20< Turuk> User error? :P
20090414 02:59:37< Crab_> night )
20090414 02:59:46< Shadow_Master> no, people who join to e.g. invite us to <game database site here>
20090414 02:59:46-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090414 03:00:22< Shadow_Master> (unless you take the fascist way and really want to consider anyone who doesn't join the forums to play/develop wesnoth, a spammer)
20090414 03:01:52< Shadow_Master> (but then again, you can leave the answer in the same line for them)
20090414 03:02:04< Shadow_Master> http://xkcd.com/233/
20090414 03:04:37-!- res|laptop [n=res@pdpc/supporter/student/res2k] has quit [Read error: 110 (Connection timed out)]
20090414 03:04:57< Polarina> http://xkcd.com/565/
20090414 03:05:59< crimson_penguin> http://xkcd.com/329/
20090414 03:06:04-!- res|laptop [n=res@erft-4d07da5a.pool.mediaWays.net] has joined #wesnoth-dev
20090414 03:07:46< Polarina> http://xkcd.com/303/ !
20090414 03:08:03 * crimson_penguin knows it isn't quite as relevant, but just wanted to get in on the xkcd linking; I've had these comics sitting open in my browser for over 2 weeks now
20090414 03:08:22< crimson_penguin> Polarina: oh yeah? well, http://xkcd.com/323/ !
20090414 03:08:43< crimson_penguin> and I think this applies to all of us now: http://xkcd.com/307/
20090414 03:08:43< Polarina> :O
20090414 03:08:57 * Polarina doesn't drink alcohol.
20090414 03:09:13 * crimson_penguin doesn't drink at all significant amounts of alcohol
20090414 03:09:32 * Turuk doesn't drink either.
20090414 03:09:46< Turuk> My personal favorite: http://xkcd.com/386/
20090414 03:09:53< crimson_penguin> I used to shun it completely, but, while I still don't find the thought of drunkenness appealing, I think alcohol's actually pretty neat stuff, and can taste pretty good too, sometimes
20090414 03:10:29< Polarina> I vomit when I taste alcohol.
20090414 03:11:00< Turuk> I don't shun it, it used to be quite the opposite, but meh.  Leads to too many issues.  I stick to maybe a beer, and only on occasions
20090414 03:11:01< crimson_penguin> Wow
20090414 03:12:00-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzz"]
20090414 03:12:05< AnMaster> Shadow_Master, so what about the question
20090414 03:12:18< AnMaster> <AnMaster> in "An Errand of Hope", there is a coffin at 11,29 which looks special but nothing happens when I move a unit there
20090414 03:12:24< AnMaster> Shadow_Master, that was the question
20090414 03:12:32< AnMaster> I'm going to bed in a sec
20090414 03:12:42-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection]
20090414 03:13:52-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090414 03:13:58< crimson_penguin> to break that chain of xkcd links: http://www.happyspork.com/pics/vancouver_photos/ducks.jpg
20090414 03:14:04< crimson_penguin> DUCKS :O
20090414 03:14:43< Turuk> funny man ;)
20090414 03:15:36< crimson_penguin> (more photos from Vancouver if you remove the ducks.jpg... but then you don't get any more ducks)
20090414 03:15:47< cjhopman> ducks!
20090414 03:17:42< Polarina> What's Vancouver?
20090414 03:18:35< Turuk> Somewhere in Canada
20090414 03:18:50< Turuk> City in British Columbia
20090414 03:19:12< crimson_penguin> Yeah, big city in British Columbia, on the West coast
20090414 03:19:23 * crimson_penguin went there for 2 weeks at the end of last month
20090414 03:19:39 * crimson_penguin lives on the other side of the country, near-ish Ottawa
20090414 03:20:12< Turuk> Ooo, near the capital
20090414 03:20:13< Turuk> Fancy
20090414 03:21:02< Turuk> It would be nice to see the Centre Block some day
20090414 03:21:17< crimson_penguin> Yeah, I'm between the capital of Canada, and the capital of Ontario (which is muuuch bigger; Toronto)
20090414 03:22:54< Turuk> Belleville? :P
20090414 03:23:03-!- |Andylee| [n=kvirc@188-23-3-153.adsl.highway.telekom.at] has joined #wesnoth-dev
20090414 03:23:11< crimson_penguin> My mom's dad lives there :P
20090414 03:23:23< Turuk> Hmm, so I was close ;)
20090414 03:23:23 * Polarina haven't got a clue on what you're talking about.
20090414 03:23:29< Turuk> Canada
20090414 03:23:29< crimson_penguin> But no, I live in the woods, near Killaloe, and nearer Wilno
20090414 03:23:55< crimson_penguin> Well not that close; Ottawa's closer than Belleville
20090414 03:24:13< Polarina> Good night. :)
20090414 03:24:41< Turuk> Ah, that half way.  So are you up near Algonquin?
20090414 03:25:32-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit ["Leaving."]
20090414 03:31:20-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has left #wesnoth-dev []
20090414 03:41:48-!- Chusslove [n=caslav@brsg-d9befe75.pool.mediaWays.net] has quit [Read error: 110 (Connection timed out)]
20090414 03:41:55-!- Andylee [n=kvirc@188-23-107-61.adsl.highway.telekom.at] has quit [Read error: 110 (Connection timed out)]
20090414 03:55:58-!- alink_ [n=alink@78.129.18.215] has quit [Remote closed the connection]
20090414 03:56:55-!- res|laptop [n=res@pdpc/supporter/student/res2k] has quit [Read error: 110 (Connection timed out)]
20090414 04:11:53-!- noy [n=Noy@70.70.224.183] has joined #wesnoth-dev
20090414 04:36:20-!- blacklotus89 [n=blacklot@p508BBD12.dip.t-dialin.net] has joined #wesnoth-dev
20090414 04:37:45< blacklotus89> is there a analyse mode for wesnoth planned?it could be based on the game ai and i thought of it because it would help me to analyse my own ai better and it's weaknesses
20090414 04:43:22< noy> blacklotus89: um, can you explain what you mean a bit better?
20090414 04:43:42< blacklotus89> sure
20090414 04:44:57-!- Ivanovic_ [n=ivanovic@dtmd-4db2af2e.pool.einsundeins.de] has joined #wesnoth-dev
20090414 04:47:38< dfranke> oh dear, here we go again...
20090414 04:47:39< blacklotus89> the analyse mode would look like the normal game but you got 2 arrows to go through the party (forward and backward). the ai can calculate who has the better position through 3 terms (3 terms cause my ai mainly uses this 3 terms) money,troops and the "tactical position" so troops that stay together...
20090414 04:47:50< blacklotus89> oh sry :P don't want to spam xD
20090414 04:47:52< dfranke> The first game in the Wesnoth MP lobby has no players in it.
20090414 04:48:31< blacklotus89> because they have different abilitys and how far/near they are to troops of the opponent
20090414 04:49:07< blacklotus89> and the analyse mode tries to tell what's good or bad and who has the better position clear or do i suck at explaining?
20090414 04:49:16< dfranke> Soliton.invoke()
20090414 04:51:44-!- DDR [n=chatzill@66.183.125.196] has joined #wesnoth-dev
20090414 04:55:52< noy> well blacklotus89, I think I get what you're explaining... I'm not too sure if it would really be that useful though
20090414 04:56:58< noy> then again others might see a utility in it
20090414 04:58:16< blacklotus89> hmm for me it would be but it's only an idea and if it's not implemented by the wesnoth devs and i don't get bored a bit more skilled and get a bit free time maybe i will write it myself and send the patch^^ i mean this function will be really cool for people who play this constantly and want to get better or something too ;)
20090414 04:58:41< blacklotus89> whooo but it's already 5 am i need at least 3 hours sleep :) gn8 @all
20090414 04:59:20< blacklotus89> oh and don't forget to think abbout it
20090414 05:00:49-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)]
20090414 05:00:55-!- Ivanovic_ is now known as Ivanovic
20090414 05:09:03-!- noy [n=Noy@wesnoth/developer/noy] has quit ["GO, GET TO THE CHOPPAH!!!"]
20090414 05:13:26-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090414 05:24:02-!- noy [n=Noy@d75-157-52-251.bchsia.telus.net] has joined #wesnoth-dev
20090414 05:32:10< dfranke> corn, why does your IP address reverse to www.fastmarketfeedback.com? :-)
20090414 05:39:00-!- ancestral [n=martinpr@97-116-111-81.mpls.qwest.net] has joined #wesnoth-dev
20090414 05:40:54-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit ["Leaving"]
20090414 05:43:31-!- karl_m [n=u3468067@dubhe.anu.edu.au] has joined #wesnoth-dev
20090414 05:56:15-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090414 05:56:50< corn> dfranke: that's still happening?
20090414 05:57:32< dfranke> corn: yup.
20090414 05:57:34< corn> I just switched my colo to a new computer and the datacenter had a mix up
20090414 05:57:38< corn> they assigned me an IP that was already taken
20090414 05:57:53< corn> they cleared the route quickly but apparently some people still have problems
20090414 05:58:18< dfranke> corn: wait... you have your own colo box?
20090414 05:58:30< corn> aye
20090414 05:58:31< dfranke> corn: I assumed cornmander.com was DynDNS or something.
20090414 05:58:34< corn> no
20090414 05:58:38< corn> I run my own server
20090414 05:58:52< corn> I was away for a few days because I had to transfer everything over from one box to another
20090414 05:59:05< dfranke> ah, nice.
20090414 05:59:11< dfranke> I used to do that, now I just use Linode.
20090414 05:59:17< corn> no performance issues?
20090414 05:59:26< corn> someone on another instance can suck up all your cpu
20090414 05:59:26< dfranke> much cheaper, just as much control, performance is all I need.
20090414 05:59:30< corn> ah
20090414 05:59:34< corn> I run gameservers on the side
20090414 05:59:42< corn> for fun
20090414 06:00:21< corn> http://cornmander.com/mrtg/
20090414 06:00:44< corn> I also have a friend at a uni that blocks bt ports
20090414 06:00:55< corn> so he has a portforwarding scheme set up through my server
20090414 06:01:02< corn> that explains the constant high bandwidth usage
20090414 06:01:26< corn> although I am pretty confident that that graph is incorrect and those are actually bits and not bytes...
20090414 06:01:30< dfranke> the load average does look a bit heavy for a linode.
20090414 06:02:50< corn> anyway, any quick bugs that could use fixing?
20090414 06:03:01< corn> if not, i am gonna address that one about 1.3 map compatibility in the editor
20090414 06:03:09< corn> I still haven't gotten commit access
20090414 06:03:11< corn> rightfully so
20090414 06:03:34< dfranke> 1.3?
20090414 06:03:37< dfranke> you mean 1.2?
20090414 06:03:41< corn> probably
20090414 06:03:56< corn> the point of the bug was that the editor didn't like files without a required header
20090414 06:04:06< dfranke> No, the problem is more complex than that.
20090414 06:04:20< dfranke> We completely changed the map symbols between 1.2 and 1.4.
20090414 06:05:24< corn> so it can't be solved just by adding in the header?
20090414 06:05:28< dfranke> Even if you can do it I don't think we want it there.  At the very least, ask esr first.
20090414 06:05:39< dfranke> no, it can't.
20090414 06:06:34 * ancestral listens
20090414 06:06:44< corn> alright
20090414 06:07:20< dfranke> corn: what's the state of the fork-to-upload patch?
20090414 06:07:47< corn> still haven't coded for windows
20090414 06:07:50< corn> I'll do that tomorrow
20090414 06:08:04< corn> gonna update timelien finally and update the gsoc page
20090414 06:08:05< dfranke> but it's working on UNIX?
20090414 06:08:07< corn> yeah
20090414 06:08:35-!- res|laptop [n=res@erft-4d07da5a.pool.mediaWays.net] has joined #wesnoth-dev
20090414 06:09:12-!- wesbot changed the topic of #wesnoth-dev to: released 1.6.1, announcing "soon" | Summer of Code info: http://www.wesnoth.org/wiki/SummerOfCodeIdeas | 53 bugs, 235 feature requests, 9 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090414 06:09:46< corn> I think the version i sent you in email is more or less the working version
20090414 06:10:19< dfranke> I can deal with the Windows support unless you really want to.  It's just going to be a pain in the butt and not really relevant to anything else you're working on.
20090414 06:10:53< corn> yes, that would be good
20090414 06:11:13< corn> I've managed to stay away from windows development until this point
20090414 06:11:34< dfranke> If you want something that'll let you dive into the codebase a bit, try doing the rest of https://gna.org/bugs/index.php?13360
20090414 06:13:26< corn> ok, so you fixed the lexical sort problem
20090414 06:13:36< dfranke> right
20090414 06:13:46< dfranke> but even the "fixed" behavior doesn't make much sense.
20090414 06:14:41< corn> ok, so you basically want to copy the functionality of the recall list to the unit list
20090414 06:15:32< dfranke> I want to change the behavior when you click on the "XP" column header, on both the recall list and the unit list.
20090414 06:16:12< corn> what is the default ordering of the recall list?
20090414 06:16:30< corn> sorty by (x/y)
20090414 06:16:34< corn> sort*
20090414 06:17:05< dfranke> default ordering is that it first sorts by level from highest to lowest, and then by how much more XP is needed for a level-up.
20090414 06:17:14< corn> qy
20090414 06:17:14< corn> ah
20090414 06:17:15< corn> ok
20090414 06:17:33< corn> can I get a savegame where I can recall a unit?
20090414 06:17:43< corn> multiple units actually
20090414 06:17:46< cjhopman> the test scenario has a recall list
20090414 06:17:49< cjhopman> 3 units
20090414 06:17:51< corn> ok
20090414 06:17:53< corn> cool
20090414 06:17:55< corn> I'll get on it now
20090414 06:17:58< cjhopman> don't know if they have experience though
20090414 06:19:04< corn> nope
20090414 06:19:05< corn> they don't
20090414 06:19:11< corn> where can I modify that
20090414 06:20:07< cjhopman> data/scenario-test.cfg
20090414 06:20:31< corn> ok, thanks
20090414 06:22:38< corn> what's the wml to specify level and exp?
20090414 06:23:35< cjhopman> experience=x
20090414 06:23:43< cjhopman> level is determined by the type i believe
20090414 06:23:46< corn> and it will automatically level based on exp?
20090414 06:24:06< cjhopman> i dont think so
20090414 06:24:22< cjhopman> leveling i think is only done after an attack
20090414 06:25:07< dfranke> you can use :unit advances=1 to level
20090414 06:25:35< cjhopman> but not while the unit is in the recall list
20090414 06:25:49< cjhopman> at least i dont think you can
20090414 06:26:24-!- res|laptop [n=res@erft-4d07da5a.pool.mediaWays.net] has quit [Read error: 110 (Connection timed out)]
20090414 06:26:33< corn> how do I trigger that command?
20090414 06:26:39< corn> I brought up the command menu and I clicked the unit
20090414 06:26:46< corn> but it tells me that the command is unavailable
20090414 06:27:07< dfranke> hmm
20090414 06:27:12< dfranke> are you on 1.6 or trunk?
20090414 06:27:16< corn> trunk
20090414 06:27:33< corn> updated and recompiled a few hours ago
20090414 06:27:52< dfranke> did you run wesnoth with -d?
20090414 06:28:06< corn> nope
20090414 06:28:08< corn> that's probably it
20090414 06:28:49< corn> yep
20090414 06:30:52< corn> anyway to grant exp in game?
20090414 06:31:19< corn> got it
20090414 06:31:24< corn> :unit experience=10
20090414 06:31:59< corn> ah, I see
20090414 06:32:13< corn> it is only sorting by the x component of the experience fraction
20090414 06:32:24< corn> ok. give me a few minutes and I'll fix
20090414 06:32:32< dfranke> right.  We want to sort by y-x.
20090414 06:32:51< corn> why not level and then x?
20090414 06:33:03< dfranke> right, that's what I mean.
20090414 06:33:07< dfranke> err, no...
20090414 06:33:10< dfranke> level and then y-x.
20090414 06:33:19< corn> level and then (x/y)
20090414 06:33:26< corn> just evaluate the fraction and sort by it
20090414 06:33:39< dfranke> no, y-x.  That's the default sort order of the recall list.
20090414 06:34:02< corn> hm, ok
20090414 06:34:13< corn> if you sorted by the fraction you'd get the unit most close to leveing first
20090414 06:34:17< corn> but y-x is fine too
20090414 06:34:38< cjhopman> not really... a unit that is at 1/2 would come after one that is 100/201
20090414 06:35:31< corn> if you sort by y and then x, you would get a unit with 1/200 before a unit with 9/10
20090414 06:35:49< corn> oh
20090414 06:35:54< corn> you mean y minus x?
20090414 06:35:59< corn> sorry, misread 
20090414 06:36:00< corn> heh
20090414 06:37:47< dfranke> corn: anyway, the relevant code is in widgets/menu.cpp.  You'll want add a new sort method to basic_sorter.
20090414 06:38:38< corn> ok
20090414 06:38:55< dfranke> (we don't already have one because the default sort order isn't generated by basic_sorter; it's the order that units are read out of the recall-list vector)
20090414 06:44:32< corn> what is font::del_tags()?
20090414 06:45:32< ancestral> Can I ask you guys something?
20090414 06:46:26< ancestral> When you go to view scenario objectives, what do you expect to see? I'm simply curious how other people take it :)
20090414 06:46:55< ancestral> (yeah it's about https://gna.org/bugs/index.php?13313 )
20090414 06:47:08< dfranke> corn: looks like it strips formatting markup from strings
20090414 06:50:56< corn> lol, pretty hackish way of returning row data
20090414 06:51:41< dfranke> where?
20090414 06:52:14< corn> using font::del_tags
20090414 06:52:24< corn> the existing sorts have to parse it afterwards
20090414 06:52:33< corn> and remove what is probably whitespace before the text
20090414 06:53:11< dfranke> yeah, I suppose it really ought to get passed through del_tags before the sorter ever sees it.
20090414 06:53:45-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 06:54:48< corn> going to have to change the parameters of basic_sorter::less
20090414 06:54:58< dfranke> what?  why?
20090414 06:55:07< corn> you need to sort by two columns
20090414 06:55:13< corn> right now you just pass one column at a time
20090414 06:55:14< dfranke> it already gets both whole rows.
20090414 06:55:37< corn> are you gauranteed that column-2 is going to be the level row?
20090414 06:55:58< esr> corn: we don't neec 1.2 compatibility in the editor because 1.4 wmllint losslessly converts those upward.  Given that, we don't want to pay for the extra weight of code.
20090414 06:56:20< dfranke> corn: no.  you want to implement the analog of set_alpha_sort or set_numeric_sort as well as adding to less.
20090414 06:56:35< corn> esr: ok
20090414 06:56:53< dfranke> corn: so, a signature like basic_sorter::set_xp_sort(int xpcolumn, int level_column)
20090414 06:57:09< corn> right
20090414 06:58:06-!- Synergizer [n=synergiz@c-75-73-225-141.hsd1.mn.comcast.net] has quit ["Leaving"]
20090414 07:00:11< dfranke> (you might want to make the level column's sort do exactly the same thing as the XP column's sort, but you could probably just leave it alone.  Up to you.)
20090414 07:01:45-!- Synergizer [n=synergiz@c-75-73-225-141.hsd1.mn.comcast.net] has joined #wesnoth-dev
20090414 07:02:57< corn> it seems a little weird that a set is being created and only one value is being put in
20090414 07:03:02< corn> is that the case or am I missing something?
20090414 07:03:24< corn> actually, nevermind
20090414 07:03:26< corn> I got it
20090414 07:04:00-!- oak_ [i=oakus@c02--112b.kn.vutbr.cz] has joined #wesnoth-dev
20090414 07:11:52-!- law_ [n=law_@evil-wire.org] has joined #wesnoth-dev
20090414 07:12:00-!- law_ [n=law_@evil-wire.org] has left #wesnoth-dev []
20090414 07:12:14-!- law_ [n=law_@evil-wire.org] has joined #wesnoth-dev
20090414 07:12:46-!- law_ [n=law_@evil-wire.org] has left #wesnoth-dev []
20090414 07:13:19-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 07:14:21< corn> how is x/y being stored?
20090414 07:14:40< dfranke> as a string
20090414 07:14:42-!- gabm [n=gabriel@72.0.215.2] has quit [Remote closed the connection]
20090414 07:14:46< corn> right
20090414 07:14:53< corn> and then you do atoi on it and get x?
20090414 07:15:10< corn> that seems like pretty strange behavior
20090414 07:15:45< dfranke> The sorter is a bit tightly coupled to the UI code, so I think that's just what was expedient.
20090414 07:16:07< corn> yeah
20090414 07:16:07-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 07:16:33< corn> it just seemed nonsensical to me at first that you were converting something with symbols into an int
20090414 07:16:46< corn> I had to look through the manpage to find that it stopped at the first invalid character
20090414 07:34:16< corn> ok, done
20090414 07:34:17< corn> I think
20090414 07:35:55-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 07:36:34< corn> what do the columns corrospond to on line 878 in menu_events.cpp?
20090414 07:36:54< corn> I am trying to modify the recall list to use the new xp_sort but there are 5 sorts set for 4 columns
20090414 07:37:23< corn> and it's starting from a 1 index, and not 0
20090414 07:37:37< corn> on line 211 you start from a 0 index
20090414 07:38:18< corn> nevermind, I see the 5th col for 878
20090414 07:38:28< corn> but nevertheless the indexing is wrong
20090414 07:43:15< dfranke> oh, that confused me too...
20090414 07:43:22< dfranke> on the recall list, column zero is the picture.
20090414 07:43:28< corn> oh
20090414 07:43:29< corn> ok
20090414 07:43:31< dfranke> on the unit list there's no picture.
20090414 07:45:24< corn> ok, now time to figure out why it's not working correctly and segfaulting sometimes
20090414 07:45:27< corn> :/
20090414 07:46:11< corn> woops, used 4 as an index instead of 3
20090414 07:47:21-!- Sirp [n=me@wesnoth/developer/dave] has quit ["leaving"]
20090414 07:47:53-!- silene [n=plouf@ASte-Genev-Bois-152-1-42-199.w83-114.abo.wanadoo.fr] has joined #wesnoth-dev
20090414 07:48:24-!- Mythological_ [i=Mytholog@77.28.91.230] has joined #wesnoth-dev
20090414 07:49:19< corn> ok, done
20090414 07:49:26< corn> I'll upload the patch now and respond to the bug
20090414 07:52:24< dfranke> nice
20090414 07:53:20-!- silene1 [n=plouf@ASte-Genev-Bois-152-1-72-176.w86-198.abo.wanadoo.fr] has joined #wesnoth-dev
20090414 07:53:39< corn> hm
20090414 07:53:45< corn> I should really learn how to do svn branching
20090414 07:53:59< corn> I have to manually go through this diff and remove the things unrelated to the patch
20090414 07:54:02< corn> that I also coded
20090414 07:54:04-!- silene [n=plouf@ASte-Genev-Bois-152-1-42-199.w83-114.abo.wanadoo.fr] has quit [Nick collision from services.]
20090414 07:54:09-!- silene1 is now known as silene
20090414 07:55:10-!- Mythological [i=Mytholog@77.28.89.213] has quit [Read error: 60 (Operation timed out)]
20090414 07:57:31< corn> submitted
20090414 07:58:02< dfranke> cool.  I'm in the middle of a game; I'll review it right afterwards.
20090414 07:58:21< corn> sure
20090414 07:58:49-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090414 07:58:53< corn> I also modified scenario-test.cfg so that you can test the sorting on the recall units in the scenario
20090414 08:00:56-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090414 08:04:55< silene> Sapient: thanks a lot, it makes a lot more sense now; the issue is indeed when initializing a std::string reference with the result of vconfig::operator[]
20090414 08:05:26< silene> mordante, Shadow_Master: ^
20090414 08:06:47< silene> i wonder if we should mark the result of this operator as volatile; it seems like a hack but it may actually catch all the offenders; i should try
20090414 08:19:40< dfranke> corn: I don't understand what your for loop is doing.
20090414 08:20:47< corn> it's exactly the same as what is in the numeric sort, I just put an extra loop around it
20090414 08:21:15< corn> for whatever reason the numeric sort moves past any non-alphanumeric characters in the string returned by delete_tags
20090414 08:22:10< corn> I have to do that 4 times
20090414 08:22:19< corn> so I just made an array instead of having 4 variables a,b,c,d
20090414 08:22:29< corn> and wrapped it into another loop
20090414 08:22:37-!- DDR [n=chatzill@66.183.125.196] has quit ["ChatZilla 0.9.84 [Firefox 3.0.8/2009032609]"]
20090414 08:23:10< corn> er s/non-alphanumeric/non-digit/
20090414 08:23:24< dfranke> ok, I see.
20090414 08:24:43< dfranke> that needs a comment.
20090414 08:24:59< corn> ok, sure
20090414 08:25:03< dfranke> also, you left your changes to the test scenario in the patch.
20090414 08:25:11< corn> yep, it's to help test
20090414 08:25:25< dfranke> put those in a separate patch then.
20090414 08:25:29< corn> alright
20090414 08:25:36< dfranke> other than that, I need to test it, but looks good.
20090414 08:25:43< corn> ok, thanks
20090414 08:33:14-!- Netsplit niven.freenode.net <-> irc.freenode.net quits: |Andylee|, johani
20090414 08:34:01-!- Netsplit over, joins: |Andylee|, johani
20090414 08:34:30-!- Netsplit niven.freenode.net <-> irc.freenode.net quits: Blueblaze
20090414 08:37:02-!- Netsplit over, joins: Blueblaze
20090414 08:39:02-!- Netsplit niven.freenode.net <-> irc.freenode.net quits: |Andylee|, johani
20090414 08:39:29-!- Netsplit over, joins: |Andylee|, johani
20090414 08:41:17< corn> ok. I am gonna go to bed, I really really will update my timetable in the morning and submit the latest prototype code to the gsoc page :)
20090414 08:42:09< dfranke> heh... I've never used the test scenario before... it's silly :-)
20090414 08:44:08-!- Netsplit niven.freenode.net <-> irc.freenode.net quits: |Andylee|, johani
20090414 08:48:35< dfranke> Updated patch looks good.
20090414 08:49:07< dfranke> What's the policy on accepting patches from non-committers?  Can I commit it myself, or is boucman supposed to look at it first?
20090414 08:49:26< corn> someone else committed for me before
20090414 08:49:44< corn> forgot what the patch number was, it was the one about the really long message logs making the mp lobby pause
20090414 08:50:42< dfranke> Yeah but I think boucman still looked at it.
20090414 08:50:45-!- ettin_ [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev
20090414 08:50:58< corn> ok
20090414 08:51:11< corn> ok, good night
20090414 08:51:17< dfranke> nite corn.  good work.
20090414 09:00:07< JW1> we need a forum ban
20090414 09:00:12< JW1> and quickly please
20090414 09:01:19< dfranke> of whom?
20090414 09:01:31< dfranke> (I'm not an admin but I'll move the spam to the mod forum)
20090414 09:03:29-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)]
20090414 09:08:20-!- ancestral [n=martinpr@97-116-111-81.mpls.qwest.net] has quit []
20090414 09:11:57< Rhonda> Is https://gna.org/bugs/?13251 also fixed in 1.6.1?
20090414 09:15:15-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090414 09:17:19-!- turin [n=turin@168.215.250.1] has quit [Read error: 110 (Connection timed out)]
20090414 09:18:52-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090414 09:25:57-!- Mythological [i=Mytholog@77.28.91.230] has joined #wesnoth-dev
20090414 09:27:09-!- Synergizer [n=synergiz@c-75-73-225-141.hsd1.mn.comcast.net] has quit ["Leaving"]
20090414 09:28:29< silene> Rhonda: at the very least, alink's patch is in 1.6.1, so hopefully it is
20090414 09:32:24-!- ikarius [n=ross@216.27.182.3] has joined #wesnoth-dev
20090414 09:32:32-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 09:36:43< Rhonda> silene: What patch? I was away for a week so I can't make sense from your sentence. :)
20090414 09:40:38< silene> Rhonda: if you look at the bug report, the last comment was automatically generated by svn and indicates that the bugfix was applied to the 1.6 branch way before 1.6.1
20090414 09:41:03< Rhonda> Ah, that way round. Didn't check that part.
20090414 09:42:11-!- Mythological_ [i=Mytholog@77.28.91.230] has quit [Read error: 110 (Connection timed out)]
20090414 09:47:54-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."]
20090414 09:50:39-!- karl_m [n=u3468067@dubhe.anu.edu.au] has quit [""leaving""]
20090414 09:51:35-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has joined #wesnoth-dev
20090414 09:51:40-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 09:53:13-!- voris [n=voris@c-24-16-107-149.hsd1.wa.comcast.net] has quit ["Leaving"]
20090414 10:09:58-!- voris [n=voris@c-24-16-107-149.hsd1.wa.comcast.net] has joined #wesnoth-dev
20090414 10:19:30< CIA-30> dfranke * r34890 /trunk/ (4 files in 3 dirs): Accepted patch by cornmander implementing better semantics for sorting unit/recall list by XP. (bug #13360)
20090414 10:29:26-!- gabm [n=gabriel@72.0.215.2] has joined #wesnoth-dev
20090414 10:32:08< Ivanovic> moin
20090414 10:32:17< YogiHH> hi Ivanovic 
20090414 10:34:16< dfranke> Ivanovic: I committed corn's patch implementing FR #13360.  I believe he has now satisfied the requirements for being granted commit access.
20090414 10:37:09< gabm> hi YogiHH
20090414 10:38:17< gabm> YogiHH: Just to let you know: I updated my proposal page with the much-awaited proposal information
20090414 10:38:52-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090414 10:38:56< gabm> YogiHH: I also submitted a small (smallish?) patch implementing a feature request from EasyCoding. It's linked on my wiki
20090414 10:40:33< YogiHH> gabm: ok, thanks
20090414 10:40:36< gabm> YogiHH: The patch https://gna.org/patch/index.php?1162
20090414 10:40:51< gabm> YogiHH: and my wiki page: http://www.wesnoth.org/wiki/SummerOfCodeProposal_gabba
20090414 10:42:29-!- [voris] [n=voris@c-24-16-107-149.hsd1.wa.comcast.net] has joined #wesnoth-dev
20090414 10:42:44-!- [voris] [n=voris@c-24-16-107-149.hsd1.wa.comcast.net] has left #wesnoth-dev ["Leaving"]
20090414 10:44:29< CIA-30> ivanovic * r34891 /trunk/icons/ (wesnoth.desktop wesnoth_editor.desktop): make desktop entry compatible with freedesktop specification
20090414 10:44:31< CIA-30> ivanovic * r34892 /branches/1.6/icons/ (wesnoth.desktop wesnoth_editor.desktop): make desktop entry compatible with freedesktop specification
20090414 10:49:34-!- noy [n=Noy@d75-157-52-251.bchsia.telus.net] has joined #wesnoth-dev
20090414 10:50:26-!- noy [n=Noy@wesnoth/developer/noy] has quit [Client Quit]
20090414 10:54:05-!- |Andylee| [n=kvirc@188-23-3-153.adsl.highway.telekom.at] has joined #wesnoth-dev
20090414 10:54:05-!- johani [n=johani@c83-250-162-206.bredband.comhem.se] has joined #wesnoth-dev
20090414 10:54:34-!- xonev [n=chatzill@59.96.4.48] has joined #wesnoth-dev
20090414 10:56:13< CIA-30> ivanovic * r34893 /branches/1.6/CMakeLists.txt: categories= in cmake modified .desktop files were broken, a clean fix has to be done later...
20090414 10:58:20-!- Dragonking [n=dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20090414 11:00:09-!- gabm [n=gabriel@72.0.215.2] has left #wesnoth-dev []
20090414 11:07:58-!- loonybot [n=loonybot@79.139.246.210] has joined #wesnoth-dev
20090414 11:08:37-!- loonycyborg [n=sergey@79.139.246.210] has joined #wesnoth-dev
20090414 11:12:01-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090414 11:14:30< CIA-30> ivanovic * r34894 /trunk/CMakeLists.txt: categories= in cmake modified .desktop files were broken, a clean fix has to be done later...
20090414 11:18:23-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20090414 11:21:45-!- _Andylee_ [n=kvirc@188-23-109-51.adsl.highway.telekom.at] has joined #wesnoth-dev
20090414 11:22:48-!- Chusslove [n=caslav@brsg-d9befe19.pool.mediaWays.net] has joined #wesnoth-dev
20090414 11:34:39-!- ABCD [n=ABCD@wikipedia/ABCD] has quit ["No Ping reply in 30 seconds."]
20090414 11:34:52-!- euschn [n=chatzill@85-127-129-168.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20090414 11:34:58-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090414 11:34:59< euschn> hi
20090414 11:35:06< Crab_> hi
20090414 11:35:21-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev
20090414 11:41:24-!- |Andylee| [n=kvirc@188-23-3-153.adsl.highway.telekom.at] has quit [Read error: 110 (Connection timed out)]
20090414 11:43:45< YogiHH> Soliton: I tried to reproduce bug #13268 (save corruption due to undo/redo) but with no luck so far. Any ideas how to do that?
20090414 11:45:01< Crab_> Dragonking: around ?
20090414 11:46:26< Dragonking> Crab_: Yes?
20090414 11:47:22< Crab_> silene suggested that, when moving from src/ai* to src/ai/, we rename the file name to drop the "ai" prefix where it's not appropriate. what do you think about it ?
20090414 11:48:53< Crab_> (something like http://wesnoth.pastebin.com/m4742808a )
20090414 11:51:09 * YogiHH votes for keeping the names, as they can be easily confused with other files if the path information is missing
20090414 11:51:38 * Crab_ is in favor of keeping the names, too.
20090414 11:52:15< Dragonking> Yes, I'd keep them
20090414 11:53:47< dfranke> I vote against keeping them.
20090414 11:54:28< Soliton> YogiHH: well, as i mention there not really. :-/
20090414 11:54:59< dfranke> if the possibility of missing path information is enough to justify redundant prefixes, then we'd have to apply that to quite a lot of our tree, I think.
20090414 11:55:11< Soliton> dfranke: that's some funky game on the server there. it makes my wesnoth go crazy when observing.
20090414 11:55:30< loonycyborg> If it's decided to rename I vote for doing that in separate commit than moving to subdir :P
20090414 11:55:35< YogiHH> Soliton: Ok, then i will see if the replay information is of any help
20090414 11:55:37< dfranke> Soliton: think it's related to the earlier "mass hysteria" problem?
20090414 11:55:50< dfranke> Soliton: I didn't dare join it for fear of losing state.
20090414 11:56:58< Soliton> dfranke: no, it looks like the host somehow left as an observer. which is kinda difficult when he was the only player in the game... not sure what happened and as mentioned observing is not particularly helpful.
20090414 11:57:15 * YogiHH imagines people talking about actions.cpp on irc, getting really confused until they find out they talk about two different files ;-)
20090414 11:58:34< YogiHH> off for lunch
20090414 11:58:51< Soliton> though i should find out what scenario WML the client gets sent and see what's funny about that. there should at least be some server messages about control changes in there...
20090414 11:58:52< dfranke> Soliton: wow, trippy.
20090414 11:59:40< dfranke> heh, it's in such a tight loop I can't even quit.
20090414 11:59:51< Soliton> yeah, i had to kill -9.
20090414 12:00:38 * dfranke goes to bed
20090414 12:02:11< loonycyborg> YogiHH: There's similar organization in src/widgets. Does it cause much confusion? Should it be converted to suffixes :P
20090414 12:02:25< loonycyborg> *prefixes
20090414 12:05:18< Soliton> right, so the game didn't end because even though there were no players an observer left and observers don't end games... or so i thought.
20090414 12:09:12-!- wesbot changed the topic of #wesnoth-dev to: released 1.6.1, announcing "soon" | Summer of Code info: http://www.wesnoth.org/wiki/SummerOfCodeIdeas | 53 bugs, 234 feature requests, 11 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090414 12:10:18< Ivanovic> esr: could you have a look at mordantes revision 34822 and add it to pofix.py ?
20090414 12:10:41< Ivanovic> or do you not think that it qualifies as small typo fix but changes the meaning?
20090414 12:10:59< dfranke> Soliton: simply creating a game with no players and then killing the client doesn't seem to reproduce the problem thoug.
20090414 12:12:19< dfranke> oh, maybe if I do that with an observer...
20090414 12:12:30< Soliton> dfranke: what if you host a game with only AIs?
20090414 12:12:37< dfranke> meh, I'll look at it in the morning if you haven't worked it out yet.
20090414 12:12:40< dfranke> I need sleep.
20090414 12:12:45< Soliton> ok, sure.
20090414 12:14:41< Soliton> hmm, works as expected.
20090414 12:16:16< CIA-30> ivanovic * r34895 /trunk/po/wesnoth-anl/it.po: updated Italian translation
20090414 12:16:22< CIA-30> ivanovic * r34896 /branches/1.6/ (changelog players_changelog po/wesnoth-anl/it.po): updated Italian translation
20090414 12:16:56< Ivanovic> Crab_: when doing the "huge move" of the ai related files over to another folder, could you please update po/wesnoth/POTFILES.in and po/wesnoth-lib/POTFILES.in ?
20090414 12:17:16< Ivanovic> it should be rather obvious what to do there, just update the filenames/paths according to your change
20090414 12:17:21< Crab_> ok
20090414 12:18:20< Ivanovic> thanks
20090414 12:23:30< Crab_> Ivanovic: should I add those ai files which are not present there to POTFILES.in  ?
20090414 12:23:50-!- lizard_r [n=MirandaM@W9444.w.pppool.de] has joined #wesnoth-dev
20090414 12:24:10< Crab_> (only 6 of 11 AI .cpp files are present there )
20090414 12:24:44< Ivanovic> yes, add those missing files, too
20090414 12:25:22< Ivanovic> in general you could use utils/sanity-check to get an idea which files are missing, but atm those are *MANY*, so wading through the list and assigning the right domains is close to "real work"
20090414 12:25:24< Ivanovic> ;)
20090414 12:25:24< YogiHH> back
20090414 12:26:36< Crab_> Ivanovic: `ls src/ai/*.cpp | cat`  is just fine )
20090414 12:27:35< Ivanovic> Crab_: trust me, there are more files missing in POTFILES.in than just your ai files
20090414 12:27:36< Ivanovic> ;)
20090414 12:28:05< Crab_> Ivanovic: yes, but I want to update only ai files in *this* big commit )
20090414 12:28:06< Ivanovic> Missing from the POTFILE.in files: src/ai_actions.cpp src/ai_configuration.cpp src/ai_interface.cpp src/ai_manager.cpp src/formula_candidates.cpp src/hash.cpp src/save_blocker.cpp src/savegame.cpp src/scripting/lua.cpp src/sound_music_track.cpp src/storyscreen/controller.cpp src/storyscreen/interface.cpp src/storyscreen/page.cpp src/storyscreen/render.cpp
20090414 12:28:46< Crab_> Ivanovic: after I commit, I can add missing to POTFILE.in, and commit them again, of course
20090414 12:29:00< YogiHH> that's a pretty complete list of the lately added files :-P
20090414 12:29:17< Ivanovic> YogiHH: of course it is
20090414 12:29:22< Ivanovic> Crab_: just add the ai stuff
20090414 12:29:32< Crab_> ok
20090414 12:29:46< Ivanovic> i will have a look at the other stuff later, especially regarding which ones to move to wesnoth-lib (and add the corresponding define in the file)
20090414 12:30:14< YogiHH> Ivanovic: what's the definition of wesnoth-lib, btw?
20090414 12:30:45< Crab_> also, there are no ai files in wesnoth-lib, so, there's nothing to add there ....
20090414 12:31:05< Ivanovic> #define GETTEXT_DOMAIN "wesnoth-lib"
20090414 12:31:49< YogiHH> Ivanovic: ugh, ok, rephrasing: What is wesnoth-lib supposed to contain?
20090414 12:32:10< Ivanovic> hehe, stuff that (in the old days) was shared between game and editor
20090414 12:33:12< YogiHH> mmm, i see
20090414 12:33:31< Ivanovic> by now it is more of a plain "feeling thing"
20090414 12:34:20< Ivanovic> that is all of the gui stuff is in -lib (since it makes sense in there)
20090414 12:34:23< Ivanovic> as well as some other stuff
20090414 12:38:25-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 12:39:29< CIA-30> esr * r34897 /trunk/data/campaigns/Delfadors_Memoirs/scenarios/19_the_portal_of_doom.cfg: Clarifying comments.
20090414 12:39:35-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Remote closed the connection]
20090414 12:41:56-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 12:44:24< CIA-30> ilor * r34898 /trunk/ (7 files in 2 dirs): make the editor able to load maps referenced in scenario files and load and save maps embedded in scenario files. If you wanted to make just that little change in the test scenario's map, rejoice. Also some doc comments.
20090414 12:45:23< YogiHH> ilor: people will love you for that one :-)
20090414 12:45:52< ilor> YogiHH: amazing what a regexp can do ;)
20090414 12:46:36< ilor> I just hope nobody gets the idea that they can make a map and then do a save into a scenario file
20090414 12:49:36-!- alink [n=alink@wesnoth/developer/alink] has joined #wesnoth-dev
20090414 12:50:27< Crab_> Ivanovic: does "moving stuff around" require a changelog entry or not ?
20090414 12:50:34< zookeeper> ilor, awesome.
20090414 12:50:37< esr> ilor: I fear you have encouraged inline maps, which ain't such a good thing.
20090414 12:51:02< ilor> esr: not that much. You can't add a map into a scenario this way, and it's somewhat deliberate
20090414 12:51:11< zookeeper> ilor, maybe worth backporting to 1.6 if/when it's deemed stable enough?
20090414 12:51:17< esr> ilor: Good.
20090414 12:51:21< ilor> esr: only if you open a map with an inline map, "save" will replace it
20090414 12:52:05< ilor> zookeeper: I think yes, same about the --load enhancement and the next change I have ready
20090414 12:52:32< Ivanovic> Crab_: i don't think this requires a changelog entry
20090414 12:52:43< Crab_> good
20090414 12:52:46< Ivanovic> Crab_: though the "made ai modular" requires one
20090414 12:52:47< Ivanovic> ;)
20090414 12:53:04< YogiHH> uh, mean one :-)
20090414 12:53:11< Ivanovic> esr: saw my message 40mins ago?
20090414 12:53:20< Crab_> Ivanovic: ai is a module, but it is not modular at  the moment )
20090414 12:55:33-!- res|laptop [n=res@erft-4d07da5a.pool.mediaWays.net] has joined #wesnoth-dev
20090414 13:00:56-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 13:04:17< CIA-30> crab * r34899 /trunk/ (51 files in 4 dirs): 
20090414 13:04:17< CIA-30> Moved ai-related files to /src/ai/
20090414 13:04:17< CIA-30> Prefixes retained (at least for now).
20090414 13:04:28-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 13:08:59< Crab_> ^^ I've tried to fix 4 build configs ( SConscript Makefile.am CMakeLists.txt projectfiles/VC9/wesnoth.vcproj ), but, as I'm using only scons, i've not tested with other buildsystems. 
20090414 13:12:25 * alink is doing a svn up && make now
20090414 13:14:42< alink> it's make-building ai files
20090414 13:15:05< CIA-30> ilor * r34900 /trunk/ (6 files in 4 dirs): Editor: Moved the clipboard actions to a context menu available in paste mode. Added a terrain sampler feature -- ctrl+click when in paint or fill mode
20090414 13:15:26< Crab_> alink it may be a good idea to do a "clean" too. it depend on the buildsystem - some buildsystems may have problems with old object files around...
20090414 13:16:58< alink> I think it would worked, but ok let's try with a make clean first
20090414 13:17:11 * alink likes ccache
20090414 13:19:12< Crab_> alink:  *sometimes* file moves may lead to subtle glitches (linking to old file instead of using new [which succeeds as files are 'equal'], etc)
20090414 13:19:21-!- euschn [n=chatzill@85-127-129-168.dynamic.xdsl-line.inode.at] has quit [Read error: 60 (Operation timed out)]
20090414 13:20:25< alink> Crab_: well, i stopped the not-clean make before the linking phase, so I don't know if that was the case here
20090414 13:23:48-!- Gnutoo [n=gnutoo@host216-163-dynamic.51-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090414 13:23:53< alink> Crab_: the AI attack my units :)
20090414 13:25:42< loonycyborg> Good! It means that Crab_ is much better at not breaking AI than suokko :P
20090414 13:26:09-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 13:27:04< alink> Crab_: it also linked the new files (a change there has effect)
20090414 13:27:40< alink> ah, but with the make clean, so that's not an useful info
20090414 13:28:47< Crab_> good
20090414 13:32:32-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 13:35:14< CIA-30> alink * r34901 /trunk/src/pathfind.hpp: Remove dead member
20090414 13:36:34< Crab_> alink: why getNoPathValue() is of type double in src/pathfind.hpp ?
20090414 13:37:43< alink> an old thing, useless before but now some cost in A* are not integer, so probably better to keep it double
20090414 13:37:51< Crab_> ok
20090414 13:39:05< alink> + the cost function 2 lines above in pathfind.hpp use double too ;)
20090414 13:39:56< alink> but don't ask me why we use this 42424242.0 value
20090414 13:40:00< Crab_> alink: ai code uses integer for move cost )
20090414 13:40:10< Crab_> alink: that's quite clear - it is a magic number )
20090414 13:40:12< alink> (besides the 42 thing)
20090414 13:40:35< Crab_> "why 42" is well-known, and it is repeated to make it clear in the debugging session
20090414 13:41:11< Crab_> "42" is the default random seed for wesnoth, too
20090414 13:41:22< alink> ah yes indeed
20090414 13:42:44< alink> we must never tell that to RNG haters ;-p
20090414 13:44:26< AnMaster> <Crab_> "42" is the default random seed for wesnoth, too <-- you don't use time or such for random seed?
20090414 13:44:49-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev
20090414 13:44:53< Crab_> AnMaster: well, 42 is a "fallback" value, if something is wrong.
20090414 13:45:03< esr> AnMaster: Random dseeding is a bad idea if you want bugs to be reproducible.
20090414 13:45:12< alink> nooooooo, someone was listening, and start to ask about this RNG detail :-)
20090414 13:45:22< Crab_> alink: hehe )
20090414 13:45:46< AnMaster> esr, that's true. But it would create a greater variance in game play I guess.
20090414 13:45:47-!- euschn [n=chatzill@85-127-129-168.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20090414 13:46:01< AnMaster> and you could possibly record the seed in the save game or something I guess.
20090414 13:46:11< Crab_> AnMaster: actually, it would be used only when loading old savegames, which do not have this seed stored
20090414 13:46:18< AnMaster> aha
20090414 13:46:47< Crab_> and it is used only in "simple" random generator
20090414 13:47:19< AnMaster> "simple rng" makes no sense (kind of)
20090414 13:47:21< AnMaster> meh
20090414 13:48:14 * AnMaster imagines a biased prng that can be tuned to different difficulty levels
20090414 13:50:11< alink> Crab_: btw, I wonder is -1 would be better for getNoPathValue(), simpler to check, and could break things when misused 
20090414 13:50:53< Crab_> alink: it will be "easier to misuse, easier to check"
20090414 13:51:19< AnMaster> what exactly was the constant 42424242.0 for btw?
20090414 13:51:48-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Read error: 110 (Connection timed out)]
20090414 13:52:13< Crab_> alink: imagine : my_max = N;  path_value = get_path_value();   if(path_value < my_max ) { ...}
20090414 13:52:44< Crab_> so, when NoPathValue is BIG, that code is ok. when PathValue is -1, it breaks
20090414 13:53:06< alink> yes indeed, -1 is a bad idea, getNoPathValue()=42424242.0 is somehow supposed to represente infinite
20090414 13:53:18< alink> as often used in pathfinding algo
20090414 13:53:25< Crab_> alink: but we need (at least) to make it a public constant
20090414 13:53:26< alink> AnMaster: ^
20090414 13:53:36< AnMaster> (btw, when talking about constants, I remember some code that did "#define SECONDS_PER_MINUTE 60", my first reaction was "oh great, this code will be easy to adjust if that ever changes", but I guess it was done for clarity of the code)
20090414 13:54:22< alink> AnMaster: :-D
20090414 13:54:26< corn> AnMaster: I laughed at that
20090414 13:54:39< AnMaster> iirc esr was mentioned in the copyright header of that file
20090414 13:54:42< AnMaster> in the freebsd kernel
20090414 13:54:49< AnMaster> the pc-speaker driver thingy
20090414 13:55:06< esr> Yeah, thsat was me.  I hate magic numbers.
20090414 13:55:10< AnMaster> haha
20090414 13:55:23< alink> AnMaster: didn't we added a second the last minute of the last year ? So you needed a seconds_per_minute(date, time) function 
20090414 13:56:04< Crab_> alink - seconds_per_minute(date, time,date,time)
20090414 13:56:04< AnMaster> alink, well that would have need recompiling the kernel to change the define before and after in the current implementation ;P
20090414 13:56:15< esr> alink: No, the leap-second is not considered part of the preceding or following minute.
20090414 13:56:34< alink> so it's in between ?
20090414 13:56:37 * esr knows about this from working on GPS software.
20090414 13:56:47< alink> a 1-second minute then ?
20090414 13:57:01< AnMaster> esr, iirc GPS does not use leap seconds?
20090414 13:57:05< Crab_> we need to know "what did we think at "data1,time1" about the number of extra seconds at "date2,time2 ?"
20090414 13:57:05 * esr slaps alink with a fish
20090414 13:57:06< AnMaster> I may misremember
20090414 13:57:10< voris> No, it's not a minute either or you'd have a 61 minute hour.
20090414 13:57:19< voris> It just is.
20090414 13:57:23< AnMaster> a one second hour?
20090414 13:57:24-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 110 (Connection timed out)]
20090414 13:58:09< esr> AnMaster: GPS has a native time that isn't leap-second-corrected, yes.  The reason I know about this is exactly that my software has to convert to UTC.
20090414 13:58:16< AnMaster> aha
20090414 13:58:26< alink> Crab_: indeed, and that start to be much more complicated than "#define SECONDS_PER_MINUTE 60" :)
20090414 13:58:35< esr> Yup.
20090414 13:58:39< YogiHH> AnMaster: "42" is the ultimate answer to the question about the meaning of the universe but we weren't sure if it is compatible with the GPL license so we enlarged it a little ;-P
20090414 13:58:49< AnMaster> hah
20090414 13:59:13< Crab_> YogiHH: but isn't a "42424242" a derived work from "42" ?
20090414 13:59:13< AnMaster> and of course I know what 42 is :P
20090414 13:59:19< AnMaster> :D
20090414 13:59:28-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 13:59:29< alink> whaaat the ultimate answer to the question about the meaning of the universe is copyrighted ? dawned copyright laws
20090414 13:59:41-!- molgrum [n=molgrum@c83-249-53-163.bredband.comhem.se] has joined #wesnoth-dev
20090414 13:59:45< esr> You need to get the crrent leap-second offset from somewhere, either your GPS satellite (but some GPSes don't make this available in there reports) or as an (ugh) magic constant.
20090414 14:00:02< esr> s/there/their/
20090414 14:01:17< AnMaster> esr, but isn't the insertion of leap seconds based on observation of how much off UTC is? Rather than a pre-defined formula
20090414 14:01:22< AnMaster> I may misremember that though
20090414 14:01:47-!- irmorelle [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20090414 14:02:17< esr> AnMaster: You're correct.. The International Earth Rotation Service (bunch of geophysicists in Paris) issues bulletins every six months at minimum.
20090414 14:03:05< AnMaster> esr, so how would a magic constant help? I mean it sound more like something that would need to be forever updated like the /usr/share/zoneinfo stuff
20090414 14:04:02-!- Dragonking [n=dk@wesnoth/developer/dragonking] has quit []
20090414 14:04:11-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has quit ["Lost terminal"]
20090414 14:04:19< Crab_> AnMaster: new software versions can include a new magic constant
20090414 14:04:21< esr> AnMaster: Heklps only in the rate case that (1) Your GPS doesn't internally correct to UTC, (2) You can't get UTC through subframe reports.  
20090414 14:04:36-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20090414 14:04:36< AnMaster> esr, hm o
20090414 14:04:40< AnMaster> ok*
20090414 14:04:48< esr> I only know of one GPS chip family that has this issue.
20090414 14:05:44-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has joined #wesnoth-dev
20090414 14:05:49< irmorelle> silene: um, what Sapient said is what I (and apparently Mordante too) were trying to say :P
20090414 14:06:16-!- ABCD_ is now known as ABCD
20090414 14:06:19< Shadow_Master> silene: I suppose we fail at English too :P
20090414 14:06:26< zookeeper> esr, so how should save confirmation work then? http://gna.org/bugs/?13364
20090414 14:06:32-!- irmorelle is now known as Guest11675
20090414 14:06:41< Reisiger> Good afternoon everyone :)
20090414 14:06:42-!- Guest11675 [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit]
20090414 14:07:28< esr> zookeeper: It's not a confoirmation prompt, just a pupup notification that conveys no information but must be dismissed with a click.  (I hate those.)
20090414 14:07:36< Shadow_Master> AnMaster: no, there's nothing special about that coffin. It's just that... a coffin.
20090414 14:07:55< AnMaster> Shadow_Master, why is it there then?
20090414 14:08:18< Shadow_Master> Unfinished idea.
20090414 14:08:39< AnMaster> ah
20090414 14:09:07< AnMaster> Shadow_Master, I ran into a minor bug in that escape from knalga scenario
20090414 14:09:08< zookeeper> esr, oops, i misread the report
20090414 14:09:10< YogiHH> hi Reisiger
20090414 14:09:37< corn> anyone have any miscellaneous programming bugs they need fixed or confirmed?
20090414 14:09:41< AnMaster> Shadow_Master, after I killed that final opponent near the end of the level, the objectives didn't update again
20090414 14:09:43< AnMaster> to say reach end
20090414 14:09:56-!- lizard_r [n=MirandaM@W9444.w.pppool.de] has quit ["I'm gone, but the Saurians will last."]
20090414 14:10:17< alink> corn: any specific area ?
20090414 14:10:19< AnMaster> not sure if that was intentional or not
20090414 14:10:20< Shadow_Master> AnMaster: noted
20090414 14:10:31< Shadow_Master> I'll cmmit a fix shortly
20090414 14:10:34< AnMaster> Shadow_Master, I could however complete level by moving to the top of the level
20090414 14:10:36< corn> alink: no, but keep in mind that I don't have extensive experience with the wesnoth code
20090414 14:10:38< AnMaster> so I'd say it is minor
20090414 14:11:12< AnMaster> Shadow_Master, I'm going afk for an hour or so, bbl.
20090414 14:11:33< YogiHH> corn: I'd be careful to make such offers. I did that a couple of times and regretted every single one ;-)
20090414 14:12:41< corn> lol
20090414 14:13:37< esr> corn: YogiHH would probably be grateful if you fixed  bug #13364 (Superflous modal "Game has been saved" pop-up on end of scenario), and it should be easy.
20090414 14:13:40< Reisiger> corn: And if you pick something you want to improve... you might end up realising that you can only make minor ones to the existing code... like me and the calculate_healing function :D
20090414 14:14:03< Reisiger> *minor improvements
20090414 14:14:27< alink> bug #13364: Superflous modal "Game has been saved" pop-up on end of scenario.   Is possibly a copy-paste job, just need to find what copy and where paste it
20090414 14:14:47< corn> reading now
20090414 14:15:27< alink> ah no sorry already assinged to YogiHH
20090414 14:15:35< Shadow_Master> AnMaster: fixed now in r4441 (1.6) and r4442 (trunk), thanks; but if you want to do more reports, do them in #wesnoth or #wesnoth-umc-dev to avoid interrupting these crazy devs
20090414 14:15:39< Shadow_Master> ;-)
20090414 14:15:45< corn> YogiHH: can I take that bug from you?
20090414 14:16:01< esr> corn: I assigned it to him.  You can.
20090414 14:16:08< corn> ok
20090414 14:16:14< corn> what does the comment me
20090414 14:16:18< corn> 'this is from the replay save'
20090414 14:16:20< corn> mean*
20090414 14:16:53< esr> Means YogiHH told me the notification popup is caused by the end-of-scebario replat save.
20090414 14:17:09< corn> ah
20090414 14:17:10< corn> ok
20090414 14:17:13< esr> s/scebario replat/screnario replay/
20090414 14:18:16 * esr thinks he's about to improve TerrainWML.
20090414 14:18:26< Shadow_Master> esr: please tell me exactly how and why
20090414 14:18:34< alink> corn: mmh if you need to check the replay/save code, then that's maybe more complicated that I thought. I assumed that someone just called the bad dialog function
20090414 14:18:37< corn> can I get a savegame of a scenario about to end?
20090414 14:18:51< corn> so I can replicate/test
20090414 14:19:02< YogiHH> corn: yes, you can take that one from me
20090414 14:19:07< alink> (as it did for similar bugs in the past)
20090414 14:19:11< corn> please attach to the bug
20090414 14:19:15< corn> oh
20090414 14:19:23< corn> woops, thought you were talking about the save and not the bug :p
20090414 14:19:30< esr> (1) There's an ambiguity as to whether [terrain] is a reference or definition tag - one use should be renamed for netter sanity checking .  This is a pure syntactic issue.
20090414 14:19:39< esr> s/netter/better/
20090414 14:20:02< corn> hm. maybe I can replicate on the test scenario
20090414 14:20:07< YogiHH> corn: the code calling it is in play_campaign.cpp (you should be able to find it searching for "replay_savegame")
20090414 14:20:14< corn> ok, thanks
20090414 14:20:25-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 14:20:36< Shadow_Master> esr: the definition should probably be renamed terrain_type to match unit_type
20090414 14:21:04< Reisiger> Q: Anyone having an issue with menu.cpp when compiling the latest revision?
20090414 14:21:19< YogiHH> corn: the relevant member is probably "interactive_"
20090414 14:21:27< YogiHH> afk
20090414 14:21:41< esr> (2) The new forest varieties aren't explauined or revealed well in the game and map displays. Furthermore, "name" is not just a doc string, it conveys info about the base terrain type.  I contemplate adding a "description" field that would be used for tooltips in the editor, e.g "Mixed Summer Forest".
20090414 14:22:12< esr> Shadow_Master: Agreed about the rename, I had the same thought.
20090414 14:22:51< esr> Neither enhancement will be very intrusive.
20090414 14:24:35< YogiHH> back
20090414 14:24:43-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Success]
20090414 14:25:17< corn> ah, I can replicate #13364 using the test scenario. very nice
20090414 14:31:22< CIA-30> esr * r34902 /trunk/data/tools/wmllint: Fix incorrect comment.
20090414 14:32:28< esr> corn: Once you get that one, I have a couple other small easy bugs I can toss you.  I do a lot of the bug triage and bug tracker cleanup.
20090414 14:32:53< Reisiger> Q: menu.cpp lines 156/157. Had to chance char *slash(1|2) = ... to const char* slash(1|2) to get it to compile. Does anyone else have a compiler error without those changes? If not that might be MSVC specific.
20090414 14:33:17< corn> nope, works for me on gnu gcc
20090414 14:33:21< corn> I was the author of that patch
20090414 14:33:28< esr> Reisiger: A: Nope, no issue here with GCC.
20090414 14:33:40 * Reisiger slaps MSVC for being 'special' again
20090414 14:33:47< Shadow_Master> WAIT...
20090414 14:34:14< esr> Uh oh, Shadow_Master is using the Voice of Doom again...
20090414 14:34:16< Shadow_Master> argh, oops, wrong channel and caps
20090414 14:34:20< corn> esr: ok, I think I've fixed it.
20090414 14:34:23< corn> one line fix
20090414 14:34:26< Reisiger> o_O
20090414 14:34:43< esr> corn: Thought it would be.  Hold on, let me test.
20090414 14:34:50< corn> let me upload the patch
20090414 14:35:03< esr> Right.
20090414 14:35:10< YogiHH> corn: please also cross-check if the manual replay save gets a confirmation
20090414 14:35:22< esr> YogiHH: Will do.
20090414 14:35:33-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 14:36:02< Reisiger> esr, corn: I'm doing a rebuild on MSVC. If there's no errors I'll make a patch and upload it to the forum. Can the two of you please verify that menu.cpp with that cmall change still works for you?
20090414 14:36:36< esr> corn: That's your next one.  (I need to go hack the terrain sybtax.)
20090414 14:37:20< corn> ok, patch uploaded to the bug
20090414 14:37:32< esr> corn: Checking...
20090414 14:38:07< CIA-30> ivanovic * r34903 /trunk/po/wesnoth/POTFILES.in: add missing source files to POTFILES.in
20090414 14:38:43< corn> hm
20090414 14:38:55< corn> not working actually
20090414 14:38:58< corn> no replay file saved ):
20090414 14:40:30< corn> actually, it is working but not saving to the right file
20090414 14:40:44< esr> Well, fixit it :-)
20090414 14:41:44< Turuk> crimson_penguin: could you ping me when you are around? Thanks.
20090414 14:42:57< corn> what is the point of this? :
20090414 14:43:02< corn>         filename_ = filename;
20090414 14:43:02< corn>         if (!interactive_)
20090414 14:43:02< corn>                 create_filename();
20090414 14:43:09< corn> the function takes in filename as a parameter
20090414 14:43:16< corn> void savegame::save_game(const std::string& filename)
20090414 14:44:03< CIA-30> esr * r34904 /trunk/src/playcampaign.cpp: Bug #10077 is marked Fixed, so make the code simplification indicated here.
20090414 14:44:12< Rhonda> hihi, received a mail from dfranke through the GSoC list. ;)
20090414 14:46:21< corn> ok
20090414 14:46:23< corn> just to verify
20090414 14:46:36< corn> the intended behavior is to save a file ending in _replay.gz ?
20090414 14:46:59< corn> right now with my working patch I open the test scenario, get Auto-Save1.gz
20090414 14:47:04< corn> then I win the scenario, end it
20090414 14:47:15< corn> and get an additional save, _replay.gz
20090414 14:47:20< corn> is that correct?
20090414 14:47:28< YogiHH> corn: yes
20090414 14:47:35< corn> ok, cool
20090414 14:47:38< corn> then the patch is done
20090414 14:47:40< corn> uploading now
20090414 14:47:47< YogiHH> corn: filename_ needs to be set, because it is used later in another context
20090414 14:49:09< YogiHH> corn: when the parameter is no longer available
20090414 14:49:26< corn> save.save_game("");
20090414 14:49:34< CIA-30> silene * r34905 /trunk/src/widgets/menu.cpp: Fixed const-ness of strchr result.
20090414 14:49:41< corn> that's what I changed the existing line to
20090414 14:49:56< corn> in this context, the filename is not used because the display is not interactive
20090414 14:50:11< corn> acceptable?
20090414 14:51:55< YogiHH> corn: i think so. Do the saves have a scenario specification in front of "replay" and "Autosave"?
20090414 14:52:01< corn> yes
20090414 14:52:11< YogiHH> ok, then it should be fine
20090414 14:52:27< corn> -rw-r--r-- 1 corn corn 19739 2009-04-14 08:47 Test_scenario_replay.gz
20090414 14:52:27< corn> -rw-r--r-- 1 corn corn 44887 2009-04-14 08:47 Test_scenario-Auto-Save1.gz
20090414 14:52:40< Reisiger> silene: Thanks :) That also fixed the MSVC compile error
20090414 14:53:03< YogiHH> corn: looks good :-)
20090414 14:53:11< corn> ok, patch submitted
20090414 14:53:38< corn> esr: what's the next bug on the list? I fixed the patch and the issue with the code not compiling is also fixed
20090414 14:53:38< YogiHH> will have another look at it when i get back from work
20090414 14:53:50< corn> at work now?
20090414 14:53:59< YogiHH> yup
20090414 14:54:02< esr> corn: Where's the new patch?
20090414 14:54:21< corn> https://gna.org/bugs/index.php?13364
20090414 14:54:27< corn> attachment #5629
20090414 14:55:42< esr> corn: Try to reproduce bug #13275 (Turn Bell Not Functioning).  If you can, fix it.
20090414 14:56:39-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Connection timed out]
20090414 14:57:15 * Reisiger finds it strange that Tortoise thinks there's a conflict if I did the exact same changes as have been done in a new revision.
20090414 14:58:20< YogiHH> Reisiger: I experienced that, too. I suspect it might have to do with non-visible characters like line endings and such
20090414 14:58:21< CIA-30> esr * r34906 /trunk/src/playcampaign.cpp: Fix for bug #13364 from corn.
20090414 14:58:53-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090414 14:58:55< corn> cool
20090414 14:58:58< corn> I am able to reproduce
20090414 14:59:06< esr> Great.  
20090414 14:59:23< corn> actually, no
20090414 14:59:25< corn> what I get is that
20090414 14:59:29< Soliton> esr: would it be difficult to implement a wmllint parameter to unleash all (likely) appropriate conversions on a savegame instead? (i'm thinking converting start-of-scenario saves have a pretty good chance to just work then..)
20090414 14:59:39< corn> turning off the turn bell during a game then turning it off does not reenable it
20090414 14:59:47< corn> the turn bell stays off regardless of the sound effects setting
20090414 14:59:48< esr> Soliton: Hmmm.
20090414 15:00:21< esr> I don't see any reason wmllint wouldn't work on savegames as is.  It's just WML, after all.
20090414 15:00:40< Soliton> ok, i was wondering if that is even the case.
20090414 15:01:06< Reisiger> YogiHH: not surprising... I'm still looking for a setting in tortoise to have eol's converted to native o_O
20090414 15:01:27< YogiHH> Reisiger: msvc has that
20090414 15:01:31< AnMaster> Reisiger, set svn:eol-style property iirc?
20090414 15:01:57< AnMaster> for tortoise I think you select file properties and then change to another tab where you can do it
20090414 15:02:06< esr> Soliton: Best would be to try conversions on some real savegames and look at diffs to ensure wmllint isn't getting overzealous about anything.
20090414 15:02:16< Reisiger> YogiHH: MSVC does that automatically, including eating all whitespace ;)
20090414 15:02:16< AnMaster> but it was years ago I last used windows, so it may have changed and/or I may have misremembered
20090414 15:02:28< YogiHH> hehe
20090414 15:02:31< Soliton> esr: yeah, currently looking if i still have a save i had in mind.
20090414 15:02:41< esr> corn: That sound like te bug as I understand it.
20090414 15:03:32< Reisiger> AnMaster: I'll have a look. It should read the settings from the ./svn folders... and I remember that in a recent revision the svn:eol-style has been set to native there
20090414 15:04:07< esr> zookeeper: Re bug #13242: graphics bug with shaman/forest/orc scout.  Shall I mark that "Wont Fix"?  I'd like to get it off the tracker before we tag for 1.7.1.
20090414 15:04:16< corn> bingo, I've figured out how to reproduce
20090414 15:04:24< AnMaster> hm ok
20090414 15:04:30< corn> if you turn off sound effects and turn bell and then only turn on turn bell, it won't play
20090414 15:04:38< AnMaster> Reisiger, but doesn't that only affect the default properties of new files?
20090414 15:04:41-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has joined #wesnoth-dev
20090414 15:05:10< Reisiger> it should influence updates and making patches...
20090414 15:05:11< esr> corn: That sounds like it might be a Wont Fix.  :-)
20090414 15:05:26< corn> is the turn bell a subset of 'sound effects'?
20090414 15:06:05< corn> it's definitely unintuitive for there to be a checkbox with a hidden dependency on another checkbox
20090414 15:06:09< esr> corn: I think wee get to chose that now.  Since it has a separate option, I'd say "no".
20090414 15:06:35< corn> esr: then it is a bug that changing sfx affects the turn bell
20090414 15:06:39-!- Polarina [n=polarina@wesnoth/translator/Polarina] has joined #wesnoth-dev
20090414 15:06:55< esr> corn: Yeah, I'm inclined to think so.
20090414 15:07:10< zookeeper> esr, actually i'd rather keep that open. it is a real issue that can be fixed, it's just pretty complicated and i don't want to try to do that in the immediate future.
20090414 15:07:18< esr> OK.
20090414 15:07:24< corn> ok, I'll find the relevant area on the code. do you have any idea where it is?
20090414 15:07:41< zookeeper> esr, i'll add my comment there..
20090414 15:07:49< zookeeper> (and mark as postponed)
20090414 15:07:57< esr> zookeeper: Thanks, I was going to ask you to do that.
20090414 15:08:04< YogiHH> corn: either preferences.cpp or game_preferences.cpp
20090414 15:08:13< corn> ok, thanks
20090414 15:08:18< YogiHH> corn: not sure if the dialog is in there as well, might be separated
20090414 15:09:26< corn> yep, relevant area of the code is probably preferences.cpp:364
20090414 15:11:34< Polarina> In my code, everything's line 1.
20090414 15:12:12< YogiHH> Polarina: it's a short code, then :-D
20090414 15:12:22< alink> or a long line :)
20090414 15:12:32< Soliton> esr: doesn't look like wmllint is doing anything.
20090414 15:12:37< Polarina> YogiHH: No, that's just failed usage of proper indentation.
20090414 15:12:44 * esr wonders if Polarina is writing APL
20090414 15:13:14< esr> Soliton: That's not unusual. What do you expect it to be doing?
20090414 15:13:34< Soliton> esr: converting stuff.
20090414 15:13:48< Soliton> esr: does it chechk for .cfg extension or so?
20090414 15:13:55< Polarina> esr: C and C++
20090414 15:14:13< Soliton> esr: in case you forgot i'm talking about converting a savegame.
20090414 15:14:18-!- BenUrban [n=benurban@unaffiliated/benurban] has quit [Remote closed the connection]
20090414 15:14:43< esr> Soliton: Oops...I think it does check for .cfg.  That's an issue.  Let me look into it.
20090414 15:18:54< esr> Soliton: Yes, it does.  Now let me think about how to change that while preserving the right behavior on directories.
20090414 15:20:21< Ivanovic> esr: by creating a script callled "savegameconvter"
20090414 15:20:32< Soliton> esr: a simple parameter to turn that check off would be good enough for me. it's probably nothing that needs to be generally enabled.
20090414 15:20:58< esr> Ivanovic: Nah, that's too complicated.  Better fix in progress.
20090414 15:20:59< Ivanovic> that takes a savegame as param, extracts it if required, renames to FILENAME.cfg, runs wmllint and afterwards compresses again to FILENAME.gz
20090414 15:21:15< Polarina> .cfg.lzma  :P
20090414 15:25:54< corn> esr: ok, bug fixed
20090414 15:25:56-!- nerwa [n=nerwa@icis.sjtu.edu.cn] has quit [Remote closed the connection]
20090414 15:25:58< corn> another 1 line change
20090414 15:27:02< esr> corn: OK. Now, if you would, try to reproduce bug #13239: Clicking on the Send statistics-button crashes the game.  Fix if you can reproduce.  
20090414 15:27:17< corn> ok, gonna upload tihs one first though
20090414 15:28:25< esr> Soliton: I'm working on your issue.
20090414 15:28:51< corn> hm
20090414 15:28:59< corn> I wonder why my firefox dictionary is set to british english
20090414 15:29:02< corn> and not american english
20090414 15:29:15< Soliton> esr: cool.
20090414 15:30:25-!- crimson_p [n=irchon@64.201.60.216] has joined #wesnoth-dev
20090414 15:30:34< esr> Soliton: It won't be a lot of work to make wmllint do the right thing on savefiles, I've already written the right file-typre predicate.  Automatically handling compression is what I'm looking into now.
20090414 15:30:56-!- crimson_p [n=irchon@64.201.60.216] has quit [Remote closed the connection]
20090414 15:32:25< Soliton> esr: ah, that would be nice indeed.
20090414 15:32:31< esr> Soliton: Hah.  This'll be easier than I though.  Python *so* rocks...
20090414 15:37:01< AnMaster> sorting in recall by xp seems broken now
20090414 15:37:27< AnMaster> I mean I sorted to get lowest xp at top, but first is one with three then one with zero
20090414 15:37:44< AnMaster> wasn't broken like this yesterday
20090414 15:37:50< corn> esr: unable to reproduce the bug under svn trunk
20090414 15:37:57< Soliton> it goes by maxXP - XP now, i think.
20090414 15:38:06< esr> corn: Hm.
20090414 15:38:14< AnMaster> Soliton, well what if I prefer the old way? Because this way seems confusing
20090414 15:38:22< AnMaster> I mean it isn't clear what is going on
20090414 15:38:31-!- busfahrer` [n=busfahre@ulmg-5f70ded6.pool.einsundeins.de] has joined #wesnoth-dev
20090414 15:38:37< AnMaster> to the user
20090414 15:38:46< esr> corn: Where is the turn bell patch?
20090414 15:38:55< corn> it is attached to the bug
20090414 15:39:14< AnMaster> Soliton, the only sane way is to sort by whatever value is displayed. If you want to sort to something else display something else too
20090414 15:39:17< corn> http://gna.org/bugs/?13275
20090414 15:39:52< Soliton> AnMaster: complain loudly, provide a patch, start to cry/curse, revert the change locally... a lot of possibilities.
20090414 15:39:55< esr> corn: Got it, wait one...
20090414 15:40:24< AnMaster> Soliton, hah. Who did this change btw?
20090414 15:40:32< corn> ok, I've attached to to the CC list for the unreproducible bug as well
20090414 15:40:39< corn> attached you*
20090414 15:41:36< Soliton> AnMaster: there is some FR in the bug tracker, i think.
20090414 15:41:46-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Nick collision from services.]
20090414 15:41:50< CIA-30> esr * r34907 /trunk/data/tools/wesnoth/wmltools.py: 
20090414 15:41:50< CIA-30> Wesnoth WML tools module now has an issave() entry pointy that detects
20090414 15:41:51-!- busfahrer` is now known as busfahrer
20090414 15:41:51< CIA-30> savefiles, including compressed savefiles.
20090414 15:41:53< AnMaster> Soliton, FR standing for?
20090414 15:42:29< esr> corn: I'll apply that, then we'll talk about the send-stats bug.
20090414 15:43:19< corn> ok
20090414 15:43:29< YogiHH> AnMaster: Feature Request
20090414 15:43:35< AnMaster> ah
20090414 15:44:10< AnMaster> anyway it seems rather confusing to the user, there is no indication of why the sort is "messed up"
20090414 15:45:08< AnMaster> I'm not saying the new system is a bad idea, I can live with it. What I have a problem with is that there is no indication of that it is the difference between current and max that is used for sorting.
20090414 15:45:28< CIA-30> esr * r34908 /trunk/src/sound.cpp: 
20090414 15:45:28< CIA-30> Turn bell has a separate preference option, so it should be orthogonal
20090414 15:45:28< CIA-30> to sound effects. Fixes bug #13275: Turn Bell Not Functioning.
20090414 15:45:28< CIA-30> Patch by corn.
20090414 15:45:45< Ivanovic> AnMaster: and in how far was it clearer before the change?
20090414 15:46:03< AnMaster> Ivanovic, well it sorted numerically by first number in xp column
20090414 15:46:08< AnMaster> that is quite easy to see
20090414 15:46:29< Ivanovic> i think "hey, this unit is closer to leveling than that one" is easy to see, too
20090414 15:46:30< AnMaster> but the new one doesn't sort by any visible value.
20090414 15:46:30< Ivanovic> ;)
20090414 15:46:49< corn> AnMaster: I was responsible for your anguish :)
20090414 15:47:07< corn> the new way of sorting is that it sorts by level first and then by y minus x
20090414 15:47:08< AnMaster> Ivanovic, not without calculator and/or paper+pen
20090414 15:47:13< corn> where x/y is the exp fraction
20090414 15:47:15< AnMaster> ;)
20090414 15:47:31< corn> you will always get the highest level units first
20090414 15:47:38< corn> and they will be subsorted by how close they are to leveling
20090414 15:47:45< corn> the old way didn't even tell you how close a unit was to leveling anway
20090414 15:47:45< AnMaster> corn, what if I sort level in reverse order?
20090414 15:47:52< corn> you will get the lowest level unit first
20090414 15:47:58< AnMaster> right
20090414 15:48:37< AnMaster> corn, I'm not saying new system is bad, just that it isn't obvious to the user what is happening.
20090414 15:48:45< corn> hm
20090414 15:48:51< corn> that might be true
20090414 15:49:18< corn> I suppose a somewhat more intuitive alternative would be to make the exp column sort by closeness to leveling
20090414 15:49:26< corn> and move the existing behavior to the level column
20090414 15:49:26< Ivanovic> IMO it is as clear as the old way
20090414 15:50:05< esr> corn: I've classified the send-stats bug as an upstream problem.  Are you good with gdb?
20090414 15:50:23< corn> esr: sure, but I haven't used it on threaded applications
20090414 15:51:03< corn> Ivanovic: he's right though. if you click the exp column you won't really have any idea what it is sorting by until you look at the level column as well
20090414 15:51:17< esr> corn: The threading isn't normally a big issue when gdbing Wesnoth, you should be OK.  Hold on, I'm finding you another bug...
20090414 15:51:34< corn> I've got to go soon, add me to the CC list for it and I'll look at it later
20090414 15:51:38< AnMaster> corn, and do max-cur
20090414 15:51:51< corn> AnMaster: max-cur?
20090414 15:51:55< AnMaster> err
20090414 15:52:00< AnMaster> didn't you say it was like that?
20090414 15:52:03< corn> yes
20090414 15:52:07< corn> oh, sorry, didn't understand
20090414 15:52:08< corn> y-x
20090414 15:52:09< AnMaster> "and then by y minus x"
20090414 15:52:10< esr> corn: OK.  Note, three bugs in one session is pretty good going.
20090414 15:52:25< AnMaster> corn, I assume y = exp for leveling and x = current exp?
20090414 15:52:32< corn> AnMaster: yeah, that's correct
20090414 15:52:33< AnMaster> or did I misinterpret you
20090414 15:52:47< corn> esr: two one line bugs and one unreproducible one :p
20090414 15:52:56< corn> AnMaster: no, that is correct
20090414 15:53:01< AnMaster> k
20090414 15:53:24< corn> I will change the sorting behavior so that sort by xp is done with y-x and then move the existing functionality to the level column
20090414 15:54:27< corn> Ivanovic , esr: how many more patches until I meet the 2 patches and you're in requirement?
20090414 15:54:37< esr> corn: That's still better than I do lots of days, and I'm not bad at this.  Got your next one: bug #13094: Game hangs at exit if summary upload server is unreachable.  You may need to change the timeout or so dome sort of thread launch so the exit doesn't block.
20090414 15:54:51< corn> esr: I am already addressing that one
20090414 15:54:55< corn> the changes for it are substantial
20090414 15:55:06< corn> the issue is that there is an OS dependent TCP timeout
20090414 15:55:09< corn> no way to change it in wesnoth
20090414 15:55:20< corn> my solution is to move stats uploading into a seperate binary and fork/exec
20090414 15:55:33< Crab_> corn: but you can add your own timer 'on top'
20090414 15:55:40< corn> the wesnoth client can then cleanly exit and you get a small binary that will run or hang
20090414 15:55:43< corn> no, you can't
20090414 15:55:48< Crab_> why ?
20090414 15:55:48< corn> you could but it would be a mess
20090414 15:55:52< corn> the code is blocking
20090414 15:55:59< Crab_> in a new thread, of course
20090414 15:56:04< corn> yep, tried it
20090414 15:56:08< esr> corn: Sounds like your make-your-bones patch to me.  Fix that And I'll ask Ivanovic to give you privs - I like the idea of having someone to work with who likes bug-chasing.
20090414 15:56:33< corn> esr: I have a patch handy already, but it's only the posix half
20090414 15:56:41< corn> windows has different mechanics for fork/exec
20090414 15:56:54< corn> I don't have a windows development environment where I can create it, but dfranke said he will handle it
20090414 15:57:03< esr> corn: I see.
20090414 15:57:04< corn> I'll get a diff ready and upload it to the bug
20090414 15:57:07< YogiHH> *phew*
20090414 15:57:16< esr> corn: OK.
20090414 15:57:25< esr> YogiHH: What's up?
20090414 15:57:29< corn> Crab_: if you put it into a seperate thread, you would have to kill the thread
20090414 15:57:35< corn> I did that and got a strange pthreads related error
20090414 15:57:36 * YogiHH doesn't want to have anything to do with this low-level stuff ;-)
20090414 15:57:48< corn> there is no way to make it gracefully exit the thread once it blocks
20090414 15:58:10< Crab_> corn: yes. but we are exiting wesnoth anyway at that point, isn't it ?
20090414 15:58:41< corn> Crab_: the upload code isn't executed on wesnoth exit though, it's executed on scenario end
20090414 15:58:56< Crab_> corn: ah. that's another matter, then.
20090414 15:58:56< corn> it's just that you can't tell that it's hanging until the game exit
20090414 15:59:13< corn> so if you made a timeout it would segfault the game when it matters
20090414 15:59:22< corn> but I don't want to make the game segfault by default anyway
20090414 15:59:24< Crab_> corn: yes, if it isn't 'at the end of wesnoth', a separate binary would be indeed better
20090414 15:59:46< YogiHH> corn: maybe we can store that somewhere and process at the title screen after the game returned?
20090414 15:59:58< corn> YogiHH: not sure what you mean
20090414 16:00:05< corn> YogiHH: store what? the logs?
20090414 16:00:21< corn> currently the logs are saved and uploaded seperately
20090414 16:00:27< corn> which is why making a seperate binary wasn't that difficult
20090414 16:00:27< YogiHH> corn: you said it is executed on scenario end. Can't we delay that?
20090414 16:00:33< corn> YogiHH: yes, you can
20090414 16:01:07< YogiHH> corn: but?
20090414 16:01:15< Soliton> there is never a time the user can't just exit wesnoth so how does that help?
20090414 16:01:34< corn> YogiHH: if you do make it a seperate thread and kill() it you end up with a segfault
20090414 16:02:02< corn> it would be better if the game *didn't* crash on exit
20090414 16:02:04< corn> especially intentially
20090414 16:02:09< corn> intentionally*
20090414 16:02:25< YogiHH> well, that's a point indeed :-)
20090414 16:02:25< euschn> i just read corn mentioning a "2 patches and youre in" requirement - is this with regard to gsoc, and I have I missed some update on that?
20090414 16:02:27< corn> although maybe my implementation was poor
20090414 16:02:39< esr> zookeeper: Who is in charge of terrain transition graphics?  I'm wondering how to assign bug #13363
20090414 16:02:44< Shadow_Master> euschn: it is s general policy
20090414 16:02:49< YogiHH> euschn: no, that is not related to GSoC
20090414 16:03:03< Shadow_Master> euschn: GSoC or not, ny one that contributes 2 nontrivial patches can be made a dev
20090414 16:03:09< Shadow_Master> *any
20090414 16:03:10< esr> euschn: No, that's our informal non-GSOC policy for how you earn dev access.
20090414 16:03:26< corn> euschn: the idea that I got was that submitting patches will definitely help you with gsoc
20090414 16:03:31< euschn> ah right, thanks for the clarification
20090414 16:03:47< corn> it's also good because you learn the organizational details
20090414 16:04:02< euschn> corn: of course
20090414 16:04:23< corn> anyway, I am going to fix my long delayed timeline
20090414 16:04:40< zookeeper> esr, i don't know who of the currently active devs would know that stuff better than me.
20090414 16:04:59< esr> zookeeper: Well, I'll assign iyt to you then.
20090414 16:05:31< zookeeper> esr, sure, fine. maybe there's a small chance that it'll actually be more simple to fix that i think.
20090414 16:05:38< esr> zookeeper: Oh, I see your comment.  Shall I mark it Wont Fix?
20090414 16:06:05< corn> esr: someone should try reproduce on win 2000 before the bug gets shifted upstream
20090414 16:06:14< zookeeper> esr, nah, i can mark it so after i've taken my second look
20090414 16:06:16< corn> I remember playing with the statistics settings on vista and it being fine
20090414 16:06:26< esr> zookeeper: OK.
20090414 16:06:50-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has quit ["Verlassend"]
20090414 16:07:27< esr> corn: I believe you.  That uncreases the chance that "Upstream" is accurate - we use that for OS-specifiuc glitches we can't fix as well ass referrals to upstream packages we can.
20090414 16:08:14< corn> Crab_: can I steal your fantastic looking timeline template?
20090414 16:08:29< Crab_> corn: yes, of course.
20090414 16:08:33< corn> thank you
20090414 16:08:41< Crab_> corn: you won't be the first :)
20090414 16:08:45< corn> lol
20090414 16:10:11< Crab_> corn: btw, I've grabbed up my copy of "Unix network programming" by R.Stevens - he describes 3 ways of setting timeout on "connect" function in #13.2
20090414 16:12:03< corn> Crab_: it's being wrapped around though. I wasn't aware that you could set a timeout on connect though
20090414 16:12:07< corn> maybe in nonblocking mode?
20090414 16:12:57< Crab_> yes, one of the ways is in nonblocking mode, one is with a SIGALRM, one is with special socket options
20090414 16:14:11< corn> sending a signal is a really interesting idea
20090414 16:14:14< Crab_> http://tinyurl.com/cs8akn
20090414 16:14:20< corn> don't think it's portable to windows though
20090414 16:14:47< YogiHH> corn: some signals are defined for windows, others are not
20090414 16:16:22 * esr goes back to work on Soliton's issue
20090414 16:16:26< corn> Crab_: option 2 and 3 are out, since we're relying on an SDL call here and not an exposed connect()
20090414 16:17:11< corn> relevant code is upload_log.cpp:106 btw
20090414 16:17:20< corn> should have SDLNet_TCP_Open
20090414 16:18:30< Crab_> it looks like that windows doesn't have SIGALRM, too.
20090414 16:19:56< Crab_> has the SDL a way to specify that timeout ?
20090414 16:20:04< corn> not sure
20090414 16:20:47< Crab_> corn: checking this is probably the best thing to do... since if it has, all will be easier...
20090414 16:21:01< corn> definitely true
20090414 16:21:46< corn> yes, I think it does
20090414 16:21:48< corn> http://test.maemo.org/platform/docs/howtos/tutorial_sdl_net_bora.html#Functions
20090414 16:22:32< corn> you can put the socket in a set 
20090414 16:22:38< corn> maybe that would work
20090414 16:23:05< corn> then you can use method #2 of the book
20090414 16:23:20< corn> use the SDL equivalent of a select() call and then delete the socket if it expires
20090414 16:23:48< corn> actually I don't think that would fix it
20090414 16:24:06-!- crimson_penguin [n=ben@64.201.60.216] has joined #wesnoth-dev
20090414 16:24:44< Crab_> corn: is there any other cross-platform socket library that can be used ?
20090414 16:25:06< corn> for wesnoth? don't think so
20090414 16:25:14< loonycyborg> Boost.Asio.
20090414 16:25:14< corn> although I don't have enough experience to say for sure
20090414 16:25:48< Crab_> and since it's async, it won't block...
20090414 16:25:57< loonycyborg> http://www.boost.org/doc/libs/1_38_0/doc/html/boost_asio.html
20090414 16:26:12< Ivanovic> loonycyborg: in which boost version was it introduced?
20090414 16:26:27< loonycyborg> 1.35
20090414 16:26:39< loonycyborg> Though it can be bcp'd
20090414 16:26:40< YogiHH> Crab_, corn: IMO, switching to another socket library needs a better reason than fixing this bug
20090414 16:26:55< Ivanovic> i think raising the dep to 1.35 for trunk should be fine
20090414 16:27:18< corn> YogiHH: what if the new lib is only used for this particular code?
20090414 16:27:25< loonycyborg> FreeOrion used to have asio commited to svn before it was 'mainlined' to boost.
20090414 16:28:08< Ivanovic> loonycyborg: *if* we started using asio i'd vote for raising the min boost version and be done
20090414 16:28:15< YogiHH> corn: we have become very careful about new dependencies. Most of them are pretty much a pain till everything runs smooth again on every platform
20090414 16:29:05< loonycyborg> Ivanovic: Yes. 1.35 is very high anymore.
20090414 16:29:11< loonycyborg> *isn't
20090414 16:29:19< Crab_> when the client wants to connect to MP server, do we have the same 'long timeout' issues ?
20090414 16:29:29< loonycyborg> All major disros should pick it up soon.
20090414 16:29:36< loonycyborg> *distros
20090414 16:29:49< corn> Crab_: stats aren't collected for MP
20090414 16:29:53< Ivanovic> isn't it even part of debian stable already?
20090414 16:29:58< corn> the issue only arises when you try to quit wesnoth anyway
20090414 16:30:15< Crab_> corn: no, I was thinking "what network library MP uses now ?"
20090414 16:30:20< corn> oh
20090414 16:30:29< YogiHH> Crab_: SDL_net
20090414 16:30:35< corn> not sure. I was never able to reproduce this bug
20090414 16:30:43< corn> dfranke was the one who reproduces it
20090414 16:30:49< corn> reproduced*
20090414 16:31:06< Crab_> YogiHH: so, "if the client connects to unavailable mp server", we'll have a "long hang", too ?
20090414 16:31:11< corn> he said that you can reproduce by blocking wesnoth.org on port 80 but the connection timeout quickly
20090414 16:31:17< corn> timed out*
20090414 16:31:24< YogiHH> Crab_: about 30s, i think
20090414 16:31:37< YogiHH> maybe even shorter
20090414 16:31:41< Crab_> YogiHH: can we send stats on "starting wesnoth" ?
20090414 16:32:23< YogiHH> hmm, you want to save them to disk?
20090414 16:32:37< Crab_> aren't they saved now ?
20090414 16:32:49< Soliton> yes.
20090414 16:32:50< YogiHH> no idea
20090414 16:33:00< CIA-30> esr * r34909 /trunk/data/tools/wmllint: 
20090414 16:33:00< CIA-30> Enable wmllinto to see saveames, including compressed savegames, and
20090414 16:33:00< CIA-30> do its transformations on them.
20090414 16:33:19< corn> Crab_: stats only start getting collected at scenario start
20090414 16:33:23 * Soliton tries.
20090414 16:33:26< corn> relevant function is upload_log::start
20090414 16:33:58< YogiHH> hehe
20090414 16:34:01< Crab_> corn: yes, but we can upload the "previously unuploaded" stats on wesnoth start, in the background.
20090414 16:34:07-!- ettin_ is now known as ettin
20090414 16:34:25< corn> Crab_: true. do you suggest that stats uploading be moved to wesnoth start instead of exit?
20090414 16:34:43 * esr I'm going to go sleep for a bit, only got 4 hours last night.
20090414 16:34:54< Ivanovic> n8 esr
20090414 16:34:57< corn> cya
20090414 16:34:59< YogiHH> good night
20090414 16:35:25< Crab_> corn: this is just an idea - so, if they timeout,  they'll timeout in the background.
20090414 16:35:32< corn> Crab_: that's not reliable though
20090414 16:35:39< corn> if a user opens wesnoth and exits, they'll get a hang
20090414 16:35:52< Crab_> yes
20090414 16:36:07< Crab_> "a segfault"
20090414 16:36:10< Crab_> or a hang
20090414 16:36:17< corn> well current behavior is a hang
20090414 16:36:24< corn> if I change it to kill the thread it is a segfault
20090414 16:37:08< Crab_> corn: so, you're thinking of making a separate binary (= separate process, so it doesn't matter if it hangs) for that ?
20090414 16:37:14< corn> yes
20090414 16:37:25< corn> there are some benefits too developer side
20090414 16:37:37< corn> no need to start wesnoth in order to send logs
20090414 16:37:49< corn> so the developer who will be working on stats and logs will have an easier time
20090414 16:37:53< Crab_> corn: btw, can we collect the stats on 'boost version used by clients' ?
20090414 16:38:03< corn> Crab_: currently not being done
20090414 16:38:11< corn> I would imagine that you'd have to define something compile time
20090414 16:38:18< Crab_> corn: yes.
20090414 16:38:25< corn> the log file is WML generated
20090414 16:38:32< corn> you can put whatever into it
20090414 16:38:44< Crab_> corn: this will help with the question "is it good to switch to boost 1.3x ?"
20090414 16:38:57< corn> sure
20090414 16:39:05< corn> I actually want to improve the platform collection in wesnoth
20090414 16:39:19< corn> check out line 176 roughly
20090414 16:39:25< corn> config_["platform"]
20090414 16:39:45< corn> on dfranke's suggestion, instead of ifdefs you should have windows and then use uname to figure out detailed info from other platforms
20090414 16:39:52< corn> uname()
20090414 16:40:15< Crab_> yes, it will be a good thing to do
20090414 16:40:21< corn> I have a small patch that does this already but I am not sure if it is portable across all unixes
20090414 16:40:42< corn> http://cornmander.com:9090/platform/
20090414 16:40:56< corn> unspecified is because linux currently does not return anything for the platform string
20090414 16:41:07< Crab_> yes, I've seen this graph
20090414 16:41:21< Crab_> the number of Mac uses surprises me )
20090414 16:41:22< corn> the windows is misleading because they have a firewall
20090414 16:41:33< corn> that blocks wesnoth from connecting 
20090414 16:41:45< corn> or atleast that's the explanation we came up with in the channel
20090414 16:42:09< Crab_> standard windows firewall doesn't block outgoing, afaik
20090414 16:42:20< corn> that's what I said too
20090414 16:42:25< YogiHH> Crab_: that's correct
20090414 16:43:01< corn> anyway
20090414 16:43:06< corn> I wanna talk to you about an idea I had
20090414 16:43:12< YogiHH> Crab_: And the reason why every sane user turns it off and installs another one ;-)
20090414 16:43:20< corn> I want to collect detailed map information on kills
20090414 16:43:28< corn> so you would have a list of units killed on a particular tile
20090414 16:43:33< corn> would that be useful for AI?
20090414 16:43:57< Crab_> corn: yes, it will be.
20090414 16:44:04< corn> ok, cool
20090414 16:44:21< corn> is there anything else that would be useful?
20090414 16:44:52< Crab_> a list of units that humans recruit playing as faction A vs faction B
20090414 16:45:06< corn> hm
20090414 16:45:17< corn> that's being collected right now, but the database structure makes it of limited use
20090414 16:45:21< Crab_> btw, it will be interesting if we make a 'local cache' of this info for this particular player
20090414 16:45:37< corn> currently there is a list of units at end game but it ends up being stored independent of any particular game
20090414 16:45:40< Crab_> so the ai can ask the game 'what does *this particular player* recruit ?'
20090414 16:45:45< corn> Crab_: currently being done
20090414 16:45:54< corn> every user who submits to wesnoth has a unique ID
20090414 16:46:07< Crab_> good. how do you think the ai will get this info back ?
20090414 16:46:10< corn> not sure if it gets recycled when they restart wesnoth but individual users can see some data
20090414 16:46:20< corn> it is provided in the wesnoth client somewhere
20090414 16:46:30< corn> ah
20090414 16:46:34< corn> preferences::upload_id()
20090414 16:46:57< Crab_> no, I meant this: the data is collected on a central wesnoth server, so we want to feed it to ai somehow. how ?
20090414 16:47:05< corn> oh
20090414 16:47:12< Crab_> as an downloadable addon ?
20090414 16:47:14< corn> I dunno, I can make an API or give you DB dumps
20090414 16:47:40< corn> I am not familiar with how addons work in wesnoth
20090414 16:47:42< Crab_> imo, it will be good to make this an 'addon' (since then we can reuse addon update checking)
20090414 16:47:48< Ivanovic> Crab_: so far there is no evolutionary/machine learning AI foir wesnoth
20090414 16:47:59< Crab_> Ivanovic: no, that's not machine learning...
20090414 16:48:14< Ivanovic> those stats are (so far) only meant for content creators to balance/improve their scenarios/campaigns/maps
20090414 16:48:34< corn> Ivanovic: right. we're considering using stats for ai regression testing
20090414 16:48:39< Crab_> Ivanovic: but,for example, Dragonking is writing a recruitment formula that makes all sorts of assumptions 'out of the sky', 'out of the map', 'out of unit stats', etc
20090414 16:48:58< Crab_> Ivanovic: so, if we had additional info, it would be able to take it into account
20090414 16:49:16< Ivanovic> Crab_: and for *watching* this info there will be a webinterface
20090414 16:49:25< Crab_> Ivanovic: that's for humans )
20090414 16:49:30< corn> lol
20090414 16:49:33< corn> he wants to make it update
20090414 16:49:33< Ivanovic> so a human can look at the data and use it to *write* the ai
20090414 16:49:58< Crab_> Ivanovic: yes. but ai can read from a .cfg, which can be packaged as an addon
20090414 16:50:28< Ivanovic> Crab_: i don't think the "generic data" we get will be a really good thing to *automatically* make conclusions from
20090414 16:50:51< Ivanovic> so basically it would have to be filtered into some sane format anyway
20090414 16:50:57< Crab_> Ivanovic: into WML :)
20090414 16:51:21< corn> Ivanovic: the same process that a user takes to filter down the data into something meaningful can be made into a formula
20090414 16:51:30< Ivanovic> Crab_: with filtered i mean some good player saying "hehe, many do this, but there is no need to explicitly do that to prevent them from doing so since it fails anyway"
20090414 16:51:32< Crab_> Ivanovic: the ai developer has to write a script which will take a db and extract those stats which he 'thinks' are useful into a WML .cfg
20090414 16:52:05< corn> Ivanovic: that confused me
20090414 16:52:09< Crab_> this is *filtering*, yes
20090414 16:52:32< Ivanovic> corn: basically some "remove stupid things from results" filter
20090414 16:52:34< Crab_> so no 'automatical conclusions', yes
20090414 16:52:44< Ivanovic> something that most likely is not possible as "automatic conclusion"
20090414 16:52:50< Crab_> I agree.
20090414 16:52:56< Crab_> but having this data would be useful.
20090414 16:53:01< Ivanovic> so some "load the data automatically" won't help at all
20090414 16:53:12< corn> Crab_: yes, that is the point of my gsoc project
20090414 16:53:20< Ivanovic> (or load data from the stats server via addons.wesnoth.org)
20090414 16:53:39< Ivanovic> since in the *webinterface* humans can filter stuff in every way they want to (once the data is collected and such)
20090414 16:53:42< Crab_> Ivanovic: no, I meant 'load AI via addons.wesnoth.org)
20090414 16:54:05< Ivanovic> loading an ai via the addon server should not be much of a problem
20090414 16:54:26< Ivanovic> and making this ai "good" is a task for a human who can/should have a look at stats.wesnoth.org
20090414 16:54:35< Crab_> Ivanovic: yes, that's what I wanted to do. And this will allow the ai developer to take 'stats.wesnoth.org' into account
20090414 16:54:40< Ivanovic> and yeah, the collected data is/will be available
20090414 16:55:13< corn> lol, not really sure what this argument is over
20090414 16:55:29< YogiHH> Ivanovic: what might be interesting is to search for statistical correlations like "recruiting mages on Siege of Elensefar improves your chances to win by 30%"
20090414 16:55:31< Ivanovic> Crab_: i understood your stuff more in the way "make the uploaded data available *directly* via the addon server so that this database can be loaded into the game and be used for an ai with some magic in between"
20090414 16:56:18< Crab_> Ivanovic: no, not directly. but of course the developer can automate some tasks of "stats->addon .cfg" using scripts
20090414 16:57:41< Crab_> for example, he may write the script to extract the human recruitment patterns from stats.wesnoth.org and make a .cfg which will be used by the ai.
20090414 16:58:02< YogiHH> riding home now, i will be back later this evening
20090414 16:58:27-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has left #wesnoth-dev []
20090414 16:59:07< Ivanovic> Crab_: so basically some "recruit like the average (winning) human in this situation does
20090414 16:59:40< Crab_> Ivanovic: or "recruit what is recruited by those AIs who win vs humans"
20090414 16:59:41< Ivanovic> and to get it more prefect, we will also need a complete replay of the game uploaded since we will need to know which hex to place those reqruited units on
20090414 16:59:43< Ivanovic> ;)
20090414 17:00:13< Crab_> Ivanovic: he-he ) no, the players decisions are too random )
20090414 17:00:32< Ivanovic> Crab_: for the moment i would prefer to have the project "statsserver" basic and working without too much extra stuff
20090414 17:00:48< Crab_> Ivanovic: it doesn't need to be done during the GSoC.
20090414 17:00:51< Ivanovic> that is: it can be extended later on to have "more" in, but i would first like to see something working
20090414 17:00:56< Ivanovic> right
20090414 17:01:04< Crab_> Ivanovic: the main things that we want to have is an 'engine' of sorts, which can be extended
20090414 17:01:48< Crab_> 'to be later extended to run a small python script to query the stats', 'to be later extended to supply more info', etc..
20090414 17:02:08< corn> hm
20090414 17:02:13< corn> doing that would be not trivial
20090414 17:02:25< corn> to expose more info from wesnoth you need to code that in
20090414 17:02:35< corn> there is no quick and easy way to extend stats
20090414 17:02:40< Ivanovic> corn: that is why i would prefer to have it "work" first
20090414 17:02:51< Ivanovic> and later on things can be extended where wanted/required
20090414 17:02:57< corn> right.
20090414 17:03:08< Ivanovic> especially since MP is not included in stats so far IIRC
20090414 17:03:24< corn> I have a set of specs that I want, those are going to be my gsoc goals
20090414 17:03:25< Ivanovic> that is: only campaign stats are currently really collected
20090414 17:03:26< Crab_> corn: the main thing is to have a good plan "what to do if it is wanted to to this, what to do if it is wanted to to that, etc..."
20090414 17:03:38< Crab_> and do only a "skeleton" subset during the GSoC
20090414 17:03:42< Ivanovic> (gold at end, gold at start, time needed, leveled units, dead units, ...)
20090414 17:04:23< corn> Crab_: my plan was to do a subset and make it complete
20090414 17:04:28< corn> rather than stub out functionality 
20090414 17:04:56< Ivanovic> corn: personally this is what i prefer as summer of code project
20090414 17:05:12< Crab_> corn: that's also good. just make sure that it *can* be extended without full rewrite:)
20090414 17:05:16< Ivanovic> so that we have some "really complete and usable" interface to help content creators improve their campaigns
20090414 17:05:21< corn> right
20090414 17:05:39< corn> here is my current design goals, things that I _must_ do to complete gsoc:
20090414 17:05:40< Ivanovic> and yeah, keeping future extensions in mind will not be a bad idea at all
20090414 17:06:08< corn> 1. current filter interface - make it work for millions of row entries, dynamically trim unneeded options as you filter down
20090414 17:06:19< corn> add new displays
20090414 17:06:54< corn> 2. kill graphs - make a page that shows a map of a wesnoth scenario and uses jscript magic to present a breakdown of units killed on each squiare
20090414 17:07:00-!- Netsplit niven.freenode.net <-> irc.freenode.net quits: jmunro[a]
20090414 17:07:00< corn> and indicate the 'hottest' squares
20090414 17:07:32< corn> 3. user interface/logins - let users login and 'subscribe' to particular views. this would be useful for ai regression testing
20090414 17:07:33-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has joined #wesnoth-dev
20090414 17:07:40< corn> also campaign development
20090414 17:08:12-!- Netsplit over, joins: jmunro[a]
20090414 17:08:44< corn> I wanted to do stats collection for MP but there seems to be huge resistance to it
20090414 17:09:02-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 17:09:05< corn> hm
20090414 17:09:14< corn> how does that sound?
20090414 17:09:29< Ivanovic> sounds reasonable
20090414 17:09:39< Ivanovic> and 2) does really sound interesting
20090414 17:10:00< corn> for part 1 I could pretty easily add stats collection on unit recruitment stats 
20090414 17:10:04< corn> it's moer or less being done right now
20090414 17:10:47< Ivanovic> corn: i personally suggest basic functionality for the moment
20090414 17:11:03< Ivanovic> when you later on see that "lots of time" is available it would still be posisble to extend stuff
20090414 17:11:15< corn> true
20090414 17:11:27< Crab_> corn: can you also provide any kind of 'basic' export feature (any, cvs, xml, what is easiest)
20090414 17:11:48< corn> Crab_: db is stored as a mysql db, easily exportable
20090414 17:11:54< Crab_> corn: ok
20090414 17:12:08< Ivanovic> basically some "has to be done" vs "would be a nice extension" situation
20090414 17:12:12< corn> right
20090414 17:12:33< Soliton> corn: it depends on what stats you want to collect in MP. what we don't want is any kind of ranking system.
20090414 17:12:47< corn> well those 3 things are my 'has to be done' things, although #1 should be elaborated on
20090414 17:13:13< Ivanovic> corn: for every "area" you can have some "extended version" with some bonus features
20090414 17:13:13< corn> Soliton: not sure who I was talking to about this but it gets complicated if the host of a game has stats logging enabled and someone in the game doesn't
20090414 17:13:14< Soliton> corn: we're now saving replays of most games on the server which can be analyzed for whatever you want.
20090414 17:14:05< Ivanovic> hmm, sounds like an interesting extension for the server: analyse provided replays and upload the results of those in a completely anonymus way"
20090414 17:14:20< Ivanovic> :)
20090414 17:14:23< corn> that's completely backwards though
20090414 17:14:26< corn> I mean
20090414 17:14:34< corn> the server is getting the *exact* data from the client
20090414 17:14:43< corn> as if it were sending stats directly
20090414 17:15:10< corn> well
20090414 17:15:11< corn> I mean
20090414 17:15:22< corn> the wesnoth server could log those IPs
20090414 17:15:31< Soliton> analyzing replays is not easy, yes. for many things you will basically have to recreate the gamestate as wesnoth does.
20090414 17:15:42< Ivanovic> corn: i don't know how this replay saving stuff is done
20090414 17:15:43< corn> I don't really see the distinction between getting stats directly and replaying a game
20090414 17:16:07< Ivanovic> if the host selects "create replay on server at end" this should be enough security
20090414 17:16:12< corn> except that replaying a game is a very backwards way to insure that we're not trying to stela your anonymity
20090414 17:16:21< Ivanovic> especially if those replays are eventually made publically available
20090414 17:16:52< corn> hm
20090414 17:16:54< corn> ok
20090414 17:17:34< Ivanovic> but yes, this should *not* be a priorty ("that" as in writing a replay analyzer)
20090414 17:25:08-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out]
20090414 17:33:05< Ivanovic> off to do some sports, cu
20090414 17:35:02-!- ikarius [n=ross@216.27.182.3] has quit []
20090414 17:49:26-!- Psyche^ [n=Psyche@g224109180.adsl.alicedsl.de] has joined #wesnoth-dev
20090414 17:52:45-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has quit [Read error: 54 (Connection reset by peer)]
20090414 17:57:48-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev
20090414 17:59:57< CIA-30> alink * r34910 /trunk/src/pathfind.cpp: Small optimization of pathfinding (paths() version) by skipping backwards moves
20090414 18:00:13-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Read error: 110 (Connection timed out)]
20090414 18:05:35-!- Patterner [n=Psyche@g224104216.adsl.alicedsl.de] has quit [Read error: 110 (Connection timed out)]
20090414 18:05:35-!- Psyche^ is now known as Patterner
20090414 18:09:12-!- wesbot changed the topic of #wesnoth-dev to: released 1.6.1, announcing "soon" | Summer of Code info: http://www.wesnoth.org/wiki/SummerOfCodeIdeas | 50 bugs, 234 feature requests, 12 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090414 18:11:56-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has joined #wesnoth-dev
20090414 18:15:39-!- turin [n=turin@168.215.250.1] has joined #wesnoth-dev
20090414 18:18:34-!- ikarius [n=ross@smtp.gridironsystems.com] has joined #wesnoth-dev
20090414 18:20:00< Soliton> esr: r34882 looks like a typo; s/mage/image/
20090414 18:25:53< Soliton> esr: converting an 1.4 save to 1.6 seems to have worked reasonably well. i just had to remove some unit_type stats (that get modified by traits) to get regenerated properly according to the unit's traits.
20090414 18:26:30< Soliton> hi elias.
20090414 18:27:05< elias> hi
20090414 18:27:21 * elias wonders if he should hide
20090414 18:27:26< Soliton> elias: i'm now automatically updating era addons for the unit tree and occasionally some annoying addon breaks all of them. any ideas on good ways to fix that automatically?
20090414 18:28:05 * Soliton only says hi when he has a request. ;-)
20090414 18:28:24< Shadow_Master> Soliton: say hi again.
20090414 18:28:25< elias> hm
20090414 18:28:44< elias> do these eras use their own unit ids?
20090414 18:29:15< Soliton> most do, but there are some black sheep, i think.
20090414 18:29:38< Soliton> that#s why i changed the parsing order to have mainline units overwrite addon ones.
20090414 18:29:42< elias> well, from what i remember, as long as unit ids are unique, the units should not break
20090414 18:30:00< Soliton> complete parsing of addons breaks.
20090414 18:30:16< elias> ah, ok
20090414 18:30:29< elias> do you know which addon?
20090414 18:30:32< Soliton> and since they all (have to) get parsed at once..
20090414 18:30:47< Soliton> well, i know when i look at the log... :-)
20090414 18:31:06< Soliton> so far i added deleting the offending addons to the cron entry.
20090414 18:31:13< Soliton> pretty ugly of course...
20090414 18:31:30< Soliton> and still needs my intervention once in a while.
20090414 18:31:59-!- JonW1 [n=chatzill@cpc2-finc11-0-0-cust855.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20090414 18:32:01< elias> hm
20090414 18:32:11< Soliton> i'm just idly wondering, don't expect there to be a solution. at least i have no idea...
20090414 18:32:31< elias> well, if there's a bug in the parser, i'd need to know the offending addon, then fix it...
20090414 18:32:55< elias> but it sounds like the addon is actually broken
20090414 18:33:04< Soliton> the last thing i tracked down was several key=value pairs on the same line.
20090414 18:33:07-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090414 18:33:16< Soliton> wesnoth probably just ignores that and uses defaults.
20090414 18:33:26< elias> i see, then the python parser should do the same
20090414 18:33:31< Soliton> actually i think i made wmlunits do that too in that case.
20090414 18:34:15< Soliton> well, really i'm just too lazy to track the errors down especially since i can't fix them in the addon anyway... :-)
20090414 18:34:53< Soliton> let me look at the latest offender...
20090414 18:35:14-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20090414 18:36:44< Soliton> hrm, log is gone but if you feel like investigating... the offending addons are: War_of_Chaos_Era Path_of_Summoners_Era mercenaries Ageless_Era
20090414 18:37:33< elias> on which server?... or can you give me the complete command to get them?
20090414 18:38:43< Soliton> something like: wesnoth_addon_manager --download='War_of_Chaos_Era|Path_of_Summoners_Era|mercenaries|Ageless_Era'
20090414 18:39:03< Soliton> not sure what kind of regexps are used there.
20090414 18:39:53< elias> and the server?
20090414 18:39:57< elias> it says the 1.7 addons list is empty
20090414 18:40:04< elias> but uses that by default here
20090414 18:40:09< Soliton> oh yeah, the 1.6 server
20090414 18:40:21< Soliton> --port 1.6.x
20090414 18:44:40-!- ettin_ [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev
20090414 18:47:44< Soliton> dfranke: aha! reproduced the odd game. it's a game with only empty sides...
20090414 18:48:42< dfranke> Soliton: that's what I tried last night.  Then what?
20090414 18:48:54< Soliton> start it.
20090414 18:49:02< elias> "Parsing addons ... 0 units found."
20090414 18:49:10< elias> i think i forgot how to use wmlunits... :P
20090414 18:49:21< Soliton> well, because there was an error?
20090414 18:49:39-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 18:49:41< Soliton> that's what happens when there is a parse error.
20090414 18:49:43< dfranke> Soliton: when I did that the game just ended immediately.
20090414 18:49:57< elias> are the parse errors written to some log file?
20090414 18:50:08< Soliton> dfranke: and you really chose empty sides?
20090414 18:50:14< dfranke> Soliton: yes
20090414 18:50:39< Soliton> well, i just produced such a game.
20090414 18:51:09< Soliton> and indeed it is still there.
20090414 18:51:18< Soliton> (i had to kill -9 wesnoth)
20090414 18:51:23-!- noy [n=Noy@d75-157-52-251.bchsia.telus.net] has joined #wesnoth-dev
20090414 18:51:43< elias> data/tools/wmlunits -l C -o tmp -d data -u tmp3
20090414 18:51:52< elias> > ls tmp3/
20090414 18:51:52< elias> add-ons
20090414 18:51:53< dfranke> Soliton: strange.  I wonder what we did differently.
20090414 18:52:02< elias> Soliton: ^ does that look like it should work?
20090414 18:53:10< Soliton> elias: i used complete paths. "source/1.6/data/tools/wmlunits -d ~/source/1.6/data/ -u ~/addons/1.6/"
20090414 18:53:41-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090414 18:54:06< elias> what is inside  ~/addons/1.6/? all the addons, or a sub-folder called "add-ons"?
20090414 18:54:13< Soliton> dfranke: either way i have a fix for the wesnothd side. but wesnoth should be fixed as well. probably just not allow creation of such games to begin with.
20090414 18:54:38-!- JonW1 [n=chatzill@cpc2-finc11-0-0-cust855.4-2.cable.virginmedia.com] has quit ["ChatZilla 0.9.84 [Firefox 3.1b3/20090305152042]"]
20090414 18:55:07< Soliton> elias: yes, except it's campaigns.
20090414 18:55:25< dfranke> Soliton: sounsd good.
20090414 18:55:27< elias> hm, strange
20090414 18:55:35< dfranke> Soliton: think this is worth a security advisory?  It's a DoS.
20090414 18:55:37< elias> i thought campaigns was renamed to add-ons
20090414 18:55:38< Soliton> elias: indeed that should be changed to add-ons or so for trunk if Shadow_Master hasn't done that yet.
20090414 18:56:13< Soliton> dfranke: well, once the server is fixed what's the problem?
20090414 18:56:40< dfranke> Soliton: third party servers.  Makes the problem pretty trivial though.
20090414 18:57:00< dfranke> Soliton: my inclination is that it's not worth treating as a security issue.
20090414 18:57:04< Soliton> yeah, i'm afraid i don't care much there. :-)
20090414 18:57:07-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)]
20090414 18:57:13-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)]
20090414 19:00:07-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit ["Konversation terminated!"]
20090414 19:03:26< Shadow_Master> no I haven't. 
20090414 19:04:28< dfranke> xb
20090414 19:04:32< dfranke> oops
20090414 19:06:11-!- edb [n=edb@169.12.95-79.rev.gaoland.net] has joined #wesnoth-dev
20090414 19:07:02-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20090414 19:07:23< mordante> hi
20090414 19:14:17-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 19:21:42-!- |Andylee| [n=kvirc@188-23-103-245.adsl.highway.telekom.at] has joined #wesnoth-dev
20090414 19:21:46-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out]
20090414 19:26:44< AnMaster> hm
20090414 19:27:46< mordante> corn, when you post a patch for a bug report, best post it at patches.wesnoth.org, that way we see it faster
20090414 19:28:19< AnMaster> damage calculation or IftU bug (not sure): Attack with berserker or ulfserker some unit that have no melee attacks. Select damage calculation. As expected it shows 100% survivability for the berserker. But it shows a 0.3% chance of the opponent not being defeated.
20090414 19:28:31< AnMaster> which doesn't make sense
20090414 19:29:18< AnMaster> noticed this on "The heart" in IftU, attacking one of those sentry towers there with an ulfserker
20090414 19:29:57< AnMaster> I suspect this is an engine bug, because the *serker will attack until either it or the opponent dies
20090414 19:30:55< AnMaster> I haven't tested any other scenario or campagin because I don't remember any other one where player had *serker and there was an opponent with no melee attacks
20090414 19:35:45< Soliton> alink: help pages have the advance from/to line even if all the advancements are hidden.
20090414 19:36:08< elias> does "add-ons" as well as "campaigns" work in trunk?
20090414 19:36:19< Soliton> Shadow_Master: ^
20090414 19:36:22< AnMaster> elias, last I tried only the former one worked
20090414 19:36:24< alink> Soliton: checking
20090414 19:36:31< elias> mercenaries.cfg has things like: {~campaigns/mercenaries/MercenaryEra.cfg}
20090414 19:36:33< AnMaster> which was like half a week ago
20090414 19:36:37 * crimson_penguin lost to an ulfserker with 97% chance of winning
20090414 19:36:39< elias> so i'd say the addon is simply broken :/
20090414 19:36:52< loonycyborg> Nope. Only "add-ons" work.
20090414 19:36:54< Soliton> alink: you can see it in DiD with DAs.
20090414 19:36:56< elias> wesnoth can't load it... so wmlunits shouldn't be able to
20090414 19:37:01< AnMaster> crimson_penguin, well that is possible. it is 97% *chance*
20090414 19:37:10< crimson_penguin> AnMaster: yes, yes :P
20090414 19:37:12< Soliton> elias: i'm only talking about 1.6.
20090414 19:37:22< AnMaster> crimson_penguin, while the case I mentioned was technically impossible.
20090414 19:37:29< elias> Soliton: i see. i'll have to get 1.6 then
20090414 19:37:45< crimson_penguin> AnMaster: that was a crazy game; 2 vs. 2 on one of those little maps (Isar's Cross), and it took 39 turns, and about 3 hours
20090414 19:37:53< elias> hm, is it faster to do a complete checkout, or copy my trunk folder and co 1.6 in there?
20090414 19:38:00< Soliton> elias: well, the wmlunits in trunk currently should work with 1.6?
20090414 19:38:05< AnMaster> crimson_penguin, long turns?
20090414 19:38:07< crimson_penguin> AnMaster: yeah yeahhh :P yours is a bug, mine is just a baseless complaint ;)
20090414 19:38:09< Soliton> 1.6 addons*
20090414 19:38:21< AnMaster> crimson_penguin, you are a dev?
20090414 19:38:25< AnMaster> (just wondering)
20090414 19:38:30< Soliton> elias: copy and switch.
20090414 19:38:36< elias> Soliton: i'm trying to find the problem, so need to first check if wesnoth itself can load those addons
20090414 19:38:40< crimson_penguin> AnMaster: not really, I think that's just a lot of turns... also, 4 people (thought it went down to 3 pretty quickly)
20090414 19:38:44< elias> if it can't, i have nothing to fix :P
20090414 19:38:51< crimson_penguin> AnMaster: I'm a packager, and a veery occasional dev
20090414 19:39:04< Soliton> elias: well, i haven't checked but i'd be very surprised if not.
20090414 19:39:28< AnMaster> crimson_penguin, ah multiplayer
20090414 19:39:35< AnMaster> never tried that
20090414 19:39:42< crimson_penguin> AnMaster: oh, yeah, this was MP
20090414 19:39:47-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer]
20090414 19:39:59< AnMaster> (plus I don't really enjoy multiplayer for other games)
20090414 19:40:01< crimson_penguin> amazingly, the guy who lost his teammate early on won
20090414 19:40:03-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 19:40:08< AnMaster> wow
20090414 19:40:08< Soliton> AnMaster: berserk is not infinite so it is technically possible.
20090414 19:40:24< AnMaster> Soliton, isn't it? Unit description seems to indicate it is
20090414 19:40:34< AnMaster> Soliton, also how is it finite?
20090414 19:40:47< alink> Soliton: you mean that the link "Apprentice Necromancer" must not be shown at all ?
20090414 19:40:47< AnMaster> I mean, what is the limit
20090414 19:41:34-!- _Andylee_ [n=kvirc@188-23-109-51.adsl.highway.telekom.at] has quit [Read error: 110 (Connection timed out)]
20090414 19:41:36< Soliton> AnMaster: look at the desscription of berserk.
20090414 19:41:37< crimson_penguin> hmm... you could run into an infinite loop with berserk, if the chance to hit was 0 (or damage)
20090414 19:41:55< AnMaster> Soliton, sec, *starts wesnoth again*
20090414 19:42:01< Soliton> alink: no, https://gna.org/bugs/index.php?13369
20090414 19:42:19< elias> Soliton: if i start wesnoth, and go to help->units, are era units supposed to show up?
20090414 19:43:03< Soliton> no idea.
20090414 19:43:11< AnMaster> Soliton, "Whenever its berserk attack is used, this unit continues to push the attack until either it or its enemy lies dead."
20090414 19:43:12< AnMaster> that?
20090414 19:43:39< Soliton> elias: looks like not.
20090414 19:43:51< Soliton> elias: start an mp game.
20090414 19:43:56< elias> so how can i best see if the addon works
20090414 19:44:01< elias> ok
20090414 19:44:01< AnMaster> Soliton, doesn't say it is limited for either berserker or ulfserker
20090414 19:44:10< AnMaster> as far as I can see
20090414 19:44:21< Soliton> indeed, which is why i sadi the berserk description.
20090414 19:44:26< Soliton> said*
20090414 19:45:19< AnMaster> well.. I'm looking at it....
20090414 19:45:27< AnMaster> ah
20090414 19:45:38< AnMaster> Soliton, not "berserker description"
20090414 19:45:39< AnMaster> rigt
20090414 19:45:41< AnMaster> right*
20090414 19:47:02< AnMaster> Soliton, never noticed the abilities had descriptions before
20090414 19:47:10< AnMaster> I mean except for those "special notes"
20090414 19:47:26< elias> is there a way to get descriptions for all units?
20090414 19:47:54< Soliton> what does that mean?
20090414 19:48:03< elias> in the in-game help
20090414 19:48:06< elias> it only has very few for me
20090414 19:48:17< Soliton> oh, right. go into debug mode.
20090414 19:48:24< elias> how? :)
20090414 19:48:27< Soliton> :debug
20090414 19:48:31< elias> ah, tx
20090414 19:48:33< Soliton> or start with -d
20090414 19:49:13< Soliton> AnMaster: the question is whether the unit description is too misleading for flavour's sake.
20090414 19:49:30-!- Mythological_ [i=Mytholog@77.28.91.139] has joined #wesnoth-dev
20090414 19:49:30< AnMaster> Soliton, ok that could be a valid reason
20090414 19:51:07< Soliton> alink: did you get the issue? the problem is we print Advances from/to: only based whether there are choices not whether those are actually visible.
20090414 19:51:22< alink> yes i got it
20090414 19:51:39< Soliton> alink: maybe a simple task for gsoc'er. ;-)
20090414 19:52:01-!- YogiHH [n=chatzill@d085178.adsl.hansenet.de] has joined #wesnoth-dev
20090414 19:52:23< YogiHH> hello everyone
20090414 19:52:47< alink> Soliton: so to be clear, you just want to remove the text 'Advnace from/to' when there is no visible types after them ?
20090414 19:53:02< Soliton> alink: sounds reasonable, no?
20090414 19:53:30< YogiHH> corn, around?
20090414 19:53:57< alink> Soliton: yes of course, I was just a bit puzzled because the bugreport doesn't seems to be about that
20090414 19:54:38< Soliton> alink: well, he just didn't realize it. ;-)
20090414 19:55:05< Soliton> alink: the bug there is also that those advancements are hidden when i don't really see why they should.
20090414 19:55:49< Soliton> i.e. removing hide_help=true will fix it.
20090414 19:55:54< alink> indeed
20090414 19:56:08< alink> mmh there is also the problem that there is 2 Dark Sorcerer, one with hide_help and the other without it
20090414 19:56:08< Soliton> but the help logic should cope with those cases anyway.
20090414 19:56:13< AnMaster> Soliton, err would this hide from the player if a unit can advance or not?
20090414 19:56:31< Soliton> AnMaster: somewhat, yes.
20090414 19:56:41< alink> Soliton: maybe remove it the hide_help in DiD will show 2 entries
20090414 19:57:00< AnMaster> Soliton, that sounds like a bad idea. I often decide to which variant to upgrade a unit (when there is a choice) based on what it can upgrade to even later.
20090414 19:57:02< alink> *remove it from 
20090414 19:57:13< Soliton> alink: i don't think so since they use the same ID.
20090414 19:57:23< AnMaster> I mean, I like to know if next advancement is the end point or if there is further advancements
20090414 19:57:27< Soliton> alink: and as you can see in the screenshots none is shown currently.
20090414 19:57:30< AnMaster> if you see what I mean
20090414 19:58:02< Soliton> AnMaster: well, it's a deliberate decision by the one writing the WML...
20090414 19:58:03< alink> Soliton: I see a id='Dark Sorcerer DiD' but it some base_unit trick, I don't know how that works
20090414 19:58:12< AnMaster> Soliton, hm...
20090414 19:58:32< alink> Soliton: the submitter may didn't discover the normal Dark Sorcerer yet.  But I test that
20090414 19:58:35< Soliton> alink: oh, yeah my bad.
20090414 19:59:02< AnMaster> Soliton, one issue in UtBS is that there are lots of copies of "Elvish fighter" listed after a while
20090414 19:59:13< Soliton> there shouldn't.
20090414 19:59:17< AnMaster> yeah I know it is because recruit cost changes during the game
20090414 19:59:33< Soliton> i mean it was already fixed.
20090414 19:59:46< Soliton> if it doesn't work atm that is a regression.
20090414 19:59:52< AnMaster> Soliton, ah it was a few weeks ago I played it last time
20090414 20:01:31< alink> Soliton: yeah remove the hide_help=true shows 2 entries with only difference in the advance path. So hide_help must stay and we need to clean the advance field when empty
20090414 20:02:02< Soliton> alink: alright.
20090414 20:02:03< alink> [19:51:54] <Soliton> alink: maybe a simple task for gsoc'er. ;-)   <--have we a place where to drop such task ?
20090414 20:02:21< Soliton> alink: EasyCoding on the wiki.
20090414 20:04:39-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 20:05:43-!- Mythological [i=Mytholog@77.28.91.230] has quit [Read error: 110 (Connection timed out)]
20090414 20:11:59< Soliton> alink: hmm, still then you can not see what the DiD DA advances to?
20090414 20:12:33< Soliton> alink: best would be to use the same ID if possible and remove hide_help=true.
20090414 20:12:41< Soliton> alink: i'm not sure that would work right though.
20090414 20:12:48< alink> by design since "Dark Sorcerer DiD" use hide_help
20090414 20:13:01< Soliton> but it's bad design!
20090414 20:13:43< Soliton> you should be able to see what to advance to.
20090414 20:13:55< alink> wait if we remove the hide_help=true from Dark Sorcerer DiD, before disover it, its entry will be hidden, but the link visible with a (?)
20090414 20:14:21< Soliton> sure, as usual?
20090414 20:14:58< alink> i mean it will be half-hidden for a new player, is it better ?
20090414 20:15:05< YogiHH> please, don't use the same ID for two different units!
20090414 20:15:19< Soliton> YogiHH: they aren't really!
20090414 20:15:20< euschn> im off for today, see you tommorow
20090414 20:15:23-!- euschn [n=chatzill@85-127-129-168.dynamic.xdsl-line.inode.at] has quit ["ChatZilla 0.9.84 [Firefox 3.0.7/2009030423]"]
20090414 20:15:52< Soliton> YogiHH: the point is that we really want to overwrite the mainline unit.
20090414 20:15:53< alink> Soliton: ah stupid I just said earlier that we can't remove it without causing double entries :-/
20090414 20:16:26< Soliton> alink: if we use the same ID there shouldn't?
20090414 20:16:52< alink> you mean use the normal unit type ?
20090414 20:17:18< alink> or create another unit type with the same id (which is indeed bad)
20090414 20:17:27< Soliton> the latter.
20090414 20:17:41< alink> mmmh
20090414 20:17:46< YogiHH> Soliton: if we don't want to change the unit, but the way it is handled by the game, then the controlling information (hide_help) is in the wrong place, i'd say
20090414 20:18:12< Soliton> YogiHH: yes, i want to remove the hide_help part.
20090414 20:18:24< CIA-30> torangan * r34911 /branches/1.6/po/wesnoth/id.po: indonesian translation update
20090414 20:19:14< Soliton> the other solution is to have DiD specific parts in the mainline DA line but that is ugly, too.
20090414 20:19:29< alink> what is 'do_not_list=yes' there is no code for that
20090414 20:19:50< Soliton> same as hide_help for some inexistant script.
20090414 20:21:25< Soliton> well, actually it looks like wmlunits requires both to be there for some reason.
20090414 20:22:44< Soliton> but i don't think that makes much sense.
20090414 20:24:41< alink> wesbot: log 25389
20090414 20:24:45< wesbot> esr * r25389 : Place do_not_list=yes where it will do some good later.
20090414 20:24:47< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=25389
20090414 20:26:29< Soliton> even in the diff you can see that it's pointless since it's added where hide_help is already there.
20090414 20:26:57-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out]
20090414 20:29:27< alink> mmh for each campaign provide a list of visible units (when discovered) ? Should also simplify to help to show only what's relevant to the campaign
20090414 20:30:05-!- ilor [n=user@wesnoth/developer/ilor] has quit [Read error: 110 (Connection timed out)]
20090414 20:30:14< alink> + I suppose that the code would be similar as the discovered_units filter from preferences
20090414 20:30:47< Soliton> so you just see units from that campaign in the help when playing it?
20090414 20:31:10< Soliton> that could be nice.
20090414 20:33:17< alink> yes if the WML specify it
20090414 20:33:17< alink> seems to make sense to me
20090414 20:33:24< alink> we could even add an option to auto add the advance tree of this unit list, so you just need to add level 1 or WML created units
20090414 20:34:01< alink> or some convention like list=goblin,thief+,yeti   to auto add the tree of thief
20090414 20:34:22< Soliton> for campaigns that works. for eras not so much.
20090414 20:34:44< Soliton> keeping the list uptodate might be annoying though.
20090414 20:34:58< alink> yes a little, indeed
20090414 20:36:04< alink> maybe a WMLlint-like tool can check which unit type are used by the campaign ?
20090414 20:36:23-!- Amu [n=smar@a88-113-60-192.elisa-laajakaista.fi] has joined #wesnoth-dev
20090414 20:37:10-!- Smar [n=smar@freenet/translator/finnish/Smar] has quit [Read error: 104 (Connection reset by peer)]
20090414 20:37:29< alink> or in-game with debug mode, when a unit is created but not present in the campaign list, show a warning WML-message 
20090414 20:38:08< Soliton> because people use debug mode to spawn valid units? :-P
20090414 20:38:42-!- stikonas [n=stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090414 20:40:44< alink> well, we could activate it for normal WML unit creation, it is already supposed to add it in the discovered units list when it's happen, but maybe this part is already buggy
20090414 20:53:03-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20090414 20:53:27< silene> hi
20090414 20:53:42< mordante> hi silene 
20090414 20:54:11-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)]
20090414 20:54:26-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 20:54:47< mordante> silene, regarding that reference problem, I told you the same cause yesterday (expect that I thought it was the config class) as Sapient this morning
20090414 20:55:43< silene> mordante: but config and vconfig are completely different beasts; you can't produce the bug with config::operator[]; hence why i was confused by what you were talking about
20090414 20:56:21< mordante> ah ok
20090414 20:57:08-!- elias [n=allefant@allegro/developer/allefant] has quit ["Leaving"]
20090414 20:58:12-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Read error: 110 (Connection timed out)]
20090414 20:58:38< silene> mordante: also, in the log you were citing, toragan was saying it was caused by the use of mutable in t_string; this was wrong: with vconfig::operator[], i can cause the bug to appear even if i remove mutable from t_string
20090414 20:59:35< mordante> silene, well I was citing that to show we had the problem before
20090414 21:00:00< mordante> silene, do you want to look into fixing it?
20090414 21:00:22< Ivanovic> re (almost, time for some lunch)
20090414 21:04:36< silene> mordante: i'm not sure it can be fixed easily; i could remove the reference from t_string::operator std::string() or use a proxy object as a result of vconfig::operator[], but both possibilities would have a nonnegligible runtime cost; c++0x would make it possible to fix it at no cost, but it will require a few more years; so i'm wondering, have there been occurrences of this bug that were not immediatly found by valgrind?
20090414 21:06:15< mordante> silene, I think others also had the problem it was hard to solve. It's now rather trivial to solve since we're aware of the problem only caused a lot of troubles to find it the first time
20090414 21:07:16< mordante> guess then we only should add a warning about the issue in the header (and I thought I already did that before :-/ )
20090414 21:08:55-!- Appleman1234 [n=Appleman@123-243-159-129.static.tpgi.com.au] has joined #wesnoth-dev
20090414 21:14:12< CIA-30> soliton * r34912 /branches/1.6/src/server/game.cpp: implemented a white list of valid chars for replay filenames
20090414 21:14:19< CIA-30> soliton * r34913 /branches/1.6/src/server/game.cpp: 
20090414 21:14:19< CIA-30> only don't display the ended game message when the user is an observer
20090414 21:14:19< CIA-30> and we're destructing the game; fixes odd games that are ended by observers
20090414 21:14:19< CIA-30> (all sides empty so there is no player in the game on start)
20090414 21:14:23< CIA-30> soliton * r34914 /branches/1.6/src/server/ (game.cpp game.hpp): fixed a memory leak on advancing a game and clear the history early when saving a replay
20090414 21:17:46< CIA-30> soliton * r34915 /trunk/src/server/game.cpp: implemented a white list of valid chars for replay filenames
20090414 21:17:53< CIA-30> soliton * r34916 /trunk/src/server/game.cpp: 
20090414 21:17:53< CIA-30> only don't display the ended game message when the user is an observer
20090414 21:17:53< CIA-30> and we're destructing the game; fixes odd games that are ended by observers
20090414 21:17:53< CIA-30> (all sides empty so there is no player in the game on start)
20090414 21:17:58< CIA-30> soliton * r34917 /trunk/src/server/ (game.cpp game.hpp): fixed a memory leak on advancing a game and clear the history early when saving a replay
20090414 21:18:02-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20090414 21:36:13-!- martinproud [n=ancestra@97-116-111-81.mpls.qwest.net] has joined #wesnoth-dev
20090414 21:37:32-!- Elvish_Pillager [n=eli@66-189-40-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090414 21:42:30-!- edb [n=edb@169.12.95-79.rev.gaoland.net] has quit [Remote closed the connection]
20090414 21:47:33< CIA-30> mordante * r34918 /trunk/src/editor2/mouse_action.cpp: Fix a compiler warning.
20090414 21:47:37-!- JW1 [n=X@c-71-57-85-168.hsd1.il.comcast.net] has quit []
20090414 21:47:45< CIA-30> mordante * r34919 /trunk/src/editor2/editor_controller.cpp: Fix a compiler warning.
20090414 21:49:34< YogiHH> mordante: do you know any (technical) reason why all the dialogs are kept into one file?
20090414 21:50:23< mordante> YogiHH, no that's only for the old ones, I prefer 1 dialog per file (sometimes a sub dialog in the same file)
20090414 21:50:39< YogiHH> mordante: good :-)
20090414 21:52:01< YogiHH> mordante: what's the status of the savegame dialogs, are they expected to change to the new gui framework soon?
20090414 21:52:47-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090414 21:54:06< mordante> YogiHH, I haven't had much time to code lately... most Wesnoth time has been spend on gsoc
20090414 21:54:39< mordante> I first need to do some lowlevel fixes and after that I want to look at converting dialogs again
20090414 21:55:00< YogiHH> mordante: well, i was talking about the future but it still sounded like "not likely" at best ;-)
20090414 21:55:29< mordante> but I think ilor also wanted to look at that dialog since it doesn't work to nicely with drive letters on Windows
20090414 21:56:02< mordante> YogiHH, the problem is I have less coding time at the moment so don't want to promise too much
20090414 21:56:18< YogiHH> mordante: don't worry, i am not going to blame you :-)
20090414 21:56:50-!- JW1 [n=X@c-71-57-85-168.hsd1.il.comcast.net] has joined #wesnoth-dev
20090414 21:57:36< mordante> I know ;-)
20090414 22:03:34< YogiHH> silene, around?
20090414 22:05:34< silene> YogiHH: yes
20090414 22:06:53< YogiHH> silene: Would it make sense to have the parser only return a subset out of a WML file or is that complicated? The background is loading summary information out of a savegame file.
20090414 22:07:17-!- stikonas [n=stikonas@wesnoth/translator/stikonas] has quit [Remote closed the connection]
20090414 22:07:40< YogiHH> silene: atm, we have to read in the whole file for that
20090414 22:12:39< silene> YogiHH: it wouldn't be particularly complicated; but there is probably an even simpler way: just put your summary directly as a wml structure at the beginning of the file, the parser will stop once it has read it
20090414 22:13:20< YogiHH> silene: That's actually what i had in mind, but how do i make the parser stop?
20090414 22:14:12< YogiHH> or why shouldn't it read the rest?
20090414 22:14:19< silene> YogiHH: it should stop automatically once it encounters the [/summary] end of tag (or whatever its name); if it doesn't, i will just fix it
20090414 22:14:57< silene> the parser isn't supposed to keep going once it has parsed a complete wml object
20090414 22:16:30< YogiHH> silene: hmm, but doesn't it do that atm with a savegame? It starts with attributes and then has some root level tags. But they are all read in or is that done by some higher-level logic?
20090414 22:17:37< silene> YogiHH: hmm... yes, you are right, it assumes there is already an opened tag; so it puts all the structures at children of a single config object
20090414 22:17:40-!- thomas_sch [n=blacklot@p508BEA77.dip.t-dialin.net] has joined #wesnoth-dev
20090414 22:17:54< CIA-30> esr * r34920 /trunk/ (11 files in 8 dirs): 
20090414 22:17:54< CIA-30> Change the terrain definition tag from [terrain] to [terrain_type].
20090414 22:17:54< CIA-30> This is paraallel to the change from [unit] to [unit_type], and for similar
20090414 22:17:54< CIA-30> reasons - reduces ambiguity, enables better WML sanity checking.
20090414 22:19:12-!- martinproud [n=ancestra@97-116-111-81.mpls.qwest.net] has left #wesnoth-dev []
20090414 22:19:36-!- ancestral [n=ancestra@97-116-111-81.mpls.qwest.net] has joined #wesnoth-dev
20090414 22:20:43-!- [Relic] [n=[Relic]@adsl-76-229-202-137.dsl.milwwi.sbcglobal.net] has joined #wesnoth-dev
20090414 22:21:57< [Relic]> Hello :)
20090414 22:22:29< mordante> hi [Relic] 
20090414 22:23:32< silene> YogiHH: i see two possibilities, either you use your own std::istream that stops when you have reached the end of summary, or you had some hack to the parser (for instance, a parameter that counts how many children should be read from the input stream)
20090414 22:24:17-!- stikonas [n=stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090414 22:25:03-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 22:25:09< esr> mordante: (and everybody else) it is possible I just introduced some bugs into terrain interpretation, so be watchful.  
20090414 22:25:22< [Relic]> :)
20090414 22:25:43< mordante> great :-/
20090414 22:25:55< YogiHH> silene: the second alternative sounds more straightforward to me
20090414 22:26:43< YogiHH> esr: if you did, what would the result be like?
20090414 22:27:49-!- fendrin [n=fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20090414 22:27:51-!- VladimirSlavik [n=chatzill@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20090414 22:27:57< esr> Um...lists of terrain types that should be populated from the core WML being empty is the most likely error.  Nothing complivcated or subtle, and I did test.
20090414 22:28:03< fendrin> hi
20090414 22:28:11< esr> hi fendrin
20090414 22:28:17< silene> YogiHH: yes, it certainly is
20090414 22:28:19-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090414 22:28:57< mordante> hi fendrin 
20090414 22:29:14< YogiHH> mordante: do you know if the dialogs within dialogs.cpp are independent of each other? I would like to take out the savegame dialogs from there.
20090414 22:30:08< mordante> YogiHH, no idea, I prefer not to touch that code too much ;-)
20090414 22:30:26< YogiHH> i see :-)
20090414 22:31:40-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090414 22:32:19-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)]
20090414 22:32:21< fendrin> esr: How can I reproduce the bug with the unknown terrain types in DM that doesn't lead to a game exit?
20090414 22:32:23< CIA-30> silene * r34921 /trunk/src/game.cpp: Moved loadscreen handler after language initialization.
20090414 22:32:30< CIA-30> silene * r34922 /trunk/src/image.cpp: Added transparent handling of localized pictures. (Patch #1154 from Chusslove.)
20090414 22:32:34< CIA-30> silene * r34923 /trunk/src/ (loadscreen.cpp loadscreen.hpp): Converted loadscreen to use the generic image loading system. (Patch #1154 from Chusslove.)
20090414 22:32:55< CIA-30> crab * r34924 /trunk/src/ (ai/ai_manager.cpp ai/ai_manager.hpp team.cpp): 
20090414 22:32:55< CIA-30> AI Refactoring: removed some code duplication during AI construction.
20090414 22:32:55< CIA-30> Now ai_manager is the sole interface to AI module from the point of view of Wesnoth.
20090414 22:33:04< esr> fendrin: Eh?  It never leads to game exit for me.  Just load scenario 19.
20090414 22:33:45< mordante> Crab_, regarding the movement of the ai code, next time please notify a bit more upfront
20090414 22:33:47< fendrin> No proplem with 19 here.
20090414 22:34:05< fendrin> I'll do an svn update and recompile.
20090414 22:34:10< Crab_> mordante: how much upfront ? 
20090414 22:34:11< mordante> Crab_, if somebody has patches laying around or objections they can react before the change
20090414 22:35:05< mordante> somewhere between half a week and a week I'd say 
20090414 22:35:13< Crab_> mordante: ok )
20090414 22:35:23-!- blacklotus89 [n=blacklot@p508BBD12.dip.t-dialin.net] has quit [Read error: 110 (Connection timed out)]
20090414 22:35:35< Crab_> I understand that not all dev's read all icq discussions...
20090414 22:35:36< mordante> and I agree with silene to drop the ai prefix 
20090414 22:36:19< mordante> you can notify on the dev-ml upfront
20090414 22:36:34< Crab_> mordante: I've notified dev-ml, but not-so-much-upfront )
20090414 22:36:39< Crab_> only 12h
20090414 22:36:52< CIA-30> soliton * r34925 /trunk/utils/mp-server/run_server: first rotate the pid file then write the new PID to it
20090414 22:37:12< mordante> Crab_, I know hence the "a bit more upfront" ;-)
20090414 22:38:27< mordante> 12hours means for me that it was unknown to me when I went to bed last night and done when I returned from work
20090414 22:38:27< Crab_> mordante: regarding the "drop the ai prefix" - I'd want to hear more opinions, since me and Dragonking are in favor of retaining them, at least for now.
20090414 22:38:43< silene> Crab_: why?
20090414 22:38:55< mordante> Crab_, no problem, just wanted to tell my opinion
20090414 22:39:16< Crab_> mordante: "if we are talking about actions.cpp, which one ? that one in src/ai ? or that one in /src ?"
20090414 22:40:03< Crab_> mordante: with r34924 committed, the 'rest of the game' only includes one of the AI files - ai/ai_manager.hpp
20090414 22:40:28< silene> Crab_: it's the perfect time, you just broke history tracking and so on, you may as well as fix the names now rather than break it again later
20090414 22:40:45< mordante> I normally type the path so ai/actions.cpp or actions.cpp
20090414 22:41:15< silene> Crab_: completely unrelated; in your lua code, since you have called set_wml_var_metatable(_G), you don't have to write wesnoth.get_variable("test_id"), you can simply type test_id; also don't forget to mark the preload events as first_time_only=no, just in case a user decides to save/load an arena
20090414 22:41:57< Crab_> silene: history tracking is not quite dead - http://svn.gna.org/viewcvs/wesnoth/trunk/src/ai/ai.cpp?rev=34899&view=log
20090414 22:42:43< Crab_> silene: I agree that now is a perfect time for fixing the names. I'd like to hear more opinions about "why do so?" (esp. from those devs who will work with ai code)
20090414 22:43:20< silene> Crab_: i wasn't thinking about the log itself, i was thinking about things like "blame"
20090414 22:43:45< Soliton> blame works fine over file moves.
20090414 22:43:46< Crab_> silene: git blame works ok )
20090414 22:44:03< Soliton> but digging into history will be a bit more cumbersome over file moves.
20090414 22:44:50< silene> Crab_: you are cheating, try "git svn blame" ;-)
20090414 22:45:15< Crab_> silene: git svn blame works too ))
20090414 22:45:27< Crab_>  silene: "also don't forget to mark the preload events as first_time_only=no, just in case a user decides to save/load an arena" - is lua state persisted when saving/loading ?
20090414 22:46:41< mordante> silene, I think git would be even better in tracking it, and git annotate works as expected
20090414 22:47:44< fendrin> esr: Still no error at 19 after recompiling and cleaning the data dir. 
20090414 22:47:56< esr> How odd.
20090414 22:48:05< esr> Let me try resyncing.
20090414 22:48:26< Crab_> silene: "svn blame" works too, without problems
20090414 22:48:53< fendrin> Maybe you should delete your data dir as well. Artifacts in there gave me some trouble in the past.
20090414 22:49:01< silene> Crab_: no, it isn't; but because of set_wml_var_metatable, there is nothing that looks like a standard lua state anyway; so you just put the function definitions inside preload events, and scalar and tables are automatically handled through wml variables (which also means they are visible from wml code, and reciprocally)
20090414 22:49:22< silene> Crab_: that's good then; there was a time where it wasn't so
20090414 22:50:41< Crab_> silene: so, that table I'm populating is persisted as a WML var ?
20090414 22:50:55< Crab_> it is a local variable there..
20090414 22:51:03< Crab_> (there = in lua)
20090414 22:51:03< silene> Crab_: no, it is a local variable
20090414 22:51:16< silene> Crab_: but that's not important, since it's created at preload time
20090414 22:51:34-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090414 22:51:42< silene> does that make sense?
20090414 22:51:45< fendrin> esr: please start scenario 7. Nice effect.
20090414 22:51:49< Crab_> silene: i
20090414 22:52:14< Crab_> i'll make it one time only' and test, and look at the save. I think it'll make sense then )
20090414 22:53:42< esr> fendrin: nuking data and resyncing...
20090414 22:54:07-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev
20090414 22:55:10< Crab_> silene: ok, got it )
20090414 22:55:42< silene> Crab_: you won't see anything in the save (except for test_id); however, what you will experience when reloading the game is messages like "trying to access the fire_event field of W, which is a nil value"
20090414 22:56:00< Crab_> yes, i understand now.
20090414 22:56:36< Crab_> thanks
20090414 22:56:51< silene> i should probably enforce first_time_only for preload events, since i can't imagine a case where it makes to have it to yes
20090414 22:56:57< silene> +sense
20090414 22:57:18< Crab_> silene: to do a special bonus to those ppl who complete the scenario without save/load :)
20090414 22:57:32< silene> lol
20090414 22:57:42< fendrin> Crab_: Not a bad idea at all.
20090414 22:58:20< Crab_> silene: maybe just change the default value of first_time_only for preload events ?
20090414 22:59:31< silene> seems like a good idea
20090414 22:59:42-!- Reisiger [n=Reisiger@adsl-89-217-175-244.adslplus.ch] has quit ["Verlassend"]
20090414 23:00:01< fendrin> esr: About 7, was there a wml change that causes that mess? Or is location filtering broken in the engine?
20090414 23:02:22< esr> fendrin: Shit I just broke location filtering.  I was afaraid something like this would happen.  See r34920 
20090414 23:02:49< esr> Well, at least now I have a test casse...
20090414 23:03:09< fendrin> It's just great.
20090414 23:03:45< esr> I did say any breakage would not be complicated or subtle :-)
20090414 23:04:48< esr> Ah, I think I may have found it.
20090414 23:05:29< mordante> night
20090414 23:05:46-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"]
20090414 23:06:10< CIA-30> jhinrichs * r34926 /trunk/src/ (5 files): 
20090414 23:06:10< CIA-30> Savegame reorganization Step 1: Providing a simpler interface to saving and loading.
20090414 23:06:10< CIA-30> Move gamestatus.cpp::load_game_summary to savegame.cpp and get rid of gamestatus.cpp::read_save_file.
20090414 23:06:46< alink> Soliton: about the previous hide help problem, I just tested a simple prototype using [+units]hide_help=Dark Adept, Dark Sorcerer[units] , seems to fix the problem. Plus, easy to code and low WML maintenance (compared to the initial show_help_list)
20090414 23:06:58< Ivanovic> anything special to keep in mind for the 1.6.1 announcement?
20090414 23:07:05< esr> Nope, that didn't fix it.  Damn.
20090414 23:07:07< Ivanovic> any news regarding world domination?
20090414 23:07:39< VladimirSlavik> Ivanovic, I guess now is not good time to ask about translations?
20090414 23:07:46< Soliton> alink: ah yes, i guess that works, too.
20090414 23:08:46-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 60 (Operation timed out)]
20090414 23:09:12< alink> Soliton: I can add fancy options later, but I like its simplicity (both code and usage)
20090414 23:09:27< esr> fendrin: Found it...
20090414 23:09:28< CIA-30> esr * r34927 /trunk/src/terrain_filter.cpp: Un-break terrain filtering.
20090414 23:09:39< crimson_penguin> Ivanovic: probably not "big" enough to mention, but on my end: the server is now included, and it should work on G3s
20090414 23:09:58< fendrin> esr: error in 19 is gone as well?
20090414 23:10:01< alink> Ivanovic: maybe mention that the bug with the missing faction column is only fixed if host use 1.6.1
20090414 23:10:12< esr> I need to check that.
20090414 23:10:18< YogiHH> i am off, too, night everyone
20090414 23:10:44-!- YogiHH [n=chatzill@d085178.adsl.hansenet.de] has left #wesnoth-dev []
20090414 23:11:32< esr> fendrin: Alas, no...
20090414 23:11:37< esr> 20090414 17:09:49 error config: Illegal character in map: (Qea) 'Qea'
20090414 23:11:39< esr> 20090414 17:09:49 error config: map could not be loaded: Illegal character found in map. The scenario cannot be loaded.
20090414 23:11:53< esr> However, it does loasd and run.
20090414 23:12:21< fendrin> That is strange I never saw wesnoth continuing after an terrain error.
20090414 23:12:51< Ivanovic> alink: noone will notice this...
20090414 23:12:58< alink> Ivanovic: otoh that's not a very important bug, it's just that 1.6.1 users may notice UI difference depending against who he plays
20090414 23:13:00< fendrin> Do you start with commandline options?
20090414 23:13:10< cjhopman> any of the other students here compete in the icpc?
20090414 23:13:18< Ivanovic> VladimirSlavik: depends on what you want to talk about
20090414 23:13:20< Ivanovic> ;)
20090414 23:13:42< alink> Ivanovic: probably indeed
20090414 23:14:07< VladimirSlavik> Ivanovic: not release.
20090414 23:14:12< alink> Ivanovic: and worst case scenario, he fills a invalid bugreport 
20090414 23:14:50-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090414 23:14:59-!- Elvish_Pillage2 [n=eli@66-189-40-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090414 23:16:08< esr> fendrin: What is more puzzling is why I get this error and you do not.
20090414 23:16:55< Ivanovic> VladimirSlavik: i know that translation stuff is not really coupled to releases
20090414 23:17:08< Ivanovic> VladimirSlavik: i meant with this that you should ask and eventually i will react
20090414 23:18:00< VladimirSlavik> well duh, I need to know why is wescamp dead and how to translate on umc-dev
20090414 23:19:46< fendrin> esr: a local change you didn't commit?
20090414 23:20:16< esr> fendrin: I don't think I have any uncommitted changes.  Checking...
20090414 23:21:32< esr> fendrin: Nope, not a one.
20090414 23:21:38< Ivanovic> VladimirSlavik: mail david about this
20090414 23:21:44-!- alink [n=alink@wesnoth/developer/alink] has quit [Remote closed the connection]
20090414 23:21:52< Ivanovic> VladimirSlavik: that is: probably something about the addon server still has to be done or such
20090414 23:21:55< esr> And I just nuked and reloaded data/, too.
20090414 23:21:57< VladimirSlavik> Ivanovic: i did and he does not know anything
20090414 23:21:58< Ivanovic> wescamp in general is alive i'd say
20090414 23:22:10< Ivanovic> no idea what you mean with "is dead" then
20090414 23:22:11< Ivanovic> ;)
20090414 23:22:30< Ivanovic> since the files on the current 1.6 server are probably the ones liked at "trunk" in the g.w.o view
20090414 23:23:43< VladimirSlavik> well... that would be an explanation!
20090414 23:24:22< Ivanovic> i *think* i made Soliton look into this strang "flipping server around" stuff for the addon server
20090414 23:24:37< Ivanovic> any maybe mordante knows if anything has to be done to get the upload stuff working nicely again
20090414 23:25:01< VladimirSlavik> wait, it is broken?
20090414 23:25:17-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit ["Konversation terminated!"]
20090414 23:25:20< VladimirSlavik> then it's clear :D
20090414 23:25:34< Ivanovic> i am not *SURE* what the status is
20090414 23:25:50< Ivanovic> i only know that the stuff is definitely not uploaded into the 1.6 branch in wescamp
20090414 23:26:03< VladimirSlavik> same here
20090414 23:26:06< Ivanovic> it *might* be that the stuff from the 1.6 addon server is still uploaded to trunk
20090414 23:26:12-!- thespaceinvader_ [n=chatzill@91.108.180.204] has joined #wesnoth-dev
20090414 23:26:27< Ivanovic> or it might be that there is a new addon server for trunk and that one is uploading to trunk in wescamp, though i don't think so
20090414 23:26:53-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Nick collision from services.]
20090414 23:26:55-!- gabm [n=gabriel@132.207.233.105] has joined #wesnoth-dev
20090414 23:27:06-!- thespaceinvader_ is now known as thespaceinvader
20090414 23:28:07< VladimirSlavik> thanks, I will direct people to trunk files when asked then, worst case it's still old
20090414 23:29:16-!- happygrue [n=Wintermu@wesnoth/developer/wintermute] has joined #wesnoth-dev
20090414 23:30:23< fendrin> esr: Do you still have a premainline version of DM in your .wesnoth directory?
20090414 23:30:43< esr> fendrin: Checking...
20090414 23:31:23< fendrin> esr: even if not you could try with .wesnoth moved away.
20090414 23:31:40-!- Elvish_Pillager [n=eli@66-189-40-122.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090414 23:31:56< esr> fendrin: Checking...
20090414 23:32:20< VladimirSlavik> good night
20090414 23:32:22-!- VladimirSlavik [n=chatzill@wesnoth/translator/VladimirSlavik] has left #wesnoth-dev []
20090414 23:34:53< Ivanovic> everyone: please check if any problems are left with the announcement: http://www.wesnoth.org/forum/viewtopic.php?f=5&t=25058
20090414 23:37:17< esr> fendrin: I tried moving .wesnoth.  That dfixed it.  But it is not a stale copy of the add-on, as I don't have any of those.  Nor is it a cache problem; I tried removing that.  *Weird*
20090414 23:38:00-!- ABCD [n=ABCD@wikipedia/ABCD] has quit ["No Ping reply in 30 seconds."]
20090414 23:38:26-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev
20090414 23:38:35< ancestral> "translations and ships several updated graphics" maybe "translations and ships, plus updated graphics" ?
20090414 23:40:41< fendrin> esr: Can you perform a binary search over the addons that are installed in your moved .wesnoth?
20090414 23:41:16< esr> fendrin: I believe I have *no* addoons installed.  Checking...
20090414 23:41:33-!- Morian_ [i=romain@bezut.info] has joined #wesnoth-dev
20090414 23:43:21< esr> fendrin: Yes, that is zero (0) add-ins.
20090414 23:44:01-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20090414 23:46:09< fendrin> So there are only savefiles, the cache and the preferences stored in that dir?
20090414 23:46:38< Ivanovic> okay, updated the frontpage, too
20090414 23:46:40< Ivanovic> release should be done
20090414 23:47:07< esr> fendrin: See http://rafb.net/p/o6ExUN93.html
20090414 23:49:18< fendrin> The 4 files in editer, are they maps?
20090414 23:49:32< esr> Looking...
20090414 23:50:40-!- Sirp [n=me@wesnoth/developer/dave] has joined #wesnoth-dev
20090414 23:50:40< CIA-30> ivanovic * r34928 /trunk/po/ (wesnoth/id.po wesnoth-tutorial/sk.po): updated Indonesian and Slovak translation
20090414 23:50:46< esr> fendrin: Don't know which you mean.
20090414 23:51:13< fendrin> ./data/maps:
20090414 23:51:15< fendrin> total 4
20090414 23:51:16< CIA-30> ivanovic * r34929 /branches/1.6/ (changelog players_changelog po/wesnoth-tutorial/sk.po): updated Slovak translation
20090414 23:51:22< esr> Looking
20090414 23:51:29< fendrin> ./editor:
20090414 23:51:30< fendrin> total 4
20090414 23:53:28< esr> fendrin: Undrer data/maps I see only one thing, which is a multiplayer directory.  How are we miscommunicating?
20090414 23:54:16-!- ilor [n=user@wesnoth/developer/ilor] has quit ["night"]
20090414 23:54:29< fendrin> Seems like I don't understand the output you posted.
20090414 23:55:51-!- happygrue [n=Wintermu@wesnoth/developer/wintermute] has quit [Read error: 110 (Connection timed out)]
20090414 23:55:55< fendrin> I guess a binary search over all that files and later over the content of that file is your best bet to find the bug if you realy want to.
20090414 23:56:14-!- Morian [i=romain@bezut.info] has quit [Read error: 110 (Connection timed out)]
20090414 23:56:23< fendrin> That should be scriptable, even the wesnoth test part of it ...
--- Log closed Wed Apr 15 00:00:22 2009