--- Log opened Fri May 22 00:00:37 2009
20090522 00:06:49< esr> Aaaarrrgggghhh!!!  I HATE C++!!!
20090522 00:09:13-!- wesbot changed the topic of #wesnoth-dev to: 61 bugs, 241 feature requests, 11 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090522 00:10:25-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 00:15:43-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection]
20090522 00:18:02< ilor_> esr: still that segfault or a new one?
20090522 00:18:40< loonycyborg> What's xgrep?
20090522 00:19:01< esr> No, I think I figured out the segfault.  This time I can't figure out wgy the &^$#@! it;s calling a particular class initiallizer when it is.
20090522 00:19:34< esr> loonycyborg: xgrep is a carnivotous typo.
20090522 00:20:04< esr> God I wish Wesnoth was written in something else.  *Anything* else...
20090522 00:20:19< loonycyborg> Intercal?
20090522 00:21:04< esr> If it were wtritten in INTERCAL *I COULD FIX THE FUCKING COMPILER*!
20090522 00:21:50< ilor_> esr: can you factor out a testcase for the issue you're having now? 
20090522 00:22:00< ilor_> or point tosome relevant lines in a paste ;)
20090522 00:23:05< esr> http://rafb.net/p/dIQZqS74.html ; gui_dialog initialization failure on line 558.
20090522 00:23:49< Ivanovic> n8
20090522 00:24:11-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090522 00:24:59< ilor_> esr: the default ctor of the gui::dialog is called there, is that somehow unexpected?
20090522 00:25:41< esr> ilor_: Yes, I don't have any idea why it's being called there.
20090522 00:26:35< ilor_> it's a member, and there is no explicit constructor call in the initializer list, so the default ctor is used
20090522 00:27:35< ilor_> all the members get constructed before execution gets to the opening brace of the ctor
20090522 00:28:00< esr> Sifgh.  What do I have to do to avoid this?  Change the vainternal variable to a pointer to the class?
20090522 00:28:09< esr> class type, I meam?
20090522 00:28:39< ilor_> or you can call the constructor you need 
20090522 00:29:39< esr> Trired that befoore That's where the segfault was ghapppebing. So I'm attempting to defer dialog initialization until after we know there's a nonempty item list.
20090522 00:30:51< ilor_> a pointer then, possibly a boost::scoped_ptr to avoid the manual labor with freeing it
20090522 00:31:18< esr> Grrr...I don't know how to use those.
20090522 00:31:39< ilor_> unless, and I doubt it, you want to do the checking via some delightful ?: constructsin the initializer list
20090522 00:32:47< ilor_> esr: basically, declare the member as boost::scoped_ptr<type>, and use m_.reset(new type(..))
20090522 00:33:04< ilor_> esr: other than that use it like a normal pointer with ->
20090522 00:35:11< esr> ilor_: Perhaps there's a simpler way....
20090522 00:36:30< ilor_> esr: it's a bit of strange syntax in two places and that's about it
20090522 00:40:37< esr> Nope, the fscking segfault is back again.  
20090522 00:40:56< ilor_> what've you got now'
20090522 00:40:57< ilor_> ?
20090522 00:41:15< esr> http://rafb.net/p/2OzAp284.html
20090522 00:42:27< esr> Somethings wrong with the dialog initialization.  Can't figure out what.  Symptom is a segfault when the sghhow() member is called.  To reproduce, just build with this and click the Load Game button.
20090522 00:50:44< ilor_> esr: the build is slow and I need to get some sleep, try to catch me tomorrow and I'll look into it
20090522 00:51:04< esr> Thanks
20090522 01:02:09< ilor_> esr, found a bug as I was about to shutdown ;)
20090522 01:02:24< esr> ?
20090522 01:02:26< ilor_> 595 lmenu_.set_menu(items, &sorter);
20090522 01:02:43< ilor_> you're taking the address of a stack variable (sorter)
20090522 01:03:14< ilor_> so once the program leaves the constructor, lmenu_ is left with a pointer to garbage
20090522 01:03:40< ilor_> unless the sorter arg is passed by pointer for some other reason
20090522 01:04:01< esr> Hmmm.... do you have a suggested fix?  If not, I can attempt one.
20090522 01:04:11< ilor_> ditto for the save_preview_pane
20090522 01:04:26< ilor_> yeah, make these vars members of the class instead of vars in the ctor
20090522 01:04:53< esr> Ah. 
20090522 01:04:56< esr> Yes.
20090522 01:05:05< ilor_> there's no need to make them dynamic, but there's a need to make them valid for as long as lmenu_ lives
20090522 01:05:38< esr> Of course in the original code they wertre all in one function scopem, so auto wasn't a problem. I'll attempt this.
20090522 01:06:09< ilor_> I'm fairly certain the pane thing is the segfault, I gt a debug build and the backtrace points to a line of code in gui::dialog that chacks something in a pane
20090522 01:07:04< esr> Seems likely, yes.
20090522 01:08:16< esr> Must eat dinner.  Will hack at it more afterwards.
20090522 01:08:49< esr> Chapter 37 in "Why I hate languages with manual memory allocation"....
20090522 01:09:12< ilor_> and alas, an automatic variable caused harm ;)
20090522 01:09:33< ilor_> really need to sleep now, night
20090522 01:12:48-!- ilor_ [n=ilor@aur115.neoplus.adsl.tpnet.pl] has quit ["Konversation terminated!"]
20090522 01:13:04-!- ilor_ [n=ilor@aur115.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20090522 01:13:06-!- ilor_ [n=ilor@aur115.neoplus.adsl.tpnet.pl] has quit [Client Quit]
20090522 01:27:04-!- BenUrban [n=benurban@c-68-55-19-224.hsd1.md.comcast.net] has joined #wesnoth-dev
20090522 01:32:48< loonycyborg> Indeed.. Why does gui::menu pass sorter by pointer? Passing and storing it by const reference would prevent those screwups..
20090522 01:39:27< loonycyborg> s/and storing//
20090522 01:48:44-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit [Read error: 60 (Operation timed out)]
20090522 01:48:51< loonycyborg> Oops! In this case pointers are required because sorter class is polymorphic.
20090522 01:49:23-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit [Read error: 113 (No route to host)]
20090522 01:49:40-!- Polarina [n=polarina@wesnoth/translator/Polarina] has joined #wesnoth-dev
20090522 02:05:07-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzz"]
20090522 02:05:43-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection]
20090522 02:19:08-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["Tengo que ir... Yeahzorz..."]
20090522 02:33:05-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit [Client Quit]
20090522 02:59:17-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090522 03:11:26-!- happygrue_ [n=George@c-67-176-145-41.hsd1.in.comcast.net] has joined #wesnoth-dev
20090522 03:11:31-!- happygrue [n=George@wesnoth/developer/wintermute] has quit [Read error: 104 (Connection reset by peer)]
20090522 03:12:01-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090522 03:16:03-!- Elvish_Pillage2 [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090522 03:16:10-!- Elvish_Pillage2 [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has quit [Read error: 104 (Connection reset by peer)]
20090522 03:26:46-!- esr [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Remote closed the connection]
20090522 03:31:59-!- Elvish_Pillager [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090522 03:33:46-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090522 03:51:32-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit ["The man who smiles when things go wrong has thought of someone to blame it on."]
20090522 04:03:30-!- happygrue_ [n=George@c-67-176-145-41.hsd1.in.comcast.net] has quit [Read error: 104 (Connection reset by peer)]
20090522 04:07:44-!- fabi [n=fabi@e179204085.adsl.alicedsl.de] has joined #wesnoth-dev
20090522 04:08:51-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Read error: 60 (Operation timed out)]
20090522 04:23:29-!- esr [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20090522 04:47:32-!- [Relic] [n=[Relic]@adsl-76-230-212-46.dsl.milwwi.sbcglobal.net] has joined #wesnoth-dev
20090522 04:48:22< [Relic]> Hello :)
20090522 04:57:08-!- Ivanovic_ [n=ivanovic@dtmd-4db2cd69.pool.einsundeins.de] has joined #wesnoth-dev
20090522 05:02:01-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 05:09:01-!- Chusslove_ [n=Chusslov@brsg-d9beede5.pool.mediaWays.net] has joined #wesnoth-dev
20090522 05:12:27-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)]
20090522 05:13:06-!- Ivanovic_ is now known as Ivanovic
20090522 05:18:16-!- norbert_ [n=norbert_@82-171-70-54.ip.telfort.nl] has joined #wesnoth-dev
20090522 05:18:22< norbert_> hi, I have a question
20090522 05:18:37< norbert_> I'm playing Colosseum (MP) right now, the last level and the AI is painfully slow
20090522 05:18:57< norbert_> is there any known way to prevent this with the current game/code?
20090522 05:19:06< norbert_> like, picking certain characters or something?
20090522 05:21:14< norbert_> the AI calculations are done on the machine of the person that hosts the play?
20090522 05:22:08-!- Chusslove [n=Chusslov@brsg-d9befab4.pool.mediaWays.net] has quit [Read error: 110 (Connection timed out)]
20090522 05:26:21-!- Dopppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has joined #wesnoth-dev
20090522 05:34:11< norbert_> it was around midnight when we started and it's 05:30 now
20090522 05:34:21< norbert_> takes several minutes just for one move
20090522 05:38:48-!- Doppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has quit [Connection timed out]
20090522 05:39:05-!- norbert_ [n=norbert_@82-171-70-54.ip.telfort.nl] has quit ["Leaving"]
20090522 05:41:49-!- Dopppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has quit []
20090522 05:42:16-!- Doppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has joined #wesnoth-dev
20090522 05:55:55-!- silene [n=plouf@ASte-Genev-Bois-152-1-70-124.w86-198.abo.wanadoo.fr] has joined #wesnoth-dev
20090522 07:13:42-!- karl_m [n=karlm@252.23.233.220.exetel.com.au] has joined #wesnoth-dev
20090522 07:18:20-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090522 07:24:29-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [Read error: 60 (Operation timed out)]
20090522 07:27:54-!- [Relic] [n=[Relic]@adsl-76-230-212-46.dsl.milwwi.sbcglobal.net] has quit ["Leaving"]
20090522 07:30:23-!- Sirp [n=me@wesnoth/developer/dave] has quit ["leaving"]
20090522 07:46:18-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."]
20090522 08:10:10-!- maxy [n=maxy@80-219-0-199.dclient.hispeed.ch] has joined #wesnoth-dev
20090522 08:16:40-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090522 08:17:01-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090522 08:59:58-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20090522 09:00:11< mordante> morning
20090522 09:12:14-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has joined #wesnoth-dev
20090522 09:14:26-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090522 09:23:25< fabi> good morning mordante
20090522 09:23:31< mordante> hi fabi 
20090522 09:35:15-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev
20090522 09:35:18< euschn> hi
20090522 09:37:07< mordante> hi euschn 
20090522 09:41:42-!- stikonas [n=and@ctv-213-164-125-83.vinita.lt] has joined #wesnoth-dev
20090522 09:52:56< corn> dfranke: hey, I just wanted to give a status report since we haven't talked in a while
20090522 09:53:02< euschn> YogiHH: I gave staruml a try, and I like it so far - as you said, reverse engineering is handy
20090522 09:53:16< euschn> too bad there is no linux version, but I wouldnt mind using it nevertheless
20090522 09:54:45< corn> dfranke: I've created a scheme where SQL queries are first tried against a small subsample of the big stats table and then the result is put through an evaluator function specific to the query. if the evaluator says the result isn't good, it tries the next biggest sample size table
20090522 09:55:18< corn> dfranke: the sample size tables are dropped and regenerated nightly in a cronjob, right now there is a 1 million row table, a 100k row table, and a 10k row table
20090522 09:55:29< corn> the main stats db (as of april 20th) is 2.5 million rows
20090522 09:55:51< corn> I've also created really basic instrumentation, so I can look at how long it takes for this query process to work
20090522 09:56:41< corn> the next thing that I am going to implement is a page where you can generate new graphs by selecting what columns to use for the x and y axes, with potentially multiple y columns
20090522 09:57:09< corn> this way, users don't have to rely on developers to hardcode new graphs in
20090522 09:57:17< corn> it was something that crab_ and I discussed 2 weeks ago
20090522 09:58:03< corn> I have been working a lot slower than I'd like but I will definitely be able to finish this within a week
20090522 09:58:22< corn> after that, I'll make the whole thing spiffy and fitting the wesnoth site style
20090522 09:59:06< corn> afterwards, we can decide whether to do the killgraphs first or to add accounts and per-user information in
20090522 10:16:03-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090522 10:29:11< Ivanovic> moin
20090522 10:29:36-!- Baufo [n=quassel@62-47-149-208.adsl.highway.telekom.at] has joined #wesnoth-dev
20090522 10:29:37< Ivanovic> corn: i talked to dfranke yesterday and he said that he will try to talk a little more with you this weekend
20090522 10:29:56< Ivanovic> since he is finally getting well again
20090522 10:31:26< mordante> hi Ivanovic 
20090522 10:35:38< euschn> hi Ivanovic
20090522 10:56:18-!- loonybot [n=loonybot@79.139.246.175] has joined #wesnoth-dev
20090522 10:56:57-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090522 10:57:14-!- loonycyborg [n=sergey@79.139.246.175] has joined #wesnoth-dev
20090522 11:03:27-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev
20090522 11:04:19-!- Chusslove_ is now known as Chusslove
20090522 11:20:29-!- Baufo [n=quassel@wesnoth/developer/baufo] has quit [Remote closed the connection]
20090522 11:20:29-!- Elvish_Pillager [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090522 11:25:19-!- Baufo [n=quassel@62-47-149-208.adsl.highway.telekom.at] has joined #wesnoth-dev
20090522 11:45:44-!- fabi [n=fabi@wesnoth/developer/fendrin] has quit [Remote closed the connection]
20090522 11:47:18-!- Baufo [n=quassel@wesnoth/developer/baufo] has quit ["http://quassel-irc.org - Chat comfortably. Anywhere."]
20090522 11:47:39-!- Baufo [n=quassel@62-47-149-208.adsl.highway.telekom.at] has joined #wesnoth-dev
20090522 11:52:04< CIA-77> mordante * r35813 /trunk/src/gui/widgets/ (scrollbar_container.cpp scrollbar_container.hpp): 
20090522 11:52:04< CIA-77> Start to polish the scrollbar_container scrollbars.
20090522 11:52:04< CIA-77> Now that the old layout algorithm is removed this can be polished. This
20090522 11:52:04< CIA-77> is the first step and the polishing is still WIP.
20090522 11:58:38-!- yann [n=dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Read error: 110 (Connection timed out)]
20090522 12:09:33-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer]
20090522 12:09:48-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 12:16:09< CIA-77> mordante * r35814 /trunk/src/gui/widgets/ (grid_private.hpp helper.hpp): 
20090522 12:16:09< CIA-77> Move tconst_duplicator to another header.
20090522 12:16:09< CIA-77> I want to reuse this helper so moved it to the helper header. (Note
20090522 12:16:09< CIA-77> might move to another header later on.)
20090522 12:16:16< YogiHH> euschn: oops, wasn't aware that StarUML is windows only.
20090522 12:17:50< YogiHH> mordante: i have seen that there is a new-widget load game dialog that differs a little from the old one. Do you want to keep it that way or is it work in progress?
20090522 12:22:37-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection]
20090522 12:24:57-!- EdB [n=edb@115.117.88-79.rev.gaoland.net] has joined #wesnoth-dev
20090522 12:26:10-!- stikonas [n=and@ctv-213-164-125-83.vinita.lt] has joined #wesnoth-dev
20090522 12:26:12< mordante> YogiHH, not sure what you mea
20090522 12:26:14< mordante> mean*
20090522 12:29:56-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Read error: 104 (Connection reset by peer)]
20090522 12:29:56-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Read error: 104 (Connection reset by peer)]
20090522 12:46:42< CIA-77> mordante * r35815 /trunk/src/gui/widgets/ (3 files): Also add a private header for scrollbar_container.
20090522 13:05:34-!- Polarina [n=polarina@wesnoth/translator/Polarina] has joined #wesnoth-dev
20090522 13:14:06-!- ardesh_ [n=ardesh@port-92-206-79-227.dynamic.qsc.de] has quit [Read error: 60 (Operation timed out)]
20090522 13:18:52-!- ardesh_ [n=ardesh@port-92-206-79-227.dynamic.qsc.de] has joined #wesnoth-dev
20090522 13:34:46-!- yann [n=dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20090522 13:38:36-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20090522 14:24:14-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit ["ChatZilla 0.9.84 [Iceweasel 3.0.6/2009050519]"]
20090522 14:31:01-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev
20090522 14:42:21-!- EdB [n=edb@115.117.88-79.rev.gaoland.net] has quit [Remote closed the connection]
20090522 15:06:29-!- loonybot [n=loonybot@79.139.246.189] has joined #wesnoth-dev
20090522 15:07:00-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090522 15:07:29-!- loonycyborg [n=sergey@79.139.246.189] has joined #wesnoth-dev
20090522 15:10:34-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"]
20090522 15:22:14< Turuk> hmm
20090522 15:22:26< mordante> ??
20090522 15:22:30< Turuk> wesnoth.org down
20090522 15:23:04< mordante> confirmed
20090522 15:23:06< loonycyborg> I can ssh to it.
20090522 15:23:39< mordante> Soliton, Ivanovic server seems to have problems again
20090522 15:25:09< Soliton> works fine here.
20090522 15:25:34< Turuk> wtf
20090522 15:25:37< Turuk> Now it works again
20090522 15:25:56< Soliton> i've reconfigured apache 2 minutes ago. maybe you tried just then.
20090522 15:26:01< Turuk> Ah
20090522 15:26:03< Turuk> Most likely
20090522 15:28:14< mordante> yes I did it about 2 minutes ago and works for me again
20090522 15:29:14< euschn> YogiHH: http://stud3.tuwien.ac.at/~e0204097/wesnoth/gamestate_redesign1.uml - this is my first go at the redesign of the game_state class, looking forward to your comments. basically I have merged gamestatus into game_state and player_info into team_info
20090522 15:30:07< euschn> I also added 2 of the 4 functions of config_adapter. I thought about about the other 2 and think it would be best to move them to savegame and controller_base respectively
20090522 15:32:14< euschn> YogiHH: one thing I am still thinking about is the size of game_state: with the addition of gamestatus its grown pretty big. One idea would be to collect all the fields and functions concerning time of day in a separate class/struct - whats your opinion on this?
20090522 15:33:13< euschn> one idea to make it smaller, that is
20090522 15:36:55< CIA-77> mordante * r35816 /trunk/src/gui/widgets/scrollbar_container.cpp: 
20090522 15:36:55< CIA-77> Don't show scrollbars if they don't help.
20090522 15:36:55< CIA-77> In certain cases the reduce_height showed the scrollbars, which
20090522 15:36:55< CIA-77> increased the height of the widget instead of reducing it. This happened
20090522 15:36:55< CIA-77> with a scrollbar_label with one line, where the scrollbar was higher as
20090522 15:36:58< CIA-77> one line. This has been fixed.
20090522 15:37:00< CIA-77> mordante * r35817 /trunk/src/gui/widgets/ (scrollbar_container.cpp scrollbar_container.hpp): 
20090522 15:37:02< CIA-77> Remove some obsolete helpers.
20090522 15:37:04< CIA-77> These functions were needed with the old layout algorithm.
20090522 15:37:12< CIA-77> mordante * r35818 /trunk/ (changelog players_changelog): Update changelogs.
20090522 15:40:16< mordante> Baufo, I assume you added server/mail.cpp, can you also add some copyright info?
20090522 15:40:55< Baufo> mordante: sure
20090522 15:41:02< mordante> thanks
20090522 16:05:13-!- jmunro[a] is now known as jmunro
20090522 16:09:20< Soliton> can others view wesnothd.wesnoth.org and not edit stuff?
20090522 16:11:09< CIA-77> baufo * r35819 /trunk/src/server/ (mail.cpp mail.hpp): added copyright/license info to server/mail.*
20090522 16:11:43< loonycyborg> Soliton: I can view wesnothd.wesnoth.org
20090522 16:12:32< Soliton> loonycyborg: and there is no edit button, yes?
20090522 16:13:09< loonycyborg> There's no "edit" button, only view button and three text fields.
20090522 16:14:13< Soliton> alright.
20090522 16:23:20-!- allefant [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev
20090522 16:38:52-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090522 16:39:02< YogiHH> euschn, you there?
20090522 16:39:15< euschn> YogiHH: yes
20090522 16:39:54< YogiHH> i took a quick look at the game_state changes
20090522 16:41:01< YogiHH> i don't think we can skip player_info altogether, although moving gold and recall list to team is a good idea
20090522 16:41:19< euschn> YogiHH: why is that?
20090522 16:41:51< YogiHH> what we need, though, is the information which team the player belongs to, because for campaigns, we don't have a save_id for the player when he loads the save again
20090522 16:42:27< YogiHH> so we don't know which team(s) he belongs to
20090522 16:42:58< YogiHH> for multiplayer it is different, there we got the login name
20090522 16:43:41< euschn> YogiHH: I see - so there is no way to tell the player team in a campaign just by checking the save_id of the team?
20090522 16:44:34< YogiHH> hmm, we could do it by marking it with a flag, maybe
20090522 16:45:30< euschn> oh, i thought the controller field would take of that
20090522 16:46:33< YogiHH> well, it is a hint indeed. It won't work well for multiplayer campaigns, however.
20090522 16:47:10< euschn> true, as there is more than one human controller
20090522 16:47:46< YogiHH> yes. I think we should keep player_info, maybe make it a vector and rename it to player_sides or something
20090522 16:48:42< euschn> YogiHH: ok, so reduce it to an indicator which team is a human player and store all other information in team_info?
20090522 16:49:18< YogiHH> yes
20090522 16:50:12< euschn> ok sounds good. what is your opinion on reducing the size of game_state by adding some separate class to handle time of day?
20090522 16:51:39-!- Baufo [n=quassel@wesnoth/developer/baufo] has quit [Remote closed the connection]
20090522 16:51:49< YogiHH> euschn: i am all for that, i think play_controller is a good place to have an instance of that class managed
20090522 16:52:18< YogiHH> i'd try to get it out of game_state completely
20090522 16:52:27< euschn> YogiHH: ok 
20090522 16:52:44< YogiHH> and the same goes for the teams map
20090522 16:53:07< YogiHH> is that somehow a member of game_state atm?
20090522 16:53:15< YogiHH> (don't have the code in front of me)
20090522 16:53:39< euschn> YogiHH: I was planning to make it a game_state member because it is a member of gamestatus atm
20090522 16:54:07< YogiHH> what's the declaration of that member right now?
20090522 16:55:02< euschn> its a public member of gamstatus: std::vector<team> *teams;
20090522 16:55:54< YogiHH> hmm, and play_controller got it's own vector, IIRC, right?
20090522 16:56:07< euschn> YogiHH: checking
20090522 16:57:30< euschn> YogiHH: youre right, it does - i have not noticed that so far
20090522 16:57:49< YogiHH> hmmm
20090522 16:57:53-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 104 (Connection reset by peer)]
20090522 16:58:51< YogiHH> ok, this is just an idea out of the box, a hypothesis that needs some checking done, but i think it should work:
20090522 16:59:15< CIA-77> mordante * r35820 /trunk/src/gui/dialogs/ (message.cpp message.hpp): Add show_error_message to gui2.
20090522 16:59:27< YogiHH> we have low-level objects (config) stuff and high-level objects (teams etc)
20090522 16:59:32< CIA-77> mordante * r35821 /trunk/src/ (7 files): Convert show_error_message calls form gui to gui2.
20090522 16:59:37< CIA-77> mordante * r35822 /trunk/src/ (show_dialog.cpp show_dialog.hpp): Remove the unused function gui::show_error_message.
20090522 16:59:46< CIA-77> mordante * r35823 /trunk/src/ (3 files in 2 dirs): 
20090522 16:59:46< CIA-77> Convert some calls to gui2::show_error_message.
20090522 16:59:46< CIA-77> Found some function that use "Error" as title instead of using the
20090522 16:59:46< CIA-77> specialized function, so converted them.
20090522 17:00:08< YogiHH> inside of play_controller, we manage the high-level objects, outside of it, we deal with low-level
20090522 17:00:24< euschn> ok
20090522 17:00:37< YogiHH> constructing play_controller also creates high-level objects out of config information
20090522 17:00:57< YogiHH> that would make game_state a container of low-level info
20090522 17:01:28< YogiHH> maybe you can check if the teams vector is used somewhere outside of play_controller?
20090522 17:01:45< euschn> ok, I will have a look at that
20090522 17:02:02< YogiHH> i'd really like to get it out of game_state
20090522 17:03:31< YogiHH> euschn: play_controller also should have members for current turn and max number of turns, probably we can get those out of game_state as well
20090522 17:03:39-!- crimson_penguin [n=ben@64.201.60.216] has joined #wesnoth-dev
20090522 17:04:19< euschn> YogiHH: agreed, it makes sense to add those to play_controller
20090522 17:04:26< euschn> i have a question though:
20090522 17:05:47 * YogiHH listens
20090522 17:06:09< euschn> if game_state does not have access to the teams vector, how can savegame build the snapshot? savegame only has a game_state to do that, isnt it?
20090522 17:06:36< YogiHH> hehe, correct :-)
20090522 17:07:23< euschn> hm actually, game_savegame does have a teams_ field, so nvm
20090522 17:07:37< YogiHH> that's what i mentioned to you some time ago, when i thought about how to get rid of referencing for example team.hpp in game_state :-)
20090522 17:08:02< euschn> i see
20090522 17:08:21< YogiHH> it does, but i am not happy with it :-)
20090522 17:08:50< euschn> YogiHH: ok - so that would favor leaving the teams with game_state again?
20090522 17:09:24< YogiHH> i am not happy with that either ;-) . Any idea how to avoid both?
20090522 17:10:01< euschn> have play_controller build the snapshot?
20090522 17:10:08< euschn> that seems weird though
20090522 17:10:09-!- stikonas [n=and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20090522 17:10:34< euschn> as it should not work with low-level config
20090522 17:10:42< YogiHH> yes, i agree
20090522 17:11:55< YogiHH> the config should be built by the objects that have the information, that is the high-level objects
20090522 17:11:58< euschn> I will give this some thought and see if I come up with a better solution then
20090522 17:12:32< euschn> so basically by game_state and savegame
20090522 17:12:38< YogiHH> the question is: how do we get that into game_state (as game_state knows best what config is needed), without having to have references to the high-level stuff?
20090522 17:13:11< euschn> mhm
20090522 17:16:18< YogiHH> euschn: i have an idea for that, but i would like to see what you come up with. It's a good design practice and i don't want you to point into a certain direction, maybe you have another better idea.
20090522 17:17:10< euschn> maybe we can do it by splitting up team_info and the team_class, i.e., have game_state hold a vector of team_info to build the snapshot, but put the remainder of the team class with play_controller?
20090522 17:17:26< euschn> thats just a wild guess though
20090522 17:17:48< euschn> ok, I will give this some though over the weekend
20090522 17:18:37< euschn> YogiHH: speaking of the weekend, do you know yet if you can/want to do our weekly discussion on saturday or sunday?
20090522 17:18:41< YogiHH> not sure if that gives us more trouble than it solves, team and team_info seem to be closely coupled. Splitting that is probably not a good idea.
20090522 17:18:49< euschn> ok
20090522 17:18:49-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20090522 17:19:35-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090522 17:20:08< YogiHH> uh, i have to admit i haven't gone active regarding that yet :-). I will send you a mail, probably late tonight. But yes, i'd still like to do it sometime on the weekend.
20090522 17:20:56< euschn> ok, in any case we have covered some of my questions right now
20090522 17:22:48< YogiHH> euschn: btw, if you like straight lines as much as i do: Select one of the connecting lines in StarUML and hit STRG+L ;-)
20090522 17:23:12< euschn> YogiHH: haha nice
20090522 17:24:56< euschn> anyways, I will have to go in a few minutes, I will check my mail and maybe be on irc later tongiht, though I cannot guarantee it - I will probably be available any time from saturday morning till sunday evening
20090522 17:25:20-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer]
20090522 17:25:21< YogiHH> great
20090522 17:25:35-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 17:26:21 * YogiHH looks out of the window... ugh, seems that putting sandals on today was too optimistic :/ 
20090522 17:27:05< euschn> haha, I have gone sandals too today - gotta get home before the next rainshower :)
20090522 17:28:08< euschn> see you tomorrow then
20090522 17:28:10-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit ["ChatZilla 0.9.84 [Iceweasel 3.0.6/2009050519]"]
20090522 17:34:18-!- Psyche^ [n=Psyche@e177230182.adsl.alicedsl.de] has joined #wesnoth-dev
20090522 17:34:34-!- Patterner [n=Psyche@e177237051.adsl.alicedsl.de] has quit [Read error: 104 (Connection reset by peer)]
20090522 17:34:34-!- Psyche^ is now known as Patterner
20090522 17:35:51-!- ardesh_ [n=ardesh@port-92-206-79-227.dynamic.qsc.de] has quit [Success]
20090522 17:36:51-!- busfahrer is now known as busfahrer|essen
20090522 17:50:12-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 17:54:02-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has left #wesnoth-dev []
20090522 17:55:43-!- busfahrer|essen is now known as busfahrer
20090522 17:57:46-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Success]
20090522 18:04:18-!- Sirp [n=me@wesnoth/developer/dave] has joined #wesnoth-dev
20090522 18:09:13-!- wesbot changed the topic of #wesnoth-dev to: 62 bugs, 241 feature requests, 11 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090522 18:29:57-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20090522 18:30:33-!- AnMaster [n=AnMaster@unaffiliated/anmaster] has quit [Connection timed out]
20090522 18:36:54-!- Elvish_Pillage2 [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090522 18:53:24-!- Elvish_Pillager [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090522 19:07:32-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20090522 19:10:22< mordante> esr, around
20090522 19:10:34-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 113 (No route to host)]
20090522 19:10:39< esr> mordante: Yes, what's up?
20090522 19:11:27< mordante> esr, a question about the gui, we have some transparent dialogs in the game what are the 'rules' for opaque or transparent?
20090522 19:11:34-!- Alesis-Novik [n=alesis@78.60.188.59] has quit [Read error: 110 (Connection timed out)]
20090522 19:12:01-!- Alesis-Novik [n=alesis@78.60.188.59] has joined #wesnoth-dev
20090522 19:12:26< esr> It's semitransparent if it's click-to-dismiss.  Modal dialogs with buttons remain fully opaque.  Or at leat that's how I left it.
20090522 19:13:39< mordante> ok, so only the semitransparent wml in-game dialogs are an exception to this rule
20090522 19:14:35< esr> I wasn't aware those existed.
20090522 19:14:55< mordante> in the test scenario round 18,11 are some tests
20090522 19:16:54< mordante> esr, what's a nice function name for click-to-dismiss, I now have the function show_message() and want a different name for this version
20090522 19:17:25< esr> transient_popup()  That's how I think of them.
20090522 19:20:29< mordante> not entirely, but the word transient is perfect :-); it will be show_transient_message to keep the function name close
20090522 19:20:50< esr> Fine.
20090522 19:21:12< esr> I'm good with that.
20090522 19:21:54-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev
20090522 19:22:23< esr> Request: please move converting the load_game() dialog up your priority list.  For extra goodness, classize it so I don't have to :-)  
20090522 19:22:59< esr> I'll take care of making save-threading work, given that infrastructure.
20090522 19:24:27< esr> I've been trying to turn it into a class, but I keep tripping over low-level C++ shit.
20090522 19:24:49-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 19:40:43< mordante> I fear it will still take some time, my list is rather full :-(
20090522 19:51:17< esr> I understand, but trying to converrt it when the code will have to be rwritten for GUI2 anyway is beginning to seem pointlessly painful.
20090522 19:52:33< CIA-77> noyga * r35824 /branches/1.6/po/ (wesnoth-nr/fr.po wesnoth-tsg/fr.po wesnoth-tutorial/fr.po): French translation update
20090522 19:53:46-!- allefant [n=allefant@allegro/developer/allefant] has quit [Read error: 60 (Operation timed out)]
20090522 19:56:08-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has left #wesnoth-dev []
20090522 20:00:59< mordante> the problem is that you need some rather specific widgets (the treeview) which doesn't exist for gui2 yet
20090522 20:01:16< mordante> a rather specific widget*
20090522 20:05:35-!- happygrue [n=George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20090522 20:05:52< CIA-77> noyga * r35825 /trunk/ (5 files in 4 dirs): French translation update
20090522 20:10:49< esr> mordante: Nope, don't need a treeview.  My current attempt usee boucman's idea, a checkbox that toggles whether tip saves only or all saves are displayed.  All it needs is a standard list-of-items selection.
20090522 20:11:18< mordante> and do you need to browse directories?
20090522 20:13:08-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev
20090522 20:16:53< Crab_> hi karl_m
20090522 20:24:53< esr> mordante: No.  The widget gets a straight list of save names.
20090522 20:26:31< mordante> in that case I can move it a bit more up in my todo list, but I still have some other things with a higher priority
20090522 20:27:16-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev
20090522 20:28:40< esr> Understood.
20090522 20:42:48< CIA-77> noyga * r35826 /branches/1.6/po/ (wesnoth-editor/fr.po wesnoth-lib/fr.po): French translation update
20090522 20:58:29-!- giusef_ [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev
20090522 21:02:22-!- giusef [n=giusef@unaffiliated/giusef] has quit [Read error: 60 (Operation timed out)]
20090522 21:02:29-!- giusef_ is now known as giusef
20090522 21:02:51< CIA-77> mordante * r35827 /trunk/src/gui/dialogs/ (message.cpp message.hpp): 
20090522 21:02:51< CIA-77> Use the proper class for the enum.
20090522 21:02:51< CIA-77> The enum also is inherited by tbutton, but is defined in tcontrol so use
20090522 21:02:51< CIA-77> that version to avoid confusion.
20090522 21:06:54-!- Baufo [n=quassel@62-47-131-227.adsl.highway.telekom.at] has joined #wesnoth-dev
20090522 21:08:46< CIA-77> mordante * r35828 /trunk/ (11 files in 7 dirs): Add a new transient dialog.
20090522 21:11:10< CIA-77> ivanovic * r35829 /branches/1.6/ (19 files in 19 dirs): update Lithuanian translation
20090522 21:11:44< CIA-77> ivanovic * r35830 /trunk/ (21 files in 20 dirs): update Lithuanian translation
20090522 21:14:56-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090522 21:19:12-!- Polarina1 [n=polarina@85-220-26-48.dsl.dynamic.simnet.is] has joined #wesnoth-dev
20090522 21:19:27< mordante> I'
20090522 21:19:31< mordante> m off bye
20090522 21:19:53-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"]
20090522 21:29:00-!- ilor [n=ilor@wesnoth/developer/ilor] has joined #wesnoth-dev
20090522 21:34:53-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit [Read error: 110 (Connection timed out)]
20090522 22:18:24-!- maxy [n=maxy@80-219-0-199.dclient.hispeed.ch] has quit []
20090522 22:23:41-!- Polarina1 is now known as Polarina
20090522 22:36:56-!- YogiHH [n=chatzill@c158008.adsl.hansenet.de] has joined #wesnoth-dev
20090522 22:48:15-!- Crab_ [i=crab@wesnoth/developer/crab] has quit ["Leaving."]
20090522 22:59:15-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev
20090522 23:01:43-!- AnMaster [n=AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20090522 23:04:00-!- Elvish_Pillager [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090522 23:04:07-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has left #wesnoth-dev []
20090522 23:04:41-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 104 (Connection reset by peer)]
20090522 23:04:48-!- Elvish_Pillage2 [n=eli@68-116-175-221.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090522 23:16:34< Ivanovic> ilor: https://gna.org/bugs/index.php?13549
20090522 23:17:10-!- ardesh [n=ardesh@port-92-206-78-166.dynamic.qsc.de] has joined #wesnoth-dev
20090522 23:19:25-!- noy [n=Noy@wesnoth/developer/noy] has quit ["GO, GET TO THE CHOPPAH!!!"]
20090522 23:20:15< Soliton> doctor, doctor, it hurts when i do this!
20090522 23:21:47< Blueblaze> ?
20090522 23:23:48-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090522 23:24:18< Soliton> that's in response to that bug report.
20090522 23:24:37< ilor> Soliton: well, the game/editor shouldn't just crash
20090522 23:27:05< Soliton> yeah, i thought it was giving an error message about not being able to create a map since a while actually.
20090522 23:27:59< Soliton> maybe the editor is missing that logic.
20090522 23:32:21-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090522 23:38:54-!- YogiHH [n=chatzill@c158008.adsl.hansenet.de] has left #wesnoth-dev []
20090522 23:58:29-!- YogiHH [n=chatzill@c203198.adsl.hansenet.de] has joined #wesnoth-dev
20090522 23:58:45-!- YogiHH [n=chatzill@c203198.adsl.hansenet.de] has left #wesnoth-dev []
--- Log closed Sat May 23 00:00:46 2009