--- Log opened Mon May 11 00:00:23 2009
--- Day changed Mon May 11 2009
20090511 00:00:23< Sirp> okay
20090511 00:00:32< Sirp> and so where is it implemented? in server.cpp?
20090511 00:02:14< Soliton> Sirp: src/server/game.cpp:game::save_replay()
20090511 00:02:55< Sirp> okay
20090511 00:03:02< Sirp> is upping svn
20090511 00:04:26-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090511 00:11:42< Sirp> Soliton: I don't see anything obvious in that function. How about doing a test where you compile the server to call save_replay 10,000 times in a loop and then test it and see if it runs out of memory or not?
20090511 00:11:52-!- Noyga [n=lame-z@wesnoth/developer/noyga] has left #wesnoth-mp ["Quitte"]
20090511 00:14:04-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090511 00:15:12< Soliton> Sirp: i think it's probably only triggered by certain replay data. also i'm finishing my thesis atm, so not really time for anything. (except chatting on IRC!) :-)
20090511 00:16:58< Sirp> Soliton: yeah possibly. Though I can't see what could possibly do that in the function
20090511 00:17:53< Sirp> Soliton: at the beginning of the function we abort without doing anything under certain conditions. I am assuming that if these conditions are true we will still clean up history_ properly somewhere?
20090511 00:18:50< Soliton> Sirp: yes, clear_history is called whether a replay was saved or not.
20090511 00:19:16< Sirp> okay
20090511 00:19:17< Soliton> Sirp: save_replay() gets called from the destructor of game.
20090511 00:19:56< Sirp> Soliton: okay. Make sure we catch all exceptions and don't let them leak out of the destructor
20090511 00:20:07< Sirp> we're writing to a file so there are a bunch of possible exceptions.
20090511 00:20:20< Sirp> if an exception leaks out of a destructor that could cause a memory leak
20090511 00:21:26< Soliton> hmm yeah, that sounds like it could be it.
20090511 00:22:10< Soliton> but wouldn't we get an abort on an uncaught exception?
20090511 00:22:39< Soliton> i guess it could be caught later on.
20090511 00:27:31< Soliton> i suppose i could just put the save_replay() call in catch(...) statement and see if we're missing something.
20090511 00:35:53< Sirp> Soliton: yes we have a catch(...) later on
20090511 00:36:17< Sirp> Soliton:  in C++ you should NEVER propagate an exception from a destructor. It's better to just put a try { ... } catch(...) {} around the body of your destructor
20090511 00:37:53< Soliton> Sirp: yeah, makes sense. that catch(...) would also abort the server though so that can't really be it.
20090511 00:38:54< Soliton> it could be a simple_wml or config error that goes uncaught though.
20090511 00:40:22< Soliton> all those print something to the log.. i'll check for that.
20090511 00:44:06-!- G-Lo [i=G-Lo@gateway/gpg-tor/key-0x40F56B8D] has quit [Nick collision from services.]
20090511 00:44:21-!- G-Lo` [n=Kvirc@unaffiliated/g-lo] has joined #wesnoth-mp
20090511 00:44:49-!- G-Lo` is now known as G-Lo
20090511 00:48:21-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection]
20090511 00:55:41< Sirp> Soliton: would it abort the server? Don't we have a high level catch(...) in the server code?
20090511 00:55:46< Sirp> that would catch it and continue?
20090511 00:56:28< Sirp> err hmm no I guess we don't.
20090511 00:56:33< Sirp> we do abort on an unknown exception
20090511 00:57:31< Soliton> there is nothing about config or simple_wml errors in the logs either.
20090511 01:12:16< Soliton> Sirp: oh btw, the apache error log is full of "terminate called after throwing an instance of 'simple_wml::error'" from the stats upload program. would be nice if errors (data from old clients?) get handled less noisy. :-)
20090511 01:13:28< Soliton> Sirp: also looks like the source of that upload program has a db password built-in and is world readable. :->
20090511 01:19:46< Sirp> ahhhh we should make it non world readable. :)
20090511 01:24:52-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-mp
20090511 01:41:14< noy> Soliton: http://www.computerworld.com/action/article.do?command=viewArticleBasic&articleId=9132758&intsrc=news_ts_head
20090511 01:52:43< Soliton> interesting that their ISP doesn't get cut off by other providers. doesn't sound like they have a lot of legitimate business.
20090511 02:08:45-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 02:08:49< noy> Soliton; Yeah I was thinking about that... there was another article you might be interested in I'm currently reading...
20090511 02:08:55< noy> http://www.cs.ucsb.edu/~seclab/projects/torpig/torpig.pdf
20090511 02:29:00-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-mp
20090511 02:38:17-!- vjoe [n=vjoe@hh088c.halls.manchester.ac.uk] has quit [Client Quit]
20090511 03:17:52-!- noy [n=Noy@wesnoth/developer/noy] has quit [Read error: 110 (Connection timed out)]
20090511 03:39:28-!- Sirp [n=me@pool-173-74-2-179.dllstx.fios.verizon.net] has quit [Read error: 113 (No route to host)]
20090511 03:42:25-!- Sirp [n=me@pool-173-74-2-179.dllstx.fios.verizon.net] has joined #wesnoth-mp
20090511 04:23:57-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-mp
20090511 04:58:17-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)]
20090511 04:58:32-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 05:12:21< noy> Soliton: around?
20090511 05:16:00-!- Lord_Aether [n=castle@206.170.190.49] has joined #wesnoth-mp
20090511 05:39:09< noy> Turuk: spam in the moderator forum
20090511 06:26:36-!- Lord_Aether [n=castle@206.170.190.49] has quit []
20090511 08:17:49-!- Sirp [n=me@pool-173-74-2-179.dllstx.fios.verizon.net] has quit ["leaving"]
20090511 09:12:58-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-mp
20090511 09:17:49-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection]
20090511 09:21:08-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-mp
20090511 09:54:04-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer]
20090511 09:54:19-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 10:21:17-!- G-Lo [n=Kvirc@unaffiliated/g-lo] has quit [Nick collision from services.]
20090511 10:21:32-!- G-Lo` [n=Kvirc@unaffiliated/g-lo] has joined #wesnoth-mp
20090511 11:30:07-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090511 14:04:29-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has quit ["Lost terminal"]
20090511 14:19:50-!- Soliton [n=Soliton@wesnoth/developer/soliton] has quit [Remote closed the connection]
20090511 14:19:58-!- Soliton [n=Soliton@wesnoth/developer/soliton] has joined #wesnoth-mp
20090511 14:30:01-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit []
20090511 14:30:46-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 15:02:45-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit []
20090511 15:29:35-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 17:10:09-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has left #wesnoth-mp []
20090511 17:51:34-!- G-Lo` is now known as G-Lo
20090511 17:54:20-!- G-Lo [n=Kvirc@unaffiliated/g-lo] has quit ["I must not fear. Fear is the mind-killer. Fear is the little-death that brings total obliteration."]
20090511 17:56:04-!- G-Lo [i=G-Lo@gateway/gpg-tor/key-0x40F56B8D] has joined #wesnoth-mp
20090511 18:06:06-!- G-Lo [i=G-Lo@gateway/gpg-tor/key-0x40F56B8D] has quit [Remote closed the connection]
20090511 18:07:36-!- G-Lo [i=G-Lo@gateway/gpg-tor/key-0x40F56B8D] has joined #wesnoth-mp
20090511 18:12:08-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 18:32:15-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-mp
20090511 18:33:08-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-mp
20090511 18:48:31-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-mp
20090511 18:59:13-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)]
20090511 18:59:28-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 19:34:48-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090511 19:36:11-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Read error: 110 (Connection timed out)]
20090511 19:36:27-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090511 19:38:38-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-mp
20090511 19:42:55-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 60 (Operation timed out)]
20090511 19:43:55-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 20:34:46-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-mp
20090511 20:55:09-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 60 (Operation timed out)]
20090511 20:59:42-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 21:30:27-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-mp
20090511 21:30:57< thespaceinvader> Turuk: you were looking for me?
20090511 21:49:14-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)]
20090511 21:49:28-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
20090511 22:40:44-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"]
20090511 22:48:23< thespaceinvader> Turuk: you were looking for me?
20090511 22:57:17-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"]
20090511 23:35:11-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit ["The man who smiles when things go wrong has thought of someone to blame it on."]
20090511 23:42:09-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090511 23:48:53-!- vjoe [n=vjoe@hh088c.halls.manchester.ac.uk] has joined #wesnoth-mp
20090511 23:54:05-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-mp
--- Log closed Tue May 12 00:00:07 2009