--- Log opened Wed Jun 10 00:00:08 2009 20090610 00:01:53-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["ChatZilla 0.9.84 [Firefox 3.0.10/2009042316]"] 20090610 00:03:40< Soliton> looks like in UMC [filter_base_value] is only used like in steadfast so it should only fix stuff to change the logic. 20090610 00:09:13-!- wesbot changed the topic of #wesnoth-dev to: 64 bugs, 242 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090610 00:13:38-!- ilor [n=user@wesnoth/developer/ilor] has quit [Read error: 113 (No route to host)] 20090610 00:17:50-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection] 20090610 00:18:40-!- boucman [n=rosen@wesnoth/developer/boucman] has quit ["Leaving."] 20090610 00:20:00-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [] 20090610 00:30:12-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit [Read error: 60 (Operation timed out)] 20090610 00:42:50-!- noy [n=Noy@wesnoth/developer/noy] has quit [Connection timed out] 20090610 00:43:01-!- Netsplit wolfe.freenode.net <-> irc.freenode.net quits: ettin_ 20090610 00:43:25-!- Netsplit over, joins: ettin_ 20090610 00:57:37-!- busfahrer` [n=busfahre@ulmg-5f70c9a5.pool.einsundeins.de] has joined #wesnoth-dev 20090610 00:58:37-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090610 01:00:42-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Read error: 145 (Connection timed out)] 20090610 01:01:18-!- Sapient [n=patrickp@wesnoth/developer/sapient] has left #wesnoth-dev [] 20090610 01:10:41< Soliton> bah, max_value is applied unconditionally or something... 20090610 01:14:51-!- Smar [n=smar@freenet/translator/finnish/Smar] has quit [Read error: 54 (Connection reset by peer)] 20090610 01:14:54-!- Smar [n=smar@a88-113-60-192.elisa-laajakaista.fi] has joined #wesnoth-dev 20090610 01:14:58-!- BenUrban [n=benurban@68.55.19.224] has joined #wesnoth-dev 20090610 01:19:05 * Soliton pings Sapient 20090610 01:29:38-!- Smar [n=smar@freenet/translator/finnish/Smar] has quit [Read error: 60 (Operation timed out)] 20090610 01:29:49-!- Smar [n=smar@a88-113-60-192.elisa-laajakaista.fi] has joined #wesnoth-dev 20090610 01:29:56-!- Netsplit wolfe.freenode.net <-> irc.freenode.net quits: busfahrer`, CIA-77 20090610 01:30:12-!- Netsplit over, joins: busfahrer`, CIA-77 20090610 01:44:31-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090610 01:47:45< Soliton> i have no idea what the point of max_value is since it applies no matter whether the actual effect was applied or not... 20090610 01:58:29-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090610 01:59:25-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Client Quit] 20090610 02:04:15-!- busfahrer` [n=busfahre@ulmg-5f70c9a5.pool.einsundeins.de] has quit [Read error: 145 (Connection timed out)] 20090610 02:10:55-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"] 20090610 02:22:42-!- ancestral [n=ancestra@97-116-126-92.mpls.qwest.net] has joined #wesnoth-dev 20090610 02:57:48-!- Sapient [n=sapien-x@66.56.60.33] has joined #wesnoth-dev 20090610 02:57:58< Sapient> Soliton: thou hast summoned me? 20090610 02:58:55< Sapient> I'm taking a look-see at the code 20090610 03:01:24< Sapient> [filter_base_value] 20090610 03:01:24< Sapient> greater_than=0 20090610 03:01:24< Sapient> less_than_equal_to=50 20090610 03:01:24< Sapient> [/filter_base_value] 20090610 03:02:16-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit ["Leaving."] 20090610 03:02:30< Sapient> I see a problem with the code in unit_abilities.cpp 20090610 03:02:40< Soliton> Sapient: i'm currently trying not to do the max_value thing when the effect actually doesn't apply. 20090610 03:03:06< Sapient> ah 20090610 03:03:13-!- ancestral [n=ancestra@97-116-126-92.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090610 03:03:16< Soliton> because no matter what the effect code does max_value is applied. 20090610 03:03:28< Sapient> but that's not the right approach... 20090610 03:03:32< Soliton> well, no matter what the base value filter is anyway. 20090610 03:04:15< Soliton> phew, finally seems to work. 20090610 03:04:20< Sapient> max_value *should* be applied unconditionally, unless the filter causes the ability to not apply 20090610 03:04:35< Sapient> oh, ok... glad it's working 20090610 03:04:58< Soliton> unconditionally, unless eh? :-) 20090610 03:06:09< Soliton> the thing is that resistance_filter_matches() does not care for the base value filter. 20090610 03:06:18< Soliton> and i've changed that now. 20090610 03:06:47< Soliton> took me a while to find a stupid mistake i introduced with earlier testing... 20090610 03:08:26< Soliton> btw, steadfast is needlessly limiting itself to the known mainline damage types. the apply_to key can simply be left out. 20090610 03:08:48< Soliton> and then it applies to any type. 20090610 03:09:02< Sapient> ah, sounds like a good change then 20090610 03:09:06< Sapient> I didn't realize that 20090610 03:09:27< Sapient> maybe just comment it out for reference purposes 20090610 03:10:46< Soliton> alright. 20090610 03:11:38< Sapient> thanks, Soliton 20090610 03:11:42< Sapient> cya later, have fun. 20090610 03:11:42-!- Sapient [n=sapien-x@wesnoth/developer/sapient] has left #wesnoth-dev [] 20090610 03:46:19-!- noy [n=Noy@wesnoth/developer/noy] has quit [] 20090610 04:05:03-!- Sirp [n=me@wesnoth/developer/dave] has joined #wesnoth-dev 20090610 04:20:13-!- Ivanovic_ [n=ivanovic@dtmd-4db227db.pool.einsundeins.de] has joined #wesnoth-dev 20090610 04:37:15-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)] 20090610 04:38:11-!- Ivanovic_ is now known as Ivanovic 20090610 04:40:02-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Read error: 104 (Connection reset by peer)] 20090610 04:43:07-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090610 05:40:06-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [] 20090610 05:44:20-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090610 05:44:34-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090610 06:09:13-!- wesbot changed the topic of #wesnoth-dev to: 65 bugs, 242 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090610 06:44:07-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["Tengo que ir... Yeahzorz..."] 20090610 07:03:43-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090610 07:45:26-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 07:45:38-!- Sirp [n=me@wesnoth/developer/dave] has quit ["leaving"] 20090610 07:48:49-!- maxy [n=maxy@80-219-0-199.dclient.hispeed.ch] has joined #wesnoth-dev 20090610 08:04:23-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has joined #wesnoth-dev 20090610 08:04:39< YogiHH> good morning 20090610 08:10:57-!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has quit [Read error: 104 (Connection reset by peer)] 20090610 08:14:37-!- esr_ [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20090610 08:20:00-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 08:20:36-!- fendrin [n=fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20090610 08:21:24-!- Crab_ [i=crab@94-248-91-22.dynamic.peoplenet.ua] has joined #wesnoth-dev 20090610 08:22:00-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 08:22:16-!- esr [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Read error: 110 (Connection timed out)] 20090610 08:30:25-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev 20090610 08:41:56-!- stikonas_ [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 08:42:41-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev 20090610 08:42:45< euschn> hi 20090610 08:43:15< fendrin> hi 20090610 08:43:20-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Remote closed the connection] 20090610 08:46:17-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 60 (Operation timed out)] 20090610 08:46:50-!- stikonas_ is now known as stikonas 20090610 08:49:03-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090610 08:50:18-!- EdB [n=edb@63.153.82-79.rev.gaoland.net] has joined #wesnoth-dev 20090610 09:02:09-!- Netsplit wolfe.freenode.net <-> irc.freenode.net quits: ettin_ 20090610 09:06:00-!- ilor_ [n=user@wesnoth/developer/ilor] has quit [Read error: 110 (Connection timed out)] 20090610 09:06:47-!- ettin [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev 20090610 09:07:14-!- Netsplit over, joins: ettin_ 20090610 09:07:14-!- ettin_ [n=jorda@wesnoth/developer/ettin] has quit [Remote closed the connection] 20090610 09:29:50< euschn> YogiHH: I am currently looking at the removal of the gamestatus turn/tod. most references are np as they come from play_controller and savegame, yet the classes that are somewhat problematic are game_display and terrain_filter 20090610 09:30:15< euschn> they have a gamestatus member, but of course no reference to play_controller 20090610 09:31:32< euschn> in the case of game_display, we could just add a tod_manager member instead of the gamestatus to sort time_of_day, but unfortunately game-display also accesses the current turn member by calling reports::generate_report 20090610 09:31:58< euschn> and in our current design, the current turn is only accessible to play_controller 20090610 09:33:31< euschn> I see two possible solutions: either give game_display a reference to play_controller (ugly imho), or move the turn functionality to tod_manager or its own class, so it can be accessed outside of play_controller 20090610 09:36:00< Crab_> euschn: note that AI code accesses time of day and turn from gamestatus. if you remove them from gamestatus, add a alternative way to get time_of_day / turn to src/ai/game_info.hpp 20090610 09:37:40< euschn> Crab_: yes, i noticed that, will do. is there anything else you are accessing via gamestatus atm? 20090610 09:41:23< Crab_> turn, time of day, plus a few obsolete things (teams and game state - ai can get them directly from ai::game_info) 20090610 09:41:43< YogiHH> euschn: is it only accessing the information or is it changing that as well? 20090610 09:42:17< YogiHH> (speaking of game_display and terrain_filter) 20090610 09:42:30< euschn> YogiHH: in the case of game_display and generate reports, accessing only 20090610 09:42:46< euschn> not 100% sure about terrain_filter, but i think its only accessing aswell 20090610 09:42:46< YogiHH> euschn: Would it be an alternative to pass it as a parameter, then? 20090610 09:42:48< Crab_> euschn: plus, later, there may be need to ask questions such as 'what will be the time of day and lawful bonus in +2 turns?' 20090610 09:44:38< euschn> YogiHH: if I pass play_controller.turn_ as a parameter, it might be changed later on by play_controller. this means the parameter would have to be a pointer to turn? 20090610 09:45:01< euschn> Crab_: I see, will keep that in mind 20090610 09:45:53< YogiHH> euschn: no, i don't think so. As far as i understand you need the turn member for a method call to game_display, right? 20090610 09:46:36< Crab_> euschn: but, basically, references to all game info that is needed by AI should be put into ai::game_info 20090610 09:47:09< euschn> YogiHH: game_display calls reports::generate_report which uses the current turn, so yes 20090610 09:47:21< euschn> Crab_: ok 20090610 09:47:40< YogiHH> euschn: as long as the turn is not changed during that call, it doesn't matter if you pass it by reference or by value 20090610 09:48:09< Crab_> euschn: it is set once per game in playsingle_controller constructor ( ai::game_info ai_info(*gui_,map_,units_,teams_,status_, gamestate_); ai::manager::set_ai_info(ai_info); ) 20090610 09:49:36-!- Crab_ [i=crab@wesnoth/developer/crab] has quit ["Leaving."] 20090610 09:51:22< euschn> YogiHH: I am not sure I understand. the turn information is accessed at game_display::draw_report (game_display.cpp: 417). if we give game_display a turn member (which is set at initialization of game_display), wont the current turn likely have changed once draw_report() is called? 20090610 09:51:23< YogiHH> euschn: so basically what i am suggesting is for game_display replacing a turn member with method parameters whereever needed. 20090610 09:52:08< euschn> ah ok, I thought wrong there 20090610 09:52:23< euschn> I think I get it now 20090610 09:52:40< Ivanovic> esr_: you might want to login/identify at nickserv with your usernamen "esr" 20090610 09:52:47< YogiHH> euschn: you think that is feasible? 20090610 09:53:05< euschn> YogiHH: I will have a look 20090610 09:53:11< Ivanovic> esr_: since you have not used it (including identification) for 4 weeks and they want to drop "unused stuff" tomorrow you nick otherwise might be dropped 20090610 09:53:27< Ivanovic> (since they define inactive with "not used for 4 weeks") 20090610 09:53:42< YogiHH> euschn: if taken further with other values, it might lead to a "parameter flood" for certain methods. If that's the case, one should think about combining related parameters into objects. 20090610 09:53:55< euschn> mhm 20090610 09:53:55< YogiHH> euschn: but i don't think it applies here 20090610 10:02:04< euschn> YogiHH: hm, it would be required to add a turn parameter to game_display::draw_side_bar() (which calls draw_reports), yet draw_side_bar() is private and virtual (reimplemented by display.cpp, though its an empty function there) 20090610 10:02:56< euschn> game_display::draw_side_bar is not referenced at all according to the online documentation 20090610 10:04:01< YogiHH> that's weird 20090610 10:04:09< euschn> I agree :) 20090610 10:04:52< YogiHH> hmm 20090610 10:06:41< YogiHH> euschn: I am always in favor of throwing away unnecessary code ;-) . So maybe comment it out for the moment, but you should check with someone who knows about things until you finally remove it (boucman, maybe, or mordante). 20090610 10:06:47< euschn> would that imply reports::generate_report currently never gets called either? seems strange 20090610 10:07:16< YogiHH> yes, doesn't make much sense to me either. I'd try to comment and see what the compiler thinks about it. 20090610 10:08:28< euschn> ok, ill comment draw_report then, cant comment draw_sidebar since it virtual and reimplemented in display.cpp 20090610 10:08:55< YogiHH> euschn: If it is still necessary, i'd add the turn parameter and adapt overriding methods accordingly 20090610 10:09:37< euschn> YogiHH: that would involve a bogus parameter for display::draw_sidebar then? 20090610 10:09:53< YogiHH> euschn: why bogus? 20090610 10:10:33-!- ilor [n=user@wesnoth/developer/ilor] has quit [] 20090610 10:11:10< euschn> YogiHH: display::draw_sidebar (as opposed to game_display::draw_sidebar) is an empty function 20090610 10:11:23-!- grzywacz [n=grzywacz@ip179-109.ghnet.pl] has joined #wesnoth-dev 20090610 10:11:29< euschn> then again, this raises the question why draw_sidebar is virtual in the first place 20090610 10:11:29-!- zookeeper [n=l@175-151.adsl.lpoy.dnainternet.fi] has joined #wesnoth-dev 20090610 10:11:58-!- noy [n=Noy@wesnoth/developer/noy] has quit [] 20090610 10:13:19< YogiHH> euschn: well, display::draw_sidebar gets the parameter as well, then 20090610 10:13:46< YogiHH> euschn: as it is overriding the game_display method, no? 20090610 10:14:02< euschn> YogiHH: exactly 20090610 10:15:25< YogiHH> euschn: Well, i'd just change it. Even if it doesn't make much sense to us atm, it won't break anything, and you can still check later if it is needed or not. 20090610 10:15:38< euschn> ok 20090610 10:16:24-!- noy [n=Noy@d75-157-39-176.bchsia.telus.net] has joined #wesnoth-dev 20090610 10:16:50-!- noy [n=Noy@wesnoth/developer/noy] has quit [Remote closed the connection] 20090610 10:20:06< euschn> YogiHH: ok, draw_report() and thus draw_sidebar() is definitely used, as it does not draw the unit information to the right when commented 20090610 10:20:37< YogiHH> ok 20090610 10:28:28-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"] 20090610 10:35:38-!- loonybot [n=loonybot@79.139.136.171] has joined #wesnoth-dev 20090610 10:36:32-!- loonycyborg [n=sergey@79.139.136.171] has joined #wesnoth-dev 20090610 10:38:01< CIA-77> euschn * r36109 /trunk/src/ (tod_manager.cpp tod_manager.hpp): removed unnecessary argument from tod_manager::get_previous_time_of_day() 20090610 10:38:01-!- loonycyborg_ [n=sergey@79.139.136.171] has joined #wesnoth-dev 20090610 10:38:36-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Nick collision from services.] 20090610 10:38:41-!- loonycyborg_ is now known as loonycyborg 20090610 10:49:27-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090610 10:50:00-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 10:56:03-!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090610 10:58:15< Ivanovic> off to uni, cu this evening 20090610 11:01:55-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 11:02:32-!- EdB [n=edb@63.153.82-79.rev.gaoland.net] has quit [Remote closed the connection] 20090610 11:13:52-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 11:14:37-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20090610 11:23:58-!- esr_ is now known as esr 20090610 11:26:21-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 11:32:56-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 11:33:12< CIA-77> euschn * r36110 /trunk/src/ (4 files): removed most references of gamestatus::turn() in play_controller and subclasses 20090610 11:41:36-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit [Remote closed the connection] 20090610 11:47:48-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 11:50:50-!- EdB [n=edb@141.12.95-79.rev.gaoland.net] has joined #wesnoth-dev 20090610 12:03:25< CIA-77> esr * r36111 /trunk/po/wesnoth-aoi/ (49 files): Eliminate spurious pofixc error messages by hand-fixing some translation keys. 20090610 12:05:25-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 12:09:53-!- anomie3 [n=gare@64-184-254-41.mammothnetworks.com] has quit [Read error: 60 (Operation timed out)] 20090610 12:12:25-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 12:13:31-!- Appleman1234 [n=Appleman@131.181.47.2] has joined #wesnoth-dev 20090610 12:16:12-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 12:20:52-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 12:21:09< thespaceinvader> esr: there? 20090610 12:21:19-!- anomie3 [n=gare@72.55.205.214] has joined #wesnoth-dev 20090610 12:22:23< esr> Yes, what's up? 20090610 12:23:01-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 12:27:33< CIA-77> esr * r36112 /trunk/ (53 files in 5 dirs): Minor punctuation and translation-key fixes. 20090610 12:50:20-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 12:50:42-!- Appleman1234 [n=Appleman@131.181.47.2] has quit [Remote closed the connection] 20090610 13:08:39-!- EdB [n=edb@141.12.95-79.rev.gaoland.net] has quit [Remote closed the connection] 20090610 13:27:07-!- loonybot_ [n=loonybot@79.139.138.177] has joined #wesnoth-dev 20090610 13:27:55-!- loonycyborg_ [n=sergey@79.139.138.177] has joined #wesnoth-dev 20090610 13:29:28-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Nick collision from services.] 20090610 13:29:32-!- loonycyborg_ is now known as loonycyborg 20090610 13:30:26-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Nick collision from services.] 20090610 13:30:26-!- loonybot_ is now known as loonybot 20090610 13:39:14< CIA-77> soliton * r36113 /branches/1.6/data/core/macros/abilities.cfg: simplified steadfast a bit 20090610 13:39:20< CIA-77> soliton * r36114 /branches/1.6/src/ (unit.cpp unit.hpp unit_abilities.cpp unit_abilities.hpp): combine filter_base_value conditions with "and" instead of "or" and made resistance_filter_matches() also check the filter_base_value (fixes steadfast) 20090610 13:41:19< CIA-77> soliton * r36115 /trunk/data/campaigns/The_South_Guard/_main.cfg: fixed bug #13659: The South Guard - too many scenarios promised 20090610 13:41:58< CIA-77> soliton * r36116 /trunk/src/ (unit.cpp unit.hpp unit_abilities.cpp unit_abilities.hpp): combine filter_base_value conditions with "and" instead of "or" and made resistance_filter_matches() also check the filter_base_value (fixes steadfast) 20090610 13:42:01< CIA-77> soliton * r36117 /trunk/data/core/macros/abilities.cfg: simplified steadfast a bit 20090610 13:54:18-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["KVIrc 3.4.2 Shiny http://www.kvirc.net/"] 20090610 13:54:40-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090610 13:59:16< thespaceinvader> esr: sorry i missed you UI put ym head down into an animation 20090610 13:59:42< thespaceinvader> just wanted to let you know I have fixed up masked fighter line frames taking the newer animations into account 20090610 14:00:02< thespaceinvader> if you'd like to get them committed 20090610 14:13:32-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has quit ["http://www.mibbit.com ajax IRC Client"] 20090610 14:26:56-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has joined #wesnoth-dev 20090610 15:10:17-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev 20090610 15:11:55-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev 20090610 15:16:02-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"] 20090610 15:21:47-!- wutzara [n=wutzara@pD9ED6AB5.dip.t-dialin.net] has joined #wesnoth-dev 20090610 15:27:57-!- loonybot [n=loonybot@79.139.138.177] has joined #wesnoth-dev 20090610 15:28:42-!- loonycyborg [n=sergey@79.139.138.177] has joined #wesnoth-dev 20090610 15:32:08-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has joined #wesnoth-dev 20090610 15:47:29-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090610 15:54:56-!- shadowmast3r [n=ignacio@146.155.82.131] has joined #wesnoth-dev 20090610 15:55:12-!- shadowmast3r [n=ignacio@146.155.82.131] has quit [Client Quit] 20090610 15:55:53-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has quit ["Lost terminal"] 20090610 16:22:55< CIA-77> crab * r36118 /trunk/src/ai/ (default/ai.cpp dfool/ai.cpp formula/ai.cpp): removed gamestatus usage, where it is not needed 20090610 16:26:47< CIA-77> euschn * r36119 /trunk/src/ (play_controller.cpp replay_controller.cpp): removed the remaining references to gamestatus::turn() from play_controller classes (except assertions) 20090610 16:35:39-!- ardesh [n=ardesh@port-92-206-58-40.dynamic.qsc.de] has joined #wesnoth-dev 20090610 16:39:23-!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has quit [Read error: 104 (Connection reset by peer)] 20090610 16:40:35< esr> thespaceinvader: Yes, I'd like to get them committed. What's the next step? 20090610 16:41:33< thespaceinvader> I'll zip them up and send them to you on the forum if that's OK by you 20090610 16:44:37< CIA-77> euschn * r36120 /trunk/src/game_events.cpp: removed a gamestatus.turn() reference from game_events.cpp 20090610 16:44:48< thespaceinvader> esr: check your PMs 20090610 16:45:03-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit ["ChatZilla 0.9.84 [Iceweasel 3.0.6/2009050519]"] 20090610 16:49:17< esr> thespaceinvader: OK, thanks. 20090610 16:54:30-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has quit [Remote closed the connection] 20090610 17:06:07< Ivanovic> hi 20090610 17:06:35< Crab_> hi, Ivanovic 20090610 17:15:49< stikonas> Ivanovic: hi, are there any plans about 1.6.3 release date? 20090610 17:18:26-!- wutzara [n=wutzara@pD9ED6AB5.dip.t-dialin.net] has quit ["Ex-Chat"] 20090610 17:21:14< Ivanovic> stikonas: "when its ready" 20090610 17:21:31< Ivanovic> no fixed plans so far and i got to run a pot-update there soon anyway... 20090610 17:30:21-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090610 17:30:33-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090610 17:31:22-!- ABCD_ is now known as ABCD 20090610 17:36:07-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 60 (Operation timed out)] 20090610 17:37:14-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090610 17:39:18-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has joined #wesnoth-dev 20090610 17:42:24-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090610 17:43:03-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev 20090610 17:52:07< CIA-77> soliton * r36121 /branches/1.6/data/campaigns/Two_Brothers/scenarios/3_Guarded_Castle.cfg: fixed bug #13664: Minor typo in Tale of Two Brothers #3 20090610 17:55:04< CIA-77> soliton * r36122 /trunk/data/campaigns/Two_Brothers/scenarios/3_Guarded_Castle.cfg: fixed bug #13664: Minor typo in Tale of Two Brothers #3 20090610 18:00:26-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has quit ["http://www.mibbit.com ajax IRC Client"] 20090610 18:02:15-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev 20090610 18:09:13-!- wesbot changed the topic of #wesnoth-dev to: 63 bugs, 242 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090610 18:36:04< CIA-77> euschn * r36123 /trunk/src/ (4 files): removed gamestatus.number_of_turns() references from game_events.cpp and play_controller classes 20090610 18:39:33-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090610 18:40:03-!- maxy [n=maxy@80-219-0-199.dclient.hispeed.ch] has quit [] 20090610 18:40:45-!- shadowmaster is now known as Shadow_Master 20090610 18:41:08-!- Shadow_Master is now known as shadowmaster 20090610 18:54:21-!- [Relic] [n=[Relic]@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20090610 18:54:27-!- Crab_ [i=crab@wesnoth/developer/crab] has left #wesnoth-dev [] 20090610 18:55:28< [Relic]> Hello :) 20090610 19:02:40-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev 20090610 19:05:08-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090610 19:07:46-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090610 19:11:47-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 19:30:15-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit ["On the road again"] 20090610 19:30:44-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090610 19:35:53-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20090610 19:36:20< mordante> servus 20090610 19:36:56< euschn> hi mordante 20090610 19:37:06< mordante> hi euschn 20090610 19:52:59-!- happygrue [n=George@wesnoth/developer/wintermute] has joined #wesnoth-dev 20090610 20:03:19-!- shadowmaster3 [n=ignacio@146.155.83.67] has joined #wesnoth-dev 20090610 20:08:58-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 54 (Connection reset by peer)] 20090610 20:10:23-!- happygrue_ [n=George@c-67-176-145-41.hsd1.in.comcast.net] has quit [Read error: 110 (Connection timed out)] 20090610 20:10:31-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 20:15:27-!- boucman [n=rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20090610 20:15:39< boucman> hey all 20090610 20:17:10< Ivanovic> hi boucman 20090610 20:17:42< mordante> hi boucman 20090610 20:17:48< euschn> hi boucman 20090610 20:17:52< boucman> :) 20090610 20:17:57< boucman> so, what's up ? 20090610 20:18:31< mordante> Soliton, r36113 doesn't that cause potential OOSes ? 20090610 20:18:40< shadowmaster> boucman: the price of gasoline 20090610 20:18:44< shadowmaster> it's really up ;) 20090610 20:18:56< boucman> shadowmaster hehe 20090610 20:19:10< mordante> Soliton, same for r36114 20090610 20:20:06< Soliton> mordante: not in mainline but it could... yeah. 20090610 20:20:28< mordante> Soliton, yes I was more concerned about UMC 20090610 20:21:40< Soliton> r36113 is very unlikely to matter anywhere. 20090610 20:22:04-!- shadowmaster3 [n=ignacio@146.155.83.67] has quit ["Lost terminal"] 20090610 20:23:11< Soliton> but that can just as well be reverted. it's worse for the steadfast fix... but i guess even if it is a bug fix it should be reverted. 20090610 20:24:04< Soliton> hmm, hmm, hmm. 20090610 20:24:56< mordante> how bad is the steadfast bug? 20090610 20:24:57< Soliton> well, another reason to switch to 1.7 i guess. 20090610 20:25:13-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit ["Lost terminal"] 20090610 20:26:18< Soliton> well, it's annoying for those UMC where you can modify resistances or get steadfast on any unit. but people have been living with it until now and i'm not even sure someone complained about it. (which is a bit odd) 20090610 20:27:01 * Soliton is playing Wesband atm. ;-) 20090610 20:27:53-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090610 20:29:43-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090610 20:29:47-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090610 20:31:17-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 60 (Operation timed out)] 20090610 20:31:31< CIA-77> soliton * r36124 /branches/1.6/data/core/macros/abilities.cfg: Revert "simplified steadfast a bit" since it can cause OOS in some UMC 20090610 20:31:39< CIA-77> soliton * r36125 /branches/1.6/src/ (unit.cpp unit.hpp unit_abilities.cpp unit_abilities.hpp): Revert "combine filter_base_value conditions with "and" instead of "or" and made resistance_filter_matches() also check the filter_base_value (fixes steadfast)" since it can cause OOS in some UMC 20090610 20:32:01-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has quit [Client Quit] 20090610 20:32:12< Soliton> mordante: good catch. didn't think about OOS there. 20090610 20:32:29< mordante> you're welcome 20090610 20:33:34-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090610 20:34:18-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090610 20:34:22-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090610 20:34:40-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090610 20:35:03-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090610 20:38:11-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090610 20:40:06-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 104 (Connection reset by peer)] 20090610 20:40:42-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090610 20:44:40-!- shadowmaster3 [n=ignacio@146.155.83.67] has joined #wesnoth-dev 20090610 20:46:10-!- shadowmaster3 [n=ignacio@146.155.83.67] has quit [Client Quit] 20090610 20:51:50-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has joined #wesnoth-dev 20090610 21:00:42< mordante> ilor around 20090610 21:00:44< mordante> ? 20090610 21:02:49-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090610 21:09:05-!- nonidShadowmaste [n=ignacio@146.155.83.67] has joined #wesnoth-dev 20090610 21:10:31-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out] 20090610 21:10:57-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090610 21:12:07-!- nonidShadowmaste is now known as unidShadowmaster 20090610 21:13:45-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"] 20090610 21:18:24-!- YogiHH [n=chatzill@c146188.adsl.hansenet.de] has joined #wesnoth-dev 20090610 21:18:34< YogiHH> hello everyone 20090610 21:18:51< mordante> hi YogiHH 20090610 21:19:12< euschn> hi YogiHH 20090610 21:29:30< ilor> hi mordante, sort-of around now, generally will work on Wesnoth later today, maybe a bit tomorrow, and certainly during the weekend 20090610 21:29:44< mordante> ok good to hear 20090610 21:30:23< mordante> do we need to discuss your progress or nothing new to mention yet? 20090610 21:30:31< ilor> I've just had one of the exams today, went quite well I think, and I've handed in a major project 20090610 21:30:59< ilor> not much yet, but I sure hope to have some chats on saturday :) 20090610 21:31:29-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Remote closed the connection] 20090610 21:31:47< mordante> ok good 20090610 21:32:08-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090610 21:32:25< mordante> things for the university going well? 20090610 21:32:26< ilor> as far as uni stuff goes, I have just one more coding project, but it's minor and not 100% compulsory, and some (3-4) exams that are some time away and I'm not the type that'd start studying that soon ;) 20090610 21:32:41< ilor> was already typing that, I'm not *that* fast :P 20090610 21:33:33< ilor> I guess I'll lay some groundwork for the lobby gui today 20090610 21:33:54< ilor> a full-screen window is still a "dialog" in gui2 terms? 20090610 21:36:19-!- unidShadowmaster [n=ignacio@146.155.83.67] has quit ["killed"] 20090610 21:36:40-!- ShikadiLord [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090610 21:37:50< mordante> ilor, I know the feeling of typing slowly ;-) 20090610 21:38:15< mordante> yes it is, I did the same for the title screen 20090610 21:38:23< mordante> (which is still WIP) 20090610 21:47:24-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090610 21:52:33-!- ShikadiLord [n=ignacio@wesnoth/developer/shadowmaster] has quit ["killed"] 20090610 22:00:59-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090610 22:01:50-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090610 22:02:02-!- ABCD_ is now known as ABCD 20090610 22:29:20-!- loonybot [n=loonybot@79.139.138.177] has joined #wesnoth-dev 20090610 22:29:41-!- Crab_ [i=crab@wesnoth/developer/crab] has quit ["Leaving."] 20090610 22:30:18-!- loonycyborg [n=sergey@79.139.138.177] has joined #wesnoth-dev 20090610 22:50:55< CIA-77> euschn * r36126 /trunk/src/ (play_controller.cpp tod_manager.cpp tod_manager.hpp): added turn members to tod_manager 20090610 22:57:09< mordante> I'm off night 20090610 22:57:32-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"] 20090610 23:04:58-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["night all, see you friday"] 20090610 23:09:55-!- elynia_ [n=shyde@wesnoth/umc-dev/misc/elynia] has joined #wesnoth-dev 20090610 23:10:12-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has quit [Nick collision from services.] 20090610 23:15:23-!- elynia_ is now known as elynia 20090610 23:22:41< shadowmaster> zookeeper: someone's concating me regarding the policy for adding mcampaigns to mainline. Should I forward the PM to you? 20090610 23:23:26-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has quit [Client Quit] 20090610 23:28:20-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer] 20090610 23:28:35-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090610 23:33:25< boucman> night all 20090610 23:33:32-!- boucman [n=rosen@wesnoth/developer/boucman] has quit ["Leaving."] 20090610 23:44:08< zookeeper> shadowmaster, well, i'd rather not type lengthy replies.. 20090610 23:50:37< CIA-77> euschn * r36127 /trunk/src/ (6 files): replaced turn related functions in play_controller by the respective functions of tod_manager 20090610 23:51:29-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"] 20090610 23:52:52< euschn> im off, good night 20090610 23:52:54-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit ["ChatZilla 0.9.84 [Firefox 3.0.10/2009042523]"] 20090610 23:54:24-!- YogiHH [n=chatzill@c146188.adsl.hansenet.de] has left #wesnoth-dev [] --- Log closed Thu Jun 11 00:00:16 2009