--- Log opened Thu Jul 09 00:00:20 2009 20090709 00:02:08-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [] 20090709 00:09:14-!- wesbot changed the topic of #wesnoth-dev to: 64 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090709 00:19:27-!- evilshadowm is now known as shadowmaster 20090709 00:20:24-!- Dragonking [n=dk@inet20908nb-1.nat.umts.dynamic.eranet.pl] has joined #wesnoth-dev 20090709 00:20:37< Dragonking> Crab_, Still around? :) 20090709 00:22:13< YogiHH> night everyone 20090709 00:22:24< Dragonking> night YogiHH 20090709 00:22:33-!- YogiHH [n=chatzill@d097023.adsl.hansenet.de] has left #wesnoth-dev [] 20090709 00:22:53< grzywacz> omg, it's Dragonking ;) 20090709 00:23:09< Dragonking> omg hai grzywacz ;] 20090709 00:24:07< shadowmaster> elias: since you are around... wesnoth_addon_manager didn't support .ign files last time I used it. Unless you have done any change to it lately, I guess it still doesn't. 20090709 00:24:23< shadowmaster> the lack of support for .ign files there could be considered a security bug by some ;) 20090709 00:24:45< elias> what is .ign? 20090709 00:25:24< elias> wesbot, define .ign 20090709 00:25:33< shadowmaster> elias: http://www.wesnoth.org/wiki/IGNFileFormat 20090709 00:25:56< elias> never can remember which bots in which channels support what :P 20090709 00:25:56< shadowmaster> it was originally implemented in 1.3.x IIRC. 20090709 00:26:40< shadowmaster> (in the C++ engine, that is) 20090709 00:26:51< elias> hm 20090709 00:27:07< elias> is wesnoth_addon_manager used a lot to upload files? 20090709 00:27:33< shadowmaster> I use it. 20090709 00:28:08< boucman> night all 20090709 00:28:13-!- boucman [n=rosen@wesnoth/developer/boucman] has quit ["Leaving."] 20090709 00:28:26< shadowmaster> Espreon noticed that my last upload contained certain files that I had added to the .ign pattern list. Files which do not contain sensitive information, but which I still preferred not to see published outside of our repository. 20090709 00:28:55< elias> ok, let me add it quick... 20090709 00:29:02< elias> can i see that .ign file of yours somewhere? 20090709 00:29:46< shadowmaster> I use that tool because I use either poor-bandwidth or overzealously-secured connections to connect to the Internet, and therefore I need to use a remote machine to upload to the add-ons server- and there's no X server running there for Wesnoth 20090709 00:30:21< shadowmaster> http://wesnoth-umc-dev.svn.sourceforge.net/viewvc/wesnoth-umc-dev/branches/1.6/Invasion_from_the_Unknown/_server.ign?view=markup 20090709 00:32:06< shadowmaster> when no .ign file is found, Wesnoth uses its own internal pattern list, generated from the function in src/addon_management.cpp line 154 20090709 00:33:53< shadowmaster> the actual pattern matching is done while storing the tree into WML on archive_dir() [src/addon_management.cpp line 225] 20090709 00:34:01< shadowmaster> elias: I belive that should suffice :) 20090709 00:35:53 * shadowmaster is off 20090709 00:42:21< elias> i added it, but did not test it 20090709 00:42:26< CIA-53> elias * r36708 /trunk/data/tools/ (wesnoth/campaignserver_client.py wesnoth_addon_manager): Added support for .ign files to wesnoth_addon_manager 20090709 00:43:12< elias> shadowmaster: just revert if I broke it, i'll be here tomorrow to fix it 20090709 00:43:52< shadowmaster> I wasn't planning to make a release unti lsaturaday 20090709 00:43:56< shadowmaster> saturday. 20090709 00:44:31< elias> i don't have any test campaign here else i would have tested. and going to bed now... 20090709 00:44:37< shadowmaster> I still need to finish writing some other tools (one in Perl, one in PHP, another in Perl) 20090709 00:44:38-!- Crab_ [i=crab@wesnoth/developer/crab] has quit [Read error: 110 (Connection timed out)] 20090709 00:44:53-!- elias [n=allefant@allegro/developer/allefant] has quit ["Leaving"] 20090709 00:45:23< crimson_penguin> Soliton: Is the last part of that bug also not true for you? 20090709 00:45:51< crimson_penguin> The Zhongwen part 20090709 00:46:16-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 00:46:40-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 00:48:16< Soliton> crimson_penguin: you mean the Nihongo part? 20090709 00:48:38 * ancestral listens in 20090709 00:59:15< Soliton> ancestral: you have to tell the translation maintainer if you want to change how a translation calls itself. 20090709 00:59:57< ancestral> Solition: Good to know. As it happens, I've already sent an email to the maintainer. 20090709 01:00:01< Soliton> and i don't see any consistence in what is put in paranthesis. 20090709 01:00:20-!- Dragonking [n=dk@inet20908nb-1.nat.umts.dynamic.eranet.pl] has quit ["Leaving"] 20090709 01:12:15-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection] 20090709 01:23:49-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["night all"] 20090709 01:27:04-!- BenUrban [n=benurban@68.55.19.224] has joined #wesnoth-dev 20090709 01:30:54-!- ilor_ [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090709 01:48:04-!- ilor [n=user@wesnoth/developer/ilor] has quit [Read error: 110 (Connection timed out)] 20090709 01:52:15-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit [Remote closed the connection] 20090709 01:52:33-!- ilor_ [n=user@wesnoth/developer/ilor] has quit [] 20090709 01:52:46-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090709 01:53:17-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit ["Hi! I'm a quit message virus vaccine. If you see a quit message virus, don't replace your quit message with it!"] 20090709 01:55:24-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090709 02:20:13-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090709 02:40:24-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090709 02:43:56-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 60 (Operation timed out)] 20090709 02:54:55-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 02:55:06-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 02:58:24-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 02:58:38-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 03:01:51-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090709 03:03:42-!- Doppp|EeePC [n=aasdasd@c-67-171-96-240.hsd1.pa.comcast.net] has joined #wesnoth-dev 20090709 03:16:50-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"] 20090709 03:22:33-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["Tengo que ir... Yeahzorz..."] 20090709 03:38:45-!- Sirp [n=me@wesnoth/developer/dave] has joined #wesnoth-dev 20090709 03:47:16-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 03:47:32-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 03:49:06-!- crimson_pinvin [n=ben@64.201.60.211] has joined #wesnoth-dev 20090709 03:49:34-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Client Quit] 20090709 03:51:16< CIA-53> soliton * r36709 /branches/1.6/src/server/simple_wml.cpp: added an assert to make sure we're not allocating crazy amounts of memory 20090709 03:52:06-!- MJ999 [n=msflower@80.154.28.81] has joined #wesnoth-dev 20090709 03:52:21< CIA-53> soliton * r36710 /trunk/src/server/simple_wml.cpp: added an assert to make sure we're not allocating crazy amounts of memory 20090709 03:52:35< CIA-53> soliton * r36711 /trunk/data/ (2 files in 2 dirs): synchronized mudcrawler configs 20090709 03:52:37-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 03:54:10-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090709 03:57:08-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [Read error: 113 (No route to host)] 20090709 03:57:48-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 04:00:10-!- cib0 [n=cib@p5DD34703.dip.t-dialin.net] has quit [Remote closed the connection] 20090709 04:00:25-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Connection reset by peer] 20090709 04:03:31-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)] 20090709 04:21:32-!- testing_xyz [n=johnTriv@87-126-108-161.btc-net.bg] has quit [Read error: 113 (No route to host)] 20090709 04:26:06-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090709 04:27:50-!- Ivanovic_ [n=ivanovic@dtmd-4db26631.pool.einsundeins.de] has joined #wesnoth-dev 20090709 04:36:39-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090709 04:38:09-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090709 04:44:11-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 113 (No route to host)] 20090709 04:45:48-!- Ivanovic_ is now known as Ivanovic 20090709 04:50:41-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has joined #wesnoth-dev 20090709 05:30:37< CIA-53> esr * r36712 /trunk/data/campaigns/Sceptre_of_Fire/utils/utils.cfg: Address bug #13911: Can't recall Scout line in Sc. 9 of SoF. 20090709 05:43:09< Turuk_> esr: Ping about edumicating me on the po fix for a pure typo 20090709 05:47:14-!- crimson_pinvin is now known as crimson_penguin 20090709 06:28:50-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["Tengo que ir... Yeahzorz..."] 20090709 06:43:32-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 101 (Network is unreachable)] 20090709 06:43:39-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 06:44:21-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090709 06:47:13-!- cjhopman [n=chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev 20090709 06:48:18< CIA-53> jetryl * r36713 /trunk/data/core/images/scenery/ (6 files): Added new versions of a number of scenery items, by Syntax_Error. 20090709 06:48:55< CIA-53> jetryl * r36714 /branches/1.6/data/core/images/scenery/ (6 files): Added new versions of a number of scenery items, by Syntax_Error. 20090709 06:52:26-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Connection reset by peer] 20090709 06:53:26-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 06:55:00-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 06:59:11-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090709 07:00:34-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:02:09-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 07:08:04-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Connection reset by peer] 20090709 07:12:56-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [] 20090709 07:14:01-!- Sirp [n=me@wesnoth/developer/dave] has quit ["leaving"] 20090709 07:14:09-!- Appleman1234 [n=Appleman@131.181.101.83] has joined #wesnoth-dev 20090709 07:15:15-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 07:24:27-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:25:07-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 07:30:18-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:30:20-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090709 07:31:36-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:32:54-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 07:39:13-!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:47:55-!- YogiHH [n=chatzill@c158139.adsl.hansenet.de] has joined #wesnoth-dev 20090709 07:52:31-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 07:56:26-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 08:02:12-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 08:02:13-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 08:04:45-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 08:07:22-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 08:10:31-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 08:11:12-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 08:16:44-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20090709 08:16:45-!- maxy [n=maxy@80-219-1-128.dclient.hispeed.ch] has joined #wesnoth-dev 20090709 08:17:01< silene> hi 20090709 08:28:15-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20090709 08:37:31-!- stikonas [n=and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20090709 08:40:58-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev 20090709 08:41:02< euschn> hi 20090709 08:41:47< MJ999> Good morning. 20090709 08:48:35-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Remote closed the connection] 20090709 08:53:42-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090709 08:56:31-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has joined #wesnoth-dev 20090709 09:05:56< YogiHH> hi euschn 20090709 09:06:12< euschn> hi YogiHH 20090709 09:17:36-!- YogiHH [n=chatzill@c158139.adsl.hansenet.de] has left #wesnoth-dev [] 20090709 09:19:35-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090709 09:24:20-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090709 09:25:21< Ivanovic> cjhopman: have you received the message from sapient? 20090709 09:26:31-!- stikonas [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090709 09:27:17< Ivanovic> cjhopman: please make sure to commit your code (and don't forget to fill out the mid term survey yourself) 20090709 09:33:31-!- Appleman1234 [n=Appleman@131.181.101.83] has quit ["Leaving"] 20090709 09:35:02< cjhopman> Ivanovic: yep 20090709 09:36:47< cjhopman> is the mailing list not working? 20090709 09:40:36< Ivanovic> hmm, there were some problems some days ago 20090709 09:40:42< Ivanovic> but it should be fine again 20090709 09:41:21< Ivanovic> the last mail that got into the archive is from 27th june 20090709 09:41:51< cjhopman> yeah, I tried to send something on sunday 20090709 09:45:48< Ivanovic> retry now, should work again 20090709 09:47:11< Ivanovic> that is: have you attached anything? 20090709 09:47:17< Ivanovic> some attachments are blocked 20090709 09:49:42< Ivanovic> you are not on the blacklist, so there should be no specific problem 20090709 09:50:08< Ivanovic> i will head off to uni rather soon, so i am not able to look into things too deeply right now 20090709 09:50:17< cjhopman> I just tried to resend it... just send to wesnoth-dev@gna.org, right? 20090709 09:50:53< Ivanovic> jupp 20090709 09:52:40< Ivanovic> i know where one of your mails went 20090709 09:52:42< Ivanovic> https://mail.gna.org/public/spam/2009-07/msg05160.html 20090709 09:53:31< Ivanovic> resend it as plain text and it *should* go through, not 100% sure though 20090709 09:53:47< cjhopman> aha, thanks 20090709 09:53:55< CIA-53> euschn * r36715 /trunk/src/gamestatus.cpp: changed write_players to use snapshot information only if specified by parameters 20090709 10:11:14< Ivanovic> the one you sent about 20mins ago ended in the spamfilter, too 20090709 10:17:49< Ivanovic> might be that it chokes on the amount of markup code in the mail and identifies it as html and thus blocks as "too much of it" 20090709 10:25:15< Ivanovic> got to head off to uni now, cu 20090709 10:36:38-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20090709 10:37:34-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has quit ["Saurian Augur - I'll heal you by 4 hp if you leave next to me"] 20090709 10:45:22-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090709 10:47:18< CIA-53> euschn * r36716 /trunk/src/ (gamestatus.cpp playcampaign.cpp): game_state::write_snapshot no longer uses player_info if use_snapshot is true 20090709 11:08:00-!- loonybot [n=loonybot@79.139.138.33] has joined #wesnoth-dev 20090709 11:08:45-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090709 11:12:04-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"] 20090709 11:19:35< ilor> wtf, "scons wesnoth" just started spamming translations info 20090709 11:22:46< loonycyborg> It wasn't doing that due to a bug in the script I fixed. Those can be disabled with nls=false 20090709 11:29:24< ilor> loonycyborg: ah, okay :) 20090709 11:34:55-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20090709 11:40:12-!- silene [n=plouf@wesnoth/developer/silene] has quit [Read error: 110 (Connection timed out)] 20090709 11:40:17-!- silene [n=plouf@ASte-Genev-Bois-152-1-61-249.w83-114.abo.wanadoo.fr] has joined #wesnoth-dev 20090709 11:43:28-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090709 11:46:44< CIA-53> euschn * r36717 /trunk/src/variable.cpp: replaced player_info references in variable.cpp by team references 20090709 11:53:28< CIA-53> euschn * r36718 /trunk/src/variable.cpp: removed unused player_info reference 20090709 12:11:49-!- Netsplit sendak.freenode.net <-> irc.freenode.net quits: Rhonda, stikonas, Mellar, Polarina, yann, Doppp|EeePC, fendrin, corn, maxy, MJ999, (+13 more, use /NETSPLIT to show all of them) 20090709 12:12:24-!- Dragonking [n=dk@inet20908na-2.nat.umts.dynamic.eranet.pl] has joined #wesnoth-dev 20090709 12:12:30-!- Netsplit over, joins: ABCD_, Ivanovic, fendrin, shikadibot, Rhonda, Amu, Smar, erl, mjs-de, stikonas (+3 more) 20090709 12:13:34-!- Netsplit over, joins: thespaceinvader, Doppp|EeePC, BenUrban, Doppp, Polarina, Mellar, maxy, MJ999, esr, CIA-53 20090709 12:14:16-!- Dragonking [n=dk@inet20908na-2.nat.umts.dynamic.eranet.pl] has quit [Client Quit] 20090709 12:15:03-!- Dragonking [n=dk@inet20908na-2.nat.umts.dynamic.eranet.pl] has joined #wesnoth-dev 20090709 12:15:10< Dragonking> hi everyone 20090709 12:15:14< Dragonking> Crab_, Around? 20090709 12:15:19< Crab_> yes, but not for long 20090709 12:15:28< Dragonking> Crab_, Ok, I need only 5 min ;p 20090709 12:17:04< Dragonking> Crab_, I think I mostly finished the patch, maybe some bugs left, but I'll take a look at it again once I have latest branch in home 20090709 12:17:15< Crab_> ok 20090709 12:17:33< Dragonking> Crab_, I removed all "local" checks from ai.cpp and rely only on check_XXX_action 20090709 12:17:46< Dragonking> Crab_, But I see already 2 things that are not checked there.. 20090709 12:17:50-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090709 12:18:11< Dragonking> Crab_, It does not check if dst during move is valid location, thus making game crash somewhere in pathfinder 20090709 12:18:57< Dragonking> Crab_, And attack_action does not check if defender is next to attacker - today I just attacked with meele unit that was 5 hexes away 20090709 12:19:08< Dragonking> Crab_, Patch is here http://wesnoth.pastebin.com/m34ea072e 20090709 12:19:24< Crab_> ok, I'll add those two checks 20090709 12:19:28< Dragonking> Once you have some time please take look at it/commit it ok? 20090709 12:19:32< Dragonking> Thanks :) 20090709 12:19:56< Crab_> Dragonking: so, you want me to commit it if it is ok ? 20090709 12:20:04< Crab_> (@today's evening) 20090709 12:20:04< Dragonking> Crab_, This gamestate_observer is pretty neat :) 20090709 12:20:11< Dragonking> Crab_, Yes 20090709 12:20:53< Dragonking> Crab_, I want it to be already there so you can work on any changes you want inside formula/ai.cpp without worrying about possible conflicts 20090709 12:21:18< Crab_> note that gamestate_observer raises events even if it's not 'that ai turn' 20090709 12:21:58< Crab_> so, any invalidation done in it should be done 'cheaply', (such as setting move_maps_valid_=false, etc) 20090709 12:22:16< Dragonking> Well, I just use it to reset two counters to 0 so it should be ok 20090709 12:23:47< Dragonking> Crab_, It is possible that there are osme bugs lest, it's difficult to test everything now.. but once I get back to my home (saturday) and you commit these 2 checks form above I'll look at it more 20090709 12:23:58< Crab_> ok 20090709 12:25:10< Dragonking> Crab_, I'll come here around evening, so if you have any comments then I can read them then 20090709 12:26:08< Crab_> ok. I'll commit a patch to make get_unit_location work, soon (~ 5 minutes) 20090709 12:26:15< Dragonking> Crab_, Thanks a lot, since you are in rush then I won't bother you now :) 20090709 12:26:29< Crab_> Dragonking: no, it was done yesterday 20090709 12:26:40< Crab_> Dragonking: but boucman asked to rename a class in it a bit 20090709 12:26:51< Dragonking> Crab_, Yes? 20090709 12:27:34< Dragonking> Crab_, Well, renaming can be done anytime, that's not a problem I think :) 20090709 12:27:51< Crab_> (I've named a class move_unit_observer, and he asked to change 'observer' part to something else ) 20090709 12:27:52< Dragonking> Crab_, Ah now I remember, I did not write a notice about 5XXX being reserved 20090709 12:28:31< Dragonking> Crab_, I see 20090709 12:28:45< Crab_> Dragonking: btw, set_var sets global per-ai variables? 20090709 12:29:47< Dragonking> Crab_, I made local observer within AI, and this observer counts locally in it calls to set_var/set_unit_var 20090709 12:30:45< Dragonking> We do something like if( check() ) and check() return true/false and iincrements needed variable 20090709 12:30:54< Dragonking> So it is locally inside one AI 20090709 12:30:56< Crab_> Dragonking: no, I was thinking about a different thing... if set_var sets global per-ai variables, maybe they can be made usable by non-fai code, as well ? by making ai::setvar_action_result c++ function in src/ai/actions 20090709 12:31:28< Dragonking> Crab_, Hmmm 20090709 12:31:36< Dragonking> Crab_, Yes, it may be a good idea 20090709 12:32:45< Crab_> Dragonking: I'll see if there any good uses for that 20090709 12:33:02< Dragonking> Crab_, Great :) 20090709 12:33:08< Dragonking> Crab_, ok, I need ot disappear now 20090709 12:33:29< Crab_> for example, allow fai/cpp to set/get global aggression/caution parameters .. 20090709 12:33:45< Crab_> ok 20090709 12:33:52< Dragonking> Crab_, If you spot any bugs/etc feel free to fix it, if it is trivial or if you want to, or just tall me once I'm here :) 20090709 12:33:58< Crab_> ok 20090709 12:34:05< Dragonking> Thanks a lot again, sorry for troubleing you 20090709 12:34:10< Crab_> np 20090709 12:34:20< Dragonking> bye :) 20090709 12:34:23-!- Dragonking [n=dk@inet20908na-2.nat.umts.dynamic.eranet.pl] has quit ["Leaving"] 20090709 12:36:34< CIA-53> crab * r36719 /trunk/src/ (7 files in 2 dirs): move_unit_spectator - collect info about allies/enemies/ambushers/failed_teleports/bugs/etc spotted during a move, for the AI to use 20090709 12:37:46-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."] 20090709 12:47:17-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has joined #wesnoth-dev 20090709 12:50:53-!- stikonas_ [n=and@ctv-213-164-98-244.vinita.lt] has joined #wesnoth-dev 20090709 12:50:53-!- testing_xyz [n=johnTriv@87-126-108-161.btc-net.bg] has joined #wesnoth-dev 20090709 13:04:46-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 110 (Connection timed out)] 20090709 13:39:44-!- EdB [n=edb@79.88.117.190] has joined #wesnoth-dev 20090709 13:46:01< silene> 20090709 13:46:16-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 13:46:39-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 13:57:56-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 14:02:08< CIA-53> euschn * r36720 /trunk/src/ (team.cpp team.hpp): added a gold_add member to class team 20090709 14:06:13-!- EdB [n=edb@79.88.117.190] has quit [Remote closed the connection] 20090709 14:16:11-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 14:16:17-!- stikonas_ is now known as stikonas 20090709 14:18:41-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090709 14:20:29-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Connection reset by peer] 20090709 14:21:14-!- ettin_ [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev 20090709 14:23:54< CIA-53> euschn * r36721 /trunk/src/ (team.cpp team.hpp): added team::write_player() 20090709 14:25:25-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 14:26:03-!- maxy [n=maxy@80-219-1-128.dclient.hispeed.ch] has quit [] 20090709 14:29:35-!- Doppp|EeePC [n=aasdasd@c-67-171-96-240.hsd1.pa.comcast.net] has quit ["Leaving."] 20090709 14:32:16-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has left #wesnoth-dev [] 20090709 14:34:58-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)] 20090709 14:51:39-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 54 (Connection reset by peer)] 20090709 14:51:58-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 14:54:28< CIA-53> euschn * r36722 /trunk/src/ (gamestatus.cpp savegame.cpp team.hpp): game_savegame::write_game_snapshot now uses the teams' recall lists for the snapshot.player tag 20090709 14:57:45-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 14:59:23-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 15:19:18-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 15:21:03-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 15:24:21-!- Sapient [n=patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev 20090709 15:24:33< Sapient> hi euschn 20090709 15:24:43< Sapient> hi cjhopman 20090709 15:24:46< euschn> hi Sapient 20090709 15:25:40< Sapient> euschn: in variable.cpp, you removed four lines and added 11... wouldn't it make more sense to add a utility function to team_manager? 20090709 15:26:36< Sapient> just a suggestion 20090709 15:28:18< euschn> Sapient: you are right, i could reduce the lines in scoped_recall_unit::activate() if i added some get_team_by_save_id() function to teams_manager 20090709 15:29:03< euschn> I currently working on a fix to , I will look into it afterwards 20090709 15:29:04< Sapient> or something to get the recall list perhaps 20090709 15:29:16< esr> euschn: Oh, good. 20090709 15:29:30< esr> That one is kpretty nasty. 20090709 15:30:24< euschn> esr: I have identified the problem: in the talk only scenario thats coming up, the player hamel is declared first in the scenariowml, which gives him the first team 20090709 15:30:52< euschn> upload_log (or playsingle_controller ) assumes aiglondur is the first team aswell, as he is the first player 20090709 15:32:14< euschn> does anyone know if upload_log is supposed to log all units of a scenario or just the ones of the "first human player"? 20090709 15:32:26< euschn> upload_log::start(), that is 20090709 15:33:10< Sapient> probably the first human player 20090709 15:33:20< Sapient> since it is for player statistics 20090709 15:38:19< euschn> ok, then this is kindof tricky. In the second scenario, "Hamel" (a non-player story only character?) is defined as the first player by the scenarioWML and not the actual player Aiglondur. So its not Aiglondurs recall list and gold which is logged but Hamels 20090709 15:39:29< euschn> a quick solution would be to either make Hamel the second human player in the scenario file, or to supply upload_log with all teams, so it will log the recall list of all human teams 20090709 15:40:45< euschn> or I could jsut remove the assertion for now, meaning that Aiglondurs recall list is not logged in the story only scenario until i come up with a better fix 20090709 15:41:45< euschn> it seems this problem existed even before my changes to player_info/team, the gold in upload_log is always taken from the team, which is in this case the wrong one (Hamels) 20090709 15:47:51< CIA-53> euschn * r36723 /trunk/src/upload_log.cpp: removed failing assertion about player_info/teams in upload_log.cpp, proper solution is work in progress (player_info removal) 20090709 15:49:56-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090709 16:05:24-!- happygrue [n=George@wesnoth/developer/wintermute] has joined #wesnoth-dev 20090709 16:07:33< Soliton> just fix the scenario IMO. i doubt that is the only case where player == team 1 is assumed. 20090709 16:08:02-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev 20090709 16:24:36< Ivanovic> hi 20090709 16:28:08< crimson_penguin> hi Ivanovic 20090709 16:28:45< crimson_penguin> so I CAN reproduce 1.6 looking DIFFERENT in the languages menu 20090709 16:29:08< Ivanovic> ??? 20090709 16:29:30< crimson_penguin> https://gna.org/bugs/?13905 20090709 16:30:36< crimson_penguin> the funny thing is, in 1.6.4, for everyone else it isn't finding a font at all, but for me, ALL of the languages have proper glyphs 20090709 16:30:59< Ivanovic> the url does currently not want to load for me 20090709 16:31:12< Ivanovic> afk for some mins anyway (just came home and got some things to do) 20090709 16:31:36< crimson_penguin> Well basically, in languages with non-roman glyphs, the game crashes on any pango text, for people other than me, on Mac 20090709 16:31:44< crimson_penguin> I'll brb too 20090709 16:33:21< Sapient> cjhopman: for what it's worth, I prefer the proxy approach over set_attribute(), because it has the lowest impact on the existing code style 20090709 16:34:19< Sapient> it's not a necessity of course 20090709 16:34:36< Sapient> just a stylistic preference / laziness ;) 20090709 16:39:45-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"] 20090709 16:43:24< silene> Sapient, cjhopman: i think it is a necessity; gratuitiously modifying tens (100?) of files is a no-no 20090709 16:44:07< silene> not counting that it makes the code harder to read in my opinion 20090709 16:44:38< Sapient> I also prefer to tread lightly upon existing conventions, especially in such a large project 20090709 16:45:28-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["ChatZilla 0.9.85 [Firefox 3.0.11/2009060215]"] 20090709 16:47:19< Sapient> altough, "harder to read" may be overstating the case a bit, I am definitely a fan of brevity and reduced keystrokes 20090709 16:55:39-!- Rrenys [n=rrenys@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090709 17:01:08< silene> think about the following line for instance: image(cfg["image"]), name(cfg["name"]), id(cfg["id"]), ...; it would become 40 characters longer! 20090709 17:04:10< silene> according to grep, 17 lines would gain 40 characters, 263 lines would gain 30 characters, and so on... i really think it makes the code harder to understand at first glance 20090709 17:09:14-!- fabi [n=fabi@78.52.75.176] has joined #wesnoth-dev 20090709 17:12:20-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 17:13:51-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 17:16:49-!- Baufo [n=quassel@62-47-141-246.adsl.highway.telekom.at] has joined #wesnoth-dev 20090709 17:19:23< crimson_penguin> I think I need to talk to whoever the pango person is 20090709 17:24:48-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Read error: 110 (Connection timed out)] 20090709 17:24:59-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 17:25:07< Ivanovic> that is mordante 20090709 17:26:01-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090709 17:31:10< Ivanovic> cjhopman: i am copy&pasting your mail and sending it to the dev-ml anyway 20090709 17:31:19< Ivanovic> maybe mine will get through... 20090709 17:33:30< Ivanovic> okay, it got to the list 20090709 17:39:33< CIA-53> elias * r36724 /trunk/data/tools/wesnoth/campaignserver_client.py: [addon_manager] fixed typo in my last commit 20090709 17:45:33-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090709 17:51:35-!- noy [n=Noy@wesnoth/developer/noy] has quit [] 20090709 17:53:08-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090709 18:09:14-!- wesbot changed the topic of #wesnoth-dev to: 63 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090709 18:13:41-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090709 18:26:08-!- Baufo [n=quassel@wesnoth/developer/baufo] has quit [Remote closed the connection] 20090709 18:30:24-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090709 18:57:20-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit ["ChatZilla 0.9.85 [Firefox 3.0.10/2009042523]"] 20090709 18:59:27-!- YogiHH [n=chatzill@d097211.adsl.hansenet.de] has joined #wesnoth-dev 20090709 19:00:12-!- ardesh [n=ardesh@port-92-206-103-103.dynamic.qsc.de] has joined #wesnoth-dev 20090709 19:10:28-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20090709 19:46:48-!- Baufo [n=quassel@62-47-141-246.adsl.highway.telekom.at] has joined #wesnoth-dev 20090709 20:02:34-!- Doppp|EeePC [n=aasdasd@CMU-326818.WV.CC.CMU.EDU] has joined #wesnoth-dev 20090709 20:03:43-!- EdB [n=edb@79.95.12.161] has joined #wesnoth-dev 20090709 20:13:46-!- Doppp|EeePC [n=aasdasd@CMU-326818.WV.CC.CMU.EDU] has quit ["Leaving."] 20090709 20:14:02-!- Doppp|EeePC1 [n=aasdasd@CMU-326818.WV.CC.CMU.EDU] has joined #wesnoth-dev 20090709 20:14:55-!- kitty_ [n=kitty@wesnoth/artist/kitty] has joined #wesnoth-dev 20090709 20:16:37-!- Dragonking [n=dk@inet20909nb-2.nat.umts.dynamic.eranet.pl] has joined #wesnoth-dev 20090709 20:22:44< Crab_> hi Dragonking 20090709 20:23:43< Dragonking> hi Crab_ :) 20090709 20:24:14< Crab_> I've reread your new patch. 20090709 20:24:21< Dragonking> And? 20090709 20:24:50< Crab_> looks good, but there's one place I don't like ( http://wesnoth.pastebin.com/m6349c9b0 ) 20090709 20:25:51-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090709 20:26:16< Dragonking> Crab_, ok.. 20090709 20:27:11< Crab_> for example, at line #47, 'if( status != 0 ) {' - this part will be executed if move is failed, too 20090709 20:27:51< Crab_> so, for example, 'LOG_AI << "ERROR #" << status << " while executing 'attack' formula function\n\n";' will be displayed twice 20090709 20:28:13< Dragonking> Crab_, Yes, I realized that too now... you're right 20090709 20:28:28< Crab_> and 'error = variant(new safe_call_result(attack,status, move_result->get_unit_location()));' will be overwritten 20090709 20:28:39< Crab_> so, I don't like that control flow. 20090709 20:28:57< Dragonking> Yes, I understand 20090709 20:30:30< Crab_> Dragonking: and also note that http://wesnoth.pastebin.com/m36bd3a55 is overkill 20090709 20:31:05< Crab_> it makes no sense to check_move_action if you want to execute it NOW. 20090709 20:31:16< Crab_> it's better to just call execute_move_action 20090709 20:31:22< Crab_> it will do that check anyway 20090709 20:31:51< Crab_> check_move_action is needed If we want to check that a move is ok, but don't want to execute it immediately 20090709 20:32:03< Crab_> say, if we want to "do the check in rca evaluation, execute in rca execution" 20090709 20:32:06< Dragonking> Crab_, Well isn't it the same what I did in all places there? 20090709 20:32:28< Crab_> Dragonking: see http://wesnoth.pastebin.com/m757041de for an example 20090709 20:33:00< Dragonking> Crab_, I took a note about check_move_action after you said that I can use it there, so I used it there 20090709 20:33:38< Crab_> yes, you can. but, now I see that in this case it's better to 'just execute' 20090709 20:33:44< Dragonking> Crab_, Before i just used execute... 20090709 20:34:01< Dragonking> ok 20090709 20:34:48< Dragonking> Well, when you said I can use it like it I thought there's some deeper meaning behind it and just wrote it in this way :) 20090709 20:35:02< Crab_> yes, there's 'some deeper meaning' :) 20090709 20:35:10< Crab_> but, in your case, execute is better 20090709 20:35:16< Dragonking> ok 20090709 20:35:29< Crab_> sorry for confusing you before :) 20090709 20:35:55< Dragonking> No problem :) 20090709 20:36:09< Crab_> I wasn't sure that you've wanted to 'execute to move immediately if it's ok', that's why I've said about check_move_result 20090709 20:36:14< Dragonking> It's not that fixing it it will cause some load of work after all 20090709 20:36:46< Dragonking> Yes, I wanted to just execute it 20090709 20:37:40< Crab_> Dragonking: ok. then, see + } else if( action.is_string() && action.as_string() == "continue") { + made_moves.push_back(action); 20090709 20:37:56< Crab_> isn't this a potential infinite loop on continue ? 20090709 20:38:16< Dragonking> Crab_, ok, that's minor thing for now, regardinf http://wesnoth.pastebin.com/m6349c9b0 we just can change the flow and move lines 47-66 in 34 (and simplify it a bit too) 20090709 20:39:27< Dragonking> Crab_, it is, I forgot to add this to the counter 20090709 20:40:10< Crab_> Dragonking: also note a minor thing - I do a partial move, not a full move, in 'moving to target' part of the attack 20090709 20:40:39< Dragonking> Yes? 20090709 20:41:06< Crab_> yes. it's the same in most situations, but not in all. 20090709 20:41:32< Crab_> sometimes, you, as a skirmisher, move successfully next to an enemy, and then a WML event snatches the enemy away 20090709 20:41:58< Crab_> if you do only a partial move, you'll still have chances to move somewhere else. 20090709 20:42:08< Dragonking> ok 20090709 20:42:10< Dragonking> Good point 20090709 20:42:38< Crab_> also note that there is engine support for weapons which don't use all MP 20090709 20:42:47< Crab_> a_.get_unit().set_movement(a_.get_unit().movement_left()-a_.get_unit().attacks()[attack_with].movement_used()); 20090709 20:43:08< Crab_> I was told that some UMC (rpg-like, for example) uses it 20090709 20:43:20< Dragonking> oh, good to know 20090709 20:43:28< Dragonking> I was not aware of it 20090709 20:44:23< Dragonking> Yes, so changing 'true' t 'false' there should adress that 20090709 20:44:26< Crab_> yes 20090709 20:44:53< Dragonking> Crab_, Should I fix it and send you another patch? 20090709 20:45:11< Crab_> will you be here for another 10min ? 20090709 20:45:24< Crab_> I can try to pastebin a proposed patch, and then you'll fix it. 20090709 20:45:35< Dragonking> Crab_, If my connection let me :) 20090709 20:45:44< Dragonking> Sure 20090709 20:54:25< Crab_> Dragonking: what do you think about this control flow ? http://wesnoth.pastebin.com/m742d7a78 20090709 20:54:43< Crab_> oops, sorry, wait a bit :) 20090709 20:56:58< Crab_> Dragonking: here, http://wesnoth.pastebin.com/m51a81b5a 20090709 20:57:02< Dragonking> :) 20090709 20:57:50< Dragonking> Oh, I wasn't aware of move_result.valid() 20090709 20:57:54< Dragonking> Yes, it looks nice 20090709 20:57:59< Crab_> it's from boost::shared_ptr 20090709 20:58:12< Dragonking> Ahhhhh yes 20090709 20:58:15< Dragonking> Right 20090709 20:58:19< Dragonking> It uses it 20090709 20:58:21< Dragonking> :) 20090709 20:58:37< Dragonking> Crab_, Yes, that's good flow 20090709 20:59:06< Crab_> Dragonking: I think that even if (!move_result || move_result->is_ok() ) will work 20090709 20:59:47< Crab_> note that ->is_ok() is equivalent to status==0 20090709 20:59:57< Dragonking> ok 20090709 21:00:21-!- Doppp|EeePC1 [n=aasdasd@CMU-326818.WV.CC.CMU.EDU] has quit ["Leaving."] 20090709 21:00:22< Dragonking> It will be good like this then 20090709 21:00:38< Dragonking> Crab_, So I'll change other check_.. to execute_.. too 20090709 21:00:43< Crab_> ok 20090709 21:01:18< Dragonking> Add this counter to continue and change true to false in attack's move 20090709 21:01:24< Dragonking> Anything else? 20090709 21:01:43< Crab_> Dragonking: btw, why do you pass status and unit_location to safe_call_result ? 20090709 21:02:26< Dragonking> Crab_, To know from status what went wrong later and to know location in case status indicated that movement was interrupted 20090709 21:02:39< Crab_> why not a smart pointer to ai::action_result ? 20090709 21:03:05< Crab_> are you sure that you will not need all those extra info about failure later ? 20090709 21:03:36< Dragonking> Crab_, I would need ot make it derived from formula_callable and I didn't want to mess with it :) 20090709 21:03:45< Dragonking> Crab_, What extra info? 20090709 21:03:55-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090709 21:04:18< Crab_> for example: ambusher location, failed teleport location, spotted units, etc.. 20090709 21:05:16< Dragonking> Yes, ambusher location was something I've been thinking about too 20090709 21:07:25< Dragonking> Crab_, If you have nothing against making action_result inherit after formula_callable I may just do it and add needed functionality, but I think it may wait for now 20090709 21:07:57< Crab_> Dragonking: hehe, I recommended this inheritance to you at some point :) 20090709 21:08:28< Dragonking> Crab_, Really? Must have missed that :/ 20090709 21:09:00< Crab_> Dragonking: note that you can just add "typedef boost::shared_ptr action_result_ptr;" to src/ai/actions.hpp , and replace 'int status' constructor parameter with 'action_result_ptr failed_action' 20090709 21:09:41< Crab_> this will allow you to get status as failed_action->get_status(), and will allow to do something else with it later 20090709 21:10:14< Crab_> (e.g., dynamic casting it to get specific action result or templating the code or something else..) 20090709 21:10:37< Crab_> but this is 'not so important' 20090709 21:10:50< Crab_> I was just wondering about the possible number of constructor parameters :) 20090709 21:11:08< Dragonking> Crab_, ok, I'll keep that in mind :) 20090709 21:12:56< Dragonking> Crab_, Hm, I just got info I'll be in home tomorrow not the day after... 20090709 21:13:05< Dragonking> Crab_, So I think I won't bother yo with commiting it today, just fix it and commit tomorrow 20090709 21:13:06< Crab_> good ) 20090709 21:13:28< Crab_> so, you expect to commit it tomorrow ? 20090709 21:13:43< Dragonking> I would like to 20090709 21:13:48< Crab_> good 20090709 21:14:00< Dragonking> Fixing it is not a big deal 20090709 21:14:31-!- EdB [n=edb@79.95.12.161] has quit [Remote closed the connection] 20090709 21:15:13< Dragonking> Crab_, I'll commit it in a way how it is now (besides issues mentioned earlier), and do some other urgent things form my 'todo' list, but after modterm eval when I'll work on documentation I'm going to add this formula_callable inheritance 20090709 21:15:21< Crab_> ok 20090709 21:16:03< Dragonking> Crab_, Thanks a lot, for guiding me through your code :) 20090709 21:16:10< Crab_> Dragonking: and, regarding 'hehe, I recommended this inheritance to you at some point \ Really? Must have missed that :/' : 05/07: 17:35 (me, about ai actions) you'll probably need to make them implement your special interface which contains get_inputs and get_value 20090709 21:16:58< Dragonking> Crab_, I really missed that one, sorry :( 20090709 21:17:24< Crab_> np 20090709 21:17:45< Dragonking> That would make things simpler form the very beginning :) 20090709 21:18:11< Crab_> at least you now know all the tiny details of their semantics :) 20090709 21:18:58< Dragonking> I wouldn't dare to say 'all the tiny details' but yes, I'm quite fammiliar now :) 20090709 21:19:07< Dragonking> The deeper I go the more I like how it looks 20090709 21:19:16< Crab_> thanks :) 20090709 21:20:50-!- kitty_ [n=kitty@wesnoth/artist/kitty] has quit [] 20090709 21:21:24< Sapient> if you burrow too deeply, the crab will come out of his burrow and pinch you ;) 20090709 21:22:08< Crab_> he-he :) 20090709 21:22:47< Dragonking> ;) 20090709 21:31:04< Dragonking> I'm going now, will be back tomorrow 20090709 21:31:10< Dragonking> bye bye 20090709 21:31:19-!- Dragonking [n=dk@inet20909nb-2.nat.umts.dynamic.eranet.pl] has quit ["Leaving"] 20090709 21:35:22-!- Sapient [n=patrickp@wesnoth/developer/sapient] has left #wesnoth-dev [] 20090709 21:40:47-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev 20090709 21:56:49-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."] 20090709 21:56:57-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20090709 22:08:22-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Read error: 104 (Connection reset by peer)] 20090709 22:24:34-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has joined #wesnoth-dev 20090709 22:28:15-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090709 22:31:00-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20090709 22:32:23< Rhonda> Can we get empty folders deleted in svn? Like in the campaign area where all the images moved to the main namespace? 20090709 22:32:48< Rhonda> It creates empty directories in the tarballs and with that empty directories carried out in the binary packages. 20090709 22:34:20-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090709 22:34:54< Ivanovic> Rhonda: can you pastebin the empty dirs somewhere? 20090709 22:35:20< Ivanovic> that is: complete path from trunk/ onwards (eg data/campaigns/whatever/images/whatever2/) 20090709 22:35:26< Ivanovic> then svn rm is a lot easier to run 20090709 22:35:28< Ivanovic> ;) 20090709 22:35:58< Rhonda> Ivanovic: http://wesnoth.debian.net/%23wesnoth-de-2009-07-09.log - it lasts longer than a pastebin. :P 20090709 22:37:18< Rhonda> :~$ w3m http://wesnoth.debian.net/%23wesnoth-de-2009-07-09.log | grep empty | awk '{print $6}' | sed -e sxusr/share/games/wesnoth/xx | tr \\n \ 20090709 22:37:22< Rhonda> data/campaigns/The_South_Guard/images/attacks/ data/campaigns/Northern_Rebirth/images/units/ data/campaigns/Sceptre_of_Fire/images/story/ data/core/images/portraits/nagas/transparent/ data/core/images/titlescreen/ data/core/images/transparent/ data/campaigns/The_Hammer_of_Thursagan/images/attacks/ data/campaigns/Under_the_Burning_Suns/images/units/dwarves/ data/campaigns/The_Rise_Of_Wesnoth/images/units/human-outlaws/ data/campaigns/Delfadors 20090709 22:37:40< Rhonda> Hope that helps. :) 20090709 22:39:00< elias> shadowmaster: did you try if uploading still works in trunk (and if it handles .ign files now)? 20090709 22:39:19< shadowmaster> no 20090709 22:43:22< grzywacz> hi 20090709 22:45:08-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090709 22:47:44-!- Baufo [n=quassel@wesnoth/developer/baufo] has quit [Remote closed the connection] 20090709 23:08:51-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090709 23:15:55-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090709 23:26:43-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Remote closed the connection] 20090709 23:27:28-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090709 23:30:33-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090709 23:31:24-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090709 23:31:55-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090709 23:33:06-!- shadowmaster [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit] 20090709 23:33:21-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090709 23:36:13-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has quit [SendQ exceeded] 20090709 23:36:17-!- Shadow_Master [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090709 23:36:19-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."] 20090709 23:37:49-!- Shadow_Master is now known as irmorelle 20090709 23:41:01< Soliton> zookeeper: the orcish shamans should have orcishfoot instead of smallfoot, yes? 20090709 23:41:55-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 60 (Operation timed out)] 20090709 23:45:13-!- giusef [n=giusef@unaffiliated/giusef] has quit ["exit (-1);"] 20090709 23:45:45< zookeeper> Soliton, well, sounds like that'd make sense 20090709 23:47:15-!- irmorelle is now known as shadowmaster 20090709 23:48:42-!- boucman [n=rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20090709 23:53:30< crimson_penguin> ARGH! 20090709 23:53:56< crimson_penguin> It thought I double-posted on Gna!, but I didn't! 20090709 23:55:51< shadowmaster> turuk. 20090709 23:55:53< crimson_penguin> That was a really long post, and the way Gna! is setup, my browser won't put the data back when I click back :( 20090709 23:55:53< shadowmaster> dammit. 20090709 23:56:42< Ivanovic> outsch 20090709 23:56:51< crimson_penguin> I can resubmit it, but I can't see what I'm submitting to copy it, or edit it so it'll actually go through... 20090709 23:58:57-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090709 23:59:32-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev --- Log closed Fri Jul 10 00:00:05 2009