--- Log opened Sun Jul 19 00:00:48 2009 20090719 00:01:28-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090719 00:03:39-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Read error: 110 (Connection timed out)] 20090719 00:07:37-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit ["On the road again"] 20090719 00:13:21-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [] 20090719 00:15:02-!- Crab_ [i=crab@wesnoth/developer/crab] has quit ["Leaving."] 20090719 00:20:32-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["quit"] 20090719 00:23:47-!- ardesh [n=ardesh@port-92-206-120-4.dynamic.qsc.de] has joined #wesnoth-dev 20090719 00:30:58-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit [] 20090719 00:46:29-!- loonybot [n=loonybot@79.139.138.33] has joined #wesnoth-dev 20090719 00:47:13-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090719 00:48:17-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["WRYYYYYYYYYYYYYYYYYYYY!"] 20090719 00:49:08-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090719 00:53:19-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090719 00:53:38-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"] 20090719 00:54:08-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090719 01:02:32< AI0867> mordante: 0 was the hardcoded value 20090719 01:19:00-!- Zarel [i=Zarel@warzone2100/developer/Zarel] has quit [Read error: 110 (Connection timed out)] 20090719 01:20:18-!- Crab_ [i=crab@wesnoth/developer/crab] has quit ["Leaving."] 20090719 01:22:29-!- mordocai [n=mordocai@66.119.9.243] has quit [Read error: 110 (Connection timed out)] 20090719 01:23:12-!- mordocai [n=mordocai@66.119.9.243] has joined #wesnoth-dev 20090719 01:42:46-!- Zarel [i=Zarel@warzone2100/developer/Zarel] has joined #wesnoth-dev 20090719 01:50:33-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090719 01:51:26-!- gabm [n=gabm@220.148-ppp.3menatwork.com] has joined #wesnoth-dev 20090719 01:52:29-!- gabm [n=gabm@220.148-ppp.3menatwork.com] has left #wesnoth-dev [] 20090719 02:03:28-!- ardesh_ [n=ardesh@port-92-206-81-41.dynamic.qsc.de] has joined #wesnoth-dev 20090719 02:03:29-!- ardesh [n=ardesh@port-92-206-120-4.dynamic.qsc.de] has quit [Read error: 104 (Connection reset by peer)] 20090719 02:03:51-!- ardesh_ [n=ardesh@port-92-206-81-41.dynamic.qsc.de] has quit [Read error: 104 (Connection reset by peer)] 20090719 02:05:48-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090719 02:17:18< corn> what tools are used to compress PNG files? 20090719 02:18:05< corn> I currently have a full-sized PNG of a wesnoth map at 1962x2268 and 6.9 mb 20090719 02:18:17< corn> and I want to get the size down as much as possible without reducing resolution 20090719 02:18:28-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090719 02:50:01-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090719 02:52:51-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)] 20090719 02:53:06-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 03:00:21< AI0867> corn: optipng 20090719 03:00:30< AI0867> and some others 20090719 03:00:30< corn> AI0867: thanks 20090719 03:00:37< AI0867> see utils/wesnoth-optipng 20090719 03:00:48< corn> ok 20090719 03:00:52< AI0867> it's a script that combines the lot of them 20090719 03:04:40< corn> what file is it using to decide what to optimize 20090719 03:04:44< corn> or, where is it getting it 20090719 03:04:53< AI0867> current directory 20090719 03:05:05< corn> ok 20090719 03:05:05< AI0867> the script isn't too intelligent 20090719 03:05:14-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090719 03:07:31< corn> ugh 20090719 03:07:35< corn> I only got a 4 kb compression savings 20090719 03:07:40< corn> on a 7 mb file 20090719 03:07:59< corn> also 20090719 03:08:02< corn> is CIA broken again? 20090719 03:08:12< corn> I put in a commit 10 mins ago and it hasn't shown up 20090719 03:12:13-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 110 (Connection timed out)] 20090719 03:13:15< AI0867> CIA lags often 20090719 03:21:09< CIA-51> cornmander * r37016 /website/stats.wesnoth.org/ (4 files in 4 dirs): 20090719 03:21:09< CIA-51> Initial work on Wesnoth map overlay for google maps API, wrote a python script to take a map image emitted by wesnoth and split it into the 20090719 03:21:09< CIA-51> map tiles that the google maps api likes 20090719 03:51:37-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["brb"] 20090719 03:56:20-!- Sapient [n=sapien-x@adsl-219-194-121.asm.bellsouth.net] has joined #wesnoth-dev 20090719 03:59:48-!- happygrue [n=George@wesnoth/developer/wintermute] has joined #wesnoth-dev 20090719 03:59:57< Sapient> I see that game resources are being controlled by a singleton resource manager now 20090719 04:00:21< Sapient> this assumption does eliminate a lot of parameter passing 20090719 04:01:14< Sapient> hopefully it won't cause grief if someone decides to run functions on multiple virtual game instances simultaneously 20090719 04:01:41< Sapient> not that that would have worked anyways, due to assumptions elsewhere (such as the global variable repository) 20090719 04:04:37< Sapient> I am glad to see the constructor calls to terrain_filter have become a reasonable size again, though 20090719 04:05:24< Sapient> so thanks for that cleanup silene 20090719 04:06:50-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has joined #wesnoth-dev 20090719 04:15:55-!- Ivanovic_ [n=ivanovic@dtmd-4db22a43.pool.einsundeins.de] has joined #wesnoth-dev 20090719 04:32:10-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)] 20090719 04:33:53-!- Ivanovic_ is now known as Ivanovic 20090719 04:36:37-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["WRYYYYYYYYYYYYYYYYYYYY!"] 20090719 04:56:00-!- Sapient [n=sapien-x@wesnoth/developer/sapient] has quit [] 20090719 05:11:34< CIA-51> cornmander * r37017 /website/stats.wesnoth.org/ (map_tiler.py wesstats/templates/killview.html): 20090719 05:11:35< CIA-51> Added zoom level support to the map tiler and to the google map. Still need to create a tileserver on the web backend so that non-existent 20090719 05:11:35< CIA-51> tile locations can correctly be served up with black tiles 20090719 05:16:28-!- ABCD_ is now known as ABCD 20090719 05:17:57< corn> < Sapient> hopefully it won't cause grief if someone decides to run functions on multiple virtual game instances simultaneously 20090719 05:18:00< corn> woops 20090719 05:18:04< corn> putty pasting mistake 20090719 05:18:08< corn> http://cornmander.com/wesstats/killmaps 20090719 05:18:10< corn> check it out 20090719 05:18:19< corn> I think it's pretty cool ;) 20090719 05:18:27< corn> I still need to add a hex grid overlay and clickable tiles 20090719 05:37:29< grzywacz> corn, server error :P 20090719 05:37:52< grzywacz> ImportError: No module named tileserver 20090719 06:08:38-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Success] 20090719 06:08:53-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 06:09:14-!- wesbot changed the topic of #wesnoth-dev to: 1.7.2 planned for next Sunday (July 19th) | 66 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090719 06:15:33-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [] 20090719 06:30:32< corn> ah 20090719 06:30:38< corn> working on it at the moment 20090719 06:30:40< corn> sorry about that 20090719 06:33:25< corn> try again now 20090719 06:33:27< corn> if you're interested 20090719 06:37:51< corn> the map surrounding the wesnoth map is because I am using a map overlay 20090719 06:38:02< corn> and you need to substitute for every tile on the existing map 20090719 06:38:16< corn> and I don't have a tileserver up yet that will serve up black tiles for areas beyond the wesnoth map 20090719 06:46:23< corn> if it didn't work before, try now 20090719 06:46:28< corn> I had some firebug-specific JS calls there 20090719 06:46:37< corn> that would have made it invalid on a plain browser 20090719 06:54:07-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)] 20090719 06:54:28-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090719 07:13:30-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 07:20:44-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)] 20090719 07:27:53-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20090719 07:28:06< mordante> servus 20090719 07:35:11-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20090719 07:35:19< silene> hi 20090719 07:35:56< mordante> corn, the google-wesnoth-map looks rather cool, only maybe add a JS detection script, I got a blank page without warning before I allowed JS 20090719 07:36:01< mordante> hi silene 20090719 07:38:50< silene> is it expected that the real google map is displayed just behind the wesnoth map? 20090719 07:39:23< mordante> yes, you can see it when loading 20090719 07:41:05< silene> nevermind, i see the commit message explains it 20090719 07:42:09-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090719 08:04:01-!- Sirp [n=user@wesnoth/developer/dave] has quit ["leaving"] 20090719 08:49:31-!- stikonas [n=and@ctv-79-132-177-212.vinita.lt] has joined #wesnoth-dev 20090719 09:02:52< CIA-51> mordante * r37018 /trunk/src/gui/dialogs/lobby_main.cpp: Allow keypad enter to work as enter in lobby. 20090719 09:02:58< CIA-51> mordante * r37019 /trunk/data/gui/default/window/lobby_main.cfg: 20090719 09:02:58< CIA-51> Remove so dummy headers for the lobby listbox. 20090719 09:02:58< CIA-51> Ilor I'm not sure which header ids you use so left the rest of them, 20090719 09:02:58< CIA-51> please have a look yourself. 20090719 09:03:00< CIA-51> mordante * r37020 /trunk/data/gui/default/macros/_initial.cfg: 20090719 09:03:00< CIA-51> Fix widget order in GUI_FORCE_WIDGET_MINIMUM_SIZE. 20090719 09:03:02< CIA-51> With this fix the mouse focus is send to the containing widget instead 20090719 09:03:04< CIA-51> of the spacer. 20090719 09:03:08< CIA-51> mordante * r37021 /trunk/data/gui/default/window/lobby_main.cfg: (log message trimmed) 20090719 09:03:10< CIA-51> Minor lobby layout improvements. 20090719 09:03:12< CIA-51> Still not as wanted but there are some more issues which need to be 20090719 09:03:14< CIA-51> fixed first: 20090719 09:03:16< CIA-51> - listbox shouldn't need to call resize after adding items (this is 20090719 09:03:18< CIA-51> probably also the cause of the rather slow display updates of the 20090719 09:03:20< CIA-51> lobby.) 20090719 09:03:24< CIA-51> mordante * r37022 /trunk/ (changelog src/gui/widgets/minimap.cpp): Fix minimap no clipping in the new wiggets. 20090719 09:03:29< CIA-51> mordante * r37023 /trunk/changelog: Changelog update 20090719 09:03:31< CIA-51> mordante * r37024 /trunk/ (changelog players_changelog): Properly add dots in the changelogs. 20090719 09:14:10< mordante> I'm off, will be back this afternoon 20090719 09:16:46-!- maxy [n=maxy@80-219-1-128.dclient.hispeed.ch] has joined #wesnoth-dev 20090719 09:24:17< CIA-51> mordante * r37025 /trunk/ (changelog src/gui/widgets/generator.cpp): 20090719 09:24:17< CIA-51> Allow to make items in a listbox invisible. 20090719 09:24:17< CIA-51> This is used for the filtering of games to load, the initial problem was 20090719 09:24:17< CIA-51> discovered by YogiHH and I found more issues after some more testing. 20090719 09:24:17< CIA-51> But all should work fine now. 20090719 09:25:05-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"] 20090719 09:41:00-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20090719 09:48:48< CIA-51> silene * r37026 /trunk/src/ (game_events.cpp unit_display.cpp unit_display.hpp): Removed redundant parameters from wml_animation. 20090719 09:48:52< CIA-51> silene * r37027 /trunk/src/ (3 files): Removed redundant fields from attack predication display. 20090719 09:48:56< CIA-51> silene * r37028 /trunk/src/ (4 files): Removed redundant parameters from turn_info. 20090719 09:48:59< CIA-51> silene * r37029 /trunk/src/ (4 files): Removed useless class verification_manager. 20090719 09:49:03< CIA-51> silene * r37030 /trunk/src/ (game_events.cpp replay.cpp replay.hpp): Removed redundant parameters from do_replay_handle. 20090719 09:49:06< CIA-51> silene * r37031 /trunk/src/ (5 files): Removed redundant and useless parameters from do_replay. 20090719 09:49:10< CIA-51> silene * r37032 /trunk/src/ (unit.cpp unit.hpp): Replaced boolean state index by an enumeration. Fixed a memory leak. 20090719 09:49:12< CIA-51> silene * r37033 /trunk/src/replay.cpp: Removed redundant parameters from check_checksums. 20090719 09:55:47-!- loonybot [n=loonybot@79.139.138.33] has joined #wesnoth-dev 20090719 09:56:17< Ivanovic> moin 20090719 09:56:34-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090719 10:00:22-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090719 10:06:39-!- stikonas [n=and@ctv-79-132-177-212.vinita.lt] has joined #wesnoth-dev 20090719 10:38:03-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20090719 10:40:10-!- Kenpachi [n=chatzill@CPE-124-182-231-247.sa.bigpond.net.au] has joined #wesnoth-dev 20090719 10:40:26< CIA-51> silene * r37034 /trunk/src/ (6 files in 2 dirs): Removed unused field from attack_type. 20090719 10:47:14-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090719 10:50:36-!- dlr365 [n=doug@S010600248c02a7d3.cg.shawcable.net] has joined #wesnoth-dev 20090719 10:53:45-!- dlr365 [n=doug@S010600248c02a7d3.cg.shawcable.net] has quit [Client Quit] 20090719 10:54:01-!- dlr365 [n=doug@S010600248c02a7d3.cg.shawcable.net] has joined #wesnoth-dev 20090719 10:54:04-!- dlr365 [n=doug@S010600248c02a7d3.cg.shawcable.net] has left #wesnoth-dev ["oink I'm an ostrich!"] 20090719 10:57:46-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20090719 10:58:01< mordante> servus 20090719 10:58:46< Ivanovic> hi mordante 20090719 10:58:55< mordante> hi Ivanovic 20090719 10:59:05< Ivanovic> mordante: so the gui stuff is ready for 1.7.2 or do you plan on even more changes today? 20090719 10:59:25< mordante> I plan to do some more minor changes but not much 20090719 11:01:00< mordante> silene, will you be moving more things like video in resources as well? 20090719 11:01:17< Ivanovic> AI0867, cjhopman, corn, Crab_, dfranke, elias, esr, grzywacz, loonycyborg, mordante, Rhonda, shadowmaster, silene, Soliton, thespaceinvader, zookeeper, everyone i forgot: i plan to start releasing in about 8 hours 20090719 11:01:30< Ivanovic> make sure to commit anything you want to have in 1.7.2 till then 20090719 11:01:56< Ivanovic> if you got any blockers, please ping me 20090719 11:02:30< thespaceinvader> Ivanovic: thanks, i'll try to get the Dwarvish Scout portrait done by then, but not guaranteeing anything. Ditto the remaining Drake Clasher line stuff 20090719 11:02:41< silene> mordante: no, the resources namespace was intended to contain everything alive during a game, so video is already there (through screen); but we can extend it to things that have a longer lifespan, like video outside games 20090719 11:03:17-!- ancestral [n=ancestra@97-116-127-39.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090719 11:03:54< mordante> I'm mainly wondering whether you want to change things for the gui2 code as well 20090719 11:05:00< mordante> if the resources namespace starts to act like a singleton for a lot of things there's no need to pass them as paramters 20090719 11:05:12< silene> mordante: no, that was not my intent, since gui2 is alive outside of games 20090719 11:05:25< mordante> hence the question 20090719 11:05:37< mordante> but good to know 20090719 11:05:39-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev 20090719 11:06:00< silene> to clarify, i haven't added any new singleton, they already were there, just not used 20090719 11:07:10< silene> but anyway, if you want to add video to resources, do not hesitate, i think it makes, it is just outside of the scope of my current changes* 20090719 11:07:16< silene> +sense 20090719 11:07:43< mordante> maybe later, I've enough to do for the moment 20090719 11:08:46< Crab_> silene: also note that ai-related stuff should get references to game info from src/ai/game_info.hpp, even if it is also present in src/resources.hpp (like units). This is because later ai::game_info will be used to allow ai to play using only 'partial' information about the game (for example, to make it fog-aware) 20090719 11:09:43< silene> Crab_: i know, that's why i haven't removed the unit_map parameters; but everything else doesn't make sense with respect to partial information (what's a partial manager for tod???) 20090719 11:10:20< Crab_> silene: 'what will be the outcome of that combat if it is fought next turn ?' 20090719 11:10:38< silene> Crab_: do not mistake tod and tod_manager 20090719 11:12:29< Crab_> silene: I do not. but, as of now battle_context doesn't take tod/tod_manager as a parameter at all. so, later, it is possible that it will be added. 20090719 11:12:51< silene> Crab_: tod perhaps, but definitely not tod_manager 20090719 11:13:13< silene> you really seem to be confused about what tod_manager actually is 20090719 11:14:15-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [Read error: 131 (Connection reset by peer)] 20090719 11:15:07< Crab_> silene: AI uses tod manager as 'Information about what turn it is, and what time of day'.it is much more than that, yes. but ai uses tod_manager as 'turn+time_of_day' 20090719 11:17:21< Rhonda> Ivanovic: Thanks for the hilight. :) 20090719 11:26:28-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20090719 11:28:41-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev 20090719 11:34:05-!- silene [n=plouf@wesnoth/developer/silene] has quit [Nick collision from services.] 20090719 11:34:28-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20090719 11:35:01-!- ilor [i=ilor@wesnoth/developer/ilor] has joined #wesnoth-dev 20090719 11:37:49< ilor> I'm just in for a sec, here's a revised server rng patch (fixed one typo that resulted in AI hanging and one stupid mistake resulting in UB in player attacking): http://wesnoth.pastebin.com/m59aa37c5 20090719 11:38:35< ilor> there is a problem with unit advancement after combat, namely, insta-OOS with this patch, I will try to work something out today 20090719 11:39:37< Ivanovic> ilor: please don't forget that 1.7.2 is planned for today 20090719 11:39:43< ilor> mordante: will take a look at your changes now too, but I have limited internet access here 20090719 11:39:59< mordante> ilor, ok 20090719 11:40:24< ilor> Ivanovic: I'll post a note in the changelogs about new lobby, I guess better update release notes when it's more polished 20090719 11:40:46< Ivanovic> okay 20090719 11:41:26< ilor> I'll drop in for a sec and in ~2hrs, will resume normal idling in channel in the evening ;) 20090719 11:41:30< ilor> need to go now, seeya 20090719 11:41:36< Ivanovic> cu 20090719 11:41:40-!- ilor [i=ilor@wesnoth/developer/ilor] has quit [] 20090719 11:47:14-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Read error: 104 (Connection reset by peer)] 20090719 11:48:29-!- cib0 [n=cib@p5DC43990.dip.t-dialin.net] has joined #wesnoth-dev 20090719 11:50:09< CIA-51> silene * r37035 /trunk/src/actions.hpp: Removed unneeded dependency. 20090719 11:50:14< CIA-51> silene * r37036 /trunk/src/ (display.hpp game_display.cpp generate_report.cpp reports.hpp): Removed redundant parameters from generate_report. 20090719 11:50:22< CIA-51> silene * r37037 /trunk/src/ (5 files): Removed unneeded forward declarations. 20090719 12:02:59-!- Chusslove [n=Chusslov@brsg-d9beff91.pool.mediaWays.net] has joined #wesnoth-dev 20090719 12:03:55< Chusslove> trunk/data/core/units/drakes/Clasher.cfg:22, naked double quotes inside string, breaks extraction for translation. 20090719 12:04:21< Chusslove> ...in case anyone willing to fix :) 20090719 12:05:44< CIA-51> thespaceinvader * r37038 /trunk/ (7 files in 6 dirs): Add and wire Valkier's Skeleton portrait, update changelogs, portrait credits. Add Valkier to about.cfg. 20090719 12:06:20< CIA-51> silene * r37039 /trunk/src/ (chat_events.hpp rng.hpp shared_string.hpp tooltips.hpp): Fixed dependencies. 20090719 12:08:53< CIA-51> thespaceinvader * r37040 /trunk/data/core/ (4 files in 4 dirs): Add and wire LordBob's Cavalryman portrait, update portrait credits. 20090719 12:12:31< CIA-51> mordante * r37041 /trunk/data/gui/default/window/game_delete.cfg: 20090719 12:12:31< CIA-51> Minor improvement to the game delete dialog. 20090719 12:12:31< CIA-51> Added some borders and fixed a "horizontal_grow and horizontal_alignment 20090719 12:12:31< CIA-51> can't be combined, alignment is ignored" warning. 20090719 12:12:49< CIA-51> mordante * r37042 /trunk/data/gui/default/window/lobby_main.cfg: 20090719 12:12:49< CIA-51> Fix a wml error in the mp lobby. 20090719 12:12:49< CIA-51> Fixes the "horizontal_grow and horizontal_alignment can't be combined, 20090719 12:12:49< CIA-51> alignment is ignored." error. 20090719 12:13:24< mordante> silene, the errors at startup are gone again^ 20090719 12:13:31< CIA-51> silene * r37043 /trunk/data/core/units/drakes/Clasher.cfg: Fixed quotes in clasher description. 20090719 12:14:10< mordante> I'm off again, see you later 20090719 12:14:22< silene> Ivanovic: when you have a chance, please run a pot-update on wesnoth-units to fix the issue reported by Chusslove 20090719 12:14:39-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"] 20090719 12:21:49< Ivanovic> silene: i run one shortly before packaging anyway 20090719 12:21:52< Ivanovic> it will be fixed then 20090719 12:22:02< Ivanovic> Turuk_: you saw the commit by silene? 20090719 12:22:26< Ivanovic> Turuk_: please take care *not* to use normal double quotes in strings! (at least not without a \ in front of them) 20090719 12:29:43< silene> in fact, it's '""', not '\"' 20090719 12:30:39< Ivanovic> silene: uhm, the version you added is bad, too 20090719 12:31:16< silene> ? 20090719 12:31:38< Ivanovic> that is: it fixes *nothing* since the extrection does not see a _ in front of the 2nd part of the string 20090719 12:31:47< Ivanovic> so it is never extracted and will never be correctly used ingame 20090719 12:32:24< silene> Ivanovic: then it's the extraction that is broken; what i did is the only (!) way that exists for writing a double-quote in wml 20090719 12:32:25< Ivanovic> either make it \" (not sure if that works!), make it single quote (') or use french quotes (which i tend to prefer, you know, the good old »« combination) 20090719 12:32:56< Ivanovic> silene: what i want to say is regarding double quoting: just don't do it!!! 20090719 12:33:23< Ivanovic> authors should see double quotes as pure markup, nothing else 20090719 12:35:30< silene> nonetheless, this is a bug in wmlxgettext; any perl expert around here? 20090719 12:37:05< Ivanovic> silene: i don't think we got a perl expert around 20090719 12:37:21< Ivanovic> beside this i'd vote for completely removing support for double quotes inside strings 20090719 12:37:42< Ivanovic> (yes, the instance you just added is the *only* one in all of wesnoth mainline!) 20090719 12:39:16< Crab_> isn't wmlxgettext written in python, not perl ? 20090719 12:40:10-!- Zarel [i=Zarel@warzone2100/developer/Zarel] has quit [Read error: 110 (Connection timed out)] 20090719 12:40:11< Noyga> it is in perl actually iirc 20090719 12:40:19< Ivanovic> the original version is written in perl 20090719 12:40:26< Ivanovic> though esr started working on a replacement in python 20090719 12:42:03< Crab_> ok, thanks for clarifying 20090719 12:42:58< CIA-51> ivanovic * r37044 /trunk/data/core/units/drakes/Clasher.cfg: 20090719 12:42:58< CIA-51> replace double double quotes by single quotes in clash description 20090719 12:42:58< CIA-51> in general double quotes should be completely avoided in strings (not just 20090719 12:42:58< CIA-51> because the translation tools break i(string extraction via wmlxgettext) but 20090719 12:42:58< CIA-51> because they too easily break things (not sure how gettext will handle it *at 20090719 12:43:00< CIA-51> all*!)) 20090719 12:43:46< Ivanovic> silene: it might be that from an engine point of view "" would work to get double quotes in the english text, but how will gettext react? 20090719 12:43:54< Ivanovic> since all strings start with " and end with " 20090719 12:44:10< Ivanovic> " has too much of a special meaning... 20090719 12:44:44< silene> Ivanovic: gettext handles it correctly, the po file would contain \" 20090719 12:52:11< Chusslove> Gettext will indeed have no problems whatsoever, wmlxgettext ought to be fixed to know about self-escaping of double quotes. 20090719 12:53:40-!- giusef [n=giusef@unaffiliated/giusef] has quit [Remote closed the connection] 20090719 13:17:11-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 110 (Connection timed out)] 20090719 13:17:16< CIA-51> ivanovic * r37045 /branches/1.6/ (152 files in 6 dirs): 20090719 13:17:16< CIA-51> pot-update (new strings in wesnoth and wesnoth-low) 20090719 13:17:16< CIA-51> regenerated doc files 20090719 13:23:42-!- stikonas [n=and@ctv-79-132-177-212.vinita.lt] has joined #wesnoth-dev 20090719 13:27:37-!- EdB [n=edb@201.12.95-79.rev.gaoland.net] has joined #wesnoth-dev 20090719 13:29:10-!- Tigge [n=tigge@bacchus.olf.sgsnet.se] has quit [Read error: 145 (Connection timed out)] 20090719 13:34:30< CIA-51> ivanovic * r37046 /trunk/ (232 files in 23 dirs): 20090719 13:34:30< CIA-51> pot-update 20090719 13:34:30< CIA-51> regenerated doc files 20090719 13:46:46-!- Tigge [n=tigge@bacchus.olf.sgsnet.se] has joined #wesnoth-dev 20090719 13:58:10-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection] 20090719 14:02:26< CIA-51> silene * r37047 /trunk/utils/ (wmltrans.pm wmlxgettext): Fixed wmlxgettext so that it understands escaped quotes. 20090719 14:02:31< CIA-51> silene * r37048 /trunk/data/core/units/drakes/Clasher.cfg: Restored double quotes in clasher description. 20090719 14:02:43< CIA-51> silene * r37049 /trunk/po/wesnoth-units/ (49 files): update-pot 20090719 14:02:51-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20090719 14:04:41-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection] 20090719 14:05:42-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090719 14:09:10-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [Read error: 145 (Connection timed out)] 20090719 14:09:12< Chusslove> Ivanovic: Here's a patch for wmlxgettext to handle escaped double quotes http://caslav.gmxhome.de/misc/wmlxgettext-parse-escaped-double-quotes-01.diff 20090719 14:09:25< Ivanovic> Chusslove: uhm, silene just commited something 20090719 14:09:35< Chusslove> :) 20090719 14:09:37< Chusslove> Nuts. 20090719 14:11:17< Crab_> Chusslove: your patch is a bit different than silene's ) 20090719 14:12:20-!- stikonas [n=and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20090719 14:14:07-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 14:14:32< Chusslove> po2rawstring() should probably also get updated, even if nowhere used, for symmetry. 20090719 14:16:16< CIA-51> silene * r37050 /trunk/utils/wmltrans.pm: Removed unused function. 20090719 14:16:40< silene> Chusslove: let's just remove it 20090719 14:16:42< Chusslove> That's another way to look at it :) 20090719 14:21:23-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 110 (Connection timed out)] 20090719 14:24:24-!- Crab_ [i=crab@wesnoth/developer/crab] has left #wesnoth-dev [] 20090719 14:29:47< CIA-51> ivanovic * r37051 /trunk/po/ (24 files in 24 dirs): updated Lithuanian translation 20090719 14:29:59< CIA-51> ivanovic * r37052 /branches/1.6/ (26 files in 25 dirs): updated Lithuanian translation 20090719 14:32:54-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 104 (Connection reset by peer)] 20090719 14:33:52-!- yann [n=dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20090719 14:35:46-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev 20090719 14:50:39-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090719 14:55:36-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090719 15:04:03< CIA-51> thespaceinvader * r37053 /trunk/data/core/images/units/drakes/ (17 files): Minor update to a few Clasher frames, remove old Clasher frames. 20090719 15:05:28-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20090719 15:08:53< CIA-51> thespaceinvader * r37054 /trunk/data/core/ (37 files in 2 dirs): New Drake Gladiator base frame and animations, remove old Gladiator frames. 20090719 15:12:53-!- ilor [i=ilor@wesnoth/developer/ilor] has joined #wesnoth-dev 20090719 15:13:38< CIA-51> thespaceinvader * r37055 /trunk/ (39 files in 3 dirs): New Drake Enforcer base frame and animations, remove old Gladiator frames. Update changelogs. 20090719 15:15:11< thespaceinvader> oops, the 'gladiator' in that last commit should read 'enforcer' 20090719 15:16:37< ilor> status update: fixed the advancement OOS, seems to work, however I think there are preexisting issues with cases where a unit has enough exp to advance several times; this is not handled specially (but does not result in OOS, only I don't yet know why it sometimes advances units all the way and sometimes leaves them with N/M exp, (N>M) after an advancement 20090719 15:17:09< ilor> here is the diff that fixes advancement OOSes: http://wesnoth.pastebin.com/m56bb9599 20090719 15:18:20< ilor> I suspect these changes open up the possiblity of choosing what a unit shold advance into when it's not the unit owner's turn 20090719 15:22:23< ilor> off again... 20090719 15:22:26-!- ilor [i=ilor@wesnoth/developer/ilor] has quit [] 20090719 15:34:11-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20090719 15:34:26< mordante> servus 20090719 15:43:38< CIA-51> ilor * r37056 /trunk/changelog: newlobby changelog entry 20090719 15:43:43< CIA-51> ivanovic * r37057 /trunk/po/ (18 files in 9 dirs): updated Serbian translation 20090719 15:43:45< CIA-51> ivanovic * r37058 /branches/1.6/ (12 files in 6 dirs): updated Serbian translation 20090719 15:48:22< mordante> ilor regarding your patch http://wesnoth.pastebin.com/m59aa37c5 line 471 why didn't you add the "& 0x7fffffff" back there? 20090719 15:53:45< mordante> ilor I see no other oddities, but best ask somebody more familiar with the network protocol to have a second look 20090719 16:37:58-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev 20090719 16:39:35-!- Sirp [n=user@wesnoth/developer/dave] has joined #wesnoth-dev 20090719 16:57:06-!- Elvish_Pillager [n=eli@71.10.231.36] has joined #wesnoth-dev 20090719 17:06:46-!- Doppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has quit [Read error: 104 (Connection reset by peer)] 20090719 17:13:09-!- Doppp [n=aassdf@67.171.96.240] has joined #wesnoth-dev 20090719 17:13:49-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090719 17:14:55-!- stikonas_ [n=and@ctv-79-132-177-212.vinita.lt] has joined #wesnoth-dev 20090719 17:15:12-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 104 (Connection reset by peer)] 20090719 17:19:55-!- stikonas_ [n=and@ctv-79-132-177-212.vinita.lt] has quit [Remote closed the connection] 20090719 17:20:15-!- stikonas_ [n=and@ctv-79-132-177-212.vinita.lt] has joined #wesnoth-dev 20090719 17:23:12-!- stikonas_ is now known as stikonas 20090719 17:38:41< mordante> ilor can you have a look at https://gna.org/bugs/index.php?11726 20090719 17:38:45-!- EdB [n=edb@201.12.95-79.rev.gaoland.net] has quit [Remote closed the connection] 20090719 17:39:03< mordante> feel free to reassign it to yourself if you think it makes sense 20090719 17:46:46-!- loktor [n=quassel@AAubervilliers-151-1-18-119.w83-114.abo.wanadoo.fr] has joined #wesnoth-dev 20090719 17:50:38-!- Rodigas [n=Rodigas@p54B622F8.dip0.t-ipconnect.de] has joined #wesnoth-dev 20090719 17:53:19< Rodigas> hi, i have some problems with the map "dark forecast" 20090719 17:53:48< Rodigas> the enemie units sometimes have negative hp values 20090719 17:53:55< Rodigas> is this an error? 20090719 17:54:14< zookeeper> most likely 20090719 17:54:19< zookeeper> in what situation does that happen? 20090719 17:55:14< Rodigas> the ai units apear on the map with negative hp .. 20090719 17:59:15-!- Sirp [n=user@wesnoth/developer/dave] has quit [Read error: 113 (No route to host)] 20090719 18:04:29< silene> hmm... here, they are not negative, they are way too positive, strange... 20090719 18:05:37< zookeeper> i can try to take a quick look after i've committed these drake villages.. 20090719 18:07:43< Rodigas> silene: sometimes they also have e.g. 52 from 32 hp but i think this should be ok if there is a random thing of hp but i thing the negative values are not ok .. 20090719 18:08:48< silene> no, this may be on purpose, but this is definitely not ok; the ai (more precisely attack prediction), breaks when hp > max_hp, which is kind of dumb for a scenario that involves the ai 20090719 18:09:57< stikonas> Turuk: are you the maintainer of units.wesnoth.org? 20090719 18:10:51< mordante> YogiHH it might be my minimap fix of this morning also fixed you blitting issue on 16 bit, can you confirm? 20090719 18:14:01< CIA-51> zookeeper * r37059 /trunk/data/core/ (15 files in 2 dirs): Added Blarumyrran's drake villages (Rr^Vd). 20090719 18:14:36-!- loktor [n=quassel@AAubervilliers-151-1-18-119.w83-114.abo.wanadoo.fr] has quit [Read error: 104 (Connection reset by peer)] 20090719 18:16:28< CIA-51> zookeeper * r37060 /trunk/ (changelog players_changelog): Updated changelogs. 20090719 18:19:40< zookeeper> urgh, that dark forecast WML is as big a mess as before 20090719 18:20:32< zookeeper> the hitpoints bug must be coming from that ADJUST_AGGRESSION macro 20090719 18:22:09< zookeeper> why...does...it...not just...change the side..? 20090719 18:24:49< silene> yes, this is quite a strange piece of code 20090719 18:25:10< zookeeper> well, i've cleaned it up now 20090719 18:25:18< CIA-51> zookeeper * r37061 /trunk/data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Simplified an incredibly unnecessarily complicated bit of code. 20090719 18:29:30< Ivanovic> AI0867, cib0, cjhopman, corn, Crab_, Crab_, dfranke, elias, esr, grzywacz, loonycyborg, maxy, mordante, Noyga, silene, Soliton, stikonas, thespaceinvader, Turuk, zookeeper, everyone else who cares: ready for 1.7.2? 20090719 18:30:03< mordante> Ivanovic, I am 20090719 18:30:18< Rodigas> zookeeper: thanks .. 20090719 18:30:34< stikonas> Ivanovic: yes. Can you tell me who maintains wesnoth.org/units? I have a bug report. 20090719 18:30:35< silene> Ivanovic: yes 20090719 18:30:38< Rodigas> will it in the next stable release 20090719 18:30:40< zookeeper> Ivanovic, in a minute, i'll just put these villages on a couple of maps.. 20090719 18:30:44< CIA-51> silene * r37062 /trunk/src/ (7 files): Cleaned code a bit. 20090719 18:30:47< Ivanovic> sure 20090719 18:30:55< mordante> stikonas, IIRC Soliton 20090719 18:31:23< Ivanovic> the scripts are in mainline now IIRC 20090719 18:31:34< Ivanovic> and it *might* be that they were originally written by elias 20090719 18:31:49< Ivanovic> but yeah, probably Soliton does maintain them 20090719 18:32:05< CIA-51> zookeeper * r37063 /trunk/data/campaigns/The_Rise_Of_Wesnoth/maps/Peoples_in_Decline.map: Used the new drakes villages on Morogor. 20090719 18:32:08< Ivanovic> of course you can just post a bug report at bugs.wesnoth.org so that it is not forgotten 20090719 18:32:09< stikonas> I'll came back in 30 minutes and maybe look then 20090719 18:32:15< zookeeper> ...1 map, to be precise 20090719 18:34:02< silene> zookeeper: i was still wondering what could have gone wrong with the old code; it was the "random_traits=yes" part... 20090719 18:35:15< zookeeper> silene, once the unnecessary complexity reaches heights like that, i usually don't even want to try to figure it out :x 20090719 18:35:32< Soliton> stikonas: what's wrong? 20090719 18:41:21< CIA-51> zookeeper * r37064 /trunk/data/campaigns/Eastern_Invasion/scenarios/13.Evacuation.cfg: Made 'Evacuation' a little bit easier by dropping the enemy gold and income slightly. 20090719 18:41:54-!- Crab_ [i=crab@wesnoth/developer/crab] has quit [Read error: 110 (Connection timed out)] 20090719 18:42:03< zookeeper> ok, i think i'm done unless i broke something and didn't notice. 20090719 18:45:04< Ivanovic> okay, will test if the game compiles, installs and if all campaigns start 20090719 18:46:46-!- Zarel [i=Zarel@warzone2100/developer/Zarel] has joined #wesnoth-dev 20090719 18:50:50< loonycyborg> Did someone recently remove #include from src/generate_report.cpp? 20090719 18:51:05-!- ABCD_ [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090719 18:51:10-!- ABCD [n=ABCD@wikipedia/ABCD] has quit [Read error: 104 (Connection reset by peer)] 20090719 18:51:35< loonycyborg> I'm getting a compile error without it when cross-compiling with ming-gcc 4.3.2 and I vaguely remember getting similar problem before. 20090719 18:52:39< Ivanovic> okay, things seem to work fine over here 20090719 18:52:46< Ivanovic> will now run stuff like the final pot update and such 20090719 18:53:27< Ivanovic> though first i'll run utils/wesnoth-optipng after the huge amount of new images added... 20090719 18:54:03-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["KVIrc 3.4.2 Shiny http://www.kvirc.net/"] 20090719 18:54:36-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090719 18:54:48< mordocai> Not sure if anyone will want to use this, https://gna.org/patch/index.php?1196. It fixes those deprecation warnings from the 1.6 branch Sconstruct file... 20090719 18:54:55< mordocai> Was annoying me... lol 20090719 18:55:49-!- Polarina1 [n=polarina@85-220-18-216.dsl.dynamic.simnet.is] has joined #wesnoth-dev 20090719 18:56:13< Soliton> i've asked about that before but i forgot what the issue was with fixing it. 20090719 18:56:32< mordocai> Well, it doesn't appear to have broken anything on my build... 20090719 18:56:37< Ivanovic> probably the min version of scons required would have to be upped 20090719 18:56:49< Ivanovic> (which was decided only to do on trunk) 20090719 18:57:01< mordocai> Ah, yeah... probably. Well, i fixed it on my build at least. 20090719 18:57:08< Ivanovic> though loonycyborg should know the reason for sure since he maintains this recipe 20090719 18:58:59-!- Polarina1 [n=polarina@85-220-18-216.dsl.dynamic.simnet.is] has quit [Client Quit] 20090719 19:00:09-!- Polarina1 [n=polarina@cl-577.lon-02.gb.sixxs.net] has joined #wesnoth-dev 20090719 19:00:26-!- Polarina [n=polarina@wesnoth/translator/Polarina] has quit [Nick collision from services.] 20090719 19:00:31-!- Polarina1 [n=polarina@cl-577.lon-02.gb.sixxs.net] has quit [Client Quit] 20090719 19:01:38-!- Polarina [n=polarina@wesnoth/translator/Polarina] has joined #wesnoth-dev 20090719 19:07:11-!- kitty_ [n=kitty@wesnoth/artist/kitty] has joined #wesnoth-dev 20090719 19:07:19< thespaceinvader> Ivanovic: do i have time to sneak a portrait in before 1.7.2? 20090719 19:07:46< thespaceinvader> hey kitty_ 20090719 19:08:01< kitty_> hey! 20090719 19:08:22< kitty_> and i'm keeping my fingers crossed that you'll still get your scoout in ;) 20090719 19:08:42< thespaceinvader> yeah 20090719 19:08:43< Ivanovic> sure 20090719 19:08:56< thespaceinvader> my next challenge, getting that foliage sorted on the wose 20090719 19:08:59-!- Rodigas [n=Rodigas@p54B622F8.dip0.t-ipconnect.de] has left #wesnoth-dev [] 20090719 19:09:14< kitty_> that'll be a hard one! 20090719 19:11:22< stikonas> Soliton: units.wesnoth.org use fuzzy strings in *.po files to generate unit summary 20090719 19:12:29< stikonas> for example http://www.wesnoth.org/units/trunk/lt_LT/Dwarvish%20Scout.html shows as Elvish Scout 20090719 19:13:23< CIA-51> thespaceinvader * r37065 /trunk/ (7 files in 5 dirs): Add and wire new Dwarf Scout portrait, update changelogs, portrait credits. 20090719 19:13:29< thespaceinvader> kitty_: yeah, it will 20090719 19:14:02< thespaceinvader> the other one is the Gryphon Rider, I want to finally replace the gryphon 20090719 19:14:19< thespaceinvader> Ivanovic: that's my commit list cleared =) 20090719 19:14:33< silene> Ivanovic: i have noticed a bug (no "enemy spotted!" anymore, which could also be considered a feature), do i have some time to try to fix it? 20090719 19:16:06-!- loonybot [n=loonybot@79.139.138.33] has joined #wesnoth-dev 20090719 19:16:42-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090719 19:17:29< loonycyborg> Ivanovic: Don't release untill I add missing #include . It seems to be required on mingw 4.3 20090719 19:17:47< Ivanovic> silene: sure, fix it 20090719 19:18:45< CIA-51> loonycyborg * r37066 /trunk/src/generate_report.cpp: Fix compilation on mingw 4.3 20090719 19:19:44-!- Kenpachi [n=chatzill@CPE-124-182-231-247.sa.bigpond.net.au] has quit ["ChatZilla 0.9.85 [Firefox 3.0.11/2009060215]"] 20090719 19:20:28< mordocai> loonycyborg: Ivanovic said i should talk to you about this? https://gna.org/patch/?1196 (I didn't put it on there, but it's about the options class being deprecated). He suggested we didn't want to put it in stable because it would make a later scons version a requirement, but also said he wasn't sure, and that i should ask you. So, after the background info: Could this be added to stable? 20090719 19:21:24< CIA-51> silene * r37067 /trunk/src/actions.cpp: Fixed incorrect code simplification: enemies were no longer sighted. 20090719 19:21:27< silene> Ivanovic: done 20090719 19:22:10< silene> loonycyborg: what about instead? (just in case it works) 20090719 19:22:28< loonycyborg> mordocai: Ivanovic is correct. 20090719 19:23:00< loonycyborg> Adding it to stable would require scons version requirement bump. 20090719 19:23:59< mordocai> loonycyborg: Okay, just making sure. Thanks. I'll just leave it on my build then :). 20090719 19:24:45< loonycyborg> silene: Shouldn't all cfoo headers put all functions in namespace std? 20090719 19:25:41< loonycyborg> src/generate_report.cpp uses them without std qualification. 20090719 19:25:56< loonycyborg> So using time.h would make more sense IMO :P 20090719 19:26:52-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090719 19:27:43< silene> loonycyborg: they should, but there is some leeway; anyway, that's precisely the reason i'm asking if it works, because if it does, that's less unneeded functions polluting the global namespace 20090719 19:28:52< loonycyborg> In this case the sourcefile refers to the global functions so in order for it to work it already must be polluted. 20090719 19:30:20< loonycyborg> Anyway, changing to doesn't break anything. 20090719 19:30:35< silene> good, then let's switch to ctime 20090719 19:30:55< loonycyborg> Maybe you should also add std qualification :P 20090719 19:32:22< silene> can you test if it works with the qualification? if it does, i will add it too; but anyway, going from time.h to ctime means 10 macros are removed 20090719 19:33:34-!- loktor [n=quassel@AAubervilliers-151-1-18-119.w83-114.abo.wanadoo.fr] has joined #wesnoth-dev 20090719 19:35:03< loonycyborg> Adding std:: to those three *time functions doesn't seem to break anything either. 20090719 19:35:21< loonycyborg> *function calls 20090719 19:36:04< silene> thanks 20090719 19:36:48< CIA-51> silene * r37068 /trunk/src/generate_report.cpp: Switched to C++-style header. 20090719 19:37:03-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090719 19:40:37-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit [Read error: 110 (Connection timed out)] 20090719 19:40:46-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev 20090719 19:41:01 * mordocai throughly enjoyed trunk/misc/fortunes/wesnoth 20090719 19:50:14-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090719 19:52:35< loonycyborg> mordocai: Be sure to use the output of svn diff instead of entire files when contributing to FOSS projects ;) 20090719 19:54:57< mordocai> loonycyborg: I did :) 20090719 19:55:53< mordocai> loonycyborg: Uploaded the wrong thing lol 20090719 19:57:13< mordocai> loonycyborg: i was going to fix it, but since it wasn't going to be used anyways... i didn't worry too much about it. 20090719 19:57:52< loonycyborg> k 20090719 20:01:37-!- BenUrban_ [n=benurban@68.55.19.224] has joined #wesnoth-dev 20090719 20:02:19-!- kitty___ [n=kitty@e180196237.adsl.alicedsl.de] has joined #wesnoth-dev 20090719 20:03:39-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)] 20090719 20:03:54-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 20:04:33-!- BenUrban [n=benurban@unaffiliated/benurban] has quit [Nick collision from services.] 20090719 20:04:38-!- BenUrban_ is now known as BenUrban 20090719 20:09:02-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090719 20:10:13-!- EdB [n=edb@79.95.12.201] has joined #wesnoth-dev 20090719 20:14:01-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090719 20:17:13-!- kitty_ [n=kitty@wesnoth/artist/kitty] has quit [Read error: 110 (Connection timed out)] 20090719 20:22:32-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit [] 20090719 20:23:01< mordante> zookeeper, FYI testing a new wiki update script to the gui pages are updated often 20090719 20:24:53< zookeeper> mordante, ok, so it seems 20090719 20:25:55< mordante> somehow it seems you always need preprocessor macros... 20090719 20:28:21-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090719 20:28:54< Rhonda> Ivanovic: Don't wait for my mentioned tsg update, got distracted and won't be able to finish ... 20090719 20:43:47-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090719 20:45:34< CIA-51> mordante * r37069 /trunk/src/gui/auxiliary/ (canvas.cpp window_builder.cpp): WIKI Moved more variable info to the canvas. 20090719 20:45:42< CIA-51> mordante * r37070 /trunk/ (changelog utils/wiki_grabber.py): 20090719 20:45:42< CIA-51> Add preprocessor macros to the wiki grabber. 20090719 20:45:42< CIA-51> This allows to copy information about widgets at three places without 20090719 20:45:42< CIA-51> copy pasting and it's bugs. The three places are: 20090719 20:45:42< CIA-51> - In the widget overview list 20090719 20:45:42< CIA-51> - In the widget definition info 20090719 20:45:44< CIA-51> - In the widget instanciate info 20090719 20:45:48< CIA-51> mordante * r37071 /trunk/src/gui/ (auxiliary/window_builder/minimap.cpp widgets/settings.cpp): WIKI Convert the minimap info to use macros. 20090719 20:53:20< Ivanovic> okay, is everybody ready for 1.7.2 now? 20090719 20:54:16< ilor> yep 20090719 20:54:26< mordante> yup was already ready before, these last commits didn't need to be in 1.7.2 20090719 20:55:52< thespaceinvader> Ivanovic: yep, all ready here 20090719 20:56:16< silene> yes 20090719 20:56:30< loonycyborg> Ivanovic: yep 20090719 20:57:17< Ivanovic> but they will be 20090719 20:57:19< Ivanovic> ;) 20090719 20:57:39< Ivanovic> uploading the result of wesnoth-optipng now 20090719 20:57:41< CIA-51> ivanovic * r37072 /trunk/data/ (149 files in 17 dirs): 20090719 20:57:41< CIA-51> ran wesnoth-optipng: 20090719 20:57:41< CIA-51> Overall statistics (only for files with a smaller recompressed size): 20090719 20:57:41< CIA-51> Original size: 3288 KiB on 149 files 20090719 20:57:41< CIA-51> Optimized size: 2992 KiB 20090719 20:57:41< CIA-51> Total saving: 296 KiB = 9% decrease 20090719 20:58:17< Ivanovic> running the preparing pot-update now, bumping the version afterwards and releasing then 20090719 20:58:37-!- Ivanovic changed the topic of #wesnoth-dev to: currently releasing 1.7.2 | 66 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090719 20:59:14< mordante> Ivanovic, will you hate me when I commit more stuff now? 20090719 20:59:25< Ivanovic> depends on the stuff 20090719 20:59:43< Ivanovic> so far the version bump itself is not commited, so atm you can still commit 20090719 21:00:16< mordante> well it's not really important to commit, so if you prefer waiting, I'll wait 20090719 21:00:50< Ivanovic> get it commited, but do so in the next mins 20090719 21:02:23-!- EdB [n=edb@79.95.12.201] has quit [Remote closed the connection] 20090719 21:02:59< mordante> ok commit is running 20090719 21:03:10< CIA-51> mordante * r37073 /trunk/src/actions.cpp: Fix indent after r37067. 20090719 21:04:08< mordante> ilor, how are things going? 20090719 21:04:57< ilor> mordante: as I wrote managed to fix the advancement OOS, been testing this somewhat and seems to work, haven't had time to look at other stuff 20090719 21:05:04< CIA-51> ivanovic * r37074 /trunk/po/ (216 files in 24 dirs): pot-update (preparing for 1.7.2) 20090719 21:05:48< ilor> mordante: I guess I'll have a go at making the new lobby userlist working after I commit the server rng 20090719 21:06:14< ilor> tomorrow might be damage control for that server rng :P 20090719 21:06:21< mordante> :-) 20090719 21:06:30-!- Ivanovic changed the topic of #wesnoth-dev to: currently releasing 1.7.2, using r37075 | 66 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090719 21:06:31< CIA-51> ivanovic * r37075 /trunk/ (changelog configure.ac players_changelog src/wesconfig.h): bump version to 1.7.2 20090719 21:06:42< Ivanovic> *doood* time out, releasing now 20090719 21:07:19< mordante> ilor, ok good, you read my messages for you in the log? 20090719 21:07:46< ilor> mordante: ah yest about the 0x7fff it's a) an omission b) very likely not needed anyway 20090719 21:08:13< mordante> ok, but I was more hinting at my lobby commits 20090719 21:08:26< ilor> as for the icons patch I'll see how they look not sure about the quality 20090719 21:08:49-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090719 21:08:51< ilor> as for lobby commits I take it you know what's missing so I'm happy to see things are going the right way 20090719 21:09:27< mordante> if the quality isn't good enough please inform the poster on the forum so s/he can improve (that is if you think the idea really has merit) 20090719 21:09:44-!- Aethaeryn is now known as MikeJB 20090719 21:10:16< mordante> yup I know what's missing for the lobby, only not sure when I'll be able to fix it 20090719 21:10:28-!- Doppp [n=aassdf@67.171.96.240] has quit [Read error: 104 (Connection reset by peer)] 20090719 21:10:46< ilor> mordante: the idea generally has merit and I was planning to do something along these lines, so I'll likely use them even if they look bad, as placeholders that I won't have to do :P 20090719 21:10:59< ilor> mordante: I'm hoping before 1.8 20090719 21:15:01< mordante> good to hear you planned something like it, btw Jetrel likes the icons ;-) http://www.wesnoth.org/forum/viewtopic.php?f=12&t=21174&p=296265&hilit=lobby#p296265 20090719 21:15:31< mordante> yes I want to have it done before 1.8, it must be done before it 20090719 21:15:46-!- Sirp [n=user@wesnoth/developer/dave] has joined #wesnoth-dev 20090719 21:16:11-!- giusef [n=giusef@unaffiliated/giusef] has quit [Remote closed the connection] 20090719 21:20:13-!- Doppp [n=aassdf@c-67-171-96-240.hsd1.pa.comcast.net] has joined #wesnoth-dev 20090719 21:20:57< Ivanovic> only 40 mins and the upload to wesnoth.org should be done... 20090719 21:21:06< mordante> :-) 20090719 21:21:10< Ivanovic> how i love the tiny filesize for the tarball, only 240MB... 20090719 21:22:09< mordante> that's 10MB more as the last release 20090719 21:22:29< mordante> seems our artists are doing a nice job :-) 20090719 21:22:49< loonycyborg> Ivanovic: How did you figure how to reach the appropriate pages on sourceforge in order to create a release? :) 20090719 21:23:25< loonycyborg> Last time I had to go through release notes to get there but perhaps there's the 'right' way? 20090719 21:23:59< Ivanovic> ah, via the admin interface there was a was to create a release 20090719 21:24:16< Ivanovic> mordante: ups, only 233MB 20090719 21:24:27< Ivanovic> still a hefty upload for my small bandwidth (in upstream) 20090719 21:25:21< loonycyborg> Probably that particular admin interface link is missing at my access level :/ 20090719 21:25:44< mordante> true, upstream is small most of the time and 233MB isn't small at all 20090719 21:27:49-!- gabm [n=gabm@72.0.201.134] has joined #wesnoth-dev 20090719 21:29:08< mordante> I'm off bye 20090719 21:29:43< ilor> bye mordante 20090719 21:29:49-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"] 20090719 21:30:50< Ivanovic> hmm, okay, when i was releasing the last version the interface was not this new... 20090719 21:31:36< Ivanovic> oaky, found it 20090719 21:31:49< Ivanovic> after going to "Develop" a link named "Project Admin" appeared 20090719 21:31:54< Ivanovic> there i select "downloads" 20090719 21:36:47< loonycyborg> There's no such link for me in https://sourceforge.net/projects/wesnoth/develop 20090719 21:37:56< Ivanovic> for me it is in the top bar: 20090719 21:38:00< Ivanovic> * Summary 20090719 21:38:01< Ivanovic> * Files 20090719 21:38:03< Ivanovic> * Support 20090719 21:38:04< Ivanovic> * Develop 20090719 21:38:06< Ivanovic> o Web Site 20090719 21:38:07< Ivanovic> o Screenshots 20090719 21:38:09< Ivanovic> o News 20090719 21:38:10< Ivanovic> o Statistics 20090719 21:38:13< Ivanovic> * Hosted Apps 20090719 21:38:15< Ivanovic> * Tracker 20090719 21:38:17< Ivanovic> o Statistics 20090719 21:38:19< Ivanovic> o Reporting 20090719 21:38:21< Ivanovic> o Search 20090719 21:38:23< Ivanovic> * Mailing Lists 20090719 21:38:25< Ivanovic> o Search 20090719 21:38:27< Ivanovic> * Forums 20090719 21:38:29< Ivanovic> o Developers 20090719 21:38:31< Ivanovic> o Help 20090719 21:38:33< Ivanovic> o Open Discussion 20090719 21:38:35< Ivanovic> o Statistics 20090719 21:38:39< Ivanovic> o Search 20090719 21:38:41< Ivanovic> * Code 20090719 21:38:43< Ivanovic> o Git 20090719 21:38:45< Ivanovic> o Git Browse 20090719 21:38:47< Ivanovic> o Git Statistics 20090719 21:38:49< Ivanovic> o Mercurial 20090719 21:38:49-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090719 21:38:53< Ivanovic> o Mercurial Browse 20090719 21:38:55< Ivanovic> o Mercurial Statistics 20090719 21:38:57< Ivanovic> o Bazaar 20090719 21:38:59< Ivanovic> o Bazaar Browse 20090719 21:39:01< Ivanovic> o Bazaar Statistics 20090719 21:39:05< Ivanovic> o CVS 20090719 21:39:07< Ivanovic> o CVS Browse 20090719 21:39:09< Ivanovic> o CVS Statistics 20090719 21:39:11< Ivanovic> o SVN 20090719 21:39:13< Ivanovic> o SVN Browse 20090719 21:39:15< Ivanovic> o SVN Statistics 20090719 21:39:17< Ivanovic> * Documentation 20090719 21:39:19< Ivanovic> o Browse 20090719 21:39:21< Ivanovic> o Submit 20090719 21:39:23< Ivanovic> o Search 20090719 21:39:25< Ivanovic> * Tasks 20090719 21:39:27< Ivanovic> o Reporting 20090719 21:39:29< Ivanovic> * Wiki 20090719 21:39:31< Ivanovic> o Wiki Home 20090719 21:39:33< Ivanovic> o Create Page 20090719 21:39:35< Ivanovic> o List Pages 20090719 21:39:37< Ivanovic> o Recent Changes 20090719 21:39:39< Ivanovic> o List and Upload Files 20090719 21:39:41< Ivanovic> o Manage Templates 20090719 21:39:43< Ivanovic> o Statistics 20090719 21:39:45< Ivanovic> * Project Admin 20090719 21:39:47< Ivanovic> o Membership 20090719 21:39:49< Ivanovic> o Feature Settings 20090719 21:39:51< Ivanovic> o Project Settings 20090719 21:39:55< Ivanovic> o Downloads 20090719 21:39:57< Ivanovic> o Analytics 20090719 21:39:59< Ivanovic> ARGH, sorry 20090719 21:40:03< Ivanovic> loonycyborg: can you reach this page? https://sourceforge.net/project/admin/editpackages.php?group_id=89495 20090719 21:40:31< loonycyborg> Yes. 20090719 21:40:46< Ivanovic> then bookmark it and use it in the future 20090719 21:41:27< ilor> Ivanovic: file a FR for accidental paste protection in your IRC client ;) 20090719 21:42:02< Ivanovic> ilor: i wanted to paste but i have not assumed that it would be this much, i assumed it would be a single line... 20090719 21:42:43< ilor> some clients show you how many lines it is ;) 20090719 21:44:44< loonycyborg> http://imagebin.org/56431 <- That's what I see. No links to Admin and other items you mentioned. 20090719 21:45:12< loonycyborg> Though I indeed remember these items being there before the upgrade. 20090719 21:46:37< Ivanovic> loonycyborg: in the line with "summary, files, support, develop" i got to click on "develop" to get the admin link shown 20090719 21:46:49< Ivanovic> in "Normal" mode i don't have it either 20090719 21:52:28< CIA-51> ivanovic * r37076 /tags/1.7.2/: tagged 1.7.2, using r37075 20090719 21:53:15< loonycyborg> Then they probably haven't updated the interface to show the link on my access level yet. It does show the admin link on other project where I'm full admin :P 20090719 21:53:55-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["KVIrc 3.4.2 Shiny http://www.kvirc.net/"] 20090719 21:53:58< Ivanovic> fill a sf.net bugreport somewhere 20090719 21:54:21-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090719 21:54:28-!- Elvish_Pillager [n=eli@71.10.231.36] has quit [Read error: 110 (Connection timed out)] 20090719 21:54:54< CIA-51> ivanovic * r37077 /trunk/ (changelog configure.ac players_changelog src/wesconfig.h): post release version bump to 1.7.2+svn 20090719 21:55:21-!- Ivanovic changed the topic of #wesnoth-dev to: released 1.7.2, announcing "soon" | 66 bugs, 240 feature requests, 14 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090719 21:55:32-!- BenUrban_ [n=benurban@unaffiliated/benurban] has joined #wesnoth-dev 20090719 21:55:41< Ivanovic> (yes, sf.net is not done yet, but i hope it will be done "soon") 20090719 21:57:44-!- BenUrban [n=benurban@unaffiliated/benurban] has quit [Nick collision from services.] 20090719 21:57:46-!- BenUrban_ is now known as BenUrban 20090719 22:01:50< silene> mordante: what kind of crap commit was 37073? the code is still not properly indented ;-) 20090719 22:05:37-!- happygrue [n=George@wesnoth/developer/wintermute] has quit [Read error: 104 (Connection reset by peer)] 20090719 22:09:26-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection reset by peer] 20090719 22:09:40-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090719 22:13:10< crimson_penguin> anyone know if there were more types of messages added for the desktop notifications? 20090719 22:17:28-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev 20090719 22:26:15< silene> crimson_penguin: there weren't 20090719 22:28:06-!- gabm [n=gabm@72.0.201.134] has quit [Read error: 104 (Connection reset by peer)] 20090719 22:28:37-!- allefant [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090719 22:29:14-!- loonybot [n=loonybot@79.139.138.33] has joined #wesnoth-dev 20090719 22:29:44-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090719 22:30:05-!- loktor [n=quassel@AAubervilliers-151-1-18-119.w83-114.abo.wanadoo.fr] has quit [Remote closed the connection] 20090719 22:30:58-!- loonycyborg [n=sergey@79.139.138.33] has joined #wesnoth-dev 20090719 22:38:33< crimson_penguin> silene: thanks 20090719 22:44:37-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)] 20090719 22:45:32< Rhonda> downloading 1.7.2 20090719 22:46:41< corn> mordante: ok, will do 20090719 22:47:00< ilor> corn: fyi, --screnshot works on windows :) 20090719 22:47:19< corn> cool 20090719 22:47:22< corn> thanks for testing :) 20090719 22:47:41< corn> who coded in the --multiplayer + --nogui combination? 20090719 22:48:00< corn> it can probably be rewritten slightly to work the same way as --screenshot 20090719 22:48:06< corn> without creating a fake framebuffer instead 20090719 22:48:24-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit [] 20090719 22:51:16-!- Sapient [n=sapien-x@wesnoth/developer/sapient] has joined #wesnoth-dev 20090719 22:55:39-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Read error: 104 (Connection reset by peer)] 20090719 22:56:14< ilor> corn: git/svn blame might tell you ;) 20090719 22:59:19 * crimson_penguin uploads 1.7.2 20090719 23:00:02< Sapient> ah, I see I'm too late to get my features in :( 20090719 23:00:16-!- noy [n=Noy@wesnoth/developer/noy] has quit [] 20090719 23:01:10< Sapient> I'm planning [store_unit_type] for WML 20090719 23:02:13< Sapient> it would be nice if unit.type could auto-store the unit's type info as well 20090719 23:02:24< Sapient> zookeeper: agreed? 20090719 23:02:48< Blueblaze> Sapient: [store_unit_type] does what over [store_unit]? Just a quicker way of doing the same thing? 20090719 23:03:09< zookeeper> Sapient, maybe 20090719 23:03:30< CIA-51> ilor * r37078 /trunk/src/server/game.cpp: server RNG - server part. inject a random seed into all [attack]s and also send it back to the attacking client 20090719 23:03:48< Sapient> Blueblaze: the unit type information is different from the unit information 20090719 23:03:53< Blueblaze> oh 20090719 23:03:55< Blueblaze> unit_type 20090719 23:03:57< Blueblaze> Got it 20090719 23:04:22< Sapient> so I could filter on all unit_types regardless of what's on the map 20090719 23:05:56< Blueblaze> Sapient: Is there a way currently to store a side's faction (since not all factions have unique leader sets) 20090719 23:06:23< zookeeper> look in leader 20090719 23:06:29< zookeeper> not: look at leader 20090719 23:06:38< Sapient> faction info is not stored anywhere 20090719 23:06:57< zookeeper> (except in the leader) 20090719 23:07:03< Sapient> where in leader? 20090719 23:07:11< zookeeper> i don't remember 20090719 23:07:13< zookeeper> faction=? 20090719 23:07:24< Sapient> ah, ok I didn't realize that 20090719 23:07:54< Sapient> Blueblaze: isn't it enough to store the side's recruit list? 20090719 23:07:59< zookeeper> probably not intentional originally, but it's been like that as long as i remember 20090719 23:08:12-!- Noyga [n=lame-z@wesnoth/developer/noyga] has left #wesnoth-dev ["Quitte"] 20090719 23:08:23< zookeeper> all the faction WML as well as the side WML is stored in the leader 20090719 23:08:38< Sapient> fascinating 20090719 23:09:20< Sapient> for what it's worth, you could also determine faction based on the recruit list 20090719 23:09:23< CIA-51> ilor * r37079 /trunk/src/ai/ (manager.cpp manager.hpp): add a sync network event to ai manager 20090719 23:09:36< zookeeper> yep 20090719 23:09:44< CIA-51> ilor * r37080 /trunk/src/ (12 files in 2 dirs): (log message trimmed) 20090719 23:09:44< CIA-51> Server side RNG, client part draft. 20090719 23:09:44< CIA-51> There are two different approaches here: 20090719 23:09:44< CIA-51> - in the AI code, the attack is queued, sent to the server and then the attacking code waits for a new random seed o arrive, polling UI events and syncing network in a loop. 20090719 23:09:45< CIA-51> - in the player code, the actual attak procedure is delayed until after a new 20090719 23:09:47< CIA-51> seed arrives by means of a callback that is called when a seed message is 20090719 23:09:49< CIA-51> received. This is potentially problematic as, for example, commands need to be 20090719 23:10:04< Sapient> if you think about it, recruit list is the only thing that is affected by the faction choice, other than available leaders 20090719 23:10:05< CIA-51> ilor * r37081 /trunk/src/ (mouse_events.cpp mouse_events.hpp random.cpp): fix newrng ai hang and player attack UB 20090719 23:10:23< CIA-51> ilor * r37082 /trunk/src/game_end_exceptions.hpp: make THROW_END_LEVEL_DELETE zero the exception pointer after copying the contents and deleting it 20090719 23:10:40< Sapient> so if you know the recruit list and the leader, you have defined a 'faction' 20090719 23:10:40< CIA-51> ilor * r37083 /trunk/src/ (playturn.cpp playturn.hpp replay.cpp replay.hpp): serverside RNG - fix the guaranteed OOS on unit advancement after combat 20090719 23:10:58< CIA-51> ilor * r37084 /trunk/src/ (4 files in 2 dirs): simplyfy --screenshot code a bit and kill a msvc warning 20090719 23:11:08< Sapient> the only thing missing is the faction name 20090719 23:11:16< CIA-51> ilor * r37085 /trunk/src/replay.cpp: fix a typo 20090719 23:11:47< Sapient> and... faction flag I suppose 20090719 23:12:30 * ilor kindly asks for the trunk server to be rebuilt with r37078 20090719 23:15:03< Chusslove> stikonas: There? 20090719 23:16:44< crimson_penguin> so, why does the 1.7.1 server let me connect with 1.7.2 already? 20090719 23:16:59< crimson_penguin> surely they're not compatible? 20090719 23:17:26< ilor> crimson_penguin: trunk server is supposed to be permissive anyway 20090719 23:17:44< silene> and they are probably compatible 20090719 23:18:04< crimson_penguin> hmm, ok 20090719 23:18:18< crimson_penguin> I thought there was a different one for trunk, and releases from trunk though 20090719 23:18:40< ilor> fyi, the server changes in r37078 don't affect compatibility with earlier clients, but clients with the srng changes need the updated server 20090719 23:19:58< stikonas> Chusslove: yes 20090719 23:20:24-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [] 20090719 23:21:01< stikonas> Chusslove: did I do something wrong again :( 20090719 23:24:29-!- YogiHH [n=chatzill@c187240.adsl.hansenet.de] has joined #wesnoth-dev 20090719 23:24:39< YogiHH> hello 20090719 23:25:14< Sapient> yo Yogi 20090719 23:28:21-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090719 23:35:51< loonycyborg> Ivanovic: 1.7.2 windows installer is uploaded. 20090719 23:36:17< Ivanovic> loonycyborg: great 20090719 23:36:52-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["WRYYYYYYYYYYYYYYYYYYYY!"] 20090719 23:43:29< YogiHH> silene, can you explain to me the rationale behind introducing "resources"? 20090719 23:43:55-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection] 20090719 23:44:10< Soliton> stikonas: i'll probably forget the fuzzy stuff. please file a bug report. 20090719 23:45:00< Soliton> Ivanovic: trunk server rebuilt. 20090719 23:45:11< Soliton> err, ilor: ^ 20090719 23:45:11< Ivanovic> Soliton: cool 20090719 23:45:20< Soliton> indeed! 20090719 23:45:21< silene> YogiHH: technically, i didn't introduce them, they already existed and were used in various places of the engine, i just brought them together and started using them systematically 20090719 23:45:26< ilor> Soliton: thanks 20090719 23:45:33< Ivanovic> so from now on trunk should have serverside rng? 20090719 23:45:52< ilor> Ivanovic: well, a draft version of it 20090719 23:45:57< Ivanovic> maybe dragonking needs another formula ai test soon, then we can direclty test the serverside rng with it 20090719 23:46:02< ilor> Ivanovic: only combats are synced so far 20090719 23:46:18-!- ABCD [n=ABCD@wikipedia/ABCD] has joined #wesnoth-dev 20090719 23:46:18< ilor> that is, recruiting and WML random numbers work the old way 20090719 23:46:29< YogiHH> silene: so resources are kind of a bunch of global variables, then, to prevent passing parameters around? 20090719 23:46:31< Ivanovic> ilor: that should be enough to basically test it 20090719 23:46:54-!- ABCD_ [n=ABCD@wikipedia/ABCD] has quit [Read error: 113 (No route to host)] 20090719 23:47:11< ilor> Ivanovic: yeah, I don't want to spend time wiring up other stuff before it's tested 20090719 23:49:26< silene> YogiHH: they are not kind, they really are global variables (they already were), and it's not so much for not passing parameters around than for not storing the same information over and over (for instance, the global game state was stored in every single unit, in every single attack type, this was getting ridiculous!) 20090719 23:49:37< stikonas> Soliton: is that enough information for you: https://gna.org/bugs/?13986 20090719 23:50:17< Sapient> silene: references you mean 20090719 23:50:42< Sapient> not actual copies 20090719 23:51:05< Soliton> stikonas: i think so. 20090719 23:51:55< silene> Sapient: fortunately not, a scan of a core dump showed about 800 occurrences of the game state pointer 20090719 23:52:17< Chusslove> stikonas: Hey, not sleeping? 20090719 23:52:19< Chusslove> :) 20090719 23:52:42< stikonas> Chusslove: not yet 20090719 23:53:16< Chusslove> No problem, I was actually going to mention to you the new check-tp-wesnoth sieve in Pology, which is the one I've been using for reports on the ML, just now cleaned up and committed. 20090719 23:53:24< Sapient> 800 pointers... yikes 20090719 23:53:42< Chusslove> stikonas: So: posieve check-tp-wesnoth .../wesnoth/branches/1.6/po/*/lv.po 20090719 23:53:48< Chusslove> ...reveals two errors :) 20090719 23:54:01< stikonas> Chusslove lv or lt 20090719 23:54:02< stikonas> ? 20090719 23:54:15< YogiHH> silene: while i agree with what you did, i feel you should have informed the other developers about such a fundamental change. For example, euschn's GSoC project works a lot with game_state and we have to do a couple of design decisions regarding that. Knowing about such changes upfront would be very helpful. 20090719 23:54:33< Chusslove> stikonas: Ahrngh... lv. 20090719 23:54:38< stikonas> lv is Latvian translation, I do no coordinate them 20090719 23:54:40< Chusslove> False alarm... 20090719 23:54:51 * Chusslove is confusing lv and lt all the time. 20090719 23:54:52< stikonas> and I think it is inactive atm 20090719 23:55:24< Sapient> well now it is really impossible to do the OOS debugger I had once considered, now that the single game instance of game resources is hard coded 20090719 23:55:46< Sapient> on the other hand, I think the code simplification is worth it 20090719 23:57:04< stikonas> Chusslove: we switched to git for Lithuanian translation and review is much easier now, so there shouldn't be anymore lt alarms :) 20090719 23:57:14< YogiHH> Sapient: yes, i feel the same. OO is all nice and well, but if a variable is indeed a global variable i will be the last to make things more complicate than necessary. 20090719 23:57:31< Chusslove> stikonas: Indeed. 20090719 23:58:10< Sapient> I am curious though, why not make the unit 20090719 23:58:13< Chusslove> Btw "we" (as in currently only I) also work on translation in a Git repo... 20090719 23:58:17< MikeJB> Lithuanian translation? 20090719 23:58:24< MikeJB> Wow, Wesnoth really *is* in every conceivable language. 20090719 23:58:25< Sapient> .. unit_map a hard coded single instance as well? 20090719 23:58:52< silene> Sapient: because i think someone will want to have an ai that can consider various positions 20090719 23:59:19< silene> all the other resources do not make sense to exist with different contents in various place, but a unit map does 20090719 23:59:56< Sapient> we already have some bugs due to WML events firing while fake unit_maps are in effect --- Log closed Mon Jul 20 00:00:21 2009