--- Log opened Thu Aug 06 00:00:40 2009 20090806 00:09:14-!- wesbot changed the topic of #wesnoth-dev to: 69 bugs, 239 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090806 00:10:59-!- Valkier [n=karasawa@c-71-225-240-156.hsd1.pa.comcast.net] has quit [] 20090806 00:11:32-!- melinath [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 110 (Connection timed out)] 20090806 00:12:49-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090806 00:16:57-!- PK8 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 00:17:34-!- PK8 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit] 20090806 00:36:58-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090806 00:37:20-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection] 20090806 00:40:14-!- allefant [n=allefant@allegro/developer/allefant] has quit [Read error: 60 (Operation timed out)] 20090806 00:48:58-!- ilor [n=user@wesnoth/developer/ilor] has quit [] 20090806 00:51:02-!- Max2008 [n=chatzill@188-23-11-22.adsl.highway.telekom.at] has joined #wesnoth-dev 20090806 00:54:09-!- Max2008 [n=chatzill@188-23-11-22.adsl.highway.telekom.at] has quit ["ChatZilla 0.9.85 [Firefox 3.5.2/20090729225027]"] 20090806 01:03:14-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["night all"] 20090806 01:06:33< Sirp> okay so in the second tutorial level, 21% of people who play it are defeated -- and only 38% are victorious; the rest quit. That seems far too hard for a tutorial for me. 20090806 01:06:55< Sirp> I think a significant amount of people are likely to quit, but I think defeats should be well into single digits. 20090806 01:13:20< elias> i got defeated in the first level :P 20090806 01:14:02 * shadowmaster remembers the 0.9.6 tutorial, and how many times he got defeated on that one's second level when fighting Delfador 20090806 01:19:23-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"] 20090806 01:19:48-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090806 01:27:31-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Remote closed the connection] 20090806 01:30:22-!- BenUrban [n=benurban@c-68-50-54-86.hsd1.md.comcast.net] has joined #wesnoth-dev 20090806 01:42:16-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 60 (Operation timed out)] 20090806 01:45:11-!- BenUrban [n=benurban@unaffiliated/benurban] has quit [Read error: 104 (Connection reset by peer)] 20090806 01:45:26-!- BenUrban [n=benurban@c-68-50-54-86.hsd1.md.comcast.net] has joined #wesnoth-dev 20090806 01:48:02-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"] 20090806 01:52:04-!- Chusslove [n=Chusslov@brsg-d9beeaad.pool.mediaWays.net] has quit [Read error: 110 (Connection timed out)] 20090806 01:58:32-!- Chusslove [n=Chusslov@brsg-d9bef809.pool.mediaWays.net] has joined #wesnoth-dev 20090806 02:23:31-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090806 02:30:54< Aethaeryn> Is there a big-gui run thing? 20090806 02:31:18< Aethaeryn> Because Wesnoth fullscreen doesn't really support my awesome 23 inch monitor... messes up when I do ctrl+f 20090806 02:31:52< Aethaeryn> the resolution in question is 1920x1080 20090806 02:32:20< Aethaeryn> Wesnoth skips from 1280x800 (too small) to 3200x1080 (waaaaaaaaay too big - is this a real TV?) 20090806 02:33:25< Aethaeryn> my makeshift solution is to do 1280x800 windowed and just make it "full screen" but it's not true full screen, has a bar at the top that says "The Battle for Wesnoth - 1.6.4" 20090806 02:34:04< Soliton> tell your window manager to not display that bar. 20090806 02:35:05-!- ancestral [n=ancestra@166.205.6.19] has joined #wesnoth-dev 20090806 02:35:06< Aethaeryn> eh... not quite sure what you mean, but two screen setup is awesome. Wesnoth on a huge 23 inch widescreen monitor where you can basically see the whole battle... 20090806 02:35:20< Aethaeryn> and coding the map on the laptop with a 16 or 17ish inch monitor 20090806 02:35:37< Aethaeryn> Soliton: can I force the resolution to 1920x1080 by running it in the command line? 20090806 02:36:38< Soliton> yes, fullscreen is different though. 20090806 02:37:02< Soliton> you could try though. but IMO windowed is always better. 20090806 02:38:07< Aethaeryn> I guess. 20090806 02:39:22< Aethaeryn> when it's 23'' I guess I shouldn't complain about a bar that's the same height as the bar on my 15.4'' latop screen right next to it 20090806 02:39:25< Aethaeryn> :P 20090806 02:40:00-!- ancestral_ [n=ancestra@166.205.6.19] has joined #wesnoth-dev 20090806 02:40:19< Soliton> what window manager are you using? 20090806 02:40:39< Aethaeryn> GNOME 20090806 02:40:41-!- Sirp [n=user@wesnoth/developer/dave] has quit ["leaving"] 20090806 02:40:46< Aethaeryn> GNOME in Fedora 11 has nice multi-screen support 20090806 02:41:20-!- ancestral [n=ancestra@166.205.6.19] has quit [Read error: 104 (Connection reset by peer)] 20090806 02:41:21-!- ancestral_ is now known as ancestral 20090806 02:41:26< Soliton> ok, no idea then. 20090806 02:41:58< Aethaeryn> Eh, I used to be about 70% GNOME, 30% KDE, but I really didn't like KDE 4 20090806 02:42:19< Aethaeryn> I also liked Enlightenment, but it had bad support for wireless and a few other things. 20090806 02:43:24-!- Tesafilmchen [n=quassel@p5B2751C2.dip.t-dialin.net] has joined #wesnoth-dev 20090806 02:43:45-!- ancestral [n=ancestra@166.205.6.19] has quit [Read error: 104 (Connection reset by peer)] 20090806 02:44:30-!- ancestral [n=ancestra@166.205.6.19] has joined #wesnoth-dev 20090806 02:45:53-!- Tesafilmchen [n=quassel@p5B2751C2.dip.t-dialin.net] has left #wesnoth-dev ["http://quassel-irc.org - Chat comfortably. Anywhere."] 20090806 02:46:35-!- ancestral [n=ancestra@166.205.6.19] has quit [Client Quit] 20090806 02:48:49-!- Netsplit clarke.freenode.net <-> irc.freenode.net quits: crimson_penguin 20090806 02:49:17-!- Netsplit clarke.freenode.net <-> irc.freenode.net quits: esr, freim, MJ999, CIA-62 20090806 02:50:02-!- Tesafilmchen [n=quassel@p5B2751C2.dip.t-dialin.net] has joined #wesnoth-dev 20090806 02:52:39-!- Netsplit over, joins: esr, freim, MJ999, CIA-62 20090806 02:53:07-!- Netsplit over, joins: crimson_penguin 20090806 03:02:42-!- Tesafilmchen [n=quassel@p5B2751C2.dip.t-dialin.net] has quit [Remote closed the connection] 20090806 03:18:33-!- Kenpachi [n=chatzill@CPE-121-220-213-222.sa.bigpond.net.au] has joined #wesnoth-dev 20090806 03:19:13-!- Kenpachi [n=chatzill@CPE-121-220-213-222.sa.bigpond.net.au] has quit [Client Quit] 20090806 03:25:13-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["WRYYYYYYYYYYYYYYYYYYYY!"] 20090806 03:52:17-!- melinath [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has joined #wesnoth-dev 20090806 03:54:04< corn> Ivanovic: I am OK with it, although we should talk about whether I should switch the default logger to the new code 20090806 04:10:19-!- Appleman1234 [n=Appleman@131.181.100.17] has joined #wesnoth-dev 20090806 04:17:49-!- melinath [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 104 (Connection reset by peer)] 20090806 04:18:03-!- melinath [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has joined #wesnoth-dev 20090806 04:22:49-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090806 04:26:33-!- cib0 [n=cib@p5DC43C73.dip.t-dialin.net] has quit [Remote closed the connection] 20090806 04:28:31-!- ancestral [n=ancestra@166.205.6.19] has joined #wesnoth-dev 20090806 04:49:34-!- ancestral [n=ancestra@166.205.6.19] has quit ["Get Colloquy for iPhone! http://mobile.colloquy.info/"] 20090806 04:54:04-!- Sirp [n=user@wesnoth/developer/dave] has joined #wesnoth-dev 20090806 04:54:44-!- Ivanovic_ [n=ivanovic@dtmd-4db2235e.pool.einsundeins.de] has joined #wesnoth-dev 20090806 04:58:06-!- ancestral [n=ancestra@97-116-126-165.mpls.qwest.net] has joined #wesnoth-dev 20090806 04:58:25-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev 20090806 05:05:50-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has quit [Connection timed out] 20090806 05:08:09-!- Ivanovic__ [n=ivanovic@dtmd-4db2235e.pool.einsundeins.de] has joined #wesnoth-dev 20090806 05:11:02-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 113 (No route to host)] 20090806 05:11:37-!- Ivanovic__ is now known as Ivanovic 20090806 05:22:44-!- Ivanovic_ [n=ivanovic@dtmd-4db2235e.pool.einsundeins.de] has quit [Read error: 113 (No route to host)] 20090806 05:31:00-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["It's going to be a long month."] 20090806 06:12:28-!- Sirp [n=user@wesnoth/developer/dave] has quit [Read error: 113 (No route to host)] 20090806 06:42:47-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [] 20090806 07:03:57-!- Turuk_ [n=Turuk@wesnoth/forumsith/turuk] has quit [Read error: 104 (Connection reset by peer)] 20090806 07:37:01-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has joined #wesnoth-dev 20090806 07:39:12-!- melinath [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 110 (Connection timed out)] 20090806 07:50:54-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20090806 08:01:51-!- Valkier [n=karasawa@c-71-225-240-156.hsd1.pa.comcast.net] has joined #wesnoth-dev 20090806 08:02:14 * Valkier wonders if anyone is actually awake 20090806 08:02:36< zookeeper> billions of people, i'd imagine. probably some of them here, too. 20090806 08:02:45< Valkier> No man 20090806 08:02:48< Valkier> The world is asleep 20090806 08:02:55< Valkier> We're all like.. just a dream... 20090806 08:03:12< noy> ... 20090806 08:03:30< ancestral> Real life is the dream world and the dream world is real life 20090806 08:03:31< Valkier> Well if he gets to be sarcastic then I get to act like a coked out hippie. 20090806 08:04:32< Valkier> I just watched Being John Malkovich. Don't toy with my perception of reality. 20090806 08:05:16< noy> how about moving this conversation to #wesnoth 20090806 08:08:11< Valkier> Yeah. Don't wanna inturrupt the lively conversation of development here. 20090806 08:09:27< noy> Valkier: Yeah, don't want to give people the wrong idea of what occurs here 20090806 08:16:41-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20090806 08:17:54-!- ancestral [n=ancestra@97-116-126-165.mpls.qwest.net] has quit ["And that’s the end of THAT chapter."] 20090806 08:23:47-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 113 (No route to host)] 20090806 08:36:09< zookeeper> so what's up with the gna mailing lists? 20090806 08:36:48< zookeeper> there's nothing on their news page 20090806 08:47:03-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)] 20090806 08:47:37-!- elias [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090806 09:03:53< noy> zookeeper: they did say there was some breakdown today 20090806 09:05:12< zookeeper> noy, there haven't been any mails this whole month 20090806 09:05:19< noy> oh really? 20090806 09:05:25< noy> have people sent any? 20090806 09:05:33< zookeeper> well, yeah, people commit stuff all the time 20090806 09:05:36< noy> ahh 20090806 09:05:56< noy> I just guessed it was a lull in emais 20090806 09:13:18-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090806 09:28:56-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev 20090806 09:28:56-!- Appleman1234 [n=Appleman@131.181.100.17] has quit [Read error: 60 (Operation timed out)] 20090806 09:29:02< euschn> hi 20090806 09:31:20< Valkier> Howdy 20090806 09:53:05< CIA-62> thespaceinvader * r37518 /trunk/ (6 files in 5 dirs): Add and wire new Paladin portrait, update changelogs, portrait credits. 20090806 09:56:41< Valkier> All righty. I got a question for anyone in here. 20090806 09:57:09< Valkier> Working on the Deathblade portrait. I think having him hold a second axe looks lame as hell. Think I can get away without one? 20090806 10:08:09< zookeeper> maybe 20090806 10:08:32< zookeeper> any chance of still having the second one on him somewhere, hanging from the back or belt or something? 20090806 10:09:03< Valkier> Was thinking back 20090806 10:09:57-!- freim [n=hogne@feathers.os-tr.net] has quit [Remote closed the connection] 20090806 10:13:04< zookeeper> i don't think it matters if he isn't holding the second one but it's just on him somewhere 20090806 10:16:39-!- grom358_ [n=grom@146.35.233.220.static.exetel.com.au] has joined #wesnoth-dev 20090806 10:16:46-!- grom358_ [n=grom@146.35.233.220.static.exetel.com.au] has quit [Client Quit] 20090806 10:16:50-!- grom358 [n=grom@146.35.233.220.static.exetel.com.au] has joined #wesnoth-dev 20090806 10:25:48< CIA-62> euschn * r37519 /trunk/src/ (gamestatus.cpp gamestatus.hpp play_controller.cpp): renamed game_state::get_player_info() to build_team() and changed some comments for more clarity 20090806 10:29:43-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090806 10:29:45< grom358> what does IIRWIIR mean? 20090806 10:30:03< Blueblaze> It is ready when it is ready 20090806 10:30:17< Blueblaze> Mainly used whenever people ask when is 1.x version coming out 20090806 10:32:47< Rhonda> Blueblaze: But 1.x is already out? 20090806 10:34:07< grom358> mmm.. weird.. why are both SCons and CMake supported? 20090806 10:35:26< Blueblaze> Rhonda: Depends what x= :) 20090806 10:35:51< Blueblaze> I guess I should replace 1.x with just X 20090806 10:36:04< Valkier> Is Wesnoth out yet? 20090806 10:36:23< Valkier> I hear it's great and doesn't afraid of anything. 20090806 10:38:02-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20090806 10:38:28< Valkier> So then TSI tells me how my arms are so big and strong 20090806 10:49:12< Ivanovic> moin 20090806 10:55:25< Valkier> Moin? 20090806 11:06:45< Ivanovic> corn: i don't know about switching the logger 20090806 11:06:54< Ivanovic> corn: what exactly would the consequences be? 20090806 11:08:00< Ivanovic> Valkier: http://en.wikipedia.org/wiki/Moin 20090806 11:08:58< Valkier> Fun word 20090806 11:09:23-!- fendrin [n=fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20090806 11:15:20-!- grom358 [n=grom@146.35.233.220.static.exetel.com.au] has quit [Read error: 54 (Connection reset by peer)] 20090806 11:16:44-!- loonybot [n=loonybot@79.139.138.234] has joined #wesnoth-dev 20090806 11:17:32-!- loonycyborg [n=sergey@79.139.138.234] has joined #wesnoth-dev 20090806 11:20:21< Valkier> Is it natural for people to stay up for two days because they lost track of time? 20090806 11:33:58-!- thespaceinvader_ [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has joined #wesnoth-dev 20090806 11:34:26-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Nick collision from services.] 20090806 11:34:36-!- thespaceinvader_ is now known as thespaceinvader 20090806 11:43:07< Soliton> euschn: http://www.wesnoth.org/forum/viewtopic.php?p=374347#p374347 already fixed, right? 20090806 11:44:04< euschn> Soliton: yes, thats fixed 20090806 11:44:16< Soliton> euschn: also, do you know that there is a problem replaying reloaded games? it seems the replay tries to start from turn one while the snapshot is from the turn it was loaded or so. 20090806 11:45:50< euschn> Soliton: hm, I think you directd me to a multiplayer game on that a while ago. I admit I didnt find time to look into it yet 20090806 11:46:10< euschn> do you know if this is a mp problem or does it occur in campaigns aswell? 20090806 11:46:15-!- deekay [n=dk@wesnoth/developer/dragonking] has joined #wesnoth-dev 20090806 11:48:05< Soliton> mp only afaict. 20090806 11:48:42< Soliton> probably because you literally create a new game just with a different starting state? 20090806 11:48:58< Soliton> while in a campaign you just reload. 20090806 11:49:49< Soliton> so i guess the problem is not the reloading but hosting a reloaded game. 20090806 11:50:36< euschn> Soliton: I see. so reloading a new game might set the snapshot as the new starting position, which of course doesnt fit with the replay information? 20090806 11:50:58< Soliton> yeah. 20090806 11:51:26< Soliton> i've fixed replays with just cutting out the replay info for the reloaded turns. 20090806 11:52:06< Soliton> better would be if they start from the beginning state of course though. 20090806 11:52:50< Soliton> i can give you example replays if you like but reproducing is probably even better. 20090806 11:52:58< euschn> Soliton: confirmed, was just able to reproduce it 20090806 11:53:06< euschn> I will have a look at it 20090806 11:53:15< Soliton> cool, thanks. 20090806 12:09:14-!- wesbot changed the topic of #wesnoth-dev to: 70 bugs, 239 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20090806 12:17:40-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090806 12:26:32-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Remote closed the connection] 20090806 12:37:32-!- noy [n=Noy@wesnoth/developer/noy] has quit ["GO, GET TO THE CHOPPAH!!!"] 20090806 12:48:20-!- Netsplit clarke.freenode.net <-> irc.freenode.net quits: erl 20090806 12:49:38-!- Netsplit over, joins: erl 20090806 12:52:56-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Remote closed the connection] 20090806 13:05:25-!- Valkier [n=karasawa@c-71-225-240-156.hsd1.pa.comcast.net] has quit [] 20090806 13:27:59-!- Amu_ [n=smar@a88-113-60-192.elisa-laajakaista.fi] has joined #wesnoth-dev 20090806 13:28:30-!- Amu [n=smar@a88-113-60-192.elisa-laajakaista.fi] has quit [Read error: 104 (Connection reset by peer)] 20090806 14:17:09< CIA-62> euschn * r37520 /trunk/src/multiplayer_connect.cpp: fixed incorrect setting of starting_pos when loading midgame multiplayer saves 20090806 14:17:12< euschn> Soliton: that should fix mp replays from loadgames 20090806 14:17:44< Soliton> euschn: nice, can it be backported to 1.6 easily? 20090806 14:17:59< Soliton> (if not don't bother.) 20090806 14:19:19< euschn> Soliton: hm, let me have a look 20090806 14:27:38< euschn> Soliton: hm, doesnt look to different, should be ok. I have not backported anything yet, where am i supposed to add the change? branches/1.6? 20090806 14:27:50< Soliton> euschn: yes. 20090806 14:27:53< euschn> ok 20090806 14:52:36-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has joined #wesnoth-dev 20090806 14:55:14-!- esr [n=chatzill@wesnoth/developer/esr] has quit [Read error: 110 (Connection timed out)] 20090806 15:00:55-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090806 15:02:55-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"] 20090806 15:13:09-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"] 20090806 15:23:07-!- Alesis-Novik_ [n=alesis@78.60.249.133] has joined #wesnoth-dev 20090806 15:24:21-!- Alesis-Novik [n=alesis@78.60.249.133] has quit [Read error: 110 (Connection timed out)] 20090806 15:27:35-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev 20090806 15:40:31-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has joined #wesnoth-dev 20090806 15:54:13-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev 20090806 15:54:24< CIA-62> euschn * r37521 /branches/1.6/src/multiplayer_connect.cpp: backported correct setting of starting_pos after loading midgame multiplayer saves 20090806 16:18:36-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 113 (No route to host)] 20090806 16:41:34-!- allefant [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev 20090806 16:43:45-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)] 20090806 16:45:37-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has joined #wesnoth-dev 20090806 16:46:00-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["bbl"] 20090806 16:50:15< CIA-62> crab * r37522 /trunk/src/ai/formula/ (ai.cpp callable_objects.cpp): Made formula_ai reuse move maps of ai_default. 20090806 16:53:07< silene> lizard_r: if you don't have svn access, please submit your patch to gna, so that we can apply it 20090806 16:53:48< lizard_r> silene: I'll submit a patch if many people like it 20090806 17:00:38-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has joined #wesnoth-dev 20090806 17:21:40< Ivanovic> ha, already sunday for me on the commit ml 20090806 17:21:46< Ivanovic> great to finally get the mails 20090806 17:30:12< CIA-62> silene * r37523 /trunk/data/campaigns/Descent_Into_Darkness/scenarios/ (7 files): Mentioned time limit in objectives. (Patch #1216 by lotsofphil.) 20090806 17:34:43-!- ettin_ [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev 20090806 17:47:44-!- ettin [n=jorda@wesnoth/developer/ettin] has quit [Read error: 110 (Connection timed out)] 20090806 17:54:13-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev 20090806 18:04:56-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090806 18:17:35-!- Blarumyrran [n=villu@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090806 18:21:28-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090806 18:22:28-!- Blarumyrran [n=villu@81-20-159-197.levira.ee] has quit [Remote closed the connection] 20090806 18:34:42-!- blarumyrran [n=minaise@81-20-159-197.levira.ee] has joined #wesnoth-dev 20090806 18:38:26-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090806 18:50:10< CIA-62> euschn * r37524 /trunk/src/playcampaign.cpp: fixed scenario advancement of clients in multiplayer games 20090806 19:09:01-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit [Read error: 60 (Operation timed out)] 20090806 19:15:53-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev 20090806 19:18:19-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"] 20090806 19:22:57-!- PK6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 19:23:05-!- PK6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit] 20090806 19:23:21-!- PK3 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 19:25:11-!- PK3 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit] 20090806 19:25:23-!- PK4 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 19:29:18-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20090806 19:29:31< mordante> servus 20090806 19:31:48< ilor> hi mordante 20090806 19:31:55< mordante> hi ilor 20090806 19:32:08< mordante> reading the commit mails 20090806 19:32:08< ilor> mordante: I'm just doing the wiki page update now, will ping you in a while once I'm done 20090806 19:32:13< mordante> ok 20090806 19:34:00< mordante> gui/dialogs/lobby_main.cpp +/- 922 "const std::string& topic = data["topic"];" don't do that const std::string& to a config::operator[] is dangerous 20090806 19:34:41< mordante> afaik cjhopman was working on a fix for his gsoc project, but guess not finished yet 20090806 19:36:11< ilor> mordante: I think it's safe in this case since the config is not touched and I only check for empty and then append the string to something 20090806 19:36:24< ilor> mordante: should I change it anyway? 20090806 19:37:14< mordante> yes please I think it's never save to use this 20090806 19:37:37 * ilor considers a grep to see how often this is used anyway 20090806 19:37:55< mordante> the std::string is bound to a temporary of a destroyed temporary and causes UB 20090806 19:38:10 * mordante fears too often :-/ 20090806 19:39:45< ilor> mordante: well I can go and kill all the cases in my code, but tbh it seems wasteful to copy these strings all thetime 20090806 19:40:33< ilor> and what about all the functions that take a const std::string& and are called with a f(a["b"]) 20090806 19:40:57< mordante> guess also not save :-( 20090806 19:41:24< mordante> it causes problems in some cases, but seems to work properly in most... all hail UB 20090806 19:42:04< ilor> I'd say this has to be fixed in config otherwise half of wesnoth can start crashing randomly 20090806 19:42:36< mordante> I agree that's also one of the things cjhopman was working on 20090806 19:44:03-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20090806 19:44:35< mordante> I'm not too happy with the hardcoding of the colours for friends etc in the lobby 20090806 19:44:48< mordante> I prefer to have this some format variables in WML 20090806 19:45:09< mordante> that way the user can specify how friends are shown in custom themes 20090806 19:45:17< ilor> mordante: I'd be happy to use another way, only couldn't think of one code-wise 20090806 19:45:34< ilor> I agree it'd be much better to leave this to wml 20090806 19:46:00< mordante> we can either make it global settings for the gui or add some extra fields to that specific window 20090806 19:46:18< ilor> ditto for some other stuff like the bunch of icons that are actually hardcoded and not easily changeable in the lobby dialog wml 20090806 19:46:52< mordante> we need to look into that 20090806 19:47:32< mordante> I think friend colours need to be global since you also see them at other MP dialogs 20090806 19:47:38< mordante> the icons can be window specific 20090806 19:49:31< ilor> I solved the icons issue partially for some icons 20090806 19:49:37< mordante> nice 20090806 19:49:55< ilor> there's a id=observers icon that gets a hardcoded filename depending on the game 20090806 19:50:18< ilor> but teh cpp code also checks for widgets with id observers_yes and observers_no or sth like that 20090806 19:50:30< ilor> and shows/hides them accordingly if they exist 20090806 19:50:50< ilor> it's not really used now but will work as "a" solution 20090806 19:52:52< mordante> ok 20090806 19:53:07< mordante> once my compiler is done, I'll have a look at how it looks now 20090806 19:54:13< ilor> mordante: wiki updated 20090806 19:54:34< ilor> added a bugs section at http://www.wesnoth.org/wiki/MP_Server_Ilor#Remaining_issues 20090806 19:56:34< mordante> ilor, the first bug is also listed here https://gna.org/bugs/index.php?14073 20090806 19:57:05< ilor> mordante: yeah I remember, want me to add the other ones to the tracker? 20090806 19:57:30< mordante> no not needed, only added this one for Ivanovic since it's a blocker 20090806 19:57:34< silene> mordante: no, associating const std::string& to the result of a config::operator[] is not dangerous; it's associating it to a vconfig::operator[] that is dangerous 20090806 19:58:02< mordante> silene, sure it's only vconfig? I thought it was both 20090806 19:58:13< silene> yes i'm sure 20090806 19:58:30< mordante> ok 20090806 19:58:30< silene> and i'm also sure it is not the first time i explain it 20090806 19:59:24 * ilor is relieved to hear that 20090806 19:59:49< mordante> silene, I know you explained it before, just thought is was both 20090806 20:00:59< silene> that being said, i'm only talking about my implementation of the config class; now that cjhopman, it may become unsafe too 20090806 20:01:14< silene> changed it, it may have* 20090806 20:02:49< mordante> we shouldn't allow that to happen, the current situation is tricky enough 20090806 20:04:22< mordante> ilor, maybe add an [M] or [I] before your remaining issues so it's clear who'll work on them 20090806 20:04:44< ilor> mordante: ok will do in a minute 20090806 20:07:18< silene> hmm... i was mistaken; cjhopman has not implemented anything yet, so the config class is still my implementation 20090806 20:08:10< mordante> he wanted to work on it and we discussed it here and on the dev-ml 20090806 20:08:32< mordante> ilor, so it seems the only mandatory item you have left is polishing :-) 20090806 20:08:56< mordante> which is partly blocked by some bugs, I've to resolve first 20090806 20:09:11< ilor> mordante: yeah pretty much. I don't want to rush stuff like the rest of the server rng 20090806 20:09:44< mordante> I understand 20090806 20:10:17-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has quit ["Saurian Augur - I'll heal you by 4 hp if you leave next to me"] 20090806 20:10:59< ilor> right now I guess I'll write some docs to the room system since I seem to have forgotten to 20090806 20:11:16 * mordante loves documentation :-) 20090806 20:11:36< mordante> what kind of documentation are you writing, user or developer? 20090806 20:11:59< mordante> I think there should be some info in the help and manual about the rooms 20090806 20:12:00< ilor> I'm not sure if it's immediatelly apparent that wesnothd can be configured so only admins can create rooms, and that these rooms can be saved on disk so they're there after a reboot 20090806 20:12:17< Soliton> that goes in the man page. 20090806 20:12:19< ilor> mordante: server operator docs first 20090806 20:12:28< mordante> ok 20090806 20:12:51< ilor> which reminds me I can't remeber if I did the periodic room save to disk after all _-_ 20090806 20:13:01< Soliton> user docs should most importantly go in help.cfg and can be replicated from there to the manual etc. 20090806 20:14:11< ilor> Soliton: and server docs to doc/man/wesnothd.6, okay 20090806 20:16:49< Soliton> yep, possibly also to ServerAdministratin in the wiki. 20090806 20:16:56< Soliton> ion* 20090806 20:24:21-!- Blueblaze [n=nick@c-98-199-143-139.hsd1.tx.comcast.net] has quit [Read error: 104 (Connection reset by peer)] 20090806 20:41:13-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20090806 20:43:48-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Read error: 104 (Connection reset by peer)] 20090806 20:43:53-!- thespaceinvader_ [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has joined #wesnoth-dev 20090806 20:43:58-!- thespaceinvader_ is now known as thespaceinvader 20090806 20:50:00-!- thespaceinvader [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has quit [Read error: 104 (Connection reset by peer)] 20090806 20:50:01-!- thespaceinvader_ [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has joined #wesnoth-dev 20090806 20:50:06-!- thespaceinvader_ is now known as thespaceinvader 20090806 20:54:51-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has joined #wesnoth-dev 20090806 21:02:14< Soliton> ilor: what might be nice for the lobby interface is a split view of the games list. i often find myself looking for some interesting games to observe but at the same time also wanting to know whether a nice new game pops up. 20090806 21:03:04< ilor> Soliton: split view? 20090806 21:03:39< Soliton> ilor: like when you split the view in an editor and see the same file twice. 20090806 21:03:53-!- PK4 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Read error: 104 (Connection reset by peer)] 20090806 21:04:10< ilor> Soliton: ugh, it does not sound very easy to do with what we have 20090806 21:04:30< Soliton> ok, just dreaming. ;-) 20090806 21:05:07< Soliton> ideally one could have different filters in each view so one can filter for new games in one (maybe with the title ladder) and have a normal view in the other. 20090806 21:05:09-!- PK1 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 21:06:09< ilor> speaking of the game list, mordante, I will need to be able to set the listbox scroll position eventually, current behavior might get unbearable real quick with many games 20090806 21:10:11-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev 20090806 21:14:20< corn> Ivanovic: right now the script that receives new logs is on my server, not the wesnoth.org server. if you switched the logger, new logs would go to my server (not ideal) and there might be breakage if the new logs are sent to the old script 20090806 21:14:50< corn> so it is probably best to wait until atleast that part of my project is run on wesnoth.org 20090806 21:18:45-!- PK1 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit ["Java user signed off"] 20090806 21:18:45-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["ttyl"] 20090806 21:19:35< Ivanovic> hmm, yeah 20090806 21:37:21-!- giusef [n=giusef@unaffiliated/giusef] has quit [Read error: 110 (Connection timed out)] 20090806 21:40:29< mordante> ilor, yup setting the scrollbar position is on my todo list as well 20090806 21:45:31-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev 20090806 21:49:50< CIA-62> cornmander * r37525 /website/stats.wesnoth.org/ (configuration.py.example map_tiler.py): Completed script that will generate map tiles for gmaps in a nightly cronjob 20090806 21:52:15< mordante> ilor, I just had a look at the new lobby and I see I have a lot of code polishing to do 20090806 21:52:29< ilor> mordante: wml-wise? 20090806 21:52:42< mordante> your part works, but there are a lot of things which look ugly 20090806 21:52:54< mordante> no c++-wise but for me 20090806 21:53:05< mordante> scrollbars popping up etc 20090806 21:53:29< mordante> this should be fixed before the next release if we want to advertise the new lobby 20090806 21:53:57< ilor> yeah but it's definitely less important than the crash bugs and the layout moving up and down 20090806 21:53:58< mordante> you did a great job, only due to the code bugs it feels bad 20090806 21:54:18< ilor> thanks :) 20090806 21:54:52< mordante> I disagree, when users use the lobby as-is they say it sucks and start to complain about it 20090806 21:55:05< mordante> eventhough the problem are the bugs not your part 20090806 21:55:44-!- PK7 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev 20090806 21:55:45< ilor> mordante: I agree this bug will annoy people and distract them from finding new bugs, but the loby randomly crashing is undeniably more severe of a bug :) 20090806 21:56:24< mordante> I agree that's a worse bug, but I want to have the code side polished before advertising the new lobby 20090806 21:57:04< mordante> but having worse bugs doesn't mean we should ignore the less severe ones ;-) 20090806 22:01:27< mordante> ilor, I assume you've enough things to do until the 10th? 20090806 22:01:48< ilor> mordante: generally yes, but if you have something in mind, fire away 20090806 22:02:01< mordante> no not really 20090806 22:02:28< mordante> I hope to do some things soon, but it's way too hot to code at the moment 20090806 22:03:54< ilor> still too hot at 10pm? ugh 20090806 22:04:13< mordante> yup still over 25 degrees outside 20090806 22:04:22< shadowmaster> ugh, I think I killed a new hard disk drive 20090806 22:04:31< mordante> :-( 20090806 22:05:21< ilor> shadowmaster: liquid spill, accidental drop or friendly fire? 20090806 22:05:22< corn> shadowmaster: how? 20090806 22:06:23< shadowmaster> no idea. I installed it, configured it, everything was fine until I let the system more or less idle for 15 minutes while studying the plan for the partition table. The debian installer partitioner crashed, became unresponsive, I couldn't switch to any text console, I forced a shutdown... 20090806 22:06:44< shadowmaster> and now, whenever I try to boot a Linux-based system off a DVD, I get this, ad infinitum: http://wesnoth.pastebin.com/d184fe00 20090806 22:08:31< loonycyborg> When do you get it? 20090806 22:08:46-!- Crab_ [i=crab@wesnoth/developer/crab] has quit [Read error: 110 (Connection timed out)] 20090806 22:08:50-!- kitty__ [n=kitty@e180196102.adsl.alicedsl.de] has joined #wesnoth-dev 20090806 22:08:50< shadowmaster> apparently before the kernel gets to run init 20090806 22:08:59< Soliton> ilor: an option for saving server side replays would be nice. ;-) 20090806 22:09:28< loonycyborg> Hm.. It shouldn't mount it if it's booting from DVD.. 20090806 22:09:39< shadowmaster> er, correction, apparently before the kernel gets to do much. A KDE 4.2.2 live CD system gets stuck after loading the sata_via and pata_via modules 20090806 22:09:40< ilor> Soliton: there's no option for that? 20090806 22:09:59< ilor> loonycyborg: it probably happens while probing for stuff 20090806 22:10:04< shadowmaster> yeah. 20090806 22:11:02< ilor> shadowmaster: does the drive spin up? 20090806 22:11:16< loonycyborg> Does it show up in bios? 20090806 22:11:21< shadowmaster> yes, it shows up. 20090806 22:11:23< Soliton> ilor: i mean in the lobby interface. 20090806 22:11:46< shadowmaster> ilor: apparently. Although right before the first crash, it started spinning up and down repeteadly 20090806 22:11:50< shadowmaster> *down and up 20090806 22:12:08< ilor> Soliton: ah. I thought we wanted ti store all replays anyway, and only allow the user to make it non-public 20090806 22:12:20< corn> shadowmaster: you should download a repair utility, most of the HD makers provide one 20090806 22:12:32< Soliton> ilor: right, that's what i meant. 20090806 22:12:35< ilor> Soliton: and it's not really a lobby thing, that's mp_create :P: 20090806 22:12:41< corn> it should give you an option to reflash the firmware with the latest update, that will reset everything on the HD to a factory state probably 20090806 22:12:47< Soliton> ilor: it needs an icon! 20090806 22:13:00< corn> so if it is a software problem in the HD rather than an hardware problem, it will get fixed 20090806 22:13:21< ilor> I might have a go at the create dialog after gsoc though and this will liekly get in 20090806 22:14:02< ilor> Soliton: then post something encouraging in my request for icons thread, so far nobody did anything :P 20090806 22:14:24< Soliton> ilor: then let's not scare them away! 20090806 22:14:37-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has quit ["Saurian Augur - I'll heal you by 4 hp if you leave next to me"] 20090806 22:18:32-!- Crab_ [i=crab@wesnoth/developer/crab] has joined #wesnoth-dev 20090806 22:19:04-!- giusef [n=giusef@unaffiliated/giusef] has quit ["exit (-1);"] 20090806 22:21:52-!- shadowmaster_ [i=be164ecd@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20090806 22:22:12-!- shadowmaster_ is now known as shadowm_webchat 20090806 22:29:35< noy> ilor: is it too late to make a feature request? 20090806 22:29:56< ilor> noy: never too late to _make_ one :) 20090806 22:30:03< noy> right 20090806 22:30:44< noy> I don't know how feasible this would be, but I would love if as a moderator I can easily see people's IPs if I put my cursor over their name 20090806 22:31:00-!- MikeJB [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev 20090806 22:31:36< ilor> doable. gui2 tooltips are not very reliable yet though so not immediatelly 20090806 22:32:00< noy> that and prior aliases 20090806 22:32:13< noy> more or less stuff that requires me to do a lot of typing now 20090806 22:32:20< mordante> fixing the tooltips is on my, way too long, todo list 20090806 22:33:04< ilor> noy: I can give you access to this via a button in the doubleclick-on-user dialog 20090806 22:33:14< noy> thats fine too 20090806 22:33:42< noy> though thats kinda what it is like now 20090806 22:34:21< ilor> noy: wouldn't that be less typing though? 20090806 22:35:51< noy> it would 20090806 22:44:24< mordante> I'm off night 20090806 22:45:24-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"] 20090806 22:46:26-!- shadowm_webchat [i=be164ecd@wesnoth/developer/shadowmaster] has quit [Ping timeout: 180 seconds] 20090806 22:47:15< CIA-62> crab * r37526 /trunk/src/ai/ (8 files in 4 dirs): 20090806 22:47:15< CIA-62> Modified formula ai to depend only on readonly_context (plus, temporary disabled some formula_ai-as-ai parts). 20090806 22:47:15< CIA-62> This will allow to use formula_ai from fai engine, thus, re-enable this engine. 20090806 22:47:57< CIA-62> crab * r37527 /trunk/src/ai/composite/ (ai.cpp engine.cpp engine.hpp engine_fai.cpp engine_fai.hpp): Re-enabled formula ai engine. There are still some known issues with fai command-line console which will be fixed soon. 20090806 22:48:24-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20090806 22:48:44-!- silene1 [n=plouf@AMarseille-251-1-96-229.w86-202.abo.wanadoo.fr] has joined #wesnoth-dev 20090806 22:49:09-!- silene [n=plouf@wesnoth/developer/silene] has quit [Read error: 60 (Operation timed out)] 20090806 22:53:31-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"] 20090806 22:55:30< Crab_> (note: r37527 errors on autosave. I'll commit a fix soon) 20090806 22:57:09-!- MikeJB is now known as Aethaeryn 20090806 23:01:26< CIA-62> crab * r37528 /trunk/src/ai/formula/ai.cpp: fixed error with serializaiton of formula_to to config on autosave 20090806 23:02:49< Aethaeryn> Bah. 20090806 23:02:56< Aethaeryn> The last thing I want to see... 20090806 23:03:09< corn> Crab_: what is the difference between attack_stats.attack_result() and attack_stats.defend_result()? 20090806 23:03:20< shadowmaster> Aethaeryn: did you find a bug? 20090806 23:03:21< Aethaeryn> Is just after I run the update (svn up and scons) is a revision that says the last one was broken and fixes the last one XD 20090806 23:03:25< Aethaeryn> mid-compile. 20090806 23:03:39< corn> Crab_: specifically, are both called when a unit attacks another unit? 20090806 23:03:40< Aethaeryn> So now I have to wait for 37527 to finish, and then update *again* XD 20090806 23:03:48< shadowmaster> you can use stable if you don't like it. 20090806 23:03:57< Aethaeryn> shadowmaster: It's worse than finding a bug because at least to find a bug you get to run Wesnoth first XD 20090806 23:04:23< Aethaeryn> And using SVN is the price you have to pay for making an era/campaign project as ambitious as mine. 20090806 23:04:30-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)] 20090806 23:04:35< Aethaeryn> It works out in the long run because it's less major wmllint and patching I have to do. 20090806 23:04:42< corn> I can check this via GDB if you don't know, but I was hoping you knew off hand 20090806 23:04:50< Aethaeryn> If I use the cutting edge, that means it'll be stable by the time I finish :P 20090806 23:04:59-!- melinath_ [n=melinath@pool-72-72-193-179.altnpa.east.verizon.net] has quit [Read error: 110 (Connection timed out)] 20090806 23:05:11< Crab_> corn: no, I don't know. I'll check it out now... 20090806 23:05:17< corn> ok 20090806 23:05:51< corn> I am implementing the kill event logging and I hope to put the code that adds to the upload_log inside one or both of those functions 20090806 23:06:42< Crab_> corn: I'll recommend patching src/game_events.cpp:2212 instead 20090806 23:07:43< corn> ok 20090806 23:08:14< Crab_> it all depends on 'what info you need', of course 20090806 23:09:14< corn> doing it at game_events.cpp:2212 would give me victim information, can I get winner information as well? 20090806 23:09:34< Crab_> corn: no. there's no winner at this point :) 20090806 23:10:02< corn> what do you mean? 20090806 23:12:07< corn> Crab_: actually it seems that death_loc and attacker_loc are provided 20090806 23:12:48< corn> no, nevermind... that is to the die event 20090806 23:14:18< Crab_> corn: so, if you need info about attacker, as well, then it's better to do as you originally planned 20090806 23:14:37< corn> ok 20090806 23:14:59< corn> attack::attack() should be refactored... it is currently 700 lines 20090806 23:15:32< Crab_> and regarding your original question, both attack_stats.attack_result() and attack_stats.defend_result() are called during an attack 20090806 23:15:37< Crab_> once per each strike 20090806 23:15:46< corn> ok, thank you 20090806 23:16:09-!- silene1 [n=plouf@AMarseille-251-1-96-229.w86-202.abo.wanadoo.fr] has quit ["Leaving."] 20090806 23:16:10< Crab_> attack_stats.attack_result on each attacker's strike, and attack_stats.defend_result on each defender's strike 20090806 23:16:50< corn> so if the attacker dies on a defender's strike, attack_result will not be called after that? 20090806 23:17:06< Crab_> no, it should not be called after that 20090806 23:17:08< corn> ok 20090806 23:17:15< corn> I will test these things myself 20090806 23:18:23-!- Crab_ [i=crab@wesnoth/developer/crab] has left #wesnoth-dev [] 20090806 23:18:27< corn> Crab_: do you think it would be good to move the loop at actions.cpp:1077 into a new function, do_attackloop()? 20090806 23:18:42< corn> aw 20090806 23:23:20-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["ttyl"] 20090806 23:36:36-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [] 20090806 23:38:21-!- kitty__ [n=kitty@e180196102.adsl.alicedsl.de] has quit ["bye"] 20090806 23:44:40-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit [] 20090806 23:54:01-!- Turuk [n=Turuk@wesnoth/forumsith/turuk] has joined #wesnoth-dev --- Log closed Fri Aug 07 00:00:49 2009