--- Log opened Mon Aug 17 00:00:09 2009
--- Day changed Mon Aug 17 2009
20090817 00:00:09< shadowmaster> oh, finally, Internet works!
20090817 00:01:26< shadowmaster> bah, I spoke too soon.
20090817 00:01:52< shadowmaster> silene: pling
20090817 00:02:16< shadowmaster> what is r37837 about? I don't remember implementing a speaker= attribute there
20090817 00:03:45-!- Sirp [n=user@71.164.166.178] has quit [Read error: 131 (Connection reset by peer)]
20090817 00:04:05< silene> shadowmaster: the contrary would have been surprising, since i did
20090817 00:04:23< shadowmaster> um, I am surprised I wasn't aware of it.
20090817 00:04:56-!- stikonas_ [n=and@ctv-213-164-123-205.vinita.lt] has quit [Read error: 110 (Connection timed out)]
20090817 00:06:22< shadowmaster> is there any example of its usage in mianline?
20090817 00:07:59< silene> shadowmaster: yes, five scenarios are using it; and that's the main reason i implemented it in a rush before the release: these scenarios had broken pango markup; i fixed them by getting rid of the markup from the wml code and into the c++ code
20090817 00:08:23< silene> s/getting rig/moving/ should make the sentence clearer
20090817 00:08:42< shadowmaster> I wonder why wouldn't a WML macro have fixed it instead?
20090817 00:09:07< silene> wml macros don't work with translatable strings
20090817 00:09:12< shadowmaster> other cases of "standard Pango markup" also use macros (e.g. WHISPER)
20090817 00:09:14-!- wesbot changed the topic of #wesnoth-dev to: released 1.7.3, announcing "soon" | 74 bugs, 239 feature requests, 10 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090817 00:10:34< silene> ah, i see what you mean; feel free to revert it
20090817 00:10:45< shadowmaster> the bad thing is that it is already relleased
20090817 00:11:40< silene> so what? just remove the documentation from the wiki; nobody will have used it yet
20090817 00:15:57< CIA-62> shadowmaster * r37891 /trunk/data/tools/helptrailer.xhtml: 
20090817 00:15:57< CIA-62> Update helptrailer.xhtml to reflect the site's current footer, in
20090817 00:15:57< CIA-62> particular the copyright statement. Do not blame me for the new trailing
20090817 00:15:57< CIA-62> dot in the support line, it's added for consistency with other current
20090817 00:15:57< CIA-62> static pages.
20090817 00:16:26< CIA-62> shadowmaster * r37892 /trunk/data/campaigns/Under_the_Burning_Suns/_main.cfg: Hide all mainline forest elves from the help index while playing UtBS.
20090817 00:17:46< fabi> silene: no idea what you have done.
20090817 00:20:23< silene> fabi: the second parameter of the tag handler is now a function that executes the previous tag handler; for instance, the following lua line makes everything printed with a big font: wesnoth.register_wml_action("print", function(cfg, old_print_handler) cfg.size=48; old_print_handler(cfg) end)
20090817 00:22:54-!- noy [n=Noy@wesnoth/developer/noy] has quit ["GO, GET TO THE CHOPPAH!!!"]
20090817 00:25:25-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection]
20090817 00:27:52< shadowmaster> sfsaf green text
20090817 00:28:25< shadowmaster> oh, and that guy who makes me want to punch him in the face!
20090817 00:29:20< shadowmaster> pango: is mordante aware that invalid markup can make wesnoth leave the scenario with an invalid WML error?
20090817 00:29:34< shadowmaster> er, fabi.
20090817 00:29:35< CIA-62> silene * r37893 /trunk/src/scripting/lua.cpp: Optimized away intermediate Lua proxy classes.
20090817 00:29:48< CIA-62> silene * r37894 /trunk/src/scripting/lua.cpp: Avoided holes when registering a new action handler.
20090817 00:29:53< CIA-62> silene * r37895 /trunk/src/scripting/lua.cpp: Allowed collection of unused action handlers.
20090817 00:30:00< CIA-62> silene * r37896 /trunk/src/playsingle_controller.cpp: Added a check for a custom end_level before announcing a defeat on time over. (Fix for bug #14140.)
20090817 00:32:13-!- melinath [n=melinath@pool-72-72-200-231.altnpa.east.verizon.net] has quit [Read error: 60 (Operation timed out)]
20090817 00:33:53< fabi> shadowmaster: hiho
20090817 00:39:53-!- silene [n=plouf@AMarseille-251-1-23-175.w83-113.abo.wanadoo.fr] has quit ["Leaving."]
20090817 00:45:55-!- melinath [n=melinath@pool-72-72-200-231.altnpa.east.verizon.net] has joined #wesnoth-dev
20090817 00:49:15-!- ilor [n=user@wesnoth/developer/ilor] has quit []
20090817 00:53:30-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090817 01:04:53-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"]
20090817 01:08:21-!- busfahrer` [n=busfahre@ulmg-5f70c8b3.pool.einsundeins.de] has joined #wesnoth-dev
20090817 01:14:47< CIA-62> cornmander * r37897 /website/stats.wesnoth.org/wesstats/templates/ (10 files): Deleted artifacts from default turbogears installation. More UI work.
20090817 01:17:20-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Read error: 145 (Connection timed out)]
20090817 01:23:53< Soliton> two spambots talking to each other? http://www.wesnoth.org/forum/viewtopic.php?f=13&t=26652
20090817 01:24:11-!- busfahrer` [n=busfahre@ulmg-5f70c8b3.pool.einsundeins.de] has quit ["leaving"]
20090817 01:29:09< CIA-62> fendrin * r37898 /trunk/data/lua/wml-tags.lua: (log message trimmed)
20090817 01:29:09< CIA-62> Wrapped a wml lua tag arround "message" to allows a [show_if] condition.
20090817 01:29:09< CIA-62> example:
20090817 01:29:09< CIA-62> [message]
20090817 01:29:09< CIA-62> id=Kalenz
20090817 01:29:10< CIA-62> message= _ "Landar is here as well"
20090817 01:29:12< CIA-62> [show_if]
20090817 01:33:32< CIA-62> fendrin * r37899 /trunk/changelog: Update changelog with new wml tag show_if in message.
20090817 01:34:49< corn> Soliton: those are some convincing bots
20090817 01:49:57-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit ["night all"]
20090817 01:53:56-!- Chusslove [n=Chusslov@adsl-ppp-2104.yubc.net] has quit [Remote closed the connection]
20090817 02:00:56< CIA-62> fendrin * r37900 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/01_The_Uprooting.cfg: 
20090817 02:00:56< CIA-62> LoW 01: Added more speech for Velon.
20090817 02:00:56< CIA-62> A new song "Casualties of War" in the playlist.
20090817 02:01:57< CIA-62> cornmander * r37901 /website/stats.wesnoth.org/wesstats/ (7 files in 2 dirs): 
20090817 02:01:57< CIA-62> Deleted more artifacts from the default tg install. Added comments to </div> end tags so that they're easier to match. Added a new
20090817 02:01:57< CIA-62> <div id="global"> tag around everything in the body to pick up more formatting from the CSS.
20090817 02:02:52-!- Appleman1234 [n=Appleman@131.181.102.78] has joined #wesnoth-dev
20090817 02:06:48< CIA-62> fendrin * r37902 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/19_Costly_Revenge.cfg: LoW 19: Added caption attributes to the story.
20090817 02:41:15-!- Pk8 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 03:04:06-!- ABCD [n=ABCD@gentoo/contributor/abcd] has quit [Read error: 54 (Connection reset by peer)]
20090817 03:09:47-!- ABCD [n=ABCD@gentoo/contributor/abcd] has joined #wesnoth-dev
20090817 03:15:21-!- ABCD [n=ABCD@gentoo/contributor/abcd] has quit [Read error: 60 (Operation timed out)]
20090817 03:17:07-!- ABCD [n=ABCD@gentoo/contributor/abcd] has joined #wesnoth-dev
20090817 03:23:09-!- Pk8 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Read error: 104 (Connection reset by peer)]
20090817 03:36:54-!- Pk6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 03:37:09-!- Pk6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit]
20090817 03:39:47-!- PK3 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 03:40:20-!- PK3 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit]
20090817 04:08:33-!- Appleman1234 [n=Appleman@131.181.102.78] has quit ["Leaving"]
20090817 04:41:14-!- Ivanovic_ [n=ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20090817 04:58:27-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)]
20090817 04:59:16-!- Ivanovic_ is now known as Ivanovic
20090817 05:14:38< esr> fabi: ping?
20090817 05:38:54-!- PK4 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 05:39:36< CIA-62> esr * r37903 /trunk/data/campaigns/ (12 files in 3 dirs): LoW dialogue polish, and fix undefined image references in TSG.
20090817 05:40:40-!- PK4 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit [Client Quit]
20090817 06:09:15-!- wesbot changed the topic of #wesnoth-dev to: released 1.7.3, announcing "soon" | 73 bugs, 239 feature requests, 10 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090817 06:11:00-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090817 06:16:43-!- allefant [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev
20090817 06:19:02-!- elias [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)]
20090817 06:31:18-!- xchat_sux [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090817 06:40:16-!- PK6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 07:00:56-!- zookeeper [n=l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20090817 07:04:57< CIA-62> jetryl * r37904 /trunk/data/core/images/units/drakes/ (4 files): Some tweaks to the burner firebreath frames.
20090817 07:11:08-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit []
20090817 07:12:12-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev
20090817 07:12:12-!- PK6 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has quit ["Java user signed off"]
20090817 07:19:55< CIA-62> cornmander * r37905 /website/stats.wesnoth.org/wesstats/templates/killview.html: 
20090817 07:19:55< CIA-62> Optimized hex grid generation to not calculate tile geometry for uncolored hexes. Changed the wesnoth copyright into a hyperlink to the
20090817 07:19:55< CIA-62> homepage.
20090817 07:23:31-!- Sapient [n=sapient@adsl-211-176-37.asm.bellsouth.net] has joined #wesnoth-dev
20090817 07:24:28< Sapient> fabi: there?
20090817 07:27:42< Sapient> I think FutureWML which is the future of WML development and core features should be coded in C++
20090817 07:28:04< Sapient> Having a sandbox where UMC authors can extend the language is great
20090817 07:28:51< corn> wesnoth forum currently having problems: http://www.wesnoth.org/forum/
20090817 07:29:04< corn> nevermind, just started working
20090817 07:29:41< Sapient> I don't want the core WML engine to be rewritten in Lua... 
20090817 07:30:21< Sapient> especially if r37898 is any indication of the code quality of such a rewrite
20090817 07:31:50< Sapient> I may not be actively developing currently but I have contributed greatly to it in the past and plan to do so again at some point
20090817 07:32:06< Sapient> So I'd like to have some say on this
20090817 07:33:07< Sapient> If you don't understand C++ then I am willing to answer any questions you might have
20090817 07:33:12< Sapient> later
20090817 07:33:30-!- Sapient [n=sapient@adsl-211-176-37.asm.bellsouth.net] has quit []
20090817 07:45:21-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit ["Quitte"]
20090817 08:07:56-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev
20090817 08:20:32-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20090817 08:24:55-!- knotwork__ [n=markm@hlfxns01bbg-142177232053.pppoe-dynamic.ns.aliant.net] has quit [Read error: 110 (Connection timed out)]
20090817 08:25:15-!- knotwork__ [n=markm@hlfxns01bbg-142177232072.pppoe-dynamic.ns.aliant.net] has joined #wesnoth-dev
20090817 08:40:13< CIA-62> jetryl * r37906 /trunk/data/core/images/units/drakes/ (7 files): Some tweaks to the burner firebreath frames.
20090817 08:46:40-!- EdB [n=edb@79.88.117.151] has joined #wesnoth-dev
20090817 08:52:51-!- stikonas [n=and@ctv-213-164-123-205.vinita.lt] has joined #wesnoth-dev
20090817 08:53:11-!- daxion_ [n=jochen@dslb-088-069-162-064.pools.arcor-ip.net] has joined #wesnoth-dev
20090817 09:22:16-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev
20090817 09:22:21< euschn> hi
20090817 09:24:51-!- Appleman1234 [n=Appleman@131.181.102.78] has joined #wesnoth-dev
20090817 09:37:48-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090817 09:39:02-!- Chusslove [n=Chusslov@adsl-ppp-2133.yubc.net] has joined #wesnoth-dev
20090817 09:41:02-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit [Remote closed the connection]
20090817 09:44:36-!- ilor [n=user@wesnoth/developer/ilor] has quit []
20090817 09:51:47-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has joined #wesnoth-dev
20090817 09:53:05< YogiHH> hello
20090817 09:56:56< Ivanovic> hi YogiHH
20090817 10:05:26-!- EdB [n=edb@79.88.117.151] has quit [Remote closed the connection]
20090817 10:16:56< Ivanovic> cjhopman, corn, crab_, deekay, euschn, ilor: only less than 10h left till the official pencils down date
20090817 10:17:27< Ivanovic> so please make sure to commit your work and prepare yourself mentally to "soon" fill out the final reports
20090817 10:17:35< Ivanovic> those should be available from tomorrow on
20090817 10:18:53< Ivanovic> boucman, dfranke, mordante, Sapient, Sirp, YogiHH: tommorrow start the final evals, you got exactly 7 days to fill them though i would welcome it if you have at least a rough version filled out early to make sure that it is not forgotten
20090817 10:19:31< YogiHH> yes sir, captain sir ;-)
20090817 10:20:00< Ivanovic> boucman, dfranke, mordante, Sapient, Sirp, YogiHH, cjhopman, corn, crab_, deekay, euschn, ilor: if there are any problems with the final reports, please ping me so that i can somehow take care of it (either by talking to leslie regarding student reports or by filling them myself for mentors, though i prefer *you* doing the stuff ;) )
20090817 10:23:55< fabi> esr: pong
20090817 10:27:07-!- loonybot [n=loonybot@79.139.138.234] has joined #wesnoth-dev
20090817 10:27:54-!- loonycyborg [n=sergey@79.139.138.234] has joined #wesnoth-dev
20090817 10:37:43-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev
20090817 10:43:42-!- Blarumyrran [n=chatzill@62.65.197.117] has joined #wesnoth-dev
20090817 10:55:57-!- Ivanovic_ [n=ivanovic@dtmd-4db2aa07.pool.einsundeins.de] has joined #wesnoth-dev
20090817 10:56:28-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Nick collision from services.]
20090817 10:56:38-!- Ivanovic_ is now known as Ivanovic
20090817 11:00:55-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090817 11:03:34-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090817 11:15:06-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."]
20090817 11:16:09-!- fabi [n=fabi@wesnoth/developer/fendrin] has quit [Remote closed the connection]
20090817 11:31:20-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20090817 11:49:44-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090817 12:00:14-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit [Remote closed the connection]
20090817 12:09:15-!- wesbot changed the topic of #wesnoth-dev to: released 1.7.3, announcing "soon" | 74 bugs, 240 feature requests, 10 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090817 12:11:02-!- daxion_ [n=jochen@dslb-088-069-162-064.pools.arcor-ip.net] has quit ["Ex-Chat"]
20090817 12:29:45-!- Chusslove [n=Chusslov@adsl-ppp-2133.yubc.net] has quit [Remote closed the connection]
20090817 12:31:18-!- daxion_ [n=jochen@dslb-088-069-162-064.pools.arcor-ip.net] has joined #wesnoth-dev
20090817 12:32:12-!- mordante [n=mordante@87.215.201.26] has joined #wesnoth-dev
20090817 12:33:22< mordante> shadowmaster, I'm not aware pango can still cause a problem with invalid markup, at least not via the ::ttext class
20090817 12:33:46< mordante> I added a fix for that recently (somewhere between 1.7.2 and 1.7.3)
20090817 12:35:54< mordante> Ivanovic, I planned to work on the gsoc review this evening
20090817 12:37:05< mordante> daxion_, I spoke with kitty yesterday and she still has to do the writing of drake script manually
20090817 12:38:10< daxion_> thank you mordante for the effort. I was thinking of probably write a small programm to generate Drak script pictures out of an input text
20090817 12:38:38< daxion_> I'll guess I'll have to talk to kitty myself, when I find her
20090817 12:39:15< mordante> she wants to put it in a real font eventually, but if you want to write a small tool to do it for the time being that would be cool
20090817 12:42:56-!- Blarumyrran [n=chatzill@62.65.197.117] has quit [Remote closed the connection]
20090817 12:43:24< mordante> off for lunch
20090817 12:44:09< daxion_> I'm not sure how she can put the Drake ceremonial particle script into a font
20090817 12:47:37< mordante> me neither, but I've no experience with creating fonts
20090817 12:47:50< mordante> guess you'll need to ask her
20090817 12:49:54< daxion_> *nods*
20090817 12:51:39-!- ettin [n=jorda@wesnoth/developer/ettin] has joined #wesnoth-dev
20090817 12:55:43-!- ettin_ [n=jorda@wesnoth/developer/ettin] has quit [Read error: 145 (Connection timed out)]
20090817 13:02:16< CIA-62> thespaceinvader * r37907 /trunk/data/core/images/units/drakes/ (86 files): TC fixes on all Drake Glider line frames.
20090817 13:02:50< thespaceinvader> daxion_: i think Kitty designed two drake fonts - one that's ceremonial, which cannot easily be fontified, and one that is for every day, which functions more like the latin alphabet, and could be turned into a font
20090817 13:04:01< daxion_> Yes I am aware of that. No point in making a programm for an easily fontified script :)
20090817 13:04:59< daxion_> But somehow I personally really like the Idea of the Drake particles
20090817 13:16:30-!- Chusslove [n=Chusslov@212.124.171.220] has joined #wesnoth-dev
20090817 13:16:42< Crab_> mordante: what's better for finding widgets ?    NEW_find_widget<T>   or  window.find_widget  ?
20090817 13:19:02-!- euschn [n=chatzill@wesnoth/developer/euschn] has joined #wesnoth-dev
20090817 13:38:22< Soliton> YogiHH: what's the idea behind the dummy_unit?
20090817 13:41:36< YogiHH> Soliton: Hrmpf, i did know that not too long ago, but forgot about it :/
20090817 13:43:52< Soliton> maybe should have put a comment in the code explaining it. ;-)
20090817 13:46:13< Soliton> i mean there is a comment mentioning unit types of other eras but it doesn't tell me much.
20090817 13:46:56< mordante> Crab_, NEW_find_widget<T> twindow::find_widget will be slowly phased out
20090817 13:47:32< Crab_> mordante: ok. another question: how to close the dialog window from a button callback ?
20090817 13:47:38< YogiHH> Soliton: If in the load_game dialog you have a save of an era different to the currently loaded one, you might request info for a unit type that is not known atm
20090817 13:48:35< YogiHH> Soliton: I think the dummy unit type is just there to prevent that peace of code (and maybe others) to get into trouble because of a null unit_type
20090817 13:48:43-!- fendrin [n=fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20090817 13:50:22< YogiHH> Soliton: It's also used for emergency path calculation and move_unit_fake. I suspect that in this case the unit_type is not relevant or would even prevent that code to work.
20090817 13:50:44< Soliton> well, why does that code not check if the unit_type was found because on the other hand the dummy_unit causes code to fail in unhelpful ways because it assumes it just needs to check for end() to figure out whether the unit_type was found.
20090817 13:51:39< Soliton> and what is the point of sometimes returning dummy_unit and sometimes end()?
20090817 13:51:58< YogiHH> Soliton: I agree with you and i considered it an ugly hack, but back then i was concentrating on other stuff
20090817 13:52:18 * YogiHH shrugs
20090817 13:52:19< Soliton> ok.
20090817 13:54:02< YogiHH> Soliton: I remember that i splitted the dummy unit into its own unit_map because there were many pieces of code (like ingame help, i think) that were not able to deal with it.
20090817 13:54:03-!- allefant [n=allefant@allegro/developer/allefant] has quit [Read error: 104 (Connection reset by peer)]
20090817 13:54:17-!- Chusslove [n=Chusslov@212.124.171.220] has quit [Remote closed the connection]
20090817 13:54:34< mordante> Crab_, you can't do it directly you need to call twindow::set_retval() which handles it
20090817 13:55:11< Crab_> mordante: so, if I call twindow::set_retval() , the dialog will close eventually ?
20090817 13:55:39< Soliton> sounds like the whole idea doesn't make much sense. :-/
20090817 13:56:16< mordante> Crab_, oh wait I already added close() as well, but set_retval also sets the return value of the dialog
20090817 13:56:29< Crab_> mordante: ok, thanks
20090817 13:56:41< mordante> without that call the window has no way to return a status value
20090817 13:57:11< mordante> so set_retval is the best solution and yes it closes the window shortly afterwards
20090817 13:57:43< mordante> (internally it calls close())
20090817 13:59:49< Soliton> YogiHH: can you point me to some code that requires the dummy unit?
20090817 14:03:19< YogiHH> Soliton: i would have to dig into it a little deeper for that and i am at work right now. If you can wait, i can do it tonight.
20090817 14:04:10-!- isaac_ [n=isaac@233.Red-83-40-20.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20090817 14:04:29< Soliton> ok, no problem.
20090817 14:09:07< Soliton> can you use move_unit_fake without a unit type?
20090817 14:09:55< Soliton> i mean it has to know the image to use etc?
20090817 14:10:27-!- isaac [n=isaac@debian/developer/isaac] has quit [Nick collision from services.]
20090817 14:10:29-!- isaac_ is now known as isaac
20090817 14:11:06< Soliton> zookeeper: ^
20090817 14:11:10-!- allefant [n=allefant@allegro/developer/allefant] has joined #wesnoth-dev
20090817 14:13:30-!- daxion_ [n=jochen@dslb-088-069-162-064.pools.arcor-ip.net] has quit ["Ex-Chat"]
20090817 14:14:07< stikonas> Soliton: maybe you have some time now to apply http://stikonas.homelinux.org/files/tutorial.diff ? zookeeper reviewed it yesterday and said that it seems ok.
20090817 14:16:02< CIA-62> shadowmaster * r37908 /trunk/ (7 files in 4 dirs): 
20090817 14:16:02< CIA-62> Revert r37729, r37731, r37837 ([part] caption= in storyscreens) and
20090817 14:16:02< CIA-62> replaced with the mainline CAPTION macro. Converted existing mainline
20090817 14:16:02< CIA-62> WML.
20090817 14:16:02< CIA-62> Also, replaced the former color (*green*!?) with the usual color used in
20090817 14:16:03< CIA-62> character messages.
20090817 14:17:48< Crab_> stikonas: are you sure that the part with "A splendid idea. You can recruit two units if you return" is ok in the diff ?
20090817 14:18:10< Crab_> stikonas: you add 2 such messages, remove 0
20090817 14:18:45< stikonas> oh, thanks for this one
20090817 14:18:58< stikonas> I'll fix it quickly
20090817 14:19:00< Crab_> np
20090817 14:20:17< stikonas> Cran_: I fixed it
20090817 14:20:24< stikonas> Crab_: ^^
20090817 14:21:18< stikonas> and the part with traits is correct because it is used only by one female elf
20090817 14:21:49< stikonas> Crab_: maybe you can look through the rest part and apply then
20090817 14:22:30< Crab_> stikonas: yes, I remember that from your yesterday's discussion with zookeeper. Yet, I'm busy debugging now, so I can apply it only in ~10 h, in the evening (unless someone gets to it first)
20090817 14:22:44< stikonas> don't bother then
20090817 14:22:47< Crab_> ok
20090817 14:23:57-!- xchat_sux [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090817 14:25:01< zookeeper> Soliton, no, you can't
20090817 14:25:12< CIA-62> shadowmaster * r37909 /trunk/changelog: 
20090817 14:25:12< CIA-62> Mention r37908 in changelog. Required since there was a changelog entry
20090817 14:25:12< CIA-62> in 1.7.3 for [part]caption=
20090817 14:25:26-!- Chusslove [n=Chusslov@adsl-ppp-1161.yubc.net] has joined #wesnoth-dev
20090817 14:27:25< Soliton> ok, i guess that is rather another part of the code that will break if the dummy_unit is returned.
20090817 14:31:22< Soliton> i can't really understand how the dummy_unit helps anything if it's just an empty unit type anyway.
20090817 14:31:43< Soliton> as soon as you try to use it it's just going to fail?
20090817 14:33:58< Soliton> i guess i'll just remove it and see what breaks...
20090817 14:35:30< zookeeper> isn't it used behind the scenes in some damage calculations or that kind of stuff?
20090817 14:36:16< shadowmaster> it is somehow used by the MUF code event if a unit type is specified and exists
20090817 14:36:32< shadowmaster> for path calculation
20090817 14:36:50< Soliton> i think you're talking about something else.
20090817 14:37:31< shadowmaster> oh yeah, sorry! it is a unit name dummy_unit, not "the" dummy_unit
20090817 14:37:34< Soliton> a variable there is called dummy_unit since that's kind of what it is but it's not the dummy_unit you get returned for not finding a unit type.
20090817 14:37:36< shadowmaster> *named
20090817 14:38:14< Soliton> as i said you can't really use that dummy_unit for anything useful since it contains no data!
20090817 14:39:03< Soliton> and if you try you'll most likely get unhelpful error messages saying there is a unit with an empty type.
20090817 14:39:31 * shadowmaster wonders by the way why the indentation in the WML handlers of game_events.cpp looks screwed up.
20090817 14:41:00< esr> fabi: I did a dalog pass on LoW.
20090817 14:42:20-!- thespaceinvader_ [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has joined #wesnoth-dev
20090817 14:45:14-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Nick collision from services.]
20090817 14:45:19-!- thespaceinvader_ is now known as thespaceinvader
20090817 14:46:11< Soliton> starting a local mp game i get this when ending turn for the first side: error scripting/lua: ...ing/projects/wesnoth-svn/trunk/data/lua/wml-tags.lua:183: attempt to perform arithmetic on field 'amount' (a string value)
20090817 14:46:15< Soliton> stack traceback: ...ing/projects/wesnoth-svn/trunk/data/lua/wml-tags.lua:183: in function <...ing/projects/wesnoth-svn/trunk/data/lua/wml-tags.lua:181>
20090817 14:47:48< Soliton> infact i get it each end turn it seems.
20090817 14:50:20< shadowmaster> I've been getting Lua errors from a non-Lua campaign too. Is Lua being used for normal WML tags?
20090817 14:52:21< YogiHH> euschn: when should we have our final meeting, tonight or later on this week?
20090817 14:57:46< euschn> YogiHH: I would prefer wednesday again
20090817 15:00:06< AI0867> shadowmaster: yes, [message] and [show_objectives], possibly more
20090817 15:00:37< shadowmaster> ugh.
20090817 15:01:36< euschn> YogiHH: if wednesday is not possible for you, tuesday or friday (evening) would be ok for me aswell
20090817 15:02:22< shadowmaster> it's basically  http://wesnoth.pastebin.com/d229b1224 in amounts enough to fill a 800 px-tall game area
20090817 15:02:38< shadowmaster> pretty darn confusing.
20090817 15:03:48< YogiHH> euschn: ok, wednesday is fine
20090817 15:03:55< euschn> great
20090817 15:03:58-!- xchat_sux is now known as Elvish_Pillager
20090817 15:08:04< Crab_> mordante: note about tbutton : 'void (*callback) (twidget*)' callbacks are not convenient to use - because boost::bind returns not a simple function pointer.  Is it planned for 'void (*callback) (twidget*)' to be someday converted into using boost::function ?
20090817 15:08:40-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090817 15:08:54< shadowmaster> callback declarations are ugly without typedefs
20090817 15:09:42-!- BenUrban [n=benurban@unaffiliated/benurban] has quit ["Power failu"]
20090817 15:18:40< Crab_> shadowmaster: declarations being ugly is not a problem, but the inability to use boost::bind with those tbutton callbacks is. (leads to me doing certain ugly hacks)
20090817 15:25:00-!- Elvish_Pillager [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 110 (Connection timed out)]
20090817 15:25:44< Elvish_Pillage2> does [allow_undo] work inside menu item commands?
20090817 15:26:41< Soliton> how do i get a save that shows a unit in the load dialog?
20090817 15:33:44< zookeeper> EP, i think yes, but it leads to OOS in MP
20090817 15:33:52< Elvish_Pillage2> :/
20090817 15:34:25< zookeeper> Soliton, err, no idea. black magic?
20090817 15:34:56< zookeeper> i mean of course you get one by starting a campaign, but no idea how it actually works.
20090817 15:36:52< mordante> Crab_, yes, it will be converted to boost::function, when I wrote this code I didn't know about boost::function and boost::bind
20090817 15:37:02< Crab_> mordante: good, thanks
20090817 15:37:13< mordante> well it annoys me now as well
20090817 15:37:54< mordante> ilor already use boost::function for some callbacks, but I want to think a bit more about a generic framework
20090817 15:38:08< shadowmaster> mordante: do you think it will be eventually possible to avoid recompiling all dialogs' code when any of their headers get changed?
20090817 15:38:18< mordante> that framework will also probably act more signal based
20090817 15:38:50< Soliton> zookeeper: the problem is i don't.
20090817 15:38:55< mordante> shadowmaster, only some headers do that, eg widget.hpp
20090817 15:39:08< shadowmaster> uhm, then someone must have been modifying those quite a lot lately.
20090817 15:39:26< zookeeper> Soliton, oh, right. well, i still have no idea.
20090817 15:39:57< mordante> lately silene removed a lot of unused functions, and some of them in rather often included headers
20090817 15:40:04< shadowmaster> isn't it awesome to fix a bug just to have it appear again months later?
20090817 15:40:44< mordante> but that's why I started to split things in more smaller units in the hope to avoid unneeded recompilation
20090817 15:41:57< mordante> shadowmaster, depends on the definition of awesome :-P
20090817 15:42:33< shadowmaster> although it seems the one I was targetting got fixed again while I wasn't able to download commits
20090817 15:43:13< shadowmaster> I'm not getting the player's leader unit displayed in the load game dialog either though.
20090817 15:43:58< shadowmaster> it used to be displayed when a) it existed and b) it was a mid-game saved game and c) it didn't have snapshot=no specified or fog or shroud active for side 1
20090817 15:44:13< Soliton> i see the image path for the leader unit is saved in the save_index so i guess the game doesn't actually have to look up the unit type for anything.
20090817 15:44:31< Soliton> still doesn't show any image for me on any save though.
20090817 15:45:49< YogiHH> Soliton: something with showing unit images seems badly broken. If you use the new load_game dialog (--new-widgets), it should work
20090817 15:46:06< Soliton> yeah, just about to try that.
20090817 15:46:12< YogiHH> Soliton: The layout needs some work, however
20090817 15:46:17< shadowmaster> mordante: oh, btw, will we eventually have proper radio button images/widgets to replace the checkbox images/widgets on gui2?
20090817 15:46:34< Soliton> YogiHH: ok, works there and no issues without the dummy_unit.
20090817 15:46:44< YogiHH> nice
20090817 15:47:02< shadowmaster> YogiHH: it doesn't use image::get_image()?
20090817 15:47:11< shadowmaster> or is it just not applying TC at all?
20090817 15:47:22< Soliton> i get the credits though when pressing escape. :-P
20090817 15:47:46< Soliton> seems like that is a general feature of the new gui though.
20090817 15:48:07< YogiHH> shadowmaster: no idea, just copied the code from elsewhere and did some modifications to show unit images again
20090817 15:48:37< YogiHH> Soliton: but cancel button works, no?
20090817 15:48:40< shadowmaster> then I guess it's the latter. I'm getting a really gay Galas in the list.
20090817 15:48:47< Soliton> YogiHH: yes.
20090817 15:48:48< YogiHH> hehe
20090817 15:49:18 * YogiHH is a mouse fanatic, that's why he never spots keyboard problems ;-)
20090817 15:50:12< Soliton> any other ideas where the dummy_unit might be needed?
20090817 15:50:38< Soliton> and i still don't really understand how it helps anything if it's an empty unit type.
20090817 15:51:16< Crab_> Soliton: just remove it and test properly for .end() in all places which get unit type...
20090817 15:51:25< Crab_> Soliton: and let that old hack die..
20090817 15:51:57< Soliton> yeah, i suppose.
20090817 15:52:41< YogiHH> Soliton: I can't tell you exactly, but iirc it did the distinction between "the unit_type key is not needed" and "the unit_type key should be there but is not found"
20090817 15:53:24< mordante> shadowmaster, depends on our artists :-P but I haven't added code for radio groups yet but of course the toggle button is meant for both check and radio button
20090817 15:54:12< mordante> Soliton, FYI the credits bug has already been reported
20090817 15:54:13-!- ABCD [n=ABCD@gentoo/contributor/abcd] has quit [Read error: 54 (Connection reset by peer)]
20090817 15:57:09-!- euschn [n=chatzill@wesnoth/developer/euschn] has quit [Remote closed the connection]
20090817 15:58:33-!- ABCD [n=ABCD@gentoo/contributor/abcd] has joined #wesnoth-dev
20090817 16:01:32-!- Appleman1234 [n=Appleman@131.181.102.78] has quit ["Leaving"]
20090817 16:10:58-!- Chusslove [n=Chusslov@adsl-ppp-1161.yubc.net] has quit [Remote closed the connection]
20090817 16:12:02-!- ABCD [n=ABCD@gentoo/contributor/abcd] has quit [Read error: 60 (Operation timed out)]
20090817 16:12:09-!- ABCD [n=ABCD@gentoo/contributor/abcd] has joined #wesnoth-dev
20090817 16:22:10< Crab_> mordante: is there a pango string escape function ?
20090817 16:22:36< Crab_> mordante: i.e., if parts of my string are user supplied and may contain pango markup
20090817 16:22:45< Crab_> which I don't want to show
20090817 16:27:57-!- melinath [n=melinath@pool-72-72-200-231.altnpa.east.verizon.net] has quit [Read error: 60 (Operation timed out)]
20090817 16:29:58-!- daxion_ [n=jochen@dslb-088-068-064-167.pools.arcor-ip.net] has joined #wesnoth-dev
20090817 16:30:54< CIA-62> dragonking * r37910 /trunk/src/ (4 files in 2 dirs): Code cleanup, obsolete code removal
20090817 16:34:03-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20090817 16:36:10-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 104 (Connection reset by peer)]
20090817 16:38:48< mordante> Crab_, yes but hidden in gui/widgets/control.cpp called escape_string, if you want to give it external linkage, better move it to gui/auxiliary/helper.?cc
20090817 16:39:25< Crab_> ok, I'll do so, but a bit later
20090817 16:39:30< Crab_> thanks
20090817 16:40:41< mordante> np
20090817 16:44:30-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090817 16:53:08-!- stikonas [n=and@ctv-213-164-123-205.vinita.lt] has joined #wesnoth-dev
20090817 16:54:15-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev
20090817 16:55:45-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20090817 16:58:28-!- YogiHH [i=d4ca9d15@wesnoth/developer/yogihh] has left #wesnoth-dev []
20090817 17:02:21-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev
20090817 17:02:28-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev
20090817 17:02:32-!- Noyga is now known as Avnoh|Aybabtu|cr
20090817 17:02:36-!- Avnoh|Aybabtu|cr [n=lame-z@wesnoth/developer/noyga] has left #wesnoth-dev ["Quitte"]
20090817 17:06:27< CIA-62> crab * r37911 /trunk/ (22 files in 9 dirs): Formula AI Debugger (uses --new-widgets )
20090817 17:06:44< shadowmaster> awesome, my create unit gui2 dialog causes an assertion failure
20090817 17:07:36< Crab_> deekay: you might want do play with ^,  by launching with   " ./wesnoth --log-debug='ai/debug/formula' --new-widgets -d -t formula .    ", and trying formula_ai console formula, such as      nearest_loc(nearest_loc(my_leader.loc,loc(11,21)),unit_moves(my_leader.loc))
20090817 17:07:45< Crab_> s/do play/to play
20090817 17:07:52-!- mordante [n=mordante@87.215.201.26] has quit ["Leaving"]
20090817 17:09:42< deekay> Crab_: Will try, compiling now :)
20090817 17:12:00< Crab_> deekay: feedback is appreciated. I'll add more features soon.
20090817 17:17:42< deekay> Crab_: Looks *really* neat
20090817 17:18:13< Crab_> deekay: thanks
20090817 17:18:18< deekay> Crab_: But... a bit slow and I just managed to make it segfault 
20090817 17:18:49< Crab_> deekay: dev version, yes.
20090817 17:18:59< Crab_> deekay: how-to-reproduce the segfault ?
20090817 17:19:00< deekay> Crab_: I executed  filter( map.terrain, defense_on(my_leader, loc) )
20090817 17:19:21< deekay> Crab_: Each step seemed a bit slow (1s-2s on my machine)
20090817 17:19:39< deekay> And later I wanted to quit dialog, it hand for about 15s and then crashed
20090817 17:20:07< Crab_> deekay: ok, I'll look into it. note, that when debugger is not enabled, it has no-to-little impact on performance
20090817 17:20:43< deekay> Good :)
20090817 17:21:02< Crab_> deekay: the segfault is probably because of I'm abusing GUI stuff to heavily ;)
20090817 17:21:17< deekay> hehe
20090817 17:21:20< deekay> Possible :)
20090817 17:21:35< deekay> Well, it's like you said dev version
20090817 17:21:52< Crab_> deekay: I doubt someone expected the GUI dialog to hold several megabytes of info :)
20090817 17:21:58< deekay> Still it looks really neat :)
20090817 17:22:06< deekay> hehe
20090817 17:22:16< Crab_> deekay: I'll try to get around  such limitations
20090817 17:22:30< deekay> ok :)
20090817 17:22:51< Crab_> deekay: ok, if any feature suggestions - post them. I'll return in a few hours
20090817 17:23:11< deekay> Sure :)
20090817 17:24:31-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit [Remote closed the connection]
20090817 17:25:41< Crab_> deekay: yes, got a backtrace. it's gui code hitting a gui limitation, and failing a VALIDATE
20090817 17:25:53-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090817 17:27:08< deekay> Crab_: You pushed wesnoth to its limits. ;p
20090817 17:29:27< Ivanovic> hi
20090817 17:36:52< deekay> hi Ivanovic 
20090817 17:37:26< Ivanovic> hi deekay
20090817 17:37:40< Ivanovic> mordante: no idea if the form for the final eval will already be done this evening
20090817 17:38:51-!- shadowmaster_ [n=ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20090817 17:42:15-!- shadowmaster_ [n=ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit]
20090817 17:46:11< CIA-62> dragonking * r37912 /trunk/src/callable_objects.cpp: Add usage info to unit and unit_type callables
20090817 17:48:29< CIA-62> silene * r37913 /trunk/data/lua/wml-tags.lua: Temporarily reverted r37898, as [message] requires location data, which are currently lost in the process. While uncommon, it may cause some event messages to not be displayed.
20090817 18:03:26-!- ilor [n=user@wesnoth/developer/ilor] has quit []
20090817 18:22:27-!- daxion_ [n=jochen@dslb-088-068-064-167.pools.arcor-ip.net] has quit ["Ex-Chat"]
20090817 18:30:35< CIA-62> silene * r37914 /trunk/src/scripting/lua.cpp: Kept queued events around so that location entities are properly propagated.
20090817 18:30:39< CIA-62> silene * r37915 /trunk/data/lua/wml-tags.lua: Reenabled r37898 now that entities are preserved. Cleaned the code a bit.
20090817 18:34:10< Soliton> silene: http://nopaste.com/p/aDWshUR8G  any idea why such an event would result in defeat?
20090817 18:34:42< Soliton> silene: that event also seemed to kill all units except the killer iirc.
20090817 18:36:02< shadowmaster> Soliton: [filter] is not interpreted there. Its contents should go in [kill]
20090817 18:37:11< Soliton> ah, i suppose the killing is also the cause of the defeat.
20090817 18:37:23< shadowmaster> to the game it just looks like a [kill][/kill] (kill everyone)
20090817 18:37:31< shadowmaster> no idea why there's one unit left though.
20090817 18:42:11-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit [Read error: 60 (Operation timed out)]
20090817 18:43:40-!- crimson_penguin [n=ben@64.201.60.211] has joined #wesnoth-dev
20090817 18:44:46-!- YogiHH [n=chatzill@c146189.adsl.hansenet.de] has joined #wesnoth-dev
20090817 18:53:13-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev
20090817 18:59:12-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090817 19:02:29-!- Chusslove [n=Chusslov@adsl-ppp-3251.yubc.net] has joined #wesnoth-dev
20090817 19:06:12< stikonas> zookeeper: would you have some time now to apply patch http://stikonas.homelinux.org/files/tutorial.diff ?
20090817 19:11:16-!- giusef [n=giusef@unaffiliated/giusef] has quit [Remote closed the connection]
20090817 19:17:37< CIA-62> dragonking * r37916 /trunk/data/ai/formula/ (4 files in 2 dirs): Add recruitment.fai to /ai/formula/lib, improve unit choosing algorithm
20090817 19:18:56-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20090817 19:20:20< stikonas> silene: maybe you can commit my patch http://stikonas.homelinux.org/files/tutorial.diff ? I have a bad luck upstreaming it :(.
20090817 19:25:09-!- mordante [n=mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20090817 19:27:29< corn> mordante: is introducing cairo as a new dependency OK to get graph support in wesnoth (specifically curve/line drawing)
20090817 19:28:02< mordante> corn, we already depend on cairo due to pangocairo
20090817 19:28:25< corn> ah, right
20090817 19:28:30< mordante> what do you want to draw?
20090817 19:28:44< corn> graphs such as gold over time, units over time
20090817 19:29:08< corn> they typically appear in other strategy games at the end of the game, as a summary
20090817 19:29:10< mordante> drawn in game or on the web site?
20090817 19:29:14< corn> in-game
20090817 19:29:28< silene> stikonas: sure; i just won't commit the part where the string is constructed on the fly, since it is broken anyway
20090817 19:30:11< corn> mordante: so it's ok to start putting in cairo headers into wesnoth src files?
20090817 19:32:21< mordante> it's a bit of a tricky question, does it add a new dependency or not...
20090817 19:32:33< mordante> but it doesn't
20090817 19:32:47< corn> it probably adds a new dependency for developers looking to compile
20090817 19:32:52< mordante> pango/pangocairo.h already pulls cairo.h in
20090817 19:32:53< corn> libcairo-dev (if I had to guess)
20090817 19:32:55< corn> oh
20090817 19:33:07< corn> ok, then it should be safe
20090817 19:33:35< mordante> yup, but it might be a good idea to mention it on the dev-ml and in the release notes as well
20090817 19:33:41< corn> ok
20090817 19:33:54< mordante> it might be some packagers want to update their dependencies
20090817 19:34:12< mordante> oh and for that matter INSTALL as well
20090817 19:34:19< corn> ok
20090817 19:34:31< CIA-62> silene * r37917 /trunk/data/campaigns/tutorial/scenarios/ (1_Tutorial.cfg 2_Tutorial.cfg): Gendrified some parts of the tutorial for internationalization purposes. (Patch by stikonas.)
20090817 19:34:40< loonycyborg> Probably not since wesnoth already depends on cairo.
20090817 19:35:11< mordante> also I like to discuss those changes in a bit more detail
20090817 19:35:15< stikonas> silene: thanks
20090817 19:35:29< corn> mordante: my proposed changes?
20090817 19:35:43< mordante> since I want to convert all code to use the new widgets I like to have this included in the new widget code
20090817 19:35:50< mordante> corn, yes
20090817 19:35:52< corn> ok, I was planning on that
20090817 19:36:07< loonycyborg> iirc you need to make several cairo calls in order to use pango's cairo backend so wesnoth already depends on it in all senses.
20090817 19:36:09< silene> does pango depends on cairo on all the platforms?
20090817 19:36:48< mordante> we depend on pangocairo
20090817 19:37:09< mordante> loonycyborg, yes we do including the cairo.h header
20090817 19:37:32< corn> I actually have very little experience in gui design... I assume that graphs would be a new type of widget?
20090817 19:38:18-!- Valkier [n=karasawa@c-71-225-240-156.hsd1.pa.comcast.net] has joined #Wesnoth-dev
20090817 19:38:37-!- Noyga [n=noyga@wesnoth/developer/noyga] has joined #wesnoth-dev
20090817 19:38:48< mordante> probably yes, but at the moment the widgets depend on hand coded routines
20090817 19:38:51-!- Noyga [n=noyga@wesnoth/developer/noyga] has left #wesnoth-dev ["Quitte"]
20090817 19:39:10< mordante> so I guess we need a kind of free drawing canvas widget
20090817 19:39:30< mordante> but also if we move the code to cairo, I prefer to convert to existing code as well
20090817 19:39:52< corn> which?
20090817 19:40:00< mordante> (and I certainly don't want to handcode arc algorithms)
20090817 19:40:12< mordante> the code in gui/auxiliary/canvas.?pp
20090817 19:41:40< corn> ah
20090817 19:41:51< corn> it is used by all of the gui code to do drawing?
20090817 19:42:07< mordante> by all gui2 code 
20090817 19:42:14< corn> ok
20090817 19:42:46< mordante> corn, http://cairographics.org/SDL/ as you can see it's rather trivial to draw on a SDL surface with cairo
20090817 19:42:58< corn> yep, as long as the SDL surface has no alpha
20090817 19:43:28< mordante> IIRC I wrote a conversion routine for that
20090817 19:43:36< corn> cairo -> sdl?
20090817 19:45:08-!- Sirp [i=97c1dc1c@wesnoth/developer/dave] has joined #wesnoth-dev
20090817 19:45:10< Sirp> hi
20090817 19:45:15< mordante> hi Sirp 
20090817 19:45:25< corn> hi
20090817 19:45:27< Sirp> hi mordante 
20090817 19:45:29< mordante> corn, yes decode_pixel() in src/text.cpp
20090817 19:46:35< corn> mordante: so if cairo and sdl can already work together easily, what do you want to move?
20090817 19:46:48< mordante> not sure how much it will slow down the code, but we can test the alpha value before decoding
20090817 19:46:57< corn> draw_line()?
20090817 19:48:44< Ivanovic> corn: so what is the status of stats.wesnoth.org?
20090817 19:48:52< Ivanovic> have you already had a look at it with Rhonda?
20090817 19:49:03< mordante> yes draw_line can be replaced by a cairo call and we can also remove put_pixel
20090817 19:49:23< corn> Ivanovic: I am not at my home machine right now, I PMed rhonda requesting him to add a new ssh key early today but he hasn't responded
20090817 19:49:45< Ivanovic> ah, okay
20090817 19:50:57< silene> mordante: if you need to speed up decode_pixel (by a large amount); the usual way is to store all the reciprocals in an array
20090817 19:51:30< mordante> and use that as a lookup table
20090817 19:51:35< silene> yes
20090817 19:51:42< mordante> yup that would do the trick
20090817 19:51:46< corn> mordante: ok. so draw_line can be replaced, trectangle::draw(), and put_pixel removed
20090817 19:51:50< silene> you replace the division by a multiplication
20090817 19:52:01< corn> (trectangle::draw() replaced)
20090817 19:52:10< mordante> which is at least on x86 much faster
20090817 19:53:25< mordante> corn, well if we go this path all drawing primitives need to be replaced by cairo
20090817 19:53:35< silene> not just on x86, on any processor with a hardware divisor (funnily enough, division is only slow on processors with hardware for it; on processors where it is emulated in software, it is usually fast)
20090817 19:54:12< corn> mordante: where are the primitives defined?
20090817 19:54:23< mordante> corn, and I need to have a look, I think the ttext is only used for the canvas if so it can skip the conversion and do it in the canvas
20090817 19:54:57< corn> ok
20090817 19:55:26< mordante> corn, draw_line and put_pixel are the primitives, basically the entire class needs to use cairo for drawing, mixing cairo and SDL alpha will be impossible
20090817 19:55:45< mordante> also need to have a look at the image drawing there
20090817 19:55:58< mordante> silene, funny, didn't know that
20090817 19:56:21< corn> ok. I will see if I make enough changes to 'make it work' today
20090817 20:00:38< mordante> shadowmaster, do you use the new ttext renderer class in the story screens?
20090817 20:01:11< shadowmaster> mordante: yes
20090817 20:01:34< mordante> ok
20090817 20:01:43< shadowmaster> the bug I mentioned seemed to come from the objectives dialog, completely unrelated. I'll tell you when I know better what's wrong with it
20090817 20:01:54< mordante> ok
20090817 20:02:16-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit [Read error: 113 (No route to host)]
20090817 20:02:25< shadowmaster> mordante: can GUI2 widgets be used without a parent window btw?
20090817 20:02:42< mordante> corn, in that case you need to add an extra render function so it can return an SDL surface without "fixing" the alpha
20090817 20:03:13< mordante> shadowmaster, it should be possible, not sure how feasible it is, where do you want to use it?
20090817 20:03:22< shadowmaster> storyscreens of course.
20090817 20:03:49< shadowmaster> I'm afk now, traveling.
20090817 20:03:53< mordante> can you give more information about how you want to use it?
20090817 20:04:03< mordante> ok then later
20090817 20:04:19< shadowmaster> basically replacing those two GUI1 (GUI0 ??) buttons that are currently used in those screens
20090817 20:04:24< shadowmaster> nothing fancier.
20090817 20:05:52< mordante> why not put them in a small window (which has no background) and force it in the right location?
20090817 20:05:53< silene> mordante: that's why non-legacy processors (e.g. itanium, cell) don't have a hardware divisor; since we don't know how to divide fast in hardware, the transistors are better spent elsewhere, for instance on fmas and lookup tables in order to divide fast in software
20090817 20:06:42< shadowmaster> mordante: that could probably work too
20090817 20:06:58< shadowmaster> I'll check when I'm finished with my currently broken GUI2 experiment.
20090817 20:07:41< mordante> shadowmaster, that way refreshing the button and handle the events will be done automatically
20090817 20:08:37< mordante> silene, fmas?
20090817 20:09:06< silene> fused multiply-add
20090817 20:09:49< silene> that computes a*b+c without rounding a*b
20090817 20:12:07< mordante> ah ok 
20090817 20:12:22< mordante> interesting the see some things can be faster in software as hardware
20090817 20:17:27-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20090817 20:20:08< silene> don't get me wrong: you could always hide the software computations behind some hardware, therefore it shouldn't possible to be faster in software; but by not hiding the fmas, even if your code does not perform divisions, it will still benefit from them since there isn't much code that neither add nor multiply
20090817 20:21:00< Rhonda> Ivanovic, Soliton: I started at my new work place and currently can't connect from there to the outside - corn might need a helping hand from someone else.
20090817 20:23:50< corn> Rhonda: ok
20090817 20:24:37-!- isaac [n=isaac@233.Red-83-40-20.dynamicIP.rima-tde.net] has quit [Read error: 110 (Connection timed out)]
20090817 20:29:01< silene> Rhonda: if you haven't done already so, when you package 1.7.3, please add a build dependency on libdbus-1-dev; it makes for nice notifications
20090817 20:31:25-!- isaac [n=isaac@debian/developer/isaac] has joined #wesnoth-dev
20090817 20:32:27< Ivanovic> Rhonda: so what are the plans regarding corn?
20090817 20:32:41< Ivanovic> Rhonda: that is: is the account already created?
20090817 20:32:47< Ivanovic> (and no idea else what is needed)
20090817 20:34:26< corn> Ivanovic: changes need to made to the apache configuration, and packages might need to be installed in order to be able to build wesnoth trunk on the server
20090817 20:34:33< corn> in order to generate map screenshots
20090817 20:34:50< corn> actually, building trunk is not so necessary, just getting a working wesnoth binary is all that is required
20090817 20:35:13< Ivanovic> corn: okay, then i will leave this to Soliton, he knows the debian package manager a lot better than me
20090817 20:35:19< corn> ok
20090817 20:35:26< corn> Ivanovic: you are a gentoo user?
20090817 20:35:30< Ivanovic> Rhonda: so even right now you can't connect to any outside servers? (beside your irc bouncer that is)
20090817 20:35:33< Ivanovic> corn: jupp
20090817 20:35:38< loonycyborg> Wesnoth depends on pangocairo, which in turn depends on  tons of things like X11..
20090817 20:36:23< corn> yes, in order to run screenshot generation on my server, I had to pull in a lot of X11 libraries even though I don't run X on my server
20090817 20:36:28-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090817 20:36:29< corn> there might be ways to hack around it
20090817 20:36:42< silene> corn: just wondering, do you need to generate the screenshots on the server, couldn't they be generated elsewhere? (are they generated on the fly?)
20090817 20:37:11< corn> silene: they are generated nightly, and yes, you can generate them whereever you like but the google maps need a directory to reference for tilesets
20090817 20:37:20< corn> which are these generated maps that have been split up into seperate tiles
20090817 20:37:25< Rhonda> silene: Erm, isn't that the thing that was already in 1.7.2 and that was suggested to leave disabled because it would confuse KDE users?
20090817 20:37:36< Ivanovic> Rhonda: it will confuse noone
20090817 20:37:42< loonycyborg> Rhonda: It was fixed.
20090817 20:37:42< Ivanovic> notifications are in a unified system now
20090817 20:37:55< Rhonda> Ivanovic: Right now I can. And I added corn's second ssh key. But during work hours I won't be able.
20090817 20:37:57< Ivanovic> they work basically the same way on every window manager that has dbus support for notifications
20090817 20:38:03< Ivanovic> Rhonda: ah, okay
20090817 20:38:12< Ivanovic> so right now you can help corn with his request?
20090817 20:38:25< Rhonda> silene: Thanks for the notice, will take a look.
20090817 20:38:38< Rhonda> Ivanovic: Right now I can. And I added corn's second ssh key. But during work hours I won't be able.
20090817 20:38:40< Ivanovic> (and yeah, good to know that at work hours you are not the one to contact for doing fixes, but just for asking things like "how to best do ABC"
20090817 20:39:46< corn> silene, loonycyborg: what I can do is keep the map screenshot generation on my server and write a script that will rsync the tile directory on the wesnoth.org server ( which will have stats) with my own tile directory
20090817 20:40:45< silene> Rhonda: to clarify, in 1.7.2, it was a compile-time option; so indeed it would have confused either gnome users or kde users, depending on the option you choose while packaging; for 1.7.3, this is no longer the case, the detection is done at runtime; at worst, it may confuse xfce users (but i'm not even sure, it's just that we don't have the feedback of these users)
20090817 20:41:00-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has joined #wesnoth-dev
20090817 20:41:27< loonycyborg> corn: This is an optimal solution.
20090817 20:42:15< Crab_> mordante: can you recommend a workaround to a problem I have ? I (in a naive way) try to use [scrollable_label] for displaying quite big block of text, which grows larger with each invocation. After a certain text size, it fails,  http://wesnoth.pastebin.com/m1018db51
20090817 20:42:16< silene> corn: i think that's the best; i tend to think that the less packages on a public server, the better ;-)
20090817 20:42:38< mordante> Crab_, didn't see you before, I'm busy rewriting your dialog
20090817 20:42:48< corn> ok
20090817 20:42:50< Crab_> mordante: ok :)
20090817 20:43:13< mordante> there's an ugly hack, which begs for its death
20090817 20:43:59< grzywacz> silene, btw. gcc replaces divisions of integers by 255 with multiplication+addition by default
20090817 20:44:11< mordante> cool
20090817 20:44:35< mordante> Crab_, another question why did you put the code under --new-widgets
20090817 20:44:36< mordante> ?
20090817 20:44:37< silene> grzywacz: you mean division by a constant?
20090817 20:45:20< Crab_> mordante: I thought that --new-widgets is required to use gui2::
20090817 20:46:09< grzywacz> silene, yes
20090817 20:46:35< silene> grzywacz: the code we were talking about does not perform divisions by constants
20090817 20:47:10< mordante> Crab_, no --new-widgets is for dialogs that already exist and need to migrated to the new gui for example ilor's new lobby is too difficult to do right in one time
20090817 20:47:21< mordante> so we use --new-widgets to test it
20090817 20:47:22< grzywacz> silene, neither it runs on Itanium; I just wanted to add a small remark ;)
20090817 20:47:25< Crab_> mordante: ok, understood
20090817 20:47:29< mordante> simple or new dialogs can be used without it
20090817 20:47:48< mordante> I already thought you had some confusion about it ;-)
20090817 20:49:42< mordante> Crab_, where can I test my modifications to your code?
20090817 20:50:03< Crab_> formula ai console, accessible by typing "f"
20090817 20:50:03-!- isaac [n=isaac@debian/developer/isaac] has quit [No route to host]
20090817 20:50:25< Crab_> f, then enter a formula. it can be a simple as 2+2
20090817 20:50:38< Crab_> or, it can be something bigger, like    nearest_loc(nearest_loc(my_leader.loc,loc(11,21)),unit_moves(my_leader.loc))
20090817 20:51:23< Crab_> or, it can be something that segfaults the gui code, like                 filter(map.terrain,defense_on(my_leader,loc))
20090817 20:53:55< mordante> Crab_, does it now always pop up?
20090817 20:54:19-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has joined #wesnoth-dev
20090817 20:54:31< Crab_> mordante: for today, yes. I'll make it optional soon, in one of my next commits
20090817 20:54:48< mordante> ok
20090817 20:55:41< Crab_> also, I'll make it pop up during AI turn in local games. I.e. "the AI has done something stupid (error while evaluating formula), you you want to debug ? yes/no " 
20090817 20:55:56< Crab_> (if the game is launched with -d, that is)
20090817 20:56:22< CIA-62> mordante * r37918 /trunk/data/gui/default/window/ (10 files): Remove some obsolete WML.
20090817 20:56:26< CIA-62> mordante * r37919 /trunk/src/gui/dialogs/ (formula_debugger.cpp formula_debugger.hpp): Polish the new formula_debugger code.
20090817 20:56:37< mordante> Crab_, ^
20090817 20:57:01< mordante> ok, just feared the debugger would remain permanent, but luckily not. 
20090817 20:57:18< mordante> I still like the feature as optional, nice to see debug info for formulas
20090817 20:57:23< mordante> which I had it before
20090817 20:57:32< Crab_> mordante: no, it's not needed in 'normal' circumstances, when all is ok.
20090817 20:57:58< silene> Crab_: please make it yes/no/never, so that it doesn't popup when debuging something else
20090817 20:58:34< Crab_> silene: ok
20090817 20:58:38< mordante> I wish it was there before, would have saved me a lot of printf's and debugging time
20090817 20:58:55< Crab_> mordante: I'll make it pop up if you turn it via a specific console command, or if you wrap a formula in debug()
20090817 20:58:58< mordante> btw I didn't modify the --new-widgets part in my last commit
20090817 20:59:20< mordante> oh that debug() would be lovely :-)
20090817 21:01:11< Crab_> mordante: and, in general, creating new windows is quite fun (especially because WML changes doesn't require recompilation, which is very slow...)
20090817 21:01:38< Crab_> mordante: the only problem I had is with these  callbacks
20090817 21:02:11< mordante> Crab_, well ilor added some helper code, which makes it much cleaner
20090817 21:02:32< mordante> but I still want to use boost::function
20090817 21:02:50< Crab_> mordante: yes, but the problem was that in src/gui/dialogs, there were 3 or 4 different ways to set those callbacks
20090817 21:03:06< Crab_> mordante: the cleanest way, imo, is boost::bind + boost::function combo....
20090817 21:03:29< mordante> yup if the code to do it is ugly, people start to invent work-arounds, so uglier as others ;-)
20090817 21:04:13< mordante> Crab_, yes I fully agree with boost::bind + boost::function, I just didn't know about their existence when I wrote that part of the code
20090817 21:04:33< Crab_> mordante: so, I was unlucky with fgrepping for 'how to do it right', and then I just notified you, got the answer that somewhen it will be good,  and then I've done it the most ugly+simple way I thought of.
20090817 21:05:00-!- PK5 [n=pk@r74-192-44-206.vctrcmta01.vctatx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20090817 21:05:17< Crab_> mordante: and what about    filter(map.terrain,defense_on(my_leader,loc))    ? 
20090817 21:05:57< Crab_> mordante: what should be done to make it work ? I need to display a scrollable append-only log, which can be huge
20090817 21:05:58< mordante> ah ok, I thought you found the solution, next time please ask I would have pointed you to that code
20090817 21:06:35< mordante> Crab_, I'm looking at it but don't have a debug build, but I fear it's an SDL limit
20090817 21:06:48< mordante> a size in a rect is Uint16..
20090817 21:06:57< Crab_> mordante: which workaround you might recommend ?
20090817 21:07:29< mordante> I'm not even sure there is one in this case :-(
20090817 21:08:44< Crab_> mordante: well, there are workarounds, on higher level.. I can try to make a 'save full log to file' button, and just keep the size of text in the scrollable box below limit
20090817 21:08:52< mordante> to be honest I gave the 65536 limit a short thought before and thought, nay that'll never happen
20090817 21:09:31-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit []
20090817 21:09:48< mordante> I think saving the text to a file is a good idea in general
20090817 21:10:10< mordante> if my log is that long I like to use grep and friends to find my problem and not read the entire thing
20090817 21:11:08< mordante> Crab_, I think I'll need to truncate the text if it doesn't fit
20090817 21:11:14< mordante> crashing is not a solution
20090817 21:11:51< mordante> after that I should look for a better solution how to handle it
20090817 21:12:08< Crab_> that log can be big,  because  "{x -> 18, y -> 7, loc -> {x -> 18, y -> 7}, id -> 'grassland'}" is 50 chars, and 100*100 map* 50 chars = 50000 chars for the terrain map alone
20090817 21:12:54< Crab_> so, if I try to intelligently truncate/skip parts of output, and keep it below 50000, it won't crush ?
20090817 21:13:18< Crab_> s/crush/crash
20090817 21:14:43< mordante> not sure where the limit exactly is
20090817 21:15:09< mordante> with SDL 1.3 the rect uses ints for all fields so might be it's fixed there
20090817 21:15:30< mordante> if you have a big log, but it doesn't crash, how fast is scrolling then?
20090817 21:16:26-!- Sapient [n=patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev
20090817 21:16:52< Crab_> mordante: scrolling is ok
20090817 21:17:20< Crab_> mordante: for the first part of the text
20090817 21:17:34< Crab_> mordante: for the 2nd half of the text it seems that scrolling doesn't work :)
20090817 21:18:14< mordante> how big is your map?
20090817 21:18:37< Crab_> 41x41
20090817 21:19:00< Crab_> it fits into scrollable_label once 'ok', and a second time partially
20090817 21:19:40< Crab_> mordante: you can try     filter(map.terrain,defense_on(my_leader,loc))    , and then hit 'step operation' a few times
20090817 21:21:21< Ivanovic> cjhopman, corn, Crab_, deekay, euschn, ilor, boucman, dfranke, mordante, Sapient, Sirp, YogiHH: the final evals are online now, don't forget to fill them in time (in time = a little less than one week is left)
20090817 21:21:31< Crab_> Ivanovic: ok
20090817 21:21:32< mordante> scrolls pretty fast for me over the entire range
20090817 21:21:37< mordante> Ivanovic, ok
20090817 21:21:39< YogiHH> Ivanovic: yup
20090817 21:21:55< Crab_> mordante: press step operation one more time, and try scrolling to the bottom
20090817 21:22:13< Crab_> mordante: for me, it scrolls fast, but, once a certain point is reached, stops working
20090817 21:22:50< mordante> well the next "next step" ended with a segfault :-/
20090817 21:23:20< Crab_> mordante: I'll try truncating the output to keep its size manageable, and provide a 'save to file' button for the really interested
20090817 21:23:38< mordante> Crab_, can you post a bug report about the issue, I like to fix it if possible
20090817 21:23:57< mordante> you can add the truncation as work around, but I prefer things to work properly
20090817 21:24:49< mordante> I think the save button would be nice to have since raw text is easier to modify/review
20090817 21:25:11< mordante> modify as in delete the not interesting parts
20090817 21:26:15< Sapient> Ivanovic: yeah I already read the last two times you said it in the logs ;)
20090817 21:27:02< Ivanovic> Sapient: i prefer to be 100% sure that all know about it early
20090817 21:27:04< Ivanovic> ;)
20090817 21:27:41< mordante> Sapient, did you manage to reach cjhopman?
20090817 21:28:36< Sapient> yes and no
20090817 21:29:08< Sapient> I got an initial response from him which indicates he won't be able to complete it
20090817 21:29:35< Sapient> but then I haven't heard back from my followup email yet where I explained he had a little time left
20090817 21:30:06< Sapient> the good news is he still wants to work on it, just not in time for final eval
20090817 21:30:06< CIA-62> ivanovic * r37920 /trunk/ (11 files in 10 dirs): updated Russian translation
20090817 21:30:08< CIA-62> ivanovic * r37921 /branches/1.6/po/ (8 files in 8 dirs): updated Russian translation
20090817 21:30:10< mordante> :-( did he mention why he wouldn't be able to complete it
20090817 21:30:26< Sapient> yes, there were some personal circumstances
20090817 21:30:34< mordante> would be really nice if he finishes it after gsoc
20090817 21:30:45< Crab_> mordante: https://gna.org/bugs/index.php?14145
20090817 21:33:05< mordante> thanks added a small comment
20090817 21:33:34< mordante> not that my buglist isn't big enough yet ;-)
20090817 21:36:20< Crab_> mordante: ok, another two questions. 1) My usage pattern of [scrollable_label] is append-only. I append chunks of text containing pango markup. soon, I will add caching of  'that unparsed string containing pango markup',. But, that means, that, with each invocation, a new 'pango parsing' of the entire 'combined string' will be made.
20090817 21:36:21< Crab_>  So, a question: it is possible to add the code somewhere, to avoid the reparse of already parsed pango chunks ?
20090817 21:37:26< mordante> Crab_, not at the moment, also not sure whether pango has that feature
20090817 21:37:31< Crab_> mordante: ok
20090817 21:38:10< Crab_> 2) is tdialog reusable ? can I keep a instance of dialog around for some time, calling its 'show' method from time to time ?
20090817 21:39:42< Crab_> I.e., instead of  "gui2::tformula_debugger debug_dialog(*this);  debug_dialog.show(resources::screen->video());", do  "create the dialog once, then just call   this->debug_dialog_.show(resources::screen->video());  "
20090817 21:40:40< mordante> Crab_, also don't see an append function in the pango documentation at first glance
20090817 21:41:19< Crab_> my workflow is something akin to "calculate, show dialog , continue calculation, show dialog, continue calculation..."
20090817 21:41:20< mordante> Crab_, should be possible I think it might already be used
20090817 21:42:06< mordante> of course every show instance creates a new window so it's not possible to keep references to the window between calls
20090817 21:42:08< Crab_> and, the code is singlethreaded, and, that calculation is not a continuation, so that means I need to 'call the dialog from the calculation', not the other way around
20090817 21:43:14< mordante> not sure I entirely follow you
20090817 21:46:17< Crab_> 'the object of my interest' is formula calculation. this calculation does not return control until fully calculated. sometimes, I want to yield control from the calculation to user. as of now, that calculation is implemented in a way that makes it not possible to "call something to calculate a bit, then return control"
20090817 21:47:03< Crab_> so, I cannot call that "calculate a bit" from a 'debug dialog', and I need to go the other way - call debug dialog from the calculation
20090817 21:47:39< mordante> ah ok, I have the same problem for the network connection code, but postponed thinking about it for now
20090817 21:48:32< Crab_> of course I can solve this by using some boost trickery (It'll be multithreaded, but only 1-thread-a-time)
20090817 21:48:44< Crab_> but, right now, I'm just creating a debug dialog on each 'delegation from calculation to user"
20090817 21:48:56< mordante> I like what they did with asio
20090817 21:49:10< Crab_> yes, it's nice
20090817 21:49:11-!- thespaceinvader_ [n=chatzill@cpc3-whit1-0-0-cust305.cdif.cable.ntl.com] has joined #wesnoth-dev
20090817 21:49:18< mordante> I might get some inspiration form that part to do the network code
20090817 21:49:34-!- rtfb [n=read-the@78-56-0-35.static.zebra.lt] has joined #wesnoth-dev
20090817 21:49:37< mordante> of course if we move the network code to asio it would even be easier ;-)
20090817 21:49:37< Crab_> so, I asked about 'reusing the dialog' to, at least, do not construct the same dialog many times
20090817 21:49:46-!- thespaceinvader [n=chatzill@wesnoth/artist/thespaceinvader] has quit [Nick collision from services.]
20090817 21:49:50-!- thespaceinvader_ is now known as thespaceinvader
20090817 21:50:07< Crab_> mordante: well, we already depend on boost 1.35, so we're closer to boost::asio now :)
20090817 21:50:16< mordante> a dialog is a rather light object, the window which will be regenerated is much heaview
20090817 21:50:22< mordante> heavier*
20090817 21:50:42< mordante> well we only need somebody to work on the code
20090817 21:51:05< mordante> ilor wanted to ask a fellow student, who has experience with asio, to work on it
20090817 21:51:50< Crab_> mordante: so, for now, I'll add some caching/truncation/etc, and then I'll profile that code and see if what % of time does window creation take
20090817 21:52:20< mordante> yup profiling is the way to go
20090817 21:52:32< mordante> but it would be nice to do it differently in the future
20090817 21:52:43< Crab_> mordante: is it possible to return control from a dialog without deleting the window ?
20090817 21:53:05< rtfb> esr/zookeeper, ping. Any of you online?
20090817 21:54:49-!- noy [n=Noy@wesnoth/developer/noy] has quit []
20090817 21:54:56-!- kitty_ [n=kitty@wesnoth/artist/kitty] has joined #wesnoth-dev
20090817 21:55:02< mordante> Crab_, not at the moment, but it should be possible to add code for that, but I rather create a tpersistent_dialog class for that
20090817 21:55:34< Crab_> mordante: e.g. "pause" the dialog to do something without touching gui, and return to it later
20090817 21:55:48< mordante> it should be possible to do it in the current dialog, but it's not really a feature I want to endorse too much so rather a separate class
20090817 21:55:54< Crab_> mordante: ok
20090817 21:56:14< Crab_> mordante: current way is good enoug for me, anyway 
20090817 21:56:15< mordante> but how do you know when to pause the dialog?
20090817 21:56:42< Crab_> mordante: when user clicks a certain button, which provides the information about 'how to proceed further'
20090817 21:57:26< mordante> but at that point the dialog is still there and can call another function
20090817 21:57:48< Crab_> mordante: well, the dialog should 'return' control to the code which has called that dialog
20090817 21:58:00< mordante> also I just recalled ilor added a callback handler in the main event loop
20090817 21:58:07< mordante> 1 sec
20090817 21:59:03< mordante> gui/dialogs/lobby_main.cpp:91 uses it for the network cod
20090817 21:59:06< mordante> code*
20090817 21:59:43< mordante> can you use that feature for your goals?
20090817 22:01:55< Crab_> is the line number right ?
20090817 22:02:13< Crab_> maybe, 191 ?
20090817 22:02:38-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has joined #wesnoth-dev
20090817 22:03:38< mordante> Crab_, 587, no idea where I found 191 :-/
20090817 22:04:06< mordante> ilor can you update your wiki page, which allows me to finish your review
20090817 22:04:10-!- Sapient [n=patrickp@wesnoth/developer/sapient] has left #wesnoth-dev []
20090817 22:04:58-!- ilor [n=user@wesnoth/developer/ilor] has joined #wesnoth-dev
20090817 22:05:07< corn> hm. I should update my page
20090817 22:05:40< Crab_> mordante: no, it's not useful, since my use case is different. I cannot 'calculate a bit each time we go in the event loop', because we're singlethreaded and the 'calculation state' takes that 1 thread.
20090817 22:06:12-!- allefant [n=allefant@allegro/developer/allefant] has quit [Read error: 110 (Connection timed out)]
20090817 22:06:47< ilor> mordante: not sure if I can manage to finish my wiki page now, will do tomorrow morning if I can't
20090817 22:07:15< mordante> ilor, ok no hurry I have until the 24th to finish it
20090817 22:07:17< Crab_> mordante: anyway, if 'reopening the dialog each time' becomes a problem, I can use boost::asio to rewrite the formula calculation to be in the separate thread
20090817 22:08:15< mordante> Crab_, feared that but adding a new dialog class is no problem for me as well
20090817 22:08:35< mordante> just don't want to mix it with the current dialog
20090817 22:08:51< Crab_> mordante: ok. for now, current execution model is good enough.
20090817 22:09:13< mordante> I might mix it if adding a new class is too much work, but I think it shouldn't be too hard
20090817 22:10:00< mordante> but it requires some more events post_create instead of pre_show and pre_show to do something per time the dialog is shown
20090817 22:10:23< mordante> that's the main reason to split the code
20090817 22:10:42< esr> rtfb: I'm here, what's up?
20090817 22:11:47< rtfb> esr, good. Remember you were fixing the direction of a river in HttT scenarios 18a and 19c few weeks ago?
20090817 22:11:59< rtfb> with boats and waterfall and stuff...
20090817 22:13:00< esr> Yes, what about it?
20090817 22:13:11< rtfb> one string survived:
20090817 22:13:12< rtfb> "Then we have only two choices: to proceed up the river or to go back where "
20090817 22:13:12< rtfb> "we came from and fight our way through the orcs or the undead."
20090817 22:13:41< rtfb> just discovered it, unfuzzying the trunk
20090817 22:14:20< esr> Ah. Thanks, I'll fix that.
20090817 22:16:33< CIA-62> esr * r37922 /trunk/data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: up the river -> down the river.
20090817 22:16:48< esr> Hm, appears there are four uses of "up" that didn't change to "down".
20090817 22:18:19-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090817 22:18:45< rtfb> indeed...
20090817 22:20:18< esr> Fixed now.
20090817 22:21:51< rtfb> thanks
20090817 22:27:07< CIA-62> thespaceinvader * r37923 /trunk/ (10 files in 5 dirs): Add and wire new Ancient Wose portrait. Update changelogs, portrait credits.
20090817 22:29:43-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev
20090817 22:30:51< Ivanovic> 1.7.3 release announcement: http://www.wesnoth.org/forum/viewtopic.php?f=5&t=26706
20090817 22:31:04< Ivanovic> please look for grammar mistakes and typos, i am confident that you will find many!
20090817 22:31:06< Ivanovic> ;)
20090817 22:31:30 * thespaceinvader lets off party poppers
20090817 22:31:45< Rhonda> pffft, and I just started with the package.
20090817 22:36:13< Ivanovic> updated the frontpage, too
20090817 22:38:57< rtfb> esr, there's another tiny bit of suspicious narrative. You might want to take a look if you missed it in the forum: http://www.wesnoth.org/forum/viewtopic.php?f=32&t=25329
20090817 22:40:09< esr> I'll look into that, thanks.
20090817 22:40:23-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."]
20090817 22:41:04-!- Sirp [i=97c1dc1c@wesnoth/developer/dave] has quit [Ping timeout: 180 seconds]
20090817 22:41:27-!- kitty_ [n=kitty@wesnoth/artist/kitty] has quit ["bye"]
20090817 22:41:43< esr> Ivanovic: Release announcement looks OK.
20090817 22:42:37< mordante> for me too
20090817 22:49:23< corn> Crab_: I will be adding a --label=<string> parameter to be used in conjunction with --multiplayer later today
20090817 22:49:39< Crab_> ok
20090817 23:05:07< corn> loonycyborg: it seems that libpango is already installed on wesnoth.org...
20090817 23:05:19< corn> corn@wesnoth:~$ aptitude show libpango1.0-0
20090817 23:05:20< Crab_> corn: and, in general, what's the status of integrating aitest.wesnoth.org stats ?
20090817 23:05:27< corn> State: installed
20090817 23:05:42< Crab_> corn: what should be done on my side ?
20090817 23:06:26< corn> Crab_: all of the things you want recorded need to be added to the upload logs
20090817 23:06:33< corn> you can either tell me what to add or I can do it myself
20090817 23:06:45< Crab_> corn: I should do it myself
20090817 23:06:49< corn> it should not be hard to do
20090817 23:07:06< Crab_> corn: yes, just add some code to src/ai/testing.cpp
20090817 23:07:59< corn> no, you would add to upload_log.cpp
20090817 23:08:39< corn> most likely upload_log::read_replay() or upload_log::~upload_log()
20090817 23:08:55< Crab_> corn: no, IMO, src/ai/testing.cpp should be modified first, and then, a function from it  should be called from upload_log.cpp
20090817 23:09:36-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090817 23:09:41< corn> that works as well
20090817 23:10:02< Crab_> it encapsulates the data collection better
20090817 23:11:00< corn> ok, you should wrap everything inside of a config& then and pass it to a (new) function in upload_log.cpp
20090817 23:13:37< Crab_> corn: yes, something like this. I'll try to do it tomorrow.
20090817 23:13:38-!- xchat_sux [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20090817 23:13:42< corn> ok
20090817 23:14:19-!- Elvish_Pillage2 [n=eli@71-10-231-36.dhcp.oxfr.ma.charter.com] has quit [Read error: 60 (Operation timed out)]
20090817 23:15:06-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090817 23:16:23-!- xchat_sux is now known as Elvish_Pillager
20090817 23:17:49-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090817 23:23:43< mordante> I'm off night
20090817 23:23:51< YogiHH> hi ilor
20090817 23:23:58< YogiHH> night mordante
20090817 23:24:12-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"]
20090817 23:24:33-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090817 23:27:49-!- Blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit []
20090817 23:30:04< loonycyborg> Crab_: Does it also have corresponding -dev package?
20090817 23:30:21< ilor> hi YogiHH
20090817 23:30:36< Crab_> loonycyborg: that's about what ?
20090817 23:30:51< loonycyborg> libpango1.0-0
20090817 23:31:07< loonycyborg> s/Crab_/corn
20090817 23:31:10< loonycyborg> :P
20090817 23:31:16< YogiHH> ilor: i can't get the vc9 release configuration to run. It compiles and links fine, but crashes right in the beginning somewhere inside of STL. Any ideas about that?
20090817 23:31:48< ilor> YogiHH: hmm, truth be told I haven't run release in quite a while. it's trunk?
20090817 23:32:00-!- melinath [n=melinath@pool-72-72-200-231.altnpa.east.verizon.net] has joined #wesnoth-dev
20090817 23:32:03< Crab_> loonycyborg: libpango1.0-dev
20090817 23:32:15< YogiHH> ilor: yes, but an outdated one, like a couple of weeks old, probably
20090817 23:32:28-!- giusef [n=giusef@unaffiliated/giusef] has quit [Remote closed the connection]
20090817 23:32:58< ilor> lots of things happened over the ;ast couple of weeks
20090817 23:33:28< ilor> YogiHH: I'll update to trunk and build release, will take me wuite a while 
20090817 23:33:30< ilor> *quite
20090817 23:34:05< YogiHH> ilor: don't hurry if there is other urgent stuff to do. But i would like to get this running sometime.
20090817 23:34:37< ilor> YogiHH: hinestly though if I want a fast build, I use scons/mingw
20090817 23:35:03< ilor> so vc9 release mode doesn't get much use by me ;)
20090817 23:35:15< YogiHH> ungh, i don't feel like setting that up again, now :)
20090817 23:35:15< ilor> brb
20090817 23:35:26-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit [Excess Flood]
20090817 23:35:40-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090817 23:35:48-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit [Client Quit]
20090817 23:35:53-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090817 23:36:20< Crab_> deekay: around ?
20090817 23:36:40< ilor> YogiHH: building ...
20090817 23:37:10< loonycyborg> corn: You'll actually need libpango1.0-dev in order to build trunk on the server.
20090817 23:37:15< deekay> Crab_: Yes?
20090817 23:37:30< deekay> Crab_: Around, but playing tournament game
20090817 23:37:40< Crab_> deekay: ok. I'll pastebin a link shortly
20090817 23:37:59< Crab_> (it's not urgent, just info)
20090817 23:48:32< deekay> Crab_: ok
20090817 23:51:20-!- melinath [n=melinath@pool-72-72-200-231.altnpa.east.verizon.net] has quit [Read error: 60 (Operation timed out)]
20090817 23:54:29< Crab_> deekay, anyone else who's interested: ftp://ftp.terraninfo.net/wesnoth/dk1.html
20090817 23:54:53< Crab_> that's Formula AI recruitment compared to default ai recruitment, after 12000+ games, as of r37748
20090817 23:55:18< Crab_> the most important column is "win delta", if it's >0, then formula AI recruitment has improved the matchup
20090817 23:55:45-!- mjs-de [n=mjs-de@vpw.wh.uni-dortmund.de] has quit ["On the road again"]
20090817 23:55:55-!- Sapient [n=patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev
--- Log closed Tue Aug 18 00:00:00 2009