--- Log opened Sun Sep 13 00:00:07 2009
--- Day changed Sun Sep 13 2009
20090913 00:00:07< Crab_> ugasoft: try asking ilor or YogiHH
20090913 00:00:09< loonycyborg> That's the most likely cause.
20090913 00:00:44< ugasoft> thank you Crab, they are the MSVC mantainer of the project, I'll tell them :)
20090913 00:01:24< ugasoft> but... it's about AI, maybe you can help me
20090913 00:01:50< ugasoft> that file "ai.cpp"... in src/ai/dfool/ ...
20090913 00:02:02< loonycyborg> Just remove it from the project
20090913 00:02:10< ugasoft> ok
20090913 00:02:18-!- fendrin [n=fabi@g227087201.adsl.alicedsl.de] has joined #wesnoth-dev
20090913 00:04:05< Crab_> wesbot: log 38610
20090913 00:04:07< wesbot> silene * r38610 : Removed AI that has been obsolete and broken for several years.
20090913 00:04:10< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=38610
20090913 00:04:26< shadowmaster> still compiling
20090913 00:04:38< Crab_> ugasoft: so, .sln wasn't changed when this was done.
20090913 00:04:56< ugasoft> ok, I saw
20090913 00:08:46-!- umcstat [n=umcstat@wesnoth/umc-dev/bot/umcstat] has joined #wesnoth-dev
20090913 00:08:46-!- umcstat [n=umcstat@wesnoth/umc-dev/bot/umcstat] has quit [Client Quit]
20090913 00:14:09-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has left #wesnoth-dev ["nyu"]
20090913 00:17:12< ugasoft> ok, I've a lot of linker error: unresolved external
20090913 00:17:34< ugasoft> MSVC version is not aligned
20090913 00:17:34< Crab_> for which symbol ?
20090913 00:18:05< ugasoft> savegame::write_music_play_list
20090913 00:18:18< ugasoft> savegame::write_events
20090913 00:18:27-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:18:48< ugasoft> gui2::tresolution_definition_::tresolution_definition_(class config const &)
20090913 00:19:18< ugasoft> gui2::implementation::tbuilder_horizontal_listbox::tbuilder_horizontal_listbox(class config const &)
20090913 00:20:03< ugasoft> and the last one
20090913 00:20:04< ugasoft> gui2::tscrollbar_panel::get_control_type(void)const
20090913 00:20:26< shadowmaster> yeah, doesn't happen with gcc 4.3.2 here :/
20090913 00:20:27< Crab_> that savegame:: stuff is in src/savegame_config.hpp and src/savegame_config.cpp  It was not added to MSVC project file.
20090913 00:20:50< ugasoft> thank :)
20090913 00:21:03-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit [SendQ exceeded]
20090913 00:21:12< Crab_> unfortunately, MSVC is not a first-class buildsystem for wesnoth :) so, from time to time, people who use it, have to correct such glitches.
20090913 00:21:56< Crab_> wesbot: log 36024
20090913 00:21:57< wesbot> euschn * r36024 : savegame reorganization: implemented savegame_config for team. moved savegame_config to its own file to resolve dependency issues between team.hpp and gamestatus.hpp
20090913 00:22:01< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=36024
20090913 00:23:48< Crab_> ugasoft: and another offender (as you had might already guessed), is ./gui/auxiliary/window_builder/horizontal_listbox.hpp
20090913 00:23:56< Crab_> (and cpp)
20090913 00:24:03< ugasoft> ;)
20090913 00:24:07-!- ^y_emkidzu-it [n=KVIrc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:24:28< Crab_> wesbot: log 38034
20090913 00:24:29< wesbot> mordante * r38034 : Add a horizontal listbox.
20090913 00:24:29< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=38034
20090913 00:26:57< ugasoft> hum, I've still 2 unresolved external
20090913 00:27:26< ugasoft> gui2::tresolution_definition_::tresolution_definition_(class config const &)
20090913 00:27:28< Crab_> ugasoft: find where they're defined and see if that hpp/cpp files are missing from project file..
20090913 00:27:32< ugasoft> gui2::tscrollbar_panel::get_control_type(void)const
20090913 00:27:40< ugasoft> yeah, I'm searching
20090913 00:28:53-!- ^y_emkidzu-it [n=KVIrc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit [SendQ exceeded]
20090913 00:29:11-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:29:49-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit [SendQ exceeded]
20090913 00:30:37-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:31:14-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit [SendQ exceeded]
20090913 00:31:16< Crab_> wesbot: log 37950
20090913 00:31:17< wesbot> mordante * r37950 : Fix ODR issues in gui2.
20090913 00:31:21< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=37950
20090913 00:31:45-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:31:55< Crab_> ( /src/gui/widgets/scrollbar_panel.cpp )
20090913 00:32:48< Crab_> note that there's another, different, scrollbar_panel.cpp , so the object files would need to be put into different places.
20090913 00:33:32< ugasoft> \src\gui\auxiliary\widget_definition h/cpp
20090913 00:35:08< Crab_> ugasoft: note: after you get it working, feel free to submit a patch to patches.wesnoth.org or here, to allow other MSVC devs to avoid repeating your work.
20090913 00:35:23 * shadowmaster feels tempted to change the "feel free" to "you must" :P
20090913 00:35:33< ugasoft> ok, how can I submit a patch? 
20090913 00:35:35< ugasoft> a zip file?
20090913 00:35:42< ugasoft> there's a convention?
20090913 00:35:49< loonycyborg> a diff
20090913 00:35:51< ugasoft> ok, not it compiles and links
20090913 00:35:54< shadowmaster> http://www.wesnoth.org/wiki/PatchSubmissionGuidelines
20090913 00:36:05< shadowmaster> if you have a svn client, the diff can be made with its "diff" command
20090913 00:36:08< ugasoft> ok, I'll read the patch submission guidelines and I'll submit it
20090913 00:36:58< Crab_> shadowmaster: no, if anything need changing from 'feel free' to 'you must', it is      "if you add a new file, feel free to add it to MSVC build system, as well"
20090913 00:37:31< shadowmaster> where is that written?
20090913 00:37:56< shadowmaster> (the PSG seem to lack instructions for updating the MSVC files) :/
20090913 00:38:52< ugasoft> ok, I've the .diff files
20090913 00:38:55< ugasoft> file*
20090913 00:38:58< Crab_> shadowmaster: no, sadly, this is not written anywhere. so, people tend to forget about it :)
20090913 00:39:20< shadowmaster> Crab_: feel free to change that. You have the power to edit the wiki article and the forum sticky.
20090913 00:39:23< shadowmaster> :p
20090913 00:39:24-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit [Read error: 60 (Operation timed out)]
20090913 00:39:37-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 00:39:50< ugasoft> I should submit it at "patches.wesnoth.org"
20090913 00:40:04< shadowmaster> yes
20090913 00:40:23< Crab_> ugasoft: yes, this is a safe choice
20090913 00:40:31< ugasoft> that means to create an account... ok
20090913 00:45:05< Crab_> shadowmaster: done
20090913 00:45:49< ugasoft> done
20090913 00:46:56< Crab_> ugasoft: have you compiled successfully ?
20090913 00:47:01< shadowmaster> Crab_: good, thanks :)
20090913 00:47:02< ugasoft> yes
20090913 00:50:19< Crab_> ugasoft: I've reviewed the patch. You missed FileConfiguration directives on src\gui\widgets\scrollbar_panel.cpp , src\gui\auxiliary\widget_definition.cpp, src\gui\auxiliary\window_builder\horizontal_listbox.cpp . those are important to avoid MSVC fails if there are 2+ files with the same name in different directories.
20090913 00:51:12< Crab_> ( those are not used for .cpp files which are directly in ./src )
20090913 00:52:04< Crab_> as an example, you can use FileConfiguration of a .cpp file in the same dir as the file you've added to MSVC build.
20090913 00:52:10< ugasoft> mmm I didn't understand...
20090913 00:52:46< Crab_> imagine src/foo/ai.cpp and src/bar/ai.cpp
20090913 00:52:50< ugasoft> ok
20090913 00:53:19< Crab_> what happens if MSVC tries to compile them ? it puts   src/foo/ai.cpp = > ai.o  and src/bar/ai.cpp => ai.o       names clash, oops 
20090913 00:53:26< fendrin> Crab_: Isn't just avoiding duplicate filenames in the source tree?
20090913 00:53:34< fendrin> *the solution
20090913 00:53:39< ugasoft> ( in all project I've worked on, filename clash was avoided by enforcing the policy of NOT naming two or more files identically )
20090913 00:53:49< Soliton> shadowmaster: happen to know how/if [movement_costs] works in single unit wml?
20090913 00:54:07< Crab_> fendrin: no. the solution is to instruct a certain stupid compiler to relocate the compiled object files :)
20090913 00:54:26< Crab_> fendrin: imagine names like src/ai/formula/ai_formula_ai_candidates.cpp 
20090913 00:54:37< Crab_> fendrin: src/ai/formula/candidates.cpp is much nicer
20090913 00:54:37< ugasoft> ok, I'm happy to know things I don't know at the moment :)
20090913 00:54:48< ugasoft> how to relocate the obj files?
20090913 00:55:25< Crab_> ugasoft: for example, take src\gui\widgets\scrollbar_panel.cpp
20090913 00:55:33< Crab_> ugasoft: the next file in .vcproj is src\gui\widgets\settings.cpp
20090913 00:55:46< Crab_> ugasoft: look at <FileConfiguration ... > directives
20090913 00:56:03< Crab_> ugasoft: one per each of the three build profiles
20090913 00:56:35< shadowmaster> Soliton: I don't know if it works in [unit] but it should be usable in a [unit][modifications][trait]/[object] with the appropriate effect
20090913 00:56:50< Soliton> hmm, looks like [movement_costs] in [unit] completely overwrites all movement costs even those you didn't specify.
20090913 00:56:53< shadowmaster> I tink it once broke
20090913 00:57:12< Soliton> shadowmaster: yeah, i thought that is a bit silly if i already know the modification when i create the unit.
20090913 00:57:40< ugasoft> ok, I need to edit with a text editor the .vcproj file, or can I set the FileConfiguration by the IDE?
20090913 00:57:54< shadowmaster> I remember that at some point of the development of my campaign I got frustrated over a change/bug/misfeature that broke some direct attribute specifications in a [unit] statement or something
20090913 00:58:27< Crab_> ugasoft: I don't know (I haven't used MSVC for some years). the simplest way is to copy-paste in a file :)
20090913 00:58:33< Soliton> and as a developer you promptly went to work and fixed it!?
20090913 00:58:38< ugasoft> ok, I try :)
20090913 00:58:39< Soliton> good job.
20090913 00:58:43< shadowmaster> no idea :P
20090913 00:58:53< CIA-62> espreon * r38620 /branches/resources/image-localization/ (. bfw-logo/ maps/): Added the 'image-localization' branch to the resources branch.
20090913 00:59:02< shadowmaster> I don't even remember if I was developer already.
20090913 00:59:21< Soliton> guess i will have a quick look whether it's an easy change or what the cause is.
20090913 00:59:36-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Read error: 104 (Connection reset by peer)]
20090913 01:00:49< Soliton> ugasoft: i moved the __func__ definition to log.hpp; will commit later.
20090913 01:01:01< Crab_> Soliton: it's probably an easy change in ./unit.cpp +1461
20090913 01:01:36< Soliton> Crab_: ah, thanks!
20090913 01:02:13< Soliton> the question is why the config is cleared there.
20090913 01:02:24< Crab_> wesbot: log 27599
20090913 01:02:25< wesbot> sapient * r27599 : bug #11424 - directly modifying unit "movement_costs","defense","resistance","abilities"
20090913 01:02:28< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=27599
20090913 01:02:33< ugasoft> good decision for __func__, it was not in a good place
20090913 01:02:47< ugasoft> and I've fixed the .vcproj
20090913 01:03:01< ugasoft> what to do? another diff to submit?
20090913 01:03:11< Crab_> ugasoft: yes. in the same patch :)
20090913 01:03:23< ugasoft> in the same patch... eh eh eh I'll try
20090913 01:03:33< ugasoft> (and I remove the other two files)
20090913 01:04:04< Soliton> ok, looks like it was added in the same style as the other childs where it makes sense to clear them. but for the movement type stuff i don't really see the point.
20090913 01:06:05< shadowmaster> ah, unit.cpp *shudders*
20090913 01:06:05< ugasoft> ok, done
20090913 01:07:06 * Soliton calls upon Sapient.
20090913 01:07:23< CIA-62> espreon * r38621 /branches/resources/image-localization/bfw-logo/bfw-logo.xcf: Added 'bfw-logo.xcf'.
20090913 01:09:32-!- blarumyrran [n=minaise@81-20-159-197.levira.ee] has quit []
20090913 01:11:24< CIA-62> crab * r38622 /trunk/projectfiles/VC9/wesnoth.vcproj: Fix MSVC project file to account for latest file changes by mordante, euschn, silene. Patch by ugasoft.
20090913 01:20:42< ugasoft> ^_^
20090913 01:20:52< ugasoft> my first patch... lol
20090913 01:20:58< ugasoft> bye all, I'm going to sleep
20090913 01:21:05< Crab_> ugasoft: yes, you've made the world a better place :)
20090913 01:21:16< Crab_> ugasoft: for MSVC devs, that is :)
20090913 01:21:17< ugasoft> :D
20090913 01:21:31-!- ugasoft [n=ugasoft@dynamic-adsl-94-36-225-73.clienti.tiscali.it] has left #wesnoth-dev []
20090913 01:22:58< Soliton> i wonder why get_checksum() is not part of the unit class.
20090913 01:23:52< shadowmaster> I wonder why C++ is designed in such a way you can call a class member method with a NULL this pointer and get away with it for a while.
20090913 01:24:32-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 60 (Operation timed out)]
20090913 01:24:51< Crab_> shadowmaster: also note 'delete this' statement.
20090913 01:25:05< loonycyborg> shadowmaster: for sake of performance and simplicity I guess :P
20090913 01:25:41< shadowmaster> for a language that offers polymorphism, it is a quirk that seems out of place
20090913 01:30:13< shadowmaster> loonycyborg: I don't think a simple this == NULL check is such a huge performance bottlenick...
20090913 01:30:42< shadowmaster> yes, it could be done by hand,, but we may as well write the whole thing in C and use structs with function pointers as "classes"
20090913 01:31:40< Soliton> not if you want others to understand the project.
20090913 01:31:44< Crab_> shadowmaster: on the other hand, if you can get away with not using any class fields, why you need this to be well-defined ?
20090913 01:34:03< shadowmaster> that's a good question.
20090913 01:45:11-!- Appleman1234 [n=Appleman@131.181.101.248] has joined #wesnoth-dev
20090913 01:53:22-!- Sapient [n=patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev
20090913 01:53:30< Sapient> yo
20090913 01:53:44< Crab_> hi, Sapient
20090913 01:53:58< Sapient> hey there Crab
20090913 01:55:46< Soliton> Sapient: objections to making it so movement type stuff in [unit] adjusts the unit type definition and doesn't replace it?
20090913 01:56:21< Sapient> umm
20090913 01:56:29< Sapient> that could be a problem
20090913 01:56:31< Crab_> wesbot: log 27599
20090913 01:56:33< wesbot> sapient * r27599 : bug #11424 - directly modifying unit "movement_costs","defense","resistance","abilities"
20090913 01:56:36< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=27599
20090913 01:56:44< Soliton> in what cases?
20090913 01:57:19< Sapient> first some backstory.
20090913 01:57:31< Sapient> it used to be the case that $unit.max_hitpoints would not return the TRUE max hitpoints
20090913 01:57:36< Soliton> i understand why it is done for the other tags.
20090913 01:58:09< Sapient> instead, it returned a base value and you had to have knowledge of all modifications to calculate the true value
20090913 01:58:20-!- loonycyborg [n=sergey@wesnoth/developer/loonycyborg] has quit ["Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz"]
20090913 01:58:28< Sapient> to a WML author, that's just not realistic to compute
20090913 01:58:47< Sapient> it is asking too much of them
20090913 01:59:11-!- Noyga [n=lame-z@wesnoth/developer/noyga] has joined #wesnoth-dev
20090913 01:59:12-!- Noyga [n=lame-z@wesnoth/developer/noyga] has quit [Client Quit]
20090913 01:59:40< Sapient> the reason why we might want movement costs to be the true movement costs is similar
20090913 02:00:26< Sapient> and likewise, allowing direct modifications to a value to actually change it to just that value
20090913 02:00:36< Soliton> i don't see any similarities so far.
20090913 02:01:30< Sapient> for a WML programmer it is burdensome and confusing when get/set involves a value that is not the TRUE value
20090913 02:01:42< Sapient> I think that should be self-evident
20090913 02:02:16< Soliton> i have still pretty much no idea what you're talking about.
20090913 02:02:41< Crab_> Soliton: what about allowing  [effect]'s directly in [unit], then ?
20090913 02:03:01< Soliton> what i would like to do is put [movement_costs] mountains=99 into [unit] and have it only override the movement cost for mountains.
20090913 02:03:26< Crab_> Soliton: this will allow to modify unit movement costs while avoiding the problems Sapient is describing.
20090913 02:03:42< Crab_> Soliton: alternatively, add 'replace=false' attribute
20090913 02:03:56< Soliton> if i knew what that problem is maybe i could answer that question.
20090913 02:04:08< Sapient> there is an optimization that could be performed certainly
20090913 02:04:19< Soliton> a replace key would be fine too yes.
20090913 02:04:28< Sapient> I agree that too much is being stored at the unit level which does not differ from the unit type
20090913 02:04:37< Soliton> though i don't see when you would ever need it.
20090913 02:05:15< Sapient> but a solution which renders these values mode difficult for the WML author to view and modify is no solution at all
20090913 02:05:55< Soliton> what does a default of append or replace have to do with that?
20090913 02:05:58< Sapient> it could be optimized so that, when loading a unit, values which did not differ from the base type would simply not be stored
20090913 02:06:40< Sapient> however, it would still need to be the case that, when storing a unit, all the values are directly viewablle and modify-able
20090913 02:07:08< Sapient> e.g. $unit.movement_costs.x
20090913 02:07:51< Soliton> i don't have a clue why they wouldn't be.
20090913 02:08:11< Sapient> If you don't understand that then maybe you shouldn't be changing the code
20090913 02:08:29< Sapient> I'm not really stating anything overly complex
20090913 02:08:31< Soliton> probably, which is why i'm asking you.
20090913 02:08:47< Soliton> well, i guess i'm retarded then.
20090913 02:10:11< Sapient> you can be very smart but it's only when I'm trying to explain something
20090913 02:11:08< Soliton> i'm afraid i don't understand a word you're saying today.
20090913 02:11:08< Sapient> but I'm just failing to communicate my ideas probably
20090913 02:11:34< Sapient> Crab_: did anything I said make sense to you?
20090913 02:11:59< Crab_> Sapient: yes, but this might be because I hit a similar problem with ai modifications recently.
20090913 02:12:09< Sapient> well, great
20090913 02:12:25< Crab_> Soliton: imagine that the WML author wants to change the movement costs of a unit many times in a scenario. when he's changing it 1st time, he knows their values to be from unit type. 
20090913 02:12:28< Crab_> Soliton: when he's changing it a second time, he might not know their current values - so, he'll need to supply values for all the movement  costs to be really sure all is set according to his desires.
20090913 02:12:53< Soliton> ok.
20090913 02:13:44< Crab_> Soliton: so, there are cases when 'replace=true' semantics is bad, there are cases when 'replace=false' semantics is bad.
20090913 02:14:33< Sapient> Crab_: we support two different ways that units are to be modified via WML : object modification and direct modification
20090913 02:14:55< Soliton> i'm talking about specifying a modification when the unit is spawned.
20090913 02:15:18< Soliton> i don't see how any of the above is relevant to that.
20090913 02:15:37< Crab_> Sapient: yes. for example, dark forecast uses [object][effect] apply_to=movement_costs ..[/effect] to modify movement costs
20090913 02:16:10< Soliton> let's take the example i gave. "[movement_costs] mountains=99" how is that making getting or setting values difficult?
20090913 02:16:12< Sapient> Crab_: objects use [effect]s to achieve the change, these are reapplied whenever the unit levels up but the effects are immediately visible in the unit's direct variables
20090913 02:17:18< Sapient> Soliton: you are speaking of the desired syntax to be supported (which would be perfectly fine)
20090913 02:17:36< Sapient> I thought you were describing the implementation in unit.cpp
20090913 02:18:02< Sapient> and I was objecting to what I perceived as your proposed implementation
20090913 02:18:14< Sapient> so, I guess I misunderstood
20090913 02:18:27< Soliton> well, i want to change the implementation in unit.cpp to work so that the above only changes the mountain movement cost and not replaces all movement costs.
20090913 02:18:39< Sapient> such a syntax could certainly be supported, yes
20090913 02:19:00< Sapient> in fact, it's a good idea
20090913 02:19:05< Soliton> ok, so is there any need to for the current replacement semantics?
20090913 02:19:17< Soliton> i can't really see any for movement type stuff.
20090913 02:19:24< Sapient> none that I am aware of
20090913 02:19:31< Soliton> phew. :-)
20090913 02:20:00 * Soliton has no idea what people that he was speaking of but is glad that is cleared up!
20090913 02:20:10< Soliton> s/that/thought/
20090913 02:20:28< Soliton> some typos are.. interesting.
20090913 02:22:14< Soliton> i guess i should have let the code speak: http://nopaste.com/p/asrs1CwDK  that's what i'm talking about.
20090913 02:26:12< Sapient> Soliton: that is making an assumption that all [unit_types] have a [defense][movement_costs] and [resistance] right?
20090913 02:26:48< Soliton> indeed, i could check but is that ever not the case?
20090913 02:27:13< Crab_> Soliton: it is not the case
20090913 02:27:23< Soliton> i suppose it's better to check.
20090913 02:27:26< Sapient> config &target = cfg_.child("defense"); // doesn't child return a config * ?
20090913 02:27:27< Crab_> Soliton: ./campaigns/Heir_To_The_Throne/units/Sleeping_Gryphon.cfg
20090913 02:28:12< Soliton> Crab_: it has a movement type defined that has all those.
20090913 02:28:14< Crab_> Soliton: as you see, no [resistance]
20090913 02:28:28< Sapient> Crab_: wow, I'm almost scared to ask how you figured that out so fast :O
20090913 02:28:29< Soliton> yes, not relevenant.
20090913 02:28:58< Sapient> more grep magic?
20090913 02:29:05< Crab_> Sapient: yes
20090913 02:29:54< Sapient> impressive
20090913 02:29:56< Soliton> Sapient: it returns a reference these days.
20090913 02:30:13< Sapient> ok then
20090913 02:30:35< Sapient> right, I remember now
20090913 02:30:36< Soliton> ah, there is a child_or_add().
20090913 02:33:53< Soliton> Crab_: cfg_ is the one we get the child from not the config we get handed in (which is the one in Sleeping_Gryphon.cfg).
20090913 02:34:08-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has joined #wesnoth-dev
20090913 02:37:15< Crab_> Soliton: look at unit::reset_modifications. it clears "attacks","movement_costs","defense","resistance","abilities" and then does a merge with type config.
20090913 02:37:16-!- ^y_emkidzu-it [i=kvirc@host208-67-dynamic.1-79-r.retail.telecomitalia.it] has quit ["When two people dream the same dream, it ceases to be an illusion. KVIrc 3.4.2 Shiny http://www.kvirc.net"]
20090913 02:38:07< Crab_> Soliton: so, there's at least some points during unit lifecycle when those tags might be not present
20090913 02:39:04< Crab_> Soliton: so, it's better to be on the safe side :)
20090913 02:40:03< Soliton> well, it's immediately merged with the unit movement type again... but anyway i changed it to child_or_add().
20090913 02:42:27< Crab_> ok
20090913 02:42:29< Soliton> the reset_modifications() call in advance_to() seems a bit redundant.
20090913 02:42:34-!- elynia [n=shyde@wesnoth/umc-dev/misc/elynia] has quit ["nyu"]
20090913 02:43:22< Crab_> Soliton: why ? the unit type might had changed..
20090913 02:43:39< CIA-62> espreon * r38623 /branches/resources/image-localization/lobby-icons/ (. references sort-az-off.xcf sort-az.xcf): Added blank templates for the lobby icons.
20090913 02:44:07< Crab_> Soliton: but some stuff indeed looks duplicated..
20090913 02:44:51< Soliton> well, shortly after abilities and attacks get removed anyway and then the parent movetype is merged in yet again.
20090913 02:45:16< Crab_> Soliton: the comment in reset_modifications hints about copypaste :)
20090913 02:45:47< Crab_> but, imo, it's the case of 'if it works, don't touch it till 1.8' :)
20090913 02:46:07< Soliton> :-)
20090913 02:49:19< Crab_> good night
20090913 02:49:19< Sapient> heh. yeah, likely I added that comment
20090913 02:49:24< Sapient> good night
20090913 02:49:28-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090913 02:51:02-!- Appleman1234 [n=Appleman@131.181.101.248] has quit [Read error: 104 (Connection reset by peer)]
20090913 02:52:29< CIA-62> soliton * r38624 /trunk/src/ (log.hpp server/game.cpp): moved the __func__ definition to log.hpp since it is usually used when logging
20090913 02:52:35< CIA-62> soliton * r38625 /trunk/src/unit.cpp: typo fix
20090913 02:52:41< CIA-62> soliton * r38626 /trunk/src/unit.cpp: changed the out of sync comment to something useful
20090913 02:52:43< CIA-62> soliton * r38627 /trunk/src/unit.cpp: don't clear movement type related tags to allow easier adjustment when creating the unit
20090913 02:52:46< CIA-62> soliton * r38628 /trunk/data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: fixed ridiculous turn limits and made the water serpents unable to move on mountains
20090913 02:59:58-!- Appleman1234 [n=Appleman@131.181.101.248] has joined #wesnoth-dev
20090913 03:12:31-!- Sapient [n=patrickp@wesnoth/developer/sapient] has left #wesnoth-dev []
20090913 03:13:37< CIA-62> espreon * r38629 /branches/resources/image-localization/lobby-icons/references: Committed accidentally unsaved changes to 'references'.
20090913 03:35:25-!- cib0 [n=cib@p5DC433D2.dip.t-dialin.net] has joined #wesnoth-dev
20090913 03:46:07-!- Chusslove [n=Chusslov@brsg-d9bef456.pool.mediaWays.net] has quit [Read error: 110 (Connection timed out)]
20090913 03:53:00-!- Chusslove [n=Chusslov@brsg-d9befa96.pool.mediaWays.net] has joined #wesnoth-dev
20090913 03:58:11-!- DDR [n=chatzill@66.183.125.196] has joined #wesnoth-dev
20090913 04:15:18-!- DDR [n=chatzill@66.183.125.196] has quit [Read error: 60 (Operation timed out)]
20090913 04:17:15-!- DDR [n=chatzill@66.183.125.196] has joined #wesnoth-dev
20090913 04:31:39-!- Fab2 [n=Fab@ANantes-251-1-119-144.w81-48.abo.wanadoo.fr] has quit ["connection reset by Fab"]
20090913 04:31:43-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has quit ["Meh.\"]
20090913 04:47:37-!- Ivanovic_ [n=ivanovic@dtmd-4db265af.pool.mediaWays.net] has joined #wesnoth-dev
20090913 04:49:18-!- Appleman1234 [n=Appleman@131.181.101.248] has quit [Read error: 104 (Connection reset by peer)]
20090913 04:58:33-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["WRYYYYYYYYYYYYYYYYYYYY!"]
20090913 04:58:58-!- Cheese-kun [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20090913 04:58:58-!- Cheese-kun [n=espreon@wesnoth/developer/espreon] has quit [Client Quit]
20090913 04:59:26-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20090913 04:59:43-!- Espreon is now known as Cheese-kun
20090913 05:03:38-!- Ivanovic [n=ivanovic@wesnoth/developer/ivanovic] has quit [Read error: 110 (Connection timed out)]
20090913 05:05:37-!- Ivanovic_ is now known as Ivanovic
20090913 05:18:33-!- cib_ [n=cib@p5DD34647.dip.t-dialin.net] has joined #wesnoth-dev
20090913 05:28:00-!- Cheese-kun is now known as Espreon
20090913 05:35:42-!- cib0 [n=cib@p5DC433D2.dip.t-dialin.net] has quit [Read error: 101 (Network is unreachable)]
20090913 05:39:08-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has quit [Remote closed the connection]
20090913 06:01:29-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit []
20090913 06:08:01-!- cib_ is now known as cib0
20090913 06:26:25-!- Blueblaze [n=nick@adsl-76-202-22-1.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20090913 06:36:14-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev
20090913 06:49:49-!- Aethaeryn is now known as MikeJB
20090913 06:59:18-!- silene [n=plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20090913 07:13:17-!- Blueblaze [n=nick@adsl-76-202-22-1.dsl.hstntx.sbcglobal.net] has quit [Remote closed the connection]
20090913 07:14:37-!- cib0 [n=cib@p5DD34647.dip.t-dialin.net] has quit [Remote closed the connection]
20090913 07:26:07-!- Espreon is now known as Cheese-kun
20090913 07:26:34-!- Cheese-kun is now known as Espreon
20090913 09:08:45-!- lobby [n=wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20090913 09:08:48-!- Topic for #wesnoth-dev: 95 bugs, 242 feature requests, 12 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090913 09:08:48-!- Topic set by wesbot [] [Sat Sep 12 22:56:23 2009]
20090913 09:08:50[Users #wesnoth-dev]
20090913 09:08:52[ abc123      ] [ CIA-62 ] [ esr      ] [ knotwork_   ] [ shikadibot] [ yann     ] 
20090913 09:08:52[ AI0867      ] [ corn   ] [ ettin    ] [ lobby       ] [ silene    ] [ zookeeper] 
20090913 09:08:54[ Alesis-Novik] [ DDR    ] [ fendrin  ] [ mordante    ] [ Sirp      ] 
20090913 09:08:54[ Amu         ] [ deekay ] [ Guest7621] [ nital       ] [ Smar      ] 
20090913 09:08:54[ AnMaster    ] [ Doppp  ] [ isaac    ] [ Rhonda      ] [ Soliton   ] 
20090913 09:08:54[ Appleman1234] [ erl_   ] [ Ivanovic ] [ rosso_      ] [ Tigge     ] 
20090913 09:08:54[ Chusslove   ] [ Espreon] [ kimrhh   ] [ shadowmaster] [ wesbot    ] 
20090913 09:08:54-!- Irssi: #wesnoth-dev: Total of 37 nicks [0 ops, 0 halfops, 0 voices, 37 normal]
20090913 09:31:44< mordante> Crab_ I prefer not to modify msvc files since they are meant to be edited by a gui instead of a text editor
20090913 09:38:53< mordante> Crab_ just have a look at "..\..\src\gui\widgets\control.cpp" in the the msvc files to see how badly it looks to add one file
--- Log opened Sun Sep 13 11:29:10 2009
20090913 11:34:25-!- lobby [n=wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20090913 11:34:25-!- Topic for #wesnoth-dev: 96 bugs, 242 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090913 11:34:25-!- Topic set by wesbot [] [Sun Sep 13 10:56:23 2009]
20090913 11:34:25[Users #wesnoth-dev]
20090913 11:34:25[ AI0867      ] [ Doppp    ] [ knotwork_   ] [ silene   ] 
20090913 11:34:25[ Alesis-Novik] [ erl_     ] [ lobby       ] [ Smar     ] 
20090913 11:34:25[ Amu         ] [ esr      ] [ loonybot    ] [ Soliton  ] 
20090913 11:34:25[ AnMaster    ] [ ettin    ] [ loonycyborg ] [ Tigge    ] 
20090913 11:34:25[ busfahrer   ] [ fendrin  ] [ mordante    ] [ wesbot   ] 
20090913 11:34:25[ Chusslove   ] [ Guest7621] [ nital       ] [ yann     ] 
20090913 11:34:25[ CIA-62      ] [ ilor     ] [ Rhonda      ] [ YogiHH   ] 
20090913 11:34:25[ corn        ] [ isaac    ] [ rosso_      ] [ zookeeper] 
20090913 11:34:25[ Crab_       ] [ Ivanovic ] [ shadowmaster] 
20090913 11:34:25[ deekay      ] [ kimrhh   ] [ shikadibot  ] 
20090913 11:34:25-!- Irssi: #wesnoth-dev: Total of 38 nicks [0 ops, 0 halfops, 0 voices, 38 normal]
20090913 11:34:36-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009
20090913 11:35:33-!- Irssi: Join to #wesnoth-dev was synced in 75 secs
20090913 11:43:28< Ivanovic> loonycyborg: for compiling on wesnoth.org you use some script, right?
20090913 11:43:48< Ivanovic> could you set niceness for it to some higher value so that the website has priority over compilation?
20090913 11:45:40< loonycyborg> What niceness should the compile processes have?
20090913 11:48:17< Ivanovic> >0
20090913 11:48:19< CIA-62> silene * r38632 /trunk/src/scripting/lua.cpp: Robustified code against missing tables.
20090913 11:48:23< CIA-62> silene * r38633 /trunk/src/game_events.cpp: Ensured there is always an event context when executing WML code.
20090913 11:49:07< Ivanovic> i'd even go as far up as 20 since running wesnothd, campaignd, apache and mysql ist probably more important on the server than waiting 5mins longer for compilation to finish
20090913 11:49:55< Ivanovic> lovely, it looks like mysql died
20090913 11:50:04< loonycyborg> Since compilation takes only three cores , at least one should be available for them at any time :P
20090913 11:50:58< Ivanovic> we only have 2 cores!
20090913 11:51:11< Ivanovic> so no, there should not be a free core available
20090913 11:51:23< loonycyborg> Two on each cpu, four total
20090913 11:51:31< Ivanovic> no
20090913 11:51:34< Ivanovic> just two cores
20090913 11:51:36< Ivanovic> no HT, nothign
20090913 11:51:52< Ivanovic> http://wesnoth.pastebin.com/d58c7d95d
20090913 11:52:24< silene> load average = 32? nice
20090913 11:52:35< Ivanovic> http://wesnoth.pastebin.com/m429160e8
20090913 11:52:42< Ivanovic> as you see, just a core2duo#
20090913 11:52:53< Ivanovic> those have exactly 2 cores and nothing like hyperthreading or the likes
20090913 11:54:15< Ivanovic> (cpu info shows every available core, it does not just list physic cpus)
20090913 11:54:21< loonycyborg> Hm.. Then it has one core less than I do :P
20090913 11:54:30< loonycyborg> On my desktop
20090913 11:54:39< Ivanovic> you have 3 cores?
20090913 11:54:48< silene> in fact, if i read it correctly, there is only one real core, which is hyperthreaded; so it's even worse then 2 cores
20090913 11:54:54< Ivanovic> silene: no
20090913 11:54:58< loonycyborg> Ivanovic: Yes.
20090913 11:54:59< Ivanovic> core2duo have two cores
20090913 11:55:21< silene> Ivanovic: no, they don't, unfortunately
20090913 11:55:38< Ivanovic> silene: ehm, they have
20090913 11:57:22< Ivanovic> and the core2quod have two of the two core ships on one die
20090913 11:58:01< Ivanovic> sorry, two dies on one package for the quad of the core series
20090913 11:59:26-!- loonybot [n=loonybot@wesnoth/bot/loonybot] has quit [Read error: 104 (Connection reset by peer)]
20090913 11:59:33< Ivanovic> Crab_, fendrin: http://www.wesnoth.org/forum/viewtopic.php?f=4&t=27062&start=0
20090913 11:59:45< Ivanovic> probably fixed already, just to be sure
20090913 11:59:49< loonycyborg> ok. I've set number of jobs to 1 and made script run compilation with nice command.
20090913 12:00:01< Ivanovic> loonycyborg: thanks
20090913 12:00:07< Crab_> yes, another already fixed WML-only bug.
20090913 12:00:22-!- kitty_ [n=kitty@e180199132.adsl.alicedsl.de] has joined #wesnoth-dev
20090913 12:00:55< Ivanovic> hi kitty_, nice to see you around
20090913 12:00:58< kitty_> hey
20090913 12:01:27< kitty_> I'm done with my WSAS project, here are all of them: http://imagebin.ca/img/oauzy_Xz.jpg
20090913 12:02:15< Ivanovic> WOW
20090913 12:02:35< kitty_> :)
20090913 12:04:01< kitty_> I feared I wouldn't get them done in time, but yeah. I'm just glad its over. Does anybody know if I need to write a review like the gsoc guys?
20090913 12:04:28< Ivanovic> there is no forced stuff for WSAS, but i would welcome to have it so that i can post it in the forums
20090913 12:04:57< Ivanovic> just PM me that info and I will post it once i got something like this from TSI, too
20090913 12:05:03< Ivanovic> wesbot: seen thespaceinvader
20090913 12:05:04< wesbot> Ivanovic: The person with the nick thespaceinvader last spoke 7d 11h ago.  2d 10h ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: "ChatZilla 0.9.85 [Firefox 3.0.13/2009073022]"
20090913 12:05:37< kitty_> hmm, I don't really know what to say - I did what I proposed and now the portrait project is closer to finished... But I'll try to write something later
20090913 12:06:14< Ivanovic> ah, just that you have worked on many portraits and add the link to the complete sheet
20090913 12:06:25< Ivanovic> i think that does say a lot more than anything you might write
20090913 12:06:26< Ivanovic> ;)
20090913 12:06:28< kitty_> okidoki
20090913 12:06:42< fendrin> Crab_: Uhh, you have been faster :-) http://www.wesnoth.org/forum/viewtopic.php?p=384133#p384133
20090913 12:07:15< Crab_> fabi: we were different, too
20090913 12:07:28< Crab_> fendrin: you told him to replace LoW 17 
20090913 12:08:31< Crab_> fendrin: why ? 
20090913 12:09:28< fendrin> Crab_: Right, I am an idiot.
20090913 12:09:40< fendrin> Crab_: human failure
20090913 12:10:19< fendrin> Have to leave, bye.
20090913 12:10:30< Crab_> fendrin: happen sometimes :) but, at least we demonstrated the quality of LoW support - if you spot a failure, you can get two developers answering the post, not just one :))
20090913 12:11:06< fendrin> :-)
20090913 12:11:16-!- fendrin [n=fabi@wesnoth/developer/fendrin] has quit [Remote closed the connection]
20090913 12:26:01< Ivanovic> Crab_: hmm, i should have pinged three devs, then there would be three answers...
20090913 12:26:02< Ivanovic> ;)
20090913 12:27:29< Crab_> Ivanovic: try it :)
20090913 12:27:55< Crab_> Ivanovic: each skill, even 'picking the right devs to show them the bug', needs practice :)
20090913 12:28:26< Ivanovic> ah, with this skill i already have *lots* of experience, doing it for years now
20090913 12:28:26< Ivanovic> ;)
20090913 12:28:40< Crab_> yes ;)
20090913 12:39:48< CIA-62> ivanovic * r38634 /trunk/po/wesnoth-thot/fi.po: updated Finnish translation
20090913 12:47:07-!- YogiHH [n=chatzill@d082197.adsl.hansenet.de] has left #wesnoth-dev []
20090913 12:55:02< Ivanovic> kitty_: perfect
20090913 12:55:13< kitty_> :)
20090913 12:59:43< CIA-62> silene * r38635 /trunk/data/core/units/humans/ (Loyalist_Heavy_Infantryman.cfg Loyalist_Iron_Mauler.cfg): Fixed HI level 1 and 3 not having attack animation. (Fix for bug #14251.)
20090913 13:08:24-!- grzywacz [n=grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20090913 13:12:28-!- giusef [n=giusef@95.233.55.81] has joined #wesnoth-dev
20090913 13:25:00< zookeeper> kitty_, the links in your post don't seem to work for me
20090913 13:25:19< kitty_> uh, I'll have a look
20090913 13:26:14< kitty_> hmm, for me they work - they just link over to imagebin
20090913 13:26:53< zookeeper> i just get a "Sorry, you can't do that from here."
20090913 13:29:03< zookeeper> wait, wtf, why the hell had someone changed the HI and mauler attack names?
20090913 13:29:21< zookeeper> frankly i didn't even think of looking there when i was looking for the cause of that bug
20090913 13:30:07< zookeeper> that was a completely silly change especially when the actual player-visible name didn't change :x looks like someone just didn't want to bother to add a proper icon= line as they should have
20090913 13:30:22< kitty_> zookeeper: I reuploaded the pics - do the links work now?
20090913 13:30:42< zookeeper> kitty_, perfectly
20090913 13:30:49< kitty_> strange
20090913 13:33:44< silene> zookeeper: yes, it was really an idiotic change
20090913 13:34:16< zookeeper> rather. i'll fix the attack icons..
20090913 13:37:43< silene> zookeeper: oh, indeed, i didn't notice the icon change
20090913 13:37:57 * zookeeper notes the portrait for IftU's ledinor looks like edward james olmos
20090913 13:39:55< CIA-62> zookeeper * r38636 /trunk/data/core/units/humans/ (Loyalist_Heavy_Infantryman.cfg Loyalist_Iron_Mauler.cfg): Made the HI and iron mauler use the spiked mace attack icon again.
20090913 13:49:27 * grzywacz bows to kitty_ 
20090913 14:10:54-!- giusef [n=giusef@unaffiliated/giusef] has quit ["exit (-1);"]
20090913 14:39:55-!- kitty_ [n=kitty@e180199132.adsl.alicedsl.de] has quit []
20090913 14:47:00-!- ugasoft [n=ugasoft@dynamic-adsl-94-36-225-73.clienti.tiscali.it] has joined #wesnoth-dev
20090913 15:19:27< Crab_> mordante: how should I debug this one ? http://wesnoth.pastebin.com/m5b066a80
20090913 15:19:52< mordante> haven't been on the forum for a while but whow the stuff kitty posted is awesome :-)
20090913 15:20:35< mordante> Crab_, how did you manage to get that ?
20090913 15:21:33< Crab_> mordante: while working on gamestate inspector dialog. I can commit my WIP code.
20090913 15:21:57< mordante> Crab_, maybe paste the diff first, I might spot the problem there
20090913 15:24:05< Crab_> mordante: ok. http://wesnoth.pastebin.com/m7b4b5635  I wanted to have two list boxes, the first with 'types of content' (variables, teams,etc) and the second with list of content (list of variables, list of interesting things about the team, etc), and the text box with the contents (value of variable, ai config, etc)
20090913 15:24:56< Crab_> also, I wanted to avoid recompilation as much as possible, because it's slow for me
20090913 15:27:56< Crab_> so, when I launch it, it shows ok. when I select a different value from second list, it works ok. when I try to do so again, it crashes.
20090913 15:30:07< mordante> Crab_, I assume dialog_view_callback is a copy of some other code, could you move that template in gui/dialogs/helper.hpp instead?
20090913 15:30:41< Crab_> mordante: yes, I would do so, after I get it working and finalized.
20090913 15:30:49< mordante> thanks
20090913 15:32:12< Crab_> mordante: it's just a way to delegate processing to another class, and as workaround for callbacks not accepting boost::function's 
20090913 15:33:01< mordante> I know but I rather avoid code duplication 
20090913 15:33:20< mordante> (and I know the swap_widget function is also duplicated too often ;-) )
20090913 15:34:21< mordante> but I see nothing odd in your code, will test it in a sec, was just busy finishing a commit
20090913 15:34:57< Crab_> thanks
20090913 15:36:33< silene> is there anyone with a clue as to why cumulative abilities work this way: http://www.wesnoth.org/forum/viewtopic.php?f=21&t=26905&p=384186 ?
20090913 15:38:06< CIA-62> mordante * r38637 /trunk/src/gui/widgets/ (window.cpp window.hpp): 
20090913 15:38:06< CIA-62> Add a helper for setting drawing_interval_.
20090913 15:38:06< CIA-62> The unit tests broke due to the fact the interval wasn't resetted which
20090913 15:38:06< CIA-62> caused the settings to have the wrong window size and crashed an
20090913 15:38:06< CIA-62> unrelated test with a resize failure. The bug was introduced in r38515.
20090913 15:38:11< CIA-62> mordante * r38638 /trunk/src/gui/widgets/window.hpp: Remove no longer needed friend declarations.
20090913 15:38:53< Crab_> silene: wow. maybe someone wanted to use floating-point values, but store them as an integer ? (i.e. 100 percent*100  = 10000)
20090913 15:40:33< mordante> Crab_, finished compiling, how to reproduce the problem?
20090913 15:41:03< Crab_> mordante: ./wesnoth-debug -d -t , and :inspect
20090913 15:41:37< Crab_> then select "team 1", then select "variables"
20090913 15:42:32< Crab_> it's possible to get segfaults, it's possible to get 'pure virtual called'
20090913 15:42:44< Crab_> depending on 'where to click'
20090913 15:43:42< mordante> I managed to reproduce it, but this is an invalid pointer so I'm no longer surprised about the non-existing virtual
20090913 15:44:56< Crab_> mordante: so, what I'm doing wrong ?
20090913 15:45:36< mordante> I'm looking at that now, but I guess you store a pointer which gets freed
20090913 15:46:04< mordante> maybe the pointers in the second listbox are invalid after clicking in the first?
20090913 15:49:48-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20090913 15:51:15< mordante> Crab_, is stuff_list_ etc in tgamestate_inspector::model supposed to be public or private?
20090913 15:51:23< Crab_> public
20090913 15:52:43< mordante> then please drop the trailing underscore, we use them to indicate private members
20090913 15:52:57< Crab_> ok
20090913 15:54:11< Crab_> ok, spotted 1 bug in clear_stuff_types_list, not sure if it is the reason, though
20090913 15:56:02< mordante> do you keep the pointers to the widgets after you clear a listbox?
20090913 15:56:35< mordante> (sorry about to leave so don't have a lot of time to look at it closely)
20090913 16:01:35-!- Crab_1 [n=Crab_@economical.offerer.volia.net] has joined #wesnoth-dev
20090913 16:01:59< Crab_1> 'do you keep the pointers to the widgets after you clear a listbox?' -> yes, i modify the pointers to widgets only once, at start
20090913 16:03:09-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit [Read error: 104 (Connection reset by peer)]
20090913 16:03:13< Crab_1> i'll try to update them each time and see what happens :)
20090913 16:03:39-!- Crab_1 [n=Crab_@economical.offerer.volia.net] has quit [Client Quit]
20090913 16:03:54-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090913 16:07:05< mordante> I meant the widgets inside the listbox, the listbox itself should remain valid
20090913 16:09:18< Crab_> no, i don't refer to any widgets that are inside the listbox at all 
20090913 16:09:21< mordante> I just tested with valgrind and I have a lot of invalid writes (forgot to add the attach-db option :-( )
20090913 16:10:11< Crab_> (all I do with listbox is 'set callback / add elements / clear / get index of selected item' )
20090913 16:25:54-!- Aethaeryn [n=Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #Wesnoth-dev
20090913 16:27:13< mordante> Crab_, I'll try to do some more testing tomorrow evening
20090913 16:27:20< Crab_> ok
20090913 16:27:23< Crab_> thanks
20090913 16:27:35< mordante> no problem 
20090913 16:27:39< Crab_> at least it has got a clear way to reproduce :)
20090913 16:29:48< CIA-62> silene * r38639 /trunk/src/unit_abilities.cpp: Implemented a sensible behavior for cumulative abilities. Always returning -10000 was not.
20090913 16:32:01< mordante> yes and that for UB ;-)
20090913 16:32:05< mordante> I'm off now bye
20090913 16:32:19< Crab_> bye
20090913 16:32:45-!- mordante [n=mordante@wesnoth/developer/mordante] has quit ["Leaving"]
20090913 16:34:42-!- crimson_penguin [n=ben@wesnoth/developer/crimsonpenguin] has quit []
20090913 16:56:23-!- wesbot changed the topic of #wesnoth-dev to: 95 bugs, 242 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090913 17:08:32< Aethaeryn> http://www.wesnoth.org/forum/viewtopic.php?f=6&t=27067&start=0
20090913 17:08:36< Aethaeryn> Can someone move this to Ideas?
20090913 17:08:41< Aethaeryn> It's probably some kind of FPI anyway.
20090913 17:15:19< Aethaeryn> btw, did anyone notice that there's still the old-style female naga portrait?
20090913 17:17:17< Ivanovic> zookeeper: https://gna.org/bugs/index.php?14301
20090913 17:18:15< Ivanovic> zookeeper: maybe you got an idea about this one, too: https://gna.org/bugs/index.php?14299
20090913 17:23:07-!- ugasoft [n=ugasoft@dynamic-adsl-94-36-225-73.clienti.tiscali.it] has quit [Read error: 110 (Connection timed out)]
20090913 17:23:31-!- ugasoft [n=ugasoft@dynamic-adsl-94-36-225-73.clienti.tiscali.it] has joined #wesnoth-dev
20090913 17:25:23< CIA-62> zookeeper * r38640 /trunk/data/campaigns/Heir_To_The_Throne/scenarios/15_The_Lost_General.cfg: Use the regular Wesnoth icon instead of a ToD image in the message describing the cave.
20090913 17:28:22 * Soliton always liked that message.
20090913 17:29:06< Soliton> (plus the image)
20090913 17:29:58< zookeeper> really? the image was just silly IMO.
20090913 17:38:20-!- Sirp [n=user@wesnoth/developer/dave] has joined #wesnoth-dev
20090913 17:47:53-!- Crab_ [n=Crab_@wesnoth/developer/crab] has quit ["Leaving."]
20090913 17:53:35-!- Crab_ [n=Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20090913 18:07:33-!- Baufo [n=thomas@188.23.181.78] has joined #wesnoth-dev
20090913 18:31:37-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has joined #wesnoth-dev
20090913 18:35:45-!- stikonas [n=and@ctv-213-164-125-176.vinita.lt] has joined #wesnoth-dev
20090913 18:49:52-!- giusef [n=giusef@unaffiliated/giusef] has joined #wesnoth-dev
20090913 19:24:25-!- Baufo [n=thomas@wesnoth/developer/baufo] has quit [Remote closed the connection]
20090913 19:27:56-!- DDR [n=chatzill@66.183.125.196] has joined #wesnoth-dev
20090913 19:30:28-!- DDR [n=chatzill@66.183.125.196] has quit [Client Quit]
20090913 19:30:51-!- DDR [n=chatzill@66.183.125.196] has joined #wesnoth-dev
20090913 19:44:40-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20090913 19:46:39-!- yamokidzu-it [n=rainy-it@host80-74-dynamic.24-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20090913 19:46:50< shadowmaster> mordante: I noticed that g.w.o  displays an error if I try to check the unofficial packages for trunk
20090913 19:51:22-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection]
20090913 19:56:18-!- Espreon [n=espreon@wesnoth/developer/espreon] has quit ["ChatZilla 0.9.85 [Firefox 3.5.2/20090729225027]"]
20090913 20:06:22-!- kitty_ [n=kitty@e180193053.adsl.alicedsl.de] has joined #wesnoth-dev
20090913 20:13:29-!- stikonas [n=and@ctv-213-164-125-176.vinita.lt] has joined #wesnoth-dev
20090913 20:15:53< shadowmaster> wesbot: seen thespaceinvader
20090913 20:15:53< wesbot> shadowmaster: The person with the nick thespaceinvader last spoke 7d 19h ago.  2d 19h ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: "ChatZilla 0.9.85 [Firefox 3.0.13/2009073022]"
20090913 20:18:06< shadowmaster> mordante: also, re the font size, that didn't quite answer my question. How do *you* manage it in GUI2? Or are all GUI2 dialogs tiny-GUI-incompatible?
20090913 20:25:04-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection]
20090913 20:26:03-!- blarumyrran [n=minaise@81.20.159.197] has joined #wesnoth-dev
20090913 20:28:06-!- stikonas [n=and@ctv-213-164-125-176.vinita.lt] has joined #wesnoth-dev
20090913 20:45:41-!- ugasoft [n=ugasoft@dynamic-adsl-94-36-225-73.clienti.tiscali.it] has left #wesnoth-dev []
20090913 20:52:29-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Remote closed the connection]
20090913 20:54:29-!- stikonas [n=and@213.164.125.176] has joined #wesnoth-dev
20090913 21:04:51-!- dtiger [i=5d7d40c6@gateway/web/freenode/x-vwpjbczbbxntauhd] has joined #wesnoth-dev
20090913 21:07:42-!- silene [n=plouf@wesnoth/developer/silene] has quit ["Leaving."]
20090913 21:11:00-!- DDR is now known as DDR_away
20090913 21:11:36-!- DDR_away is now known as DDR
20090913 21:14:09-!- dtiger [i=5d7d40c6@gateway/web/freenode/x-vwpjbczbbxntauhd] has quit ["Page closed"]
20090913 21:18:18-!- esr [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has quit ["ChatZilla 0.9.85 [Firefox 3.0.13/2009080315]"]
20090913 21:20:00-!- DDR is now known as DDR_away
20090913 21:21:11< shadowmaster> just awesome how a X.org module can crash my laptop in such a way a reboot is not enough :
20090913 21:22:02< shadowmaster> um, and completely corrupt the syslog log files
20090913 21:24:15-!- Zarel [n=Zarel@warzone2100/developer/Zarel] has joined #wesnoth-dev
20090913 21:24:49< Zarel> ooc, has any work been done on the Spectre and Nightgaunt units for 1.7?
20090913 21:24:51-!- Espreon [n=espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20090913 21:25:12< shadowmaster> Zarel: as in animating them?
20090913 21:25:21< Zarel> shadowmaster: Yeah, that.
20090913 21:25:30< shadowmaster> nope AFAIK, but I'm no Jetrel
20090913 21:26:05< Zarel> I've seen forum discussion on practically every other unit, but those always seemed the most in need of animation in 1.6, and I always wondered why I haven't seen discussion of them.
20090913 21:53:20< CIA-62> caslav_ilic * r38641 /trunk/ (5 files in 3 dirs): Updated localized images for Serbian.
20090913 22:25:00-!- noy [n=Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20090913 22:25:21< Sirp> hi noy
20090913 22:25:59< noy> hey Sirp 
20090913 22:26:05< noy> whats shaking
20090913 22:26:51-!- fendrin [n=fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20090913 22:36:24-!- esr [n=chatzill@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20090913 22:36:56-!- stikonas [n=and@wesnoth/translator/stikonas] has quit [Read error: 131 (Connection reset by peer)]
20090913 22:37:20-!- stikonas [n=and@ctv-213-164-125-176.vinita.lt] has joined #wesnoth-dev
20090913 22:42:04-!- Appleman1234 [n=Appleman@131.181.101.86] has joined #wesnoth-dev
20090913 22:42:20-!- rosso_ [n=rosso@dslb-088-070-068-063.pools.arcor-ip.net] has quit [Remote closed the connection]
20090913 22:51:09-!- giusef [n=giusef@unaffiliated/giusef] has quit ["exit (-1);"]
20090913 22:52:26-!- lizard_r [n=Miranda@wesnoth/umc-dev/developer/lizard] has quit ["Saurian Augur - I'll heal you by 4 hp if you leave next to me"]
20090913 22:56:23-!- wesbot changed the topic of #wesnoth-dev to: 95 bugs, 243 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20090913 23:02:44-!- busfahrer [n=busfahre@unixboard/user/busfahrer] has quit ["leaving"]
20090913 23:03:36-!- DDR_away is now known as DDR
20090913 23:03:46-!- noy [n=Noy@wesnoth/developer/noy] has quit [Read error: 145 (Connection timed out)]
20090913 23:11:31< CIA-62> zookeeper * r38642 /trunk/data/core/ (4 files in 2 dirs): Removed the old-style female naga fighter portrait.
20090913 23:11:53< zookeeper> esr, ^ maybe something you might want to add to the tools, maybe not
20090913 23:11:55-!- Zarel [n=Zarel@warzone2100/developer/Zarel] has left #wesnoth-dev ["And thus, I depart"]
20090913 23:11:58-!- zookeeper [n=l@wesnoth/developer/zookeeper] has quit []
20090913 23:14:49< esr> I just joined, and zookeeper just keft.  Can anyone tell me what he was trying to point ne art when he said "maybe something you might want to add to the tools, maybe not"?
20090913 23:15:33< Espreon> He removed the old nagini portrait.
20090913 23:15:58< CIA-62> soliton * r38643 /trunk/data/campaigns/Heir_To_The_Throne/scenarios/23_Test_of_the_Clans.cfg: made it so the victory dialog just shows one time if the last clan member you need to defeat is the last enemy leader
20090913 23:17:03< Crab_> esr: he was talking about adding the check for the removed portrait to wmllint
20090913 23:17:59< esr> I don't understand.  wmlscope already detect references to removed portraits.
20090913 23:18:18< Crab_> ok, then there is nothing that should be done.
20090913 23:18:39< Crab_> I guess that he wasn't aware of 'wmlscope already detect references to removed portraits'
20090913 23:19:45-!- ancestral [n=ancestra@166.205.4.143] has joined #wesnoth-dev
20090913 23:20:18< esr> Running it now to check on others.
20090913 23:20:21< fendrin> esr: In the old days the nagas had a sex.
20090913 23:21:16< fendrin> esr: Now the are uniform in the portraits. Maybe all female or male references shall be modified to the new generic portrait.
20090913 23:22:29-!- ancestral_ [n=ancestra@166.205.4.46] has joined #wesnoth-dev
20090913 23:22:31< esr> Hm, that is not something my tools do yet.   It wouldn't be difficult.  All I'd need to know is which old portait names should change into which new ones.
20090913 23:23:41< fendrin> esr: the log to release 38642 will give you the old portrait names. The new one is commited alreade, let's see.
20090913 23:25:22< fendrin> esr: data/core/images/portraits/nagas/fighter.png is for lvl one ; data/core/images/portraits/nagas/myrmidon.png is for lvl2 and lvl3 if there is one.
20090913 23:25:37< fendrin> wesbot: show r38643
20090913 23:26:01< fendrin> wesbot: show r38642
20090913 23:26:28< fendrin> CIA-62: show r38642
20090913 23:26:47< fendrin> CIA-62: man cia-62
20090913 23:27:56< Crab_> wesbot: log 38643
20090913 23:27:58< wesbot> soliton * r38643 : made it so the victory dialog just shows one time if the last clan member you need to defeat is the last enemy leader
20090913 23:28:01< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=38643
20090913 23:28:06< Crab_> wesbot: log 38642
20090913 23:28:07< wesbot> zookeeper * r38642 : Removed the old-style female naga fighter portrait.
20090913 23:28:10< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=38642
20090913 23:28:23< fendrin> esr: for the transparent versions (which are used in campaign wml) put a "transparent" folder between "nagas" and the filename.
20090913 23:28:48< fendrin> Crab_: thanks
20090913 23:29:02< Crab_> np
20090913 23:29:26< fendrin> esr: trunk/data/core/images/portraits/nagas/fighter+female.png shall lose the +female.
20090913 23:30:11< esr> fendrin: Working...
20090913 23:31:11< esr> Is the curret dev version 1.7.4+ or 1.7.5+?
20090913 23:31:18< fendrin> esr: 1.7.5+
20090913 23:32:26< esr> OK, I've got that subsitution ready to commit.  Amy others?
20090913 23:33:30-!- ancestral_ [n=ancestra@166.205.4.46] has quit [Read error: 104 (Connection reset by peer)]
20090913 23:34:56< fendrin> esr: Nothing that is usefull in general is on my mind. But you still have to find a solution to the story speech parts in NR.
20090913 23:36:45-!- Appleman1234 [n=Appleman@131.181.101.86] has quit [Read error: 104 (Connection reset by peer)]
20090913 23:39:38-!- Appleman1234 [n=Appleman@131.181.101.86] has joined #wesnoth-dev
20090913 23:43:47-!- ancestral [n=ancestra@166.205.4.143] has quit [Connection timed out]
20090913 23:58:43< CIA-62> esr * r38644 /trunk/data/tools/wmllint: 
20090913 23:58:43< CIA-62> Follow up on the Naga Fighter portrait replacement. Also, don't require a
20090913 23:58:43< CIA-62> translation mark for translattables that are all spaces.
--- Log closed Mon Sep 14 00:00:07 2009