--- Log opened Sat Mar 06 00:00:16 2010
20100306 00:01:37-!- Mythological [Mythologic@77.28.113.68] has joined #wesnoth-dev
20100306 00:01:42< fendrin> wesbot: seen ilor?
20100306 00:01:43< wesbot> fendrin: The person with the nick ilor 3d 8h ago was here and on the channel #wesnoth with the message:
20100306 00:02:58< fendrin> I have a google summer of code idea. 
20100306 00:03:13< fendrin> It's about teaching the editor some wml.
20100306 00:03:24< Espreon> Tell us moar.
20100306 00:04:04< fendrin> So a UMC author could code a "scenario" for the editor that can be used to build a certain wesnoth gametype scenario.
20100306 00:05:31< fendrin> [event] name=terrain placed [filter_location] ... [insert_tag] ....
20100306 00:06:00-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20100306 00:06:13< fendrin> That is it basically
20100306 00:06:15< fendrin> .
20100306 00:07:02< fendrin> A editor scenario could for examble be one that produces survivals.
20100306 00:09:14< fendrin> No aplause?
20100306 00:09:25< Espreon> Indeed.
20100306 00:11:00< fendrin> But also no open revolt. :-)
20100306 00:22:42-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100306 00:30:11-!- elias [~elias@allegro/developer/allefant] has quit [Ping timeout: 245 seconds]
20100306 00:33:15< Ivanovic> boucman: https://gna.org/bugs/index.php?15544
20100306 00:34:30-!- movicont [~movicont@2607:f140:400:1176:21e:4cff:fe3b:178d] has joined #wesnoth-dev
20100306 00:35:52-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100306 00:36:48< boucman> Ivanovic: yes, I saw it
20100306 00:36:53< Ivanovic> oaky
20100306 00:37:02< boucman> going to bed right now, i'll take a look probably tomorow
20100306 00:37:06< boucman> night all
20100306 00:37:08< Ivanovic> great
20100306 00:37:14< Ivanovic> i am about to head off to bed, too
20100306 00:37:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20100306 00:37:15< Ivanovic> n8
20100306 00:54:05-!- movicont [~movicont@2607:f140:400:1176:21e:4cff:fe3b:178d] has quit [Ping timeout: 268 seconds]
20100306 01:17:09-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100306 01:37:01-!- Zarel [~Zarel@warzone2100/developer/Zarel] has joined #wesnoth-dev
20100306 01:39:41-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20100306 01:40:28-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100306 01:46:35-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20100306 01:53:45-!- Mythological_ [Mythologic@77.28.122.176] has joined #wesnoth-dev
20100306 01:55:55-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20100306 01:55:58-!- Mythological [Mythologic@77.28.113.68] has quit [Ping timeout: 276 seconds]
20100306 01:57:33< CIA-88> ai0867 * r41459 /branches/fendrin_editor/src/tests/utils/fake_display.cpp: Fix compilation of 'test' target
20100306 01:57:41< AI0867> fendrin: 'test' compiles now, but one of the testcases fails
20100306 02:23:09-!- MikeJB [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100306 02:24:05< fendrin> AI0867: cool
20100306 02:48:37< CIA-88> fendrin * r41460 /branches/fendrin_editor/src/ (3 files in 2 dirs): Implemented drag and drop replacement for the Labels.
20100306 02:53:09-!- gabm [~gabm@70.35.164.2] has joined #wesnoth-dev
20100306 02:53:43-!- gabm [~gabm@70.35.164.2] has left #wesnoth-dev []
20100306 03:01:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100306 03:04:56-!- Appleman1234 [~Appleman1@CPE-124-191-176-143.oxqn1.cha.bigpond.net.au] has joined #wesnoth-dev
20100306 03:22:43-!- Blueblaze [~nick@adsl-99-158-47-180.dsl.hstntx.sbcglobal.net] has quit [Read error: Operation timed out]
20100306 03:33:06-!- MikeJB [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: quit()]
20100306 03:46:12-!- Zarel [~Zarel@warzone2100/developer/Zarel] has quit [Ping timeout: 256 seconds]
20100306 03:51:36-!- rolando [~rolando@64.138.54.77.rev.vodafone.pt] has quit [Quit: leaving]
20100306 04:23:06-!- StandYourGround [~Adium@230.121.55.224.guam.net] has joined #wesnoth-dev
20100306 04:31:10< shadowmaster> Crab_: could the AI sides automatically change recruitment patterns based on the human player's initial turn 1 recruits?
20100306 04:31:30< shadowmaster> that is, without the coder providing parameters or events to tell it to do so?
20100306 04:42:34-!- wesbot changed the topic of #wesnoth-dev to: string/feature freeze active! | 72 bugs, 254 feature requests, 9 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100306 04:43:36-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100306 04:45:26-!- Blueblaze [~nick@adsl-99-158-47-180.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100306 04:46:17-!- StandYourGround [~Adium@230.121.55.224.guam.net] has quit [Quit: Leaving.]
20100306 04:58:53-!- Ivanovic_ [~ivanovic@dtmd-4db2e9b0.pool.mediaWays.net] has joined #wesnoth-dev
20100306 05:01:01-!- Blarumyrran [~Blarumyrr@81-20-159-197.levira.ee] has quit [Quit: Lahkun]
20100306 05:02:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20100306 05:02:51-!- Ivanovic_ is now known as Ivanovic
20100306 05:15:17< AI0867> shadowmaster: I believe there's a formula component that does that
20100306 05:34:04-!- movicont [~movicont@ste-102-15.ResHall.Berkeley.EDU] has joined #wesnoth-dev
20100306 05:55:32-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Quit: meric]
20100306 06:04:11-!- mordocai [~mordocai@66.119.9.243] has joined #wesnoth-dev
20100306 06:07:50-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has joined #wesnoth-dev
20100306 06:11:22-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Read error: Connection reset by peer]
20100306 06:11:22-!- meric_ [~Eric@124-168-172-204.dyn.iinet.net.au] has joined #wesnoth-dev
20100306 06:11:23-!- meric_ is now known as meric
20100306 06:18:11-!- mordocai [~mordocai@66.119.9.243] has quit [Ping timeout: 246 seconds]
20100306 06:40:24-!- ancestral [~ancestral@97-116-124-46.mpls.qwest.net] has joined #wesnoth-dev
20100306 07:36:08-!- Sirp [~user@pool-71-164-166-178.dllstx.fios.verizon.net] has quit [Remote host closed the connection]
20100306 07:42:16-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Quit: meric]
20100306 08:10:45-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has joined #wesnoth-dev
20100306 08:12:03-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Quit: WRYYYYYYYYYYYYYYYYYYYY!]
20100306 08:18:35-!- dtiger [~dtiger@dynamic-vpdn-93-125-65-231.telecom.by] has joined #wesnoth-dev
20100306 08:33:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100306 08:57:36-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100306 09:32:46-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100306 09:49:47-!- StandYourGround [~Adium@230.121.55.224.guam.net] has joined #wesnoth-dev
20100306 09:52:32-!- StandYourGround [~Adium@230.121.55.224.guam.net] has quit [Client Quit]
20100306 10:03:48-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Quit: meric]
20100306 10:09:48-!- movicont [~movicont@ste-102-15.ResHall.Berkeley.EDU] has quit [Quit: Leaving]
20100306 10:10:33-!- ancestral [~ancestral@97-116-124-46.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20100306 10:10:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20100306 10:18:10-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100306 10:26:47-!- Ivanovic [~ivanovic@dtmd-4db2e9b0.pool.mediaWays.net] has quit [Changing host]
20100306 10:26:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100306 10:27:42< Ivanovic> moin
20100306 10:28:13-!- Blueblaze [~nick@adsl-99-158-47-180.dsl.hstntx.sbcglobal.net] has quit [Remote host closed the connection]
20100306 10:33:26< boucman> anybody good at using the editor around ?
20100306 10:35:23< Rhonda> Just ask your question. :)
20100306 10:35:30< boucman> hehe
20100306 10:35:41< Rhonda> Some people are known to read the logs, so …
20100306 10:35:47< boucman> i'm trying to reproduce bug 15544
20100306 10:36:15< boucman> and it's a terrain transition that happens between road and desert with great tree overlay
20100306 10:36:26< boucman> but I can't get the editor to add a great tree overlay
20100306 10:36:41< Ivanovic> you have to create a scenario with the definition stuff included
20100306 10:36:43< boucman> when I put a great tree, it replaces the underlying terrain too
20100306 10:36:57< boucman> Ivanovic: i have to create a new terrain for that ?
20100306 10:36:58< Ivanovic> you could eg just alter the file where utbs does define its things
20100306 10:37:09< Ivanovic> i don't think that plain overlay putting does work
20100306 10:38:06< boucman> well, you can overlay some stuffs, like ^Xo
20100306 10:38:16< boucman> (impassable) or keep overlay
20100306 10:39:09< zookeeper> shift-click or something
20100306 10:39:16< zookeeper> or ctrl-
20100306 10:39:23< boucman> testing
20100306 10:39:45< boucman> shift does it
20100306 10:39:48< boucman> thx zookeeper
20100306 10:39:53< zookeeper> great
20100306 10:45:52< Ivanovic> uhm, i tried to reproduce the issue in the editor, here everything is displayed perfectly correct
20100306 10:48:01< boucman> yyou mean the bug i'm studying ?
20100306 10:48:04< Ivanovic> jupp
20100306 10:48:10< boucman> i do reproduce it...
20100306 10:48:28-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100306 10:49:46< Ivanovic> https://gna.org/file/Dd-Rd_bug-test.jpg?file_id=8380
20100306 10:49:56< Ivanovic> as you see things do work over here using svn trunk
20100306 10:50:23< boucman> you used Ds not Dd
20100306 10:50:26< Ivanovic> i also attached the mapfile used to create the screenshot
20100306 10:50:28< Ivanovic> ah, okay
20100306 10:51:49< Ivanovic> yeah, okay, with dd it does reproduce
20100306 10:51:55-!- Noyga [~noyga@wesnoth/developer/noyga] has joined #wesnoth-dev
20100306 10:55:26< Ivanovic> boucman: okay, attached the mapfile to the report, so that the testcase is directly available
20100306 10:55:50< boucman> Ivanovic: that's ok I reproduce easily with the editor
20100306 10:59:43-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20100306 11:03:07< CIA-88> boucman * r41461 /trunk/ (changelog data/core/terrain-graphics.cfg): fix bug 15544 bad transitions between roads and desert with overlay
20100306 11:04:42< CIA-88> boucman * r41462 /branches/water_animation/data/core/ (37 files in 3 dirs): add dirt-snowy-dirt transitions inside forts
20100306 11:39:14-!- Noyga [~noyga@wesnoth/developer/noyga] has left #wesnoth-dev ["Quitte"]
20100306 11:55:34-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has joined #wesnoth-dev
20100306 11:59:02-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100306 11:59:48-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100306 11:59:49< Ivanovic> boucman: was it intentional that the dirt-snow-dirt part was branches only?
20100306 12:17:17-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20100306 13:18:06-!- mjs-de [~mjs-de@p3EE26418.dip.t-dialin.net] has joined #wesnoth-dev
20100306 13:18:14-!- mjs-de [~mjs-de@p3EE26418.dip.t-dialin.net] has quit [Client Quit]
20100306 13:48:35-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20100306 13:54:35-!- Mythological [Mythologic@77.28.127.134] has joined #wesnoth-dev
20100306 13:57:03-!- Mythological_ [Mythologic@77.28.122.176] has quit [Ping timeout: 256 seconds]
20100306 14:02:21-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20100306 14:02:31< mordante> servus
20100306 14:08:14-!- Appleman1234 [~Appleman1@CPE-124-191-176-143.oxqn1.cha.bigpond.net.au] has quit [Ping timeout: 246 seconds]
20100306 14:10:34< boucman> Ivanovic: yes, that part is about the orcish winter fort, which is 1.9 only
20100306 14:11:42-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100306 14:28:00-!- Blarumyrran [~Blarumyrr@81-20-159-197.levira.ee] has joined #wesnoth-dev
20100306 14:34:39-!- Ivanovic_ontour [~nils@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100306 14:34:41-!- Ivanovic_ontour [~nils@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20100306 14:38:47< CIA-88> mordante * r41463 /trunk/src/gui/widgets/listbox.cpp: Properly set the visible area.
20100306 14:38:51< CIA-88> mordante * r41464 /trunk/src/gui/widgets/tree_view_node.cpp: Fix a stupid subtraction error.
20100306 14:38:54< CIA-88> mordante * r41465 /trunk/src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): Remove a pointer in the parent upon destruction.
20100306 14:39:02< CIA-88> mordante * r41466 /trunk/src/gui/widgets/tree_view_node.hpp: 
20100306 14:39:02< CIA-88> Make the constructor and a typedef public.
20100306 14:39:02< CIA-88> They should have public in the first place, but the friendship with
20100306 14:39:02< CIA-88> ttree_node hid the problem.
20100306 14:39:04< CIA-88> mordante * r41467 /trunk/src/gui/widgets/ (tree_view.cpp tree_view_node.cpp tree_view_node.hpp): 
20100306 14:39:04< CIA-88> Rename parent to parent_node.
20100306 14:39:04< CIA-88> This to avoid confusion with the usage of parent in the rest of the gui
20100306 14:39:04< CIA-88> code, there the parent is the owning parent widget.
20100306 14:39:08< CIA-88> mordante * r41468 /trunk/src/gui/widgets/ (tree_view.cpp tree_view_node.cpp tree_view_node.hpp): Rewrote the tree view node -> tree view link.
20100306 14:39:09< CIA-88> mordante * r41469 /trunk/src/gui/widgets/tree_view_node.cpp: 
20100306 14:39:09< CIA-88> Fix stupid bug in get_indention_level.
20100306 14:39:09< CIA-88> AI0867 spotted the problem while reviewing the code.
20100306 14:39:11< CIA-88> mordante * r41470 /trunk/src/gui/widgets/tree_view_node.cpp: Remove an unneeded include.
20100306 14:39:14< CIA-88> mordante * r41471 /trunk/src/gui/ (3 files in 3 dirs): 
20100306 14:39:14< CIA-88> Add some wiki comment for the tree view.
20100306 14:39:14< CIA-88> Not complete but at least some information can be shown in the wiki.
20100306 14:39:19< CIA-88> mordante * r41472 /trunk/src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): Update doxygen comment.
20100306 14:39:21< CIA-88> mordante * r41473 /trunk/src/gui/widgets/ (grid.cpp grid.hpp): Change some 0's to NULL's.
20100306 14:39:30< CIA-88> mordante * r41474 /trunk/ (changelog src/gui/widgets/window.cpp): (log message trimmed)
20100306 14:39:30< CIA-88> Fix a crash when destroying a window (MSVC only).
20100306 14:39:30< CIA-88> The chrash was caused by UB and only MSVC seemed to crash and our g++
20100306 14:39:30< CIA-88> users got unlucky never noticing the problem. The bug was spotted by
20100306 14:39:30< CIA-88> ilor and YogiHH.
20100306 14:39:31< CIA-88> Diagnosed and tested an earlier patch with YogiHH, this patch uses a
20100306 14:39:32< CIA-88> slightly different way, but should fix the problem as well. However it
20100306 14:39:44< mordante> YogiHH/ilor^
20100306 15:05:24-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100306 15:09:29-!- elias [~elias@allegro/developer/allefant] has joined #wesnoth-dev
20100306 15:40:08< boucman> wesbot: seen crimson_penguin
20100306 15:40:09< wesbot> boucman: The person with the nick crimson_penguin last spoke 2d 17h ago.  6h 42m ago was here and on the channel #wesnoth with the message: Quit: crimson_penguin
20100306 16:06:30-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Quit: meric]
20100306 16:16:48-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100306 16:17:16-!- stikonas [~and@bcm-131-111-247-5.girton.cam.ac.uk] has joined #wesnoth-dev
20100306 16:17:16-!- stikonas [~and@bcm-131-111-247-5.girton.cam.ac.uk] has quit [Changing host]
20100306 16:17:16-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100306 16:21:37-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has joined #wesnoth-dev
20100306 16:24:03-!- rolando [~rolando@161.87.103.87.rev.vodafone.pt] has joined #wesnoth-dev
20100306 16:25:20-!- meric [~Eric@124-168-172-204.dyn.iinet.net.au] has quit [Client Quit]
20100306 16:28:43< fendrin> wesbot: seen ilor
20100306 16:28:43< wesbot> fendrin: The person with the nick ilor 4d 1h ago was here and on the channel #wesnoth with the message:
20100306 16:37:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100306 16:43:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100306 16:46:14-!- ilor [~ilor@wesnoth/developer/ilor] has joined #wesnoth-dev
20100306 17:02:48< fendrin> hi ilor
20100306 17:03:12< fendrin> ilor: I have many questions about the editor framework.
20100306 17:03:49< shadowmaster> AI0867: right, but at least I haven't activated it
20100306 17:13:47< CIA-88> fendrin * r41475 /branches/fendrin_editor/src/editor/ (mouse_action.cpp mouse_action.hpp): Hacked a basic drag and drop support for map labal replacement.
20100306 17:24:12< CIA-88> fendrin * r41476 /branches/fendrin_editor/src/editor/mouse_action.cpp: Code cleanups and commented the hack a bit.
20100306 17:33:22< boucman> fendrin: it still segfaults for me, is there anything I can do to help debug ?
20100306 17:35:05< fendrin> boucman: Oh, I have moved on. The segfault is beyond my skills. And because I can't reproduce it any longer it's even harder to investigate.
20100306 17:35:19< boucman> ok
20100306 17:35:23< boucman> :(
20100306 17:36:27< fendrin> boucman: But if you want to go after it, I will try to be as much helpful as I am able to.
20100306 17:39:18< fendrin> ilor: Is it intended that the mouse_action::drag_left() is called multiple times per hex?
20100306 17:39:21< teaser> can core menu-items be accessed in set_menu_item, so that it is possible to write an alias for a default menu-item that shows in the context-menu? (I'm thinking about items from the main-menu, not that are already in the context menu)
20100306 17:52:46< fendrin> teaser: On what are you working?
20100306 17:53:44< loonycyborg> fendrin: I can reproduce a crash on that map too but only if I scroll the view down.
20100306 17:53:55< shadowmaster> rrr/37
20100306 17:54:55< fendrin> loonycyborg: Yeah, that is it. The moment you trigger the units to be drawn something is segfaulting. That is what boucman is getting into. It's working fine on my machine for some reason. Do you have a mac like boucman?
20100306 17:55:11< shadowmaster>  /37
20100306 17:55:15< shadowmaster> oh dammit
20100306 17:55:53< loonycyborg> fendrin: No. Linux.
20100306 17:55:56< fendrin> teaser: I may help you since I work on the gui1 menu system as well.
20100306 17:56:48< fendrin> loonycyborg: Normaly you only have one unit_map around. I guess it is a unit_map that conatains invalid locations or units. But in the editor we have several maps at once each with their set of envirenment objects. 
20100306 17:57:22< boucman> fendrin: i use ubuntu, no mac here
20100306 17:57:50< fendrin> loonycyborg: Maybe the copy constructor of unit_map is broken but that got never noticed since there wasn't a need to copy the unit_map unitil now.
20100306 17:58:10< fendrin> boucman: 64bit?
20100306 17:58:19< boucman> yes
20100306 17:58:42-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100306 17:58:44< fendrin> loonycyborg: 64bit?
20100306 17:58:57< loonycyborg> No. 32 bit.
20100306 17:59:18< fendrin> :-)
20100306 17:59:46< shadowmaster> oh, arch survey time?
20100306 18:00:46< fendrin> shadowmaster: It was just a desperate try to blaim the architectury for a segfault I don't manage to fix.
20100306 18:01:34< shadowmaster> only twice I have found bugs that reproduce only on x86 and not on amd64 and that wasn't even wesnoth
20100306 18:01:43< shadowmaster> s/found/produced/
20100306 18:02:35< fendrin> shadowmaster: one of you unit tests is failing.
20100306 18:02:44< fendrin> shadowmaster: Maybe that can give a hint to the bug.
20100306 18:03:29< shadowmaster> mine?
20100306 18:04:54< shadowmaster> I don't think I wrote any unit tests but the version_info module. ...And I'm feeling too lazy to recompile memoryeaternoth unless it's strictly necessary
20100306 18:07:08< ilor> fendrin: sorry, was afk
20100306 18:07:43< fendrin> ilor: Cool to have you back after 4 days of absence :-)
20100306 18:07:45< ilor> fendrin: drag_left needs to keep track of last hex it was on somewhere iirc
20100306 18:08:31 * ilor goes read the logs
20100306 18:08:47< fendrin> ilor: That is the way I have implemented it now. So it is fired several times per hex on purpose?
20100306 18:10:03< ilor> fendrin: it's fired beacues at this point it's not known yet if the cursor is in the same hex, if I remember
20100306 18:10:56< fendrin> ilor: Cool, I can live with that. Another thing, why is there no drag_end_left and drag_end_right? 
20100306 18:11:03< shadowmaster> fendrin: so, um, what unit test is failing?
20100306 18:11:57< fendrin> shadowmaster: I don't know, AI0867 reported it (It was also him who ported the unit tests to the new editor branch). I well tell you if you tell my how to perform the tests.
20100306 18:12:32< fendrin> shadowmaster: nevermind, I got it:-)
20100306 18:15:34< fendrin> shadowmaster: Well, can't see it. My debug output is that dense that it makes the tests output useless. And there is a wml error reported by the engine during the test. 
20100306 18:23:05-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100306 18:26:30-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Read error: Connection reset by peer]
20100306 18:28:07-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100306 18:33:24< fendrin> ilor: Do you know why empty menus lead to a crash?
20100306 18:34:59< ilor> fendrin: nope
20100306 18:35:13< ilor> fendrin: no drag end hum not sure
20100306 18:50:28-!- krotop [~christoph@smj33-1-82-233-64-163.fbx.proxad.net] has joined #wesnoth-dev
20100306 19:01:46-!- VladimirSlavik [~chatzilla@88.103.147.178] has joined #wesnoth-dev
20100306 19:02:22-!- VladimirSlavik [~chatzilla@88.103.147.178] has quit [Changing host]
20100306 19:02:22-!- VladimirSlavik [~chatzilla@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20100306 19:12:21-!- Guest1078 [~luiz@201-27-196-78.dsl.telesp.net.br] has joined #wesnoth-dev
20100306 19:12:32-!- Guest1078 is now known as lucifernando
20100306 19:13:12< VladimirSlavik> hi, I have a question about release announcement translation... should I change links to FSF so that they point to localized but outdated pages, or keep them as is?
20100306 19:48:38-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20100306 19:59:57-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20100306 20:01:41-!- Espreon [~espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20100306 20:09:03-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100306 20:17:10-!- fabi [~fabi@88-134-187-173-dynip.superkabel.de] has joined #wesnoth-dev
20100306 20:17:10-!- fabi [~fabi@88-134-187-173-dynip.superkabel.de] has quit [Changing host]
20100306 20:17:10-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20100306 20:20:03< shadowmaster> 712
20100306 20:20:36-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds]
20100306 20:25:38< CIA-88> esr * r41477 /trunk/data/core/team-colors.cfg: Address bug #15547: incorrect order in team-colors.cfg.
20100306 20:32:17< mordante> ilor, any news on the lobby index out of bounds errors?
20100306 20:33:49-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 268 seconds]
20100306 20:40:28-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100306 20:56:16< teaser> fendrin: I wanted to get access to the main-menus 'save map' in a [set_menu_item]-context-menu-item for consistency when working on WCE (wesnoth collaborative editor), maybe it is doable by creating a new theme, but iirc the gui1-theme-wml is pretty hard to work with (so not worth the effort atm).
20100306 20:57:00-!- fabi is now known as fendrin
20100306 21:12:03-!- migge [~marc@ip-95-223-247-31.unitymediagroup.de] has joined #wesnoth-dev
20100306 21:13:13-!- migge [~marc@ip-95-223-247-31.unitymediagroup.de] has quit [Client Quit]
20100306 21:13:34-!- migge [~marc@ip-95-223-247-31.unitymediagroup.de] has joined #wesnoth-dev
20100306 21:29:07< CIA-88> mordante * r41479 /trunk/src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): 
20100306 21:29:07< CIA-88> Fix assertion failures in the tree view.
20100306 21:29:07< CIA-88> When opening or closing a node the sizes are now calculated better as
20100306 21:29:07< CIA-88> before and no longer cause assertions failures due to out of size.
20100306 21:29:07< CIA-88> Note the code still feels a bit hacky, but it seems to work properly so
20100306 21:29:08< CIA-88> rather commit now as rewriting it. The latter is scheduled to do later.
20100306 21:29:11< CIA-88> mordante * r41478 /trunk/ (changelog src/gui/widgets/scrollbar_container.cpp): 
20100306 21:29:11< CIA-88> Fix container resize glitches.
20100306 21:29:11< CIA-88> The scrollbars are now properly resized and enabled or disabled when not
20100306 21:29:11< CIA-88> needed with the new number of items.
20100306 21:29:53-!- Blueblaze [~nick@adsl-99-158-47-180.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100306 21:30:17< mordante> Ivanovic, that fixes the tree view issues left in the lobby^
20100306 21:30:46< mordante> Ivanovic, still have some resize glitches which cause the window scrollbars to show up every now and then
20100306 21:31:23< mordante> Ivanovic, but the out of bounds index problem makes it hard to test that
20100306 21:31:52< mordante> Ivanovic, I'll disable those checks but not sure whether that allows be to test, since I enter UB-land
20100306 21:36:43< ilor> mordante: not really in a position to test thing atm (on a netbook) but will hunt for the out of bounds issue tomorrow
20100306 21:36:55< mordante> ilor, ok great
20100306 21:37:05< mordante> ilor, do you still use MSVC?
20100306 21:37:13< ilor> mordante: you did fix the asserts I've been having?
20100306 21:37:15< boucman> crimson_penguin: around ?
20100306 21:37:33< mordante> ilor, which asserts?
20100306 21:37:33< ilor> mordante: I've somewhat given up on it and mostly just use scons
20100306 21:38:06< ilor> mordante: about a week ago or more I bugged you about asserts happening whe clicking on the tree view in the lobby etc
20100306 21:38:38< mordante> ok then I'll ask YogiHH to test the MSVC fix
20100306 21:39:15< mordante> yes those should be fixed now (wasn't sure whether it was regarding these asserts)
20100306 22:00:13< teaser> zookeeper: (or any other wml expert) is there an event that takes place after the first objectives are shown but before players take control?
20100306 22:01:38< Gambit> No but you ought to be able to fake it with fire_event
20100306 22:02:06< Gambit> wait nevermind
20100306 22:05:17-!- Appleman1234 [~Appleman1@CPE-124-191-176-143.oxqn1.cha.bigpond.net.au] has joined #wesnoth-dev
20100306 22:05:56< Gambit> Actually depending on when advancement happens maybe you could fake it by spawning a unit with just enough exp to level
20100306 22:06:32< Gambit> teaser: ^^ if advancement happens after objectives display
20100306 22:10:41< mordante> fendrin, any reason why map_labels has it's own private member labels_ instead of letting the class use labels::labels_ via an accessor ?
20100306 22:11:54< fendrin> labels_ is not of datatype map_labels.
20100306 22:12:39< fendrin> mordante: Ah, the whole file is a implemented a bit dirty. Good you spotted it.
20100306 22:12:54< fendrin> mordante: I want to redo that commit.
20100306 22:13:38< teaser> Gambit, well, but when should I spawn the unit?
20100306 22:13:47< Gambit> turn 1
20100306 22:14:26< mordante> fendrin, ok then I won't touch the file
20100306 22:15:07< fendrin> mordante: The own private member labels_  is another type since I overwrite the type definition. I guess that is a very dirty hack.
20100306 22:15:17< fendrin> mordante: Do you have any trouble with the file?
20100306 22:19:26-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 240 seconds]
20100306 22:19:50< mordante> fendrin, you confuse me both members are declared as "team_label_map labels_;", what do you mean with "I overwrite the type definition" ?
20100306 22:20:13-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20100306 22:20:19< mordante> gcc is just complaining in a nagging mode, no real error
20100306 22:21:40< fendrin> mordante: There are different type definitions for team_label_map and label_map in the both classes.
20100306 22:22:14< fendrin> mordante: In one case it's a map over labels in the other a map over terrain_labels. 
20100306 22:22:54-!- dtiger [~dtiger@dynamic-vpdn-93-125-65-231.telecom.by] has quit [Remote host closed the connection]
20100306 22:23:38< crimson_penguin> boucman: I am now
20100306 22:23:56< boucman> crimson_penguin: did you redo a build of the water animation branch ?
20100306 22:24:02< crimson_penguin> nope
20100306 22:24:12< boucman> could you do that  please ?
20100306 22:24:41< crimson_penguin> what's the branch called again?
20100306 22:25:33< mordante> fendrin, ah I see now, reminds me again why I often try to avoid typedefs
20100306 22:26:49< fendrin> mordante: I was unable to develop a design pattern with map_labels unsing terrain_label and labels using label. So that hack is the result.
20100306 22:26:58< boucman> water_animation
20100306 22:27:49< fendrin> boucman: Just had your segfault. Maybe it is stable again :-)
20100306 22:29:40< mordante> fendrin, do you keep pointers or reference to labels and map_labels in a container?
20100306 22:32:30< zookeeper> teaser, no, probably no way to do that
20100306 22:33:36< teaser> ok, thanks, will work around it
20100306 22:36:50< CIA-88> mordante * r41480 /trunk/src/ai/composite/engine_lua.cpp: Initialize all members.
20100306 22:36:55< CIA-88> mordante * r41481 /trunk/src/ (gamestatus.cpp menu_events.cpp multiplayer_connect.hpp): Strip trailing whitespace.
20100306 22:41:02-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Quit: WRYYYYYYYYYYYYYYYYYYYY!]
20100306 22:42:34-!- wesbot changed the topic of #wesnoth-dev to: string/feature freeze active! | 71 bugs, 254 feature requests, 9 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100306 22:44:27-!- VladimirSlavik [~chatzilla@wesnoth/translator/VladimirSlavik] has left #wesnoth-dev []
20100306 22:44:56-!- allefant [~elias@allegro/developer/allefant] has joined #wesnoth-dev
20100306 22:46:12-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Remote host closed the connection]
20100306 22:46:51-!- elias [~elias@allegro/developer/allefant] has quit [Ping timeout: 245 seconds]
20100306 22:53:20< teaser> Soliton: I just got a server msg that seemed to belong in a private conversation among moderators (1.6-server) I think that isn't intended (maybe malfunctioning mod or server?
20100306 22:55:55< CIA-88> fendrin * r41482 /branches/fendrin_editor/ (7 files in 3 dirs): 
20100306 22:55:55< CIA-88> Enabled side switching to the editor.
20100306 22:55:55< CIA-88> Yumm.
20100306 22:56:50< fendrin> mordante: It's pointers.
20100306 22:57:19< mordante> fendrin, can you point me to the code which uses it?
20100306 22:58:24-!- rolando [~rolando@161.87.103.87.rev.vodafone.pt] has quit [Ping timeout: 245 seconds]
20100306 22:58:49< fendrin> mordante: editor/editor_map.hpp
20100306 22:59:04< fendrin> mordante: The labels are a member there.
20100306 22:59:47< fendrin> mordante: Not in trunk. That is in the editor branch.
20100306 23:00:41< mordante> is that by any chance the same code boucman has crashes in?
20100306 23:05:32< fendrin> Maybe. Another reason more to revert the commit from trunk soon.
20100306 23:16:14-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100306 23:18:13-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100306 23:19:10-!- mjs-de [~mjs-de@p3EE25F7A.dip.t-dialin.net] has joined #wesnoth-dev
20100306 23:19:40< Blarumyrran> Hello - is it possible that a replay of a game is smaller than a save-game from a previous point in the same game?
20100306 23:21:07< Blarumyrran> (30 kB vs 40 kB)
20100306 23:24:46-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100306 23:26:08< fendrin> boucman: What can go wrong if there is fog but it's not cleared for units?
20100306 23:26:19< boucman> ???
20100306 23:26:22< boucman> in the editor ?
20100306 23:26:31< fendrin> Right
20100306 23:26:54< boucman> wide guess : there is an "update fog" to add whenever you place a unit...
20100306 23:30:54< fendrin> boucman: Can it be related to the fact that my gamestate is a empty one?
20100306 23:31:03< boucman> no idea
20100306 23:31:29< mordante> fendrin, I had a short look at the code and it seems that there isn't a labels/map_labels problem yet
20100306 23:31:44< mordante> fendrin, but it's an accident waiting to happen...
20100306 23:32:01< mordante> you didn't define a virtual destructor in the base class
20100306 23:32:19< mordante> and also don't use virtual functions
20100306 23:32:49< mordante> so as soon as somebody access a map_labels via a labels pointer things will go wrong
20100306 23:33:49< mordante> some examples http://wesnoth.pastebin.com/5cNWpRyX
20100306 23:35:29< fendrin> mordante: I guess it isn't worth to repair the broken class in any way. Or do you consider the design acceptable?
20100306 23:36:51< crimson_penguin> boucman: so is the guy english? then I could leave out translations
20100306 23:37:04< boucman> I don't think so, sorry
20100306 23:37:17< boucman> crimson_penguin: hopefully, this one's the good one
20100306 23:37:43< boucman> last time he had animated water but no coasts, and since it was based on my FOSDEM patch and not the branch, it makes sense...
20100306 23:38:59< mordante> fendrin, for trunk or your branch?
20100306 23:44:27< crimson_penguin> ok
20100306 23:46:29-!- mjs-de [~mjs-de@p3EE25F7A.dip.t-dialin.net] has quit [Remote host closed the connection]
20100306 23:48:11< fendrin> mordante: I will revert trunk now.
20100306 23:48:27< mordante> fendrin, ok
20100306 23:48:56< mordante> for your branch maybe add a more generic base class and inherit both paths from there
20100306 23:49:51-!- lucifernando [~luiz@201-27-196-78.dsl.telesp.net.br] has quit [Quit: Ex-Chat]
20100306 23:49:55< mordante> or maybe make it a template class and have two versions one of the map_labels and one for the labels
20100306 23:50:15< mordante> but I haven't looked to close at the code to see what the best solution is
20100306 23:51:24< mordante> but when using inheritance you often end up with virtual functions especially in this case
20100306 23:52:38< mordante> but the two labels_ members feel like the design should be different
--- Log closed Sun Mar 07 00:00:25 2010