--- Log opened Sun Mar 14 00:00:41 2010
20100314 00:07:05-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Quit: later]
20100314 00:23:56-!- allefant [~elias@allegro/developer/allefant] has quit [Quit: Leaving]
20100314 00:28:47-!- teaser [~teaser@h-37-106.A254.priv.bahnhof.se] has quit [Ping timeout: 246 seconds]
20100314 00:40:56-!- Gambit|AFK|Guess is now known as Gambit
20100314 00:53:09-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Quit: Leaving]
20100314 01:24:16-!- Blueblaze [~nick@adsl-99-158-47-51.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 265 seconds]
20100314 01:36:12-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100314 01:37:21-!- lfernando [~luiz@201-27-198-31.dsl.telesp.net.br] has quit [Remote host closed the connection]
20100314 01:43:50-!- LucaMoller [~a1184a02@gateway/web/freenode/x-wvoiwntuycesszdj] has joined #wesnoth-dev
20100314 01:44:13-!- LucaMoller [~a1184a02@gateway/web/freenode/x-wvoiwntuycesszdj] has left #wesnoth-dev []
20100314 01:57:06-!- Espreon [~espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20100314 02:03:50-!- Tesafilmchen [~quassel@p5B2763E0.dip.t-dialin.net] has quit [Remote host closed the connection]
20100314 02:16:34-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100314 02:21:44< crimson_penguin> fendrin: you got my message that it's up?
20100314 02:36:08-!- teaser [~teaser@h-37-106.A254.priv.bahnhof.se] has joined #wesnoth-dev
20100314 02:36:22-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20100314 02:36:52-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20100314 02:59:14< fendrin> crimson_penguin: Yes, thank you very much. 
20100314 02:59:25< crimson_penguin> no problem
20100314 03:39:32-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100314 03:48:13-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has quit [Quit: switching timezones]
20100314 03:48:48-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100314 03:53:18-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100314 03:56:35< gabm> is game_display::get_singleton() the correct way to get the display, for instance when I want to show a dialog box?
20100314 03:57:33< gabm> I use it successfully, but if I use it again after entering and exiting a game it crashes
20100314 04:19:44-!- Blueblaze [~nick@adsl-99-158-47-51.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100314 04:19:46-!- Guest81174 [~h0tm4ilsu@cm-84.215.182.243.getinternet.no] has quit [Ping timeout: 316 seconds]
20100314 04:20:07-!- Guest81174 [~h0tm4ilsu@cm-84.215.182.243.getinternet.no] has joined #wesnoth-dev
20100314 04:22:48-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has quit [Quit: switching timezone]
20100314 04:23:12-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100314 04:24:41-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Quit: good night]
20100314 04:26:43-!- Ivanovic_ [~ivanovic@dtmd-4db2dee1.pool.mediaWays.net] has joined #wesnoth-dev
20100314 04:26:44-!- Ivanovic_ [~ivanovic@dtmd-4db2dee1.pool.mediaWays.net] has quit [Changing host]
20100314 04:26:44-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100314 04:30:11-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds]
20100314 04:30:44-!- Ivanovic_ is now known as Ivanovic
20100314 04:32:33< CIA-53> ai0867 * r41557 /branches/fendrin_editor/src/soundsource.cpp: Don't let non-numerical coordinates for a [soundsource] kill wesnoth through an uncaught bad_lexical_cast. Display an error instead.
20100314 04:32:59< AI0867> Espreon: ^
20100314 04:33:44< Espreon> Thanks.
20100314 04:33:57< AI0867> oops
20100314 04:33:58-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20100314 04:33:59< AI0867> wrong branch
20100314 04:34:48< Espreon> Well, less merge work perhaps?
20100314 04:35:12< AI0867> true
20100314 04:35:20< AI0867> merging into trunk now...
20100314 04:41:16< CIA-53> ai0867 * r41558 /trunk/src/soundsource.cpp: Don't let non-numerical coordinates for a [soundsource] kill wesnoth through an uncaught bad_lexical_cast. Display an error instead.
20100314 04:41:56< AI0867> Espreon: in trunk now ^
20100314 04:42:25< AI0867> svn wouldn't let me merge from url to url, so I used git instead
20100314 04:43:35< Espreon> Cool, thanks.
20100314 04:46:03< fendrin> hi AI0867
20100314 04:47:31< Espreon> Uh oh...
20100314 04:47:36 * Espreon runs.
20100314 05:16:50< Espreon> mordante: https://gna.org/bugs/index.php?15614 ... Have fun.
20100314 05:47:06< gabm> wesbot: seen boucman
20100314 05:47:06< wesbot> gabm: The person with the nick boucman last spoke 9h 1m ago.  8h 56m ago was here and on the channel #wesnoth with the message: Ping timeout: 276 seconds
20100314 05:47:33< gabm> boucman: I'd appreciate if you could review my patch: https://gna.org/patch/index.php?1528
20100314 05:48:18< gabm> boucman: it's for the "Anonymous Local Player" issue we were discussing on the mailing list.
20100314 06:09:45-!- pushkalcodes [~dce36163@gateway/web/freenode/x-ujmhmbaqchbviqmo] has joined #wesnoth-dev
20100314 06:19:22-!- pushkalcodes [~dce36163@gateway/web/freenode/x-ujmhmbaqchbviqmo] has quit [Ping timeout: 252 seconds]
20100314 06:35:02< jabagawee> hi there, i'm interested in participating in gsoc 2010 if possible. any suggestions on how to familiarize myself both with the code and the community?
20100314 06:40:23-!- mordocai [~mordocai@66.119.9.243] has joined #wesnoth-dev
20100314 06:42:21-!- mordocai [~mordocai@66.119.9.243] has quit [Client Quit]
20100314 07:00:19-!- dtiger [~dtiger@dynamic-vpdn-93-125-16-205.telecom.by] has joined #wesnoth-dev
20100314 07:13:45< Espreon> jabagawee: Well, regularly come here, get an account on the fora, and read the GSoC stuff on the wiki I suppose.
20100314 07:14:18< jabagawee> Espreon: sounds good. i got my gna, wiki, forum, and irc accounts already, and i'm making a proposal page
20100314 07:14:22< jabagawee> what're my chances of being accepted?
20100314 07:14:25< Espreon> Sadly, the people who have the "real" answers are probably asleep... (most of them live in Europe).
20100314 07:14:28< Espreon> It depends...
20100314 07:14:46< Espreon> ... on many things...
20100314 07:14:50< Espreon> IDK,
20100314 07:14:52< Espreon> *.
20100314 07:15:25< Espreon> I'm just the guy who maintains UtBS, localizes images, and does other random things.
20100314 07:15:41< Espreon> *localizes images for various languages and transliterations
20100314 07:16:34< Espreon> jabagawee: Wait for people such as Ivanovic and mordante to come back; they live in Germany... so... yeahz...
20100314 07:16:56< jabagawee> sure thing
20100314 07:16:57< jabagawee> thanks
20100314 07:17:02< Espreon> You are welcome.
20100314 07:17:18< Espreon> Meh, not sure about mordante, but I am sure he lives in that area of Europe.
20100314 07:17:57< jabagawee> just wondering, but where are you from?
20100314 07:18:40< Espreon> I live in the United States of America; the state in which I reside is Pennsylvania.
20100314 07:18:46< Espreon> I just happen to be crepuscular/nocturnal.
20100314 07:18:51-!- Blueblaze [~nick@adsl-99-158-47-51.dsl.hstntx.sbcglobal.net] has quit [Remote host closed the connection]
20100314 07:19:26< jabagawee> nah, 1pm is nothing :P
20100314 07:20:30< Espreon> On the weekends, I prefer to go to bed at around six... seven o'clock.
20100314 07:20:37< Espreon> ... AM of course.
20100314 07:20:58< Espreon> Sadly, I cannot follow this awesome schedule on the weekdays.
20100314 07:21:01< jabagawee> dang, that's a bit nocturnal then :P
20100314 07:21:50< Espreon> Indeed.
20100314 07:22:07< jabagawee> you should've hit dst already, right?
20100314 07:22:25< Espreon> Not till two o'clock, apparently.
20100314 07:22:51< Espreon> IDK, I hæt DST.
20100314 07:23:07< Espreon> It may make my weekends more fun, but it makes my weekdays suck.
20100314 07:23:32< jabagawee> i thought DST occurred at one o'clock and sent you to two.
20100314 07:24:14< Espreon> Meh, I wouldn't know.
20100314 07:24:29< Espreon> I don't pay attention to such trivial matters...
20100314 07:24:55< Espreon> Unlike seeing "harbour", it is not a catastrophe.
20100314 07:25:31< jabagawee> seeing "harbour"?
20100314 07:25:43< Espreon> "Harbour" is an evil spelling of the purer "harbor".
20100314 07:25:56< Espreon> Yes, I am an Anglophile.
20100314 07:26:11< Espreon> And everyone knows that true Anglophiles reject the "-our" and "-ise" spellings.
20100314 07:26:39< jabagawee> heh. colourise.
20100314 07:27:36< Espreon> How evil...
20100314 07:38:20< Espreon> jabagawee: Out of curiosity, what do you plan to do for GSoC?
20100314 07:38:29< jabagawee> probably the spritesheet idea
20100314 07:38:37< jabagawee> do you have any suggestions?
20100314 07:40:19< Blarumyrran> I thought spritesheets were already coded
20100314 07:40:28< jabagawee> must've been last year's idea then?
20100314 07:41:50< Espreon> Blarumyrran: LOL, wut?
20100314 07:42:03< jabagawee> Blarumyrran: can you elaborate?
20100314 07:46:36-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has joined #wesnoth-dev
20100314 07:47:04-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has quit [Changing host]
20100314 07:47:04-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100314 07:47:42< Espreon> mordante: https://gna.org/bugs/index.php?15071 ... It's back...
20100314 07:49:16< Espreon> mordante: Same case as last time.
20100314 07:49:48< Espreon> ... and I am using the latest hidden Windows build.
20100314 07:50:01< Blarumyrran> Espreon, jabagawee, http://forums.wesnoth.org/viewtopic.php?f=18&t=26531&p=374077&hilit=spritesheets#p374077
20100314 07:53:04< jabagawee> Blarumyrran: well gosh darn. i guess i have to find a new gsoc idea
20100314 07:53:10< Espreon> Yes, it is possible, but maybe things need to be perfected.
20100314 07:53:41< jabagawee> Espreon: though you really have no say in it, do you recommend i follow this idea?
20100314 07:53:58< Espreon> I don't recommend anything; as I said, wait for people who actually have the answers to arrive.
20100314 07:54:02< jabagawee> gotcha
20100314 07:55:11< Espreon> Yeah, just because something is possible doesn't mean that its implementation has been perfected.
20100314 08:12:18< gabm> Blarumyrran: how do spritesheets work right now? Some animations are just put together manually in a big png, and you use the CROP command to select the right frame?
20100314 08:14:02< CIA-53> silene * r41559 /trunk/src/text.cpp: 
20100314 08:14:02< CIA-53> Fixed text being clipped on the right due to Wesnoth lying to Pango about 4 extra columns.
20100314 08:14:02< CIA-53> No idea what the "hack" is/was supposed to fix. (Fix for bug #15613.)
20100314 08:16:10< Blarumyrran> gabm, I guess? I'm not sure if even that ~CROP thing is actually used anywhere
20100314 08:16:36-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100314 08:16:57< gabm> Blarumyrran: ok
20100314 08:17:13-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20100314 08:17:22< mordante> servus
20100314 08:17:37< Espreon> mordante: Ic grete þe. :)
20100314 08:17:45< mordante> hi Espreon :-)
20100314 08:17:58< Espreon> I am sure that you will have a couple lovely surprises today... :)
20100314 08:18:30< mordante> ok, you have a crystal ball?
20100314 08:18:40< Espreon> Don't need one... just read the logs... ;)
20100314 08:18:46 * Espreon smiles creepily.
20100314 08:20:18< mordante> oh yeah I just had one, only 90% of the email is spam, thought the number was higher ;-)
20100314 08:20:53< Espreon> Heh...
20100314 08:21:14< Espreon> I may get spam, but it doesn't touch my inbox. ;)
20100314 08:22:24< mordante> indeed the log is nice, but I don't think that's the part you meant ;-)
20100314 08:24:15< Espreon> Well, I think that https://gna.org/bugs/index.php?15071 coming back would have been a bit surprising.
20100314 08:24:21< silene> mordante: what is the point of the "hack" in src/text.cpp? that's what was causing the tip of the day to be truncated on the right
20100314 08:24:47< silene> and it would also cause any rtl language to be clipped
20100314 08:26:15< mordante> silene, which hack?
20100314 08:26:45< silene> mordante: "Need to see whether this is a bug in pango or a bug in my understanding of the pango api."
20100314 08:31:41< mordante> silene, see the comment around text.cpp:348 for more info
20100314 08:32:00< silene> mordante: that doesn't explain why you need it
20100314 08:36:00< mordante> silene, there was a bug with the campaign dialog where the last line sometimes disappeared
20100314 08:36:43< mordante> after looking into it it seemed that the value for the best size returned a different size as the size used when the text was placed the widget
20100314 08:37:13< mordante> and it first seemed to be a 4 pixel offset, but that was not always true, hence to more elaborate version
20100314 08:37:48< mordante> the problem is that the area used after placement didn't use the entire width but slightly less
20100314 08:38:05< mordante> causing the text to wrap earlier and in the end resulting in more lines
20100314 08:38:15< mordante> where the last one was "out of the widget"
20100314 08:39:34< mordante> Espreon, any way to reproduce it?
20100314 08:39:47< silene> mordante: so it is a bug in the widget code?
20100314 08:39:55< Espreon> mordante: Hwæt exactly?
20100314 08:40:47< Espreon> You mean that segfault?
20100314 08:41:42< mordante> silene, no in my opinion it's a bug in pango I ask how it will layout the text and I reserve space for it
20100314 08:42:02< mordante> then when I place the text it suddenly uses a different size 
20100314 08:42:08< mordante> Espreon, yes
20100314 08:42:21< Espreon> Same as last time.
20100314 08:43:32< silene> mordante: anyway, the hack is now disabled for rtl language, since it was truncating text; so whatever your bug is, it will now reappear
20100314 08:50:47< mordante> in which way did it truncate text in rtl languages?
20100314 08:51:23< mordante> Crab_ FYI [unstore_unit]advance=true was MP safe 
20100314 08:54:19< silene> mordante: because it was trying with 4 extra columns on the right; pango was replying that it fits, and then the 4 extra columns were lost when the text was rendered
20100314 08:55:40< silene> (and for rtl languages, contrarily to ltr languages, the rightmost columns obviously contains characters)
20100314 09:00:15< mordante> ok, well I want to investigate the problem further later anyway see where the bug really is my understanding of pango or pango
20100314 09:05:13-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100314 09:05:15< mordante> silene, thanks for the info regarding the c++ standard
20100314 09:14:55-!- gabm [~gabm@206.176-ppp.3menatwork.com] has left #wesnoth-dev []
20100314 09:29:21-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 09:31:16-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Client Quit]
20100314 09:40:02< CIA-53> silene * r41560 /trunk/src/mouse_events.cpp: Fixed context menu popping anywhere outside the game area.
20100314 09:42:07-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 09:44:50-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has left #wesnoth-dev []
20100314 09:50:31-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 09:59:47-!- loonybot [~loonybot@ppp79-139-136-187.pppoe.spdop.ru] has joined #wesnoth-dev
20100314 09:59:47-!- loonybot [~loonybot@ppp79-139-136-187.pppoe.spdop.ru] has quit [Changing host]
20100314 09:59:47-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100314 10:00:38-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100314 10:42:34-!- wesbot changed the topic of #wesnoth-dev to: string/feature freeze active! | 77 bugs, 253 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100314 10:46:24< Ivanovic> moin
20100314 10:48:25< mordante> hi Ivanovic 
20100314 10:48:54< Espreon> Ivanovic: Ic grete þe.
20100314 10:51:53< Ivanovic> jabagawee: before you can have any chance to be accepted by wesnoth as summer of code student one thing has to happen: wesnoth has to be accepted as org
20100314 10:52:05< Ivanovic> if this is the case it will be announced next friday
20100314 10:53:05< Ivanovic> in general to improve your chances you should communicate with us about your proposal, have eg a look at some easy coding tasks and submit patches so that you get into things and we got an idea about how you handle stuff
20100314 10:53:30< mordante> Ivanovic, he told be he'll be around again later today
20100314 10:54:37< Ivanovic> mordante: i hope that he does read his irc clients backlogs, since this is a thing wesnoth devs should do, too (at least grabbing for their nickname in the logs)
20100314 10:54:44< Ivanovic> ;
20100314 10:54:46< Ivanovic> )
20100314 10:56:33-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Read error: Connection reset by peer]
20100314 10:56:33-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev
20100314 10:57:20< CIA-53> ivanovic * r41561 /trunk/po/ (wesnoth-did/ja.po wesnoth-httt/ja.po wesnoth-units/ja.po): updated Japanese translation
20100314 10:59:25< Ivanovic> mordante: any news on the lobby resize issues
20100314 10:59:30< Ivanovic> ?
20100314 11:00:11< mordante> working on it
20100314 11:01:00< Ivanovic> okay
20100314 11:03:16-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100314 11:20:28< mordante> Ivanovic, I think I have a solution, going of for lunch now... let's see how it looks afterwards
20100314 11:21:10< Ivanovic> mordante: cool!
20100314 11:21:47< Ivanovic> what else beside the "strange resize stuff" is still blocking 1.8?
20100314 11:22:05< Ivanovic> that is: once the patch is in and i tested it a little, too, what do you think of directly releasing 1.8rc1?
20100314 11:22:33< mordante> the redraw issues which pop up every now and then (you had it when pressing the refresh button)
20100314 11:22:49< Ivanovic> right
20100314 11:22:57< mordante> and some other minor issues like the horizontal scrollbar in the chat window
20100314 11:23:10< mordante> but I think they shouldn't be a blocker
20100314 11:23:11< Ivanovic> i'd guess this might be related to some bad layering or the likes
20100314 11:23:28< Ivanovic> and yes, the lobby chat bar is no blocker (though it would be nice to see it fixed!)
20100314 11:24:17< mordante> well I personally prefer getting 1.8 out soon and leave these minor issues for now
20100314 11:24:34< Ivanovic> :)
20100314 11:24:52-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Quit: WRYYYYYYYYYYYYYYYYYYYY!]
20100314 11:25:39< mordante> for 1.9 I want to look more critical at some parts of the gui2 code
20100314 11:26:06< mordante> I have some ideas about how to improve certain aspects 
20100314 11:26:20< mordante> and I've more experience with the sizing issues 
20100314 11:26:41< mordante> the lobby is and was a good learning experience in that regard
20100314 11:26:55< mordante> and also one of the hardest dialogs to convert
20100314 11:27:03< Ivanovic> yeah
20100314 11:27:45< mordante> but off to lunch now
20100314 11:27:56< mordante> (lobby still looks good)
20100314 11:58:39-!- dtiger [~dtiger@dynamic-vpdn-93-125-16-205.telecom.by] has quit [Remote host closed the connection]
20100314 12:05:33-!- ilor [~ilor@wesnoth/developer/ilor] has joined #wesnoth-dev
20100314 12:42:17< mordante> ilor, any luck with reproducing the index out of bounds issue?
20100314 12:44:58-!- Tesafilmchen [~quassel@p5B277D63.dip.t-dialin.net] has joined #wesnoth-dev
20100314 12:46:46< ilor> mordante: what testing I did did not show anything
20100314 12:47:13< ilor> mordante: the issue inside diff update is checked for properly now anyway
20100314 12:47:48< Ivanovic> ilor: what are the other open issues you know regarding the mp lobby?
20100314 12:47:58< mordante> ilor, ok then I'll test whether it's also fixed for me
20100314 12:50:36< Ivanovic> ilor: what is the status of https://gna.org/bugs/?15162 ?
20100314 12:58:55< CIA-53> silene * r41562 /trunk/src/scripting/lua.cpp: Brought Lua interface closer to the engine implementation by allowing references to units out of the map.
20100314 12:59:04< CIA-53> silene * r41563 /trunk/src/scripting/lua.cpp: Adjusted interface with respect to Lua units.
20100314 12:59:06< CIA-53> silene * r41564 /trunk/src/scripting/lua.cpp: Allowed modifying locations of units outside the map.
20100314 12:59:09< CIA-53> silene * r41565 /trunk/src/scripting/lua.cpp: Added accessor to unit resistance.
20100314 12:59:12< CIA-53> silene * r41566 /trunk/src/scripting/lua.cpp: Added accessor to unit movement cost.
20100314 12:59:16< CIA-53> silene * r41567 /trunk/src/scripting/lua.cpp: Added accessor to unit defense.
20100314 13:00:02< CIA-53> ivanovic * r41568 /trunk/src/preferences_display.cpp: add some more commonly used resolutions to the list
20100314 13:01:39< Ivanovic> ilor, mordante: what is the status of this one? https://gna.org/bugs/?15161
20100314 13:02:16< Ivanovic> what about this assert? https://gna.org/bugs/?15163
20100314 13:03:08< Ivanovic> mordante: any news about this one? https://gna.org/bugs/?15060
20100314 13:03:25< Ivanovic> (yeah, i am currently very annoying since i just went through the list of bugs marked blocker or important)
20100314 13:06:25< mordante> 15060 is only reproducible on Windows and I haven't found a solution for it
20100314 13:07:14< mordante> not being able to reproduce it makes it very hard to fix (IIRC it seems to be a bug in pango)
20100314 13:08:24< Ivanovic> okay
20100314 13:15:56< Ivanovic> silene: you saw this forum post? http://forums.wesnoth.org/viewtopic.php?f=4&t=29167
20100314 13:17:21< CIA-53> mordante * r41569 /trunk/ (changelog players_changelog src/gui/widgets/grid.cpp): 
20100314 13:17:21< CIA-53> Improve the sizing of the widgets in gui2.
20100314 13:17:21< CIA-53> Still needs more tweaking post 1.8, but with this fix the scrollbars in
20100314 13:17:21< CIA-53> the MP lobby appear less often. (Still show at small screens, but I
20100314 13:17:21< CIA-53> consider that "as designed".)
20100314 13:20:32< mordante> Ivanovic, ^this should fix the scrollbar issue, still running some more tests here
20100314 13:21:05< mordante> I get some assertion failures, but before I investigate them further I want to make sure the out of bounds issue is fixed
20100314 13:22:29< Ivanovic> i am off for some three hours
20100314 13:22:53< Ivanovic> afterwards i'll do a testrun of the new lobby and, depending on how things work, try to release rc1 afterwards
20100314 13:23:37< Ivanovic> AI0867, Chusslove, esr, fendrin, ilor, loonycyborg, mordante, shadowmaster, silene, Soliton, zookeeper, everyone else who cares: ready for rc1 in some 3 to 4h?
20100314 13:23:39< mordante> ok see you later
20100314 13:23:55< Ivanovic> any bigger bugs left that should make it only beta instead of rc?
20100314 13:24:08< Ivanovic> any blockers that should completely block me from releasing?
20100314 13:24:17< Ivanovic> please ping me if that is the case!
20100314 13:24:33< mordante> I let you know later after more testing
20100314 13:24:45< Ivanovic> okay
20100314 13:26:33< esr> Ivanovic: I don't see blockers.  I'm not really happy about the state of the bug list, though - too many different things wrong in too many different areas, it feels like we're no near a stable state.
20100314 13:29:47< silene> Ivanovic: yes, i saw it, but i don't have much to say; i don't know whether the change of behavior between 1.6 and 1.7 was willingful; so i would prefer the developer responsible for the change to reply (hopefully it's not me)
20100314 13:29:59< mordante> ilor, Ivanovic running the lobby with this patch http://paste.debian.net/64187/ shows the out of bounds problem is still there
20100314 13:49:15-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100314 13:55:12< ilor> mordante: argh. the > / >= typo is still there right above that
20100314 13:55:26< ilor> I was certain I fixed that
20100314 13:59:43< mordante> ilor, maybe locally and not pushed upstream?
20100314 14:00:41-!- Appleman1234 [~Appleman1@CPE-124-191-176-143.oxqn1.cha.bigpond.net.au] has quit [Ping timeout: 265 seconds]
20100314 14:00:46< CIA-53> ilor * r41570 /trunk/src/gui/dialogs/lobby_main.cpp: Fix a typo in an out-of-bounds check in lobby
20100314 14:00:49< ilor> mordante: must have been
20100314 14:02:03< mordante> ilor, ok thanks, will test the lobby later again, looking at the redraw issue at the moment
20100314 14:02:13< ilor> Ivanovic: regarding the bugs I marked two of them as fixed, did not remember ever reproducing the third one (retun from race selection) but then again I did not tets on *nix
20100314 14:02:38< ilor> however it does seem a bit strange for it to crash there as the lobby is torn down completely when entering a game
20100314 14:21:04-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100314 14:27:23-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Ping timeout: 246 seconds]
20100314 14:32:49-!- teaser [~teaser@h-37-106.A254.priv.bahnhof.se] has quit [Ping timeout: 265 seconds]
20100314 14:34:52-!- elias [~elias@allegro/developer/allefant] has joined #wesnoth-dev
20100314 14:40:44-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100314 15:07:11-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20100314 15:08:22< CIA-53> silene * r41571 /trunk/src/scripting/lua.cpp: Added interface for Dijkstra's pathfinder.
20100314 15:15:50< AI0867> silene: he's depending on an undocumented change in behaviour. you reverted the behaviour to the original way, which also makes more sense. As for the change, it was sapient's r22211
20100314 15:15:59< AI0867> it may have been unintended
20100314 15:25:50-!- MikeJB [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100314 15:26:02-!- MikeJB is now known as Aethaeryn
20100314 15:35:51-!- ghyr-easeus [~kvirc@69-35-135-95.pool.ukrtel.net] has joined #wesnoth-dev
20100314 15:53:34-!- ilor [~ilor@wesnoth/developer/ilor] has quit [Remote host closed the connection]
20100314 15:53:59-!- ilor [~ilor@wesnoth/developer/ilor] has joined #wesnoth-dev
20100314 15:56:27-!- ghyr-easeus [~kvirc@69-35-135-95.pool.ukrtel.net] has quit [Quit: When two people dream the same dream, it ceases to be an illusion. KVIrc 3.4.3 Shiny(svn-3438) http://www.kvirc.net]
20100314 16:16:51< fendrin> AI0867: About your schema validator, are you still working on it?
20100314 16:18:35< AI0867> fendrin: yes, but not very high priority atm
20100314 16:19:36< CIA-53> silene * r41572 /trunk/src/scripting/lua.cpp: Added an interface to the combat predictor.
20100314 16:19:38< AI0867> standard WML syntax's validity depends on a wide variety of factors
20100314 16:19:45< fendrin> AI0867: Do you consider the wml schema syntax final?
20100314 16:19:53< AI0867> fendrin: no
20100314 16:20:06< AI0867> the stuff used in schema-gui.cfg won't change
20100314 16:20:26< AI0867> but the stuff used in schema.cfg may ([element] and [attribute] tags and the like)
20100314 16:20:27< fendrin> Do you have any c++ connection to the schemas planed?
20100314 16:20:42< AI0867> I have no plans in that direction
20100314 16:21:16< AI0867> though having wesnoth dump its preprocessed version could be useful for comparing with wmlparser's result
20100314 16:21:43< fendrin> I would like to use them to display a proper gui for handling unit configs for example.
20100314 16:23:01< fendrin> Example: The scenario designer wants to change some values of a predefined unit. Left click on a hex which is already occupied by a unit brings up a modified version of crab's gamestate inspector. 
20100314 16:24:10< fendrin> That modified gamestate inspector will read the schema for the wml tag [unit] and know that gender is enum type and not a string for example. It can present the designer a scrollbox in which only valid values are presented.
20100314 16:25:36< AI0867> you don't need the validator for that, just wmlgrammar
20100314 16:25:51< fendrin> what is wmlgrammar?
20100314 16:26:14< AI0867> that's not finished either (it's the part that interprets the schema), but the interface is something I should stabilize soon
20100314 16:26:19< AI0867> see /data/tools/wesnoth/wmlgrammar.py
20100314 16:27:30< fendrin> AI0867: Can I call this python tools you wrote from within c++?
20100314 16:32:56< mordante> ilor, thusfar no crashes so seems that problem is fixed
20100314 16:33:31< mordante> Ivanovic, still have the redraw glitch every now and then, but not predictable and not reproducible yet
20100314 16:34:34< mordante> when it comes it stays a while (few refreshes after eachother exhibit the problem) and then disappears again
20100314 16:37:39< ilor> mordante: well not really _fixed_ as such but worked around to prevent crashes... I do plan on nailing the underlying problem as soon as I'm able to reproduce :)
20100314 16:38:14< mordante> well that's good enough for me now ;-)
20100314 16:38:31< mordante> but I know the feeling of the underlaying problem... ;-)
20100314 16:38:34< AI0867> fendrin: I didn't expose any C++ bindings, so calling it from C++ would take some work
20100314 16:39:02< AI0867> the schema isn't particularly complicated, so you're probably best off parsing it yourself
20100314 16:39:29-!- teaser [~teaser@h-37-106.A254.priv.bahnhof.se] has joined #wesnoth-dev
20100314 16:42:34-!- wesbot changed the topic of #wesnoth-dev to: string/feature freeze active! | 74 bugs, 253 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100314 16:50:31-!- Noyga [~noyga@wesnoth/developer/noyga] has joined #wesnoth-dev
20100314 16:50:51-!- Noyga [~noyga@wesnoth/developer/noyga] has quit [Remote host closed the connection]
20100314 16:54:58< fendrin> AI0867: I don't think it's a good idea to parse the schema in c++. It will only lead to 2 implementations of the wmlvalidator. The c++ bindings sound better to me.
20100314 16:57:57-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: Reconnecting]
20100314 16:58:20-!- Aethaery1 [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100314 16:59:04-!- Aethaery1 is now known as Aethaeryn
20100314 17:04:09< ilor> off topic time, is there a Python implementation of ImagePathWML, or at least of the team-coloring?
20100314 17:07:09< mordante> no idea
20100314 17:07:41< mordante> teaser, any more info about reproducing https://gna.org/bugs/?15561? I can't reproduce it here
20100314 17:08:10-!- dtiger [~dtiger@dynamic-vpdn-91-149-132-203.telecom.by] has joined #wesnoth-dev
20100314 17:10:28< ilor> mordante: I think I saw that issue, it's about gamelist items shrinking to a minimum reaonable size instead of expanding horizontally
20100314 17:10:42< ilor> you'll need a large resolution screen and games with short names 
20100314 17:15:34< mordante> also doesn't do the trick for me :-(
20100314 17:15:53< mordante> but thanks for the hint
20100314 17:18:14-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Quit: On the road again]
20100314 17:19:18-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 17:24:56< mordante> AI0867, are the wml schemes documented somewhere?
20100314 17:37:10< AI0867> mordante: not yet
20100314 17:37:18< AI0867> best docs are in data/tools/wesnoth/wmlgrammar.py
20100314 17:39:09< mordante> AI0867, ok 
20100314 17:39:21< Ivanovic> re
20100314 17:39:34< Ivanovic> esr: the problem with the bug list is that we proably need to *really* clean it up
20100314 17:39:55< Ivanovic> atm i fear that there are a) several already fixed bugs and b) lots of "can't reproduce" things
20100314 17:42:02< mordante> not too sure about that, I think a lot of bugs are quite recent
20100314 17:42:38< mordante> my guess is about 50 old ones and 25 rather recent ones
20100314 17:44:52-!- boucman|FOSDEM [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20100314 17:46:24< Ivanovic> mordante: you probably got no idea about this one, right? https://gna.org/bugs/index.php?15590
20100314 17:47:17< mordante> Ivanovic, no no idea only that we had this bug before
20100314 17:47:43< mordante> and I think we always marked it upstream either SDL or the videocard driver
20100314 17:47:52< Ivanovic> ah, okay
20100314 17:48:01< mordante> but it shows in gui1 code so I expect it to be old
20100314 17:48:26< CIA-53> ivanovic * r41573 /trunk/ (5 files in 4 dirs): updated German translation
20100314 17:48:27< mordante> the second might be gui2
20100314 17:48:46< mordante> not sure which part shadowmaster converted
20100314 17:49:38-!- boucman|FOSDEM [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20100314 17:52:06< Ivanovic> silene: can you have a look at https://gna.org/bugs/index.php?15514 ?
20100314 17:52:18< Ivanovic> that is: you already had a look, the question is: is the patch that is attached usable?
20100314 17:52:34< Ivanovic> i fear that alink is basically inactive, so i don't expect him to tackle this one anytime soon
20100314 17:54:59< fendrin> Ivanovic: Let me do a last commit to LoW. I want to limit the Multiplayer scenarios to 7. 
20100314 17:55:06< Ivanovic> fendrin: sure
20100314 17:55:30< fendrin> Ivanovic: Everything after scenario 7 is not very tested.
20100314 17:56:18< Ivanovic> mordante: could you review this patch, looks like a real trival one: https://gna.org/patch/?1525
20100314 17:59:21-!- Blarumyrran [~Blarumyrr@81-20-159-197.levira.ee] has quit [Ping timeout: 245 seconds]
20100314 18:00:11-!- Blarumyrran [~Blarumyrr@81-20-159-197.levira.ee] has joined #wesnoth-dev
20100314 18:01:28< Ivanovic> zookeeper: is this a case of plain stupid wml? https://gna.org/bugs/index.php?15375
20100314 18:02:06< Ivanovic> ilor: is this one still valid or is it fixed? https://gna.org/bugs/index.php?15365
20100314 18:05:14< Ivanovic> esr: just went through the more recent bug entries
20100314 18:05:31< Ivanovic> anything in there that is not marked fixed or ready for testing does not look too major
20100314 18:05:57< Ivanovic> at least not important enough to block 1.8, most things are rather tiny things which are in the area of "polishing"
20100314 18:06:34< ilor> Ivanovic: never ran into this one
20100314 18:06:36< mordante> Ivanovic, the patch needs some work, you want me to do it or handle it as a normal patch?
20100314 18:06:57< Ivanovic> handle it as a normal patch since it is a possible SoC student
20100314 18:08:56-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100314 18:09:04< silene> Ivanovic: the patch only fixes a symptom, not the actual bug; i will fix it
20100314 18:09:13< Ivanovic> silene: okay, thanks
20100314 18:09:57< Ivanovic> ilor: would it be much work to make sorting in the player list case insensitive?
20100314 18:10:28< Ivanovic> ilor: do you know about the issue with hitting the update key and elements vanishing then?
20100314 18:10:35< Ivanovic> that is: as if some layering is broken
20100314 18:10:51< Ivanovic> i am not sure if this one is for mordante (who knows about it), or if it is for you
20100314 18:11:24< Ivanovic> basically you do hit the "refresh" button and as result eg the filter elements are hidden and reappear once hovering over them
20100314 18:12:14< Ivanovic> ilor: i could reproduce the button clicking and crash issue
20100314 18:12:18< Ivanovic> wesnoth-svn: /src/wesnoth/src/gui/dialogs/lobby_main.cpp:803: void gui2::tlobby_main::update_gamelist_filter(): Zusicherung >>lobby_info_.games().size() == gamelistbox_->get_item_count()<< nicht erf?llt.
20100314 18:12:34< Ivanovic> yes, i cheated and was on the 1.6.x lobby
20100314 18:12:52< Ivanovic> there i joined a game as observer and directly left (was OOS)
20100314 18:13:03< Ivanovic> afterwards i wanted to toggle off the "frieds" icon
20100314 18:13:09< Ivanovic> my friendlist is empty
20100314 18:13:14< Ivanovic> got the assert above
20100314 18:14:38< Ivanovic> another one in this category, trying the same thing while the lobby was currently refreshing:
20100314 18:14:40< Ivanovic> wesnoth-svn: /src/wesnoth/src/gui/dialogs/lobby_main.cpp:803: void gui2::tlobby_main::update_gamelist_filter(): Zusicherung >>lobby_info_.games().size() == gamelistbox_->get_item_count()<< nicht erf?llt.
20100314 18:15:59< mordante> Ivanovic, the disappearing elements has been reported several times, but no way to reliable reproduce it
20100314 18:16:21< mordante> I also think this is the same cause of the larger clear things that happen every now and then
20100314 18:16:26< CIA-53> fendrin * r41574 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/08_Council_of_hard_choices.cfg: Made LoW MP end after scenario 8.
20100314 18:16:57< mordante> but none again for a long (20 minutes and counting) time here 
20100314 18:17:16< fendrin> Ivanovic: Ready for RC1.
20100314 18:17:25< Ivanovic> fendrin: okay
20100314 18:17:38< mordante> so there definitely is some invalidation issue around, but it's elusive
20100314 18:18:33< Ivanovic> :)
20100314 18:18:55< mordante> doesn't make me happy :-(
20100314 18:19:13< mordante> rather have a good way to reproduce it so it can be fixed...
20100314 18:19:42< Ivanovic> the "hidden elements" stuff *is* easy to reproduce by using the "refresh" button in the main lobby
20100314 18:22:08< mordante> how, because all my attempts thusfar failed
20100314 18:24:01< Ivanovic> ehm, you said that you could reproduce the problems with the filter buttons gone hiding when hitting "refresh" in the mp lobby
20100314 18:24:08< Ivanovic> using 1024x768
20100314 18:25:20< AI0867> Ivanovic: I'm working on a bug, I would like to get the fix into rc1
20100314 18:25:22< mordante> sometimes I can reproduce something once but not repeatably 
20100314 18:25:42< AI0867> https://gna.org/bugs/index.php?15330
20100314 18:25:47< Ivanovic> AI0867: okay, any estimates?
20100314 18:26:00< Ivanovic> mordante: so you can't reproduce this one any longer?
20100314 18:26:27< mordante> I'll test in a clean checkout without my set of test patches
20100314 18:26:35-!- Noyga [~noyga@wesnoth/developer/noyga] has joined #wesnoth-dev
20100314 18:26:41< mordante> just to be sure they don't mess up the test
20100314 18:26:52-!- Noyga [~noyga@wesnoth/developer/noyga] has left #wesnoth-dev []
20100314 18:27:35< zookeeper> Ivanovic, well, yes, it's plain stupid WML, but i'm not sure if the bug is otherwise valid or not...
20100314 18:27:43< AI0867> Ivanovic: shouldn't take more than an hour
20100314 18:27:52< Ivanovic> mordante: okay, can describe the issue better:
20100314 18:28:05< Ivanovic> the background of the game list overwrite all existing foreground
20100314 18:28:19< Ivanovic> mordante: join the 1.6.x lobby with a build with the test version set
20100314 18:28:28< Ivanovic> set display to 1024x768
20100314 18:28:39< Ivanovic> wait till everthing is shown, hit refresh
20100314 18:28:42< AI0867> I would probably be done by now if I wasn't doing the compiling on my netbook, but it's a netbook-specific bug
20100314 18:30:13< Ivanovic> ilor, mordante: http://imagebin.org/88844
20100314 18:30:37< CIA-53> caslav_ilic * r41575 /trunk/ (28 files in 14 dirs): Updated translations for Serbian.
20100314 18:30:38< Ivanovic> as you see in the width it does use all width the game view would use if there were no scrollbars
20100314 18:30:51< mordante> Ivanovic, ok seems more or less reproducible now (/me keeps his fingers crossed it stays that way)
20100314 18:31:26< mordante> btw Ivanovic did you notice the "Games: showing" sneaked back in?
20100314 18:31:37< Ivanovic> yes
20100314 18:32:22< mordante> Ivanovic, I see the cause... the string is no longer translatable
20100314 18:33:30< Ivanovic> outsch!
20100314 18:33:33< mordante> guess the extract script doesn't like VGETTEXT instead of vgettext
20100314 18:33:48< Ivanovic> huge OUTSCH!
20100314 18:33:50< Ivanovic> in fact
20100314 18:35:39< mordante> Ivanovic, can you test whether this patch fixes the issue for you?
20100314 18:35:49-!- ilor [~ilor@wesnoth/developer/ilor] has quit [Ping timeout: 264 seconds]
20100314 18:35:55< mordante> (that is whether the string is put back in the pot files)
20100314 18:36:35< mordante> Ivanovic, this time with a link http://paste.debian.net/64251/ ;-)
20100314 18:40:57< mordante> afk for dinner will look into the lobby afterwards
20100314 18:47:55-!- qemqemqem [~quassel@ip70-177-181-137.dc.dc.cox.net] has quit [Remote host closed the connection]
20100314 18:53:08< Ivanovic> mordante: since CIA is slow atm: your change does work, added it and ran (and commited) a pot-update
20100314 19:00:19< teaser> mordante: updated https://gna.org/bugs/?15561 with information on how to reproduce on my system
20100314 19:02:06< teaser> mordante: found a creepy bug in the mp-lobby that has to do with cut&paste, I would like to describe it here to be able to post a good bugreport
20100314 19:03:11< Ivanovic> Chusslove: the last commit does affect serbian
20100314 19:03:20< Ivanovic> Chusslove: readds several strings from the mp lobby
20100314 19:06:28-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: bbl]
20100314 19:08:47< Chusslove> Ivanovic: Got it, thanks.
20100314 19:08:58< Ivanovic> notifying the i18n list about this
20100314 19:14:49-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Read error: Connection reset by peer]
20100314 19:24:57< CIA-53> ivanovic * r41576 /trunk/po/CMakeLists.txt: patch by Mordante to extract strings marked with VGETTEXT and not just with vgettext
20100314 19:25:31< mordante> Ivanovic, ok the "Games" part shows in German again :-)
20100314 19:26:08< mordante> teaser, ok thanks for the update, what cut and paste bug did you find?
20100314 19:26:19< CIA-53> ivanovic * r41577 /trunk/ (248 files in 25 dirs): 
20100314 19:26:19< CIA-53> pot-update with change to extract strings more reliably (could include new strings in wesnoth and wesnoth-lib, most langs should still have the strings unless the "old strings" section was manually purged!)
20100314 19:26:19< CIA-53> regenerated doc files
20100314 19:26:33< mordante> teaser, you know that the chan is logged?
20100314 19:27:37< CIA-53> silene * r41578 /trunk/src/ (game_events.cpp unit.cpp): Sanitized unit types and exception handling. (Fix for bug #15514.)
20100314 19:28:39< AI0867> Ivanovic: I'm done
20100314 19:29:27< AI0867> shikadibot: log head
20100314 19:29:28< shikadibot> Revision 41583 (ai0867, 2010-03-14 18:28:09 +0000 (Sun, 14 Mar 2010)):
20100314 19:29:28< shikadibot> Fix some documentation
20100314 19:29:28< shikadibot> Web interface URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=41583
20100314 19:29:39< AI0867> shikadibot: log r41582
20100314 19:29:40< shikadibot> Revision 41582 (ai0867, 2010-03-14 18:28:04 +0000 (Sun, 14 Mar 2010)):
20100314 19:29:40< shikadibot> Make set_fullscreen() use detect_video_settings() if the default resolution doesn't work. This fixes bug #15330
20100314 19:29:41< CIA-53> caslav_ilic * r41579 /trunk/po/wesnoth-lib/ (sr.po sr@latin.po): Updated translations for Serbian.
20100314 19:29:43< shikadibot> Web interface URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=41582
20100314 19:29:58 * AI0867 kicks CIA-53 
20100314 19:30:00< CIA-53> ow
20100314 19:30:20< fendrin> silene: Are you an expert with units, unit_type, unit_map and such classes?
20100314 19:31:33< CIA-53> ai0867 * r41580 /trunk/src/ (game.cpp preferences_display.cpp preferences_display.hpp): Move detect_video_settings() into preferences_display
20100314 19:31:43< CIA-53> ai0867 * r41581 /trunk/src/ (game.cpp preferences_display.cpp): Remove unneeded members of game_controller
20100314 19:31:44< CIA-53> ai0867 * r41582 /trunk/src/preferences_display.cpp: Make set_fullscreen() use detect_video_settings() if the default resolution doesn't work. This fixes bug #15330
20100314 19:31:45< CIA-53> ai0867 * r41583 /trunk/src/preferences_display.hpp: Fix some documentation
20100314 19:33:54< silene> fendrin: i know them
20100314 19:34:08< AI0867> wesbot: seen  grzywacz
20100314 19:34:08< wesbot> AI0867: The person with the nick grzywacz last spoke 4d 21h ago.  1d 6h ago was here and on the channel #wesnoth with the message: Remote host closed the connection
20100314 19:34:50< AI0867>  grzywacz: I just finished the refactoring you started 13000 revisions ago
20100314 19:34:55< fendrin> silene: I believe that the assign and copy constructor of unit_map is not working right. 
20100314 19:35:03< silene> why?
20100314 19:35:24< fendrin> Every unit has a member parent which is the unit_map it belongs to.
20100314 19:35:46-!- Blarumyrran [~Blarumyrr@81-20-159-197.levira.ee] has quit [Ping timeout: 264 seconds]
20100314 19:35:48< fendrin> That is not updated during the copy.
20100314 19:37:37-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100314 19:37:48< silene> right, unit_map::insert should have taken care of that; that being said, is the parent member really useful?
20100314 19:39:39< fendrin> silene: The bug is not visible in the game since there is only one unit_map around and no need to assign or copy. But in a multimap envirenment like the editor the wrong parent leads to segfaults during the drawing of the unit.
20100314 19:41:20< silene> fendrin: sure, but what about just getting rid of the parent member?
20100314 19:43:27< shadowmaster> mordante: I only converted the rendering of the story screen text to GUI2, the rest isn't even GUI1, except for the Next and Skip buttons
20100314 19:44:04< mordante> ok shadowmaster 
20100314 19:44:11< shadowmaster> in fact, I'm not sure whether it can be called GUI2 if it's only an application of ttext
20100314 19:44:59< mordante> like I said I'm not sure what you did regarding the conversion
20100314 19:54:26< fendrin> silene: I will try so. Let's see what is using the parent thing.
20100314 19:54:53< shadowmaster> the kind of bugs I'd not expect with software rendering -.-
20100314 19:57:15-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 19:58:01-!- rolando [~rolando@110.183.54.77.rev.vodafone.pt] has joined #wesnoth-dev
20100314 20:00:00< fendrin> silene: Okay, some of the unit's methods would require the extra parent argument. No idea if removing it is a good idea. Fixing the copy constructor and assign method isn't that complicated, is it? 
20100314 20:01:31< silene> fendrin: no it isn't that complicated; but if this member had not been there, there wouldn't have been any bug in the first place, that's why i'm suggesting to remove it
20100314 20:01:47-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Ping timeout: 258 seconds]
20100314 20:02:34< silene> fendrin: and again, it's not the copy and assignment methods that need fixing, it's the insert method
20100314 20:12:33< teaser> mordante: I know about the log, but I prefer talking in realtime... anyway...
20100314 20:13:26-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.]
20100314 20:13:30< teaser> the cut&paste bug is: if i select using shift + 'end' and/or 'home' the client crashes but if I use the arrow-buttons it doeasn't
20100314 20:13:32< fendrin> silene: I have a solution that works in my branch, the question is if that is a bug that needs to be fixed in trunk. If so, before 1.8? 
20100314 20:13:34-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has joined #wesnoth-dev
20100314 20:14:02< fendrin> silene: I have a solution that works in my branch, the question is if that is a bug that needs to be fixed in trunk. If so, before 1.8? 
20100314 20:14:24< silene> i doubt it needs fixing; as you said, there is only one unit map
20100314 20:14:29-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has quit [Changing host]
20100314 20:14:29-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100314 20:15:38< fendrin> silene: I am not sure about that. 
20100314 20:17:09-!- silene [~plouf@wesnoth/developer/silene] has quit [Client Quit]
20100314 20:17:16-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has joined #wesnoth-dev
20100314 20:17:17< teaser> mordante: I found the above bug a few days ago, could reproduce it before but not now...
20100314 20:17:37-!- silene [~plouf@ASte-Genev-Bois-152-1-98-245.w86-203.abo.wanadoo.fr] has quit [Changing host]
20100314 20:17:37-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100314 20:37:48-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Quit: Leaving]
20100314 20:39:26-!- rolando [~rolando@110.183.54.77.rev.vodafone.pt] has quit [Ping timeout: 246 seconds]
20100314 20:44:13< fendrin> Crab_: Do you have some time?
20100314 20:44:25< Crab_> partially
20100314 20:47:42< fendrin> Crab_: I have searched for a method to use your gamestate_inspector architecture for displaying configs.
20100314 20:48:31< fendrin> For that purpose I have derived tinspector class into gamestate_inspector and config_inspector.
20100314 20:58:32< fendrin> The problem is the inner class concept.
20100314 20:58:56< Crab_> why ?
20100314 20:59:39< CIA-53> fendrin * r41584 /branches/fendrin_editor/src/ (4 files in 2 dirs): butchered the gamestate_inspector.
20100314 21:00:39< fendrin> The inner classes of the tconfig_inspector are not used. It always executes the code in tinspector instead.
20100314 21:03:03-!- Desciero [~chatzilla@cpe-069-132-139-120.carolina.res.rr.com] has joined #wesnoth-dev
20100314 21:20:34< Ivanovic> teaser: so https://gna.org/bugs/index.php?15561 is fixed?
20100314 21:21:08< Ivanovic> (that is, in general if you can no longer reproduce an issue, state this in the respective bug report ;) )
20100314 21:21:50< Crab_> fendrin: do you want me to do/suggest something about it ? or you've already figured out the solution ?
20100314 21:22:11< Ivanovic> Crab_: any news about the not MP save macro that is used in dark forecast?
20100314 21:22:32< fendrin> Crab_: I have a solution that doesn't work. So I would like you to review the design. 
20100314 21:22:53< Crab_> Ivanovic: no good news so far. I've got a partial solution that works for a simple testcase but breaks with DF
20100314 21:23:04< Ivanovic> okay
20100314 21:23:58< Ivanovic> Crab_: so what do you think of replacing the macros that are currently used in dark forecast with the mp save ones and documenting in the macro reference that this one is not mp save?
20100314 21:24:28< Ivanovic> (together with a "TODO: make sure this macro is mp save!" ;) )
20100314 21:24:31-!- ilor [~ilor@wesnoth/developer/ilor] has joined #wesnoth-dev
20100314 21:24:41< Crab_> Ivanovic: well, it's definitely possible to do. when do you want to release a next version ?
20100314 21:24:52< Ivanovic> Crab_: uhm, now
20100314 21:24:53< Ivanovic> ;)
20100314 21:25:04< Ivanovic> okay, lets say i take a shower first, read a little and the likes
20100314 21:25:08< Ivanovic> so maybe in one hour?
20100314 21:25:30< Ivanovic> mordante: what do you think, can i name that one rc1?
20100314 21:25:41< Crab_> heh, no, I'm not prepared to do some dirty hacks at the moment. maybe zookeeper can ?
20100314 21:25:41< Ivanovic> that is: looking at the main blocker being the mp lobby
20100314 21:25:50< Ivanovic> zookeeper: around?
20100314 21:26:09< zookeeper> yes
20100314 21:26:10< Ivanovic> zookeeper: can you replace the macros used in dark forecast in a short "search and replace" way?
20100314 21:26:11< Crab_> zookeeper: what do you think about reworking DF to avoid the 'transform unit'/ 'advance unit' macros, as a temporary solution ?
20100314 21:26:27< zookeeper> well, not right now, no
20100314 21:26:43< zookeeper> i had time earlier, but not anymore, sorry :p
20100314 21:26:45< Crab_> ok
20100314 21:27:03< zookeeper> but AFAIK there's no MP-safe transform/advance macros
20100314 21:27:24< Crab_> zookeeper: spawn L2s from the start or ask the ai to recruit them ?
20100314 21:27:26< zookeeper> you'd have to simply create a new [unit], using variables from the stored one
20100314 21:27:51< zookeeper> Crab_, i don't know what you're asking
20100314 21:27:52< Crab_> Ivanovic: what do you think about just commenting out the buggy code, to make the ai only use L1 and L0 units ?
20100314 21:27:56< zookeeper> anyways, i'm off now.. ->
20100314 21:28:02< Ivanovic> Crab_: sounds reasonable
20100314 21:28:18< Ivanovic> Crab_: will you also mark the macros that do transformation and whatever as "not mp save" for the moment?
20100314 21:28:35< Ivanovic> since zookeeper already said that it looks like atm all of them are not safe to use
20100314 21:28:44-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100314 21:28:48< Crab_> Ivanovic: they're MP safe in some conditions...
20100314 21:31:26< Ivanovic> better mark them that they should be seen as "unsafe" and might be broken
20100314 21:38:01-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 21:38:06-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Client Quit]
20100314 21:38:18-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 21:42:31-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100314 21:42:31-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Read error: Connection reset by peer]
20100314 21:43:08-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has joined #wesnoth-dev
20100314 21:48:10< mordante> teaser, I just mentioned it if it was security related
20100314 21:48:42< mordante> teaser, what kind of crash assertion failure or silent error?
20100314 21:50:31< mordante> Ivanovic, I'll see whether I can find a solution for the redraw issue
20100314 21:59:37-!- elias [~elias@allegro/developer/allefant] has quit [Quit: Leaving]
20100314 22:00:16< zookeeper> Crab_, Ivanovic, ok, now i have time again
20100314 22:00:22< zookeeper> need help?
20100314 22:00:52< Crab_> zookeeper: the idea is to do a quick fix of DF
20100314 22:01:23< zookeeper> i asked if you wanted that when we last talked about it and you said you'd rather fix the engine ;P
20100314 22:01:35< zookeeper> but yeah, i can try to write a quick fix
20100314 22:01:37< Crab_> zookeeper: yes, but Ivanovic wants to release something fixed :)
20100314 22:05:09< CIA-53> fendrin * r41585 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/19_Costly_Revenge.cfg: LoW 19: Rearanged the music playlist.
20100314 22:06:17< zookeeper> ok, working on it...
20100314 22:07:43< Crab_> zookeeper: one of the ways to avoid that transform is to just create new [unit]s instead of transforming old ones..
20100314 22:08:03-!- migge [~marc@ip-95-223-247-31.unitymediagroup.de] has joined #wesnoth-dev
20100314 22:08:11< Crab_> it should work because there'll be no '[unstore_unit] advance=true' problems
20100314 22:10:58-!- migge_ [~marc@ip-95-223-247-31.unitymediagroup.de] has quit [Ping timeout: 248 seconds]
20100314 22:12:22-!- Blueblaze [~nick@adsl-99-158-47-51.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100314 22:13:22< zookeeper> eh, do all DF spawned units have the name "none"?
20100314 22:13:28< zookeeper> that's what the WML looks like it's doing...
20100314 22:20:39< zookeeper> i guess not
20100314 22:20:54-!- dtiger [~dtiger@dynamic-vpdn-91-149-132-203.telecom.by] has quit [Remote host closed the connection]
20100314 22:21:56< zookeeper> does the game treat name="none" specially? all the spawn [unit]s have that, yet they receive normal random names.
20100314 22:22:14< AI0867> zookeeper: is generate_name=yes set?
20100314 22:22:22< zookeeper> no
20100314 22:22:23< AI0867> name would probably be ignored in that case
20100314 22:22:26< AI0867> odd
20100314 22:25:55< CIA-53> zookeeper * r41586 /trunk/data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Likely fix for the Dark Forecast OOS.
20100314 22:26:14< zookeeper> ok, that removes the TRANSFORM_UNIT and replaces it with a regular [unit]...please test
20100314 22:26:35< silene> generate_name=yes is the default, so unless it is explicitly "no", names will be generated
20100314 22:27:07< zookeeper> silene, that can't be right, because named units don't have generate_name=no
20100314 22:27:52< silene> zookeeper: let me rephrase, unit without names and without generate_name=no get random names
20100314 22:28:05< zookeeper> silene, yes, of course
20100314 22:29:09-!- jabagawee [~45e71935@gateway/web/freenode/x-yehxjagsilmtcinu] has quit [Disconnected by services]
20100314 22:29:28-!- jabagawee [~andrew@unaffiliated/jabagawee] has joined #wesnoth-dev
20100314 22:31:11 * zookeeper pokes Crab_ with r41586
20100314 22:31:25< Crab_> zookeeper: ok, I'll test it :)
20100314 22:31:33< Crab_> thanks
20100314 22:33:28-!- Espreon [~espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20100314 22:33:37-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20100314 22:33:45< silene> zookeeper: {CLEAR_VARIABLE spawns[$id].name}; spawned units don't have names (just in case you haven't noticed it already)
20100314 22:34:42< [Relic]> Hello :)
20100314 22:35:39< Ivanovic> taking a shower now, i plan to release in some 30mins
20100314 22:36:37< Ivanovic> AI0867, Chusslove, Crab_, crimson_penguin, Espreon, esr, fendrin, ilor, loonycyborg, mordante, shadowmaster, silene, Soliton, zookeeper, everyone else who cares: 1.8rc1 planned in some 30mins
20100314 22:37:39< zookeeper> silene, right, i had missed that
20100314 22:37:47< crimson_penguin> but... but... man, this has been a lot of uploading lately :P
20100314 22:37:49-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20100314 22:37:56< Ivanovic> crimson_penguin: yes
20100314 22:37:57< mordante> Ivanovic, I found a way to reproduce the unwanted clearing, not sure whether I find a solution in 30min
20100314 22:38:05-!- teaser [~teaser@h-37-106.A254.priv.bahnhof.se] has quit [Ping timeout: 246 seconds]
20100314 22:38:12< Ivanovic> mordante: okay
20100314 22:38:24< Ivanovic> mordante: if you are "close" to a fix, ping me and i can delay a little
20100314 22:38:33< Ivanovic> (eg till tomorrow in the afternoon)
20100314 22:38:49< Ivanovic> or just for some 30 more mins
20100314 22:40:01< silene> zookeeper: that being said, i don't know what's the point of generating them with name "none" first, then regenerating them with random names
20100314 22:40:24< esr> Ivanovic: Noted.
20100314 22:41:40< AI0867> zookeeper: actually, generate_name doesn't work if there's already a name set
20100314 22:41:57< Espreon> Ivanovic: I'm fine.
20100314 22:42:03< zookeeper> silene, errh, some ridiculously unnecessary hack i think. at one place there's an [if] check for whether the name is "none" or not...yet it doesn't look like it does anything
20100314 22:42:33< silene> zookeeper: the "unit_name" thing? where is that variable even set?
20100314 22:42:34-!- wesbot changed the topic of #wesnoth-dev to: string/feature freeze active! | 70 bugs, 253 feature requests, 13 patches | logs: http://irclogs.wesnoth.org/ | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100314 22:42:48< zookeeper> silene, exactly...nowhere
20100314 22:43:08< zookeeper> i think i might have removed the setting previously
20100314 22:43:26< zookeeper> but looks like it works anyway
20100314 22:43:27 * zookeeper shrugs
20100314 22:45:05< mordante> Crab_, https://gna.org/bugs/index.php?14114 is an easycoding task?
20100314 22:46:07< Crab_> mordante: yes, very easy coding. for GSoCers. I'm surprised that there's no patches yet.
20100314 22:46:31< mordante> Crab_, well jabagawee is looking for an easy coding bug
20100314 22:47:04< Crab_> well, two people are already looking at that bug. 3 might be too much :)
20100314 22:48:54< zookeeper> looks like DF was mainlined for 1.4...there's hardly any excuse for its code quality
20100314 22:49:08< Crab_> zookeeper: yeah
20100314 22:49:16< mordante> Crab_, you know who's working on it?
20100314 22:50:19< Crab_> mordante: lucifernando
20100314 22:51:33-!- Gambit [~Gambit@pa-67-234-116-244.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100314 22:51:37< zookeeper> Crab_, so did you test it already? i'm going to bed in a few minutes so if there's anything further for me to do, i'd like to know ASAP..
20100314 22:53:45< Crab_> zookeeper: testing atm
20100314 22:53:58< Crab_> zookeeper: 2 minutes...
20100314 22:54:03< zookeeper> ok
20100314 22:55:23< Crab_> zookeeper: yes, the main issue looks fixed. thanks!
20100314 22:55:31-!- Appleman1234 [~Appleman1@131.181.102.139] has joined #wesnoth-dev
20100314 22:57:39-!- Tesafilmchen [~quassel@p5B277D63.dip.t-dialin.net] has quit [Ping timeout: 265 seconds]
20100314 23:00:45< zookeeper> Crab_, awesome
20100314 23:01:32-!- Appleman1234 [~Appleman1@131.181.102.139] has quit [Ping timeout: 246 seconds]
20100314 23:01:34 * zookeeper suggests scrapping both DF and ANL in 1.9
20100314 23:02:24< Crab_> zookeeper: push them out to UMC ?
20100314 23:03:07< zookeeper> just push them out, whether to UMC or to oblivion ;)
20100314 23:03:27< zookeeper> but yeah, converting them to UMC would be trivial so no reason not to do that
20100314 23:06:04< zookeeper> what i'd really like most would be if we got the right people together to design some new MP scenarios for mainline
20100314 23:07:24< CIA-53> fendrin * r41587 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/ (19_Costly_Revenge.cfg 23_End_of_War.cfg): LoW 19 + 23: Last minute playlist changes.
20100314 23:07:44< zookeeper> instead of adapting an existing UMC, since usually those have way less than ideal implementation
20100314 23:08:12< zookeeper> anyways, i'm off to bed... ->
20100314 23:08:14-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100314 23:12:01< Ivanovic> re
20100314 23:12:13< Ivanovic> mordante: so how are things looking regarding the "hidden elements"?
20100314 23:12:55< Crab_> Ivanovic: so, zookeeper fixed DF, by removing the usage of MP-unsafe '[unstore_unit]advance=true', without functionality loss.
20100314 23:13:07< Ivanovic> great
20100314 23:13:25< Crab_> no changelogs were harmed during the fix :)
20100314 23:13:35< Ivanovic> :)
20100314 23:13:51< Crab_> I'll do so now
20100314 23:14:00< Ivanovic> though you should add it to the changelog since it was a player visible change and fixing a reported bug
20100314 23:14:02< Ivanovic> okay,thanks
20100314 23:15:50< mordante> Ivanovic, still working on it, debugging is annoying... gdb segfaults
20100314 23:16:07< Ivanovic> ugh
20100314 23:16:17< Ivanovic> okay, will give you some 30more mins
20100314 23:16:27-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100314 23:17:01< mordante> no guarantees on success in that time
20100314 23:17:13< mordante> but I really prefer to have that issue fixed before the rc
20100314 23:17:38< Ivanovic> so do i
20100314 23:17:58< Ivanovic> i will wait as long as i can while still having a reasonable time for packaging before i got to get to bed
20100314 23:18:17< mordante> at least I can now reproduce it 100% reliable :-)
20100314 23:18:19< Ivanovic> that is i got to get up "too early" tomorrow due to a meeting i got at university about my final thesis
20100314 23:18:42< mordante> so you need to get up at 12:00 :-P
20100314 23:18:45< Ivanovic> my comp will be running anyway over the night, so i can upload anyway
20100314 23:18:53< Ivanovic> no, i got to leave my home at 12
20100314 23:19:00< Ivanovic> but am currently used to sleep till past 11...
20100314 23:19:02< Ivanovic> ;)
20100314 23:22:40< mordante> my alarm will be much earlier :-(
20100314 23:22:41-!- Iskander [~Iskander@colander-ua.cosmonova.net.ua] has quit [Read error: Connection reset by peer]
20100314 23:23:06< loonycyborg> Ivanovic: Because you go to bed at 4AM? :P
20100314 23:23:29 * Espreon goes to bed at around six... seven o'clock AM on weekends.
20100314 23:24:27< Ivanovic> loonycyborg: nah, i go to bed at about 1am
20100314 23:24:34< Ivanovic> (and read a little then...)
20100314 23:28:01< Ivanovic> Espreon: i go to bed and get up about the same time no matter if in the middle of the week or at weekend...
20100314 23:28:17< Ivanovic> (yeah, being a student who just has the final thesis open is *nice*)
20100314 23:28:30< Espreon> Heh...
20100314 23:29:20-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100314 23:31:17-!- stikonas [~and@ctv-79-132-179-139.vinita.lt] has joined #wesnoth-dev
20100314 23:31:17-!- stikonas [~and@ctv-79-132-179-139.vinita.lt] has quit [Changing host]
20100314 23:31:17-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100314 23:32:42-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.]
20100314 23:34:59-!- Mythological [Mythologic@77.28.113.246] has joined #wesnoth-dev
20100314 23:39:54-!- Appleman1234 [~Appleman1@131.181.47.1] has joined #wesnoth-dev
20100314 23:42:28< Ivanovic> okay, sent a mail with my current plans to the dev-ml informing everyone how soon 1.8 is planned
20100314 23:42:39< Ivanovic> (including the transition of trunk to the 1.9 development)
20100314 23:43:26< Ivanovic> silene, AI0867: http://forums.wesnoth.org/viewtopic.php?p=415174#p415174
20100314 23:53:30-!- Appleman1234 [~Appleman1@131.181.47.1] has quit [Ping timeout: 252 seconds]
20100314 23:53:36< AI0867> I was probably wrong about the commit I referenced
20100314 23:53:38< AI0867> it's way too old
20100314 23:56:26-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Quit: WRYYYYYYYYYYYYYYYYYYYY!]
20100314 23:58:47< Ivanovic> doesn't matter
20100314 23:59:03< Ivanovic> what matters is, that the functionality is somewhere documented in the way it is (currently) meant to be
--- Log closed Mon Mar 15 00:00:50 2010