--- Log opened Thu May 20 00:00:00 2010
20100520 00:00:09-!- YogiHH [YogiHH@80.171.98.68] has joined #wesnoth-dev
20100520 00:00:24-!- YogiHH [YogiHH@80.171.98.68] has quit [Changing host]
20100520 00:00:24-!- YogiHH [YogiHH@wesnoth/developer/yogihh] has joined #wesnoth-dev
20100520 00:00:35< YogiHH> hello
20100520 00:01:27-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20100520 00:12:20-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100401080539]]
20100520 00:34:41-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100520 00:37:08-!- drusepth [~drusepth@dhcp-077-249-151-209.chello.nl] has quit [Remote host closed the connection]
20100520 00:39:13-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20100520 01:32:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Operation timed out]
20100520 01:35:37-!- YogiHH [YogiHH@wesnoth/developer/yogihh] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100401080539]]
20100520 01:43:55-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has quit [Quit: Leaving]
20100520 01:46:59-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has joined #wesnoth-dev
20100520 01:58:24-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20100520 01:59:06-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20100520 02:01:25-!- Tigge [~tigge@c-e3a272d5.015-28-73746f34.cust.bredbandsbolaget.se] has quit [Read error: Operation timed out]
20100520 02:05:00-!- norbert_ [~norbert@82-171-70-54.ip.telfort.nl] has quit [Quit: Leaving]
20100520 02:08:20-!- Zarel is now known as Zarel|AFK
20100520 02:20:39-!- Netsplit *.net <-> *.split quits: Skystriker
20100520 02:20:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20100520 02:21:31-!- Ivanovic [~ivanovic@dtmd-4db2b1d8.pool.mediaWays.net] has joined #wesnoth-dev
20100520 02:22:05-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has quit [Quit: Leaving]
20100520 02:22:26-!- Netsplit over, joins: Skystriker
20100520 02:23:38-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Quit: Leaving]
20100520 02:37:18-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has joined #wesnoth-dev
20100520 02:41:11-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20100520 02:47:58-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Remote host closed the connection]
20100520 02:49:20-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100520 02:49:55-!- shadowm_laptop is now known as shadowm
20100520 02:51:00-!- shadowm is now known as shadowm_laptop
20100520 02:57:15-!- Skystriker [~croselius@pool-70-111-210-233.nwrk.east.verizon.net] has quit [Ping timeout: 240 seconds]
20100520 03:10:35-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds]
20100520 03:11:05-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100520 03:12:28-!- Zarel|AFK [~Zarel@warzone2100/developer/Zarel] has quit [Ping timeout: 240 seconds]
20100520 03:53:47-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100520 03:56:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 04:05:59-!- Ivanovic_ [~ivanovic@dtmd-4db23a77.pool.mediaWays.net] has joined #wesnoth-dev
20100520 04:09:14-!- Ivanovic [~ivanovic@dtmd-4db2b1d8.pool.mediaWays.net] has quit [Ping timeout: 240 seconds]
20100520 04:09:57-!- Ivanovic_ is now known as Ivanovic
20100520 04:13:31< Espreon> wesbot: seen Chusslove ?
20100520 04:13:31< wesbot> Espreon: The person with the nick Chusslove 24d 2h ago they left with the message: Read error: Operation timed out
20100520 04:13:36< Espreon> Damn it!
20100520 04:14:13-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Quit: Hi! I'm a quit message virus vaccine. If you see a quit message virus, don't replace your quit message with it!]
20100520 04:19:03-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowmaster] has quit [Quit: You are doing it right!]
20100520 04:58:40-!- FAAB [~huajie@219.142.224.248] has joined #wesnoth-dev
20100520 05:28:39-!- Gambit [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Read error: Connection reset by peer]
20100520 05:39:26-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100520 05:44:16< CIA-10> silene * r42729 /trunk/src/terrain_filter.cpp: Propagated with_border parameter to nested location computations. (Fix for bug #16052.)
20100520 05:45:51-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20100520 05:55:41-!- Vetinari_ [~lukjad007@unaffiliated/lukjad007] has joined #wesnoth-dev
20100520 05:55:48-!- coder_ [~pattihess@75.143.233.138] has joined #wesnoth-dev
20100520 05:57:17< coder_> hey, does anyone know where a full one-shot-deal WML reference is, that would be easy to print out and read from paper?
20100520 05:58:32-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 06:00:03-!- Netsplit *.net <-> *.split quits: noy, Vetinari
20100520 06:00:03-!- noy_ is now known as noy
20100520 06:00:19< coder_> crimson_penguin, you there?
20100520 06:00:37< CIA-10> silene * r42730 /branches/1.8/src/terrain_filter.cpp: 
20100520 06:00:37< CIA-10> Propagated with_border parameter to nested location computations. (Fix for bug #16052.)
20100520 06:00:37< CIA-10> Backported from trunk r42729.
20100520 06:06:17< crimson_penguin> coder_: yeah, but I'm working
20100520 06:07:14< coder_> ok cool, real quick, do you know of one? (see first message)
20100520 06:09:36< crimson_penguin> nope
20100520 06:09:50< crimson_penguin> I don't know a whole lot that doesn't have to do with Mac packaging - sorry
20100520 06:11:20< coder_> thanks anyway
20100520 06:26:10-!- FAAB [~huajie@219.142.224.248] has quit [Ping timeout: 264 seconds]
20100520 06:30:41< AI0867> lj
20100520 06:39:48-!- coder_ [~pattihess@75.143.233.138] has quit [Read error: Connection reset by peer]
20100520 06:42:19-!- FAAB [~huajie@219.142.234.90] has joined #wesnoth-dev
20100520 06:58:52< AI0867> boucman: the animation works, the problem is moving the fake units. The move_unit() call is commented out to concentrate on the status of the fake units: the units clearly move, but the sprites don't
20100520 07:00:42-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has joined #wesnoth-dev
20100520 07:01:35-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has quit [Client Quit]
20100520 07:01:52-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has joined #wesnoth-dev
20100520 07:01:52-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has quit [Changing host]
20100520 07:01:52-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20100520 07:04:11-!- Crab_ [~Crab@wesnoth/developer/crab] has joined #wesnoth-dev
20100520 07:09:50< AI0867> boucman: never mind, this seems to have fixed it (I should read the entire log before replying)
20100520 07:11:02-!- valgor [~596fb03c@gateway/web/freenode/session] has joined #wesnoth-dev
20100520 07:11:37-!- valgor [~596fb03c@gateway/web/freenode/session] has quit [Client Quit]
20100520 07:22:23< FAAB> hi Crab_, thanks for your comment on my patch. I will send a fix when I am done.
20100520 07:22:36< Crab_> ok
20100520 07:22:56< Crab_> in general, you've done somewhat more than was necessary :)
20100520 07:32:24-!- Crab__ [~Crab@195.238.92.115] has joined #wesnoth-dev
20100520 07:33:33-!- Crab__ [~Crab@195.238.92.115] has quit [Read error: Connection reset by peer]
20100520 07:34:09-!- Crab__ [~Crab@195.238.92.115] has joined #wesnoth-dev
20100520 07:34:17-!- Crab__ [~Crab@195.238.92.115] has quit [Changing host]
20100520 07:34:17-!- Crab__ [~Crab@wesnoth/developer/crab] has joined #wesnoth-dev
20100520 07:34:27-!- Crab_ [~Crab@wesnoth/developer/crab] has quit [Ping timeout: 258 seconds]
20100520 07:34:50-!- Crab__ is now known as Crab_
20100520 07:35:21-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100520 07:52:36-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20100520 07:56:25-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20100520 07:58:42-!- ancestral [~ancestral@97-116-112-18.mpls.qwest.net] has joined #wesnoth-dev
20100520 07:59:28-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has quit [Ping timeout: 265 seconds]
20100520 08:04:33-!- Tigge [~tigge@bacchus.olf.sgsnet.se] has joined #wesnoth-dev
20100520 08:07:04-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100520 08:15:25-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100520 08:15:36< timotei> hello Crab_
20100520 08:15:59< Crab_> hi, timotei
20100520 08:16:17< Crab_> how it's going ? have you solved the 'launch external app' issues ?
20100520 08:17:36< timotei> Crab_: I wanted yo ask you to test it aswell. for me is working ok (thanks to AI0867 for poiting the issue)
20100520 08:18:03< Crab_> ok, show me the code
20100520 08:18:03< timotei> but on fendrin's PC the launch of the editor freezes his eclipse(the one which contains the runned plugin)
20100520 08:18:11< timotei> Crab_: it's commited
20100520 08:18:20< Crab_> do you consume the stdout/stderr of the editor ?
20100520 08:18:27< timotei> Crab_: yeah
20100520 08:18:37-!- Upthorn [~ogmar@69.62.144.108] has quit [Disconnected by services]
20100520 08:18:38-!- orn [~ogmar@69.62.144.108] has joined #wesnoth-dev
20100520 08:18:38-!- orn is now known as Upthorn
20100520 08:18:42< timotei> but I start it in another thread
20100520 08:20:52< timotei> brb eating, and then need to leave
20100520 08:26:08< Crab_> timotei: yes, there's code in there that can lead to not-that-good things depending on the system scheduler.
20100520 08:27:53< Crab_> timotei: but that depends on how eclipse handles those code wrt threads, I'll take a look at it (somewhen around +20h)
20100520 08:28:50< timotei> back
20100520 08:28:57< timotei> well... ok
20100520 08:29:28< AI0867> I couldn't actually test it, but I'm glad my change worked
20100520 08:30:10< timotei> for we it was logically both ways... but if eclipse minds if we pass the whole string as arguments, its ok
20100520 08:30:16< timotei> s/we/me
20100520 08:30:32< Crab_> timotei: if OpenEditorHandler.execute blocks the ui thread while it's running, then the sleep/poll in while(!toolInvoker.processEnded()) will block the ui thread, too.
20100520 08:30:53< Crab_> timotei: passing whole strings will work, too, but the command line needs to be formatted slightly differently
20100520 08:31:09< timotei> Crab_: damn it, you're right
20100520 08:31:22< timotei> forgot about that "infinite" cycle+ Thread.Sleep
20100520 08:31:31< timotei> ok, I'll fix that when I get back
20100520 08:32:05< timotei> I have to go now,
20100520 08:32:06< Crab_> timotei: I am not fully sure, because I don't know atm from which thread  OpenEditorHandler.execute runs
20100520 08:32:17< AI0867> If I read the docs correctly, ProcessBuilder either takes a List of String, or a variadic amount of strings
20100520 08:32:32< timotei> Crab_: it's worth trying that
20100520 08:32:37< timotei> good bye
20100520 08:32:42-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100520 08:32:44< AI0867> in either case, the first string is the command to execute, and the rest are an argument each
20100520 08:33:26< cjhopman_> for anybody who is well-versed in wml preprocessing, I have some questions.... or rather I have some wml samples and want to know if the preprocessed results are well-defined
20100520 08:33:49< cjhopman_> see http://wesnoth.pastebin.com/HTP5DQWw and http://wesnoth.pastebin.com/Ru1BivTf
20100520 08:35:27< AI0867> that doesn't look well-defined at all to me
20100520 08:35:38< Crab_> cjhopman_: silene is the person to ask.
20100520 08:35:49< cjhopman_> AI0867: that's what I'm hoping
20100520 08:36:28< AI0867> but yes, silene is the person to ask
20100520 08:36:43< AI0867> at least the first of the two, the second looks halfway reasonable
20100520 08:37:02< Crab_> afair, there's a reason for the first, too.
20100520 08:37:39< AI0867> there is, but it's mostly just implementation details you're seeing
20100520 08:37:48< AI0867> not actual specified behaviour
20100520 08:40:20< Crab_> but, can the preprocessor directives be nested ?
20100520 08:41:13< cjhopman_> you can't normally have a #define in another #define... but if you insert it indirectly by bringing in another file it passes the preprocessor
20100520 08:41:14< Crab_> first example has #undef inside #define, second has #define inside a #define
20100520 08:41:21< cjhopman_> yeah i know
20100520 08:41:36< Crab_> wiki says 'As a result, you should not write a recursive macro, because it will cause errors (but, alas, not necessarily error messages).'
20100520 08:41:36< cjhopman_> I think it should be an error, or at least undefined behaviour
20100520 08:41:58< cjhopman_> thats more referring to doing "#define FOO \ {FOO} \ #enddef"
20100520 08:42:45< Crab_> yes, but those examples are handled in similar way.
20100520 08:44:18< cjhopman_> kind of... again, I think they should be considered errors... but I don't know if similar nesting is used in current wml somewhere
20100520 08:44:35< FAAB> Crab_: can you elaborate on how critical it is not to touch get_default_ai_parameters() ?
20100520 08:45:12< FAAB> for me it is just doing the same as calling get_ai_config_for("default")
20100520 08:45:35< Crab_> FAAB: default ai parameters are 'default fallback values for AI'. so, if it is not included in the config, then the ai author will need to provide the value for every and each current ai parameter.
20100520 08:45:41< FAAB> if I searched well it is only used in src/ai/manager.cpp
20100520 08:46:56< Crab_> FAAB: see '//insert default config at the beginning' line in configuration.cpp
20100520 08:47:06< Crab_> FAAB: basically, you do not need to touch it.
20100520 08:47:19< Crab_> FAAB: since it is not used for customizing the ai.
20100520 08:47:37< Crab_> FAAB: it's only used to provide default values, to avoid hardcoding them in C++.
20100520 08:48:02< CIA-10> zookeeper * r42731 /trunk/data/campaigns/Son_Of_The_Black_Eye/images/units/orcish-watch-tower.png: Updated the shadow of the orcish watchtower.
20100520 08:48:11< Crab_> FAAB: see data\ai\utils\default_config.cfg
20100520 08:50:44< Crab_> and, get_ai_config_for() is different, it gets the actual ai config, from ai_configurations_ or era_ai_configurations_ , you've done with it already.
20100520 08:51:49< Crab_> the config that get_default_ai_parameters()  gives you is not one of the objects that get_ai_config_for() can give you, it's different.
20100520 08:54:08< Crab_> FAAB: if i'd wanted to implement the feature you're doing, I'd extended struct description in configuration.hpp to hold a 'int sort_order_' value
20100520 08:55:01< Crab_> and then, in the game creations screen, I'd sort the std::vector<description*> that  ai::configuration::get_available_ais() creates for me, by that priority, desc.
20100520 08:56:13< Crab_> then, the list of ais would be sorted down by that priority, and era ais would be able to specify their priorities, thus enabling the era author to sort the era ai list according to his wishes.
20100520 08:56:21-!- Ivanovic [~ivanovic@dtmd-4db23a77.pool.mediaWays.net] has quit [Changing host]
20100520 08:56:21-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100520 08:56:45< FAAB> Crab_: do you mean the sort id being set through WML ?
20100520 08:57:08< Crab_> yes, the description struct is generated as we parse the ai config we get from wml
20100520 08:58:10< Crab_> so, it's just something like desc.sort_order = lexical_cast_default<int>(ai_configuration["score"],0);
20100520 08:58:22< Crab_> s/score/sort_order
20100520 08:59:03< FAAB> so the sort_order for the default AI would be 0 ?
20100520 08:59:58< Crab_> yes, it will end up like this.
20100520 08:59:59< FAAB> and you set a sort_order to anything positive if you want to replace the default AI
20100520 09:00:07< Crab_> or <0 for development ais
20100520 09:00:09< Crab_> yes
20100520 09:00:27< Crab_> the sort can be done in configuration::get_available_ais(), too
20100520 09:00:39< Crab_> it's just a 1-liner in there
20100520 09:01:40< Crab_> as you have a temp vector with pointers, ais_list, and can sort it by the sort_order of the dereferenced element, descending.
20100520 09:02:20< FAAB> That sound a good idea, less ifs everywhere ;) how would it impact the selection of AI when using the droid command ?
20100520 09:02:54< Crab_> it will not, and, imo, it should not.
20100520 09:02:55< FAAB> would that help me to implement that feature too ?
20100520 09:03:22< Crab_> the droid command uses the ai which is already specified for the given side.
20100520 09:03:53< Crab_> so, if you want the droid to use the most high-priority ai, you should do it at game creation, by adding the ai configs of the 'first' available ai to human players
20100520 09:07:02< FAAB> Crab_: I haven't found how the setting of the AI to human player uses the get_available_ai
20100520 09:07:58-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100520 09:08:15< Crab_> well, currently, no AI is set for human players, so, if scenario hasn't got any AI for human side, it is threated as upgrade from old version which explicitly uses testing_ai_default ai.
20100520 09:08:26< Crab_> s/threated/treated
20100520 09:08:44< Crab_> so, you need to add the ai for human sides at game creation screen
20100520 09:08:50< Crab_> exactly as it is done for AIs
20100520 09:09:27< Crab_> you must treat the 'human player selected for side 1' as 'first ai is selected for side 1, and the controller is human'
20100520 09:10:52< Crab_> FAAB: see case CNTR_COMPUTER in multiplayer_connect.cpp : 669
20100520 09:11:45< Crab_> (for now, assume that allow_player implies the fact that the ai for that side is not set by scenario)
20100520 09:12:54< Crab_> so, those lines in which are inside 'if (allow_player_)' will need to be used with human sides, too.
20100520 09:13:51< Crab_> so, that const config &ai_cfg = ai::configuration::get_ai_config_for(ai_algorithm_); should be made for them, too, and ai_algorithm_ should be set to the 'most high sorted ai'
20100520 09:13:58< FAAB> Crab_: I am a bit lost, my code reading made me think when droiding the AI is set in get_or_create_ai_stack_for_side
20100520 09:14:10< Crab_> yes, but it uses the side config
20100520 09:14:19< Crab_> so, we need to set that side config beforehand.
20100520 09:14:24< Crab_> and it's set at game creation
20100520 09:14:31< FAAB> using the default constructor for ai_ in holder that is composite_ai_ptr
20100520 09:14:34< Crab_> in config connect::side::get_config()
20100520 09:15:28< Crab_> FAAB: see the parameter cfg  in  holder::holder( side_number side, const config &cfg )
20100520 09:15:41< Crab_> FAAB: as you can see, the ai which is created is based on that cfg
20100520 09:15:57< Crab_> FAAB: so, the code in ai::holder needs to respect that cfg.
20100520 09:16:42< Crab_> so, the initialization in ai::holder is 'too late' to do anything.
20100520 09:16:59< FAAB> ok
20100520 09:17:34< Crab_> the 'last chance' to change something is in team_info constuctor, which does the ai::manager::add_ai_for_side_from_config(side, cfg, true); call
20100520 09:18:38< Crab_> but, at that point you can't access the list of ais from ai::configuration, since teams are constructed on all the network machines independently
20100520 09:18:57< Crab_> so, you need to put all the info into side config beforehand.
20100520 09:19:22< FAAB> I think understand now
20100520 09:19:25< Crab_> and, the place to do that is game creation, since only 1 side (the host) determines the initial game config
20100520 09:21:21< FAAB> so I will do it with the sort order and see if I can address both situations (AI controller and droid) in a single patch
20100520 09:22:10< Crab_> FAAB: ok. you can split patches, since the first one is easy to do and the second is trickier.
20100520 09:24:21< FAAB> Crab_: yeah that was my feeling too. I will see how it fares. Thanks a lot for your time !
20100520 09:24:33< Crab_> ok, good luck to you :)
20100520 09:24:55< Crab_> the thing to verify with the second part: hit :inspect and see that the player side has got the correct ai config.
20100520 09:34:14-!- Bocom__ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100520 09:34:40-!- Bocom_ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Read error: Connection reset by peer]
20100520 09:40:58-!- Bocom__ is now known as Bocom
20100520 09:41:45< CIA-10> zookeeper * r42732 /trunk/data/campaigns/Liberty/images/units/undead-skeletal/ (4 files): Added the death squire's and skeleton rider's attack animations, forgotten in r42722.
20100520 09:45:27-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has quit [Ping timeout: 276 seconds]
20100520 09:51:13-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20100520 09:59:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: GO, GET TO THE CHOPPAH!!!]
20100520 09:59:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 10:13:25< CIA-10> zookeeper * r42733 /trunk/ (3 files in 2 dirs): Changed Scavenger's crediting as requested.
20100520 10:18:40< CIA-10> zookeeper * r42734 /branches/1.8/ (3 files in 2 dirs): Ported r42733 to 1.8.
20100520 10:27:15-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Read error: Operation timed out]
20100520 10:27:27-!- Smar [smar@freenet/translator/finnish/Smar] has quit [Read error: Operation timed out]
20100520 10:27:29-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20100520 10:28:40-!- Blueblaze [~nick@adsl-99-182-52-253.dsl.hstntx.sbcglobal.net] has quit [Remote host closed the connection]
20100520 10:28:46-!- ancestral [~ancestral@97-116-112-18.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20100520 10:29:03-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Read error: Operation timed out]
20100520 10:31:08-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20100520 10:31:09-!- Smar [smar@smar.fi] has joined #wesnoth-dev
20100520 10:31:09-!- Smar [smar@smar.fi] has quit [Changing host]
20100520 10:31:09-!- Smar [smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev
20100520 10:34:43-!- Valkier [~karasawa@c-174-55-104-2.hsd1.pa.comcast.net] has quit []
20100520 10:40:20-!- loonybot [~loonybot@ppp79-139-141-74.pppoe.spdop.ru] has joined #wesnoth-dev
20100520 10:40:20-!- loonybot [~loonybot@ppp79-139-141-74.pppoe.spdop.ru] has quit [Changing host]
20100520 10:40:20-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100520 10:41:10-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100520 10:53:28< CIA-10> zookeeper * r42735 /trunk/data/ (9 files in 2 dirs): Wired the AI controller in to all appropriate SotBE scenarios.
20100520 11:04:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100520 11:22:34-!- FAAB [~huajie@219.142.234.90] has quit [Quit: Leaving.]
20100520 11:24:55-!- stikonas [~and@bcm-131-111-247-104.girton.cam.ac.uk] has joined #wesnoth-dev
20100520 11:24:55-!- stikonas [~and@bcm-131-111-247-104.girton.cam.ac.uk] has quit [Changing host]
20100520 11:24:55-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100520 11:45:06-!- Vetinari_ is now known as Vetinari
20100520 11:55:16-!- wesbot changed the topic of #wesnoth-dev to: 105 bugs, 280 feature requests, 18 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20100520 11:59:16-!- fkhodkov [~fedor76@ppp-78-24-25-100-bras0.istra.ru] has joined #wesnoth-dev
20100520 12:10:09< Ivanovic> moin
20100520 12:12:55-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100520 12:41:51< timotei> serus
20100520 12:43:52< Crab_> hi, timotei
20100520 12:44:07< timotei> hi Crab_
20100520 12:47:42-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev
20100520 12:59:14< CIA-10> zookeeper * r42736 /trunk/data/core/ (17 files in 3 dirs): Added latest version of Alarantalara's mine cart tracks.
20100520 13:21:35-!- Gallaecio [~555b5a28@gateway/web/freenode/x-tfmfinddbaybedep] has joined #wesnoth-dev
20100520 13:23:38-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100520 13:26:05-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100520 13:31:22-!- Bocom_ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100520 13:31:23-!- Bocom [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Read error: Connection reset by peer]
20100520 13:46:54< CIA-10> timotei * r42737 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/builder/ExternalToolInvoker.java: 
20100520 13:46:54< CIA-10> eclipse plugin: fix the tool invoker when launching it with the argument
20100520 13:46:54< CIA-10> "waitFor=false". The output printing is being executed in a separate
20100520 13:46:54< CIA-10> thread
20100520 13:47:11< timotei> Crab_: ok, fixed the output-ing part
20100520 13:47:20< Gallaecio> Is it already know that in UtbS there is an old animation when the Desert Sentinel attacks?
20100520 13:47:22< timotei> fendrin: now it works as wanted
20100520 13:47:40< Crab_> ok
20100520 13:49:21-!- euschn [~eugen@wesnoth/developer/euschn] has joined #wesnoth-dev
20100520 13:49:34< Crab_> timotei: note that you limited yourself to 100 lines per second
20100520 13:50:02< Crab_> timotei: there is no reason to Thread.sleep if you've outputted something
20100520 13:50:10< timotei> Crab_: well, isn't good enough?
20100520 13:50:40< timotei> Crab_: I know it's better to put a sleep rather than don't do anything (aka: infinite loop - if no output available)
20100520 13:51:06< Crab_> timotei: well, sleep if-and-only-if you've done at least one println
20100520 13:51:58< timotei> so, I should remove that Sleep?
20100520 13:52:36< timotei> what about, sleeping 10 ns while(!errorStream.ready() && !outputStream.ready()) ?
20100520 13:52:37< Crab_> timotei: no, removing sleep is worse. make it conditional
20100520 13:53:04< timotei> ok, so until no output to be read, sleep
20100520 13:53:06< Crab_> timotei: note that you've already called ready() a few times :)
20100520 13:53:12< timotei> yeah
20100520 13:54:58< Crab_> timotei: you can do while(!errorStream.ready() && !outputStream.ready()), yes, or a similar condition. that will work.
20100520 13:55:11< Crab_> timotei: i was thinking of refactoring the code to get rid of ready altogether.
20100520 13:55:34< timotei> Crab_: the ones from ReadLine, right?
20100520 13:55:35< Crab_> timotei: e.g, spawn two helper threads, one for stderr and another for stdout, and just use blocking readline on them
20100520 13:56:19< Crab_> so, there'll be no need to sleep since the helper threads will just block on IO.
20100520 13:56:29< timotei> yes, that's better
20100520 13:57:59< timotei> ok, then reverting to the old readline
20100520 13:59:24< timotei> the reason I didn't use 2 thread was that too many threads are not so good  - that's what I knew - don't know that still does apply on dual core machines
20100520 14:00:08< Crab_> timotei: there are other problems with the code, which will get unmasked once you rework it.
20100520 14:00:11-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20100520 14:01:04-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20100520 14:01:22< timotei> Crab_: calling ToolInvoker from 2 different threads?
20100520 14:03:11< Crab_> timotei: no, blocking on 'we want to output data from stdout buffer and block waiting for more stdout from app; application wants to output data to stderr but blockes because no space in stderr buffer; deadlock.
20100520 14:03:37< Crab_> your current ' if (waitFor) ' part might be vulnerable (after rework)
20100520 14:04:16< Crab_> so, regardless of waitFor, we need to read data from stderr and stdout as soon as it arrives, and store it in local buffers. for that, we can use two helper threads.
20100520 14:04:56< Crab_> then, in case of !waitFor, we can (synced on those buffers) read our buffers and out them to user-specified stream, such as to system.out
20100520 14:05:04< timotei> well, if the waitfor thing is true, it will wait till the application ends... and after that reads all what's in the output/error stream buffer
20100520 14:05:24< Crab_> we must read all what's in OUR output/error stream buffers, not in app buffers.
20100520 14:05:41< Crab_> if you read by lines, you can make two lists of strings on the fly, while the app runs.
20100520 14:07:36-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has joined #wesnoth-dev
20100520 14:10:03-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100520 14:10:23< timotei> so, it's not good by reading+output one line at a time?
20100520 14:10:31< Crab_> no
20100520 14:10:45< Crab_> timotei: basically, each collector thread can do something like this : http://wesnoth.pastebin.com/NTqvigTa
20100520 14:11:05-!- Netsplit *.net <-> *.split quits: erl, Ingmar
20100520 14:11:36< Crab_> timotei: basically, read the bufferedReader connected to the app stdout asap, and store the lines in a arraylist of lines
20100520 14:11:49< timotei> Crab_: well, but "stacking" the read lines in a list, we wouldn't be able to ouput them as soon as they arrive
20100520 14:11:57< timotei> so, no real-time outputing
20100520 14:13:36< Crab_> timotei: a third thread can do that. or you can make it somewhat more fancy
20100520 14:14:03< Crab_> timotei: basically, if we use just one helper thread and ready...
20100520 14:14:17-!- Netsplit over, joins: Ingmar, erl
20100520 14:15:28< Crab_> timotei: "while (app_is_alive_and_something_left_in_stderr_or_stdout) { if (stderr or stdout is ready) read the one which is ready and either place it in a list or output it to user-defined stream }"
20100520 14:15:42< Crab_> where 'either' part depends on waitFor
20100520 14:16:26< Crab_> note that your current code is similar, but it blocks on if (waitFor) becase the app might never finish if it waits for us to read its output
20100520 14:17:06< timotei> well... 
20100520 14:18:05< Crab_> (that's in case waitFor is true )
20100520 14:18:29< Crab_> because toolInvoker.waitFor() will not return till the app has finished
20100520 14:18:44< Crab_> but the app will not finish if it blocks on std::cout or std::cerr
20100520 14:19:08< Crab_> which will block if the process will not have enough space in system buffers to output data
20100520 14:20:21< Crab_> to ensure it has space in those buffers, we must read BOTH stderr and stdout of the process, either with two blocking threads or with 1 nonblocking thread which uses ready and sleep (you code has that part working)
20100520 14:21:23< Crab_> but, that 'working part' in your code will not be activated if waitFor is true, since 1) we'll block at earlier line 2) you use it only for waitFor==false part of if ().
20100520 14:22:00< Crab_> so, you can base the solution on your Thread thread = new Thread(new Runnable() { ... } part.
20100520 14:22:42< Crab_> but you need to use it regardless of waitFor, but just process lines differently depending on waitFOr
20100520 14:23:05< Crab_> and, of course, get rid of that toolInvoker.waitFor(); part which can block things.
20100520 14:23:30< Crab_> you can use it only if you are certain that other threads will read both stdout and stderr for you.
20100520 14:23:36< timotei> mhh
20100520 14:23:38< Crab_> (the 'two helper threads' solution)
20100520 14:23:48< timotei> currently it has 2 helper threads
20100520 14:24:12< timotei> so... I'll add a second parameter: waitForDuration 
20100520 14:24:20< Crab_> the first is unrelated - it's to unblock eclipse while all that happens.
20100520 14:24:35< Crab_> so, you have 1 thread which reads output. and it's not even started if you hang in waitFor()
20100520 14:24:53< Crab_> note: there's a way to cheat to make all things easier. just redirect stderr to stdout via processBuilder's options.
20100520 14:24:54< timotei> well waitfor is from the user
20100520 14:25:11< timotei> maybe it will be better to provide a menu for stopping the launched application
20100520 14:25:28< timotei> I'll think more about it. now I have to go.
20100520 14:25:32< Crab_> timotei: 'to provide a menu for stopping the launched application' is unrelated, too
20100520 14:25:44< Crab_> timotei: the current problem is that we need to consume input from the app
20100520 14:26:09< timotei> ok
20100520 14:26:13< Crab_> timotei: and it's not done in *all* cases in your code. so it can block on certain parameters being passed to it.
20100520 14:26:29< timotei> we'll talk later
20100520 14:26:38< Crab_> and the 'no need to sleep() if we've done something last time' applies, too
20100520 14:26:41< Crab_> ok, good luck.
20100520 14:26:42-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100520 14:29:00-!- Gallaecio [~555b5a28@gateway/web/freenode/x-tfmfinddbaybedep] has quit [Ping timeout: 252 seconds]
20100520 14:36:51< CIA-10> alink * r42738 /trunk/wesnoth.kdevelop: 
20100520 14:36:51< CIA-10> Update Kdevelop project file.
20100520 14:36:51< CIA-10> Change from automake-based project to a simpler custom buildsystem project,
20100520 14:36:51< CIA-10> but still using automake by default. This fix various problems of the old one
20100520 14:36:51< CIA-10> (didn't check src/subdirectories and break configure.ac). Tested on Kdevelop 3.5.2
20100520 14:37:17< alink> shadowmaster: are you still using kdevelop ?
20100520 14:40:41-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has joined #wesnoth-dev
20100520 14:55:53< CIA-10> zookeeper * r42739 /trunk/data/campaigns/Son_Of_The_Black_Eye/scenarios/03_Towards_Mountains_of_Haag.cfg: Cleaned up bonus objective text and removed the unnecessary killing of Blemaker at the end.
20100520 15:07:13< CIA-10> zookeeper * r42740 /trunk/data/campaigns/Son_Of_The_Black_Eye/ (55 files in 3 dirs): Added numbering to the SotBE maps and fixed a few inconsistencies in map/scenario id's, names and filenames.
20100520 15:13:43-!- fkhodkov [~fedor76@ppp-78-24-25-100-bras0.istra.ru] has quit [Read error: Connection reset by peer]
20100520 15:19:07-!- fkhodkov [~fedor76@ppp-78-24-25-100-bras0.istra.ru] has joined #wesnoth-dev
20100520 15:20:27-!- elias [~elias@allegro/developer/allefant] has joined #wesnoth-dev
20100520 15:37:41< alink> does gna-svn works for you ?
20100520 15:39:57-!- elias [~elias@allegro/developer/allefant] has quit [Remote host closed the connection]
20100520 15:48:45< CIA-10> alink * r42741 /trunk/src/ (4 files in 2 dirs): simplify header
20100520 15:48:46< CIA-10> alink * r42742 /trunk/src/widgets/ (menu.cpp menu.hpp menu_style.cpp scrollarea.hpp): simplify header
20100520 15:48:59< alink> nevermind, works again
20100520 15:49:11-!- billynux [~billy@wesnoth/developer/billynux] has joined #wesnoth-dev
20100520 15:50:24< CIA-10> ivanovic * r42743 /trunk/po/ (3 files in 3 dirs): updated Chinese (simplified) translation
20100520 15:50:28< CIA-10> ivanovic * r42744 /branches/1.8/po/ (3 files in 3 dirs): updated Chinese (simplified) translation
20100520 16:02:01-!- Gambit [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100520 16:05:27-!- Crab_ [~Crab@wesnoth/developer/crab] has quit [Read error: Connection reset by peer]
20100520 16:13:00-!- fakedrake [~fakedrake@ppp-94-64-232-166.home.otenet.gr] has joined #wesnoth-dev
20100520 16:28:27< CIA-10> zookeeper * r42745 /trunk/data/core/images/terrain/cave/ (18 files): Fixed botched commit of the mine cart tracks.
20100520 16:46:35-!- AnMaster [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 248 seconds]
20100520 16:54:15-!- rigved [~rigved@116.72.163.243] has quit [Quit: Bye]
20100520 16:58:46-!- Bocom_ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Read error: Connection reset by peer]
20100520 16:58:47-!- Bocom__ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100520 17:09:07-!- Bocom__ [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Read error: No route to host]
20100520 17:11:47-!- Bocom [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100520 17:20:23-!- fendrin [~fabi@88-134-187-231-dynip.superkabel.de] has joined #wesnoth-dev
20100520 17:20:23-!- fendrin [~fabi@88-134-187-231-dynip.superkabel.de] has quit [Changing host]
20100520 17:20:23-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20100520 17:27:27-!- AnMaster [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20100520 17:30:47-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20100520 17:47:58-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100520 17:54:57-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Remote host closed the connection]
20100520 17:55:35-!- crimson_penguin [~ben@206.174.176.131] has joined #wesnoth-dev
20100520 17:55:35-!- crimson_penguin [~ben@206.174.176.131] has quit [Changing host]
20100520 17:55:35-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100520 17:56:45-!- crimson_pinvin [~ben@64.201.60.211] has joined #wesnoth-dev
20100520 17:56:45-!- crimson_pinvin [~ben@64.201.60.211] has quit [Changing host]
20100520 17:56:45-!- crimson_pinvin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100520 17:59:48-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 240 seconds]
20100520 17:59:48-!- crimson_pinvin is now known as crimson_penguin
20100520 18:01:31-!- euschn [~eugen@wesnoth/developer/euschn] has quit [Quit: Leaving.]
20100520 18:12:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 18:17:24-!- Bocom_ [~Bocom@c-b7cfe255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100520 18:17:53-!- Gambit1 [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100520 18:18:42-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100520 18:19:31-!- Gambit [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Disconnected by services]
20100520 18:19:33-!- Gambit1 is now known as Gambit
20100520 18:21:01-!- Bocom [~Bocom@c-13cde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Ping timeout: 265 seconds]
20100520 18:25:57< cjhopman_> silene: are these defined behaviour for the wml preprocessor? http://wesnoth.pastebin.com/HTP5DQWw and http://wesnoth.pastebin.com/Ru1BivTf
20100520 18:27:29< fendrin> wesbot: seen timotei?
20100520 18:27:30< wesbot> fendrin: The person with the nick timotei last spoke 4h 1m ago.  4h ago was here and on the channel #wesnoth-umc-dev with the message: Remote host closed the connection
20100520 18:28:10< silene> cjhopman_: it depends of what you mean by "defined"; did it occur to me that someone would one day try this? no; does it behave like the code says it should? yes
20100520 18:30:02< silene> anyway, the semantic of the preprocessor says that substitutions happen at insertion time, so it works fine, i guess
20100520 18:31:56-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100520 18:33:07-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100520 18:36:53-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100520 18:41:39< cjhopman_> silene: Yeah, I know that it does what the code says it should, I got these examples when I was reading the preprocessor code and it wasn't doing what I expected.
20100520 18:42:00< cjhopman_> I was kinda hoping though that you would say that nesting preprocessor directives inside #define is not allowed
20100520 18:50:01-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100520 18:50:05-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100520 18:53:53-!- AnMaster [~AnMaster@unaffiliated/anmaster] has quit [Quit: ZNC - http://znc.sourceforge.net]
20100520 18:55:35< cjhopman_> or rather, just that #define/#enddef/#undef couldn't be nested... since #if/else/endif are used in macros often
20100520 18:57:55< timotei> Crab_: I thought about that thread thing, and I think I got it
20100520 18:57:57< cjhopman_> also if/else/endif I believe work as expected as I wasn't able to find a way to split an #if/endif across multiple macros or multiple files
20100520 18:58:09< timotei> Crab_: you were talking about: if (waitFor) as if that true, it will block the caller ?
20100520 18:58:59< silene> cjhopman_: no preprocessor construct can be split, so it includes #if and so on, but also strings, macro parameters, etc
20100520 18:59:10< Crab_> timotei: yes, it might block the caller if the app outputs too much
20100520 18:59:46< timotei> Crab_: so you would "think" that the WHOLE outputing takes place "async" in a separate thread?
20100520 19:00:36-!- _jbx_ [~jbailey@12.190.80.225] has joined #wesnoth-dev
20100520 19:00:52< timotei> Crab_: whether, we wait or not for the app
20100520 19:01:22< silene> cjhopman_: as for forbidding #define/#undef, i don't see the point; it's a good that one can include a file from a macro, and i don't a reason to prevent using preprocessing directives in a preprocessed file
20100520 19:07:11< timotei> hey silene
20100520 19:08:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100520 19:11:04< cjhopman_> silene: the one I don't understand is, on http://wesnoth.pastebin.com/Ru1BivTf why is the 3rd output [foo][/foo] .... is the macro call substituted innermost first? In which case why does http://wesnoth.pastebin.com/xDFieV5V have the result it does?
20100520 19:13:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 19:14:33-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100520 19:14:37-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20100520 19:16:25-!- cib0 [~Miranda@p5DD348D1.dip.t-dialin.net] has joined #wesnoth-dev
20100520 19:24:05< shadowmaster> alink: no
20100520 19:28:28< silene> cjhopman_: the third output is [foo][/foo] because it is the 2nd macro argument, so {FOO} was expanded at the time it was encountered (that is, before expanding {REDEFINE}); as for your second example, macro expansions are considered to be single entitities, so they aren't preprocessed a second time to discover they could have been split across several arguments
20100520 19:30:31-!- Upthorn [~ogmar@69.62.144.108] has quit [Ping timeout: 245 seconds]
20100520 19:30:37< silene> in other words, it's as if you had written {BAZ ({FOO})}
20100520 19:31:42< timotei> Crab_: btw, done the eclipse setup page: http://wiki.wesnoth.org/EclipsePlugin_setup did I miss anything?
20100520 19:31:45< timotei> fendrin: hey
20100520 19:32:34< Crab_> timotei: yes, i've seen it. good.
20100520 19:32:42< timotei> silene: there is a small problem I've encountered in the preprocessor
20100520 19:32:50< silene> which one?
20100520 19:33:49< timotei> silene: I made the command line "preprocess" to preprocess a file. I tested it against LoW campaign (on windows) and it told me this: 
20100520 19:33:52< timotei> 20100520 20:06:58 debug config: testing for macro MULTIPLAYER: not defined
20100520 19:33:53< timotei> 20100520 20:06:58 debug filesystem: Looking for 'MULTIPLAYER'.
20100520 19:33:55< timotei> 20100520 20:06:58 debug filesystem:   trying '/media/Work/work/gitwesnoth/data/MULTIPLAYER'
20100520 19:33:56< timotei> 20100520 20:06:58 debug filesystem:   found: '/media/Work/work/gitwesnoth/data/MULTIPLAYER'
20100520 19:33:57< timotei> 20100520 20:06:58 debug config: testing for file or directory MULTIPLAYER: found
20100520 19:34:23< silene> timotei: i don't see anything wrong
20100520 19:34:39< timotei> well... shouldn't that be a macro instead of a filename?
20100520 19:34:49< timotei> foldername
20100520 19:35:17-!- elias [~elias@allegro/developer/allefant] has joined #wesnoth-dev
20100520 19:35:25< silene> timotei: there is no difference between macros and filenames in WML, they are included the same way: {toto}
20100520 19:35:46< silene> so the game just tests one and the other
20100520 19:36:07< timotei> well, that acts as if MULTIPLAYER is defined... which is not...
20100520 19:36:37< silene> timotei: how can the engine know that you aren't trying to include a file named MULTIPLAYER?
20100520 19:37:13< timotei> maybe because of this: #ifdef MULTIPLAYER ?
20100520 19:37:31 * cib0 thinks that timotei has a point.
20100520 19:37:33< Crab_> silene: yes, it cannot know what the WML author wants. this looks like a side effect of patch https://gna.org/patch/?1590 
20100520 19:37:58< timotei> silene: so... you checking for a macro defined, not a folder...
20100520 19:38:11< silene> timotei: #ifdef is also used for checking files
20100520 19:38:14< Crab_> silene: i.e. the new syntax changes the behavior of old code
20100520 19:38:19< timotei> silene: didn't know
20100520 19:39:05-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has quit [Read error: Connection reset by peer]
20100520 19:40:19< silene> Crab_: that sure would be bad
20100520 19:40:32< Crab_> silene: current main.cfg has this : http://wesnoth.pastebin.com/cv9epuTP
20100520 19:40:38< Crab_> data/_main.cfg
20100520 19:41:12< Crab_> so, it includes multiplayer directory if it exists
20100520 19:41:51< Crab_> previously, it included it only if  cache_.add_define("MULTIPLAYER"); was used
20100520 19:41:54< silene> case-insensitive file systems suck; but yeah, i agree, #ifdef can't be used then
20100520 19:42:12< silene> i guess i will change it to #iffile or something like that
20100520 19:43:00< Crab_> I was thinking about #ifhave
20100520 19:43:09< timotei> silene: only on windows it "skips" that, because of the sensitive check, but on windows it doesn't
20100520 19:43:41< cjhopman_> #ifexists ?
20100520 19:44:39< Crab_> cjhopman_: it's bad, because it's hard to remember if it should be #ifexists or #ifexist
20100520 19:44:43< silene> i guess #ifhave and  #ifexists are better since they don't make a difference between files and directories; i think i prefer the shorter one, but i don't have a strong opinion on it
20100520 19:45:05< cjhopman_> Crab_: true
20100520 19:45:35< fendrin> timotei: hi
20100520 19:46:57< timotei> fendrin: I fixed the blocking thingy:D
20100520 19:47:05< timotei> fendrin: now it should be really ok
20100520 19:47:07< fendrin> timotei: how? what was it?
20100520 19:47:53< timotei> fendrin: well, I forgot to put the WHOLE call in a thread
20100520 19:48:23< fendrin> timotei: That was what I tried to suggest yesterday.
20100520 19:48:24< zookeeper> silene, do you think it'd make sense to actually use different syntax for file includes and macros, so the game could tell the difference?
20100520 19:49:02< timotei> fendrin: yeah, but missed over the last part of the code :(
20100520 19:49:13< fendrin> zookeeper: I think that is a good idea.
20100520 19:51:39< timotei> fendrin: could you confirm it works ok?
20100520 19:51:42< timotei> s/could/can
20100520 19:51:54< fendrin> timotei: yes, is already in progress
20100520 19:51:57< timotei> ok
20100520 19:52:34< fendrin> timotei: I am on my main machine now. It compiles very fast.
20100520 19:52:53< timotei> fendrin: take your time, I don't have to go anywhere:)
20100520 19:53:12< timotei> CIA-10 is dead?
20100520 19:54:45< CIA-10> timotei * r42746 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/builder/ExternalToolInvoker.java: eclipse plugin: refactor the external tool invoker
20100520 19:55:00< timotei> :))
20100520 19:55:17 * fendrin thinks that elezar's terrain work is awesome.
20100520 19:57:25-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20100520 19:58:12< silene> zookeeper: yes
20100520 19:58:30< timotei> mhh, wesnothd is used to start a wesnoth dedicated server, right?
20100520 19:59:00< Crab_> timotei: mp server, yes
20100520 20:00:50< timotei> fendrin: I start implementing the starting of wesnoth server 
20100520 20:00:59< timotei> fendrin: so I can finish milestone 1
20100520 20:01:13< timotei> fendrin: of course, if something misses just tell m
20100520 20:01:16< timotei> s/m/me
20100520 20:02:09-!- rigved [~rigved@116.72.163.243] has quit [Ping timeout: 276 seconds]
20100520 20:02:35-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20100520 20:03:13< fendrin> timotei: Okay, it doesn't work for me, that is because I still call an not uptodate binary. Nothing wrong with that but can you let it tell me why there is nothing happening? 
20100520 20:03:44< fendrin> timotei: Currently there is only useful output in the host eclipse's console. 
20100520 20:03:47< timotei> fendrin: nothing happening where?
20100520 20:04:38< fendrin> timotei: -datadir is not recognized when opening the map editor. 
20100520 20:05:41< timotei> fendrin: the datadir is for wesnoth's data, not especially for the map editor
20100520 20:05:54< fendrin> timotei: Okay, with the updated binary everthing works fine.
20100520 20:05:55< timotei> fendrin: if you try specifing a "wrong" datadir, then the game won't load
20100520 20:06:01< timotei> good
20100520 20:06:36< fendrin> timotei: I only miss a feedback when the binary doesn't work as expected.
20100520 20:06:54< timotei> fendrin: feedback from wesnoth?
20100520 20:07:11< fendrin> timotei: No, from the plugin or eclipse.
20100520 20:07:15< timotei> fendrin: cause from the plugin, the single piece of feedback you get is: tool started, tool ended
20100520 20:07:52< timotei> fendrin: well, I could use the return code of wesnoh, to trigger some GUI messages
20100520 20:08:06< fendrin> timotei: Okay, but you should get an return code != 0 from wesnoth if it is called with wrong parameters like I did. This can be used to give feedback.
20100520 20:08:26< timotei> fendrin: yes, but afair not every "bad" thing returns !=0 
20100520 20:08:39-!- dtiger [~dtiger@dynamic-vpdn-93-125-65-150.telecom.by] has joined #wesnoth-dev
20100520 20:09:08-!- Lastmerlin [~Lastmerli@kalypso.csn.tu-chemnitz.de] has joined #wesnoth-dev
20100520 20:09:24< timotei> for example, only: process_command_args returns an error code if any
20100520 20:10:13< timotei> the other part of processing the arguments (in the game constructor) don't return any error code afais
20100520 20:11:50< timotei> is any way in the console to see the return value of an application?
20100520 20:11:55< timotei> in linux?
20100520 20:11:58< fendrin> $?
20100520 20:12:22< fendrin> That is an environment variable that contains the exit value.
20100520 20:12:37< fendrin> eche $?
20100520 20:12:49< Crab_> timotei: waitFor() in java gives you the exit value, too
20100520 20:12:49< fendrin> "echo $?" will print it.
20100520 20:12:58< timotei> good
20100520 20:13:24< timotei> Crab_: but that only if we "waitfor"
20100520 20:13:42< Crab_> timotei: well, the return value is only known after process has terminated
20100520 20:13:48< timotei> Crab_: yes.
20100520 20:14:08< fendrin> timotei: We can implement more return values for several causes of error later. It's just that the infrastructure is in place. You could print the output of wesnoth if exit != 0.
20100520 20:14:08< Crab_> timotei: so, if you do it after parsing the output, you can use it without blocking, or  exitValue() without exceptions
20100520 20:14:42< timotei> fendrin: ok
20100520 20:17:05-!- ancestral [~ancestral@12.145.225.25] has joined #wesnoth-dev
20100520 20:17:36-!- timotei is now known as timotei_away
20100520 20:35:10-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving]
20100520 20:42:29-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has quit [Ping timeout: 240 seconds]
20100520 20:42:30-!- ancestral [~ancestral@12.145.225.25] has quit [Quit: Grocery store → Tacos]
20100520 20:49:14-!- timotei_away is now known as timotei
20100520 20:52:10-!- Upthorn [~ogmar@sccadmin2208.scc.losrios.edu] has joined #wesnoth-dev
20100520 20:52:42-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100520 21:00:56-!- Upthorn [~ogmar@sccadmin2208.scc.losrios.edu] has quit [Ping timeout: 245 seconds]
20100520 21:03:12-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has joined #wesnoth-dev
20100520 21:03:12-!- cjhopman_ [~chris@71-90-6-151.dhcp.ftbg.wi.charter.com] has quit [Changing host]
20100520 21:03:12-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20100520 21:05:07-!- Lastmerlin [~Lastmerli@kalypso.csn.tu-chemnitz.de] has left #wesnoth-dev ["Kopete 0.12.7 : http://kopete.kde.org"]
20100520 21:11:51-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20100520 21:14:21-!- fkhodkov [~fedor76@ppp-78-24-25-100-bras0.istra.ru] has quit [Read error: Connection reset by peer]
20100520 21:17:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: GO, GET TO THE CHOPPAH!!!]
20100520 21:17:28< fendrin> Ivanovic: We need a site where the eclipse plugin can be hosted from, http.
20100520 21:17:37< Ivanovic> huh?
20100520 21:17:55< fendrin> Ivanovic: Ever used eclipse?
20100520 21:18:02< Ivanovic> some ages ago
20100520 21:18:15< shadowmaster> by http you mean a website?
20100520 21:18:31-!- fkhodkov [~fedor76@ppp-78-24-25-100-bras0.istra.ru] has joined #wesnoth-dev
20100520 21:18:34< fendrin> shadowmaster: no, just a folder where the plugin lives.
20100520 21:18:35< Ivanovic> something like wesnoth.org?
20100520 21:18:43< fendrin> Ivanovic: yes
20100520 21:19:10< Ivanovic> what exactly is/would be required there?
20100520 21:19:23< Ivanovic> is it enough to place a symlink to the svn checkout we got on the server?
20100520 21:19:43< fendrin> Ivanovic: I guess that would work.
20100520 21:19:58< timotei> fendrin: yeah, I could create a folder for the plugin update site
20100520 21:19:59< shadowmaster> uh.
20100520 21:20:16< fendrin> timotei: Right, that is what I had in mind.
20100520 21:20:16< Ivanovic> fendrin, timotei: you should comunicate with Rhonda for this stuff
20100520 21:20:22< shadowmaster> well, I could probably browse to wesnoth..org/path/.svn too then
20100520 21:20:25< fendrin> Rhonda: around?
20100520 21:20:32< shadowmaster> which would be bad
20100520 21:20:33< Ivanovic> personally i'd prefer to simply place a symlink to the svn checkout folder if possible
20100520 21:20:38< Ivanovic> shadowmaster: anonymus checkout
20100520 21:20:40< Ivanovic> does not matter
20100520 21:20:50 * Rhonda looks up.
20100520 21:21:00< fendrin> Rhonda: Please read the last few lines.
20100520 21:21:02< timotei> Ivanovic: that would be very good, so we can update the plugin's webpage directly from the svn server
20100520 21:21:17< shadowmaster> and in any case authentication info isn't in .svn dirs AFAIK
20100520 21:21:26< shadowmaster> it's saved in the user's .subversion config dir
20100520 21:21:49< Ivanovic> there is just some userdata stuff like the checkout url+username in there which does not matter at all regarding the anonymus checkouts
20100520 21:22:08< Rhonda> Yeah, symlink sounds suitable.
20100520 21:22:30< Rhonda> Would it suit in the files/ directory?
20100520 21:23:02< Ivanovic> Rhonda: not sure where to put it, somehow i'd say something like eclipse.wesnoth.org or the likes might be best
20100520 21:23:04< Rhonda> Or should it be rather a folder on its own? Actually I don't mind, and Ivanovic can do that, I don't see much of a reason why it couldn't be done.
20100520 21:23:13< Ivanovic> (pointing to wesnoth.org/eclipse )
20100520 21:23:29< Rhonda> Fine for me too, then have it an eclipse subdir. :)
20100520 21:23:44< Rhonda> Special purpose URLs for special purposes always best suited.
20100520 21:24:21-!- cib0 [~Miranda@p5DD348D1.dip.t-dialin.net] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20100520 21:25:02< fendrin> Yes, that sounds good.
20100520 21:25:31< Rhonda> You have my blessing to do it. :)
20100520 21:27:17< fendrin> Rhonda: I don't have rights on the server.
20100520 21:27:34< fendrin> Or do I?
20100520 21:27:47< Rhonda> Does someone build wesnoth with make -j2 or such?
20100520 21:27:50< Ivanovic> fendrin: get the stuff for the website done, so that it is in the rep
20100520 21:27:59< Ivanovic> Rhonda: i do (using -j4)
20100520 21:28:05< fendrin> Rhonda: I use make -j5 or scons -j5
20100520 21:28:39< Rhonda> Ivanovic: So parallel build does actually work. Good to know that it's not a an issue with wesnoth itself but with the fscking b0rked debian/rules file.
20100520 21:28:41< Ivanovic> fendrin: once things are in the rep, please ping again so that we can simply point a symlink to the correct checkout folder (yeah, we got to have that first ;) )
20100520 21:29:01< Ivanovic> parallel build works lovely with gentoo and makes things a whole lot faster
20100520 21:29:54-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has quit [Ping timeout: 276 seconds]
20100520 21:29:54 * Rhonda silently curses isaac, the ancient debian/rules file and the slow build for draining my motivation to fix it for good :(
20100520 21:30:38< fendrin> timotei: Did you read what Ivanovic said?
20100520 21:30:41< shadowmaster> that's really silent
20100520 21:30:44< timotei> fendrin: yes
20100520 21:30:50< fendrin> Okay
20100520 21:30:56< timotei> fendrin: I will create the directory for the update site
20100520 21:31:23< fendrin> timotei: Cool, tell me when it works, I will test it.
20100520 21:31:32< timotei> ok
20100520 21:31:48< fendrin> timotei: If you specify dependencies eclipse should be able to fetch all at once.
20100520 21:31:57< timotei> fendrin: yes
20100520 21:33:35-!- Greywhind [~Greywhind@harkness-146.resnet.brown.edu] has joined #wesnoth-dev
20100520 21:38:14-!- billynux [~billy@wesnoth/developer/billynux] has joined #wesnoth-dev
20100520 21:38:26-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100520 21:44:07-!- Gambit [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Quit: Leaving.]
20100520 21:44:26-!- Gambit [~Gambit@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100520 21:46:47-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100520 22:03:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100520 22:08:34-!- rigved [~rigved@116.72.163.243] has quit [Quit: Bye]
20100520 22:16:16-!- elias [~elias@allegro/developer/allefant] has quit [Quit: Leaving]
20100520 22:16:30-!- k23z__ [k23z__@unaffiliated/k23z--/x-2536701] has joined #wesnoth-dev
20100520 22:19:45-!- cjhopman_ [~chris@wesnoth/developer/cjhopman] has quit [Ping timeout: 240 seconds]
20100520 22:33:56< timotei> fendrin: ok, created a sample update site. I will commit it now
20100520 22:34:28< fendrin> timotei: okay, don't forget to notice Ivanovic when it is ready.
20100520 22:34:31< timotei> ok
20100520 22:35:39< CIA-10> timotei * r42747 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (2 files in 2 dirs): eclipse plugin: show a message if the tool returned non-zero value
20100520 22:35:49< CIA-10> timotei * r42748 /trunk/utils/java/plugin_feature/ (. .project build.properties feature.xml): eclipse plugin: add the feature for update site
20100520 22:35:50-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
20100520 22:35:58< CIA-10> timotei * r42749 /trunk/utils/java/update_site/ (13 files in 4 dirs): eclipse plugin: add the plugin update site
20100520 22:36:35< timotei> Ivanovic: ok, I added the website
20100520 22:36:42< timotei> http://svn.gna.org/svn/wesnoth/trunk/utils/java/update_site/
20100520 22:37:10< timotei> but... I don't know how we'll link to a normal website, since we can't execute a webpage from the svn server 
20100520 22:37:20< timotei> if you click on index.html... it will display it's HTML code
20100520 22:43:15-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving]
20100520 22:45:02-!- Blueblaze [~nick@adsl-99-182-52-253.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100520 22:50:14-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20100520 22:50:56-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Ping timeout: 245 seconds]
20100520 22:57:38< Ivanovic> timotei: http://eclipse.wesnoth.org/
20100520 22:57:57< timotei> Ivanovic: thanks :)
20100520 22:58:08< Ivanovic> works the same as http://www.wesnoth.org/eclipse
20100520 22:58:25< Ivanovic> the rules should basically work comparable to the one for the forums
20100520 22:58:47< timotei> Ivanovic: good. so it's linked to the repo, right?
20100520 22:59:08< Ivanovic> it is linked to the checkout folder trunk/utils/java/update_site/
20100520 22:59:16< timotei> ok
20100520 22:59:17< Ivanovic> which is updated every ~30mins
20100520 22:59:26< timotei> good enough
20100520 23:01:04-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 268 seconds]
20100520 23:04:20-!- dtiger [~dtiger@dynamic-vpdn-93-125-65-150.telecom.by] has quit [Remote host closed the connection]
20100520 23:04:55-!- Upthorn [ogmar@75.26.163.86] has joined #wesnoth-dev
20100520 23:06:34< timotei> Ok, I'll go now
20100520 23:06:37< timotei> good night everyone
20100520 23:07:08-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100520 23:17:42-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100520 23:26:40-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.]
20100520 23:32:39-!- Valkier [~karasawa@c-174-55-104-2.hsd1.pa.comcast.net] has joined #wesnoth-dev
20100520 23:42:51-!- governor [~mike@S0106002369fa3756.cg.shawcable.net] has joined #wesnoth-dev
20100520 23:43:09-!- JonW [~chatzilla@cpc2-finc11-0-0-cust855.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20100520 23:46:48-!- JonW [~chatzilla@cpc2-finc11-0-0-cust855.4-2.cable.virginmedia.com] has quit [Client Quit]
20100520 23:48:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20100520 23:48:25-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100520 23:48:35-!- norbert_ [~norbert@82-171-70-54.ip.telfort.nl] has joined #wesnoth-dev
20100520 23:50:21< CIA-10> espreon * r42750 /trunk/data/core/images/terrain/cave/ (12 files): Ran umcpropfix.
20100520 23:51:53< CIA-10> espreon * r42751 /trunk/data/core/images/terrain/cave/ (27 files): 
20100520 23:51:53< CIA-10> Ran wesnoth-optipng:
20100520 23:51:53< CIA-10> Overall statistics (only for files with a smaller recompressed size):
20100520 23:51:54< CIA-10> Original size: 60 KiB on 27 files
20100520 23:51:54< CIA-10> Optimized size: 38 KiB
20100520 23:51:54< CIA-10> Total saving: 21 KiB = 36% decrease
--- Log closed Fri May 21 00:00:06 2010