--- Log opened Sat Jun 12 00:00:21 2010 20100612 00:02:18-!- eleazar_ [~jbjerk@ppp-70-226-193-29.dsl.spfdil.ameritech.net] has left #wesnoth-dev [] 20100612 00:06:46< CIA-86> espreon * r43291 /trunk/data/core/images/portraits/undead/ (draug.png transparent/draug-2.png transparent/draug.png): 20100612 00:06:46< CIA-86> Ran wesnoth-optipng: 20100612 00:06:46< CIA-86> Overall statistics (only for files with a smaller recompressed size): 20100612 00:06:46< CIA-86> Original size: 455 KiB on 3 files 20100612 00:06:46< CIA-86> Optimized size: 433 KiB 20100612 00:06:46< CIA-86> Total saving: 22 KiB = 4% decrease 20100612 00:24:41-!- mjs-de [~mjs-de@p3EE25BA1.dip.t-dialin.net] has quit [Remote host closed the connection] 20100612 00:31:55-!- drusepth [~drusepth@dhcp-077-249-151-209.chello.nl] has quit [Remote host closed the connection] 20100612 00:41:01-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.] 20100612 00:42:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100612 00:44:10-!- Shakey [HydraIRC@c-71-201-89-187.hsd1.il.comcast.net] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- IRC with a difference] 20100612 00:44:40-!- Mythological [Mythologic@77.29.0.208] has joined #wesnoth-dev 20100612 00:49:22< gabba> anybody knows if wesnoth has a function to convert from an Uint32 to a string that's expected by the image::locator modifiers parameter? i.e. I want to convert 0xFF00FF --> "FF00FF" 20100612 00:53:15-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100401080539]] 20100612 00:53:30< shadowmaster> if it was C I'd use sprintf(foo, "%06lx", num) 20100612 00:53:55< shadowmaster> but C++ has these IO stream manipulators which could probably be used to achieve a similar result 20100612 00:54:31< shadowmaster> except I still forget what they are 20100612 00:56:33-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving] 20100612 01:03:32< gabba> thanks for the clue, I'm gonna investigate that... or just make my arrow::set_color() method expect a string parameter 20100612 01:15:00-!- meric [~Eric@124-168-133-6.dyn.iinet.net.au] has joined #wesnoth-dev 20100612 01:17:04-!- Mythological_ [Mythologic@77.28.87.158] has joined #wesnoth-dev 20100612 01:20:00-!- Mythological [Mythologic@77.29.0.208] has quit [Ping timeout: 258 seconds] 20100612 01:31:30-!- meric [~Eric@124-168-133-6.dyn.iinet.net.au] has quit [Ping timeout: 258 seconds] 20100612 01:34:25-!- meric [~Eric@124-168-133-6.dyn.iinet.net.au] has joined #wesnoth-dev 20100612 01:40:04-!- meric [~Eric@124-168-133-6.dyn.iinet.net.au] has quit [Quit: meric] 20100612 01:45:24-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has joined #wesnoth-dev 20100612 01:50:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100612 01:59:10-!- noy_ [~Noy@70.70.237.127] has joined #wesnoth-dev 20100612 01:59:10-!- noy_ [~Noy@70.70.237.127] has quit [Changing host] 20100612 01:59:10-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100612 02:03:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 276 seconds] 20100612 02:03:18-!- noy_ is now known as noy 20100612 02:06:35-!- Sapient [~patrickp@wesnoth/developer/sapient] has left #wesnoth-dev [] 20100612 02:08:56-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Ping timeout: 240 seconds] 20100612 02:22:33< CIA-86> gabba * r43292 /trunk/src/whiteboard/move.cpp: Whiteboard: change log level 20100612 02:22:34< CIA-86> gabba * r43293 /trunk/src/ (arrow.cpp arrow.hpp): Arrows: color parameter now gets used, and set_color() works properly. 20100612 02:22:35< CIA-86> gabba * r43294 /trunk/src/ (arrow.cpp arrow.hpp): Arrow: added a set_style() method, that uses images from a subdirectory of images/arrows 20100612 02:24:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds] 20100612 02:25:06-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100612 02:30:43-!- Catoptromancy [~Cato@unaffiliated/catoptromancy] has joined #wesnoth-dev 20100612 02:55:55-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz] 20100612 02:56:04< CIA-86> gabba * r43295 /trunk/src/ (arrow.cpp arrow.hpp): Arrows: comments 20100612 02:56:12< CIA-86> gabba * r43296 /trunk/src/ (4 files in 2 dirs): 20100612 02:56:12< CIA-86> Arrows: solved problem with setting color or other parameter before the path was valid. 20100612 02:56:12< CIA-86> Also, in the past few commits I moved some members to "protected" instead of "private", to allow subclassing. 20100612 02:56:12< CIA-86> Whiteboard: adapted to the change of interface in arrows. 20100612 02:56:13< CIA-86> Now setting the arrows to white during creation, then to team color when created. 20100612 02:56:15< Catoptromancy> heh 20100612 02:56:30-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20100612 03:16:04-!- Bob_The_Mighty [~chatzilla@cpc4-brig15-0-0-cust904.3-3.cable.virginmedia.com] has joined #wesnoth-dev 20100612 03:52:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100612 03:56:46-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20100612 03:59:01-!- wesbot changed the topic of #wesnoth-dev to: 125 bugs, 281 feature requests, 13 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100612 04:00:23-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Quit: Leaving] 20100612 04:05:31-!- Ivanovic_ [~ivanovic@dtmd-4db2d89d.pool.mediaWays.net] has joined #wesnoth-dev 20100612 04:08:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 258 seconds] 20100612 04:09:29-!- Ivanovic_ is now known as Ivanovic 20100612 04:51:17-!- Bob_The_Mighty [~chatzilla@cpc4-brig15-0-0-cust904.3-3.cable.virginmedia.com] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100401080539]] 20100612 04:56:35-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 260 seconds] 20100612 04:57:27-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Quit: Leaves have fallen all around. It's time I was on my way. Thanks to you I'm much obliged for such a pleasant stay.] 20100612 04:59:07-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 05:37:39-!- King_Elendil [~King_Elen@75.143.233.138] has quit [Read error: Connection reset by peer] 20100612 05:49:40-!- silene [~plouf@bau91-1-82-239-244-109.fbx.proxad.net] has joined #wesnoth-dev 20100612 05:51:05-!- silene [~plouf@bau91-1-82-239-244-109.fbx.proxad.net] has quit [Changing host] 20100612 05:51:05-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20100612 06:07:46-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 06:13:36-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev 20100612 06:18:53-!- meric [~Eric@124.171.54.101] has joined #wesnoth-dev 20100612 06:35:59-!- King_Elendil [~King_Elen@75.143.233.138] has quit [Read error: Connection reset by peer] 20100612 06:36:35-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 06:42:48-!- King_Elendil [~King_Elen@75.143.233.138] has quit [Ping timeout: 252 seconds] 20100612 07:11:02-!- shadowmaster_ [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100612 07:11:51-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Disconnected by services] 20100612 07:11:58-!- shadowmaster_ is now known as shadowm_laptop 20100612 07:40:16-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Read error: Connection reset by peer] 20100612 07:42:18-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has quit [Read error: Connection reset by peer] 20100612 07:47:09-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has joined #wesnoth-dev 20100612 07:55:52-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds] 20100612 07:56:31-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev 20100612 08:04:21< CIA-86> gabba * r43297 /trunk/src/ (arrow.cpp arrow.hpp): Arrows: added set_alpha method to set transparency. 20100612 08:04:26< CIA-86> gabba * r43298 /trunk/src/whiteboard/manager.cpp: Whiteboard: use transparent arrows. 20100612 08:04:33< CIA-86> gabba * r43299 /trunk/src/ (display.cpp display.hpp): Arrows: Unsubscribe display from arrow updates in display's destructor. 20100612 08:04:42< CIA-86> gabba * r43300 /trunk/src/team.cpp: Whiteboard: explicit initialization for side_actions member in team class. 20100612 08:04:48< CIA-86> gabba * r43301 /trunk/src/whiteboard/ (manager.cpp manager.hpp move.cpp side_actions.cpp): 20100612 08:04:48< CIA-86> Whiteboard: 20100612 08:04:48< CIA-86> - moved to std::auto_ptr for some variables to ensure proper deletion on manager "death". 20100612 08:04:48< CIA-86> - fixed infamous off-by-one error with the team indexes 20100612 08:04:49< CIA-86> - made manager noncopyable 20100612 08:04:49< CIA-86> - use more forward declarations and less includes in manager.hpp 20100612 08:06:52-!- Blueblaze [~nick@76.202.16.236] has quit [Ping timeout: 245 seconds] 20100612 08:09:26-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100612 08:13:52-!- Aizu` [~drusepth@dhcp-077-249-151-209.chello.nl] has joined #wesnoth-dev 20100612 08:16:06-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has quit [Read error: Connection reset by peer] 20100612 08:18:30-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has joined #wesnoth-dev 20100612 08:21:36-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection] 20100612 08:23:22< CIA-86> gabba * r43302 /trunk/src/whiteboard/manager.cpp: Whiteboard: experiment with bright team colors instead of white for highlighted arrows. 20100612 08:24:57-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20100612 08:26:58-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin] 20100612 08:36:01-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev 20100612 08:37:44-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...] 20100612 08:47:17-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20100612 09:09:37-!- Upthorn [~ogmar@adsl-75-26-174-104.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 258 seconds] 20100612 09:09:41-!- Upth [~ogmar@adsl-75-26-174-104.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds] 20100612 09:10:13-!- Upthorn [~ogmar@adsl-75-26-170-167.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100612 09:10:14-!- Upth [~ogmar@adsl-75-26-170-167.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100612 09:13:22-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has quit [Ping timeout: 260 seconds] 20100612 09:17:56-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has joined #wesnoth-dev 20100612 09:42:56-!- ancestral [~ancestral@97-116-112-18.mpls.qwest.net] has joined #wesnoth-dev 20100612 09:49:25< CIA-86> silene * r43303 /branches/1.8/data/core/units/humans/Outlaw_Highwayman.cfg: Fixed highwayman not having attack animation. (Fix for bug #16145.) 20100612 09:59:01-!- wesbot changed the topic of #wesnoth-dev to: 124 bugs, 281 feature requests, 13 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100612 10:05:07-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20100612 10:05:28< boucman> hey all 20100612 10:07:30-!- kevg [~kevg@94.232.5.102] has joined #wesnoth-dev 20100612 10:19:59-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection] 20100612 10:24:16-!- Ivanovic [~ivanovic@dtmd-4db2d89d.pool.mediaWays.net] has quit [Changing host] 20100612 10:24:17-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20100612 10:24:58< Ivanovic> moin 20100612 10:26:56< boucman> moin moin 20100612 10:32:06-!- ancestral [~ancestral@97-116-112-18.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.] 20100612 10:41:55-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20100612 10:44:38-!- kevg [~kevg@94.232.5.102] has quit [Remote host closed the connection] 20100612 10:46:47< CIA-86> ivanovic * r43304 /trunk/src/addon/: set some svn irgnores 20100612 11:28:58-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20100612 11:46:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100612 12:03:38-!- loonybot [~loonybot@ppp79-139-137-245.pppoe.spdop.ru] has joined #wesnoth-dev 20100612 12:03:38-!- loonybot [~loonybot@ppp79-139-137-245.pppoe.spdop.ru] has quit [Changing host] 20100612 12:03:38-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20100612 12:04:27-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20100612 12:06:58-!- VladimirSlavik_ [~chatzilla@88.103.147.178] has joined #wesnoth-dev 20100612 12:07:10-!- VladimirSlavik_ is now known as VladimirSlavik 20100612 12:07:35-!- VladimirSlavik [~chatzilla@88.103.147.178] has quit [Changing host] 20100612 12:07:35-!- VladimirSlavik [~chatzilla@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev 20100612 12:09:15-!- meric [~Eric@124.171.54.101] has quit [Quit: meric] 20100612 12:12:57-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20100612 12:14:20< CIA-86> boucman * r43305 /trunk/data/ (7 files in 3 dirs): reorganisation/renaming of all transition macros, mainline updated 20100612 12:24:22< CIA-86> upthorn * r43306 /trunk/src/ (persist_context.cpp persist_context.hpp): 20100612 12:24:23< CIA-86> Re-engineered persist_context struct to simplify structure, initialization, and 20100612 12:24:23< CIA-86> garbage collection as well as reducing data duplication. Additionally, empty 20100612 12:24:23< CIA-86> nodes are now removed from the structure when the last child or attribute is 20100612 12:24:23< CIA-86> removed. 20100612 12:58:23-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20100612 13:06:33-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev 20100612 13:07:23-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20100612 13:13:48-!- k23z__ [~k23z__@188.27.126.170] has joined #wesnoth-dev 20100612 13:18:18-!- Mythological [Mythologic@77.29.0.10] has joined #wesnoth-dev 20100612 13:20:02-!- Mythological_ [Mythologic@77.28.87.158] has quit [Ping timeout: 240 seconds] 20100612 13:29:23-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20100612 13:39:11-!- meric [~Eric@124.171.54.101] has joined #wesnoth-dev 20100612 13:58:33-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20100612 14:13:58-!- fendrin [~fabi@88-134-103-91-dynip.superkabel.de] has joined #wesnoth-dev 20100612 14:13:59-!- fendrin [~fabi@88-134-103-91-dynip.superkabel.de] has quit [Changing host] 20100612 14:13:59-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20100612 14:17:57-!- k23z__ [~k23z__@188.27.126.170] has quit [Ping timeout: 272 seconds] 20100612 14:20:25< zookeeper> boucman, regarding patch #1669: does it prevent the side from showing up in the player assignment screen at all, or just prevent players from taking or getting slotted to that side? 20100612 14:21:37< zookeeper> well, it's currently documented as doing the former, so i guess that's ok...but it wouldn't be a bad thing to be able to show that side yet disallow a human player from taking it, i guess. 20100612 14:22:36< zookeeper> so as far as i'm concerned the patch seems ok to me, if it works as advertised 20100612 14:23:54< zookeeper> the difference between caves of the basilisk and dark forecast is that the latter also has hidden=yes for the side while the former doesn't 20100612 14:30:05-!- meric [~Eric@124.171.54.101] has quit [Quit: meric] 20100612 14:34:24< zookeeper> boucman, in any case, i can't see the bug it's supposed to fix. 20100612 14:34:56< zookeeper> i've tried creating games using those scenarios and i can't see the AI sides anywhere in the side assignment screen 20100612 14:57:13-!- FAAB [~huajie@219.142.237.146] has joined #wesnoth-dev 20100612 15:10:40-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 15:10:47< boucman> hmm 20100612 15:11:08< boucman> thx zookeeper, could you copy/paste your comments above in the bug, and reassign to me ? 20100612 15:12:06-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Ping timeout: 252 seconds] 20100612 15:20:42-!- meric [~Eric@124.171.54.101] has joined #wesnoth-dev 20100612 15:23:00-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev 20100612 15:25:17< CIA-86> alink * r43307 /trunk/src/cursor.cpp: Revert r43164. True cause of the bug was unrelated to this. 20100612 15:25:24< CIA-86> alink * r43308 /trunk/src/ (persist_context.cpp persist_context.hpp): Fix a typo/error and several warnings in r43306 20100612 15:26:29< alink> Upthorn: I think the policy is to use -Wall on trunk, please use it too 20100612 15:27:40< alink> in this case, it even spotted a real coding error (I assumed, maybe check) 20100612 15:27:42-!- kevg [~kevg@94.232.5.102] has joined #wesnoth-dev 20100612 15:27:42-!- King_Elendil [~King_Elen@75.143.233.138] has quit [Read error: Connection reset by peer] 20100612 15:27:49< kevg> hi to all 20100612 15:27:54< alink> hi kevg 20100612 15:28:30-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 15:28:42-!- Appleman1234 [~Appleman1@CPE-60-226-180-71.qld.bigpond.net.au] has quit [Ping timeout: 240 seconds] 20100612 15:31:07< alink> Upthorn: also, I suggest to add better separation between data_ and functions. 20100612 15:35:53-!- mjs-de [~mjs-de@p3EE265C7.dip.t-dialin.net] has joined #wesnoth-dev 20100612 15:42:11< kevg> I have 2 units. And i need to determine if they are enemies or allies or from the same team. What is the best way to do so? Is there are some function in wesnoth? 20100612 15:43:06< alink> kevg: check the code of functions already using this, ZoC probably 20100612 15:43:38< alink> pathfind::enemy_zoc 20100612 15:44:51< alink> kevg: be aware of the mess of team numbers being sometimes (0 or 1)-based 20100612 15:45:23< alink> usually 0-based in c++ code, but sometimes 1-based when related to WML 20100612 15:46:04< kevg> alink: thanks 20100612 15:47:23< alink> kevg: you are welcome, and this is a general trick: copy-paste something similar and adapt it ;-) 20100612 15:51:08-!- norbert_ [~norbert@82-171-70-54.ip.telfort.nl] has joined #wesnoth-dev 20100612 15:52:46-!- meric [~Eric@124.171.54.101] has quit [Quit: meric] 20100612 15:52:46< norbert_> hi, did the era id for the Default Era change permanently (recently)? 20100612 15:53:01< norbert_> *Ageless Era 20100612 15:53:10< norbert_> ehm 20100612 15:53:23< norbert_> never mind, now that I've corrected myself, I can simply download the add-on 20100612 15:56:13< norbert_> it did change; from ageless_era to Ageless Era 20100612 15:57:01< FAAB> norbert_: does it have anything to do with wesnoth dev ? ;) 20100612 15:57:29< norbert_> depends on how narrow you define "Wesnoth dev" 20100612 15:58:36-!- un214 [~quassel@adsl-75-45-4-19.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100612 15:58:44< loonycyborg> norbert_: Probably his point is that it's #wesnoth-umc-dev material :P 20100612 15:58:45< norbert_> my initial question was about the Default Era, but then things changed :) 20100612 15:59:00< CIA-86> alink * r43309 /trunk/src/ (menu_events.cpp widgets/menu.hpp): 20100612 15:59:00< CIA-86> Fix FR/bug #16149: Remember Recall List Sorting Order 20100612 15:59:00< CIA-86> Not saved when exiting the game for now. Not even sure if needed. 20100612 15:59:01-!- wesbot changed the topic of #wesnoth-dev to: 124 bugs, 282 feature requests, 13 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100612 15:59:22-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20100612 15:59:34< mordante> servus 20100612 15:59:50< alink> hi mordante 20100612 16:00:15< mordante> hi alink 20100612 16:01:21-!- un214 [~quassel@adsl-75-45-4-19.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection] 20100612 16:03:03< alink> mordante: -Wall is the trunk policy, right ? 20100612 16:03:31-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20100612 16:03:33< mordante> alink, yes why compilation problem? 20100612 16:04:06< alink> I had some with r43306, but I fixed it 20100612 16:04:20< loonycyborg> alink: AFAIK Upthorn uses msvc. No -Wall for it :P 20100612 16:04:33< alink> oh :-( 20100612 16:04:41-!- k23z__ [~k23z__@188.27.126.240] has joined #wesnoth-dev 20100612 16:05:17< mordante> alink, ah ok then I don't need to fix it :-) 20100612 16:05:48< alink> mordante: yeah, just wanted to be sure that I gave correct info to Upthorn 20100612 16:06:02< mordante> oh haven't read the log yet 20100612 16:06:18< alink> anyway, correct data field initialization order is good practise 20100612 16:06:30< mordante> yup 20100612 16:06:40< mordante> it can avoid silly mistakes 20100612 16:07:55-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 276 seconds] 20100612 16:14:15-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Ping timeout: 265 seconds] 20100612 16:18:13-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20100612 16:19:43-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Remote host closed the connection] 20100612 16:24:04-!- King_Elendil [~King_Elen@75.143.233.138] has quit [Quit: Got to go, I'm in a hurry so bye.] 20100612 16:29:59< mordante> Upth, Upthorn ping 20100612 16:31:37< silene> alink: -Wall -W is the trunk policy 20100612 16:37:24< alink> silene: ok 20100612 16:37:35-!- Catoptromancy [~Cato@unaffiliated/catoptromancy] has quit [Quit: Lost terminal] 20100612 16:39:44< alink> indeed '-W' has also some usefull warnings 20100612 16:41:32< AI0867> heh, I just played 'Glory' in Liberty, and an orc killed the general 20100612 16:41:43< AI0867> the dialogue that followed was rather amusing 20100612 16:55:48< mordante> what was it? 20100612 16:59:46-!- Upthorn [~ogmar@adsl-75-26-170-167.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 264 seconds] 20100612 17:00:33< AI0867> the orc tells the general that his reign of terror is over 20100612 17:01:05< AI0867> then the general goes off on a speech about how they will never successfully oppose asheviere 20100612 17:03:01< mordante> :-) 20100612 17:05:34-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20100612 17:07:50-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20100612 17:13:37< boucman> thespaceinvader: around ? 20100612 17:13:50< thespaceinvader> boucman: what's up? 20100612 17:14:26< boucman> i've been discussing with jetrel, and he believes it would be appropriate to change your forum title... if you're fine with the idea 20100612 17:14:50< boucman> he thought of "Deputy Art Directory" since that describes what you have been doing recently 20100612 17:23:25< CIA-86> loonycyborg * r43310 /trunk/src/ (arrow.cpp arrow.hpp): Fixed compile error with mingw gcc 4.2 20100612 17:23:31< thespaceinvader> yeah, that wouold be fine boucman 20100612 17:23:39< thespaceinvader> i'll change it myself if you want ;) 20100612 17:23:50< boucman> cool, yes, please do :) 20100612 17:29:25< thespaceinvader> sorted tha\t 20100612 17:30:13< boucman> congratulation 20100612 17:35:11< mordante> yeah congrats thespaceinvader 20100612 17:35:19< thespaceinvader> thanks =) 20100612 17:46:56< zookeeper> AI0867, uh, ok...gotta fix that then 20100612 17:49:50-!- crimson_penguin [~ben@64.201.60.211] has joined #wesnoth-dev 20100612 17:49:50-!- crimson_penguin [~ben@64.201.60.211] has quit [Changing host] 20100612 17:49:50-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20100612 17:51:07-!- Blueblaze [~nick@76.202.16.236] has joined #wesnoth-dev 20100612 17:56:45-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100612 17:59:04-!- FAAB [~huajie@219.142.237.146] has quit [Ping timeout: 276 seconds] 20100612 18:01:38< CIA-86> mordante * r43311 /trunk/src/sdl_utils.cpp: 20100612 18:01:38< CIA-86> Make Wesnoth more compatible with C++0x (g++4.5). 20100612 18:01:38< CIA-86> Prevent narrowing when using an initializer list to initialize SDL_Rect. 20100612 18:01:38< CIA-86> This only fixes normal creation function, the other occurrences will be 20100612 18:01:38< CIA-86> fixed in later commits. 20100612 18:01:48< CIA-86> mordante * r43312 /trunk/src/video.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:01:52< CIA-86> mordante * r43313 /trunk/src/unit.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:01:54< CIA-86> mordante * r43314 /trunk/src/unit_frame.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:01:57< CIA-86> mordante * r43315 /trunk/src/about.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:00< CIA-86> mordante * r43316 /trunk/src/attack_prediction_display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:03< CIA-86> mordante * r43317 /trunk/src/cursor.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:08< CIA-86> mordante * r43318 /trunk/src/dialogs.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:09< CIA-86> mordante * r43319 /trunk/src/display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:14< CIA-86> mordante * r43320 /trunk/src/display.hpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:16< CIA-86> mordante * r43321 /trunk/src/editor/editor_controller.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:18< CIA-86> mordante * r43322 /trunk/src/editor/editor_palettes.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:22< CIA-86> mordante * r43323 /trunk/src/editor/mouse_action.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:24< CIA-86> mordante * r43324 /trunk/src/floating_textbox.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:27< CIA-86> mordante * r43325 /trunk/src/font.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:31< CIA-86> mordante * r43326 /trunk/src/game_display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:34< CIA-86> mordante * r43327 /trunk/src/game_preferences_display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:34-!- phlaem [~a@e178090001.adsl.alicedsl.de] has joined #wesnoth-dev 20100612 18:02:37< CIA-86> mordante * r43328 /trunk/src/gui/auxiliary/canvas.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:41< CIA-86> mordante * r43329 /trunk/src/gui/widgets/window.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:44< CIA-86> mordante * r43330 /trunk/src/halo.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:47< CIA-86> mordante * r43331 /trunk/src/image.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:50< CIA-86> mordante * r43332 /trunk/src/loadscreen.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:53< CIA-86> mordante * r43333 /trunk/src/mapgen_dialog.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:02:58< CIA-86> mordante * r43334 /trunk/src/minimap.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:01< CIA-86> mordante * r43335 /trunk/src/multiplayer.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:05< CIA-86> mordante * r43336 /trunk/src/multiplayer_create.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:07< CIA-86> mordante * r43337 /trunk/src/multiplayer_ui.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:10< CIA-86> mordante * r43338 /trunk/src/multiplayer_wait.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:13< CIA-86> mordante * r43339 /trunk/src/preferences_display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:17< CIA-86> mordante * r43340 /trunk/src/storyscreen/render.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:20< CIA-86> mordante * r43341 /trunk/src/titlescreen.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:22< CIA-86> mordante * r43342 /trunk/src/tools/exploder_cutter.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:25< CIA-86> mordante * r43343 /trunk/src/widgets/menu.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:33< CIA-86> mordante * r43344 /trunk/src/widgets/progressbar.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:33< CIA-86> mordante * r43345 /trunk/src/widgets/scrollbar.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:36< CIA-86> mordante * r43346 /trunk/src/widgets/slider.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:39< CIA-86> mordante * r43347 /trunk/src/widgets/textbox.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:43< CIA-86> mordante * r43348 /trunk/src/widgets/widget.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:44< CIA-86> mordante * r43349 /trunk/src/sdl_utils.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:49< CIA-86> mordante * r43350 /trunk/src/ (sdl_utils.cpp sdl_utils.hpp): 20100612 18:03:49< CIA-86> Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:49< CIA-86> Prevent narrowing when using an initializer list to initialize 20100612 18:03:49< CIA-86> SDL_Color. 20100612 18:03:51< CIA-86> mordante * r43351 /trunk/src/game_display.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:54< CIA-86> mordante * r43352 /trunk/src/game_events.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:03:59< CIA-86> mordante * r43353 /trunk/src/generate_report.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:04:02< CIA-86> mordante * r43354 /trunk/src/intro.cpp: Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:04:06< CIA-86> mordante * r43355 /trunk/src/serialization/preprocessor.cpp: 20100612 18:04:07< CIA-86> Make Wesnoth more compatible with C++0x (g++-4.5). 20100612 18:04:07< CIA-86> Prevent narrowing when using an initializer list to initialize 20100612 18:04:07< CIA-86> token_desc. 20100612 18:04:10< CIA-86> mordante * r43356 /trunk/src/ (17 files in 4 dirs): Strip trailing whitespace. 20100612 18:04:17< CIA-86> mordante * r43357 /trunk/changelog: Update changelog. 20100612 18:04:18-!- Shakey [HydraIRC@c-71-201-89-187.hsd1.il.comcast.net] has joined #wesnoth-dev 20100612 18:06:10-!- kevg [~kevg@94.232.5.102] has left #wesnoth-dev [] 20100612 18:19:46< alink> mordante: not important but perhaps 0 is a weird default value for the alpha channel 20100612 18:28:30< mordante> alink, that's how it was used in the old code as well, but feel free to change it 20100612 18:28:50< mordante> also not sure why the field is called unused... 20100612 18:29:37< alink> ok, because not specifying alpha, usually means alpha=255 20100612 18:30:00< alink> mordante: old code? you means SDL_Color construction ? 20100612 18:30:10< mordante> yup 20100612 18:32:58< alink> mordante: I don't understand SDL_Color color = {45,42,42}; fails 20100612 18:35:18< mordante> does it fail? 20100612 18:35:33< alink> yes, I ll past the error msg 20100612 18:36:16< alink> error: missing initializer for member 'SDL_Color::unused' 20100612 18:36:54< mordante> might be that for a struct all fields need to be listed, for an array it's not required 20100612 18:36:58< alink> which make this new create_color() even more welcome :) 20100612 18:37:24< mordante> but I don't use this way of initializing that often 20100612 18:37:36< mordante> s/this/that/ 20100612 18:37:55< alink> yes, and it doesn't work in ctor initializing list, I think 20100612 18:39:21< Upth> alink, mordante 20100612 18:39:41< Upth> sorry about that I went to sleep for 4 hours immediately after making that commit 20100612 18:40:02< crimson_penguin> I guess it's called unused from a loooong time ago... before SDL supported alpha? 20100612 18:40:13< crimson_penguin> but why they actually called it unused is beyond me 20100612 18:40:52< alink> Upth: np, was easy to fix, and it was mainly to inform you about the warning policy 20100612 18:40:53< Upth> I had noticed that there was one initializer list (persist_context::persist_context) that was out of order but forgot to correct it before commit. 20100612 18:41:55< alink> crimson_penguin: maybe they realize too late that renaming it will break too much stuff? 20100612 18:42:06< Upth> and yeah I use msvc which has no wall option which will give me pedantic warnings about ordering. 20100612 18:42:06< crimson_penguin> yeah, I guess 20100612 18:42:32< crimson_penguin> msvc can give a lot of warnings though, can it not? 20100612 18:44:10< mordante> of course but they could have expected an alpha field else why add it to the struct in the first place 20100612 18:44:36< mordante> Upth, I also had some things regarding that file (also started to fix the issue) 20100612 18:44:39< alink> mordante: padding ? 20100612 18:44:53< mordante> then call it padding ;-) 20100612 18:44:59< alink> indeed :) 20100612 18:45:11< Upth> yeah I noticed you said about separating data from functions 20100612 18:45:22< Upth> which I did first thing after waking up 20100612 18:45:39< Upth> and then tried to commit only to be told that my persist_context.*pp files were out of date 20100612 18:46:11< mordante> Upth, when you commit new files please update the copyright header to the current year and yourself as copyright holder 20100612 18:46:45< Upth> ah 20100612 18:46:47< CIA-86> alink * r43358 /trunk/src/ (game_display.cpp game_events.cpp sdl_utils.hpp): Use 255 has default alpha value in the new create_color() 20100612 18:47:35< mordante> also a header file should only have small function definition (preferably only the constructor (if short) and setters) 20100612 18:48:24< mordante> for example parse() is way to long, when a class member is defined in the class definition the compiler inlines the function, which isn't wanted with large functions 20100612 18:49:57< mordante> I'm also not sure whether the name name_space is a good variable name, too close to namespace to my liking, what about for example domain? 20100612 18:57:31-!- Upth [~ogmar@adsl-75-26-170-167.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 260 seconds] 20100612 19:15:23-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100401080539]] 20100612 19:21:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100612 19:24:59-!- Blarumyrran [~Blarumyrr@84-50-143-71-dsl.rkv.estpak.ee] has joined #wesnoth-dev 20100612 19:29:43-!- Shakey [HydraIRC@c-71-201-89-187.hsd1.il.comcast.net] has quit [Quit: Want to be different? Try HydraIRC -> http://www.hydrairc.com <-] 20100612 20:11:15-!- King_Elendil [~King_Elen@75.143.233.138] has joined #wesnoth-dev 20100612 20:17:45-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection] 20100612 20:21:22-!- norbert_ [~norbert@82-171-70-54.ip.telfort.nl] has quit [Quit: Leaving] 20100612 20:21:27-!- k23z__ [~k23z__@188.27.126.240] has quit [Ping timeout: 245 seconds] 20100612 20:31:52-!- Nobun [~Admin@95.74.146.207] has joined #wesnoth-dev 20100612 20:33:17< Nobun> for Developers: There is a bug reported in GNA times ago but someone (was reported at 15/04/2010) that since now not assigned to anyone neither closed. 20100612 20:33:32< Nobun> I reported the thing also in forum: 20100612 20:34:28< silene> Nobun: there are currently 406 open reports, most of them are not assigned; one more or one less... 20100612 20:35:02< Nobun> Yep I can understand but usually you are all very quick to assign a bug to someone :) 20100612 20:35:20< Nobun> this is reported several months ago 20100612 20:35:26< Nobun> not by me 20100612 20:35:47< Nobun> I wrote only here to focus your attention in the case you lost it 20100612 20:35:56< silene> again, there are more than 350 unassigned reports, and some of them were reported several years ago 20100612 20:36:13< Nobun> ah also years xD 20100612 20:36:17< Nobun> I didn't figure it 20100612 20:37:17< Nobun> however I wrote it only for support you on taking note about this (I opened a discussion in forum). Thank for your explainations, silene 20100612 20:38:07< Nobun> I thought you could miss some bugs (forgot about them) so the reason why I wrote also here :) 20100612 20:39:18< Nobun> it is the only way I can contribute (I am not well on programming, very very unable on painting, having not the software to compose music) 20100612 20:39:33< Nobun> thank for your time, silene 20100612 20:57:48< CIA-86> silene * r43359 /trunk/src/random.cpp: Avoided costly roundtrip through strings. 20100612 20:57:53< CIA-86> silene * r43360 /trunk/src/ai/configuration.cpp: Avoided costly roundtrip through strings. 20100612 20:57:57< CIA-86> silene * r43361 /trunk/src/game_preferences_display.cpp: Avoided costly roundtrip through strings. 20100612 20:58:00< CIA-86> silene * r43362 /trunk/src/server/room.cpp: Avoided costly roundtrip through strings. 20100612 20:58:04< CIA-86> silene * r43363 /trunk/src/unit_types.hpp: Avoided costly roundtrip through strings. 20100612 20:58:07< CIA-86> silene * r43364 /trunk/src/gui/dialogs/lobby/lobby_info.cpp: Avoided costly roundtrip through strings. 20100612 20:58:11< CIA-86> silene * r43365 /trunk/src/gui/auxiliary/window_builder/control.cpp: Avoided costly roundtrip through strings. 20100612 20:58:16< CIA-86> silene * r43366 /trunk/src/variable.cpp: Avoided costly roundtrip through strings. 20100612 20:58:19< CIA-86> silene * r43367 /trunk/src/gui/auxiliary/window_builder/tree_view.cpp: Avoided costly roundtrip through strings. 20100612 20:58:23< CIA-86> silene * r43368 /trunk/src/gui/auxiliary/window_builder/toggle_button.cpp: Avoided costly roundtrip through strings. 20100612 20:58:31< CIA-86> silene * r43369 /trunk/src/gui/auxiliary/window_builder/toggle_panel.cpp: Avoided costly roundtrip through strings. 20100612 20:58:32< CIA-86> silene * r43370 /trunk/src/gui/auxiliary/window_builder/button.cpp: Avoided costly roundtrip through strings. 20100612 20:58:36< CIA-86> silene * r43371 /trunk/src/replay.cpp: Avoided costly roundtrip through strings. 20100612 20:58:39< CIA-86> silene * r43372 /trunk/src/upload_log.cpp: Avoided costly roundtrip through strings. 20100612 20:58:43< CIA-86> silene * r43373 /trunk/src/ (upload_log.cpp upload_log.hpp): Removed useless parameter. 20100612 20:58:48< CIA-86> silene * r43374 /trunk/src/ (config.cpp config.hpp): Uninlined, added validity check, and documented functions. 20100612 20:58:53< CIA-86> silene * r43375 /trunk/src/ (config.cpp config.hpp): 20100612 20:58:53< CIA-86> Added config accessor combining has_attribute and get_attribute. 20100612 20:58:53< CIA-86> Ideally, a bool opperator would have been added to attribute_value instead of adding yet another accessor to config. 20100612 20:58:53< CIA-86> But it can't work for now: 20100612 20:58:54< CIA-86> - conversion to a safe bool would lose against the conversion to int; 20100612 20:58:54< CIA-86> - conversion to plain bool would conflict with the conversion to int. 20100612 20:58:55< CIA-86> So we are stuck with using a pointer to emulate an option type. 20100612 20:59:02< CIA-86> silene * r43376 /trunk/src/unit.cpp: Removed redundant attribute lookup. 20100612 20:59:05< CIA-86> silene * r43377 /trunk/src/ai/configuration.cpp: 20100612 20:59:05< CIA-86> Removed redundant attribute lookup. 20100612 20:59:05< CIA-86> Avoided costly roundtrip through strings. 20100612 20:59:08< CIA-86> silene * r43378 /trunk/src/ai/composite/goal.cpp: Removed redundant attribute lookup. 20100612 20:59:12< CIA-86> silene * r43379 /trunk/src/unit_abilities.cpp: Removed redundant attribute lookup. 20100612 20:59:17< CIA-86> silene * r43380 /trunk/src/game_config.cpp: Removed redundant attribute lookup. 20100612 20:59:22< CIA-86> silene * r43381 /trunk/src/gamestatus.cpp: Removed redundant attribute lookup. 20100612 20:59:25< CIA-86> silene * r43382 /trunk/src/gamestatus.cpp: Removed broken test. 20100612 20:59:29< CIA-86> silene * r43383 /trunk/src/gamestatus.cpp: Removed redundant attribute lookup. 20100612 21:01:36-!- Nobun [~Admin@95.74.146.207] has quit [Quit: Leaving.] 20100612 21:10:29< CIA-86> ivanovic * r43384 /branches/1.8/ (5 files in 5 dirs): updated Vietnamese translation 20100612 21:10:33< CIA-86> ivanovic * r43385 /trunk/ (5 files in 5 dirs): updated Vietnamese translation 20100612 21:35:33< CIA-86> mordante * r43386 /trunk/src/persist_context.hpp: Initialize all members. 20100612 21:35:38< CIA-86> mordante * r43387 /trunk/src/arrow.cpp: Initialize all members. 20100612 21:35:40< CIA-86> mordante * r43388 /trunk/src/display.cpp: Initialize all members. 20100612 21:35:44< CIA-86> mordante * r43389 /trunk/src/play_controller.cpp: Initialize all members. 20100612 21:35:46< CIA-86> mordante * r43390 /trunk/src/whiteboard/find_visitor.cpp: Initialize all members. 20100612 21:35:50< CIA-86> mordante * r43391 /trunk/src/whiteboard/manager.cpp: Initialize all members. 20100612 21:35:52< CIA-86> mordante * r43392 /trunk/src/whiteboard/mapbuilder_visitor.cpp: Initialize all members. 20100612 21:40:08< mordante> I'm off night 20100612 21:40:34-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20100612 21:44:24-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100612 21:59:01-!- wesbot changed the topic of #wesnoth-dev to: 124 bugs, 281 feature requests, 13 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100612 22:03:56-!- k23z__ [~k23z__@188.27.127.14] has joined #wesnoth-dev 20100612 22:04:26-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20100612 22:04:59-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100612 22:08:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds] 20100612 22:08:02-!- noy_ is now known as noy 20100612 22:25:31< CIA-86> timotei * r43393 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/StringUtils.java: eclipse plugin: escape regex specific characters (if any) 20100612 22:38:09-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev 20100612 22:50:02-!- Bob_The_Mighty [~chatzilla@cpc4-brig15-0-0-cust904.3-3.cable.virginmedia.com] has joined #wesnoth-dev 20100612 22:54:50-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20100612 22:56:53< gabba> hi boucman 20100612 22:57:00< boucman> hey gabba 20100612 22:57:04< boucman> how is it going ? 20100612 22:57:10< boucman> did you do some thinking ? :P 20100612 22:57:38< gabba> a bit of thinking, and a lot of coding when I concluded I was out of ideas :P 20100612 22:57:45< boucman> hehe 20100612 22:57:47< gabba> I have a quick question 20100612 22:57:50< boucman> sure 20100612 22:58:42< gabba> mordante just went through an initialization rampage through my .cpp files, and I'm not sure I get the point. 20100612 22:59:02< timotei> :)) 20100612 22:59:33< boucman> gabba: different compilers act differently on unitialized members of class, so as a rule of thumb, all our classes initialize all the variables 20100612 23:00:27< gabba> ah. AFAIK for non-reference, non-pointer, non base type members, there's no need to put them in the initialization list since they get initialized with their default constructor 20100612 23:00:36< gabba> so this is not true, or??? 20100612 23:01:13< gabba> what do compilers do differently in this case? 20100612 23:01:31< boucman> probably true, but i'm not a c++ expert, and initializing explicitely everything allows automated checking 20100612 23:03:07< gabba> "automated checking" such as? -- also silene, do you have any extra info on this? 20100612 23:03:58< loonycyborg> gabba: Why did you use float_t instead of float in arrow.?pp ? 20100612 23:04:13< boucman> gabba: i don't know the details, ask mordante, I guess 20100612 23:04:17< timotei> haha "initialization rampage". I'll laugh the whole night at it =)) 20100612 23:05:09< gabba> loonycyborg: I kind of assumed it was there for cross-platform portability reasons, please tell me if it was a bad idea ("long double" DOES sound a little bit like overkill") 20100612 23:05:25-!- Mythological [Mythologic@77.29.0.10] has quit [] 20100612 23:05:27< gabba> timotei: :) 20100612 23:05:47< boucman> gabba: float can have different precision, but it exists on all platforms, and for what we do, it is precise enough 20100612 23:06:06< gabba> boucman: ok, so I'll change it to float 20100612 23:06:13-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Quit: Johannes13_] 20100612 23:06:14< loonycyborg> float_t didn't work on mingw gcc 4.2 that I'm using on the server. 20100612 23:06:24< loonycyborg> I already changed it myself 20100612 23:06:54< gabba> loonycyborg: ok, that's fine - and sorry for the trouble 20100612 23:11:00< silene> gabba: for copy constructor, initializing members with the default constructor is often a bug 20100612 23:13:11< gabba> silene: ah, that's some more interesting info. But what's the difference between relying on the default constructor, and putting the variable name in the initialization list with empty parentheses? 20100612 23:14:09< silene> no difference, but at least it shows to others that using the default constructor was indeed intended 20100612 23:15:53< gabba> So I gather it's more of a stylistic issue to communicate intentions? I happen to like cleaner, easier to read initialization lists, but I can conform to that if it's a Wesnoth guideline. 20100612 23:27:27< boucman> gabba: that's the sort of area where "clean" is open to discussion, I could put arguments both side... 20100612 23:38:57< Espreon> Damn it, I missed alink. 20100612 23:39:50< shadowmaster> thespaceinvader got his color changed :O 20100612 23:40:00< shadowmaster> huzzah! 20100612 23:51:14-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection] 20100612 23:55:12-!- VladimirSlavik [~chatzilla@wesnoth/translator/VladimirSlavik] has quit [Ping timeout: 245 seconds] 20100612 23:55:42-!- VladimirSlavik [~chatzilla@88.103.147.178] has joined #wesnoth-dev --- Log closed Sun Jun 13 00:00:27 2010