--- Log opened Thu Jun 24 00:00:18 2010
20100624 00:06:26-!- qemqemqem_ [~quassel@cpe-74-74-148-190.rochester.res.rr.com] has quit [Ping timeout: 240 seconds]
20100624 00:24:07-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving]
20100624 00:25:10-!- qemqemqem__ [~quassel@urwireless-dhcp-128-151-21-171.wireless.rochester.edu] has joined #wesnoth-dev
20100624 00:49:53-!- ancestral [~ancestral@97-116-114-248.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20100624 00:50:25-!- ancestral [~ancestral@97-116-114-248.mpls.qwest.net] has joined #wesnoth-dev
20100624 00:53:03-!- Bob_The_Mighty [~chatzilla@cpc8-brig15-2-0-cust40.know.cable.virginmedia.com] has joined #wesnoth-dev
20100624 00:58:08-!- qemqemqem__ [~quassel@urwireless-dhcp-128-151-21-171.wireless.rochester.edu] has quit [Remote host closed the connection]
20100624 01:13:16-!- phlaem [~a@e178100031.adsl.alicedsl.de] has quit [Quit: Leaving]
20100624 01:38:57-!- Upth [ogmar@adsl-75-26-178-38.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100624 01:42:11-!- Upthorn [ogmar@adsl-75-26-200-123.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 248 seconds]
20100624 01:45:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100624 01:46:39-!- noy_ [~Noy@70.70.255.54] has joined #wesnoth-dev
20100624 01:46:39-!- noy_ [~Noy@70.70.255.54] has quit [Changing host]
20100624 01:46:39-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100624 01:50:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds]
20100624 01:50:22-!- noy_ is now known as noy
20100624 02:00:44-!- Gambit_ [~quassel@67.234.73.7] has joined #wesnoth-dev
20100624 02:04:15-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Ping timeout: 240 seconds]
20100624 02:11:17-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100624 02:14:45-!- Gambit_ [~quassel@67.234.73.7] has quit [Ping timeout: 240 seconds]
20100624 02:16:44-!- Gambit_ [~quassel@67.234.73.7] has joined #wesnoth-dev
20100624 02:16:56-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100624 02:18:50-!- Gambit is now known as Guest21865
20100624 02:19:06-!- Gambit_ is now known as Gambit
20100624 02:19:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100624 02:20:35-!- Guest21865 [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Ping timeout: 260 seconds]
20100624 02:44:43-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100624 03:00:03-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Quit: Leaving]
20100624 03:07:09-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20100624 03:07:58-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20100624 03:33:22< Espreon> OK, the game segfaulted in the test scenario when a side two unit moved on one of hexes that trigger the map changes: wesnoth: /home/espreon/wesnoth/src/shared_object.hpp:79: const T& shared_object<T, node>::get() const [with T = t_string_base, node = shared_node<t_string_base>]: Assertion `valid()' failed.
20100624 03:35:40< ancestral> Blueblaze: Need to take a 5-10 min. break
20100624 03:35:45< ancestral> oops wrong channel
20100624 03:40:12< Espreon> Meh, segfault/assertion failure, whatever.
20100624 03:49:13< CIA-87> alink * r43662 /trunk/src/unit_map.cpp: Remove now useless calls (parameter is ignored and remaining code already called at construction)
20100624 03:49:15< CIA-87> alink * r43663 /trunk/src/ (unit.cpp unit.hpp): Remove useless parameter and code redundancy
20100624 03:49:20< CIA-87> alink * r43664 /trunk/src/ (5 files): Improve constness of recall list's uses
20100624 03:49:27< CIA-87> alink * r43665 /trunk/src/ (15 files in 7 dirs): 
20100624 03:49:27< CIA-87> Use resources in unit::invisible()
20100624 03:49:27< CIA-87> It was already using it via get_ability_bool("hides")
20100624 03:49:31< CIA-87> alink * r43666 /trunk/src/ (menu_events.cpp mouse_events.cpp unit.cpp unit.hpp): use resources::units in find_visible_unit
20100624 03:49:38< CIA-87> alink * r43667 /trunk/src/ (5 files in 2 dirs): use resources::units in get_visible_unit()
20100624 03:49:39< CIA-87> alink * r43668 /trunk/src/ (6 files in 5 dirs): use resources::units in get_teleport_locations()
20100624 03:49:41< CIA-87> alink * r43669 /trunk/src/ (actions.cpp pathfind/pathfind.cpp pathfind/pathfind.hpp): use resources::units in enemy_zoc()
20100624 03:50:07-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100624 04:09:52-!- Netsplit *.net <-> *.split quits: elias, yann, AI0867
20100624 04:11:00-!- Netsplit over, joins: yann, AI0867, elias
20100624 04:25:22-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 252 seconds]
20100624 04:30:08-!- Blarumyrran [~Blarumyrr@unaffiliated/blarumyrran] has quit [Read error: Connection reset by peer]
20100624 04:34:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100624 04:34:27-!- Appleman1234 [~Appleman1@131.181.100.34] has quit [Ping timeout: 248 seconds]
20100624 04:39:22-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100624 04:42:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20100624 04:42:47-!- noy_ is now known as noy
20100624 04:49:45-!- Ivanovic_ [~ivanovic@dtmd-4db2ab41.pool.mediaWays.net] has joined #wesnoth-dev
20100624 04:53:12-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 258 seconds]
20100624 04:53:42-!- Gambit [~quassel@67.234.73.7] has quit [Quit: But now it's time for me to go. The autumn moon lights my way.]
20100624 04:53:43-!- Ivanovic_ is now known as Ivanovic
20100624 05:33:34-!- Bob_The_Mighty [~chatzilla@cpc8-brig15-2-0-cust40.know.cable.virginmedia.com] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.4/20100611143157]]
20100624 05:34:36-!- gabba [~gabba@wesnoth/developer/gabba] has quit [Quit: Leaving.]
20100624 05:50:52-!- Valkier [~IceChat7@c-174-55-104-2.hsd1.pa.comcast.net] has quit [Quit: OUCH!!!]
20100624 06:14:42-!- ancestral [~ancestral@97-116-114-248.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20100624 06:26:52-!- shadowm_laptop is now known as OrangeMaster
20100624 06:39:22-!- Appleman1234 [~Appleman1@131.181.100.34] has joined #wesnoth-dev
20100624 06:40:16-!- OrangeMaster is now known as shadowm_laptop
20100624 06:43:31-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Remote host closed the connection]
20100624 06:50:18-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev
20100624 06:58:31-!- silene [~plouf@bau91-1-82-239-244-109.fbx.proxad.net] has joined #wesnoth-dev
20100624 06:59:11-!- Blueblaze [~nick@adsl-99-186-64-86.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20100624 07:00:52-!- silene [~plouf@bau91-1-82-239-244-109.fbx.proxad.net] has quit [Changing host]
20100624 07:00:52-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100624 07:03:38-!- Mythological [~mythologi@77.28.88.255] has joined #wesnoth-dev
20100624 07:05:07< CIA-87> gabba * r43671 /trunk/src/ (3 files in 2 dirs): Whiteboard: continue the revert toward punctual application of temp modifiers.
20100624 07:05:10< CIA-87> gabba * r43670 /trunk/src/ (mouse_events.cpp whiteboard/manager.cpp): Whiteboard: start of the revert toward punctual application of temp modifiers.
20100624 07:05:13< CIA-87> gabba * r43672 /trunk/src/ (7 files in 2 dirs): Whiteboard: continue the revert toward punctual application of temp modifiers.
20100624 07:05:18< CIA-87> gabba * r43673 /trunk/src/whiteboard/ (manager.cpp manager.hpp move.hpp): 
20100624 07:05:18< CIA-87> Whiteboard: finished the revert toward punctual application of temp modifiers.
20100624 07:05:18< CIA-87> Some path highlighting issues remain.
20100624 07:05:25< CIA-87> gabba * r43674 /trunk/src/ (mouse_events.cpp whiteboard/manager.cpp): Whiteboard: made highlight work properly, and blocked mouse click during wb move creation animation.
20100624 07:05:31< CIA-87> gabba * r43675 /trunk/src/mouse_events.cpp: Whiteboard: deselect with right-click now works properly.
20100624 07:05:38< CIA-87> gabba * r43676 /trunk/src/whiteboard/ (manager.cpp move.cpp): Whiteboard: some todos
20100624 07:10:34-!- ancestral [~ancestral@97-116-114-248.mpls.qwest.net] has joined #wesnoth-dev
20100624 07:10:41< CIA-87> espreon * r43677 /trunk/ (445 files in 20 dirs): Converted more apostrophes; ran pofix.
20100624 07:10:54< Espreon> ancestral: ^ Yeahz, you may wanna svn up.
20100624 07:11:04< ancestral> Slick
20100624 07:11:10< ancestral> Short night tonight
20100624 07:11:10< Espreon> ancestral: I think that I'll work on TSG now.
20100624 07:11:13< ancestral> Okay
20100624 07:14:45-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Ping timeout: 265 seconds]
20100624 07:15:53-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev
20100624 07:29:02-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Operation timed out]
20100624 07:30:13-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Ping timeout: 265 seconds]
20100624 07:30:26-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100624 07:40:35< Espreon> Hmmmm, since the default language is American English, shall I enforce illogical quotes?
20100624 07:40:47< Espreon> esr: ^ ?
20100624 07:42:34-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100624 07:43:43-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev
20100624 07:44:35-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100624 08:05:10-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20100624 08:17:35-!- Mythological [~mythologi@77.28.88.255] has quit []
20100624 08:24:03< Espreon> boucman: http://forums.wesnoth.org/viewtopic.php?p=437482#p437482
20100624 08:24:28< boucman> thx, but the change is already compiled, i'm about to test it :)
20100624 08:26:06< Espreon> Ah, I see.
20100624 08:27:02< Espreon> boucman: Also: http://forums.wesnoth.org/viewtopic.php?p=437401#p437401
20100624 08:27:33-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20100624 08:27:42< boucman> hey gabba
20100624 08:27:49< Espreon> Hello gabba.
20100624 08:27:51< CIA-87> boucman * r43678 /trunk/ (4 files in 3 dirs): set movement speed to 200, will be documented once jetrel confirms the speed is fine
20100624 08:27:55< gabba> hey boucman & Espreon
20100624 08:27:55< CIA-87> gabba * r43679 /trunk/src/whiteboard/ (action.hpp move.cpp move.hpp side_actions.cpp): Whiteboard: handle case where unit doesn't finish it's move for whatever reason. Still needs tweaking.
20100624 08:28:06< CIA-87> gabba * r43680 /trunk/src/whiteboard/move.cpp: Whiteboard: handle case where executing move results in no movement, such as when unit has no movement points remaining.
20100624 08:28:12< boucman> Espreon: not sure why you pointed the second one to me...
20100624 08:28:28< boucman> gabba: i'll be around all day today, if you need me (exceptionally)
20100624 08:29:36< Espreon> boucman: Well, I thought that maybe you would want to wire them in correctly. Unless I misinterpreted it and he already did fix it and just posted an earlier screenshot.
20100624 08:30:04< gabba> boucman: alright! I'm not sure when I'll log back in, since it's 2:30 AM here and I'll sleep eventually. I really wanted to put the whiteboard back in shape, and thankfully it's looking good now.
20100624 08:30:31< boucman> if I read Eleazar correctly, they were correctly wired in before commit, only the screenshot is wrong
20100624 08:30:43< Espreon> Meh, who knows?
20100624 08:30:56< Espreon> gabba: 6:00 AM is the ideal bedtime.
20100624 08:31:07< Espreon> Being crepuscular/nocturnal is quite nice.
20100624 08:31:34< boucman> gabba: great, go get some sleep, then ;)
20100624 08:32:16< gabba> Espreon: It's great for coding, but girlfriends tend to appreciate it less :-/. Can't see why really :P .
20100624 08:32:36< Espreon> Uh huh, I see.
20100624 08:34:01< shadowmaster> ...am I the only one who doesn't like the road terrain "improvements"?
20100624 08:34:42< shadowmaster> same goes for the ford, which I can hardly distinguish from regular shallow water now (and I'm not affecteed by any kind of color-blindness)
20100624 08:34:51 * Rhonda . o O ( fnord )
20100624 08:35:21 * Espreon doesn't like the "improvements" with the dark road.
20100624 08:35:57< Espreon> shadowmaster: Perhaps some of these "improvments" are only improvements in the eyes of visuophiles.
20100624 08:36:05< gabba> boucman: your code review skills would be welcome since I changed a lot of stuff; also I have a problem with the real unit at the start position flickering (you'll easily see it when testing), and I haven't found yet why it happens... graphics debugging help is welcome.
20100624 08:36:13< shadowmaster> Espreon: I know your opinions.
20100624 08:36:29< Espreon> Jeß jeß...
20100624 08:36:38< shadowmaster> I'm voicing them in here hoping that someone with more artistic experience reads them.
20100624 08:36:50< shadowmaster> because if I post them in the forums I'll most likely look like a retard to Jetrel.
20100624 08:36:51< boucman> gabba: sure thing, but my review might be lon, we might want to do it at your wakeup
20100624 08:37:12< gabba> boucman: sure, I'm off now.
20100624 08:37:18< boucman> g'night
20100624 08:37:21< gabba> See you all. Zzzzz....
20100624 08:37:24-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20100624 08:49:35< CIA-87> boucman * r43681 /trunk/data/core/ (4 files in 2 dirs): allow transitions detection on hex with 4/5/6 similar neighbours
20100624 08:59:38-!- stikonas [~and@ctv-79-132-162-160.vinita.lt] has joined #wesnoth-dev
20100624 08:59:38-!- stikonas [~and@ctv-79-132-162-160.vinita.lt] has quit [Changing host]
20100624 08:59:38-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 09:04:52-!- gangil [~gangil@unaffiliated/gangil] has joined #wesnoth-dev
20100624 09:05:29< gangil> Can you give me an advice, as I am developing a small RPG game, if MiniXML would suffice my needs ? The game is pretty much basic as of now.
20100624 09:14:45-!- Ivanovic [~ivanovic@dtmd-4db2ab41.pool.mediaWays.net] has quit [Changing host]
20100624 09:14:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100624 09:15:16< Ivanovic> moin
20100624 09:18:22< shadowmaster> WOW. Enabling SDL's hardware (???) acceleration does the opposite of improving performance.
20100624 09:18:43< shadowmaster> +       frameBuffer = SDL_SetVideoMode( x, y, bits_per_pixel, flags |SDL_HWSURFACE | SDL_HWACCEL );
20100624 09:19:56< shadowmaster> now a particular view gets drawn at 15-18 fps when it was drawn at 20-30 fps without those flags.
20100624 09:21:59-!- Upthorn [~ogmar@adsl-75-26-178-38.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100624 09:23:25< shadowmaster> hm.
20100624 09:24:00< shadowmaster> well, SDL_HWSURFACE was already on. What happens if I do something like foo | A | A ? if this equivalent to foo | A or to foo ?
20100624 09:25:22-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 09:25:27-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20100624 09:25:54< shadowmaster> (assuming !(foo & A); and yes, I hardly know a lot bout bitwise operations)
20100624 09:27:39< shadowmaster> s/a lot bout/about/
20100624 09:32:53< ABCD> A | A == A
20100624 09:33:14< shadowmaster> ah.
20100624 09:33:35< ABCD> "|" is associative and commutative, so ((foo | A) | A) == (foo | (A | A))
20100624 09:33:49< shadowmaster> so, setting SDL_HWACCEL is what slows down stuff.
20100624 09:34:52< silene> shadowmaster: for wesnoth, that's expected, since the engine constantly saves the parts of the framebuffer it is about to overwrite
20100624 09:35:13< shadowmaster> what for?
20100624 09:36:02< silene> what for what? saving the overwritten parts? to restore them afterward, obviously
20100624 09:37:25< shadowmaster> I still don't understand what's the point in saving/restoring the framebuffer like that.
20100624 09:38:23< shadowmaster> IIRC alpha bleding operations and such are done in separate software surfaces before blitting on the screen fb
20100624 09:40:37< silene> only things that don't care about the current picture can blended out of the screen buffer; things like halos, labels, units, and so on, need the content of the framebuffer in order to be drawn
20100624 09:43:31< shadowmaster> hm. right.
20100624 09:51:07-!- stikonas_ is now known as stikonas
20100624 09:56:02< CIA-87> espreon * r43682 /trunk/ (517 files in 25 dirs): Converted more apostrophes; ran pofix.
20100624 09:56:10< Espreon> ancestral: ^
20100624 10:09:18-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20100624 10:10:48-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100624 10:10:58-!- stikonas [~and@ctv-79-132-162-160.vinita.lt] has joined #wesnoth-dev
20100624 10:10:58-!- stikonas [~and@ctv-79-132-162-160.vinita.lt] has quit [Changing host]
20100624 10:10:58-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 10:13:49-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100624 10:23:14-!- gangil1 [~gangil@122.175.80.66] has joined #wesnoth-dev
20100624 10:24:01-!- gangil [~gangil@unaffiliated/gangil] has quit [Read error: Connection reset by peer]
20100624 10:27:05-!- Upthorn [~ogmar@adsl-75-26-178-38.dsl.scrm01.sbcglobal.net] has quit [Quit: I'm a gay robot / oh, God, it is Brock Samson / It's nerf or nothin']
20100624 10:52:32-!- Upthorn [~ogmar@adsl-75-26-178-38.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100624 11:06:56< CIA-87> fendrin * r43683 /trunk/data/campaigns/Delfadors_Memoirs/maps/ (09_Houses_of_the_Dead.map 18_The_Portal_of_Doom.map): DM: Map terrain updates.
20100624 11:14:22< CIA-87> ivanovic * r43684 /trunk/src/whiteboard/: set svn:ignore
20100624 11:22:25< Espreon> Ivanovic: Be careful when runnng pofix on data/campaigns; in TSG, the rules will introduce UTF-8 in things such as ids.
20100624 11:22:59< Ivanovic> Espreon: i just ran a check and you have everything covered, no need for me to change anything
20100624 11:23:20< Ivanovic> (my test is running pofix on all pof files, running a pot-update afterwards and then running pofix again
20100624 11:23:25< Espreon> OK, I just wanted to make sure.
20100624 11:23:33< Ivanovic> if in the last pofix run something new comes up, those changes are missing in the cfg files
20100624 11:23:45< Ivanovic> (can get them using a diff between the bak and the normal file)
20100624 11:27:12-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20100624 11:28:47< CIA-87> espreon * r43685 /trunk/ (55 files in 3 dirs): 'Epilog' -> 'Epilogue'.
20100624 11:28:53< Espreon> Yes, I ran pofix.
20100624 11:30:06< CIA-87> espreon * r43686 /trunk/data/campaigns/Delfadors_Memoirs/maps/plains.map: Smote an unused map.
20100624 11:32:17-!- Upthorn [~ogmar@adsl-75-26-178-38.dsl.scrm01.sbcglobal.net] has quit [Quit: guitar you to death / we're abusing the triggers / combat rape turtles]
20100624 11:33:06-!- loonybot [~loonybot@ppp79-139-137-245.pppoe.spdop.ru] has joined #wesnoth-dev
20100624 11:33:06-!- loonybot [~loonybot@ppp79-139-137-245.pppoe.spdop.ru] has quit [Changing host]
20100624 11:33:06-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100624 11:34:10-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100624 11:37:33-!- Upthorn [~ogmar@75.26.178.38] has joined #wesnoth-dev
20100624 11:40:34< Espreon> Ivanovic: You wouldn't mind if I were to set up svn:ignore patterns for -bak files, would you?
20100624 11:40:45< Ivanovic> please don't
20100624 11:40:54< Espreon> Why?
20100624 11:41:03< Ivanovic> reason: this way i can easily see newly added -bak files which *might* be relevant
20100624 11:41:13< Espreon> Fair enough.
20100624 11:41:18< Ivanovic> just rm those files yourself once you are done with the updates you run
20100624 11:42:15< Espreon> It's just so annoying to have to type a bigass command just to unpollute my svn status output. But, whatever.
20100624 11:42:35< Ivanovic> uhm, bigass command?
20100624 11:42:42< Ivanovic> rm po/wesnoth*/*-bak
20100624 11:42:46< Ivanovic> one simple line...
20100624 11:43:03< Espreon> Oh, I was running something more elaborate, but, whatever.
20100624 11:43:54< boucman> I do a xargs on "svn st"
20100624 11:54:35< Espreon> Yeah, the Sun is rising, so... yeahz.
20100624 11:54:39< Espreon> Goodbye.
20100624 11:54:46 * Espreon disappears...
20100624 11:56:35-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20100624 12:02:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100624 12:10:02-!- Appleman1234 [~Appleman1@131.181.100.34] has quit [Quit: Leaving]
20100624 12:39:43-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Ping timeout: 258 seconds]
20100624 13:26:03-!- euschn [~eugen@wesnoth/developer/euschn] has joined #wesnoth-dev
20100624 13:41:32-!- gangil1 [~gangil@122.175.80.66] has quit [Ping timeout: 276 seconds]
20100624 13:45:12-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 13:46:07-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has joined #wesnoth-dev
20100624 14:00:31-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20100624 14:20:32-!- Valkier [~IceChat7@c-174-55-104-2.hsd1.pa.comcast.net] has joined #wesnoth-dev
20100624 14:23:59-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev
20100624 14:27:36< Rhonda> oh
20100624 14:27:41 * Rhonda bonks wesbot over the head.
20100624 14:27:46< zookeeper> uh...aren't the little arrows in the new story screen navigation buttons a bit reversed?
20100624 14:28:13< zookeeper> next ->         <- back           first <-            -> last
20100624 14:28:35< zookeeper> shouldn't that be       next ->         <- back           <- first            last ->     ?
20100624 14:31:46< zookeeper> i can see why it'd seem more logical to have it the way it is, but frankly that seems just confusing and harder to read to me
20100624 14:32:34-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev
20100624 14:32:54-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20100624 14:32:54 * wesbot bonks Rhonda over the head.
20100624 14:34:04< zookeeper> also i don't understand the point of the "first" and "last" buttons. why not just have "next", "back" and "play/skip"?
20100624 14:35:07< Rhonda> zookeeper: shouldn't it be rather <- first  <- back   next ->  last ->
20100624 14:35:25 * zookeeper shrugs
20100624 14:35:40< zookeeper> would make more sense that way too, i suppose
20100624 14:35:48< Rhonda> That would make more sense, IMHO and is consistent with other similar navigations.
20100624 14:35:56< Rhonda> :)
20100624 14:36:13< zookeeper> err, wait, that's exactly what i suggested, just ordered differently
20100624 14:36:24< Rhonda> you said next back first last?
20100624 14:36:32< Rhonda> I said first back next last
20100624 14:36:39< zookeeper> "just ordered differently"
20100624 14:37:00< zookeeper> i wasn't originally commenting on the ordering
20100624 14:37:03< Rhonda> but you ordered the initial part differently too?
20100624 14:37:25< Rhonda> oh, wait. you were just refering to switch the first and last arrows from before/after to the other way round.
20100624 14:37:29< zookeeper> yeah
20100624 14:37:36< Rhonda> Now it makes sense. :)
20100624 14:38:50< zookeeper> also i suppose we still don't have the possibility of disabling buttons :/
20100624 14:41:44< boucman> no, we don't have that possibility
20100624 14:47:45-!- billynux [~billy@wesnoth/developer/billynux] has joined #wesnoth-dev
20100624 14:52:33< Rhonda> Hmm, but the language selection has some disabling feature?
20100624 14:52:40< Rhonda> But those aren't buttons.
20100624 14:54:24< boucman> Rhonda: I didn't say it wasn't doable, it's just hadsn't been coded...
20100624 14:54:47< boucman> and i'm not sure allowing WML authors to forbid skiping intro is a good idea, but that's another discussion
20100624 14:54:54< Rhonda> Yeah, I just wondered if that is a different area. :)
20100624 14:55:08< boucman> I think Kegv did that patch, if you want him to correct
20100624 14:57:03< zookeeper> boucman, uh, i wasn't suggesting that
20100624 14:57:23< boucman> zookeeper: well, you were suggesting correcting the buttons, at least :)
20100624 14:57:49< zookeeper> yeah, making them not appear and disappear in different screens
20100624 14:58:00< zookeeper> which is always confusing
20100624 15:00:59< zookeeper> i can't think of any better way to do the story screens besides having just three buttons (next, back, play/skip) with back disabled on the first screen and next disabled on the last screen.
20100624 15:02:17< zookeeper> the "first" and "last" buttons are pretty redundant considering that there's never _that_ many screens in the first place, nor do you (IMO) really want to see the last screen if you don't want to see the previous ones.
20100624 15:32:46-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has joined #wesnoth-dev
20100624 15:35:45-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 15:36:06-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Client Quit]
20100624 15:36:20-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 15:39:18-!- Crab_ [~Crab@wesnoth/developer/crab] has joined #wesnoth-dev
20100624 15:41:12-!- Upthorn [~ogmar@75.26.178.38] has quit [Quit: slides under a truck / You seem a decent fellow / Damn you all to hell!]
20100624 15:50:19-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has quit [Remote host closed the connection]
20100624 15:51:59-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20100624 15:54:14-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100624 15:56:11-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has joined #wesnoth-dev
20100624 15:57:24-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has quit [Remote host closed the connection]
20100624 15:58:57< AI0867> 22:32 < timotei> AI0867: in the schema, identifier="re ^[a-zA-Z0-9_ ]+$" , does the identifier allow spaces? <-- yes, this is because unit idS are allowed to contain spaces
20100624 16:03:44< Soliton> that also allows a single space? is that legal?
20100624 16:04:20< Soliton> ah unit ids, i guess it is, technically.
20100624 16:30:31-!- King_Elendil [~King_Elen@75.143.235.104] has joined #wesnoth-dev
20100624 16:34:48-!- King_Elendil [~King_Elen@75.143.235.104] has quit [Client Quit]
20100624 16:41:14-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
20100624 16:45:07-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has joined #wesnoth-dev
20100624 16:53:00-!- PK [~pk@r74-192-30-57.bcstcmta01.clsttx.tl.dh.suddenlink.net] has joined #wesnoth-dev
20100624 16:59:08-!- euschn [~eugen@wesnoth/developer/euschn] has quit [Ping timeout: 276 seconds]
20100624 16:59:12-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20100624 17:09:01-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has joined #wesnoth-dev
20100624 17:09:01-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has quit [Remote host closed the connection]
20100624 17:09:19< CIA-87> eleazar * r43687 /trunk/data/core/images/terrain/flat/ (60 files): removing unneeded old grass-to-water transitions.
20100624 17:11:33-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has joined #wesnoth-dev
20100624 17:22:53< CIA-87> eleazar * r43688 /trunk/data/core/ (65 files in 2 dirs): some tweaks to the 'bank' what i've now decided to call the flat-to-water transition.
20100624 17:34:30-!- EdB [~EdB@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20100624 17:46:48< CIA-87> eleazar * r43689 /trunk/data/core/images/terrain/flat/ (4 files): some temporary purple grass 5 and 6 sided transitions.
20100624 17:55:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100624 17:55:55< CIA-87> boucman * r43690 /trunk/data/core/terrain-graphics/internal-border.cfg: fix stupy copy/paste mistakes in six sided transitions
20100624 17:59:55-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev
20100624 18:00:14-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has quit [Remote host closed the connection]
20100624 18:05:04-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100624 18:10:27< CIA-87> boucman * r43691 /trunk/ (21 files in 4 dirs): 
20100624 18:10:27< CIA-87> early commit of the stonebridge to allow artists to test in place... note that
20100624 18:10:27< CIA-87> multiple tiles are not placed correctly (n-s main tile is the most visible) and
20100624 18:10:27< CIA-87> that most transitions are missing of badly placed. However all macros are in
20100624 18:10:27< CIA-87> place and artists can start adjusting
20100624 18:16:49-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20100624 18:18:00< CIA-87> boucman * r43692 /trunk/src/whiteboard/ (7 files): partially revert accidental commit
20100624 18:24:05-!- D-zize [~rudi@110.138.179.20] has joined #wesnoth-dev
20100624 18:24:17-!- D-zize [~rudi@110.138.179.20] has left #wesnoth-dev []
20100624 18:34:02-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20100624 18:37:50-!- _jbx_ [~jbailey@12.190.80.225] has joined #wesnoth-dev
20100624 19:00:41-!- Bocom [~Bocom@c-b7cfe255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Quit: Lämnar]
20100624 19:01:29-!- ancestral [~ancestral@97-116-114-248.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20100624 19:01:48-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: restarting X.org]
20100624 19:05:14-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 265 seconds]
20100624 19:09:04-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100624 19:09:38-!- shadowm_laptop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100624 19:09:39-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Disconnected by services]
20100624 19:09:48-!- shadowm_laptop2 is now known as shadowm_laptop
20100624 19:19:52-!- Blueblaze [~nick@adsl-99-186-64-86.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100624 19:27:14-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20100624 19:28:43< CIA-87> eleazar * r43693 /trunk/data/core/images/terrain/bridge/ (18 files): adjusted file name, fixed translateable name for the new basic stone bridge.
20100624 19:29:14< CIA-87> eleazar * r43694 /trunk/data/core/ (terrain-graphics.cfg terrain.cfg): adjusted file name, fixed translateable name for the new basic stone bridge. Part 2. Done.
20100624 19:31:45-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100624 19:32:30< timotei> hey fendrin. around?
20100624 19:35:38-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20100624 19:36:36< CIA-87> eleazar * r43695 /trunk/data/core/images/terrain/flat/ (4 files): returning test grass transitions back to green from purple.
20100624 19:39:59-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100624 19:46:31-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100624 19:51:52< CIA-87> eleazar * r43696 /trunk/data/core/images/terrain/frozen/ (27 files): adjusted snow color away from cyan toward blue to match the snow hills and snow mountains better.
20100624 19:55:17-!- Crab_ [~Crab@wesnoth/developer/crab] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20100624 19:59:38-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 20:01:04-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20100624 20:01:13-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20100624 20:06:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100624 20:07:29-!- phlaem [~a@e178097170.adsl.alicedsl.de] has joined #wesnoth-dev
20100624 20:07:51-!- PK [~pk@r74-192-30-57.bcstcmta01.clsttx.tl.dh.suddenlink.net] has quit [Quit: Java user signed off]
20100624 20:08:05-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 240 seconds]
20100624 20:17:00-!- Sirp [~me@wesnoth/developer/dave] has joined #wesnoth-dev
20100624 20:22:17< fendrin> timotei: yes
20100624 20:23:07-!- stikonas_ is now known as stikonas
20100624 20:23:47< timotei> fendrin: I have a question on how should I do a thing
20100624 20:23:52< timotei> you know, there is the wml schema
20100624 20:24:08< timotei> in the xtext framework, for the future editor, I have to write the WML "grammar", based on the schema.
20100624 20:24:47< timotei> but that need to be "converted". Should I try and make a script/java program that does that, or it's fine if I write it manually?
20100624 20:25:06< timotei> provided the wml schema will not change "so much" between different periods of yime
20100624 20:25:09< timotei> s/yime/time
20100624 20:25:46-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-174.telecom.by] has joined #wesnoth-dev
20100624 20:25:57-!- Bocom [~Bocom@c-b7cfe255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20100624 20:26:07< fendrin> timotei: I think it's far better to do that by a script/program.
20100624 20:26:31< timotei> fendrin: okay
20100624 20:26:59< fendrin> timotei: Just imagine a total conversion of wesnoth that uses the same engine but defines another set of wml language.
20100624 20:27:16< timotei> fair enough :D
20100624 20:32:36< silene> you don't have to imagine a total conversion, that's already the case for both 1.8 mainline and umc
20100624 20:36:14-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100624 20:36:50< shadowmaster> lua-based WML tags?
20100624 20:38:37< silene> yes
20100624 20:39:51< silene> more precisely, the ones that are not in wml-tags.lua (since these ones are part of the standard wml language)
20100624 20:40:22< timotei> silene: where is wml-tags.lua file?
20100624 20:43:10< silene> timotei: in data/lua; but as i said, you don't have to look at it, since it defines standard wml tags that are available for any wml scenarios; what's important to understand is that there are mainline and user-made campaigns that define their own wml tags
20100624 20:44:02< timotei> oh. ok
20100624 20:49:57-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100624 20:50:15-!- timotei [~timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20100624 20:50:33< CIA-87> espreon * r43697 /trunk/data/core/images/terrain/bridge/ (9 files): Ran umcpropfix.
20100624 20:56:39-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has joined #wesnoth-dev
20100624 20:56:51-!- e_s-iOS [~esios@pool-108-2-88-55.phlapa.east.verizon.net] has quit [Remote host closed the connection]
20100624 20:56:57-!- ancestral [~ancestral@12.145.225.25] has joined #wesnoth-dev
20100624 20:58:50< fendrin> silene, timotei: The wml schema file will contain descriptions for that lua based wml tags as well. 
20100624 20:59:31< fendrin> timotei: Don't bother about the lua wml tags for now. We will find a solution for them at another level.
20100624 20:59:42< timotei> fendrin: yes, no problem with that:)
20100624 21:00:01< timotei> I'm just writing some simple and general WML grammar rules so I can adapt the script
20100624 21:00:08< timotei> to create the whole grammar from the schema :D
20100624 21:00:38< ancestral> timotei: That's awesome!
20100624 21:00:39< timotei> fendrin: I just found a much easier and faster method of setup-ing the workspace in eclipse :D
20100624 21:00:54< silene> fendrin: but how do you store nonstandard one? for instance, how do you put the [chat_message] tag from wesband in the schema?
20100624 21:03:53-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 245 seconds]
20100624 21:14:01-!- Crab_ [~Crab_@c.218.175.a530.sta.adsl.cyfra.net] has joined #wesnoth-dev
20100624 21:14:09-!- Crab_ [~Crab_@c.218.175.a530.sta.adsl.cyfra.net] has quit [Changing host]
20100624 21:14:09-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100624 21:15:51-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Ping timeout: 240 seconds]
20100624 21:15:56< fendrin> silene: The schema.cfg file will be generated out of c++ comments in the future. mordante already did a similar thing for his gui wml tags. We will also read lua comments to generate campaign or addon specific schema.cfgs.
20100624 21:16:49< fendrin> silene: Those comments will also act as the source for generating the wml reference wiki then.
20100624 21:20:26< shadowmaster> sudo ldconfig
20100624 21:20:30< shadowmaster> er.
20100624 21:21:17< silene> fendrin: are you the one who will copy the whole content of the wiki to c++ comments?
20100624 21:26:45< fendrin> silene: No, it will be a time taking process, finished far in the future.
20100624 21:27:06< fendrin> silene: But I will contribute some of the needed work.
20100624 21:29:21-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20100624 21:29:32< gabba> bonjour
20100624 21:30:01< shadowmaster> hi there
20100624 21:30:55< boucman> bonjour gabba
20100624 21:31:20< boucman> I proofread your code, let me check my notes... (not much this time, though)
20100624 21:31:23< billynux> bonjour gabba
20100624 21:31:56< boucman> (if you're ready to start with that...
20100624 21:32:31< gabba> salut boucman et billynux
20100624 21:32:43< Espreon> gabba: Ic grete þe.
20100624 21:32:48< gabba> sure boucman, I'm ready
20100624 21:32:54< gabba> hi Espreon
20100624 21:32:55< boucman> k
20100624 21:33:04< ancestral> timotei: let me know how the grammar goes — I'm working on one for a different project, using ANTLR
20100624 21:33:21< ancestral> I'd love to see what you have if/when you make progress :)
20100624 21:33:24< boucman> in find_visitor class, you have a found_ member
20100624 21:33:42< boucman> it's synonimous to !search_result_.empty() 
20100624 21:34:05< boucman> so you could remove that member
20100624 21:34:19-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100624 21:35:51-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20100624 21:36:57< gabba> boucman: true, and it's so obvious when re-reading the code :)
20100624 21:37:49< boucman> I love the way you have actions reporting if they should be removed on execute or not... the idea of still keeping half of the planned action when an ennemy unit is spotted is just great
20100624 21:37:55< timotei> ancestral: timotei well, I don't write directly antlr grammar :P
20100624 21:38:09< ancestral> Oh that's fine
20100624 21:38:10< timotei> ancestral: I'm using "xtext", a java language framework for DSL,
20100624 21:38:21< ancestral> Does it produce CFG-like grammar?
20100624 21:38:24< timotei> but yes, you can use xtext to generate the .g file for antlr grammar
20100624 21:38:30< timotei> LL afair
20100624 21:38:36< timotei> http://www.eclipse.org/Xtext/
20100624 21:38:47-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100624 21:39:11< boucman> gabba: in move::~move, you destroy the fake unit and invalidate its location, but do nothing about the arrow itself, I guess arrows are smart about removing themselves on destruction, but I wanted to make sure with you
20100624 21:39:11< gabba> boucman: thanks! I hope it's gonna plug in well into the whole action validation thing (I think it should)
20100624 21:41:20< gabba> You made me spot redundant code in there: remove_temporary_unit calls invalidate. As far as deleting proper, both the fake unit and arrow use shared pointers, so no problem there.
20100624 21:41:45< boucman> k, good
20100624 21:41:45< timotei> ancestral: there is currently some *very basic* grammar for WML in the repo 
20100624 21:42:45< boucman> in manager::~manager, you don't do anything on the stack... this is probably not an issue, but shouldn't you at least make sure that the actions are not applied on the unit map ?
20100624 21:44:35< gabba> let me see... yeah, the mapbuilder_ that holds the stack is a scoped_ptr, so it auto-deletes
20100624 21:45:50< boucman> manager::during_move_creation : this should probably be inlined and avoid declaring intermediate variable, just return <the test>
20100624 21:46:29< boucman> other question, what's the point of that function ? is it used somewhere ?
20100624 21:47:45< gabba> yup, mouse_event.cpp:465 and 533
20100624 21:48:07-!- stikonas_ is now known as stikonas
20100624 21:48:16< gabba> inlining it sounds fine, I can always bring it back to the .cpp if it becomes more complex
20100624 21:48:20< boucman> ok, and what is it for ? isn't move creation atomic as far as display is concerned ? 
20100624 21:48:36< gabba> but I think the compiler should optimize intermediate variables anyways, isn't it?
20100624 21:48:48< gabba> sometimes for debugging ease I separate things like that
20100624 21:49:45< boucman> yes, it's more a question of style, intermediate variables can help clear complicated conditions, but here it's not the case,
20100624 21:50:25< boucman> and return <condition> is easier for the reader as "we are just testing stuff, not doing anything" or "this is a shortcut for some complicated condition"
20100624 21:50:45< boucman> it's almost like a get/set... making it one line makes it more explicit
20100624 21:50:52< gabba> ^^The function means "there's a unit selected and a temp arrow visible, create a move now instead of using the regular mouse handler code"
20100624 21:50:59< gabba> ok
20100624 21:53:10< boucman> m'kay...
20100624 21:53:32< boucman> actually, that's a great intro to my next remark :)
20100624 21:53:48< boucman> overall I don't like the way you name your functions in manager.hpp
20100624 21:54:23< gabba> he he
20100624 21:54:24< boucman> you have many case of the common mistake in naming functions : naming them on their use instead of what they do...
20100624 21:55:13< gabba> probably because I added them as needed... planning an API for this was pretty impossible
20100624 21:55:14< boucman> in CS courses, you are taught to think "black box" when designing, that is : a module should be thought of as a black box when designing its interfaces...
20100624 21:55:35< gabba> but, I can of course rename them
20100624 21:56:04-!- Bob_The_Mighty [~chatzilla@cpc8-brig15-2-0-cust40.know.cable.virginmedia.com] has joined #wesnoth-dev
20100624 21:56:21< boucman> well, the "black box" concept should apply to naming functions : a function name should explain what it is in the context of the module it's part of, i.e independently of any likely usage...
20100624 21:56:44< boucman> so, let's look at your functions, (top to bottom in the hpp)
20100624 21:57:20< gabba> yes, suggestions are needed
20100624 21:57:47< boucman> active() and set_active() are fine (some people prefer is_active() instead of active, in some critical software there is even a requirement that functions which return bool and have no side effects be named either is_* or has_*
20100624 21:58:42< boucman> push and pop are "reserved words" that means "this is a stack like data structure" to any programmer
20100624 21:59:29< boucman> however, the manager is not a stack like structure (even if it contains such a structure internally) it's actually more "switch like" structure
20100624 21:59:44< gabba> in this case (I might simplify it actually), there's a stack aspect: if you "push" modifiers twice, they won't be removed until you "pop" them twice
20100624 22:00:02< boucman> gabba: is there ? 
20100624 22:00:29< boucman> I'm not sure what the point, though...
20100624 22:00:58< gabba> you might have noticed I made a whole lot of functions dealing with temp modifiers, including two structs at the end of the .hpp;
20100624 22:01:16< boucman> how about set_planned_unit_map, set_real_unit_map and is_unit_map_planned
20100624 22:02:02< boucman> yes, but these could "self stack" i.e remember if the planned or real unit map is active before doing their job and restoring to the previous state on destruction... 
20100624 22:02:20< boucman> no need for an explicit stack in the manager in that case (unless there are other reasons to do so
20100624 22:02:43< gabba> that's because I kept running in annoying cases, such as enabling the modifiers, but the the code called a function that needed to apply/remove them as well, and so ended up "snatching them away" from the rest of the calling function
20100624 22:03:12< gabba> s/the the/then the
20100624 22:03:44< boucman> actually the scoped modifiers are a gread idea... I think they should be stack-only (there is a boost::something for that, isn't there?)
20100624 22:04:07< gabba> in the end the stack-like functionality and the counter is unused since I found other ways to deal with that
20100624 22:04:15< boucman> but I don't think storing the stack in the manager is the best way to do it... storing the stack on the stack is better (if you see what I mean)
20100624 22:04:39< boucman> gabba: ok, in that case we could just remove it and keep that in mind if/when needed
20100624 22:04:48< gabba> all I use now is push_temp_modifiers, pop_temp_modifiers, and the scoped_modifiers struct.
20100624 22:05:19< gabba> Those names you suggested are great btw^^
20100624 22:05:19< boucman> well, they still need renaming, then :P
20100624 22:05:29< gabba> yup
20100624 22:06:22< gabba> what the boost::something for stack-only you mentioned? Something enforcing that an object can't be created on the heap?
20100624 22:06:26-!- ancestral [~ancestral@12.145.225.25] has quit [Quit: ancestral]
20100624 22:06:33< boucman> ok, while we're around, you should rename the scoped_modifier to contain unit_map somehow... so someone that reads UI code but isn't a whiteboard expert has a good idea of what's hapenning
20100624 22:07:04< boucman> gabba: yes, I'm not sure it exists, but if it does it would be great for scoped resources
20100624 22:08:08< gabba> scoped_unit_map_modifiers ? It's annoyingly too long, but if we want to have both scoped and unit_map in there...
20100624 22:09:29< boucman> scoped_planned_unit_map
20100624 22:10:03< boucman> and scoped_real_unit_map
20100624 22:11:21< gabba> ok, sounds fine
20100624 22:12:24< boucman> I guess clear_temp_modifiers will disapear now, if we remove the stack structure...
20100624 22:12:55< gabba> exact
20100624 22:13:04< boucman> ok
20100624 22:13:12< boucman> what's ignore_mouse_movement... 
20100624 22:15:07< gabba> it's a bool used to block the whole mouse_motion and left_click methods in mouse_events.cpp
20100624 22:16:15< boucman> gabba: i'm a bit suprised... it's usefull because you move a unit save_temp_move
20100624 22:16:42< boucman> no, you don't...
20100624 22:16:48< gabba> eh what?
20100624 22:17:11< boucman> why exactly is it used for... it's only set to true within save_temp_move, but I don't see why...
20100624 22:18:14< gabba> the whole problem is that while I call the unit's move animation, the UI regains control and the user can select stuff, which calls the UI code, which calls my code again while I'm in the middle of things...
20100624 22:18:37< gabba> there's a variable attack_move_ in the mouse UI code that serves a similar purpose.
20100624 22:19:05-!- ancestral [~ancestral@mobile-166-137-140-008.mycingular.net] has joined #wesnoth-dev
20100624 22:19:39-!- Ken_Oh [~briang@static-71-178-174-220.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
20100624 22:23:45< boucman> mkay...
20100624 22:24:44< boucman> gabba: if you look at unit_display.cpp, we call some code to disable part of the UI (like recruiting) during move animations, there might be a bettter way to plug-in through that mean...
20100624 22:25:36< gabba> around which line?
20100624 22:26:52< boucman> ok, it's not there, it must be around the callers of move_unit
20100624 22:27:03< gabba> Oh, this reminds me: your disabled_ghosted animation doesn't seem to work
20100624 22:27:15< boucman> k, looking...
20100624 22:29:13< boucman> I can't see anything wrong at first sight...
20100624 22:30:35< gabba> boucman: the best way to test it is to put it at manager.cpp line 246, instead of set_ghosted
20100624 22:31:03< boucman> k
20100624 22:31:12< gabba> that's where I wanted to use it, but units just looked... normal
20100624 22:32:07< boucman> ok, let's finish with this i'll look at it after
20100624 22:32:42< boucman> I don't like the ignore_mouse_motion, nor the way you block UI events, but I have no better proposal ATM
20100624 22:34:15< boucman> gabba: mouseover_hex, select_unit and deselect_unit are logically callbacks... you might want to rename them on_mouseover_changed, on_unit_select and on_unit_deselect
20100624 22:35:12< gabba> ^ I think I saw a disable_controls method somewhere or something similar... search yields nothing though
20100624 22:35:22< gabba> ok, those names sound fine as well
20100624 22:36:52-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20100624 22:37:04< boucman> gabba: during_move_creation() is a weird name too... bool has_selected_unit would make more sense
20100624 22:37:33< gabba> he he, I named it exactly that before and didn't like it for some reason
20100624 22:38:20< boucman> gabba: has_action would be a proper name if it returned a bool, but here it should be renamed get_first_action
20100624 22:39:10-!- timotei [~timo@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20100624 22:42:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: restarting X.org]
20100624 22:44:24< boucman> gabba: you ok with all that ?
20100624 22:44:55< gabba> yes, those names are a definite improvement
20100624 22:45:20 * gabba is spamming alt+shift+r in Eclipse
20100624 22:45:22< boucman> ok, my next question is about the highlight visitor
20100624 22:45:41< boucman> IIUC this visitor will highlight all actions... what's the point ?
20100624 22:46:14-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20100624 22:46:43< boucman> IOW when do you highlight ALL actions ?
20100624 22:46:58-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-174.telecom.by] has quit [Remote host closed the connection]
20100624 22:48:41< CIA-87> boucman * r43698 /trunk/src/unit_animation.cpp: attemp at fixing ghosted anims
20100624 22:48:45< gabba> manager::highlight_hex --> I use a condition before applying the visitor
20100624 22:50:13< boucman> mkay...
20100624 22:50:26< gabba> The visitor could be replaced by an action::highlight virtual method, btw, but preferably only if highlighting makes sense for all kinds of planned moves
20100624 22:51:18< boucman> it could also be implemented around the find visitor (maybe expanded to have a find_all_at and find_first_at to find actions related to a given hex instead of unit)
20100624 22:51:34< boucman> but ok, that's just another way of doing it, not something I don't like
20100624 22:51:49< gabba> ^I think you ask this because the find_visitor does the loop itself... I don't know of a clear rule in this case, so I'll keep experimenting until a usage pattern emerges
20100624 22:53:03< boucman> k, I think personally it makes more sense to have the loop in visitors, to minimize the work that the manager has wrt visitors and make visitors more self-contained and easier to read/write
20100624 22:53:26-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20100624 22:53:31< boucman> the visitor parent class could even provide a generic "all actions" loop that could be used as is by most of the childs
20100624 22:54:09< gabba> Sounds good, I'll favor the self-contained approach whenever possible then
20100624 22:54:23< boucman> gabba: btw, I'm not sure I saw what you saw with ghosted anims, so I have attempted a fix that is most likely correct, but I'd be gratefull if youtested it
20100624 22:55:08< gabba> ah right, I hadn't seen the CIA-87 notice above
20100624 22:55:15< gabba> I'll test it soonish
20100624 22:58:09< gabba> phone, afk for minute
20100624 23:04:15< gabba> back
20100624 23:05:28-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving]
20100624 23:20:35< gabba> boucman: I'll have to do another test since my handling of which ghosted unit goes where is still messed up, but it seems to me that disabled_ghosted units are less transparent than regular ghosted ones.
20100624 23:21:01< boucman> less transparent ? not more ?
20100624 23:25:05< boucman> anything else to discuss ?
20100624 23:26:01< gabba> yes, less transparent (and they should be more from what we discussed), but as I said I'll test again to make sure I'm not mixing them up
20100624 23:27:11< gabba> well, there's that flicker at the real unit's location when moving the temp arrow around and defining planned moves, so I was wondering if you could help diagnose that.
20100624 23:29:40-!- Gallaecio [~Gallaecio@232.158.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100624 23:31:34-!- billynux [~billy@wesnoth/developer/billynux] has joined #wesnoth-dev
20100624 23:33:51-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds]
20100624 23:34:18< CIA-87> boucman * r43699 /trunk/data/core/terrain-graphics.cfg: fix an error in desert castle spotted by alarantalara
20100624 23:35:45-!- ancestral [~ancestral@mobile-166-137-140-008.mycingular.net] has quit [Remote host closed the connection]
20100624 23:37:09< gabba> boucman: ok, this is officially confusing. I did a different test (use disabled_ghosted fake unit at the tip of the temp arrow), and the unit is indeed very transparent, probably too much actually (it's barely visible, if you know to look for it)
20100624 23:37:44< boucman> yes, 0.2 might be a little too much
20100624 23:37:46< gabba> boucman: but the weird thing is, I seem to get different results or levels of transparency depending on where I call the animation from... huh?
20100624 23:37:55< boucman> huh ?
20100624 23:38:08< gabba> huh
20100624 23:38:25< gabba> can't express it better :P
20100624 23:38:36< boucman> it's a bit late to investigate tonight, some other things can change the visibility of a unit (like the unit being invisible)
20100624 23:38:44< boucman> i'll have to look tomorow
20100624 23:39:47< gabba> ok, I'll play around and see what I might be doing wrong, but the best is if you test, and see if you understand better than me the various weird graphical happenings
20100624 23:40:07< gabba> I look forward to your tomorrow's testing
20100624 23:40:22< boucman> gabba: if it's too much trouble, just forget them for the moment, focusing on the rest, i'll have a look later
20100624 23:42:35-!- ancestral [~ancestral@mobile-166-137-140-008.mycingular.net] has joined #wesnoth-dev
20100624 23:47:41< CIA-87> gabba * r43700 /trunk/src/whiteboard/ (find_visitor.cpp find_visitor.hpp): Whiteboard: simplified find_visitor
20100624 23:47:44< CIA-87> gabba * r43701 /trunk/src/whiteboard/move.cpp: Whiteboard: cleaned up move class destructor
20100624 23:47:51< CIA-87> gabba * r43702 /trunk/src/whiteboard/ (manager.cpp manager.hpp): Whiteboard: Inlined a method
20100624 23:47:59< CIA-87> gabba * r43703 /trunk/src/ (4 files in 2 dirs): Whiteboard: s/active()/is_active()
20100624 23:48:04-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20100624 23:48:07< CIA-87> gabba * r43704 /trunk/src/ (3 files in 2 dirs): Whiteboard: renamed methods in the manager
20100624 23:48:12< CIA-87> gabba * r43705 /trunk/src/ (3 files in 2 dirs): Whiteboard: renamed methods in the manager
20100624 23:48:18< CIA-87> gabba * r43706 /trunk/src/whiteboard/manager.cpp: Whiteboard: simplified create_temp_move method; use set_disabled_ghosted on intermediary waypoints
20100624 23:48:25< CIA-87> gabba * r43707 /trunk/src/whiteboard/manager.cpp: Whiteboard: cleanup
20100624 23:49:02-!- _jbx_ [~jbailey@12.190.80.225] has quit [Quit: Dig that hole, forget the sun.]
20100624 23:49:51< boucman> gabba: if you want to tweak ghosted animation, search for "ghost" in unit_animation.cpp, the transparency value is the 0.5/0.2
20100624 23:50:32< boucman> set it to whatever feels good to you. I'll probably "desaturate" them too at some point to have them look like the stoned units... it will be less intrusive
20100624 23:50:48< gabba> ok, thanks boucman
20100624 23:52:30< boucman> ok, sleep time here, see you all tomorow
20100624 23:52:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20100624 23:54:21-!- ancestral [~ancestral@mobile-166-137-140-008.mycingular.net] has quit [Quit: Colloquy for iPhone - http://colloquy.mobi]
--- Log closed Fri Jun 25 00:00:24 2010