--- Log opened Sat Jul 31 03:00:16 2010 20100731 03:00:24-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20100731 03:00:24-!- Topic for #wesnoth-dev: Wesnoth.org down | Alt. logs: http://wesnoth.debian.net | 132 bugs, 283 feature requests, 13 patches | Wesnoth Licensing Meeting at 16:00 GMT on Sunday August 1st | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100731 03:00:24-!- Topic set by shadowmaster [~ignacio@wesnoth/developer/shadowmaster] [Sat Jul 31 00:14:08 2010] 20100731 03:00:24[Users #wesnoth-dev] 20100731 03:00:24[ ABCD ] [ CIA-87 ] [ Gambit ] [ noy ] 20100731 03:00:24[ Aethaeryn ] [ Daltx` ] [ grzywacz ] [ Rhonda ] 20100731 03:00:24[ AI0867 ] [ DigitalSeraphim ] [ happygrue_ ] [ shadowm_laptop] 20100731 03:00:24[ alink ] [ eleazar__ ] [ Ingmar ] [ shadowmaster ] 20100731 03:00:24[ AnMaster ] [ elias ] [ isaac ] [ shikadibot ] 20100731 03:00:24[ apoi ] [ Elvish_Pillage2 ] [ Ivanovic ] [ Sirp ] 20100731 03:00:24[ Appleman1234] [ elvish_sovereign] [ iwaim ] [ Smar ] 20100731 03:00:24[ astraljava ] [ erl ] [ Ke ] [ Tigge ] 20100731 03:00:24[ Blarumyrran ] [ Espreon ] [ knotwork ] [ Vetinari ] 20100731 03:00:24[ Blueblaze ] [ esr ] [ koan ] [ wesbot ] 20100731 03:00:24[ Bocom ] [ ettin ] [ lobby ] [ yann ] 20100731 03:00:24[ Carneus ] [ fendrin ] [ Mythological] 20100731 03:00:24[ chris| ] [ gabba ] [ nguyenatto ] 20100731 03:00:24-!- Irssi: #wesnoth-dev: Total of 50 nicks [0 ops, 0 halfops, 0 voices, 50 normal] 20100731 03:00:41-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20100731 03:00:50-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev 20100731 03:01:50-!- Irssi: Join to #wesnoth-dev was synced in 94 secs 20100731 03:02:19< alink> gabba: ah i see that you already introduced a "master_boolean" in current_unit_attacks_from ;) 20100731 03:03:22< alink> note that '&=' doesn't do short-circuit evaluation 20100731 03:04:48< alink> btw select_hex already do what I suggested about moving code into function 20100731 03:05:36< alink> this also solve the clicked_u iterator problem, there is a planned_unit_map for the whole function 20100731 03:08:00< alink> but it's maybe a bit more complicated than that. I need to check more the wb details 20100731 03:08:09< alink> but not now, bye 20100731 03:08:11-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection] 20100731 03:10:38-!- shadowmaster changed the topic of #wesnoth-dev to: 132 bugs, 283 feature requests, 13 patches | Wesnoth Licensing Meeting at 16:00 GMT on Sunday August 1st | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100731 03:45:37-!- ancestral [~ancestral@97-116-127-109.mpls.qwest.net] has joined #wesnoth-dev 20100731 04:20:28-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Remote host closed the connection] 20100731 04:20:47-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20100731 04:24:50< CIA-87> espreon * r44951 /trunk/src/whiteboard/ (recruit.cpp recruit.hpp): Ran umcpropfix. 20100731 04:24:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 276 seconds] 20100731 04:26:23-!- ancestral [~ancestral@97-116-127-109.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.] 20100731 04:26:52-!- Ivanovic_ is now known as Ivanovic 20100731 04:35:29-!- ancestral [~ancestral@97-116-105-67.mpls.qwest.net] has joined #wesnoth-dev 20100731 04:37:55-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 276 seconds] 20100731 04:39:25-!- Simons [524536cf@gateway/web/freenode/ip.82.69.54.207] has joined #wesnoth-dev 20100731 04:40:00< CIA-87> espreon * r44952 /trunk/projectfiles/VC9/liblua.vcproj: Assigned svn:eol-style to a file. 20100731 04:42:50< Simons> 'Ere, my ' Mith' has fallen off. 20100731 04:44:46< Simons> I posted a diff in the Wesnoth writers forum, with corrections and clarifications for advanced_preferences.cfg and game_preferences_display.cpp 20100731 04:47:03< Simons> Problem: Which is the best forum for discussion; Writers Forum, Coders' Corner, here 20100731 04:48:50< Appleman1234> generally if it involves .cpp , it is coders' corner 20100731 04:49:53-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection] 20100731 04:51:16< Simons> [Apple] Thx. I may cross-post there. Internal UI text strines are a funny halfway house, mixed between .cfgs and .cpps, as I've discovered. 20100731 04:51:30< Simons> *strings* 20100731 05:16:06-!- Mythological [Mythologic@77.29.94.12] has quit [] 20100731 05:36:56-!- Simons [524536cf@gateway/web/freenode/ip.82.69.54.207] has left #wesnoth-dev [] 20100731 06:04:30-!- elvish_sovereign [~elvish_so@pool-173-59-65-48.phlapa.east.verizon.net] has quit [Quit: elvish_sovereign] 20100731 06:08:31-!- dtiger [~dtiger@dynamic-vpdn-93-125-66-92.telecom.by] has joined #wesnoth-dev 20100731 06:41:56-!- Netsplit *.net <-> *.split quits: shikadibot, erl, Ingmar, isaac, Ke, koan, Vetinari, Carneus 20100731 06:41:56-!- koan_ [~koan@unaffiliated/koan] has joined #wesnoth-dev 20100731 06:43:47-!- Netsplit over, joins: shikadibot 20100731 06:44:45-!- Netsplit over, joins: Vetinari 20100731 06:44:45-!- isaac [~isaac@heal.cauterized.net] has joined #wesnoth-dev 20100731 06:44:46-!- isaac [~isaac@heal.cauterized.net] has quit [Changing host] 20100731 06:44:46-!- isaac [~isaac@debian/developer/isaac] has joined #wesnoth-dev 20100731 06:45:08-!- Ke [~jkarlson@gateway/shell/tkk.fi/x-ptluzofszepbbluj] has joined #wesnoth-dev 20100731 06:45:08-!- Ke [~jkarlson@gateway/shell/tkk.fi/x-ptluzofszepbbluj] has quit [Changing host] 20100731 06:45:08-!- Ke [~jkarlson@pdpc/supporter/active/ke] has joined #wesnoth-dev 20100731 06:47:36-!- Ingmar [ingmar@exherbo/developer/ingmar] has joined #wesnoth-dev 20100731 06:48:13-!- Carneus [~Carneus@carneus.tontut.fi] has joined #wesnoth-dev 20100731 06:54:03-!- erl [~erl@vetinte.spelaroll.se] has joined #wesnoth-dev 20100731 06:59:39-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds] 20100731 07:12:26< CIA-87> gabba * r44953 /trunk/src/whiteboard/recruit.cpp: Whiteboard: don't generate random traits for planned recruit. 20100731 07:12:33< CIA-87> gabba * r44954 /trunk/src/whiteboard/manager.cpp: Whiteboard: logging changes. 20100731 07:12:39< CIA-87> gabba * r44955 /trunk/src/mouse_events.cpp: Whiteboard: new boolean to make code a bit less verbose. 20100731 07:40:50-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20100731 07:45:54-!- EdB [~edb@4.103.89-79.rev.gaoland.net] has joined #wesnoth-dev 20100731 07:46:52-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100731 07:47:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100731 07:52:51-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20100731 08:13:14 * shadowmaster scratches head 20100731 08:13:56< shadowmaster> long cp command line is loooong. 20100731 08:14:14< shadowmaster> no wonder the site gets stuck during the backup cronjob 20100731 08:17:06-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...] 20100731 08:23:10-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20100731 08:23:22< mordante> servus 20100731 08:25:39-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20100731 08:27:57-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100731 08:28:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100731 08:31:48< mordante> gabba I don't think multiple returns are bad per se, I love them to do validation and bail out 20100731 08:31:58< mordante> the alternative would be a deeply nested if 20100731 08:32:13< mordante> (if fact I even use goto's for that :-) ) 20100731 08:32:44< shadowmaster> mordante: this might be relevant: http://xkcd.com/292/ 20100731 08:33:09< mordante> shadowmaster, :-) 20100731 08:34:28< mordante> last week I used about 6 of them... /me waits for a small herd of velociraptors 20100731 08:40:51-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev 20100731 08:41:04-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20100731 08:42:15< alink> mordante: do you run your trailing space remover on WML ? 20100731 08:42:34< mordante> alink, no only on the source code 20100731 08:42:42< mordante> you want me to run it on WML? 20100731 08:44:36< alink> maybe, now that my IDE auto remove them, it touches a lot of lines when I modify a cfg file 20100731 08:44:56< alink> unless trailing space can have a meaning in WML? 20100731 08:45:15< Crab_> alink: strings that span multiple lines ? 20100731 08:45:43< alink> Crab_: hmmm, good point 20100731 08:45:54< alink> but that's true in c++ too 20100731 08:46:27< Crab_> there's a lot less strings in c++, and even less multi-line strings 20100731 08:46:28< mordante> Crab_, I'll first test in small steps and look at the diffs before committing 20100731 08:46:49< Crab_> mordante: you can do it in one big step and check how translation list changed 20100731 08:47:08< Crab_> mordante: if done right, then you'll immediately see if there were changes in translateable strings 20100731 08:47:10< mordante> and to be honest I hate trailing spaces in long wml texts, better leading once, they are visible 20100731 08:47:32< mordante> Crab_, not really there hasn't been a pot-update for ages 20100731 08:48:25< mordante> of course I can do it locally branch commit, test stripping back to master commit dcommit 20100731 08:48:54< Crab_> yes, it should be possible to do locally\ 20100731 08:49:41< alink> note that I noticed them in terrain_graphics files (which is a weird case), perhaps there is less of them in normal WML files 20100731 08:49:50< mordante> I'll first look locally how the cfgs are stripped and then go the pot way, good tip Crab_ :- 20100731 08:49:53< mordante> :-) 20100731 08:52:21< CIA-87> alink * r44956 /trunk/src/serialization/preprocessor.cpp: 20100731 08:52:21< CIA-87> Optimize cache building (-30%). 20100731 08:52:21< CIA-87> Stop writing never read debug data. It was only output in cfg.plain (produced by --preprocess) where it filled 3/4 of the file with useless spam. 20100731 08:52:30< CIA-87> alink * r44957 /trunk/src/serialization/preprocessor.cpp: Also uncompress macro filenames debug info in some logging functions 20100731 08:52:34< CIA-87> alink * r44958 /trunk/src/serialization/preprocessor.cpp: 20100731 08:52:34< CIA-87> No need anymore to disable filename compression for --preprocess. 20100731 08:52:34< CIA-87> (cfg.plain doesn't output these filenames) 20100731 08:52:35< CIA-87> alink * r44959 /trunk/src/serialization/preprocessor.cpp: Small protection against unexpected case. 20100731 08:53:06< mordante> alink, if fails horribly data/gui/default/macros/_initial.cfg around line 160 ;-) 20100731 08:53:16< mordante> other then that it looks good 20100731 08:54:01< alink> fails horribly ? 20100731 08:55:14< mordante> just look at the source 20100731 08:55:15< alink> # Note Foo has trailing spaces to force extra width. 20100731 08:55:19< alink> indeed 20100731 08:57:06-!- EdB [~edb@4.103.89-79.rev.gaoland.net] has quit [Remote host closed the connection] 20100731 09:07:42< gabba> mordante, alink: two questions about logging: 1/ what does the logdomain() macro do, exactly? 2/ does the logging system have a way of automatically displaying the file + line number the trace comes from? (I know about __LINE__ and BOOST_STRINGIZE() already, but I don't want to reinvent the wheel) 20100731 09:09:30< mordante> the logging system has no file + line number info, I normally use a LOG_HEADER macro for that 20100731 09:11:37< CIA-87> mordante * r44960 /trunk/CMakeLists.txt: Update status 20100731 09:11:45< CIA-87> mordante * r44961 /trunk/data/gui/ (52 files in 4 dirs): Strip trailing spaces 20100731 09:12:14< alink> mordante: thanks 20100731 09:12:27< alink> gabba: logdomain() macro ? 20100731 09:13:06< mordante> I just wanted to ask about logdomain as well... 20100731 09:13:08< silene> alink: are you sure about r44956? restoring the location at the end of a preprocessor should be used whenever a file or a macro has been included 20100731 09:13:11< alink> there is a #define LOG_STREAM(a, b) if (lg::a.dont_log(b)) ; else lg::a(b) I suppose you may add variant for your needs 20100731 09:13:21< alink> silene: looking 20100731 09:13:24< mordante> now only if the potupdate would run... 20100731 09:14:37< alink> silene: i believe it's done directly using location_, not by parsing \376line stuff 20100731 09:14:49< gabba> alink, mordante: sorry, I meant log_scope() 20100731 09:14:58< alink> silene: and nobody parse \376line stuff 20100731 09:15:17< silene> alink: tokenizer.cpp does; that's where all the debug informations come from! 20100731 09:17:29< alink> silene: mmh indeed, I missed that one because of the skip_comment name :-/ . I check more 20100731 09:17:30< mordante> gabba, log_scope indents the logging for a scope 20100731 09:17:50< mordante> I use that a lot in the layout functions of the gui 20100731 09:17:58< silene> alink: technically, you just completely removed error messages from wml parsing 20100731 09:18:45< gabba> mordante: thanks 20100731 09:18:54< alink> silene they still worked in my few tests 20100731 09:19:12< silene> alink: are you sure you didn't test preprocessor errors only? 20100731 09:19:28< alink> silene: but now that I see that it's really parsed I will test more 20100731 09:19:42< alink> silene mmh good point 20100731 09:21:45< alink> silene: indeed, some errors are now incorrectly reported :-/ 20100731 09:22:25< alink> I will revert that change then 20100731 09:23:01< alink> silene: thanks for the checking 20100731 09:24:13< alink> wait, skip_comment() only use the linenumber, not the filenames 20100731 09:25:58< silene> alink: it does use the filename too; where do you think the filenames in the error messages come from otherwise? 20100731 09:26:48< silene> dst = &file_; *dst += current_; 20100731 09:27:41< alink> ok 20100731 09:28:51< CIA-87> mordante * r44962 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (5 files): Empty string shall not be marked as translatable. 20100731 09:28:58 * mordante puts on the translation maintainers hat and looks at fendrin^ 20100731 09:31:15-!- silene [~plouf@wesnoth/developer/silene] has quit [Disconnected by services] 20100731 09:31:15-!- silene1 [~plouf@AMarseille-553-1-293-140.w92-153.abo.wanadoo.fr] has joined #wesnoth-dev 20100731 09:31:17-!- silene1 is now known as silene 20100731 09:31:18-!- silene [~plouf@AMarseille-553-1-293-140.w92-153.abo.wanadoo.fr] has quit [Changing host] 20100731 09:31:18-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20100731 09:35:32-!- Upth [~ogmar@69.62.144.108] has joined #wesnoth-dev 20100731 09:35:32-!- Upth is now known as Upthorn 20100731 09:37:32< mordante> silene, just curious I noticed you added an uninlined default destructor for config::attribute_value, how much does it help? 20100731 09:38:43< silene> mordante: i don't remember (wasn't it written in the commit message?), but it helped quite a bit, since boost::variant is a huge class 20100731 09:40:23-!- Unnheulu [~ieuan@cpc5-pnth2-0-0-cust800.5-2.cable.virginmedia.com] has joined #wesnoth-dev 20100731 09:42:27< CIA-87> alink * r44963 /trunk/src/serialization/preprocessor.cpp: 20100731 09:42:27< CIA-87> Revert r44956 (and r44958 which relied on it), 20100731 09:42:28< CIA-87> because it breaks debug info of some error messages 20100731 09:42:34< mordante> silene, "Reduced compilation time and binary size by uninlining heavy members (-13% on amd64 at -O1)." I assume the 13% is the size 20100731 09:42:37< alink> silene: reverted^ 20100731 09:42:51< silene> mordante: yes, it is 20100731 09:42:58< Ivanovic> moin 20100731 09:43:02< mordante> hi Ivanovic 20100731 09:43:32< mordante> silene, ok thanks 20100731 09:44:33-!- koan_ is now known as koan 20100731 09:49:19< silene> alink: thanks; the thing to do, if you really want to speed up start times, is to merge the preprocessor and the parser so that they share data: no need to tokenize twice, no need to embed debug informations, and so on 20100731 09:50:53< alink> silene: yes that not-sharing-data seems to be a waste. But such change seems to be a lot of work 20100731 09:51:59< alink> I also started simple code to skip debug info the first time, and when catching an error, reparse with debug info on to display the error message 20100731 09:53:19< alink> I think it worked, but I stopped testing it when I incorrectly thought that I could simply remove the #line stuff 20100731 09:54:38< alink> but the merge will probably help more 20100731 09:55:41< alink> unfortunately that's much beyond my level of understanding of that area :-/ 20100731 09:57:30< Upthorn> hrm. there's a 6 hour gap in the logs 20100731 09:58:54< mordante> Upthorn, around what time? 20100731 09:59:15< alink> http://wesnoth.debian.net/%23wesnoth-dev-2010-07-31.log 20100731 09:59:43< mordante> alink, great minds think alike ;-) 20100731 10:00:28< mordante> still would be interesting to know why the other logs failed 20100731 10:00:30< alink> well dumb minds too, but let's be optimistic about ourself :-p 20100731 10:01:31< alink> wesnoth.org was down 20100731 10:01:45< mordante> of course, never said I was a great mind ;-) 20100731 10:01:55< Upthorn> mordante: from 20100730 21:20:47 to 20100731 03:00:24 20100731 10:02:04< alink> http://collectd.wesnoth.org/ 20100731 10:02:11< mordante> ah ok 20100731 10:03:00< alink> there was a big IO just before the gap 20100731 10:04:31< Upthorn> man, those charts are weird to look at 20100731 10:04:50< Upthorn> with the 5 hour 40 minute gap 20100731 10:04:56< Upthorn> in all of them 20100731 10:05:41< CIA-87> mordante * r44965 /trunk/data/core/units/saurians/ (5 files): 20100731 10:05:41< CIA-87> Strip trailing spaces. 20100731 10:05:41< CIA-87> Using Crab_'s idea to use pot updates to test whether translations are 20100731 10:05:41< CIA-87> affected. 20100731 10:05:41< CIA-87> mordante * r44964 /trunk/data/campaigns/ (12 files in 3 dirs): 20100731 10:05:42< CIA-87> Strip trailing spaces. 20100731 10:05:42< CIA-87> Using Crab_'s idea to use pot updates to test whether translations are 20100731 10:05:43< CIA-87> affected. 20100731 10:05:44< CIA-87> mordante * r44966 /trunk/data/core/macros/ (carryover-utils.cfg scenario-utils.cfg): Strip trailing whitespace. 20100731 10:05:44< CIA-87> mordante * r44967 /trunk/data/core/terrain-graphics/ (internal-tracks.cfg tracks.cfg): Strip trailing whitespace 20100731 10:06:25< Ivanovic> Upthorn: the gap means that wesnoth.org simply was down 20100731 10:06:40< Ivanovic> Upthorn: for irclogs: the ones Rhonda makes at wesnoth.debian.net should work 20100731 10:06:57< Upthorn> I know but I mean that reading them is made visually awkward by the blank space 20100731 10:07:01< Ivanovic> (you know, different server and all the likes) 20100731 10:07:10< mordante> Crab_, the pot-update worked perfectly, one string change was caught which needs to be moved to the translation fixes later 20100731 10:07:21< Crab_> great 20100731 10:07:23< Upthorn> and I did look through the logs on wesnoth.debian when mordante linked them 20100731 10:07:26< alink> http://collectd.wesnoth.org/index.cgi?hostname=wesnoth.wesnoth.org&plugin=df×pan=31622400&action=show_selection&ok_button=OK 20100731 10:07:34< alink> ^soon need to delete something 20100731 10:07:37< Upthorn> found that nothing relevant to me appears to have happened since my commit 20100731 10:12:35-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection] 20100731 10:15:30< CIA-87> mordante * r44968 /trunk/data/ (10 files in 5 dirs): Strip trailing spaces. 20100731 10:19:04< Ivanovic> okay, left Soliton a message in the nonpublic chan about some possible places of reducing space usage on the server 20100731 10:27:53< CIA-87> mordante * r44969 /trunk/src/network_manager_ana.cpp: Strip trailing whitespace. 20100731 10:28:17< mordante> alink ^ that concludes the stripping session 20100731 10:28:22< mordante> I'm off now 20100731 10:28:48-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20100731 10:42:49-!- maxy [~maxy@84-74-65-49.dclient.hispeed.ch] has joined #wesnoth-dev 20100731 10:59:32-!- Unnheulu [~ieuan@cpc5-pnth2-0-0-cust800.5-2.cable.virginmedia.com] has quit [Quit: Lost terminal] 20100731 11:14:06-!- ieuan [~ieuan@cpc5-pnth2-0-0-cust800.5-2.cable.virginmedia.com] has joined #wesnoth-dev 20100731 11:14:37-!- ieuan is now known as Unnheulu 20100731 11:14:37-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.] 20100731 11:26:33< CIA-87> ivanovic * r44971 /branches/1.8/po/ (6 files in 6 dirs): updated Chinese (simplified) translation 20100731 11:26:38< CIA-87> ivanovic * r44970 /trunk/po/ (6 files in 6 dirs): updated Chinese (simplified) translation 20100731 11:28:15-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20100731 11:35:37< fendrin> hello 20100731 11:36:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100731 11:55:12-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20100731 11:56:08-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20100731 12:00:33-!- ancestral [~ancestral@97-116-105-67.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20100731 12:07:36< CIA-87> upthorn * r44972 /trunk/data/scenario-test.cfg: minor modification to allow loading and running the test scenario on windows. (something about parsing that [trait] tag crashes wesnoth) 20100731 12:08:36< CIA-87> upthorn * r44973 /trunk/data/scenario-test.cfg: added a quick and dirty persistence demo to the test scenario 20100731 12:15:07< CIA-87> gabba * r44974 /trunk/src/ (mouse_events.cpp whiteboard/move.cpp): Whiteboard: moar changes to logging. 20100731 12:15:13< CIA-87> gabba * r44975 /trunk/src/ (3 files in 2 dirs): Whiteboard: ensure help message is really only printed once, and change it slightly. Don't delete all actions anymore when wb is deactivated. 20100731 12:15:20< CIA-87> gabba * r44976 /trunk/src/whiteboard/ (manager.cpp validate_visitor.cpp): Whiteboard: whitespace/comments/logging cleanup. 20100731 12:15:26< CIA-87> gabba * r44977 /trunk/src/whiteboard/ (5 files): Whiteboard: logging changes, and change a variable name. 20100731 12:15:33< CIA-87> gabba * r44978 /trunk/src/mouse_events.cpp: Removed a boolean that was used only once. 20100731 12:15:39< CIA-87> gabba * r44979 /trunk/src/ (mouse_events.cpp mouse_events.hpp): mouse_handler: split a part of move_unit_along_current_route() into new public method move_unit_along_route() 20100731 12:15:48< CIA-87> gabba * r44980 /trunk/src/whiteboard/move.cpp: Whiteboard: use new method mouse_handler::move_unit_along_route() to execute move actions. This fixes "Enemy sighted press T to continue" behavior, even though a more whiteboard-specific solution would be desirable here. 20100731 12:15:55< CIA-87> gabba * r44981 /trunk/src/mouse_events.hpp: Made get_adjacent_enemies() public in mouse_handler, for use by whiteboard. 20100731 12:16:00< CIA-87> gabba * r44982 /trunk/src/whiteboard/attack.cpp: Whiteboard: take into account the possibility of ambush on destination hex when executing a planned attack-move. 20100731 12:16:04< CIA-87> gabba * r44983 /trunk/src/mouse_events.cpp: Whiteboard: added a todo. 20100731 12:20:37-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Ping timeout: 265 seconds] 20100731 12:21:30-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev 20100731 12:23:57< gabba> Upthorn: this greeting at the start of every test scenario is a bit annoying, since I use it for quick and dirty testing. Could you please set it so it triggers only when moving a unit on a specific, labeled hex, as most tests do? 20100731 12:24:55-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20100731 12:25:16-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20100731 12:28:11-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [] 20100731 12:30:45-!- prkc [~negusnyul@145.236.180.41] has joined #wesnoth-dev 20100731 12:39:18< CIA-87> fendrin * r44984 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/Sentry.cfg: UtBS Added the Sentry unit. 20100731 12:44:01< CIA-87> upthorn * r44985 /trunk/data/scenario-test.cfg: moved persistence demo trigger to a labeled hex, instead of side 1 turn 1. 20100731 12:52:24< CIA-87> silene * r44986 /trunk/src/game_errors.hpp: Inherited from standard exception. 20100731 12:52:35< CIA-87> silene * r44987 /trunk/src/scripting/lua.cpp: Simplified code further by avoiding gotos. Added more typechecking to interface arguments. 20100731 12:52:39< CIA-87> silene * r44988 /trunk/src/ (9 files in 3 dirs): 20100731 12:52:39< CIA-87> Factored the whole exception handling. 20100731 12:52:40< CIA-87> Implemented sticky exceptions that can be rethrown at will. 20100731 12:52:40< CIA-87> Used them to ensure that quitting the game, loading a new game, and leaving to title screen, work correctly when WML is being executed. 20100731 13:00:28-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100731 13:00:49< CIA-87> fendrin * r44989 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (10 files): UtBS: Quenoth elves updated. 20100731 13:06:32-!- Mythological [Mythologic@77.28.82.231] has joined #wesnoth-dev 20100731 13:16:43-!- Blueblaze [~Blueblaze@adsl-99-4-146-0.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20100731 13:16:52-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev 20100731 13:32:20< CIA-87> fendrin * r44990 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/hunter/ (. Archer.cfg Chaser.cfg Hawker.cfg Hunter.cfg Marksman.cfg): UtBS: Moved the hunter line in a subdirectory. 20100731 13:33:10< CIA-87> fendrin * r44991 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/mystic/ (8 files): Moved the mystic line in its own subdirectory. 20100731 13:33:54< CIA-87> fendrin * r44992 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/warrior/ (. Sentinel.cfg Sentry.cfg Warrior.cfg): Moved the fighters in an own subdirectory and renamed the line to warrior. 20100731 13:58:22< CIA-87> fendrin * r44993 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (20 files in 2 dirs): UtBS: deleted obsolete files. 20100731 13:59:11< CIA-87> fendrin * r44994 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (5 files in 2 dirs): UtBS: sanddancer moved in subdirectory. 20100731 14:00:08< CIA-87> fendrin * r44995 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/mystic/Sun_Singer.cfg: UtBS: Sun Singer unit updated. 20100731 14:01:11< CIA-87> fendrin * r44996 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Singer: UtBS: Removed obsolete file. 20100731 14:19:51-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20100731 14:21:37< CIA-87> fendrin * r44997 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/warrior/ (Assailant.cfg Warrior.cfg): UtBS: updates to the warriors. 20100731 14:24:29-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20100731 14:28:42-!- Unnheulu [~ieuan@cpc5-pnth2-0-0-cust800.5-2.cable.virginmedia.com] has quit [Quit: Lost terminal] 20100731 14:50:38< CIA-87> silene * r44998 /trunk/ (4 files in 3 dirs): Added an autotool target, so that out-of-tree builds are possible again. 20100731 15:13:35-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has quit [Ping timeout: 265 seconds] 20100731 15:56:03< CIA-87> fendrin * r44999 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (6 files in 3 dirs): UtBS: Renamed Twin Fighter and Twin Master to Striker and Slayer. 20100731 15:58:53< CIA-87> fendrin * r45000 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (7 files in 2 dirs): UtBS: renamed warrior to guard. 20100731 16:00:13< CIA-87> fendrin * r45001 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/guard/ (Assailant.cfg Blade_Dancer.cfg): UtBS: Renamed Assailant to Blade Dancer. 20100731 16:05:16< CIA-87> fendrin * r45002 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/guard/ (Guard.cfg Warrior.cfg): UtBS: More unit name changes. 20100731 16:16:46-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20100731 16:28:00< CIA-87> eleazar * r45003 /trunk/data/core/ (images/terrain/off-map/symbol.png terrain.cfg): improved appearance of off-map in minimap. 20100731 16:54:49< CIA-87> fendrin * r45004 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/guard/ (6 files): UtBS: Worked on the Guard line. 20100731 16:56:35< CIA-87> fendrin * r45005 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/hunter/ (Archer.cfg Harrier.cfg Hawker.cfg Hunter.cfg Marksman.cfg): 20100731 16:56:35< CIA-87> UtBS: 20100731 16:56:35< CIA-87> Work on the hunter line. 20100731 16:56:35< CIA-87> Renamed the Hawker to Harrier. 20100731 16:57:49-!- boucman [50d6fd0d@wesnoth/developer/boucman] has joined #wesnoth-dev 20100731 17:01:29< CIA-87> eleazar * r45006 /trunk/data/core/images/terrain/water/ (8 files): more visible temporary ford. 20100731 17:10:55< anonymissimus> silene: can't reproduce the click-on-cross crash in 1.9 now 20100731 17:17:14-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20100731 17:18:28< CIA-87> eleazar * r45007 /trunk/data/core/images/terrain/walls/ (51 files): moved up the baseline of the wall terrains, which previously stuck too far south. Eventually i'll make it stick up north less too, but that will probable be part of a bigger overhaul. 20100731 17:26:22-!- prkc [~negusnyul@145.236.180.41] has quit [Remote host closed the connection] 20100731 17:31:09< anonymissimus> are the lua dlls still needed by trunk now ? 20100731 17:35:51< Upthorn> I don't think so, but I haven't tried removing them 20100731 17:48:23-!- happygrue_ is now known as happygrue 20100731 17:49:26-!- Gambit [~quassel@pa-67-234-73-7.dhcp.embarqhsd.net] has quit [Ping timeout: 260 seconds] 20100731 17:51:44-!- boucman [50d6fd0d@wesnoth/developer/boucman] has quit [Quit: Page closed] 20100731 17:59:35< anonymissimus> it certainly looks like they're no longer needed 20100731 18:04:11< AI0867> src/tests/gui/test_gui2.cpp: In member function ‘void test_make_test_fake::test_method()’: 20100731 18:04:13< Upthorn> anonymissimus: just tested and the lua dlls are indeed no longer required by trunk. 20100731 18:04:15< AI0867> src/tests/gui/test_gui2.cpp:229: error: ‘struct twml_exception’ has no member named ‘user_message’ 20100731 18:10:31< loonycyborg> AI0867: Obviously that means that someone has broken the unit tests again :P 20100731 18:21:46-!- mjs-de [~mjs-de@p3EE2347B.dip.t-dialin.net] has joined #wesnoth-dev 20100731 18:27:14-!- eleazar__ [~eleazar@ppp-70-226-219-69.dsl.spfdil.ameritech.net] has quit [Ping timeout: 260 seconds] 20100731 18:27:58-!- elvish_sovereign [~elvish_so@pool-173-59-65-48.phlapa.east.verizon.net] has joined #wesnoth-dev 20100731 18:28:21-!- elvish_sovereign [~elvish_so@pool-173-59-65-48.phlapa.east.verizon.net] has quit [Remote host closed the connection] 20100731 18:28:26-!- elvish_sovereign [~elvish_so@pool-173-59-65-48.phlapa.east.verizon.net] has joined #wesnoth-dev 20100731 18:32:33-!- eleazar_ [~eleazar@ppp-70-226-208-182.dsl.spfdil.ameritech.net] has joined #wesnoth-dev 20100731 18:33:17< silene> AI0867, loonycyborg: sorry, it's my fault 20100731 18:33:53< silene> since they no longer work, i have stopped compiling them, it was a mistake 20100731 18:35:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100731 18:38:03< zookeeper> ehh. i wonder what's this set_no_flag= key used all over the place in terrain-graphics/... 20100731 18:38:09< silene> anonymissimus: great, so perhaps the original issue is fixed too, at least for 1.9 20100731 18:38:23< zookeeper> looks like what used to be set_flag=, but i can't see why anyone would have renamed it in such a silly manner and not documented it 20100731 18:38:39< anonymissimus> who has experience with gdb on win around here ? 20100731 18:39:09< zookeeper> s/set_flag/has_flag or no_flag 20100731 18:40:08< zookeeper> ok, found it in the svn logs... 20100731 18:40:52< loonycyborg> anonymissimus: I used it on win once :P 20100731 18:41:17< anonymissimus> with an IDE ? 20100731 18:41:39< loonycyborg> No. From MSYS 20100731 18:41:55< silene> anonymissimus: it's probably easier to use without an ide 20100731 18:42:05< anonymissimus> I'm trying it with CodeBlocks for some time already 20100731 18:44:40< silene> without an ide, just open a console and type: "gdb path\to\wesnoth.exe", then type "run --whatever-options-you-usually-use", and when it stops abruptly, type "bt" to get the backtrace 20100731 18:48:33-!- Gambit [~quassel@pa-67-234-82-198.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100731 18:49:06< anonymissimus> thats what I tried, but "no stack" 20100731 18:49:19< anonymissimus> don't I need to compile it accordingly 20100731 18:51:50< silene> anonymissimus: if it stays "no stack", it may just be that gdb assumed that it was executed correctly 20100731 18:52:06< anonymissimus> it wasn't 20100731 18:52:45< silene> what if you type "br terminate", does it complain? 20100731 18:54:34< anonymissimus> function terminate not defined in loaded symbols 20100731 18:55:00< anonymissimus> IM comiling in codeblocks with the debug configuration currently 20100731 18:55:35< silene> and "br std::terminate"? 20100731 18:57:49< CIA-87> silene * r45008 /trunk/src/ (6 files in 2 dirs): Fixed compilation of unit tests by moving symbols out of game.cpp. 20100731 18:59:05< silene> hmm... strangely enough, my gdb accepts it only if i type "br std::terminate()" 20100731 18:59:16< anonymissimus> Can't find member of namespace, class, struct, or union named "std::terminate" 20100731 19:00:04< silene> yes, you may have the same issue as me, try with the parentheses 20100731 19:01:07< anonymissimus> Breakpoint 1 at 0xa3b816 20100731 19:01:32< CIA-87> zookeeper * r45009 /trunk/data/core/ (3 files in 2 dirs): Wired in the new volcano tiles. Currently they're only used when a hex of volcano has three mountain hexes underneath it; should be improved later with the addition of a single-hex tile and a proper editor image. 20100731 19:01:37< zookeeper> eleazar_, ^ 20100731 19:01:48< silene> good, try running it again with "run --whatever", hopefully it will accept to give you a backtrace afterwards 20100731 19:06:19< anonymissimus> i have something from when it stopped at the breakpoint 20100731 19:07:18< silene> could you paste it on http://wesnoth.pastebin.com ? so that we see if it is any use 20100731 19:07:24< anonymissimus> http://wesnoth.pastebin.com/uRrNcEZd 20100731 19:08:14< anonymissimus> no stack after exit 20100731 19:08:42< silene> thanks 20100731 19:08:51< anonymissimus> is that useful ? 20100731 19:10:49< anonymissimus> hm why does it reference the lua system installation 20100731 19:11:35< silene> anonymissimus: yes; try removing the definition of the [message] tag in data/lua/wml-tags.lua and the error message on exit should disappear 20100731 19:12:05< silene> anonymissimus: because 1.8 uses the lua system installation 20100731 19:12:45< anonymissimus> I suspected that it's the message tag 20100731 19:13:24-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev 20100731 19:13:46< alink> silene: thanks for the automaked lua 20100731 19:13:55< silene> i was told that exception and longjmp were mixing well on windows, but i guess that was true only for programs compiled with msvc; for programs compiled using gcc, issues occur (though this one hardly matters, since it happens on exit) 20100731 19:15:21< silene> alink: you are welcome 20100731 19:18:54< CIA-87> alink * r45010 /trunk/autogen.sh: 20100731 19:18:54< CIA-87> Remove call to configure in autogen.sh. 20100731 19:18:54< CIA-87> It's inconvenient for out-of-tree build, prevent to see --help before calling configure, contradict wiki and possibly non-standard. 20100731 19:19:49< alink> zookeeper: yes, indeed, set_no_flag is a silly name. I considered others : set_and_no_flags, set_once_flags, unique_flags ... any better ones? 20100731 19:20:20< silene> what is it supposed to do? 20100731 19:20:23< anonymissimus> silene> anonymissimus: yes; try removing the definition of the [message] tag in data/lua/wml-tags.lua and the error message on exit should disappear: YES 20100731 19:20:53< alink> combine set_flags and no_flags, since 90% of the times they are the same 20100731 19:21:52< silene> anonymissimus: great, thanks a lot for your efforts; i guess i will close the report as won't fix now; the original bug is fixed, and this one would be too intrusive to fix for such a small gain 20100731 19:22:00< zookeeper> alink, set_flags_once would communicate the idea best, i guess? 20100731 19:22:05< alink> and it's used as set the flag here, and only works once since the no_flags will prevent other rule application 20100731 19:22:19< zookeeper> (assuming i'm understanding it right) 20100731 19:22:34< anonymissimus> win-only bugs not getting fixed annoy me :P 20100731 19:23:24< silene> anonymissimus: no, it's win+gcc+atexit bugs not getting fixed ;-) 20100731 19:23:30< anonymissimus> silene> anonymissimus: because 1.8 uses the lua system installation: it was since the lua dlls weren't present in wesnoth's install dir, but the ones from the lua installation are in system path 20100731 19:24:20< alink> zookeeper: for common use, yes, but in theory you can combine set_no_flag with other more specific set_flag or no_flag. So using set and no in the name may remind that they works on the same set 20100731 19:24:35< alink> s/set/sets 20100731 19:25:08< silene> anonymissimus: oh, i see, i had misunderstood what you meant 20100731 19:25:57< alink> zookeeper: for example IIRC there is few case where set_flag and no_flag have a big common part, that could be repaced with a big set_no_flags and a little no_flags 20100731 19:29:09< zookeeper> alink, uh, ok. don't expect any insight on that from me :) 20100731 19:29:39< zookeeper> if it's intentional then that's fine by me ;) i don't want to get into that stuff much 20100731 19:30:47< alink> maybe need the opinion of someone often writing complex terrain rules 20100731 19:30:57< alink> but I will already add it to the wiki, even it the name change later 20100731 19:31:03-!- ilor__ [~ilor@87.204.122.151] has joined #wesnoth-dev 20100731 19:34:07< zookeeper> alink, ok, great 20100731 19:35:33< anonymissimus> zookeeper: do you want this syntax for modify_unit you wrote in http://forums.wesnoth.org/viewtopic.php?f=10&t=30983&p=446728#p446728 ? 20100731 19:37:00< zookeeper> anonymissimus, no, i want the syntax i wrote :p 20100731 19:37:08< anonymissimus> I'm wondering about writing the two tags 20100731 19:37:25< anonymissimus> as long as silene hasn't done it 20100731 19:37:36< anonymissimus> :P 20100731 19:38:40< anonymissimus> e.g. the filter tag wouldn't be neccessary 20100731 19:38:54< anonymissimus> many rags take the filter keys directly 20100731 19:38:57< anonymissimus> tags 20100731 19:42:25< zookeeper> you need a tag either for the filter or for the modifications 20100731 19:44:57< anonymissimus> yes thats true 20100731 19:46:24< zookeeper> eleazar_, btw, i'm almost done adding a single-hex version of the volcano, but i won't commit it quite yet since there's some transitions that are still wrong...but i'm working on it 20100731 19:48:21< anonymissimus> and then your're going to change all occurances of MODIFY_UNIT in mainline to that tag...or will esr write some script for you ? 20100731 19:50:37-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20100731 19:50:50< timotei> hi:D 20100731 19:51:01< alink> hmm we use singular (has_flag, no_flag ... ) but these keys often accept a list of flags, so plural should be used. I will not change that, though 20100731 19:51:04< zookeeper> anonymissimus, no need to mass-convert anything...we don't need to remove the macro 20100731 19:51:12< zookeeper> at least for a long time 20100731 19:58:43-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100731 19:58:57< shadowmaster> the laptop had its battery at 50% when I turned it on 20100731 19:59:07< shadowmaster> now it claims 0% and even the LED is blinking 20100731 19:59:11< shadowmaster> :/ 20100731 20:00:27< eleazar_> zookeeper: cool i'll check it out 20100731 20:03:52-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds] 20100731 20:09:25< timotei> !countdown 20100731 20:19:18-!- Upthorn [~ogmar@69.62.144.108] has quit [Ping timeout: 260 seconds] 20100731 20:27:16< alink> forum notifications are working right? I think I missed one 20100731 20:27:36< alink> (asking because site had trouble yesterday) 20100731 20:28:35< alink> ah no, I had some after the downtime 20100731 20:47:54< CIA-87> fendrin * r45011 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (5 files in 3 dirs): UtBS: Unit updates. 20100731 20:50:51-!- Sapient [~chatzilla@wesnoth/developer/sapient] has joined #wesnoth-dev 20100731 20:57:56< CIA-87> eleazar * r45012 /trunk/ (15 files in 3 dirs): adding new mushroom farm terrain. 20100731 21:04:14-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Ping timeout: 245 seconds] 20100731 21:09:56< Sapient> anonymissimus: hi 20100731 21:10:10< anonymissimus> hi ? 20100731 21:10:21< Sapient> did you give up on MSVC ? 20100731 21:10:35< timotei> grr. msvn native doesn't work:( 20100731 21:11:53< Sapient> I'm planning to use MSVC10 going forward, but it will probably take me a long time to get all the dependencies 20100731 21:12:08< timotei> Sapient: why not msvc9? 20100731 21:12:47< zookeeper> eleazar_, if i commit the single-hex version, can you fix the transitions? i'm not completely sure how your new transition stuff works exactly, and my initial attempt didn't seem to get it completely right. 20100731 21:12:49< anonymissimus> no 20100731 21:12:59< Sapient> timotei: why not use the latest version? 20100731 21:13:05< anonymissimus> I rather gave up on gdb and code blocks 20100731 21:13:20< timotei> Sapient: I tried msvc 10 with wesnoth 2 months ago. it was a pain 20100731 21:13:43< Sapient> timotei: how far did you get, and what obstacles should I expect? 20100731 21:13:44< timotei> Sapient: actually, it works upgrading the project, but you need to get some libraries for vs10 no vs9 20100731 21:13:45< anonymissimus> but in principle I'm happy with anythign I get to work 20100731 21:14:20< timotei> Sapient: well...I don't really remember anything. but the build process was very stupid 20100731 21:14:30< timotei> they changed to msbuild afair 20100731 21:14:42< timotei> some retarded verbose messages 20100731 21:15:02< Sapient> ah... maybe older is better then 20100731 21:15:13< anonymissimus> m yes you need to recompile boost iirc 20100731 21:15:28< Sapient> I was going to do all that anyways 20100731 21:15:33< timotei> anonymissimus: if you're good, then you'll compile just the modules you need :) 20100731 21:15:35< Sapient> I want to build the dependencies myself 20100731 21:15:48< anonymissimus> well I'm bad :P 20100731 21:15:48< timotei> no need to compile whole boost:) 20100731 21:15:59< timotei> I was bad too first 2 times 20100731 21:16:18< Sapient> just --with-regex and --with-iostreams right? 20100731 21:16:27< timotei> umm no 20100731 21:16:29< timotei> and date-time too 20100731 21:16:30< timotei> :P 20100731 21:16:55< timotei> Sapient: just be sure to include zlib 20100731 21:17:03< timotei> or... you'll get a lot of linking errors 20100731 21:17:09< timotei> did that myself and end up bad:( 20100731 21:17:33< anonymissimus> what may matter is that vs 10 express has a 30 day period after which you must register, vs 9 express doesn't seem to have a time limit instead 20100731 21:18:02< timotei> umm I don't think so 20100731 21:18:18-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev 20100731 21:18:41-!- Blueblaze [~Blueblaze@99.4.146.0] has joined #wesnoth-dev 20100731 21:18:47< anonymissimus> there's nothing to pay however 20100731 21:18:57< Sapient> anonymissimus: yeah I already registered it (free) 20100731 21:19:23< CIA-87> zookeeper * r45013 /trunk/data/core/ (4 files in 2 dirs): Added a single-hex tile for the new volcano. Transitions not working yet. 20100731 21:19:25< zookeeper> eleazar_, ^ done. if you could enable the transitions, that'd be nice. 20100731 21:19:39< Sapient> this was how I configured bjam last time (when using code::blocks) -- http://www.wesnoth.org/forum/viewtopic.php?p=331300#p331300 20100731 21:19:57< Sapient> so what extra flags will I need? 20100731 21:20:09< anonymissimus> yes I saw it 20100731 21:20:53< timotei> why toolset gcc? 20100731 21:20:56< timotei> use msvc 20100731 21:21:01< timotei> msvc10 20100731 21:25:30< anonymissimus> that quote was for codeBlocks which is used with gcc compiler 20100731 21:30:50< eleazar_> zookeeper: i'd like to do a 7hex version too, but i'm not quite sure how to chop it 20100731 21:34:47< timotei> silene: around? 20100731 21:34:57< timotei> I'm tring to compile trunk and I got this: 20100731 21:35:03< timotei> src\lua\luaconf.h(15) : fatal error C1189: #error : "Exception support requires a C++ compiler." 20100731 21:35:20< timotei> I extra defined __cplusplus, but that opens for new errors 20100731 21:36:15< silene> which new errors? 20100731 21:36:39-!- Gambit [~quassel@pa-67-234-82-198.dhcp.embarqhsd.net] has quit [Ping timeout: 240 seconds] 20100731 21:37:02< timotei> silene: like this: http://wesnoth.pastebin.com/J6TpbbLA 20100731 21:37:18< silene> timotei: by the way, http://msdn.microsoft.com/en-us/library/b0084kay.aspx explicitly says that __cpluscplus is defined by msvc, so you have something seriously broken 20100731 21:37:36< timotei> oh:| 20100731 21:38:47< anonymissimus> hm I got that error in CodeBlocks 20100731 21:39:03< anonymissimus> changing the c compiler to the one for C++ solved it 20100731 21:40:30< anonymissimus> silene: do you mind me writing the modify_unit tag ? 20100731 21:40:57< silene> anonymissimus: why i should i mind? ;-) 20100731 21:41:29< anonymissimus> well, for example because you have planned something anyway that interferes with it 20100731 21:43:03< silene> no, the unit interface should be quite stable; i'm still thinking about providing a native interface to unit variables, but it shouldn't have any impact on a [modify_unit] tag 20100731 21:50:18< CIA-87> eleazar * r45014 /trunk/ (changelog data/core/terrain-graphics.cfg players_changelog): enabling normal mountainy transitions for volcano-- i think. 20100731 21:51:21< eleazar_> zookeeper: can you get a screenshot of the volcanos? 20100731 21:52:08< eleazar_> my compile is a little messed up and isn't giving me what i expect. Don't know if the problem is at my end. 20100731 21:53:09< anonymissimus> silene: when are the core lua files loaded (reloaded) ? 20100731 21:57:32-!- Gambit [~quassel@pa-67-234-82-198.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100731 21:57:37-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20100731 21:57:48-!- Gambit [~quassel@pa-67-234-82-198.dhcp.embarqhsd.net] has quit [Remote host closed the connection] 20100731 22:00:34< CIA-87> timotei * r45015 /trunk/utils/java/ (39 files in 12 dirs): eclipse plugin: grammar update. Now it should match 90% WML Code 20100731 22:01:00< CIA-87> timotei * r45016 /trunk/utils/java/ (24 files in 10 dirs): eclipse plugin: wml grammar update 20100731 22:01:21< CIA-87> timotei * r45017 /trunk/utils/java/ (33 files in 12 dirs): eclipse plugin: add macro defines, some preprocessor commands and textdomains to the wml grammar 20100731 22:01:44< CIA-87> timotei * r45018 /trunk/utils/java/ (32 files in 12 dirs): eclipse plugin: add support for wml arrays 20100731 22:02:05< CIA-87> timotei * r45019 /trunk/projectfiles/VC9/wesnoth.vcproj: update the project files, adding 'exceptions.(c|h)pp' 20100731 22:02:24< CIA-87> timotei * r45020 /trunk/utils/java/ (39 files in 11 dirs): 20100731 22:02:24< CIA-87> eclipse plugin: wml grammar update. now the macros 20100731 22:02:24< CIA-87> are handled better though not 100% 20100731 22:02:47< CIA-87> timotei * r45021 /trunk/utils/java/ (24 files in 10 dirs): eclipse plugin: wml gramamr update: allow animation related values 20100731 22:05:04< CIA-87> espreon * r45022 /trunk/src/exceptions.hpp: Ran umcpropfix. 20100731 22:05:16< Sapient> gabba: hi 20100731 22:05:18< Espreon> Damn it... 20100731 22:05:48< CIA-87> espreon * r45023 /trunk/src/exceptions.cpp: Ran umcpropfix. 20100731 22:07:24< gabba> hi Sapient 20100731 22:08:40< silene> anonymissimus: in trunk, toplevel [lua] tags (which is the case for the core files) are loaded right before the preload events 20100731 22:08:58< CIA-87> espreon * r45024 /trunk/utils/java/org.wesnoth.wml/ (16 files in 3 dirs): Ran dos2unix and umcpropfix. 20100731 22:10:01< anonymissimus> so when you test something new what do you do to reload the lua files 20100731 22:12:48< CIA-87> espreon * r45025 /trunk/data/core/images/terrain/mountains/ (volcano-tile.png volcano.png): Ran umcpropfix. 20100731 22:13:37< CIA-87> espreon * r45026 /trunk/data/campaigns/Under_the_Burning_Suns/ (6 files in 3 dirs): Ran umcpropfix. 20100731 22:13:48< silene> anonymissimus: i'm just reloading the scenario, which is usually instant 20100731 22:13:49< eleazar_> Espreon: can your emcporopfix tell the difference between 8 bits per channel and 16 bits per channel? 20100731 22:13:55< CIA-87> espreon * r45027 /trunk/data/campaigns/Under_the_Burning_Suns/units/quenoth/ (7 files in 4 dirs): Ran wmlindent. 20100731 22:14:12< Espreon> eleazar_: Uh... wut? 20100731 22:14:34< eleazar_> isn't "umcpropfix" a PNG crusher? 20100731 22:14:43< Espreon> umcpropfix just sets appropriate properties and unsets svn:executable if it does not belong. 20100731 22:15:11< eleazar_> ah, never mind then 20100731 22:15:31< Espreon> eleazar_: To compress images, "wesnoth-optipng" is used. 20100731 22:15:51< eleazar_> OK, do you know about that? 20100731 22:16:12< Espreon> It's just a script that calls a bunch of tools. 20100731 22:18:00< eleazar_> who knows about the wesnoth-optipng script? 20100731 22:18:16< Espreon> eleazar_: It calls ImageMagick's "convert", optipng, and advdef. Other than that, I don't know that much. 20100731 22:18:54< Espreon> Why do you ask? 20100731 22:19:24< eleazar_> There are a number of image files that have more bit depth than neccesary 20100731 22:19:29< Espreon> Ah, I see. 20100731 22:19:38< eleazar_> i don't have a good way to find them 20100731 22:20:09< eleazar_> but if the imagemagic could tell the difference that would be convenient 20100731 22:21:20< eleazar_> specifically 16 bits per channel is excessive. The normal 8 bits per channel is plenty. 20100731 22:21:44< eleazar_> I run across a 16 bit file every so often 20100731 22:22:22< silene> eleazar_: "file" does it: data/core/images/attacks/axe.png: PNG image, 60 x 60, 8-bit/color RGBA, non-interlaced 20100731 22:22:53-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: Leaving] 20100731 22:23:21< eleazar_> silene: "file" what? I'm mostly a button clicker 20100731 22:23:31< AI0867> the 'file' command in a terminal 20100731 22:23:36< silene> eleazar_: it's the name of a command 20100731 22:23:42< CIA-87> espreon * r45028 /trunk/data/core/images/misc/schedule-indoors.png: Ran indexed2rgb.sh. 20100731 22:24:09< AI0867> and most of the 16 bits/channel images were created because that's the only way to losslessly convert 16 bit greyscale 20100731 22:24:35< AI0867> and wesnoth-optipng doesn't play nice with images that aren't RGB/RGBA 20100731 22:24:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100731 22:24:54< eleazar_> AI0867: i don't think rea have a reason to have 16 bit greyscale images either 20100731 22:25:03< eleazar_> s/rea/we 20100731 22:25:09< AI0867> well, I didn't look at the contents 20100731 22:25:11< CIA-87> espreon * r45029 /trunk/data/core/images/misc/schedule-indoors.png: 20100731 22:25:12< CIA-87> Ran wesnoth-optipng: 20100731 22:25:12< CIA-87> Overall statistics (only for files with a smaller recompressed size): 20100731 22:25:12< CIA-87> Original size: 12 KiB on 1 files 20100731 22:25:12< CIA-87> Optimized size: 6 KiB 20100731 22:25:12< CIA-87> Total saving: 5 KiB = 43% decrease 20100731 22:25:23< silene> eleazar_: antd it tells me there are 217 16-bit png files in trunk 20100731 22:25:29< AI0867> I'm just not going to modify the contents of the images with automated tools 20100731 22:26:04< eleazar_> AI0867: i appreciate caution when automatically doing that kind of stuff 20100731 22:26:17< eleazar_> we've gotten a few big messes in the past 20100731 22:26:38-!- Gambit [~quassel@pa-67-234-82-198.dhcp.embarqhsd.net] has joined #wesnoth-dev 20100731 22:27:00< silene> AI0867: i don't see any 16-but grayscale images in my list 20100731 22:27:14< AI0867> silene: indexed2rgb.sh converted those 20100731 22:27:29< AI0867> as wesnoth-optipng occasionally screws up on anything but rgb/rgba 20100731 22:28:06< silene> i see 20100731 22:28:08< eleazar_> that's fine. rgb/rgba is the most likely to work with image editors 20100731 22:28:34< eleazar_> other formats don't always work right 20100731 22:29:03< zookeeper> eleazar_, ok, i'm back. still need the screenshot? 20100731 22:29:09< eleazar_> yeah 20100731 22:29:15< zookeeper> ok, give me a few minutes... 20100731 22:29:21< eleazar_> great 20100731 22:32:22-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.] 20100731 22:33:58< zookeeper> eleazar_, http://imagebin.org/107573 20100731 22:34:38< zookeeper> i didn't add Qv to any of the transition macro calls 20100731 22:34:50< eleazar_> i don't see transitions on the single hex 20100731 22:35:18< zookeeper> well, exactly 20100731 22:35:34< zookeeper> that's what i figured you could do, since i don't really know where all i should be adding Qv to 20100731 22:35:44-!- dtiger [~dtiger@dynamic-vpdn-93-125-66-92.telecom.by] has quit [Remote host closed the connection] 20100731 22:35:54< eleazar_> zookeeper: did you update? 20100731 22:36:15< eleazar_> i commited such changes (i think) 20100731 22:36:43< eleazar_> r45014 20100731 22:36:49< zookeeper> oh, right. i didn't notice that 20100731 22:37:09< zookeeper> explains why i thought it was slightly odd you wanted a screenie of them in the first place ;) 20100731 22:38:05< zookeeper> checking... 20100731 22:38:24< eleazar_> i haven't been able to compile in a while so some of the new .cfgs aren't compatible with my binary 20100731 22:39:11< eleazar_> so what i see... is not what you get 20100731 22:41:23< zookeeper> eleazar_, ok, it looks like the transitions work all right now, except with snowhills 20100731 22:41:30< zookeeper> (just a hard edge) 20100731 22:42:01< eleazar_> can probably fix that.... 20100731 22:47:56< Sapient> gabba: hi, you there? 20100731 22:48:09< gabba> Sapient: yup, I'm around 20100731 22:48:27< Sapient> I noticed you were having isssues with invalid unit iterators 20100731 22:49:00< Sapient> and I wondered if you realized that there are a variety of iterator/accessor types to choose from 20100731 22:49:48< gabba> I'm not sure what you're referring to... various accessors offered by the unit map? 20100731 22:49:56< Sapient> yes 20100731 22:50:56< gabba> I'd imagine none of them would stay valid if a unit is inserted, iterator is acquired, then unit is removed and reinserted before iterator is used? 20100731 22:52:28< CIA-87> eleazar * r45030 /trunk/data/core/terrain-graphics.cfg: improved transitions for the volcano 20100731 22:52:52< Sapient> gabba, actually there were just that sort of class 20100731 22:53:11< zookeeper> eleazar_, checking again... 20100731 22:53:12< Sapient> unfortunately, I am looking at unit_map.hpp right now and I don't see it in there anymore 20100731 22:53:21< Sapient> so maybe it was removed 20100731 22:54:20< gabba> ok, in any case thanks for letting me know there are several possibilities there, I'll take a look 20100731 22:56:31< zookeeper> eleazar_, yeah, that fixed the snow hills, and i haven't spotted any other problems 20100731 22:57:38< Sapient> gabba: it looks like it was converted to use templates, then apparently much of it was removed by silene because no one had made use of it yet or something 20100731 22:57:55< eleazar_> It should work as well as the mountains do-- i.e. not well with chasm 20100731 23:01:07-!- Upth [ogmar@adsl-75-26-198-150.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100731 23:01:07-!- Upth is now known as Upthorn 20100731 23:02:54< gabba> Sapient: I see. In any case, my code in the mouse handler is rather hacky, and the best solution would be for me to reorganise it better to suit the wb... rather than have iterators that don't invalidate. Right now I manage to reuse the selection and route/move/attack code, but the result is patchy at best. 20100731 23:04:04-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Read error: Connection reset by peer] 20100731 23:10:12-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20100731 23:15:07< Sapient> gabba, silene: for the history behind the "smart unit_map iterator" idea, see this thread: http://www.wesnoth.org/forum/viewtopic.php?p=236063#p236063 20100731 23:15:55-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection] 20100731 23:16:08< Sapient> I think rather than removing the unused accessors, the relevant code areas should be made to use them 20100731 23:16:36< Sapient> that was the original intention but I guess no one got around to it 20100731 23:17:04-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev 20100731 23:18:27< Sapient> The way I see it, there are three types of unit accessors needed: 20100731 23:18:39< Sapient> Type 1) a unit accessor that only wants to keep pointing to the same unit based on unique identity 20100731 23:19:03< Sapient> Type 2) a unit accessor that is picky about BOTH location and the unique identity (possibly the most common case) 20100731 23:19:16< gabba> Sapient: well, current unit map iterators are resilient to changing the location of an already inserted unit to another map_location 20100731 23:19:17< Sapient> Type 3) a unit accessor that only wants to keep pointing to the (volatile) unit at a given location. Probably the least common case 20100731 23:20:44< Sapient> for some purposes, Type1 not the desired behavior. 20100731 23:20:52-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Remote host closed the connection] 20100731 23:21:19< Sapient> for example, if you are attacking someone with a sword and they teleport across the map 20100731 23:22:26< Sapient> in the end, I guess I didn't communicate the idea effectively enough or maybe no one cared enough to use it 20100731 23:23:23< Sapient> it probably wouldn't be too hard to add the support back in later in case I decide to make use of it, though 20100731 23:28:18-!- wesbot changed the topic of #wesnoth-dev to: 131 bugs, 283 feature requests, 13 patches | Wesnoth Licensing Meeting at 16:00 GMT on Sunday August 1st | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100731 23:28:27< CIA-87> eleazar * r45031 /trunk/data/core/images/terrain/ (118 files in 9 dirs): downsampling terrain images from 16 bits per channel to 8. Also shrinking excessively image size on some files. Saved .4 MB-- hope it improves performance. 20100731 23:31:22< AI0867> eleazar_: did you run optipng? 20100731 23:31:25< AI0867> if not, I'm running it now 20100731 23:31:33< eleazar_> please do 20100731 23:33:13-!- Blueblaze is now known as Blueblaze|SC2 20100731 23:36:04-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20100731 23:39:10-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20100731 23:39:31-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20100731 23:39:31-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev --- Log closed Sun Aug 01 00:00:14 2010