--- Log opened Sat Aug 14 00:00:09 2010 --- Day changed Sat Aug 14 2010 20100814 00:00:09< gabba> wow merci. ok j'essaye! 20100814 00:00:21< shadowmaster> http://shadowm.rewound.net/blog/archives/95-Wesnoth.org-and-the-Prosilver-transition.html 20100814 00:00:27< boucman> and after taht i'll likely go to bed :P 20100814 00:01:16< shadowmaster> http://shadowm.rewound.net/blog/archives/95-Wesnoth.org-and-the-Prosilver-transition.html 20100814 00:01:57< shadowmaster> of course that's only for those who care about the forums 20100814 00:04:41< gabba> boucman, those arrows actually look really nice 20100814 00:04:52< gabba> did you do the border by hand or with some filter? 20100814 00:06:03< boucman> I built myself a "cutout" and built them with gimp layers 20100814 00:09:21< gabba> boucman: one question: it'd be nice to get the WB tested more widely this weekend, maybe I could make a ML announcement so that devs come and test it on the server? 20100814 00:09:56< boucman> that, and you could lurk on #wesnoth-mp 20100814 00:10:15< boucman> there are usually a couple of senior players there that could give you feedback 20100814 00:10:32< Crab_> boucman: will they be able to use non-released trunk ? 20100814 00:10:39< gabba> that too 20100814 00:10:48< boucman> Crab_: good point 20100814 00:11:32< boucman> gabba: there is little time before 1.9.0, getting testing is nice but I'm not sure you would have much time to adapt anything prior to 1.9.0, and you will have more feedback with the release anyway... 20100814 00:12:34< gabba> TBH, since the evaluation is on monday I was a bit worried about handing in such an untested work 20100814 00:12:49< gabba> even though it's symbolic and I'll keep working on it 20100814 00:13:38< boucman> gabba: i'm not against having more playtest matches, esp if they can uncover serious bugs, it's more on the UI side I doubt you would have time to get much feedback 20100814 00:14:49< gabba> yes it's more to discover bugs, trying to get UI adjustments in for monday just risks introducing more bugs (like the "funny" one of the trailing ghost) 20100814 00:14:56< gabba> phone 20100814 00:15:25< Crab_> gabba: is there a whiteboard manual/quickstart guide ? 20100814 00:16:09< boucman> Crab_: http://wesnoth.pastebin.com/XWc2Sgrn 20100814 00:18:46< gabba> boucman: he he this message needs a bit of updating, but I can do that and post it tonight to the ML 20100814 00:19:06< boucman> gabba: that and in the RELEASE_NOTES 20100814 00:19:19< boucman> and yes, that's something you can do while compiling ;) 20100814 00:19:41< gabba> Crab_: not yet, but as boucman says I intend to add something to the RELEASE_NOTES 20100814 00:20:04< Crab_> ok 20100814 00:24:33-!- Sapient [~patrickp@wesnoth/developer/sapient] has joined #wesnoth-dev 20100814 00:26:40-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds] 20100814 00:34:49-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has joined #wesnoth-dev 20100814 00:34:51< Crab_> billynux: ok, ana-static now compiles under MSVC (ana has some link issues, but this doesn't matter for now). but, there's still some ana-related MSVC-errors in wesnoth itself - some type conversion failures, which seem fixed by something like http://wesnoth.pastebin.com/FvcRdrHx 20100814 00:37:34< Upthorn> okay, it looks like my compiling problems on a new install were that wesnoth requires VC9 Service Pack 1 20100814 00:38:01< Crab_> MSVC can be funny sometimes 20100814 00:38:48< Upthorn> at the very least several warnings and a couple of errors (complaining that it can't find operator== for std::string == config::attribute_value) have disappeared. 20100814 00:39:09< Crab_> that's good. any bugs which still remain ? 20100814 00:39:39< Upthorn> hopefully it will also solve the "cannot open vc90.pdb file does not exist" problem, but compilation under SP1 hasn't reached the point where that occurs ye 20100814 00:41:36< Crab_> ok. I've just successfully compiled wesnoth under msvc 2008 professional sp1 (cmake route), just had to fix a few issues with ana. 20100814 00:47:41< Crab_> silene: cmake+MSVC2008 compiles and runs ok with lua source included. 20100814 00:49:47< gabba> boucman: that nulloid guy in the log gave me an idea (for later of course): the WB could offer a feature to auto-plan the swapping of two units. 20100814 00:50:33< Crab_> gabba: note that there'a decision involved in the swapping, namely 'which units goes first and where' 20100814 00:53:45< gabba> Crab_: true. I tend to think it doesn't matter usually, unless you're dealing w/ leadership, or moving would uncover fog. Anyways, it's just an idea to keep in mind. 20100814 00:54:14-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 00:54:21< Crab_> gabba: no, it would matter in any case, since the number of MP remaining would differ. 20100814 00:55:05< gabba> unless both units end up next to an enemy unit (as is often the case when switching places) 20100814 00:55:57-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20100814 00:56:09< Crab_> unless one or more of them are skirmishers :) 20100814 00:56:22< gabba> even though I guess you get even more often the case where you're trying to move one unit away from the front line 20100814 00:56:44< gabba> yeah, that too 20100814 00:56:46< Crab_> yes, I agree. but those are things to keep in mind. 20100814 00:58:38< gabba> Oh well. Maybe more promising is the feature that someone asked for on the forums/bug tracker: the ability to place symbols in the hex of your choice, as a complement to labels. Very easy to do with the WB as actions that do nothing... and they'll be visible by allies once the network part is in place. 20100814 00:59:28< Crab_> ok, I've uploaded a new version of `external` folder (without lua, with more boost libs, allows to compile trunk using msvc\cmake ), to ftp://ftp.terraninfo.net/wesnoth/msvc9/external_19.zip 20100814 00:59:36< Crab_> gabba: yes, that looks promising indeed 20100814 00:59:57< Crab_> later, the AI can use it, as well, to show human what 'wants' to do 20100814 01:00:14< Crab_> for AI has 'target' markers which are useful for that purpose 20100814 01:01:34< gabba> those symbols could even be configured in a WML file with name=, symbol=, so new ones could easily be added without modifying the C++. 20100814 01:11:29-!- West [~Administr@hd5e2754c.gavlegardarna.gavle.to] has quit [Quit: Leaving] 20100814 01:11:42< boucman> night all 20100814 01:11:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20100814 01:15:24< Crab_> gabba: well, add feature that you personally like, and see the feedback :) 20100814 01:15:57< CIA-49> crab * r45571 /trunk/projectfiles/VC9/README.txt: documented updated instructions for cmake+MSVC2008 compilation 20100814 01:18:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100814 01:18:21< noy> weird... I have a "memo" 20100814 01:18:24< noy> how do I check that 20100814 01:18:51< noy> ah 20100814 01:18:53< noy> there we go 20100814 01:19:33< Crab_> noy: http://toxin.jottit.com/freenode_memoserv_commands , in case it's still needed 20100814 01:19:39< noy> got it 20100814 01:19:42< noy> its all good 20100814 01:19:48< shadowmaster> bah, I missed the oportunity of explaining how MemoServ works and bragging about atheme-services' awesomeness 20100814 01:20:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: rebooting] 20100814 01:20:23< Crab_> shadowmaster: upgrade the bot to react faster - let no opportunities be missed :)) 20100814 01:20:43< AI0867> memoserv... isn't that something I used on quakenet 10 years ago? 20100814 01:20:46< AI0867> wasn't very useful 20100814 01:21:24< Upthorn> okay, SP1 did fix my "fatal error C1083: Cannot open program database file: 'c:\...\debug (fast)\vc90.pdb': No such file or directory" errors 20100814 01:21:35< Crab_> good 20100814 01:25:32-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 01:30:00< gabba> Crab_: there isn't a way of asking the engine "are we in the process of moving a unit" (/performing an attack/upgrading/etc.), is it? 20100814 01:30:24< Crab_> you can check if commands are enabled or disabled 20100814 01:30:36< Crab_> and, when we are 'in the process', they are disabled 20100814 01:31:07< gabba> Found that one already, yes, but it's too much of a "blanket" for my needs I think. 20100814 01:32:41< gabba> I'll probably add events::unit_is_moving and the like if I can't find another way 20100814 01:35:22< Crab_> bye 20100814 01:35:51< Crab_> yes, you can add events but be sure to cover all cases :) 20100814 01:36:33-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.] 20100814 01:59:57-!- Sapient [~patrickp@wesnoth/developer/sapient] has left #wesnoth-dev [] 20100814 02:05:42-!- eleazar [~eleazar@ppp-70-226-209-195.dsl.spfdil.ameritech.net] has quit [Quit: eleazar] 20100814 02:13:13-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection] 20100814 02:44:19-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz] 20100814 02:44:54-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20100814 03:24:46-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection] 20100814 03:31:15-!- shadowmaster [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 03:33:06-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has quit [Quit: Colloquy for iPhone - http://colloquy.mobi] 20100814 03:38:08-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number] 20100814 03:38:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 04:07:28-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.2/20100316074819]] 20100814 04:11:27-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20100814 04:14:27-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 04:34:47-!- Ivanovic_ [~ivanovic@dtmd-4db2fccf.pool.mediaWays.net] has joined #wesnoth-dev 20100814 04:37:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 276 seconds] 20100814 04:38:45-!- Ivanovic_ is now known as Ivanovic 20100814 04:47:47-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 252 seconds] 20100814 05:11:38-!- Gallaecio [~quassel@72.137.117.91.dynamic.mundo-r.com] has quit [Remote host closed the connection] 20100814 05:20:34-!- Gambit [~Gambit@unaffiliated/gambit] has quit [Quit: he leaked the documents in which the term was first used [insert unrequired tongue]] 20100814 05:23:51-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has joined #wesnoth-dev 20100814 05:27:40-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has quit [Read error: Connection reset by peer] 20100814 05:36:09-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Remote host closed the connection] 20100814 05:42:36-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has quit [Quit: Colloquy for iPhone - http://colloquy.mobi] 20100814 06:03:01-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has joined #wesnoth-dev 20100814 06:07:30-!- silene [~plouf@AMarseille-553-1-286-245.w90-53.abo.wanadoo.fr] has joined #wesnoth-dev 20100814 06:07:30-!- silene [~plouf@AMarseille-553-1-286-245.w90-53.abo.wanadoo.fr] has quit [Changing host] 20100814 06:07:30-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev 20100814 07:05:38-!- ancestral [~ancestral@mobile-166-137-141-123.mycingular.net] has quit [Quit: Colloquy for iPhone - http://colloquy.mobi] 20100814 07:07:57-!- ancestral [~ancestral@206.55.180.8] has joined #wesnoth-dev 20100814 07:13:53-!- Upthorn [~chatzilla@adsl-75-26-199-178.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 241 seconds] 20100814 07:13:58-!- Upthorn [~ogmar@adsl-75-26-185-189.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 07:15:10-!- Upth [~ogmar@75.26.199.178] has quit [Ping timeout: 240 seconds] 20100814 07:15:57-!- Upthorn_ [~chatzilla@adsl-75-26-185-189.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 07:35:53-!- dtiger [~dtiger@dynamic-vpdn-91-149-190-114.telecom.by] has joined #wesnoth-dev 20100814 07:54:31-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin] 20100814 08:03:05-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20100814 08:05:22< timotei> moarrninng 20100814 08:05:22< timotei> :D 20100814 08:14:04< ancestral> Oh hye 20100814 08:14:14< ancestral> Lemme find that file 20100814 08:15:15< timotei> oh, hi ancestral 20100814 08:20:26< ancestral> Let me pastebin something for you 20100814 08:21:19< timotei> ok 20100814 08:22:25< ancestral> http://pastebin.com/ajbuUYtH 20100814 08:22:43< ancestral> Might not be a perfect grammar mind you - it's incomplete but yeah 20100814 08:24:01< timotei> wow, you're using backtracking?:P 20100814 08:25:22< timotei> well, you see? 20100814 08:25:30< timotei> I could use the RETURN thingy in WML too 20100814 08:25:39< timotei> but the following is valid, so would break my grammar: 20100814 08:25:50< timotei> {MACRO (id=Elf) } 20100814 08:25:54< timotei> thus, not ending with eol ;) 20100814 08:28:14< ancestral> So breaking that down 20100814 08:28:53< timotei> did you saw already the current grammar?:) 20100814 08:29:25< ancestral> No, I guess I haven't haha 20100814 08:29:43< ancestral> it's in source? 20100814 08:29:46< timotei> yes 20100814 08:29:47< ancestral> svn up? 20100814 08:29:49< ancestral> k 20100814 08:29:53< timotei> http://svn.gna.org/viewcvs/wesnoth/trunk/utils/java/org.wesnoth.wml/src/org/wesnoth/ 20100814 08:30:02< timotei> exactly: http://svn.gna.org/viewcvs/wesnoth/trunk/utils/java/org.wesnoth.wml/src/org/wesnoth/WML.xtext?rev=45508&view=markup 20100814 08:30:04< timotei> ancestral: ^ 20100814 08:30:12< ancestral> thanks 20100814 08:30:28< timotei> I modified it a lil bit in the meantime, but it resembles that one 20100814 08:30:38< ancestral> += ? 20100814 08:30:49< timotei> multiple adds 20100814 08:30:55< timotei> that means, all WMLTags encountered 20100814 08:30:57< timotei> are added: 20100814 08:31:00< timotei> Tags.Add() 20100814 08:31:04< ancestral> Hmm 20100814 08:31:07< timotei> Tags will be a list of values 20100814 08:31:08< ancestral> ANTLR convention? 20100814 08:31:17< timotei> no, it's enbnf 20100814 08:31:21< ancestral> Ohhhh 20100814 08:31:21 * ancestral is old school I guess 20100814 08:31:23< timotei> the antlr is much ... 'harder':)) 20100814 08:31:35< ancestral> Wlel 20100814 08:31:51< timotei> this is the antlr: http://svn.gna.org/viewcvs/wesnoth/trunk/utils/java/org.wesnoth.wml/src-gen/org/wesnoth/parser/antlr/internal/InternalWML.g?rev=45508&view=markup 20100814 08:31:52< timotei> :)) 20100814 08:31:52< ancestral> I was taught with lex/flex and yacc/bison 20100814 08:37:38< ancestral> So where are you stuck? 20100814 08:38:23-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...] 20100814 08:38:25< timotei> well, I've started it all over again, from scratch 20100814 08:38:39< timotei> one sec 20100814 08:38:55< timotei> well, in the grammar you saw, the arrays are not supported 20100814 08:39:15< timotei> x,y=myarray[2].x,myarray[2].y 20100814 08:39:32< shadowmaster> you mean $myarray[2].x,$myarray[2].y 20100814 08:39:41< timotei> umm... 20100814 08:39:54< shadowmaster> $ is the variable interpolation token 20100814 08:40:05< timotei> [set_variable] 20100814 08:40:05< timotei> name=my_awesome_array[0].x 20100814 08:40:05< timotei> value=10 20100814 08:40:05< timotei> [/set_variable] 20100814 08:40:37< shadowmaster> of course, since the name= attribute is not to be interpolated as it describes variable name 20100814 08:40:48< shadowmaster> *a variable name. 20100814 08:41:09< shadowmaster> it can still contain interpolated variables to determine the variable name based on other variables. 20100814 08:41:40< shadowmaster> i.e. name=unit_status_at_$x1|_$y1 20100814 08:41:54< shadowmaster> ( | being the interpolation delimiter token) 20100814 08:41:57< shadowmaster> confused yet? 20100814 08:43:40< timotei> umm.. 20100814 08:43:43< timotei> what's that?:) 20100814 08:43:47< timotei> oh 20100814 08:44:23< CIA-49> gabba * r45572 /trunk/images/arrows/ (123 files in 3 dirs): (log message trimmed) 20100814 08:44:23< CIA-49> Arrows: added 25% transparency to the highlighted arrows, as the focus arrows are supposed to be the brightest. 20100814 08:44:23< CIA-49> Added/updated imagemagick_command.txt for both standard and highlighted arrows. 20100814 08:44:23< CIA-49> Ran wesnoth-optipng over all arrow images: 20100814 08:44:23< CIA-49> Overall statistics (only for files with a smaller recompressed size): 20100814 08:44:24< CIA-49> Original size: 261 KiB on 121 files 20100814 08:44:25< CIA-49> Optimized size: 241 KiB 20100814 08:44:26< CIA-49> gabba * r45573 /trunk/src/whiteboard/ (highlight_visitor.cpp manager.cpp manager.hpp): Whiteboard: improve code for hiding units and avoiding too much superposition. 20100814 08:44:32< shadowmaster> Sapient would do a better job at explaining this mess. 20100814 08:44:33< CIA-49> gabba * r45574 /trunk/src/game_display.cpp: Always draw temp units last, so they appear on top. Has no effect on their use for animating movement, but it makes the whiteboard's fake units a bit more visible in stacked situations. 20100814 08:44:39< CIA-49> gabba * r45575 /trunk/src/ (game_display.cpp game_display.hpp): Add methods to game_display to allow a unit to request to be the only one drawn in its hex. 20100814 08:44:48< CIA-49> gabba * r45576 /trunk/src/whiteboard/ (4 files): Whiteboard: use exclusive draw methods to replace old problematic way of hiding units. 20100814 08:44:53< CIA-49> gabba * r45577 /trunk/src/whiteboard/side_actions.hpp: Whiteboard/side_actions: add reverse iterators and rend() rbegin() methods. 20100814 08:45:00< CIA-49> gabba * r45578 /trunk/src/whiteboard/highlight_visitor.cpp: Whiteboard/highlight_visitor: ensure actions defined later get priority when highlighting. 20100814 08:45:06< CIA-49> gabba * r45579 /trunk/src/whiteboard/highlight_visitor.hpp: Whiteboard/highlight_visitor: added methods to return main and secondary highlighted actions. 20100814 08:45:12< CIA-49> gabba * r45580 /trunk/src/whiteboard/manager.cpp: Whiteboard/manager: call the highlighter after erasing an action. 20100814 08:45:18< CIA-49> gabba * r45581 /trunk/src/whiteboard/manager.hpp: Whiteboard/manager: added method to return the highlight visitor instance. 20100814 08:45:24< CIA-49> gabba * r45582 /trunk/src/whiteboard/side_actions.cpp: Whiteboard/side_actions: highlight numbers whenever their corresponding actions are highlighted. 20100814 08:46:59-!- eleazar [~eleazar@ppp-70-226-203-255.dsl.spfdil.ameritech.net] has joined #wesnoth-dev 20100814 08:58:49-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev 20100814 09:05:40-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has joined #wesnoth-dev 20100814 09:06:57< ancestral> timotei: Do you have a sample file you're testing with? 20100814 09:07:08< timotei> ancestral: the .. mainline files :) 20100814 09:07:11< timotei> data/campaigns 20100814 09:07:14< ancestral> k 20100814 09:08:24< ancestral> what's value = LUA_CODE ? 20100814 09:08:55< ancestral> LUA_CODE is a variable, or? 20100814 09:09:01< ancestral> a string? 20100814 09:09:02< timotei> it's a rule 20100814 09:09:07< timotei> a terminal rule exactly 20100814 09:09:12< timotei> '<<' -> '>>'; 20100814 09:09:17< ancestral> Oh of course 20100814 09:15:47-!- stikonas [~and@ctv-213-164-99-190.vinita.lt] has joined #wesnoth-dev 20100814 09:15:47-!- stikonas [~and@ctv-213-164-99-190.vinita.lt] has quit [Changing host] 20100814 09:15:47-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20100814 09:20:06-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has quit [Remote host closed the connection] 20100814 09:36:34-!- joo [~joo@188-221-182-115.zone12.bethere.co.uk] has joined #wesnoth-dev 20100814 09:36:34-!- joo [~joo@188-221-182-115.zone12.bethere.co.uk] has quit [Changing host] 20100814 09:36:34-!- joo [~joo@unaffiliated/joo] has joined #wesnoth-dev 20100814 09:40:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20100814 09:42:13< timotei> ancestral: btw, do you use/used antlrworks? 20100814 09:46:37< timotei> gabba: hey there 20100814 09:46:45< gabba> hey timotei 20100814 09:46:52< timotei> do you use commit template?:P 20100814 09:46:57< timotei> or you type that by hand? 20100814 09:47:11< gabba> Nope, all that by hand :D 20100814 09:47:17< timotei> you should add a template 20100814 09:47:30< timotei> gabba: http://book.git-scm.com/5_customizing_git.html 20100814 09:48:08< timotei> lucky me, for using git. sometimes when commiting non-eclipse plugin stuff, I forgot to remove the template, thus needing to revert the commit in order to fix the commit message:) 20100814 09:48:37< gabba> ah, thanks! That'd save me at least typing Whiteboard every time. 20100814 09:48:43< timotei> yeah 20100814 09:49:12< gabba> git is great. I'm becoming addicted to 'git commit --amend' and 'git rebase -i' 20100814 09:49:48< timotei> hmm 20100814 09:49:52< timotei> yeah, git rebase -i is nice 20100814 09:50:12< timotei> thou I forgot what ammend does 20100814 09:50:30< gabba> you use 'git commit --amend' to edit your commit message instead of reverting, for instance. Or to add more changes to the last commit. 20100814 09:50:30< timotei> oh right 20100814 09:50:32< timotei> reset and commit 20100814 09:50:39< timotei> aha 20100814 09:50:43< gabba> right 20100814 09:50:56< timotei> yes, it's truly amazing the power of git 20100814 09:50:57< timotei> :D 20100814 09:51:17-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev 20100814 09:52:36< ancestral> timotei: Yes I use ANTLRworks 20100814 09:53:04< timotei> ancestral: the thing I don't understand, its when got multiple ways of doing a thing 20100814 09:53:09< timotei> for example 20100814 09:53:46< timotei> in syntax diagram, warning(200): D:\bin\antlrworks\InternalWML.g:225:1: Decision can match input such as "RULE_ID" using multiple alternatives: 1, 2 20100814 09:53:46< timotei> As a result, alternative(s) 2 were disabled for that input 20100814 09:54:03< ancestral> Right 20100814 09:54:04< ancestral> So 20100814 09:54:05< timotei> if I chose to show alternative 2, I don't know what and how it happens? 20100814 09:54:10< ancestral> It checks in an order 20100814 09:54:14< ancestral> the terminals probably 20100814 09:54:25< ancestral> Make the most specific examples earlier 20100814 09:54:31< ancestral> The least specific later 20100814 09:54:54< timotei> ancestral: http://imagebin.org/109603 20100814 09:54:57< timotei> how do I read this? 20100814 09:55:01< ancestral> e.g. number; integer; digit; character 20100814 09:55:36< ancestral> Hmm not sure the red 20100814 09:55:47< ancestral> Maybe that means it won't be included 20100814 09:55:59< ancestral> I think it's asking 20100814 09:56:09< ancestral> "ruleWMLKeyValue?" and the answer is yes 20100814 09:56:27< ancestral> And doesn't ask any other questions 20100814 09:56:38< ancestral> '5' is a number and an integer 20100814 09:56:50< ancestral> So if I have both as terminals 20100814 09:57:11< ancestral> that might happen 20100814 09:57:31< ancestral> Unless I make something in common with both number and integer, like digit 20100814 09:57:37< thespaceinvader> is it OK for me to update the Burner and Fighter portraits in 1.8 branch to the new versions? 20100814 09:58:02< ancestral> and just use digit instead 20100814 10:01:00< CIA-49> silene * r45583 /trunk/src/unit_map.hpp: Added assertion against broken usage of iterators, e.g. i != end which always return true when they are not from the same unit map. 20100814 10:02:17< silene> thespaceinvader: if filenames change, definitely no; but if it's just some pixels of the images, i don't think it's an issue 20100814 10:02:46< thespaceinvader> i'd be updating existing images, not adding or changing any file names 20100814 10:02:47< thespaceinvader> thanks 20100814 10:03:38< ancestral> timotei: I'll take a look at your work in the morning (~6-8 hours) 20100814 10:07:22< timotei> ok 20100814 10:07:23< timotei> thanks 20100814 10:07:36< timotei> ancestral: by that time it will be commited the last working stuff, hopefully 20100814 10:08:12< ancestral> Maybe you'll fix it 100% by the time I awake ;-) 20100814 10:09:07< CIA-49> thespaceinvader * r45584 /trunk/ (17 files in 3 dirs): Add and wire new Spearman s attack animation by Major. Update changelogs. 20100814 10:09:33< timotei> :D 20100814 10:09:35< timotei> I hope so 20100814 10:09:50-!- Upth [~ogmar@adsl-75-26-165-241.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 10:10:10-!- Upthorn__ [~chatzilla@adsl-75-26-165-241.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 10:11:35-!- Upthorn [~ogmar@adsl-75-26-185-189.dsl.scrm01.sbcglobal.net] has quit [Disconnected by services] 20100814 10:11:37-!- Upthorn__ is now known as Upthorn 20100814 10:11:54-!- ancestral [~ancestral@206.55.180.8] has quit [Quit: And that’s the end of THAT chapter.] 20100814 10:12:18-!- Upthorn_ [~chatzilla@adsl-75-26-185-189.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 252 seconds] 20100814 10:13:06< CIA-49> thespaceinvader * r45585 /branches/1.8/ (7 files in 4 dirs): Update Drake Fighter and Burner portraits. Update changelogs, portrait credits. 20100814 10:15:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20100814 10:26:08< gabba> morning boucman 20100814 10:26:20< timotei> hi boucman 20100814 10:26:37< boucman> morning 20100814 10:27:10-!- Blueblaze [~Blueblaze@adsl-99-158-46-202.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 246 seconds] 20100814 10:28:46< gabba> boucman, mordante: when you have a moment, I'm still clueless about how to add an item to Wesnoth's context menu. I saw code that removes elements ("hotkeys") from there, but none that adds it. If it's gui2 wml stuff, I haven't found it either. 20100814 10:31:00-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20100814 10:31:22< boucman> gabba: did you grep for a menu entry ? 20100814 10:31:55-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Client Quit] 20100814 10:34:16< gabba> boucman: I sure did, and found out the text of the menu entries come from the hotkeys, but I can't get beyond the conclusions above. 20100814 10:34:46< boucman> ok... 20100814 10:34:53< gabba> I checked all references to a few hotkeys, as well 20100814 10:35:22< boucman> hmm 20100814 10:35:28< boucman> did you check the theme WML ? 20100814 10:36:24< boucman> yup it's there... 20100814 10:37:05< gabba> damn, which file is that? 20100814 10:37:43< boucman> data/themes/* more at http://wiki.wesnoth.org/ThemeWML 20100814 10:37:58< gabba> thanks 20100814 10:38:05< boucman> np :P 20100814 10:39:32< boucman> gabba: your new number highlighting is great... 20100814 10:39:59< boucman> I think the big problem UI-wise now is that ghosted units are too hard to see 20100814 10:40:04< gabba> boucman: thanks, it was a sudden late night inspiration :P 20100814 10:40:20< gabba> you mean ghosted_disabled ones? 20100814 10:40:20< boucman> more precisely, intermediate ghost units are fine, but final ghost units should be more visible... 20100814 10:41:03< gabba> boucman: ok I have wesnoth open, and I see what you mean 20100814 10:41:31< boucman> cool, that gains me the effort of writing a clear explanation :P 20100814 10:42:57-!- Ivanovic [~ivanovic@dtmd-4db2fccf.pool.mediaWays.net] has quit [Changing host] 20100814 10:42:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20100814 10:43:13< Ivanovic> moin 20100814 10:43:27< gabba> boucman: ok, I could set the final ghosts to the regular ghosted animation without too much trouble 20100814 10:43:31< gabba> morning Ivanovic 20100814 10:43:34< timotei> hi Ivanovic :P 20100814 10:43:43< boucman> moin moin 20100814 10:43:44< timotei> it seems only to me or you were really late?:D 20100814 10:44:14< boucman> gabba: yes, that would be great... if it's a minute work could you do it before bed so I can test it while you sleep ? 20100814 10:45:54< timotei> ok, commit flood on its way 20100814 10:46:00< gabba> Let me see... I remember finding the proper place to update which planned action was the last one of a unit was a nuisance, but my code has changed a lot since 20100814 10:46:10< Ivanovic> timotei: uhm, why late? 20100814 10:46:18< timotei> just blambing.:P 20100814 10:46:35< Ivanovic> just because i enjoy staying in bed for some more time since it is compftable? 20100814 10:46:36< timotei> usually you'd be online at 9 AM 20100814 10:46:42< timotei> :) 20100814 10:47:23< timotei> but it's still ok, since most people are too lazy, and sleep till 12 AM 20100814 10:49:03< CIA-49> timotei * r45586 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/schema/Tag.java: 20100814 10:49:03< CIA-49> eclipse plugin: add helper methods for finding 20100814 10:49:04< CIA-49> tags and tagkeys by name 20100814 10:49:14< CIA-49> timotei * r45587 /trunk/utils/java/org.wesnoth.wml.ui/src/org/wesnoth/ui/labeling/wmldoc/ (WMLDocHandler.java WMLDocTag.java): 20100814 10:49:14< CIA-49> eclipse plugin: implement showing documentation for tags. 20100814 10:49:14< CIA-49> Currently just the 'description' from schema is supported 20100814 10:49:28< CIA-49> timotei * r45588 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/schema/SchemaParser.java: 20100814 10:49:28< CIA-49> eclipse plugin: remove the starting and ending quotes 20100814 10:49:28< CIA-49> when parsing description tag 20100814 10:49:41< CIA-49> timotei * r45589 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/builder/WesnothProjectBuilder.java: 20100814 10:49:41< CIA-49> eclipse plugin:disable auto regenerating build.xml 20100814 10:49:41< CIA-49> since we can have project that are located in data/ 20100814 10:49:54< CIA-49> timotei * r45590 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/ (ProjectUtils.java ResourceUtils.java WorkspaceUtils.java): 20100814 10:49:54< CIA-49> eclipse plugin: removed the 'user addons' project and instead 20100814 10:49:54< CIA-49> create projects for every directory that exists in data/campaigns 20100814 10:49:54< CIA-49> and in useraddons/data/add-ons 20100814 10:50:09< CIA-49> timotei * r45591 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/WorkspaceUtils.java: eclipse plugin: updated the guide message on setupworkspace 20100814 10:50:26< CIA-49> timotei * r45592 /trunk/src/game.cpp: 20100814 10:50:26< CIA-49> make '--preprocess' gain 90% more speed by processing 20100814 10:50:26< CIA-49> just files that contain macro definitions 20100814 10:50:35< CIA-49> timotei * r45593 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (handlers/TestHandler.java utils/WorkspaceUtils.java): 20100814 10:50:35< CIA-49> eclipse plugin: create a default working set 20100814 10:50:35< CIA-49> when the user setups the workspace 20100814 10:50:48< CIA-49> timotei * r45594 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/Activator.java: 20100814 10:50:48< CIA-49> eclipse plugin: delay the checking for conditions 20100814 10:50:48< CIA-49> in the activator and make sure the workbench 20100814 10:50:48< CIA-49> is up and running before checking them 20100814 10:51:02< CIA-49> timotei * r45595 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (3 files in 3 dirs): 20100814 10:51:02< CIA-49> eclipse plugin: make the new campaign and new empty projects 20100814 10:51:02< CIA-49> make use of the same method for creating the projects 20100814 10:51:11-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20100814 10:51:17< CIA-49> timotei * r45596 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/ProjectUtils.java: 20100814 10:51:17< CIA-49> eclipse plugin: disable the xtext nature until 20100814 10:51:17< CIA-49> it's really used. this should fix the 'no heap space' problems 20100814 10:51:29< CIA-49> timotei * r45597 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/wizards/ (2 files in 2 dirs): eclipse plugin: remove references to user addons project 20100814 10:51:42< CIA-49> timotei * r45598 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (9 files in 8 dirs): eclipse plugin: remove references to user addons project (part2) 20100814 10:52:01< CIA-49> timotei * r45599 /trunk/utils/java/ (28 files in 12 dirs): eclipse plugin: update grammar 20100814 10:52:20< CIA-49> timotei * r45600 /trunk/utils/java/ (4 files in 3 dirs): 20100814 10:52:20< CIA-49> eclipse plugin: add completion proposal 20100814 10:52:20< CIA-49> for enum attribute values. 20100814 10:52:20< CIA-49> Refactor some TagKey functionality 20100814 10:52:32< CIA-49> timotei * r45601 /trunk/utils/java/org.wesnoth.wml.ui/src/org/wesnoth/ui/contentassist/WMLProposalProvider.java: 20100814 10:52:32< CIA-49> eclipse plugin: fix the indentation used on 20100814 10:52:32< CIA-49> a direct tag child by subtracting 1 in case of rule proposal 20100814 10:52:47< CIA-49> timotei * r45602 /trunk/utils/java/org.wesnoth.wml.ui/src/org/wesnoth/ui/navigation/WMLHyperlinkHelper.java: 20100814 10:52:47< CIA-49> eclipse plugin: fix a possible situation when the 20100814 10:52:47< CIA-49> map_data doesn't contain quotes or '{' 20100814 10:52:58< CIA-49> timotei * r45603 /trunk/utils/java/org.wesnoth.wml/src/org/wesnoth/validation/WMLJavaValidator.java: eclipse plugin: add hooks for future code validators 20100814 10:53:13< CIA-49> timotei * r45604 /trunk/utils/java/org.wesnoth.wml.ui/src/org/wesnoth/ui/ (3 files in 2 dirs): 20100814 10:53:13< CIA-49> eclipse plugin: add priorities on proposal so we are 20100814 10:53:13< CIA-49> getting important stuff faster. 20100814 10:53:28< CIA-49> timotei * r45605 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/ProjectUtils.java: 20100814 10:53:29< CIA-49> eclipse plugin: fix the build.xml created by 20100814 10:53:29< CIA-49> specifing the project name as the target copy directory 20100814 10:53:42< CIA-49> timotei * r45606 /trunk/utils/java/eclipse_plugin/ (3 files in 3 dirs): 20100814 10:53:42< CIA-49> eclipse plugin: add menu entry for regenerating the 20100814 10:53:42< CIA-49> build files. Also, the add/remove nature is now 20100814 10:53:42< CIA-49> available on non-wesnoth projects too 20100814 10:53:55< CIA-49> timotei * r45607 /trunk/utils/java/eclipse_plugin/ (5 files in 3 dirs): eclipse plugin: add wizard for wesnot .cfg file 20100814 10:54:10< CIA-49> timotei * r45608 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/ProjectUtils.java: 20100814 10:54:10< CIA-49> eclipse plugin: fix the creation of projects when both 20100814 10:54:10< CIA-49> description and handle are null 20100814 10:54:23< CIA-49> timotei * r45609 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/wizards/ (4 files in 2 dirs): 20100814 10:54:23< CIA-49> eclipse plugin: add a checkbox for allowing the user 20100814 10:54:23< CIA-49> select whether creting or not the '_server.pbl' file 20100814 10:54:41< CIA-49> timotei * r45610 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/builder/WesnothProjectBuilder.java: 20100814 10:54:41< CIA-49> eclipse plugin: optimize the building by reading 20100814 10:54:41< CIA-49> the defines file only at the end of the build 20100814 10:54:54< CIA-49> timotei * r45611 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (8 files in 6 dirs): eclipse plugin: convert HashMap to Map 20100814 10:55:07< CIA-49> timotei * r45612 /trunk/utils/java/org.wesnoth.wml.ui/src/org/wesnoth/ui/navigation/WMLHyperlinkHelper.java: 20100814 10:55:07< CIA-49> eclipse plugin: fix the regex replacing in the path 20100814 10:55:07< CIA-49> by replacing '\' with '/' 20100814 10:55:25< CIA-49> timotei * r45613 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (Activator.java utils/PreprocessorUtils.java): 20100814 10:55:25< CIA-49> eclipse plugin: optimize preprocessing by saving 20100814 10:55:25< CIA-49> already "preprocessed files"'s timestamps to disk 20100814 10:55:25< CIA-49> and load them at startup 20100814 10:55:36< CIA-49> timotei * r45614 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (8 files in 4 dirs): 20100814 10:55:36< CIA-49> eclipse plugin: make 'PreprocessorUtils' a singleton 20100814 10:55:36< CIA-49> thus allow lazy loading of file timestamps improving 20100814 10:55:36< CIA-49> plugin's startup time 20100814 10:55:50< CIA-49> timotei * r45615 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/Activator.java: 20100814 10:55:51< CIA-49> eclipse plugin: ensure all plugin settings are 20100814 10:55:51< CIA-49> successfully saved by terminating the plugin as late 20100814 10:55:51< CIA-49> possible 20100814 10:56:04< CIA-49> timotei * r45616 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/utils/PreprocessorUtils.java: 20100814 10:56:04< CIA-49> eclipse plugin: handle the case when no 20100814 10:56:04< CIA-49> file with timestamps is createdd 20100814 10:56:19< CIA-49> timotei * r45617 /trunk/utils/java/eclipse_plugin/src/wesnoth_eclipse_plugin/ (5 files in 3 dirs): 20100814 10:56:19< CIA-49> eclipse plugin: 20100814 10:56:19< CIA-49> allow the user to reload cached defines 20100814 10:56:19< CIA-49> allow the user to choose whether to create or not 'build.xml' 20100814 10:56:32< CIA-49> timotei * r45618 /trunk/utils/java/eclipse_plugin/changelog: eclipse plugin: update the changelog 20100814 11:08:08< boucman> gabba: in recall::execute, you seem to alway succeed, what if there isn't enough money ? is the move invalidated/removed earlier, or is thit considered a success anyway ? 20100814 11:09:26< gabba> boucman: well, you can't create the planned recall in the first place if you don't have enough money. But, 20100814 11:10:24< boucman> hmm yes, even with execute, you can't get an impossible situation that way (assuming WML does nothing weird) 20100814 11:10:27< gabba> you might have found a loophole in my logic. If you define planned recalls, then spend money some other way, I don't do anything even if the total of planned recalls exceeds your available money. 20100814 11:11:12< gabba> This said I believe the code that checks if the player has enough money runs when we execute the planned recall, so there's no real bug there. 20100814 11:11:35< boucman> you check that (sum of money planned to be spent < (current gold) via refusing to create planned recalls, so you should be fine except for WML 20100814 11:12:33< boucman> well, not in recall::execute maybe in menu_handler::do_recall, but recall::execute will always return true 20100814 11:12:57< gabba> returning true just means the action gets deleted, though 20100814 11:13:09< boucman> oh, right... 20100814 11:13:19< boucman> in that case we should be fine 20100814 11:13:36-!- dtiger [~dtiger@dynamic-vpdn-91-149-190-114.telecom.by] has quit [Remote host closed the connection] 20100814 11:14:33-!- dtiger [~dtiger@dynamic-vpdn-91-149-190-114.telecom.by] has joined #wesnoth-dev 20100814 11:16:03< timotei> fendrin: hi 20100814 11:21:04< CIA-49> ivanovic * r45619 /trunk/ (5 files in 5 dirs): updated Chinese (Traditional) and Indonesian translation 20100814 11:21:07< CIA-49> ivanovic * r45620 /branches/1.8/ (6 files in 5 dirs): updated Chinese (Traditional) and Indonesian translation 20100814 11:23:25< boucman> gabba: there might be a simpler way to remove invalid actions in validate_visitor::validate_actions (no big deal, just mentionning) remember the index of actions to remove then remove them in revert order (starting by the end) so the index stay correct all along 20100814 11:25:18< gabba> boucman: actually, if I remember well that piece of code, the best would be to remove them as I go, updating the iterator every time by using the one the erase() method returns. It's harder to get right though. 20100814 11:25:44< boucman> agreed 20100814 11:26:20< CIA-49> silene * r45621 /trunk/src/multiplayer_connect.cpp: Fixed waiting label being overwritten. 20100814 11:27:30< gabba> boucman: feel free to insert a todo there if I haven't yet 20100814 11:27:54< boucman> I have troubles understanding how it works though... for action N to check validity you should have all previous valid actions applied, but I don't see where that's done... 20100814 11:27:58< boucman> will do 20100814 11:29:40< gabba> boucman: it works as you said, see for instance validate_visitor.cpp:134 20100814 11:30:06< CIA-49> timotei * r45622 /trunk/utils/java/ (190 files in 45 dirs): eclipse plugin: rename 'wesnoth_eclipse_plugin' to 'org.wesnoth' 20100814 11:30:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds] 20100814 11:30:13-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100814 11:32:17< boucman> oh, I had missed that validate_visitor inherited from mapbuilder 20100814 11:33:35< fendrin> timotei: hi 20100814 11:34:51< CIA-49> timotei * r45623 /trunk/utils/java/ (219 files in 41 dirs): it seems git forgot I've changed the directory name too 20100814 11:35:56-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20100814 11:36:10< timotei> fendrin: I've done a couple of fixes 20100814 11:36:13< timotei> Crab_: hi 20100814 11:36:21< timotei> Crab_: I think you can start the plugin now :P 20100814 11:36:29< timotei> Crab_: you are launching a RCP application? 20100814 11:37:01< Crab_> timotei: ok, i'll try (in a few minutes) 20100814 11:37:08< timotei> Crab_: take your time 20100814 11:37:18< timotei> fendrin: I'm gonna work now on those completion stuff 20100814 11:37:21< timotei> fendrin: variables, events 20100814 11:37:22< timotei> :) 20100814 11:37:28< timotei> fendrin: hope it will be easy as I think 20100814 11:42:20-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev 20100814 11:47:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100814 11:50:12-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds] 20100814 11:51:14< CIA-49> boucman * r45624 /trunk/src/whiteboard/validate_visitor.cpp: add a quick todo 20100814 11:57:06-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20100814 11:58:07-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20100814 12:03:04< CIA-49> gabba * r45625 /trunk/src/whiteboard/recruit.hpp: Whiteboard/recruit: added get_recruit_hex() method 20100814 12:03:11< CIA-49> gabba * r45626 /trunk/src/whiteboard/ (manager.cpp manager.hpp): Whiteboard/manager: added allow_leader_to_move method 20100814 12:03:18< CIA-49> gabba * r45627 /trunk/src/mouse_events.cpp: Whiteboard: display a warning and prevent leader to move away from the keep if there are some planned actions left. 20100814 12:03:24< CIA-49> gabba * r45628 /trunk/src/ (8 files in 2 dirs): Whiteboard: last planned move of a unit now uses the ghosted animation, while intermediate moves use disabled_ghosted. Also, changed a few methods in side_actions to use pointers instead of references. 20100814 12:04:09< gabba> darn, r45627 should say "if there are some planned recruits left" 20100814 12:04:31< gabba> boucman: done! 20100814 12:04:49< boucman> thx, updating... 20100814 12:05:17< gabba> boucman: I still have to do the checks before reordering, wrt recruits and recall, but that'll wait for tomorrow 20100814 12:05:43< fendrin> timotei: It is not compiling anymore for me. 20100814 12:05:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100814 12:05:59< fendrin> timotei: "EditorUtils cannot be resolved" 20100814 12:06:08< timotei> fendrin: yes. because I've renamed the folders 20100814 12:06:22< gabba> bye boucman & all 20100814 12:06:25< timotei> eclipse_plugin is no org.wesnoth 20100814 12:06:29< timotei> so import that project 20100814 12:06:32< fendrin> timotei: okay 20100814 12:06:48< timotei> I've changed the names to keep the consistency 20100814 12:06:55-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20100814 12:09:47< CIA-49> fendrin * r45629 /trunk/src/ (generate_report.cpp time_of_day.cpp time_of_day.hpp): Made the new time of day alignment hidden in the time of day tooltip if the liminal alignment is not supported by this tod. 20100814 12:09:51< fendrin> ^noy, zookeeper 20100814 12:10:05< fendrin> wesbot: seen esr? 20100814 12:10:05< wesbot> fendrin: The person with the nick esr last spoke 2d 15h ago. 1d 11h ago was here and on the channel #wesnoth-umc-dev with the message: Ping timeout: 245 seconds 20100814 12:10:07-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20100814 12:10:42< gabba> boucman: damn, I forgot to send the message to the mailing list asking for testing. Didn't have time with all the coding. 20100814 12:16:54< gabba> boucman: I've updated a bit http://wesnoth.pastebin.com/bsMP6YVV : I'd appreciate if you could post it to the ML this morning, so we at least get some last-minute testing from devs. If people test today I can fix some bugs on Sunday. 20100814 12:17:00-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20100814 12:19:11< fendrin> timotei: "org.wesnoth.parser cannot be resolved to a type" 20100814 12:19:24< timotei> fendrin: did you refresh your projects? 20100814 12:19:33< timotei> and also, clean them 20100814 12:19:50< fendrin> yes 20100814 12:19:56< fendrin> done both 20100814 12:21:02-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection] 20100814 12:21:03< timotei> where you got that error in? 20100814 12:21:21< timotei> there is no org.wesnoth.parser.. 20100814 12:21:52< fendrin> AbstractWMLUiModule.java 20100814 12:22:42< timotei> oh, did you try to generate the grammar again? 20100814 12:23:18< fendrin> timotei: No, should I? 20100814 12:23:22< timotei> no 20100814 12:23:26< timotei> it's weird 20100814 12:23:32< fendrin> timotei: I have removed everything and did a new checkout. 20100814 12:23:40< timotei> it worked? 20100814 12:23:45< fendrin> timotei: No.+ 20100814 12:23:48< timotei> :| 20100814 12:23:51< timotei> let'me check something 20100814 12:24:29< timotei> I'll checkout a new one too 20100814 12:24:37< timotei> Just allow me 2 mins 20100814 12:26:11< timotei> (ok, building) 20100814 12:32:50< CIA-49> silene * r45630 /trunk/src/ (5 files in 5 dirs): Fixed header dependencies and removed unused broken headers. 20100814 12:32:52< CIA-49> silene * r45631 /trunk/src/ (SConscript gui/dialogs/icon_message.cpp): Removed empty file. 20100814 12:35:05< timotei> fendrin: no problems compiling... 20100814 12:35:12< timotei> fendrin: did you update up to version... 20100814 12:35:20< timotei> it worked? 45623? 20100814 12:35:52< Crab_> silene: are you sure that using  #include "config.hpp" instead of  #include "../../config.hpp" is a good thing ? stuff in /src/ai generally uses the second style, and there are files with same names (e.g., actions.hpp) which will be ambiguous if entire /src/ai is converted to first style. 20100814 12:36:04< fendrin> timotei: I am uptodate. 20100814 12:36:13< timotei> fendrin: that is very weird 20100814 12:36:25< timotei> fendrin: does svn complain about uncommited files? 20100814 12:36:55< silene> Crab_: then we won't change the ambiguous files; but i always test my changes and this one worked 20100814 12:37:08< fendrin> timotei: yes 20100814 12:37:24< timotei> then... it something from your side 20100814 12:37:25< timotei> cleanup them 20100814 12:37:33< fendrin> timotei: Well there are files that are not known to the svn. 20100814 12:38:35< timotei> hmm 20100814 12:38:46< timotei> if there is anything in utils/java please delete them 20100814 12:38:51< fendrin> timotei: Which of the projects in java are needed? 20100814 12:38:53< timotei> as may interefere with plugin building 20100814 12:38:59< timotei> org.wesnoth.* 20100814 12:39:02< timotei> those 3 20100814 12:39:26< Crab_> silene: Yes, I know that it works for files with non-ambiguous names. It will only break if someone adds a /src/ai/composite/config.hpp or /src/ai/composite/foreach.hpp I just don't like the mix of styles. 20100814 12:40:00< fendrin> timotei: Okay, I had more. 20100814 12:40:18< Crab_> so, I was just wondering if there are any benefits in the conversion, that I've missed. 20100814 12:40:19< timotei> the other 2 are used for building the installer 20100814 12:40:26< timotei> plugin_feature and uodate_site 20100814 12:42:55< fendrin> timotei: Fine, it looks very good. 20100814 12:43:04< timotei> fendrin: what it looks very good? 20100814 12:43:27< fendrin> timotei: I am just browsing a scenario out of LoW. 20100814 12:43:37< fendrin> timotei: nice 20100814 12:43:47< timotei> out of LOW? you mean, opening an external file? 20100814 12:43:55< timotei> out of workspace? 20100814 12:44:22< fendrin> timotei: Out of workspace. The campaign has got it's own project. 20100814 12:44:28< timotei> ok 20100814 12:45:23< fendrin> timotei: The plugin did generate a campaign project for my ".svn" directory. That does not make much sense. 20100814 12:45:32< timotei> ha? 20100814 12:45:34< timotei> ops 20100814 12:45:36< timotei> right 20100814 12:45:41< timotei> thanks :)) 20100814 12:45:57< timotei> I think I should skipping dot files altogheter 20100814 12:46:09< fendrin> timotei: Yes, skip them. 20100814 12:46:45< fendrin> timotei: There are also some errors in the syntax highlighting. Can we discuss them right now? 20100814 12:46:57< timotei> fendrin: yes 20100814 12:47:34< fendrin> timotei: #textdomain wesnoth-low stays black. It should be in the same color as all other preprocesser commands. 20100814 12:47:56< timotei> yes 20100814 12:48:03< fendrin> timotei: preprocessor commands and comments are both colored in the same color. 20100814 12:48:20< timotei> I currently have just #textdomain and #define/#enddef as preprocessor command 20100814 12:48:28< timotei> I need to add the rest of them today 20100814 12:54:59< fendrin> timotei: file includes are colored strangely. 20100814 12:55:05< timotei> yes 20100814 12:55:20< timotei> {~addons/asdasd} ? 20100814 12:55:32< timotei> fendrin: ^ 20100814 12:55:37< fendrin> {campaigns/Legend_of_Wesmere/utils/deaths.cfg} 20100814 12:55:45< timotei> aha 20100814 12:56:02< fendrin> only the word "campaigns" is painted orange. The rest is black. 20100814 12:56:16< fendrin> {./07_Elves_last_stand_utils.cfg} 20100814 12:56:20< timotei> yes I know 20100814 12:56:26< fendrin> The "." is causing an error. 20100814 12:56:37< timotei> I haven't handled yet this cases. since I was going to redo the grammar.. 20100814 12:56:38< timotei> :) 20100814 12:56:52< timotei> FYI, almost everything depends on the grammar 20100814 12:57:21< fendrin> recruit={ELVES}, Elvish Captain, Elvish Hero, Elvish Sorceress 20100814 12:57:35< timotei> oh an 20100814 12:57:36< timotei> man* 20100814 12:57:36< fendrin> It seems not to handle the macro call right. 20100814 12:57:41< timotei> well of course 20100814 12:58:01< timotei> I'm thinking of making {macr call} hidden 20100814 12:58:08< timotei> though I don't know how it will work 20100814 12:58:14< timotei> there are just too much things to take in account 20100814 12:58:20< timotei> because of the preprocessor stuff 20100814 12:58:33< timotei> that allows everything to be writtent everywhere 20100814 12:58:35< timotei> I wonder if: 20100814 12:58:44< timotei> {id}=02_scenario is even possible 20100814 12:59:08< fendrin> timotei: Sure, it is. 20100814 12:59:12< timotei> ... 20100814 12:59:40< timotei> well, I'll ask if I may implement my own parser, even with that I won't get a so better error recovering stuff 20100814 13:00:59< Crab_> Ivanovic: can you add a 'whiteboard' category on gna ? 20100814 13:01:08< Ivanovic> sure 20100814 13:01:13< Crab_> thanks 20100814 13:01:22< fendrin> Ivanovic: And one for the eclipse plugin as well please. 20100814 13:01:27< timotei> there is already one :P 20100814 13:01:33< fendrin> cool 20100814 13:02:03< Ivanovic> Crab_: done 20100814 13:02:04< fendrin> timotei: I am not sure about the own parser rewrite. 20100814 13:02:08< Crab_> thanks 20100814 13:02:13< timotei> fendrin: why/what? 20100814 13:02:43< timotei> I'm thinking of doing things like: 20100814 13:02:57< timotei> WMLTag: '[' name='TAG_NAME' ']' ; 20100814 13:03:11< timotei> and in my lexer, if the tag is a valid tag_name, I'll output: TAG_NAME 20100814 13:03:22< timotei> though, that I don't think will work good enough 20100814 13:03:27< timotei> damn 20100814 13:06:41-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev 20100814 13:10:22< fendrin> timotei: Can't you just resolve macros at parsing? 20100814 13:10:38< timotei> in which way? 20100814 13:11:05< fendrin> timotei: If you discover one, feed the syntax checker with the macro instead of the call. 20100814 13:14:43-!- Octalot [~noct@cpc2-hitc1-0-0-cust727.hitc.cable.virginmedia.com] has joined #wesnoth-dev 20100814 13:16:50< fendrin> timotei: Are you still around? 20100814 13:16:54< timotei> yes 20100814 13:17:00< timotei> I'm thinking 20100814 13:17:13< timotei> so basically... expand the macro? 20100814 13:18:35< timotei> ok, time for a big break 20100814 13:18:38< timotei> I'll got get some sleep 20100814 13:18:41< timotei> see you later 20100814 13:19:01-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: Leaving] 20100814 13:21:30< boucman> Crab_: thx for the testing 20100814 13:25:50< Crab_> boucman: np. unfortunately, on turn 2 I've hit the same assertion failure as silene had. 20100814 13:25:57< Crab_> boucman: so, testing stopped, as for now :) 20100814 13:27:04< Crab_> boucman: usability-wise, two issues: 1) hard to amend a move - e.g. I can't click the unit or the 'ghost' unit and re-target it - it need to cancel the move first and only then make a new move 2) hard to see which units have already move planned for them - a change of color for the orb or smth like that, would be nice. 20100814 13:27:06< boucman> havn't heard of that assert, is it WB related ? 20100814 13:27:10< Crab_> boucman: yes 20100814 13:27:28< Crab_> https://gna.org/bugs/index.php?16424 20100814 13:27:51< boucman> Crab_: do you have gabba's latest commit (which make final units more visible) ? 20100814 13:28:21< Crab_> yes 20100814 13:28:21< boucman> Crab_: the report is not clear, you press tab to activate or deactivate WB ? 20100814 13:28:47< Crab_> boucman: you simply attack with the WB enabled, using tab-click to do so. 20100814 13:28:52< boucman> k... both remarks are interesting... 20100814 13:29:22< boucman> ok, it could also have been pressing tab to get back to normal mode when :wb was activated 20100814 13:29:43< Crab_> boucman: I reproduced in a different way, with no 'tab' involved - turn 1: move unit near enemy, enemy moves next to me , turn 2: attack (without tab, simply 'plan a attack move' while unit was net to enemy). boom. 20100814 13:29:50< Crab_> s/net/next 20100814 13:29:58< Crab_> but the same assertion was hit 20100814 13:30:49< Crab_> about 'hard to see which units have already move planned for them' - it's important when units are crowded, so you can't see where each arrow starts. 20100814 13:30:52< boucman> kay 20100814 13:31:20< Crab_> the 'final' units are visible ok, it's just hard to see which units are moving to those final units, and which still haven't got a plan 20100814 13:31:29< Crab_> also, the in-game help doesn't say how to execute all 20100814 13:31:48< boucman> ok 20100814 13:31:59< boucman> i'm not sure if there is still an execute all key... 20100814 13:32:15< Crab_> ok 20100814 13:40:22-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit [] 20100814 13:59:27-!- stikonas_ [~and@ctv-213-164-99-190.vinita.lt] has joined #wesnoth-dev 20100814 13:59:27-!- stikonas_ [~and@ctv-213-164-99-190.vinita.lt] has quit [Changing host] 20100814 13:59:27-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20100814 14:00:42-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds] 20100814 14:01:06-!- Gambit [~Gambit@unaffiliated/gambit] has joined #wesnoth-dev 20100814 14:03:32-!- stikonas_ is now known as stikonas 20100814 14:13:33-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20100814 14:15:10-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20100814 14:15:34-!- stikonas_ is now known as stikonas 20100814 14:23:15< fendrin> Crab_: placement=leader is a bit difficult to use when placing olurfs unit into battle. 20100814 14:23:38< fendrin> Crab_: We have more than one leader around at that time. 20100814 14:23:40< Crab_> fendrin: yes, for that he needs to be in his own side for a while 20100814 14:23:58< Crab_> fendrin: x,y= olurf's x and y will work fine 20100814 14:25:36-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev 20100814 14:29:22-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds] 20100814 15:00:35-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20100814 15:16:05< CIA-49> fendrin * r45632 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/14_Human_Alliance.cfg: LoW 14: Add some extra speech to Aldin. 20100814 15:16:56< CIA-49> fendrin * r45633 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/07_Elves_last_stand.cfg: LoW 7: Made the player selecting the place where Olurf appears. 20100814 15:16:58< fendrin> Crab_: ^ 20100814 15:18:01< CIA-49> fendrin * r45634 /trunk/data/campaigns/Legend_of_Wesmere/maps/Kalian.map: 20100814 15:18:01< CIA-49> LoW Kalian.map: 20100814 15:18:01< CIA-49> New terrain updates. 20100814 15:19:31< CIA-49> fendrin * r45635 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/07_Elves_last_stand_utils.cfg: LoW 07 utils: Redefined the location of Olurf's party. 20100814 15:20:35< CIA-49> fendrin * r45636 /trunk/data/campaigns/Legend_of_Wesmere/utils/abilities.cfg: LoW: Added a file for campaign specific abilities. 20100814 15:21:33< CIA-49> fendrin * r45637 /trunk/data/campaigns/Legend_of_Wesmere/utils/_main.cfg: LoW: Included the abilities file. 20100814 15:22:10< CIA-49> fendrin * r45638 /trunk/data/campaigns/Legend_of_Wesmere/utils/characters.cfg: LoW: Assigned new abilities to Cleodil. 20100814 15:24:43< Crab_> fendrin: great 20100814 15:25:37< fendrin> Crab_: There is already some feedback to the new low14 ai: http://www.wesnoth.org/forum/viewtopic.php?p=449359#p449359 20100814 15:25:46< fendrin> Crab_: See the spoiler. 20100814 15:27:24< Crab_> yes, I see 20100814 15:27:29< Crab_> thanks for the link 20100814 15:29:23-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20100814 15:29:40< fendrin> hi timotei 20100814 15:29:41< timotei> hi 20100814 15:29:57< timotei> hey fendrin 20100814 15:31:55< boucman> wesbot: seen alink 20100814 15:31:55< wesbot> boucman: The person with the nick alink last spoke 16h 45m ago. 13h 18m ago they left with the message: Remote host closed the connection 20100814 15:34:23< CIA-49> fendrin * r45639 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/07_Elves_last_stand.cfg: LoW: Corrected all wmllint reported errors but the ones reporting the missing translation mark of stub strings. 20100814 15:38:38-!- King_Elendil [~King_Elen@75.143.235.104] has joined #wesnoth-dev 20100814 15:42:13< fendrin> Crab_: The player does have the option between 2 entry points for Olurf. The old one and another one in the NorthWest corner. 20100814 15:42:26< Crab_> ok.more is better ) 20100814 15:43:12-!- King_Elendil_ [~King_Elen@75.143.235.104] has joined #wesnoth-dev 20100814 15:43:29-!- King_Elendil [~King_Elen@75.143.235.104] has quit [Read error: Connection reset by peer] 20100814 15:43:30-!- King_Elendil_ is now known as King_Elendil 20100814 15:45:46-!- King_Elendil [~King_Elen@75.143.235.104] has quit [Client Quit] 20100814 15:58:03< Gambit> Is WMLlint capable of upgrading a 1.0 campaign to 1.8 standards? 20100814 16:00:13< fendrin> Gambit: AFAIK it's not possible in a row. You will need all inbetween wmllint versions to upgrade. 20100814 16:00:27< fendrin> Gambit: Which campaign are you talking about? 20100814 16:00:30< Gambit> fendrin: Thanks. That explains at least part of this person 20100814 16:00:34< Gambit> 's problems. 20100814 16:00:52< fendrin> Gambit: And don't do expect wmllint to do the whole job. 20100814 16:01:03< fendrin> Gambit: There will be some handwork to do left. 20100814 16:01:04< Gambit> http://forums.wesnoth.org/viewtopic.php?p=449623#p449623 20100814 16:01:10< Gambit> ^lol 20100814 16:04:26< fendrin> Gambit: And I don't even know if there is a wmllint version for 1.2. 20100814 16:04:44< fendrin> Gambit: But maybe the 1.4 version is able to convert 1.0 content directly to 1.4. 20100814 16:04:59< fendrin> Gambit: But it seems that the user isn't able to run wmllint at all. 20100814 16:05:28< Gambit> Yeah. I think they're using a machine translator. 20100814 16:05:44< Gambit> Also I'm not good at wmllint myself, so it's the blind leading the blind. 20100814 16:06:03< Gambit> And the two blind people have to speak through garbled kiddy walkie talkies. 20100814 16:06:38< fendrin> Gambit: wmllint is best called against data/core and the whole campaign at once. It will most likely not do well if called against a single file. 20100814 16:10:49-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev 20100814 16:15:08-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20100814 16:15:39< CIA-49> silene * r45640 /trunk/src/ (variable.cpp variable.hpp): Removed unused assignment operator for class vconfig. 20100814 16:15:45< CIA-49> silene * r45641 /trunk/src/unit_frame.cpp: Removed unused incorrect checks for buffer overflow. 20100814 16:15:53-!- King_Elendil [~King_Elen@75.143.235.104] has joined #wesnoth-dev 20100814 16:16:14-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has quit [Ping timeout: 264 seconds] 20100814 16:18:32-!- King_Elendil [~King_Elen@75.143.235.104] has quit [Read error: Connection reset by peer] 20100814 16:24:24< timotei> wow, IDialogSettings is so much cooler than Properties 20100814 16:24:25< timotei> :D 20100814 16:24:51< timotei> but still, I haven't a much simpler method in Java like in C# for serialization objects 20100814 16:25:19< timotei> Crab_: do you know any? ^ 20100814 16:25:58< Crab_> there are libs to serialize to xml 20100814 16:26:15< timotei> Crab_: the one in C# I am talking about is the XMLSerializer.serialize/deserialize. 3 lines of code 20100814 16:27:40< fendrin> timotei: In java you can serialize every object to disc if it implements the interface serializable. 20100814 16:28:08< timotei> hmm 20100814 16:28:49< timotei> oh, right. missed that 20100814 16:56:31-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.] 20100814 17:04:46< Gambit> Does trunk have prerequisites that 1.8 didn't? 20100814 17:05:02< timotei> in which way prerequisites? 20100814 17:05:06< timotei> dependecies? 20100814 17:05:12< Gambit> I can't get it to compile. Something about "boost system library" 20100814 17:05:14< timotei> well, ana has 20100814 17:05:16< timotei> yes 20100814 17:05:19< timotei> you're still on ubuntu? 20100814 17:05:23< Gambit> Yes 20100814 17:05:32< timotei> install boost thread and system 20100814 17:05:49< timotei> actually on configure it should tell you exactly what boost library is missing ;) 20100814 17:06:35< Gambit> I don't actually understand this stuff. I just do what the wiki tells me. :$ 20100814 17:07:35< Gambit> timotei: Thanks. I found it. 20100814 17:09:40< Gambit> Cool. It's doing its thing now. 20100814 17:11:03< boucman> Gambit: do you want a quick tuto on WB ? we are looking for early testers before 1.9.0 20100814 17:11:09< CIA-49> ivanovic * r45643 /branches/1.8/ (5 files in 4 dirs): updated Czech translation 20100814 17:11:14< CIA-49> ivanovic * r45642 /trunk/po/ (4 files in 4 dirs): updated Czech translation 20100814 17:11:19-!- eleazar [~eleazar@ppp-70-226-203-255.dsl.spfdil.ameritech.net] has quit [Disconnected by services] 20100814 17:12:45< Gambit> boucman: whiteboard? 20100814 17:12:49< timotei> yes 20100814 17:12:49< Gambit> Sure 20100814 17:13:00< boucman> the new arrow thingy we are developing with gabba 20100814 17:13:02< timotei> actually, I should compile too 20100814 17:13:32< boucman> Gambit: just ping me once you're done compiling 20100814 17:24:46< Gambit> boucman: A whole second round trip? :P 20100814 17:25:13< Gambit> boucman: lame IRC jokes aside, it's done now. 20100814 17:25:49-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20100814 17:28:19-!- wesbot changed the topic of #wesnoth-dev to: 1.9.0 planned for Monday (2010-08-16), 19:00 GMT | 140 bugs, 287 feature requests, 13 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100814 17:29:13< boucman> k, so did you plan sp or mp (whiteboard is only available when there is no complicated WML at the moment, so MP or custom games vs AI but no campaigns) 20100814 17:30:02< boucman> Gambit: ^^ 20100814 17:30:13< Gambit> MP 20100814 17:30:20< boucman> k, good 20100814 17:31:10< boucman> so, the whiteboard is a way for you to plan your moves by "drawing arrows" on the map 20100814 17:31:25< boucman> to enable whiteboard you type :wb 20100814 17:31:41< boucman> at this point, you have two keyboard shortcuts to know 20100814 17:32:07< timotei> help 20100814 17:32:08< timotei> http://wiki.wesnoth.org/VariablesWML 20100814 17:32:26< boucman> "y" will execute the move you have planned for the selected unit (if you have a selected unit) or the first planned move if you don't have any 20100814 17:32:27< timotei> at: Variables substitution ... why the macro: {DEBUG_MSG $x1} # "1", since that's the x coordinate where this moveto event triggers 20100814 17:32:38< timotei> where is $x defined? 20100814 17:32:40< timotei> fendrin: ^ 20100814 17:32:43< boucman> and "h" will delete the move for the selected unit, allowing you to plan another one 20100814 17:32:59< boucman> other (less usefull, but still good to know) shortcuts 20100814 17:33:09< boucman> pgup/pgdn allow you to reorder your actions 20100814 17:33:28< boucman> tab allow you to disable whiteboard entirely (to execute an action "the normal way" 20100814 17:33:56< boucman> Gambit: and don't hesitate to ask questions at first, and report what you think of the whole thing 20100814 17:40:17< boucman> Gambit: crash ? 20100814 17:40:41< Gambit> boucman: Nopw. 20100814 17:40:43< Gambit> *Nope 20100814 17:40:49< Gambit> I just quit. 20100814 17:40:52< boucman> k 20100814 17:41:29< Gambit> It's cool. 20100814 17:41:35< boucman> thx :) 20100814 17:41:55< boucman> feel free to play some more and report any c&c you have 20100814 17:42:19< Gambit> Well I have one completely unrelated urge to be able to draw on the screen. 20100814 17:43:17-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Remote host closed the connection] 20100814 17:43:28< boucman> hehe 20100814 17:44:55< fendrin> timotei: $x is most likely not defined. 20100814 17:45:18< fendrin> timotei: But $x1 is defined. 20100814 17:45:30< fendrin> Or is so hopefully 20100814 17:45:57< fendrin> For example does an event define x1 to the primary unit that is involved in the event. 20100814 17:51:16< timotei> ops. trunk crashed 20100814 17:52:18< timotei> silene, boucman: any clue on this? : http://wesnoth.pastebin.com/K9h7y85E 20100814 17:53:12< boucman> timotei: nothing obvious... can your reproduce easily ? 20100814 17:53:21< timotei> one sec 20100814 17:53:31< timotei> yes 20100814 17:53:36< timotei> multiplayer->local game 20100814 17:53:44< timotei> and fist scenario: caves of basilisk 20100814 17:53:59< boucman> k 20100814 17:55:18< timotei> brb going to buy watermelons :D 20100814 18:00:08-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has joined #wesnoth-dev 20100814 18:01:53-!- eleazar_ [~eleazar@ppp-70-226-203-255.dsl.spfdil.ameritech.net] has joined #wesnoth-dev 20100814 18:07:16< timotei> beck 20100814 18:07:29< timotei> boucman: managed to reproduce? 20100814 18:07:46< timotei> on second map worked 20100814 18:09:05< boucman> nope, is it immediately when entering the map 20100814 18:09:06< boucman> ? 20100814 18:10:06< timotei> after pressing start 20100814 18:10:23< timotei> hmm 20100814 18:10:30< timotei> the arrows look a little bit too big:( 20100814 18:14:28< silene> timotei: i can't reproduce it, not even with valgrind 20100814 18:18:50< boucman> timotei: wb arrows ? 20100814 18:19:06< timotei> silene: what is valgrind? 20100814 18:19:09< boucman> maybe it's windows only... 20100814 18:19:13< timotei> well, maybe it was just something from me 20100814 18:19:20< timotei> boucman: yes. wb arrows 20100814 18:19:37< silene> timotei: an emulator that checks every memory access, every system call, and so on 20100814 18:19:46< boucman> timotei: I made these yesterdday to have "something useable" until a real artist works on it :P 20100814 18:19:57< boucman> feel free to provide better alternatives ;) 20100814 18:21:10< silene> boucman: valgrind is not happy with side_actions::find_last_action_of, and i must admit that i'm not really fond of "begin() - 1" either 20100814 18:22:29< boucman> silene: let me look 20100814 18:23:49< silene> (note that "begin() - 1" is probably not what valgrind complains about line 424, so there must be another mistake there) 20100814 18:23:58< boucman> well, it makes sense... I agree the legibility isn't good, but we are looking at the list of action backward, 20100814 18:24:20< boucman> the list of action is not a STL structure, despite having a begin() and end() with similar semantics 20100814 18:25:00< boucman> not sure what valgind is unhappy with, then... 20100814 18:25:26< silene> boucman: since when did std::deque stop begin a stl structure? 20100814 18:25:43< silene> being* 20100814 18:26:23< silene> computing begin() - 1 for a deque is terribly wrong 20100814 18:26:41< boucman> I must be confused, but I don't see where side_action is a std::dequeue 20100814 18:26:54< silene> typedef std::deque action_queue; 20100814 18:27:06< silene> typedef action_queue::iterator iterator; 20100814 18:27:12< silene> iterator begin() { return actions_.begin(); } 20100814 18:27:22< boucman> ok, I follow you now 20100814 18:28:39< silene> you would never think of computing begin() - 1 for a list, it's the same for a deque 20100814 18:28:40< boucman> silene: ok, and since we do have the rbegin and rend available, it's indeed wrong and easy to correct 20100814 18:29:18< boucman> silene: yes, I had missed the deque thing, originally we intended not to use STL structures here, and I thought it was still the case 20100814 18:29:31< boucman> i'll add a note in there to discuss with gabba when he gets back 20100814 18:36:18< timotei> oh, valgrind is ... linux/mac only :( 20100814 18:37:08< timotei> boucman: why can't I plan outside my move range? 20100814 18:37:26< boucman> because your units can't move there :P 20100814 18:37:42< boucman> at this point we had to disable multiple turn planning, 20100814 18:37:49< timotei> hmm 20100814 18:37:51< boucman> however you can plan during your oponent's turn 20100814 18:38:00< timotei> well, I can reach there in 2 turns 20100814 18:38:00< boucman> (usefull in MP versus humans) 20100814 18:38:02< timotei> aah, ok 20100814 18:40:54< timotei> boucman: http://imagebin.org/109657 20100814 18:40:56< timotei> boucman: why? 20100814 18:42:13< boucman> good question :P 20100814 18:42:43< boucman> there seems to be a mixup in the arrow styles, i'll note it for gabba 20100814 18:44:40< timotei> hmm.. 20100814 18:44:49< timotei> and pgup/pgdown doesn't work everythime 20100814 18:45:24< timotei> if I let some planned moves, and end turn 20100814 18:45:27< boucman> timotei: oh ? I know it has weird interaction with recruit/recall/leader mvt but appart from that it's supposed to work fine... 20100814 18:45:29< timotei> next time I can't anymore 20100814 18:45:51< boucman> I don't understand what you mean 20100814 18:45:53< timotei> plan 3 actions 20100814 18:45:57< timotei> execute one 20100814 18:46:04< timotei> end turn without executing th 2 others 20100814 18:46:15< timotei> now you can't pgup/pgdown anymore 20100814 18:46:25< boucman> hmm weird 20100814 18:46:29< timotei> neither on already planned but nonexecuted, nor on the new planned 20100814 18:46:41< boucman> very weird indeed... 20100814 18:46:58< timotei> maybe he... resets some flag at end turn 20100814 18:47:27< boucman> maybe... I know that end turn wasn't easy to handle properly, but i'm not sure of the details 20100814 18:47:40< timotei> oh 20100814 18:47:49< timotei> well, I've just reported:) 20100814 18:47:58< boucman> and thx for that :) 20100814 19:03:11-!- Upthorn_ [~chatzilla@adsl-75-26-169-186.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:04:39-!- Upth [~ogmar@adsl-75-26-165-241.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds] 20100814 19:04:50-!- Upth [~ogmar@adsl-75-26-169-186.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:05:17-!- Upthorn [~chatzilla@adsl-75-26-165-241.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 258 seconds] 20100814 19:05:23-!- Upthorn_ is now known as Upthorn 20100814 19:06:01< timotei> silene: where can be used variables? 20100814 19:06:28< timotei> if I define a variable in a file, in what places I can use them, in current file? 20100814 19:06:45< timotei> it's the same a with a macro call? 20100814 19:07:35-!- Blueblaze [~Blueblaze@adsl-99-158-46-202.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20100814 19:10:44-!- Octalot [~noct@cpc2-hitc1-0-0-cust727.hitc.cable.virginmedia.com] has quit [Read error: Connection reset by peer] 20100814 19:11:27-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20100814 19:11:33< silene> timotei: variables can be used in any attribute values that appears inside [event] tags and their children (and a few other places); there is no such thing as defining a variable in wml; you can set their value, that's all 20100814 19:12:56-!- Octalot [~noct@cpc2-hitc1-0-0-cust727.hitc.cable.virginmedia.com] has joined #wesnoth-dev 20100814 19:13:46-!- Tigge [~tigge@c-94a672d5.015-28-73746f34.cust.bredbandsbolaget.se] has quit [Ping timeout: 248 seconds] 20100814 19:18:46< boucman> timotei: how did you manage to get that weird arrow, it looks good here... 20100814 19:19:17-!- Upthorn_ [~chatzilla@adsl-75-26-205-233.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:19:28-!- Upthorn [~chatzilla@adsl-75-26-169-186.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 258 seconds] 20100814 19:19:29-!- Upthorn_ is now known as Upthorn 20100814 19:21:01-!- Upth [~ogmar@adsl-75-26-169-186.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 276 seconds] 20100814 19:21:28-!- Upth [~ogmar@adsl-75-26-205-233.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:23:28-!- Upthorn_ [~chatzilla@adsl-75-26-206-60.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:25:59< boucman> Ivanovic: do you think it would be a good idea to ask packagers to package 1.9.0 in such a way that it doesn't disturb 1.8.x (i.e not the same directory, not the same config dir) so people can test it out without risking to lose their 1.8.0 games/settings and being able to have both installed simultaneously with no hassle ? 20100814 19:26:11-!- Upth [~ogmar@adsl-75-26-205-233.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 252 seconds] 20100814 19:26:11-!- Upthorn [~chatzilla@adsl-75-26-205-233.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 252 seconds] 20100814 19:26:26-!- Upthorn_ is now known as Upthorn 20100814 19:26:50-!- Upth [~ogmar@adsl-75-26-206-60.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20100814 19:29:09< timotei> boucman: don't ask me. I just pressed a lot of things 20100814 19:29:14< timotei> boucman: :)) and tried stuff 20100814 19:29:16< boucman> :P 20100814 19:29:39-!- billynux [~billy@wesnoth/developer/billynux] has joined #wesnoth-dev 20100814 19:29:39< timotei> I'm not so good at finding 'reproducible' bugs :D 20100814 19:30:20< timotei> silene: and that variable has the scope.. like macros? or it's visible everywhere? 20100814 19:31:32< timotei> fendrin, silene: for example, I've parsed a cfg file, and got a list of [set_variable(s)]. Now I need to figure it out where to add them to autcomplete proposals 20100814 19:31:40< timotei> fendrin, silene so inside [event] mainly 20100814 19:32:38< Gambit> For really big arrays, is it faster, slower, or the same to use [have_location]find_in=[/have_location] versus looping through and checking? 20100814 19:33:22< silene> timotei: yes; note also that the variable may come from a previous scenario 20100814 19:33:34< silene> Gambit: find_in will be faster 20100814 19:33:49< Gambit> Darn. Because it is extremely slow right now. 20100814 19:33:54< timotei> silene: ok. 20100814 19:34:46< Gambit> Like 1-2 minutes hanging. 20100814 19:35:00< silene> Gambit: are you sure that it's what is slow and not something else? 20100814 19:35:39< Gambit> Actually yeah it's not just that. What I have is: 20100814 19:36:14< Gambit> It stores all the ocean tiles. And then loops through them. For each one it stores adjacent ones, and then does a [have_location]find_in for hexes that aren't water. 20100814 19:36:25< silene> time to learn lua 20100814 19:36:31< Gambit> So it's running a ton of find_in's. 20100814 19:37:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100814 19:37:55< Gambit> silene: That'd be faster? 20100814 19:38:02< timotei> Gambit: working on Breaking Ground? 20100814 19:38:22< silene> Gambit: for your tidal system? it would be instant 20100814 19:38:27< Gambit> timotei: Actually no. I'm working on a tile on tile interaction add on. 20100814 19:38:40< timotei> pm me to test it when it's done :) 20100814 19:38:55< Gambit> timotei: Okay. See you next year then. :D 20100814 19:39:00< timotei> lol? 20100814 19:39:57< Gambit> timotei: Especially since I apparently have to learn a new language now... 20100814 19:40:10< timotei> fendrin, boucman, Ivanovic: the status of GSOC completion, should be already set on 16 August? or it's time till 20 August? 20100814 19:40:19< timotei> Gambit: it's not so.. hard 20100814 19:41:08< boucman> timotei: not sure what you mean... the "pencil down date" is the 16, i.e we will juge you on what you did before the 16 20100814 19:41:17< boucman> however we have until the 20 to do that :P 20100814 19:42:21< timotei> boucman: I was asking whether if we are doing things from 16 till 20 we can 'improve' our success chances :) 20100814 19:42:46< timotei> boucman: for example, I still have a LOT of things that can be improved/added 20100814 19:42:48< boucman> ok, so I have answered your question :) 20100814 19:43:06< timotei> ok 20100814 19:43:14< boucman> timotei: that's fine, crab is still working on his GSoC from last year :P 20100814 19:43:33< timotei> boucman: who was crab's mentor?:) 20100814 19:43:38< boucman> I was 20100814 19:43:39< timotei> if he had any :D 20100814 19:43:44< timotei> nice:P 20100814 19:44:16< boucman> hehe I didn't have good students every year (my first student actually failed his finals) but sometime we are lucky 20100814 19:44:27< timotei> :( 20100814 19:44:52< timotei> why did he failed? didn't he finished doing all required things? too many bugs? 20100814 19:45:34< boucman> he basically worked much less after mid-term, and thus went much slower than expected... I felt he didn't put in the required effort 20100814 19:45:46< timotei> oh 20100814 19:46:01-!- eleazar_ [~eleazar@ppp-70-226-203-255.dsl.spfdil.ameritech.net] has left #wesnoth-dev [] 20100814 19:46:21-!- eleazar_ [~eleazar@ppp-70-226-203-255.dsl.spfdil.ameritech.net] has joined #wesnoth-dev 20100814 19:47:30< timotei> since what year did wesnoth participatein gsoc? 20100814 19:47:40< boucman> it's our third year 20100814 19:47:55< timotei> nice 20100814 19:58:13-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20100814 20:06:01< Gambit> silene: wesnoth.set_terrain does not take a layer argument? 20100814 20:07:30< fendrin> boucman: What is going to happen if a final fails? No money? 20100814 20:08:54< boucman> fendrin: yes, you still get the part for mid-term, IIUC, though 20100814 20:14:26< anonymissimus> Gambit: apparently not 20100814 20:14:57< anonymissimus> but you could try wesnoth.fire("terrain", ...) and then define a layer in the wml table delivered 20100814 20:15:04< Gambit> Yeah. 20100814 20:15:32< anonymissimus> but for the thing you're going to do lua is certainly a good idea 20100814 20:15:40< Gambit> But if I'm firing wml tags for everything, why/how is it faster? 20100814 20:15:55< Gambit> (Assuming there are other similar limitations) 20100814 20:17:06< anonymissimus> well, I think you should try to use the wesnoth.some_tag stuff instead of wesnoth.fire("some_tag"), e.g. wesnoth.get_locations 20100814 20:17:10< anonymissimus> in 1.9 20100814 20:17:30< timotei> Gambit: http://learnpythonthehardway.com/index 20100814 20:21:38< Gambit> anonymissimus: get_locations only returns x and y coordinates? 20100814 20:22:04< silene> Gambit, anonymissimus: no, get_locations is not a good idea; the best thing to do is to read the complete map and put it into a lua table (something like t[x+y*width]), then just performs loops on it 20100814 20:22:09< Gambit> The wesnoth.some_tag things all seem to be incredibly limited, and not useful. 20100814 20:23:35< silene> Gambit: "incredibly limited", as in "everything wml can do, and more"? 20100814 20:24:09< anonymissimus> yes, as far as I see it it can do almost 'everything' 20100814 20:24:29-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20100814 20:24:34< anonymissimus> didn't yet try the dolog stuff but certainly will :P 20100814 20:24:39< anonymissimus> dialog 20100814 20:24:43< Gambit> as in "don't give me the information I need" and "don't have have the keys I need" as in the above two examples 20100814 20:25:12< anonymissimus> wesnoth.get_terrain returns the terrain code 20100814 20:25:21< anonymissimus> for a location 20100814 20:25:37< Gambit> Okay sorry then. 20100814 20:25:38< anonymissimus> (it could be packed into one) 20100814 20:25:45< Gambit> Either the documentation is out of date, wrong, or I don't get it. 20100814 20:26:06< silene> the documentation is uptodate, correct, and you don't get it 20100814 20:26:11< anonymissimus> it's the last thing 20100814 20:26:46< Gambit> It says it returns locations. Locations are stored as pairs. And then it uses loc[1] and loc[2] in place of x and y 20100814 20:26:49< Gambit> That's a pair. 20100814 20:26:50< anonymissimus> I never understood what a metatable is although silene explained it xxx times :P 20100814 20:26:58< Gambit> So... that's all there is? 20100814 20:34:06< Gambit> I think I'll have to learn lua outside of wesnoth and then come back and learn how the two interact. 20100814 20:34:55-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Remote host closed the connection] 20100814 20:37:25< anonymissimus> Gambit: you're on win, aren't you ? There's a nice installer lua for windows which will let you run lua scripts independently from wesnoth (I do this always in my editor before launching it with wesnoth) 20100814 20:38:27< anonymissimus> It includes the SciTe editor which I can certainly recommend, it's customized with lua syntax highlighting and more 20100814 20:38:32< Gambit> Ubuntu actually 20100814 20:38:53< anonymissimus> hm okay but then I can still recommend SciTE :P 20100814 20:39:14< anonymissimus> I used Geany on Debian however 20100814 20:39:47 * Gambit will stick with Kate. 20100814 20:39:53< Gambit> Thanks though. 20100814 20:40:57< Gambit> At least with text editors, I'd rather have one program do everything medium-well than have a bunch of specialized programs 20100814 20:46:35< timotei> fendrin: have you found any other todo things? 20100814 20:47:06< fendrin> timotei: Well, the mainline campaigns have their own projects each, but the addons are a single project. 20100814 20:47:30< timotei> fendrin: what do you mean? doesn't it create a project for each directory? 20100814 20:47:46< fendrin> timotei: No 20100814 20:48:03-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20100814 20:48:10< gabba> bonjour 20100814 20:48:15< timotei> hi gabba 20100814 20:48:18< fendrin> timotei: There is still a project called "addons". 20100814 20:48:22< gabba> hi timotei 20100814 20:48:26< timotei> hmm 20100814 20:48:32< timotei> fendrin: let'me try 20100814 20:48:55< boucman> hey gabba 20100814 20:49:10< boucman> gabba: you can read most of today's log, lots of stuff for you around :P 20100814 20:49:21< gabba> hey boucman 20100814 20:49:36< gabba> yup, greping the log now 20100814 20:49:43< timotei> boucman, gabba: GMT +1? 20100814 20:49:45< timotei> or GMT? 20100814 20:50:04< gabba> timotei: ha ha, mighty wrong guess 20100814 20:50:06< boucman> i'm gmt +2 20100814 20:50:10< timotei> hmm 20100814 20:50:16< timotei> france should be GMT 20100814 20:50:18< timotei> at most GMT+ 20100814 20:50:19< timotei> 1 20100814 20:50:28< timotei> I'm in Romania = GMT+2 20100814 20:50:40-!- crimson_penguin [~ben@64.201.60.211] has joined #wesnoth-dev 20100814 20:50:40-!- crimson_penguin [~ben@64.201.60.211] has quit [Changing host] 20100814 20:50:40-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20100814 20:54:14< gabba> timotei: http://maps.google.ca/maps?f=q&source=s_q&hl=fr&geocode=&q=Montr%C3%A9al,+Qc 20100814 20:54:30< timotei> oh right 20100814 20:54:36< timotei> gabba: you're canadian:D 20100814 20:55:12< gabba> please, please, a French Canadian i.e. Québécois 20100814 20:55:13< timotei> hmm, Rue = Street I presume? 20100814 20:55:23< timotei> a French Canadian, right 20100814 20:55:38< gabba> rue = street, yeah 20100814 20:55:54-!- srk9 [~richard@pool-173-52-112-20.nycmny.fios.verizon.net] has joined #wesnoth-dev 20100814 20:58:28< srk9> Hi. I started playing wesnoth this past Wednesday and it is an awesome game. I think I found some bugs in it. Is it possible for me to bring it to the attention of the Wesnoth developers here? 20100814 20:58:41< billynux> srk9, indeed 20100814 20:58:48< billynux> hi everybody else :) 20100814 20:58:52< billynux> I remember fondly the local disputes of Quebecois/AngloCanadians while I lived in Montreal 20100814 20:58:58< srk9> I filed a bug report with a patch: https://gna.org/bugs/index.php?16433 20100814 20:59:54< srk9> The bugs are involving rounding calculations. The bonus gold calculation uses truncation rather than rounding, which cheats players out of 1 gold every other scenario on average. There is a function in util.hpp for doing rounding, but it has an issue where it will misround numbers 2% of the time. The patch fixes both of them. 20100814 21:00:03< timotei> wow, I don't know when I will play wesnoth to such level to observe -1 gold income 20100814 21:00:07< timotei> anyway GG srk9 20100814 21:00:38< boucman> thx for the patch we'll have a look at it (not right now for me, but if someone else don't beat me to it, i'll have a look) 20100814 21:00:46< srk9> Well, I like doing mental math and I have this strange tendency to check the math computers do. This is the first time I have ever found a computer's calculations to be wrong. 20100814 21:00:53< timotei> :) 20100814 21:01:08< boucman> srk9: not that because of risc or out of think I won't apply to 1.8, only to trunk... 20100814 21:01:15< billynux> srk9, the math done by the computer wasn't wrong, the programmer misprogrammed it :) 20100814 21:01:20< boucman> /not/note 20100814 21:01:25< srk9> This is also the first patch I have ever submitted in C++ to an open source project. I am really happy about it. 20100814 21:01:35< billynux> srk9, way to go! 20100814 21:01:58< boucman> srk9: submit a couple (more ambitious ones) and you might get svn access :) 20100814 21:02:28< billynux> srk9, usually the problem is between the screen and the chair. . . but there are times where the ALU will play games with us 20100814 21:02:35< timotei> btw, if we are talking about ... rangs here, how can one become release manager? 20100814 21:02:46< timotei> does it need to be a child/descendent of current release manager? 20100814 21:02:57< srk9> billynux: The general public tends to think of computers as being infallible. This is the first time when I have caught them doing otherwise. I can joke about this to average joe from now on. ;) 20100814 21:02:59< boucman> timotei: not sure what you mean.... 20100814 21:03:40< timotei> boucman: I was asking whether the 'rank' of release manager is given from parent to child?:) 20100814 21:03:46< timotei> (just joking around) 20100814 21:04:16< boucman> iirc Ivanovic is our third RM. miyo was first and isaac was second 20100814 21:04:19< billynux> srk9, hm... I regret to say that I think you just caught some poor programming (errare humanum est), rather that a hardware error 20100814 21:04:23< boucman> I don't think they are related :P 20100814 21:05:43< srk9> boucman: That sounds cool. Unfortunately, I am busy with undergraduate research to try to polish my resume for graduate school. I did not think I would have time to patch it myself, but I seem to have exceeded my own expectations. 20100814 21:07:41< srk9> billynux, I have a poor sense of humor. Nevermind. Nice Latin by the way. difficis invenire homo quae loquitor linga latina est in hoc tempus. 20100814 21:08:29< timotei> god... it's so hot in here:( 20100814 21:08:40< timotei> loonycyborg: still fires/smoke in moscow? 20100814 21:09:17< loonycyborg> No more smoke. I can see other buildings in the window now :P 20100814 21:09:31< timotei> good 20100814 21:09:52< timotei> I heard/saw that putin took it's own heli and try estinguish some fire 20100814 21:09:52< timotei> :D 20100814 21:10:27< gabba> Ok, not great, wesnoth crashes with a SIGSEV on start 20100814 21:10:53< boucman> gabba: crab and silene reported an assert failure IIRC 20100814 21:11:04< gabba> no, this is not my bug 20100814 21:11:22< boucman> you sure ? I thought they said it was... 20100814 21:11:47< gabba> Stack trace: http://wesnoth.pastebin.com/nSDRCWux 20100814 21:12:17< boucman> gabba: ok, my bad 20100814 21:12:24< gabba> their assert triggers when they plan+execute an attack, not when the game starts 20100814 21:13:59< billynux> srk9, did you mean: it's hard to come upon men speaking Latin in these times? 20100814 21:14:17< boucman> iirc we have a latin translation in wesnoth 20100814 21:14:40< billynux> a Latin phrase that could be well aplied to Wesnoth: Quod nihil illi deerat regnandum praeter regnum... 20100814 21:14:55< billynux> All he needed to be a king was a kingdom :) 20100814 21:15:30< billynux> hm... maybe: He lacked nothing to be a king but a kingdom 20100814 21:15:44< timotei> o, s, t 20100814 21:16:43< srk9> billynux: Close. I was trying to say that "It is difficult in these times to find a man who speaks Latin". 20100814 21:16:57< billynux> :) 20100814 21:17:05< billynux> spanish is pretty close to Latin 20100814 21:17:19< srk9> billynux, you have a minor issue in your translation. homo is singular. 20100814 21:17:38< srk9> ?Habla usted espanol? 20100814 21:17:38< billynux> ah, indeed 20100814 21:17:44< billynux> Si, soy Argentino :) 20100814 21:18:00< srk9> Mi abuela es de Puerto Rico. 20100814 21:18:28< billynux> nice... I bet the weather is nice there now 20100814 21:18:58< gabba> boucman: ok, found the faulty commit 20100814 21:19:03< srk9> I would not know. I live in New York. My grandmother does too. While we have some relatives there, we are not in frequent enough contact to know those details. 20100814 21:19:57< gabba> fendrin: your r45629 crashes wesnoth on start 20100814 21:20:59< fendrin> gabba: Damn, I have tested it here. 20100814 21:21:36< gabba> fendrin: stack trace: http://wesnoth.pastebin.com/nSDRCWux, and reverting your commit as I just did makes is run again 20100814 21:21:45< srk9> billynux: Does your latin phrase mean "That nothing that lacks rule beyond a king"? 20100814 21:21:46< gabba> s/is/it 20100814 21:22:55< boucman> hmm 20100814 21:22:57< srk9> billynux: I am embarassed to admit that my Latin is weak. I know very few people who speak Latin and I only see them a few times a year. 20100814 21:23:35< boucman> srk9: you are modifying div100rounded (I assume you correct it, I didn't actually redo the math) but this is used in utils::apply_modifier which in turn is used all over the place 20100814 21:23:44< billynux> srk9, I really don't know for sure... I thought it meant something along the lines of: "He lacked nothing to be a king but a kingdom", and my Latin is non existent, I just try to remember odd phrases I can understand the general meaning of them by interpolation of known words :P 20100814 21:24:08< boucman> so I will need some time to checkout all the consequences. I assume it should be ok, but i don't want to introduce weird OOS anywhere 20100814 21:24:27< srk9> boucman: div100rounded() has an issue where it will misround numbers of the form 100x + 50. 20100814 21:25:35< boucman> srk9: I believe you, but that's not what i'm worried about... 20100814 21:25:38< srk9> boucman: I am probably interchanging between computer programming and mathmatics notation a bit too much. 100x + 50 is a monomial, where x is an integer. The value of the monomial for any value of x is misrounded down. 20100814 21:26:05< boucman> srk9: yup I got it the first time 20100814 21:26:45< billynux> srk9, what's your research topic? 20100814 21:26:57< boucman> so, gabba, did you see the reporst from today ? the reverse iterator thingy, the weird arrows, a couple of suggestions (probably not for monday, though) 20100814 21:28:01< gabba> boucman: I've haven't seen everything yet, but I'm fixing the assert on attack first. 20100814 21:28:23< srk9> boucman: Perhaps it would be a bitter idea to separate the patch into two patches. One that fixes the gold issue in 1.8.x, and another that is applied to the trunk. Understanding the implications of changing div100rounded() in a bugfix release to make a sound judgment regarding fixing the bug might be too much of a hassle. Also... 20100814 21:29:34< boucman> srk9: no no, that would make two single-line patches, not that much value added here... (we are not the linux kernel, we are way cooler with our commit process) it's just that I need to go up and check every usage, I don't see any other way 20100814 21:29:53< fendrin> gabba: I can't reproduce it. Does it crash every time? 20100814 21:30:00< boucman> and the bug is too minor to backport to 1.8, I'm only considering it for the dev release 20100814 21:30:11< billynux> Hm... gotta go... football (as in soccer) match :) 20100814 21:30:23< billynux> see you guys 20100814 21:30:41-!- billynux [~billy@wesnoth/developer/billynux] has quit [Quit: Leaving] 20100814 21:31:23< gabba> fendrin: I can test for you again in a moment 20100814 21:34:09< srk9> boucman: I was sort of doing that on my own after I posted about the bug in the channel. The effects looked big enough that I did not think that I could verify that everything would be okay on my own, so I kept quiet about it. I have an hour. Is there any way that we could collaborate on working out the effects? 20100814 21:34:17< CIA-49> gabba * r45644 /trunk/src/whiteboard/move.cpp: Whiteboard: Add additional checks for pointer validity. fixes bug #16424. 20100814 21:35:13< boucman> srk9: divide100rounded is only used in apply_modifier, which is aminly used in units.cpp 20100814 21:35:20< boucman> unit.cpp 20100814 21:35:45< CIA-49> fendrin * r45645 /trunk/src/time_of_day.cpp: Fixed missed assignment of a member in time_of_day. 20100814 21:35:49< fendrin> gabba: ^ Should have fixed it. 20100814 21:36:04< gabba> fendrin: thanks, updating 20100814 21:36:41< boucman> if you could check usages in unit.cpp and unit_type.cpp which are almost all of the uses, but should be the most trivial ones (it's a caracteristic that is calculated only once) i'll look at the tod one 20100814 21:37:41< srk9> Before I going through units.cpp, there is a possible issue that I see in apply_modifier(). 20100814 21:37:48< srk9> *Before I go through units.cpp, there is a possible issue that I see in apply_modifier(). 20100814 21:37:51< boucman> yes ? 20100814 21:39:35-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20100814 21:39:53< srk9> The string amount is always passed to atoi(). There is logic right after it to check if the last character in the string amount is a '%'. If that is the case, atoi() should fail. Is that an intended behavior? 20100814 21:40:23-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has quit [Quit: leaving] 20100814 21:40:36< boucman> let me check the details of atoi 20100814 21:41:03< fendrin> gabba: I guess the crash only happened when there is no time of day schedule provided in the scenario. 20100814 21:41:12-!- Blueblaze [~Blueblaze@adsl-99-158-46-202.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20100814 21:41:17< gabba> fendrin: I was using the test scenario 20100814 21:41:20< srk9> boucman: Here is a reference: http://www.cplusplus.com/reference/clibrary/cstdlib/atoi/ 20100814 21:41:29< gabba> starting with ./wesnoth --test 20100814 21:41:31< boucman> srk9: atoi won't fail, IIUC, it will convert the part of the string it understand, i.e up to the first non numeric charracter 20100814 21:41:45< fendrin> gabba: That does explain it. 20100814 21:42:24< gabba> fendrin: just tested and it doesn't crash anymore. Thanks! 20100814 21:42:25< srk9> boucman: You are right. Sorry about that. I skipped the first paragraph in that reference and just read the information about return values. 20100814 21:42:42< fendrin> gabba: No problem. It's me who has to say thank you. 20100814 21:43:48-!- dtiger [~dtiger@dynamic-vpdn-91-149-190-114.telecom.by] has quit [Remote host closed the connection] 20100814 21:45:52< zookeeper> fendrin, you seem to have a real tendency to write translation markers as "_ instead of _" 20100814 21:46:27< zookeeper> actually it seems most of your recent commits feature that :P 20100814 21:46:36< srk9> boucman: Just so you know, I am looking through util.cpp now. 20100814 21:46:57< fendrin> zookeeper: Yes, that is intentional. I don't want to bother the translators before esr has made the prose final. It has the side effect that unfinished prose can easily be found by running wmllint. 20100814 21:46:59< boucman> k 20100814 21:47:31< zookeeper> fendrin, oh...ok. 20100814 21:47:31< boucman> srk9: just so you know i'm not working on it right now, so work on whatever you want, i'll pick up where you left later 20100814 21:47:39< srk9> boucman: I meant unit.cpp. 20100814 21:47:46< srk9> boucman: Okay. 20100814 21:47:50-!- mjs-de [~mjs-de@p3EE274BE.dip.t-dialin.net] has joined #wesnoth-dev 20100814 21:47:54-!- mjs-de [~mjs-de@p3EE274BE.dip.t-dialin.net] has quit [Remote host closed the connection] 20100814 21:48:14< zookeeper> fendrin, i guess that works if esr knows that he's supposed to fix it when working on the prose. 20100814 21:48:24< gabba> boucman: ok, so silene spotted my "begin() - 1" which is apparently a horrible STL sin :P 20100814 21:48:35< boucman> hehe 20100814 21:48:42< zookeeper> when i saw those i just instantly assumed you had systematically typoed them 20100814 21:48:44< silene> gabba: it's not a sin, it is a random value 20100814 21:48:55< fendrin> zookeeper: The lines in question are also marked with "#TODO ESR" and I will tell him as soon as he is back. 20100814 21:48:59< boucman> but as i said, you have rbegin and rend already available so you could as well use these 20100814 21:49:27< gabba> silene: I'm wondering why I didn't use reverse iterators there really. But the weird thing is, it works as intended?? 20100814 21:50:06< silene> gabba: it works as intended, because you are comparing begin() - 1 with itself in a short lapse of time, so the value didn't have time to change 20100814 21:51:13< boucman> gabba: btw, IIRC when you fix a bug you should mark it as fixed but not close it... we close bugs when the game is released 20100814 21:51:17< gabba> silene: ok, but if begin() - 1 is a random value, shouldn't position != begin() - 1 always return true, thus leading to an index out of range almost every time? 20100814 21:51:39< gabba> boucman: ah, thanks for reminding me. Should I reopen them then? 20100814 21:51:56< silene> gabba: no, don't reopen, the bug has never been released, so it's fine to close it 20100814 21:52:02< gabba> ok 20100814 21:52:06< boucman> silene: goood point 20100814 21:52:41< silene> gabba: as i said, you are comparing begin() - 1 with begin() - 1, so it answers that, while random, they are equal 20100814 21:52:55< CIA-49> timotei * r45646 /trunk/utils/java/org.wesnoth/src/org/wesnoth/utils/WorkspaceUtils.java: eclipse plugin: skip creating projects for ".*" files 20100814 21:53:01< gabba> silene: ok, understood 20100814 21:53:44< CIA-49> timotei * r45647 /trunk/utils/java/org.wesnoth/templates/ (camp_structure.txt empty_project.txt): 20100814 21:53:44< CIA-49> eclipse plugin: remove 'build.xml' from template 20100814 21:53:44< CIA-49> as it's created internal based on user's choice 20100814 21:53:50< timotei> fendrin: hmm, creating addons projects work fine for me. 20100814 21:54:05< CIA-49> timotei * r45648 /trunk/utils/java/ (11 files in 8 dirs): 20100814 21:54:05< CIA-49> eclipse plugin: switch from 'Properties' way of storing 20100814 21:54:05< CIA-49> preferences to 'DialogSettings' which offers greater 20100814 21:54:05< CIA-49> control over the file 20100814 21:54:14< timotei> fendrin: I don't know how to reproduce it 20100814 21:54:21< timotei> fendrin: please try with latest trunk 20100814 21:54:25< fendrin> timotei: Let my try again. 20100814 21:54:28< timotei> fendrin: ok 20100814 21:54:44< CIA-49> timotei * r45649 /trunk/utils/java/org.wesnoth/src/org/wesnoth/ (3 files in 3 dirs): eclipse plugin: add code for saving the project cache 20100814 21:54:56< CIA-49> timotei * r45650 /trunk/utils/java/org.wesnoth/src/org/wesnoth/ (4 files in 2 dirs): eclipse plugin: parse variables from the config files 20100814 21:54:58< CIA-49> timotei * r45651 /trunk/utils/java/ (9 files in 5 dirs): 20100814 21:54:58< CIA-49> eclipse plugin: refactor the cache for config files 20100814 21:54:58< CIA-49> so we have a more general usage 20100814 21:55:07< timotei> hehe, cia bot is slow today 20100814 21:55:13< timotei> no wonder with my commit floods 20100814 21:55:35< fendrin> timotei: It's working fine now. Sorry to bother you with an already fixed issue. 20100814 21:55:41-!- joo is now known as joo|sleep 20100814 21:55:43< timotei> fendrin: it's ok 20100814 21:55:49< timotei> fendrin: do you have any other quick todos? 20100814 21:55:54< timotei> fendrin: I think I'll go soon 20100814 21:57:00< timotei> fendrin: do you have in mind any issues others you're not fine with, without autocompletion? 20100814 21:57:08< timotei> s/without/besides 20100814 21:57:10< gabba> silene: just trying to educate myself, are these uses wrong then: http://www.google.com/codesearch?hl=fr&start=10&sa=N&filter=0&q=%22begin%28%29+-+1%22 ? 20100814 21:57:38< fendrin> timotei: No, let's just hunt down all remaining bugs and declare the thing ready for 1.0 20100814 21:57:57< timotei> fendrin: I wish we could try tomorrow to try again with the grammar (toghether) 20100814 21:58:11< fendrin> timotei: Okay, we can do that. 20100814 21:58:12< timotei> fendrin: and I'll update then the documentation 20100814 21:58:26< timotei> fendrin: I was thinking of adding some usecases/workflow sugesstions 20100814 21:58:33< timotei> fendrin: are you okay with that? 20100814 21:58:49< timotei> fendrin: things like: how can I add a project for an already made project 20100814 21:58:55< gabba> silene: "reverse_iterator rend() { return reverse_iterator(begin() - 1); }" looks like the correct way to do things to me. I know this is in some version of wxWidgets, but does the STL do that behind the scenes when you request a reverse iterator? 20100814 21:58:56< silene> gabba: it depends what kind of container it is; if it is an STL one instead of a custom one, it is definitely wrong (for instance, msvc in iterator-debug mode will actually assert false) 20100814 21:59:04< fendrin> timotei: I still have the issue that it is slow. Eating one cpu. 20100814 21:59:24< timotei> fendrin: hmm, with xtext builders disabled right? 20100814 21:59:36< timotei> fendrin: that is, no project (opened) that has an X on it as icon? 20100814 21:59:44< timotei> anonymissimus: hey:) 20100814 21:59:49< silene> gabba: it is correct only because they implemented the container themselves 20100814 21:59:59< gabba> silene: ok, I see 20100814 22:00:10< fendrin> timotei: I think it is on again. Did a complete new import of the projects. 20100814 22:00:38< gabba> guess I'll install the libstc++ dev packages and look for myself at rend() methods. hopefully I can understand something through all the templating. 20100814 22:01:16< timotei> fendrin: 'new import' that is, with, setup workspace? 20100814 22:01:26< timotei> fendrin: http://imagebin.org/109679 do you have any icons like the 2nd one? 20100814 22:01:56< boucman> gabba: btw, do you know how timotei managed to get http://imagebin.org/109657 ? 20100814 22:01:58< fendrin> timotei: No. 20100814 22:02:06< CIA-49> eleazar * r45652 /trunk/data/core/images/terrain/chasm/ (18 files): updated snow chasm by doofus. 20100814 22:02:25< timotei> fendrin: well... 20100814 22:02:40< timotei> fendrin: then I don't know why it still does that. let me think 20100814 22:02:50< silene> gabba: you won't learn much; here is the deque::rend in libstdc++: rend() { return reverse_iterator(this->_M_impl._M_start); } 20100814 22:03:16< gabba> boucman: no, but I did run into that unfrequently while testing 20100814 22:03:23< boucman> k 20100814 22:03:28< gabba> silene: indeed, not very informative :P 20100814 22:03:35< timotei> fendrin: there shouldn't be any background stuff that is not shown in progress bar 20100814 22:03:39< boucman> it's not a blocker, but it's a bug that needs fixing... 20100814 22:03:52< fendrin> timotei: Yes, the progress bar is empty. 20100814 22:04:00< silene> gabba: but notice that, even though it is a custom container (from their point of view), they still didn't use -1 20100814 22:04:04< fendrin> timotei: And there aren't any errors reported right now. 20100814 22:04:16< timotei> fendrin: in which way errors? 20100814 22:04:20< fendrin> timotei: ".sv" is still around. 20100814 22:04:37< fendrin> timotei: There is not a single line marked as error in any campaign anymore. 20100814 22:04:39< gabba> silene: yeah, I think I learned the lesson at this point ;) 20100814 22:04:48< timotei> fendrin: delete all projects, and setup workspace again 20100814 22:05:11< fendrin> timotei: I have done that just a moment ago. 20100814 22:05:39< timotei> fendrin: for(File file: files) 20100814 22:05:39< timotei> { 20100814 22:05:39< timotei> if (file.isDirectory() == false || 20100814 22:05:39< timotei> file.getName().startsWith(".")) 20100814 22:05:39< timotei> continue; 20100814 22:06:14< timotei> fendrin: so... it's skipping . files 20100814 22:06:54-!- Tigge [~tigge@c-94a672d5.015-28-73746f34.cust.bredbandsbolaget.se] has joined #wesnoth-dev 20100814 22:07:00< timotei> fendrin: the errors are not present because there is no more builder to 'build' them. they will appear as soon as you open them 20100814 22:07:42-!- ancestral [~ancestral@206.55.180.8] has joined #wesnoth-dev 20100814 22:08:02< fendrin> timotei: Maybe the files are full qualified. Open them? 20100814 22:08:13< timotei> hmm 20100814 22:08:37< timotei> it's file.getName. will get just the name (last part of path) 20100814 22:08:45< timotei> I've spawneed some .svn files 20100814 22:08:47< timotei> but still 20100814 22:08:52< timotei> it doesn't create any 20100814 22:09:50< gabba> silene: ok, but if I ask for an iterator as parameter to specify the beginning of the (reverse) search, do I have to force the method's caller to specify a reverse iterator, or can I request a regular one and reverse it myself? (and how?) 20100814 22:10:34< silene> gabba: i don't think you can 20100814 22:11:51< gabba> damn... yeah I understand better now why I coded the method like that. I'd like to return a regular iterator too, and I won't be able to either apparently. 20100814 22:12:49< silene> anonymissimus: i'm currently applying your [move_unit] patch (and therefore reviewing it in depth); you are mistaken about multiple assignations combined with "or"; if you write "a,b = c,d or e", then you get e only if d fails, not if c does 20100814 22:14:30< fendrin> timotei: Are you aware that the mainline campaigns are all named "_Campaign_Dead_Water"? 20100814 22:14:43< timotei> what??? 20100814 22:14:47< timotei> they have 20100814 22:14:50< timotei> _Campaign_ prefix 20100814 22:14:57< fendrin> timotei: Right. 20100814 22:15:03< timotei> should I change it? 20100814 22:15:42< silene> gabba: not that you don't to use reverse iterators if you don't want, you can use normal ones; just check that you have reached the end (that is, the beginning) before actually decrementing it 20100814 22:15:45< fendrin> timotei: No, it's fine. I would like to have a folder for the mainline campaigns later but I guess that has to wait for the working sets to be in place. Until then it's okay. 20100814 22:15:52< timotei> fendrin: yes 20100814 22:15:56< fendrin> timotei: I just thought that the prefix could be the problem. 20100814 22:16:18< timotei> well, I wanted to be something... usefull, so to categorise the campaigns 20100814 22:16:26< timotei> rather than being scattered along projects 20100814 22:18:30< gabba> silene: true, I could do that too. I'm currently reading http://www.drdobbs.com/cpp/184401406 : apparently you can convert back and forth from reverse and regular iterators but there are some catches.... reading on. 20100814 22:18:58< srk9> boucman: I finished with unit.cpp and unit_types.cpp. The only effect that this change will have is to increase certain numbers by 1 in 2% of all calculations involving percentages and I cannot find any significant effects that would occur as a result of that. 20100814 22:19:03< timotei> fendrin: I'm going now. 20100814 22:19:06< timotei> fendrin: see you tomorrow 20100814 22:19:29< timotei> fendrin: if you find things that should be improved, please list them down and tell me 20100814 22:19:43< fendrin> timotei: Okay. The .svn problem 20100814 22:19:48-!- Octalot [~noct@cpc2-hitc1-0-0-cust727.hitc.cable.virginmedia.com] has quit [Remote host closed the connection] 20100814 22:19:57< timotei> anonymissimus: hey. I'd like you to test the plugin :D, so if you find bugs/problems, tell me 20100814 22:19:58< boucman> srk9: the effect i'm worried about is out of sync, i.e the calculation being different on both side of the network, i.e the calculation being done somewhere else with a different formula in different circumstances 20100814 22:20:02< fendrin> timotei: Is not that important. Only a minor thing. There are more things to do. 20100814 22:20:08< timotei> ok 20100814 22:20:40< timotei> fendrin: well, better list them, and then tomorrow list them in a pastebin, so nothing is lost 20100814 22:20:50< timotei> fendrin: it's better to have them listed so I can easily check them 20100814 22:20:54< timotei> good night guys:) 20100814 22:21:03-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: Leaving] 20100814 22:21:20< srk9> boucman: I thought that the policy was that only 1.x.y releases where x is even and the same were guarenteed to have no out of sync issues. 20100814 22:21:58< srk9> boucman: i.e. As long as this is applied to 1.9.x, syncronization should not be an issue. 20100814 22:22:44< srk9> boucman: http://wiki.wesnoth.org/FAQ#Which_versions_of_Wesnoth_can_play_together.3F 20100814 22:23:43< boucman> srk9: yes, i mean somewhere else where someone do the same calculation in another place in the same binary... i'm not too worried about unit.cpp, though... 20100814 22:23:46< anonymissimus> timotei: yes I've tested it recently, not in depth though; apart from the "compiling" wml errors no problems 20100814 22:24:05< anonymissimus> silene: thx, good to know... 20100814 22:25:00< anonymissimus> this type of "or" syntax is unknown to me from other programming languages 20100814 22:25:48< srk9> boucman: Would that not be a separate issue? As far as I know, logic is supposed be written once and reused as needed. Everything I could see in the code I read corresponded to that. 20100814 22:26:00< anonymissimus> I'm especially missing something like try..catch 20100814 22:26:30< silene> anonymissimus: the "or" is the same than in other languages, except that its semantic is extended to other types than boolean 20100814 22:26:57< silene> anonymissimus: right, unfortunately no exception except for pcall 20100814 22:27:03< boucman> srk9: in theory yes, but with WML you never know what external coders might do 20100814 22:27:14< boucman> but once again it needs to be checked but i'm not too worried 20100814 22:27:25< srk9> 16:25 < boucman> srk9: in theory yes, but with WML you never know what external coders might do 20100814 22:28:01< srk9> boucman: ignore that. I am using irssi and I just had an accidental highlight and drag with my mouse. :/ 20100814 22:29:38< anonymissimus> silene: in line 57-58 in the move_unit patch you can use put_unit to remove the unit after dumping it with __cfg, btu removing is neccessary however to remove the unit image at the start position while move_unit_fake runs 20100814 22:30:53< srk9> boucman: I am not versed in WML, so I am not able to check those things, although it is probably the external coder's problem if they are doing something strange. By external, I assume you mean outside of the official project. 20100814 22:30:55< silene> anonymissimus: extract+put is faster than put(wml), so i will keep it (unless i'm misunderstanding what you mean?) 20100814 22:33:39< anonymissimus> extract+put is faster than put(wml): in this case, extract is better yes 20100814 22:34:06< anonymissimus> but the dump is needed in any case to get some of the fields 20100814 22:34:42< silene> anonymissimus: right, i had misread, i will keep the extract and the cfg, but i will put the extracted one, not the cfg one 20100814 22:36:39< anonymissimus> I'm also missing something like powerful iterators in lua, e.g. has_next() would be nice in that loop 20100814 22:38:47< silene> anonymissimus: note that, contrarily to exceptions, the language is sufficiently powerful for that; you can define such iterators in a library if you want to 20100814 22:39:27< silene> and it would involve metatables for sure ;-) 20100814 22:41:12-!- Espreon|Wii [47af4857@wesnoth/developer/espreon] has joined #wesnoth-dev 20100814 22:41:42< gabba> ok, after my reading I rewrote the method as such: http://wesnoth.pastebin.com/Wc4k5jcz, and it compiles and runs fine with some reasonable testing. Does it pass the silene seal of approval? 20100814 22:44:18< silene> gabba: it's fine (but a bit ugly, i would still have gone with decrementing normal iterators) 20100814 22:45:12< gabba> ok 20100814 22:46:56< CIA-49> gabba * r45653 /trunk/src/whiteboard/side_actions.cpp: Whiteboard/side_actions: rewrote a method to avoid doing something really wrong with iterators. 20100814 22:48:13-!- Blueblaze [~Blueblaze@adsl-99-158-46-200.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20100814 22:53:19< gabba> timotei: I can't reproduced what you reported to boucman (about actions impossible to reorder after ending turn). Note that you can't reorder actions belonging to the same unit that depend on each other. I guess I should play an error sound or have some visual feedback when you try those. 20100814 22:55:11-!- ancestral [~ancestral@206.55.180.8] has quit [Quit: i go sleeps kthxbai] 20100814 23:03:12< CIA-49> silene * r45654 /trunk/src/ (filesystem.cpp filesystem.hpp): Inlined trivial comparator. 20100814 23:03:23< CIA-49> silene * r45655 /trunk/data/lua/wml-tags.lua: Implemented [move_unit]. (Patch #1836 by Anonymissimus.) 20100814 23:04:57< silene> anonymissimus: are you already in the credits? if not, could you send me a patch to add you? 20100814 23:06:16< anonymissimus> I don't know whether I want to appear there :P 20100814 23:06:41< anonymissimus> can't you do a, b = c or e, d or e ? 20100814 23:07:46< silene> anonymissimus: yes, but it was starting to be hard to read 20100814 23:13:04< Espreon|Wii> Now we just need [move_units]... 20100814 23:14:51< shadowmaster> fendrin: around? 20100814 23:15:48< zookeeper> Espreon|Wii, [move_unit] can move multiple units (unless something changed) 20100814 23:16:34< Espreon|Wii> At once? 20100814 23:16:38-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.] 20100814 23:16:53< shadowmaster> anonymissimus: you have approved patches? 20100814 23:17:02< shadowmaster> your forum account, please 20100814 23:17:13< anonymissimus> same name 20100814 23:17:19< zookeeper> Espreon|Wii, oh, you meant simultaneously. no, it can't 20100814 23:17:42< Espreon|Wii> Bah! 20100814 23:17:53< fendrin> shadowmaster: yes 20100814 23:18:39< shadowmaster> fendrin: I just noticed your LoW thread for 1.9.x. It's quite hard to find atm amongst the UMC threads, and this is really the case for all mainline campaigns' threads. 20100814 23:18:40-!- Tigge [~tigge@c-94a672d5.015-28-73746f34.cust.bredbandsbolaget.se] has quit [Ping timeout: 240 seconds] 20100814 23:18:53< shadowmaster> How about I move them all to a new subforum under Scen. & Campaign Development? 20100814 23:19:14< fendrin> shadowmaster: Very good idea! 20100814 23:20:57< fendrin> shadowmaster: It can be found because it is linked from the low thread in mainline campaign scenario feedback. But I guess that not every player will know about that. 20100814 23:23:21-!- norbert_ [~norbert@82-171-70-54.ip.telfort.nl] has joined #wesnoth-dev 20100814 23:24:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20100814 23:26:08< CIA-49> gabba * r45656 /trunk/src/whiteboard/manager.cpp: Whiteboard: allow moving/planning the leader away from the keep (with some planned recruits in the castle) if another leader is present on a keep in the same castle. Fixes bug #16425. 20100814 23:27:35< gabba> boucman: whew, I think I got everything 20100814 23:27:56< boucman> hehe 20100814 23:28:06< boucman> that leader thing is tricky... 20100814 23:28:19-!- wesbot changed the topic of #wesnoth-dev to: 1.9.0 planned for Monday (2010-08-16), 19:00 GMT | 139 bugs, 287 feature requests, 12 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org 20100814 23:28:26< boucman> btw is there an "execute all" command or did we drop that idea ? 20100814 23:29:08< gabba> well, you said players would prefer to spam the 'y' key, and who am I to argue ;) 20100814 23:29:23< boucman> hehe 20100814 23:29:24-!- Octalot [~noct@cpc2-hitc1-0-0-cust727.hitc.cable.virginmedia.com] has joined #wesnoth-dev 20100814 23:29:31< boucman> ok, wasn't sure what we decided 20100814 23:30:03< boucman> i'll test the leader thing some more tomorow, but i think we don't have much on the "required" tab for monday... 20100814 23:30:32< boucman> release notes, changing the themeWML if possible, maybe disabling DSU 20100814 23:30:35< gabba> still reordering vs recruits/recall 20100814 23:30:43< boucman> yes, that one... 20100814 23:31:23< gabba> and I think the context menu will require some work, since I need to make sure the menu items appear only when it makes sense 20100814 23:31:39< gabba> it's different from hotkeys, which you can just ignore if pressed at the wrong time 20100814 23:31:47< boucman> gabba: just make them appear all the time for 1.9.0, I think... 20100814 23:32:17< gabba> ok, I could do that 20100814 23:32:25< norbert_> shadowmaster: I'm not sure, but it seems that if one has unread messages in "Mainline Campaign Development", "Scenario & Campaign Development" now always shows as having unread messages because of that first link to the other board 20100814 23:32:45< gabba> boucman: in WML, can you continue a list on the next line? 20100814 23:32:58< boucman> not sure what you mean 20100814 23:33:58< gabba> boucman: just asking because the items= line in the default theme is getting huge, and I was wondering if I have to keep adding to it on the same line 20100814 23:34:20< gabba> it's a comma-separated list 20100814 23:35:01< boucman> gabba: no idea... my guess is that it must be on a single line, from the general WML syntax, but just try it and see if it refuses to start... 20100814 23:35:25< gabba> I'm just gonna leave them on the same line and save one more test :P 20100814 23:35:35< boucman> :P 20100814 23:36:05< gabba> given the length of the line, maybe I'm following a time-honored tradition 20100814 23:41:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20100814 23:42:03-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.8/20100722155716]] 20100814 23:42:09< shadowmaster> norbert_: I don't think that should be a problem. 20100814 23:42:29< norbert_> not a problem, but it's somewhat annoying for people like me 20100814 23:42:32< shadowmaster> it makes sense to me. 20100814 23:42:44< norbert_> I don't read the "Mainline Campaign Development" board... 20100814 23:42:59 * shadowmaster shrugs 20100814 23:43:10< norbert_> well, not that big a deal 20100814 23:43:17< norbert_> I can manage 20100814 23:46:29-!- Blueblaze [~Blueblaze@adsl-99-158-46-200.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20100814 23:50:52< CIA-49> gabba * r45657 /trunk/src/hotkeys.cpp: Whiteboard: changed hotkey text so it fits better in the context menu. 20100814 23:50:59< CIA-49> gabba * r45658 /trunk/data/themes/default.cfg: Add whiteboard commands to the 'actions' and context menu of the default theme. 20100814 23:55:12-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit [] 20100814 23:55:20< shadowmaster> fendrin: I think I moved all mainline campaign threads. If you think I'm missing something, please tell me. 20100814 23:55:33< shadowmaster> DW doesn't have a 1.9.x mainline thread yet, AFAIK 20100814 23:56:08< shadowmaster> hm, interesting, my trunk build is broken and doesn't display half of the images. 20100814 23:56:16< shadowmaster> and I apparently missed AOI 20100814 23:58:57< shadowmaster> I also missed TRoW. That should be all of it. I'll go to lock and mark older threads as [Historical] --- Log closed Sun Aug 15 00:00:44 2010