--- Log opened Sat Aug 28 00:00:32 2010
--- Day changed Sat Aug 28 2010
20100828 00:00:32-!- gabba [~gabba@wesnoth/developer/gabba] has quit [Quit: Leaving.]
20100828 00:04:03-!- Upth [ogmar@75.26.208.231] has joined #wesnoth-dev
20100828 00:07:41-!- Upthorn [ogmar@adsl-75-26-170-84.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 276 seconds]
20100828 00:09:26-!- Blueblaze [~Blueblaze@adsl-99-148-247-171.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100828 00:13:44< Sapient> hmm.. technically my example above wouldn't color black to red, but rather the lowest luminosity value of the red teamcolor range
20100828 00:14:06-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100828 00:19:53-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 265 seconds]
20100828 00:20:18< Gambit> units killed by [kill] can still match [filter] ?
20100828 00:20:35< Gambit> Somehow a dead unit is getting stored with my [store_unit] and that's the only explanation I can think of.
20100828 00:23:19-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has quit [Read error: Connection reset by peer]
20100828 00:25:13< Gambit> Nope that's not it at all.
20100828 00:25:57< Gambit> Great... the real answer is that this only happens in side turn end
20100828 00:26:02< Gambit> Which means... I messed up.
20100828 00:29:30-!- Bob_The_Mighty [~chatzilla@cpc8-brig15-2-0-cust40.3-3.cable.virginmedia.com] has joined #wesnoth-dev
20100828 00:29:45-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100828 00:31:25-!- silene [~plouf@wesnoth/developer/silene] has quit [Quit: Leaving.]
20100828 00:34:26< Gambit> Actually the answer is that I'm an idiot who forgot first_time_only and needs to stop discussing nonexistant bugs in #wesnoth-dev before more thorough testing.
20100828 00:35:39-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has quit [Remote host closed the connection]
20100828 00:35:56-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Ping timeout: 240 seconds]
20100828 00:36:19< Sapient> tragedy averted :)
20100828 00:37:58-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Ping timeout: 272 seconds]
20100828 00:38:13-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100828 00:41:11< Gambit> That's true. WML errors are way better than c++ ones.
20100828 00:48:52< Gambit> eleazar: The windmill looks odd now.
20100828 00:49:04< Gambit> The animation in its hex is off sync with the bits in adjacent hexes
20100828 00:49:15< eleazar> Gambit: yeah that was reported
20100828 00:49:40< eleazar> it's boucman or alink's kind of thing
20100828 00:54:47-!- Bob_The_Mighty [~chatzilla@cpc8-brig15-2-0-cust40.3-3.cable.virginmedia.com] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.8/20100722155716]]
20100828 00:59:30-!- ancestral [~ancestral@12.145.225.25] has joined #wesnoth-dev
20100828 01:03:36-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20100828 01:07:02-!- ancestral [~ancestral@12.145.225.25] has quit [Quit: i go sleeps kthxbai]
20100828 01:10:02-!- Sapient [~patrickp@wesnoth/developer/sapient] has left #wesnoth-dev []
20100828 01:12:32-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100828 01:13:50-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20100828 01:16:13< CIA-35> eleazar * r46036 /trunk/ (576 files in 3 dirs): Adding tropical ocean terrain. Near the bottom of 'terrain-graphics.cfg' several lines are noted that can improve speed without totally deactivating animations. Improved transitions between ocean and void and off-map.
20100828 01:42:09< alink> eleazar: btw, the bug that I just fixed about some animated terrains shouldn't affect 1.9.0. I was caused by a recent commit
20100828 01:42:20< alink> s/I/it
20100828 01:45:24< alink> Gambit: can you reproduce the windmill bug reliably ? I never saw it on my box
20100828 01:45:49< Gambit> Yes.
20100828 01:45:52< alink> and what OS do you use?
20100828 01:46:13< Gambit> Ubuntu, and I'm at revision 46027 if that helps
20100828 01:47:15< Gambit> Actually what do you mean by "reliably"? It's not in the map editor.
20100828 01:47:34< alink> Gambit: well, tell me your method
20100828 01:47:52< alink> and do you mind testing some patch about it (but not today). Because, for the moment, it can have various causes
20100828 01:47:53< Gambit> I'm playing a local game with a windomill on, and surrounded by Gg
20100828 01:48:43< alink> and it glitches every time and for every windmills (or at least very often)
20100828 01:48:46< Gambit> Whoa. I made a new map, and it's not there.
20100828 01:49:41< alink> ^?
20100828 01:50:16< Gambit> alink: It's just one map I have apparently.
20100828 01:50:24< Gambit> Shall I send it to you?
20100828 01:50:40< alink> oh, good yeah but better post it on the Gna bug report
20100828 01:51:22< alink> https://gna.org/bugs/?16529
20100828 01:56:35< Gambit> alink: Also it isn't nearly as pronounced on my computer as it is in that attached gif.
20100828 01:56:58< alink> Well, on mine I have nothing
20100828 01:57:35< alink> Gambit: maybe try if this fix it : http://wesnoth.pastebin.com/feZvCfZw   (this disable the random shifting of anim)
20100828 01:57:45< Gambit> And it's only on at the top half of the animation
20100828 01:58:09< alink> that's the only part out of hex, use grid to see it
20100828 02:00:09< alink> Gambit: thanks, checking your map on mine
20100828 02:00:31< Gambit> Applying that patch
20100828 02:00:42-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20100828 02:02:34< Gambit> "patch unexpectedly ends in middle of line"
20100828 02:02:40< alink> still no bug here
20100828 02:02:47-!- Gallaecio is now known as skarcha
20100828 02:03:17-!- skarcha is now known as Guest49770
20100828 02:03:30-!- Guest49770 is now known as eskarcha
20100828 02:03:39< Gambit> alink: You use git?
20100828 02:03:45< alink> yes
20100828 02:03:53< Gambit> I use SVN.
20100828 02:04:04< Gambit> I'll replace that line manually I guess.
20100828 02:04:16< alink> yes, it's a simple change
20100828 02:04:26< alink> sorry that the patch didn't work
20100828 02:05:27< Gambit> Building
20100828 02:06:28< Gambit> alink: Didn't fix.
20100828 02:06:39-!- eskarcha is now known as Gallaecio
20100828 02:07:05< alink> Gambit: ok thanks, at least now I am sure that it was not that
20100828 02:07:54< alink> So it seems to be not from terrain code, then it's from animation code I guess
20100828 02:08:33< Gambit> Also I copied that section of terrain in a 3 hex radius centered on the windmill to a new map.
20100828 02:08:37< Gambit> The windmill was fine.
20100828 02:09:22< alink> mmh weird, that shouldn't change anything, especially with my patch
20100828 02:09:23< Gambit> So it's not terrain/transition specific.
20100828 02:09:35< Gambit> alink: I meant prepatching.
20100828 02:10:45< alink> well without the patch, the anim is randomly shifted depending of its location. That's the only thing that I see changing between 2 maps
20100828 02:11:04< Gambit> So with that map I uploaded I can get it in game and in map, but with-
20100828 02:11:05< Gambit> Ah
20100828 02:11:13< Gambit> alink: The location is not maintained in the new copy.
20100828 02:12:56< alink> well, we already established that it was not caused by the randomly shift. I just don't see another difference between 2 maps
20100828 02:13:31< Gambit> The location is different
20100828 02:15:16-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20100828 02:15:42< Gambit> alink: Okay pasting the same chunk of terrain in the same location on a new map of the same size does give me the glitch.
20100828 02:15:58< Gambit> I unapplied your patch though.
20100828 02:17:01< alink> this is annoying, because this seems to point towards the randomly shift, but the test with the patch discarded that
20100828 02:17:17< alink> maybe it's random enough to confuse us
20100828 02:18:57< alink> aaaah I see the bug now :-)
20100828 02:21:08< alink> using :layers on the windmill triggers it, but it's maybe not related. However it's the exact same glitch
20100828 02:22:25< Gambit> There's also the possibility that in the places where I don't see it, it's just too small to notice.
20100828 02:27:24< alink> Gambit: this fix what I have here with :layers : http://wesnoth.pastebin.com/Cki1kgQA
20100828 02:36:58< Gambit> Ah sorry; got called away to do dishes.
20100828 02:37:05< Gambit> alink: That does it. :D
20100828 02:37:20< alink> Gambit: \o/
20100828 02:37:40< Gambit> I filled a map with windmills for this one too.
20100828 02:37:43< Gambit> All perfect.
20100828 02:38:31-!- PeteyP [~Pete@pc-218-249-120-200.cm.vtr.net] has quit [Quit: Saliendo]
20100828 02:38:47< alink> unfortunately, it changes too much a core animation function, so boucman must adapt it to something cleaner. Perhaps add a dedicated function
20100828 02:39:46-!- anonymissimus [~chatzilla@HSI-KBW-095-208-088-086.hsi5.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.2/20100316074819]]
20100828 02:40:13< alink> boucman: My theory is that for some reason (slow box, scrolling...) the cache of hexes from the same anim are rebuild at times different enough to introduce this glitch
20100828 02:41:16< alink> So, need to avoid using the current tick (but instead use always 0 or a fixed one), or better control what happen when different ticks are used
20100828 02:41:19-!- Blueblaze [~Blueblaze@adsl-99-148-247-171.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20100828 02:43:20< Gambit> Did you figure out why you aren't affected?
20100828 02:43:45< alink> no, it seems a bit platform dependant, maybe a number thing somewhere
20100828 02:43:54< alink> or just a performance problem
20100828 02:44:02< Gambit> We'll have to assume genetics and test your whole family if not.
20100828 02:44:07< alink> Gambit: map/game start fast for you ?
20100828 02:44:17< Gambit> Yes I've never had performance issues here :)
20100828 02:44:41< Gambit> Instant loading, flawless animated water, fast AI, etc.
20100828 02:45:05< alink> but glitchy anims ;-p
20100828 02:47:40< alink> boucman: to reproduce: use :layers on central or north hex of windmill, this will only rebuild the cache of this hex, at a time very different from others. This create the glitch. Then use :turn to trigger a ToD change. All hexes are rebuild at the same time and the glitch is gone
20100828 02:50:53< alink> we could fix it with a major change of builder code (like how I proposed to load images/anim of the whole map at start, instead of hex by hex), but this bug seems to indicate a problem(or missing feature) when trying to synchronize animations
20100828 02:52:22< alink> Gambit: btw, I almost forget to thank you for your collaboration :)
20100828 02:53:44< alink> I always said that having someone testing patch about a hard to reproduce bug is the only way to fix it
20100828 02:54:00< alink> and it's much easier than trying to guess things
20100828 02:54:35< Gambit> No problem. It was fun.
20100828 02:56:59< alink> even more fun was when I tried to debug animated multi-hexes terrain by using dancing mountains, very disturbing :)
20100828 03:00:00< alink> about windmills, I wonder if simply using variation having different speed would look better
20100828 03:04:04< alink> boucman: other simpler way to reproduce the bug. Use very slow scrolling speed to show an hex before the other (of a windmill). From north to south is probably better
20100828 03:16:18-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100828 03:17:12-!- crimson_penguin [~ben@64.201.60.211] has joined #wesnoth-dev
20100828 03:17:12-!- crimson_penguin [~ben@64.201.60.211] has quit [Changing host]
20100828 03:17:12-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100828 03:19:36-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100828 03:30:48-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has quit [Quit: Leaving]
20100828 03:35:25-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 240 seconds]
20100828 04:22:08-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has joined #wesnoth-dev
20100828 04:37:12-!- Ivanovic_ [~ivanovic@dtmd-4db22bcb.pool.mediaWays.net] has joined #wesnoth-dev
20100828 04:39:28-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20100828 04:41:09-!- Ivanovic_ is now known as Ivanovic
20100828 04:46:43-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has quit [Ping timeout: 272 seconds]
20100828 04:59:50-!- cz1stf [~cz1stf@78.24.12.198] has quit [Remote host closed the connection]
20100828 05:11:09-!- Banannaboy [~Pete@pc-218-249-120-200.cm.vtr.net] has joined #wesnoth-dev
20100828 05:12:08-!- Banannaboy is now known as PeteyP
20100828 05:37:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20100828 05:37:48-!- Gambit [~Gambit@unaffiliated/gambit] has quit [Remote host closed the connection]
20100828 05:40:09-!- Blueblaze [~Blueblaze@adsl-99-4-146-181.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100828 05:49:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100828 05:50:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20100828 05:50:59-!- monochromatic [~elvish_so@pool-108-2-86-247.phlapa.east.verizon.net] has quit [Quit: Colloquy for Mac - client quit]
20100828 06:10:20-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100828 06:14:33-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20100828 06:14:59-!- Blueblaze [~Blueblaze@adsl-99-4-146-181.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20100828 06:18:57-!- Blueblaze [~Blueblaze@adsl-99-4-146-181.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100828 06:22:56-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has joined #wesnoth-dev
20100828 06:37:18-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has joined #wesnoth-dev
20100828 06:45:02-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20100828 06:48:22-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has quit [Quit: Smell ya later!]
20100828 06:50:02-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has quit [Ping timeout: 276 seconds]
20100828 06:59:26-!- Blueblaze [~Blueblaze@adsl-99-4-146-181.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20100828 07:45:21< CIA-35> silene * r46037 /trunk/src/replay_controller.cpp: Fixed era events not being replayed.
20100828 07:56:02-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-22.telecom.by] has joined #wesnoth-dev
20100828 07:57:02-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has joined #wesnoth-dev
20100828 08:01:58-!- PeteyP [~Pete@pc-218-249-120-200.cm.vtr.net] has quit [Quit: Saliendo]
20100828 08:03:52-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20100828 08:15:56-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20100828 08:21:49-!- Gallaecio [~quassel@225.189.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20100828 08:25:39-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100828 08:30:50-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has quit [Quit: Smell ya later!]
20100828 08:33:16-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100828 08:37:12-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has joined #wesnoth-dev
20100828 08:46:47-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has quit [Quit: Smell ya later!]
20100828 08:53:06-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100828 09:01:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20100828 09:27:40-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has joined #wesnoth-dev
20100828 09:29:36-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20100828 09:30:32-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has joined #wesnoth-dev
20100828 09:41:35-!- ancestral [~ancestral@mobile-166-137-140-089.mycingular.net] has quit [Quit: Smell ya later!]
20100828 10:12:09-!- Ivanovic [~ivanovic@dtmd-4db22bcb.pool.mediaWays.net] has quit [Changing host]
20100828 10:12:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100828 10:18:54< Ivanovic> moin
20100828 10:22:43< boucman> moinmoin
20100828 10:25:27-!- mjs-de [~mjs-de@vpw.wh.uni-dortmund.de] has joined #wesnoth-dev
20100828 10:26:43< Ivanovic> silene: http://forums.wesnoth.org/viewtopic.php?p=452830#p452830
20100828 10:40:36-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20100828 10:54:24< boucman> zookeeper: around ?
20100828 10:56:25< zookeeper> boucman, for a short while
20100828 10:56:26< zookeeper> what's up?
20100828 10:56:43< boucman> I just assigned a patch to you... could you have a quick look ?
20100828 10:57:17< boucman> ilor_, silene: you have some "in progress" patches that have been lying around for some time, any update ?
20100828 10:58:30< zookeeper> boucman, the scenario count patch? sure, i can deal with that, just not right now.
20100828 10:59:00< boucman> k, thx
20100828 10:59:53< boucman> gambit is a dev now, isn't he ?
20100828 11:00:07< boucman> (as grickit IIUC)
20100828 11:00:14< boucman> Ivanovic: ^^
20100828 11:00:39< Ivanovic> boucman: yes
20100828 11:00:50< boucman> k, i'll assign his own patches to him :P
20100828 11:04:14-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20100828 11:12:13< Ivanovic> :)
20100828 11:21:08-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20100828 11:21:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100828 11:23:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20100828 11:25:06-!- Ivanovic_ is now known as Ivanovic
20100828 11:27:14< silene> Ivanovic: i will take a look
20100828 11:28:38< Ivanovic> thanks
20100828 11:29:10< silene> boucman: not sure why it ever was assigned to me, i will close it
20100828 11:29:56< boucman> mkay... not sure if it's still relevant...
20100828 11:34:35-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20100828 11:34:42< silene> Ivanovic: by the way, it's shadowmaster's code
20100828 11:35:40-!- fendrin [~fabi@88-134-103-91-dynip.superkabel.de] has joined #wesnoth-dev
20100828 11:35:40-!- fendrin [~fabi@88-134-103-91-dynip.superkabel.de] has quit [Changing host]
20100828 11:35:40-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20100828 11:41:29-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20100828 11:41:47-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100828 11:42:28-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100828 11:44:15-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20100828 11:46:32< CIA-35> silene * r46038 /trunk/src/scripting/lua.cpp: Merged stack cleaning methods. (Mentioned in patch #1432.)
20100828 11:52:47-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20100828 12:02:47< Ivanovic> silene: heh, okay, no idea whos code it is/was, i just know that you already fixed a lot of engine related problems
20100828 12:10:43< CIA-35> ivanovic * r46040 /branches/1.8/po/ (7 files in 7 dirs): updated Japanese translation
20100828 12:10:45< CIA-35> ivanovic * r46039 /trunk/ (21 files in 20 dirs): updated Japanese translation
20100828 12:15:38< fendrin> Ivanovic: I haven't reached timotei yet, regarding the code example google wants to have.
20100828 12:15:50< Ivanovic> fendrin: he was online yesterday
20100828 12:16:00< fendrin> Ivanovic: Is there a deadline and are there any consequences if it is missing?
20100828 12:16:14< fendrin> Ivanovic: I have missed him yesterday.
20100828 12:27:09< Ivanovic> no idea to both
20100828 12:27:24< Ivanovic> though it seems as if officially they are meant to start uploading on 31st anyway
20100828 12:36:03-!- dtiger_ [~dtiger@dynamic-vpdn-93-125-69-67.telecom.by] has joined #wesnoth-dev
20100828 12:36:41-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-22.telecom.by] has quit [Ping timeout: 276 seconds]
20100828 13:11:04< CIA-35> silene * r46041 /trunk/src/scripting/lua.cpp: Factored querying global values and handled missing tables.
20100828 13:40:45-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20100828 14:19:40-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100828 14:22:56-!- Gambit [~Gambit@unaffiliated/gambit] has joined #wesnoth-dev
20100828 14:27:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20100828 14:34:06< CIA-35> silene * r46042 /trunk/src/team.cpp: Fixed initialization of per-side income. (Fix for bug #16563.)
20100828 15:04:20-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has quit [Quit: Leaving]
20100828 15:11:59-!- Gallaecio [~quassel@225.189.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100828 15:23:57-!- DesertPanther [~Khalid@unaffiliated/desertpanther] has joined #wesnoth-dev
20100828 15:44:05-!- Upthorn [~ogmar@adsl-75-26-180-40.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100828 15:46:32-!- Upth [ogmar@75.26.208.231] has quit [Ping timeout: 258 seconds]
20100828 15:55:40-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20100828 15:58:59-!- zookeeper [~l@88-148-252-191.bb.dnainternet.fi] has joined #wesnoth-dev
20100828 15:59:03-!- zookeeper [~l@88-148-252-191.bb.dnainternet.fi] has quit [Changing host]
20100828 15:59:03-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20100828 15:59:17-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20100828 15:59:33< alink> hi
20100828 16:00:46< CIA-35> alink * r46043 /trunk/src/marked-up_text.cpp: Try to silence a Windows warning about patch #1140 (Fixed line wrap for CJK languages)
20100828 16:00:58< CIA-35> alink * r46044 /trunk/src/marked-up_text.cpp: 
20100828 16:00:58< CIA-35> Add a shorcut for common non-CJK characters (assuming compiler didn't guess it)
20100828 16:00:58< CIA-35> This also simplifies the reading of the CJK list.
20100828 16:06:45-!- Elvish_Pillage2 [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20100828 16:32:59-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20100828 16:33:13-!- rigved [~rigved@116.72.163.243] has quit [Client Quit]
20100828 16:39:43< CIA-35> alink * r46045 /trunk/src/ (display.cpp unit.cpp): 
20100828 16:39:43< CIA-35> Optimize rendering of flying units and fix tiny glitch.
20100828 16:39:43< CIA-35> This helps because they often have standing anims (gain few fps during bat season)
20100828 16:39:43< CIA-35> Done by stopping considering flying as 1% submerged, which was usually not visible but uselessly triggered the expensive submerged effect. Instead use -1, as "negative depth", which make more sense.
20100828 16:46:57-!- stikonas [~and@ctv-213-164-99-190.vinita.lt] has joined #wesnoth-dev
20100828 16:46:57-!- stikonas [~and@ctv-213-164-99-190.vinita.lt] has quit [Changing host]
20100828 16:46:57-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20100828 16:48:19< alink> boucman: I noticed several equality comparisons in anim code. Probably not very important, but fyi I believe that it's unadvised 
20100828 16:49:59< alink> IIRC, long time ago, we had a performance bug with halo about a cache hit test always missing because of such equality problem
20100828 16:51:58< alink> ah I see a gcc warning switch : -Wfloat-equal   I will try that
20100828 17:04:28< alink> good most of them are tests against 0, which I believe is safer.
20100828 17:05:20< alink> however some should be checked, and as I thought there is a big bunch in one anim function (unit_frame::merge_parameters)
20100828 17:22:09-!- Gallaecio_ [~quassel@233.152.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20100828 17:23:42-!- Gallaecio [~quassel@225.189.60.213.dynamic.mundo-r.com] has quit [Ping timeout: 272 seconds]
20100828 17:25:37-!- Blueblaze [~Blueblaze@adsl-99-4-146-16.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20100828 17:31:19-!- PeterPorty [~Pete@pc-218-249-120-200.cm.vtr.net] has joined #wesnoth-dev
20100828 17:31:55-!- Gallaecio_ is now known as Gallaecio
20100828 17:35:36< CIA-35> alink * r46046 /trunk/src/actions.cpp: Simplify the logic of some code in choose_defender_weapon()
20100828 17:36:46< alink> I wonder why we use so many ugly new and delete in that area^. Surely c++ allows cleaner ways
20100828 17:45:49-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20100828 17:46:44< silene> i guess we could use scoped pointers instead and (ab)use their swap operator, it would make the code a bit simpler
20100828 17:54:43< boucman> alink: IIRC in merge parameters, ==0 is sematically equivalent to "is set"
20100828 17:54:52< boucman> so I guess it's as inteded
20100828 18:02:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100828 18:04:12< alink> <alink> boucman: I noticed several equality comparisons in anim code. Probably not very important, but fyi I believe that it's unadvised <-- Ah, stupid me I forget to mention that it was about float/double
20100828 18:04:31< boucman> alink: I answered ten minutes ago :)
20100828 18:04:34< alink> hopefully the -Wfloat-equal thing clarified that
20100828 18:05:13< alink> ok ,but don't you mean "is NOT set" ?
20100828 18:05:45< alink> and yes such usage should be safe
20100828 18:06:03< boucman> alink: oops, yes
20100828 18:06:19< boucman> I could add a boolean to the structure for that, but I was lazy. 
20100828 18:06:30< boucman> and comparing floats to zero should be fast (I guess)
20100828 18:06:43< alink> or maybe define NOT_SET = 0.0
20100828 18:06:51< alink> yeah it's not a speed problem
20100828 18:08:50< alink> and if one day we need to use 0.0 for a "set" value, we could change NOT_SET to -424242 or something
20100828 18:10:25-!- elvish_sovereign [~elvish_so@pool-108-2-86-247.phlapa.east.verizon.net] has joined #wesnoth-dev
20100828 18:11:41< alink> ah stupid me again, I said testing again 0 should be safe and then I propose to use -424242 :-/
20100828 18:11:52< alink> really need a break, afk
20100828 18:20:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20100828 18:20:43-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20100828 18:53:09< CIA-35> eleazar * r46047 /trunk/data/core/ (7 files in 2 dirs): adding in the snowy human city village by doofus-01
20100828 18:54:32< boucman> alink: good catch with the 1%submerged
20100828 18:55:32< CIA-35> eleazar * r46048 /trunk/ (changelog players_changelog): changelog update.
20100828 18:59:56< eleazar> alink: boucman the new human snow city (and some other terrains) cause an odd error message:
20100828 18:59:58< eleazar> warning display: terrain/village/human-city-tile.png overlay is RLE-encoded, creating a neutral surface
20100828 19:00:09< eleazar> but everything seems to work
20100828 19:00:15< eleazar> should i care?
20100828 19:00:21< boucman> never heard of that one before...
20100828 19:07:47< zookeeper> eleazar, did you try opening and re-saving the images? maybe he's just saved them funny somehow.
20100828 19:08:08< eleazar> zookeeper: i crushed it, but yeah, i should try that too
20100828 19:13:33< silene> i'm not sure it has to do with the actual file; it seems to be an instance of https://gna.org/bugs/index.php?12856 except that nowadays it displays a warning instead of crashing
20100828 19:14:48< CIA-35> eleazar * r46049 /trunk/data/core/terrain-graphics.cfg: fixed glitch with mountains and water.
20100828 19:16:29< zookeeper> silene, have you considered allowing lua to be used to write abilities/specials?
20100828 19:16:55< zookeeper> (not that i have any idea how it'd work exactly)
20100828 19:17:40< silene> zookeeper: sure; but i haven't yet thought about what it would look like (it would look like a function, but what should this function do, that's what i haven't considered yet); if you have suggestions, i'm all hear
20100828 19:19:16< zookeeper> silene, well, no, i don't really have suggestions :P also the only reason i thought of that was because i'm still craving for that [defense] ability tag...
20100828 19:20:54< zookeeper> i guess the lua part should be able to do pretty much anything to the affected unit, but i have no idea how that'd work with the fact that ability/special effects aren't permanent.
20100828 19:21:21< eleazar> zookeeper: boucman looks like a lot of village terrains cause that error report --- but it only complains about the "tile" image-- the one used for the editor palette and minimap.
20100828 19:21:29< eleazar> i don't think i'm gonna worry about it.
20100828 19:21:40 * zookeeper needs to go afk for a while
20100828 19:27:26-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Remote host closed the connection]
20100828 19:28:24< fendrin> Gambit: I still don't get how side=global is being used when reading from a global variable. Which side's version is used?
20100828 19:28:43< Gambit> side 1
20100828 19:28:48< Gambit> I think
20100828 19:29:27< Gambit> fendrin: Ah no that'd be the currently active player
20100828 19:29:30< Gambit> According to the wiki
20100828 19:32:45-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Ping timeout: 240 seconds]
20100828 19:35:44< CIA-35> mordante * r46050 /trunk/src/scripting/lua.cpp: Fix a compiler warning.
20100828 19:37:04-!- Upth [ogmar@adsl-75-26-180-40.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100828 19:39:50-!- Upthorn [~ogmar@adsl-75-26-180-40.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 255 seconds]
20100828 19:40:52-!- Upthorn [ogmar@adsl-75-26-193-228.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20100828 19:44:14-!- Upth [ogmar@adsl-75-26-180-40.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 265 seconds]
20100828 19:49:22-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has quit [Ping timeout: 272 seconds]
20100828 19:54:42-!- Greywhind [~Greywhind@pool-96-238-43-241.prvdri.fios.verizon.net] has joined #wesnoth-dev
20100828 20:15:03< CIA-35> alink * r46051 /trunk/src/minimap.cpp: 
20100828 20:15:03< CIA-35> Fix useless surface copy of overlay in minimap and probably kill a warning.
20100828 20:15:03< CIA-35> It seems that blit_surface doesn't have a RLE assert anymore, which is a good thing and allows this simplification.
20100828 20:15:17< alink> eleazar: probably fixed^, how do you reproduced it ?
20100828 20:16:02< alink> btw snowy mountains village doesn't draw villages in editor
20100828 20:16:21< alink> only snowy moutains
20100828 20:18:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20100828 20:19:00< alink> mmh the old assert is gone, but now I see new other one. I should check that
20100828 20:22:29-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20100828 20:25:33< eleazar> just draw a snowy human city village on a map
20100828 20:26:52< eleazar> Vhca
20100828 20:28:49< alink> no still nothing, even with --log-warning=display
20100828 20:29:10< eleazar> try the snowy orc village
20100828 20:30:14< alink> still nothing, but not a problem
20100828 20:30:24< eleazar> then i guess you fixed it
20100828 20:31:09< alink> well, I need a second commit to fix something wrong with my previous commit :-/
20100828 20:32:10< CIA-35> alink * r46052 /trunk/src/sdl_utils.cpp: 
20100828 20:32:10< CIA-35> Allows to lock RLE-encoded surface. SDL auto decode them when needed.
20100828 20:32:10< CIA-35> Forcing the caller to always do it himself is inefficient since only SDL know the current true RLE state (which is not always reflected by the RLE flag)
20100828 20:32:16< alink> now safely fixed
20100828 20:32:58< alink> eleazar: ^could be useful to check it with your box, since you seem to have different SDL behavior
20100828 20:33:20< eleazar> i'm having issues with compiling again
20100828 20:33:38< alink> eleazar: ah ok
20100828 20:36:39-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100828 20:37:46-!- loonybot [~loonybot@ppp95-165-186-178.pppoe.spdop.ru] has joined #wesnoth-dev
20100828 20:37:46-!- loonybot [~loonybot@ppp95-165-186-178.pppoe.spdop.ru] has quit [Changing host]
20100828 20:37:46-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100828 20:37:47< CIA-35> zookeeper * r46053 /trunk/data/multiplayer/ (13 files in 2 dirs): 1vs1 map updates from Doc Paterson.
20100828 20:38:31-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100828 20:44:59-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20100828 20:47:19< zookeeper> boucman, i don't know how to apply that scenario count patch
20100828 20:47:31< zookeeper> or tortoisesvn doesn't
20100828 20:47:59< boucman> zookeeper: k, i'll do it
20100828 20:48:49< zookeeper> i'm not sure what's wrong, i even tried to apply the patch from a couple different dirs
20100828 20:49:58< boucman> you need to do it from the root wesnoth directory (the one that contains data/ and src/) with a -j2 argument (not sure how to do that with tortoise)
20100828 20:51:36< zookeeper> oh, well, i didn't know that. what does that argument do?
20100828 20:53:17< alink> maybe you mean -p2 ?
20100828 20:54:15< alink> or -p0, anyway i don't know either about -j2 and I must go, afk
20100828 20:55:13< boucman> sorry, yes, -p2
20100828 20:55:30-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20100828 20:55:43< boucman> it removes a part of the path embedded in the patch to make it match your local path
20100828 20:56:08< CIA-35> silene * r46054 /trunk/src/scripting/lua.cpp: Added a function for adding tile overlays.
20100828 20:56:11< CIA-35> silene * r46055 /trunk/src/scripting/lua.cpp: Added a function for removing tile overlays.
20100828 20:56:20-!- mysticX [aid@rbi0332.giga-dns.com] has joined #wesnoth-dev
20100828 20:56:29< CIA-35> silene * r46056 /trunk/ (data/lua/wml-tags.lua src/game_events.cpp): Moved [item] implementation to Lua.
20100828 20:56:29< CIA-35> silene * r46058 /trunk/data/lua/ (wml/ wml/objectives.lua wml-tags.lua): Moved objectives-related tags to their own file.
20100828 20:56:29< CIA-35> silene * r46057 /trunk/ (data/lua/wml-tags.lua src/game_events.cpp): Moved [remove_item] implementation to Lua.
20100828 20:56:29< CIA-35> silene * r46059 /trunk/data/lua/wml/objectives.lua: Simplified code a bit.
20100828 20:56:29< CIA-35> silene * r46060 /trunk/data/lua/ (wml/objectives.lua wml-tags.lua): Added default handlers for load/save events.
20100828 20:56:30< CIA-35> silene * r46061 /trunk/data/lua/ (wml/items.lua wml-tags.lua): Moved item-related tags to their own file.
20100828 20:56:30< CIA-35> silene * r46062 /trunk/ (7 files in 3 dirs): Moved handling of toplevel [item] tags to Lua.
20100828 20:59:44< CIA-35> silene * r46063 /trunk/data/lua/wml/items.lua: Fixed tag naming.
20100828 21:01:42< CIA-35> silene * r46064 /trunk/src/scripting/lua.cpp: Marked [story] tag as handled.
20100828 21:04:12< zookeeper> silene, ok, so about that lua ability/special issue: it's a bit hard to give suggestions when i can't really tell how it all works internally now...
20100828 21:04:24< zookeeper> from a WML author POV it'd be nice if i could just add lua code which would get passed the affected unit(s) as parameters and to which my lua code could then do anything it wants, resulting in whatever effect i'm after.
20100828 21:05:37< silene> zookeeper: internally, everything is hardcoded: a function is called when unit resistances are queried, a function is called when defenses are queried, and so on; and each of these functions check for the relevant abilities; it never works the other way around (which we would like, for wml customization)
20100828 21:06:13< zookeeper> right
20100828 21:06:47< zookeeper> sounds a bit hard to add non-messy lua hooks to that
20100828 21:09:22< silene> yes, with the current system, lua functions for each ability would have a different semantic; for instance, the lua function attached to a [resistance] ability would return an integer; the one attached to [invisible] would return a boolean, and so on
20100828 21:09:41< zookeeper> unless you fancy reworking the whole system (which i doubt), maybe it's better to just add new ability tags etc in c++ as usual...
20100828 21:09:50< silene> so, a [defense] ability would still to be hardcoded, if only for the sole purpose of calling the corresponding lua function
20100828 21:10:43< silene> zookeeper: yes, if you can tell me the attributes of a [defense] ability, i can implement it
20100828 21:11:48-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Ping timeout: 240 seconds]
20100828 21:11:56< silene> hmm... i get lots of error when loading LoW 1; either i messed badly, or there is something terribly wrong with this scenario
20100828 21:11:59-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Ping timeout: 258 seconds]
20100828 21:12:32< Crab_> silene: what errors?
20100828 21:12:42< Crab_> I've got r46051 compiled, I can check
20100828 21:12:55< silene> Crab_: wml action tags at scenario level
20100828 21:12:59< zookeeper> silene, oh, that'd be nice! give me a few minutes and i'll check my notes...
20100828 21:13:41< boucman> Crab_: around ?
20100828 21:13:46< Crab_> boucman: yes
20100828 21:14:08< boucman> could you do a quick runthrough of all the patches assigned to you ? 
20100828 21:14:14< Crab_> silene: in r46051, started low 1 at normal difficulty level, hit end turn. no error messages on screen/console
20100828 21:14:21< zookeeper> silene, i think my rather old description in http://gna.org/bugs/?11388 is still good to go
20100828 21:14:29-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20100828 21:14:36< Crab_> boucman: yes, in a few minutes
20100828 21:15:33< silene> Crab_: strange, mine tells me that it encountered [store_unit], [remove_unit_overlay], [clear_variable] at toplevel
20100828 21:16:16< Crab_> silene: that's with r46051, maybe your recent changes made it detect some errors that were not visible before
20100828 21:17:14< silene> Crab_: oh sorry, i misread your revision number, the error messages were introduced in r46060
20100828 21:17:28< Crab_> (compiling latest trunk atm)
20100828 21:20:01< zookeeper> silene, so, the attributes not listed as http://wiki.wesnoth.org/AbilitiesWML#Common_keys_and_tags_for_every_ability are just value= and max_value=
20100828 21:20:39< zookeeper> if you need more info that that, i'll do what i can...
20100828 21:21:39< silene> zookeeper: seems enough for now; i will take care of it once i have found what's going wrong with LoW
20100828 21:24:21< zookeeper> silene, awesome, thanks. in case you weren't aware, that tag will help unravel the big inconsistent village aliasing mess we have now :P
20100828 21:24:34< silene> Crab_: the LOW_PRESTART macro is the culprit; it's at the wrong place in the first scenario (and hence completely ignored)
20100828 21:25:14< silene> Crab_: and in fact, it seems like it is wrong in all the scenarios; was it ever tested?
20100828 21:26:04< Crab_> silene: fendrin added it. it allowed old saves from 1.6 and early 1.7 to be 'upgraded' to have multiple leaders who can reruit
20100828 21:26:23-!- Upthorn [ogmar@adsl-75-26-193-228.dsl.scrm01.sbcglobal.net] has quit [Quit: out back later]
20100828 21:26:45< silene> Crab_: seeing how it is ignored, "allowed" seems a bit farfetched here ;-)
20100828 21:26:49< Crab_> silene: I don't know if it was tested. it causes no bugs for person who plays LoW anew, and those playing from old saves just don't get multiple-leaders-who-can-recruit.
20100828 21:27:00< Crab_> yes, I'm about the intent :)
20100828 21:27:18< Crab_> it's really nice that the engine reports such errors now
20100828 21:28:46< silene> Crab_: i will let you fix it; i don't dare doing it, in case the actual execution of the macro breaks LoW
20100828 21:30:18< Crab_> ok
20100828 21:31:05-!- dtiger_ [~dtiger@dynamic-vpdn-93-125-69-67.telecom.by] has quit [Remote host closed the connection]
20100828 21:32:25< zookeeper> well, that macro seems awfully unnecessary nowadays.
20100828 21:32:47< silene> for 1.9 sure, but what about 1.8?
20100828 21:33:36< zookeeper> well, 1.8 too, if its only purpose is to allow saves from 1.6/1.7 to be loaded...
20100828 21:33:45< zookeeper> (especially if it doesn't even work ;P)
20100828 21:33:45< CIA-35> crab * r46065 /trunk/data/campaigns/Legend_of_Wesmere/utils/low-macros.cfg: fix LOW_PRESTART macro in LoW not being a proper event - this ensures that all the leaders always have canrecruit=yes
20100828 21:34:14< Crab_> zookeeper: the saves would always be loaded, they just won't have the 'multiple leaders who can recruit' feature
20100828 21:34:36< Crab_> zookeeper: still, the WML was not proper and the fix is easy.
20100828 21:36:55-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20100828 21:39:14< CIA-35> silene * r46066 /trunk/ (data/lua/wml-tags.lua src/scripting/lua.cpp): Improved error handling a bit.
20100828 21:42:35< CIA-35> crab * r46067 /branches/1.8/data/campaigns/Legend_of_Wesmere/utils/low-macros.cfg: backport r46065 to branches/1.6 - fix LOW_PRESTART macro not being a proper event - this ensure that old saves are converted to have all the proper leaders with canrecruit=yes
20100828 21:44:14-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20100828 21:44:55< silene> hmm... the test scenario uses the TELEPORT_TILE macro at scenario toplevel, which in turns use [redraw]; this doesn't make sense
20100828 21:47:42< zookeeper> i'd think [teleport] makes equally little sense at scenario toplevel?
20100828 21:47:56< zookeeper> at least i'm not aware of it having any meaning there
20100828 21:48:06< CIA-35> silene * r46068 /trunk/data/scenario-test.cfg: Removed senseless macro expansion.
20100828 21:48:40< silene> right, don't know why i disabled the error message for it, i will reenable it
20100828 21:49:44< CIA-35> silene * r46069 /trunk/src/scripting/lua.cpp: Unmarked [teleport] as handled.
20100828 22:04:18-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20100828 22:06:17< CIA-35> silene * r46070 /trunk/src/unit.cpp: Added a [defense] ability. (Fix for bug #11388.)
20100828 22:07:11< silene> zookeeper: ^ i only tested that it doesn't break the current engine; once you have got your hands on a compiled version, please check that it fits your needs; even better, please a test to the test scenario
20100828 22:14:57< silene> in particular, the values may be backward (no idea whether defense is supposed to increase or decrease internally), so it needs testing
20100828 22:15:50-!- wajimba [~Andrew_Ah@64.202.242.252] has joined #wesnoth-dev
20100828 22:16:41< boucman> zookeeper: still around ?
20100828 22:28:43< CIA-35> boucman * r46071 /trunk/ (15 files in 15 dirs): apply patch #1871 (correct map count for all mainline campaigns) by elvish sovereign. I'll let zookeeper test if that is correct
20100828 22:35:45-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20100828 22:41:52-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20100828 22:44:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20100828 22:50:16< zookeeper> silene, cool, thanks, i'll test it as soon as i get a new build
20100828 22:50:51< zookeeper> boucman, i'll check the diff and fix if there's anything to fix...
20100828 23:01:24-!- ancestral [~ancestral@mobile-166-137-143-237.mycingular.net] has joined #wesnoth-dev
20100828 23:02:41-!- e_s [~elvish_so@pool-173-59-68-133.phlapa.east.verizon.net] has joined #wesnoth-dev
20100828 23:03:34-!- Appleman1234 [~Appleman1@CPE-60-226-176-19.qld.bigpond.net.au] has joined #wesnoth-dev
20100828 23:05:19-!- elvish_sovereign [~elvish_so@pool-108-2-86-247.phlapa.east.verizon.net] has quit [Ping timeout: 265 seconds]
20100828 23:05:19-!- e_s is now known as elvish_sovereign
20100828 23:06:57< alink> silene: note that [defense] will be a bit slow, maybe  a problem for AI and pathfinding.
20100828 23:07:24< alink> But the feature is cool, a unit affecting the def% of adjacent units (allies or enemies) open a new plane of support strategy
20100828 23:08:51< alink> to optimize ability, I always wanted some cache knowing if there is at least one unit having ability X affecting adjacent units
20100828 23:09:29< alink> because it's rare and it's the probably the most expensive part, so we could skip it most of the time
20100828 23:11:26< alink> silene: btw i mean checking [defense] (even when never used) may be a bit slow
20100828 23:13:17< alink> mmmh if the ability used only a terrain filter, then we could simply store its effect in the already coded terrain cache. But that's limited power
20100828 23:15:13-!- ancestral [~ancestral@mobile-166-137-143-237.mycingular.net] has quit [Quit: Smell ya later!]
20100828 23:21:50-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20100828 23:32:20-!- PeterPorty [~Pete@pc-218-249-120-200.cm.vtr.net] has quit [Quit: Saliendo]
20100828 23:51:30-!- mysticX [aid@rbi0332.giga-dns.com] has quit [Quit: Leaving.]
--- Log closed Sun Aug 29 00:00:52 2010