--- Log opened Sat Dec 11 00:00:09 2010
20101211 00:01:28-!- PetePorty [~Pete@pc-21-251-120-200.cm.vtr.net] has quit [Quit: Saliendo]
20101211 00:02:35-!- stikonas_ [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 00:02:35-!- stikonas_ [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 00:02:35-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 00:05:08-!- dipseydoodle [460feb71@gateway/web/freenode/ip.70.15.235.113] has quit [Quit: Page closed]
20101211 00:05:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20101211 00:05:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20101211 00:05:49-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20101211 00:07:17-!- Blueblaze [~Blueblaze@adsl-99-158-44-235.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 272 seconds]
20101211 00:09:23-!- Blueblaze [~Blueblaze@adsl-99-148-246-6.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20101211 00:10:05-!- Appleman1234 [~Appleman1@131.181.211.208] has joined #wesnoth-dev
20101211 00:13:58-!- Upth [ogmar@adsl-75-26-205-134.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 00:14:47-!- Upthorn [ogmar@adsl-75-26-183-134.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 265 seconds]
20101211 00:19:06< CIA-28> fendrin * r47909 /trunk/data/core/encyclopedia/ (_main.cfg geography.cfg): First rugh geography section.
20101211 00:25:44-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20101211 00:26:01-!- Upthorn [ogmar@75.26.208.118] has joined #wesnoth-dev
20101211 00:27:09-!- Upth [ogmar@adsl-75-26-205-134.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20101211 00:35:55-!- stikonas_ [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20101211 00:38:51-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20101211 00:50:14-!- Upth [ogmar@75.26.196.89] has joined #wesnoth-dev
20101211 00:52:58-!- Upthorn [ogmar@75.26.208.118] has quit [Ping timeout: 265 seconds]
20101211 00:59:33-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20101211 00:59:48-!- Ivanovic [~ivanovic@dtmd-4db2fe27.pool.mediaWays.net] has joined #wesnoth-dev
20101211 01:10:31-!- Upth [ogmar@75.26.196.89] has quit [Read error: Connection reset by peer]
20101211 01:10:54-!- Upth [ogmar@adsl-75-26-196-89.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 01:10:54-!- Upth is now known as Upthorn
20101211 01:29:02-!- Upthorn [ogmar@adsl-75-26-196-89.dsl.scrm01.sbcglobal.net] has quit [Read error: Connection reset by peer]
20101211 01:30:31-!- Upth [ogmar@adsl-75-26-211-5.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 01:30:31-!- Upth is now known as Upthorn
20101211 01:37:07-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20101211 01:40:18-!- Upth [ogmar@adsl-75-26-211-5.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 01:41:34-!- Aurora [48df48f0@gateway/web/freenode/ip.72.223.72.240] has joined #wesnoth-dev
20101211 01:42:21-!- Upthorn [ogmar@adsl-75-26-211-5.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20101211 02:02:52-!- Bocom_ [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20101211 02:03:03-!- Bocom [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Read error: Connection reset by peer]
20101211 02:10:14-!- phlaem [~a@e178060139.adsl.alicedsl.de] has joined #wesnoth-dev
20101211 02:16:47-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20101211 02:17:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20101211 02:32:49-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer]
20101211 02:34:26-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20101211 02:35:51-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20101211 02:36:25-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20101211 02:38:07-!- Appleman1234 [~Appleman1@131.181.211.208] has quit [Remote host closed the connection]
20101211 02:53:14-!- phlaem [~a@e178060139.adsl.alicedsl.de] has quit [Quit: Leaving]
20101211 03:00:50-!- Upth [ogmar@adsl-75-26-211-5.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 250 seconds]
20101211 03:02:15-!- Upth [ogmar@adsl-75-26-165-225.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 03:02:15-!- Upth is now known as Upthorn
20101211 03:08:41-!- Dante__ [Dante@nusnet-187-225.dynip.nus.edu.sg] has quit [Ping timeout: 240 seconds]
20101211 03:13:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20101211 03:21:04-!- Upth [ogmar@adsl-75-26-165-225.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 03:21:41-!- Upthorn [ogmar@adsl-75-26-165-225.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20101211 03:45:03-!- Appleman1234 [~Appleman1@131.181.211.208] has joined #wesnoth-dev
20101211 03:50:03-!- Appleman1234 [~Appleman1@131.181.211.208] has quit [Remote host closed the connection]
20101211 03:51:21-!- Upthorn [ogmar@adsl-75-26-203-252.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 03:51:43-!- Upth [ogmar@adsl-75-26-165-225.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20101211 03:54:48-!- Dokem [~reid@c-98-195-128-61.hsd1.tx.comcast.net] has joined #wesnoth-dev
20101211 03:54:53-!- Appleman1234 [~Appleman1@131.181.211.208] has joined #wesnoth-dev
20101211 04:12:29-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20101211 04:13:38-!- iwaim_vs [~iwaim@p3166-ipbf6408marunouchi.tokyo.ocn.ne.jp] has joined #wesnoth-dev
20101211 04:28:22-!- ancestral [~ancestral@174-30-224-142.mpls.qwest.net] has joined #wesnoth-dev
20101211 04:31:51-!- Ivanovic_ [~ivanovic@dtmd-4db2d16c.pool.mediaWays.net] has joined #wesnoth-dev
20101211 04:31:51-!- Ivanovic_ [~ivanovic@dtmd-4db2d16c.pool.mediaWays.net] has quit [Changing host]
20101211 04:31:51-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20101211 04:32:09-!- Zacru [48df48f0@gateway/web/freenode/ip.72.223.72.240] has joined #wesnoth-dev
20101211 04:35:07-!- Ivanovic [~ivanovic@dtmd-4db2fe27.pool.mediaWays.net] has quit [Ping timeout: 240 seconds]
20101211 04:35:56-!- Ivanovic_ is now known as Ivanovic
20101211 04:56:53-!- Dokem [~reid@c-98-195-128-61.hsd1.tx.comcast.net] has quit [Quit: Leaving]
20101211 05:03:21-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has quit [Ping timeout: 265 seconds]
20101211 05:03:28-!- Appleman1234 [~Appleman1@131.181.211.208] has quit [Ping timeout: 250 seconds]
20101211 05:42:28-!- Zacru [48df48f0@gateway/web/freenode/ip.72.223.72.240] has quit [Ping timeout: 265 seconds]
20101211 05:42:57-!- Aurora [48df48f0@gateway/web/freenode/ip.72.223.72.240] has quit [Ping timeout: 265 seconds]
20101211 05:45:45-!- veg^ [~veg@178.125.157.65] has joined #wesnoth-dev
20101211 06:01:38-!- Appleman1234 [~Appleman1@eduroam-gw.er2.uq.cpe.aarnet.net.au] has joined #wesnoth-dev
20101211 06:02:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20101211 06:02:12-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20101211 06:13:32< CIA-28> espreon * r47910 /trunk/data/core/ (3 files in 2 dirs): Ran umcpropfix.
20101211 06:13:35-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20101211 07:18:41-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 265 seconds]
20101211 07:54:04-!- beetlenaut [~dan@70-41-198-155.cust.wildblue.net] has quit [Remote host closed the connection]
20101211 07:56:43-!- beetlenaut [~dan@70-41-198-155.cust.wildblue.net] has joined #wesnoth-dev
20101211 07:58:06-!- rigved [~rigved@116.72.163.243] has quit [Ping timeout: 250 seconds]
20101211 08:01:13-!- Upth [ogmar@adsl-75-26-181-22.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 08:02:52-!- Upthorn [ogmar@adsl-75-26-203-252.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 250 seconds]
20101211 08:15:19-!- Upthorn [ogmar@adsl-75-26-168-77.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 08:16:53-!- Upth [ogmar@adsl-75-26-181-22.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20101211 08:34:28-!- Upth [ogmar@adsl-75-26-163-34.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 08:35:55-!- Upthorn [ogmar@adsl-75-26-168-77.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20101211 08:48:28-!- ancestral [~ancestral@174-30-224-142.mpls.qwest.net] has quit [Quit: And that's the end of THAT chapter]
20101211 09:05:51-!- Upthorn [ogmar@adsl-75-26-167-137.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 09:08:04-!- dtiger [~dtiger@12-243-252-87-dynamic-pool.gprs.mts.by] has joined #wesnoth-dev
20101211 09:08:23-!- Upth [ogmar@adsl-75-26-163-34.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 265 seconds]
20101211 09:13:55-!- timotei [~timotei@193.34.191.4] has joined #wesnoth-dev
20101211 09:13:55-!- timotei [~timotei@193.34.191.4] has quit [Changing host]
20101211 09:13:55-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20101211 09:18:25-!- iwaim___ [~iwaim@ns1.alib.jp] has quit [Remote host closed the connection]
20101211 09:20:24-!- Upth [ogmar@adsl-75-26-186-114.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 09:20:55-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 09:20:55-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 09:20:55-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 09:23:04-!- Upthorn [ogmar@adsl-75-26-167-137.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20101211 09:23:08-!- iwaim [~iwaim@ns1.alib.jp] has joined #wesnoth-dev
20101211 09:38:12-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20101211 09:38:23-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20101211 09:41:30-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20101211 09:50:54-!- Upthorn [ogmar@adsl-75-26-171-4.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 09:52:53-!- Upth [ogmar@adsl-75-26-186-114.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20101211 09:55:53-!- dtiger [~dtiger@12-243-252-87-dynamic-pool.gprs.mts.by] has quit [Read error: Connection reset by peer]
20101211 10:05:07-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20101211 10:06:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20101211 10:06:46-!- Appleman1234 [~Appleman1@eduroam-gw.er2.uq.cpe.aarnet.net.au] has quit [Ping timeout: 276 seconds]
20101211 10:11:00-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20101211 10:11:00-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20101211 10:11:00-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20101211 10:11:14< mordante> servus
20101211 10:15:18< boucman> morning mordante
20101211 10:22:08< mordante> hi boucman 
20101211 10:29:48-!- dtiger [~dtiger@46.56.9.128] has joined #wesnoth-dev
20101211 10:32:05< boucman> timotei: around ?
20101211 10:40:05< Espreon> Ic grete eow.
20101211 10:50:57-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 10:50:57-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 10:50:57-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 10:53:07-!- dtiger [~dtiger@46.56.9.128] has quit [Ping timeout: 240 seconds]
20101211 10:59:58-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20101211 11:00:20-!- negusnyul [~negusnyul@dsl4E5CD9EB.pool.t-online.hu] has joined #wesnoth-dev
20101211 11:01:15-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 11:09:40-!- MeccaGod [MeccaGod@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20101211 11:10:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20101211 11:21:02-!- veg^ [~veg@178.125.157.65] has quit [Remote host closed the connection]
20101211 11:21:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20101211 11:28:57-!- wesbot changed the topic of #wesnoth-dev to: 192 bugs, 305 feature requests, 22 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20101211 11:29:06< timotei> boucman: yeah.
20101211 11:29:16< boucman> timotei: whe you're around, I didn't validate your task, because it lacks a tiny detail : you don't say what software the task is about
20101211 11:29:32< boucman> I think it's the javaplugin, but I wasn't 100% sure so I didn't fill it
20101211 11:29:32< timotei> hmm
20101211 11:29:54< timotei> where should that be said?
20101211 11:29:56< timotei> Installation video tutorial - Wesnoth UMC Plugin - Windows
20101211 11:30:29< boucman> it's called "Video Tutorial/Showcase - template" for me...
20101211 11:31:12< timotei> oh
20101211 11:31:14< timotei> not that :P
20101211 11:31:40< boucman> oh... ok, got it
20101211 11:31:52< boucman> is it ok if i rename it UMC java plugin
20101211 11:31:54< timotei> there are 5 tasks
20101211 11:32:11< timotei> well, ok
20101211 11:32:31< boucman> or else we'll have a video on how to get things from the addon server :P
20101211 11:33:16< boucman> ok, it's approved and published, should I do that for the other video ones ?
20101211 11:33:27< timotei> 2 for bfw trailer
20101211 11:33:30< timotei> and 3 for plugin
20101211 11:33:30< timotei> ok
20101211 11:33:31< timotei> yeah
20101211 11:33:49-!- GNUtoo|laptop [~gnutoo@host237-37-dynamic.117-80-r.retail.telecomitalia.it] has joined #wesnoth-dev
20101211 11:34:15< timotei> though, I gave the people link to the readme 
20101211 11:34:16< timotei> :)
20101211 11:36:18< timotei> but I'll specify that's a java/eclipse plugin in the desription
20101211 11:36:22< timotei> thanks for pointing it out
20101211 11:37:51< boucman> timotei: I assume the template task is not to be published...
20101211 11:38:04< timotei> boucman: yeah, not to be published
20101211 11:39:30< boucman> fendrin: around ?
20101211 11:56:31-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20101211 12:22:26-!- Appleman1234 [~Appleman1@eduroam-gw.er2.uq.cpe.aarnet.net.au] has joined #wesnoth-dev
20101211 12:32:09-!- loonybot [~loonybot@46.138.72.220] has joined #wesnoth-dev
20101211 12:32:09-!- loonybot [~loonybot@46.138.72.220] has quit [Changing host]
20101211 12:32:09-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20101211 12:32:14-!- iwontbecreative [~thibault@89.180.73.127] has joined #wesnoth-dev
20101211 12:32:30< iwontbecreative> hi
20101211 12:33:06-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20101211 12:33:27-!- Gambit [~Gambit@67.232.229.73] has joined #wesnoth-dev
20101211 12:33:27-!- Gambit [~Gambit@67.232.229.73] has quit [Changing host]
20101211 12:33:27-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20101211 12:33:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20101211 12:45:12< Espreon> mordante: http://wesnoth.pastebin.com/2grdR5u8 ... Help! That's what I get when I try to use cl.
20101211 12:50:14-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20101211 13:01:44-!- dtiger [~dtiger@178.168.154.184] has joined #wesnoth-dev
20101211 13:02:29-!- rigved [~rigved@116.72.163.243] has quit [Quit: Bye]
20101211 13:05:20-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20101211 13:35:05< Ivanovic> hi
20101211 13:36:26< timotei> hi
20101211 13:36:27< timotei> :P
20101211 13:40:27< mordante> hi Ivanovic 
20101211 13:41:06 * Espreon wonders if mordante forsook him...
20101211 13:41:51< mordante> Espreon, no just got back and trying to reproduce your issue
20101211 13:42:04< Espreon> Ah.
20101211 13:55:18-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20101211 13:55:30-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20101211 13:58:29< mordante> Espreon, works for me with the latest trunk
20101211 13:59:02< Espreon> Odd...
20101211 13:59:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 240 seconds]
20101211 14:00:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20101211 14:02:03< mordante> I tried with TB and worked, can you test the latest trunk with TB as well?
20101211 14:02:39< Espreon> Of course.
20101211 14:02:52 * Espreon is recompiling at the moment...
20101211 14:03:12< mordante> that took me a while as well ;-)
20101211 14:04:09< iwontbecreative> mordante: Are you planning any big changes to wiki_grabber.py ? I already made many changes to be more "pythonnic"
20101211 14:07:20< mordante> iwontbecreative, what do you mean with pythonnic, maybe post your patch somewhere
20101211 14:07:34< iwontbecreative> Still not finished
20101211 14:08:06< mordante> I don't care ;-) just to see what you mean with more pythonnic
20101211 14:08:10< iwontbecreative> But things like using re.verbose instead of always adding things to the regex
20101211 14:08:26< Espreon> mordante: OK, running make clean and recompiling fixed it. Sorry.
20101211 14:08:46< iwontbecreative> Also some pep8 things and removing unused variables
20101211 14:09:06< mordante> (and I'm not a python coder, nor do I intent to become one, it's just nicer as perl ;-) )
20101211 14:09:15 * Espreon chuckles
20101211 14:09:16< mordante> Espreon, no problem, good to know it works 
20101211 14:09:31< iwontbecreative> mordante: So does this means no ?
20101211 14:09:44< iwontbecreative> Also using things like:
20101211 14:09:55< iwontbecreative> for x in range(len(x)):
20101211 14:10:03< iwontbecreative> is not very elegant
20101211 14:11:38< mordante> iwontbecreative, I expect an update for the patch send yesterday since it doesn't work with python 2.5
20101211 14:12:23< mordante> and probably want to do some cleanup on the number of tables (some are deprecated)
20101211 14:12:23< iwontbecreative> They are also many things that you can do like convert: if x != None and x != "": to if not x:
20101211 14:12:51< mordante> but I don't mind to wait with those things until you did your patch
20101211 14:13:06< iwontbecreative> mordante: First change is just about hardcoded values and more code, so not important for the patch
20101211 14:13:54< iwontbecreative> Second change would be more problematic, because I added a function that removed some code duplication, but this only saved space if they were a lot of tables
20101211 14:14:00-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20101211 14:14:33< mordante> iwontbecreative, some duplicates might be deprecated stuff, but I don't mind cleanup patches
20101211 14:14:37< iwontbecreative> Actually I still have to check for the re.verbose things, because escaping spaces is a bit harder
20101211 14:20:14-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20101211 14:26:18< mordante> iwontbecreative, I finished looking at what I want to change, but I can wait with it until you finished your cleanup patch
20101211 14:26:34< iwontbecreative> mordante: Ok
20101211 14:26:35< mordante> if you're interested I can already tell which direction I want to go
20101211 14:27:30< iwontbecreative> Yep, would be better
20101211 14:31:57< mordante> typing some info
20101211 14:32:06-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Remote host closed the connection]
20101211 14:33:26< iwontbecreative> mordante: You want it to be compatible with 2.5 or even least ?
20101211 14:35:05< mordante> 2.5 since we often see Debian Stable often as lower bound, and I use that OS
20101211 14:35:18< iwontbecreative> Ok
20101211 14:36:10< mordante> iwontbecreative, http://paste.debian.net/102129/ the format for the tables
20101211 14:36:24-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 14:36:24-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 14:36:24-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 14:36:46< mordante> and of course the deprecated table needs to be removed
20101211 14:36:46< iwontbecreative> Ok, this doesn't really affect my changes
20101211 14:36:54< mordante> ok good
20101211 14:36:56< iwontbecreative> What will be the deprecated tables ?
20101211 14:37:27< mordante> s/tables/table/ ;-) create_container_table
20101211 14:38:24< iwontbecreative> I changed some things there, but no problem
20101211 14:39:17< mordante> indeed no problem
20101211 14:40:49-!- Appleman1234 [~Appleman1@eduroam-gw.er2.uq.cpe.aarnet.net.au] has quit [Ping timeout: 240 seconds]
20101211 14:48:50< iwontbecreative> They are still many things that I want to change, but I'll do that after both patches
20101211 14:49:38< iwontbecreative> Removed some deprecated things aswell
20101211 14:50:11< iwontbecreative> Next changes will be to use enumerate and with
20101211 14:59:15-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20101211 15:00:16-!- fstltna [~fstltna@70-7-79-83.pools.spcsdns.net] has joined #wesnoth-dev
20101211 15:08:00< iwontbecreative> mordante: https://gna.org/patch/index.php?2254
20101211 15:08:44< iwontbecreative> Let me know if you find some bugs.
20101211 15:09:03< mordante> iwontbecreative, I will, downloading it now
20101211 15:11:23< mordante> iwontbecreative, just curious but why change to one import per line is that deemed good style?
20101211 15:11:48< iwontbecreative> It's a pep8 change I think
20101211 15:11:58< iwontbecreative> You can change it back if you want
20101211 15:12:19< iwontbecreative> I like to have one import per line so I can check dependencies need faster
20101211 15:13:00< mordante> no I just wondered why you changed it, like I said before I'm no real python hacker
20101211 15:15:01< mordante> iwontbecreative, I'm not happy with not_an_empty_table I rather see empty_table as function
20101211 15:15:17< mordante> in general a boolean function with not in the name makes me frown
20101211 15:15:45< mordante> and since it's usage is not not_an_empty_table for every usage it looks really awkward
20101211 15:16:43-!- dtiger [~dtiger@178.168.154.184] has quit [Ping timeout: 240 seconds]
20101211 15:16:50< iwontbecreative> Yep, wondered what was better at a point
20101211 15:17:02< iwontbecreative> Want me to update the patch ?
20101211 15:17:26< iwontbecreative> You only have to do a search and replace
20101211 15:17:48< iwontbecreative> [Only proble with empty_table is that it could be missread as a way to empty one table.]
20101211 15:18:07< iwontbecreative> [Maybe is_empty_table ?]
20101211 15:19:23-!- MeccaGod [MeccaGod@h14n4fls31o279.telia.com] has quit []
20101211 15:19:32< mordante> is_empty_table is also fine and might be a bit more clearer
20101211 15:20:07< mordante> I want to review the rest of the patch first
20101211 15:21:56< iwontbecreative> ok
20101211 15:23:47-!- Blueblaze [~Blueblaze@adsl-99-148-246-6.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20101211 15:28:46< mordante> iwontbecreative, your patch has an error, if you compare the output of the original with the new version I'll notice a double " after span id=
20101211 15:29:09< iwontbecreative> Ok
20101211 15:29:32< mordante> also are you already in data/core/about.cfg?
20101211 15:29:47< iwontbecreative> Yep, line 199 char 35 needs to be removed
20101211 15:29:55< iwontbecreative> mordante: No
20101211 15:30:09< iwontbecreative> I guess this is about credits ?
20101211 15:30:21-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has joined #wesnoth-dev
20101211 15:30:24< mordante> yep 
20101211 15:30:46< mordante> feel free to add yourself in the section "Miscellaneous Contributors"
20101211 15:32:03-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20101211 15:32:25-!- dtiger [~dtiger@46.56.23.3] has joined #wesnoth-dev
20101211 15:32:37< mordante> could you then post a new patch with the changes as discussed, then I'll commit the modified version
20101211 15:33:27< iwontbecreative> I guess the about.cfg bugs with non Latin char ?
20101211 15:33:41< iwontbecreative> Nvm, it doesn't
20101211 15:34:25< mordante> no it doesn't we have a lot of contributors with non-Latin char eg the Japanese translation team 
20101211 15:40:26-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 15:40:26-!- stikonas [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 15:40:26-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 15:42:26< iwontbecreative> mordante: https://gna.org/patch/index.php?2254
20101211 15:43:33< mordante> ok thanks
20101211 15:50:11< mordante> looks good I only changed the description of is_empty_table slightly
20101211 15:51:22< iwontbecreative> Ok :)
20101211 15:52:07-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 15:52:13< CIA-28> mordante * r47911 /trunk/src/widgets/combo_drag.cpp: 
20101211 15:52:13< CIA-28> Initialize all members.
20101211 15:52:13< CIA-28> Issue found by cppcheck.
20101211 15:52:21< CIA-28> mordante * r47912 /trunk/src/widgets/menu.cpp: 
20101211 15:52:21< CIA-28> Initialize all members.
20101211 15:52:21< CIA-28> Issue found by cppcheck.
20101211 15:52:25< CIA-28> mordante * r47913 /trunk/src/widgets/scrollbar.cpp: 
20101211 15:52:25< CIA-28> Initialize all members.
20101211 15:52:25< CIA-28> Issue found by cppcheck.
20101211 15:52:27< CIA-28> mordante * r47914 /trunk/ (data/core/about.cfg utils/wiki_grabber.py): 
20101211 15:52:27< CIA-28> Applying a cleanup patch for wiki_grabber.py.
20101211 15:52:27< CIA-28> Applying patch #2254 by iwontbecreative.
20101211 16:13:04-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20101211 16:16:03-!- sush [~chatzilla@59.96.62.237] has joined #wesnoth-dev
20101211 16:24:00-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 245 seconds]
20101211 16:27:04< CIA-28> mordante * r47915 /trunk/utils/wiki_grabber.py: Small documentation update for wikigrabber.
20101211 16:27:55-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 16:29:50-!- sush [~chatzilla@59.96.62.237] has quit [Quit: ChatZilla 0.9.86 [Firefox 3.6.3/20100423140709]]
20101211 16:30:43-!- iwontbecreative [~thibault@89.180.73.127] has quit [Ping timeout: 240 seconds]
20101211 16:32:25< fendrin> boucman: hi
20101211 16:36:50-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20101211 16:43:15-!- PetePorty [~Pete@pc-21-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20101211 16:46:21-!- iwontbecreative [~thibault@89-181-35-121.net.novis.pt] has joined #wesnoth-dev
20101211 16:59:59-!- silene [~plouf@wesnoth/developer/silene] has quit [Ping timeout: 272 seconds]
20101211 17:01:18-!- Upth [ogmar@adsl-75-26-171-4.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 17:03:29-!- Upthorn [ogmar@adsl-75-26-171-4.dsl.scrm01.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20101211 17:07:09-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20101211 17:08:35-!- fendrin [~fabi@88-134-73-62-dynip.superkabel.de] has joined #wesnoth-dev
20101211 17:08:35-!- fendrin [~fabi@88-134-73-62-dynip.superkabel.de] has quit [Changing host]
20101211 17:08:35-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20101211 17:10:08-!- rigved [~rigved@116.72.163.243] has quit [Read error: Connection reset by peer]
20101211 17:15:13< CIA-28> fendrin * r47916 /trunk/src/help.cpp: Implemented the extra topics to a race being listed on the sections main page.
20101211 17:16:59< CIA-28> fendrin * r47917 /trunk/data/core/encyclopedia/geography.cfg: More work on the encyclopedia.
20101211 17:18:09< CIA-28> fendrin * r47918 /trunk/data/core/units/drakes/drakes.cfg: Finished transfering the articles from the drakipedia to the races page under units in the help.
20101211 17:19:41-!- vcap_ [~vcap@AReims-551-1-25-205.w86-215.abo.wanadoo.fr] has joined #wesnoth-dev
20101211 17:21:16-!- vcap [~vcap@AReims-551-1-17-86.w90-58.abo.wanadoo.fr] has quit [Disconnected by services]
20101211 17:21:18-!- vcap_ is now known as vcap
20101211 17:24:40-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20101211 17:25:30-!- silene [~plouf@wesnoth/developer/silene] has joined #wesnoth-dev
20101211 17:27:06-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 17:43:58-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20101211 17:49:21< boucman> hey fendrin, still around ?
20101211 17:49:36< fendrin> boucman: yes
20101211 17:50:15< boucman> fendrin: in the non-published task list, there is one from you
20101211 17:50:33< boucman> (low chapter one, normal)
20101211 17:50:48< boucman> is it meant to be published, or should it be deleted, or is it a template ?
20101211 17:51:22< Crab_> boucman: afair, 'should be deleted, as there were playtesting tasks for each difficulty of low,and this particular task was used as the template for them'
20101211 17:52:13< boucman> fendrin: you confirm ?
20101211 17:57:23< fendrin> boucman: yes, it can be deleted
20101211 17:58:31< boucman> k, doing it now
20101211 18:00:14< boucman> done
20101211 18:08:50< fendrin> boucman: I have done some work on the encyclopedia thing.
20101211 18:09:12< fendrin> boucman: There is now c++ code that supports topics inside the [race] tag.
20101211 18:09:29< fendrin> for everything that is race specific information.
20101211 18:09:47< fendrin> I am not satisfied with the toplevel topic being units
20101211 18:10:18< fendrin> The geography part of the encyclopedia on the other hand is already there.
20101211 18:12:21-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20101211 18:12:31< boucman> i personally think that race description should be a sub topic of encyclopedia, since it's not gameplay info (unlike unit descriptions) but that's my opinion, others might disagree
20101211 18:13:22< fendrin> boucman: That is my opinion as well.
20101211 18:13:57< fendrin> Nevertheless, the new feature is useful for providing extra gameplay info as well.
20101211 18:14:55< boucman> indeed, units could now be split into subsections (by level or by faction for example) 
20101211 18:19:20-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20101211 18:20:32< fendrin> boucman: hmmm. No. The unit topics are autogenrated. Haven't changed anything on that. It's only extratopics in [race] that have been added.
20101211 18:20:42< boucman> ok
20101211 18:21:18< fendrin> boucman: But I think that for example some tactic advices can go into the race.
20101211 18:22:21-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has joined #wesnoth-dev
20101211 18:24:26-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 18:24:58< boucman> maybe, well see how it evolves...
20101211 18:26:51-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20101211 18:27:34-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20101211 18:52:38-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 18:57:10-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20101211 19:05:14-!- stikonas_ is now known as stikonas
20101211 19:05:41-!- fstltna [~fstltna@70-7-79-83.pools.spcsdns.net] has quit [Remote host closed the connection]
20101211 19:10:06< CIA-28> mordante * r47919 /trunk/utils/wiki_grabber.py: 
20101211 19:10:06< CIA-28> Let use wikigrabber use parameters.
20101211 19:10:06< CIA-28> This removes the old hard-coded paths, the defaults are the same as the
20101211 19:10:06< CIA-28> hardcoded paths to remain backwards compatible.
20101211 19:10:06< CIA-28> The patch was provided by Natan Yellin as a GCI contribution.
20101211 19:13:24-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 260 seconds]
20101211 19:16:37-!- stikonas_ [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 19:16:37-!- stikonas_ [~and@ctv-213-164-107-237.vinita.lt] has quit [Changing host]
20101211 19:16:37-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20101211 19:16:44-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20101211 19:27:11-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20101211 19:44:45-!- phlaem [~a@e178188216.adsl.alicedsl.de] has joined #wesnoth-dev
20101211 19:51:31-!- dtiger [~dtiger@46.56.23.3] has quit [Ping timeout: 240 seconds]
20101211 19:53:44< iwontbecreative> mordante: I'm adding valid directory checking and use enumerate() when needed.
20101211 19:54:17-!- dtiger [~dtiger@178.168.221.46] has joined #wesnoth-dev
20101211 19:57:54< mordante> iwontbecreative, ok what does enumerate exactly do?
20101211 19:58:32-!- shadowm_laptop [~ignacio@186.9.26.100] has joined #wesnoth-dev
20101211 19:58:49< iwontbecreative> enumerate(["hi", "ok", "lol"])
20101211 19:58:56-!- shadowm_laptop is now known as Guest17466
20101211 19:59:03< mordante> ok
20101211 19:59:39< iwontbecreative> Or http://docs.python.org/library/functions.html#enumerate
20101211 19:59:55-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20101211 20:02:25< zookeeper> Crab_, http://gna.org/bugs/?17206 - i haven't tried to reproduce yet, but he's saying that the leader of a side with [ai] passive_leader=yes [/ai] moved without good reason. know anything about anything like that?
20101211 20:02:53< Crab_> yes, I know that passive_leader is broken atm
20101211 20:03:13< zookeeper> ah, ok, that explains it
20101211 20:03:41< Crab_> will be fixed before new year, one way (via GCI) or another (I'll have a holiday from 20th december)
20101211 20:03:43-!- Grimling [~Grimling@91.181.182.227] has joined #wesnoth-dev
20101211 20:03:58< Crab_> Grimling: hello
20101211 20:04:07< Grimling> Crab_:  hi
20101211 20:04:18-!- Guest17466 [~ignacio@186.9.26.100] has quit []
20101211 20:04:27< Crab_> Grimling: how it's going ? have you looked at the 'passive leader' bugs ?
20101211 20:05:15< Grimling> Crab_:  yes, I've looked at it, not very much (exams), but I haven't found yet where in the code the AI's turn starts
20101211 20:05:40< Grimling> Crab_:  I think I need this place to understand everything better
20101211 20:06:29< zookeeper> Crab_, okay. i'll add a comment and assign to you...
20101211 20:06:34-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20101211 20:06:38< Crab_> Grimling: for the new ai, http://wiki.wesnoth.org/Customizing_AI_in_Wesnoth_1.8#how_AI_works.2C_a_short_developer-oriented_overview
20101211 20:07:00< mordante> thanks iwontbecreative 
20101211 20:07:08< mordante> afk
20101211 20:07:33< Crab_> in /wesnoth/src/ai/testing/stage_rca.cpp , candidate_action_evaluation_loop::do_play_stage()  contains the main loop
20101211 20:07:53< Grimling> Crab_:  thank you, that's usefull
20101211 20:08:21< Crab_> and look, say, at /wesnoth/data/ai/ais/default_ai.cfg
20101211 20:09:08< Crab_> oops, /wesnoth/data/ai/ais/testing_ai_default.cfg
20101211 20:10:32< Crab_> and look at data/core/macros/ai_candidate_actions.cfg and /wesnoth/src/ai/registry.cpp
20101211 20:10:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20101211 20:11:01< Crab_> Grimling: basically, we have one  [stage] with name=testing_ai_default::candidate_action_evaluation_loop 
20101211 20:11:34< Crab_> in registry.cpp, it's translated to c++ class, candidate_action_evaluation_loop (which is located in stage_rca.cpp )
20101211 20:11:39< Crab_> that stage has a number of candidate actions
20101211 20:11:48< Crab_> they are specified via some macro calls
20101211 20:12:05< Crab_> the macros are explained in ai_candidate_actions.cfg - they expand to [candidate_action] tags
20101211 20:12:20< Crab_> and each of those [candidate_action] tags has a name=, as well
20101211 20:12:37< Crab_> and in registry.cpp, each of those tags is translated to a c++ class
20101211 20:13:28< Crab_> for example, {AI_CA_COMBAT}  is expanded to   [candidate_action]         id=combat         engine=cpp         name=testing_ai_default::combat_phase         max_score=100000        score=100000    [/candidate_action] 
20101211 20:13:57< Crab_> and in registry.cpp, we have static register_candidate_action_factory<testing_ai_default::combat_phase>        combat_phase_factory("testing_ai_default::combat_phase");
20101211 20:14:12< Crab_> so, testing_ai_default::combat_phase c++ class is used to run this candidate action.
20101211 20:15:19< Crab_> so, to make passive_leader work, we need to teach all the candidate actions written in c++ to don't use the leader if get_passive_leader() is true.
20101211 20:16:17< Crab_> and to make passive_leader_shares_keep, we need to add an exception to some candidate actions and, if necessary, add a new one for 'keep sharing'
20101211 20:16:49< Crab_> alternatively, just get rid of passive_leader_shares_keep and add a new candidate action which will ignore (purposely) passive_leadere.
20101211 20:17:11< Crab_> but that's two separate tasks. the first is making movement/combat/etc routine obey passive_leader
20101211 20:17:50< Crab_> that requires finding all classes which are c++ candidate actions (see registry.cpp for a list or just check what c++ classes extend candidate_action ) and patching each of those.
20101211 20:19:51< Crab_> for example, for get_healing phase - in get_healing_phase::evaluate, just add a  'if (get_passive_leader() && u.can_recruit()) continue;'  and it'll fix it
20101211 20:20:13< Crab_> --
20101211 20:20:47< Grimling> Crab_:  thanks, that made it a lot clearer
20101211 20:20:58< Crab_> great
20101211 20:21:08< Crab_> ping me when you'll want to have a task for that created.
20101211 20:22:54< Grimling> Crab_:  as soon as they accept the task I've done
20101211 20:23:01< Crab_> ok
20101211 20:24:50< Crab_> (note that some older candidate actions assume we only have 1 leader. this is not true in later versions of wesnoth, we can have multiple leaders here)
20101211 20:25:56< Grimling> Crab_: what do I need to do then?
20101211 20:27:04-!- stikonas__ [~and@ctv-213-164-107-237.vinita.lt] has joined #wesnoth-dev
20101211 20:27:13< Crab_> read the code, find out the logic, fix.
20101211 20:27:19< Crab_> for example, let's check retreat_phase::evaluate 
20101211 20:27:29-!- stikonas_ [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20101211 20:27:35-!- EdB [~edb@tss37-1-89-84-18-220.dsl.club-internet.fr] has quit [Read error: Connection reset by peer]
20101211 20:27:42< Crab_> it uses the leader twice 1) it gets the 1 leader, gets all hexes near him
20101211 20:28:06< Crab_> 2) leaders don't retreat via this stage
20101211 20:28:23< Crab_> (2)  is now checked as unit_map::const_iterator(i) != leader 
20101211 20:28:51< Crab_> easy to reword as   !(i->second.can_recruit())
20101211 20:28:54< Crab_> that leaves (1)
20101211 20:29:00< Crab_> let's see why they need those hexes...
20101211 20:29:19< Crab_> it's explained in the comments -  // If the unit is in range of its leader, it should never retreat -- it has to defend the leader instead.
20101211 20:29:37< Crab_> so, to keep this logic, we need to check how can_reach_leader is found
20101211 20:30:14< Crab_> it's done in a way like 'for each hexes to where our unit can retreat, if it's near leader's position, then we can reach it'
20101211 20:31:11< Crab_> easy to reword as 'let's take all leaders, take all their nearby hexes, make it a set A of hexes;      then for each hexes to where our unit can retreat, if it's in that set A, then we can reach one of the leaders'
20101211 20:32:17< Crab_> note that (2) is needed to fix passive_leader (otherwise second/third/etc leaders will be able to retreat), and (1) is a side fix needed to fix multi-leader behavior, unrelated to passive_leader.
20101211 20:32:32< Crab_> so for the purpose of this task, you can get away with only fixing (2)
20101211 20:33:34< Crab_> for combat_phase, it's best to fix get_attacks() to don't show attacks for the leader if get_passive_leader()
20101211 20:35:25< Crab_> for move to targets phase, such as 'testing_move_to_targets_phase::execute', nothing to fix - leaders dont participate in it, it has the correct can_recruit check already.
20101211 20:37:03< Crab_> looking at the code, get_villages should already honor passive_leader
20101211 20:41:25< Grimling> Crab_:  for the get_attacks, do you mean in contexts.hpp:626? en when get_passive_leader(), what should it return? an empty vector?
20101211 20:41:51< Crab_> (p.s.: when testing, if you run with --log-debug="ai/stage/rca,ai/actions", you'll see the candidate actions being selected and the actions that the ai does)
20101211 20:43:21< Grimling> or in the evaluate itself? 
20101211 20:43:46< Grimling> I don't see a way to check if it's a passive leader in contexts.hpp
20101211 20:44:20< Crab_> attacks are provided indirectly. you can trace it through the code, but better look at src/ai/default/attack.cpp
20101211 20:44:46< Crab_> search for                     if (up->can_recruit()) { 			uses_leader = true; 
20101211 20:44:55< Crab_> it's the place where we see that the attack uses the leader
20101211 20:47:40< Crab_> but note that it's not the 'best' place to check for passive leader
20101211 20:47:57< Crab_> it's better to catch this earlier, when movements for this attack are determined
20101211 20:48:55< Crab_> and that leads us to src/ai/testing/aspect_attacks.cpp
20101211 20:49:49< Crab_> in void aspect_attacks::do_attack_analysis, there'a  loop over units.
20101211 20:49:55< Crab_> I guess that we can add the check there
20101211 20:50:49< Crab_> or we can do it even earlier
20101211 20:51:31< Crab_> in aspect_attacks::analyze_targets(), there's another loop  (where we skip units which don't have attacks left, etc, around 'if (i->side() == get_side() && i->attacks_left()) { ' code)
20101211 20:52:53< Crab_> that's probably the best place to add something like     && !( get_passive_leader() && i->can_recruit() )
20101211 20:53:35-!- negusnyul [~negusnyul@dsl4E5CD9EB.pool.t-online.hu] has quit [Ping timeout: 245 seconds]
20101211 20:53:42-!- prkc [~negusnyul@dsl4E5CD9EB.pool.t-online.hu] has joined #wesnoth-dev
20101211 20:54:07< Grimling> Crab_:  r78?
20101211 20:54:26-!- prkc is now known as negusnyul
20101211 20:54:35< Crab_> yes
20101211 20:58:42-!- stikonas__ is now known as stikonas
20101211 20:59:40< stikonas> Crab_: If I press "Needs more work" in melange, will student get some more time to complete the work?
20101211 21:00:00< Crab_> stikonas: yes, you will be able to input the number of additional hours you give them
20101211 21:00:14< stikonas> thanks
20101211 21:00:19< Crab_> when you select 'needs more work', a edit field is made visible for that
20101211 21:01:08< stikonas> Yes, I see it now
20101211 21:05:54-!- negusnyul [~negusnyul@dsl4E5CD9EB.pool.t-online.hu] has quit [Ping timeout: 250 seconds]
20101211 21:06:28-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20101211 21:10:03-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 21:12:41-!- rigved [~rigved@116.72.163.243] has quit [Quit: Bye]
20101211 21:15:59< Grimling> Crab_:  is there a method to find all leaders? or do I just need to make a loop?
20101211 21:17:00< Crab_> no, but you can add a method to src/unit_map.?pp, near unit_map::unit_iterator unit_map::find_leader(int side)
20101211 21:17:24< Crab_> let it return a std::vector of unit_map iterators, or something like that
20101211 21:18:02< Grimling> Crab_:  ok
20101211 21:19:06< Grimling> Crab_:  const or normal iterators? or both?
20101211 21:20:00< Crab_> both. note how you can implement const versions by delegating to non-const version and using a const_cast
20101211 21:20:11< Crab_> ( it's done in unit_map.hpp for find_leader )
20101211 21:21:22< Grimling> Crab_:  yes, that's why I was asking
20101211 21:25:00-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20101211 21:25:48< Grimling> can I cast a std::vector<unit_map::unit_iterator> to const std::vector<unit_map::const_unit_iterator> ?
20101211 21:26:23< mordante> no const_iterator and iterator are two different beasts
20101211 21:27:15< Crab_> it works for find_leader by casting to 'unit_map *' first ..
20101211 21:28:54< Grimling> Crab_:  but I mean directly, without a loop to copy and cast each leader
20101211 21:29:34< Crab_> I think, yes. try
20101211 21:30:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20101211 21:31:07< Crab_> if not, you can use something like\  std::copy(a->begin(), a->end(), std::back_inserter(b)); 
20101211 21:32:54< iwontbecreative> mordante: Done those changes
20101211 21:33:04< iwontbecreative> I only needed to use enumerate once.
20101211 21:33:36< iwontbecreative> Overall the file is a bit shorter than before, but we have safe reading and directory checking now.
20101211 21:33:44< iwontbecreative> Submitting a patch
20101211 21:35:01< mordante> ok nice
20101211 21:38:08< iwontbecreative> mordante: https://gna.org/patch/index.php?2255
20101211 21:38:30< iwontbecreative> No python error and shouldn't change anything in the output
20101211 21:39:06-!- Bocom_ [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Ping timeout: 240 seconds]
20101211 21:43:31< mordante> ok thanks, looking into it now
20101211 21:46:07< mordante> interesting now I learn how to write nice looking Python ;-P
20101211 21:46:39< iwontbecreative> The thing about range(len(x)) is really common for other languages coders
20101211 21:48:34< mordante> yeah just like if(foo == bar): instead of if foo == bar:
20101211 21:48:55< iwontbecreative> Yes
20101211 21:49:10< mordante> but the i[x] looks much better, just wasn't aware it was possible
20101211 21:50:14< mordante> with the if I prefer the `if(foo == bar):' but the other method seems the `python way'
20101211 21:51:14< iwontbecreative> well, in most python codes you'll see if x == y and not if(x == y)
20101211 21:51:32< iwontbecreative> The parenthesis are generally used for complex statements
20101211 21:52:01-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20101211 21:52:21< mordante> yeah I looked at wmllint after your initial change of that style and it used the if x == y: as well
20101211 21:52:39< mordante> so was a good indication that that's the python way ;-)
20101211 21:54:06-!- Bocom [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20101211 21:55:54< mordante> iwontbecreative, when you enter an invalid directory you get an error message and then a stacktrace is the latter intended or did you want to abort the program?
20101211 21:56:23< iwontbecreative> Oh, forgot that :(
20101211 21:56:32< mordante> one other small comment
20101211 21:56:42< iwontbecreative> Not sure, is it better to rest to default values or stop the programm ?
20101211 21:57:05< iwontbecreative> *reset
20101211 21:57:11-!- Bocom [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has quit [Client Quit]
20101211 21:57:17< mordante> I prefer "Argument '%s' isn't a directory." instead of "Argument %s isn't a directory." the extra quotes show the argument better
20101211 21:57:43< mordante> best stop the default also may not be valid
20101211 21:58:04< mordante> and if the user ask for directory foo and gets the default s/he might be surprised
20101211 21:58:23< iwontbecreative> Yep, right
20101211 21:58:29< iwontbecreative> I'll raise an error
20101211 21:58:35-!- Blueblaze [~Blueblaze@adsl-99-148-246-6.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20101211 21:58:37< mordante> further the patch seems to work output is still the same :-)
20101211 21:59:33-!- PetePorty [~Pete@pc-21-251-120-200.cm.vtr.net] has quit [Quit: Saliendo]
20101211 22:01:21-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20101211 22:03:33-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 22:03:55-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds]
20101211 22:07:04-!- un214 [~un214@adsl-75-45-10-238.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 22:11:53-!- Grimling [~Grimling@91.181.182.227] has quit [Quit: Grimling]
20101211 22:14:18-!- un214 [~un214@adsl-75-45-10-238.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20101211 22:15:10< iwontbecreative> mordante: https://gna.org/patch/index.php?2255 Sorry, had forgot to upload the updated version
20101211 22:15:53< iwontbecreative> It also includes a small enhancement to GCI's student patch
20101211 22:20:58< mordante> ok, will look at it in a sec
20101211 22:23:12< iwontbecreative> Btw: is wmllint meant to throw an exception and stop after finding a wml mistake ?
20101211 22:23:40< mordante> I'm no wmllint expert, but I assume it's supposed to keep going
20101211 22:24:14< mordante> iwontbecreative, I just added a new GCI task for converting the wiki_grabber input format
20101211 22:24:22< shadowmaster> iwontbecreative: nope, it's a bug.
20101211 22:24:56-!- knotwork [~markm@142.177.233.245] has quit [Ping timeout: 265 seconds]
20101211 22:25:26-!- knotwork [~markm@142.177.233.245] has joined #wesnoth-dev
20101211 22:27:59< CIA-28> mordante * r47921 /trunk/utils/wiki_grabber.py: 
20101211 22:27:59< CIA-28> Cleanup and hardening patch for wiki_grabber.py.
20101211 22:27:59< CIA-28> Using more standard Python code and protects against non-existing input
20101211 22:27:59< CIA-28> or output directories. (Patch 2255.)
20101211 22:28:09< CIA-28> mordante * r47920 /trunk/src/gui/auxiliary/canvas.cpp: Fix indention.
20101211 22:30:40-!- ABCD [~abcd@gentoo/developer/abcd] has quit [Ping timeout: 245 seconds]
20101211 22:31:54< mordante> iwontbecreative, accepted your claim
20101211 22:32:00< iwontbecreative> Thanks
20101211 22:32:22< mordante> I think you deserved it
20101211 22:32:45< mordante> do you have questions regarding the task?
20101211 22:32:51< iwontbecreative> Yes.
20101211 22:33:48< iwontbecreative> There's nothing done with new format, right ?
20101211 22:35:07-!- ABCD [~abcd@gentoo/developer/abcd] has joined #wesnoth-dev
20101211 22:35:42< mordante> jein, dialog_widgets almost is the new format but instead of @begin{table}[dialog_widgets] it should become @begin{table}{dialog_widgets}
20101211 22:35:58< mordante> the other tables use a rather hacky format
20101211 22:36:08< mordante> and need to be fully converted
20101211 22:37:39< iwontbecreative> Ok
20101211 22:38:05< iwontbecreative> I'll just take a glance at the wmllint bug before I do this
20101211 22:38:56< iwontbecreative> wmllint maintainer is esr, right ?
20101211 22:39:05< mordante> yes
20101211 22:40:24< iwontbecreative> esr: When "[unit_type]" is incorrectly spelled/not here, wmllint crashes
20101211 22:40:42< esr> Hm.
20101211 22:42:00< esr> What do you nab by "not here"? That is, where is it expwcted but missing?
20101211 22:42:27< iwontbecreative> Yes
20101211 22:42:47< iwontbecreative> Try to remove [unit_type] from an unit, then launch wmllint
20101211 22:47:51-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 22:48:23< esr> Huh? Where does [unit_type] occur inside a [unit]?  I thought it was a separate eclaration.
20101211 22:48:47< mordante> I'm off night
20101211 22:50:07-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Excess Flood]
20101211 22:50:44< iwontbecreative> esr: Sorry if I'm not clear. This: #textdomain wesnoth-units
20101211 22:50:45< iwontbecreative> [unit_type]
20101211 22:50:45< iwontbecreative> is the start of a wesnoth core unit. If you remove [unit_type], wmllint will crash
20101211 22:51:05-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20101211 22:51:17< esr> Oh.  In that case, I'm not a bit surprised.  Don't do that :-)
20101211 22:51:58< esr> wmmlint can't be robust againstall possible deformed inputs.  The code is complicated enough as it is.
20101211 22:52:24< iwontbecreative> Ok.
20101211 22:52:40< iwontbecreative> It was just the first test I had in mind, as it's the first line.
20101211 22:53:00< iwontbecreative> I reckon most people won't do this in real work files
20101211 22:56:30< shadowmaster> WML people
20101211 22:56:37< shadowmaster> suggest a syntax to integrate color range and stuff for UMC
20101211 22:58:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 23:00:13-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Remote host closed the connection]
20101211 23:00:14-!- Bocom [~Bocom@c-8dcde255.013-31-6b736412.cust.bredbandsbolaget.se] has joined #wesnoth-dev
20101211 23:02:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20101211 23:02:54-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Excess Flood]
20101211 23:04:53-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 23:06:17-!- un214 [~un214@adsl-75-45-10-238.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20101211 23:06:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20101211 23:08:27-!- dtiger [~dtiger@178.168.221.46] has quit [Read error: Connection reset by peer]
20101211 23:13:54-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Changing host]
20101211 23:13:54-!- Gambit [~Gambit@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20101211 23:14:09-!- Gambit [~Gambit@unaffiliated/gambit/bot/gambot] has quit [Changing host]
20101211 23:14:09-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20101211 23:14:34-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 276 seconds]
20101211 23:19:14-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20101211 23:20:50-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20101211 23:22:08-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 23:27:16-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 265 seconds]
20101211 23:28:57-!- wesbot changed the topic of #wesnoth-dev to: 193 bugs, 305 feature requests, 22 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://wesnoth.pastebin.com | http://imagebin.org
20101211 23:29:39-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20101211 23:31:01-!- Mussious [~kamil@dfx51.neoplus.adsl.tpnet.pl] has quit [Remote host closed the connection]
20101211 23:32:33-!- PetePorty [~Pete@pc-21-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20101211 23:33:46-!- iwaim_vs [~iwaim@p3166-ipbf6408marunouchi.tokyo.ocn.ne.jp] has quit [Quit: Loqui]
20101211 23:35:12-!- iwaim_vs [~iwaim@p3166-ipbf6408marunouchi.tokyo.ocn.ne.jp] has joined #wesnoth-dev
20101211 23:40:18< shadowmaster> [B[B/69
20101211 23:40:55-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 23:40:55-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Excess Flood]
20101211 23:41:32-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20101211 23:43:46< CIA-28> ivanovic * r47922 /trunk/ (6 files in 5 dirs): updated Finnish translation
20101211 23:51:25< iwontbecreative> mordante is not here, but does somebody knows if the new format for wiki should be the one in wiki (@start{table}{type}) or the one in code (@begin{table}[type])
20101211 23:51:38< iwontbecreative> I know that [type] should be {type}
20101211 23:51:43-!- Aurora [48df48f0@gateway/web/freenode/ip.72.223.72.240] has joined #wesnoth-dev
20101211 23:51:53< iwontbecreative> But don't know if it's begin or start
20101211 23:52:12< Aurora> Where is crab when you need him?
20101211 23:52:22< boucman> hehe
20101211 23:52:48< boucman> Aurora: I think he reads the logs, so you can always ask your question...
20101211 23:53:08< Aurora> I need to get a time extension on my task.
20101211 23:53:28< boucman> iwontbecreative: reverse engineer wiki_grabber :)
20101211 23:54:37< Ivanovic> Aurora: make sure to post something in the task so that Crab_ sees the reason right in the task
20101211 23:54:41-!- GNUtoo|laptop [~gnutoo@host237-37-dynamic.117-80-r.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds]
20101211 23:54:59< boucman> yes, good idea, commenting a task sens a message to the mentor...
20101211 23:55:30< iwontbecreative> Which goes often to spam :D
20101211 23:56:06< boucman> not true, some good filtering can easily keep them out of spam
20101211 23:56:37< iwontbecreative> Yes, was talking about the bug with gmail :D
20101211 23:57:27< iwontbecreative> Aurora: If the time remaining is really short, you can submit a dummy file as work submission and in the comment ask for more time, no ?
20101211 23:57:52< boucman> what happen if you completely run out of time ?
20101211 23:58:25< iwontbecreative> Task is forcely reopenned
--- Log closed Sun Dec 12 00:00:16 2010