--- Log opened Sat Apr 16 00:00:57 2011
20110416 00:03:07-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 00:03:15-!- eoc is now known as eoc|off
20110416 00:05:22-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 00:06:54-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20110416 00:08:42-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 250 seconds]
20110416 00:13:36-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 00:13:39-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 258 seconds]
20110416 00:20:43< Upthorn> oh hey, this is the same bug I ran into during the last GSoC period, with the parsing of [trait] tags
20110416 00:20:54< Crab_> )))
20110416 00:21:23< Upthorn> my workaround was to change [trait] to [object]
20110416 00:21:39< Upthorn> http://svn.gna.org/viewcvs/wesnoth/trunk/data/scenario-test.cfg?r1=44852&r2=44972
20110416 00:22:51< Upthorn> as it turns out
20110416 00:22:56< Upthorn> that's not really a long term solution
20110416 00:27:37< Upthorn> I think I can prevent the error from occuring by changing the {}s around 	if (!mod_description.empty()) {
20110416 00:27:57< Upthorn> so that add_trait_description is only called if there is actually a description
20110416 00:32:55< AI0867> fendrin: pong
20110416 00:33:29-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 00:34:49< fendrin> AI0867: What do you think about merging the editor branch back to trunk in the near future?
20110416 00:34:49-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 00:35:03< fendrin> AI0867: I would like to have it in before the gsoc starts.
20110416 00:36:18< fendrin> AI0867: So I will remove features that are harder to implement. Labels are the most evil thing around.
20110416 00:36:35-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 276 seconds]
20110416 00:37:13-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 00:39:24-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110416 00:43:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20110416 00:43:15-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has joined #wesnoth-dev
20110416 00:45:05-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 258 seconds]
20110416 00:51:30-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110416 00:51:42-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 00:56:11-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 248 seconds]
20110416 00:56:40-!- Blueblaze [~Blueblaze@adsl-76-202-19-162.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110416 00:57:02-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 00:59:27-!- wesbot changed the topic of #wesnoth-dev to: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 199 bugs, 312 feature requests, 21 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110416 01:01:48< Upthorn> hooray, my change fixed it
20110416 01:03:18< CIA-82> upthorn * r49222 /trunk/src/unit.cpp: Only call add_trait_description if the trait actually has a description. Otherwise we crash on windows for undescribed traits.
20110416 01:03:23-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 01:03:40-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 252 seconds]
20110416 01:03:50-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 01:05:34-!- Blueblaze [~Blueblaze@adsl-76-202-19-162.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110416 01:05:34-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 01:06:46-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 01:07:37-!- loonycyborg_ [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110416 01:07:38-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Ping timeout: 250 seconds]
20110416 01:08:13-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Ping timeout: 260 seconds]
20110416 01:14:17< timotei> hif e
20110416 01:14:18< timotei> hi fendrin 
20110416 01:14:31< fendrin> timotei: hi
20110416 01:14:39< timotei> oh. you're still here
20110416 01:15:13< timotei> >D
20110416 01:15:45< timotei> fendrin: I'm gonna go soon, again, it's already 2 AM here :(
20110416 01:15:47-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 252 seconds]
20110416 01:16:35< fendrin> timotei: Okay
20110416 01:16:58< timotei> fendrin: do you want to tell me something?
20110416 01:17:41-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Remote host closed the connection]
20110416 01:20:18-!- Blueblaze [~Blueblaze@adsl-76-202-19-162.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110416 01:21:03-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 01:23:14-!- Blueblaze [~Blueblaze@76.202.19.162] has joined #wesnoth-dev
20110416 01:28:29-!- ancestral [~ancestral@198.228.224.172] has joined #wesnoth-dev
20110416 01:32:44-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110416 01:33:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110416 01:33:53< AI0867> fendrin: I'm not aware of the status of the branch, other than that it compiles
20110416 01:34:12-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 01:34:30-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20110416 01:34:41-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 240 seconds]
20110416 01:36:07-!- LordNasty [~NaSTy@93.43.149.208] has joined #wesnoth-dev
20110416 01:36:07-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 01:42:00-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110416 01:46:15-!- LordNasty [~NaSTy@93.43.149.208] has quit [Ping timeout: 260 seconds]
20110416 01:52:31< ancestral> elias: http://forums.wesnoth.org/viewtopic.php?f=17&t=33582
20110416 01:53:30< anonymissimus> Crab_: (hope you're reading logs)
20110416 01:54:04-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 01:54:16< anonymissimus> the get_sides_set function should be moved to the side_filter and exposed as wesnoth.get_sides or something  in the lua interface I think
20110416 01:54:44< anonymissimus> this gets problematic with the side filter functionalities otherwise, for the lua tags
20110416 01:55:11-!- ancestral [~ancestral@198.228.224.172] has quit [Quit: Smell ya later!]
20110416 01:55:14< anonymissimus> off now
20110416 01:55:18< Upthorn> is it possible to create or set labels from Lua?
20110416 01:55:27< anonymissimus> yes
20110416 01:55:32< anonymissimus> what do you want
20110416 01:55:37< Upthorn> I want to double-check that I'm pushing x and y in the correct order
20110416 01:55:55< Upthorn> by making a label on the resulting hex
20110416 01:56:20< anonymissimus> call wesnoth.wml_actions.label({ text = "bla", x = x, y = y }) or something (untested)
20110416 01:56:56< Upthorn> thanks
20110416 01:58:23-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20110416 02:00:48-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 246 seconds]
20110416 02:01:26< Upthorn> looks like I had an off-by-one error
20110416 02:01:47< Upthorn> I guess due to c++ indexing from 0 and wml indexing from 1
20110416 02:03:59-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 02:04:35-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 02:06:14< CIA-82> upthorn * r49223 /trunk/ (data/ai/scenarios/scenario-lua-ai.cfg src/ai/lua/core.cpp): exposed suitable_keep(unit) to Lua AI library. Added test of AI.suitable_keep to lua ai test scenario.
20110416 02:06:14-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 02:09:48-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 258 seconds]
20110416 02:10:37-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 02:14:05-!- rigved [~rigved@116.72.163.243] has quit [Ping timeout: 276 seconds]
20110416 02:20:48-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110416 02:27:29-!- Nephro [~Dmitry@80.233.231.12] has quit [Read error: Connection reset by peer]
20110416 02:34:59-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 02:37:16-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 02:38:08-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 276 seconds]
20110416 02:39:52-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 02:51:11-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 240 seconds]
20110416 02:58:17-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 03:05:22-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 03:07:43-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 03:12:02-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 264 seconds]
20110416 03:13:20-!- LordNasty [~NaSTy@93.43.149.208] has joined #wesnoth-dev
20110416 03:14:35-!- eoc|off [~eoc@pD95609BD.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20110416 03:14:35-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 252 seconds]
20110416 03:18:25-!- LordNasty [~NaSTy@93.43.149.208] has quit [Ping timeout: 260 seconds]
20110416 03:18:36-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 03:18:48-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
20110416 03:19:24-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110416 03:19:27-!- Upth is now known as Upthorn
20110416 03:22:15-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
20110416 03:22:31-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110416 03:22:31-!- Upth is now known as Upthorn
20110416 03:26:57-!- eoc|off [~eoc@pD95611E6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110416 03:35:41-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 240 seconds]
20110416 03:35:47-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 03:37:49-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 03:39:54-!- sheraff [~Tri@c-98-196-106-93.hsd1.tx.comcast.net] has joined #wesnoth-dev
20110416 03:41:04-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 03:45:29-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 240 seconds]
20110416 03:48:47-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 03:52:25-!- loonycyborg_ [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20110416 04:03:36-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: System reboot in progress (up 10 days, 18:06)]
20110416 04:05:23-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110416 04:06:12-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 04:08:16-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 04:09:30-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110416 04:13:41-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 276 seconds]
20110416 04:14:39-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 04:36:36-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 04:38:43-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 04:39:17-!- Ivanovic_ [~ivanovic@dtmd-4d0bf13f.pool.mediaWays.net] has joined #wesnoth-dev
20110416 04:39:20-!- Ivanovic_ [~ivanovic@dtmd-4d0bf13f.pool.mediaWays.net] has quit [Changing host]
20110416 04:39:20-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110416 04:42:51-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds]
20110416 04:43:07-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 276 seconds]
20110416 04:43:15-!- Ivanovic_ is now known as Ivanovic
20110416 04:43:33-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110416 04:53:32-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110416 04:57:35< Espreon> AI0867: Thanks.
20110416 05:06:57-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 05:09:10-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 05:14:29-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 252 seconds]
20110416 05:27:45-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110416 05:37:21-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 05:39:01-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 276 seconds]
20110416 05:39:01-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 05:39:46-!- happygrue_ [~George@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20110416 05:52:03-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 05:54:19-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 06:00:51-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20110416 06:00:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20110416 06:03:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110416 06:22:28-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 06:24:46-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 06:26:09-!- Blueblaze [~Blueblaze@76.202.19.162] has quit [Quit: Blueblaze]
20110416 06:29:41-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has quit [Ping timeout: 240 seconds]
20110416 06:42:29-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 06:44:43-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 06:59:27-!- wesbot changed the topic of #wesnoth-dev to: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 198 bugs, 312 feature requests, 21 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110416 07:01:25-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110416 07:12:53-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 07:13:01-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110416 07:15:10-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 07:17:06-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20110416 07:32:19-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110416 07:33:34-!- epyon [~IceChat77@89-73-132-59.dynamic.chello.pl] has quit [Read error: Connection reset by peer]
20110416 07:36:52-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has quit [Ping timeout: 246 seconds]
20110416 07:43:15-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 07:45:16-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 07:47:46< CIA-82> espreon * r49224 /trunk/po/ (3 files in 3 dirs): Updated the Old English translation.
20110416 07:59:16-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110416 08:04:00-!- sheraff [~Tri@c-98-196-106-93.hsd1.tx.comcast.net] has quit [Read error: Connection reset by peer]
20110416 08:13:40-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 08:15:43-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 08:25:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 08:28:08-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20110416 08:28:26< mordante> servus
20110416 08:35:26-!- vultraz [~chatzilla@124.109.10.191] has quit [Ping timeout: 258 seconds]
20110416 08:35:26-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 258 seconds]
20110416 08:35:37-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20110416 08:35:37-!- Topic for #wesnoth-dev: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 198 bugs, 312 feature requests, 21 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110416 08:35:37-!- Topic set by wesbot [~wesbot@asteria.debian.or.at] [Sat Apr 16 06:59:27 2011]
20110416 08:35:38[Users #wesnoth-dev]
20110416 08:35:38[ 5EXACG1HJ   ] [ erl      ] [ knotwork      ] [ Smar     ] 
20110416 08:35:38[ ABCD        ] [ Espreon  ] [ lobby         ] [ Soliton  ] 
20110416 08:35:38[ AI0867      ] [ esr      ] [ LordNasty     ] [ stikonas ] 
20110416 08:35:38[ ancestral   ] [ ettin_   ] [ mcsmash       ] [ Tigge    ] 
20110416 08:35:38[ apoi        ] [ fendrin  ] [ MGoods|RangerM] [ tschmitz ] 
20110416 08:35:38[ Appleman1234] [ fstltna  ] [ mordante      ] [ Upthorn  ] 
20110416 08:35:38[ automagic   ] [ Greywhind] [ noy           ] [ vcap     ] 
20110416 08:35:38[ chris|      ] [ harbin   ] [ Rhonda        ] [ Vorpal   ] 
20110416 08:35:38[ CIA-82      ] [ Ingmar   ] [ shadowm_laptop] [ vultraz  ] 
20110416 08:35:38[ clanehin_   ] [ isaac_   ] [ shadowmaster  ] [ wesbot   ] 
20110416 08:35:38[ elias       ] [ Ivanovic ] [ shikadibot    ] [ zookeeper] 
20110416 08:35:38[ eoc|off     ] [ iwaim___ ] [ Sirp          ] 
20110416 08:35:38-!- Irssi: #wesnoth-dev: Total of 47 nicks [0 ops, 0 halfops, 0 voices, 47 normal]
20110416 08:35:45-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009
20110416 08:36:46-!- Irssi: Join to #wesnoth-dev was synced in 79 secs
20110416 08:44:05-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 08:46:10-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 09:02:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20110416 09:14:21-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20110416 09:14:21-!- Topic for #wesnoth-dev: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 198 bugs, 312 feature requests, 21 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110416 09:14:21-!- Topic set by wesbot [~wesbot@asteria.debian.or.at] [Sat Apr 16 06:59:27 2011]
20110416 09:14:21[Users #wesnoth-dev]
20110416 09:14:21[ 5EXACG1HJ   ] [ eoc|off  ] [ knotwork      ] [ Soliton  ] 
20110416 09:14:21[ ABCD        ] [ erl      ] [ lobby         ] [ stikonas ] 
20110416 09:14:21[ AI0867      ] [ Espreon  ] [ LordNasty     ] [ Tigge    ] 
20110416 09:14:21[ ancestral   ] [ esr      ] [ mcsmash       ] [ tschmitz ] 
20110416 09:14:21[ apoi        ] [ ettin_   ] [ MGoods|RangerM] [ Upthorn  ] 
20110416 09:14:21[ Appleman1234] [ fendrin  ] [ mordante      ] [ vcap     ] 
20110416 09:14:21[ automagic   ] [ fstltna  ] [ noy           ] [ Vorpal   ] 
20110416 09:14:21[ boucman     ] [ Greywhind] [ Rhonda        ] [ vultraz  ] 
20110416 09:14:21[ chris|      ] [ harbin   ] [ shadowm_laptop] [ wesbot   ] 
20110416 09:14:21[ CIA-82      ] [ Ingmar   ] [ shadowmaster  ] [ zookeeper] 
20110416 09:14:21[ clanehin_   ] [ isaac_   ] [ shikadibot    ] 
20110416 09:14:21[ Crendgrim   ] [ Ivanovic ] [ Sirp          ] 
20110416 09:14:21[ elias       ] [ iwaim___ ] [ Smar          ] 
20110416 09:14:21-!- Irssi: #wesnoth-dev: Total of 49 nicks [0 ops, 0 halfops, 0 voices, 49 normal]
20110416 09:14:25-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009
20110416 09:14:26-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 09:15:28-!- Irssi: Join to #wesnoth-dev was synced in 74 secs
20110416 09:16:37-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 09:21:58-!- mode/#wesnoth-dev [+o shadowmaster] by ChanServ
20110416 09:22:24-!- mode/#wesnoth-dev [-bo *!*@ip-62-143-120-102.unitymediagroup.de shadowmaster] by shadowmaster
20110416 09:24:28-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110416 09:34:28-!- molgrum [~molgrum@h-188-80.A189.priv.bahnhof.se] has joined #wesnoth-dev
20110416 09:34:32-!- molgrum [~molgrum@h-188-80.A189.priv.bahnhof.se] has left #wesnoth-dev []
20110416 09:44:47-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 09:46:29-!- MeccaGod [majs@81.231.147.14] has joined #wesnoth-dev
20110416 09:46:29-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 09:49:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 248 seconds]
20110416 09:51:39< boucman> automagic: i'm still trying to meet you if you are around...
20110416 09:59:58-!- dtiger [~dtiger@dynamic-vpdn-93-125-68-69.telecom.by] has joined #wesnoth-dev
20110416 10:02:06< automagic> boucman: Hi
20110416 10:02:53< automagic> Sorry for yesterday. I spent the whole day with my dad.
20110416 10:03:18< boucman> yes, I kind of guessed you were away, no big deal...
20110416 10:03:30< boucman> I commited your patch :)
20110416 10:03:39< automagic> Great :)
20110416 10:03:49< automagic> I will try to finish the unit tests today.
20110416 10:04:11< automagic> I have some questions regarding testing btw.
20110416 10:04:18< boucman> how do you unit-test ? using the test scenario ?
20110416 10:04:22< boucman> sure, 
20110416 10:04:34< automagic> Wouldn't it be a good idea to disable logging for tests?
20110416 10:05:38< automagic> The messages regarding failures should give enough information about what's wrong and all these warnings that show up make finding the real errors a bit harder when they occur.
20110416 10:05:49< boucman> ???
20110416 10:06:13< boucman> i'm not sure what you are talking about, I don't have that many warnings when running wesnoth...
20110416 10:06:14< automagic> The unit tests often test things that should give warning messages
20110416 10:06:44< automagic> And these messages are kind of annoying
20110416 10:07:04< automagic> not when running wesnoth but when running ./test
20110416 10:07:26< automagic> after "make test"
20110416 10:08:08< automagic> although it's rather "make test ; cd .. ; build/test ; cd build"
20110416 10:09:19< automagic> To answer your question I'm trying to write the tests using the existing Boost.Test framework
20110416 10:09:34-!- Grimling [~FKint@91.181.49.70] has joined #wesnoth-dev
20110416 10:10:34< automagic> I have created a src/tests/test_image_modifications.cpp file and have written a bunch of test cases for correct modification parsing.
20110416 10:12:24< automagic> Btw, you told me that when someone is creating a file he or she should write his or her name in the header or something like that. What is the correct format?
20110416 10:13:37< boucman> automagic: in that case, you didn't really create the file, you renamed it (a fact I missed when I reviewed your patch) so no big deal...
20110416 10:13:49< boucman> it's for the copyright in the standard header you copied
20110416 10:14:11< automagic> Yes but this time I'm really creating a new file.
20110416 10:14:59< boucman> ok :)
20110416 10:15:08-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 10:15:19< boucman> just look at the header of any file, it has a copyright header with a name
20110416 10:16:05< automagic> Is the first line automatically generated?
20110416 10:16:24< boucman> yes
20110416 10:16:49< boucman> automagic: if you finish early there is a small coding task I'd like you to do...
20110416 10:17:00< automagic> Ok
20110416 10:19:16-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 10:36:53-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 10:42:03< mordante> automagic, the debug output in the unit tests can be both, helpful and annoying
20110416 10:42:23< boucman> pipe grep pipe gvim :P
20110416 10:42:29< mordante> automagic, when that test passes it's annonying but can be helpful when you want to ignore that test
20110416 10:43:50< mordante> but if you want to can send the output to a custom logger
20110416 10:44:08< mordante> see test_grid in tests/gui/iterator.cpp
20110416 10:44:29< automagic> I usually like to have minimal amount of messages when all the tests pass.
20110416 10:44:33< mordante> if you do that on function level and don't print the output it's easy to enable it when needed
20110416 10:44:47-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110416 10:45:00< mordante> if they pass yes, but when a test fails it would be nice to see the output of that function
20110416 10:45:09< mordante> hence the helpful and annoying
20110416 10:45:33-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 10:45:33< mordante> I just think it should be enabled per test and not globally
20110416 10:46:21< automagic> I guess you're right
20110416 10:47:07< mordante> and for example in that file I validate the output of the logger against the expected output
20110416 10:47:31< mordante> do you want to work on a patch for it, or shall I
20110416 10:49:43-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 10:53:10< mordante> timotei, did you see my messages regarding MSVC in the log yesterday?
20110416 10:56:22< automagic> The problem is that a lg::set_log_domain_severity("all", -1); wouldn't only work for one test suite. Since the log is global this call would affect all the tests that follow.
20110416 10:57:07< mordante> automagic, did you look at test_grid in tests/gui/iterator.cpp ?
20110416 10:57:15< automagic> yes
20110416 10:58:01< mordante> I was thinking about using the lg::tredirect_output_setter
20110416 10:58:06< automagic> but it does the same thing - it sets the log domain severity
20110416 10:58:15< mordante> so it logs to a std::stringstream and then never print it
20110416 10:58:17< automagic> it affects all the other tests, doesn't it?
20110416 10:58:27< Ivanovic> moin
20110416 10:58:30< mordante> hi Ivanovic 
20110416 10:58:44< automagic> the only thing is that no other test uses that log domain
20110416 10:59:09< mordante> automagic, actually the setting of the severity happens in caller of test_grid
20110416 10:59:45< mordante> automagic, lg::tredirect_output_setter is scoped, so restores the original logger when it goes out of scope
20110416 10:59:54< mordante> hence the extra scopes in test_grind
20110416 10:59:58< mordante> test_grid
20110416 11:00:41< automagic> but there is also a lg::set_log_domain_severity("gui/iterator", 3) call in the test case?
20110416 11:00:53< automagic> aaa
20110416 11:01:04< mordante> yes that is special and I don't propose that as general solution
20110416 11:01:11< automagic> ok, it actually sets the logging to higher sensitivity
20110416 11:01:40< automagic> ok
20110416 11:02:02< automagic> I'll use the redirection method for my tests.
20110416 11:02:52< mordante> ok
20110416 11:03:09< mordante> do you also want to update the rest of the tests?
20110416 11:04:23-!- Octalot [~noct@host109-157-80-211.range109-157.btcentralplus.com] has joined #wesnoth-dev
20110416 11:06:19< automagic> I can.
20110416 11:07:31< CIA-82> mordante * r49225 /trunk/src/gui/auxiliary/window_builder/ (control.cpp horizontal_listbox.cpp slider.cpp): Fix some whitespace issues in the wiki grabber.
20110416 11:07:32< boucman> anybody able to compile/test under windows around ?
20110416 11:07:35< CIA-82> mordante * r49226 /trunk/ (src/gui/widgets/settings.cpp utils/wiki_grabber.py): 
20110416 11:07:35< CIA-82> Improve the wiki grabber validation.
20110416 11:07:35< CIA-82> Also add escapes for & and $ in a table and use it at one place.
20110416 11:09:00< mordante> ok thanks
20110416 11:13:17-!- negusnyul [~negusnyul@dsl4E5CC609.pool.t-online.hu] has joined #wesnoth-dev
20110416 11:15:37< mordante> boucman, automagic wesnoth -t crashes upon startup, in image::mod_ptr_comparator_::operator()
20110416 11:15:47< mordante> does that ring any bells?
20110416 11:15:53< boucman> indeed...
20110416 11:15:57-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 11:16:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110416 11:16:07-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20110416 11:16:19< boucman> though I tested that case before comitting...
20110416 11:16:23< boucman> updating svn now
20110416 11:17:07< mordante> seems to call a null pointer function
20110416 11:17:17-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 11:19:25< Ivanovic> elias: are you maintaining the units.w.o scripts?
20110416 11:19:25-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 11:19:35< Ivanovic> if yes, maybe you could have a look at this one: http://forums.wesnoth.org/viewtopic.php?f=17&t=33582
20110416 11:20:35< boucman> mordante: works for me... that's weird
20110416 11:21:38< mordante> I've some local modifications, but at least the pointers in the function are deferred before being tested
20110416 11:23:04< boucman> could you post a BT ?
20110416 11:23:25< timotei> mordante: hi
20110416 11:23:29< timotei> mordante: yes. I'm testing now.
20110416 11:23:39< timotei> but I've added the warning to the solution ;)
20110416 11:23:44< timotei> though didn't commit it yet :)
20110416 11:23:53< timotei> was trying to get opemp working xD
20110416 11:24:21< mordante> boucman, http://paste.debian.net/114203/
20110416 11:24:25< boucman> thx
20110416 11:28:36< mordante> timotei, ok, I queued up some changes but working on some more patches at the moment
20110416 11:29:21< boucman> automagic: can you reproduce/debug ?
20110416 11:30:29< boucman> mordante: in load_image_sub_file() could you give me the value of val_.modifications_ if you still have it ?
20110416 11:32:55< timotei> boucman: should I try to see if openmp has the same issue as on linux with the busy threads?
20110416 11:32:56< mordante> boucman, recompiling with debug symbols
20110416 11:34:05< timotei> boucman: before trying the execv hack?
20110416 11:36:18< boucman> timotei: that would be nice, note that the current trunk didn't compile for you yesterday...
20110416 11:36:31< boucman> it's a one line change, though, I could guide you
20110416 11:36:33< timotei> boucman: yes. I've modified the unsigned
20110416 11:36:35< timotei> :P
20110416 11:36:40< boucman> oh, good :P
20110416 11:36:41< timotei> (I've seen your patch already xD)
20110416 11:36:44< boucman> and it works now ?
20110416 11:36:46< automagic> boucman: It doesn't seem to happen for me.
20110416 11:36:53< timotei> it's still compiling :)
20110416 11:36:57< boucman> mkay...
20110416 11:37:09< boucman> mordante: i'm afraid we'll have to remote-debug with you
20110416 11:37:56< automagic> if it crashes on mod_ptr_comparator_::operator() that would have to mean that one of the modification*s compared is NULL, which shouldn't happen
20110416 11:38:13< boucman> indeed, that's what I thought too
20110416 11:38:22< boucman> any idea how to figure out where this comes from ?
20110416 11:38:33< automagic> the modification::decode checks adds only non null modifications
20110416 11:39:21< automagic> I would write a function to print the modification_queue
20110416 11:39:30< mordante> automagic, in general I prefer asserts on the pointers so if it fails for a user it gives a nice error
20110416 11:39:50< boucman> good point...
20110416 11:39:51< automagic> or maybe to print the modification*s in operator() of the comparator
20110416 11:40:04< mordante> also not that I use the debug libraries of gcc, so the might be UB which works for you and fails for me
20110416 11:40:25< boucman> UB ?
20110416 11:40:31< automagic> a simple assertion of not being null would be a good idea
20110416 11:40:35< mordante> undefined behaviour
20110416 11:40:45< mordante> automagic, why not?
20110416 11:40:55< mordante> sorry I misread
20110416 11:42:40< mordante> the debug binary is still compiling
20110416 11:45:15< mordante> timotei, in r49180 I noticed NDEBUG is set in MSVC is that on purpose?
20110416 11:46:56< mordante> boucman, automagic the value of val_.modifications_ is "~RC(red>purple)~RC(blue>black)"
20110416 11:47:12< mordante> also switched to a clean checkout without local modifications
20110416 11:47:53< boucman> k
20110416 11:48:23< boucman> nothing really suspicious here (though I'm not sure we have a black palette, but we probably do)
20110416 11:53:15-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds]
20110416 11:55:31< timotei> mordante: lemme check
20110416 11:57:17< timotei> mordante: http://www.kernel.org/doc/man-pages/online/pages/man3/assert.3.html
20110416 11:57:26< timotei> mordante: according to that, NDEBUG doesn't generate the assert code
20110416 11:57:37-!- automagic [~karol@87-205-250-240.adsl.inetia.pl] has quit [Ping timeout: 246 seconds]
20110416 11:58:18< timotei> so maybe it's on purpose
20110416 11:58:51< mordante> I know what NDEBUG does ;-)
20110416 11:58:55< timotei> oh
20110416 11:58:58< timotei> ops, boucman 
20110416 11:59:02< timotei> d:\work\gw\src\game.cpp(2395) : error C3861: 'setenv': identifier not found
20110416 11:59:23< boucman> oookay...
20110416 11:59:28< boucman> let's google for a bit
20110416 11:59:28< mordante> just that we assert on a lot of places and kind of assume the code stops if it fails
20110416 11:59:51< timotei> oh. and you mean that NDEBUG should not be defined?
20110416 11:59:55< timotei> that's for Release mode btw
20110416 12:01:00< mordante> ok, just wondered whether on purpose
20110416 12:01:12< timotei> lemme check something
20110416 12:01:18-!- negusnyul [~negusnyul@dsl4E5CC609.pool.t-online.hu] has quit [Remote host closed the connection]
20110416 12:01:50-!- harbin [poke@dsl-jklbrasgw2-fea0f800-138.dhcp.inet.fi] has quit []
20110416 12:03:39< boucman> timotei: try this http://pastebin.com/pDy4YBcD
20110416 12:03:40< timotei> mordante: on a ... blank MSVC project, that define is defined by default.
20110416 12:03:49< timotei> mordante: so it's set there by "microsoft" xD
20110416 12:04:05< boucman> (minor changes to game.cpp, a new include and move setenv to _setenv within the win #ifdef
20110416 12:05:05< timotei> ok trying :)
20110416 12:05:48< mordante> timotei, yeah that doesn't mean it's the proper setting for wesnoth ;-)
20110416 12:06:17-!- negusnyul [~negusnyul@dsl4E5CC609.pool.t-online.hu] has joined #wesnoth-dev
20110416 12:09:01< timotei> mordante: good point
20110416 12:09:11< timotei> boucman: 1>d:\work\gw\src\game.cpp(84) : fatal error C1083: Cannot open include file: 'env.h': No such file or directory
20110416 12:09:27< boucman> hmm
20110416 12:09:32-!- harbin [poke@dsl-jklbrasgw2-fea0f800-138.dhcp.inet.fi] has joined #wesnoth-dev
20110416 12:10:36-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev
20110416 12:10:36-!- automagic [~karol@77-253-88-162.adsl.inetia.pl] has joined #wesnoth-dev
20110416 12:10:57< automagic> I have recompiled after svn update, changed the modifications to "~RC(red>purple)~RC(blue>black)" and still everything works fine.
20110416 12:13:22< Nephro> wesbot, seen Crab_
20110416 12:13:23< wesbot> Nephro: The person with the nick Crab_ last spoke 11h 52m ago.  11h 21m ago they left with the message: Quit: Leaving.
20110416 12:14:55< boucman> automagic: I don't think we will be able to reproduce, try to remote debug with crab, post patches on pastebin to help him debug
20110416 12:15:18< boucman> timotei: afk for 10' then i'm back to you
20110416 12:16:36< timotei> boucman: ok. Take your time
20110416 12:16:41< timotei> I need to refactor a bit my timeline >P
20110416 12:16:43< timotei> :P*
20110416 12:21:03-!- Qbunia [540aafbf@gateway/web/freenode/ip.84.10.175.191] has joined #wesnoth-dev
20110416 12:21:21< Nephro> Why in the world could an object suddenly lose the value of his members and replace them with gibberish? :D Everything is cool, it does all the calculations fine, but the I press Step Into aaaaaand the member variables go insane
20110416 12:21:50< mordante> Nephro, did you see my message I left you in the log?
20110416 12:21:58< Nephro> mordante, hi, no
20110416 12:22:03< Nephro> I'll look it up
20110416 12:22:15< mordante> Nephro, best do so, since your code is really odd
20110416 12:24:13< Nephro> mordante, oh that one I solved, I just had to take a closer look on it, and the error was obvious :) But thanks for checking it out
20110416 12:24:58< Nephro> I've acquired a new one, though :(
20110416 12:25:24< Nephro> fendrin, morning, you wanted to talk to me yesterday?
20110416 12:25:32< boucman> timotei: could you disable completely the ifdef OPENMP in game.cpp so we can see if it's needed at all in windows
20110416 12:25:42< timotei> boucman: well, I'm currently trying to...
20110416 12:25:52< timotei> get the VCOMP90d.dll ȘÂ
20110416 12:25:53< timotei> :|
20110416 12:26:38< timotei> I wonder where I can get that from
20110416 12:27:09< boucman> huh ?
20110416 12:27:14< timotei> ok. found it xD
20110416 12:27:37< timotei> cap
20110416 12:27:39< timotei> crp
20110416 12:28:13-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20110416 12:28:35< Nephro> mordante, and that wasn't actually odd, I told Crab that I have that rubbish there when I gave it to him, because I was in a hurry, and didn't intend to post that patch... But he said I should, so I just threw what was there. And those lines were only for debug reasons, I somehow tend to add things to the code, break it all down to really small pieces, etc
20110416 12:28:36-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 12:28:39< timotei> WOW:O
20110416 12:28:50< boucman> did wesnoth cause that ?
20110416 12:28:57< timotei> umm... had to log off
20110416 12:29:05-!- automagic [~karol@77-253-88-162.adsl.inetia.pl] has quit [Ping timeout: 240 seconds]
20110416 12:29:09< timotei> because, it started an infinite wesnoth starting
20110416 12:29:11< timotei> :|
20110416 12:29:14< timotei> lemme check
20110416 12:29:34< boucman> when you disabled my code ???
20110416 12:29:41< timotei> no. with the current code
20110416 12:29:45< timotei> is that even working for you?
20110416 12:29:52< boucman> hmm, I thought the current code didn't compile
20110416 12:30:02< timotei> I removed the setenv thingy
20110416 12:30:06< timotei> and used: system("OMP_WAIT_POLICY=PASSIVE");
20110416 12:30:16< boucman> hmm
20110416 12:30:19< timotei> boucman: but wait. the execv will be executed forever
20110416 12:30:23< timotei> causing an avalanche execvs
20110416 12:30:25< AI0867> timotei: under windows, I believe you should add 'set' in front of that
20110416 12:30:36< timotei> oh. yeah
20110416 12:30:46< timotei> AI0867: I use cygwin all the time, and forgot about it xD
20110416 12:31:13< AI0867> timotei: under unix, you should use setenv unless you use the variable on the same line
20110416 12:31:14-!- automagic [~karol@77-253-107-122.adsl.inetia.pl] has joined #wesnoth-dev
20110416 12:31:24< timotei> let's try again
20110416 12:31:48< timotei> ok, it works now
20110416 12:31:55< AI0867> as in: setenv LC_ALL="nl_NL.UTF-8";./wesnoth -t  *OR*  LC_LALL="nl_NL.UTF-8" ./wesnoth -t
20110416 12:31:56< timotei> it still spawned some consoles, but it's ok
20110416 12:32:15< boucman> k
20110416 12:32:33< timotei> I'm stupid. I've commented the execv thingy
20110416 12:32:37< timotei> that's why it works
20110416 12:32:45< timotei> and yeah, the system("set whatever") doesn't work
20110416 12:32:54< timotei> as it seems for each set, it opens another console windows :(
20110416 12:33:33< timotei> boucman: so, we are at missing the env.h right?
20110416 12:33:39< timotei> we were*
20110416 12:34:11< boucman> timotei: I can't find a good documentation for windows API to set it :(
20110416 12:34:21< timotei> lemme check
20110416 12:34:27< AI0867> perhaps execve?
20110416 12:34:38 * Nephro thinks he found the last error in his code
20110416 12:35:14< timotei> haha
20110416 12:35:23< timotei> intuitive as always: http://msdn.microsoft.com/en-us/library/ms686206%28v=vs.85%29.aspx
20110416 12:35:32< AI0867> http://msdn.microsoft.com/en-us/library/hyw61wtd.aspx
20110416 12:36:51< mordante> Nephro, ok, since I'm about to leave I've no time to look at your other issue
20110416 12:37:07< Nephro> mordante, I've seem to found it
20110416 12:37:21< mordante> ok good
20110416 12:38:09< mordante> automagic, have a close look at your for loop in locator::load_image_sub_file
20110416 12:38:45< mordante> and what it exactly does
20110416 12:39:47< automagic> mordante: It removes all the modifications from the queue applying them to the surface and deleting after use, doesn't it?
20110416 12:42:05< AI0867> mordante: windows should contain execv() in process.h
20110416 12:42:28< timotei> boucman: ok, not the SetEnvironmentVariable way
20110416 12:42:30< automagic> mordante: Do you see something wrong with that loop?
20110416 12:42:45< timotei> boucman: since you need to include <windows.h> and that will conflict with some already defined macros by SDL_Net
20110416 12:42:53< timotei> so AI0867's way is better
20110416 12:43:35< boucman> automagic: look some more :)
20110416 12:43:52< AI0867> er, boucman
20110416 12:44:04< mordante> automagic, yes I know what's wrong just want you to find it as well
20110416 12:44:26< boucman> AI0867: it's called _execv and we solved that part yesterday, but thx
20110416 12:44:39< boucman> now we are trying to find a windows equivalent of setenv
20110416 12:44:41< AI0867> boucman: no, I mean windows should have a version without the underscore too
20110416 12:44:44< AI0867> according to wikipedia
20110416 12:44:53< mordante> automagic, also thing about what data structure you loop upon
20110416 12:45:34< timotei> AI0867: http://msdn.microsoft.com/en-us/library/ms235416.aspx
20110416 12:45:51< AI0867> lovely...
20110416 12:45:59< timotei> xD
20110416 12:46:17< AI0867> how is it ISO C++ conformant?
20110416 12:47:18< timotei> IDK
20110416 12:49:43< automagic> mordante: I'm sorry, but the loop looks fine to me. It checks if it's empty, gets the top element applys it, deletes it, pops, and so on until it's empty.
20110416 12:50:38< timotei> fendrin: I've updated the proposal's timeline :)
20110416 12:50:59< boucman> hmm, how experienced are you with STL containers ?
20110416 12:51:27< automagic> I have some experience. I don't use priority_queue that often
20110416 12:52:26< mordante> automagic, what do you think happens when you pop an element from a priority queue
20110416 12:53:20< automagic> The top element gets removed from the queue.
20110416 12:53:24< timotei> http://www.parashift.com/c++-faq-lite/how-to-post.html#faq-5.4
20110416 12:53:30< timotei> Do not top-post. In other words, don't type your reply above the previous author's text. Even if top-posting seems "natural" or "obvious" or "better," don't do it — it's not the comp.lang.c++ "way."
20110416 12:53:40< timotei> is this the netiquette for all other mailing lists?
20110416 12:53:53< timotei> for me it seems it's better to see the reply at the start of the message, isn't it?
20110416 12:54:06< timotei> rather than scrolling though quotes from a ton of other replies
20110416 12:54:15-!- negusnyul_ [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has joined #wesnoth-dev
20110416 12:54:17< mordante> automagic, good and now I have a debug library, what else would you do as sanity check when removing an item
20110416 12:54:59< automagic> check if there is an item in the queue?
20110416 12:55:15< Ivanovic> boucman, zookeeper: http://forums.wesnoth.org/viewtopic.php?f=4&t=33588
20110416 12:55:48< Ivanovic> boucman: http://forums.wesnoth.org/viewtopic.php?f=4&t=33589
20110416 12:56:13< mordante> automagic, yes anything else you like to check just to be sure everything is fine?
20110416 12:56:19-!- eoc|off is now known as eoc
20110416 12:56:32-!- Grimling [~FKint@91.181.49.70] has quit [Quit: Leaving]
20110416 12:56:48< mordante> (automagic, we just hope you find the issue, normally I would directly tell what the problem is)
20110416 12:56:57-!- negusnyul [~negusnyul@dsl4E5CC609.pool.t-online.hu] has quit [Ping timeout: 240 seconds]
20110416 12:56:59< boucman> Ivanovic: noted, i'll give it a try
20110416 12:57:06< Ivanovic> boucman: thanks
20110416 12:58:59< automagic> mordante: The elements gets destroyed ofc, but a pointer is just like an int - it doesn't have a destructor. 
20110416 12:59:59< boucman> automagic: almost there...
20110416 13:00:24-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110416 13:01:10-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110416 13:01:12< mordante> automagic, true, in which function did it crash
20110416 13:01:15< automagic> According to cplusplus.com nothing else happens (at least of the things noticable by the programmer)
20110416 13:01:27< boucman> timotei: ok, _putenv("OMP_WAIT_POLICY=PASSIVE") seems to be the way to go, but I can't find what include to add
20110416 13:01:31-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 248 seconds]
20110416 13:01:48< automagic> mordante: Aaah
20110416 13:01:57-!- mjs-de [~mjs-de@d117203.adsl.hansenet.de] has joined #wesnoth-dev
20110416 13:01:59< mordante> automagic, that's why it crashes in my debug version and not in your normal version
20110416 13:02:04< automagic> So to update the heap it has to make a check?
20110416 13:02:20< automagic> It doesn't
20110416 13:02:38< timotei> boucman: ok. so, I've compiled wesnoth with openmp
20110416 13:02:44< boucman> great
20110416 13:02:45< mordante> and what do you want to check to test whether the priority queue is valid?
20110416 13:02:47< automagic> The underlying heap has a pointer to the top element ready.
20110416 13:02:49< timotei> boucman: started the httt scenario 1
20110416 13:02:58< boucman> do you see 100% cpu usage
20110416 13:02:59< timotei> I'm looking at the ... 2 units
20110416 13:03:25< timotei> not at all
20110416 13:03:26< boucman> ok, need to run, i'll catch on the log when returning
20110416 13:03:35< timotei> maximum 50 or so, when moving my mouse over the terrain xD
20110416 13:03:40< timotei> so... not a problem at all
20110416 13:03:40< boucman> so you probably don't need to tweak the env, then
20110416 13:03:45< timotei> (plus I run on debug !
20110416 13:03:47< timotei> :P
20110416 13:03:49< timotei> so no optimizations
20110416 13:03:52< timotei> yes.
20110416 13:03:58< timotei> that's required only for linux from what I see
20110416 13:04:12< Ivanovic> timotei: how many cores do you have?
20110416 13:04:13< timotei> oh. I've disabled some animations
20110416 13:04:15< timotei> Ivanovic: 2
20110416 13:04:19-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20110416 13:04:22< Ivanovic> 50% would still mean one core completely used
20110416 13:04:22< timotei> Ivanovic: intel pentium dual core 2.0ghz
20110416 13:04:28< automagic> mordante: The restructuring of the heap shouldn't take into account the removed element.
20110416 13:04:44< Ivanovic> could you turn animations off and check cpu usage?
20110416 13:04:46< mordante> true
20110416 13:04:49< Ivanovic> (meaning: animated terrains)
20110416 13:05:10< timotei> http://dl.dropbox.com/u/462510/Capture.PNG
20110416 13:05:10< mordante> automagic, can you tell me the properties of a priority queue?
20110416 13:05:22< timotei> Ivanovic: yes. they are turned off
20110416 13:05:26< Ivanovic> boucman: i don't know the exact symptoms of the openmp problems, but i think windows measures cpu usage differently than linux
20110416 13:05:44< timotei> Ivanovic: that is, the "Animate terrain" option in advanced preferences is "No"
20110416 13:05:45< automagic> the top element is allways the maximum or minimum according to some comparison function
20110416 13:05:49< Ivanovic> that is: on linux the 1.0 for cpu usage means that one core is completely used, where on windows 100% means all cores are compltely used
20110416 13:05:50< boucman> timotei: ok, let's test it different
20110416 13:06:15< Ivanovic> timotei: ah, okay, this looks okayish to me, as if there is no busy waiting
20110416 13:06:23< boucman> please start wesnoth from the CLI with OMP_WAIT_POLICY forced to passive from the command line and look if it changes cpu usage
20110416 13:06:24< mordante> automagic, good, so what do you want to check if you modify the priority queue
20110416 13:06:56< Ivanovic> boucman: do you think once this problem is solved, a new release might make sense?
20110416 13:07:28< boucman> Ivanovic: we need to block the release for that, but after that, it's your decision :)
20110416 13:07:29< automagic> mordante: When you add or remove an element you have to restructure the heap after changes.
20110416 13:07:57< Ivanovic> and if it was not done yet, please mention the usage of openmp in the RELEASE_NOTES so that i also know what to tell the packagers (new dependency if wanted, ...)
20110416 13:07:57-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Read error: Connection reset by peer]
20110416 13:08:25< mordante> automagic,  not per se it reserves memory and may not give it back when you remove an element 
20110416 13:08:30< automagic> mordante: I don't think there is an explicit check anywhere to make sure the top element is the good one. That should always be the case if adding and removing are correctly implemented and would be inefficient.
20110416 13:08:36< Ivanovic> boucman: considering that this is/was a real issue with 1.9.5 a release of 1.9.6 shortly after it being fixed sounds like a good approach to me
20110416 13:08:42< mordante> automagic, (at least quite sure about it)
20110416 13:08:51-!- Johannes13 [~Johannes@p5DF74AAA.dip.t-dialin.net] has joined #wesnoth-dev
20110416 13:08:51-!- Johannes13 [~Johannes@p5DF74AAA.dip.t-dialin.net] has quit [Changing host]
20110416 13:08:51-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110416 13:09:17< mordante> automagic, yes of course, that's why I asked about debug sanity checks ;-)
20110416 13:09:33< mordante> so what happens if I test the order when popping an element?
20110416 13:10:15< automagic> mordante: Yes, but it is reserved for the modification* and not for the modification, so the delete shouldn't affect the queue. The removed element should not be used in the reordering.
20110416 13:11:27< mordante> automagic, not for the reordering, but what if I want to test the element removed really had the same or higher priority as the next element
20110416 13:11:52< timotei> boucman: the same :)
20110416 13:12:17-!- epyon [~IceChat77@89-73-132-59.dynamic.chello.pl] has joined #wesnoth-dev
20110416 13:13:16< automagic> mordante: On priority_queue::pop the last element replaces the first and then it is recursively checked against its children and swapped with the bigger child if it is smaller. The popped element's value (which in this case is the modification) is overwritten with the value of that element.
20110416 13:13:48-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110416 13:14:07-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 258 seconds]
20110416 13:14:58< automagic> mordante: A decent implementation wouldn't do any unnecessary checks.
20110416 13:15:30< mordante> automagic, I told you I use a debug version of the library so it _does_ unnecessary checks
20110416 13:15:40< mordante> that's also why it fails for me and not for you
20110416 13:15:57< loonycyborg> boucman: Note that msvc is not used to make the official binaries but mingw, so it'll still use gcc's gomp.
20110416 13:16:15< mordante> so what happens if I test the order of _all_ elements when popping?
20110416 13:16:33< automagic> mordante: But that changes the contracts of the priority_queue
20110416 13:16:36< loonycyborg> If gomp even works with mingw in which I'm not sure.
20110416 13:18:36< automagic> mordante: The priority_queue shouldn't expect the top element to be valid on pop. With that debug version the contract changes and the element has to be valid.
20110416 13:19:58< automagic> mordante: The code can be easily changed to pop before delete, but assuming the priority_queue behaves as it should be the code I have written is correct.
20110416 13:20:46< mordante> automagic, are you sure it's allowed to be not valid? 
20110416 13:22:28-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110416 13:23:17-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev
20110416 13:26:38< mordante> automagic, I'm about to leave, can you give me a reference that supports your assertion?
20110416 13:26:44< automagic> mordante: I think so. I haven't read the c++ standard specification or anything, but the fact that the element has to be valid isn't pointed out anywhere and I don't think it is uncommon to delete the element before popping.
20110416 13:26:59< automagic> mordante: I don't have one.
20110416 13:27:26< mordante> I quickly glanced over (a draft) of the standard and it seems to expect elements to be valid
20110416 13:28:08< automagic> mordante: Ok. In that case I will change the code to pop before deleting. Sorry.
20110416 13:28:17< mordante> pop_heap requires the range [first, last) to be a valid range
20110416 13:28:48< mordante> also if code fails even not confirm to the standard it's the code that needs to be changed
20110416 13:29:18< mordante> we want to support a large range of compilers so need to adapt our code to those compilers
20110416 13:29:38< automagic> mordante: I understand.
20110416 13:30:22< mordante> for example the standard allows export templates, most compilers do not support that (and never will)
20110416 13:30:45< mordante> so it makes no sense to export templates if you're the lucky one with a compiler that supports it
20110416 13:32:00< mordante> I'm off now
20110416 13:32:04-!- eoc` [~eoc@pD9560E9C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110416 13:32:04< automagic> cya
20110416 13:32:08-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20110416 13:34:12-!- Crendgrim [~crend@77-22-173-219-dynip.superkabel.de] has quit [Remote host closed the connection]
20110416 13:34:49-!- eoc [~eoc@pD95611E6.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20110416 13:35:55-!- eoc` is now known as eoc
20110416 13:45:14 * Nephro got his code working, welcome lua aspects
20110416 13:45:44-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20110416 13:52:07< boucman> automagic: whe your patch is ready please post it in pastebin rather than patches.wesnoth.org
20110416 13:52:14< boucman> since i'm around it will be faster
20110416 13:52:39< boucman> timotei: could you do the counter test ? start it with OMP_WAIT_POLICY=ACTIVE and see if it changes anything
20110416 13:52:57< boucman> loonycyborg: interesting... would you be able to test with mingw
20110416 13:55:25< loonycyborg> mingw that is installed in my winxp VM doesn't offer gomp either.
20110416 13:55:42< boucman> google to the rescue...
20110416 13:56:02< loonycyborg> I'll probably need to switch to another mingw distro.
20110416 13:56:50< boucman> ok, there is OMP support in mingw, though as you said, your build may vary
20110416 13:57:35< loonycyborg> http://mingw-w64.sourceforge.net/ <- I was planning to try this one eventually.
20110416 14:09:45< timotei> boucman: lemme check
20110416 14:10:17-!- FAAB [~huajie@219.142.239.253] has joined #wesnoth-dev
20110416 14:15:47< timotei> boucman: the same
20110416 14:16:16< timotei> boucman: I think it uses just what when it needs  :)
20110416 14:17:41< boucman> my guess is msvc doesn't check that env var, it's a hint IIRC*
20110416 14:17:59< timotei> IDK
20110416 14:18:30< automagic> boucman: Ok
20110416 14:19:13-!- vultraz [~chatzilla@124.109.10.191] has quit [Ping timeout: 260 seconds]
20110416 14:21:28< loonycyborg> boucman: Are you planning to add more openmp code?
20110416 14:21:39< loonycyborg> For now only one loop is parallelized.
20110416 14:21:52< boucman> loonycyborg: it's a huge loop
20110416 14:22:16< boucman> and no, I don't plan to... Crab is the one that probably will do some OMP stuff in AI
20110416 14:22:16< loonycyborg> That makes me think how easy it would be to use boost::thread instead :P
20110416 14:23:23< boucman> loonycyborg: I'm not expoert in boot::thread, but the point of OMP is to add a dose of multi-core in single threaded application, boots::thread is about writing a real multitasking app,which is a much bigger job
20110416 14:23:28< loonycyborg> Or maybe even SDL's thread support.
20110416 14:28:01-!- Blueblaze [~Blueblaze@adsl-76-202-19-162.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110416 14:32:06-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has joined #wesnoth-dev
20110416 14:32:34-!- Blueblaze [~Blueblaze@adsl-76-202-19-162.dsl.hstntx.sbcglobal.net] has quit [Client Quit]
20110416 14:37:15< Ivanovic> boucman: benefit of using something like boost::thread would be that it really *is* multithreaded
20110416 14:37:33< Ivanovic> meaning that there is no extra lib required and we know that it should make use of several cores nicely
20110416 14:37:59< boucman> it's much more work to make wesnoth multi-threaded that way
20110416 14:38:05< boucman> whereas omp is pretty simple
20110416 14:38:32< Ivanovic> is wesnoth not semi multithreaded right now? meaning that eg sound has a thread of its own
20110416 14:39:27< boucman> afaik, only network use its own threads...
20110416 14:39:47< boucman> and that is knowledge from before asio usage
20110416 14:39:51< Ivanovic> i think when i created some backtraces *ages* ago there were something like 4 threads that i had to switch through
20110416 14:39:54< Ivanovic> one of those being sound
20110416 14:43:29-!- Qbunia [540aafbf@gateway/web/freenode/ip.84.10.175.191] has quit [Ping timeout: 252 seconds]
20110416 14:46:53-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110416 14:48:38-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20110416 14:51:39-!- FAAB [~huajie@219.142.239.253] has quit [Quit: Leaving.]
20110416 14:55:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20110416 14:59:57-!- FAAB [~huajie@219.142.239.253] has joined #wesnoth-dev
20110416 15:01:15-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20110416 15:04:08-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 258 seconds]
20110416 15:12:12< fendrin> timotei: hello
20110416 15:14:33< timotei> hi fendrin 
20110416 15:14:59< Soliton> timotei: you wanted some cron job set up?
20110416 15:15:36< timotei> Soliton: yes. I'd like a cron job to run make javadoc on the plugin's directory.
20110416 15:15:52< timotei> though, I don't know how to setup cmake to output the javadoc in a folder specified by the user who runs it
20110416 15:15:54< fendrin> timotei: And one for a daily build of the standalone app.
20110416 15:16:14< timotei> fendrin: that will be done after I implement the headless build
20110416 15:16:39< timotei> Soliton: could you make the javadoc output it in a folder in the eclipse.wesnoth.org ?
20110416 15:17:16< timotei> Soliton: for example, in a folder: eclipse.wesnoth.org/javadoc.
20110416 15:17:28< fendrin> timotei: I thought it might be less overhead for Soliton if you register the cran job already now and call a empty target as long as the implementation fails.
20110416 15:17:36< timotei> fendrin: oh. ok :)
20110416 15:18:09< timotei> one sec
20110416 15:18:55< CIA-82> ivanovic * r49227 /trunk/ (7 files in 6 dirs): updated Vietnamese transaltion
20110416 15:19:40< Nephro> fendrin, hi, you pinged me yesterda
20110416 15:19:54< fendrin> hi Nephro
20110416 15:20:21< fendrin> Nephro: I have reread your proposal. Can you tell me more about the brain?
20110416 15:20:49< Nephro> Sure thing. Do you have any particular questions?
20110416 15:20:54< fendrin> Yes
20110416 15:21:46< fendrin> I have understood that the brain lives in a separate thread where it does constantly update a database, right?
20110416 15:22:18< fendrin> A single request from the brain is delivered out of the database in O(1)?
20110416 15:22:49< Soliton> timotei: so i should run "make javadoc" in utils/java and copy the output (where does it go?) to eclipse.wesnoth.org/javadoc?
20110416 15:23:42< timotei> fendrin: hmm... regarding the nightly, we will do that just in the form of the plugin on the update site, right? No standalone built automatically
20110416 15:24:04< Soliton> "make: *** No rule to make target `javadoc'.  Stop."
20110416 15:24:10< timotei> Soliton: yes, but run it in utils/java/org.wesnoth. The target creates by default a javadoc folder in utils/java/org.wesnoth
20110416 15:24:11< Nephro> fendrin, Indeed, and it not only updates the information known to it, it also builds new and new structures on itself. The request will hopefully be in constant time always, the simplest structures(the ones generated in the beginning of the game) will have O(n) complexity, but the each next one will be more sophisticated
20110416 15:24:26< timotei> so not really utils/java, but rather utils/java/org.wesnoth :)
20110416 15:25:40< Nephro> fendrin, as I maybe written in the description(don't remember), the "brain" might stay neutral sometimes, if it hasn
20110416 15:25:40< Soliton> any idea what package javadoc would be in?
20110416 15:25:45< Nephro> hasn't built much yet
20110416 15:26:11< fendrin> Nephro: Does the brain consume a single core completely during the whole game?
20110416 15:26:51< timotei> Soliton: umm. sun's jdk
20110416 15:27:02< timotei> IDK if openjdk contains it aswell
20110416 15:27:55< Soliton> if it's not in debian then i don't have time for it.
20110416 15:28:10< timotei> Soliton: it is: http://www.debian.org/doc/manuals/debian-java-faq/ch4.html
20110416 15:28:55< automagic> How to add an attribute to a config ?
20110416 15:29:43< Soliton> config["key"] = "value"?
20110416 15:29:50< Soliton> timotei: ask Rhonda.
20110416 15:30:26< Nephro> fendrin, I haven't thought about that, yet, since I wanted to discuss this matter with someone more experienced. It will certainly depend on the level chosen by the player(easy, med, hard etc)... I figured that it could be progressive, or dynamic, it will need lots of power in the beginning to start up, then it could "calm down", and progressively increase later on. 
20110416 15:30:58< automagic> Soliton: Thanks.
20110416 15:31:50-!- vultraz [~chatzilla@124.109.10.191] has quit [Read error: Connection reset by peer]
20110416 15:32:01< boucman> automagic: so, do you have a fix to mordante's problem ?
20110416 15:32:48< fendrin> Nephro: I think it is okay to consume cpu. Realtime 3D games usually waste a complete core for rendering as best as possible. I can't see why Wesnoth should not do the same for the ai.
20110416 15:33:01-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110416 15:33:07-!- vultraz [~chatzilla@124.109.10.191] has quit [Read error: Connection reset by peer]
20110416 15:33:21< Nephro> fendrin, it may also be able to take over control at some point, that will be time consuming too, since it will transform from an evaluator, to a generator, but I don't think that is possible to achieve by the end of the summer, I plan to work on that during autumn/winter, since the university programm bores me to death
20110416 15:34:18< Nephro> fendrin, I also wanted it to be kind of my project, that I could show to future recruiters of submit in university, if that is allowed, by licensing etc
20110416 15:34:19< automagic> boucman: Yes, that one is very simple. I'm working on the unit tests.
20110416 15:34:40< boucman> could you pastebin that particular change somewhere so I can commit it in hte meantime ?
20110416 15:36:21< automagic> boucman: http://pastebin.com/z72qwPHb
20110416 15:37:35-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110416 15:39:33< boucman> and done
20110416 15:39:43< CIA-82> boucman * r49228 /trunk/src/image.cpp: fix an access after delete while applying image modifications
20110416 15:40:01< fendrin> timotei: On my ubuntut system the javadoc lives in "sun-java6-jdk".
20110416 15:40:47< fendrin> timotei: We will have to use it anyway because the open jdk does not drive the plugin, right?
20110416 15:42:57< fendrin> Soliton: Please install the "sun-java6-jdk" debian package.
20110416 15:43:48< fendrin> Soliton: http://jayraj87.blogspot.com/2010/02/installing-sun-java6-jdk-in-debian.html
20110416 15:45:07< timotei> fendrin: yeah. We need sun's jdk
20110416 15:48:12-!- eoc` [~eoc@pD9560EE5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110416 15:48:13< fendrin> Soliton: http://wiki.debian.org/Java/Sun <-- It is in non-free. No need for an extra sources.list entry.
20110416 15:51:38-!- eoc [~eoc@pD9560E9C.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20110416 15:56:19< CIA-82> timotei * r49229 /trunk/projectfiles/VC9/ (4 files): update the suppressed warnings
20110416 15:56:47< CIA-82> timotei * r49230 /trunk/utils/java/org.wesnoth/Makefile: add dummy entry for building the plugin
20110416 15:58:26< fendrin> timotei: Would you talk me through the process of installing the latest version somehow?
20110416 15:58:29-!- knotwork_ [~markm@142.177.232.243] has joined #wesnoth-dev
20110416 15:58:29-!- knotwork_ [~markm@142.177.232.243] has quit [Changing host]
20110416 15:58:29-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20110416 15:59:02< timotei> fendrin: the standalone or the plugin in eclipse?
20110416 15:59:34< fendrin> timotei: standalone.
20110416 15:59:57< timotei> fendrin: ok.
20110416 16:00:01< timotei> fendrin: ensure you have sun's jdk
20110416 16:00:12< timotei> fendrin: then download the archive: https://sourceforge.net/projects/wesnoth/files/wesnoth-umcplugin/1.0.0/
20110416 16:00:18< timotei> depending on your architecture
20110416 16:00:41-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 240 seconds]
20110416 16:01:41< fendrin> timotei: That file is quite old.
20110416 16:02:06< timotei> fendrin: do you want me to update it to current trunk version? :)
20110416 16:02:22< timotei> well, I'll do it ;)
20110416 16:02:35< fendrin> Yes please. But give it another name.
20110416 16:02:44< timotei> in which sense?
20110416 16:02:51< fendrin> -dev
20110416 16:03:02< timotei> wesnoth-umc-dev?
20110416 16:04:12< Nephro> fendrin, do you have any other questions/are the ones asked answered well?
20110416 16:04:23< Nephro> cause I plan running off for an hour or so :)
20110416 16:04:48< timotei> fendrin: I'll release standalone 1.0.1 and plugin 1.0.2 later, when I get back from a meeting ok ?:)
20110416 16:04:53< fendrin> Nephro: No, I am fine. I guess I have heard enough to make a new judge on the proposal.
20110416 16:05:25< fendrin> timotei: Yes, okay.
20110416 16:06:13-!- Qbunia_ [540aafbf@gateway/web/freenode/ip.84.10.175.191] has joined #wesnoth-dev
20110416 16:11:03-!- MeccaGod [majs@81.231.147.14] has quit []
20110416 16:11:03-!- eoc` is now known as eoc
20110416 16:23:40-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110416 16:27:34< CIA-82> elias * r49231 /trunk/data/tools/wmlunits: [wmlunits] fixed ignored unit-specific resistance/movement-cost/defence values
20110416 16:35:58< elias> Soliton: around?
20110416 16:39:06-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Remote host closed the connection]
20110416 16:44:38-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20110416 16:51:48-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110416 16:58:50-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110416 17:43:16-!- vcap [~vcap@AReims-551-1-133-217.w90-18.abo.wanadoo.fr] has quit [Quit: leaving]
20110416 17:49:47-!- negusnyul_ [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20110416 17:51:56-!- Qbunia_ [540aafbf@gateway/web/freenode/ip.84.10.175.191] has quit [Ping timeout: 252 seconds]
20110416 17:54:34-!- georgeSebastian_ [~georgeSeb@117.230.183.85] has joined #wesnoth-dev
20110416 17:54:41-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 240 seconds]
20110416 17:55:31-!- georgeSebastian_ is now known as georgesebastian
20110416 17:55:43-!- georgesebastian [~georgeSeb@117.230.183.85] has quit [Changing host]
20110416 17:55:43-!- georgesebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110416 18:04:32-!- champ [~champ@125.33.216.121] has joined #wesnoth-dev
20110416 18:08:56-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110416 18:12:57-!- vcap [~vcap@AReims-551-1-133-217.w90-18.abo.wanadoo.fr] has joined #wesnoth-dev
20110416 18:18:50< loonycyborg> boucman: I've got wesnoth to build with openmp-enabled TDM-mingw and it runs.
20110416 18:18:56< automagic> boucman: Some modifications parsers have no-argument code that is never executed because of the way the ifs are written
20110416 18:19:22< loonycyborg> Though no idea about spinning since windows installed in VM supports only one cpu core.
20110416 18:19:40< automagic> boucman: Should I add a utils::REMOVE_EMPTY flag to the split method or rather change the ifs to check for empty first argument?
20110416 18:19:53< boucman> loonycyborg: ok... here is a plan then
20110416 18:20:03< loonycyborg> I figured out how to enable multiple cores in virtualbox after I've installed windows there.
20110416 18:20:05< boucman> 1) I commit my fix as it, and have it disabled for windows
20110416 18:20:10-!- Qbunia [540aafbf@gateway/web/freenode/ip.84.10.175.191] has joined #wesnoth-dev
20110416 18:20:12< boucman> 2) we release 1.9.5
20110416 18:20:19< loonycyborg> And it apparently requires reinstall.
20110416 18:20:20< boucman> 3) you build with openmp
20110416 18:20:34< boucman> 4.1) if it works, great
20110416 18:20:52< boucman> 4.2) if it doesn't work, you repackage with openmp disabled, and we fix the problem for windows
20110416 18:20:58< automagic> boucman: I would add the REMOVE_EMPTY flag but I'm not sure if empty args can't be used to ommit values (e.g. ~CROP(1,,,4))
20110416 18:21:02< loonycyborg> kk
20110416 18:21:39< boucman> unless you can upload a test binary for someone with a real multicore windows to test in the meantime
20110416 18:22:29< boucman> automagic: check what the documentation says about that... but afaik you can't skip arguments usually
20110416 18:22:35< loonycyborg> I build releases on multicore windows, I just loathe to reboot to windows partition for anything other than a release :P
20110416 18:23:19-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110416 18:23:20< boucman> well, I really would like to get that tested... and I think this is a case where rebooting is legitimate :P
20110416 18:23:32-!- FAAB [~huajie@219.142.239.253] has quit [Quit: Leaving.]
20110416 18:23:38-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20110416 18:23:50< loonycyborg> I can test at the same time I make the release.
20110416 18:24:56< loonycyborg> For now I'd rather work out a way to confirm that workload is actually parallelized. How do you test?
20110416 18:25:21< boucman> it won't be on a single CPI
20110416 18:25:23< boucman> CPU
20110416 18:25:48< boucman> openMP creates as many working threads as available cpus by default... we could force it to have more if you really want to...
20110416 18:26:20< loonycyborg> No. I mean some AI and animation heavy test scenario.
20110416 18:27:14< boucman> you mean testing at release time when you have multiple CPUs ?
20110416 18:27:33< loonycyborg> Or right now on linux.
20110416 18:27:52 * shadowmaster writes random crap to loonycyborg's /dev/mem to give him a excuse to reboot
20110416 18:28:33< boucman> it's quite tricky to test actually, right now we play an AI heavy game and time the AI turn using Crab_'s debug output
20110416 18:43:35-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110416 18:51:03< automagic> boucman: http://pastebin.com/zP0F4cw1
20110416 18:52:36< automagic> I have to go walk the dogs now; bbl
20110416 18:53:35-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has joined #wesnoth-dev
20110416 18:54:18< boucman> checking...
20110416 18:57:34< loonycyborg> boucman: That's interesting. It seems to be pretty evenly distributed over cores no matter whether openmp is enabled or not.
20110416 18:58:07< boucman> hmm
20110416 18:58:13< boucman> not sure I can explain that..
20110416 18:59:45-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20110416 19:04:18-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110416 19:07:17< loonycyborg> I'm testing by starting Dead Water and there is no difference when idling whether omp-enabled(with OMP_WAIT_POLICY=PASSIVE) binary is used or not.
20110416 19:07:36< loonycyborg> So those water animations somehow spread over cores by themselves :P
20110416 19:08:20< shadowmaster> loonycyborg: compositing window manager?
20110416 19:08:32< loonycyborg> Yes.
20110416 19:09:04< shadowmaster> It might be useful to disable that to benchmark wesnoth if you have an NVIDIA GPU
20110416 19:10:46-!- Qbunia [540aafbf@gateway/web/freenode/ip.84.10.175.191] has quit [Ping timeout: 252 seconds]
20110416 19:10:55-!- mjs-de [~mjs-de@d117203.adsl.hansenet.de] has quit [Ping timeout: 246 seconds]
20110416 19:11:09< loonycyborg> It'll be hard to find a non-compositing WM now :P
20110416 19:12:09< shadowmaster> killall kwin metacity whatever
20110416 19:12:38< shadowmaster> there, now you don't have a window manager. even better.
20110416 19:12:52< Soliton> elias: around now.
20110416 19:14:45< elias> Soliton: just was wondering if i should put a re-compile of the wesnoth binary into cron...
20110416 19:15:02< elias> units.wesnoth.org wasn't updating because the one i compiled a few weeks stopped working :P
20110416 19:15:09< elias> +ago
20110416 19:15:14< Aethaeryn> Okay, where do I submit the patch when I'm ready?
20110416 19:15:46< Soliton> patches.wesnoth.org
20110416 19:16:05< Soliton> elias: sounds good.
20110416 19:17:28< Soliton> elias: you can check collectd.wesnoth.org and find a time when there is not a lot going on.
20110416 19:17:59< loonycyborg> Without a WM even keyboard focus doesn't seem to work so I wasn't able to type anything into irc :P
20110416 19:18:12< loonycyborg> So twm is better..
20110416 19:19:32< elias> xmonad is the best WM
20110416 19:19:41< elias> (it has no mouse support though)
20110416 19:21:32< loonycyborg> Yes, I'll definitely try it soon.
20110416 19:22:36< boucman> loonycyborg: if you don't have long AI turn it's impossible to see the effect of openMP
20110416 19:22:38-!- mjs-de [~mjs-de@e182035113.adsl.alicedsl.de] has joined #wesnoth-dev
20110416 19:22:48< boucman> since the game is basically using no CPU anyway
20110416 19:23:25< loonycyborg> It's using around 20% in core 1 and 2 at the start of DW
20110416 19:23:49< loonycyborg> Core 3 appears alomst idle with TWM
20110416 19:25:15< loonycyborg> And openmp still doesn't matter.
20110416 19:26:35< loonycyborg> And those water animations are definitely very cpu-heavy, load changes significantly when scrolling to land.
20110416 19:27:04< boucman> k...
20110416 19:27:46< boucman> loonycyborg: I could guide you into adding some debug code to make sure you are multi-threaded if you want to
20110416 19:28:22< loonycyborg> Sure.
20110416 19:29:43< boucman> in game_display.cpp, the parallelized loop line 923
20110416 19:30:20-!- Qbunia [540aafbf@gateway/web/freenode/ip.84.10.175.191] has joined #wesnoth-dev
20110416 19:30:55< loonycyborg> I know. I tried to hack it to fix spinning :P
20110416 19:31:08< boucman> print out the value of omp_get_thread_num()
20110416 19:31:27< boucman> (you need to include <omp.h> for that
20110416 19:31:46< boucman> if it doesn't always print the same value, it means you're multi-threaded
20110416 19:32:19< CIA-82> anonymissimus * r49232 /trunk/projectfiles/VC9/wesnoth.vcproj: Disabled "OpenMP=true" setting in MSVC project file for now since it causes a compiler error on my built system. Timotei, would be nice to mention such thing in the commit message.
20110416 19:33:35< anonymissimus> timotei: the compiler error showed only up on a full rebuilt AFAIK
20110416 19:34:34< CIA-82> fendrin * r49233 /trunk/ (3 files in 3 dirs): Removed race specific topics from the unit section of the ingame help.
20110416 19:37:42-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 19:38:49< timotei> anonymissimus: I'm sorry for the latest commit
20110416 19:39:00< timotei> forgot to change back openmp after helped boucman to test openmp on windows :)
20110416 19:39:14< timotei> I usually diff my commits before commiting them, but forgot that
20110416 19:40:18< anonymissimus> ok, so it was a mistake, np
20110416 19:40:28< timotei> yes.
20110416 19:40:44-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110416 19:40:44-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110416 19:40:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 19:40:50< timotei> loonycyborg: if you don't mind, I can test the binary built with openmp and gcc ;)
20110416 19:41:47< anonymissimus> what about the unreferenced local varaible warning; I get it for lge in lin 390 min playsingle_controller.cpp but that variable IS referenced
20110416 19:42:41< loonycyborg> timotei: No idea whether it'll work for you due to different dlls but I'll upload it somewhere.
20110416 19:43:13< loonycyborg> Actually it'll be hard to get it from the VM :P
20110416 19:43:38< timotei> loonycyborg: virtualbox or vmware?
20110416 19:43:45< loonycyborg> virtualbox
20110416 19:43:56< timotei> you don't use... a shared folder?
20110416 19:44:20< loonycyborg> Ah. I can copy it *into* shared folder.
20110416 19:44:31< timotei> loonycyborg: because you've set it to read-only ?
20110416 19:44:38< timotei> anonymissimus: what code does the warning have?
20110416 19:44:58< loonycyborg> I just missed the detail that it can work both ways.
20110416 19:45:05< anonymissimus> C4101
20110416 19:45:55< timotei> anonymissimus: yes. There are more like that: http://pastebin.com/u8qb3dzD
20110416 19:46:37< anonymissimus> yeah but for the other ones its actually unreferenced
20110416 19:47:33< timotei> true
20110416 19:47:42< timotei> well.. weird
20110416 19:47:56< timotei> maybe because is const?
20110416 19:48:10< timotei> lemme check
20110416 19:48:31< timotei> no. it's not because of that
20110416 19:48:31< timotei> IDK
20110416 19:54:24< loonycyborg> timotei: Uploaded to http://files.wesnoth.org/hidden/win/ as wesnoth-omp.exe
20110416 19:55:43< loonycyborg> *gomp
20110416 19:56:00-!- negusnyul [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has joined #wesnoth-dev
20110416 20:02:15< timotei> loonycyborg: ok
20110416 20:03:16< timotei> loonycyborg: pthreadGC2.dll is missing :P
20110416 20:03:56< loonycyborg> Probably you can fetch it from the internet.
20110416 20:04:32< loonycyborg> Along with libgomp-1.dll
20110416 20:04:40< timotei> ok
20110416 20:05:03< loonycyborg> http://tdm-gcc.tdragon.net/download <- probably they all can be found here.
20110416 20:06:04-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20110416 20:06:23< timotei> ok, that did
20110416 20:07:58< timotei> wow:O
20110416 20:08:17< timotei> this works a bit better than the vs binary. maybe because it's in release mode :P
20110416 20:08:30< timotei> so,...again, not rising over 40-50% :)
20110416 20:08:35< timotei> even with animations enabled ;)
20110416 20:09:06< timotei> boucman ^
20110416 20:09:17< timotei> so openmp works fine on windows :)
20110416 20:10:43< boucman> great, so no need to do any windows code, i'll commit that
20110416 20:10:59< timotei> boucman: yes.
20110416 20:11:10< timotei> boucman: be sure to commit the unsigned-> signed conversion too
20110416 20:11:17< timotei> so MSVC could compile it in the future
20110416 20:12:19< loonycyborg> timotei: How many cores do you have?
20110416 20:12:46< timotei> loonycyborg: 2
20110416 20:14:02< loonycyborg> 40-50% is total or for particular core?
20110416 20:15:55< timotei> loonycyborg: IDK how windows does calculate, but the wesnoth process doesn't take more than 40-50%
20110416 20:16:38< loonycyborg> It hogs two cores from my three. What if it hogs one from your two?
20110416 20:18:58< timotei> loonycyborg: it doesn't hog any. it balances the usage: http://dl.dropbox.com/u/462510/Capture.PNG
20110416 20:19:25< automagic> boucman: What do you think about the unit tests?
20110416 20:19:46< boucman> i've been chasing a tricky bug, I havn't looked yet
20110416 20:19:50-!- champ [~champ@125.33.216.121] has quit [Ping timeout: 260 seconds]
20110416 20:19:57< boucman> but i'll do right away since it's more urgent
20110416 20:21:24-!- harbin [poke@dsl-jklbrasgw2-fea0f800-138.dhcp.inet.fi] has quit [K-Lined]
20110416 20:22:30< loonycyborg> timotei: I bet it can be somehow made show individual cores.
20110416 20:22:51< timotei> loonycyborg: where it shows them. that's the 2 columns for :P
20110416 20:23:10< timotei> oh. and that image is from *actual* playing+ all animations enabled :)
20110416 20:23:15< boucman> automagic: quick skimming, it looks good
20110416 20:23:26< loonycyborg> Ah. Then it's definitely not spinning.
20110416 20:23:29< boucman> nothing very complicated here, there is one big remark though...
20110416 20:23:41< automagic> yes?
20110416 20:23:54< boucman> you should really add a header on the top of every test explaining what you test... 
20110416 20:24:29< automagic> Ok, I'll add that.
20110416 20:24:34< boucman> for example, your first test seems to test that priority_queue works correctly
20110416 20:24:43< boucman> which is not something wesnoth should really test...
20110416 20:25:05< boucman> what you are really testing is that the important assumption that RC is always top priority is still true...
20110416 20:25:50< boucman> and that's not obvious, you have to have a good knowledge of how image path work to understand that it needs testing... which sort of defy the point
20110416 20:26:01< boucman> since people who know that usuallly won't fall into the trap
20110416 20:26:20< boucman> so basically, think of the comments as hints and instructions on what to do when the test fails
20110416 20:26:33< automagic> Ok
20110416 20:26:55< CIA-82> boucman * r49234 /trunk/ (RELEASE_NOTES src/game.cpp src/game_display.cpp): fix cpu usage when openMP is enabled
20110416 20:28:32< Upthorn> I am somewhat concerned that my gsoc proposal (http://socghop.appspot.com/gsoc/proposal/review/google/gsoc2011/upthorn/1) has not received any feedback about the changes I've made in response to the initial comments from mentors
20110416 20:35:41< Aethaeryn> just a fyi for the people following GSOC. I'm finalizing what I have on my patch today, I wil get something in by the end of the "day" (0400 to 0600 GMT actually)
20110416 20:36:08< shadowmaster> 757
20110416 20:36:09< Aethaeryn> It took me longer than expected because (1) Wesnoth is massive, lots of things to keep track, (2) I had to learn the Lua C API, (3) school, (4) I wound up rewriting it about twice
20110416 20:36:18< Aethaeryn> And rewriting does tend to make things take longer
20110416 20:39:32< Upthorn> Aethaeryn: what is your project?
20110416 20:39:41< Upthorn> err, proposed project
20110416 20:41:28-!- epyon [~IceChat77@89-73-132-59.dynamic.chello.pl] has quit [Ping timeout: 258 seconds]
20110416 20:43:42< timotei> Upthorn: I didn't receive comments after my post either :)
20110416 20:43:46< Upthorn> nevermind, I found it on the wiki
20110416 20:44:52< Upthorn> Of the three times I've applied for GSoC, this year is the one that I am least confident that I will be accepted
20110416 20:45:25< Upthorn> because I deliberately chose a project that will challenge me if I am
20110416 20:49:18-!- Sytyi [~chatzilla@95-2-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110416 20:51:51-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 20:52:55-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20110416 20:52:55-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 20:53:55-!- timotei [~timotei@89.43.196.13] has joined #wesnoth-dev
20110416 20:53:55-!- timotei [~timotei@89.43.196.13] has quit [Changing host]
20110416 20:53:55-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 21:02:55-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110416 21:04:05-!- thespaceinvader_ [~chatzilla@95.149.85.102] has joined #wesnoth-dev
20110416 21:05:13-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Ping timeout: 260 seconds]
20110416 21:05:13-!- thespaceinvader_ is now known as thespaceinvader
20110416 21:05:29-!- georgesebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 240 seconds]
20110416 21:05:44-!- thespaceinvader [~chatzilla@95.149.85.102] has quit [Changing host]
20110416 21:05:44-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has joined #wesnoth-dev
20110416 21:08:08-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: I ATE'NT DEAD]
20110416 21:09:26< Aethaeryn> Upthorn: Shorty explained: Writing a bunch of Lua functions that are better than the current WML tables to cover some currently awkward things that are way too common 
20110416 21:09:30< Aethaeryn> E.g. [message]
20110416 21:09:51< Aethaeryn> I'm trying to write interface-related Lua functions that are easy to use.
20110416 21:10:03< Sytyi> mordante: Any other requests? Any commrnts about patch? 
20110416 21:10:06< Aethaeryn> http://wiki.wesnoth.org/SoC2011_Student_Page_Aethaeryn
20110416 21:10:31< Aethaeryn> Upthorn: It's a lot harder to explain that it seems, because explaining it shortly can misrepresent what I'm trying to do, or make it look like there's no unifying purpose.
20110416 21:10:41-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110416 21:11:03< Aethaeryn> It's basically improving the ability of UMCs to do interface code via Lua.
20110416 21:11:09< Upthorn> Aethaeryn: I think I understood from your initial explanation
20110416 21:11:12< Aethaeryn> ok
20110416 21:12:01< Aethaeryn> Though that last sentence kind of got it down to one sentence after all
20110416 21:12:40< Aethaeryn> I am a man of many words because school papers require me to be verbose so that I can write incredibly simple/obvious things in 5+ pages.
20110416 21:13:20< Upthorn> I understand.
20110416 21:14:25< Aethaeryn> I've been trained for years to *not* be able to get to the point :-P
20110416 21:14:49< Upthorn> that is what school teaches us, isn't it?
20110416 21:15:35-!- dtiger [~dtiger@dynamic-vpdn-93-125-68-69.telecom.by] has quit [Remote host closed the connection]
20110416 21:16:27< Aethaeryn> Even in programming courses. Damn, we have to comment a lot.
20110416 21:16:49< Aethaeryn> Simple code + complex comments = almost as many lines of comments as code. :-P
20110416 21:20:26-!- Sytyi [~chatzilla@95-2-133-95.pool.ukrtel.net] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 4.0/20110303194838]]
20110416 21:22:13-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 21:24:16-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 21:30:56-!- Blueblaze [~Blueblaze@adsl-76-202-22-13.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110416 21:36:25-!- eoc` [~eoc@pD9560253.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110416 21:39:21-!- eoc [~eoc@pD9560EE5.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20110416 21:39:26-!- eoc` is now known as eoc
20110416 21:50:32< Nephro> Aethaeryn, they make us do that in uni too, but I  don't :) I have script that comments each and every line, appending "// there is nothing to comment here", after first 3 submits the tutor came to me and said that I am allowed not to write comments, if I don't tell anyone I am :D
20110416 21:51:24-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 21:51:27< Afan> I'm trying to get Wesnoth to compile but I'm missing a few files, any idea on where I could get them?
20110416 21:51:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110416 21:52:00< Soliton> maybe if you mention them.
20110416 21:52:04-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110416 21:52:04-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110416 21:52:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 21:52:16-!- Blueblaze [~Blueblaze@adsl-76-202-22-13.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 246 seconds]
20110416 21:52:43< Afan> libintl.h
20110416 21:55:04-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 21:55:49-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 21:57:18< Soliton> that should come with your c library.
20110416 21:57:18-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 22:04:32< Aethaeryn> \o/
20110416 22:04:52< Aethaeryn> I got it to run!
20110416 22:05:04-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 276 seconds]
20110416 22:05:19< Aethaeryn> For certain definitions of run. Unfortunately, users being users, they'll find all sorts of creative ways to not use it exactly as I used it to get it to run.
20110416 22:05:27< Aethaeryn> Hence, this is only step one of many. ;-P
20110416 22:14:16-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20110416 22:21:33< automagic> boucman: http://pastebin.com/2fEDznZg
20110416 22:24:08< boucman> automagic: looks good, i'll commit
20110416 22:26:15-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110416 22:27:39-!- champ [~champ@125.33.218.48] has joined #wesnoth-dev
20110416 22:27:39-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110416 22:34:59-!- Blueblaze [~Blueblaze@adsl-76-202-22-13.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110416 22:36:52-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110416 22:38:07-!- timotei [~timotei@89.43.196.13] has joined #wesnoth-dev
20110416 22:38:07-!- timotei [~timotei@89.43.196.13] has quit [Changing host]
20110416 22:38:07-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110416 22:39:18< Nephro> Good evening, Crab_. I've finished the task today, the only thing left is adding them factories in the registry. I remember you said I could bypass that somehow, could you explain, please?
20110416 22:40:44< Crab_> for lua, if you only have  1 lua aspect c++ type, you can just create the correct c++ type from engine_lua
20110416 22:41:30< CIA-82> boucman * r49235 /trunk/src/ (4 files in 2 dirs): add test cases for image modifications, patch by automagic
20110416 22:41:44< Nephro> But the class is a template, how can I deal with that?
20110416 22:41:51< boucman> automagic: please add commit id 49235 to your patch list (since we didn't create an actual patch in the bug database)
20110416 22:42:19< boucman> and, automagic, will you be around tomorow ?
20110416 22:48:28< Nephro> Crab_, should I post the patch as is now? I mean for evaluation purposes etc. Since today and tomorrow I won't be able to work(tomorrow's my flight back to Glasgow)
20110416 22:49:11< boucman> Nephro: yes, please
20110416 22:50:14< Crab_> Nephro: yes, definitely. include a small note 'what works, what doesn't work'.
20110416 22:51:04< Nephro> I hope this will not cause any confusion, like with my previous patch, when mordante thought I am crazy reading the lines "a = new A(); delete a; a->b();", but I was just investigating a destructor error :)
20110416 22:51:28< Nephro> (of course, all that is long gone)
20110416 22:52:03< Crab_> :)
20110416 22:52:17< Crab_> it's good that you've figured out how boost::shared_ptr works :)
20110416 22:56:30< Nephro> Crab_, I knew how it works from the very beginning, but it seems I got so comfortable with it that I stopped seeing reasons, why NOT to use it :)
20110416 22:57:04< Crab_> :)))
20110416 22:58:18< Nephro> BTW, after I solved that problem I sent you, I ran into another one, where shared_ptr was the bad guy again, but the good old-fashioned C pointer came to the rescue
20110416 23:04:43-!- stikonas_ [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110416 23:04:43-!- stikonas_ [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110416 23:04:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 23:05:25< automagic> boucman: Yes, I will.
20110416 23:06:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20110416 23:06:39-!- MGoods|RangerM [~kvirc@84.45.236.142] has quit [Quit: KVIrc Insomnia 4.0.2, revision: 4740, sources date: 20100627, built on: 2010-08-03 23:23:39 UTC http://www.kvirc.net/]
20110416 23:06:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20110416 23:06:48< boucman> ok,I won't ( :) ) but if you have some time, there are a couple of places in the code where we (ab)use image modification by appending stuff to the image string
20110416 23:06:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 23:07:20< boucman> if you could hunt them down, that would be nice... if you'd rather work on your proposal, that's fine too, of course
20110416 23:07:51< automagic> boucman: Ok, I
20110416 23:07:59< automagic> I'll try to find these
20110416 23:08:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20110416 23:09:08-!- stikonas_ [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110416 23:09:08-!- stikonas_ [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110416 23:09:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110416 23:12:37< Crab_> Nephro: what kind of problem :) ?
20110416 23:13:53-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110416 23:14:00< Nephro> Crab_, well, you must have that line too... it's T lua_object<T>::get();
20110416 23:14:59< Nephro> I created a shared_ptr to "this" and passed it somewhere, but when the shared_ptr went out of scope, it called the destructor for this, although this still existed afterwards, all it's values were trashed
20110416 23:16:05< Nephro> And imagine me, sitting in the debugger, looking at a watch to this->value_, which was a beatiful 0.1, transforms to a random double after I try to step into the next line
20110416 23:16:09< Crab_> :))
20110416 23:16:12< Nephro> I thought I was going nuts
20110416 23:16:53< Crab_> in general, the safe way is to create a new object for the shared_ptr to use\manage.
20110416 23:17:04< Crab_> most other ways are inviting trouble :)
20110416 23:22:36< anonymissimus> Crab_: would you minf making it so that if there is a [filter_side]side= key it gets priority over the outer side= key ? would be way easier on wml and C++ side imo, instead of merging those
20110416 23:24:53< Crab_> generally, if both side= and [filter_side] side=  are specified, it's not good for the WML developer karma, it's better to just use 1
20110416 23:25:25< Crab_> maybe, let's classify the usage of both side= and [filter_side] as an error ?
20110416 23:25:29< anonymissimus> of course
20110416 23:25:36< Aethaeryn> Is there a way to find out how many students are still active?
20110416 23:25:50< Crab_> Aethaeryn: wiki pages -> history -> check changes
20110416 23:25:55< anonymissimus> yes, an error would be nice
20110416 23:28:26< anonymissimus> and its a problem on the lua side that this contructor
20110416 23:28:27< anonymissimus> side_filter(const vconfig &cfg, const std::string &side_string, bool flat_tod = false);
20110416 23:28:46< anonymissimus> isnt available, that is, the merging of the two side keys
20110416 23:29:15< anonymissimus> but if it's an error if both are set that's solved
20110416 23:35:11< Upthorn> hello Crab_
20110416 23:35:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110416 23:35:56< Upthorn> I wanted to doublecheck that the way I exposed suitable_keep to Lua was acceptable
20110416 23:36:49< Upthorn> lines 108-131 of src/ai/lua/core.cpp
20110416 23:37:13< Crab_> Upthorn: yes, I've seen the diff. 
20110416 23:37:27< Crab_> Upthorn: note that we have lua in tree already, and it's compiled with c++ error handling
20110416 23:37:43< Crab_> so the code there is somewhat obsolete - no need to do those jumps-on-error
20110416 23:38:17< Upthorn> I mimicked the way ai_execute_move operates
20110416 23:38:44< Crab_> yes, I know
20110416 23:38:48< Crab_> it's obsolete, too
20110416 23:38:59< Crab_> it was coded at a time where that was required
20110416 23:39:12< Upthorn> I thought it was odd that it didn't use a try/catch pair
20110416 23:39:18< Upthorn> but figured there was a reason for it
20110416 23:39:32< Crab_> previously, we had out-of-tree lua, which was compiled with C error handling
20110416 23:39:57< Upthorn> I recall that the changeover happened during or shortly after last gsoc coding period
20110416 23:41:17< Upthorn> now that I understand that's why it was done that way, I can switch over to a try/catch and throw
20110416 23:41:37-!- mjs-de [~mjs-de@e182035113.adsl.alicedsl.de] has quit [Remote host closed the connection]
20110416 23:42:26< Crab_> no need to do try-catch
20110416 23:43:11< Crab_> since the standard C++ error handling (unwind stack on exception) would just work.
20110416 23:44:25< Upthorn> I am now confused. Is 'return luaL_typerror(L, index, error_message);' also obsolete?
20110416 23:46:02< Upthorn> my intention was to make that the content of the catch bracket
20110416 23:46:18-!- eleazzaar [~jbjerk@ppp-70-226-217-90.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110416 23:47:01< Crab_> check src/scripting/lua.cpp , it's done in 'new-style' there.
20110416 23:48:16< Upthorn> http://pastebin.com/RyarEDxN is what I had before you said no need to do try-catch
20110416 23:48:25< Upthorn> I'll check the new style
20110416 23:49:17< Crab_> luaL_argerror
20110416 23:52:50< Upthorn> I now have http://pastebin.com/PmghgEvM
20110416 23:52:53< Upthorn> is this correct?
20110416 23:53:56< Crab_> yes, the error handling looks good
20110416 23:54:29< Crab_> but,  else goto error_call_destructors; is not needed
20110416 23:56:10< Crab_> I guess you can return luaL_typerror if the type of the arg is not good
20110416 23:56:36< Upthorn> I was just about to ask if that is what I should do
20110416 23:57:59< Upthorn> http://pastebin.com/A9a9XP9h is what I have now
20110416 23:58:16< Crab_> I guess that if (false) {                 error_call_destructors:         } can be killed, as well 
20110416 23:58:37< Upthorn> I thought I already did that.
20110416 23:58:54< Crab_> the paste still has it, you've only removed the goto
20110416 23:59:04< Upthorn> yeah, I see that.
20110416 23:59:15< Upthorn> it might be useful for me to read my code before I ask you about it
20110416 23:59:44< Upthorn> instead of being hasty and submitting several unnecessary revisions
--- Log closed Sun Apr 17 00:00:03 2011