--- Log opened Sun Apr 17 00:00:03 2011
20110417 00:00:38< Upthorn> I'm sorry. I was trying to get it corrected quickly, and I appear to have had the opposite result
20110417 00:01:08< Crab_> also note that if the map contains no keeps, the c++ code will return a null location - will it be translated to lua correctly ?
20110417 00:01:49< Upthorn> my current code would not translate it to lua correctly, no
20110417 00:03:09< Upthorn> would correct handling of that be "Lua_pushnil(L); return 1;" or "return 0;"?
20110417 00:05:46< Crab_> I'd like 'return 0;' more
20110417 00:07:31< Upthorn> ok
20110417 00:09:33< CIA-82> upthorn * r49236 /trunk/src/ai/lua/core.cpp: updated handling of ai.suitable_keep so as not to use obsolete code, and to handle null_locations acceptably.
20110417 00:09:46< Crab_> good, thanks
20110417 00:09:58< Upthorn> no problem.
20110417 00:10:35< Upthorn> Crab_: I also wanted to talk with you about an idea I had, since it appears Nephro has not had a chance to do so yet
20110417 00:11:07-!- negusnyul [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20110417 00:11:41< Crab_> we can do so now
20110417 00:12:11< Upthorn> you may already be aware of it if you have read the logs thoroughly, but I think Nephro's AI brain idea is really interesting, and I think it could easily occupy the whole coding period
20110417 00:12:30< Crab_> yes, I've read that.
20110417 00:12:45< Upthorn> it also seems like Nephro would be happier if he could devote himself to that if he were accepted
20110417 00:12:46< Crab_> however, there are reason why we don't want it to occupy the whole coding period
20110417 00:12:51< Upthorn> ok
20110417 00:13:01< Crab_> we want to allow a project to be successful even if that idea fails.
20110417 00:13:30< Upthorn> That's a very valid concern.
20110417 00:13:30< Crab_> for that, we need a project to include a big enough mandatory part which is not 'ai-related magic'
20110417 00:14:10< Crab_> so, I'd be able happily mark the project as 'well, not all was done but the mandatory stuff is in, success' 
20110417 00:15:13< Upthorn> Yeah, I agree. I just hadn't considered the possibility that Nephro would not succeed at that
20110417 00:16:11< Upthorn> I won't pursue it further
20110417 00:16:43< Upthorn> and I apologize if it caused any difficulty for you or any other wesnoth mentors
20110417 00:16:54< Crab_> Upthorn: no, no difficulties
20110417 00:17:01< Crab_> Upthorn: and it's totally ok to discuss
20110417 00:17:35-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 00:18:50< Upthorn> What made me think of it is that reading Nephro's proposal reminded me of gabba's whiteboard proposal from last year, and I thought it would be nice not to have to compete directly for acceptance
20110417 00:20:12< Nephro> Hehe, well, I think that my project would be for about two years of work and studies of structures and analysis methods, so the mandatory part doesn't change a lot really :)
20110417 00:21:36< Crab_> Upthorn: yes, it would be nice, of course.
20110417 00:21:40< Crab_> Nephro: :)))
20110417 00:22:19< Upthorn> fair enough
20110417 00:22:47< Nephro> Crab_, btw, I asked fendrin this question, but he must've missed it. If I succeed with the brain thingy, will I be allowed to submit it as coursework for the university or/and show it to potential employers
20110417 00:23:46< Crab_> Nephro: the official answer from google (Carol) was 'yes'
20110417 00:23:48< Upthorn> Nephro: I think that would actually be up to google, as far as I understand it, the answer is yes to both.
20110417 00:24:12-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20110417 00:24:19< Upthorn> yay for being right.
20110417 00:24:28< fendrin> Nephro: Wesnoth is GPL so your code will be. You are only bound to that license no mather what google says.
20110417 00:24:49< Crab_> fendrin: the 'will I be allowed to submit it as coursework' is a slightly different matter.
20110417 00:25:48< Nephro> Well that seems great, since the uni will most probably make me write some boring java gui xword puzzle editor, maybe I'll persuade them that my thingy is way cooler :)))
20110417 00:26:11-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20110417 00:27:09< Nephro> One of the lectors said that all the code we produce in university belongs to university, that's why I ask... It's all slippery and painful 
20110417 00:27:21-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110417 00:27:32< Espreon> My my...
20110417 00:33:32-!- eleazzaar [~jbjerk@ppp-70-226-217-90.dsl.spfdil.ameritech.net] has quit [Quit: eleazzaar]
20110417 00:34:53< Rhonda> Soliton: If timotei comes up with something useful I might look into it, though I don't have much java clue neither.
20110417 00:41:42< Nephro> wesbot, patch 2638
20110417 00:41:42< wesbot> Patch #2638  Assigned to: None  Status: None  Priority: 5 - Normal
20110417 00:41:42< wesbot> Summary: Lua Aspect Foundation(different implementation)
20110417 00:41:42< wesbot> Original submission: Different implementation suggested by Crab_.Still TO-
20110417 00:41:45< wesbot> DO:- functions to evade multiple retranslation when passing Lua objects to Lua
20110417 00:41:49< wesbot> URL: https://gna.org/patch/?2638
20110417 00:41:51< wesbot> Attached file (1st): https://gna.org/patch/download.php?file_id=12866
20110417 00:41:57< Nephro> Crab_, ^
20110417 00:42:13< Crab_> thanks
20110417 00:43:57< Nephro> I will probably go to sleep now, since I have a plane in 11 hours :) I'll try to reach the net asap tomorrow
20110417 00:44:06< Crab_> good luck, then :)
20110417 00:44:20< Nephro> thanks, good night
20110417 00:45:06< Crab_> Nephro: note, in general, adding extra unneeded header dependencies is not fun.
20110417 00:45:25< Crab_> Nephro: i.e.#include "../lua/core.hpp" is not a good thing, since it's not needed by that header at all.
20110417 00:45:45< Crab_> Nephro: but that forces all the stuff which depends on engine.hpp to be recompiled if core.hpp is changed. 
20110417 00:47:15< Crab_> Nephro: virtual double evaluate(), 'lua_object<int>* l_obj = new lua_object<int>();' - looks like a memory leak
20110417 00:48:14< Crab_> Nephro: engine_lua::do_parse_aspect_from_config - using factories is possible, but is overkill there, since we expect to have only 1 lua aspect C++ wrapper.
20110417 00:49:00-!- eoc [~eoc@pD9560253.dip0.t-ipconnect.de] has quit [Quit: www.unknown-horizons.org - open source real-time strategy with the comfy anno1602 feeling]
20110417 00:49:11-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 240 seconds]
20110417 00:50:17-!- eoc [~eoc@pD9560253.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 00:51:23< Crab_> Nephro: there are faster ways to pass a lua object around instead of serializing it to string, but it's ok for now.
20110417 00:53:14< Crab_> Nephro: I see little reasons for a DTO such as lua object to depend/include handlers.. just doesn't feel that right, it's better to pass a lua_object to handler from some kind of management code
20110417 00:54:10< Crab_> Nephro: to_type part looks good.
20110417 00:54:55-!- eoc is now known as eoc|happy
20110417 00:55:16< Crab_> Nephro: and your current code requires T to have a default constructor, which is not always the case. (terrain_filter doesn't have one, and it's passed to translation routines when we work with 'avoid' AI aspect.)
20110417 00:55:36< Crab_> Nephro: instead of T value_;, you should have used a (smart) pointer to T.
20110417 00:59:27-!- wesbot changed the topic of #wesnoth-dev to: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 198 bugs, 312 feature requests, 22 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110417 00:59:52-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: I'm editing my configuration file by hand because I'm crazy durdurdurdur]
20110417 01:00:18-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20110417 01:01:48-!- thespaceinvader [~chatzilla@wesnoth/artist/thespaceinvader] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.16/20110319135224]]
20110417 01:13:25-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 246 seconds]
20110417 01:14:11-!- automagic [~karol@77-253-107-122.adsl.inetia.pl] has left #wesnoth-dev []
20110417 01:21:49-!- eleazzaar [~jbjerk@ppp-70-226-217-90.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110417 01:22:13< Aethaeryn> I wish I had a dollar for each spam wiki page I deleted.
20110417 01:22:27< Aethaeryn> Then maybe they'd fix the spam filter for the wiki so I wouldn't have to go through over 30 a month :-P
20110417 01:29:15-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Ping timeout: 248 seconds]
20110417 01:43:19-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110417 01:43:23-!- shadowm_laptop [ignacio@186.11.210.104] has joined #wesnoth-dev
20110417 01:43:47-!- shadowm_laptop is now known as Guest42600
20110417 01:44:39-!- Guest42600 [ignacio@186.11.210.104] has quit [Client Quit]
20110417 01:45:25-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110417 01:46:33-!- p1mps [~p1mps@151.65.21.248] has joined #wesnoth-dev
20110417 01:47:45-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Ping timeout: 258 seconds]
20110417 01:58:21-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20110417 02:07:44-!- eoc|happy is now known as eoc|off
20110417 02:09:46-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Remote host closed the connection]
20110417 02:21:15-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 02:28:25-!- deekay [~dk@wesnoth/developer/dragonking] has quit []
20110417 02:35:43-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has quit [Read error: Operation timed out]
20110417 02:50:27-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 02:54:58-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 03:10:54-!- eoc` [~eoc@pD95605D1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 03:11:37-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 03:12:10-!- p1mps [~p1mps@151.65.21.248] has quit [Ping timeout: 246 seconds]
20110417 03:14:17-!- eoc|off [~eoc@pD9560253.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20110417 03:17:42-!- Guest62239 [~jeff@174.4.2.228] has joined #wesnoth-dev
20110417 03:51:19-!- Blueblaze [~Blueblaze@adsl-76-202-22-13.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110417 04:32:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110417 04:37:36-!- Ivanovic_ [~ivanovic@dtmd-4db2efa8.pool.mediaWays.net] has joined #wesnoth-dev
20110417 04:37:36-!- Ivanovic_ [~ivanovic@dtmd-4db2efa8.pool.mediaWays.net] has quit [Changing host]
20110417 04:37:36-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110417 04:40:24-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 04:41:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds]
20110417 04:43:38-!- Ivanovic_ is now known as Ivanovic
20110417 04:50:26-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20110417 04:51:10-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110417 05:09:47< ancestral> So I had a "radical" thought
20110417 05:10:11< Aethaeryn> :o
20110417 05:10:15< Aethaeryn> HERETIC!
20110417 05:10:47< ancestral> Maybe more people would know where the wiki was if "Create" was called "Wiki" on the web page instead.
20110417 05:11:08< ancestral> (and I suppose you could roll play in there two if you wanted to…)
20110417 05:11:15< ancestral> *too
20110417 05:35:10-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110417 05:40:41-!- elias [~allefant@allegro/developer/allefant] has quit [Ping timeout: 240 seconds]
20110417 05:46:53-!- elias [~allefant@allefant.com] has joined #wesnoth-dev
20110417 05:49:10-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 05:52:52-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 06:01:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20110417 06:01:03-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20110417 06:13:14-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has quit [Read error: Operation timed out]
20110417 06:32:02-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 06:48:33-!- champ [~champ@125.33.218.48] has left #wesnoth-dev []
20110417 06:50:37-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20110417 06:51:02-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20110417 06:51:02-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev
20110417 06:57:22-!- Aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20110417 07:03:37-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20110417 07:05:32-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev
20110417 07:11:36-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 07:12:49-!- rigved [~rigved@116.72.163.243] has joined #wesnoth-dev
20110417 07:16:02-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 07:58:26-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20110417 07:58:26-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20110417 07:58:26-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20110417 07:58:38< mordante> servus
20110417 07:58:54< mordante> seen automagic
20110417 07:58:58< Espreon> mordante: Ic grete þe.
20110417 07:59:02< mordante> wesbot,  seen automagic
20110417 07:59:02< wesbot> mordante: The person with the nick automagic last spoke 8h 51m ago.  6h 44m ago person left:
20110417 07:59:04< mordante> hi Espreon 
20110417 07:59:09< shadowmaster> hi mordante 
20110417 07:59:36< mordante> hi shadowmaster 
20110417 08:00:38-!- rigved [~rigved@116.72.163.243] has quit [Quit: Bye]
20110417 08:02:55-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: manual override]
20110417 08:03:21-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20110417 08:13:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20110417 08:14:07< boucman> morning all
20110417 08:14:13< mordante> hi boucman 
20110417 08:15:46-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 08:18:41< mordante> timotei, anonymissimus, yes I also wondered about the unreferenced local variable, have a commit pending for the real issues
20110417 08:20:09-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: manual override]
20110417 08:20:19-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20110417 08:25:58< mordante> Sytyi I had a look at your patch, but didn't finish the review yet
20110417 08:26:47< mordante> Sytyi since I didn't expect you this weekend I didn't write an initial review, will look at it in about half an hour
20110417 08:29:20-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: manual override]
20110417 08:29:36-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20110417 08:30:39< mordante> Nephro, well the most confusing about your first thing was that you manually deleted the pointer held by boost:shared_ptr
20110417 08:31:13< mordante> Nephro, so was not sure whether you understood the concept of a shared_ptr
20110417 08:31:43< Nephro> mordante, I know, that was purely for debug reasons, and the post was "as is", what we first discussed with Crab :) So that was just a usual misunderstanding :)
20110417 08:31:45< mordante> but good to know you know about them
20110417 08:36:31< Nephro> mordante, do you have any other questions about my proposal or everything at all? Because I am heading out for a plane soon and don't know when I'll be able to reach IRC, since the ports are closed in university library :(
20110417 08:39:35< mordante> Nephro, not at the moment, but I still want to look at some proposals today, yours is one of them
20110417 08:46:20< boucman> tschmitz: around ?
20110417 08:47:55< tschmitz> Yes
20110417 08:48:10< mordante> Nephro, regarding whether you're allowed to submit your GSoC work for course material
20110417 08:48:23< tschmitz> boucman: yes
20110417 08:48:43< mordante> Nephro, it also depends on whether your university allows it, some unis say work committed to them is theirs
20110417 08:48:55< boucman> there has been a patch posted anonymously a minute ago implementing supposed dead...
20110417 08:49:00< boucman> I assume it's you...
20110417 08:49:06< tschmitz> woops
20110417 08:49:16< tschmitz> I must not have been logged in ...
20110417 08:49:18< mordante> Nephro, so as long as the code is 100% yours it's fine, but if the code in Wesnoth is modified by other developers you can't relicense it
20110417 08:49:29< mordante> Nephro, and I'm not a layer 
20110417 08:50:22< Nephro> mordante, well, as I said somewhere up there yesterday, one of the lectors said, that whatever we produce in/for uni is theirs :(
20110417 08:51:03< mordante> Nephro, haven't read that part yet ;-) but that means you can't use GSoC work at your uni :-(
20110417 08:51:15< Nephro> That's sad
20110417 08:51:29< mordante> yes
20110417 08:51:30< Nephro> Will probably have to develop them X-word puzzle editors
20110417 08:51:43< boucman> tschmitz: just asking because there were no about.cfg entry, so I wanted to make sure
20110417 08:51:54< boucman> and you should ask a comment stating it's you while logged in
20110417 08:52:03< boucman> so you get mail updates when the patch is commented
20110417 08:53:07< tschmitz> boucman: K I'll put that comment. And I thought I added myself to about.cfg in my previous patch; is that how it works?
20110417 08:53:21< mordante> Nephro, you can still try ask the uni to use it and an approval to release the code as GPL
20110417 08:53:22< boucman> yes, no need to do it again
20110417 08:53:51< Nephro> mordante, thanks for the advice, I will certainly have to investigate this before making any moves ;]
20110417 08:53:55< Nephro> alright
20110417 08:53:58< Nephro> I run to the plane
20110417 08:54:06< Nephro> c'ya all
20110417 08:54:07< mordante> ok see you later
20110417 08:54:11-!- Nephro [~Dmitry@80.233.231.12] has quit [Quit: Leaving]
20110417 08:57:55-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110417 08:59:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110417 09:01:59-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110417 09:03:35-!- shadowm_laptop is now known as Pasta
20110417 09:04:00-!- Guest62239 [~jeff@174.4.2.228] has quit [Ping timeout: 260 seconds]
20110417 09:05:16-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110417 09:20:40-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110417 09:32:21< mordante> timotei/timotei21, all but three MSVC warnings should be gone now, 2 false positive and one which I still need to look into see what the C++ standard exactly tells
20110417 09:32:44< CIA-82> mordante * r49237 /trunk/src/version.hpp: Fix a g++ pedantic warning.
20110417 09:32:48< CIA-82> mordante * r49238 /trunk/src/playmp_controller.cpp: 
20110417 09:32:48< CIA-82> Fix a MSVC unused variable warning.
20110417 09:32:48< CIA-82> Also catch by refererence since we don't modify the exception.
20110417 09:32:49< CIA-82> mordante * r49239 /trunk/src/display.cpp: Fix a MSVC warning about truncating from a double.
20110417 09:32:54< CIA-82> mordante * r49240 /trunk/src/scripting/lua.cpp: 
20110417 09:32:54< CIA-82> Fix a MSVC warning about a virtual function.
20110417 09:32:54< CIA-82> The cv-qualifiers of a parameter were changed from the origial
20110417 09:32:54< CIA-82> signature.
20110417 09:32:57< CIA-82> mordante * r49241 /trunk/src/actions.cpp: 
20110417 09:32:58< CIA-82> Use empty() instead of comparing size() with 0.
20110417 09:32:58< CIA-82> Issue found by cppcheck.
20110417 09:33:00< CIA-82> mordante * r49242 /trunk/src/game_events.cpp: 
20110417 09:33:00< CIA-82> Use empty() instead of comparing size() with 0.
20110417 09:33:00< CIA-82> Issue found by cppcheck.
20110417 09:33:05< CIA-82> mordante * r49243 /trunk/src/sdl_utils.cpp: 
20110417 09:33:05< CIA-82> Fix same expression on both sides of '!=.'
20110417 09:33:05< CIA-82> Issue found by cppcheck.
20110417 09:33:07< CIA-82> mordante * r49245 /trunk/src/gui/widgets/listbox.cpp: Fix a MSVC warning about unary to an unsigned.
20110417 09:33:11< CIA-82> mordante * r49244 /trunk/src/gui/dialogs/mp_change_control.cpp: 
20110417 09:33:11< CIA-82> Pre instead of post increment a variable.
20110417 09:33:11< CIA-82> Issue found by cppcheck.
20110417 09:33:12< CIA-82> mordante * r49246 /trunk/src/gui/widgets/tree_view_node.cpp: Fix a MSVC warning about unary to an unsigned.
20110417 09:34:01< shadowmaster> oh my
20110417 09:34:37 * Soliton wonders what an "unary to an unsigned" warning is.
20110417 09:35:02< mordante> crap unary minus
20110417 09:35:04< CIA-82> mordante * r49247 /trunk/src/ (9 files in 4 dirs): Strip trailing whitespace.
20110417 09:35:20< Soliton> ok, that makes more sense. :-)
20110417 09:35:40< Soliton> what options do you use with cppcheck, btw?
20110417 09:36:13< Soliton> i've not seen "comparing size() with 0" warnings although we use that a lot at work.
20110417 09:36:28< mordante> I use -q -f -a -s
20110417 09:37:12< Soliton> we use qt and not stl so much though so it might not know that.
20110417 09:37:31< mordante> I use their latest git, and r49243 was really a nice catch
20110417 09:38:59< Soliton> yeah, sounds like a real bug.
20110417 09:39:02< mordante> it also has nice catch I need to discuss with DK formula_function.cpp:978 both branches are identical
20110417 09:40:02< mordante> not sure how good their qt support is, I've no experience with it
20110417 09:41:30< Soliton> it's good if i atleast can point to such a warning for the stl since i'm afraid some convincing might be needed...
20110417 09:47:47< Aethaeryn> ............
20110417 09:48:23< Aethaeryn> Literally at the last minute (in terms of the patch being ready) I find a way that can reduce it 100-200 lines by rewriting a function so that it can handle code from elsewhere.
20110417 09:48:40< boucman> hehe
20110417 09:48:52< Aethaeryn> I hope I don't get judged harshly if I manage to make my patch as small and minimal as possible :-P
20110417 09:49:01< Aethaeryn> It's actually the harder approach by far :-P
20110417 09:49:23< CIA-82> mordante * r49248 /trunk/src/game.cpp: Fix a comment typo.
20110417 09:50:50< mordante> Soliton, don't parse your sentence
20110417 09:52:27< boucman> Aethaeryn: on the confrary, it proves good synthesis abilities
20110417 09:52:30-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110417 09:52:55 * shadowmaster feels tempted to fix comment typos and grammar incorrectness everywhere!
20110417 09:53:11 * mordante just when he sees it
20110417 09:53:17< Aethaeryn> hmm, don't worry, it isn't ready yet.
20110417 09:53:19< Aethaeryn> I managed to break something.
20110417 09:53:28< Aethaeryn> It compiles, yes, but it has a runtime error :-P
20110417 09:54:50< tschmitz> When submitting a bug report, what should I put in the "Release" field?
20110417 09:55:40< shadowmaster> tschmitz: the version to which the report applies, or the version you are testing
20110417 09:55:53< shadowmaster> whatever version you are using to reproduce the bug
20110417 09:57:19< tschmitz> shadowmaster: What's the easiest way to find that out? ... heh ...
20110417 09:58:55< shadowmaster> uh, wesnoth --version
20110417 09:59:08< shadowmaster> or just look at the titlebar and/or titlescreen ](bottom left corner)
20110417 10:06:25-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 10:08:40-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 10:09:21< boucman> svn info :P
20110417 10:09:45< tschmitz> "1.9.5+svn (49106M)" ?
20110417 10:09:59< tschmitz> Something that looks like that?
20110417 10:10:19< Soliton> yes.
20110417 10:10:38< tschmitz> Thank you.
20110417 10:10:53< Soliton> of course the M in there is suspicious for a bug report.
20110417 10:11:09< Soliton> nobody knows what you changed.
20110417 10:21:10< tschmitz> Hm ...
20110417 10:22:05< tschmitz> I'm reasonably certain that the bug existed before my changes, I just didn't notice it until after making some changes
20110417 10:22:18< tschmitz> and tests
20110417 10:24:55-!- timotei [~timotei@89.43.196.13] has joined #wesnoth-dev
20110417 10:24:55-!- timotei [~timotei@89.43.196.13] has quit [Changing host]
20110417 10:24:55-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110417 10:24:59< Aethaeryn> hmm, 30 minutes later and the bug I introduced is still in my code
20110417 10:25:06< Aethaeryn> that's rather annoying
20110417 10:25:53< tschmitz> Egh ... forgot to set the category on my bug report.
20110417 10:26:29< timotei> Aethaeryn: well... you could ask Crab_ if has some time, to add a mediawiki registration captcha
20110417 10:28:29< Aethaeryn> timotei: It's been bothering me for months, I just didn't know who to bug
20110417 10:28:40< Aethaeryn> I had to clean up at least 25 today from the past week
20110417 10:29:21< timotei> Aethaeryn: yes. I've seen it ocassionally. 
20110417 10:36:50-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 10:39:07-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 10:42:41-!- Pasta [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20110417 10:49:32-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 10:55:27< timotei> fendrin: I
20110417 10:55:30< timotei> fendrin: hi
20110417 10:55:47< timotei> fendrin: I'm prepearing for releasing the 1.0.2 plugin version. should be up in 30mins -1 hour
20110417 10:56:02< timotei> mordante: thanks for fixing those warnings xD
20110417 10:56:39< mordante> timotei, you're welcome and feel free to post new warnings when you run into them
20110417 10:56:59< mordante> some warnings are valid, so I don't mind fixing them
20110417 10:57:25< timotei> mordante: I've insisted on suppressing those silly warnings because when I code I might really do a bad thing, and acustomed to getting silly warning, won't look into that 
20110417 10:58:03< mordante> of course suppressing silly ones it good, gcc has silly ones or ones with too many false positives
20110417 11:07:15-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 11:09:34-!- Afan [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 11:11:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 246 seconds]
20110417 11:12:04< mordante> wesbot, seen disruption
20110417 11:12:04< wesbot> mordante: The person with the nick Disruption last spoke 2d 13h ago.  2d 13h ago was here and on the channel #wesnoth with the message:
20110417 11:12:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110417 11:15:42< Qbunia> wesbot, seen mordante 
20110417 11:15:42< wesbot> Qbunia: Queried user last spoke 3m 38s ago.  mordante is currently here and on the channel #wesnoth-de.
20110417 11:15:50< Qbunia> :D
20110417 11:15:52< mordante> Qbunia, hi
20110417 11:16:04< Qbunia> hi iam fooling around i dont have any question ;p
20110417 11:16:14< mordante> ok
20110417 11:18:19-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20110417 11:22:52< Ivanovic> moin
20110417 11:24:02< mordante> hi Ivanovic 
20110417 11:28:49-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110417 11:31:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110417 11:31:28< mordante> Upthorn, your patches link twice to http://svn.gna.org/viewcvs/wesnoth?view=rev&revision=49222
20110417 11:31:45-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110417 11:32:27< mordante> Upthorn, and best also link your latest commit as well, I really dislike the goto usage in 49223
20110417 11:32:48< mordante> be happy Sapient is not here ;-)
20110417 11:43:24< CIA-82> timotei * r49249 /website/eclipse.wesnoth.org/ (9 files in 3 dirs): release plugin version 1.0.2. Coming soon the standalone version.
20110417 11:44:44< CIA-82> ivanovic * r49250 /branches/1.8/po/wesnoth-l/sk.po: updated Slovak translation
20110417 11:45:18< CIA-82> ivanovic * r49251 /trunk/ (25 files in 24 dirs): updated Irish and Slovak translation
20110417 11:50:45-!- vultraz [~chatzilla@124.109.10.191] has quit [Ping timeout: 252 seconds]
20110417 11:52:54< CIA-82> timotei * r49252 /trunk/utils/java/org.wesnoth/src/org/wesnoth/Constants.java: eclipse plugin: make some constant fields final
20110417 11:53:22< CIA-82> timotei * r49253 /trunk/utils/java/ (4 files in 4 dirs): 
20110417 11:53:22< CIA-82> eclipse plugin: make the editor projects follow
20110417 11:53:22< CIA-82> the main plugin's version
20110417 11:53:42< CIA-82> timotei * r49254 /trunk/utils/java/plugin_feature/signing.cmd: eclipse plugin: update the signing script
20110417 11:54:10< CIA-82> timotei * r49255 /trunk/utils/java/update_site/ (doc_howto.html features.html index.html): eclipse plugin: Update the website
20110417 11:54:40< CIA-82> timotei * r49256 /trunk/utils/java/update_site/site.xml: eclipse plugin: update the website for releasing 1.0.2
20110417 11:55:08< CIA-82> timotei * r49257 /trunk/utils/java/org.wesnoth/org.wesnoth.product: eclipse plugin: update the fragment dependencies
20110417 11:59:59-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110417 12:16:42-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 12:16:59-!- dtiger [~dtiger@dynamic-vpdn-93-125-68-107.telecom.by] has joined #wesnoth-dev
20110417 12:26:26-!- vultraz [~chatzilla@124.109.10.191] has quit [Ping timeout: 240 seconds]
20110417 12:35:03-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110417 12:41:00< stikonas> wesbot: seen silene
20110417 12:41:00< wesbot> stikonas: Sorry, I don't know of silene.
20110417 12:41:07< stikonas> wesbot: seen Silene
20110417 12:41:07< wesbot> stikonas: Sorry, I don't know of Silene.
20110417 12:41:11< stikonas> hmm, strange
20110417 12:42:50< timotei> stikonas: silene is gone
20110417 12:43:07< timotei> idk if he'll be around anymore soon
20110417 12:43:25< stikonas> oh, I see, nobody will be able to fix i18n bugs now...
20110417 12:43:34< timotei> i18n?
20110417 12:43:39< timotei> why nobody ?:)
20110417 12:43:40< stikonas> internationalization
20110417 12:43:47< timotei> sorry, i18n bugs*
20110417 12:44:20< stikonas> timotei: do you know anybody who knows that code well?
20110417 12:45:25< stikonas> silene wrote all that code...
20110417 12:45:56< stikonas> and I found a string in lua code that should be plural form aware
20110417 12:46:12-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20110417 12:46:33< timotei> I don't think that if somebody wrote some code, other won't be able to "know" it and modify accordingly to specs ;)
20110417 12:47:01< timotei> Just ask around/submit a bug
20110417 12:47:43< timotei> stikonas: also, where is that i18n code you talk about ?
20110417 12:48:42< stikonas> timotei: http://svn.gna.org/viewcvs/wesnoth/trunk/data/lua/wml/objectives.lua?revision=47547&view=markup
20110417 12:48:56< stikonas> string.format(tostring(_"(%d turns left)"), turn_limit - current_turn + 1)
20110417 12:49:29< stikonas> Wesnoth has support for plural strings in .cpp files, but I'm not sure about lua scripts
20110417 12:50:21< timotei> oh. I don't know lua anyway, so I can't help :) Maybe ask zookeeper since he modified that file aswell :P
20110417 12:50:22< stikonas> in .cpp files you do something like that: _n("%d turn left", "%d turns left", number_of_turns)
20110417 12:50:58< timotei> oh
20110417 12:50:59< stikonas> yeah, lua is the problem, I would have made a patch myself it it were C++ file :)
20110417 12:51:06< timotei> well, that code already checks
20110417 12:51:08< timotei> for "plural" thingy
20110417 12:51:14< stikonas> only for English language
20110417 12:51:18< timotei> or you want to use cardinal numerals?
20110417 12:51:25< stikonas> other languages have absolutely different rules
20110417 12:51:34< timotei> Yes. Indeed :P
20110417 12:51:37< stikonas> http://www.gnu.org/software/hello/manual/gettext/Plural-forms.html
20110417 12:51:49< timotei> thinking how that would be written in Romanian, I see the problem aswell
20110417 12:52:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110417 12:52:34< stikonas> Ivanovic: maybe you know what can be done with this string?
20110417 12:52:59 * Ivanovic has no ideas!
20110417 12:54:21< stikonas> well, I will probably have to submit a bug, so that this is not forgotten, but I'm not sure who can fix it anyway
20110417 12:57:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110417 12:58:04-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110417 12:58:04-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110417 12:58:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110417 12:59:02-!- Sytyi [~chatzilla@70-54-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110417 12:59:27-!- wesbot changed the topic of #wesnoth-dev to: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 200 bugs, 312 feature requests, 24 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110417 12:59:50< Ivanovic> lua is something that i basically have no clue about
20110417 13:00:01< Ivanovic> how does the plural form stuff work for "normal" wml?
20110417 13:00:17< Ivanovic> i'd guess that it would work in a similar fashion for the lua stuff
20110417 13:00:40-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20110417 13:01:00< stikonas> Ivanovic: wml does not have plural form support
20110417 13:01:10< Ivanovic> then lua doesn't have it either
20110417 13:01:12< stikonas> only C++ files have
20110417 13:01:30-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20110417 13:01:37< stikonas> hmm, then I will have to somehow workaround the translation
20110417 13:01:40< Ivanovic> basically because atm the same string extractor (wmlxgettext) is used
20110417 13:04:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20110417 13:06:39< Sytyi> mordante: hi! 
20110417 13:22:31-!- atomicbomber [7da7c492@gateway/web/freenode/ip.125.167.196.146] has joined #wesnoth-dev
20110417 13:34:16-!- Disruption [~Disruptio@185.Red-81-34-191.dynamicIP.rima-tde.net] has joined #wesnoth-dev
20110417 13:34:25< Disruption> hi devs! :=
20110417 13:34:26< Disruption> :)
20110417 13:35:26< Ivanovic> @all gsoc students: in case there is *anything* else you want to have noted for your proposal make sure that you leave a comment in your proposal at google asap!
20110417 13:35:33< Ivanovic> (basically 2h ago would have been better!)
20110417 13:36:53-!- eoc` is now known as eoc
20110417 13:49:56-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110417 13:57:30< Sytyi> Crab_: hi! Sorry, Had no time to phone and meet. 
20110417 13:57:44< Crab_> hi. (it's ok)
20110417 14:04:06-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20110417 14:05:03< CIA-82> timotei * r49258 /website/eclipse.wesnoth.org/ (artifacts.jar content.jar site.xml): release plugin version 1.0.2. (update the update site)
20110417 14:05:21< mordante> hi Sytyi 
20110417 14:05:40< Sytyi> mordante: hi :)
20110417 14:06:04-!- p1mps [~p1mps@151.65.21.248] has joined #wesnoth-dev
20110417 14:06:13< mordante> still at the olympiad?
20110417 14:06:39< Sytyi> mordante: I've got back yesterday
20110417 14:06:56< mordante> how was it?
20110417 14:07:00< Sytyi> mordante: The things went bad, we dissapointed and returned
20110417 14:07:38< mordante> :-(
20110417 14:08:09< Sytyi> mordante: we took only 12yh place from 50, and our robot to participate in another part breaked in a hour before robo-ontest started
20110417 14:08:42< mordante> that really sucks
20110417 14:10:20< Sytyi> mordante: I'leaving in a hour, so I want to know what to improve in patch, or if you had seen timeline in milestones. 
20110417 14:10:47-!- FAAB [~huajie@219.142.235.36] has joined #wesnoth-dev
20110417 14:12:05< mordante> Sytyi, did you see my comment on your patch
20110417 14:12:41< Sytyi> mordante: yes. and I want to know my mistakes and hear your opinion
20110417 14:13:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110417 14:13:41-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has joined #wesnoth-dev
20110417 14:13:41-!- stikonas [~gentoo@ctv-213-164-115-159.vinita.lt] has quit [Changing host]
20110417 14:13:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110417 14:13:45< mordante> Sytyi, ok we can talk about that, however you don't need to post an update unless you really want
20110417 14:13:59< mordante> I wanted to get an impression of your skills and I have that now
20110417 14:15:41< Sytyi> mordante: I have a little inspiration, so at my free time I will work on that sources, to improve TODO list and also to try another scheme of parsing. (using regex substitution)
20110417 14:16:26< mordante> regarding your patch, it still has one »using namespace std;« in a header when I remove it breaks compilation. I see you used the std:: at a lot of places, so I see it as a simple mistake
20110417 14:17:01< mordante> the getters in key.hpp are not const functions
20110417 14:17:24< Sytyi> mordante: I want to know what of two variants will be more quick and take less memory. 
20110417 14:18:09< mordante> in the main program, you ask whether or not to proceed after errors, would be nice if you handle n/N better, the user now gets a message as if a wrong answer might have been given
20110417 14:18:57< mordante> Sytyi, ok sounds interesting
20110417 14:19:26< Sytyi> mordante: ok. and for the n/N it was only quick implementation, of course it schould be be as you said
20110417 14:20:00< mordante> something which is really wrong in you current patch is you loop on !f_.eof(), what happens if f_.fail() returns true?
20110417 14:20:40-!- atomicbomber is now known as atomicbomb
20110417 14:21:20< Sytyi> mordante: Ow, I see. Sometimes I return false, and sometimes I only add an error without any returns. 
20110417 14:22:56< mordante> jup
20110417 14:23:40< Sytyi> mordante: Missed to return false. And what you think about errors system?
20110417 14:24:02< mordante> also don't take the comments too hard, I like you managed to get a working patch and especially since you also got it working with boost regex
20110417 14:24:50< mordante> Sytyi, regarding the error handling, I usually directly print errors using a dedicated logger or std::cerr
20110417 14:25:00< mordante> but I think your solution is also nice
20110417 14:25:14-!- negusnyul [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has joined #wesnoth-dev
20110417 14:25:50< mordante> especially since you print them and then ask whether the user still wants to output
20110417 14:26:33< Sytyi> mordante: I think I need to add some max err count to avoid using many memory but that is little details
20110417 14:27:04< mordante> Sytyi, just print them all
20110417 14:27:18< mordante> Sytyi, do you work a lot on embedded systems?
20110417 14:28:12< Sytyi> mordante: no. 
20110417 14:28:38< mordante> ok since you seem to care a lot about speed and memory usage
20110417 14:28:48< mordante> not that it's bad to care about both
20110417 14:29:16< mordante> but I wouldn't worry about the memory usage by the error handling of your parser
20110417 14:30:42-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 246 seconds]
20110417 14:30:55< mordante> regarding your regex question, I don't think moving them out of the source is that useful
20110417 14:31:05< mordante> but maybe grouping them in the source
20110417 14:32:09< Sytyi> mordante: making static members or something like that.
20110417 14:32:57< mordante> yes for example
20110417 14:34:29< mordante> also for example have a look at wiki_grabber.py create_config_table there I build the regex from several basic blocks
20110417 14:34:52< mordante> so if I discover a bug in the re_field_separator I need to modify one place
20110417 14:35:27< Sytyi> mordante: ok. Can you give me some advices to improve milestones? I'm lost a bit there. Also I want to notice that it is a pessimistic one, an optimistic has suggestion to make SG before 15 of June. 
20110417 14:35:55< mordante> Sytyi, I'm already looking and thinking that ;-)
20110417 14:36:23< mordante> btw there's also a typo error in the output of your schema.txt ;-)
20110417 14:39:25< Sytyi> mordante: :(
20110417 14:39:42< mordante> no problem
20110417 14:39:46-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has joined #wesnoth-dev
20110417 14:40:58< mordante> the only thing I would like to change in your timeline are the additional SG tasks
20110417 14:41:10< mordante> move them to the end of the project
20110417 14:42:04-!- epyon [~IceChat77@89-73-132-59.dynamic.chello.pl] has joined #wesnoth-dev
20110417 14:42:09< mordante> the most important thing of the project is the validator, so which of course needs the SG
20110417 14:42:10< Sytyi> mordante: ok. The error is different slash \ instead of / 
20110417 14:42:19< mordante> yup
20110417 14:42:55< mordante> but the additional SG tasks are not too important and at the end we know better how much time is left
20110417 14:43:22< mordante> in our experience most projects take longer as initially expected
20110417 14:44:37< Sytyi> mordante: yes. So I want to make SG as earlier as possible
20110417 14:45:25< mordante> of course, but leave the additional parts for later, if there is time left you can work on them, if not there's no problem
20110417 14:45:41< mordante> but a half finished validator is bad
20110417 14:46:26< Sytyi> mordante: I just didn't think about it. I understand. Any other advices ? I want to leave in 15 minutes. 
20110417 14:48:17< mordante> Sytyi, move that tasks marked ADDITIONAL to the end of the stages table
20110417 14:49:38< mordante> then I think it looks better
20110417 14:50:52< mordante> you can also flesh out the details about how you want to tackle the validator in more detail
20110417 14:51:15< mordante> but that will take you more time and we need to discuss that a bit more
20110417 14:51:34< Ivanovic> Disruption: regarding your proposal: have you provided some code samples?
20110417 14:51:43< mordante> so if you want we can look at that later
20110417 14:51:53< Ivanovic> meaning: some sourcecode in the lang that you would be using for the implementation?
20110417 14:52:05< Sytyi> mordante: Ok. Thanks a lot!  
20110417 14:52:07< Ivanovic> i know there is the jar and the screenshots, but is there the sourcecode, too?
20110417 14:52:19< mordante> but to be honest I found getting the patch more important
20110417 14:52:32< mordante> so I'm happy you managed to write that :-)
20110417 14:52:40< mordante> you're welcome
20110417 14:53:38< Disruption> Ivanovic: I have the sourcecode for the jar that makes the GUI, but I haven't provided any other sourcecode.  I submitted a patch for wesnoth, but that's c++, so it doesn't count much as I'm using Java in my proposal
20110417 14:53:53< Disruption> I know my way around java, but I don't know what I could actually code to show my skills or anything
20110417 14:53:55< Ivanovic> is the patch linked in your proposal?
20110417 14:53:59< Disruption> yep
20110417 14:54:12< Disruption> it's the one regarding the leaders not showing in the status table on fogged maps
20110417 14:54:24< Ivanovic> i'd say at least link the sourcecode for the prototype gui
20110417 14:55:11< Disruption> I can, but that code is pretty much self-generated by the visual interface builder, and as it is a mockup it has some "dummy" code to simulate the real behaviour
20110417 14:55:27< Disruption> I have no problems in uploading a zip or rar file with the java project inside
20110417 14:56:20< Sytyi> mordante: Can you mention any tool to know how many memory takes my program?
20110417 14:57:53< mordante> Sytyi, http://code.google.com/p/google-perftools/
20110417 14:58:30< Sytyi> mordante: Thanks a lot. Now I;m leaving. See you later :) 
20110417 14:58:37< mordante> ok see you later
20110417 14:59:36< Ivanovic> Disruption: it is at least a sample though yeah, it does not say too much
20110417 15:00:18-!- Sytyi [~chatzilla@70-54-133-95.pool.ukrtel.net] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 4.0/20110303194838]]
20110417 15:00:34< Disruption> Should I upload then the java project for the gui mockup?¿
20110417 15:00:55-!- atomicbomb [7da7c492@gateway/web/freenode/ip.125.167.196.146] has quit [Quit: Go home!]
20110417 15:01:26-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 15:05:28< Ivanovic> exactly
20110417 15:05:49-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110417 15:05:52< Disruption> ok
20110417 15:05:52-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 252 seconds]
20110417 15:06:01< Disruption> thank you for your tip :) I'll upload it right away ^w^
20110417 15:06:22-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has joined #wesnoth-dev
20110417 15:11:13< Disruption> Ivanovic: I added it, should I write a comment in my gsoc application in google site?
20110417 15:11:21< Ivanovic> of course you should!
20110417 15:11:26< Disruption> ok :)
20110417 15:13:44< Disruption> done ^^
20110417 15:14:20-!- LordNasty [~NaSTy@93-43-149-208.ip92.fastwebnet.it] has quit [Ping timeout: 250 seconds]
20110417 15:21:18< Disruption> Ivanovic: Thanks ^w^
20110417 15:22:59-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110417 15:23:21-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has joined #wesnoth-dev
20110417 15:42:30-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Read error: Connection reset by peer]
20110417 15:42:31< timotei> fendrin: at last. I've updated eclipse and didn't know why it won't generate the standalone eclipse version anymore.
20110417 15:42:43< timotei> fendrin: I'll build them & upload to source forge and then announce the version
20110417 15:42:46-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110417 15:42:48< timotei> fendrin: afterwars you can test it :D
20110417 15:44:04< fendrin> thanks
20110417 15:45:37< timotei> fendrin: can't wait to get the headless build & update done
20110417 15:50:04-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 15:50:06< timotei> I'm wondering, is .zip good enough for ... linux/mac? or I should use .tar.bz2?
20110417 15:52:50< fendrin> timotei: tar.gz or tar.bz2 is more common
20110417 15:52:55< timotei> fendrin: ok.
20110417 15:54:57-!- loonybot [~loonybot@ppp109-252-61-208.pppoe.spdop.ru] has joined #wesnoth-dev
20110417 15:54:57-!- loonybot [~loonybot@ppp109-252-61-208.pppoe.spdop.ru] has quit [Changing host]
20110417 15:54:57-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110417 15:55:26-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110417 16:01:42< Qbunia> guys where i can find list of all aspects? 
20110417 16:02:18< Crab_> Qbunia: in code, or in data/ai/utils/default_config.cfg
20110417 16:02:34< Crab_> Qbunia: those which are of user interest can be found on http://wiki.wesnoth.org/AiWML , too
20110417 16:03:12< Qbunia> oh thx
20110417 16:03:15< Crab_> with some comments on them in http://wiki.wesnoth.org/Customizing_AI_in_Wesnoth_1.8#Tweaking_AI_parameters_.28_via_.5Baspect.5D_tags_.29
20110417 16:05:35-!- FAAB [~huajie@219.142.235.36] has quit [Quit: Leaving.]
20110417 16:06:21< Qbunia> Crab_: only agression is implemented in lua ? 
20110417 16:07:03< Crab_> atm, yes
20110417 16:07:11< Qbunia> okok 
20110417 16:07:16< Crab_> more specifically, none are implemented in lua
20110417 16:07:31< Crab_> but it's possible to get aggression from lua (as calculated by c++ routine and transformed to lua value)
20110417 16:08:19< Qbunia> so its enough to only get values from aspects or i need to do something more?
20110417 16:10:08< Crab_> well, for start, get value from aspect is enough
20110417 16:10:38< Qbunia> ok 
20110417 16:10:38< Crab_> the reverse (allow aspects to be written in lua) is almost handled by a patch from Nephro (almost because of some unfinished stuff and some little bugs)
20110417 16:11:14< Qbunia> okok
20110417 16:11:15< Qbunia> we need to expose AI target lists to lua (target is a marker on the game map)
20110417 16:11:22< Qbunia> target list is list of all enemytargets?
20110417 16:11:58< Crab_> no, target is {location, type, score}
20110417 16:12:21< Crab_> and [goal] tag can be used to, say mark all locations of enemy wolf riders with score 10 and type TARGET.
20110417 16:13:25< Qbunia> howe we difine score and wha types unit can be ?
20110417 16:13:31< Qbunia> define*
20110417 16:13:59-!- FAAB [~huajie@219.142.235.36] has joined #wesnoth-dev
20110417 16:14:05-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20110417 16:14:26< Upthorn> mordante: I have updated my wiki proposal to link to the correct revisions, and refer to the more recent one, thanks for the heads up.
20110417 16:14:34< Crab_> usually, user provides the score
20110417 16:14:45-!- myrice [~ldd@114.249.154.128] has joined #wesnoth-dev
20110417 16:14:55< Crab_> they can be locations without units on them, just any locations the user wishes to specify
20110417 16:15:23-!- myrice [~ldd@114.249.154.128] has left #wesnoth-dev []
20110417 16:15:40< Qbunia> quite smart :) thx 
20110417 16:15:49< Crab_> technically, the target can have any type, atm, VILLAGE, LEADER, EXPLICIT, THREAT, BATTLE_AID, MASS, SUPPORT are defined
20110417 16:18:17-!- PetePorty [~quassel@pc-134-250-120-200.cm.vtr.net] has joined #wesnoth-dev
20110417 16:18:18< mordante> Upthorn, you're welcome
20110417 16:19:30-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110417 16:27:54< Qbunia> attacks_vector can u tell me more about this type ? 
20110417 16:28:28< Crab_> a vector with information about all possible attacks of N attackers versus a single defender.
20110417 16:29:47< Qbunia> and how attacks are described ? 
20110417 16:29:51< Upthorn> wow, I'm glad I just doublechecked that
20110417 16:30:15< Upthorn> I had accidentally made my revision 49236 link point to 49223
20110417 16:30:21< Upthorn> now it is corrected
20110417 16:30:35< Crab_> Qbunia: see src/ai/default/contexts.hpp , attack_analysis
20110417 16:34:36< mordante> boucman, automagic the unit tests no longer compile with boost 1.35
20110417 16:38:02-!- PetePorty [~quassel@pc-134-250-120-200.cm.vtr.net] has quit [Remote host closed the connection]
20110417 16:42:06< timotei> fendrin: https://sourceforge.net/projects/wesnoth/upload/wesnoth-umcplugin/1.0.2/
20110417 16:42:06< timotei> :)
20110417 16:42:53< Qbunia> Crab_: hmm where i can find class config, move_map, terrain_filter?
20110417 16:42:59< fendrin> timotei: I have no sourceforge account :-(
20110417 16:43:05< timotei> ops
20110417 16:43:07< timotei> wrong link
20110417 16:43:09< timotei> https://sourceforge.net/projects/wesnoth/files/wesnoth-umcplugin/1.0.2/
20110417 16:43:10< timotei> >P
20110417 16:43:11< timotei> :P*
20110417 16:44:12< Crab_> Qbunia: config -> src/config.hpp  ;    terrain_filter -> src/terrain_filter.hpp      ;   typedef std::multimap<map_location,map_location> move_map;
20110417 16:44:28< Qbunia> ok thx 
20110417 16:45:58-!- PetePorty [~quassel@pc-134-250-120-200.cm.vtr.net] has joined #wesnoth-dev
20110417 16:46:05< CIA-82> timotei * r49259 /trunk/utils/java/ (6 files in 5 dirs): eclipse plugin: post release version bump
20110417 16:46:16-!- p1mps [~p1mps@151.65.21.248] has quit [Ping timeout: 246 seconds]
20110417 16:46:18< CIA-82> timotei * r49260 /trunk/utils/java/update_site/doc_howto.html: eclipse plugin: Update the download links
20110417 16:49:54< Soliton> timotei: i suggest to write a release script if you haven't already. there seem to be an aweful lot of locations you need to update...
20110417 16:50:13< timotei> Soliton: yes. I will do it :)
20110417 16:58:34-!- PetePorty [~quassel@pc-134-250-120-200.cm.vtr.net] has quit [Remote host closed the connection]
20110417 17:15:45< Qbunia> Crab_: stage_ptr is a class that points to Stage class?
20110417 17:16:49< Crab_> yes, a boost::shared_ptr to stage
20110417 17:17:51< Qbunia> is vector class already exposed to lua ?
20110417 17:23:29< Crab_> vector naturally corresponds to lua table
20110417 17:23:52< Crab_> so, all depends on the type of the vector element
20110417 17:25:10< Qbunia> Crab_: so what about type of vector element how can it be written if i need to expose few functions that returns vectors with various types?
20110417 17:26:06< Crab_> just return an array of tuples
20110417 17:26:46< Crab_> e.g. see intf_get_locations
20110417 17:26:57< Crab_> it returns an array of locations matching a SLF
20110417 17:34:30< Qbunia> whats SLF ?
20110417 17:34:37< Crab_> standard location filter
20110417 17:35:00< Crab_> http://wiki.wesnoth.org/StandardLocationFilter
20110417 17:35:24< Qbunia> i seee
20110417 17:38:39-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 17:38:39-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20110417 17:39:53-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20110417 17:40:13-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110417 17:40:47< Aethaeryn> Crab_: I introduced a bug at the last minute that took at least an hour to solve :/
20110417 17:40:54< Crab_> happens :)
20110417 17:40:57< Crab_> so, where's the patch ? :)
20110417 17:41:35< Aethaeryn> I didn't want to submit it because I figured I was too tired to test it since it had took me an hour to find something fairly obvious in hindsight.
20110417 17:42:37< Ivanovic> you are aware that a semifinished patch is more code for us gsoc people to look at than no patch, right?
20110417 17:43:34< Crab_> Aethaeryn: so, if you have time, look at it once more to see if you find something, then submit it :))
20110417 17:46:23< Qbunia> Crab_: iam thinking about funciton get_leader_goal which returns config type value do i have to expose all class config to succesfuly use function in lua ?
20110417 17:46:43< Crab_> no, we already have code to convert config to lua and back.
20110417 17:46:51< Qbunia> ah great
20110417 17:46:57< Aethaeryn> Ivanovic: Yeah, but I didn't want to submit something that isn't finished that might have a bug I didn't spot yet.
20110417 17:47:15< Qbunia> can i found somewhere which types are convecret and which not ?
20110417 17:47:17< Crab_> Aethaeryn: doesn't matter much atm, but better submit it once you check it :)
20110417 17:47:18< Aethaeryn> Crab_: Exactly, we alread yhave code to convert config to lua and back.
20110417 17:47:37< Aethaeryn> I found, when coding exceptions to the original part of the function, that it was easier to just delete the special tables
20110417 17:47:41< Aethaeryn> And then use toconfig()
20110417 17:48:03< Aethaeryn> You told me to reuse as little code as possible.
20110417 17:48:13< Aethaeryn> as much
20110417 17:48:15< Aethaeryn> as much code as possible
20110417 17:48:20< Aethaeryn> brb, coffee
20110417 17:48:59< Crab_> Qbunia: luaW_toconfig, luaW_checkconfig, luaW_pushconfig
20110417 17:49:30-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110417 17:54:00< Aeth> Crab_, Ivanovic: http://pastebin.com/k11WtkRG
20110417 17:54:04< Aeth> If you want to see what I currently have.
20110417 17:54:20< Crab_> I'll take a look
20110417 17:54:20< Aeth> Now I need to detach my server irssi so I stop confusing myself and switching which nick I'm speaking from every time I alt-tab
20110417 17:54:54-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110417 17:56:42< Aethaeryn> Crab_: Aeth is me on my server, in case you didn't notice that there's two of me.
20110417 17:56:50< Crab_> :))
20110417 17:57:00< Aethaeryn> oooh, whoops, I managed to break it in that current form.
20110417 17:57:02< Aethaeryn> Good thing I tested it
20110417 17:57:18< timotei> hi gabba 
20110417 17:57:58< Aethaeryn> Crab_: That's why I couldn't really test it in order to submit it, there was a runtime (not compile) error for about an hour or two for all the latest changes
20110417 17:58:44< gabba> hi timotei
20110417 17:59:30< Qbunia> Crab_: attacks_vector, variant, terrain_filter i have to convert ? 
20110417 18:00:02< Aethaeryn> Crab_: Oh whoops, that does run, I just forgot to recompile 
20110417 18:00:11< Crab_> Qbunia: for the project, yes. note that variant is formula_ai representation of something else.
20110417 18:01:21-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20110417 18:02:46-!- champ [~champ@222.131.37.10] has joined #wesnoth-dev
20110417 18:07:16< Aethaeryn> Crab_: Once I debug text_input and add side_for's optional table form, I can submit a patch with what I have working to be reviewed while I work on option, you'd prefer to have a patch?
20110417 18:07:51< Crab_> yes
20110417 18:08:00< Crab_> preferably, with support for callbacks
20110417 18:08:09< Crab_> I can help, if there would be any questions
20110417 18:09:06-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110417 18:09:30-!- Disruption [~Disruptio@185.Red-81-34-191.dynamicIP.rima-tde.net] has quit []
20110417 18:10:13-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 18:19:58-!- FAAB [~huajie@219.142.235.36] has quit [Quit: Leaving.]
20110417 18:25:13< Qbunia> Crab_: how attacks can be described as a variant of types: int, list, map  or string?
20110417 18:26:10< Crab_> attacks list is a vector of attack analysis, and attack analysis can be represented by a lua table or a lua pseudo-table (userdata with overridden index metamethod)
20110417 18:26:34< Qbunia> yes i know u told it before
20110417 18:26:43< Qbunia> but iam looking at function 
20110417 18:26:52< Qbunia> const variant& readonly_context_impl::get_attacks_as_variant()
20110417 18:27:43-!- eoc` [~eoc@pD9560873.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 18:28:51< Crab_> you don't need to translate this to lua
20110417 18:28:57< Crab_> since the base is in c++
20110417 18:28:57< Qbunia> ah ok 
20110417 18:29:12< Crab_> and get_attacks_as_variant() just returns it translated from c++ to fai representation
20110417 18:29:16-!- mjs-de [~mjs-de@e182035113.adsl.alicedsl.de] has joined #wesnoth-dev
20110417 18:29:35< Crab_> so, translating from c++ to fai to lua is not a good thing, it's better to translate from c++ to lua directly
20110417 18:30:07< Qbunia> right ^^
20110417 18:30:40< gabba> brb
20110417 18:30:41-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110417 18:30:51-!- eoc [~eoc@pD95605D1.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20110417 18:31:30-!- eoc` is now known as eoc
20110417 18:32:40-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110417 18:33:19< Qbunia> Crab_: we need to expose AI movement maps to lua ( std::multimap<map_location, map_location> , four of them) what means four of them ? 
20110417 18:33:36< Qbunia> thgere are four maps with diffrent types ? 
20110417 18:33:56< Crab_> four maps with same type, get_srcdst, getdstsrc, get_enemy_srcdst, get_enemy_dstsrc
20110417 18:33:56-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20110417 18:34:12< Crab_> for us / for enemies, normal / reversed
20110417 18:35:20-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 260 seconds]
20110417 18:36:02-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110417 18:36:12< Qbunia> what means name of functions?
20110417 18:44:16-!- PolarPanda [~quassel@pc-134-250-120-200.cm.vtr.net] has joined #wesnoth-dev
20110417 18:46:56-!- PolarPanda [~quassel@pc-134-250-120-200.cm.vtr.net] has quit [Client Quit]
20110417 18:47:25-!- PolarPanda [~quassel@pc-134-250-120-200.cm.vtr.net] has joined #wesnoth-dev
20110417 18:48:38-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: ancestral]
20110417 18:49:24-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110417 18:53:13-!- PolarPanda [~quassel@pc-134-250-120-200.cm.vtr.net] has quit [Quit: RAGEQUIT!]
20110417 18:53:59-!- PolarPanda [~quassel@pc-134-250-120-200.cm.vtr.net] has joined #wesnoth-dev
20110417 18:55:24< Qbunia> Crab_: std::back_insert_iterator< std::vector< target > > target_list this target list have to be converted?
20110417 18:58:19< Crab_> yes
20110417 18:59:27-!- wesbot changed the topic of #wesnoth-dev to: Google Summer of Code: http://wiki.wesnoth.org/SummerOfCodeIdeas | 200 bugs, 312 feature requests, 25 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110417 19:02:00-!- eoc` [~eoc@217.86.2.154] has joined #wesnoth-dev
20110417 19:02:02< Aethaeryn> ugh
20110417 19:03:06< Espreon> What?
20110417 19:04:17-!- eoc [~eoc@pD9560873.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20110417 19:04:20-!- eoc` is now known as eoc
20110417 19:05:14< Aethaeryn> Espreon: I put my code in pastebin to say I couldn't find an issue and before I could paste it, I found one
20110417 19:05:17< Aethaeryn> :-P
20110417 19:05:57< Espreon> I see...
20110417 19:06:52< Aethaeryn> I'm going from 4 known bugs to 3, and this compiling might get it down to 2
20110417 19:08:06< Crab_> good
20110417 19:10:29< Aethaeryn> brb
20110417 19:14:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110417 19:21:23-!- markus_ [~mjs-de@e182047241.adsl.alicedsl.de] has joined #wesnoth-dev
20110417 19:24:23-!- mjs-de [~mjs-de@e182035113.adsl.alicedsl.de] has quit [Disconnected by services]
20110417 19:24:31-!- markus_ is now known as mjs-de
20110417 19:29:12< Aethaeryn> back
20110417 19:29:26< Aethaeryn> hmm, I seem to have introduced a new bug by fixing this one
20110417 19:31:48-!- Pasta [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110417 19:34:42-!- champ [~champ@222.131.37.10] has left #wesnoth-dev []
20110417 19:36:37-!- Pasta is now known as shadowm_laptop
20110417 19:39:39< Aethaeryn> Crab_: Is there an official way to debug?
20110417 19:39:54< Aethaeryn> My unofficial method is taking too long.
20110417 19:42:21< Soliton> explain what you're debugging and how then maybe someone can suggest better ways.
20110417 19:46:15-!- p1mps [~p1mps@151.65.21.248] has joined #wesnoth-dev
20110417 19:47:33< Qbunia> Crab_: implementing target list should look like this? :
20110417 19:47:52< Qbunia> table of tables of targets?
20110417 19:48:08-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20110417 19:48:21< Aethaeryn> ...........................................
20110417 19:48:33< Aethaeryn> Second bug I fixed by putting it into pastebin to ask for advice.
20110417 19:49:31< Aethaeryn> I mean, before I asked for advice I saw the bug in the code.
20110417 19:52:13-!- Sirp [~user@pool-173-74-15-196.dllstx.fios.verizon.net] has quit [Ping timeout: 276 seconds]
20110417 19:52:59-!- Sirp [~user@pool-173-74-15-196.dllstx.fios.verizon.net] has joined #wesnoth-dev
20110417 19:55:05-!- eoc` [~eoc@pD9560540.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 19:56:36-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110417 19:56:45-!- eoc [~eoc@217.86.2.154] has quit [Ping timeout: 260 seconds]
20110417 19:56:49-!- eoc` is now known as eoc
20110417 20:01:34-!- eoc` [~eoc@pD95604EF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 20:02:51-!- eoc [~eoc@pD9560540.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20110417 20:03:44-!- inferno8 [~kvirc@178-36-69-240.adsl.inetia.pl] has joined #wesnoth-dev
20110417 20:03:58-!- eoc` is now known as eoc
20110417 20:04:47-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Quit: AndroIRC]
20110417 20:05:32-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20110417 20:07:13-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has joined #wesnoth-dev
20110417 20:10:08< Qbunia> Crab_: structure map_location isint converted?
20110417 20:12:05< Crab_> depends. sometimes to two integer values
20110417 20:12:11< Crab_> sometimes to a table with two values
20110417 20:12:22< Crab_> sometimes to userdata with x,y accessors via index metamethod
20110417 20:14:54< Upthorn> that should probably be standardized...
20110417 20:18:08< Qbunia> Crab_: tiyr abswer us to target list?
20110417 20:18:19< Qbunia> cuz i dont understand much :| 
20110417 20:18:47< Crab_> Upthorn: no, it's more like of speed-vs-convenience tradeoff
20110417 20:18:59< Crab_> Upthorn: some cases call for speed, some for more uniform access
20110417 20:19:12< Upthorn> ah
20110417 20:19:12-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20110417 20:19:21< Crab_> for target list, I think that  'userdata with accessors x,y via index metamethod' will work, at least for start
20110417 20:19:31-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 20:19:34< Crab_> Upthorn: doing t.x and t.y is slower than just having x and y
20110417 20:19:47< Upthorn> yes
20110417 20:21:25-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110417 20:22:27< Upthorn> I was thinking that users might become confused or annoyed by the fact that functions that return a map_location to lua don't necessarily return it in the same format as other functions which do the same
20110417 20:24:19< Upthorn> I suppose that map_locations in wesnoth are not really a case where having a standard interface should outweigh speed/utility concerns
20110417 20:25:17< Upthorn> if the same thing were happening with units, that would be a problem
20110417 20:25:34< mordante> hi tschmitz 
20110417 20:25:38< tschmitz> mordante: Hey
20110417 20:25:44< mordante> tschmitz, I had a look at your patch
20110417 20:25:48< tschmitz> Yeah
20110417 20:25:52< tschmitz> I was about to see if you were here
20110417 20:26:00< mordante> :-)
20110417 20:26:02< mordante> and really curious about the extra scope
20110417 20:26:58< tschmitz> Hah, that was me ... sensing what would help me to more easily understand what I'm looking at in the header file
20110417 20:28:19< tschmitz> I just felt like it would be nice to see what my class is inheriting and have it separate from what's new
20110417 20:28:36< tschmitz> It's just a comment
20110417 20:31:37< mordante> yes but I like the idea
20110417 20:31:55< mordante> and the extra indention makes it stand out
20110417 20:31:56< tschmitz> mordante: Not sure if you cross-referenced my patch with any of the existing code, but you'd likely find lots of similarities with gabba's existing code; since I was adding an extra sub-class, it is modeled after his other sub-classes
20110417 20:32:07< tschmitz> Oh,
20110417 20:32:09< tschmitz> thank you!
20110417 20:32:26< mordante> no I didn't, haven't looked much at the wb code
20110417 20:33:08< tschmitz> Where "modeled after" is a euphemism for some copy-paste action
20110417 20:33:33< Qbunia> to post any changes to my proporsal i have time till 00:00 CET? 
20110417 20:34:29< tschmitz> mordante: gabba had a lot of comments that were identical for all the existing sub-classes, so I added those comments to the new suppose_dead sub-class when they remained relevant
20110417 20:35:43< mordante> Qbunia, you're free to post updates until we have to make our final decision to google
20110417 20:36:11< Qbunia> mordante: and i dont have a specified time for updates the deadline is simple: as soon as possible i guess?
20110417 20:36:15< mordante> Qbunia, however the sooner the better, we need to make up our minds at some point
20110417 20:36:30< Ivanovic> if you are too late for your stuff to be taken into account: bad luck
20110417 20:36:32< Ivanovic> simple as that
20110417 20:36:33< Qbunia> cuz i heard its quite secret the time of you meetting ;) 
20110417 20:36:39< Qbunia> ye :) 
20110417 20:36:47< mordante> tschmitz, well it's open source so feel free to borrow other ideas
20110417 20:37:01< mordante> Qbunia, you know the definition of secret :-P
20110417 20:37:08< Qbunia> :D
20110417 20:37:30< Qbunia> i heard few rumors when it is 
20110417 20:37:41< Qbunia> but nvm i have to hurry :) 
20110417 20:38:53< tschmitz> mordante: Regarding the weird assert in the suppose_dead constructor, I agree it is weird and sort of just turned a blind eye on it when I was cleaning up and debugging;
20110417 20:39:49< mordante> Qbunia, I've heard a lot of rumours over the years ;-P
20110417 20:40:20< Qbunia> haha :D
20110417 20:41:01< mordante> tschmitz, ok, but would using a reference be possible
20110417 20:41:11< tschmitz> mordante: I modeled the constructor code after the constructor code for one of the other sub-classes, and there is an assert in there. A pointer is also used in the other sub-class instead of a reference. I think the pointer can become NULL at a later time though ... I'll look
20110417 20:41:25< mordante> if the pointer is NULL it's not suppose dead, but a dead Wesnoth
20110417 20:43:08< mordante> tschmitz, might be as I told zaroth, when a GSoC student submits a patch we go with a toothcomb over it, once the student becomes a dev we look less closely
20110417 20:43:31< tschmitz> Sounds good
20110417 20:44:06< tschmitz> gabba uses the assert to make sure he can dereference the pointer in the constructor
20110417 20:44:27< tschmitz> I stuck that dereference in the initializer list, making my assert in the body useless
20110417 20:46:55< mordante> in general use a pointer when it can be NULL and a reference if it can't
20110417 20:47:24-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 240 seconds]
20110417 20:47:35< tschmitz> For some reason, the pointer is set to NULL if the action becomes invalid later
20110417 20:48:02< tschmitz> Well, if the unit is no longer there, basically, the unit pointer is set to NULL when the validator discovers that
20110417 20:48:24< tschmitz> Not sure how necessary it is to do that
20110417 20:49:01< tschmitz> in either case, the assert in the body of my constructor is useless, considering I've already dereferenced that pointer in the initializer list
20110417 20:49:40< mordante> tschmitz, you can still use a pointer in the class itself, only send a reference to the constructor
20110417 20:50:12< tschmitz> mordante: That is quite true.
20110417 20:50:21< mordante> then you can there get the address of the referenced unit and store it as a pointer
20110417 20:51:22< tschmitz> mordante: How should I consider making changes, anyway? editing my .patch file and re-uploading it?
20110417 20:52:50< mordante> tschmitz, best modify your code -> create a patch -> add it to your current patch submission
20110417 20:53:13< mordante> modifying patch files (if you really proposed that) is very tricky
20110417 20:53:52< tschmitz> mordante: Someone else recommended cleaning up patch files by hand before uploading them
20110417 20:53:52< tschmitz> Don't remember who
20110417 20:54:46< tschmitz> I did edit this .patch file by hand before uploading it
20110417 20:54:48< mordante> tschmitz, what did they mean by cleaning up `by hand'
20110417 20:55:03< tschmitz> mordante: I didn't ask them to clarify
20110417 20:56:11< mordante> tschmitz, which OS do you use?
20110417 20:56:38< tschmitz> mordante: Windows XP
20110417 20:58:11< mordante> tschmitz, I expected Windows, there is one issue with your patch it uses different eol line styles
20110417 20:58:26< tschmitz> I was wondering whether that would happen
20110417 20:58:39< mordante> yo can set the properties of your new files to svn:eol-style to native
20110417 20:58:42< mordante> you*
20110417 20:59:01< mordante> maybe they meant that with cleaning up the patch
20110417 20:59:57-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Quit: AndroIRC]
20110417 21:00:07-!- boucman_mobile [~boucman@62.201.142.94] has joined #wesnoth-dev
20110417 21:00:07-!- boucman_mobile [~boucman@62.201.142.94] has quit [Client Quit]
20110417 21:00:14-!- boucman_mobile [~boucman@62.201.142.94] has joined #wesnoth-dev
20110417 21:00:14-!- boucman_mobile [~boucman@62.201.142.94] has quit [Changing host]
20110417 21:00:14-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20110417 21:00:19-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Client Quit]
20110417 21:04:38-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 21:04:46-!- p1mps [~p1mps@151.65.21.248] has quit [Quit: Sto andando via]
20110417 21:08:34< Qbunia> Crab_: Do i have to handle inheritance when exposing to lua?
20110417 21:09:01< Crab_> you need to make sure that lua stuff has access to the info that c++ stuff uses 
20110417 21:09:18< Qbunia> okok
20110417 21:09:20< Crab_> i.e., in src/ai/testing/ca.cpp, you can find existing C++ ai routines, you can see what they use
20110417 21:10:31< Crab_> for example, if someone would need to rewrite goto phase in lua, he'd need access to get_passive_leader(), get_passive_leader_shares_keep()
20110417 21:10:41-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 240 seconds]
20110417 21:14:48-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20110417 21:15:38< Qbunia> i see
20110417 21:16:18< Crab_> and to get_dstsrc, as well
20110417 21:16:45< Qbunia> ye 
20110417 21:17:10< Qbunia> mm using userdata is always the best for converting struct?
20110417 21:17:28< Qbunia> i thinking how i would represent Atack analysis 
20110417 21:19:00-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110417 21:19:30< gabba> tschmitz: I reviewed your patch
20110417 21:19:56< tschmitz> Oh hey gabba
20110417 21:20:24< gabba> hey hey
20110417 21:20:32-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: you are doing it wrong]
20110417 21:20:42< gabba> tschmitz: nice work with the suppose_dead
20110417 21:21:04< tschmitz> gabba: Thanks
20110417 21:21:25< tschmitz> It turns what used to be an annoying bug into an exploitable bug
20110417 21:21:38< tschmitz> so I submitted a tiny patch closing that hole as well
20110417 21:21:50< gabba> I found a few minor issues and I have a question, though (probably about that bug)
20110417 21:23:20-!- GeorgeSebastian [~georgeSeb@117.230.234.101] has joined #wesnoth-dev
20110417 21:23:20-!- GeorgeSebastian [~georgeSeb@117.230.234.101] has quit [Changing host]
20110417 21:23:20-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 21:23:30< gabba> I'm reading your conversation with mordante in the log
20110417 21:23:43< tschmitz> K
20110417 21:25:09-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 21:27:19-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 21:28:34-!- Sytyi [~chatzilla@70-54-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110417 21:29:32-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 276 seconds]
20110417 21:31:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110417 21:31:28< gabba> tschmitz: "Someone else recommended cleaning up patch files by hand before uploading them" -> yeah, that was me :P
20110417 21:31:55< mordante> gabba, what did you mean with it?
20110417 21:32:21< gabba> mordante: checking for weird extra whitespace or line endings, basically
20110417 21:33:19< mordante> actually it would be better to change that in the original code and then recreate the patch
20110417 21:33:34< gabba> mordante: you're right of course
20110417 21:34:09< mordante> tschmitz, and just for your information, due to the weird line endings the last line of the header file got ignored ... 
20110417 21:34:15< gabba> tschmitz: ^mordante's advice about this is better than mine
20110417 21:34:38-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110417 21:36:25< tschmitz> mordante, gabba: regarding the comment about a bug in std::equal(), I tested out std::equal() on the university unix server and it appears to not have the issue
20110417 21:37:11< gabba> tschmitz: what was the bug exactly?
20110417 21:37:15< gabba> (is)
20110417 21:37:21< tschmitz> I got an assertion failure in iterator::operator+= called from std::equal()
20110417 21:37:46< mordante> tschmitz, I don't mind adding the work-around, just like more comment what when wrong and on which compiler
20110417 21:37:52< tschmitz> as best I could tell, it occurred because the second vector being compared was shorter than the first
20110417 21:38:17< tschmitz> mordante: An explanatory comment in the code, or someplace else?
20110417 21:38:25< mordante> tschmitz, that makes it easier to judge later whether the workaround needs to remain
20110417 21:38:40< mordante> tschmitz, just in the code, let me get you an example
20110417 21:39:00< tschmitz> Thank you
20110417 21:39:47< mordante> searching for MSVC gives you several, but I was looking for terrain_filter.hpp line 33
20110417 21:40:14< mordante> not that I suggest the #ifdef for your case
20110417 21:40:44< tschmitz> Hm, good ol' MSVC
20110417 21:40:51-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has joined #wesnoth-dev
20110417 21:40:51-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has quit [Changing host]
20110417 21:40:51-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20110417 21:40:58-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 21:41:45< mordante> looking for gcc also has several hits ;-)
20110417 21:42:21< mordante> I just have more issues with MSVC, the code works for me and fails on MSVC
20110417 21:42:43< mordante> if it would fail on GCC I often just change the code directly ;-)
20110417 21:43:02< mordante> and don't always look up the standard whether it's a bug or not
20110417 21:43:25-!- eoc [~eoc@pD95604EF.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20110417 21:44:24< ancestral> elias: I'm setting up a git for Bestiary. Let me know if you have any interest in having access
20110417 21:46:47-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Remote host closed the connection]
20110417 21:47:05-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 276 seconds]
20110417 21:47:32< mordante> tschmitz, actually I start to believe your compiler might do the right thing ... let me lookup some references
20110417 21:49:31-!- eoc [~eoc@pD95612F6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 21:49:52< mordante> tschmitz, your change does the right thing the old code was wrong
20110417 21:49:56-!- |Marek| [~kvirc@84.45.236.142] has joined #wesnoth-dev
20110417 21:50:00< mordante> http://www.cppreference.com/wiki/algorithm/equal
20110417 21:50:22< mordante> std::equal tests for the number of elements in the first range
20110417 21:50:57< mordante> so if the second is shorter it results in deferring end() and increasing an end() iterator
20110417 21:51:06< gabba> tschmitz: I posted my comments on the patch page
20110417 21:51:37< mordante> and if the second range is longer but equal for the first range it returns that the ranges are equal
20110417 21:52:43< mordante> tschmitz, so that means it's not compiler specific, the original code had a bug, so no need for compiler specific comment
20110417 21:53:11< tschmitz> Does vector have an operator== overload?
20110417 21:53:31< Qbunia> asd
20110417 21:54:02< gabba> mordante: wow, so equals() is useless for comparing ranges that are not of the same length
20110417 21:54:38< mordante> tschmitz, I recommend this side in your bookmarks http://www.cppreference.com/
20110417 21:54:55< mordante> and to answer your question http://www.cppreference.com/wiki/container/vector/operator_comp
20110417 21:55:07< tschmitz> Thanks
20110417 21:55:14< mordante> you're welcome
20110417 21:55:21 * gabba shakes fist at the stl
20110417 21:55:34-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 21:55:40< mordante> gabba, seems like it, most algorithms really do only one thing
20110417 21:56:03< mordante> gabba, and how is it supposed to know the length of the second range?
20110417 21:56:04< gabba> I think I was spoiled by java Collections
20110417 21:56:42< tschmitz> by hitting .end()
20110417 21:56:59< tschmitz> but I understand now that std::equal() is not what we want here
20110417 21:57:03< mordante> gabba, if both are vectors (and tschmitz's question is hinting at it) you could have used the ==
20110417 21:57:20< mordante> tschmitz, and how does std::equal know where end() is?
20110417 21:58:33< tschmitz> mordante: Hm, OK. How did gcc avoid the assertion failure then?
20110417 21:58:35< gabba> mordante: yeah... since you enter iterator as arguments and not containers, it can't call end() on something to compare it to the current iterator
20110417 21:58:46< mordante> gabba, exactly
20110417 21:58:54 * gabba slaps forehead
20110417 21:59:07< mordante> tschmitz, well welcome into the land of undefined behaviour
20110417 21:59:26< tschmitz> I think I'll go home and change to ==
20110417 21:59:34-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 21:59:51< mordante> and I wouldn't be surprised if operator== tests for the length and then uses std::equal 
20110417 22:00:04< mordante> tschmitz, if both are vectors that would be the best solution
20110417 22:00:14< gabba> now I'm asking myself why I didn't use == ... good question, git-svn should also save our thought process
20110417 22:00:17< Aethaeryn> ugh
20110417 22:00:21< Aethaeryn> still broken :/
20110417 22:00:41< mordante> gabba, :-)
20110417 22:00:42< tschmitz> That was a metaphorical "go home" by the way; I'm already home.
20110417 22:01:44< CIA-82> crab * r49261 /trunk/src/formula_function.cpp: modify formula ai functions floor and ceil to behave like c++ floor and ceil. fixes error spotted by mordante
20110417 22:01:44-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 22:03:06< mordante> Crab_ actually cppcheck spotted the issue ;-)
20110417 22:04:12-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110417 22:04:31-!- negusnyul [~negusnyul@BC244FEB.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20110417 22:04:38< mordante> Crab_ actually cppcheck spotted the issue ;-)
20110417 22:04:39< Crab_> mordante: but you run it and commented here on IRC about it :))
20110417 22:04:48< mordante> true
20110417 22:04:59-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has quit [Ping timeout: 252 seconds]
20110417 22:05:19< Crab_> so, it now behaves like http://www.cplusplus.com/reference/clibrary/cmath/floor and http://www.cplusplus.com/reference/clibrary/cmath/ceil/
20110417 22:05:29< mordante> it's really nice to see what it sometimes spots
20110417 22:05:38< Crab_> yes
20110417 22:05:48< Crab_> Aethaeryn: anything I can help with ?
20110417 22:11:02< Aethaeryn> Crab_: At this point I've just commented out much of my code and I'm continuously recompiling with more uncommented until I can track it down :/
20110417 22:11:10< Crab_> ok
20110417 22:11:28< Crab_> not the best approach usually, wesnoth is too slow to recompile :)
20110417 22:11:37< mordante> Crab_, I had a look at Upthorn's commit today and noticed some odd style, but I see you also use it eg ai_execute_move
20110417 22:11:54< Aethaeryn> Well, yeah, but every other approach I thought of hasn't worked, so if I'm going to waste a lot of time I might as well do it the brute force way.
20110417 22:12:04< mordante> Crab_, is there a reason for the goto's instead of a normal if?
20110417 22:13:19< Crab_> mordante: there was a reason when we had C-style lua, for lua code
20110417 22:13:23< Upthorn> mordante: Crab_ and I had a talk about just that, and my more recent commit should answer yourquestion
20110417 22:13:35< Crab_> mordante: goto jumped-out-of-scope, calling the destructors
20110417 22:13:49< Crab_> mordante: with c++ lua, all such code should be rewritten
20110417 22:14:04< Crab_> s/c++/"c++" :)
20110417 22:14:07< Qbunia> where is function: calculate_possible_moves( ? 
20110417 22:14:09< gabba> tschmitz: to conclude on the std::equals thing, definitely change it for ==
20110417 22:14:17< Crab_> Qbunia: src/ai/context.cpp
20110417 22:14:30-!- inferno8 [~kvirc@178-36-69-240.adsl.inetia.pl] has quit [Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/]
20110417 22:14:33< Qbunia> thx
20110417 22:14:40< Crab_> Qbunia: in general, fgrep (or any IDE with search-in-files) support is a fast way to find those
20110417 22:14:50< Qbunia> iam using notepad++ 
20110417 22:14:56< Qbunia> and i coulnt find it i dunno why 
20110417 22:14:57< Crab_> it has this
20110417 22:15:00< Qbunia> searched for cpp files
20110417 22:15:15< Crab_> Search -> Find in files
20110417 22:15:22< Qbunia> yes i know iam using it all the time 
20110417 22:15:23< tschmitz> gabba: Testing wesnoth with that change now
20110417 22:15:33-!- eoc [~eoc@pD95612F6.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20110417 22:15:36< Qbunia> but in this case it bring me 0 results :|
20110417 22:15:44< Qbunia> i typed good that name
20110417 22:16:01< mordante> Upthorn, I saw that commit, but didn't explain why to goto's were used
20110417 22:16:28< mordante> Crab_, ok thanks, that explains it
20110417 22:16:31< Upthorn> well in the new commit, they aren't
20110417 22:17:13-!- eoc [~eoc@pD95611C8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 22:17:14< mordante> Upthorn, yes I saw that, but that doesn't explain to me why they were used
20110417 22:17:36-!- GeorgeSebastian [~georgeSeb@117.230.111.64] has joined #wesnoth-dev
20110417 22:17:36-!- GeorgeSebastian [~georgeSeb@117.230.111.64] has quit [Changing host]
20110417 22:17:36-!- GeorgeSebastian [~georgeSeb@unaffiliated/georgesebastian] has joined #wesnoth-dev
20110417 22:17:55< Upthorn> they were used in the first one because I saw their use in other functions, and Crab_ wasn't on to ask if there was a reason, so I assumed there was
20110417 22:18:28< Qbunia> Crab_: how does this movment map works ? i know that multimap can have multiple values assigned to 1 key and we can get it by iterator 
20110417 22:18:51< Upthorn> later, Crab_ explained that there isn't any reason to do it that way anymore, so it was changed
20110417 22:19:07< mordante> Upthorn, yeah I assumed that was the reason you did it, but I expected Crab_ had a good reason to do so, but didn't know what it was
20110417 22:19:32< Qbunia> i guess that movment map is a map where all units of side can go so key is a map location xy and values are multiple hexs where we can get from that map location 
20110417 22:19:34< mordante> and the reason wasn't documented
20110417 22:19:44< Crab_> Qbunia: yes, it just stores all pairs of <from,to> of our moves
20110417 22:19:51< Qbunia> ^^
20110417 22:20:00< Crab_> Qbunia: and, for dstsrc map, it stores all pairs of <to,from>
20110417 22:20:16< Crab_> it is a multimap because each our unit is usually able to move to 2+ hexes
20110417 22:20:25< Qbunia> ye
20110417 22:20:27< Crab_> so, for each to, there's multiple froms
20110417 22:20:39< Crab_> and, for each from, multiple tos
20110417 22:20:51< Qbunia> yes i see ;)
20110417 22:22:09-!- Guest62239 [~jeff@S01060040f4e77a17.ok.shawcable.net] has quit [Ping timeout: 246 seconds]
20110417 22:23:45-!- dtiger [~dtiger@dynamic-vpdn-93-125-68-107.telecom.by] has quit [Remote host closed the connection]
20110417 22:26:27-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has joined #wesnoth-dev
20110417 22:27:39-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Read error: Connection reset by peer]
20110417 22:27:39-!- Afan_ [~IceChat77@c-76-29-51-121.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
20110417 22:28:40< mordante> tschmitz, do you have an eta for the next version of your patch? (I'm about to leave, but can wait a little bit longer if you're almost done)
20110417 22:29:37< tschmitz> mordante: Sorry, it'll be a little while;
20110417 22:30:14< tschmitz> I was just testing a couple of the changes
20110417 22:30:14< tschmitz> I didn't realize you were waiting on me, exactly
20110417 22:30:32< mordante> tschmitz, no problem just want to make sure you don't have a patch ready the second I left ;-)
20110417 22:30:39< tschmitz> If you're about to leave, you probably might as well
20110417 22:30:41< tschmitz> OK
20110417 22:31:27< mordante> I'm not waiting ;-)
20110417 22:31:59< tschmitz> tschmitz: OK; heading out then?
20110417 22:32:08< tschmitz> lol
20110417 22:32:09< tschmitz> mordante: OK; heading out then?
20110417 22:32:25-!- Sytyi [~chatzilla@70-54-133-95.pool.ukrtel.net] has quit [Ping timeout: 246 seconds]
20110417 22:32:30-!- elias [~allefant@allefant.com] has quit [Changing host]
20110417 22:32:30-!- elias [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20110417 22:33:04< mordante> tschmitz, in a few minutes
20110417 22:34:48< Qbunia> is in wesnoth function that handles patrol ?
20110417 22:35:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110417 22:36:30< Aethaeryn> 2 bugs remaining
20110417 22:36:32< Aethaeryn> Finally.
20110417 22:36:36< Aethaeryn> Damn that took forever.
20110417 22:36:48< Aethaeryn> At least I'm now 100% certain what the Lua stack is and how it works :-P
20110417 22:36:52< Aethaeryn> Having dissected it for hours :-P
20110417 22:36:57< CIA-82> gabba * r49262 /trunk/images/whiteboard/suppose_dead.png: Placeholder image for the upcoming Suppose Dead whiteboard feature
20110417 22:37:01< Crab_> :) great
20110417 22:37:36< tschmitz> gabba: Thanks lol
20110417 22:38:09< gabba> tschmitz: no problem, notice I changed the file name in advance so we can replace it later with something better
20110417 22:38:13< tschmitz> gabba: I'll change the image name in the code in my updated patch
20110417 22:38:19< CIA-82> espreon * r49263 /trunk/images/whiteboard/suppose_dead.png: Ran umcpropfix.
20110417 22:38:48< gabba> Espreon: you're fast as hell, or a bot does that for you?
20110417 22:38:58< Espreon> The former.
20110417 22:40:03< gabba> Espreon: nice.
20110417 22:40:14< Espreon> Thanks.
20110417 22:40:28< Espreon> Yeah, I'm often really bored...
20110417 22:40:48< Espreon> So, once a new file comes in, I immediately check to see if it has the right properties set.
20110417 22:41:09 * mordante wished he had time to be bored ;-)
20110417 22:41:39< Espreon> I have plenty of that.
20110417 22:41:40-!- eoc` [~eoc@pD95611E8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 22:42:09< gabba> Espreon: umcpropfix is a script that isn't in the wesnoth trunk, isn't it?
20110417 22:42:26< Espreon> It is not.
20110417 22:42:35< Espreon> It lies in Wesnoth-UMC-Dev.
20110417 22:42:36-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 22:43:38-!- eoc [~eoc@pD95611C8.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20110417 22:43:57-!- eoc` is now known as eoc
20110417 22:44:30< Qbunia> Crab_: those functions in ca.cpp they works fine ? Are they used by cpp AI ?
20110417 22:44:38< Crab_> yes / yes
20110417 22:45:13< Qbunia> so i see it is possible to implement some of those to lua 
20110417 22:46:12< Qbunia> having map location, target list and movmet map + aspects in lua 
20110417 22:47:11< Crab_> yes, it is already possible to write candidate actions in lua. but, to write stuff that works like that, we need that ' map location, target list and movmet map + aspects in lua' part 
20110417 22:47:30< Crab_> of course, we don't need to rewrite those if they work ok. but we want to allow people to write other like these.
20110417 22:47:43-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 22:48:10-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Remote host closed the connection]
20110417 22:48:16< Qbunia> yea 
20110417 22:48:50< Qbunia> Crab_: i see we dont have a mechanism like patrol or guard ? 
20110417 22:49:08< tschmitz> gabba, anybody: Any recommendations on a hotkey to use for Suppose Dead?
20110417 22:50:21< Crab_> Qbunia: LoW (Legend of Wesmere), scenario 16 (The chief must die) has a patrol written in formula ai. 
20110417 22:51:01< Crab_> Qbunia: but the code ( data/campaigns/Legend_of_Wesmere/ai/patrol.fai ) is NOT prettry
20110417 22:51:03< Crab_> *pretty
20110417 22:51:42< gabba> tschmitz: preferably a letter, something not too far from y and h... but I think the whiteboard hotkeys need rethinking, so for now any will I think
20110417 22:52:06< gabba> tschmitz: backspace or delete would be funny though, if they're unused and easy to assign
20110417 22:52:08 * mordante loves the any key :-P
20110417 22:52:30< gabba> lol
20110417 22:52:32< tschmitz> Ah, yes ... the N+E key
20110417 22:52:35< Qbunia> Crab_: ye the code is weird ... 
20110417 22:52:44< Qbunia> Crab_: so what about guarding? 
20110417 22:52:54< Qbunia> Crab_: guard location or unit ;> 
20110417 22:53:08< Crab_> Qbunia: no, there's no code for that
20110417 22:53:34< Crab_> Qbunia: in Seek & Hide, in Liberty campaign, it's hand-coded using WML tricks
20110417 22:53:36-!- eoc` [~eoc@pD95611E0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 22:54:21< tschmitz> OK so { grep "key=i" hotkeys.cfg } gets no hits
20110417 22:54:40< tschmitz> Does that mean 'i' is free?
20110417 22:56:00-!- loonybot [~loonybot@ppp109-252-61-208.pppoe.spdop.ru] has joined #wesnoth-dev
20110417 22:56:00-!- loonybot [~loonybot@ppp109-252-61-208.pppoe.spdop.ru] has quit [Changing host]
20110417 22:56:00-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110417 22:56:11-!- eoc [~eoc@pD95611E8.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20110417 22:56:17-!- eoc` is now known as eoc
20110417 22:56:24< gabba> assuming you tested your grep on another key you know it's there, probably
20110417 22:56:37< mordante> tschmitz, yes
20110417 22:56:42-!- MeccaGod [~majs@h14n4fls31o279.telia.com] has quit []
20110417 22:56:43< gabba> check the wesnoth manual to make sure, some stuff like the number keys is hardcoded
20110417 22:57:10< gabba> (and not necessarily documented, not sure those are listed in the manual)
20110417 22:57:59< tschmitz> Hrmrmmm ...
20110417 22:58:47< gabba> Hey that would be a task to add to Easy Coding on the wiki: un-hardcode all the hardcoded keys
20110417 22:59:01< gabba> (identify and ...)
20110417 22:59:17< mordante> gabba, what's wrong with a hard-coded default?
20110417 23:00:08< gabba> mordante: I have nothing against defaults, as long as you can find everything in one place -- those number keys are one exception
20110417 23:00:16-!- tschmitz_ [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 23:00:27-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110417 23:00:48< gabba> As well as shift to accelerate animations
20110417 23:00:56< mordante> ah yes true
20110417 23:02:02< Aethaeryn> ROFLMAO
20110417 23:02:12< Aethaeryn> Segmentation Fault (core dumped)
20110417 23:02:25-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 23:02:27< Aethaeryn> I guess that doesn't fix my bug
20110417 23:04:36-!- tschmitz_ [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110417 23:06:03-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 264 seconds]
20110417 23:09:19< mordante> I'm off night
20110417 23:09:45-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20110417 23:10:39-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20110417 23:13:24-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110417 23:14:03-!- Blueblaze2 [~Blueblaze@adsl-99-182-53-32.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110417 23:15:50-!- Blueblaze [~Blueblaze@adsl-99-158-44-255.dsl.hstntx.sbcglobal.net] has quit [Read error: Operation timed out]
20110417 23:15:50-!- Blueblaze2 is now known as Blueblaze
20110417 23:16:52-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110417 23:21:12-!- Blueblaze [~Blueblaze@adsl-99-182-53-32.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110417 23:29:55-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20110417 23:40:52< gabba> tschmitz: an issue that's quite normal given how the whiteboard works, but that'll likely seem strange to users, is that you can't get mouseover information anymore when above a "suppose dead" unit
20110417 23:41:40< tschmitz> gabba:  Yeah I think that one confused my roommate
20110417 23:42:14< gabba> Ah I see you already have testers :) !
20110417 23:42:28< tschmitz> Hah
20110417 23:42:32< tschmitz> Yeah something like that
20110417 23:43:35< gabba> It would be nice to think up a solution... it'll probably involve modifying quite a bit how the sidebar gets the unit it should display, though
20110417 23:44:42< tschmitz> maybe we should just make the unit disappear ... or be faded out ...
20110417 23:45:24< tschmitz> or make the sidebar get its info from the real unit map
20110417 23:45:28-!- eoc` [~eoc@pD95600DE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110417 23:47:51-!- eoc [~eoc@pD95611E0.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20110417 23:47:57-!- eoc` is now known as eoc
20110417 23:48:41< gabba> "make the sidebar get its info from the real unit map": then you get problems with no mouseover on unit ghosts
20110417 23:49:42-!- eleazzaar [~jbjerk@ppp-70-226-217-90.dsl.spfdil.ameritech.net] has quit [Quit: eleazzaar]
20110417 23:50:10< gabba> but we can test the simple solution first, which is: just cover up the unit with an enlarged skull image
20110417 23:50:26< gabba> tschmitz: ^
20110417 23:51:41< tschmitz> gabba: Yeah, sounds good. When you move another unit into that spot, will the ghost unit get drawn over that skull?
20110417 23:52:54< gabba> You put it into the arrows layer, and I think that gets drawn on top of units. You might wanna fiddle with that.
20110417 23:57:37-!- eleazzaar [~jbjerk@ppp-70-226-217-90.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110417 23:58:25-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Read error: Connection reset by peer]
--- Log closed Mon Apr 18 00:00:03 2011