--- Log opened Sat May 07 00:00:05 2011
20110507 00:05:01-!- ancestral [~ancestral@198.228.226.176] has joined #wesnoth-dev
20110507 00:06:35< zaroth> boucman: there is no much more studying needed, more of writing test code for what I've alread ywritten :-)
20110507 00:07:10< zaroth> boucman: if everything goes as planned, I should make a nice commit tomorrow
20110507 00:09:22< ancestral> zaroth: How does the combo updater apply binary patches for 1.8.1 vs 1.8.2?
20110507 00:09:41< zaroth> ancestral: I have replied you in topic...
20110507 00:09:49< ancestral> I saw
20110507 00:10:22< ancestral> I guess something doesn't make sense to me
20110507 00:10:52< zaroth> I don't know if we speak about the same thing then... My aim is to make a patch installer which will upgrade any of the 1.8.x versions directly to the newest one
20110507 00:11:08< zaroth> not by applying incremental patches one-by-one
20110507 00:11:14< ancestral> Okay
20110507 00:11:32< ancestral> So you have 5 different bdiffs
20110507 00:11:42< ancestral> For a given binary?
20110507 00:12:30< zaroth> let me quote my post: "I added a --replace option to this tool to generate patchers who package the whole files from new version instead of generating diffs and applying them afterwards"
20110507 00:12:38< zaroth> that means that it does *no* bdiffs at all
20110507 00:12:58< zaroth> it just packages new version of the files and bluntly overwrites whatever is there
20110507 00:13:21< zaroth> simple and more efficient than having several bdiffs inside :-)
20110507 00:13:37< ancestral> So you're bundling a full binary of say the exe?
20110507 00:13:48< zaroth> (believe me, I did test how much would the patch weigh with bdiffs)
20110507 00:13:57< zaroth> correct
20110507 00:14:25< ancestral> Just curious, how much does the exe weigh in at?
20110507 00:14:30< zaroth> when I did a bdiff for 1.8.0 -> 1.8.5 it took ~23MB
20110507 00:14:57< zaroth> patch replacing all the files from 1.8.x to 1.8.5 as you can see takes ~37 MB
20110507 00:15:15< zaroth> bundling all the 1.8.0, 1.8.1, 1.8.2 etc. bdiffs would surely take more than that
20110507 00:15:26 * ancestral nods
20110507 00:15:31< zaroth> and be more error-prone, since the user may have edited any of the files
20110507 00:15:47< zaroth> and a single bdiff could fail - what then?
20110507 00:15:54< ancestral> Text files, sure, binary files very unlikely
20110507 00:16:06< zaroth> well, viruses do exist, you know ;-)
20110507 00:16:21< zaroth> and they have the nice quality of attaching themselves to .exe files...
20110507 00:16:41< zaroth> (some of them)
20110507 00:16:51< ancestral> Wait, you don't do any diffs at all?
20110507 00:17:04< zaroth> none at all
20110507 00:17:14< zaroth> the only diff I make is in the generation of patch process
20110507 00:17:22< zaroth> "diff"
20110507 00:17:31< ancestral> cool
20110507 00:17:39< zaroth> I hash every file from 1.8.0 and 1.8.5 to see if contents changed
20110507 00:18:24< zaroth> to generate the list of files to include :-)
20110507 00:22:14-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: Zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz]
20110507 00:22:24-!- jiero [~jie@115-64-43-246.static.tpgi.com.au] has joined #wesnoth-dev
20110507 00:22:45-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110507 00:23:42-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Remote host closed the connection]
20110507 00:34:20-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20110507 01:01:09-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has left #wesnoth-dev [":wq"]
20110507 01:04:45-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110507 01:10:48-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110507 01:11:28-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has quit [Client Quit]
20110507 01:14:27-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Read error: Operation timed out]
20110507 01:14:55-!- zaroth [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev
20110507 01:26:19-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110507 01:29:27-!- sheraff [~Tri@c-98-196-106-93.hsd1.tx.comcast.net] has quit [Ping timeout: 240 seconds]
20110507 01:30:04-!- akzfowl [~akzfowl@1.186.7.45] has quit [Ping timeout: 240 seconds]
20110507 01:31:09-!- ancestral_ [~ancestral@209.181.233.7] has joined #wesnoth-dev
20110507 01:31:16-!- ancestral [~ancestral@198.228.226.176] has quit [Quit: Smell ya later!]
20110507 01:31:16-!- ancestral_ is now known as ancestral
20110507 01:32:59-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 240 seconds]
20110507 01:37:56-!- sheraff [~Tri@c-98-196-106-93.hsd1.tx.comcast.net] has joined #wesnoth-dev
20110507 01:50:44-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer]
20110507 01:51:03-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20110507 02:00:04-!- ancestral [~ancestral@209.181.233.7] has quit [Quit: i go sleeps kthxbai]
20110507 02:08:09-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has joined #wesnoth-dev
20110507 02:23:20-!- molgrum [~molgrum@h-189-85.A189.priv.bahnhof.se] has joined #wesnoth-dev
20110507 02:23:27-!- molgrum [~molgrum@h-189-85.A189.priv.bahnhof.se] has left #wesnoth-dev []
20110507 02:26:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110507 02:29:46-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has left #wesnoth-dev []
20110507 02:37:03-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has joined #wesnoth-dev
20110507 02:37:06-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has quit [Client Quit]
20110507 02:42:52-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Remote host closed the connection]
20110507 02:46:25-!- eoc [~eoc@pD9560E80.dip0.t-ipconnect.de] has quit [Quit: They are in love. Fuck the war.]
20110507 02:49:47-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds]
20110507 03:05:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110507 03:38:37-!- sheraff [~Tri@c-98-196-106-93.hsd1.tx.comcast.net] has quit [Read error: Connection reset by peer]
20110507 03:39:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110507 03:46:27-!- Shakey [~Shakey@12.190.80.225] has quit [Quit: Default + Kalifate]
20110507 03:58:21-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110507 04:01:34-!- Blueblaze [~Blueblaze@adsl-99-185-10-185.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110507 04:10:34-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110507 04:15:08-!- Ivanovic_ [~ivanovic@dtmd-4db23183.pool.mediaWays.net] has joined #wesnoth-dev
20110507 04:15:43-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has joined #wesnoth-dev
20110507 04:18:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 248 seconds]
20110507 04:19:04-!- Ivanovic_ is now known as Ivanovic
20110507 04:19:33-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has quit [Read error: Connection reset by peer]
20110507 04:20:37-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has joined #wesnoth-dev
20110507 04:20:51-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has quit [Client Quit]
20110507 04:22:50-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has joined #wesnoth-dev
20110507 04:23:51-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110507 04:24:59< melinath> GUIWML question: Does anyone happen to know how to put focus on a text_box widget with wml and/or lua? The edit_label window and the load_game window use autofocusing, but the code that makes it work is external to the window definition and I've been unable to track it down.
20110507 04:28:07-!- eleazzaar_ [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110507 04:28:07-!- eleazzaar [~jbjerk@70.226.200.254] has quit [Read error: Connection reset by peer]
20110507 04:28:08-!- eleazzaar_ is now known as eleazzaar
20110507 04:28:10-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 246 seconds]
20110507 04:29:46-!- eleazzaar_ [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110507 04:29:46-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has quit [Read error: Connection reset by peer]
20110507 04:29:46-!- eleazzaar_ is now known as eleazzaar
20110507 04:30:41-!- eleazzaar_ [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110507 04:30:41-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has quit [Read error: Connection reset by peer]
20110507 04:30:42-!- eleazzaar_ is now known as eleazzaar
20110507 04:38:15-!- SpoOkyMagician [~chatzilla@74-138-202-211.dhcp.insightbb.com] has quit [Quit: i have things to do... I mean, I have no idea...]
20110507 04:38:25-!- fendrin [~fabi@88-134-60-109-dynip.superkabel.de] has quit [Remote host closed the connection]
20110507 04:44:04-!- dansan [~daniel@99-70-244-137.lightspeed.rcsntx.sbcglobal.net] has joined #wesnoth-dev
20110507 04:45:22< dansan> Hey guys, I'm trying to add an ability via lua and I don't appear to be going about it correctly (needs to work in 1.8 as well as 1.9).  So can't I just do  helper.get_child(unit.__cfg, "abilities") and if I get nil, to a table.insert(unit.__cfg, {"abilities" {}}) and repeat the same procedure for the specific ability?
20110507 04:46:02< dansan> err, " if I get nil, *do* a table.insert..."
20110507 04:50:42< dansan> i.e., if you change wml via lua, do you have to do some type of save operation or am I simply attempting it incorrectly?
20110507 04:56:28-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has quit [Quit: eleazzaar]
20110507 04:57:59< melinath> dansan: you don't need to do any kind of save operation
20110507 04:58:20< dansan> melinath: well, my new abilities aren't showing up :(
20110507 04:58:35< dansan> melinath: isn't it basically the unit.__cfg.abilities.<ability_name>
20110507 04:58:46< dansan> err, well that's not correctl lua...
20110507 04:59:49< melinath> dansan: I'm trying to find a certain bit of documentation... just a sec
20110507 04:59:52< dansan> unit.__cfg would have a child like this: {"abilities", {"my_ability}, {name="something, description="something", id="something", etc... }}}
20110507 04:59:56< dansan> ty!
20110507 05:00:29< dansan> correction: {"abilities", {"my_ability", {name="something", description="something", id="something", --[[ etc...]]-- }}}
20110507 05:04:20< melinath> dansan: I think you may need to use put_unit to replace the unit if you're modifying it like that.
20110507 05:04:42< dansan> w00t! :)
20110507 05:04:45< melinath> Which I guess would be sort of like a save operation after all
20110507 05:04:48< melinath> http://wiki.wesnoth.org/LuaWML:Units
20110507 05:05:36< melinath> only the proxied fields write directly to the unit instance... afaict the cfg is not direct access.
20110507 05:06:05< dansan> ok, I think I understand.  
20110507 05:06:07< melinath> but you should be able to do "put_unit(x,y,u.__cfg)", which might work
20110507 05:06:31< dansan> so I'm basically replacing the existing unit at the coordinate with a copy of it's self, slightly modified :)
20110507 05:06:48< melinath> that's the idea.
20110507 05:06:55< melinath> hopefully it works!
20110507 05:07:02< dansan> Too bad the __cfg object (which is "userdata" type) doesn't directly manipulate the wesnoth internal objects
20110507 05:08:48< dansan> didn't work :(
20110507 05:09:12< dansan> mayhap I'm incorrectly manipulating the wml in the 1st place
20110507 05:09:22< dansan> oh, phone...
20110507 05:09:58< melinath> could be.
20110507 05:15:50-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20110507 05:15:50-!- Upth is now known as Upthorn
20110507 05:22:32-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 276 seconds]
20110507 05:23:29-!- Gambit [~quassel@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20110507 05:41:20-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has quit [Ping timeout: 240 seconds]
20110507 05:55:39-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110507 06:10:29-!- ancestral [~ancestral@198.228.226.176] has joined #wesnoth-dev
20110507 06:17:26-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Remote host closed the connection]
20110507 06:21:59< shadowmaster> YAY! http://shadowm.ai0867.net/method_not_implemented.png
20110507 06:23:19< shadowmaster> Somewhat related: Wesnoth.org lately likes to ignore my POST data for some reason, both in the forums and the wiki.
20110507 06:23:24-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20110507 06:23:39< shadowmaster> Although being the lazy bum I am, I don't know if it's just my browser or ISP.
20110507 06:26:11-!- knotwork__ [~markm@unaffiliated/knotwork] has quit [Ping timeout: 240 seconds]
20110507 06:31:07-!- ancestral [~ancestral@198.228.226.176] has quit [Quit: Smell ya later!]
20110507 06:32:36-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20110507 06:40:59-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has quit [Ping timeout: 240 seconds]
20110507 06:43:03-!- ancestral [~ancestral@198.228.226.176] has joined #wesnoth-dev
20110507 06:56:14-!- akzfowl [~akzfowl@1.186.7.45] has joined #wesnoth-dev
20110507 06:57:01-!- Khezar [~Greywhind@138.16.23.112] has joined #wesnoth-dev
20110507 06:57:08-!- Khezar [~Greywhind@138.16.23.112] has quit [Client Quit]
20110507 07:12:46-!- ancestral [~ancestral@198.228.226.176] has quit [Quit: Smell ya later!]
20110507 07:13:38-!- cjhopman [~chris@wesnoth/developer/cjhopman] has quit [Remote host closed the connection]
20110507 07:15:39-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Remote host closed the connection]
20110507 07:15:50-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110507 07:16:52-!- cjhopman [~chris@24-183-40-128.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20110507 07:16:52-!- cjhopman [~chris@24-183-40-128.dhcp.mdsn.wi.charter.com] has quit [Changing host]
20110507 07:16:52-!- cjhopman [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20110507 07:24:31< dansan> melinath: nope, didn't work :(
20110507 07:24:59< dansan> So hey guys, any ideas on manipulating abilities via lua?
20110507 07:25:08< dansan> this is in 1.8
20110507 07:25:36< dansan> I attempted to do it by altering unit.__cfg, but no luck, it doesn't save my changes
20110507 07:29:58< dansan> fyi, cute table dumping function: http://pastebin.ca/2054772
20110507 07:30:03< dansan> (lua)
20110507 07:32:38< dansan> shadowmaster: something to consider - in a bugzilla database (I think at apache.org) I had no end of trouble until I deleted all of my cookies from that site.  Obviously, it sucks trying this to find that it doesn't work and you have to re-enter all of your data again
20110507 07:34:45-!- Blueblaze [~Blueblaze@adsl-99-185-10-185.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110507 07:39:21-!- dtiger [~dtiger@dynamic-vpdn-93-125-15-40.telecom.by] has joined #wesnoth-dev
20110507 07:39:54-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110507 07:46:01-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110507 07:46:45< dansan> man, that's really frustrating :(
20110507 07:47:11< dansan> a lua implementation should give you much more direct access to internal game ojects
20110507 07:49:46< Crab_> dansan: is helper.modify_unit usable for that purpose ?
20110507 07:50:14< Crab_> dansan: if not, it's easy to copy it's code and change the 'for k, v in pairs(vars) do' part do do something else.
20110507 07:50:32< Crab_> it does a find_and_store-modify-unstore , basically
20110507 07:51:26< dansan> well, I tried helper.modify_unit, but I didn't have success.  Being that I needed to access the "abilities" and add a new one, I attempted this: helper.modify_unit({x = 10, y = 10}, {"abilities", {{"suckme", {name="suck my balls", id="suckme", description="suck me hard" }}}})
20110507 07:51:35< dansan> well, obviously, I was frustrated
20110507 07:52:05< dansan> Ideally, it would have created a "suckme" ability that was only visual
20110507 07:52:47< dansan> Crab_ where is the code for functions like modify_unit?
20110507 07:53:04< Crab_> data/lua/helper.lua
20110507 07:53:25< Crab_> basically, at the end you need to store your new config into WML variable and unstore it as unit on the original location
20110507 07:53:33< dansan> ahh, found it :0
20110507 07:54:16< dansan> Crab_ wait, I don't understand that" store it has a config into WML variables" and then "unstore it"?
20110507 07:54:25< dansan> please elaborate
20110507 07:54:52< Crab_> take a look at the source of modify_unit
20110507 07:55:04< dansan> oh!! you mean the WML action store_unit!
20110507 07:55:12< Crab_> wesnoth.fire("store_unit" ... -> this part stores the unit's config in the WML variable
20110507 07:55:13< dansan> all it's doing is firing off wml, that kinda sucks :(
20110507 07:55:34< Crab_> note that you can get away without this part
20110507 07:55:42< dansan> rather than interfacing into the WML laungauge layer, I was hoping it would modify the underlying (i.e., C-level) objects :(
20110507 07:55:43< Crab_> you can take units config in lua form, and modify it
20110507 07:56:06< dansan> yeah, that's what I've been doing, directly manipulating unit.__cfg
20110507 07:56:07< Crab_> but, at the end, as of now, you'll need to call unstore_unit to replace the unit
20110507 07:56:22< dansan> ok
20110507 07:56:25< Crab_> so, you need to get that __cfg to be an argument to unstore_unit, for the unit to be changed
20110507 07:57:08< dansan> rather than complain, I should have finished Glest's lua interface instead of leaving the project, lol!
20110507 07:57:24-!- jiero [~jie@115-64-43-246.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20110507 07:57:28< dansan> it was going to give direct & immediate access to all facets of the units, map, etc.
20110507 07:57:29< Crab_> and since unstore unit works with wml variables, you'll need wesnoth.set_variable to store it somewhere
20110507 07:57:49-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110507 07:59:07< Crab_> yes, if someone will modify impl_unit_set and impl_unit_get in src/scripting/lua.cpp to provide direct read-write-add-delete access to abilities, it'll be more funny to work with.
20110507 07:59:25-!- Blueblaze [~Blueblaze@adsl-99-185-10-185.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110507 07:59:43< dansan> but how do you append?  So like unit.abilities needs another child.  Do I 1st find the length of the array and then assign unit.abilities[len+1] = my new ability?
20110507 08:00:18< dansan> I know then that they will be woried about security, but you have to scrutinize that in your design 
20110507 08:01:11< dansan> that's the thing with each collection, you have to have a mechanism to delete existing items (which can have other links) and create & add new ones -- I know that can be tricky
20110507 08:02:04< Crab_> table.insert(tablevar, value)
20110507 08:02:42< Crab_> to expose wesnoth's data to lua, wesnoth's data would need to have a metamodel attached to them, which is not the case atm (' you have to have a mechanism to delete existing items (which can have other links) and create & add new ones' )
20110507 08:03:10< Crab_> after the metamodel is in place, it'll be possible to enumerate it and generate the lua accessor code on the fly.
20110507 08:36:30-!- Appleman1234 [~Appleman1@119.225.96.245] has joined #wesnoth-dev
20110507 08:36:34-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has joined #wesnoth-dev
20110507 08:40:21-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20110507 08:40:21-!- Upth is now known as Upthorn
20110507 08:43:05-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20110507 08:48:48< dansan> Crab_: sorry for the late reply, but yeah, that's pretty much my idea
20110507 08:49:01< dansan> but for now, I just want to finish this cute little scenario, lol!
20110507 08:49:05< Crab_> :) good luck
20110507 08:49:42< boucman> morning all
20110507 08:49:52< Crab_> morning, boucman
20110507 09:06:10-!- knotwork__ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20110507 09:09:23-!- knotwork_ [~markm@unaffiliated/knotwork] has quit [Ping timeout: 240 seconds]
20110507 09:18:23-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 258 seconds]
20110507 09:20:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110507 09:36:53-!- Appleman1234 [~Appleman1@119.225.96.245] has quit [Ping timeout: 252 seconds]
20110507 09:37:27-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has joined #wesnoth-dev
20110507 09:38:10-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20110507 09:45:49< Crab_> deekay: hello. have you got a chance to look at the MP chat window ? 
20110507 09:45:54-!- melinath [~melinath@ip-75-137.wireless.oberlin.edu] has quit [Ping timeout: 260 seconds]
20110507 09:46:17< Crab_> deekay: I will have some time to fix/rework things on Sunday, so it would be a good idea if I get some feedback, since 1.8.6 is not far out
20110507 09:46:28< Crab_> (' 1.8.6 planned for 11th May; ')
20110507 09:46:39< deekay> Crab_: Hey
20110507 09:47:37< deekay> Crab_: I had no time yet, and sadly I can't guess if I will have time today
20110507 09:47:38< Crab_> also, I'll have some time for backports, if there's some small-enough stuff which should be in 1.8 line
20110507 09:47:56-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110507 09:48:14< Crab_> (I'll read the logs, today and tomorrow, to see if there'll be suggestions)
20110507 09:48:23< deekay> There is one old bug...
20110507 09:48:33< deekay> Related to MP that was not fixed
20110507 09:49:08< Crab_> (so far, shadowmaster has pointed me to an issue related to player-gone-observer and team-only labels, which he has fixed for 1.9)
20110507 09:50:14< deekay> Thing is I believe that this bug still exists in 1.9 -> you have to start mp game, ith teammate,you move scout forward and back (you reveal new terrain), and once it is ack, your teammates can still see nrevealed terrain
20110507 09:50:28< deekay> I can't think of anything else
20110507 09:50:55-!- zaroth [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev
20110507 09:50:59< Crab_> ok, understood
20110507 09:51:48< boucman> morning zaroth
20110507 09:52:00< zaroth> hello boucman
20110507 09:52:02< shadowmaster> Crab_: I was planning to backport it as soon as I could bother running a few simple commands.
20110507 09:52:16< boucman> so, how is your code exploration going ?
20110507 09:52:40< Crab_> shadowmaster: ok, I'll handle it if it's not still backported by the time I get there )
20110507 09:58:46< zaroth> boucman: as I replied yesterday (?), fine - I should probably finally be ready to commit today :-)
20110507 09:59:08< boucman> hehe
20110507 10:04:53< boucman> great, what did you do so far ?
20110507 10:08:13-!- grzywacz [~grzywacz@89-78-180-180.dynamic.chello.pl] has joined #wesnoth-dev
20110507 10:08:13-!- grzywacz [~grzywacz@89-78-180-180.dynamic.chello.pl] has quit [Changing host]
20110507 10:08:13-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20110507 10:08:16< CIA-82> shadowmaster * r49404 /branches/1.8/ (changelog players_changelog src/map_label.cpp): 
20110507 10:08:16< CIA-82> Don't display team-based map labels to observers (bug #9648)
20110507 10:08:16< CIA-82> There's a glitch where if a player becomes observer due to the host's
20110507 10:08:16< CIA-82> use of the :control command, he/she will still be able to see his/her
20110507 10:08:16< CIA-82> team's labels until the currently playing side finishes his/her turn.
20110507 10:08:17< CIA-82> (Backported from trunk, r48572.)
20110507 10:08:32< CIA-82> shadowmaster * r49405 /branches/1.8/ (changelog src/playturn.cpp): 
20110507 10:08:32< CIA-82> Force gamemap label refreshing on controller switch events (i.e. :control)
20110507 10:08:32< CIA-82> This effectively fixes the glitch noted in 48572, and possibly others
20110507 10:08:32< CIA-82> not reported affecting the more general case.
20110507 10:08:32< CIA-82> (Backported from trunk, r48573.)
20110507 10:08:44< CIA-82> shadowmaster * r49406 /branches/1.8/players_changelog: Typo
20110507 10:08:53< shadowmaster> Crab_: ^^
20110507 10:10:24-!- ancestral [~ancestral@71-34-10-19.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20110507 10:10:28< Crab_> ok, thanks
20110507 10:10:36< shadowmaster> Crab_: I am getting this with r49406: 20110507 05:10:15 error gui/parse: horizontal_grow and horizontal_alignment can't be combined, alignment is ignored.
20110507 10:10:41-!- jiero [~jie@115-64-43-246.static.tpgi.com.au] has joined #wesnoth-dev
20110507 10:10:43< shadowmaster> (1.8, fresh build)
20110507 10:11:25< Crab_> probably a mistake in data
20110507 10:11:27< Crab_> is it fatal ?
20110507 10:11:47< shadowmaster> no, but it's labeled as "error", thus everyone will think it's fatal just judging by the looks
20110507 10:12:03< Crab_> ok, I'll take a look at it tomorrow, then
20110507 10:12:17< shadowmaster> Crab_: actually, it is fatal in a way :p
20110507 10:12:20< Crab_> it's probably a small mistake in the gui2 definition of the dialog in 'data'
20110507 10:12:27< shadowmaster> I am getting "unknown unit type <insert mainline unit type here>"
20110507 10:12:34< shadowmaster> so all MP games are broken
20110507 10:12:52< Crab_> how it can be related ?
20110507 10:13:45< shadowmaster> I don't know whether it's related yet, in fact.
20110507 10:15:22< Crab_> data/gui/default/window/chat_log.cfg, lines  99 and 102 - one of those must die for the greater good
20110507 10:16:01< Crab_> I'd start with 102, horizontal_alignment = "left" , remove it to see what happens :)
20110507 10:16:02< shadowmaster> mordante: what warnings does r49351 address?
20110507 10:16:16< shadowmaster> it'd be nice to have that information in the commit message so I didn't freak out at the massive removal of code.
20110507 10:16:44< shadowmaster> actually... let me try something
20110507 10:17:38< shadowmaster> oh for the love of...
20110507 10:17:50< shadowmaster> Crab_: it's mordante's r49351 that broke 1.8
20110507 10:18:19< Crab_> ok, understood.. happens sometimes )
20110507 10:19:45-!- Appleman1234 [~Appleman1@119.225.96.245] has joined #wesnoth-dev
20110507 10:20:29-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Quit: ZNC - http://znc.sourceforge.net]
20110507 10:20:39< shadowmaster> I guess I'm not in position to revert it upstream...
20110507 10:21:34< Crab_> well, there's still plenty of time before 1.8 release, so there's time to fix it...
20110507 10:22:29-!- vultraz [~chatzilla@124.109.10.191] has quit [Remote host closed the connection]
20110507 10:24:03-!- Octalot [~noct@host109-157-81-179.range109-157.btcentralplus.com] has joined #wesnoth-dev
20110507 10:25:24< shadowmaster> Ironically enough, trunk doesn't seem to be broken.
20110507 10:25:51< shadowmaster> Or at least, not in the same way. I can't say for sure whether more code disappeared.
20110507 10:27:32-!- Ivanovic [~ivanovic@dtmd-4db23183.pool.mediaWays.net] has quit [Changing host]
20110507 10:27:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110507 10:27:58< Ivanovic> moin
20110507 10:28:58< Ivanovic> shadowmaster: the error you are seeing is due to mordante
20110507 10:29:13< Ivanovic> shadowmaster: it was caused by the gcc 4.6 "warning" fixes
20110507 10:29:24< shadowmaster> No sh*t, Sherlock.
20110507 10:29:26< Ivanovic> and it not only stops mp games from working but also campaign gameplay
20110507 10:29:40< shadowmaster> Yeah, I noticed already, as you are about to find out.
20110507 10:29:44-!- negusnyul [~negusnyul@dsl5402136A.pool.t-online.hu] has joined #wesnoth-dev
20110507 10:29:53< Ivanovic> wrote about this yesterday already
20110507 10:34:40< shadowmaster> Crab_: back to the chatlog dialog, it also feels like it's lacking border_size specifications in one or more widgets; for example, the Close button feels a tad too close to the dialog border.
20110507 10:35:07< shadowmaster> Also, there could be a bit of space between the "Page" label and the slider </nitpicking>
20110507 10:35:42< CIA-82> ivanovic * r49407 /trunk/po/wesnoth/vi.po: updated Vietnamese translation
20110507 10:35:52< shadowmaster> and a colon </morenitpicking>
20110507 10:42:19< Crab_> ok
20110507 10:43:50< Ivanovic> shadowmaster: colon is problematic since it would basically mean a stringchange...
20110507 10:43:53< Ivanovic> ;)
20110507 10:50:00-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20110507 10:50:28< shadowmaster> Ivanovic: the person in charge of i18n should also learn about good UI strings practice, then!
20110507 10:50:50< Ivanovic> huh?
20110507 10:51:03< shadowmaster> you could have noticed the missing colon :p
20110507 10:51:05< Ivanovic> what does i18n itself to do with the gui strings?
20110507 10:51:11< Ivanovic> and no, i don't review the new strings!
20110507 10:51:13< shadowmaster> a lot, since those are to be internationalized
20110507 10:51:31< shadowmaster> and hopefully localized
20110507 10:51:50< Ivanovic> yeah, like i said, i don't review the new strings
20110507 10:52:04< Ivanovic> i just assume that the coder does the gui string "right" (for english!)
20110507 11:11:15-!- stikonas [~gentoo@bcm-131-111-216-209.girton.cam.ac.uk] has joined #wesnoth-dev
20110507 11:11:15-!- stikonas [~gentoo@bcm-131-111-216-209.girton.cam.ac.uk] has quit [Changing host]
20110507 11:11:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110507 11:13:51-!- Appleman1234 [~Appleman1@119.225.96.245] has quit [Ping timeout: 240 seconds]
20110507 11:20:01-!- Crendgrim [~crend@77-22-173-219-dynip.superkabel.de] has joined #wesnoth-dev
20110507 11:20:44-!- Unnheulu [~ieuan@host109-154-174-143.range109-154.btcentralplus.com] has joined #wesnoth-dev
20110507 11:20:58-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110507 11:24:33-!- negusnyul [~negusnyul@dsl5402136A.pool.t-online.hu] has quit [Ping timeout: 252 seconds]
20110507 11:27:39-!- Unnheulu [~ieuan@host109-154-174-143.range109-154.btcentralplus.com] has quit [Ping timeout: 240 seconds]
20110507 11:44:30-!- Crend [~crend@77-22-173-219-dynip.superkabel.de] has joined #wesnoth-dev
20110507 11:44:31-!- Crendgrim [~crend@77-22-173-219-dynip.superkabel.de] has quit [Read error: Connection reset by peer]
20110507 12:05:26< CIA-82> ivanovic * r49408 /branches/1.8/ (15 files in 5 dirs): 
20110507 12:05:27< CIA-82> temporarily revert r49351 by mordante: "Fixed gcc 4.6 compiler warnings."
20110507 12:05:27< CIA-82> this commit caused 1.8 to not allow playing *at all* and thus testing is impossible, sample error from starting Two Brothers:
20110507 12:05:27< CIA-82> 20110507 12:04:43 error general: Error while playing the game: game_error: unknown unit type: Knight
20110507 12:05:27< CIA-82> please fix the issues and recommit a working version
20110507 12:05:50< Ivanovic> okay, this way we can at least do some testing until mordante manages to work on fixing the problems
20110507 12:11:41-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20110507 12:14:13< Ivanovic> Crab_: what are your plans for porting the new chatlog dialog to trunk?
20110507 12:16:17-!- loonybot [~loonybot@ppp109-252-64-191.pppoe.spdop.ru] has joined #wesnoth-dev
20110507 12:16:17-!- loonybot [~loonybot@ppp109-252-64-191.pppoe.spdop.ru] has quit [Changing host]
20110507 12:16:17-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110507 12:16:53-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110507 12:26:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110507 12:38:22-!- negusnyul [~negusnyul@dsl5402136A.pool.t-online.hu] has joined #wesnoth-dev
20110507 12:47:36-!- Filar [~kamil@dab184.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20110507 12:50:16-!- atomicbomb [7da7c492@gateway/web/freenode/ip.125.167.196.146] has joined #wesnoth-dev
20110507 12:53:29< Ivanovic> Crab_, deekay: http://forums.wesnoth.org/viewtopic.php?f=4&t=33772
20110507 13:01:11-!- monochromatic [~monochrom@pool-173-59-78-136.phlapa.east.verizon.net] has quit [Ping timeout: 240 seconds]
20110507 13:02:58-!- monochromatic [~monochrom@pool-173-59-65-32.phlapa.east.verizon.net] has joined #wesnoth-dev
20110507 13:03:01-!- Gambit [~quassel@wesnoth/developer/grickit] has joined #wesnoth-dev
20110507 13:18:40-!- fendrin [~fabi@88-134-60-155-dynip.superkabel.de] has joined #wesnoth-dev
20110507 13:25:28-!- Appleman1234 [~Appleman1@119.225.96.245] has joined #wesnoth-dev
20110507 13:25:40-!- eoc [~eoc@pD9561180.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 13:29:48-!- vultraz [~chatzilla@124.109.10.191] has joined #wesnoth-dev
20110507 13:33:46< deekay> Ivanovic: I see... he's right, formula.cpp:637 increases precedence of "/" 
20110507 13:34:59< deekay> Seems like it was like that from the very beginning of formula merge.. sorry but I don't have time to look at it now more.. :S
20110507 13:35:25< deekay> Looks like an easy fix, but I don't want to tweak something then disappear for 2 days
20110507 13:49:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20110507 13:51:42-!- stikonas [~and@bcm-131-111-216-209.girton.cam.ac.uk] has joined #wesnoth-dev
20110507 13:51:42-!- stikonas [~and@bcm-131-111-216-209.girton.cam.ac.uk] has quit [Changing host]
20110507 13:51:42-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110507 13:59:56< zaroth> Crab_, anonymissimus: when trying to use [objectives] tag with side=1,2 I got this:
20110507 14:00:22< zaroth> http://pastebin.com/BDpESwcY
20110507 14:00:55< zaroth> (I don't know if [objectives] was converted to use comma separated sides already, so just letting you Lua wizards know)
20110507 14:04:46< zaroth> mordante: how hard would it be to make long (multiline) labels to become center aligned instead of left aligned?
20110507 14:06:20< Ivanovic> deekay: no idea if this would be a save fix for a stable series either
20110507 14:08:20-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Remote host closed the connection]
20110507 14:08:39-!- zaroth [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev
20110507 14:11:54-!- Appleman1234 [~Appleman1@119.225.96.245] has quit [Ping timeout: 240 seconds]
20110507 14:17:06-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20110507 14:18:30-!- stikonas [~and@bcm-131-111-216-209.girton.cam.ac.uk] has joined #wesnoth-dev
20110507 14:18:30-!- stikonas [~and@bcm-131-111-216-209.girton.cam.ac.uk] has quit [Changing host]
20110507 14:18:30-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110507 14:27:25-!- FAAB [~huajie@219.142.225.11] has joined #wesnoth-dev
20110507 14:49:01-!- FAAB [~huajie@219.142.225.11] has quit [Quit: Leaving.]
20110507 15:25:01-!- mjs-de [~mjs-de@g224188151.adsl.alicedsl.de] has joined #wesnoth-dev
20110507 15:28:16-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110507 15:29:35-!- atomicbomb [7da7c492@gateway/web/freenode/ip.125.167.196.146] has quit [Quit: Uh-oh]
20110507 15:37:26-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110507 15:54:36< Soliton> looks like the fishy change in mordante's commit is the part in unit_types.cpp.
20110507 15:54:47-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20110507 15:55:25-!- deekay [~dk@wesnoth/developer/dragonking] has quit [Quit: deekay]
20110507 15:55:33 * Soliton will check that and re-commit if confirmed.
20110507 15:59:28-!- Filar [~kamil@dab184.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20110507 16:13:50-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 276 seconds]
20110507 16:19:52< CIA-82> ivanovic * r49409 /branches/1.8/ (changelog players_changelog po/wesnoth-lib/de.po): updated German translation
20110507 16:33:52-!- fendrin [~fabi@88-134-60-155-dynip.superkabel.de] has quit [Remote host closed the connection]
20110507 16:36:04< CIA-82> wintermute * r49410 /trunk/RELEASE_NOTES: updated Khalifate release announcement to include link to forum feedback thread.
20110507 16:38:53-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110507 16:40:38< anonymissimus> @all The side=1 as default - what to do with it ? issue currently blocks 1.9.6; at least the fact that wmllint support hasnt been added; but I also strongly disagree with Crab's patch on that
20110507 16:47:38< Soliton> what's the issue?
20110507 16:53:55< anonymissimus> there are some frequently used tags which output deprecation when used without a side= setting; and wml doesnt reflect that since wmllint isnt updated
20110507 16:54:18< Crab_> anonymissimus: and why it's a blocker ?
20110507 16:54:38< Crab_> as the behavior isn't changed so far
20110507 16:55:49< anonymissimus> hm ok; but I also dislike the introduction of the "all" value, since leaving the filter empty will mean "all" anyway
20110507 16:56:28< grzywacz> ow
20110507 16:56:30< Crab_> we can remove 'all', it's not a big deal for me.
20110507 17:00:43-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110507 17:01:37< Gambit> anonymissimus: WMLLINT not supporting that is hardly a blocker.
20110507 17:01:54< Gambit> All of mainline content works, and there are much worse breakages that wmlint knows absolutely nothing about.
20110507 17:02:11< Gambit> (i.e. all of the terrain macros)
20110507 17:03:05< Gambit> " but I also strongly disagree with Crab's patch on that"
20110507 17:03:11< Gambit> How's it behave now?
20110507 17:12:05< CIA-82> soliton * r49411 /branches/1.8/ (15 files in 5 dirs): Recommit "Fixed gcc 4.6 compiler warnings." sans the unit type breakage
20110507 17:13:19< Soliton> Ivanovic, mordante: ^ should be all good now.
20110507 17:13:57< Crab_> Gambit: solution #5 from the ML
20110507 17:15:07< Crab_> Gambit: that is, implicit side=1 default is deprecated but works, support for filter_side is added, and side= can take a comma-separated list and a 'all' keyword.
20110507 17:15:45< Crab_> Gambit: take a look at http://wiki.wesnoth.org/StandardSideFilter
20110507 17:16:32< Crab_> (and, afair it's not fully enabled for lua-based tags)
20110507 17:16:34-!- Blueblaze [~Blueblaze@adsl-99-185-10-185.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110507 17:16:43< Crab_> but that one should be fast to add
20110507 17:18:35< Soliton> it's certainly not a blocker or an issue at all if some WML change in a dev version causes deprecation warnings.
20110507 17:34:57-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20110507 17:36:00< anonymissimus> Crab_: it is neither enabled at all nor is ti fast to add
20110507 17:36:20< anonymissimus> a patch on this should have taken care for lua tags from the beginning
20110507 17:36:37-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Quit: ZNC - http://znc.sourceforge.net]
20110507 17:36:53< anonymissimus> now there's the situation that allow_recruit is bit different from set_recruit and disallow_recruit
20110507 17:36:59< Crab_> anonymissimus: why it's not fast to add ? it's quite easy to patch the lua tags to get the proper side from the c++ callback for the cfg
20110507 17:37:57-!- vultraz [~chatzilla@124.109.10.191] has quit [Quit: bye all see ya later :)]
20110507 17:38:20< anonymissimus> how much do you know of the lua interface ? I plan to expose the get_sides_set function, returning a proxy table for matching sides
20110507 17:43:58< Crab_> yes, that's one of the ways to do it. performance wise, not the fastest way, but it'll work.
20110507 17:45:19-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110507 17:45:19-!- Upth is now known as Upthorn
20110507 17:46:59< Crab_> another solution would be to reimplement it in lua, using match_side when appropriate
20110507 17:48:37< Crab_> that way, no c++ code would need to be touched
20110507 17:48:50< Crab_> ( since so far, side_filter::get_teams does no better than iterate over the teams anyway, there's little need to expose side_filter::get_teams )
20110507 17:49:30-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110507 17:55:21-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20110507 17:59:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110507 18:00:22< anonymissimus> i had a lua iterator function in an analog way to get_sides_set done but decided not to commit since I didnt want to introduce redundancies
20110507 18:02:01< anonymissimus> wesnoth scenarios dont have many sides; i guess it doesntz matter to iterate a few times more
20110507 18:02:03< Crab_> anonymissimus: note that the get_sides_set callback can be coded to accept not a cfg but 'string for side=, bool for presense of [filter_side] and cfg for filter_side' - to avoid having to dump the entire cfg into c++
20110507 18:02:39< Crab_> but, the simplest solution will work, too
20110507 18:03:31< anonymissimus> a wesnoth.get_sides shouldl have a ssf cfg as first argument, without a [filter_side] tag, to be analog to get_units
20110507 18:04:08< Crab_> well, were need a get_sides_set here, not get_sides
20110507 18:04:20< Crab_> and they accept different arguments
20110507 18:04:36< anonymissimus> thats not analog to the other lua functions
20110507 18:04:53< Crab_> yes
20110507 18:04:57< shadowmaster> Soliton: I assume the compiler warnings in question were something about unused code modifying variables with no side effects?
20110507 18:04:59< Crab_> how do you want to make it ?
20110507 18:05:01< anonymissimus> get_units returns a proxy table; get_sides should do that too
20110507 18:05:20-!- mjs-de [~mjs-de@g224188151.adsl.alicedsl.de] has quit [Remote host closed the connection]
20110507 18:05:49< Crab_> anonymissimus: ok for me
20110507 18:05:58< shadowmaster> or "no side effects as far as the dumb compiler can see"?
20110507 18:08:46< anonymissimus> Crab_: but pls remove that "all" value; we dont have all anywhere in wml yet
20110507 18:08:52< anonymissimus> "all"
20110507 18:09:00< Crab_> ok
20110507 18:10:38-!- Elvish_Pillager [~eli@dhip-164.foss.residences.colby.edu] has joined #wesnoth-dev
20110507 18:28:18-!- mjs-de [~mjs-de@g224188151.adsl.alicedsl.de] has joined #wesnoth-dev
20110507 18:44:34-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Remote host closed the connection]
20110507 18:55:17-!- jiero [~jie@115-64-43-246.static.tpgi.com.au] has quit [Quit: Leaving.]
20110507 18:59:24-!- noy [~Noy@S0106001b63b6db79.vw.shawcable.net] has joined #wesnoth-dev
20110507 18:59:28-!- noy [~Noy@S0106001b63b6db79.vw.shawcable.net] has quit [Changing host]
20110507 18:59:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110507 19:03:22-!- fendrin [~fabi@88-134-17-170-dynip.superkabel.de] has joined #wesnoth-dev
20110507 19:03:56-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has quit [Ping timeout: 240 seconds]
20110507 19:05:18< fendrin> hi
20110507 19:05:38< Crab_> hi, fendrin
20110507 19:06:01< fendrin> wesbot: seen timotei?
20110507 19:06:01< wesbot> fendrin: The person with the nick timotei last spoke 4d 19h ago.  4d 19h ago they left with the message: Quit: SIGKILL
20110507 19:06:07< fendrin> wesbot: seen timotei21?
20110507 19:06:07< wesbot> fendrin: Person, who 4d 22h ago used nick timotei21, last spoke 4d 19h ago.  4d 19h ago as timotei they left with the message: Quit: SIGKILL
20110507 19:09:59-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110507 19:11:30-!- ancestral [~ancestral@198.228.224.183] has joined #wesnoth-dev
20110507 19:14:27-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110507 19:15:40-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110507 19:17:39-!- ancestral [~ancestral@198.228.224.183] has quit [Quit: Smell ya later!]
20110507 19:20:47-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has joined #wesnoth-dev
20110507 19:21:19-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has quit [Client Quit]
20110507 19:21:57-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has joined #wesnoth-dev
20110507 19:22:21-!- dipseydoodle [~mwkich@70.15.235.113.res-cmts.ovr.ptd.net] has left #wesnoth-dev []
20110507 19:24:56-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110507 19:29:57-!- anonymissimus [~chatzilla@HSI-KBW-095-208-006-134.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110507 19:32:52-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20110507 19:42:27-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110507 19:48:39-!- Blueblaze2 [~Blueblaze@adsl-99-185-11-169.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110507 19:48:55-!- Blueblaze [~Blueblaze@adsl-99-185-10-185.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 260 seconds]
20110507 19:48:56-!- Blueblaze2 is now known as Blueblaze
20110507 19:50:08-!- eoc [~eoc@pD9561180.dip0.t-ipconnect.de] has quit [Quit: They are in love. Fuck the war.]
20110507 19:53:38-!- eoc [~eoc@pD9561180.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 19:54:15< Soliton> shadowmaster: 4.6 introduced a "variable set but not used warning".
20110507 19:55:21< Soliton> so in this case just a claim that the return value is not used.
20110507 19:56:36-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110507 19:57:00-!- Blueblaze [~Blueblaze@adsl-99-185-11-169.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110507 19:58:32-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110507 19:59:54-!- mjs-de [~mjs-de@g224188151.adsl.alicedsl.de] has quit [Remote host closed the connection]
20110507 20:02:23-!- Blueblaze [~Blueblaze@adsl-99-185-11-169.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110507 20:18:57-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110507 20:22:28-!- Blueblaze2 [~Blueblaze@adsl-99-4-146-10.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110507 20:25:41-!- Blueblaze [~Blueblaze@adsl-99-185-11-169.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20110507 20:25:41-!- Blueblaze2 is now known as Blueblaze
20110507 20:29:05-!- eoc- [bouncer@syngo.info] has left #wesnoth-dev ["Where's those banana cream pies, eh?"]
20110507 20:30:35-!- Blueblaze [~Blueblaze@adsl-99-4-146-10.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110507 20:33:42-!- eoc` [~eoc@pD956113E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 20:34:59-!- eoc [~eoc@pD9561180.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20110507 20:38:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110507 20:52:33< Crab_> wow, the tRoW dragon looks way hotter since the last time I've seen it :) red, big & scary.
20110507 20:54:51< un214> wow AI improved well since 1.8
20110507 21:00:16-!- akzfowl [~akzfowl@1.186.7.45] has quit [Ping timeout: 264 seconds]
20110507 21:03:28< anonymissimus> something I'm not sure about: what's the concrete difference between config and vconfig, and when should each one be used ? is config analog to a lua wml table, and vconfig to a lua wml table-userdata ?
20110507 21:03:50< Crab_> vconfig is a proxy for config which expands variables on demand
20110507 21:04:11< anonymissimus> so is the dfifference whether variable substitution is made upon accessing the fields ?
20110507 21:04:32< Crab_> yes. 'whether' and 'when'
20110507 21:04:44< Crab_> you can get a config out of vconfig by expanding all vars
20110507 21:05:02< Crab_> or you can get the 'raw' config out of vconfig with no vars expanded
20110507 21:06:09-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has quit [Quit: eleazzaar]
20110507 21:06:31< anonymissimus> so it is actually analog to the lua types; there's .literal (which is getting without substitution) and .parsed (everything substituted, including all children)
20110507 21:06:52< anonymissimus> for a voncig object/lua userdata wml table
20110507 21:07:13< Crab_> exactly. 
20110507 21:07:43< Crab_> the code in src/scripting/lua.cpp has : 
20110507 21:07:49< Crab_> if (strcmp(m, "__literal") == 0) {   luaW_pushconfig(L, v->get_config()); 
20110507 21:07:52< Crab_> if (strcmp(m, "__parsed") == 0) {   luaW_pushconfig(L, v->get_parsed_config());
20110507 21:08:08< Crab_> where v is vconfig*
20110507 21:08:23< anonymissimus> hm
20110507 21:08:48< Crab_> so your analogy is fully correct
20110507 21:09:07< anonymissimus> and do you know about the topics "memory management" or "raw methods vs non-raw methods" (for teh lua_something methods) ?
20110507 21:09:53< anonymissimus> sometimes silene uses "new" (for creating the units proxy table), sometimes not (for teh sides table)
20110507 21:09:55-!- akzfowl [~akzfowl@1.186.0.4] has joined #wesnoth-dev
20110507 21:11:32< Crab_> for lua raw vs nonraw, the difference is 'should we consult the metatable method (not raw) or not (raw)?'
20110507 21:11:54< Crab_> i.e., a table can have a special method which will be called on access to fields that are not in the table
20110507 21:11:59< Crab_> thus allows for virtual fields
20110507 21:12:09< Crab_> 'raw' access bypasses it
20110507 21:14:30< Crab_> for the 'new' in get_units,  this is a special type of 'new' operator called 'placement new', which constructs the object at a location which is explicitly given by coder.
20110507 21:15:32< Crab_> I believe that the syntax was used to store a c++ object in an area of memory managed by lua (lua_newuserdata call allocates that memory)
20110507 21:17:38< Crab_> I think that for teams, there was no need to create a lua_team class
20110507 21:18:04< Crab_> that's because we cannot manipulate teams as easily as units (i.e., we can't easily add a team, delete a team, etc)
20110507 21:18:30< Crab_> so, the list of the teams stays the same, and a team can be easily represented by a pointer or an index
20110507 21:18:47< Crab_> but, for units, we take units, store them, unstore them, put them to/from recall/ etc
20110507 21:19:00< Crab_> so, a lua_unit class was created to help lua code handle that
20110507 21:19:20< Crab_> and, that called for that kind of 'placement new' syntax
20110507 21:19:42< Crab_> it's actually quite a fun way to manage stuff
20110507 21:21:50-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20110507 21:22:48-!- eleazzaar [~jbjerk@ppp-70-226-200-254.dsl.spfdil.ameritech.net] has joined #wesnoth-dev
20110507 21:29:07< anonymissimus> and when and from where is the memory destroyed then ?
20110507 21:29:34< anonymissimus> when I call get_units and a unit is returned, that new allocates some memory
20110507 21:29:41< Crab_> no, it does not
20110507 21:29:55< Crab_> it uses the memory block prepared by lua_newuserdata call
20110507 21:30:12< Crab_> it is managed by lua's garbage collector
20110507 21:31:25< anonymissimus> "When Lua collects a full userdata with a gc metamethod, Lua calls the metamethod and marks the userdata as finalized. When this userdata is collected again then Lua frees its corresponding memory. "
20110507 21:32:03< Crab_> and the c++ code can use placement delete or explicit destructor calls to cleanup things (i.e. when replacing one unit with another)
20110507 21:32:59< anonymissimus> I dont understand why there seem to be two speps in teh garbage collection
20110507 21:33:08-!- ancestral [~ancestral@209.181.233.7] has joined #wesnoth-dev
20110507 21:33:33< Crab_> because even through the memory is managed by lua, it does not know what it manages. it's userdata, "user data"
20110507 21:34:00< Crab_> so, it has to notify the user that some block of data can go away, to let his code to any cleanups desired
20110507 21:34:27< Crab_> but, the actual memory is to be reclaimed by lua routines
20110507 21:34:37< Crab_> since the memory was given by lua in the first place, not by user.
20110507 21:41:14< anonymissimus> aha, so first lua notifies the user (which is the lua api C++ coder here) that some memory cna be freed; then the lua api coder does cleanups needed (the destructor of the lua_unit class), and then lua can finally delete it
20110507 21:41:56< Crab_> exactly
20110507 21:42:02< anonymissimus> :)
20110507 21:42:14< Crab_> the metamethod in question is called __gc
20110507 21:42:31< Crab_> take a look at impl_unit_collect in src/scripting/lua.cpp
20110507 21:42:44-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds]
20110507 21:43:48< Crab_> here's the code snippets -http://pastebin.mozilla.org/1220557
20110507 21:44:48-!- Sytyi [~chatzilla@166-190-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110507 21:45:09< anonymissimus> you dont need to copypaste ;)
20110507 21:45:14< Crab_> ok )
20110507 21:47:16-!- Filar [~kamil@dab184.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20110507 21:51:25< anonymissimus> amazing that the true C++ units in the unit map get deleted when the lua garbage collector decides - when are they deleted if I had not called get_units instead ?
20110507 21:52:59< Crab_> no, true C++ units in the unit map are not deleted in that way
20110507 21:53:16< anonymissimus> but there's delete ptr in the destructor
20110507 21:53:27< Crab_> yes, but note that the units in the unit map are represented by lua_unit via their underlying_id, not via the ptr
20110507 21:53:40< Crab_> so, for those units, it's just 'delete NULL', which is 
20110507 21:54:06< Crab_> there are units which are 'owned' by lua code, they are not in the unit map
20110507 21:54:11< Crab_> and for them , that ptr is used
20110507 21:54:14-!- Sytyi [~chatzilla@166-190-133-95.pool.ukrtel.net] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 4.0.1/20110413222027]]
20110507 21:54:19< Crab_> and then the delete actually deletes them. 
20110507 21:54:37< Crab_> note the comment at src/scripting/lua_api.hpp
20110507 21:54:43< anonymissimus> ptr seems to be a copy
20110507 21:54:45< Crab_> at the header of lua_unit class
20110507 21:58:15-!- SpoOkyMagician [~chatzilla@74-138-202-211.dhcp.insightbb.com] has joined #wesnoth-dev
20110507 22:03:53-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds]
20110507 22:05:37-!- shadowm_laptop is now known as evilshadowmaster
20110507 22:06:38-!- ancestral [~ancestral@209.181.233.7] has quit [Quit: i go sleeps kthxbai]
20110507 22:11:02< anonymissimus> anything heard of Aetheryn btw ? he had a project realted to the lua interface
20110507 22:11:23< Crab_> he's got an unfinished patch wrt that
20110507 22:11:43< anonymissimus> wesbot: seen Aetheryn
20110507 22:11:44< wesbot> anonymissimus: Sorry, I don't know of Aetheryn.
20110507 22:11:46< Crab_> we've discussed the idea with him, and sooner or later it'll be implemented, it's not that hard to do once we figured out what to do
20110507 22:11:59< Crab_> Aethaeryn: ^
20110507 22:12:14< shadowmaster> wesbot: seen Aethaeryn 
20110507 22:12:15< wesbot> shadowmaster: Queried user last spoke 6d 15h ago.  Aethaeryn is currently (also as Aeth) here and on the channels #wesnoth and #wesnoth-umc-dev.
20110507 22:13:38-!- Johannes13 [~Johannes@p5DF73AC0.dip.t-dialin.net] has joined #wesnoth-dev
20110507 22:13:38-!- Johannes13 [~Johannes@p5DF73AC0.dip.t-dialin.net] has quit [Changing host]
20110507 22:13:38-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110507 22:18:12-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20110507 22:20:06-!- dtiger [~dtiger@dynamic-vpdn-93-125-15-40.telecom.by] has quit [Remote host closed the connection]
20110507 22:31:03-!- PolarPanda is now known as evilmynickwontfi
20110507 22:31:23-!- evilmynickwontfi is now known as MyNickWontFit
20110507 22:36:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110507 22:39:55-!- eoc [~eoc@pD9561034.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 22:41:16-!- eoc` [~eoc@pD956113E.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20110507 22:43:31-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110507 22:47:49-!- SpoOkyMagician [~chatzilla@74-138-202-211.dhcp.insightbb.com] has quit [Quit: brb in a few]
20110507 22:53:11< Aethaeryn> Crab_: I have a week and a half left in the semester. Since I didn't get GSOC, I'm not sacrificing the potential for straight As to get in a patch now that is just as acceptable a week and a half from now.
20110507 22:53:40< Crab_> yes, that's perfectly ok
20110507 22:58:37-!- negusnyul [~negusnyul@dsl5402136A.pool.t-online.hu] has quit [Remote host closed the connection]
20110507 23:04:05-!- Filar [~kamil@dab184.neoplus.adsl.tpnet.pl] has quit [Quit: Ex-Chat]
20110507 23:08:33< esr> Are happygrue_ or noy here?
20110507 23:08:48< noy> I am
20110507 23:09:33< esr> What's up with the halifa "napalm" attack?  What's the actual weapon and damage effect?
20110507 23:09:53< noy> napalm and fire
20110507 23:09:59< noy> naptha 
20110507 23:10:22< esr> Yes, but Espreon is asking me to rename it because "napalm" is a modern coinage.
20110507 23:10:29< esr> Ahh..
20110507 23:10:54< esr> Shall we just make it "naptha", then, or perhaps "firecaster"?
20110507 23:10:59< noy> naptha is fine
20110507 23:11:02< noy> actually...
20110507 23:11:18< noy> well the arabic word is naft... 
20110507 23:11:29< noy> so naptha sounds fin
20110507 23:11:31< noy> fine
20110507 23:11:39< esr> OK.  Will do.
20110507 23:11:50< noy> any other words?
20110507 23:12:59< esr> That's it for the moment.  Er, you know the problem with the name "Khalifa", Right? Are we just ignoring that?
20110507 23:13:37< noy> it is going back to Khalifate
20110507 23:13:51< noy> someone changed it back... I'm not sure why
20110507 23:14:04< noy> I mean it was at one point Kalifa
20110507 23:14:17< noy> we changed it to Khalifate, then in a mixup someone put it back to Kalifa
20110507 23:14:36< esr> OK, as long as I know that's being handled.
20110507 23:15:22< Soliton> it is Khalifate right now.
20110507 23:15:57< noy> Soliton: yeah I had a different answer last week. 
20110507 23:16:10< noy> esr: you're the reason why we originally changed it
20110507 23:16:15< noy> what was the issue again?
20110507 23:16:20< noy> that it just meant life?
20110507 23:17:04< esr> Khalifa is in fact the Arabic personal title we translate as "Caliph".
20110507 23:17:25< noy> yes
20110507 23:17:33< noy> I mean the original issue with kalifa
20110507 23:17:37< noy> err
20110507 23:17:47< noy> Kalifa means life in Arabic
20110507 23:18:22< esr> Hm.  So the Initial guttural is phonemic.  I didn't know that.
20110507 23:19:03< noy> I've got different transliterations going here so I wouldn't use it as a guide
20110507 23:19:14< esr> That must make for some interesting puns and semantic associations.
20110507 23:19:29< esr> So the Caliph is the life of his people.
20110507 23:19:50-!- SpoOkyMagician [~chatzilla@74-138-202-211.dhcp.insightbb.com] has joined #wesnoth-dev
20110507 23:20:24< esr> http://en.wikipedia.org/wiki/Caliph
20110507 23:21:30< noy> I maybe wrong about that... Its been awhile since I had to speak it.
20110507 23:22:43< esr> Arabic: خليفة‎ / ḫalīfa / khalīfa = Caliph.
20110507 23:23:32< noy> well, its academic... we already changed it
20110507 23:25:36< noy> anything else?
20110507 23:25:42< noy> I'm running low on battery here
20110507 23:27:20< noy> ... okay, I'll be back on in a couple of hours. 
20110507 23:31:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 248 seconds]
20110507 23:32:06< anonymissimus> Crab_: you know it would be better if the whole get_sides_set was an iterator function like can be done in lua ? I cant write that for C++ however
20110507 23:32:14-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20110507 23:33:29< Crab_> yes, I guess that an iterator would be slightly better. you can always do it via a lua wrapper. but it can be done in c++, too (just harder)
20110507 23:34:32-!- eoc [~eoc@pD9561034.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20110507 23:34:32-!- eoc` [~eoc@pD9560003.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 23:38:09-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20110507 23:40:27-!- Crend [~crend@77-22-173-219-dynip.superkabel.de] has quit [Remote host closed the connection]
20110507 23:43:49< CIA-82> esr * r49412 /trunk/data/ (6 files in 4 dirs): Replacement of modern names and terminology.
20110507 23:45:18< Ivanovic> esr: saw my ping one or two days ago?
20110507 23:45:32< Ivanovic> esr: about the message from wmllint and the special parts?
20110507 23:45:41< Ivanovic> (special note stuff)
20110507 23:45:54< esr> Ivanovic: Yes, I think I asked for an FR.  Is there one?
20110507 23:46:03< Ivanovic> no, different one
20110507 23:46:08< Ivanovic> you have not reacted on this one
20110507 23:46:19< esr> Oh, OK.  What?
20110507 23:46:24< Ivanovic> it is about the heal +8 "special note" which should just be the one of heal +4
20110507 23:46:46< Ivanovic> *but* many units got the "cure" entry, which means "remove poison *and* heal +8"
20110507 23:47:18< Ivanovic> basically a way to allow "if there is heal_extra but not remove poison, make sure the special note heal is okay/accepted
20110507 23:47:28< esr> Yes, that's been a problem waiting to blow up for years.  I can fix it, but the fix has to break some UMC.
20110507 23:48:18< esr> File an FR with details of the symptoms you're seeing.  I'll probably get to it tomorrow.
20110507 23:48:21< Ivanovic> currently i manually added the special note
20110507 23:48:29< Ivanovic> and get a warning about "you are missing the ability!"
20110507 23:50:31< esr> Right.
20110507 23:51:21< esr> As I said, there's a systematic fix.  It involves changing some macros to work the way they should have been coded in the first place.
20110507 23:56:57< Ivanovic> esr: but i now created an FR for the "add plural forms" script thingie
20110507 23:57:07< Ivanovic> no idea where/how to best add it
20110507 23:57:17< Ivanovic> could eg be in pofix.py or something like this
20110507 23:57:55< Ivanovic> you want a report/fr for the "change behaviour with heals_extra in wmllint"?
20110507 23:58:10< Ivanovic> or is it mainly a thing of "lets just ignore it for the moment..."
20110507 23:58:20-!- eoc [~eoc@pD956132C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20110507 23:58:54-!- eoc` [~eoc@pD9560003.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
--- Log closed Sun May 08 00:00:05 2011