--- Log opened Thu Jun 30 00:00:52 2011
20110630 00:00:52< Crab_> note that current system is very dump - i.e., cancellation of map selection in local game throws back to main menu
20110630 00:01:02< Crab_> *dumb
20110630 00:02:15< Crab_> zaroth: a question: can we limit the amount of information which would be kept in global status info by unfinished flow ?
20110630 00:02:36< zaroth> that's what I've been saying from the very beginning, that the current graph only supports going back to loaded_headrs
20110630 00:03:20< zaroth> well, I guess we could make another composite state
20110630 00:03:33< zaroth> in which the updated config would be hold as the context
20110630 00:03:40< Crab_> zaroth: I've got an idea, for now
20110630 00:03:50< zaroth> and upon exit from this composite state the global config would be updated with this contextual config
20110630 00:04:03< zaroth> so, grouping
20110630 00:04:04< Crab_> I think that what we need now is to get your map of states and put all the dialogs (=all the cancel buttons available to users) to them.
20110630 00:04:58-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has joined #wesnoth-dev
20110630 00:05:09< Crab_> yes, grouping should help solve some of the use cases.
20110630 00:05:26< boucman> ok, I need to go now, see you all tomorow
20110630 00:05:30< Crab_> boucman: night
20110630 00:05:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20110630 00:05:59< Crab_> zaroth: so, what do you think about just putting all the dialogs and all the cancel buttons and their destinations on that diagram (treating it as a separate layer of icons) ?
20110630 00:07:00< zaroth> I'm investigating how to do this in the tools I have
20110630 00:07:13< Crab_> zaroth: thanks
20110630 00:07:15< zaroth> unless you know something about UMLet or argoUML
20110630 00:07:35< Crab_> no, sadly
20110630 00:07:48< Crab_> meanwhile, some thoughts about the configs and states :
20110630 00:08:03< zaroth> it's my first time playing with UML as well, but YogiHH recommended it to me and it was used a lot in Boost.Statechart tutorial
20110630 00:08:27< Crab_> imagine we have a state in which we have a dialog which allows a user to select 'sp campaign' 'mp campaign' 'mp game' 'local game'
20110630 00:08:40< Crab_> sometimes we'll have to autoskip this dialog, using preselected value
20110630 00:09:02< Crab_> the next dialog is in different state, with some other settings, and it has a cancel button
20110630 00:09:48< Crab_> so, in our dialog, we have a config which will contain stuff like  choice='sp campaign'
20110630 00:09:57< Crab_> also, it'll contain auto=yes or auto=no
20110630 00:10:56< Crab_> when we enter this state (A), we'll have [config]auto=no[/config] or [config]auto=yes choice='sp campaign'[/config]
20110630 00:11:18< Crab_> when we leave it, we might have  [config]auto=no choice='local game' [/config] or [config]auto=yes choice='sp campaign'[/config]
20110630 00:11:56< Crab_> if, on pressing cancel, we return to [config]auto=no[/config] , we'll lose the user choice on that dialog (the value user has previously selected
20110630 00:12:15< Crab_> so, we should return to [config]auto=no choice='local game' [/config] to allow the value to be preselected, yet allowing the value to select it again
20110630 00:12:32< Crab_> if the flag auto=yes, we should return even earlier
20110630 00:13:36< Crab_> this might be handled by letting the config provide a 'cancellation config' when passing control
20110630 00:13:52< Crab_> in that config, we can include a nested section with 'even previous' cancellation config
20110630 00:14:11< Crab_> that means that we can get away with only 1 config being passed between stages
20110630 00:15:13< Crab_> so, on pressing OK, state A will pass a config with  [config]  auto=no  type='local game'   [cancel]auto=no choice='local game' [/cancel]  [/config] to state B
20110630 00:16:22< Crab_> and state B might continue it to pass it around like [config] info=z  [cancel] auto=no  type='local game' gold1=300 gold2=400 income=3   [cancel]auto=no choice='local game' [/cancel] [/cancel] [/config] 
20110630 00:17:12< grzywacz> Wouldn't it be simpler to have a config wrapper that would dynamically apply a "delta" to the underlying one? I.e. doing a lookup in itself first, then delegating to the embedded one?
20110630 00:17:56< Crab_> the configs in question are really small, being a serialization of user input
20110630 00:18:01-!- deekay [~dk@wesnoth/developer/dragonking] has quit [Quit: deekay]
20110630 00:18:12< grzywacz> ack
20110630 00:18:12< Crab_> or we might unpack this structure to [state1] auto=no type='local game' [/state1][state2] ...[/state2] [state3]....[/state3] ....
20110630 00:18:30< Crab_> if they were large, the delta-trick might prove useful, yes, you're right
20110630 00:20:04< Crab_> but, if we unpack, that'll mean that the states correspond to the 'game meta-state elements' directly, which limits our flexibility
20110630 00:21:00< Crab_> zaroth: so, for cancels, I'd go for an undo stack which would allow us to go back to the last pair <state, config> where we saved the flow
20110630 00:21:30< Crab_> zaroth: I think that's the most flexible/easy way, so far.
20110630 00:22:31< Crab_> zaroth: for start, we can keep only the <main_menu, dummy metaconfig> pair, which can be autogenerated when we cancel
20110630 00:23:22< Crab_> zaroth: thus, in the first version, all cancels would indeed return to main menu
20110630 00:23:34< Crab_> but, later, we would be able to return to any state
20110630 00:24:10< Crab_> zaroth: what do you think ?
20110630 00:25:24< Crab_> zaroth: as a side bonus, this structure allows to cheat and use undos as teleports to go directly from 1 state to another without properly passing through all the intermediate stages, although I don't recommend this.
20110630 00:26:08< Crab_> zaroth: one way to improve your state machine example is to make it more interactive
20110630 00:26:27< Crab_> zaroth: i.e., in each state, display a small list of available options
20110630 00:26:38< Crab_> zaroth: like in text-based adventure game
20110630 00:27:03< zaroth> Crab_: will do
20110630 00:27:11< Crab_> zaroth: i.e. 'you see a dark shape of wesnoth's main menu, just in front of you. you can ( 1 ) , ( 2 ), ... '
20110630 00:27:37< Crab_> this would allow us to insert text-only dialog stubs inside it until we've done with placement of all the dialogs
20110630 00:27:39< zaroth> so I will stop my efforts to putting what I have now to wesnoth trunk and keep improving the example then
20110630 00:27:46< Crab_> yes, I think it's easier this way
20110630 00:28:02< zaroth> as for the config method, I'm still pondering it
20110630 00:28:41< Crab_> as a side bonus, if you put a dialog into your state chart, you are basically documenting (in code) the interface of said dialog
20110630 00:29:24< zaroth> the nesting is certainly nice idea, and easy enough with wesnoth structure
20110630 00:29:28< Crab_> i.e. if you make a text dialog which will ask the user for a mp map, you'll be able to learn what things the map seleciton dialog will provide you, and what things it'll need to work
20110630 00:29:54< Crab_> and you'll also see what the cancel buttons are and where do they lead
20110630 00:31:00-!- Wurmish [46f6e342@gateway/web/freenode/ip.70.246.227.66] has quit [Ping timeout: 252 seconds]
20110630 00:31:34< Crab_> zaroth: I think that if we hack all the wesnoth's dialogs to conform to your structure, we'll be able to use the state machine as a drop-in replacement for current control flow without having to massively recode the dialogs themselves
20110630 00:33:32< Crab_> i.e., we would be able to use transparently use the 'new campaign' button in wesnoth's main menu to start a serverless local MP game for that campaign, after user selects the campaign and difficulty
20110630 00:34:08< Crab_> and callbacks are not really necessary atm, until the code will show we need them or some other solution...
20110630 00:37:55< CIA-85> zookeeper * r50091 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/10_Speaking_with_the_Fishes.cfg: Fixed a few erroneous speakers as reported on the forums.
20110630 00:38:58< zaroth> Crab_: do you think I should call the said "dialogs" in the states themselves?
20110630 00:39:06< Crab_> yes
20110630 00:39:26< zaroth> in the constructors it is, then
20110630 00:39:29< Crab_> yes. you have some inline atm
20110630 00:39:50< Crab_> i.e. the code which asks for campaign name - it is a dialog
20110630 00:40:03< zaroth> well, but it's outside of any state
20110630 00:40:16< zaroth> it's in the main loop
20110630 00:40:37< zaroth> and the stuff being asked gets packed into config and sent to the machine
20110630 00:40:50< zaroth> so the machine is treated like a black box here, steered with events
20110630 00:41:04< zaroth> and we're going to take approach of the machine steering itself
20110630 00:41:14< zaroth> if I understood correctly
20110630 00:43:44< zaroth> btw, upon writing the dialogs into the states I think I stumbled upon a redundant state
20110630 00:44:03< Crab_> yes, the approach of machine steering itself
20110630 00:44:07< Crab_> which one ?
20110630 00:44:11< zaroth> players_assignment_known, namely
20110630 00:44:22< zaroth> is there something we need to do when the players are already known?
20110630 00:44:35< zaroth> it could probably go directly to play_game
20110630 00:44:41< zaroth> after ev_specify_players
20110630 00:45:24< zaroth> http://i.imgur.com/U4ozz.png
20110630 00:46:03< Crab_> yes, we can drop it for now
20110630 00:46:10< Crab_> it's just a artifact of naming convention
20110630 00:46:26< Crab_> i.e. there might be a 'assign players state', but you named them differently
20110630 00:46:55-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110630 00:47:01< gabba> Hi all
20110630 00:47:03< zaroth> well, boucman said that the names can be easily changed
20110630 00:47:07< zaroth> hello aristocrat ;-)
20110630 00:47:19< gabba> zaroth :D hello
20110630 00:48:04< zaroth> and I wasn't that good of creating names anyway
20110630 00:48:24< gabba> tschmitz, how go things?
20110630 00:48:44< tschmitz> Hey gabba
20110630 00:49:01< tschmitz> not bad;
20110630 00:49:18< tschmitz> just put init() methods in all the subclasses of action
20110630 00:49:52< tschmitz> was gonna move on to crippling undo
20110630 00:50:03< gabba> tschmitz: I think that it would be the right time for a commit
20110630 00:50:37< gabba> after making sure that the OOS was really because of the scenario and not your code, and that enemies cannot see plans
20110630 00:50:38< tschmitz> gabba: No one ever told me I have commit access, so I wouldn't suppose that I do
20110630 00:51:02-!- Bob_The_Mighty [~chatzilla@cpc5-brig16-2-0-cust70.3-3.cable.virginmedia.com] has joined #wesnoth-dev
20110630 00:51:27< gabba> tschmitz: I asked Ivanovic to give it to you after your second patch, so I think you should
20110630 00:51:41< tschmitz> I guess I'll see if I can do it
20110630 00:52:29< zaroth> Crab_:  http://i.imgur.com/qbNnT.png something missing?
20110630 00:52:40< zaroth> (I decided to stick to ArgoUML for now)
20110630 00:53:04< gabba> tschmitz: if you're listed as contributor to Battle for Wesnoth here, I think you have commit rights: https://gna.org/my/groups.php
20110630 00:53:07-!- Shakey [~Shakey@12.190.80.225] has quit [Quit: Shakey]
20110630 00:53:36< Ivanovic> tschmitz: what is the name of your account at gna?
20110630 00:53:53< tschmitz> Ivanovic: I'm pretty sure it's tschmitz ...
20110630 00:54:18-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20110630 00:54:22< Ivanovic> nope, i don't see this account
20110630 00:54:28< Crab_> zaroth: looks ok for start
20110630 00:55:14< Ivanovic> "Tommy Schmitz <tschmitz>" is corect?
20110630 00:55:15< tschmitz> Gna! says passwords were recently reset?
20110630 00:55:22< Crab_> zaroth: night for me, bye
20110630 00:55:31-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110630 00:55:34< zaroth> night crimson_penguin
20110630 00:55:37< zaroth> crap
20110630 00:55:38< tschmitz> Ivanovic: Yeah that looks good
20110630 00:56:12< Ivanovic> okay, then you should be able to switch your checkout to svn+ssh://tschmitz@FOOOOOOO
20110630 00:56:42< Ivanovic> (as long as you got your public ssh key uploaded at gna and waited "long enough" after having it uploaded there)
20110630 00:59:25< gabba> tschmitz: I wanted to plan for the next few days, since I probably won't have a good chunk of time to spend with you until saturday or sunday
20110630 00:59:54< tschmitz> gabba: OK
20110630 01:00:16< tschmitz> gabba: I might have questions about committing
20110630 01:00:23< gabba> tschmitz: as I see it, priorities should be to first commit your work,
20110630 01:00:41< gabba> tschmitz: and then tackle disabling undo when whiteboard is on,
20110630 01:01:46< gabba> tschmitz: as well as displaying invalid plans as such instead of erasing them + using planned moves from allies that move before you in the validation process
20110630 01:02:12< gabba> tschmitz: you can pick whether you work on undo or validation first
20110630 01:02:24< gabba> but I expect validation to be more work
20110630 01:02:53< tschmitz> OK
20110630 01:02:54< gabba> you'll need to make mockup "invalid arrows"
20110630 01:05:37< tschmitz> gabba: Yeah ... I'll figure that out somehow
20110630 01:06:04< gabba> tschmitz: if you have questions I'll be mostly afk starting now but I'll answer eventually
20110630 01:06:17< tschmitz> gabba: Ah. OK then
20110630 01:06:39< gabba> Unless you have a burning one right then and there :)
20110630 01:06:50< tschmitz> gabba: I made my keypair on my computer at school
20110630 01:07:07< tschmitz> am I gonna be able to commit from here?
20110630 01:07:39< gabba> Good question. I know you can register multiple keys, for certain...
20110630 01:08:01< gabba> Dunno if you can transfer your private key to your current computer
20110630 01:08:24< tschmitz> gabba: Well I suppose I'll figure it out eventually
20110630 01:08:28-!- anonymissimus [~chatzilla@HSI-KBW-095-208-215-104.hsi5.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20110630 01:08:45< tschmitz> Talktoya later then, I guess
20110630 01:08:47< gabba> I'm confident you will ;)
20110630 01:08:55< gabba> 'later
20110630 01:19:50-!- mjs-de [~mjs-de@f053188070.adsl.alicedsl.de] has quit [Quit: On the road again]
20110630 01:20:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110630 01:21:03-!- Aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20110630 01:24:30-!- Aeth [~Michael@ec2-50-16-189-117.compute-1.amazonaws.com] has joined #wesnoth-dev
20110630 01:24:39-!- Aeth [~Michael@ec2-50-16-189-117.compute-1.amazonaws.com] has quit [Changing host]
20110630 01:24:39-!- Aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20110630 01:30:19-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110630 01:34:36-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110630 01:40:29< tschmitz> gabba: K I'm just making a new key; maybe I'll commit later tonight or tomorrow or something
20110630 01:41:06-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 01:41:31< AngelsJinx> wesbot: seen cjhopman
20110630 01:41:31< wesbot> AngelsJinx: Queried user last spoke 11d 15h ago.  cjhopman is currently here and on the channel #wesnoth.
20110630 01:44:45-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 255 seconds]
20110630 01:52:17-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit []
20110630 01:53:26< CIA-85> espreon * r50092 /trunk/src/gui/dialogs/ (folder_create.cpp folder_create.hpp): Ran umcpropfix.
20110630 01:56:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110630 01:58:49-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has joined #wesnoth-dev
20110630 01:59:21< CIA-85> espreon * r50093 /trunk/projectfiles/VC10/ (4 files): Set svn:eol-style.
20110630 02:00:09-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20110630 02:03:58-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has quit [Quit: Leaving.]
20110630 02:21:23-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110630 02:21:23-!- Upth is now known as Upthorn
20110630 02:27:38-!- Shakey [HydraIRC@c-24-1-105-76.hsd1.il.comcast.net] has joined #wesnoth-dev
20110630 02:36:33-!- atomicbomb [~quassel@61.94.173.9] has joined #wesnoth-dev
20110630 02:58:25-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev
20110630 03:03:11< tschmitz_> Linker error: cannot open file 'VCOMPD.lib' ?
20110630 03:16:29-!- LordNasty [~NaSTy@93-43-157-80.ip92.fastwebnet.it] has quit []
20110630 03:21:11-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 240 seconds]
20110630 03:23:50-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has quit [Quit: Leaving.]
20110630 03:23:55-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has joined #wesnoth-dev
20110630 03:28:23-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has quit [Ping timeout: 258 seconds]
20110630 03:34:21-!- AngelsJinx [~AngelsJin@119.224.78.213] has left #wesnoth-dev []
20110630 03:41:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110630 03:47:55-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20110630 04:06:00-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has joined #wesnoth-dev
20110630 04:13:34-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Ping timeout: 252 seconds]
20110630 04:14:00-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev
20110630 04:15:26< gabba> 'night all
20110630 04:15:38-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110630 04:34:28-!- Ivanovic_ [~ivanovic@dtmd-4db2d4cf.pool.mediaWays.net] has joined #wesnoth-dev
20110630 04:38:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 276 seconds]
20110630 04:38:24-!- Ivanovic_ is now known as Ivanovic
20110630 04:51:42-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Ping timeout: 252 seconds]
20110630 04:56:13-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: kernel upgrade in progress]
20110630 04:57:53-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110630 05:03:49-!- enchilado [~enchilado@ppp118-208-35-190.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110630 05:07:13-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20110630 05:24:37-!- Crab_ [~Crab_@62.80.190.34] has joined #wesnoth-dev
20110630 05:24:37-!- Crab_ [~Crab_@62.80.190.34] has quit [Changing host]
20110630 05:24:37-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110630 05:29:58-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 05:30:24< AngelsJinx> wesbot: seen cjhopman
20110630 05:30:24< wesbot> AngelsJinx: Queried user last spoke 11d 18h ago.  cjhopman is currently here and on the channel #wesnoth.
20110630 05:31:06< shadowmaster> AngelsJinx: you might as well try to speak to him.
20110630 05:31:33< AngelsJinx> Did do so this morning, was hoping he'd dropped by here in the mean time
20110630 05:50:57-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20110630 05:55:16-!- Shakey [HydraIRC@c-24-1-105-76.hsd1.il.comcast.net] has quit [Quit:  HydraIRC -> http://www.hydrairc.com <- Now with extra fish!]
20110630 05:55:52-!- Bob_The_Mighty [~chatzilla@cpc5-brig16-2-0-cust70.3-3.cable.virginmedia.com] has quit [Quit: ChatZilla 0.9.87 [Firefox 5.0/20110615151330]]
20110630 06:03:44-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Read error: Connection reset by peer]
20110630 06:08:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110630 06:13:38-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Quit: GOMU GOMU NO QUIT]
20110630 06:41:38-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110630 07:02:52-!- AngelsJinx [~AngelsJin@119.224.78.213] has left #wesnoth-dev []
20110630 07:04:21-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has quit [Quit: Leaving.]
20110630 07:09:44-!- Gallaecio [~quassel@92.39.broadband12.iol.cz] has joined #wesnoth-dev
20110630 07:12:06-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20110630 07:25:58-!- vultraz [~chatzilla@124.109.10.222] has joined #wesnoth-dev
20110630 07:26:03-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 250 seconds]
20110630 07:48:16-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 07:59:38-!- beetlenaut [~dan@174.32.63.204] has joined #wesnoth-dev
20110630 08:05:43-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110630 08:05:46-!- enchilad1 [~enchilado@ppp118-208-4-41.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110630 08:08:09-!- enchilado [~enchilado@ppp118-208-35-190.lns20.bne1.internode.on.net] has quit [Ping timeout: 244 seconds]
20110630 08:08:13-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has joined #wesnoth-dev
20110630 08:08:33-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Quit: Page closed]
20110630 08:15:15-!- enchilad1 is now known as enchilado
20110630 08:26:29-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110630 08:43:35-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has joined #wesnoth-dev
20110630 08:47:06-!- Grimling [~FKint@91.181.6.117] has joined #wesnoth-dev
20110630 08:54:31-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 240 seconds]
20110630 08:55:27-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110630 09:06:18-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has joined #wesnoth-dev
20110630 09:06:18-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has quit [Changing host]
20110630 09:06:18-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 09:39:48-!- Ivanovic [~ivanovic@dtmd-4db2d4cf.pool.mediaWays.net] has quit [Changing host]
20110630 09:39:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110630 09:39:58-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110630 09:41:07< Ivanovic> moin
20110630 10:00:19-!- alkenrinnstet [~alkenrinn@nusnet-28-9.dynip.nus.edu.sg] has quit [Quit: Leaving.]
20110630 10:10:00-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has quit []
20110630 10:11:30-!- enchilado [~enchilado@ppp118-208-4-41.lns20.bne1.internode.on.net] has quit [Ping timeout: 260 seconds]
20110630 10:11:53-!- loonybot [~loonybot@46.138.86.250] has joined #wesnoth-dev
20110630 10:11:53-!- loonybot [~loonybot@46.138.86.250] has quit [Changing host]
20110630 10:11:53-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110630 10:15:04-!- Gallaecio [~quassel@92.39.broadband12.iol.cz] has quit [Remote host closed the connection]
20110630 10:18:19-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110630 10:19:28-!- enchilado [~enchilado@ppp118-208-169-119.lns20.bne4.internode.on.net] has joined #wesnoth-dev
20110630 10:36:15-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has joined #wesnoth-dev
20110630 10:44:07-!- enchilado [~enchilado@ppp118-208-169-119.lns20.bne4.internode.on.net] has quit [Ping timeout: 240 seconds]
20110630 11:19:55-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev
20110630 11:25:31-!- Crab_ [~Crab@wesnoth/developer/crab] has joined #wesnoth-dev
20110630 11:40:03-!- Ivanovic_ [~ivanovic@dtmd-d9bffe31.pool.mediaWays.net] has joined #wesnoth-dev
20110630 11:40:03-!- Ivanovic_ [~ivanovic@dtmd-d9bffe31.pool.mediaWays.net] has quit [Changing host]
20110630 11:40:03-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110630 11:41:36-!- LordNasty [~NaSTy@93-43-157-80.ip92.fastwebnet.it] has joined #wesnoth-dev
20110630 11:42:05-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20110630 11:43:50-!- enchilado [~enchilado@ppp118-208-177-87.lns20.bne4.internode.on.net] has joined #wesnoth-dev
20110630 11:43:59-!- Ivanovic_ is now known as Ivanovic
20110630 11:51:23-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20110630 11:55:57-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110630 12:03:43-!- atomicbomb [~quassel@61.94.173.9] has quit [Quit: tired]
20110630 12:14:19-!- Gallaecio [~quassel@92.39.broadband12.iol.cz] has joined #wesnoth-dev
20110630 12:26:28-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20110630 12:30:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110630 12:31:56-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has joined #wesnoth-dev
20110630 12:34:44-!- atomicbomb [~quassel@125.160.83.186] has joined #wesnoth-dev
20110630 12:35:52-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has joined #wesnoth-dev
20110630 12:37:55-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Ping timeout: 260 seconds]
20110630 12:38:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20110630 13:04:05-!- enchilado [~enchilado@ppp118-208-177-87.lns20.bne4.internode.on.net] has quit [Read error: Connection reset by peer]
20110630 13:05:41-!- enchilado [~enchilado@ppp118-208-177-87.lns20.bne4.internode.on.net] has joined #wesnoth-dev
20110630 13:25:41-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has quit [Read error: Connection reset by peer]
20110630 13:26:09-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has joined #wesnoth-dev
20110630 13:28:31< Nephro> Hi, Crab_ 
20110630 13:28:40-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 260 seconds]
20110630 13:29:11< Crab_> hi
20110630 13:29:33-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110630 13:29:43< Nephro> I've encountered a very weird problem: I created a table called conf, set it's fields and tried to iterate through it using the generic for outputting key-value pairs. The only pair I got was __varname=>conf
20110630 13:30:31< Nephro> The guys at #lua don't know what could cause such behaviour, although if I check the fields one by one, or using a different interpreter the code seems to work fine
20110630 13:30:53< Crab_> can you pastebin the code ?
20110630 13:31:38< Nephro> http://codepad.org/vi72udJF
20110630 13:32:01< Nephro> this code produces "__varname=>conf" when run on wesnoth
20110630 13:32:51-!- hhyloc [~hhyloc@113.166.151.80] has joined #wesnoth-dev
20110630 13:32:58< Nephro> <RenaKunisaki> Nephro, indeed, maybe you're using some weird hacked interpreter... the output should match what the paste shows @ #lua
20110630 13:33:15-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20110630 13:36:38< elias> what should it produce?
20110630 13:37:15< Nephro> all of the key-value pairs
20110630 13:37:37< elias> http://codepad.org/X3yMSLNa
20110630 13:37:42< elias> ^this is what i guess
20110630 13:37:44< elias> *get
20110630 13:37:50< elias> codepad uses lua 5.0 from what i know
20110630 13:37:54< Nephro> that is correct
20110630 13:38:05< Nephro> because codepad knows nothing about the variables
20110630 13:38:12< Nephro> but wesnoth knows all of them
20110630 13:38:20< Nephro> I thinki I know where the problem is
20110630 13:38:22< elias> ah, i see, no ""
20110630 13:39:26< Nephro> SURE... there has to be a "local" before conf... I can't believe I keep falling for this one over and over again
20110630 13:41:27< elias> also unrelated... why are you using ["side"] = instead of side =?
20110630 13:42:05< Nephro> because there's a variable called side
20110630 13:42:29< Nephro> side=side would be weird and I doubt that it would be valid at all
20110630 13:42:38< Gambit> side=$side
20110630 13:42:45< timotei> Nephro: why it has to be "local" ?
20110630 13:43:17< elias> side=side should be valid... but yeah, might be weird
20110630 13:43:20< Gambit> derp wrong language
20110630 13:44:22< Nephro> timotei, iirc lua treats all vars defined without a local as global vars. Our lua interpreter must be tweaked to do something I don't know to global vars... I have noticed that using variables without local causes all kinds of weird stuff
20110630 13:45:07< timotei> Nephro: wait. aren't we using the original lua?
20110630 13:45:12< timotei> since it's embedded in our source code?
20110630 13:46:56< Nephro> It probably is original, but Lua is very customizable
20110630 13:48:05-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: No route to host]
20110630 13:49:14-!- stikonas [~gentoo@ctv-79-132-175-26.vinita.lt] has joined #wesnoth-dev
20110630 14:01:59-!- mjs-de [~mjs-de@g224177118.adsl.alicedsl.de] has joined #wesnoth-dev
20110630 14:17:12< Nephro> Crab_, can you, please, help me out a bit? I am at the point where I should call modify_ai to add the sticky candidate action. Problem is, I can't find in the C++ code, at which point the candidate action is actually created.  component_manager::add_component() in the holder::modify_ai doesn't call any creation code at all, so I am a bit confused.
20110630 14:18:29< Crab_> let's see...
20110630 14:20:51< Crab_> component_manager::add_component, component::add_child, vector_property_handler::handle_add, vector_property_handler::do_add
20110630 14:21:14< Crab_> then, open src\ai\testing\stage_rca.cpp
20110630 14:21:27< Crab_> note the register_vector_property(property_handlers(),"candidate_action",candidate_actions_, factory_candidate_actions); line
20110630 14:21:43< Crab_> note the factory_candidate_actions variable
20110630 14:21:52< Crab_> note the testing_ai_default::candidate_action_evaluation_loop::create_candidate_action binding
20110630 14:22:22< Crab_> and candidate_action_evaluation_loop::create_candidate_action calls engine::parse_candidate_action_from_config
20110630 14:22:53< Crab_> and engine::parse_candidate_action_from_config delegates to the actual engine for this candidate action
20110630 14:23:26< Crab_> to engine_cpp::do_parse_candidate_action_from_config or to engine_lua::do_parse_candidate_action_from_config or to engine_fai::do_parse_candidate_action_from_config
20110630 14:23:59< Crab_> is this enough info ? or is there anything else ?
20110630 14:24:32< Nephro> enough, thanks
20110630 14:24:46< Crab_> so, candidate action with 'engine=lua' would be parsed to engine_lua::do_parse_candidate_action_from_config
20110630 14:25:23< Crab_> the reason for the indirection with property handlers is to separate the concept of properties and the actual functions which do create the properties
20110630 14:26:15< Crab_> i.e. all the logic is in property_handler and component classes, except 1-2 lines which tell the actual functions that are used to create the properties and the line which is used to register  the property
20110630 14:26:32< Nephro> the reason I ask, is because I tried just using the modify_ai functionality, but it never got to the breakpoint in the engine code
20110630 14:27:06< Nephro> the res in holder::modify_ai remained false after entering add_component
20110630 14:31:57< Crab_> maybe something was not good in [modify_ai] config
20110630 14:32:11< Crab_> that might be the reason for breakpoint not hitting
20110630 14:32:28< Crab_> does your ca have a proper id= ?
20110630 14:32:56-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has joined #wesnoth-dev
20110630 14:34:34< Nephro> Ooops, this I did forget... Or, no, I thought it will extract the id from the path
20110630 14:34:40< Nephro> Added it anyway
20110630 14:37:05< Crab_> note that there's --log-debug=ai/mod
20110630 14:40:32-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110630 14:41:45-!- vultraz [~chatzilla@124.109.10.222] has quit [Quit: installing security update :S]
20110630 14:44:01< Nephro> Yes, I think something is wrong with my config. 	const config &ch = cfg.child(tail.property);if (!ch) {return false;}
20110630 14:44:14< Nephro> this return is executed
20110630 14:57:01-!- Grimling [~FKint@91.181.6.117] has quit [Quit: Leaving]
20110630 14:58:32< Nephro> Crab_, const config &ch = cfg.child(tail.property); -- does this line imply that we have to have a subconfig with a key "candidate_action" to have all the attributes of the new CA or am I wrong? This creates a problem, since it seems I can't pass a nested table to wesnot.wml_actions.modify_ai, because a nested table is not a WML table
20110630 14:58:34-!- hhyloc [~hhyloc@113.166.151.80] has quit [Quit: Leaving]
20110630 14:58:58< Crab_> you can pass any config using a lua table
20110630 14:59:03-!- stikonas [~gentoo@ctv-79-132-175-26.vinita.lt] has quit [Remote host closed the connection]
20110630 14:59:10< Crab_> and you should have a subconfig, yes
20110630 14:59:36< Crab_> like       { side = 1, { 'candidate_action', { .... }}}
20110630 14:59:49< Crab_> just nest the subtag name first, then the contents
20110630 15:00:05< Crab_> see http://wiki.wesnoth.org/LuaWML#Encoding_WML_objects_into_Lua_tables  for examples
20110630 15:00:33< Nephro> oh, I see. I was trying to do {a = {}}
20110630 15:00:40< Nephro> So it choked
20110630 15:00:52-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20110630 15:04:24-!- AngelsJinx [~AngelsJin@119.224.78.213] has quit [Read error: Connection reset by peer]
20110630 15:04:41-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 15:05:09-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has joined #wesnoth-dev
20110630 15:05:09-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has quit [Changing host]
20110630 15:05:10-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 15:06:09-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20110630 15:10:49-!- monochromatic [~monochrom@pool-173-59-67-167.phlapa.east.verizon.net] has quit [Read error: Operation timed out]
20110630 15:10:59-!- monochromatic [~monochrom@pool-74-109-66-162.phlapa.east.verizon.net] has joined #wesnoth-dev
20110630 15:17:35-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110630 15:28:03-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 240 seconds]
20110630 15:28:28-!- atomicbomb [~quassel@125.160.83.186] has quit [Quit: Nice movie... :D]
20110630 15:28:44-!- Crab_ [~Crab@wesnoth/developer/crab] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20110630 15:29:37-!- Johannes13 [~Johannes@p5DF74B5B.dip.t-dialin.net] has joined #wesnoth-dev
20110630 15:29:41-!- Johannes13 [~Johannes@p5DF74B5B.dip.t-dialin.net] has quit [Changing host]
20110630 15:29:41-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110630 16:03:17-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110630 16:14:54< CIA-85> nephro * r50094 /trunk/ (4 files in 4 dirs): Added functionality to the [add_ai_behavior] tag. Not fully working at the moment, but is usable. The usage syntax will most probably remain, but the internals will be modified.
20110630 16:15:11-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 240 seconds]
20110630 16:15:48-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110630 16:30:38-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 252 seconds]
20110630 16:31:15-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev
20110630 16:40:01-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has quit [Remote host closed the connection]
20110630 16:44:52< CIA-85> espreon * r50095 /trunk/data/ai/lua/patrol.lua: Ran umcpropfix.
20110630 16:53:15< Nephro> Espreon, can you please explain what you just did there? So that next time I'd do it myself...
20110630 16:54:08< Espreon> I just svn:eol-style (with the "native" value) on the file.
20110630 16:54:25< Espreon> Nephro: It can be done manually like so: svn propset svn:eol-style native <files>
20110630 16:54:41-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20110630 16:55:00< Nephro> Espreon, ok thanks 
20110630 16:55:07< Espreon> No prob.
20110630 16:58:02-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 16:59:50-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has joined #wesnoth-dev
20110630 17:00:50-!- vultraz [~chatzilla@124.109.10.222] has joined #wesnoth-dev
20110630 17:05:41-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20110630 17:12:06-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev
20110630 17:17:05< CIA-85> nephro * r50096 /trunk/data/ai/ (lua/patrol.lua scenarios/scenario-lua-ai.cfg): Removed debug outputs
20110630 17:35:18< CIA-85> espreon * r50097 /trunk/utils/umc_dev/ (4 files in 4 dirs): Set svn:eol-style.
20110630 17:52:01-!- Sytyi [~sytyi@224-3-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110630 17:57:50-!- timotei [~timotei@193.34.190.70] has joined #wesnoth-dev
20110630 17:57:50-!- timotei [~timotei@193.34.190.70] has quit [Changing host]
20110630 17:57:50-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110630 17:57:50-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20110630 18:00:33-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110630 18:03:21-!- stikonas [~gentoo@ctv-79-132-175-26.vinita.lt] has joined #wesnoth-dev
20110630 18:18:41-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110630 18:22:15-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 276 seconds]
20110630 18:27:14-!- Shakey [~Shakey@12.190.80.225] has joined #wesnoth-dev
20110630 18:27:27-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has quit [Ping timeout: 276 seconds]
20110630 18:40:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110630 18:42:00-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20110630 18:50:55-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Read error: No route to host]
20110630 18:51:53-!- zaroth [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev
20110630 18:52:21-!- AngelsJinx [~AngelsJin@119.224.78.213] has quit [Ping timeout: 264 seconds]
20110630 18:55:04-!- stikonas [~gentoo@ctv-79-132-175-26.vinita.lt] has quit [Remote host closed the connection]
20110630 19:01:10-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 19:11:16-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110630 19:50:58-!- Nephro [~Dmitry@80.233.231.12] has quit [Read error: Connection reset by peer]
20110630 20:27:49-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20110630 20:27:50-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20110630 20:27:50-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20110630 20:28:04< CIA-85> tschmitz * r50098 /trunk/ (24 files in 4 dirs): 
20110630 20:28:04< CIA-85> Made whiteboard plans visible to allied network players
20110630 20:28:04< CIA-85> Disabled undo while planning mode is active
20110630 20:28:04< CIA-85> Changed arrow constructor to be more RAII
20110630 20:28:10< mordante> servus
20110630 20:37:05< Sytyi> mordante: hi.
20110630 20:37:10< mordante> hi Sytyi 
20110630 20:37:56< Sytyi> mordante: uploaded two patches to differnt patch pages on Gna!
20110630 20:37:57< mordante> Sytyi, how are things goint?
20110630 20:38:03< mordante> going*
20110630 20:39:09< Sytyi> mordante: Prepairing to next stage - trying to understand how to parse schema.cfg and how tokenizer works
20110630 20:39:41< Sytyi> mordante: Reading devdocs and sources
20110630 20:42:00< mordante> ok good
20110630 20:42:05< vultraz> what's the link to the latest vaersion+svn changelog?
20110630 20:42:08-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20110630 20:42:28< mordante> brb
20110630 20:42:56< grzywacz> i
20110630 20:42:58< grzywacz> hi even
20110630 20:47:57-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 20:48:15< vultraz> nvn found it
20110630 20:53:09-!- mjs-de [~mjs-de@g224177118.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds]
20110630 21:03:05-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has quit [Ping timeout: 260 seconds]
20110630 21:07:15-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has joined #wesnoth-dev
20110630 21:10:54-!- anonymissimus [~chatzilla@HSI-KBW-095-208-215-104.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110630 21:11:37-!- anonymissimus [~chatzilla@HSI-KBW-095-208-215-104.hsi5.kabel-badenwuerttemberg.de] has quit [Client Quit]
20110630 21:26:12-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 276 seconds]
20110630 21:29:09-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has quit [Quit: ...]
20110630 21:40:09-!- AngelsJinx [~AngelsJin@119.224.78.213] has quit [Ping timeout: 250 seconds]
20110630 21:46:13-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 250 seconds]
20110630 21:47:33-!- MeccaGod [~majs@h146n3fls33o279.telia.com] has quit []
20110630 21:48:16-!- anonymissimus [~chatzilla@HSI-KBW-095-208-215-104.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110630 21:53:09-!- cjhopman [~chris@wesnoth/developer/cjhopman] has quit [Read error: Operation timed out]
20110630 21:53:42-!- cjhopman [~chris@c-71-202-164-232.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110630 21:53:42-!- cjhopman [~chris@c-71-202-164-232.hsd1.ca.comcast.net] has quit [Changing host]
20110630 21:53:42-!- cjhopman [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20110630 22:04:19-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
20110630 22:05:00-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 276 seconds]
20110630 22:08:44< Sytyi> mordante: Schould the entities to read from cfg be structs, or they can be classes as well?
20110630 22:13:14< Sytyi> mordante: I.E. http://www.wesnoth.org/devdocs/structgui2_1_1tgui__definition.html
20110630 22:23:41< mordante> Sytyi, in C++ a struct and a class are the same thing, only their default visibility differs
20110630 22:24:19< Sytyi> So I can write class to my needs
20110630 22:24:29< mordante> yes
20110630 22:24:47< Sytyi> mordante: cool. Can you say anything good about my patches ?
20110630 22:24:53< CIA-85> mordante * r50099 /trunk/src/hotkeys.hpp: Initialize all members.
20110630 22:24:56< CIA-85> mordante * r50101 /trunk/src/ai/composite/engine_lua.cpp: 
20110630 22:24:56< CIA-85> Properly name a private variable.
20110630 22:24:56< CIA-85> Private variables should have a trailing underscore.
20110630 22:24:56< CIA-85> mordante * r50100 /trunk/src/ai/composite/engine_lua.cpp: Initialize all members.
20110630 22:24:57< CIA-85> mordante * r50102 /trunk/src/hotkeys.cpp: Initialize all members.
20110630 22:25:00< CIA-85> mordante * r50103 /trunk/src/ (ai/composite/engine_lua.cpp whiteboard/attack.cpp): Strip trailing whitespace.
20110630 22:26:10< mordante> Sytyi, was about to start before I went on the phone... will finish them now
20110630 22:26:57< mordante> nephro have a look at r50101, also I think there might be an issue when find returns and end of container iterator
20110630 22:33:27-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has quit [Ping timeout: 250 seconds]
20110630 22:33:34-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has joined #wesnoth-dev
20110630 22:37:33< mordante> Sytyi, regarding the mandatory, it now no longer says a field is not mandatory when it's not
20110630 22:37:51< mordante> also won't default now say »default = """"« ?
20110630 22:40:04< Sytyi> mordante: default now will not say """" - I fixed it. But I mistoke and made this case equal to defalut =            (none) and key is mandatory. This is fixed in one line  -  
20110630 22:40:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110630 22:42:56< anonymissimus> mordante: "in C++ a struct and a class are the same thing, only their default visibility differs": I was told that classes are less efficient than structs in C++ (time needed to access members an such), that is, one should attempt to avoid classes, while structs are ok especially if one doesnt need member functions, only data members
20110630 22:43:29< Sytyi> mordante: and possibly - not in one line. Is hidden in regex. Added to TODO list.
20110630 22:44:01-!- Grimling [~FKint@91.181.6.117] has joined #wesnoth-dev
20110630 22:44:51< mordante> Sytyi, ok will test it later, expect it in the regex since the diff between the two patches is small on that line
20110630 22:45:20< mordante> anonymissimus, you've been misinformed
20110630 22:47:05-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110630 22:47:14-!- Crab_ [~Crab_@wesnoth/developer/crab] has left #wesnoth-dev []
20110630 22:47:20< anonymissimus> could that depend on the build environment too, e.g. g++ links classes more efficiently than MSVC or something
20110630 22:47:49< Sytyi> mordante: I see, now it automatically removes quotes (if they are) and add when printing. So earlier version also added quotes, even if they already were. The solution is to move quotes inside regex to substring ("? "key_value" "?). and remove quoting from printing. Will do it.  
20110630 22:49:53< mordante> Sytyi, ok
20110630 22:50:35< grzywacz> anonymissimus, unlikely :)
20110630 22:50:37< mordante> anonymissimus, no shouldn't matter, what could matter is that most people don't use getters and setters in structs and do in classes
20110630 22:51:16< mordante> if these getters and setters are not inlined in the header it has a function call overhead
20110630 22:58:17-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110630 23:00:17< anonymissimus> I understand :)
20110630 23:03:42-!- Gallaecio [~quassel@92.39.broadband12.iol.cz] has quit [Remote host closed the connection]
20110630 23:04:05< Espreon> mordante: Hello. Do you wish to test the insertion stuff today?
20110630 23:04:49< mordante> Espreon, no, will be off soon, probably will look at it this weekend
20110630 23:04:55< Espreon> OK.
20110630 23:12:32-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Operation timed out]
20110630 23:15:43< mordante> Sytyi, more questions for now?
20110630 23:15:49< Sytyi> nope. 
20110630 23:16:09< mordante> ok good I'm about to leave
20110630 23:16:29< CIA-85> mordante * r50107 /trunk/src/ana/api/ana.hpp: Fix a doxygen warning.
20110630 23:16:29< CIA-85> mordante * r50105 /trunk/src/actions.hpp: Fix doxygen warnings.
20110630 23:16:29< CIA-85> mordante * r50106 /trunk/src/ai/composite/aspect.hpp: Fix a doxygen warning.
20110630 23:16:30< CIA-85> mordante * r50104 /trunk/src/actions.hpp: Fix some doxygen warnings.
20110630 23:16:30< CIA-85> mordante * r50108 /trunk/src/ana/api/timers.hpp: Fix doxygen warnings.
20110630 23:16:30< CIA-85> mordante * r50109 /trunk/src/builder.cpp: Fix doxygen warnings.
20110630 23:16:33< CIA-85> mordante * r50110 /trunk/src/menu_events.cpp: Fix doxygen warnings.
20110630 23:16:36< CIA-85> mordante * r50111 /trunk/src/image_modifications.cpp: Fix a doxygen warning.
20110630 23:16:47-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has joined #wesnoth-dev
20110630 23:16:47-!- stikonas [~and@ctv-79-132-175-26.vinita.lt] has quit [Changing host]
20110630 23:16:47-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 23:17:37< mordante> I'm off night
20110630 23:17:43< Sytyi> mordante: bye. 
20110630 23:19:06-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20110630 23:20:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110630 23:20:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110630 23:29:56-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20110630 23:35:05< anonymissimus> shadowmaster: can you look at one of exasperation's patches ? I want him to get write access ;); already applied one of them and it's not so good if I make all of them :P
20110630 23:36:10-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev
20110630 23:36:14-!- Sytyi [~sytyi@224-3-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20110630 23:36:22< anonymissimus> as I see it, we con't have enough devs with enough time to apply all those patches and this is both the reason and cause of itsself :P
20110630 23:36:48< anonymissimus> notably for alarantalara's apply patches too
20110630 23:37:21< shadowmaster> depends on what the patch is about. I do not review changes on areas I do not  know well.
20110630 23:37:43< shadowmaster> *in
20110630 23:37:44< anonymissimus> well, it's a gui related patch
20110630 23:37:52< anonymissimus> gui2
20110630 23:38:18< anonymissimus> http://gna.org/patch/?2760
20110630 23:38:42< anonymissimus> and also lua; we lua dialog authors would greatly appreciate this feature
20110630 23:41:00< shadowmaster> the changelog hunk adds to the wrong location; the config interface should be used for retrieving boolean values, not string_bool()
20110630 23:42:28< shadowmaster> and somehow it feels like this isn't a Lua-specific change and would affect the static GUI2 WML as well; in such case it'd ne becessary to make sure the existing defaults don't change
20110630 23:42:36< shadowmaster> *be ne*
20110630 23:43:09-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20110630 23:44:00< shadowmaster> I personally think this kind of patches affecting the GUI2 framework itself should be mordante's responsibility
20110630 23:44:03< anonymissimus> afaik it makes possible to use a use_markup= attribute in the data/gui/ wml definitions
20110630 23:44:11< anonymissimus> as well
20110630 23:44:19-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110630 23:44:50< shadowmaster> yeah, and that can only be done from the C++ right now and I'm not sure whether the default is positive or negative
20110630 23:45:52-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110630 23:46:20< anonymissimus> the default seems negative - in lua dialogs pango doesnt work and can also nto be enabled currently
20110630 23:47:20< shadowmaster> in that case the utils::string_bool() call is alright, but it still needs to be replaced with a config method call for consistency
20110630 23:47:30< anonymissimus> I just wonder whether there's something structurally bad about adding the feature to the "gui2 framework", but if it just wasn't needed until now it should be added
20110630 23:47:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20110630 23:47:56< anonymissimus> yes .to_bool() I saw that too
20110630 23:49:12< shadowmaster> I'd consider the addition an improvement either way.
20110630 23:49:46< anonymissimus> ok thx for looking
20110630 23:50:52-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110630 23:51:50-!- Exasperation [4a47319b@gateway/web/freenode/ip.74.71.49.155] has joined #wesnoth-dev
20110630 23:56:28-!- Upth [~ogmar@public-nat1.scc.losrios.edu] has joined #wesnoth-dev
20110630 23:56:28-!- Upth is now known as Upthorn
20110630 23:59:29< anonymissimus> Exasperation: shadowmaster and me were just talking about your patch xD
--- Log closed Fri Jul 01 00:00:01 2011