--- Log opened Sun Jul 03 00:00:59 2011 20110703 00:13:11-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 244 seconds] 20110703 00:16:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20110703 00:40:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20110703 00:48:01-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev 20110703 00:51:56-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has quit [Remote host closed the connection] 20110703 00:53:21-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has joined #wesnoth-dev 20110703 00:53:40-!- covale [~covale@h55eb1ca0.selukra.dyn.perspektivbredband.net] has quit [Client Quit] 20110703 00:54:13-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds] 20110703 01:00:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20110703 01:12:06-!- beetlenaut [~dan@174.32.63.204] has quit [Read error: Connection reset by peer] 20110703 01:12:59-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20110703 01:18:12-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20110703 01:20:53-!- beetlenaut [~dan@174.32.63.204] has joined #wesnoth-dev 20110703 01:37:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20110703 01:39:44-!- un214 [~un214@75.45.20.64] has quit [Remote host closed the connection] 20110703 01:45:41-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20110703 02:02:33-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev [] 20110703 02:23:46-!- lamefun [~dingbing@unaffiliated/lamefun] has quit [Ping timeout: 263 seconds] 20110703 02:30:37-!- deekay [~dk@wesnoth/developer/dragonking] has quit [Quit: deekay] 20110703 02:31:53-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [] 20110703 02:35:48< CIA-85> tschmitz * r50115 /trunk/images/arrows/focus_invalid/ (60 files): Added images for the whiteboard arrow style focus_invalid. 20110703 02:39:14-!- Shakey [HydraIRC@c-24-1-105-76.hsd1.il.comcast.net] has quit [Quit: HydraIRC -> http://www.hydrairc.com <- IRC with a difference] 20110703 03:30:28-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 258 seconds] 20110703 03:42:42-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds] 20110703 03:56:28-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev 20110703 04:03:43-!- Ivanovic_ [~ivanovic@dtmd-4db2e2a5.pool.mediaWays.net] has joined #wesnoth-dev 20110703 04:03:43-!- Ivanovic_ [~ivanovic@dtmd-4db2e2a5.pool.mediaWays.net] has quit [Changing host] 20110703 04:03:43-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20110703 04:07:18-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds] 20110703 04:07:43-!- Ivanovic_ is now known as Ivanovic 20110703 04:13:57-!- atomicbomb [~quassel@61.94.49.248] has joined #wesnoth-dev 20110703 04:37:46-!- admiralbumblebe1 [~Adium@cpe-173-171-233-235.tampabay.res.rr.com] has joined #wesnoth-dev 20110703 04:42:57-!- admiralbumblebe1 [~Adium@cpe-173-171-233-235.tampabay.res.rr.com] has quit [Ping timeout: 276 seconds] 20110703 04:54:44< CIA-85> espreon * r50116 /trunk/images/arrows/focus_invalid/ (59 files): Ran umcpropfix. 20110703 05:06:07-!- enchilad1 [~enchilado@ppp118-208-42-239.lns20.bne1.internode.on.net] has joined #wesnoth-dev 20110703 05:09:10-!- enchilado [~enchilado@ppp118-208-85-205.lns20.bne4.internode.on.net] has quit [Ping timeout: 252 seconds] 20110703 05:22:18-!- Gambit is now known as SilentGambob 20110703 05:22:43-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev [] 20110703 05:53:30-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...] 20110703 05:57:01-!- monochromatic [~monochrom@pool-74-109-69-108.phlapa.east.verizon.net] has quit [Quit: Computer has gone to sleep] 20110703 06:13:53-!- SilentGambob [~Gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20110703 06:18:16-!- Appleman1234 [~Appleman1@27-33-43-153.static.tpgi.com.au] has quit [Remote host closed the connection] 20110703 06:18:51-!- atomicbomb [~quassel@61.94.49.248] has quit [Remote host closed the connection] 20110703 06:49:29-!- atomicbomb [~quassel@61.94.94.49] has joined #wesnoth-dev 20110703 06:53:31< Espreon> ... And it seems that RCA AI is the only option to be selected when creating a game... sometimes. 20110703 07:12:40< tschmitz> Espreon: Hey, what is umcpropfix? 20110703 07:19:46-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev 20110703 07:19:52-!- AngelsJinx [~AngelsJin@119.224.78.213] has left #wesnoth-dev [] 20110703 07:35:02-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev 20110703 07:35:10-!- AngelsJinx [~AngelsJin@119.224.78.213] has left #wesnoth-dev [] 20110703 07:59:04< Espreon> tschmitz: It is a script that sets and unsets svn properties. 20110703 07:59:30< Espreon> tschmitz: It just set svn:mime-type on your images. 20110703 07:59:38-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev 20110703 08:00:13< tschmitz_> Let's see who was beeping me ... 20110703 08:00:20< Espreon> 'Twas I. 20110703 08:01:41< tschmitz_> K cool 20110703 08:02:03< tschmitz_> Espreon: Is that something that I should have done? 20110703 08:03:22< Espreon> I suppose. 20110703 08:04:15< Espreon> tschmitz_: Look at the help data for svn propset for more information if you really want to do it. Or you could just grab umcpropfix from Wesnoth-UMC-Dev's repository. 20110703 08:05:54< shadowmaster> http://wesnoth-umc-dev.ai0867.net/docs/svnprops.php 20110703 08:06:19< shadowmaster> it's much better to have the SVN client do that kind of things automatically 20110703 08:06:26< Espreon> ... and I forgot that we had that page. 20110703 08:10:48< tschmitz_> shadowmaster, Espreon: Thanks. Things sure are streamlined around here 20110703 08:11:09< Espreon> No prob. 20110703 08:18:33-!- zaroth [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev 20110703 08:28:03-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds] 20110703 08:29:04-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20110703 08:44:58-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Ping timeout: 252 seconds] 20110703 08:46:23-!- fabi [~fabi@88-134-20-121-dynip.superkabel.de] has joined #wesnoth-dev 20110703 08:50:09-!- fendrin [~fabi@88-134-20-121-dynip.superkabel.de] has quit [Ping timeout: 276 seconds] 20110703 08:55:00-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has joined #wesnoth-dev 20110703 08:59:02-!- hopman- [~chris@c-71-202-164-232.hsd1.ca.comcast.net] has joined #wesnoth-dev 20110703 08:59:41-!- cjhopman [~chris@wesnoth/developer/cjhopman] has quit [Ping timeout: 240 seconds] 20110703 08:59:43-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev 20110703 09:11:06-!- zaroth_ [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev 20110703 09:11:15-!- zaroth [~zaroth@wesnoth/developer/zaroth] has quit [Ping timeout: 246 seconds] 20110703 09:22:41-!- enchilad1 is now known as enchilado 20110703 09:23:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds] 20110703 09:24:24-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has quit [Ping timeout: 276 seconds] 20110703 09:24:46-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has joined #wesnoth-dev 20110703 09:33:41-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20110703 09:39:05-!- stikonas [~and@ctv-213-164-115-173.vinita.lt] has joined #wesnoth-dev 20110703 09:39:05-!- stikonas [~and@ctv-213-164-115-173.vinita.lt] has quit [Changing host] 20110703 09:39:05-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev 20110703 09:45:26-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Quit: Page closed] 20110703 09:45:47-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev 20110703 09:49:26-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev 20110703 09:50:14-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Ping timeout: 252 seconds] 20110703 09:52:35-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has joined #wesnoth-dev 20110703 09:53:00-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev 20110703 10:01:59-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20110703 10:02:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20110703 10:09:23-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev 20110703 10:09:26-!- Rose [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev 20110703 10:11:33-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Ping timeout: 264 seconds] 20110703 10:28:34-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection] 20110703 10:34:58-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has quit [Ping timeout: 252 seconds] 20110703 10:36:30-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has joined #wesnoth-dev 20110703 10:36:30-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has quit [Changing host] 20110703 10:36:30-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev 20110703 10:43:07-!- enchilad1 [~enchilado@ppp118-208-86-184.lns20.bne4.internode.on.net] has joined #wesnoth-dev 20110703 10:43:57-!- Sytyi [~sytyi@203-107-112-92.pool.ukrtel.net] has joined #wesnoth-dev 20110703 10:46:08-!- enchilado [~enchilado@ppp118-208-42-239.lns20.bne1.internode.on.net] has quit [Ping timeout: 250 seconds] 20110703 10:46:42-!- Gallaecio [~quassel@zla02.domus.cz] has joined #wesnoth-dev 20110703 10:52:17< Sytyi> is there smth like bug tracker for translations ? 20110703 10:54:44< Ivanovic> no 20110703 10:54:57< Ivanovic> if you find an issue in a translation, mail the maintainer 20110703 10:55:19< Ivanovic> for a list of maintainers check http://wiki.wesnoth.org/WesnothTranslations 20110703 10:58:34< CIA-85> ivanovic * r50117 /trunk/ (7 files in 6 dirs): updated Indonesian translation 20110703 11:10:43-!- Gallaecio [~quassel@zla02.domus.cz] has quit [Ping timeout: 240 seconds] 20110703 11:11:54-!- Gallaecio [~quassel@zla02.domus.cz] has joined #wesnoth-dev 20110703 11:12:40-!- loonybot [~loonybot@46.138.86.250] has joined #wesnoth-dev 20110703 11:12:40-!- loonybot [~loonybot@46.138.86.250] has quit [Changing host] 20110703 11:12:40-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20110703 11:18:44-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: Lost terminal] 20110703 11:24:39-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds] 20110703 11:26:25< Sytyi> Ivanovic: thanks. 20110703 11:27:30-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev 20110703 11:41:53< Sytyi> Ivanovic: also, i noticed a small thing in current version - message in left top corner of game window with text smth like "side= empty, set to 1 ". Is it a bug, or I am too suspicious? 20110703 11:45:10< Ivanovic> Sytyi: uhm, which language? 20110703 11:45:24< Ivanovic> Sytyi: it is either some broken translation file, or something broken in code 20110703 11:45:25< Sytyi> Russian. 20110703 11:45:50< Ivanovic> in which scenario do you see this? 20110703 11:46:20-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20110703 11:46:39< Sytyi> Ivanovic: It was in HTTT 04, when the victory triggered 20110703 11:48:24< Ivanovic> so where exactly was it displayed? 20110703 11:48:28< Ivanovic> among the error messages? 20110703 11:48:55< Ivanovic> (meaning the top left corner of the game screen (map below) where otherwise chatmassages in MP appear and stuff like that) 20110703 11:50:26< shadowmaster> it will be displayed both in stderr and in the chat stream 20110703 11:51:12< Sytyi> Ivanovic: Im not a expirienced player. Havent play MP. It was left top corner about 20 px left to borders of mainwindow 20110703 11:51:41< Ivanovic> Sytyi: and right below the top bar 20110703 11:51:52< Sytyi> Ivanovic: Yep 20110703 11:51:59< Ivanovic> and you probably also have this line in your commandline output 20110703 11:52:22< Sytyi> Ivanovic: didnt watch it, but I can try to reproduce 20110703 11:52:24 * shadowmaster is speaking based on his current observations after using :throw enemies defeated in the scenario 20110703 11:52:24< Ivanovic> sounds like some case of sound issue that you should ping zookeeper about 20110703 11:53:03< Sytyi> Ivanovic: So that is a probably bug, and I can document it. 20110703 11:53:22< Ivanovic> either a bug or a "too verbose" error message 20110703 11:53:34< Ivanovic> but more likely some "this code is not as clean as it could be" scenario 20110703 11:55:54< CIA-85> shadowmaster * r50118 /trunk/data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg: HttT: fix a warning about allow_recruit.side being missing in scenario 4's enemies defeated event; spotted by Sytyi 20110703 11:57:13< Sytyi> shadowmaster: You're really quick. 20110703 11:57:44< shadowmaster> sometimes we are quick 20110703 12:00:44< shadowmaster> This will pop up in a few other places as well; we'd better get a wmllint rule to help. 20110703 12:02:32< Sytyi> shadowmaster: while speaking I tried to preprocess that file but get no output. 20110703 12:03:04< shadowmaster> what do you mean by preprocess? 20110703 12:03:27< Sytyi> shadowmaster: wesnoth -p file target_dit 20110703 12:04:13< shadowmaster> perhaps it's croaking because it needs to preprocess other paths in order to get all of the preprocess-time dependencies for that file 20110703 12:05:04-!- timotei [~timotei@193.34.190.70] has joined #wesnoth-dev 20110703 12:05:05-!- timotei [~timotei@193.34.190.70] has quit [Changing host] 20110703 12:05:05-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20110703 12:05:29< timotei> Sytyi: check for stderr 20110703 12:05:40< timotei> Sytyi: core is automatically parsed before any other files IIRC 20110703 12:06:08< shadowmaster> yeah, but it also uses HttT-specific macros which are included by the tree starting at data/campaigns/Heir_to_the_Throne/_main.cfg 20110703 12:06:32< shadowmaster> BIGMAP_BAY_OF_PEARLS in particular 20110703 12:06:40-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.17/20110422054610]] 20110703 12:07:02-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20110703 12:07:13-!- Johannes13 [~Johannes@p5DF75CF5.dip.t-dialin.net] has joined #wesnoth-dev 20110703 12:07:13-!- Johannes13 [~Johannes@p5DF75CF5.dip.t-dialin.net] has quit [Changing host] 20110703 12:07:14-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20110703 12:07:23< shadowmaster> in fact, that's the exact error on whioch it croaks 20110703 12:07:31-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20110703 12:07:31-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev 20110703 12:07:56< shadowmaster> http://pastebin.com/A7GKwYKH 20110703 12:12:33-!- atomicbomb [~quassel@61.94.94.49] has quit [Remote host closed the connection] 20110703 12:12:58< timotei> ah 20110703 12:12:59< timotei> yeah 20110703 12:13:18< shadowmaster> I think I'll ask Anonymissimus to take care of the wmllint FR. It seems like more tags than just *_recruit are affected by some .side handling changes 20110703 12:14:09< Sytyi> shadowmaster: Curious but I had next http://pastebin.com/qmcvsW4x 20110703 12:14:21< shadowmaster> circa r49478 (this particular case appears to have been introduced by r49479) 20110703 12:15:44< shadowmaster> Sytyi: the "Unterminated quote string" and the following dump is probably just the preprocessor code being as helpful as always when it comes to diagnostics. 20110703 12:16:33< Sytyi> shadowmaster: thanks. 20110703 12:16:58< shadowmaster> since 1.9.0, unresolved macros or files lead to the preprocessor declaring further tinkering with the WML a lost case 20110703 12:17:05-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 260 seconds] 20110703 12:18:17< shadowmaster> I was going to say "cause", but since WML tends to be so hard to read as legalese that may work too. 20110703 12:20:55< timotei> Sytyi: umm, why don't you preprocess the entire HTTT directory? :) 20110703 12:20:58< timotei> :P 20110703 12:24:37< shadowmaster> zaroth_: I'm getting proxy options in --help with a no-libana build and the proxy code is a (incomplete?) feature from the libana network interface. With SDL_net it leads to an early abort due to a thrown std::runtime_error ("what(): Proxy not available while using SDL_net. Use ANA instead.") 20110703 12:24:53< Sytyi> timotei: there is no need now, but I'll remember it . shadowmaster dealed with that probably bug. 20110703 12:25:44< zaroth_> shadowmaster: is a "no-ana build" a #define? 20110703 12:25:50< zaroth_> or how is it done? 20110703 12:26:09< shadowmaster> Sytyi: it's not so much a bug in the sense that something is not working as expected; things are working as expected, but someone (anonymissimus) forgot to tell esr to add wmllint rules for fixing code based on the assumption that .side defaults to 1 for some actions 20110703 12:27:01< shadowmaster> zaroth_: scons magic :) let me check 20110703 12:27:19-!- atomicbomb [~quassel@61.94.183.20] has joined #wesnoth-dev 20110703 12:28:24< shadowmaster> now if there's a wmllint rule in place it doesn't work (mainline runs clean) nor I can't find it in the script 20110703 12:29:31< esr> wmllint rule? Eh? What rule do we need? 20110703 12:30:25-!- hhyloc [~hhyloc@113.166.160.67] has joined #wesnoth-dev 20110703 12:30:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20110703 12:30:50-!- AngelsJinx [~AngelsJin@119.224.78.213] has joined #wesnoth-dev 20110703 12:30:54-!- AngelsJinx [~AngelsJin@119.224.78.213] has left #wesnoth-dev [] 20110703 12:31:28< shadowmaster> esr: something about set_recruit, allow_recruit and disallow_recruit no longer assuming side=1 silently when there's no side specification; they now cause a noisy warning in the game, probably with the purpose of removing that behavior entirely in some later version. As I pointed out above I'm not sure what else is affected. 20110703 12:31:45< esr> Hm. 20110703 12:32:09< shadowmaster> there's a few instances of those actions lacking side specifications in mainline campaigns 20110703 12:32:14< esr> Sio I should detect and warn when one of these lacks a side specification? 20110703 12:33:01< shadowmaster> yes, but an automatic fix (add the missing side=1) would be probably nice as well 20110703 12:35:09< esr> shadowmaster: I'll look into it. 20110703 12:35:33< shadowmaster> okay, thanks 20110703 12:45:39-!- enchilad1 is now known as enchilado 20110703 12:46:37< shadowmaster> zaroth_: well, it seems most of the magic is not in the build recipe but in the source code. I'll take a look at that part later. 20110703 12:47:03-!- enchilado [~enchilado@ppp118-208-86-184.lns20.bne4.internode.on.net] has quit [Read error: Connection reset by peer] 20110703 12:47:23< zaroth_> so how exactly one does a "noana build" then? ;-) 20110703 12:47:32< shadowmaster> or we could leave it as is. Really the only reason I care is that it may make sense to disable libana by default when approaching the 1.10 betas or RCs 20110703 12:47:59< shadowmaster> zaroth_: what build system do you use? 20110703 12:48:03< zaroth_> cmake 20110703 12:48:13< shadowmaster> meh. 20110703 12:49:44< shadowmaster> zaroth_: looks like it might be -DUSE_ANA_NETWORK=OFF for cmake; it's use_network_ana=false for scons 20110703 12:50:00-!- enchilado [~enchilado@ppp118-208-86-184.lns20.bne4.internode.on.net] has joined #wesnoth-dev 20110703 12:50:34< shadowmaster> so continuing on the "reason I care" rant; advertising missing features in --help is a bit evil 20110703 12:50:55< esr> shadowmaster: That change turned out to be easy. Detection logic and mainline fixes coming up in a few minutes. 20110703 12:55:30< CIA-85> esr * r50119 /trunk/data/ (17 files in 9 dirs): 20110703 12:55:30< CIA-85> Teach wmllint to detect missing side attribute in recruit, allow_recruit 20110703 12:55:30< CIA-85> and disallow_recruit. Fix all mainline instances of this glitch. 20110703 12:56:18< shadowmaster> zaroth_: oh, I see. The SDL_net/ANA backend switch is done at both the compiler and linker level by switching which set of object files gets compiled 20110703 12:56:57< shadowmaster> for ANA that's network_ana.o and network_amanager_ana.o instead of network.o which is used with SDL_net 20110703 12:57:56< zaroth_> hmm... so how can we detect which version are we using? 20110703 12:58:10< shadowmaster> it doesn't seem like their shared interface has any methods for exposing the compiled backend, though :( 20110703 12:58:17< shadowmaster> (yet) 20110703 12:59:12< esr> What is ANA? 20110703 13:00:59< shadowmaster> billynux's GSoC 2010 project, a new Boost.Asio based network backend to replace the inflexible[citation needed] and aging SDL_net backend 20110703 13:03:05-!- yenloc [~hhyloc@113.166.160.67] has joined #wesnoth-dev 20110703 13:03:10-!- hhyloc [~hhyloc@113.166.160.67] has quit [Ping timeout: 258 seconds] 20110703 13:05:30< esr> Ah. Siunds like a good thing. I think in general SDL is becoming an increasing drag on the project. 20110703 13:06:46< shadowmaster> yeah, but billynux disappeared and libana is too buggy for some uses (wesnothd and the built-in add-ons client, in particular) :( loonycyborg is working on a new Boost.Asio-based backend, though. 20110703 13:07:08< shadowmaster> esr: r50119 looks okay, but why did you decide against making wmllint automatically fix those cases? 20110703 13:07:30< shadowmaster> ah, nvm. I can guess that one. 20110703 13:07:46< shadowmaster> after all, one can forget to add side= in new code too 20110703 13:09:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20110703 13:16:29< esr> shadowmaster: Yes. Also, for missing-attribute cases detection is easy but fixing is somewhat difficult - can't be done with the sort of regexp-bashing wmllint mostly leans on. 20110703 13:22:10-!- admiralbumblebee [~Adium@cpe-173-171-233-235.tampabay.res.rr.com] has joined #wesnoth-dev 20110703 13:22:41-!- admiralbumblebee [~Adium@cpe-173-171-233-235.tampabay.res.rr.com] has left #wesnoth-dev [] 20110703 13:29:31-!- Sytyi [~sytyi@203-107-112-92.pool.ukrtel.net] has quit [Read error: Connection reset by peer] 20110703 13:35:40-!- Sytyi [~sytyi@203-107-112-92.pool.ukrtel.net] has joined #wesnoth-dev 20110703 13:36:01-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds] 20110703 13:38:45-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Ping timeout: 260 seconds] 20110703 13:43:22-!- timotei [~timotei@193.34.190.70] has joined #wesnoth-dev 20110703 13:43:22-!- timotei [~timotei@193.34.190.70] has quit [Changing host] 20110703 13:43:22-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20110703 13:50:23-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Ping timeout: 240 seconds] 20110703 14:04:56-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has joined #wesnoth-dev 20110703 14:42:48-!- yenloc [~hhyloc@113.166.160.67] has quit [Ping timeout: 240 seconds] 20110703 14:43:41-!- grzywacz [~grzywacz@89-78-52-133.dynamic.chello.pl] has joined #wesnoth-dev 20110703 14:43:41-!- grzywacz [~grzywacz@89-78-52-133.dynamic.chello.pl] has quit [Changing host] 20110703 14:43:41-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev 20110703 15:02:29-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20110703 15:14:11< Sytyi> Anybody know - people from Russian i10n team visit irc channels, and what channels, if yes? 20110703 15:18:36< loonycyborg> They're mostly on the forums in appropriate thread. 20110703 15:19:25< loonycyborg> http://forums.wesnoth.org/viewtopic.php?f=7&t=964&start=375 20110703 15:25:19< Sytyi> loonycyborg: Thanks. 20110703 15:28:57< CIA-85> ivanovic * r50120 /trunk/ (5 files in 4 dirs): updated Estonian translation 20110703 15:29:04< CIA-85> ivanovic * r50121 /branches/1.8/ (5 files in 4 dirs): updated Estonian translation 20110703 15:29:36-!- Gallaecio [~quassel@zla02.domus.cz] has quit [Ping timeout: 255 seconds] 20110703 16:02:01-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20110703 16:02:14< mordante> servus 20110703 16:04:20< Sytyi> mordante: hi 20110703 16:04:25< mordante> hi Sytyi 20110703 16:04:32< mordante> Sytyi, how are things going? 20110703 16:05:01< mordante> cjhopman there is a click dismiss property, which AFAIK works both in- and outside a dialog 20110703 16:05:26< Sytyi> mordante: currently now I am writing initilization of validator tool . 20110703 16:06:09< Sytyi> mordante: reading schema config fiel 20110703 16:06:15< mordante> ok good and how is that going? 20110703 16:06:54< Sytyi> mordante: I've got the idea, so it will be finished soon. 20110703 16:07:02-!- mjs-de [~mjs-de@f053188111.adsl.alicedsl.de] has joined #wesnoth-dev 20110703 16:07:50< mordante> Sytyi, btw still reading the log, running into your questions now 20110703 16:08:27< mordante> Sytyi, how makes a stand-alone tool making testing the validation easier? 20110703 16:08:38< Sytyi> mordante: Yes, and great 20110703 16:08:56< mordante> Sytyi, the question was how does it make it easier? 20110703 16:09:20< mordante> the validation only needs to be done when reading a cfg, once read it's expected to be validated 20110703 16:10:27< mordante> what do you mean with the question yesterday at 13:42? 20110703 16:10:46< Sytyi> mordante: I see. So if it is inside reading (I suppose game_config::read(config &, stream&)). no need in stand alone util 20110703 16:11:05< mordante> no 20110703 16:11:28< mordante> that was never my vision, I know some other devs liked that idea, but for GSoC the goal is to have in in the game 20110703 16:11:46< mordante> a stand-alone tool could be written if there's time left 20110703 16:12:32-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev 20110703 16:12:33-!- Upth is now known as Upthorn 20110703 16:13:00< Sytyi> mordante: I wanted to write validation of already read config object, like a fuction called on it. And then stand alone tool would help me to debug it. 20110703 16:14:21< mordante> but validation should happen during the reading, it can be done after reading, but the read function needs to do it 20110703 16:14:38< mordante> so either itself or by calling a function after the real reading 20110703 16:15:07< Sytyi> mordante: about that question : I have class_tag in SG tool. I need the same object in V-r tool. What will be better - extend it with new methods, write a new class or use existing as a parent 20110703 16:16:14< Sytyi> mordante: So if a variant to call validation after all reading is possible - i want to write standalone util, call tha validation after read(...) 20110703 16:16:31< Sytyi> and when task done - call it inside read( ...) 20110703 16:17:06-!- bodom [~quassel@2001:470:1f0b:ac0::2] has joined #wesnoth-dev 20110703 16:17:28< Sytyi> mordante: about class_tag - I prefer inheritance - the SG tag wont be ruined, and all changes will be implemented 20110703 16:17:34< mordante> Sytyi, I tend to think using the class_tag as parent might be the best, however not sure how much extra functions it needs 20110703 16:18:00< Sytyi> mordante: a few reading from config methods 20110703 16:18:14< mordante> Sytyi, the main goal for GSoC is to have the validation in the engine, not a stand-alone tool 20110703 16:18:23< mordante> so I prefer that we focus on that part first 20110703 16:18:51< Sytyi> mordante: I think it doesnot matter where to call validation FOR TESTING. 20110703 16:19:19< Sytyi> and it will be called inside read(...) AFTER testing 20110703 16:20:04< mordante> for testing it indeed doesn't matter, I just want to make clear what the goals for GSoC are 20110703 16:20:28< Sytyi> ok. It will be inside read(...) for sure. 20110703 16:20:38< mordante> ok 20110703 16:20:48< Sytyi> but first (prototype ) will be outside 20110703 16:21:36< mordante> that's fine by me, just make sure that you don't spend too much time on the stand-alone tool outside the prototyping part 20110703 16:22:07-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20110703 16:22:33< Sytyi> mordante: Got. 20110703 16:23:31< Sytyi> mordante: Also I'm thinking about a few levels of strictness, and I'd rather disccuss it with you 20110703 16:23:59< Sytyi> mordante: I.E. 0 - leave everything as it is. 20110703 16:24:22< Sytyi> 1 - change wrong key values to default 20110703 16:24:48< Sytyi> 2 - not allow keys and tags, that havent been mentioned in schema 20110703 16:25:30-!- atomicbomb [~quassel@61.94.183.20] has quit [Quit: (very) tired] 20110703 16:25:36< Sytyi> 3 - not allow even top-level tags and there children , if they are not mentioned. 20110703 16:25:56< Sytyi> and offcourse -silent mode, and warning-on mode 20110703 16:26:57< mordante> I think 1 might be tricky if there's no default 20110703 16:27:20< mordante> I think 2 looks fine, maybe even allow as switch for a schema key 20110703 16:28:01< mordante> I think 2 and 3 are about the same 20110703 16:28:17< Sytyi> mordante: Now we have annotated only [gui] 20110703 16:28:38< mordante> true 20110703 16:29:08< mordante> but I think attaching a schema to the read function itself should be optional 20110703 16:29:17< mordante> at least until everything has a schema 20110703 16:29:38< mordante> shadowmaster, do you have an example of your multi_page issue? 20110703 16:30:03< Sytyi> mordante: level 2 allow work with [gui] and [scenario] and will strictly validate [gui] children 20110703 16:30:17< Sytyi> even if [scenario] not in schema 20110703 16:31:05< Sytyi> mordante: Strict level - is that optional 20110703 16:31:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20110703 16:31:29< mordante> true, but for now gui is a toplevel item and don't expect that to change 20110703 16:31:47< mordante> but I think merging option 2 and 3 in one item would be better 20110703 16:31:57< mordante> and then allow that as option 20110703 16:32:04< Sytyi> mordante: ok. 20110703 16:32:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20110703 16:32:25< mordante> btw Sytyi how is it going with the documentation? 20110703 16:33:13< Sytyi> mordante: Later we can change read (cfg, stream ) to read(cfg,stream,level_of_validation = 0) and suppose everything working. 20110703 16:34:01< Sytyi> mordante: If documentation includes only wiki page, and doxygen comments - then I need only update things about {super="tag"} 20110703 16:34:24< Sytyi> mordante: if anything else - let me know, please. 20110703 16:35:18< mordante> Sytyi, just FYI we use NULL instead of 0 for NULL-pointers 20110703 16:35:49< Sytyi> aaaaaaaaaa ? level is int 20110703 16:35:52-!- Rose is now known as Cookie 20110703 16:36:18< mordante> Sytyi, sorry I misread, but in that case rather an enum ;-) 20110703 16:36:30< Sytyi> mordante: yes, offcourse. 20110703 16:36:36< mordante> but the read function also needs a parameter for which schema to read 20110703 16:36:42-!- Cookie [~quassel@unaffiliated/cookiee] has quit [Read error: Connection reset by peer] 20110703 16:36:51< Sytyi> mordante: :-( 20110703 16:36:58< mordante> ? 20110703 16:37:29< mordante> how does the read function else know which schema to read? 20110703 16:37:40< Sytyi> mordante: forgot. that 20110703 16:37:46< mordante> ah ok 20110703 16:38:52< Sytyi> mordante: we can use either stream, cfg object, validator object, or filename as argument 20110703 16:39:14< Sytyi> and from that point of view maybe pointer to validator object 20110703 16:39:47< Sytyi> we can even use a fucntion template to let other devs write their own validators 20110703 16:39:48< mordante> do you already have a structure for the validator object? 20110703 16:40:13< mordante> regarding the documentation, I also like some higher level view on how things work 20110703 16:40:48< mordante> how do classes interact, what are the external 'api' calls etc. etc. 20110703 16:41:50< Sytyi> writing it now(validator). As for me , it will have public validate(), public load_schema and maybe a log output. 20110703 16:43:03< Sytyi> mordante: got the idea 20110703 16:43:07< mordante> ok good 20110703 16:43:28< mordante> do you have a preference where to write it in? 20110703 16:43:49< Sytyi> no for now. What want you to advice ?? 20110703 16:43:51< mordante> maybe that validate() call needs the validation_level 20110703 16:43:58< Sytyi> yes 20110703 16:43:59< mordante> do you know LaTeX? 20110703 16:44:09< Sytyi> not fot now, but I can try 20110703 16:44:14< Sytyi> *for 20110703 16:44:28< Sytyi> I 've got what you want. 20110703 16:44:50< Sytyi> yoy are already writing doc about GUI 20110703 16:45:52< mordante> exactly 20110703 16:46:04< mordante> the other option is to write it in Doxygen 20110703 16:46:32< mordante> eg http://devdocs.wesnoth.org/gui2_iterator.html 20110703 16:47:43< Sytyi> what are the utils to work with LaTeX 20110703 16:48:04< mordante> I use vim+pdflatex 20110703 16:48:23< mordante> but there are some other tools as well, but I just like the command line 20110703 16:48:44< Sytyi> and from console they are? 20110703 16:48:52< loonycyborg> mordante: I'll need to make the new network transmission dialog and thus new network subsystem used by default soon. 20110703 16:49:10< loonycyborg> Since maintaining it as gui2 specific will become a PITA. 20110703 16:49:21< mordante> from the console pdflatex is the tool 20110703 16:49:27< loonycyborg> Due to layout of addon manager code. 20110703 16:49:52< Sytyi> ok, I will try to found it in reps. 20110703 16:49:59< mordante> loonycyborg, well if your system works better as SDL_Net and ANA I've no problem with it :-) 20110703 16:50:05< loonycyborg> So I'd appreciate some more testing/feedback from somebody else than me. 20110703 16:50:10< mordante> Sytyi, the texlive package contains most things you need 20110703 16:50:20< Sytyi> thanks a lot. 20110703 16:50:33< mordante> loonycyborg, on the dialog or dialog+network stuff 20110703 16:50:34< mordante> ? 20110703 16:50:46< loonycyborg> On the dialog mainly. 20110703 16:51:07-!- anonymissimus [~chatzilla@HSI-KBW-095-208-215-104.hsi5.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20110703 16:51:40< mordante> loonycyborg, I can try to review it later today, still have some reviews of Sytyi pending 20110703 16:51:47< loonycyborg> kk 20110703 16:52:04< Sytyi> mordante: There are a two line change in patch. 20110703 16:52:23< mordante> Sytyi, in which one? 20110703 16:52:44< anonymissimus> Esr, shadowmaster : why did you not apply http://gna.org/patch/?2666 and make revision 50118 and 50119 instead ? since there 20110703 16:52:59< Sytyi> mordante: there are last version on patches.gna.org 20110703 16:53:05< anonymissimus> is no reply I need to assume you forgot it 20110703 16:53:27< mordante> Sytyi, I meant in which patch ;-) 20110703 16:53:56< Sytyi> in SG tool. The annotations will take much more time :( 20110703 16:54:06< mordante> ok 20110703 16:54:27< anonymissimus> and the three tags are way not all cases, you missed quite a few (but there's no need to undo any of the wml changes) 20110703 17:03:00< anonymissimus> shadowmaster: well no I told esr but he let the patch linger around :P 20110703 17:05:47< Sytyi> mordante: Where shall I place my LaTeX documentation, if I choose that. 20110703 17:10:58< mordante> Sytyi, somewhere in doc, maybe also in doc/design 20110703 17:11:33< Sytyi> mordante: Like a gui but with another name. 20110703 17:11:48< mordante> exactly 20110703 17:19:23-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20110703 17:22:09-!- negusnyul_ [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev 20110703 17:22:29-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Client Quit] 20110703 17:24:42-!- vjoe [~vjoe@a94-132-117-16.cpe.netcabo.pt] has joined #wesnoth-dev 20110703 17:25:15< Sytyi> mordante: Also I forgot to ask whether the toplevel [root] in schema.cfg is apropriate. Maybe schema will be better? and maybe it does not matter. 20110703 17:26:03-!- vcap [~vcap@AReims-551-1-92-163.w92-155.abo.wanadoo.fr] has quit [Read error: Operation timed out] 20110703 17:26:22-!- vcap [~vcap@AReims-551-1-92-163.w92-155.abo.wanadoo.fr] has joined #wesnoth-dev 20110703 17:28:27-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Ping timeout: 240 seconds] 20110703 17:30:53-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20110703 17:31:02-!- negusnyul_ [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection] 20110703 17:31:24-!- negusnyul_ [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev 20110703 17:38:08-!- bodom [~quassel@2001:470:1f0b:ac0::2] has quit [Read error: No route to host] 20110703 17:41:50< anonymissimus> mordante: is there a way to enable/disable gui2 meny items, such as greying out a slider ? 20110703 17:42:18< anonymissimus> nto menu items, widgets in general 20110703 17:43:10-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20110703 17:47:13< anonymissimus> tcontrol::set_active ? 20110703 17:53:46-!- hhyloc [~hhyloc@113.166.154.90] has joined #wesnoth-dev 20110703 17:55:38-!- monochromatic [~monochrom@pool-74-109-69-108.phlapa.east.verizon.net] has joined #wesnoth-dev 20110703 17:58:23-!- vjoe [~vjoe@a94-132-117-16.cpe.netcabo.pt] has quit [Quit: leaving] 20110703 17:59:04-!- Sytyi [~sytyi@203-107-112-92.pool.ukrtel.net] has quit [Ping timeout: 244 seconds] 20110703 18:01:09-!- tschmitz [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev 20110703 18:01:48-!- hhyloc [~hhyloc@113.166.154.90] has quit [Read error: Connection reset by peer] 20110703 18:08:33-!- Sytyi [~sytyi@232-68-133-95.pool.ukrtel.net] has joined #wesnoth-dev 20110703 18:08:36-!- tschmitz_ [626cdb95@gateway/web/freenode/ip.98.108.219.149] has joined #wesnoth-dev 20110703 18:09:19-!- Exasperation [4a47319b@gateway/web/freenode/ip.74.71.49.155] has joined #wesnoth-dev 20110703 18:14:04< Exasperation> mordante: I've been looking at gui2 stuff recently, and submitted a few patches. Most of them are just exposing gui2 functions through Lua, but one in particular isn't, and I would appreciate it if you took a look at it. It's patch #2760. 20110703 18:18:56-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 260 seconds] 20110703 18:24:02< mordante> Sytyi, I think the root item needs to describe the contents, so maybe gui should be the top level item 20110703 18:24:11< mordante> or something like wml_schema 20110703 18:24:39< mordante> but since we use WML and not XML I think [gui] would be a nice top level name 20110703 18:24:58< mordante> anonymissimus, indeed set_active does gray-out a widget 20110703 18:25:15< mordante> Exasperation, I hope to have time to look today, but have some other patches to review 20110703 18:25:16< Sytyi> and as far as root has nothing about him , the top level tags can be exact sons of [gui] 20110703 18:25:35< Exasperation> ok, no hurry 20110703 18:25:48< mordante> Sytyi, sorry failed to parse that sentence 20110703 18:26:54< Sytyi> [wml_schema] [gui] [...] [/gui] [/wml_schema] 20110703 18:27:29< mordante> yeah that looks fine 20110703 18:27:42< Sytyi> root is just a container of toplevel tags, We can use a wml_schema to be both container and toplevel 20110703 18:28:16< mordante> ah ok 20110703 18:29:00-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev 20110703 18:33:43< Sytyi> mordante: If you decide to commit that patch - then change please "root" to "wml_schema" at line 476 20110703 18:36:06< anonymissimus> Exasperation: well, you could make a patch for widget disabling using tcontrol:set_active then 20110703 18:36:45< anonymissimus> probably a wesnoth.something function this time, which can be used wesnoth.set_dialog_callback 20110703 18:37:21< Exasperation> Yeah, I mentioned planning on doing that at one point. I just got distracted by other things and haven't gotten to it. 20110703 18:38:09< mordante> Sytyi, ok 20110703 18:39:23< anonymissimus> ah and Exasperation before you create a patch make an svn update to the latest revision pls 20110703 18:39:30< Exasperation> I was thinking wesnoth.set_dialog_active(, ) or something along those lines; passing true sets to active, false sets to inactive 20110703 18:40:10< Exasperation> I do update to the latest SVN before I create patches... it's just been a few updates since I posted those 20110703 18:43:00< Exasperation> If you look, you'll see that the second version of patch #2760 is vs. 50044, while the third version is vs. 50111 20110703 18:43:21-!- LordNasty [~NaSTy@93-43-157-80.ip92.fastwebnet.it] has quit [Ping timeout: 264 seconds] 20110703 18:48:35-!- LordNasty [~NaSTy@93-43-157-80.ip92.fastwebnet.it] has joined #wesnoth-dev 20110703 18:57:52-!- zaroth__ [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev 20110703 18:58:21-!- zaroth_ [~zaroth@wesnoth/developer/zaroth] has quit [Ping timeout: 264 seconds] 20110703 19:18:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20110703 19:55:42< Sytyi> mordante: What does mean lines 27 28 in http://www.wesnoth.org/devdocs/window__builder_8hpp_source.html ? 20110703 20:00:06-!- deekay [~dk@wesnoth/developer/dragonking] has quit [Ping timeout: 276 seconds] 20110703 20:04:59-!- Gallaecio [~quassel@zla02.domus.cz] has joined #wesnoth-dev 20110703 20:07:42-!- Bob_The_Mighty [~chatzilla@cpc5-brig16-2-0-cust70.3-3.cable.virginmedia.com] has joined #wesnoth-dev 20110703 20:11:05-!- Shakey [HydraIRC@c-24-1-105-76.hsd1.il.comcast.net] has joined #wesnoth-dev 20110703 20:14:13-!- timotei [~timotei@193.34.190.70] has joined #wesnoth-dev 20110703 20:14:13-!- timotei [~timotei@193.34.190.70] has quit [Changing host] 20110703 20:14:13-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20110703 20:20:22< Espreon> mordante: Hello. Would you like to test that insertion stuff today? 20110703 20:22:07< anonymissimus> Espreon: "insertion stuff" ? 20110703 20:22:58< anonymissimus> mordante is busy^^ 20110703 20:23:14< anonymissimus> everyone os bothering him 20110703 20:23:37< Espreon> anonymissimus: The stuff I speak of puts translations from WesCamp into addons on the addon server. 20110703 20:27:24< mordante> Sytyi, these lines declare a class, when a function only needs to know something is a class you can declare it like that 20110703 20:27:58< mordante> Sytyi, for example line 50 needs to know a config is a class, but not the details when passing a reference 20110703 20:28:20< mordante> this reduces the number of headers included and in turn avoids spreading headers over all files 20110703 20:28:51< mordante> Espreon, like anonymissimus said, I'm busy :-( still hope to find time later today... but not too much hope 20110703 20:29:58< Espreon> Sigh... OK... 20110703 20:30:02< anonymissimus> mordante: are you fine with me applying http://gna.org/patch/?2760 20110703 20:32:00< mordante> anonymissimus, like to review it first and have some other things to review first 20110703 20:39:03-!- Gallaecio [~quassel@zla02.domus.cz] has quit [Ping timeout: 240 seconds] 20110703 20:43:38< Sytyi> mordante: I'm trying to read from config object but I ve got next http://pastebin.com/2SXuF71Y . Line 6 confuses me mostly 20110703 20:51:17< mordante> Sytyi, did you have a look at src/serialization/preprocessor.hpp:29 20110703 20:51:17-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20110703 20:52:00< mordante> Sytyi, and can you paste tools/validator/tag.hpp:34 ? 20110703 20:52:22< mordante> I assume it's line 19 in the pastebin, but want to be sure 20110703 20:53:00< Sytyi> mordante: you're right 20110703 20:53:52< mordante> Sytyi, for the line »void read(const config & s){« the compiler only needs to know config is a class 20110703 20:54:37< Sytyi> mordante: and I need to write class config; 20110703 20:54:52< mordante> for the line »s.empty()« it needs to know that config has a function »some_return_type empty()« 20110703 20:55:21< mordante> the header preprocessor.hpp already provides the line »class config;« 20110703 20:55:51< mordante> so at the first line an incomplete type is valid for the empty() a complete type is required 20110703 20:56:07< mordante> so you need to include config.hpp 20110703 20:58:44< Sytyi> mordante: thanks a lot. I tried, "class config;" but it didnt help. 20110703 20:59:14< mordante> no that wouldn't help the preprocessor.hpp already did that part ;-) 20110703 21:01:08< Sytyi> mordante: And define HAVE_CONFIG_H somewhere probavly could help, too ? 20110703 21:01:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 255 seconds] 20110703 21:01:39< Sytyi> mordante: no, could nt 20110703 21:01:40< mordante> not sure what that define does 20110703 21:02:06< Sytyi> it includes config.h and there are only a list of defines. 20110703 21:03:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20110703 21:05:42-!- Sytyi [~sytyi@232-68-133-95.pool.ukrtel.net] has quit [Quit: Leaving.] 20110703 21:06:38-!- Sytyi [~sytyi@232-68-133-95.pool.ukrtel.net] has joined #wesnoth-dev 20110703 21:10:01-!- Gallaecio [~quassel@zla02.domus.cz] has joined #wesnoth-dev 20110703 21:15:47-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20110703 21:17:00-!- alkenrinnstet [~alkenrinn@bb121-6-177-142.singnet.com.sg] has quit [Quit: Leaving.] 20110703 21:22:01< Exasperation> anonymissimus: patch for wesnoth.set_dialog_active is submitted 20110703 21:26:10< anonymissimus> Exasperation: checkboolean probably 20110703 21:26:18< anonymissimus> not toboolean 20110703 21:30:27< anonymissimus> and why gettop ? 20110703 21:30:51< anonymissimus> 2 20110703 21:31:31< Exasperation> I'm not sure about that... toboolean is used pretty consistently throughout scripting/lua.cpp 20110703 21:36:42< Exasperation> gettop bacause I was trying to make the behavior consistent with existing code 20110703 21:39:46< Exasperation> checkboolean doesn't even seem to exist 20110703 21:41:01< anonymissimus> yes, use isboolean 20110703 21:41:35< anonymissimus> if someone forgets to specify the first argument therea a wrong error message otherwise 20110703 21:42:30< anonymissimus> well, is there a intf_function where gettop is used to access the arguments 20110703 21:44:01-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has joined #wesnoth-dev 20110703 21:44:01-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has quit [Changing host] 20110703 21:44:01-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev 20110703 21:44:28< anonymissimus> usually there are simple integers used so that the error messages one gets are correct 20110703 21:44:36< Exasperation> All of the existing "unsupported widget" errors use gettop in the same fashion 20110703 21:44:58< anonymissimus> if you use gettop and the lua coder passed additional arguments (after the documented ones) you egt a wrong index 20110703 21:46:08< Exasperation> these functions take an arbitrary number of arguments; all the ones after the nth are part of the path to the widget 20110703 21:46:25< Exasperation> (n can vary depending on the function) 20110703 21:48:31< Exasperation> if we get to this particular error, we have successfully found *some* widget using all of the passed arguments 20110703 21:49:11< Exasperation> otherwise there would have been an error thrown by find_widget 20110703 21:54:23< anonymissimus> ok yes gettop is fine; one needs a testcase like the one in the wiki wesnoth.set_value(_"Hello world", "foo", 7, "bar") 20110703 21:54:46< anonymissimus> for me it worked with only 1 argument so far, it found the widget even if nested 20110703 21:55:12< anonymissimus> maybe if the names are all unique 20110703 21:55:15-!- zookeeper [~l@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20110703 21:55:48< anonymissimus> and otherwise it can find a wrong one 20110703 21:57:03-!- mjs-de [~mjs-de@f053188111.adsl.alicedsl.de] has quit [Ping timeout: 255 seconds] 20110703 21:57:17-!- negusnyul_ [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection] 20110703 21:57:54< mordante> Sytyi, did you manually modify the latest patch? It's broken :-( 20110703 21:58:30< mordante> Sytyi, could you post a fixed one including the wml_schema change we discussed today? 20110703 21:58:54< Sytyi> mordante: yes 20110703 21:59:15< Sytyi> mordante: How Can I remove unnesessary files from patch? 20110703 21:59:42< mordante> Sytyi, by doing svn di and then select the wanted files 20110703 22:00:16< Sytyi> mordante: just remove them from file? 20110703 22:00:21< anonymissimus> Exasperation: ok well it seems silene did go for "if it's not actually a boolean just convert it silently" as far as booleans passed to the engine are concerned 20110703 22:00:48< anonymissimus> then we follow that too :P 20110703 22:00:56< Exasperation> yeah, that seems to be the standard way things are handled as booleans in the Lua engine 20110703 22:01:40< mordante> Sytyi, no instead of doing just »svn di« do »svn di list_of_files_to_add_to_the_patch« 20110703 22:01:42< anonymissimus> so if it gets a string referring to a widget it won't complain about it but call it "true" instead 20110703 22:02:27< mordante> anonymissimus, actually implicit conversion is rather ugly, does this also convert random strings? 20110703 22:03:46< anonymissimus> random strings ? if i understand yes; in lua everything except nil and false itsself are "casted" to true 20110703 22:04:03-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds] 20110703 22:07:34< Sytyi> mordante: done. I'll remember that fo future. 20110703 22:07:44< Exasperation> yeah, that's my understanding as well 20110703 22:09:42< anonymissimus> yeah, to_boolean casts strigs to true 20110703 22:10:35< anonymissimus> I guess the logic is to mimick the behavior of lua itsslef 20110703 22:11:33< anonymissimus> if you do ("some_string" and true) in lua that becomes true; the wesnoth.something functions shall behave the same was 20110703 22:11:40< anonymissimus> way 20110703 22:11:57< anonymissimus> now if we change that into checks for an actual boolean type it may break UMC 20110703 22:12:41< anonymissimus> if someone is passing not an actual boolean to such a function in his UMC and expects it to be casted 20110703 22:13:15< anonymissimus> so I guess we betetr follow the way it is 20110703 22:14:07< Exasperation> yeah, neither choice is perfect here 20110703 22:15:29< anonymissimus> well at least I understand a good reason now to allow implicit conversions here :) 20110703 22:16:01< Exasperation> and knowing is half the battle? 20110703 22:17:04< anonymissimus> it is everything 20110703 22:17:34< anonymissimus> really, I'm going crazy trying to understand each an every consequence of changes I attempt 20110703 22:19:30< Exasperation> yeah, I feel that way sometimes when I'm trying to follow the documentation and figure out what things are supposed to do 20110703 22:22:13< anonymissimus> damn did google change their website ? there were these nice links to language tools and advanced search, I miss them 20110703 22:29:09< Exasperation> click on the little gear in the upper right corner; that's where they seem to have gone 20110703 22:29:29< Exasperation> less convenient, though 20110703 22:35:32< shadowmaster> mordante: yes, but it's in a branch. If you want I can give you a patch to apply on top of trunk. 20110703 22:35:46< shadowmaster> mordante: although you mean stacked_widget, not multi_page 20110703 22:35:49-!- Johannes13 [~Johannes@p5DF75CF5.dip.t-dialin.net] has joined #wesnoth-dev 20110703 22:35:49-!- Johannes13 [~Johannes@p5DF75CF5.dip.t-dialin.net] has quit [Changing host] 20110703 22:35:49-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20110703 22:36:08< mordante> shadowmaster, a patch would be fine, then I can have a look 20110703 22:37:15-!- Johannes13_ [~Johannes@p5DF75CF5.dip.t-dialin.net] has joined #wesnoth-dev 20110703 22:37:15< shadowmaster> anonymissimus: why didn't you apply that patch instead? :p 20110703 22:37:16-!- Johannes13_ [~Johannes@p5DF75CF5.dip.t-dialin.net] has quit [Changing host] 20110703 22:37:16-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20110703 22:37:43< shadowmaster> it looks like you still should apply the rest of the patch 20110703 22:38:36< mordante> Sytyi, did you compile test your patch? 20110703 22:38:46< shadowmaster> now, leaving that unsolved for a couple of development versions sounds like laziness to me both on part of the assigned developer and the patch submitter 20110703 22:39:36< Sytyi> mordante: I did svn di from working copy. and it works for me. Any problems? 20110703 22:39:58< mordante> Sytyi, it doesn't compile 20110703 22:40:17< mordante> at least not with -Werror, which is the default in Wesnoth 20110703 22:41:18-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 276 seconds] 20110703 22:41:25-!- mjs-de [~mjs-de@f053188111.adsl.alicedsl.de] has joined #wesnoth-dev 20110703 22:41:28< shadowmaster> with cmake, not scons 20110703 22:43:21< shadowmaster> mordante: http://pastebin.com/TD1ii5kQ . Should apply on top of HEAD and to see what I mean you have to start wesnoth with --new-widgets, go into Preferences and try the button in every page. You'll notice that it looks like only the last page's button captures events even when invisible 20110703 22:43:28-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20110703 22:44:26< shadowmaster> notice the tooltip at the bottom of the screen 20110703 22:44:30< Sytyi> mordante: strange. 20110703 22:45:11-!- monochromatic [~monochrom@pool-74-109-69-108.phlapa.east.verizon.net] has quit [Read error: Connection reset by peer] 20110703 22:45:14-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20110703 22:45:30-!- monochromatic [~monochrom@pool-74-109-69-108.phlapa.east.verizon.net] has joined #wesnoth-dev 20110703 22:46:21-!- Appleman1234 [~Appleman1@CPE-60-226-179-130.qld.bigpond.net.au] has quit [Remote host closed the connection] 20110703 22:48:37< anonymissimus> shadowmaster: well I dont want to interfere with esr's area of reponsibility 20110703 22:49:00< anonymissimus> strange enought that he apparently forgot that patch (and that I told him about it) 20110703 22:49:21-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds] 20110703 22:50:10< anonymissimus> and you forgot it too btw; since I asked you to apply it too, but you didnt want to since it "was not trivial" 20110703 22:50:30< shadowmaster> python crap is not trivial for me, period 20110703 22:51:24< shadowmaster> the most I am able to apply are simple replacement rules like @campaigns -> ~addons 20110703 22:51:39< shadowmaster> or path replacement rules 20110703 22:54:03< Sytyi> mordante: How can I reproduce your errors ? 20110703 22:54:17< Sytyi> mordante: * errors appered at you 20110703 22:55:24< mordante> shadowmaster, the stacked_widget is not meant to be used like that, the multi_page is 20110703 22:55:48< Sytyi> mordante: I compiled with ENABLE_STRICT_COMPILATION = ON 20110703 22:56:43< mordante> Sytyi, »src/tools/schema/tag.cpp:93: error: comparison is always true due to limited range of data type« 20110703 22:59:10< shadowmaster> mordante: I imagine it's not _meant_ to be used like that, but multi_page doesn't trivially allow pages with different grid definitions; as far as Exasperation and I found, the only possible way to do that would be generating and inserting extra grid data in the dialog's C++, something that doesn't sound attractive to me considering that GUI2's internal interfaces tend to change every once in a while. Adding WML support for ... 20110703 22:59:16< shadowmaster> ... that would involve messing with the widget code, something I'm not quite ready to do myself either. 20110703 22:59:29< shadowmaster> stacked_widget allows different grids that can be toggled as you can see. 20110703 23:00:08-!- Crendgrim [~crend@77-22-254-233-dynip.superkabel.de] has quit [Quit: zzz] 20110703 23:00:43< shadowmaster> Sytyi, mordante : perhaps that warning is generated only by newer versions of g++ 20110703 23:00:53< mordante> shadowmaster, true, but not everything in gui2 is ready yet :-( 20110703 23:01:17< mordante> but the stacked_widget is not meant for this task, the multi_page will be at some point 20110703 23:02:01< shadowmaster> well, I suppose I'll abandon that branch for now then 20110703 23:04:06< mordante> hope to find time to fix it, but there's quite a lot of things to be done for gui2 still 20110703 23:04:15< mordante> anyway I'm off now night 20110703 23:04:37-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20110703 23:07:29< Sytyi> cool. Comparison with std::string::npos can generate warnings and it depends on the platform. :-( 20110703 23:15:10< shadowmaster> Sytyi: where's that patch btw? 20110703 23:16:17< Sytyi> shadowmaster: gna.org/patch/?2636. I think i find the solution 20110703 23:17:12< shadowmaster> yes, use size_t or std::string::size_type (which is usually (always?) compatible with size_t AFAIK) 20110703 23:20:20< Sytyi> shadowmaster: Thanks . 20110703 23:20:56< Sytyi> bye 20110703 23:22:19-!- Sytyi [~sytyi@232-68-133-95.pool.ukrtel.net] has quit [Quit: Leaving.] 20110703 23:26:28-!- wesbot changed the topic of #wesnoth-dev to: 220 bugs, 321 feature requests, 30 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20110703 23:27:02-!- zookeeper [~l@wesnoth/developer/zookeeper] has quit [] 20110703 23:28:21-!- zaroth__ [~zaroth@wesnoth/developer/zaroth] has quit [Read error: Operation timed out] 20110703 23:30:35-!- zaroth__ [~zaroth@wesnoth/developer/zaroth] has joined #wesnoth-dev 20110703 23:30:44-!- Exasperation [4a47319b@gateway/web/freenode/ip.74.71.49.155] has quit [Quit: Page closed] 20110703 23:33:21-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 260 seconds] 20110703 23:41:04-!- A_Guy [~chatzilla@cpe-74-72-253-74.nyc.res.rr.com] has joined #wesnoth-dev 20110703 23:41:12< A_Guy> Maybe the people here will speak to me. 20110703 23:49:26-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20110703 23:52:25< CIA-85> shadowmaster * r50122 /trunk/changelog: Update changelog for r50119 20110703 23:55:06< CIA-85> shadowmaster * r50123 /trunk/config/ (config.rpath mkinstalldirs): Remove left-overs of the autotools build system 20110703 23:56:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20110703 23:56:33-!- Blueblaze [~Blueblaze@adsl-99-182-55-50.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev --- Log closed Mon Jul 04 00:00:59 2011