--- Log opened Thu Aug 11 00:00:12 2011
20110811 00:01:54-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20110811 00:03:35-!- deekay [~dk@wesnoth/developer/dragonking] has quit [Quit: deekay]
20110811 00:07:29< anonymissimus> zookeeper, Espreon : what wouldnt be fine about duration= being misclick protection via minimum time ?
20110811 00:11:05< Crab_> anonymissimus: what if someone reads faster ? 1 duration= doesn't cover both use cases, I think
20110811 00:11:53< anonymissimus> sure, but thats nto the question
20110811 00:13:26< CIA-57> sytyi * r50688 /trunk/src/serialization/ (schema_validator.cpp schema_validator.hpp): Initial realization of validation. No changes to CMakeLists yet, need to talk with mordante about priniting error messages.
20110811 00:13:39< Crab_> ok
20110811 00:16:00< Espreon> anonymissimus: He just said he thinks that misclick protection shouldn't be done in WML.
20110811 00:16:18< Espreon> Well, as a key at least.
20110811 00:17:41< anonymissimus> well, how would it be done ? the wml code can better know whether it is likely that the user hits the mouse button quickly after an event fires
20110811 00:18:20< Espreon> How should I know?
20110811 00:18:33< Espreon> If you want a misclick protection key, then there can be one.
20110811 00:18:45< anonymissimus> other than that we'd need to find the first [message] in an event and how fast it comes after the event start
20110811 00:23:31< CIA-57> sytyi * r50689 /trunk/src/serialization/schema_validator.cpp: Forgot to change the log.
20110811 00:25:16-!- sytyi [~sytyi@147-121-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20110811 00:26:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 276 seconds]
20110811 00:26:45< specing> I also have multiplayer problems
20110811 00:27:06< specing> It appears to go into an infinite loop after loading the multiplayer screen
20110811 00:28:19< Espreon> Which version?
20110811 00:29:00< specing> 1.8.6
20110811 00:30:50< Espreon> Hmmm, then I have no ideas.
20110811 00:37:53< specing> Now it worked
20110811 00:38:22< specing> Sometimes it works, sometimes it doesent
20110811 00:47:46-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: ...]
20110811 00:54:15< anonymissimus> Crab_: how many "tasks" do you have assigned to you ? :P
20110811 00:54:46< anonymissimus> I would like to see me fixing the problems around the sighted event at some day
20110811 00:55:18< anonymissimus> I know you have several related bugs assigned to you
20110811 00:55:23< shadowmaster> Crab_: you are still moving IIRC?
20110811 01:00:15< CIA-57> anonymissimus * r50690 /trunk/projectfiles/VC9/wesnoth.vcproj: MSVC projectfile update
20110811 01:00:36< CIA-57> anonymissimus * r50691 /trunk/projectfiles/CodeBlocks/wesnoth.cbp: cb projectfile update
20110811 01:00:37< CIA-57> anonymissimus * r50692 /trunk/src/game_events.cpp: emit a warning when attempting to advance a unit when unstoring to the recall list (fix for bug #17023)
20110811 01:03:13< Crab_> anonymissimus: a lot of tasks. sighted events will be fixed after/if the whiteboard gsoc would more-or-less finish, so delayed shroud updates would be safe to remove from code
20110811 01:03:49< Crab_> anonymissimus: so, those bugs are postponed till then.
20110811 01:04:25< Crab_> shadowmaster: yes, but at least today I've got a wesnoth checkout on a slightly newer laptop, which can compile a debug build in reasonable time
20110811 01:04:42< Crab_> and something is wrong with unit map, there're some strange segfaults around.
20110811 01:05:09< shadowmaster> Crab_: just wanted to remind you that the GUI2 MP match chat log needs to be forward-ported :)
20110811 01:05:21< Crab_> shadowmaster: noted
20110811 01:05:25< Crab_> like https://gna.org/bugs/index.php?18480 and https://gna.org/bugs/?18484
20110811 01:06:55< Crab_> in both cases the code is old and fairly innocent (doing stuff like foreach on unit map or some checking of unit map iterators)
20110811 01:07:35-!- Appleman1234 [~Appleman1@emerch3.lnk.telstra.net] has joined #wesnoth-dev
20110811 01:10:17< anonymissimus> Crab_: I put my hand *into the fire* that removing delayed_shroud_updates is *not* sufficient for fixing the sighted event
20110811 01:10:37< Crab_> anonymissimus: it's a prerequisite :)
20110811 01:11:19< anonymissimus> whats more, I definitely want delayed_shroud since the whiteboard is nto sufficient as a substitution and I am way not alone with this opinion
20110811 01:11:37< anonymissimus> ask shadowmaster for instance
20110811 01:11:49< Crab_> the whiteboard should have a mode to emulate DSU
20110811 01:12:09< Crab_> i think that it's possible and more important than any fancy multi-turn planning
20110811 01:12:17< anonymissimus> whats more, the whoteboard is more or less one of the most buggy areas of the engine atm
20110811 01:12:19< shadowmaster> the whiteboard is horribly complicated for me and I'm not sure I'll be able to learn to use it ever
20110811 01:12:47< Crab_> my point is: the whiteboard should have a mode to *emulate* the behavior of dsu, without any additional complexity
20110811 01:12:54< anonymissimus> about as buggy as sighted events and delayed shroud updates, so to say
20110811 01:13:45< Crab_> wesbot: bug 13256
20110811 01:13:45< wesbot> Bug #13256  Assigned to: Iurii Chernyi <crab>  Status: Postponed  Priority: 5 - Normal
20110811 01:13:48< wesbot> Summary: Assertion failure in  src/actions.cpp, happened when moved (12,8)-> (10,10)
20110811 01:13:51< wesbot> Original submission: Launched a test scenario, moved (12,8)-> (10,10)Happene
20110811 01:13:54< wesbot> d once, unable to reproduce so far.==./wesnoth-debug -d -t --log-debug=ai,
20110811 01:13:57< wesbot> URL: https://gna.org/bugs/?13256
20110811 01:14:02< Crab_> wesbot: bug 15600
20110811 01:14:03< wesbot> Bug #15600  Assigned to: Iurii Chernyi <crab>  Status: Postponed  Priority: 3 - Low
20110811 01:14:06< wesbot> Summary: Shroud updates which are part of apply_shroud_changes interfere with WML modifications to shroud
20110811 01:14:09< wesbot> Original submission: Sometimes it is needed to skip shroud updates which are p
20110811 01:14:12< wesbot> art of undo stack unwind.Example: teleport from one 'level' of map to anothe
20110811 01:14:15< wesbot> URL: https://gna.org/bugs/?15600
20110811 01:14:26< Crab_> wesbot: bug 14269
20110811 01:14:26< wesbot> Bug #14269  Assigned to: Iurii Chernyi <crab>  Status: Postponed  Priority: 5 - Normal
20110811 01:14:29< wesbot> Summary: name=sighted events not firing on enemy moves and affected by delay_shroud setting
20110811 01:14:32< wesbot> Original submission: This bug seems like it might be a regression (see bug #11
20110811 01:14:35< wesbot> 286 ), and depending on current policy, it may be moot (see the most recent comm
20110811 01:14:38< wesbot> URL: https://gna.org/bugs/?14269
20110811 01:15:37< Crab_> there's a lots of stuff related to DSU which from the engine point of view can be handled by the whiteboard much more nicely
20110811 01:16:05< anonymissimus> the whiteboard is too complicated in real mp
20110811 01:16:14< Crab_> that's the problem with the UI of whiteboard
20110811 01:16:37< Crab_> but there's no particular reason we can't have a 'DSU-emulation' using whiteboard as engine
20110811 01:17:05< anonymissimus> they ought to fix all theri bugs first in any case
20110811 01:17:07< Crab_> where you just move/undo/attack, as usual, but the actual unit_map modifications are handled by the whiteboard
20110811 01:17:25< anonymissimus> in its current state it's useless
20110811 01:18:17< Crab_> I hope they will fix the bugs. and note that dsu-emulation is somewhat simpler to get right than stuff like multi-turn planning 
20110811 01:19:08< anonymissimus> well bugs tend to not get fixed unfortunately
20110811 01:19:27< Crab_> I hope things will get better after gsoc
20110811 01:19:38< shadowmaster> *cough*
20110811 01:19:52< shadowmaster> *new* *cough* *lobby*
20110811 01:19:55< anonymissimus> see the units highlighting thing; I reported that bug almost a year ago
20110811 01:20:18< anonymissimus> wesbot: bug 16652
20110811 01:20:19< wesbot> Bug #16652  Assigned to: Gabriel M. <gabba>  Status: None  Priority: 4
20110811 01:20:22< wesbot> Summary: attackable units incorrectly highlighted
20110811 01:20:24< wesbot> Original submission: 
20110811 01:20:27< wesbot> URL: https://gna.org/bugs/?16652
20110811 01:20:31< Crab_> and src/whiteboard is only 5800+ lines, there's only a finite amount of bugs there :)
20110811 01:20:54< anonymissimus> it has effect even if whiteboard deactivated thats bad; btu feature continue to be implemented nevertheless
20110811 01:21:19< anonymissimus> and after GSoC those students tend to disappear but the bugs stay
20110811 01:21:29< Crab_> yeah. and, well, the current number of bugs is way too high
20110811 01:21:35< anonymissimus> hard to say but its true
20110811 01:21:49< anonymissimus> and it pisses me off
20110811 01:21:49-!- Johannes13_ [~Johannes@p4FDEDABB.dip.t-dialin.net] has joined #wesnoth-dev
20110811 01:21:49-!- Johannes13_ [~Johannes@p4FDEDABB.dip.t-dialin.net] has quit [Changing host]
20110811 01:21:49-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110811 01:21:50-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 252 seconds]
20110811 01:22:11< shadowmaster> *cough* libana*
20110811 01:22:20< anonymissimus> bugs first! if you know of a bug it has to be fixed before implementing anythign new thats what I propose
20110811 01:22:39< Crab_> shadowmaster: what's bad going on in libana, btw ?
20110811 01:22:51< Crab_> shadowmaster: I'm just not familiar or forgotten
20110811 01:23:23< shadowmaster> besides that the GSoC student that wrote it disappeared after the term before getting to stabilizing it?
20110811 01:23:33< Crab_> I mean, in terms of bugs
20110811 01:23:55-!- horon [~horon@nttkyo103205.tkyo.nt.adsl.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20110811 01:24:02< shadowmaster> I know that for me a libana-based wesnoth client was unable to report progress on campaignd uploads
20110811 01:24:39< shadowmaster> and apparently Soliton had to disable libana in the official builds used in the MP servers due to some crash that never got fixed
20110811 01:25:59< anonymissimus> well it seems loony did a good job now so it does no longer matter
20110811 01:26:01< shadowmaster> there's also one security vulnerability bug filed that only seems to affect libana builds
20110811 01:26:14< shadowmaster> anonymissimus: is his asio backend used[D already?
20110811 01:26:39< anonymissimus> afaik yes, the add download/upload uses it
20110811 01:26:47< anonymissimus> in trunk and 1.9.8
20110811 01:27:13< shadowmaster> I wonder if it supports IPv6 :)
20110811 01:28:07< shadowmaster> https://gna.org/bugs/?17099
20110811 01:28:26-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 260 seconds]
20110811 01:28:37< anonymissimus> also, I'm kind of sure that I would still not dare to start coding around the unit_map in wesnoth ;)
20110811 01:28:40< Espreon> I hope it'll support proxies... if that is desired.
20110811 01:28:58< anonymissimus> as opposed to some other new coder :)
20110811 01:29:03< shadowmaster> one of the features introduced with libana as I discussed with zaroth as the proxy options
20110811 01:29:08< shadowmaster> *was
20110811 01:29:46< Crab_> anonymissimus: well, if it's not fixed before next release, we should roll the unit map back.
20110811 01:29:58< Crab_> anonymissimus: but there's no particular reason to not try to make things faster 
20110811 01:30:25< anonymissimus> yes...but maybe it's best to undo all those modifications now and to let him work privately
20110811 01:30:36< anonymissimus> until he has a well tested patch
20110811 01:31:07< shadowmaster> anonymissimus: are you talking of the switch from an underlying ordered associative container to an unordered one?
20110811 01:31:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110811 01:32:24< anonymissimus> shadowmaster: well...since I only vaguely imagine what those are I better shut up
20110811 01:32:28< Crab_> anonymissimus: well, we help test it, actually :)
20110811 01:32:43< shadowmaster> anonymissimus: std::map to Boost's unordered_map :p
20110811 01:32:45< Crab_> shadowmaster: see the diff, there's a lot more fun going on there apart from the switch
20110811 01:34:01< shadowmaster> r50546, yes?
20110811 01:36:03< shadowmaster> there's a few code _format_ changes in that diff that makes it really hard to read
20110811 01:36:05< Crab_> r50674 as well
20110811 01:36:54< anonymissimus> wesbot: r50546
20110811 01:37:03< anonymissimus> wesbot: r 50546
20110811 01:37:03< shadowmaster> okay, now that looks scarily complex
20110811 01:37:07< Crab_> wesbot: log 50546
20110811 01:37:08< wesbot> boucman * r50546 : apply patch #2819 : Change unit_map to a faster implementation by thonsew
20110811 01:37:11< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=50546
20110811 01:37:22< Crab_> wesbot: log 50674
20110811 01:37:23< wesbot> thonsew * r50674 : Changed unit_map to not store invalidated iterators.Added incremental recovery of invalidated but reference counted unit_map::iterators.
20110811 01:37:26< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=50674
20110811 01:37:27< shadowmaster> (mainly because it talks about iterator implementations)
20110811 01:37:53< Crab_> it's more than that - note the 3rd map added
20110811 01:39:00< shadowmaster> either way, the problem with making people work with branches is precisely that: they get even less testers and therefore are prone to producing poorer output
20110811 01:39:41< shadowmaster> Wesnoth is not like Linux where there's at least one hundred active developers actively testing everything before releases
20110811 01:40:48< shadowmaster> (on the other hand, Linux is quite hostile to changes that advertise performance improvements at the cost of internal interface changes, so...)
20110811 01:41:01< anonymissimus> wesnoth has a lot of devs compared to similar projects it seems
20110811 01:42:15< shadowmaster> open source games tend to have smaller teams behind, yes (and I know one person who could write a whole essay on the subject :P)
20110811 01:42:42< Crab_> and his nickname ends in 'r' ? :)
20110811 01:42:50< shadowmaster> no
20110811 01:42:56< Crab_> ok :)
20110811 01:43:00< shadowmaster> it's more like an 'l'
20110811 01:47:19-!- o11c [~ben@74.85.42.110] has quit [Quit: vacation]
20110811 01:48:35< Crab_> anonymissimus: ok, looked around (on the whiteboard). I see that the way to get the sighted events more working than now is to implement that dsu emulation mode for the whiteboard myself first, and then cleanup the dsu code, and then recode the 'remove fog/shroud' stuff to be more predictive.
20110811 01:48:47< Crab_> and whiteboard is indeed not in good shape now
20110811 01:51:19< anonymissimus> i still think the player community will demand the old DSU
20110811 01:52:19< Crab_> will they see the difference ?
20110811 01:53:44< Crab_> the only difference between a proper DSU emulation via whiteboard and a DSU, is that dsu emulation does not trigger moveto events until the undo stack is unwinded (so, if there'are moveto events, some of the moves might be lost [or transferred to 'true' whiteboard moves] )
20110811 01:54:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110811 01:54:27< Crab_> so, in MP, the only difference would be the handling of ambush
20110811 01:55:23< anonymissimus> aha hm ok I vaguely understand the direction
20110811 01:55:44< Crab_> basically, why whiteboard engine is better - because it doesn't touch the real unit_map unit we commit
20110811 01:55:58< Crab_> but the UI sucks, more or less, for most people I've talked to.
20110811 01:56:12< Crab_> but we can use the DSU UI with the whiteboard engine
20110811 01:56:51< Crab_> if there're no ambushes and no moveto events, you wouldn't be able to find out what is used
20110811 01:57:20< anonymissimus> and sighted events
20110811 01:57:25< Crab_> yes
20110811 01:57:34< Crab_> they would work in the same way as without DSU
20110811 01:57:44< anonymissimus> and probably a ton more of problems which nobody yet thought about lol
20110811 01:57:59< Crab_> no, just a generic unwind process
20110811 01:58:46< Crab_> i.e. you move units A B C D, press end turn (which should trigger an implicit commit).  A moves, B moves, C moves and triggers ambush. D is left in place (the move is cancelled), and turn is not ended.
20110811 01:59:09< Crab_> which is *exactly* the same situation which you'd get if you move A,B,C,D without DSU
20110811 01:59:49< Crab_> since from the point of view of engine which works with real unit map, there would be no DSU at all.
20110811 02:00:07< Crab_> and that simplification is the main reason why I want to kill current DSU
20110811 02:00:48< Crab_> note that this doesn't require the use of the whiteboard UI, at all.
20110811 02:01:41< Crab_> the only 'new' user interaction is the 'oops, some of your moves got cancelled because of unexpected thing during one of your first moves'
20110811 02:02:52-!- loonybot [~loonybot@46.138.80.53] has joined #wesnoth-dev
20110811 02:02:52-!- loonybot [~loonybot@46.138.80.53] has quit [Changing host]
20110811 02:02:52-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110811 02:04:00< Crab_> (technically, it's even possible to emulate the old slightly buggy behavior by autocommiting on the first move which triggers moveto/ambush)
20110811 02:04:00-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110811 02:04:04< anonymissimus> with current DSU, if an unxpected thing happens - wml event without undo possibility or ambush - it means a "commit"
20110811 02:04:12< Crab_> yes, exactly
20110811 02:04:19< Crab_> and we can do the same, if we want.
20110811 02:04:46< Crab_> note that this allows for some exploits
20110811 02:05:16< Crab_> imagine you have a field with 99 empty hexes and 1 hex with treasure, and there's 1 moveto nonundoable event on treasure
20110811 02:05:31< Crab_> you can enable DSU, then move to A, undo, move to B, undo, ... 
20110811 02:05:56< Crab_> you'll find the treasure, guaranteed, because you can check all 100 hexes.
20110811 02:06:30-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20110811 02:06:30-!- Upth is now known as Upthorn
20110811 02:06:36< Crab_> that's ok, actually, since this doesn't lead to causality violations
20110811 02:06:42< Crab_> tschmitz: hi
20110811 02:08:01< Crab_> tschmitz: we were just talking a little about modifying the whiteboard to allow a special mode which emulates old delayed-shroud-updates for the UI, while using whiteboard as the engine for unit_map manipulation. maybe I'll try to do it, several weeks later.
20110811 02:09:47< tschmitz> Crab_: Not 100% sure what you mean, but it sounds good anyway
20110811 02:10:17< Crab_> tschmitz: the idea is to emulate delayed shroud updates for a user perspective, while actually using the whiteboard to do stuff.
20110811 02:10:43-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110811 02:10:49< Crab_> tschmitz: i.e. when a player moves a unit, it does a planned move, but looks like a true move ui-wise (like it was with dsu), with no shadows, arrows, whatever
20110811 02:11:31< Crab_> tschmitz: and at the end of turn or when any attack happens, we commit, and do actual moves behind the screen (which would change nothing onscreen if no ambush/moveto/etc fires)
20110811 02:14:00< tschmitz> Crab_: so basically the idea is to change how the whiteboard looks, in some sense
20110811 02:14:14< tschmitz> Crab_: I'd like that
20110811 02:14:38< tschmitz> Crab_: For some reason, it reminds me of pointers vs references in C++
20110811 02:20:37< Crab_> tschmitz: it's mainly to please the old players which like the delayed shroud updates interface, while still keeping things clean on the engine side
20110811 02:21:03< Crab_> the removal of the delayed shroud updates in the code, surprisingly, allows to streamline a lot of stuff and fix quite a lot of bugs.
20110811 02:21:18< Crab_> and that interface is fairly simple
20110811 02:29:08< CIA-57> crab * r50693 /trunk/ (changelog src/actions.cpp): Fixed bug #18098: now recruits and recalls capture village if recruited or recalled on village+castle hex
20110811 02:29:31< Crab_> wesbot: topic
20110811 02:29:33-!- wesbot changed the topic of #wesnoth-dev to: 201 bugs, 326 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 02:30:11< anonymissimus> <200! <200!
20110811 02:31:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110811 02:32:08< Crab_> anonymissimus: yeah, that's what I'm thinking about atm :)
20110811 02:33:20< anonymissimus> good luck, bye
20110811 02:33:23-!- anonymissimus [~chatzilla@HSI-KBW-046-005-024-090.hsi8.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20110811 02:37:14-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Read error: No route to host]
20110811 02:37:17-!- crimson_pingvin [~ben@184.71.170.250] has joined #wesnoth-dev
20110811 02:37:17-!- crimson_pingvin [~ben@184.71.170.250] has quit [Changing host]
20110811 02:37:17-!- crimson_pingvin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 02:45:29-!- crimson_pingvin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_pingvin]
20110811 02:45:38-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 02:50:30-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 260 seconds]
20110811 03:20:56-!- hhyloc [~hhyloc@113.166.149.169] has joined #wesnoth-dev
20110811 03:23:41-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 240 seconds]
20110811 03:33:43-!- LordNasty [~NaSTy@93-43-134-30.ip92.fastwebnet.it] has quit [Read error: Connection reset by peer]
20110811 03:41:29-!- yenloc [~hhyloc@113.166.149.169] has joined #wesnoth-dev
20110811 03:43:48< CIA-57> crab * r50694 /trunk/ (4 files in 4 dirs): (log message trimmed)
20110811 03:43:48< CIA-57> Fixed bug #18057: AI leaders should now attack when they should. The problem
20110811 03:43:48< CIA-57> applied to AI leaders with two attacks, one of them ranged and another melee,
20110811 03:43:48< CIA-57> such as Orc Warlord, vs melee-strong ranged-weak opponents (and reverse,
20110811 03:43:48< CIA-57> ranged-strong melee-weak leaders vs ranged-strong melee-weak opponens). AI
20110811 03:43:48< CIA-57> selected the weapon using default aggression, so it selected a weapon most
20110811 03:43:49< CIA-57> damaging to both combatans, vs a 'safe' weapon. but then, when it rated the
20110811 03:44:35-!- LordNasty [~NaSTy@93-43-134-30.ip92.fastwebnet.it] has joined #wesnoth-dev
20110811 03:45:18-!- hhyloc [~hhyloc@113.166.149.169] has quit [Ping timeout: 258 seconds]
20110811 03:45:59< Crab_> wesbot: topic
20110811 03:46:00-!- wesbot changed the topic of #wesnoth-dev to: 199 bugs, 326 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 03:46:10< Crab_> :)
20110811 03:46:13-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Leaving.]
20110811 03:47:38-!- yenloc [~hhyloc@113.166.149.169] has quit [Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/]
20110811 03:51:04-!- Blueblaze [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 04:04:34-!- Blueblaze [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110811 04:04:36-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110811 04:34:59< CIA-57> crab * r50695 /trunk/ (4 files in 4 dirs): Fixed bug #18356: AI leaders now won't move to avoided keeps. Also, bumped up leader_aggression in EI:13
20110811 05:05:47< Gambit> So I have something in Wesnoth I'd like to fix tomorrow, but I'm not very familiar with Wesnoth's innards and not particularly awesome at C++. I'm hoping someone can read this and leave me a message in the logs, or help me tomorrow:
20110811 05:05:55< Gambit> When we make terrain_types we give them id's.
20110811 05:06:03< Gambit> And then we alias them to about 15 different groups.
20110811 05:06:17< Gambit> Then when we set [movement_costs] and [defense] we just use those alias's to save time.
20110811 05:06:35< Gambit> However it looks like if you try to set one of the original id's defense/movement costs for a unit, it won't override the one for the alias.
20110811 05:06:51< Gambit> So I can't say "I want this unit to have 50 defense on all flat except for this particular type of grass."
20110811 05:06:56< Gambit> For a crazy example^
20110811 05:07:12< Gambit> I want to make it so we can do this.
20110811 05:07:23< Gambit> I'm hoping someone can point me at the relevant .cpp file
20110811 05:07:44< shadowmaster> certainly out of reach for me
20110811 05:08:13< shadowmaster> the game logic is something I've touched exactly once and it was an emergency of sorts; certainly not doing it again
20110811 05:08:18< shadowmaster> (it is not in a single file)
20110811 05:08:55< Gambit> I'm hoping it's as simple as that when you're on a hex it checks it's id first and it's alias second and I can make it not do the latter if the former worked.
20110811 05:08:58< Gambit> But probably not.
20110811 05:09:09< Gambit> *its
20110811 05:10:11< Gambit> The actual example is that I want to use WML to inject movement costs of 0 for ids of rail, raildiag1, and raildiag2. But it's looking like their alias to flat overrides what I do.
20110811 05:14:04< Gambit> Anyway good night everyone.
20110811 05:14:41< Gambit> And if someone can point me at the right .cpp file at least, that'd be really cool.
20110811 05:15:02-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20110811 05:21:00-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110811 05:26:29-!- wesbot changed the topic of #wesnoth-dev to: 197 bugs, 326 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 05:36:05-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20110811 06:18:04-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110811 06:29:05-!- Blueblaze [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 06:37:01-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 260 seconds]
20110811 06:50:53-!- horon [~horon@nttkyo103205.tkyo.nt.adsl.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20110811 07:05:55-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 07:24:25-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110811 08:06:26-!- AngelsJinx [~AngelsJin@203.160.126.252] has joined #wesnoth-dev
20110811 08:07:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110811 08:10:31-!- AngelsJinx [~AngelsJin@203.160.126.252] has left #wesnoth-dev []
20110811 08:12:01-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110811 08:12:38< gabba> Hi all
20110811 08:12:41< gabba> Hi tschmitz
20110811 08:15:07-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110811 08:15:07-!- Upth is now known as Upthorn
20110811 08:19:29-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20110811 08:29:31-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20110811 08:38:43< tschmitz> gabba: Hey there
20110811 08:38:50-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110811 08:38:58< tschmitz> See ya
20110811 08:39:15-!- Blueblaze [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110811 08:55:10-!- AngelsJinx [~AngelsJin@203.160.126.252] has joined #wesnoth-dev
20110811 08:55:14-!- AngelsJinx [~AngelsJin@203.160.126.252] has left #wesnoth-dev []
20110811 09:11:13-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Disconnected by services]
20110811 09:11:36-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110811 09:29:48-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has joined #wesnoth-dev
20110811 09:31:13-!- timotei [~Timotei@193.34.190.70] has joined #wesnoth-dev
20110811 09:31:13-!- timotei [~Timotei@193.34.190.70] has quit [Changing host]
20110811 09:31:13-!- timotei [~Timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 09:40:50-!- enchilado [~enchilado@ppp118-208-34-231.lns20.bne1.internode.on.net] has quit [Read error: Connection reset by peer]
20110811 09:40:59< thonsew> Hello shadowmaster, timotei
20110811 09:41:01-!- enchilado [~enchilado@ppp118-208-34-231.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110811 09:41:12< shadowmaster> hi
20110811 09:41:36< thonsew> I saw the discussion/fustration earlier with my buggy code.
20110811 09:42:12< shadowmaster> eh, I don't handle much information on that; I haven't even tested trunk for a good while
20110811 09:42:47< timotei> thonsew, ah... I wasn't frustrated at all. I didn't even compile wesnoth for the last 2-3 weeks :P
20110811 09:43:02< Ivanovic> moin
20110811 09:43:03< timotei> and I've discovered that running linux on my older PC works better in combination with Eclipse
20110811 09:43:09< thonsew> anonymissimuss was fustrated
20110811 09:43:45< thonsew> Believe it not I played showdown with a version of my buggy code.
20110811 09:44:00< shadowmaster> (I'm currently frustrated at bigger fish, not recent contributors)
20110811 09:44:14< thonsew> With all my changes in it was 4 times faster (wall clock).
20110811 09:44:38< thonsew> However, apparently I exercise a limited range of the wesnoth feature with my play.
20110811 09:45:34< thonsew> Has anyone ever considered stealing/writing automated test vehicle?
20110811 09:46:07< thonsew> I think that is the big advantage that say firefox has is tinderbox.
20110811 09:46:09< shadowmaster> why not use the existing unit test framework?
20110811 09:46:43< shadowmaster> the only problem with it AFAICT is that people forget it exists and don't add new tests nor ensure existing tests run clean
20110811 09:46:46< thonsew> Do we have a set of unit tests for all/most of the features previously implemented?
20110811 09:47:01< thonsew> Answers my question.
20110811 09:47:19< thonsew> Did people initially try to generate a complete set of tests?
20110811 09:47:37< thonsew> Is it documented somewhere?
20110811 09:50:27< shadowmaster> I believe we did, you can check for yourself what there is in src/tests; I only contributed one unit (the version_info test) and the rest is mostly suokko's effort before disappearing
20110811 09:50:35< shadowmaster> I really doubt there's any documentation besides what Boost's has to offer though
20110811 09:51:35< shadowmaster> apparently zaroth and mordante also contributed some tests
20110811 09:53:22< thonsew> thanks.  I'll  check to see if it is easy to add some as I go along.  
20110811 09:53:39< thonsew> So that I/we never duplicate bugs again.
20110811 09:55:14-!- Appleman1234 [~Appleman1@emerch3.lnk.telstra.net] has quit [Remote host closed the connection]
20110811 10:01:04-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has quit [Ping timeout: 250 seconds]
20110811 10:01:55-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has joined #wesnoth-dev
20110811 10:20:47-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110811 10:34:51-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20110811 10:43:43-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev
20110811 10:44:05-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20110811 10:44:19-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection]
20110811 10:45:24-!- timotei [~Timotei@wesnoth/developer/timotei] has quit [Remote host closed the connection]
20110811 10:47:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110811 10:51:22-!- timotei [~Timo@193.34.190.70] has joined #wesnoth-dev
20110811 10:51:22-!- timotei [~Timo@193.34.190.70] has quit [Changing host]
20110811 10:51:22-!- timotei [~Timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 10:53:01-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110811 11:12:58-!- AngelsJinx [~AngelsJin@203.160.126.252] has joined #wesnoth-dev
20110811 11:17:08-!- AngelsJinx [~AngelsJin@203.160.126.252] has left #wesnoth-dev []
20110811 11:30:41-!- fendrin [~fabi@88-134-20-121-dynip.superkabel.de] has quit [Remote host closed the connection]
20110811 12:01:38-!- Elvish_Hunter [6d36d8ef@gateway/web/freenode/ip.109.54.216.239] has joined #wesnoth-dev
20110811 12:04:00-!- sytyi [~sytyi@147-121-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110811 12:05:00-!- loonybot [~loonybot@46.138.80.53] has joined #wesnoth-dev
20110811 12:05:00-!- loonybot [~loonybot@46.138.80.53] has quit [Changing host]
20110811 12:05:00-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110811 12:15:44-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110811 12:26:20-!- Unnheulu [~ieuan@host86-180-11-31.range86-180.btcentralplus.com] has joined #wesnoth-dev
20110811 12:46:43-!- horon [~horon@nttkyo103205.tkyo.nt.adsl.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20110811 12:48:12-!- Elvish_Hunter [6d36d8ef@gateway/web/freenode/ip.109.54.216.239] has quit [Ping timeout: 252 seconds]
20110811 12:48:33-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110811 12:49:50-!- Elvish_Hunter [6d36d8ef@gateway/web/freenode/ip.109.54.216.239] has joined #wesnoth-dev
20110811 12:53:03-!- timotei [~Timo@wesnoth/developer/timotei] has quit [Ping timeout: 276 seconds]
20110811 12:53:48-!- sytyi [~sytyi@147-121-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20110811 12:54:50-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20110811 12:56:50-!- fendrin [~fabi@88-134-20-121-dynip.superkabel.de] has joined #wesnoth-dev
20110811 12:57:05< fendrin> hi Crab_
20110811 12:57:11< Crab_> hi, fendrin
20110811 12:57:48< fendrin> Crab_, I have ported LoW to work with the patch and it seems to work. Difficult level is still always medium.
20110811 12:58:31< Crab_> hm, then something is not ported or has changed. the patch 100% worked back then, I personally checked it.
20110811 12:58:53< Crab_> try to output the new WML just after it's parsed and make sure it's used
20110811 12:59:25-!- timotei [~Timo@193.34.190.70] has joined #wesnoth-dev
20110811 12:59:25-!- timotei [~Timo@193.34.190.70] has quit [Changing host]
20110811 12:59:25-!- timotei [~Timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 12:59:37< fendrin> hi timotei
20110811 13:02:30-!- Elvish_Hunter [6d36d8ef@gateway/web/freenode/ip.109.54.216.239] has quit [Ping timeout: 252 seconds]
20110811 13:04:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110811 13:07:42-!- Crab_ [~Crab_@wesnoth/developer/crab] has left #wesnoth-dev []
20110811 13:15:32-!- hopman- [~chris@c-24-23-181-11.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
20110811 13:16:55-!- hopman- [~chris@c-24-23-181-11.hsd1.ca.comcast.net] has joined #wesnoth-dev
20110811 13:24:41-!- timotei [~Timo@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20110811 13:25:49-!- timotei [~Timo@193.34.190.70] has joined #wesnoth-dev
20110811 13:25:49-!- timotei [~Timo@193.34.190.70] has quit [Changing host]
20110811 13:25:49-!- timotei [~Timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 13:25:56-!- timotei [~Timo@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20110811 13:29:41< Rhonda> mordante is cmake scapegoat, right?
20110811 13:43:31-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20110811 14:13:22< Espreon> Rhonda: Sounds about right.
20110811 14:13:42-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: ^]
20110811 14:17:24< CIA-57> fendrin * r50696 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/ (53 files in 6 dirs): LoW: Grouped scenarios into chapters at file system level.
20110811 14:23:16< CIA-57> espreon * r50697 /trunk/po/ (6 files in 6 dirs): Updated the British English translation.
20110811 14:25:05-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20110811 14:27:59-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110811 14:34:14-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20110811 14:38:15< Rhonda> Espreon: Because actually, since autofoo was removed, I was unable to get wesnoth to compile on armel, mips, mipsel or sparc.  %-/
20110811 14:38:37-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20110811 14:38:41< Rhonda> No clue whether I should give scons a whack instead, maybe that behaves better with different architectures, no clue.
20110811 14:38:49 * Espreon shrugs
20110811 14:47:44< loonycyborg> Rhonda: What where those errors again?
20110811 14:48:11-!- vcap_ [~vcap@AReims-551-1-5-33.w86-215.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds]
20110811 14:50:32< Gambit> Who can I talk to about src/pathfind/pathfind.cpp ?
20110811 14:51:57< Gambit> Right now it's throwing errors for movecosts of 0, but it doesn't look like anything bad actually happens when I remove that check.
20110811 14:52:42< Gambit> Well actually it looks like the little footprint trails don't render. hmmm
20110811 14:54:59< Gambit> Ah darn there are pathfinding problems there.
20110811 14:55:09< Rhonda> loonycyborg: some sdl related ones
20110811 14:55:26< Rhonda> CMakeFiles/wesnoth.dir/network_worker.cpp.o: In function `receive_buf':
20110811 14:55:26< Rhonda> /build/buildd-wesnoth-1.9_1.9.8-1-mipsel-Rr9Stp/wesnoth-1.9-1.9.8/src/network_worker.cpp:603: undefined reference to `SDLNet_Read32'
20110811 14:56:31< loonycyborg> SDL_net seems to use a lot of macro magic with that particular call.
20110811 14:57:59-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20110811 14:58:58< CIA-57> fendrin * r50698 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/_main.cfg: LoW: _main.cfg file for the scenario folder.
20110811 15:00:36< loonycyborg> I'd bet on a SDL_net issue. Either it doesn't link against sdl-net properly or something in that macro chain is rotten.
20110811 15:00:52-!- timotei [~Timo@193.34.190.70] has joined #wesnoth-dev
20110811 15:00:52-!- timotei [~Timo@193.34.190.70] has quit [Changing host]
20110811 15:00:52-!- timotei [~Timo@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 15:10:07< CIA-57> fendrin * r50699 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/ (6 files in 4 dirs): LoW more scenario file movement.
20110811 15:12:35-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110811 15:33:51< CIA-57> fendrin * r50700 /trunk/data/campaigns/Legend_of_Wesmere/scenarios/ (2 files in 2 dirs): LoW 17+22: Fixed a reference to a util wml file.
20110811 15:34:40-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
20110811 15:39:41-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20110811 15:51:42-!- anonymissimus [~chatzilla@HSI-KBW-046-005-024-090.hsi8.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110811 15:52:46-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110811 15:53:02< anonymissimus> thonsew: I wouldn't call it "frustrated"...as far as your recent unit_map changes are concerned, I just had the problem that the loading-a-replay bug prevented me from reproducing two other bugs
20110811 15:53:15< anonymissimus> for a few days
20110811 15:57:07< anonymissimus> Gambit: maybe Sapient...sounds like a bug, pls report ?
20110811 16:01:59< Gambit> Well it's not really a bug. Whoever made this knew it wouldn't support movement costs of 0 and put in several checks to make sure it never had to.
20110811 16:04:29< anonymissimus> Espreon: could you have a look at https://gna.org/bugs/?14822 ? since you coded stuff in A new land lately
20110811 16:04:40< anonymissimus> should be wml only xD
20110811 16:08:10-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection]
20110811 16:08:46-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20110811 16:17:09-!- fabi [~fabi@88-134-20-121-dynip.superkabel.de] has joined #wesnoth-dev
20110811 16:21:15-!- fendrin [~fabi@88-134-20-121-dynip.superkabel.de] has quit [Ping timeout: 276 seconds]
20110811 16:25:00< Gambit> Whoa wtf.
20110811 16:25:06< Gambit> Crap and fendrin just timed out.
20110811 16:25:17< Gambit> The game is crashing with LoW related errors :|
20110811 16:25:36 * Gambit investigates
20110811 16:25:54< Gambit> (Why can a campaign make the game entirely unloadable anyway?)
20110811 16:29:50< fabi> Gambit: please report.
20110811 16:30:18-!- mjs-de [~mjs-de@d190161.adsl.hansenet.de] has joined #wesnoth-dev
20110811 16:30:48< Gambit> fabi: the problem is that you're calling a macro that's defined in another scenario
20110811 16:32:48-!- horon [~horon@nttkyo103205.tkyo.nt.adsl.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20110811 16:35:25-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has quit [Remote host closed the connection]
20110811 16:35:59< Gambit> fabi: Do you mind if I commit a quick fix?
20110811 16:36:15< Gambit> I'm going to move two macros out of that scenario into utils/low-macros.cfg
20110811 16:36:36< Gambit> Because head is unusable right now.
20110811 16:36:56< fabi> Gambit: Yes please do so.
20110811 16:37:38< anonymissimus> head works for me, interesting
20110811 16:37:49< fabi> anonymissimus: It does for me as well.
20110811 16:37:54< anonymissimus> r50700
20110811 16:38:56< CIA-57> grickit * r50701 /trunk/data/campaigns/Legend_of_Wesmere/ (2 files in 2 dirs): Moved PLAYER_GOLD_04 and MULTIPLAYER_GOLD_04 into utils/low-macros.cfg so that all LoW scenaiors have access to them.
20110811 16:39:02< Gambit> anonymissimus: If I go to start a local game it crashes
20110811 16:39:37< Gambit> http://pastebin.com/fA780Wjh
20110811 16:40:15< anonymissimus> aha yeah, probably since MULTIPLAYER is defined then
20110811 16:45:03< anonymissimus> fabi: it seems https://gna.org/bugs/?11276 is no longer in your scope
20110811 16:46:07< fabi> anonymissimus: That is right.
20110811 17:05:46< Gambit> Hmmm. The village overlay doesn't actually work.
20110811 17:06:27< Gambit> Which doesn't make sense because all villages are overlays...
20110811 17:11:19< Gambit> Oh nevermind -_-
20110811 17:12:19-!- sytyi [~sytyi@147-121-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110811 17:23:33-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110811 17:26:29-!- wesbot changed the topic of #wesnoth-dev to: 196 bugs, 327 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 17:27:24-!- Blueblaze2 [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 17:43:55-!- Blueblaze2 [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze2]
20110811 17:45:46-!- Blueblaze2 [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 18:01:31-!- Blueblaze2 [~Blueblaze@adsl-76-202-17-215.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze2]
20110811 18:06:14-!- vcap [~vcap@AReims-551-1-5-33.w86-215.abo.wanadoo.fr] has joined #wesnoth-dev
20110811 18:14:40-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-236.telecom.by] has joined #wesnoth-dev
20110811 18:28:20-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 18:28:40-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Read error: Connection reset by peer]
20110811 18:29:30-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 18:42:01< anonymissimus> wesbot: topic
20110811 18:42:02-!- wesbot changed the topic of #wesnoth-dev to: 192 bugs, 328 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 18:44:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110811 18:46:41-!- loonybot [~loonybot@46.138.80.53] has joined #wesnoth-dev
20110811 18:46:41-!- loonybot [~loonybot@46.138.80.53] has quit [Changing host]
20110811 18:46:41-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110811 19:01:39-!- Blueblaze [~Blueblaze@adsl-99-148-247-65.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 19:07:05-!- Blueblaze [~Blueblaze@adsl-99-148-247-65.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110811 19:18:45-!- Ivanovic_ [~ivanovic@dtmd-4db23f93.pool.mediaWays.net] has joined #wesnoth-dev
20110811 19:18:45-!- Ivanovic_ [~ivanovic@dtmd-4db23f93.pool.mediaWays.net] has quit [Changing host]
20110811 19:18:45-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110811 19:21:22-!- markus_ [~mjs-de@d190161.adsl.hansenet.de] has joined #wesnoth-dev
20110811 19:27:02-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110811 19:27:27-!- mjs-de [~mjs-de@d190161.adsl.hansenet.de] has quit [Ping timeout: 255 seconds]
20110811 19:27:27-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 255 seconds]
20110811 19:27:28-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 255 seconds]
20110811 19:27:41-!- Elvish_Pillager [~eli@71-10-224-192.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20110811 19:28:42-!- Ivanovic_ is now known as Ivanovic
20110811 19:51:40< Espreon> Hmmmm... I can't work like this...
20110811 19:51:53< Espreon> anonymissimus: I'd love to look at it and do other nice shit for it but...
20110811 19:52:17< Espreon> http://pastebin.com/QtZVaAyd
20110811 19:52:44< Espreon> That's what happens when you try to make a village into a university.
20110811 19:53:37< anonymissimus> looks like s severe bug
20110811 19:53:49< Espreon> Indeed.
20110811 19:53:57< anonymissimus> well then why not assign the bug I linked to to you and report this one
20110811 19:54:23< anonymissimus> until it gets fixed so you can work on the original one
20110811 19:54:33< CIA-57> sytyi * r50702 /trunk/src/tools/schema/tag.cpp: Fixed bug when links&tags of super tag overrided links of tag, dropping special context-based info.
20110811 19:54:34< Espreon> Eh, no assigning stuff to me till I become familiar with the diplomacy code.
20110811 19:57:48< Espreon> anonymissimus: Isn't this fun? Although the bug count is dropping, the number of critical bugs is rising!
20110811 19:58:55< anonymissimus> critival new bugs are all unit_map related
20110811 19:59:16< Espreon> I know.
20110811 19:59:20< anonymissimus> except yours now maybe
20110811 20:05:00< Espreon> Well, I added a gdb backtrace to the bug report.
20110811 20:07:11-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Disconnected by services]
20110811 20:11:01-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has joined #wesnoth-dev
20110811 20:13:22-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20110811 20:18:49-!- timotei21 [~timotei@193.34.190.70] has joined #wesnoth-dev
20110811 20:18:49-!- timotei21 [~timotei@193.34.190.70] has quit [Changing host]
20110811 20:18:49-!- timotei21 [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110811 20:24:20< Gambit> So uh… trunk just crashed and automagically generated a backtrace for me (:O) http://pastebin.com/xyvc5due
20110811 20:24:25< Gambit> One of my units died.
20110811 20:25:29< anonymissimus> IMHO these unit map modifications hinder too much the work on other stuff
20110811 20:26:01< Espreon> Yeah...
20110811 20:26:12< Espreon> I wanna work on my God-damned GNU Hurd!
20110811 20:28:25< Gambit> Need branches :)
20110811 20:32:47-!- sytyi [~sytyi@147-121-133-95.pool.ukrtel.net] has quit [Read error: Connection reset by peer]
20110811 20:35:37< anonymissimus> wesbot: topic
20110811 20:35:39-!- wesbot changed the topic of #wesnoth-dev to: 194 bugs, 328 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 20:35:47< timotei21> anonymissimus: hehe:P
20110811 20:35:50< timotei21> hmm
20110811 20:35:53-!- fabi [~fabi@88-134-20-121-dynip.superkabel.de] has quit [Remote host closed the connection]
20110811 20:35:55< timotei21> I'm logged on 2 machines.
20110811 20:35:56< timotei21> gr
20110811 20:36:09< CIA-57> thonsew * r50703 /trunk/src/ (4 files in 2 dirs): 
20110811 20:36:09< CIA-57> 1. Fixed copy operator bug, failure to check if RHS already equals LHS
20110811 20:36:09< CIA-57> 2. Added std::pair<iterator, bool> return types to allow faster moving, insertion etc.
20110811 20:36:09< CIA-57> 3. Added extensive comments.
20110811 20:36:09< CIA-57> 4. Fixed some const correctness
20110811 20:36:14-!- timotei [~Timo@wesnoth/developer/timotei] has quit [Quit: Leaving]
20110811 20:36:26-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110811 20:38:51< Espreon> zookeeper: Do you know when the village that resembles the encampment keep was removed?
20110811 20:39:50-!- fendrin [~fabi@88-134-20-121-dynip.superkabel.de] has joined #wesnoth-dev
20110811 20:40:47-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has joined #wesnoth-dev
20110811 20:43:59< Crab_> hi, thonsew - recompiling now to see if bug #18484 will go away after your r50703
20110811 20:44:05< Gambit> Espreon: Re^Vct is still there.
20110811 20:44:14< Gambit> Espreon: Top left corner on the villages tab.
20110811 20:44:32< thonsew> crab thanks, that why I'm here.
20110811 20:44:41< Gambit> Oh it doesn't have that variant anymore. I see.
20110811 20:44:53< Espreon> Yeah.
20110811 20:47:49< Espreon> Hmmm, it seems that bugs 18480 and 18487 were fixed by that.
20110811 20:48:15< thonsew> small yeah.
20110811 20:48:38< thonsew> I see the new one though
20110811 20:48:48-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20110811 20:48:48-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20110811 20:48:48-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20110811 20:48:48< Crab_> thonsew - I'm also able to reproduce #18488 , so I'd check it, as well.
20110811 20:49:04< mordante> servus
20110811 20:49:17< zookeeper> Espreon, within the last couple of months, i think
20110811 20:49:23< Espreon> mordante: Ic grete þe.
20110811 20:49:28< mordante> hi Espreon 
20110811 20:49:31< Espreon> zookeeper: Hmmm, I kinda liked that village, though...
20110811 20:49:34< zookeeper> or at least within the last 6 months
20110811 20:50:47< mordante> Rhonda, I might have time next week to look at cmake, but quite busy at the moment
20110811 20:50:58-!- sytyi [~sytyi@109-135-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20110811 20:51:38< Espreon> zookeeper: Do you think it should be brought back?
20110811 20:51:49< timotei21> hi fendrin.
20110811 20:51:59< timotei21> Sorry for not responding. I was to take my notebook out of service. :)
20110811 20:53:22< mordante> sytyi, hi
20110811 20:53:45< sytyi> mordante: hi
20110811 20:53:59< mordante> sytyi, how are things going?
20110811 20:54:05< Espreon> zookeeper: eleazar just replaced the graphics with that of the desert tent village.
20110811 20:54:39< sytyi> mordante: improving markup
20110811 20:55:07< mordante> ok
20110811 20:55:14< mordante> any troubles at the moment?
20110811 20:55:44-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110811 20:56:50< sytyi> mordante: I 've documented window_definition, etc 
20110811 20:57:00-!- Octalot [~noct@host86-166-162-91.range86-166.btcentralplus.com] has quit []
20110811 20:57:21< sytyi> mordante: now working with all  [.._definition]
20110811 20:57:37< sytyi> mordante: Number of errors is now 43
20110811 20:57:49< sytyi> as yesterday:
20110811 20:58:26< Crab_> thonsew: #18484 - fixed, great
20110811 20:58:30< sytyi> mordante: Maybe I'll commit, and give you list of some errors like type value ?
20110811 20:58:35 * anonymissimus just got yet another unit related crash
20110811 20:58:49< Crab_> anonymissimus: r ?
20110811 20:59:09< thonsew> Gambit:  You were asking yesterday about the pathfinding code and zero cost paths.  
20110811 20:59:18< thonsew> Do you still need an answer?
20110811 20:59:30< Gambit> Yes sure. :)
20110811 20:59:49< Gambit> It'd be a nice feature to have.
20110811 21:00:08< Gambit> I found the relevant code, but it's beyond me.
20110811 21:00:11< thonsew> pathfinding uses an A* or djikstra algorithm to determine the best path.  Both require every path 
20110811 21:00:17< mordante> sytyi, sounds fine
20110811 21:00:19< thonsew> to have some cost.
20110811 21:00:39< thonsew> One work around would be to use the teleport code to create zero length paths.
20110811 21:00:41< Crab_> thonsew: #18488 - not fixed, backtrace changed, it now looks  like the unit iterator invalidation guarantees changed
20110811 21:01:19< anonymissimus> thonsew: btw do your unit map changes affect teh order in which units are iterated upon in SUFs ?
20110811 21:01:47< anonymissimus> if so, that could cause lots of subsequent wml bugs
20110811 21:02:09< thonsew> It should be the same, but I didn't enforce it.
20110811 21:02:11-!- iCyrus [~cyrus@adsl-70-238-70-193.dsl.snantx.sbcglobal.net] has joined #wesnoth-dev
20110811 21:02:21< anonymissimus> if wml/lua code expects certain unit to be stored first
20110811 21:02:31< thonsew> The old order was by id and enforced by the map iteration.
20110811 21:02:50< anonymissimus> the old order was by underlying_id
20110811 21:02:56< thonsew> The new order is arbitrary, but currently in the order the ids are created.
20110811 21:03:16< anonymissimus> said silene somewhere once
20110811 21:03:26< iCyrus> Hey, I'm not new to programming but I've heard that making campaigns/other things for Wesnoth is not like regular programming, I was looking through the forums and I couldn't find a step-by-step guide to learn how to get started
20110811 21:03:30< thonsew> silene is/was correct
20110811 21:03:47< iCyrus> The best I found was something that was just showing how to DESIGN one rather than make one itself
20110811 21:04:08< anonymissimus> iCyrus: get Campaign-How-To from the 1.9 addons server
20110811 21:04:14< CIA-57> sytyi * r50704 /trunk/src/gui/auxiliary/ (42 files in 3 dirs): GUI WML markup. Initial work. Still some errors while validation.
20110811 21:04:20< sytyi> mordante: Maybe PM ?
20110811 21:04:23< Crab_> thonsew: enjoy the new backtrace in https://gna.org/bugs/index.php?18488
20110811 21:04:26< timotei21> iCyrus: Did you took a look over this page? http://wiki.wesnoth.org/Create
20110811 21:04:38-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20110811 21:04:40< thonsew> Crab_ thanks.
20110811 21:04:47< iCyrus> anonymissimus: I'd have to upgrade to 1.9 to get that?
20110811 21:05:24< Espreon> Why not use 1.9?
20110811 21:05:26< anonymissimus> iCyrus: i'd advice to upgrade since 1.9 is better foe beginner coders due to mroe meaningful error messages
20110811 21:05:26< iCyrus> timotei21: I saw a lot of outdated links so I didn't bother checking them, should I have?
20110811 21:05:30< Espreon> 1.9's better for SP anyway.
20110811 21:05:46< timotei21> iCyrus: IDK. I don't do much UMC anyway, but they should be a start :)
20110811 21:05:50< mordante> negusnyul, around?
20110811 21:05:54< timotei21> combined with anonymissimus's suggestion
20110811 21:05:56< mordante> sytyi, I rather have an email
20110811 21:06:51< Crab_> thonsew: basically, what happens, is the code does a .erase(loc), .add(loc)
20110811 21:06:54< sytyi> mordante: Wanted to discuss erroe part
20110811 21:07:17< mordante> with PM you mean a PM on IRC?
20110811 21:07:35< Crab_> thonsew: in the old code, there was a guarantee that the iterators would stay valid in that case, as this is really a common case (take unit, do something with it, put it back, on same location)
20110811 21:08:32< negusnyul> mordante: I'm here now
20110811 21:08:37< Crab_> it was documented in unit_map.hpp, as   'They even stay valid if a unit is erased from the map and another unit with the same underlying id is inserted in the map'
20110811 21:08:47< thonsew> Crab_, in the old code no memory was recovered it any iterator was extant.
20110811 21:09:05< Crab_> yes, if at least one was present, just because of that
20110811 21:09:25< sytyi> mordante: yes
20110811 21:09:28< thonsew> Crab_, in the new code memory is recovered if it has iterators extant.
20110811 21:09:56< thonsew> Which file/code are you looking at?
20110811 21:10:13< Crab_> the #4 in the backtrace
20110811 21:10:44< Crab_> menu_events.cpp:3517 , menu_events.cpp:3520, and failing menu_events.cpp:3522
20110811 21:11:03< Crab_> erase(loc)-add(loc)-reuse old iterator sequence
20110811 21:11:11< specing> Is there a way to turn on verbosity to debug my problem?
20110811 21:11:11< mordante> negusnyul, this is your first patch?
20110811 21:11:37< Crab_> and the iterator guarantee is still at unit_map.hpp:34
20110811 21:12:03-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20110811 21:12:03< thonsew> Crab_, that should work.
20110811 21:12:25< Crab_> thonsew: #18488 includes a easy how-to-reproduce, try it
20110811 21:17:44< negusnyul> mordante: yes
20110811 21:18:54< Crab_> Espreon: so, https://gna.org/bugs/?18480 and https://gna.org/bugs/?18487 can be marked as fixed?
20110811 21:19:27< Crab_> (yes, that's an attempt to drive the bug counter to < 190 today ) :)
20110811 21:19:50< Espreon> Crab_: So it seems.
20110811 21:20:07< Crab_> great
20110811 21:20:09< thonsew> Crab_,  I understand the problem
20110811 21:20:44< thonsew> The new unit returns new iterators on modifying operations like STL containers.
20110811 21:20:55< thonsew> The new unit_map
20110811 21:21:06< mordante> negusnyul, ok
20110811 21:22:37< Crab_> good. I hope that there's a solution other than removing the guarantee and rewriting all stuff which depends on it (because it's hard to find all the places which break without the guarantee in place)
20110811 21:22:38< mordante> negusnyul, FYI the changelog should be max 80 chars
20110811 21:22:57< negusnyul> mordante: ok, didn't know that
20110811 21:23:15< thonsew> I'm a thinking.
20110811 21:23:15< Crab_> but there's easy to 'fix' each particular place (i.e., here it's enough to store the location beforehand)
20110811 21:24:21< thonsew> Each modifying operation return std::pair<unit_iterator, bool>
20110811 21:25:22< thonsew> If you do like STL std::pair<unit_iterator,bool> i = unit_map.add(loc, new_unit) it will work
20110811 21:25:24< Crab_> note that, in general. the code holding the iterator might not know about any modifications called while it's holding the iterator (i.e. if it calls a helper function to do the modification)
20110811 21:27:28< Crab_> also there was a note that the guarantee doesn't apply to iterator order - i.e. 'The code does not involve any magic, so units moved while being iterated upon may be skipped or visited twice.', so only the validity of individual iterators is important
20110811 21:28:28< thonsew> but erasing and reinsert doesn't count as moving
20110811 21:28:58< zookeeper> Espreon, eh, i don't mind too much, so i'm willing to let eleazar have it the way he wanted
20110811 21:29:14< thonsew> enforcing the old guarrantee was forcing a double lookup O(N) which is why unit_map::find
20110811 21:29:28< thonsew> shows up in the top 5 every time you profile
20110811 21:32:18< Crab_> dropping the guarantee would mean the need to hunt for an unspecified number of bugs like this.
20110811 21:32:18< Espreon> zookeeper: All right, then.
20110811 21:33:05< Crab_> for each bug, it's easy to change the code to make it work. but finding them all is tricky, especially if they are found by end-user without debugger
20110811 21:33:30< Crab_> and most of those might be found by end-users, they do play a lot of more strange WML-heavy scenarios than we do
20110811 21:34:20< Crab_> thonsew: btw, can an iterator 'fix itself' in this case ?
20110811 21:37:28< CIA-57> mordante * r50705 /trunk/ (CMakeLists.txt INSTALL): 
20110811 21:37:28< CIA-57> Updated files to bumped Boost requirements.
20110811 21:37:28< CIA-57> Updated INSTALL and cmake files. Omitted scons since some parts refer to
20110811 21:37:28< CIA-57> versions others don't and the version mentioned differs as well.
20110811 21:37:28< CIA-57> mordante * r50706 /trunk/ (6 files in 4 dirs): 
20110811 21:37:28< CIA-57> Implement chat log again.
20110811 21:37:28< CIA-57> Applies patch #2892 and fixes bug #7254.
20110811 21:37:46< Crab_> thonsew: i.e., when we failed that valid() assertion, there was a unit with 'same' underlying id on the game map, it was just in a different place in those internal maps
20110811 21:38:02< mordante> negusnyul, committed in r50706
20110811 21:38:19< thonsew> Yes, with some changes.  If the unit is deleted when it is erased. 
20110811 21:38:23< Espreon> OK, I somehow got this after leaving Wesnoth idle for a bit and going back to it: http://pastebin.com/4KNnjZyL
20110811 21:38:28< Espreon> And yes, I was playing ANL.
20110811 21:39:02< Crab_> Espreon: nice :)
20110811 21:39:23< Crab_> thonsew: but then a unit was readded (with same underlying_id)
20110811 21:39:25< negusnyul> mordante: yay! nice :)
20110811 21:39:37< negusnyul> mordante: that was fast, thanks :)
20110811 21:39:37< wesbot> negusnyul: Sometimes we are fast
20110811 21:39:38< mordante> negusnyul, well you did the job ;-)
20110811 21:39:49< Crab_> thonsew: is it possible to somehow 'reattach' the iterator by that underlying id ?
20110811 21:40:25< Crab_> this might be a more O-expensive operation, but that shouldn't happen often, since afterwards that'll be a normal iterator with normal access times
20110811 21:41:01< thonsew> unless the code is generally written as the function we are looking at now.
20110811 21:41:26< Crab_> why the current style prevents this ?
20110811 21:41:33< thonsew> When I was playing with the teleport code I found that it was parsing the unit name 6,000,000 a turn
20110811 21:41:57< thonsew> That noticable
20110811 21:42:12< Crab_> that's probably a unit filter problem upstream in the code
20110811 21:42:34< Rhonda> mordante: Well, at least we now know that the next Debian freeze is next june, so no hurry  ;P
20110811 21:43:02< thonsew> I added a LRU cache to the vconfig parse code and that fixed the problem, regardless of upstream.
20110811 21:43:13< Rhonda> mordante: On the other hand, it might be required to look at it before 1.10 becomes stable, otherwise it might bite us
20110811 21:43:15< thonsew> I haven't submitted this code to wesnoth
20110811 21:43:38< mordante> Rhonda, like to have it fixed before so we can test the fix a few releases
20110811 21:43:58< Crab_> thonsew: note that vconfig expansion can change even during the same turn, if some of the impliit or explicit vars change.
20110811 21:44:51< Crab_> thonsew: so, I was thinking, ok ' in    menu_handler_.gui_->invalidate(i->get_location()); ' line, iterator is not valid (and it knows that). but, if it still knows its underlying id, it can become valid again (by itself), since it can find its location and unit* again.
20110811 21:46:44< thonsew> I store parse  and the expansion in separate caches.  The parse only updates if the string updates
20110811 21:46:58< thonsew> The expansion can update whenever the vconfig changes.
20110811 21:47:36< thonsew> For this one bug I'm trying just to update i.
20110811 21:47:43< thonsew> I'll getting punchy though.
20110811 21:47:45< Crab_> ok
20110811 21:50:06< thonsew> It worked.  I'll make a commit message, svn dcommit and say goodbye.
20110811 21:50:32< Crab_> ok, great
20110811 21:51:50< CIA-57> thonsew * r50707 /trunk/src/menu_events.cpp: Fix for bug #18488 unit_map iterator not updated when changed in menu_events.cpp
20110811 21:52:21< thonsew> Can you check that before I toddle off?
20110811 21:52:28< Crab_> yes, I will
20110811 21:52:43< Crab_> doing a recompile now
20110811 21:54:08-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Remote host closed the connection]
20110811 21:55:17< CIA-57> mordante * r50708 /trunk/data/gui/default/widget/window_tooltip_large.cfg: 
20110811 21:55:17< CIA-57> Fix an invalid key.
20110811 21:55:17< CIA-57> Found by Sytyi's validation tool.
20110811 21:55:21< CIA-57> mordante * r50709 /trunk/data/gui/default/widget/toggle_button_icon.cfg: 
20110811 21:55:21< CIA-57> Fix an invalid key.
20110811 21:55:21< CIA-57> Found by Sytyi's validation tool.
20110811 21:56:11< Crab_> thonsew: I hope that a better solution for the issue would be found.
20110811 21:57:34< thonsew> I'll think about it.
20110811 21:57:40< Crab_> great
20110811 22:00:26< Crab_> launching...
20110811 22:02:32< Crab_> fixed for :unit moves=10, but still present for :unit advances=2
20110811 22:03:05< thonsew> I told you I'm tired.
20110811 22:03:08< Crab_> there's multiple code paths, and there are some unit modifications inside dialogs:advance_unit (menu_events.cpp:3511)
20110811 22:03:31< Crab_> it's ok, the main part is that a problem is understood, we'll still got a plenty of time before next release
20110811 22:03:50< thonsew> When is the next release?
20110811 22:04:06< Crab_> I think that the usual policy is 'when we'd consider it ready' :)
20110811 22:04:39< Crab_> the last one was 1.9.2 on 29th July
20110811 22:04:40< thonsew> I think that the fixing up idea is good from a stability perspective , even though it opens a potentially
20110811 22:04:44< Crab_> 1.9.8 :)
20110811 22:04:54< thonsew> deep performance hole.
20110811 22:05:16< Crab_> 1.9.7 was on June 20
20110811 22:05:33< Crab_> 1.9.6 was on May 9
20110811 22:05:37-!- dtiger [~dtiger@dynamic-vpdn-93-125-17-236.telecom.by] has quit [Remote host closed the connection]
20110811 22:05:50< thonsew> pretty frequent
20110811 22:05:58< Crab_> so 1-2 months between those
20110811 22:07:29< thonsew> I'll look into a self healing ability and also feeding the iterator itself back into add, move etc , which would be O(1)
20110811 22:08:15< thonsew> bye for now.
20110811 22:08:17< mordante> thonsew, before Ivanovic considers releasing he'll ask for blockers
20110811 22:08:20< mordante> bye thonsew 
20110811 22:08:29< Crab_> bye
20110811 22:08:50-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has quit [Quit: Leaving]
20110811 22:10:09< mordante> loonycyborg, I saw you removed some strict aliases
20110811 22:10:33< mordante> loonycyborg, there are still some left in the unit tests, due to programming options
20110811 22:10:46< mordante> loonycyborg, could you have a look at them?
20110811 22:15:16-!- Blueblaze [~Blueblaze@adsl-99-185-8-157.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 22:15:24< mordante> I'm off night
20110811 22:15:36-!- Blueblaze [~Blueblaze@adsl-99-185-8-157.dsl.hstntx.sbcglobal.net] has quit [Client Quit]
20110811 22:15:41-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20110811 22:16:06-!- Blueblaze [~Blueblaze@adsl-99-185-8-157.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20110811 22:19:03-!- timotei21 [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20110811 22:23:14-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20110811 22:23:39-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20110811 22:23:39-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev
20110811 22:40:25< Gambit> fendrin: You implemented [tunnel] right?
20110811 22:41:11< Espreon> Gambit: He did.
20110811 22:41:12< fendrin> Gambit: yes
20110811 22:41:37< Gambit> fendrin: So I notice that the [teleport] ability has a $teleport_unit available for filtering.
20110811 22:41:44< Gambit> Can that be made available in [tunnel]?
20110811 22:42:48< Crab_> Gambit: btw, note that the AI will not work properly with zero-cost paths, if you get them implemented, unless you're really careful.
20110811 22:42:59< Gambit> I'm trying to get a tunnel that goes to certain hexes within a radius
20110811 22:43:08< Gambit> Crab_: I'm attempting to abuse [tunnel] for what I need :)
20110811 22:43:25< Gambit> The end result is just that you can move infinitely on connected train tracks.
20110811 22:44:09-!- Blueblaze [~Blueblaze@adsl-99-185-8-157.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20110811 22:44:10< Gambit> But to test connectedness I need [filter_radius] and to [filter_radius] I need radius= and to use radius= you have to give it a starting X and Y. :(
20110811 22:44:31< Gambit> Perhaps I can make this into an ability and inject it into units...
20110811 22:49:53< CIA-57> crab * r50710 /trunk/src/menu_events.cpp: improve r50707 by adding a workaround to deal with :unit advances=2 , as well. Also, add a :unit fail=now command as a testcase for iterator stability guarantee, violation of which is the real cause behind bug #18488
20110811 22:52:24-!- Crab_ [~Crab_@wesnoth/developer/crab] has quit [Ping timeout: 250 seconds]
20110811 22:52:31-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110811 22:54:11< fendrin> Gambit: I think you have the $teleport_unit available in [tunnel] already.
20110811 22:55:08-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Quit: Leaving]
20110811 23:03:09< Gambit> Hmm. I think there are issues with the timing of variable substitution.
20110811 23:03:34< Gambit> If I create the tunnel inside an event, $teleport_unit does not exist yet.
20110811 23:07:09-!- Crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20110811 23:07:17< Gambit> But delayed_variable_substitution=yes does not help.
20110811 23:07:31< Gambit> [tunnel] is not event
20110811 23:07:41< Gambit> So there is no time when it actually substitutes.
20110811 23:08:45< CIA-57> sytyi * r50711 /trunk/src/serialization/ (schema_validator.cpp schema_validator.hpp): Improved error printing
20110811 23:10:18-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110811 23:12:06< Crab_> fendrin: around ?
20110811 23:12:15< fendrin> Crab_: hi
20110811 23:12:26< Crab_> fendrin: a small question about https://gna.org/bugs/index.php?18122
20110811 23:12:35< Crab_> fendrin: I've debugged, and found the cause
20110811 23:13:12< Crab_> fendrin: if we use the AI controller to set the AI leader to become defensive, it's caution is set to 1.0
20110811 23:13:27< Crab_> fendrin: that means that the default max_risk of goal is 1-1 = 0
20110811 23:13:43< Crab_> fendrin: that means that it will not move to any place which is even remotely can be reached by the enemy
20110811 23:13:56< Crab_> fendrin: that means that,in general, it'll ignore leader goal.
20110811 23:15:18< Crab_> fendrin: I want to fix it by making the goal set by ai controller have something like max_risk=HIGH_VALUE (i.e., if human asked us to move there, we will trust his judgment and move, even if we think it's dangerous
20110811 23:15:22< Crab_> fendrin: what do you think ?
20110811 23:16:23< Espreon> wesbot: topic
20110811 23:16:24-!- wesbot changed the topic of #wesnoth-dev to: 192 bugs, 327 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 23:16:47< Espreon> Note that I just reported a bug.
20110811 23:17:29< Espreon> And no, it has nothing to do with unit_map.
20110811 23:17:39< Crab_> anonymissimus: can you add something like a save to bug #18489 ?
20110811 23:18:14< anonymissimus> Crab_: that bug has nothing to do with the unit map
20110811 23:18:24< anonymissimus> I fix it myself
20110811 23:18:32< Crab_> anonymissimus: yes, I know. I just wanted to fix it :)
20110811 23:18:40< Crab_> anonymissimus: ok, then :)
20110811 23:18:46< anonymissimus> I assigned it to me !!?
20110811 23:18:54< anonymissimus> upon posting
20110811 23:19:03< anonymissimus> why you attempt to fix it
20110811 23:19:21< Crab_> because I don't like crashes :)
20110811 23:19:43< Crab_> and I haven't noticed the 'assigned to' field
20110811 23:20:32-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110811 23:20:40< Espreon> anonymissimus: If you must fix something, why not fix the bug I just reported?
20110811 23:21:12< Crab_> fendrin: so, what do you think about that solution ? or any other ideas ?
20110811 23:21:46< fendrin> Crab_: Good enough for me. I think you should ask zookeeper, he is the author of the ai controller.
20110811 23:22:17< Crab_> fendrin: it's more of 'how it should behave from player's PoV' question...
20110811 23:23:00< Crab_> fendrin: and since the macroses for setting leader goal are generic, I'll need to copy them
20110811 23:23:52< Crab_> fendrin: thus, each place in LoW which will want to use the 'move here always' behavior will need to be changed from {AI_ASPECT_LEADER_GOAL_MOVE_TO X Y} to the other macro
20110811 23:26:29-!- wesbot changed the topic of #wesnoth-dev to: 191 bugs, 327 feature requests, 20 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110811 23:26:48< anonymissimus> Espreon: that was a duplicate sry
20110811 23:26:58< Espreon> Blargh...
20110811 23:35:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20110811 23:35:29< anonymissimus> we get down to 18* and even without silene^^
20110811 23:36:19< CIA-57> crab * r50712 /trunk/ (changelog data/core/macros/ai.cfg): Fix bug #18122: AI leaders set to defensive will now follow human-set leader goals anyway, even to the death.
20110811 23:42:33-!- Unnheulu [~ieuan@host86-180-11-31.range86-180.btcentralplus.com] has quit [Quit: Ex-Chat]
20110811 23:43:36-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection]
20110811 23:44:38-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has joined #wesnoth-dev
20110811 23:44:46-!- deekay [~dk@89-79-35-236.dynamic.chello.pl] has quit [Changing host]
20110811 23:44:46-!- deekay [~dk@wesnoth/developer/dragonking] has joined #wesnoth-dev
20110811 23:47:05< CIA-57> espreon * r50713 /trunk/utils/umc_dev/ (108 files in 36 dirs): Set svn:eol-style; ran dos2unix.
20110811 23:47:55< Espreon> timotei will probably greet me with a nice, warm hug tomorrow!
20110811 23:49:33< CIA-57> espreon * r50714 /trunk/utils/umc_dev/ (11 files in 2 dirs): Set svn:mime-type.
20110811 23:52:21< anonymissimus> good you excluded projectfiles/VC*
20110811 23:56:01< CIA-57> espreon * r50715 /trunk/utils/umc_dev/ (13 files in 8 dirs): Set svn:eol-style.
20110811 23:57:46-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
20110811 23:59:08-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
--- Log closed Fri Aug 12 00:00:12 2011