--- Log opened Sat Sep 10 00:00:30 2011
20110910 00:08:04< anonymissimus> Espreon: I just got your lua errors in the test scenario :|
20110910 00:08:14< Espreon> Yay.
20110910 00:18:19< anonymissimus> thonsew: ok so far, seems the MSVC debuggers work again; I must have had some old objects floating around in VC9
20110910 00:18:57< anonymissimus> good job
20110910 00:20:49< fendrin> anonymissimus: Are you aware about the lua errors, thrown by the test scenario?
20110910 00:21:05< Espreon> ... He is.
20110910 00:22:07< anonymissimus> I am, and if I have to guess it's caused by thonsew's config modifications ;)
20110910 00:22:54< fendrin> It's good to see wesnoth being broken by anyone but me. :-)
20110910 00:24:57< fendrin> anonymissimus: Aren't you the expert on location filters?
20110910 00:27:13< anonymissimus> Espreon: , fendrin if you find a better testcase for this (that is, more minimal) then please make a report
20110910 00:27:39< Espreon> OK.
20110910 00:28:58< anonymissimus> as far as I see it is triggered by a call to modify_unit, but most likely the problem is somewhere in the call stack of wesnoth.set_variable, so config-related
20110910 00:29:44< anonymissimus> modify_unit is just a wrapper which passes everything to wesnoth.set_variable
20110910 00:30:13< anonymissimus> so not a lua error, it's just propagated and looks like it
20110910 00:30:37< anonymissimus> the second one may have the same cause
20110910 00:30:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20110910 00:31:33< fendrin> anonymissimus: Do you have an idea where the standard location filter does the processing of the "time_of_day" attribute?
20110910 00:35:53< anonymissimus> fendrin: I'd have to search, no
20110910 00:42:17< anonymissimus> fendrin: seems it's done in terrain_filter.cpp line 237ff
20110910 00:43:15< anonymissimus> you want an exampe code for the alignments I guess
20110910 00:43:43< fendrin> I was not sure if the current filter system can handle liminal.
20110910 00:44:05< fendrin> But for the purpose of the "time_of_day" attribute liminal seems to equal neutral.
20110910 00:47:11-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 252 seconds]
20110910 00:48:23-!- horon_ [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20110910 00:55:18< anonymissimus> if only powershot wouldn't be careful enough for shadowmaster not to find a valid enough reason to ban him :|
20110910 00:57:40< enchilado> :P
20110910 01:17:51< CIA-22> fendrin * r51109 /trunk/src/terrain_filter.cpp: Added support for the time_of_day=liminal attribute in standard location filters.
20110910 01:23:24< anonymissimus> thonsew: pls do not write code like this { ... }
20110910 01:23:29< anonymissimus> it is a pain
20110910 01:23:46< anonymissimus> i'd really like to set breakpoints into that
20110910 01:24:43< anonymissimus> especially in the .hpp getters and setters
20110910 01:26:28< anonymissimus> uh, just found that breakpoints work there, in MSVC10 at least :)
20110910 01:31:45< anonymissimus> but it still stops only for the complete function no matter what
20110910 01:34:27-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20110910 01:36:08-!- Talad is now known as Talad|ZzZ
20110910 01:43:02< shadowmaster> anonymissimus: give me a valid reason to ban him
20110910 01:43:07< shadowmaster> ban him again, that is
20110910 01:43:51-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110910 01:44:05< fendrin> shadowmaster: Just his amount of posts. He has done nearly 1000 posts in quarter a year.
20110910 01:45:30< shadowmaster> as much as I'd love to ban people just because they annoy me, banning him once got me some criticism from an amount of moderators already
20110910 01:47:19< shadowmaster> if you look at the situation from an objective point of view, he's just an inoffensive kid
20110910 01:48:05< anonymissimus> i wonder how old he is, actually xD
20110910 01:48:08< shadowmaster> and AFAIK his current posts are on-topic (if that's not the case then why the fuck aren't you posting in the forum that's designed for that purpose?)
20110910 01:49:14< anonymissimus> posts like this http://forums.wesnoth.org/viewtopic.php?p=506351#p506351 are completely pointless
20110910 01:50:05< anonymissimus> i refrained from posting a moderator-like critics for it
20110910 01:51:07< anonymissimus> when you see last poster = powershot, dont bother looking into the thread xD
20110910 01:52:01< Espreon> anonymissimus: Maybe you could look into this: https://gna.org/bugs/?18625 ... It's really pissing me off.
20110910 01:52:44-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Read error: Connection reset by peer]
20110910 01:52:50-!- crimson_penguin [~ben@184.71.170.250] has joined #wesnoth-dev
20110910 01:52:50-!- crimson_penguin [~ben@184.71.170.250] has quit [Changing host]
20110910 01:52:50-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110910 01:53:35< anonymissimus> Espreon: why don't YOU look into it ?
20110910 01:54:12< anonymissimus> guessing wildly it could be caused by gabba's commit lately
20110910 01:54:19-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has joined #wesnoth-dev
20110910 01:54:27< anonymissimus> waypoint removal
20110910 01:54:45< Espreon> You know why I can't deal with it.
20110910 01:55:15< anonymissimus> why is a gunction from whiteboard called when the editor is open ?
20110910 01:55:34< Espreon> Exactly.
20110910 01:55:46< Espreon> Why do such a thing?
20110910 01:55:57< anonymissimus> thats probably the key question, probably not too hard to fix
20110910 01:56:11< anonymissimus> so you may assign to tschmitz or gabba
20110910 01:57:28< Espreon> Yeah.
20110910 01:58:16< anonymissimus> well, maybe it's as easy as inserting a if whiteboard is active then else at teh right spot
20110910 01:59:09< shadowmaster> anonymissimus: it's really bad that you refrain from posting in the mods forum. I am not sure how else I'm supposed to find out about problem users.
20110910 02:06:15< anonymissimus> shadowmaster: I don't get what you mean
20110910 02:06:45< anonymissimus> I would have posted in that thread saying to powershot he shouldnt make such pointless posts
20110910 02:07:26< anonymissimus> Espreon: well there should be somewhere a boolean indicating whether the editor is active
20110910 02:08:27< anonymissimus> and that should probably be used in hotkeys.cpp line 926
20110910 02:09:02< shadowmaster> anonymissimus: I said mods forum. If you don't like a user for a non-subjective reason you can post in there.
20110910 02:09:04< anonymissimus> so if we are in the editor, dont call on_key_event from the whiteboard
20110910 02:10:25< anonymissimus> shadowmaster: well, like you said, you may remove the mod powers from the dev group some day, and I don't see me as a mod
20110910 02:11:03< shadowmaster> that is completely irrelevant for posting in there
20110910 02:11:42< shadowmaster> I did say that I'd do that if I ever got enough moderators and it doesn't take much to realize we are still very far from that point
20110910 02:15:08< anonymissimus> in any case I'm doing enough as a dev
20110910 02:15:20< anonymissimus> forum moderating is others job
20110910 02:15:31< anonymissimus> yours xD
20110910 02:16:08< shadowmaster> not mine; also this is no matter for laughing
20110910 02:37:04< anonymissimus> Espreon: well, it doesnt seem that easy to fix
20110910 02:38:03< anonymissimus> maybe it should be fixed by moving that call to a later place, since afaik the call stack splits depending on whether we are in the game or editor to separate functions processing the pressed hotkeys
20110910 02:40:21< anonymissimus> while the common part is handled first
20110910 02:40:48< anonymissimus> there is somce derivation there, one of those things I don't grasp :P
20110910 02:41:27-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20110910 03:01:10-!- happygrue [~George@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20110910 03:06:10-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20110910 03:10:08-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 260 seconds]
20110910 03:10:55< anonymissimus> Espreon: as for the lua errors in the test scenario, teh first one at least is for sure due to thonsew
20110910 03:11:25< anonymissimus> I'm off, bye
20110910 03:11:31-!- anonymissimus [~chatzilla@HSI-KBW-046-005-024-128.hsi8.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20110910 03:30:28-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has joined #wesnoth-dev
20110910 03:30:28-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has quit [Changing host]
20110910 03:30:28-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20110910 03:34:51-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20110910 03:57:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 04:05:50-!- Ivanovic_ [~ivanovic@dtmd-4db2ba29.pool.mediaWays.net] has joined #wesnoth-dev
20110910 04:05:50-!- Ivanovic_ [~ivanovic@dtmd-4db2ba29.pool.mediaWays.net] has quit [Changing host]
20110910 04:05:50-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110910 04:09:34-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds]
20110910 04:09:56-!- Ivanovic_ is now known as Ivanovic
20110910 04:15:23-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110910 04:17:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20110910 04:18:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 04:19:11-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds]
20110910 04:33:17-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Read error: Connection reset by peer]
20110910 04:33:32-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110910 04:33:32-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has quit [Changing host]
20110910 04:33:32-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20110910 05:07:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: testing something]
20110910 05:09:54-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 276 seconds]
20110910 05:14:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110910 05:15:27-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Client Quit]
20110910 05:16:10-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110910 05:21:50< Espreon> wesbot: update
20110910 05:21:57< Espreon> Wait, what was it again?
20110910 05:22:24< Gambit> wesbot: topic
20110910 05:22:24< Espreon> wesbot: topic
20110910 05:22:25-!- wesbot changed the topic of #wesnoth-dev to: 182 bugs, 331 feature requests, 18 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110910 05:22:28-!- wesbot changed the topic of #wesnoth-dev to: 182 bugs, 331 feature requests, 18 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110910 05:22:37-!- horon_ [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20110910 05:25:54-!- noy_ [~Noy@74.198.151.8] has joined #wesnoth-dev
20110910 05:25:54-!- noy_ [~Noy@74.198.151.8] has quit [Changing host]
20110910 05:25:54-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 05:28:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20110910 05:28:50-!- noy_ is now known as noy
20110910 05:47:58-!- Nephro [~neph@80.233.231.12] has quit [Ping timeout: 260 seconds]
20110910 05:53:33-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110910 06:07:17-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 06:08:16< Espreon> gabba: Did you notice that bug I assigned to you?
20110910 06:10:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 252 seconds]
20110910 06:10:23-!- noy_ is now known as noy
20110910 06:25:06< gabba> Espreon: if you did it today, probably not yet
20110910 06:26:29< gabba> wesbot: bug #18625
20110910 06:26:29< wesbot> Bug #18625  Assigned to: Gabriel M. <gabba>  Status: None  Priority: 7 - High
20110910 06:26:32< wesbot> Summary: The editor segfaults when any key is pressed
20110910 06:26:35< wesbot> Original submission: To reproduce, just start the editor and press any key and
20110910 06:26:38< wesbot>  it should segfault.Backtrace:Program received signal SIGSEGV, Segmentat
20110910 06:26:40< wesbot> URL: https://gna.org/bugs/?18625
20110910 06:32:24< gabba> Espreon: it doesn't segfault for me, but I'll take a shot at the probable problem
20110910 06:34:24< enchilado> When I try to place void tiles in 1.8 it segfaults :S
20110910 06:35:41< gabba> enchilado, that must be an old bug, file it on gna!
20110910 06:36:36< gabba> Stuff can go unnoticed for years if nobody makes the effort to file them
20110910 06:36:42< enchilado> It could be an Ubuntu bug - I'm using 11.10 beta :S
20110910 06:42:20-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20110910 06:57:25< CIA-22> gabba * r51110 /trunk/src/whiteboard/manager.cpp: Prevent null key poller from being used, should fix bug #18625.
20110910 06:57:48< gabba> Espreon: ^, please try it now if you can and tell me if the problem's gone
20110910 06:58:55< Espreon> OK.
20110910 07:00:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20110910 07:03:18< Espreon> gabba: It didn't fix it.
20110910 07:03:31< gabba> gah
20110910 07:04:07< gabba> Espreon: do you get the same backtrace?
20110910 07:04:48< Espreon> Sigh... lemme get one.
20110910 07:05:12< gabba> Espreon, wait
20110910 07:05:35< gabba> Let me try something else before you have fun with gdb, mmkay?
20110910 07:06:06< Espreon> Well, too late.
20110910 07:06:38< Espreon> gabba: http://pastebin.com/0zf7C202
20110910 07:06:53< gabba> ok, thanks then and sorry for the trouble
20110910 07:16:20< Espreon> No prob.
20110910 07:42:49-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20110910 07:43:36-!- timotei [timotei@193.34.190.70] has joined #wesnoth-dev
20110910 07:43:36-!- timotei [timotei@193.34.190.70] has quit [Changing host]
20110910 07:43:36-!- timotei [timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20110910 07:44:12< Espreon> gabba: So, when will you kill this annoying bug?
20110910 07:44:51< gabba> Espreon: in a few minutes. I found the cause, but it's forcing me to rethink how I handle some stuff - hence the delay
20110910 07:45:00< Espreon> Ah.
20110910 07:49:56< CIA-22> gabba * r51111 /trunk/src/hotkeys.cpp: 
20110910 07:49:56< CIA-22> Remove my current way of polling the Tab key since it introduces a whiteboard dependency at the wrong place and gets called even if the wb isn't initialized, such as when using the editor.
20110910 07:49:56< CIA-22> Really fixes bug #18625.
20110910 07:50:28< gabba> Espreon: this doesn't fix my whole problem, but it fixes your editor crash
20110910 07:52:37< Espreon> OK.
20110910 07:59:00< Espreon> gabba: And it does indeed fix the crash.
20110910 07:59:04< Espreon> Thanks.
20110910 07:59:22< gabba> No problem.
20110910 08:03:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110910 08:05:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 08:24:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20110910 08:38:14-!- vultraz [~chatzilla@124.109.10.221] has quit [Read error: No route to host]
20110910 08:40:57-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20110910 09:00:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110910 09:00:56-!- dtiger [~dtiger@dynamic-vpdn-91-149-132-76.telecom.by] has joined #wesnoth-dev
20110910 09:04:22-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20110910 09:14:48-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20110910 09:18:39-!- stikonas [~gentoo@79.132.164.89] has joined #wesnoth-dev
20110910 09:18:39-!- stikonas [~gentoo@79.132.164.89] has quit [Changing host]
20110910 09:18:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 09:19:23< CIA-22> thonsew * r51113 /trunk/src/game_events.cpp: 
20110910 09:19:23< CIA-22> Workaround for bug #18626 crash when attempting to [kill]x,y=14,6. Somehow the
20110910 09:19:23< CIA-22> t_string reference is binding to a temporary t_string. This hack only fixes the
20110910 09:19:23< CIA-22> immediate problem, but not using a reference. The underlying problem needs more
20110910 09:19:23< CIA-22> work.
20110910 09:19:26< CIA-22> thonsew * r51112 /trunk/src/ (7 files): 
20110910 09:19:26< CIA-22> Fix for bug #18627.
20110910 09:19:26< CIA-22> Changed assertion to a wml_syntax_exception that provides an error to user informing them of invalid wml syntax and then continues with the variable marked as invalid.
20110910 09:20:29< Ivanovic> moin
20110910 09:29:14< CIA-22> espreon * r51114 /trunk/src/exceptions.cpp: Ran umcpropfix.
20110910 09:48:17-!- Crendgrim [~crend@77-22-155-217-dynip.superkabel.de] has joined #wesnoth-dev
20110910 09:51:44< gabba> morning Ivanovic
20110910 09:52:40< Ivanovic> wesbot: seen nephro
20110910 09:52:40< wesbot> Ivanovic: The person with the nick Nephro last spoke 2d 18h ago.  4h 4m ago they left with the message: Ping timeout: 260 seconds
20110910 09:52:58< Ivanovic> nephro: do not forget to upload your code samples to google!
20110910 09:53:08< Ivanovic> at the moment your sample is missing
20110910 09:53:29< Ivanovic> cf http://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2011/codeguidelines
20110910 10:00:05-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Read error: No route to host]
20110910 10:00:17-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110910 10:00:17-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has quit [Changing host]
20110910 10:00:17-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20110910 10:20:30< CIA-22> gabba * r51115 /trunk/src/whiteboard/ (manager.cpp manager.hpp): Completely removed the whiteboard's tab key polling, as the problem that warranted the workaround now seems fixed.
20110910 10:26:44-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110910 10:30:37-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20110910 10:47:21-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Quit: Lost terminal]
20110910 10:48:44-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110910 10:48:44-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has quit [Changing host]
20110910 10:48:44-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20110910 10:48:55-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Client Quit]
20110910 10:50:39-!- Octalot [~noct@host86-182-33-109.range86-182.btcentralplus.com] has quit [Remote host closed the connection]
20110910 10:51:29-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has joined #wesnoth-dev
20110910 10:51:29-!- enchilado [~enchilado@ppp118-208-12-112.lns20.bne1.internode.on.net] has quit [Changing host]
20110910 10:51:29-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20110910 11:02:36-!- Crendgrim [~crend@77-22-155-217-dynip.superkabel.de] has quit [Quit: ...]
20110910 11:06:57< CIA-22> gabba * r51116 /trunk/src/mouse_events.cpp: 
20110910 11:06:57< CIA-22> Stop incorrectly highlighting adjacent enemy's hexes when selecting a unit
20110910 11:06:57< CIA-22> that's out of attacks. The bug was introduced in revision #44834. I'm not sure
20110910 11:06:57< CIA-22> what was alink's intention but AFAICS I'm not breaking anything by reinstating
20110910 11:06:57< CIA-22> this check.
20110910 11:06:58< CIA-22> Fixes bug #16652.
20110910 11:07:59< Espreon> shikadibot: log 44834
20110910 11:08:01< shikadibot> Espreon: Revision 44834 (alink) on Thu Jul 29 01:02:16 2010:
20110910 11:08:01< shikadibot> Espreon: Fix move+attack not interrupted if ambushed at destination.
20110910 11:08:01< shikadibot> Espreon: Works by scanning adjacent enemies before and after move, so it could detect
20110910 11:08:04< shikadibot> Espreon: other cases than simple ambush (WML events).
20110910 11:08:05< shikadibot> Espreon: Web interface URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=44834
20110910 11:30:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20110910 11:39:08-!- negusnyul [~negusnyul@183-86-125.ip.adsl.hu] has joined #wesnoth-dev
20110910 11:48:49-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20110910 11:50:18-!- negusnyul [~negusnyul@183-86-125.ip.adsl.hu] has quit [Ping timeout: 260 seconds]
20110910 11:50:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20110910 11:58:09-!- horon [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20110910 12:04:07-!- loonybot [~loonybot@ppp109-252-50-3.pppoe.spdop.ru] has joined #wesnoth-dev
20110910 12:04:07-!- loonybot [~loonybot@ppp109-252-50-3.pppoe.spdop.ru] has quit [Changing host]
20110910 12:04:07-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20110910 12:04:33-!- negusnyul [~negusnyul@dsl540211C9.pool.t-online.hu] has joined #wesnoth-dev
20110910 12:25:00-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20110910 12:31:53-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20110910 12:58:19-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20110910 13:04:47-!- wesbot changed the topic of #wesnoth-dev to: 181 bugs, 331 feature requests, 18 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110910 13:07:57-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20110910 13:07:57-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20110910 13:07:57-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20110910 13:08:12< mordante> servus
20110910 13:14:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 13:17:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20110910 13:20:54< mordante> thonsew we use /** */ style of doxygen comment could you please use the same style?
20110910 13:24:24< CIA-22> mordante * r51117 /trunk/src/dialogs.cpp: Fix compilation with -DLOW_MEM.
20110910 13:25:56< mordante> thonsew also wonder whether there isn't a better was as using static_casts all over the place^
20110910 13:32:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110910 13:36:19-!- stikonas [~and@79.132.164.89] has joined #wesnoth-dev
20110910 13:36:19-!- stikonas [~and@79.132.164.89] has quit [Changing host]
20110910 13:36:19-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 13:38:26< Soliton> did some recent changes change WML attribute ordering? this breaks multiplayer.
20110910 13:39:12< mordante> you mean the ordering of the keys in WML?
20110910 13:39:20< Soliton> indeed.
20110910 13:39:45< mordante> thonsew did several changes to the config class, it might be related
20110910 13:40:03< mordante> not sure what he exactly changed, but he added hashing at several places
20110910 13:51:56< CIA-22> mordante * r51119 /trunk/src/serialization/tokenizer.hpp: Initialize all members.
20110910 13:52:00< CIA-22> mordante * r51118 /trunk/src/formula_string_utils_backend.hpp: Added constructor to initialize all members.
20110910 13:52:00< CIA-22> mordante * r51120 /trunk/src/utils/interned.hpp: Initialize all members.
20110910 13:52:04< CIA-22> mordante * r51121 /trunk/src/utils/interned.hpp: Initialize all members.
20110910 13:52:08< CIA-22> mordante * r51122 /trunk/src/serialization/tokenizer.hpp: 
20110910 13:52:08< CIA-22> Initialize all members.
20110910 13:52:08< CIA-22> thonsew please review whether the intention was default or copy for
20110910 13:52:08< CIA-22> these members.
20110910 13:52:11< CIA-22> mordante * r51123 /trunk/src/formula_string_utils_backend.cpp: Initialize all members.
20110910 13:52:15< CIA-22> mordante * r51124 /trunk/src/formula_string_utils_backend.cpp: Initialize all members.
20110910 13:52:20< CIA-22> mordante * r51125 /trunk/src/ (43 files in 8 dirs): Strip trailing whitespace.
20110910 14:00:36-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Read error: Connection reset by peer]
20110910 14:16:32-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20110910 14:29:47-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110910 14:32:48-!- stikonas [~gentoo@79.132.164.89] has joined #wesnoth-dev
20110910 14:32:48-!- stikonas [~gentoo@79.132.164.89] has quit [Changing host]
20110910 14:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 14:39:51-!- Gambit [~Gambit@pa-184-5-186-26.dhcp.embarqhsd.net] has joined #wesnoth-dev
20110910 14:39:54-!- Gambit [~Gambit@pa-184-5-186-26.dhcp.embarqhsd.net] has quit [Changing host]
20110910 14:39:54-!- Gambit [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20110910 14:47:14-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20110910 14:50:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20110910 15:03:14-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has joined #wesnoth-dev
20110910 15:05:50-!- anonymissimus [~chatzilla@HSI-KBW-046-005-024-128.hsi8.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20110910 15:06:05-!- Talad|ZzZ is now known as Talad
20110910 15:06:45< anonymissimus> thonsew: why in game_events.cpp line 2190 there are t_strings ?
20110910 15:06:57< anonymissimus> these values are nto meant to be translatable
20110910 15:08:25< anonymissimus> they are either (that is, should be) valid integers matching an on-map location, or the string "recall", non-translatable, so a t_string on teh C++ side doesnt make any sense
20110910 15:15:22-!- Sarcasm [~user@163.5.175.173] has joined #wesnoth-dev
20110910 15:15:23-!- Sarcasm [~user@163.5.175.173] has quit [Client Quit]
20110910 15:19:22-!- horon [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20110910 15:44:19-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20110910 15:53:45-!- mjs-de [~mjs-de@e182045183.adsl.alicedsl.de] has joined #wesnoth-dev
20110910 16:09:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 16:14:06-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Ping timeout: 252 seconds]
20110910 16:20:50-!- Crendgrim [~crend@77-22-155-217-dynip.superkabel.de] has joined #wesnoth-dev
20110910 16:53:32-!- vultraz_ubuntu [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20110910 17:20:35< Crendgrim> did anyone ever say that Wesnoth 1.9 had better error messages? :/ "error scripting/lua: Mandatory WML child missing yet untested for. Please report." and a backtrace from the core lua files. sigh.
20110910 17:21:58< mordante> jup lot of Lua errors recently
20110910 17:22:24< mordante> at least if the user does as asked we learn about the issue :-P
20110910 17:23:19< CIA-22> ivanovic * r51126 /trunk/ (8 files in 5 dirs): updated Indonesian and Italian translation
20110910 17:23:23-!- mjs-de [~mjs-de@e182045183.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20110910 17:24:06< Crendgrim> I was just trying to revert my most recent changes to see if it helps..
20110910 17:24:11-!- Elvish_Hunter [6d36e335@gateway/web/freenode/ip.109.54.227.53] has joined #wesnoth-dev
20110910 17:25:05< Crendgrim> mordante: http://pastebin.com/gpqK4izS
20110910 17:25:25< Crendgrim> (svn r51125)
20110910 17:27:30< Crendgrim> not reproducable with 1.9.9, so it was probably caused by a rather recent commit (as it didn't occur yesterday either)
20110910 17:28:00< anonymissimus> Crendgrim: most likely die to thonsew's config changes
20110910 17:28:04< anonymissimus> due
20110910 17:28:05< Soliton> that's not a user error so unrelated to 1.9 having better error messages.
20110910 17:28:23< Crendgrim> hey, that was a joke :p
20110910 17:28:30< Crendgrim> (well, it was meant to be one.)
20110910 17:29:19< anonymissimus> I already made a similar report, so you can just bother thonsew to fix his bugs ;)
20110910 17:32:57< Crendgrim> anonymissimus: which of the many assigned to thonsew is it?
20110910 17:33:40< anonymissimus> #buf 18631
20110910 17:33:49< anonymissimus> #bug 18631
20110910 17:33:57< Crendgrim> thanks
20110910 17:33:58< mordante> yup get that issue here as well
20110910 17:34:19< anonymissimus> wesbot: bug 18631
20110910 17:34:19< wesbot> Bug #18631  Assigned to: Thonsew <thonsew>  Status: None  Priority: 5 - Normal
20110910 17:34:22< wesbot> Summary: lua error in the test scenario (#1)
20110910 17:34:25< wesbot> Original submission: At the start of the test scenario there is a new "lua" er
20110910 17:34:28< wesbot> ror. Originally found by Espreon. It is triggered by the call to [modify_unit], 
20110910 17:34:31< wesbot> URL: https://gna.org/bugs/?18631
20110910 17:35:32< Crendgrim> note to self: never update both your work and wesnoth before trying whether everything works as expected, or you end up wondering what you did wrong this time...
20110910 17:35:49-!- mjs-de [~mjs-de@g224185188.adsl.alicedsl.de] has joined #wesnoth-dev
20110910 17:37:03< anonymissimus> I've seen "mandatory wml child missing" caused by various things though, but all of these here have probably teh same cause
20110910 17:42:43-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has joined #wesnoth-dev
20110910 17:43:14< thonsew> good day.
20110910 17:43:26< mordante> hi thonsew 
20110910 17:43:42< thonsew> mordnate: I changed the static_casts to operator*() dereferencing.  My original intent was to gaurrantee that the programmer (me)explicitly thought about each cast to prevent spurious string creation which caused the slow down in the first place.
20110910 17:44:27-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20110910 17:44:57< mordante> thonsew, but adding an operator+ or something, won't that do the trick
20110910 17:45:40< mordante> IMHO these casts look `wrong' as if you do something not intended
20110910 17:46:50< thonsew> I also added a + operator, but that has to create temporary object and you pay the allocation and construction costs.  The + operator I want for sure to require a static_cast, otherwise people can silently  concatenate string and we return to the same original condition.
20110910 17:47:06-!- Nephro [~neph@80.233.231.12] has joined #wesnoth-dev
20110910 17:47:07< thonsew> I agree that it looks wrong.
20110910 17:47:14< fendrin> thonsew: I think one of the biggest problems right now is that the editor crashes at any keypress. 
20110910 17:47:47< fendrin> thonsew: Oh, gabba fixed it recently, don't mind. I thought it was a consequence of your commits.
20110910 17:47:48< thonsew> I think it is wrong in the cases where the operator*() allows a simple replacement of the static cast
20110910 17:48:36< thonsew> fendrin: That problem was due to the whiteboard and gabba fixed it yesterday.
20110910 17:49:33< fendrin> thonsew: Yeah, sorry.
20110910 17:50:23< thonsew> fendrin:  No problem.  Much has been broken, mostly but not all due to me.  That's why I waited until just after 1.9.9.
20110910 17:50:31-!- noy_ [~Noy@74.198.151.108] has joined #wesnoth-dev
20110910 17:50:31-!- noy_ [~Noy@74.198.151.108] has quit [Changing host]
20110910 17:50:31-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20110910 17:51:02< thonsew> mordante, anonymissimus: Formatting that we don't like ///, {code}.  I will remove these as I go along.
20110910 17:52:19< mordante> thanks
20110910 17:52:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 276 seconds]
20110910 17:52:41-!- noy_ is now known as noy
20110910 17:53:36< thonsew> mordante, once I've replaced all of the static_casts that can be replaced by (*z_whatever) I think that it will be clear that t_tokens are immutable and changes require constructing a new token.  Then most, maybe all of the static_casts will be gone, leaving only some constructors when a mutable operation happens.
20110910 17:54:22< thonsew> It will look right.
20110910 17:54:39< mordante> how feasible would be to add a str() member function, which does the job?
20110910 17:54:41-!- negusnyul [~negusnyul@dsl540211C9.pool.t-online.hu] has quit [Remote host closed the connection]
20110910 17:55:01< thonsew> trivial
20110910 17:55:05-!- negusnyul [~negusnyul@dsl540211C9.pool.t-online.hu] has joined #wesnoth-dev
20110910 17:55:30< mordante> maybe that instead of the static_cast
20110910 17:55:56< mordante> then you explicitly ask for the string and avoid the casts
20110910 17:56:55< thonsew> That was effectively what the cast was doing, but I agree conditioning people to accept casts a acceptable code is bad form.
20110910 17:57:37-!- Elvish_Hunter [6d36e335@gateway/web/freenode/ip.109.54.227.53] has quit []
20110910 17:57:38< mordante> yeah, that's why I dislike casts in this fashion
20110910 18:00:47< thonsew> anonymissimus:  line 2190 was set to t_string by ai0867.  I didn't know the expected syntax so I left it that way.
20110910 18:02:21< anonymissimus> thonsew: which revision was that ?
20110910 18:03:46< anonymissimus> it should be std::string or maybe now a token
20110910 18:03:54< anonymissimus> mbut certaibnly not t_string
20110910 18:04:15< thonsew> Revision 40413
20110910 18:04:29< anonymissimus> wesbot: log 40413
20110910 18:04:30< wesbot> ai0867 * r40413 : Fix indentation in game_events.cpp
20110910 18:04:30< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=40413
20110910 18:06:02< anonymissimus> um long ago
20110910 18:06:25< anonymissimus> ok then
20110910 18:08:36< thonsew> anonymissimus: Do you think the best example of newly introduced lua bug is the one from the wesnoth -test
20110910 18:11:39< thonsew> Soliton:  I don't think that I changed the ordering of the ordered keys in config.  They were and still are a vector.  What specifically is broken.  If you write up a bug with a test case, then I will fix it.
20110910 18:12:42< anonymissimus> thonsew: IDK, maybe
20110910 18:12:58< anonymissimus> I already worked a bit on it however, as you can see
20110910 18:13:18< CIA-22> mordante * r51127 /trunk/src/config.cpp: Avoid copying a singular iterator.
20110910 18:13:21< CIA-22> mordante * r51128 /trunk/src/commandline_options.cpp: 
20110910 18:13:21< CIA-22> Avoid wrongly using the debug-dot-level parameter.
20110910 18:13:21< CIA-22> It was assigned to debug_dot_domain instead. This led to an error in the
20110910 18:13:21< CIA-22> unit_tests.
20110910 18:13:25< CIA-22> mordante * r51129 /trunk/src/tests/test_network_worker.cpp: 
20110910 18:13:25< CIA-22> Reenable a unit test.
20110910 18:13:25< CIA-22> Since ANA won't be used as main network library any time soon re-enable
20110910 18:13:25< CIA-22> the test.
20110910 18:13:25< thonsew> maybe is good enough for me.  I'll start there.
20110910 18:13:26< CIA-22> mordante * r51130 /trunk/ (changelog src/network_worker.cpp): (log message trimmed)
20110910 18:13:26< CIA-22> Fixed compilation on all Debian architectures.
20110910 18:13:26< CIA-22> The #undef was introduced in r47336, but the commit offers no reason
20110910 18:13:26< CIA-22> _why_ the macro was undefined. This patch has been tested by Rhonda on
20110910 18:13:27< CIA-22> all Debian architectures and there it caused no build problem, whereas
20110910 18:13:27< CIA-22> the r47336 caused several architectures failing to build.
20110910 18:13:28< CIA-22> The reason the issue was spotted much later is that before Debian
20110910 18:14:17< mordante> thonsew did you see the message I left for you in the commit log earlier today?
20110910 18:14:33< Rhonda> you write too long commit messages for CIA :)
20110910 18:14:40< anonymissimus> thonsew: you can just copy the call to [modify_unit] from the test scenario like I did
20110910 18:14:50< Rhonda> wesbot: r51130
20110910 18:14:56< Rhonda> wesbot: revision r51130
20110910 18:14:59< anonymissimus> or put the pasted code from teh bug report into any scenario
20110910 18:15:13< anonymissimus> wesbot: log 51130
20110910 18:15:14< wesbot> mordante * r51130 : Fixed compilation on all Debian architectures.The #undef was introduced in r47336, but the commit offers no reason_why_ the macro was undefined. This patch has been tested by Rhonda onall Debian architectures and there it caused no build problem, whereasthe r47336 caused several architectures failing to build.The reason the issue was spotted much later is that before Debiancompiled with the ANA network. It switched to the
20110910 18:15:17< thonsew> mordante: Which comment?
20110910 18:15:21< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=51130
20110910 18:15:49< Rhonda> ah, log
20110910 18:16:00< Rhonda> And I think it's still cut :)
20110910 18:16:24< Rhonda> mordante, and … I thought I disabled ana in the package?
20110910 18:16:43< mordante> Rhonda, will mail the debian bug report as well
20110910 18:16:53< mordante> Rhonda, you did in cmake, but not in autotools
20110910 18:17:01< Rhonda> I am certain I did.
20110910 18:17:37< thonsew> mordante:  To check the initializers that you fixed for me.  Yes I saw the comment.  Thanks for fixing them.  I will get cppcheck working.  I think I just have some system header problems.
20110910 18:17:38< mordante> then autotools knew better and decided to compile ANA any way :-P
20110910 18:17:54< Rhonda> it gave me troubles with autotools too
20110910 18:18:00< mordante> odd
20110910 18:18:18< mordante> thonsew, ok, just wasn't sure what was the intention for that copy-ctor
20110910 18:19:13< Rhonda> Wait, wasn't ana disabled by default?
20110910 18:19:40< CIA-22> fendrin * r51131 /trunk/data/campaigns/Legend_of_Wesmere/maps/Kalian.map: LoW 3+7: Tiny change to the map.
20110910 18:19:40< mordante> not sure at that time, but maybe not in autotools
20110910 18:19:45< Rhonda> ah, hmm#
20110910 18:19:55< Rhonda>   * Switch off USE_ANA_NETWORK, it makes the server segfault.
20110910 18:20:03< Rhonda> Right, that was when I switched to cmake.
20110910 18:20:22< mordante> oh ok
20110910 18:20:48< mordante> I was sure I checked the debian build logs to see whether the network_worker.cpp was compiled with autotools
20110910 18:21:07< mordante> btw really nice Debian keeps those logs around, saved me a lot of time :-)
20110910 18:21:49< Rhonda> :)
20110910 18:22:12< Rhonda> Doesn't cost much, so we keep stuff.
20110910 18:24:59< Soliton> thonsew: start a network game on wesnothd. (if you manage to login.)
20110910 18:25:06< CIA-22> thonsew * r51132 /trunk/src/serialization/tokenizer.hpp: Fixed copy constructor to copy everything, as per mordante's observation.
20110910 18:26:42< thonsew> Soliton:  Therein lies the problem.  I haven't played a network game.  I'll add it to my list.
20110910 18:28:51< thonsew> Soliton:  What ordering do you think changed?
20110910 18:30:16< thonsew> Soliton:  Can you start a network game and then pastebin the resulting errors?
20110910 18:31:01< Soliton> 20110910 18:23:51 error config: attributes: 'turns' < 'map_data'
20110910 18:31:01< Soliton> 20110910 18:23:51 error config: ERROR: 'attributes not in order'
20110910 18:31:21-!- Sirp [~user@pool-173-74-15-196.dllstx.fios.verizon.net] has quit [Ping timeout: 276 seconds]
20110910 18:33:23< Soliton> the server uses a different WML implementation (simple_wml) which requires attributes to be in order.
20110910 18:34:55< thonsew> At what what point.  If it is using a different object then the requirement can only be on the transmission ordering of the attributes, not the internal representation.
20110910 18:35:46< thonsew> I say can only, when I mean my completely uninformed guess, as I haven't looked at the wesnothd code.
20110910 18:36:14< Soliton> sure.
20110910 18:36:56< Soliton> it's about the WML it gets sent from wesnoth.
20110910 18:37:27< thonsew> Do you know why the server is using a different object, that seems to have guaranteed that if/when the config object is changed in wesnoth wesnothd breaks.
20110910 18:40:16< Soliton> changing the config object in externally visible ways will break all kinds of things.
20110910 18:40:38< Soliton> the server uses simple_wml for performance reasons.
20110910 18:42:35-!- Sirp [~user@pool-173-74-15-196.dllstx.fios.verizon.net] has joined #wesnoth-dev
20110910 18:42:58< thonsew> I'll make a bug report and fix it.
20110910 18:43:11< Soliton> thanks.
20110910 19:03:51-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 276 seconds]
20110910 19:04:47-!- wesbot changed the topic of #wesnoth-dev to: 183 bugs, 331 feature requests, 18 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20110910 19:07:50< zookeeper> i haven't ran any tests myself, but i _suspect_ someone's broken some WML handling: http://forums.wesnoth.org/viewtopic.php?f=4&t=34971&p=506426 of course, it could also be a genuine AI bug.
20110910 19:07:58-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20110910 19:09:10< zookeeper> i'll try to run some tests on that later tonight if no one beats me to it.
20110910 19:13:34-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20110910 19:16:31-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20110910 19:17:17-!- Nephro [~neph@80.233.231.12] has quit [Ping timeout: 252 seconds]
20110910 19:19:52-!- Unnheulu [~ieuan@host86-147-156-6.range86-147.btcentralplus.com] has quit [Quit: Ex-Chat]
20110910 19:19:55< CIA-22> anonymissimus * r51133 /trunk/projectfiles/VC9/wesnoth.vcproj: add exceptions.cpp to VC9 projectfile
20110910 19:20:08< CIA-22> anonymissimus * r51134 /trunk/projectfiles/VC10/ (wesnoth.vcxproj wesnoth.vcxproj.filters): add exceptions.cpp to VC10 projectfile
20110910 19:20:19< CIA-22> anonymissimus * r51135 /trunk/projectfiles/CodeBlocks/wesnoth.cbp: add exceptions.cpp to CB projectfile
20110910 19:20:19-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has quit [Read error: Connection reset by peer]
20110910 19:20:34< CIA-22> anonymissimus * r51136 /trunk/src/scripting/lua.cpp: removed unused macros return_vector_string_attrib and modify_vector_string_attrib
20110910 19:20:51< CIA-22> anonymissimus * r51137 /trunk/src/scripting/lua.cpp: fixed indentation
20110910 19:23:05-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has joined #wesnoth-dev
20110910 19:35:15< anonymissimus> zookeeper: I notice a bit lag, but way not as bad as the poster described
20110910 19:36:24< anonymissimus> thonsew: when I closed wesnoth, I now got an exception
20110910 19:36:45< anonymissimus> that is not always repricdducible and introduced ver revently
20110910 19:38:11-!- vultraz_ubuntu [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds]
20110910 19:39:07-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has quit [Read error: Connection reset by peer]
20110910 19:42:39< thonsew> anonymissimus:  Was it an exception or a core dump?
20110910 19:44:33< un214> *(char *)0=0; is most definitely a core dump
20110910 19:47:20< thonsew> Then is may be a static de-initilization error due to one of the static const t_token * blah = new ... that were replaced with static const t_token & blah = ... the other day.
20110910 19:48:02< anonymissimus> a crash
20110910 19:48:46< thonsew> I'm fixing the wesnothd problem first then the lua/wml issues.  The wesnothd problem is complete show stopper.
20110910 19:49:39< anonymissimus> stupid nug search at gna
20110910 19:49:43< anonymissimus> bug
20110910 19:49:58< thonsew> I'm still trying to wrap my head around the simple_wml differences.
20110910 19:50:20< anonymissimus> I even remember the title almost exactly
20110910 20:03:28-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20110910 20:08:49< gabba> Hi tschmitz
20110910 20:09:01< gabba> we can have the game in ~15 min if you want
20110910 20:20:51-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20110910 20:21:05-!- gabba1 [~gabba@ip-50-21-140-31.dsl.netrevolution.com] has joined #wesnoth-dev
20110910 20:23:59-!- gabba [~gabba@wesnoth/developer/gabba] has quit [Ping timeout: 252 seconds]
20110910 20:24:12-!- Ivanovic_ [~ivanovic@dtmd-d9bffe15.pool.mediaWays.net] has joined #wesnoth-dev
20110910 20:25:09-!- Ivanovic_ [~ivanovic@dtmd-d9bffe15.pool.mediaWays.net] has quit [Changing host]
20110910 20:25:09-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20110910 20:26:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 246 seconds]
20110910 20:26:30-!- Ivanovic_ is now known as Ivanovic
20110910 20:32:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 258 seconds]
20110910 20:41:03-!- Gallaecio [~quassel@183.157.165.83.dynamic.mundo-r.com] has joined #wesnoth-dev
20110910 20:41:27-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Ping timeout: 246 seconds]
20110910 20:43:58< gabba1> thonsew: around?
20110910 20:47:11-!- molgrum [molgrum@h-188-237.a189.priv.bahnhof.se] has joined #wesnoth-dev
20110910 20:47:20-!- molgrum [molgrum@h-188-237.a189.priv.bahnhof.se] has left #wesnoth-dev []
20110910 20:58:46< Soliton> gabba1: networked game is not possible with current trunk.
20110910 20:59:40-!- Sirp [~user@pool-173-74-15-196.dllstx.fios.verizon.net] has quit [Quit: leaving]
20110910 21:01:31< gabba1> Soliton: yeah, that's kind of what I gathered reading the irc log
20110910 21:03:41-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20110910 21:03:48< gabba1> Soliton: have you seen this though:
20110910 21:03:52< gabba1> wesbot: bug #18623
20110910 21:03:53< wesbot> Bug #18623  Assigned to: None  Status: None  Priority: 5 - Normal
20110910 21:03:53< wesbot> Summary: wesnoth --server command-line parameter is broken
20110910 21:03:53< wesbot> Original submission: Connecting to a server with the "wesnoth --server" comman
20110910 21:03:56< wesbot> d-line option causes all sorts of errors that don't happen when connecting throu
20110910 21:03:59< wesbot> URL: https://gna.org/bugs/?18623
20110910 21:04:18< mordante> I'm off bye
20110910 21:04:48< gabba1> It's an old bug but weirdly similar to the one you guys were talking about in the log, i.e. errors about wml params in the wrong order
20110910 21:04:56-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20110910 21:07:09< tschmitz> gabba1: Evidently I overslept
20110910 21:07:43< gabba1> tschmitz: no problem, apparently it's not possible to play multiplayer with current trunk, so ...
20110910 21:08:01< tschmitz> gabba1: Oh really? What's up?
20110910 21:08:12< Soliton> gabba1: i can only see the exact same bug there.
20110910 21:08:24< gabba1> thonsew is ripping apart wesnoth's entrails :P
20110910 21:09:04< thonsew> gabba:  I missed your earlier message.  
20110910 21:09:09< gabba1> Soliton: your sentence is a bit cryptic for me
20110910 21:09:35< gabba1> thonsew: yes, I have a question for you about the unit map, since you've been working with it
20110910 21:09:56< thonsew> I have a grasp on the ordering problem wrt to wesnothd and am implementing an interim fix while presumably wesnothd is upgraded
20110910 21:10:04< thonsew> ask away
20110910 21:10:23< Soliton> wesnothd is upgraded?
20110910 21:11:07< gabba1> thonsew: I want to remove and then put back a bunch of units from the unit map, and I was wondering if there's a way of doing that without breaking underlying IDs and invalidating iterators
20110910 21:11:47< Soliton> gabba1: if you get other errors than i posted add them to your bug report.
20110910 21:12:36< gabba1> that is, ideally if you don't use the iterator when the unit's gone, I'd like it to still work after the unit has been put back
20110910 21:13:05< thonsew> Soliton: wesnothd was and still is using vectors of simplified  attributes to avoid the exact same overhead fixed by t_token. This imposes an additional restriction unecessary on clients for multiplayer  of sorting their configs.  The quick fix is to re-sort the attributes prior to sending.
20110910 21:15:45< Soliton> i suggest talking to Sirp about replacing simple_wml with whatever t_token is.
20110910 21:15:46< thonsew> gabba:  The way to do it, which is brittle, is to do the following.
20110910 21:17:03< thonsew> 1. unit * u = unit_map::extract(loc);   //Now you own the unit but the unit_map remembers any extant iterators.
20110910 21:17:18< thonsew> 2. Do stuff with unit but don't change the uid.
20110910 21:18:17< thonsew> 3. unit_map::insert(u);  
20110910 21:19:25< gabba1> thonsew: ok, that's what I would've done but I wasn't sure about the internals, thanks
20110910 21:19:29< thonsew> 4. u=NULL; //Now the unit map owns the unit an all the old iterator should still be valid.  
20110910 21:20:02< thonsew> The problem is that the iterators are not invalidated, which means that any other part 
20110910 21:20:33< thonsew> of the code that accesses, or re-inserts the unit causes all the iterators to be valid and means
20110910 21:20:55< thonsew> that there will be a collision when you try to re-insert the unit.
20110910 21:21:27< thonsew> I suspect that is the reason ALL of the stl containers invalidate all iterators on any mutating operator.
20110910 21:21:59< tschmitz> (except for the ones that don't)
20110910 21:23:15< gabba1> thonsew: ok, so let me get this right. I can extract the unit, do stuff to it through its pointer and put it back fine,
20110910 21:23:51< gabba1> BUT I should ensure nobody accesses the iterator or reinserts the unit before I reinsert it myself
20110910 21:23:53< gabba1> right?
20110910 21:24:03< thonsew> Yes
20110910 21:24:09< thonsew> The unit_map tries to show a helpful error something like Trying to add joe-4 over fred-4.  The new unit will be assigned underlying_id=99 to prevent duplicate id conflicts.
20110910 21:24:28< thonsew> You should consider this an error NOT a warning.
20110910 21:25:01< thonsew> ,becauses it almost always means the unit has been inserted twice.
20110910 21:25:02-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20110910 21:25:37< tschmitz> I found that error occurred because the ID manager got reset back to 1 when it shouldn't have
20110910 21:26:52< thonsew> I created this bug https://gna.org/bugs/index.php?18591 to track it.
20110910 21:27:51< thonsew> The erroneous resetting was occurring in multiplayer events for some reason if I remember correctly.
20110910 21:27:59< gabba1> Soliton: the error messages are similar (but I can't reproduce the bug I submitted now since we can't even get to the lobby screen), but the big difference is that my bug has been around for at least one year - during GSoC 2010 I wasn't able to connect to the server using "wesnoth -s localhost" without running into out-of-order WML issues when joining or starting a game
20110910 21:31:17< thonsew> tschmitz:  I think the distinction is the difference between iterators (increment/decrement) and pointers.  Iterators should have restricted functionality wrt pointers otherwise you should just a pointer which is never invalidated.  Requiring them to be invalidated sometimes opens up the room to optimize the structure and performance of the underlying data structure.
20110910 21:32:07< thonsew> gabba:  Did I answer your question sufficiently to get back to trying to patch up multiplayer?
20110910 21:32:30< gabba1> thonsew: yes, thanks a lot :)
20110910 21:33:02< thonsew> Good, I'll try and have multiplayer working as quickly as possible.
20110910 21:36:35< thonsew> Soliton : For now I'm trying to get things working in the quickest way, then we can upgrade both sides of the connection.
20110910 21:41:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 21:43:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20110910 22:03:02-!- stikonas_ is now known as stikonas
20110910 22:06:57< gabba1> tschmitz: do you have an idea about where I should put code to remove all hidden enemy units from the unit map when building the future one?
20110910 22:08:29< gabba1> inside mapbuilder::build_map() before or after the call to reset_moves() seems to be a nice place to remove them, and mapbuilder::restore_normal_map() a good place to put them back
20110910 22:08:48< gabba1> but I'd like to respect any structural choices you've made
20110910 22:11:03< gabba1> hmm, or rather I should rename reset_moves to something like pre_build() and do the removing in there, to avoid iterating twice over the whole unit map, I guess
20110910 22:22:54< CIA-22> thonsew * r51138 /trunk/src/serialization/ (binary_or_text.cpp binary_or_text.hpp parser.cpp parser.hpp): (log message trimmed)
20110910 22:22:54< CIA-22> Fix network communication between wesnoth and wesnothd, bug #18632
20110910 22:22:54< CIA-22> This is not a final fix.
20110910 22:22:54< CIA-22> wesnothd expects attributes to be sent in alphabetical order (sorted by client)
20110910 22:22:54< CIA-22> to reduce server load. The new config attribute table is no longer ordered.
20110910 22:22:55< CIA-22> The interim solution is to sort the attributes before sending them. So
20110910 22:22:56< CIA-22> multiplater client bear a sorted cost no paid by single player clients.
20110910 22:29:06-!- mjs-de [~mjs-de@g224185188.adsl.alicedsl.de] has quit [Remote host closed the connection]
20110910 22:29:22-!- vultraz_ubuntu [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20110910 22:33:40-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20110910 22:50:29-!- Crendgrim [~crend@77-22-155-217-dynip.superkabel.de] has quit [Read error: Connection reset by peer]
20110910 23:02:20-!- negusnyul [~negusnyul@dsl540211C9.pool.t-online.hu] has quit [Remote host closed the connection]
20110910 23:03:05< gabba1> @all, does someone know if there's a method available to see if a team sees a particular unit (or to get the list of units a team doesn't see, which is really what I'm after)
20110910 23:03:30< gabba1> or do I have to compute it myself trying to take into account all factors such as fog, ents in trees etc.
20110910 23:03:43-!- dtiger [~dtiger@dynamic-vpdn-91-149-132-76.telecom.by] has quit [Remote host closed the connection]
20110910 23:05:38< Soliton> you could check how sighted events work.
20110910 23:12:28< thonsew> gabba: is unit.find_visible_unit(const map_location &loc, const team &current_team, bool const see_all = false) what you want? 
20110910 23:16:33< gabba1> thonsew: yup, I think this is exactly what I need, thanks!
20110910 23:20:24-!- vultraz_ubuntu [~chatzilla@124.109.10.221] has quit [Remote host closed the connection]
20110910 23:29:54-!- ancestral [~ancestral@12.145.225.25] has joined #wesnoth-dev
20110910 23:30:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: No route to host]
20110910 23:30:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 23:44:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20110910 23:47:12< CIA-22> thonsew * r51139 /trunk/src/mapgen.cpp: Fixed 2 references bound to temporaries.
20110910 23:48:23< thonsew> I can startup and run my network game now, at least for hosting a local game.  I have to go.  Good luck and bye.
20110910 23:48:42-!- thonsew [~thonsew__@gateway/tor-sasl/thonsew] has quit [Quit: Leaving]
20110910 23:50:42-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20110910 23:51:42-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20110910 23:51:44-!- stikonas [~and@79.132.164.89] has joined #wesnoth-dev
20110910 23:51:44-!- stikonas [~and@79.132.164.89] has quit [Changing host]
20110910 23:51:44-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20110910 23:59:30-!- tschmitz [18827665@gateway/web/freenode/ip.24.130.118.101] has quit [Ping timeout: 252 seconds]
--- Log closed Sun Sep 11 00:00:07 2011