--- Log opened Tue Nov 01 00:00:24 2011
20111101 00:04:48-!- wesbot changed the topic of #wesnoth-dev to: 171 bugs, 326 feature requests, 14 patches | logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20111101 00:05:33< Alarantalara> anonymissimus: Most people shorten my nick to Alara, but now that Wizards of the Coast has almost certainly trademarked it, it may not be such a good choice
20111101 00:08:44-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: I ATE'NT DEAD]
20111101 00:09:07-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20111101 00:18:36-!- Blueblaze [~Blueblaze@adsl-76-202-18-35.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20111101 00:29:00< noy> I like Alarant !
20111101 00:30:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20111101 00:45:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20111101 00:56:37-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has joined #wesnoth-dev
20111101 00:58:00< evilshadowmaster> wesbot: seen Sapient
20111101 00:58:01< wesbot> evilshadowmaster: The person with the nick Sapient last spoke 41d 1h ago.  41d 1h ago they left with the message: Quit: ChatZilla 0.9.86-rdmsoft [XULRunner 1.9.0.17/2009122204]
20111101 01:00:25-!- janebot [grickit@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20111101 01:11:04-!- Sytyi [~Sytyi@60-175-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20111101 01:14:28-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.86.1 [Firefox 3.6.2/20100316074819]]
20111101 01:18:35-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20111101 01:27:04< evilshadowmaster> I can't believe I just spent literally hours diagnosing a long-standing bug (which after an extensive IRC log search turns out to be https://gna.org/bugs/?7439) only to find out that mordante marked it "Won't Fix".
20111101 01:28:18< evilshadowmaster> "Postponed" would have been a little less demotivating.
20111101 01:28:49< evilshadowmaster> I guess I'll stash my candidate fix into yet another local branch.
20111101 01:30:25-!- Grimling [~FKint@91.181.181.29] has quit [Quit: Leaving]
20111101 01:30:42< evilshadowmaster> ("Barely perceptible". Right. It's annoyed me for multiple development cycles. Does that mean my vision isn't normal and needs to be corrected?)
20111101 01:33:17< chrisoelmueller> for me, esr closed it
20111101 01:33:39< evilshadowmaster> Oh.
20111101 01:33:55-!- janebot [grickit@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20111101 01:34:27< evilshadowmaster> His wording in comment #6 kind of implies GUI2 was going to magically solve it before too long, though. ;)
20111101 01:35:07< evilshadowmaster> I guess I didn't pay attention to the author of #7 since the bug was assigned to mordante.
20111101 01:40:16-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20111101 01:46:22-!- vultraz_asleep is now known as vultraz
20111101 01:47:30-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has quit [Remote host closed the connection]
20111101 02:01:28< evilshadowmaster> OTOH, I had forgotten the existence of that pesky Unit Profile button. Since its area is contained within the unit preview panels, the fix creates a new bug. 
20111101 02:02:10< evilshadowmaster> My, fix. Not the one in the tracker. Now that's interesting...
20111101 02:18:07-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20111101 02:35:09< evilshadowmaster> Alarantalara: I confirm the fix in r51791, thanks
20111101 02:49:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111101 03:15:42-!- Alarantalara [~alarantal@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20111101 03:24:30-!- chpln_ [~chpln@ppp118-210-48-1.lns20.adl2.internode.on.net] has quit [Ping timeout: 260 seconds]
20111101 03:24:37-!- chpln [~chpln@ppp118-210-36-30.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20111101 03:34:56-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 248 seconds]
20111101 03:38:36-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20111101 03:38:36-!- Upth is now known as Upthorn
20111101 04:02:03-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20111101 04:04:30-!- evilshadowmaster is now known as shadowmaster
20111101 04:05:09-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20111101 04:16:56-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20111101 04:27:24-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20111101 04:33:12-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20111101 04:52:35-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20111101 04:54:37-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 240 seconds]
20111101 04:55:43-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 252 seconds]
20111101 05:05:01-!- horon [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20111101 05:11:37-!- ancestral [~ancestral@67-6-61-207.mpls.qwest.net] has joined #wesnoth-dev
20111101 05:13:25< ancestral> When a unit moves left but is drawn for the right Wesnoth flips the image. Is there a way to turn this off or is the only option to provide the same image as a left version?
20111101 05:16:30-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20111101 05:22:07-!- Gambit [~Gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20111101 05:28:15-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Quit: this quit message is 100% guaranteed not to contain obscenity.]
20111101 05:34:35-!- janebot [grickit@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20111101 05:34:39-!- janebot [grickit@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20111101 05:51:27-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 252 seconds]
20111101 05:59:57-!- un214 [~un214@adsl-75-45-20-64.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20111101 06:21:08-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has joined #wesnoth-dev
20111101 06:21:08-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has quit [Changing host]
20111101 06:21:08-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20111101 06:34:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20111101 07:00:54-!- Sytyi [~Sytyi@60-175-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20111101 07:25:05-!- ancestral [~ancestral@67-6-61-207.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20111101 07:26:59-!- ancestral [~ancestral@67-6-61-207.mpls.qwest.net] has joined #wesnoth-dev
20111101 07:30:52-!- Sytyi [~Sytyi@60-175-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20111101 07:33:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20111101 08:05:25-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Read error: No route to host]
20111101 08:05:45-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20111101 08:18:17-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds]
20111101 08:21:29-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20111101 08:36:14-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Read error: No route to host]
20111101 08:36:29-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20111101 08:47:37-!- ancestral [~ancestral@67-6-61-207.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20111101 09:59:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 258 seconds]
20111101 10:08:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20111101 10:09:22-!- loonybot [~loonybot@109.252.49.111] has joined #wesnoth-dev
20111101 10:09:22-!- loonybot [~loonybot@109.252.49.111] has quit [Changing host]
20111101 10:09:22-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20111101 10:10:53-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20111101 10:18:02-!- stikonas [~gentoo@bcm-131-111-216-35.girton.cam.ac.uk] has joined #wesnoth-dev
20111101 10:18:02-!- stikonas [~gentoo@bcm-131-111-216-35.girton.cam.ac.uk] has quit [Changing host]
20111101 10:18:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111101 10:33:41-!- atomicbomb [~quassel@125.160.86.135] has joined #wesnoth-dev
20111101 10:44:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20111101 10:54:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111101 11:03:29-!- EdB [~edb@144.154.124.78.rev.sfr.net] has joined #wesnoth-dev
20111101 11:06:06< Ivanovic> for those asking themselves what the status regarding "do we have a gaming dev room at fosdem?" is: no idea, the results should have been posted/sent yesterday, so far i have not received anything and their website doesn't say anything either
20111101 11:09:56-!- atomicbomb_ [~quassel@61.94.184.230] has joined #wesnoth-dev
20111101 11:11:48-!- atomicbomb [~quassel@125.160.86.135] has quit [Ping timeout: 244 seconds]
20111101 11:12:42-!- atomicbomb_ is now known as atomicbomb
20111101 11:36:41-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20111101 11:37:28-!- enchilado [~enchilado@unaffiliated/enchilado] has quit [Ping timeout: 245 seconds]
20111101 11:40:27-!- atomicbomb [~quassel@61.94.184.230] has quit [Quit: brb]
20111101 11:46:53-!- Grimling [~FKint@91.181.188.37] has joined #wesnoth-dev
20111101 12:00:50-!- atomicbomb [~quassel@61.94.173.158] has joined #wesnoth-dev
20111101 12:13:11-!- EdB [~edb@144.154.124.78.rev.sfr.net] has quit [Ping timeout: 252 seconds]
20111101 12:13:56-!- EdB [~edb@144.154.124.78.rev.sfr.net] has joined #wesnoth-dev
20111101 12:18:03-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20111101 12:22:35-!- EdB [~edb@144.154.124.78.rev.sfr.net] has quit [Ping timeout: 276 seconds]
20111101 12:50:58-!- atomicbomb [~quassel@61.94.173.158] has quit [Remote host closed the connection]
20111101 12:51:18-!- atomicbomb [~quassel@61.94.173.158] has joined #wesnoth-dev
20111101 13:00:57-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has joined #wesnoth-dev
20111101 13:02:08-!- ettin_ [~jorda@96.207.219.87.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
20111101 13:04:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20111101 13:06:47-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20111101 13:18:51-!- stikonas [~and@bcm-131-111-216-35.girton.cam.ac.uk] has joined #wesnoth-dev
20111101 13:18:51-!- stikonas [~and@bcm-131-111-216-35.girton.cam.ac.uk] has quit [Changing host]
20111101 13:18:51-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111101 13:19:49-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111101 13:21:31-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111101 13:21:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20111101 13:27:30-!- Gambit [~Gambit@pa-184-5-186-26.dhcp.embarqhsd.net] has joined #wesnoth-dev
20111101 13:27:56-!- Gambit is now known as Guest26748
20111101 13:29:08-!- Guest26748 [~Gambit@pa-184-5-186-26.dhcp.embarqhsd.net] has quit [Changing host]
20111101 13:29:08-!- Guest26748 [~Gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20111101 13:29:22-!- Guest26748 is now known as Gambit
20111101 13:53:28< Gambit> Ivanovic: I have one more thing to add. It was just suggested on the forums last night and I think it's really good and simple. The freeze isn't yet in effect is it?
20111101 13:55:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20111101 13:58:39-!- Crab___ [~Crab__@public-gprs4645.centertel.pl] has joined #wesnoth-dev
20111101 13:59:00-!- Crab___ [~Crab__@public-gprs4645.centertel.pl] has quit [Client Quit]
20111101 14:00:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20111101 14:02:50< Gambit> boucman: Will you be around in a few minutes to review some code I am writing?
20111101 14:03:19< boucman> can do...
20111101 14:03:39< Gambit> I am told you are the relevant person for this (adding a color for slowed units)
20111101 14:06:16< zookeeper> a yellow or white tint (similar to poison) sounds like a good idea to me.
20111101 14:07:20< Gambit> Not red? Okay.
20111101 14:07:26< Gambit> zookeeper: what if they're both poisoned and slowed?
20111101 14:07:39< Gambit> At the moment I was combining red and green to make yellow
20111101 14:07:52< boucman> we already thought of it, the hard part is getting the correct color that doesn't conflict with anything
20111101 14:08:32< boucman> I would have gone for light blue (ice-like color) and yes, pois+slow is a problem...
20111101 14:08:47< zookeeper> Gambit, well, then you use the average or sum of all tints. dunno how hard that would be.
20111101 14:09:17< Gambit> Easy except that poison is already maxed green
20111101 14:09:36< Gambit> oh average
20111101 14:09:40< Gambit> Right
20111101 14:10:11< zookeeper> what does it matter if poison is already maxed green? 0,255,0 + 128,128,128 = 128,255,128
20111101 14:10:25< zookeeper> (and yeah, that'd be gray instead of white there)
20111101 14:10:46< Gambit> Can't use gray and probably not white because of petrified.
20111101 14:11:04< zookeeper> why not? petrified units can't be slowed or poisoned
20111101 14:11:13< zookeeper> (at least not AFAIK)
20111101 14:11:29< Gambit> Because the whole point of adding a slowed color is to make ill units easy to identify at a glance
20111101 14:11:48< zookeeper> and..? they wouldn't look like petrified units.
20111101 14:12:44< zookeeper> unless i'm mistaken in how i think the poison tint currently works
20111101 14:15:19< boucman> IIRC poison and stone are different mechanism, one is a tint, the other is desaturating, but I may be
20111101 14:15:20< boucman> wron
20111101 14:15:22< boucman> g
20111101 14:15:24< boucman> darn
20111101 14:15:43< zookeeper> yes, petrification is desaturation
20111101 14:15:43< Gambit> But they're still both grey in the end.
20111101 14:16:32< zookeeper> boucman, does poison tint (0,255,0) turn 255,0,0 into 0,255,0 or 255,255,0?
20111101 14:16:44< zookeeper> i'm pretty sure it's the latter, in which case gray doesn't produce any problems.
20111101 14:17:56< boucman> I guess the latter, but you would neet do test to be sure
20111101 14:18:52< zookeeper> actually i guess it should have been "0,85,0 or 255,255,0" but whatever
20111101 14:19:36< zookeeper> and now that i think of it, poisoned units tend to be pretty bright instead of dark green, so that's good enough of a test for me :P
20111101 14:20:38< zookeeper> so, with that assumption, a tint of 128,128,128 doesn't make the unit gray
20111101 14:21:13< zookeeper> and a slowed and poisoned unit would be lighter green than a unit which is only poisoned
20111101 14:21:13-!- horon [~horon@nttkyo340050.tkyo.nt.adsl.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20111101 14:21:37< Gambit> If it's only slowed it does doesn't it?
20111101 14:21:43< zookeeper> how?
20111101 14:22:06< Gambit> If you're doing 128,128,128 for slow?
20111101 14:22:30< zookeeper> well add 128,128,128 to 255,0,0 and you get 255,128,128. is it light red or gray?
20111101 14:23:28< Gambit> What do you mean add to 255,0,0?
20111101 14:23:39< zookeeper> 255,0,0 is the red pixel in the unit's cape
20111101 14:23:56< zookeeper> and you're saying it'd turn gray
20111101 14:25:13< Gambit> I just want it to be really clear. But okay I'll try that
20111101 14:28:30-!- fabi_ [~fabi@88-134-14-215-dynip.superkabel.de] has joined #wesnoth-dev
20111101 14:29:44-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20111101 14:31:33-!- fabi [~fabi@88-134-14-215-dynip.superkabel.de] has quit [Ping timeout: 260 seconds]
20111101 14:39:58-!- fabi_ is now known as fendrin
20111101 14:42:54< Gambit> Well this is interesting. You can tell between poisoned and poisoned+slowed easily, but there's no visible difference between regular and slowed.
20111101 14:42:59< Gambit> Might have to make it closer to white
20111101 14:43:10< Gambit> Oh wait. My fault. Typos :|
20111101 14:45:30< Gambit> zookeeper: http://dl.dropbox.com/u/20566997/images/wesnoth/tinttest1.png
20111101 14:47:12< Gambit> boucman: /home/derek/Dropbox/Public/games/wesnoth/tint.patch
20111101 14:47:15< Gambit> err
20111101 14:47:17< Gambit> fail
20111101 14:47:26< Gambit> Sorry. boucman: http://dl.dropbox.com/u/20566997/games/wesnoth/tint.patch
20111101 14:47:47< loonycyborg> I had np idea that slowed should have been visually different..
20111101 14:47:50< loonycyborg> *no
20111101 14:48:20< Gambit> It's an improvement to usability.
20111101 14:50:01< loonycyborg> Hm.. In your screenshot it's still not as prominent as poisoned,
20111101 14:50:26< Gambit> Indeed
20111101 14:51:37< Gambit> My concerns of it getting mixed up with petrified were apparently silly.
20111101 14:51:41< Gambit> I'll try completely white.
20111101 14:51:49< boucman> Gambit: looks good
20111101 14:52:01< Gambit> Thanks
20111101 14:52:11< Gambit> I'll commit when I have a good color then
20111101 14:52:22< boucman> Gambit: there might be something to document on the AnimationWML wiki too
20111101 14:52:57< Gambit> This blending is nice. Is it exposed to an image path function?
20111101 14:53:37< boucman> not sure
20111101 14:53:39< boucman> probably
20111101 14:55:32< Gambit> http://dl.dropbox.com/u/20566997/images/wesnoth/tinttest2.png
20111101 14:56:46< Gambit> The difference between poisoned and poisoned+slowed is subtle
20111101 14:56:59< Gambit> I'd rather have distinct colors than different shades of green
20111101 14:57:07< boucman> both is good, but I think slowed is too similar to stoned...
20111101 14:57:21< boucman> could you try making slow a bit bluer to see if it fits ?
20111101 14:59:48< Gambit> From the forums "How about a red color? (Red signifying “stop” at a stoplight, and as showing pain or struggle.)"
20111101 14:59:52< Gambit> (blue screenshot uploading)
20111101 15:00:33< Gambit> Here is 128,128,255: http://dl.dropbox.com/u/20566997/images/wesnoth/tinttest3.png
20111101 15:01:04< Gambit> *128,128,255,0.25 because we could also play with the blend ratio
20111101 15:01:53< boucman> my favorite so far... could you try removing the red tint too ? (i.e pure blue)
20111101 15:05:06< Gambit> 4 is uploaded (change the number in the url) 0,0,255,0.25
20111101 15:05:20< Gambit> 5 is on the way 255,0,0,0.25
20111101 15:05:57-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20111101 15:06:43< Gambit> 5 is done
20111101 15:07:06< Gambit> 6 is on the way 255,255,0,0.25
20111101 15:08:20< Gambit> 6 is done
20111101 15:13:06< Gambit> 7 is on the way 255,128,0,0.25
20111101 15:13:11< Gambit> I like this one best so far
20111101 15:15:42< Gambit> 7 is done
20111101 15:16:15< zookeeper> i liked 6 more, but 7 works well too
20111101 15:17:15< Gambit> I didn't think 6 had enough difference.
20111101 15:17:18< boucman> I don't like 5, red is definitely "rage,fire,burning", it doesn't match slow for me...
20111101 15:17:58< Gambit> None of the slow attacks are freezing or cold though
20111101 15:17:58< zookeeper> wanna try 255,191,0? :P
20111101 15:18:13< boucman> 6 and 7... again I think we should keep yellow, it doesn't associate with slow for me (it works, but my favorite is four)
20111101 15:18:36< Gambit> zookeeper: right after I walk my dog. brb
20111101 15:18:50< boucman> what would be "light blue" ?
20111101 15:28:18< Gambit> probably 191,191,155
20111101 15:28:58< Gambit> 8 is on the way with 255,191,0
20111101 15:29:35< Gambit> Oh how I wish this were soft coded.
20111101 15:30:41< Gambit> zookeeper: 8 is done
20111101 15:31:22< Gambit> 9 is on the way with 191,191,255. IMO not enough difference between poisoned and poisoned+slowed
20111101 15:31:49< Gambit> It'd probably be better to have icons for statuses instead of color shifts
20111101 15:32:05< zookeeper> hmh, 8 is pretty good IMO. maybe 255,223,0 is worth trying. :x
20111101 15:32:54< boucman> my favorite is 9now :P
20111101 15:32:59< zookeeper> well, the color shifts are pretty nice really. of course icons could also be used.
20111101 15:33:17< zookeeper> ...yeah, 9 is really good
20111101 15:33:28-!- atomicbomb [~quassel@61.94.173.158] has quit [Remote host closed the connection]
20111101 15:33:35< boucman> I really think blue is better than yellow from a semantic point of view... 
20111101 15:33:47< boucman> ice colors for frozen character is a common convention in video games
20111101 15:33:52-!- Crendgrim [~crend@77-22-113-8-dynip.superkabel.de] has joined #wesnoth-dev
20111101 15:33:53< zookeeper> slowed and both are kinda hard to tell apart unless you have them next to each other
20111101 15:34:04< Gambit> I'm approaching this from a clarity perspective
20111101 15:34:24< Gambit> And that's why I'm preferring red
20111101 15:34:34< Gambit> Not sure how this works with color blindedness
20111101 15:34:48< Gambit> There's still the fallback of selecting the unit
20111101 15:34:56< Gambit> This is just for fast recognition.
20111101 15:35:27< boucman> i'm looking at usability, and conventions are very important for usability...
20111101 15:36:13< zookeeper> well, i don't think there's any particular colour that's common enough for "slow" effects to be called a convention
20111101 15:36:24< boucman> blue tint...
20111101 15:36:27< Gambit> I really wish more people had participated in the forums. Maybe they will and I can alter it later.
20111101 15:36:58< Gambit> 10 is on the way with 255,223,0
20111101 15:37:18< Gambit> These take about a minute to upload on my connection
20111101 15:37:40< zookeeper> if we had a proper opengl rendering engine then we could make all sorts of fancy effects instead of basic tints :J
20111101 15:37:40-!- fendrin [~fabi@88-134-14-215-dynip.superkabel.de] has quit [Remote host closed the connection]
20111101 15:38:09< Gambit> 10 is done
20111101 15:38:12< zookeeper> yeah, well, >2mb for a single image showing a couple of tinted units is a bit excessive...
20111101 15:38:16< Gambit> I don't like it.
20111101 15:38:20< Gambit> Yeah I'll shrink my window.
20111101 15:40:17< zookeeper> yeah
20111101 15:41:03< Gambit> So... 9?
20111101 15:41:40< boucman> yes, let's go for 9 and if people (especially artists) have better suggestion we can change it later
20111101 15:42:08< zookeeper> fine by me
20111101 15:45:01< Gambit> Is this player-facing enough to go in the players  changelog?
20111101 15:45:28< boucman> definitely
20111101 15:47:44< CIA-64> grickit * r51792 /trunk/ (changelog players_changelog src/unit.cpp): Slowed units are now tinted to be recognizable at a glance
20111101 15:49:09-!- fendrin [~fabi@88-134-14-215-dynip.superkabel.de] has joined #wesnoth-dev
20111101 15:57:21-!- oldtopman [~oldtopman@71-208-213-204.hlrn.qwest.net] has joined #wesnoth-dev
20111101 15:57:21-!- oldtopman [~oldtopman@71-208-213-204.hlrn.qwest.net] has quit [Changing host]
20111101 15:57:21-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20111101 15:57:27-!- EdB [~edb@144.154.124.78.rev.sfr.net] has joined #wesnoth-dev
20111101 16:02:03< Gambit> 7 looks like the poor HI has rusted in the rain :P
20111101 16:02:18< Gambit> Here's the thread for it by the way: http://forums.wesnoth.org/viewtopic.php?f=12&t=35378
20111101 16:18:49-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Remote host closed the connection]
20111101 16:29:35< Gambit> zookeeper, boucman: What do you think of making the snail's skin match slow's color?
20111101 16:30:32< zookeeper> a blue snail?
20111101 16:30:57< Gambit> Why not?
20111101 16:31:30< Gambit> It'd be really nice to apply the exact same process to the snail image.
20111101 16:31:33< Gambit> Err no
20111101 16:31:35< Gambit> not the shell
20111101 16:32:40-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has quit [Remote host closed the connection]
20111101 16:35:44< Gambit> http://dl.dropbox.com/u/20566997/images/wesnoth/tintedsnail.png
20111101 16:36:06< boucman> hehe
20111101 16:36:10< boucman> looks cute :P
20111101 16:36:34< Gambit> Should probably keep the original somewhere in case the color is changed.
20111101 16:36:42< Gambit> Err... no I guess that's what SVN is for.
20111101 16:36:45< fendrin> The snail is nice.
20111101 16:37:10< Gambit> Though perhaps someone has used the old image for something else.
20111101 16:37:29< Gambit> I'll save a copy of the original as snail.png
20111101 16:38:19< zookeeper> looks passable to me, no particular opinion either way
20111101 16:39:42-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20111101 16:40:11-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20111101 16:40:11-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev
20111101 16:41:09< CIA-64> grickit * r51793 /trunk/ (changelog images/misc/slowed.png images/misc/snail.png): 
20111101 16:41:09< CIA-64> Tinted the slowed snail icon to match the new slowed unit color.
20111101 16:41:09< CIA-64> The old image still exists at images/misc/snail.png
20111101 16:45:48-!- dtiger [~dtiger@dynamic-vpdn-46-53-165-218.telecom.by] has joined #wesnoth-dev
20111101 16:46:03-!- dtiger [~dtiger@dynamic-vpdn-46-53-165-218.telecom.by] has quit [Remote host closed the connection]
20111101 16:46:43-!- dtiger [~dtiger@dynamic-vpdn-46-53-165-218.telecom.by] has joined #wesnoth-dev
20111101 16:55:36-!- EdB [~edb@144.154.124.78.rev.sfr.net] has quit [Ping timeout: 276 seconds]
20111101 17:00:54< alink> shadowmaster: r51782 inverted the wanted meaning of the warning (see code), the goal is to recommend the use of modifiers
20111101 17:01:57< alink> back in the days it was to prevent unwanted spamming of hard disk with big bmp files
20111101 17:02:41< alink> later we added a popup, but not sure if it shows in every GUI cases
20111101 17:03:33< alink> also we had a bug with chat, where binding a simple letter to screenchot would trigger it when typing
20111101 17:04:04-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20111101 17:11:45< Ivanovic> Gambit: correct, the freeze has not started yet
20111101 17:20:26< CIA-64> fendrin * r51794 /trunk/src/ (12 files in 4 dirs): 
20111101 17:20:26< CIA-64> Implemented the $second_unit being bound to the acting leader in recruit/recall events.
20111101 17:20:26< CIA-64> LUA and WML connections to the feature are still missing.
20111101 17:20:56< Gambit> Hmmm what happens when you divide an int by a double? I just noticed in all these images that the "both" isn't nearly as strong
20111101 17:23:47< Gambit> Maybe not...
20111101 17:24:37< Gambit> *double by an int
20111101 17:30:02-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20111101 17:32:12-!- crimson_penguin [~ben@184.71.170.250] has joined #wesnoth-dev
20111101 17:32:12-!- crimson_penguin [~ben@184.71.170.250] has quit [Changing host]
20111101 17:32:12-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20111101 17:32:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20111101 17:33:34-!- ancestral [~ancestral@209.181.233.7] has joined #wesnoth-dev
20111101 17:35:54-!- Upth [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has joined #wesnoth-dev
20111101 17:35:54-!- Upth is now known as Upthorn
20111101 17:41:11< Gambit> Some day I should actually try to learn what I'm doing instead of trial and error...
20111101 17:42:42< Gambit> Using a higher blend ratio makes the blue/green/both a lot easier to differentiate.
20111101 17:51:32-!- timotei [~timotei@188.24.3.207] has joined #wesnoth-dev
20111101 17:51:32-!- timotei [~timotei@188.24.3.207] has quit [Changing host]
20111101 17:51:32-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20111101 17:53:59< Soliton> Gambit: the int is promoted to a double.
20111101 17:57:57-!- Sytyi [~Sytyi@101-135-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20111101 18:06:08-!- ancestral [~ancestral@209.181.233.7] has quit [Quit: i go sleeps kthxbai]
20111101 18:30:33-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds]
20111101 18:50:39-!- chrisoelmueller [bouncer@syngo.info] has left #wesnoth-dev ["Where's those banana cream pies, eh"]
20111101 18:54:43-!- happygrue [~George@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer]
20111101 18:55:39-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20111101 18:58:15-!- fendrin [~fabi@88-134-14-215-dynip.superkabel.de] has quit [Remote host closed the connection]
20111101 18:58:33-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111101 18:58:53< shadowmaster> alink: why recommend the use of modifiers if modifiers don't work?
20111101 19:00:02< shadowmaster> ah. Hm.
20111101 19:01:00< shadowmaster> apparently my window manager captures the sequences I was testing with.
20111101 19:06:55-!- negusnyul [~negusnyul@dsl54020BE5.pool.t-online.hu] has joined #wesnoth-dev
20111101 19:11:06-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111101 19:16:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111101 19:20:44< CIA-64> shadowmaster * r51795 /trunk/src/preferences_display.cpp: 
20111101 19:20:44< CIA-64> Hotkey preferences: Make the screenshot hotkey assignment warning correct again
20111101 19:20:44< CIA-64> alink pointed out that r51782 inverted the meaning of the warning, so
20111101 19:20:44< CIA-64> invert it again and "try" to explain why modifiers are recommended.
20111101 19:25:41-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has joined #wesnoth-dev
20111101 19:29:46-!- Shakey [~Shakey@12.190.80.225] has joined #wesnoth-dev
20111101 19:34:44-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20111101 19:34:59< mordante> servus
20111101 19:36:24< mordante> shadowmaster, why do you need to know whether code is is pre_show or not?
20111101 19:40:06< shadowmaster> r51731
20111101 19:41:06< mordante> yews, but why is it needed?
20111101 19:41:29< shadowmaster> I didn't say it was needed. Now that I know there isn't a way I just coded my own in that dialog.
20111101 19:42:04< mordante> why is the change in that commit needed?
20111101 19:42:16< mordante> the log only mention what it does, but not why
20111101 19:43:09< shadowmaster> r51672  introduced an additional "refresh the entire GUI" call that caused extra flickering when the dialog was initialized.
20111101 19:47:14< mordante> of course some comment in the code why it's needed would have been nice :-|
20111101 19:48:44< mordante> and why all the text changes "according to the upcomming UI Style Guide" ?
20111101 19:49:38< shadowmaster> Because Espreon and I decided that the UI Style Guide was wrong about capitalization on checkboxes and slider labels and decided to take a hint from the GNOME HIG instead
20111101 19:49:52-!- Upthorn [~ogmar@c-76-105-37-245.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
20111101 19:50:02< mordante> wouldn't it make sense to discuss the style before changing it ?
20111101 19:51:04< shadowmaster> It didn't require any discussion, really.
20111101 19:53:05< mordante> good guess that means there is no guide
20111101 19:53:29< shadowmaster> http://wiki.wesnoth.org/UI_Style_Guide
20111101 19:53:36< shadowmaster> this has existed since last year
20111101 19:55:15< shadowmaster> It was written taking existing Wesnoth practice in mind, but the points about checkboxes and slider labels were dubious (mainly because there was no consistent existing practice in Wesnoth about them at the time it was written) and didn't really match existing practice outside of Wesnoth
20111101 19:55:56< mordante> like I said, if nobody bothers to bring it up on the dev-ml and now claims it's a guide it's not a guide
20111101 19:56:36< shadowmaster> as far as I can see, the only active people who really care about this kind of minor things at the moment are Espreon and me.
20111101 19:58:25< mordante> AI0867, can't remember the problem
20111101 20:00:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20111101 20:02:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111101 20:02:38< mordante> shadowmaster, can you please not blame me for marking it won't fix https://gna.org/bugs/?7439
20111101 20:03:08< shadowmaster> yes, if you read the rest of the logs before replying you'd see as much :p
20111101 20:03:14-!- stikonas [~gentoo@bcm-131-111-216-35.girton.cam.ac.uk] has joined #wesnoth-dev
20111101 20:03:14-!- stikonas [~gentoo@bcm-131-111-216-35.girton.cam.ac.uk] has quit [Changing host]
20111101 20:03:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111101 20:03:22-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20111101 20:04:15< mordante> I normally reply directly
20111101 20:12:07< anonymissimus> zookeeper: a unit xna easily be slowed, stoned and poisoned etc at teh same time
20111101 20:12:59< anonymissimus> can even happen in a real game, northerner assassin poisons and pillager slows; bit can be set by wml in any case
20111101 20:13:41< anonymissimus> once there's poisoned and stoned it's of course no longer very visible what's up...
20111101 20:15:31< mordante> Rhonda, around to talk about the language hiding FR?
20111101 20:16:08< Rhonda> sort of
20111101 20:18:35< mordante> when you enable the feature what do you want
20111101 20:18:42< mordante> only the language not in the menu
20111101 20:18:52< mordante> or also not installing the mo-files?
20111101 20:19:10< Rhonda> Only not in the menu. So that people could edit the preferences file to still use them.
20111101 20:20:10< mordante> you expect people to do that?
20111101 20:20:11< Rhonda> This will work to reduce confusion about not getting the language for DAUs not understanding why selecting won't get them much (== anything in their point of view), while translators still have an easy way to test their stuff.
20111101 20:20:27< Rhonda> I expect translators who want to test their stuff to do that, yes.
20111101 20:21:04< mordante> let me test, but I think when setting the default language of the OS to the proper language also does it
20111101 20:21:12< Rhonda> Something which still is easy but not directly available to endusers who would be confused by unfinished translations.
20111101 20:21:38< Rhonda> hmm, right
20111101 20:21:59< Rhonda> so people who would have set the system language to such an unfinished translation would still get that, then …
20111101 20:23:48< mordante> yup, but what I intended was to delete data/languages/de.cfg
20111101 20:24:14< mordante> this works properly for de_DE, but fails for de_AT
20111101 20:24:36< mordante> hmm only not sure whether I even installed de_AT locales ...
20111101 20:25:15< mordante> I didn't
20111101 20:26:54< mordante> ok seems to work properly after installing de_AT
20111101 20:27:40< mordante> so then we could cook up some script to remove the languages not translated enough and you could integrate it in your build script
20111101 20:28:28< anonymissimus> fendrin: are you sure that wml/lua connections are missing ?
20111101 20:28:53< anonymissimus> once you pass the recruiting/recalling leader's location to game_events::fire you should be done
20111101 20:29:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20111101 20:32:28< anonymissimus> the location will be available in wesnoth.current.event_context, leader as $second_unit and $x1, $y1 in wml, yep
20111101 20:32:59< shadowmaster> zookeeper: would it be a good idea to disable replay saves (endlevel.replay_save=no) for non-playable epilogue and cutscene scenarios in mainline camapigns?
20111101 20:34:33< anonymissimus> as for this save disabling, I really dislike not being given the possibility to save at the end of cutscene scenarios in mainline campaigns (linger_mode=no)
20111101 20:35:55< shadowmaster> What would be the point if the game will automatically save a start-of-scenario save following that, and there's nothing useful to see on the map (except for the occasional easter eggs, but those don't exist in mainline anymore I think) after a cutscene is over?
20111101 20:36:00< zookeeper> shadowmaster, not sure. my gut feeling would say no, since replaying gameplay isn't the only legitimate use of replays. you might want to re-read dialogue with options and branching, or something.
20111101 20:36:40< shadowmaster> Cutscenes which offer some kind of option or branching route to the player don't fall into the non-playable category, of course.
20111101 20:37:00< anonymissimus> shadowmaster: ah yes, save=no is even more annoying than linger_mode=no
20111101 20:37:25< shadowmaster> I advise you don't play my campaigns, then. :)
20111101 20:37:46< zookeeper> shadowmaster, ah, right. in that case maybe.
20111101 20:37:50< anonymissimus> it is most annoying for when I'm not playing but debugging a campaign
20111101 20:38:16< CIA-64> mordante * r51796 /trunk/ (changelog src/playmp_controller.cpp): 
20111101 20:38:16< CIA-64> Removed old markup style from OOS messages.
20111101 20:38:16< CIA-64> Fixes bug #18387. Also reverts r51002, which is wrong since the dialog
20111101 20:38:16< CIA-64> has pango markup disabled.
20111101 20:38:44< mordante> Rhonda, does the approach above sound sane to you?
20111101 20:47:24-!- timotei [~timotei@188.24.3.207] has joined #wesnoth-dev
20111101 20:47:24-!- timotei [~timotei@188.24.3.207] has quit [Changing host]
20111101 20:47:24-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20111101 20:49:52< shadowmaster> anonymissimus: thanks for the replay in #18892, by the way, although I'm not really able to interpret the backtraces/core dumps and the information I get from valgrind correctly.
20111101 20:50:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20111101 20:51:30< shadowmaster> anonymissimus: do you think there's any information I could provide that you could use?
20111101 20:58:08< anonymissimus> wesbot: bug 18892
20111101 20:58:09< wesbot> Bug #18892  Assigned to: None  Status: None  Priority: 7 - High
20111101 20:58:09< wesbot> Summary: wesnoth 1.9.9. crashes when trying to load replay
20111101 20:58:09< wesbot> Original submission: Hello,It happens quite often. We run into it all the 
20111101 20:58:12< wesbot> time, when playing WTT tournament ( http://forums.wesnoth.org/viewtopic.php?f=15
20111101 20:58:15< wesbot> URL: https://gna.org/bugs/?18892
20111101 20:58:18< wesbot> Attached file (1st): https://gna.org/bugs/download.php?file_id=14368
20111101 20:59:44< anonymissimus> why do you act as if the bug was assigned to me ? is it not reproducible on Linux ?
20111101 21:00:05< shadowmaster> it is very reproducible on Linux.
20111101 21:00:50< anonymissimus> what does valgrind say ?
20111101 21:01:19< shadowmaster> http://pastebin.com/J89jwM8z
20111101 21:03:04< shadowmaster> whether the bug is assigned to you isn't really relevant; I just thought that you could be interested on further information about the crash (I tend to assign bugs to myself only when they are in code I recently handled, or after committing a fix)
20111101 21:03:07-!- Exasperation [4a47319b@gateway/web/freenode/ip.74.71.49.155] has joined #wesnoth-dev
20111101 21:03:44< Exasperation> mordante: did you see my comments the other day?
20111101 21:04:29< mordante> Exasperation, no when did you leave a comment?
20111101 21:05:06< Exasperation> 20111029 23:15:44 in the logs
20111101 21:05:28< Exasperation> I think I missed you by about an hour
20111101 21:05:59< Exasperation> or maybe that was a different day
20111101 21:06:09< mordante> no I found it
20111101 21:06:42< anonymissimus> shadowmaster: yes, thx for the valgrind paste
20111101 21:06:47-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20111101 21:07:26< mordante> Exasperation, yeah I had a look at the patch and seems fine to me, just like a second opinion of anonymissimus 
20111101 21:07:50< mordante> since I'm not familiar with the lua part
20111101 21:07:54< Exasperation> ok
20111101 21:08:20< shadowmaster> anonymissimus: I'm not sure, however, what's to be read in "play_button_->enable(true);" . I imagine play_button_ points to a bad location, or alternatively gui::button::enable()'s start address changes for some reason, which should not happen unless the OS or the compiler were broken, though.
20111101 21:08:38< mordante> anonymissimus, does patch #2763 look sane to you, from a Lua point of view?
20111101 21:08:41< shadowmaster> then again, Espreon had reported a bug with a similar backtrace that ended in a SIGILL (illegal instruction) instead of a SIGSEGV
20111101 21:08:58< mordante> shadowmaster, maybe test whether the pointer is NULL
20111101 21:09:06< shadowmaster> gdb says the pointer isn't NULL.
20111101 21:09:46< mordante> oh joy, not so much fun to debug
20111101 21:09:51< shadowmaster> this was what I found last night (I'm rebuilding wesnoth-debug atm so the core dump might not be good anymore):
20111101 21:09:54< shadowmaster> 22:48:38 <evilshadowmaster> (gdb) print play_button_
20111101 21:09:57< shadowmaster> 22:48:38 <evilshadowmaster> $1 = (gui::button *) 0x3a044f8
20111101 21:11:22< shadowmaster> Espreon's bug: https://gna.org/bugs/?18495 (supposedly partially fixed by thonsew)
20111101 21:12:58< anonymissimus> wesbot: patch 2763
20111101 21:12:59< wesbot> Patch #2763  Assigned to: Mark de Wever <mordante>  Status: None  Priority: 5 - Normal
20111101 21:13:00< CIA-64> mordante * r51797 /trunk/ (changelog src/gui/dialogs/game_save.cpp): 
20111101 21:13:00< CIA-64> Fixes OOS ignore toggle in the save dialog.
20111101 21:13:00< CIA-64> Fixes bug #18330.
20111101 21:13:02< wesbot> Summary: Adds support for button widget to wesnoth.set_dialog_callback
20111101 21:13:04< wesbot> Original submission: This patch adds support for the button widget to wesnoth.
20111101 21:13:07< wesbot> set_dialog_callbackTest case:local T = helper.set_wml_tag_metatable {}wes
20111101 21:13:10< wesbot> URL: https://gna.org/patch/?2763
20111101 21:13:12< wesbot> Attached file (1st): https://gna.org/patch/download.php?file_id=14316
20111101 21:13:57< anonymissimus> shadowmaster: I think I got both for that bug, SIGKILL and SIGSEV
20111101 21:15:23-!- Crendgrim [~crend@77-22-113-8-dynip.superkabel.de] has quit [Quit: ...]
20111101 21:16:16< shadowmaster> SIGILL (illegal instruction) isn't the same as SIGKILL (killed) :p
20111101 21:17:07< shadowmaster> on Linux the second doesn't happen automatically, I believe, unless the program is automatically killed during a general out-of-memory condition
20111101 21:17:33< anonymissimus> mordante: fine with me
20111101 21:17:49< mordante> thanks anonymissimus 
20111101 21:17:58< mordante> Exasperation, will commit the patch later
20111101 21:18:23< Exasperation> is it my imagination, or does the code say it should be button::set_active, not button::enable?  http://devdocs.wesnoth.org/gui_2widgets_2button_8hpp_source.html
20111101 21:18:29< Exasperation> ok
20111101 21:18:36< anonymissimus> shadowmaster: I remember reading "illegal instruction" though
20111101 21:19:20< timotei> hmm... 171 bugs.
20111101 21:19:22< timotei> nice...>D
20111101 21:21:40-!- dtiger [~dtiger@dynamic-vpdn-46-53-165-218.telecom.by] has quit [Remote host closed the connection]
20111101 21:21:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 258 seconds]
20111101 21:24:21-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111101 21:25:13-!- Gallaecio [~quassel@84.120.216.157.dyn.user.ono.com] has quit [Ping timeout: 240 seconds]
20111101 21:27:03-!- Gallaecio [~quassel@84.120.216.157.dyn.user.ono.com] has joined #wesnoth-dev
20111101 21:27:05< shadowmaster> *play_button_ is wrong, though: http://pastebin.com/ZKMnvSAr
20111101 21:29:03< anonymissimus> shadowmaster: the play_button is in any case screwed up in play_button_->enable(true);
20111101 21:29:03-!- Grimling [~FKint@91.181.188.37] has quit [Ping timeout: 240 seconds]
20111101 21:29:10< anonymissimus> type, label etc show garbage stuff
20111101 21:29:11-!- Grimling [~FKint@91.181.188.37] has joined #wesnoth-dev
20111101 21:30:52< shadowmaster> the most assignment or arithmetic done with that pointer in replay_controller.cpp is at the start of replay_controller::replay_buttons_wrapper::update in line 141, so if the pointer is wrong it must be wrong as handled by display.cpp or a different operation is corrupting its value
20111101 21:31:58-!- markus__ [~mjs-de@f053189014.adsl.alicedsl.de] has joined #wesnoth-dev
20111101 21:32:22< shadowmaster> oh, I think I see an address to a temporary in display.cpp:531 being used later.
20111101 21:32:40< shadowmaster> s/temporary/object past its original scope/
20111101 21:33:37-!- mjs-de [~mjs-de@f053189014.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20111101 21:34:50< shadowmaster> yet that code hasnt been touched since 2007
20111101 21:37:16< shadowmaster> I take it back, buttons_ doesn't hold pointers, only copies.
20111101 21:38:58-!- Grimling [~FKint@91.181.188.37] has quit [Ping timeout: 240 seconds]
20111101 21:38:58-!- Grimling [~FKint@91.181.188.37] has joined #wesnoth-dev
20111101 21:41:59-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds]
20111101 21:43:53-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111101 21:45:15-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20111101 21:45:29-!- fstltna-1 [~fstltna@74.63.219.251] has joined #wesnoth-dev
20111101 21:45:31< anonymissimus> shadowmaster: something in the update_gui() call replay_controller.cpp:263 is reponsible it seems
20111101 21:45:32< anonymissimus> ok, do you want to debug it ? we are doing the same here
20111101 21:45:32-!- fstltna [~fstltna@74.63.219.251] has quit [Ping timeout: 240 seconds]
20111101 21:47:14< shadowmaster> I think I already depleted my pool of ideas for debugging it.
20111101 21:47:15-!- markus__ is now known as mjs-de
20111101 21:49:04< shadowmaster> I do wonder why, if the pointer is invalid, the first frame in the backtrace is not in the member method invoked, though.
20111101 21:56:23< shadowmaster> I won't claim I know Intel64 assembler, but RIP appears to pointat a supossedly harmless instruction sequence too
20111101 21:57:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20111101 21:59:25< CIA-64> espreon * r51798 /trunk/ (58 files in 3 dirs): Converted a straight apostrophe.
20111101 22:00:10< anonymissimus> so now I know it happens in the (*gui_).draw(); replay_controller:453 :|
20111101 22:00:24< anonymissimus> previously to that the buttons are ok
20111101 22:01:01-!- Exasperation_ [4a47319b@gateway/web/freenode/ip.74.71.49.155] has joined #wesnoth-dev
20111101 22:01:15< mordante> Exasperation, what about the active vs enabled?
20111101 22:04:03-!- Exasperation [4a47319b@gateway/web/freenode/ip.74.71.49.155] has quit [Ping timeout: 265 seconds]
20111101 22:06:06< Exasperation_> nevermind, I was talking about what anon & shadow were looking at, but have since realized they were talking about gui1 buttons, not gui2
20111101 22:07:29< shadowmaster> the diassembler output at the point of the crash: http://pastebin.com/uPpABKMV
20111101 22:07:47< shadowmaster> it's not even left replay_controller::replay_buttons_wrapper::reset_buttons() yet
20111101 22:09:13< anonymissimus> i dont know how to interpret that
20111101 22:10:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20111101 22:10:20-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20111101 22:11:34-!- Sytyi [~Sytyi@101-135-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20111101 22:12:25< CIA-64> mordante * r51799 /trunk/ (changelog src/scripting/lua.cpp): 
20111101 22:12:25< CIA-64> Add Lua support for clickable gui2 elements.
20111101 22:12:25< CIA-64> Patch #2763.
20111101 22:23:22-!- Moloch_IT [~Moloch_IT@78.159.207.2] has joined #wesnoth-dev
20111101 22:23:54< mordante> I'm off bye
20111101 22:24:07-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20111101 22:36:13< anonymissimus> wesbot: log 48442
20111101 22:36:14< wesbot> dragonking * r48442 : Improvement of the wesnoth replay player - this should probably fix bug #16237, since OOS in replay mode was often releated to buttons being pressed too many times
20111101 22:36:19< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=48442
20111101 22:38:35< anonymissimus> shadowmaster: well, I supposed r48442 introduced it
20111101 22:39:25< anonymissimus> this call to display::draw seems to recreate the buttons and the old reference gets invalid or something
20111101 22:40:45< anonymissimus> wesbot: bug 16237
20111101 22:40:46< wesbot> Bug #16237  Assigned to: Jörg Hinrichs <jhinrichs>  Status: Fixed  Priority: 5 - Normal
20111101 22:40:49< wesbot> Summary: Replays intermittently produce out of sync errors
20111101 22:40:51< wesbot> Original submission: If you start 1.8.2 and run this replay (which was made un
20111101 22:40:54< wesbot> der 1.8.2), it will most likely work. However, pause it during the replay, reset
20111101 22:40:57< wesbot> URL: https://gna.org/bugs/?16237
20111101 22:41:00< wesbot> Attached file (1st): https://gna.org/bugs/download.php?file_id=9465
20111101 22:42:04-!- crimson_pingvin [~ben@184.71.170.250] has joined #wesnoth-dev
20111101 22:42:04-!- crimson_pingvin [~ben@184.71.170.250] has quit [Changing host]
20111101 22:42:04-!- crimson_pingvin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20111101 22:42:10-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Read error: Connection reset by peer]
20111101 22:42:10-!- crimson_pingvin is now known as crimson_penguin
20111101 22:43:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20111101 22:49:26-!- enchilado [~enchilado@unaffiliated/enchilado] has joined #wesnoth-dev
20111101 22:50:16-!- negusnyul [~negusnyul@dsl54020BE5.pool.t-online.hu] has quit [Remote host closed the connection]
20111101 22:50:34< shadowmaster> hm, then we probably could refresh the old pointers too
20111101 22:50:51< shadowmaster> s/refresh/replace/
20111101 22:51:25< shadowmaster> or better yet, not have those pointers or any other sort of caching in the replay controller in the first place.
20111101 22:52:41< anonymissimus> yes, r48 is reponsible
20111101 22:52:48< anonymissimus> r48442
20111101 22:53:03< anonymissimus> the old code made some check whether the button already existed
20111101 22:57:23< anonymissimus> ok hm I'm assigning it to dragonking posting what we've found out
20111101 22:57:47< shadowmaster> wesbot: seen deekay
20111101 22:57:48< wesbot> shadowmaster: The person with the nick deekay 32d 22h ago was here and on the channel #wesnoth with the message: Quit: deekay
20111101 22:58:09< shadowmaster> That might not be very useful. We'd better come up with a fix on our own.
20111101 22:59:11< shadowmaster> It's just a matter of not keeping dangling pointers around.
20111101 22:59:29< anonymissimus> well, I don't commit a fix
20111101 23:00:00< anonymissimus> too much C++ theory and cyclic relations
20111101 23:00:33< shadowmaster> Huh.
20111101 23:00:41< shadowmaster> I thought you knew C++? :)
20111101 23:01:09< anonymissimus> I never learned C++ of izs own
20111101 23:01:32< anonymissimus> only language I learned theory for is java
20111101 23:01:52< anonymissimus> everything else I look up whenever I need it
20111101 23:04:18< shadowmaster> I guess our theory that you are someone else in disguise is rendered invalid, then.
20111101 23:04:21< shadowmaster> ;)
20111101 23:07:25-!- Grimling [~FKint@91.181.188.37] has quit [Quit: Leaving]
20111101 23:08:56< anonymissimus> I don't have a second nick here or something, no
20111101 23:19:54< anonymissimus> strange thing is also that it mostly works so there must be some UB involved
20111101 23:20:25< shadowmaster> dangling pointers *are* UB
20111101 23:20:58< shadowmaster> well, more like things done with them besides reassigning
20111101 23:22:09-!- Shakey [~Shakey@12.190.80.225] has quit [Quit: My goblin and me]
20111101 23:28:31< anonymissimus> actually, I had a small C++ course, but it was only one week and I understood nothing of it
20111101 23:28:53< anonymissimus> i was tryign to understand that I need headers fiels and such
20111101 23:29:49< anonymissimus> and I've never really using anything else than MSVC since then
20111101 23:30:25< anonymissimus> although the compiler warnings and errors by gcc *are* more useful admittedly
20111101 23:30:29< shadowmaster> Basically, the problem with dangling pointers is that you can't take an address to an object/POD once, destroy it, and then keep referencing the object by the stored address because that address could now point to a different object, the middle of a different object, or to memory that doesn't belong to the process anymore.
20111101 23:31:29< shadowmaster> The latter case is the most benign one because modern protected-mode operating systems like Windows and Linux will kill your process due to access violation/segmentation fault if you do that. The other cases can lead to all kinds of unexplainable behavior due to memory corruption.
20111101 23:33:39< shadowmaster> For example, maybe the address in question was taken when there was a gui::button instance allocated in it. Now that instance doesn't exist anymore and there's a long std::string there instead, which is periodically used to output something to the console. The code relying on its previous identity will misbehave (and hopefully crash), and the code relying on the std::string identity will output garbage to the console.
20111101 23:35:32< anonymissimus> this display::find_button seems strange to me however; it returns a pointer to a member of it
20111101 23:35:46< anonymissimus> and allows its member to be modified from anywhere thereby
20111101 23:36:26< shadowmaster> That's probably necessary so the End Turn/End Scenario switch works, at least.
20111101 23:37:50< shadowmaster> *output garbage to the console if the previous code succeeds in changing the memory pointed to by the dangling pointer.
20111101 23:43:20< anonymissimus> ok well I think I did about this bug what I can
--- Log closed Wed Nov 02 00:00:24 2011