--- Log opened Sun Dec 11 00:00:16 2011
20111211 00:04:49-!- wesbot changed the topic of #wesnoth-dev to: String/feature-freeze active for trunk | 165 bugs, 327 feature requests, 13 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20111211 00:31:31-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20111211 00:32:54-!- negusnyul_ [~negusnyul@dsl4E5C5C6B.pool.t-online.hu] has quit [Remote host closed the connection]
20111211 00:37:07-!- mjs-de [~mjs-de@g224185233.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20111211 00:38:51-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 00:43:01-!- BatmanGambit is now known as Gambit
20111211 00:50:01-!- mjs-de [~mjs-de@g224183138.adsl.alicedsl.de] has joined #wesnoth-dev
20111211 00:53:36-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: system reboot in progress]
20111211 00:55:37-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111211 00:56:40-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20111211 01:08:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20111211 01:38:48-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20111211 01:40:18-!- Kolbur [~die@82.113.99.205] has left #wesnoth-dev []
20111211 01:47:19-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20111211 01:56:04-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20111211 02:00:28< alink> mordante: yes, I added ~BLIT (and few others), but it was some time ago and the image path functions code has changed a lot
20111211 02:02:17< CIA-79> alink * r52213 /trunk/src/ (6 files in 3 dirs): 
20111211 02:02:17< CIA-79> Small optimization of ToD local light and code simplification.
20111211 02:02:17< CIA-79> Add a ToD color struct and operators to easily kill some wasteful ~CS(0,0,0)
20111211 02:02:17< CIA-79> (which were common for some ToD cases)
20111211 02:08:27-!- mjs-de [~mjs-de@g224183138.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20111211 02:10:02< alink> and i am not sure that I like the image path functions code. Seems to be a good example of "let's rewrite this big ugly but simple if-else pages in some elegant but over-engineered code"
20111211 02:10:13< alink> with weird macro etc
20111211 02:11:39< shadowmaster> I kind of started the trend, then someone submitted a patch that made it even, uh, better.
20111211 02:11:43< alink> which is fine until you want to add a simple little thing not expected by the design idea
20111211 02:12:18< shadowmaster> why someone threw a Lua engine implementation detail into it later beats me
20111211 02:12:52< shadowmaster> in particular, I'd not have approved of the macros
20111211 02:13:22< alink> ilor did that too for ":debug commands" and now it's always a lot of work to add a simple new :command.
20111211 02:14:23< alink> in the past it was just add "if cmd==":cool" {}"  , now you must study a OO monsters and edit multiple files with weird compiler errors
20111211 02:15:09-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20111211 02:15:49< alink> i like the intention, but I suspect that sometimes the designer lost track of the KISS
20111211 02:17:03< shadowmaster> didn't that change bring built-in command descriptions though?
20111211 02:17:43< alink> yes there was good feature too, indeed 
20111211 02:18:47< alink> but I suspect that a more KISS way could provide them too
20111211 02:19:33< alink> it's probably a flaw of c++, the temptation to write such cathedral even when not needed
20111211 02:30:32-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20111211 02:42:02-!- horon [~horon@nttkyo316066.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20111211 02:48:55-!- antonius [~quassel@61.94.173.77] has joined #wesnoth-dev
20111211 02:50:13< alink> shadowmaster: there is bound limitation to ~CROP ?
20111211 02:51:03< alink>  error display: start X coordinate of SECTION modification is negative - truncating to zero
20111211 02:51:04-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Remote host closed the connection]
20111211 02:51:25< alink> if I understand correctly, maybe an error message is not needed
20111211 02:52:08< shadowmaster> just remember that there's a feature freeze active until 1.10
20111211 02:52:36< shadowmaster> I implemented CROP so many years ago I couldn't possibly remember why I added artificial limitations to the top layer
20111211 02:53:23< alink> ok, I just try to use it for something else and it spams the console
20111211 02:54:15 * alink is trying to fix ~LOC which was lost during the code rewrite
20111211 02:55:05< shadowmaster> what was that supposed to do?
20111211 02:55:07< alink> and since now it's impossible to make ~LOC works there, I try to replace it with a combination of other image path calls
20111211 02:55:33< alink> i use it internally only for :layers
20111211 02:55:41< shadowmaster> oh, found this: https://gna.org/bugs/index.php?12067#comment2
20111211 02:57:17< alink> ~LOC cut images in hexes like the terrain engine does
20111211 02:57:40< shadowmaster> *big sigh* https://gna.org/bugs/index.php?11704
20111211 02:58:47< alink> Do we need a ~BLUR ?  ;-p
20111211 03:03:43-!- Octalot [~noct@host86-186-159-239.range86-186.btcentralplus.com] has quit []
20111211 03:06:19< alink> ok it seems that these limitation of ~CROP are not needed anymore, cut_surface is robust enough now
20111211 03:07:30< alink> I suppose that silencing errors spams doesn't break the freeze
20111211 03:09:35< alink> but not sure about the values handling, depends if fixing a reported error is a feature
20111211 03:09:59-!- happygrue [~George@wesnoth/developer/wintermute] has quit [Ping timeout: 252 seconds]
20111211 03:11:35< Espreon> alink: Who knows if we need it? But let's keep it.
20111211 03:12:22< alink> Espreon: well my point is that's a useless limitation of ~CROP
20111211 03:12:26< shadowmaster> if cut_surface() won't trigger a segmentation fault or behave erratically in any other way when fed negative/OOB coordinates, then go ahead
20111211 03:12:31-!- happygrue [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20111211 03:13:10< Espreon> alink: I meant BLUR.
20111211 03:13:16< alink> shadowmaster: right I should study that carefully, in case someone was ignoring the error message
20111211 03:14:25< alink> Espreon: oh ok sorry, I was joking about adding it, I was not aware that we already have it
20111211 03:14:31< Espreon> Ah.
20111211 03:14:53< alink> (because shadowmaster wanted blurred menu)
20111211 03:15:05< shadowmaster> no, I don't know why I added BLUR
20111211 03:15:20< shadowmaster> the implementation detail used by BLUR was already there in use in GUI1 dialogs
20111211 03:15:26< alink> it's ~BL btw
20111211 03:15:48< shadowmaster> IIRC it was esr's idea before I joined
20111211 03:16:24< Espreon>     
20111211 03:16:30< Espreon>    
20111211 03:16:40< shadowmaster> Espreon: what's up?
20111211 03:16:41< alink> well it didn't use image path function anyway, again I was joking about abusing them on the titlecreen background
20111211 03:17:13< shadowmaster> not abuse, besides Jetrel came up with the idea at the same time as me
20111211 03:17:53< shadowmaster> unfortunately a certain person whose name begins with 'M' didn't have time to fix the GUI2 implementation
20111211 03:18:44< alink> yeah I mean just add ~BL to the titlecreen image, and boom problem solved (except that it's blurred everywhere, not just under menus but that's a detail)
20111211 03:18:57< alink> <:o)
20111211 03:19:19-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20111211 03:19:23< shadowmaster> hmmmmmmmmmm
20111211 03:20:09< shadowmaster> that does give me an idea, but it would turn out to be rather expensive
20111211 03:21:03< shadowmaster> i.e. set the titlescreen panels' background to variations of the titlescreen background path with a creative use of SCALE, CROP, BL and BLIT
20111211 03:21:48< alink> assuming that the menus never move with resolution
20111211 03:22:02< shadowmaster> (SCALE using the titlescreen dialog dimensions, CROP using the panel geometry, BL, and BLIT (a scaled version?) the transparent background PNG
20111211 03:22:36< shadowmaster> presumably, if the resolution changes the formula will be re-evaluated with the new geometry
20111211 03:22:47< alink> madness
20111211 03:23:47< shadowmaster> of course that would require processing a new copy of the titlescreen background for every panel (two panels)
20111211 03:24:11< alink> and it's a big image
20111211 03:24:47< shadowmaster> yeah, that would create a performance problem as the titlescreen dialog size difers from the background picture's real size
20111211 03:25:32< alink> well, we are not talking seriously about doing that, I hope?
20111211 03:25:44-!- Vorpal [~AnMaster@unaffiliated/anmaster] has quit [Ping timeout: 252 seconds]
20111211 03:25:50< shadowmaster> of course not!
20111211 03:25:58< alink> just checking
20111211 03:26:33< alink> note that I used image path trick for the titlescreen on the OGL branch
20111211 03:26:49< shadowmaster> but it serves as an example of how BL could be used in a real situation
20111211 03:28:34< alink> another possible use of ~BL is to have outline shadow for sprite
20111211 03:29:05< alink> img~DARK~BL~BL~BLIT(img) 
20111211 03:29:12< alink> or something like that 
20111211 03:29:46< shadowmaster> I think BL takes a radius/strength argument
20111211 03:29:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20111211 03:29:58< alink> even better 
20111211 03:31:22< alink> in fact using ~SCALE ~BLIT ~DARK ~BL you could even drop nice smooth silhouette shadow below units :)
20111211 03:31:58< alink> (not in order )
20111211 03:32:49< alink> ah need to tweak alpha too
20111211 03:33:43< shadowmaster> there is ~O to change opacity
20111211 03:37:06< alink> this thing is too powerful, no need for opengl, just use more image path functions ;-p
20111211 03:42:26< Espreon> Hmmm, it seems garbage escaped the application I was using.
20111211 03:42:29< Espreon> Sorry.
20111211 03:49:29-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: done building targets]
20111211 03:50:45-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 268 seconds]
20111211 03:52:26-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111211 04:12:32-!- antonius [~quassel@61.94.173.77] has quit [Quit: brb]
20111211 04:13:39-!- atomicbomb [~quassel@61.94.173.77] has joined #wesnoth-dev
20111211 04:16:16< alink> ah I can finally replace the broken (and a bit useless) ~LOC by ~CROP~MASK
20111211 04:17:44< alink> just need to remove the limitations of ~CROP. I am almost sure that I can since the terrain engine crops with negative values all the times, but I will check the algo in details
20111211 04:18:53< alink> I am also happy to have a working ":layers" again :-)
20111211 04:20:58< alink> it really exposes well the craziness of our terrain engine where each grass tile is composed of 20 images
20111211 04:22:26< alink> anyway, I will finish that later, gn
20111211 04:22:34-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20111211 04:29:21-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20111211 04:33:55-!- chpln [~chpln@ppp118-210-56-64.lns20.adl2.internode.on.net] has quit [Ping timeout: 268 seconds]
20111211 04:38:30< AI0867> Ivanovic: okay, well, I can change the update script, but someone with a shell account will have to replace the wescamp checkouts
20111211 04:51:54-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house]
20111211 04:52:11-!- Ivanovic_ [~ivanovic@dtmd-4db22775.pool.mediaWays.net] has joined #wesnoth-dev
20111211 04:54:43-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20111211 04:56:08-!- Ivanovic_ is now known as Ivanovic
20111211 05:17:28-!- atomicbomb [~quassel@61.94.173.77] has quit [Remote host closed the connection]
20111211 05:19:42-!- antonius [~quassel@61.94.173.77] has joined #wesnoth-dev
20111211 05:26:41-!- chpln [~chpln@ppp121-45-87-154.lns20.adl6.internode.on.net] has joined #wesnoth-dev
20111211 05:44:20-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 252 seconds]
20111211 05:58:38-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has joined #wesnoth-dev
20111211 05:59:35-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20111211 06:24:14-!- antonius is now known as atomicbomb
20111211 06:32:39-!- Gambit [~quassel@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20111211 07:06:53-!- happygrue_ [~George@wesnoth/developer/wintermute] has joined #wesnoth-dev
20111211 07:10:22-!- happygrue [~George@wesnoth/developer/wintermute] has quit [Ping timeout: 252 seconds]
20111211 07:19:05< csarmi> !tag 1.9.9
20111211 07:19:09< shikadibot> csarmi: Tag 1.9.9, revision 51017 (ivanovic) on Sun Sep  4 14:30:02 2011:
20111211 07:19:13< shikadibot> csarmi: tagged 1.9.9, using r51016
20111211 07:19:14< shikadibot> csarmi: Web interface URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=51017
20111211 07:23:01-!- atomicbomb [~quassel@61.94.173.77] has quit [Remote host closed the connection]
20111211 07:24:35-!- atomicbomb [~quassel@61.94.173.77] has joined #wesnoth-dev
20111211 07:40:12-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20111211 07:42:07-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20111211 07:44:18-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has joined #wesnoth-dev
20111211 08:07:31-!- antonius [~quassel@61.94.173.77] has joined #wesnoth-dev
20111211 08:07:35-!- atomicbomb [~quassel@61.94.173.77] has quit [Remote host closed the connection]
20111211 08:17:07-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20111211 09:07:20-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20111211 09:27:36-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20111211 09:41:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20111211 09:44:46-!- antonius is now known as atomic
20111211 10:01:15-!- Ivanovic [~ivanovic@dtmd-4db22775.pool.mediaWays.net] has quit [Changing host]
20111211 10:01:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20111211 10:04:14-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 10:04:14-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 10:04:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 10:10:11-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20111211 10:10:11-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20111211 10:10:11-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20111211 10:10:25< mordante> servus
20111211 10:11:08< Ivanovic> moin
20111211 10:11:14< mordante> hi Ivanovic 
20111211 10:16:48< CIA-79> mordante * r52214 /trunk/src/whiteboard/recruit.cpp: Initialize all members.
20111211 10:16:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 10:17:20-!- Elvish_Hunter [6d36ec6e@gateway/web/freenode/ip.109.54.236.110] has joined #wesnoth-dev
20111211 10:18:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20111211 10:21:47-!- Kolbur [~die@89.204.130.68] has joined #wesnoth-dev
20111211 10:22:37-!- stikonas__ [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 10:26:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20111211 10:31:52< CIA-79> elvish_hunter * r52215 /trunk/ (2 files in 2 dirs): NR: fixed sighted events in Infested Caves
20111211 10:36:12< CIA-79> elvish_hunter * r52216 /trunk/ (2 files in 2 dirs): NR: fixed Hamel not having the hero overlay
20111211 10:38:46-!- stikonas__ is now known as stikonas
20111211 10:39:05-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 10:39:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 10:41:23< CIA-79> elvish_hunter * r52217 /trunk/ (2 files in 2 dirs): NR: fixed Dwarves recruitment not being disallowed in Clearing the Mines
20111211 10:52:01< CIA-79> elvish_hunter * r52218 /trunk/ (2 files in 2 dirs): NR: fixed sighted events in The Pursuit
20111211 10:56:43< CIA-79> elvish_hunter * r52219 /trunk/ (2 files in 2 dirs): NR: added hero overlay to Ro'Arthian and Ro'Sothian
20111211 11:00:27-!- atomic [~quassel@61.94.173.77] has quit [Quit: Bath]
20111211 11:01:29< CIA-79> elvish_hunter * r52220 /trunk/ (2 files in 2 dirs): NR: used ON_SIGHTING in Introductions
20111211 11:03:50-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20111211 11:07:42< CIA-79> elvish_hunter * r52221 /trunk/ (3 files in 2 dirs): NR: added expendable leader overlay to Krash and Eryssa
20111211 11:09:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:12:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 11:13:43< CIA-79> elvish_hunter * r52222 /trunk/ (2 files in 2 dirs): NR: fixed a couple of minor bugs in Stolen Gold
20111211 11:18:41-!- Sytyi [~Sytyi@252-156-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20111211 11:18:46-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20111211 11:18:53-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Remote host closed the connection]
20111211 11:19:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:19:42< CIA-79> elvish_hunter * r52223 /trunk/ (2 files in 2 dirs): NR: fixed the fake Gryphon's movement in The Eastern Flank
20111211 11:22:12-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 11:22:12-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 11:22:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 11:25:11< CIA-79> elvish_hunter * r52224 /trunk/ (2 files in 2 dirs): NR: the two Liches lose the hero overlay if they're leaders in Showdown
20111211 11:27:51< CIA-79> elvish_hunter * r52225 /trunk/ (2 files in 2 dirs): NR: fixed Hamel's death as defeat condition in Showdown
20111211 11:30:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:32:49< CIA-79> elvish_hunter * r52226 /trunk/ (2 files in 2 dirs): NR: fixed music playlist in Epilogue
20111211 11:33:47-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 11:33:48-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 11:33:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 11:36:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:38:55< Elvish_Hunter> And now, after so many fixes for NR, two more bugfixes for Eastern Invasion...
20111211 11:39:16-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20111211 11:40:24< CIA-79> elvish_hunter * r52227 /trunk/ (2 files in 2 dirs): EI: fixed sighted event in The Escape Tunnel
20111211 11:41:04-!- Gallaecio [~quassel@84.120.216.157.dyn.user.ono.com] has joined #wesnoth-dev
20111211 11:41:49-!- loonybot [~loonybot@46.138.81.125] has joined #wesnoth-dev
20111211 11:41:49-!- loonybot [~loonybot@46.138.81.125] has quit [Changing host]
20111211 11:41:49-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20111211 11:43:54< CIA-79> elvish_hunter * r52228 /trunk/ (2 files in 2 dirs): EI: fixed a typo in Konrad's last breath event
20111211 11:44:40-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 11:44:40-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 11:44:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 11:46:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:47:14< Elvish_Hunter> Well, I guess that I finished my commits for today. Bye!
20111211 11:47:24-!- Elvish_Hunter [6d36ec6e@gateway/web/freenode/ip.109.54.236.110] has quit [Quit: Ciao!]
20111211 11:52:32-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 11:52:32-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 11:52:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 11:53:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 11:58:37-!- Atomicbomb [~quassel@125.161.22.133] has joined #wesnoth-dev
20111211 12:00:32-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 12:00:32-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 12:00:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 12:03:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 12:09:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 12:31:11-!- Octalot [~noct@host86-186-159-239.range86-186.btcentralplus.com] has joined #wesnoth-dev
20111211 12:37:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 12:39:21-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 12:39:21-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 12:39:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 12:45:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20111211 12:51:49-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has joined #wesnoth-dev
20111211 12:51:49-!- stikonas [~gentoo@ctv-213-164-121-13.vinita.lt] has quit [Changing host]
20111211 12:51:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 13:02:02-!- Atomicbomb [~quassel@125.161.22.133] has quit [Read error: Connection reset by peer]
20111211 13:18:52< CIA-79> caslav_ilic * r52229 /trunk/ (130 files in 29 dirs): Updated translations for Serbian.
20111211 13:20:51-!- negusnyul [~negusnyul@h47-207.pool95-168.dyn.tolna.net] has quit [Read error: Connection reset by peer]
20111211 13:35:46-!- Gambit [~quassel@wesnoth/developer/grickit] has joined #wesnoth-dev
20111211 13:41:45< Kolbur> hello
20111211 13:42:17< Kolbur> i see no folder for the current date on the replay server for 1.8
20111211 13:44:26< csarmi> me neither
20111211 13:54:45-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Read error: Connection reset by peer]
20111211 14:04:17-!- Kolbur [~die@89.204.130.68] has quit [Ping timeout: 252 seconds]
20111211 14:04:24< Soliton> should be visible now.
20111211 14:05:08< Soliton> no idea how that error happened unfortunately.
20111211 14:07:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20111211 14:08:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 14:09:52< Soliton> hmm, maybe if the server was very busy at the time...
20111211 14:18:06-!- Kolbur [~die@89.204.130.68] has joined #wesnoth-dev
20111211 14:19:20-!- negusnyul [~negusnyul@1F2EA95B.dsl.pool.telekom.hu] has joined #wesnoth-dev
20111211 14:23:56-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20111211 14:25:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20111211 14:42:42-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20111211 14:48:10-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 14:48:10-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 14:48:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 14:56:25< Soliton> loonybot << NAME_MAX
20111211 14:56:34< loonybot> 255
20111211 14:58:14< Soliton> loonybot << _POSIX_NAME_MAX
20111211 14:58:15< loonybot> 14
20111211 15:11:23-!- Kolbur [~die@89.204.130.68] has quit [Ping timeout: 252 seconds]
20111211 15:23:22< csarmi> loonybot << help
20111211 15:23:28< loonybot> Mini-manual:  http://www.eelis.net/geordi/
20111211 15:31:40< CIA-79> ivanovic * r52230 /trunk/ (26 files in 23 dirs): updated Czech and German translation
20111211 15:32:20-!- mjs-de [~mjs-de@f053188001.adsl.alicedsl.de] has joined #wesnoth-dev
20111211 15:33:01< CIA-79> ivanovic * r52231 /trunk/ (changelog players_changelog): fix changelogs to only use 80 chars per line
20111211 15:44:28-!- Kolbur [~die@89.204.130.68] has joined #wesnoth-dev
20111211 15:58:07-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20111211 15:59:38-!- horon [~horon@nttkyo316066.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20111211 16:11:58-!- EdB [~edb@89.82.194.231] has joined #wesnoth-dev
20111211 16:14:26-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20111211 16:14:32< alink> hi
20111211 16:33:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Operation timed out]
20111211 16:34:54-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 16:34:54-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 16:34:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 16:47:14< CIA-79> alink * r52232 /trunk/src/menu_events.cpp: 
20111211 16:47:14< CIA-79> Fix hex-cut images in :layers
20111211 16:47:14< CIA-79> This remove the need of ~LOC (which was broken some time ago) by using ~CROP~MASK instead.
20111211 16:47:17< CIA-79> alink * r52233 /trunk/src/image_modifications.cpp: Remove disabled code for ~LOC
20111211 16:48:39-!- EdB [~edb@89.82.194.231] has quit [Remote host closed the connection]
20111211 16:48:40< alink> shadowmaster: I didn't need to change ~CROP limitation for now. Maybe a bit more tricky that I thought since it can also create image containing 0 pixels
20111211 16:55:00< CIA-79> alink * r52234 /trunk/changelog: update changelog
20111211 16:56:53< CIA-79> ai0867 * r52235 /trunk/data/scenario-test.cfg: Add test case for bug #17961 and bug #18686 to test scenario
20111211 17:06:55-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer]
20111211 17:32:51-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20111211 17:34:42< anonymissimus> Soliton: see bug #19161 btw; it was supposedly introduced by my half-baked fix for the MP bug
20111211 17:51:36-!- chrisoelmueller [bouncer@syngo.info] has left #wesnoth-dev ["Where's those banana cream pies, eh"]
20111211 18:01:37-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20111211 18:04:46< CIA-79> alink * r52236 /trunk/ (8 files in 3 dirs): 
20111211 18:04:46< CIA-79> Fix lingering dead code for brightened hexes.
20111211 18:04:46< CIA-79> It was disabled since the new golden hex cursor. Also rename "semi-brightened"
20111211 18:04:46< CIA-79> (still used for editor selection) as "brightened"
20111211 18:13:31< csarmi> hi anonymissimus
20111211 18:14:57< anonymissimus> wesbot: bug #17961
20111211 18:14:58< wesbot> Bug #17961  Assigned to: Mark de Wever <mordante>  Status: Ready For Test  Priority: 5 - Normal
20111211 18:15:01< wesbot> Summary: portaits scaled badly in dialogue
20111211 18:15:04< wesbot> Original submission: Starting in 1.9.3, the portraits got scaled down severely
20111211 18:15:07< wesbot> , at least for some screen sizes.  In 1.9.5, the scaling method degrades the ima
20111211 18:15:10< wesbot> URL: https://gna.org/bugs/?17961
20111211 18:23:30< CIA-79> alink * r52237 /trunk/src/editor/editor_display.cpp: 
20111211 18:23:30< CIA-79> Fix selection under brush in editor.
20111211 18:23:30< CIA-79> It disabled selection brightening under the brush, making the brush more visible
20111211 18:23:30< CIA-79> but the selection area less clear in some cases. Looking at the code, it looks like
20111211 18:23:30< CIA-79> an unwanted result from another change. I also move the brush layer to the cursor layer.
20111211 18:23:30< CIA-79> Make sense and help to better see the brush to compensate the first change.
20111211 18:27:30< CIA-79> ai0867 * r52238 /trunk/ (4 files in 3 dirs): Dutch translation fixes for problems found by posieve
20111211 18:35:42-!- Octalot [~noct@host86-186-159-239.range86-186.btcentralplus.com] has quit []
20111211 18:40:31-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20111211 18:45:58-!- knotwork [~markm@142.177.235.88] has joined #wesnoth-dev
20111211 18:45:58-!- knotwork [~markm@142.177.235.88] has quit [Changing host]
20111211 18:45:58-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20111211 18:48:56-!- Sytyi [~Sytyi@252-156-133-95.pool.ukrtel.net] has quit [Quit: Leaving.]
20111211 18:53:08-!- Sytyi [~Sytyi@252-156-133-95.pool.ukrtel.net] has joined #wesnoth-dev
20111211 19:02:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: No route to host]
20111211 19:02:49-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 19:02:49-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 19:02:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 19:16:44-!- grzywacz [~grzywacz@89-72-193-138.dynamic.chello.pl] has joined #wesnoth-dev
20111211 19:16:48-!- grzywacz [~grzywacz@89-72-193-138.dynamic.chello.pl] has quit [Changing host]
20111211 19:16:48-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20111211 19:20:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20111211 19:46:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 19:49:19-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 19:49:42-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 19:52:16-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 19:52:16-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 19:52:16-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 19:59:40-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 20:02:44-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 20:02:44-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 20:02:44-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 20:03:06-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 20:07:07-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 20:07:07-!- stikonas [~and@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 20:07:07-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 20:07:52-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 20:12:31-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 20:14:28-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 20:17:23-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 20:18:54< anonymissimus> wesbot: bug #18686
20111211 20:18:55< wesbot> Bug #18686  Assigned to: Mark de Wever <mordante>  Status: Ready For Test  Priority: 5 - Normal
20111211 20:18:58< wesbot> Summary: Using really big images in [message] can cause image doesn't fit on canvas errors to be thrown
20111211 20:19:01< wesbot> Original submission: When starting Mystery Campaign from the add-ons server, t
20111211 20:19:04< wesbot> he following error is thrown and the campaign aborts:The error message is :
20111211 20:19:07< wesbot> URL: https://gna.org/bugs/?18686
20111211 20:21:35-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 20:22:10-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 20:30:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20111211 20:46:49< anonymissimus> Espreon: could you run umcpropfix on SoW please ?
20111211 20:47:15< anonymissimus> added and changed quite some stuff
20111211 20:50:21< shadowmaster> done, only one file was affected
20111211 21:05:29< anonymissimus> shadowmaster: what seriousness is going to be added to HttT ?
20111211 21:06:34< shadowmaster> less goofy prose
20111211 21:07:59< csarmi> anonymissimus
20111211 21:08:19< anonymissimus> we can make another game if you want
20111211 21:08:29< anonymissimus> but update the addon
20111211 21:08:44< csarmi> we can play if you like
20111211 21:08:59< anonymissimus> might get OOS if it is not the exact same version...and I need to figure out a test for that...
20111211 21:09:41< csarmi> updated
20111211 21:09:48< csarmi> test for what?
20111211 21:10:06< anonymissimus> some test for that every player uses the same addon version
20111211 21:10:13< csarmi> the addon to test if players use same version?
20111211 21:10:42< anonymissimus> I know addons dont usually care for that, but the technical requirements for and addon written by me are high :)
20111211 21:10:52< csarmi> I suppose that should be something basic? I dont know much about creating maps but it sounds like that
20111211 21:11:30< anonymissimus> no its absolutely nto trivial
20111211 21:11:47< csarmi> aha
20111211 21:12:15< csarmi> I supposed a check like that should be smething scenario developers would like to do
20111211 21:35:02-!- Blueblaze [~Blueblaze@adsl-99-4-147-142.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 248 seconds]
20111211 21:38:52< shadowmaster> perhaps the FORCE_CHANCE_TO_HIT macro in data/core/macros/utils.cfg should use [filter_condition] now?
20111211 21:41:56< zookeeper> yes, it should
20111211 21:46:26-!- Blueblaze [~Blueblaze@99.4.147.142] has joined #wesnoth-dev
20111211 21:46:44< CIA-79> ai0867 * r52239 /trunk/src/ (dialogs.cpp reports.cpp unit.hpp unit_abilities.cpp): Fix help-links from sidebar for female abilities. (bug #18745)
20111211 21:47:03< AI0867> Espreon: ^
20111211 21:47:36< shadowmaster> looks like placement=map_overwrite doesn't work
20111211 21:48:34< AI0867> shadowmaster: is that even a valid placement?
20111211 21:48:53< shadowmaster> it's listed in http://wiki.wesnoth.org/SingleUnitWML
20111211 21:49:16< AI0867> I see map and map_passable
20111211 21:49:50< AI0867> it's not in the source
20111211 21:49:57< AI0867> so someone was overzealous in documenting it
20111211 21:51:57< shadowmaster> that would've been Crab_
20111211 21:52:16< AI0867> perhaps it was a planned feature
20111211 21:52:29< shadowmaster> :/
20111211 21:52:36< AI0867> the _passable doesn't seem to affect overwriting units, just whether they're impassable
20111211 21:52:53< AI0867> everything passes pathfind::VACANT_ANY
20111211 21:54:42< shadowmaster> wesbot: seen Crab_
20111211 21:54:42< wesbot> shadowmaster: The person with the nick Crab_ last spoke 44d 2h ago.  25d 22h ago they left with the message: Client Quit
20111211 21:54:47< shadowmaster> wesbot: seen Crab__
20111211 21:54:47< wesbot> shadowmaster: Person, who 42d 2h ago used nick Crab__, 42d 1h ago as Crab___ they left with the message: Ping timeout: 260 seconds
20111211 21:55:13< shadowmaster> and the GUI2 chat log dialog still hasn't been forward ported
20111211 21:55:39< AI0867> it was developed on 1.8?
20111211 21:56:04< shadowmaster> yes
20111211 21:56:39< AI0867> I consider that a bug
20111211 21:57:02< shadowmaster> first appeared in r49342 and received various commits before 1.8.6
20111211 21:57:49< shadowmaster> the first commit won't merge on trunk due to various changes
20111211 21:58:40< mordante> AI0867, I only expect it adds new strings as well :-(
20111211 21:59:02< mordante> but I agree it's sad it hasn't been merged with trunk yet
20111211 21:59:18< shadowmaster> I am pretty sure Ivanovic authorized the thawing for that particular case before tagging 1.9.10
20111211 21:59:22< AI0867> that's where it should have been developed to begin with
20111211 21:59:28< mordante> I agree
20111211 21:59:52< mordante> it would be cool if Ivanovic did, but I guess then we need to do it rather soon
20111211 22:00:26-!- mjs-de [~mjs-de@f053188001.adsl.alicedsl.de] has quit [Remote host closed the connection]
20111211 22:00:28< Ivanovic> the chat dialog was okayed if it is done rather soonish
20111211 22:00:41< Ivanovic> and yeah, it should have been developed in trunk and backported to stable
20111211 22:00:50< Ivanovic> but that was not the case so we can't change it
20111211 22:01:00< AI0867> shadowmaster: you've tried merging it? what are the problems?
20111211 22:01:13< Ivanovic> shadowmaster: do not expect Crab_ to do the commit, everything he does as open source stuff needs a review from google folks first
20111211 22:01:25< shadowmaster> AI0867: lots of conflicts
20111211 22:01:25< Ivanovic> (google holds all copyright for stuff that crab_ does these days)
20111211 22:01:36< shadowmaster> Ivanovic: hm, does he work for Google?
20111211 22:01:38< mordante> Ivanovic, oh didn't know that
20111211 22:01:50< mordante> also the stuff he does at home?
20111211 22:02:06< Ivanovic> mordante: anything!
20111211 22:02:19< mordante> that sucks :-(
20111211 22:02:38< Ivanovic> that is: they at least want to review the first some commits he does
20111211 22:02:54< Ivanovic> so crab_ is either postponing stuff, freaking busy or the reviews are taking *ages*
20111211 22:03:48< zookeeper> umm, what?
20111211 22:07:35< Gambit> They want to make sure he's not stealing stuff from them?
20111211 22:09:18< Ivanovic> he signed a contract where the ownership (aka copyright) of his work is property of google
20111211 22:09:55< shadowmaster> so he works for Google, right?
20111211 22:10:01< Ivanovic> shadowmaster: yes
20111211 22:10:21< mordante> afaik it's rather uncommon in Europe
20111211 22:10:46< shadowmaster> boucman: ping
20111211 22:11:56< AI0867> I'm not even sure if it'd be *legal* for that to apply to stuff he does at home
20111211 22:12:00< zookeeper> i'm pretty sure that even in the US, you can't have a contract which limits how you can copyright your own works if they have nothing to do with whoever you make the contract with.
20111211 22:12:02< boucman> pong
20111211 22:12:07< boucman> shadowmaster: pong
20111211 22:12:32< shadowmaster> boucman: I found some inaccuracies in the AnimationWML page in the wiki.
20111211 22:12:45< mordante> AI0867, yeah, but don't know the rules in Switzerland
20111211 22:13:04< mordante> zookeeper, I wouldn't be too sure about the USA
20111211 22:13:05< boucman> ok, can you fix them or do you need me ?
20111211 22:13:57< shadowmaster> boucman: well, I'm not sure about one of them. As I said the other day, several animation descriptions mention an undocumented "highlight" attribute.
20111211 22:14:08< shadowmaster> IIRC I couldn't find anything like that in the source and I don't know what the correct name should be.
20111211 22:14:10< boucman> hmm
20111211 22:14:36< shadowmaster> I just found that in the levelin and levelout animation descriptions at least, the blend_* attributes are completely wrong.
20111211 22:15:24< boucman> ok, highlight is the internal name for the attribute named "alpha", my mistake
20111211 22:15:41< boucman> i'll check levelin
20111211 22:15:44< shadowmaster> blend_width should be blend_ratio, and I think the numbers are also reversed (should be 0~1 for levelin and 1~0 for levelout unless the levelin/levelout order is incorrect, I think)
20111211 22:16:40< shadowmaster> and example further below (for [defend]) uses blend_with where it should use blend_color
20111211 22:17:05< shadowmaster> of course I don't know what else doesn't reflect the real source behavior anymore (if it ever did)
20111211 22:17:17-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Read error: Connection reset by peer]
20111211 22:17:49< boucman> shadowmaster: description of levelin and levelout are reversed, levelout is the animation when you level out of a unit, levelin is when you level into the new unit
20111211 22:18:11< boucman> and again, blen_with is the internal name, I got them confused, my bad
20111211 22:18:20< shadowmaster> ahh
20111211 22:18:37< boucman> so blend_with is blend_ratio
20111211 22:18:54< AI0867> mordante: have you read my comments on the bugs you marked ready for test?
20111211 22:19:26< boucman> hmm, wait a second, 
20111211 22:19:55< boucman> the two correct names are "blend_ratio" and "blend_color"
20111211 22:20:02< boucman> can I let you correct it ?
20111211 22:20:11-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Read error: Operation timed out]
20111211 22:20:40< anonymissimus> shadowmaster: this placement key is IMHO bad wml design; a single key shouldnt be overloaded with so many stuff
20111211 22:20:41< shadowmaster> I guess so, not sure if those are the only inaccuracies as I said, though.
20111211 22:21:04< anonymissimus> it should better have been several single boolean keys
20111211 22:21:32< anonymissimus> but anyway, looks unhandled in the unit creator
20111211 22:21:36-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 22:22:02< shadowmaster> I was more shocked about the placement thing popping up in middle of the 1.7 feature freeze
20111211 22:24:07< Gambit> But that's like... slavery :|
20111211 22:24:35< Gambit> Er whoops I didn't scroll and was still reading the earlier stuff about poor Crab_
20111211 22:26:39< shadowmaster> boucman: okay, fixed
20111211 22:26:50< boucman> thx a lot
20111211 22:40:59< Espreon> mordante: Even after that revision, certain portraits are problematic.
20111211 22:41:05< Espreon> Like Nemesis's portrait in BMR.
20111211 22:45:28< anonymissimus> wesbot: bug #15146
20111211 22:45:29< wesbot> Bug #15146  Assigned to: Iurii Chernyi <crab>  Status: Fixed  Priority: 5 - Normal
20111211 22:45:32< wesbot> Summary: Wesnoth crashes after Kaleh dies because of Lava
20111211 22:45:34< wesbot> Original submission: Campaign: Under the burning SunLevel: In the Tunnel of 
20111211 22:45:37< wesbot> the TrollsAt the End of the Map, when Kaleh dies because of Lava, the Game c
20111211 22:45:40< wesbot> URL: https://gna.org/bugs/?15146
20111211 22:45:43< wesbot> Attached file (1st): https://gna.org/bugs/download.php?file_id=7712
20111211 22:48:39< anonymissimus> wesbot: patch #1392
20111211 22:48:40< wesbot> Patch #1392  Assigned to: Jörg Hinrichs <jhinrichs>  Status: Done  Priority: 5 - Normal
20111211 22:48:43< wesbot> Summary: Debugmode deactivation in multiplayer mode
20111211 22:48:46< wesbot> Original submission: Hello,there seems to be a little bug: When you join a m
20111211 22:48:49< wesbot> ultiplayer game after activating the debugging mode in single-player mode, it's 
20111211 22:48:52< wesbot> URL: https://gna.org/patch/?1392
20111211 22:48:54< wesbot> Attached file (1st): https://gna.org/patch/download.php?file_id=7540
20111211 22:55:29< mordante> AI0867, I did now
20111211 22:56:41< mordante> Espreon, BMR?
20111211 22:58:05 * anonymissimus wishes the wiki would allow for "blame" functionality
20111211 22:59:07< Espreon> mordante: Bad Moon Rising
20111211 22:59:18-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20111211 22:59:20-!- negusnyul [~negusnyul@1F2EA95B.dsl.pool.telekom.hu] has quit [Remote host closed the connection]
20111211 22:59:49< mordante> Espreon, ah ok, could you post the information in the bug report
20111211 23:00:00< Espreon> Sure.
20111211 23:00:05< mordante> then I hope to be able to look at it before 1.9.13
20111211 23:00:07< mordante> thanks
20111211 23:00:47< anonymissimus> wesbot: bug #15113
20111211 23:00:48< wesbot> Bug #15113  Assigned to: Iurii Chernyi <crab>  Status: Postponed  Priority: 5 - Normal
20111211 23:00:51< wesbot> Summary: Units can talk in their own die events
20111211 23:00:54< wesbot> Original submission: A die event fires after the unit's death animation plays,
20111211 23:00:57< wesbot>  and the unit disappears. However, in the following code, the unit that triggere
20111211 23:01:00< wesbot> URL: https://gna.org/bugs/?15113
20111211 23:01:26< Espreon> mordante: No prob.
20111211 23:02:40-!- Aethaeryn [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20111211 23:02:44< CIA-79> alink * r52241 /trunk/src/ (7 files in 2 dirs): Use better parameters order for get_time_of_day()
20111211 23:02:48< CIA-79> alink * r52240 /trunk/src/ (6 files in 2 dirs): 
20111211 23:02:48< CIA-79> Optimize get_time_of_day()
20111211 23:02:48< CIA-79> Split in 2 functions depending if illumination is needed.
20111211 23:02:48< CIA-79> This allows to use reference for the common case.
20111211 23:04:25< anonymissimus> shadowmaster: well the last bug I queried is the related one to map_overwrite
20111211 23:04:58< anonymissimus> it looks as if Crab "forgot" to implement it after documenting
20111211 23:05:00< mordante> I'm off night
20111211 23:05:18< anonymissimus> or thought he had coded it
20111211 23:05:26< shadowmaster> I don't see anything about placement in #15113
20111211 23:06:19-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20111211 23:06:41< anonymissimus> that is the correct report
20111211 23:07:23< anonymissimus> if you read a bit through it; and Crab's commit message in teh wiki mentions this bug
20111211 23:08:02< anonymissimus> his commit message where he documents the placement key and its attributes, including map_overwrite
20111211 23:16:25-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 23:16:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20111211 23:17:53< anonymissimus> alink: could you please not change my function names
20111211 23:18:08-!- Netsplit *.net <-> *.split quits: CIA-79, LordNasty, Amuchan
20111211 23:18:10-!- Netsplit *.net <-> *.split quits: koan, elias
20111211 23:18:12-!- Netsplit *.net <-> *.split quits: fstltna, wesbot, janebot
20111211 23:18:29-!- Netsplit *.net <-> *.split quits: melinath, ejls, Rhonda, Gambit, vultraz, Kolbur, Espreon, isaac, Ivanovic, apoi,  (+22 more, use /NETSPLIT to show all of them)
20111211 23:18:31-!- Netsplit over, joins: LordNasty
20111211 23:18:31-!- elias [~allefant@allefant.com] has joined #wesnoth-dev
20111211 23:18:42< anonymissimus> from what your commit looks like it seems that taking into account illuminating units also automatically takes or took into account time areas
20111211 23:18:57-!- Netsplit over, joins: Soliton, Amuchan, loonybot, Gallaecio
20111211 23:19:01< anonymissimus> this is no longer obvious with your function names
20111211 23:19:09-!- Netsplit over, joins: Mkaysi, Ingmar, erl
20111211 23:19:09-!- koan [~koan@174.136.97.66] has joined #wesnoth-dev
20111211 23:19:28-!- Netsplit over, joins: shadowmaster, apoi, vultraz, Rhonda
20111211 23:19:45-!- Netsplit over, joins: csarmi, loonycyborg, crimson_penguin, yann
20111211 23:19:51-!- Netsplit over, joins: matthiaskrgr, isaac, Smar
20111211 23:20:49-!- wesbot [~wesbot@asteria.debian.or.at] has joined #wesnoth-dev
20111211 23:20:49-!- janebot_ [grickit@bunker.unvanquished.net] has joined #wesnoth-dev
20111211 23:20:49-!- Netsplit over, joins: Espreon, AI0867, melinath, Elvish_Pillager, Kolbur
20111211 23:20:56-!- Guest82312 [bouncer@syngo.info] has joined #wesnoth-dev
20111211 23:21:02-!- Guest82312 is now known as chris_oelmueller
20111211 23:21:26-!- Netsplit over, joins: happygrue_, Aeth, alink, boucman, chpln, ejls
20111211 23:23:23-!- elias [~allefant@allefant.com] has quit [Changing host]
20111211 23:23:23-!- elias [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20111211 23:23:59< anonymissimus> when I call from somewhere else in the code a tod getting function i anyway don't know which to choose then, there's so many with confusing docs ;)
20111211 23:24:29< alink> anonymissimus: I removed a parameter consider_illuminates from get_time_od day() and instead used get_time_of_day() get_illuminated_time_of_day()
20111211 23:24:47< alink> if it is confusing, it's not because of my change
20111211 23:25:18-!- fstltna [~fstltna@74.63.219.251] has joined #wesnoth-dev
20111211 23:25:22-!- Upth [~ogmar@c-98-208-38-181.hsd1.ca.comcast.net] has joined #wesnoth-dev
20111211 23:25:22-!- Upth is now known as Upthorn
20111211 23:25:25-!- Gambit [~quassel@wesnoth/developer/grickit] has joined #wesnoth-dev
20111211 23:25:37-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has joined #wesnoth-dev
20111211 23:25:37-!- stikonas [~gentoo@ctv-213-164-110-84.vinita.lt] has quit [Changing host]
20111211 23:25:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 23:25:43-!- CIA-85 [~CIA@cia.atheme.org] has joined #wesnoth-dev
20111211 23:25:50-!- Ivanovic [~ivanovic@dtmd-4db22775.pool.mediaWays.net] has joined #wesnoth-dev
20111211 23:26:07< alink> the function named get_time_of_day_with_areas_and_units() was irrelevant because only called from one place inside tod_manager, so it was like a private function
20111211 23:26:53-!- Vorpal [~AnMaster@unaffiliated/anmaster] has joined #wesnoth-dev
20111211 23:28:03-!- janebot_ is now known as janebot
20111211 23:28:04< alink> so the number of public functions is the same, and the choice should only be: do i care about illumination
20111211 23:28:21-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20111211 23:28:33-!- janebot is now known as Guest80095
20111211 23:29:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20111211 23:29:55-!- Guest80095 [grickit@bunker.unvanquished.net] has quit [Remote host closed the connection]
20111211 23:30:48< alink> ah ok i see there is also a get_time_of_day_with_areas(), i will check if sill relevant
20111211 23:30:53< alink> *still
20111211 23:30:59-!- janebot [grickit@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20111211 23:31:22< anonymissimus> alink: also I'm not sure whether it is a good idea to make such refactoring at this time
20111211 23:31:52-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20111211 23:31:54< anonymissimus> consider that I fixed the tod stuff in ~May and there were zero bugs since then reported
20111211 23:31:55< alink> anonymissimus: are you serious? it doesn't even change the logic
20111211 23:32:42< alink> anonymissimus: that is an optimization, feature freeze is a good time to do that
20111211 23:33:52< alink> also if we can't even rename function and move parameter, that means stop touching the code
20111211 23:37:33< alink> ok, get_time_of_day is almost like get_time_of_day_with_areas, only difference is supporting off-map tiles. So I guess I can clean that
20111211 23:41:53< CIA-85> espreon * r52242 /trunk/ (4 files in 3 dirs): Updated the British English translation.
20111211 23:48:26< CIA-85> soliton * r52243 /trunk/src/playturn.cpp: 
20111211 23:48:26< CIA-85> do side init on controller change/side drop if necessary
20111211 23:48:26< CIA-85> properly fixes bug #16299
20111211 23:48:26< CIA-85> might fix bug #19161
20111211 23:51:15< anonymissimus> shadowmaster: left a note in the wiki that map_overwrite doesnt work
20111211 23:54:39< Soliton> testing of above commit is welcome. i just did a quick check with the procedure mentioned in bug #16299.
20111211 23:55:32< AI0867> shadowmaster, mordante: currently busy porting the first revision of (I believe) 3"
20111211 23:56:47< shadowmaster> AI0867: no, they are more than 3
20111211 23:57:16< AI0867> well, there are no more than 20 commits after the first chat log commit, so I can't have missed that many
20111211 23:57:24< shadowmaster> basically every commit by crab in the 1.8 branch since r49342 is related, so that should be 7 commits
20111211 23:58:45< shadowmaster> r49342, r49343, r49471, r49472, r49473, r39474
20111211 23:58:56< shadowmaster> also, I can't count
--- Log closed Mon Dec 12 00:00:32 2011