--- Log opened Sat Jan 14 00:00:31 2012
20120114 00:07:01-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120114 00:08:08-!- Elvish_Pillager [~eli@137.146.78.97] has joined #wesnoth-dev
20120114 00:13:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120114 00:24:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20120114 00:27:51< CIA-91> ivanovic * r52578 /trunk/ (10 files in 9 dirs): updated Czech translation
20120114 00:27:57< CIA-91> espreon * r52579 /website/start/1.10/ (index.fi.html po/fi.po): Updated the Finnish release announcement.
20120114 00:34:04< CIA-91> espreon * r52580 /website/start/1.10/ (index.fi.html po/fi.po): Fixed a broken path in the Finnish announcement.
20120114 00:38:51-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Ping timeout: 252 seconds]
20120114 00:39:32-!- crimson_pingvin [~ben@184.71.170.250] has joined #wesnoth-dev
20120114 00:39:33-!- crimson_pingvin [~ben@184.71.170.250] has quit [Changing host]
20120114 00:39:33-!- crimson_pingvin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120114 00:39:56-!- happygrue_ [~quassel@c-98-222-183-113.hsd1.il.comcast.net] has joined #wesnoth-dev
20120114 00:39:57-!- happygrue_ [~quassel@c-98-222-183-113.hsd1.il.comcast.net] has quit [Changing host]
20120114 00:39:57-!- happygrue_ [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev
20120114 00:42:23-!- Elvish_Pillage2 [~eli@137.146.78.97] has joined #wesnoth-dev
20120114 00:43:10-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Disconnected by services]
20120114 00:43:17-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20120114 00:48:31-!- Netsplit *.net <-> *.split quits: loonybot, LordNasty, crimson_penguin, Elvish_Pillager, happygrue
20120114 00:48:31-!- crimson_pingvin is now known as crimson_penguin
20120114 00:48:58-!- Netsplit over, joins: LordNasty
20120114 01:02:24-!- Elvish_Pillage2 [~eli@137.146.78.97] has quit [Ping timeout: 240 seconds]
20120114 01:02:45-!- Elvish_Pillage2 [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20120114 01:10:36< CIA-91> ivanovic * r52581 /trunk/ (4 files in 3 dirs): updated Italian translation
20120114 01:21:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120114 01:25:59-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 245 seconds]
20120114 01:35:17< anonymissimus> oh nice, assertion failed in :inspect
20120114 01:35:29< anonymissimus> finally I can reproduce it
20120114 01:49:58-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 252 seconds]
20120114 01:51:03-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20120114 01:59:53-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 02:19:16-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Ping timeout: 240 seconds]
20120114 02:42:48-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: crimson_penguin]
20120114 02:42:59-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120114 02:47:07-!- horon [~horon@nttkyo324106.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120114 02:47:16-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 240 seconds]
20120114 03:07:14-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: done building targets]
20120114 03:16:30-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120114 03:23:25-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has joined #wesnoth-dev
20120114 03:23:26-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has quit [Changing host]
20120114 03:23:26-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120114 03:49:58-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20120114 03:54:22-!- LordNasty [~NaSTy@93-43-141-188.ip92.fastwebnet.it] has quit [Read error: Connection reset by peer]
20120114 04:08:57-!- ancestral [~ancestral@17.232.7.174] has joined #wesnoth-dev
20120114 04:12:09-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 04:35:38-!- horon [~horon@nttkyo324106.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120114 04:36:48-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 04:37:09-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 04:43:11-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20120114 04:55:12-!- Ivanovic_ [~ivanovic@dtmd-4db27dbd.pool.mediaWays.net] has joined #wesnoth-dev
20120114 04:58:13-!- Elvish_Pillage2 [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 248 seconds]
20120114 04:58:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20120114 04:59:08-!- Ivanovic_ is now known as Ivanovic
20120114 05:03:39< CIA-91> anonymissimus * r52582 /trunk/data/multiplayer/scenarios/2p_Hornshark_Island.cfg: fix missing {IS_LOYAL}s (patch by kernigh, bug #19281)
20120114 05:04:11< CIA-91> anonymissimus * r52583 /trunk/data/multiplayer/scenarios/2p_Hornshark_Island.cfg: (log message trimmed)
20120114 05:04:11< CIA-91> implement better faction detection (bug #19281)
20120114 05:04:11< CIA-91> Whenever default era is used the units should be placed for sure now,
20120114 05:04:11< CIA-91> this was IMHO not guaranteed since the recruits are internally a std::set,
20120114 05:04:11< CIA-91> so the first entry can change.
20120114 05:04:11< CIA-91> In case that one or both of the players have another faction than the
20120114 05:04:12< CIA-91> ones in the default era, none of the players gets the extra units.
20120114 05:08:15-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: done building targets]
20120114 05:11:46-!- Blueblaze [~Blueblaze@adsl-99-4-144-55.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120114 05:23:50-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120114 05:46:13-!- Blueblaze [~Blueblaze@adsl-99-4-144-55.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20120114 05:53:56-!- ancestral [~ancestral@17.232.7.174] has quit [Quit: ancestral]
20120114 06:15:30-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Read error: Connection reset by peer]
20120114 06:16:50-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20120114 06:23:56-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 06:24:35-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 06:36:46-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has joined #wesnoth-dev
20120114 06:44:21-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20120114 06:44:21-!- Upth is now known as Upthorn
20120114 07:49:52-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 07:50:31-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 08:03:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120114 08:25:46-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 08:26:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120114 08:55:05-!- fendrin [~fabi@88-134-14-215-dynip.superkabel.de] has quit [Remote host closed the connection]
20120114 09:15:47-!- fendrin [~fabi@88-134-14-215-dynip.superkabel.de] has joined #wesnoth-dev
20120114 09:29:33-!- atomicbomb [~quassel@61.94.49.121] has joined #wesnoth-dev
20120114 09:34:37-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20120114 09:35:21-!- Crendgrim [~crend@77-22-113-8-dynip.superkabel.de] has joined #wesnoth-dev
20120114 09:36:55-!- Ivanovic [~ivanovic@dtmd-4db27dbd.pool.mediaWays.net] has quit [Changing host]
20120114 09:36:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120114 09:38:49< Ivanovic> moin
20120114 09:40:23-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Remote host closed the connection]
20120114 09:52:35-!- mjs-de [~mjs-de@f053188164.adsl.alicedsl.de] has joined #wesnoth-dev
20120114 10:18:19-!- csarmi [csarmi@94-21-229-177.pool.digikabel.hu] has joined #wesnoth-dev
20120114 10:18:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 10:26:53< Crendgrim> is there any way to see all currently active events inside a game?
20120114 10:38:01< ancestral> Crendgrim: You mean, like a live debugger?
20120114 10:38:07< ancestral> Hmmm
20120114 10:38:14-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 10:38:19< Crendgrim> ancestral: something like that, yes
20120114 10:38:27< Crendgrim> any way to see all events which are registered
20120114 10:38:50< Crendgrim> ah, I don't mean the events which are currently triggered, but the handlers registered with WML [event]
20120114 10:52:06-!- atomicbomb [~quassel@61.94.49.121] has quit [Read error: Connection reset by peer]
20120114 11:07:54-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 11:08:29-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 11:11:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120114 11:26:46< vultraz> Crendgrim: :inspect?
20120114 11:26:58< Crendgrim> vultraz: doesn't show events for me
20120114 11:27:41< Crendgrim> ... -.-
20120114 11:27:57< csarmi> m
20120114 11:27:58< Crendgrim> wesnoth.get_units only returns pointers to units and doesn't save the information about them. 
20120114 11:27:59< vultraz> oh
20120114 11:32:07< Crendgrim> next problem: Is there a way to read a map file with lua?
20120114 11:36:17-!- horon [~horon@nttkyo324106.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120114 11:41:56-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 11:42:29-!- oldtopmanserver [1000@174-29-209-86.hlrn.qwest.net] has joined #wesnoth-dev
20120114 11:42:31-!- oldtopmanserver [1000@174-29-209-86.hlrn.qwest.net] has quit [Changing host]
20120114 11:42:31-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 11:48:55< CIA-91> ivanovic * r52584 /trunk/po/wesnoth-trow/it.po: updated Italian translation
20120114 12:22:13-!- Drakefriend [~kvirc@31-19-75-43-dynip.superkabel.de] has joined #wesnoth-dev
20120114 12:31:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120114 12:48:00-!- atomicbomb [~quassel@125.161.20.112] has joined #wesnoth-dev
20120114 12:56:55-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 12:57:22-!- oldtopmanserver [1000@174-29-209-86.hlrn.qwest.net] has joined #wesnoth-dev
20120114 12:57:34-!- oldtopmanserver [1000@174-29-209-86.hlrn.qwest.net] has quit [Changing host]
20120114 12:57:34-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 13:07:27-!- loonybot [~loonybot@46.138.77.63] has joined #wesnoth-dev
20120114 13:07:34-!- loonybot [~loonybot@46.138.77.63] has quit [Changing host]
20120114 13:07:34-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120114 13:09:30-!- atomicbomb [~quassel@125.161.20.112] has quit [Ping timeout: 260 seconds]
20120114 13:12:53-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 13:12:53-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 13:12:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 13:18:48-!- Elvish_Pillage2 [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20120114 13:19:33-!- atomicbomb [~quassel@125.161.20.112] has joined #wesnoth-dev
20120114 13:20:55-!- vultraz [~chatzilla@124.109.10.221] has quit [Remote host closed the connection]
20120114 13:28:45-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 13:29:17-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 13:35:41-!- negusnyul [~negusnyul@54009A3C.dsl.pool.telekom.hu] has joined #wesnoth-dev
20120114 13:36:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120114 13:36:45-!- negusnyul [~negusnyul@54009A3C.dsl.pool.telekom.hu] has left #wesnoth-dev []
20120114 13:59:47-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 14:00:36-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 14:12:59-!- stikonas [~and@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 14:12:59-!- stikonas [~and@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 14:12:59-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 14:22:21-!- horon [~horon@nttkyo324106.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120114 14:26:46-!- stikonas_ [~gentoo@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 14:26:46-!- stikonas_ [~gentoo@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 14:26:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 14:27:43< CIA-91> espreon * r52585 /trunk/data/multiplayer/scenarios/2p_Hornshark_Island.cfg: Removed pointless reliance on the Wesnoth Lua Pack.
20120114 14:31:15< CIA-91> elvish_hunter * r52586 /trunk/data/core/about.cfg: Updated Italian translation credits
20120114 14:41:57-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120114 14:43:20< anonymissimus> Espreon: thanks! (forgot that) :)
20120114 14:43:34< Espreon> Yup.
20120114 14:43:43< Espreon> I *should* smack you, though.
20120114 14:46:04< anonymissimus> Crendgrim: I imagine that one could use wesnoth.game_events.on_save; all events which are currently possible to be triggered are passed ub its argument to be saved with the scenario wml
20120114 14:48:04< anonymissimus> map files in text format cannot be read by lua; however you can transform them slightly into a lua file returning the map string when read
20120114 14:48:33< Crendgrim> that's ... bad.
20120114 14:48:42< anonymissimus> why ?
20120114 14:49:10< Crendgrim> modifying map files to make them being lua prevents me from editing them easily in the map editor
20120114 14:49:13< anonymissimus> it would allow reading of arbitrary files, so dofile is disabled for security reasons
20120114 14:49:53< Crendgrim> and this way, I need to include all files I need in WML and create a lua handler for a tag which saves all information to WML variables
20120114 14:50:09< Crendgrim> well, I don't necessarily need the lua handler, but still
20120114 14:50:18< anonymissimus> one could make a script which generates the lua map files out of the text ones
20120114 14:50:54< Crendgrim> mhm..
20120114 14:51:39< anonymissimus> I made one to get embedable files out of pure lua scripts
20120114 14:51:55< anonymissimus> so after editing a single key press should be enough
20120114 14:52:21< Crendgrim> yet I don't see right now why reading a file from lua is bad and the preprocessor include is not
20120114 14:53:01< anonymissimus> because my script cannot be run by wesnoth, only be the sole lua interpreter
20120114 14:53:21< anonymissimus> and only if the dependency is installed
20120114 14:54:10-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120114 14:54:13< Crendgrim> what's bad about a wesnoth.readfile() function which does nothing except from reading a file and giving it back as a string?
20120114 14:54:44< anonymissimus> hm one could use that to read your credit card number
20120114 14:55:01< anonymissimus> to *try* to read it
20120114 14:55:12< Crendgrim> and why can't the preprocessor include do the same?
20120114 14:55:22< vultraz> XD
20120114 14:55:32< Espreon> anonymissimus: Then please create an add-on that let's the evil mastermind get other people's credit card numbers.
20120114 14:55:35< Crendgrim> I mean, I can do something like [tag]arg="{~add-ons/My_Addon/file}"
20120114 14:55:41< Espreon> *lets the
20120114 14:55:46< anonymissimus> because if the file doesnt exist exactly with that name it would choke ?
20120114 14:56:08< Crendgrim> what I'm speaking about is a lua function which behaves exactly like the preprocessor include
20120114 14:56:19< anonymissimus> but anyway, this was clearly silene's decision and IÄ, sure he had good reasons
20120114 14:57:05< Crendgrim> plain lua allows file reading only via io. That this library isn't available makes sense to me.
20120114 14:57:37< Crendgrim> but saying a missing feature was silene's decision, without him being around anymore to ask, basically disallows any lua enhancement...
20120114 14:57:39< anonymissimus> if {~add-ons/My_Addon/file} doesnt exist the addon doesnt work
20120114 14:57:57< Crendgrim> right.. and?
20120114 14:59:51< anonymissimus> it's not disallowing, it's impossible; if someone who knows an area of the code well enough disappeared, that area cannot much be worked on any longer until someone else has reached the same knowledge about it
20120114 15:00:14< anonymissimus> otherwise danger of detrioration is high
20120114 15:05:38< anonymissimus> perhaps he wrote somewhere why he disallowed it, in the first lua commits for instance, I certainly would want to read that
20120114 15:11:18< Crendgrim> anonymissimus: I still don't see what the disallowing of basic.dofile has to do with a function which reads a plain text file..
20120114 15:19:55-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 15:19:58< anonymissimus> hm I never used basic.dofile since it's disallowed, but io.open+io.read would probably be better for reading map files
20120114 15:20:24-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 15:21:04< anonymissimus> I imagine that would allow loading of arbitrary libraries
20120114 15:21:38-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20120114 15:21:54-!- ancestral [~ancestral@67-6-35-100.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120114 15:22:55< Crendgrim> I do so as well, that's why I suggested a new function..
20120114 15:23:17< anonymissimus> perhaps a special lua function which gets the path to a map file in map editor format and returns the file as a string would be fine ?
20120114 15:23:40< Crendgrim> that's what I meant.
20120114 15:23:47< anonymissimus> but there needs to be some syntax check that its actually a valid map
20120114 15:23:54< Crendgrim> why?
20120114 15:24:23< anonymissimus> because otherwise its like io.read
20120114 15:24:58< Crendgrim> well, you can already read files with lua by creating a wml tag and giving the file content as an argument
20120114 15:25:32-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 15:25:32-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 15:25:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 15:26:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20120114 15:29:06< anonymissimus> I dont dare trying to understand the preprocessor though :<
20120114 15:29:14< Crendgrim> okay
20120114 15:29:23< Crendgrim> well, for 1.10 it doesn't matter anyways..
20120114 15:47:10< Ivanovic> someone with terrain art/wml knowledge around to fix this one? http://forums.wesnoth.org/viewtopic.php?f=4&t=35886
20120114 15:47:55< Ivanovic> might "just" be some bad layer combination for the stuff in the straight long line (those extra triangles in the black area)
20120114 15:48:16< Espreon> We'll probably have to wait for Alarantalara.
20120114 15:48:40< Espreon> The cursor sinking into the wall is a bit blargh.
20120114 15:49:04< Ivanovic> hmm, should the cursor not always be in the very topmost layer?
20120114 15:51:08-!- Amu [~smar@84.20.150.140] has quit [Ping timeout: 240 seconds]
20120114 15:51:28-!- Amuchan [~smar@84.20.150.140] has joined #wesnoth-dev
20120114 15:51:46< anonymissimus> Ivanovic: "Ivanovic, can you please add mich to the Translators group?"
20120114 15:52:01< Ivanovic> anonymissimus: long done!
20120114 15:59:06-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20120114 16:04:01-!- atomicbomb [~quassel@125.161.20.112] has quit [Read error: Connection reset by peer]
20120114 16:10:58-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120114 16:20:54< Espreon> Hmmm, what are the section names in this derived from: http://wiki.wesnoth.org/Credits
20120114 16:22:28< zookeeper> from the section names in about.cfg
20120114 16:22:44< zookeeper> title = _"Programming" etc
20120114 16:22:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 16:24:49-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 16:25:46-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 16:35:12< Espreon> zookeeper: No, I mean like the names of the campaign sections.
20120114 16:36:41< zookeeper> right. i can only guess that the script which generates/updates the wiki page does those.
20120114 16:37:01< Espreon> elias: Maybe you know?
20120114 16:37:45< elias> hm
20120114 16:38:02< elias> i suppose it reads the credits sections of all campaigns in addition to about.cfg
20120114 16:38:28< Ivanovic> it does
20120114 16:44:31< CIA-91> ivanovic * r52587 /trunk/po/ (wesnoth-dm/sk.po wesnoth-ei/sk.po): updated Slovak translation
20120114 16:47:26-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20120114 16:56:55-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 16:59:18< CIA-91> espreon * r52588 /trunk/po/ (wesnoth/fi.po wesnoth-help/fi.po): Updated the Finnish translation.
20120114 17:09:36-!- LordNasty [~NaSTy@93-43-141-188.ip92.fastwebnet.it] has joined #wesnoth-dev
20120114 17:10:18< vultraz> Ivanovic, Espreon : do you guys really translate yourselves, or is that someone else's work you're committing?
20120114 17:11:15< Espreon> What do you think?
20120114 17:11:32< CIA-91> ivanovic * r52589 /trunk/po/ (wesnoth/de.po wesnoth-lib/de.po wesnoth-manual/de.po): updated German translation
20120114 17:11:45< vultraz> I think the latter; no one could know so many languages
20120114 17:11:51< Espreon> Well, mostly, I just commit other people's work.
20120114 17:11:55< Ivanovic> vultraz: you should just check the credits
20120114 17:12:08< Espreon> I think Ivanovic might work on the German translation, though.
20120114 17:12:10< Ivanovic> vultraz: we tend to list ourselves were we participate
20120114 17:12:44< vultraz> ah
20120114 17:12:46< vultraz> mk
20120114 17:22:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120114 17:25:38-!- stikonas [~and@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 17:25:38-!- stikonas [~and@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 17:25:38-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 17:26:22-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20120114 17:29:23< anonymissimus> Espreon only just pretends to do such a lot of work xD 
20120114 17:29:32< Espreon> I do not.
20120114 17:29:48< Espreon> I certainly do not know Finnish.
20120114 17:30:08< Espreon> ... thus I wouldn't attempt to translate something to Finnish.
20120114 17:55:43-!- Crendgrim is now known as ObservantObserve
20120114 17:56:01-!- ObservantObserve is now known as Crendgrim
20120114 18:02:46-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120114 18:03:05-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Client Quit]
20120114 18:03:23-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120114 18:08:07< CIA-91> anonymissimus * r52590 /trunk/data/tools/wmlindent: 
20120114 18:08:07< CIA-91> Fix wmlindent writing CRLF end of lines on windows.
20120114 18:08:07< CIA-91> Its documentation says it converts to LF. Also, my wesnoth+windows
20120114 18:08:07< CIA-91> experience says it is best to use always only LF no matter what OS.
20120114 18:08:07< CIA-91> For wml at least. And I dont wanna convert back each time.
20120114 18:30:36-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Ping timeout: 240 seconds]
20120114 18:33:55-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has joined #wesnoth-dev
20120114 18:35:57< CIA-91> espreon * r52591 /trunk/po/wesnoth/fi.po: Updated the Finnish translation.
20120114 18:40:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20120114 18:43:54-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 18:43:54-!- stikonas [~gentoo@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 18:43:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 18:48:33-!- stikonas_ [~and@ctv-217-147-36-195.vinita.lt] has joined #wesnoth-dev
20120114 18:48:33-!- stikonas_ [~and@ctv-217-147-36-195.vinita.lt] has quit [Changing host]
20120114 18:48:33-!- stikonas_ [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120114 18:51:24-!- stikonas_ [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20120114 19:09:23-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 19:13:56< CIA-91> ivanovic * r52592 /website/start/1.10/ (13 files in 2 dirs): updated Slovak announcement translation
20120114 19:25:01-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120114 19:29:59-!- negusnyul [~negusnyul@dsl4E5CDBD4.pool.t-online.hu] has joined #wesnoth-dev
20120114 19:38:44< Alarantalara> Regarding the cursor, it appears to be a side effect of making it appear to surround units.
20120114 19:39:17< Alarantalara> If you place the cursor on a large unit, you'll notice it goes behind the unit at the top
20120114 19:39:59-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20120114 19:39:59< Alarantalara> This means that any terrain that would be drawn above the unit also gets drawn above the cursor
20120114 19:40:14< gabba> Hi all
20120114 19:41:12< gabba> Just a heads up: please look at my post to the mailing list if you know anything about the unit map.
20120114 19:41:34< gabba> It would save me a lot of trial and errors for the major bugs I'm trying to solve for 1.10
20120114 19:41:51< Alarantalara> Does anyone mind if I do something about this? https://gna.org/bugs/?19284
20120114 19:41:53< gabba> wesbot: seen Crab_
20120114 19:41:54< wesbot> gabba: Person, who 6d 23h ago used nick Crab_, last spoke 6d 22h ago.  5d 23h ago as Crab___ they left with the message: Client Quit
20120114 19:42:18< Alarantalara> I was just playing a game with Kolbur and noted that it was rather difficult to grant me control of a side
20120114 19:42:24< Alarantalara> thus the report
20120114 19:44:14-!- Kolbur [~die@89.204.139.157] has joined #wesnoth-dev
20120114 19:46:52-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 19:47:11-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 19:48:32< Ivanovic> Alarantalara: sounds like a regression to me, though maybe also ping our mp devs like Soliton about this
20120114 19:48:43< Ivanovic> esr: nice to see you around again!
20120114 19:48:51< Espreon> Alarantalara: Hmmm, can't we just play with layering to have the cursor always be on top?
20120114 19:48:52< Kolbur> hello
20120114 19:48:54< Ivanovic> already missed you when it was time to review the announcement for 1.10...
20120114 19:49:00< Espreon> Yeah...
20120114 19:49:33< Kolbur> may i ask if this bug: https://gna.org/bugs/index.php?19083 will be fixed for 1.10? :)
20120114 19:49:37< Alarantalara> It would be easy enough for the cursor to go on top - I think Eleazar picked the current state because for most unit/terrain combinations this looks better
20120114 19:50:07< Espreon> I guess.
20120114 19:50:53-!- negusnyul [~negusnyul@dsl4E5CDBD4.pool.t-online.hu] has left #wesnoth-dev ["Konversation terminated!"]
20120114 19:52:19< Alarantalara> I'm not sure what the triangles are: they also go away if you move the cursor over them
20120114 19:52:28< Ivanovic> Alarantalara: with units in the hex that is perfectly fine
20120114 19:52:49< Ivanovic> Alarantalara: possibly there is a way to change the behaviour depending on the terrain type?
20120114 19:53:15< Ivanovic> eg if the terrain is of type onwalkable the cursor is on top always
20120114 19:53:25< Alarantalara> Ivanovic: I don't know. I haven't looked at where the layer for the hex is determined
20120114 19:53:46< Ivanovic> Alarantalara: in this forum post i see another issue, do you see those tiny triangles in the straight line of walls?
20120114 19:53:55< Ivanovic> those look like some terrain wml mistake, too
20120114 19:54:38< Alarantalara> It would be nice if it were
20120114 19:54:57< Ivanovic> it is not?
20120114 19:54:57< Alarantalara> The problem is that almost anything that redraws the hex will make them go away
20120114 19:55:28< Alarantalara> so I can't tell what's causing the problem
20120114 19:55:35< Ivanovic> okay
20120114 20:00:39< Alarantalara> I have a map with which it occurs that I'm playing with right now
20120114 20:00:54< Alarantalara> and it only happens on a single vertical row
20120114 20:01:04< Alarantalara> all the others always display properly
20120114 20:01:53< Alarantalara> It makes me suspect a problem with invalidation
20120114 20:02:18< Ivanovic> so possibly boucman has to have a look at this
20120114 20:02:36< Alarantalara> since the column it happens on is one that is appearing very close to the map edge and the triangle is exactly the size of the non-displayed section
20120114 20:06:51< Alarantalara> very close = at most 4 pixels of the hex are hidden
20120114 20:17:12< Alarantalara> Ivanovic: regarding changing behaviour of cursor drawing based on terrain, it's likely possible, but the layer is hardcoded into display.cpp
20120114 20:17:22< Ivanovic> hmmm, okay
20120114 20:17:27< Alarantalara> so wouldn't take into account UMC terrain
20120114 20:18:05< Alarantalara> I think it would make more sense to move it forward if no unit drawn on the hex
20120114 20:18:25< Alarantalara> or always
20120114 20:18:36< Alarantalara> always looks bad but is very simpel
20120114 20:18:39< Alarantalara> *simple
20120114 20:19:08< Alarantalara> and it has to be drawn, not present, to avoid hovering to find units in fogged terrain
20120114 20:24:26< anonymissimus> Kolbur: I dunno, I suggest to make as many MP people as possible to complain about the bug
20120114 20:25:14< gabba> Kolbur, anonymissimus: what's the current state of this bug, exactly?
20120114 20:25:21< anonymissimus> I imagine that this might make Ivanovic consider the bug as a blocker for 1.10 and wait with the stable release until it has been fixed
20120114 20:25:43< gabba> anonymissimus: from the comments you seem to say its fixed
20120114 20:26:03< gabba> then later on people say it's actually not fixed, but did you confirm that?
20120114 20:26:30< anonymissimus> gabba: if you mean bug #19083, its obviously not fixed
20120114 20:26:41< anonymissimus> since Kolbur checked it with 1.9.14
20120114 20:26:48< Kolbur> i could reproduce it just today, yeah
20120114 20:27:17< anonymissimus> my comment there was based onto the idea that your problem with the attack execution was perhaps caused by the same thing like that bug
20120114 20:27:47< anonymissimus> but I might be wrong of course, I have no idea of the related code
20120114 20:29:10< Kolbur> anonymissimus: i'll see what i can do ;)
20120114 20:29:43< gabba> anonymissimus: more or less, yeah. The issue seems to be that since the attack confirmation window can still be open after the timer runs out, you can order an attack outside your turn. The server receives the attack and sends the callback with the seed to the client who ordered it, and also sends the attack to the other ones. However locally since we're out-of-turn the code supposed to receive and execute the attack callback isn't running anymor
20120114 20:30:07< Ivanovic> gabba: your post ends with "execute the attack callback isn't running anymor"
20120114 20:30:43< gabba> Ivanovic: err, does irc cut too long posts?
20120114 20:30:48< Ivanovic> yes
20120114 20:31:03< gabba> ok here's the end of my post: e.
20120114 20:31:03< Ivanovic> many clients automatically send >1 message when required
20120114 20:31:07< Ivanovic> but not all
20120114 20:31:54-!- alink [~alink@wesnoth/developer/alink] has joined #wesnoth-dev
20120114 20:32:02< alink> hi
20120114 20:32:12< gabba> hi alink
20120114 20:32:20< alink> hello gabba
20120114 20:33:05< gabba> alink: are you by any chance well-versed in knowledge of the unit map :P ?
20120114 20:33:57< alink> gabba: no sorry, I know how to use it but the inner parts are too weird for me
20120114 20:34:35< gabba> arrg, nobody seems to know anything about it and Crab_ isn't around
20120114 20:34:54-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 20:35:15-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 20:35:44< alink> yeah it's a voodoo area with various layers added with time
20120114 20:36:00< gabba> alink: do you at least know if I can rely on a unit map iterator to tell me if a unit is still around, and if inserting/removing a unit invalidates the iterator to it?
20120114 20:36:30< gabba> The keyword here is "rely"
20120114 20:37:11< alink> no, i am not sure about these things, sorry
20120114 20:37:22< gabba> alright, thanks anyways :)
20120114 20:37:31< Ivanovic> gabba: for this stuff is it not possible to somehow create a testcase for yourself to check this?
20120114 20:37:36< anonymissimus> we'd need thonsew now :P
20120114 20:37:56< alink> but I would guess removing unit invalidates iterator
20120114 20:38:05< gabba> Ivanovic: I want to eventually add to the unit tests, but it's hard to exhaustively check these
20120114 20:38:17< anonymissimus> he could probably answer your questions
20120114 20:38:43< alink> Sapient and Silene know the unit_map I think
20120114 20:39:12< gabba> anonymissimus: well, thonsew made the unit map even harder to understand as far as I'm concerned, he kind of took one of my questions for a feature request
20120114 20:39:23< Ivanovic> silene seems to be 100% gone by now
20120114 20:39:40< Ivanovic> (also asked me to remove the gna account!)
20120114 20:41:36< Espreon> Sadness...
20120114 20:42:37< gabba> Yeah, it's sad to see people go. Hopefully it wasn't because of the iOS port fiasco.
20120114 20:43:06< anonymissimus> I wonder whats up with him; disappearing in that way after doing such a lot of work for the project doesn't seem logical to me
20120114 20:44:10< anonymissimus> Alarantalara: that bug you reported isnt a minor one
20120114 20:44:41< anonymissimus> I imagine it to be pretty annoying
20120114 20:44:52< Alarantalara> Annoying, yes
20120114 20:45:17< Alarantalara> I figured out how to fix it before reporting it, though
20120114 20:45:24< Alarantalara> So it felt minor
20120114 20:46:08< gabba> Oh well, at some point I'm gonna get pissed off enough at the unit map black box that I'll replace it with an std::map, and we'll have come full circle :P
20120114 20:47:04< Alarantalara> By the way, this: http://imagebin.org/193628 is why the hex goes under units (and sometimes terrain)
20120114 20:47:21< alink> Alarantalara: I added that golden hex behavior, your solution (always on top when no unit drawn) seems good. I can code it (unless you already started?)
20120114 20:47:36< anonymissimus> Alarantalara: ok well then commit pls ? :P
20120114 20:47:46< alink> also ugly for units on keep 
20120114 20:48:24< alink> Alarantalara: mmh seeing your screenshot, I suppose you already started
20120114 20:48:30< Alarantalara> alink: I haven't already started, mostly because I'm not sure how to identify units
20120114 20:48:46< alink> use the unit_map ;)
20120114 20:49:03< Alarantalara> I never have before. Is it global?
20120114 20:49:25< gabba> resources::units
20120114 20:49:26< anonymissimus> resources::units
20120114 20:49:48< alink> mmh, in fact since we want to care about fog, there is probably a get_visible_unit function somewhere
20120114 20:50:54< alink> yes there is one in unit.?pp and it's accessible from display code
20120114 20:52:57< Alarantalara> and it covers stealth too, which is good (though I don't think there are any terrains yet that get drawn over units in the top half of the hex that a unit can enter)
20120114 20:53:16< alink> Alarantalara: btw nice catch about the fogged case, could have been a sneaky cheat
20120114 20:53:51< Alarantalara> It would only work adjacent to walls, but still
20120114 20:53:51< alink> Alarantalara: yes that was also my thinking when I added this IIRC
20120114 20:55:51< anonymissimus> Gambit: yes, I like to try your addon
20120114 20:56:25< anonymissimus> Gambit: however, I've been told that you need to be willing to tell me what it should do ;)
20120114 20:56:31< alink> that layers order can never be perfect for all cases, we can just aim to be good for the general case and not too ugly for others
20120114 20:56:34< anonymissimus> what I should do
20120114 20:56:46< Gambit> anonymissimus: Alright. As soon as I hunt down this one bug.
20120114 20:56:57< Gambit> For some reason [store_side] is failing to store a side I know exists...
20120114 20:57:55< Gambit> o_o it even fails when I explicitly tell it to store side 1
20120114 21:00:41< anonymissimus> hm what's your code ?
20120114 21:00:43< Gambit> Ah I forgot to consider variable interpolation.
20120114 21:01:09< Gambit> *forgot to consider when that happens. A macro call inside [set_variables] in a prestart event. Sides would not exist yet.
20120114 21:04:04< Gambit> No because it's in a set_menu_item... hmm
20120114 21:04:22< Gambit> anonymissimus: https://github.com/grickit/Breaking-Ground/blob/master/utils/harvesting.cfg
20120114 21:04:26< Gambit> The macro at line 1
20120114 21:05:05< Gambit> It works when called from line 73 from line 133
20120114 21:05:30< Gambit> But not from line 73 from line 83 of: https://github.com/grickit/Breaking-Ground/blob/master/utils/archery.cfg
20120114 21:06:03< Gambit> [store_side] is returning nothing
20120114 21:07:41-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has quit [Read error: Connection timed out]
20120114 21:08:49< anonymissimus> well I'm afraid that I only see a lot of confusing code there :)
20120114 21:11:39< Gambit> I've inserted a [chat] to verify that the MARK_CHASM macro is indeed getting the right number for {SIDE}
20120114 21:13:12< Gambit> Hmmm.
20120114 21:13:31< Gambit> anonymissimus: is [store_side] backed by lua?
20120114 21:17:58< Gambit> Nevermind. My theory that tags written in lua don't work in [set_variables]/[insert_tag] is bogus.
20120114 21:21:27< Alarantalara> alink: This represents something to cover the changing of drawing depending on the presence of a visible unit http://pastebin.com/vyNCTDw1
20120114 21:21:49< Alarantalara> since this is not an area of code I'm familiar with, can I get you to check it before I consider committing it?
20120114 21:22:36-!- Pete-Flux [~quassel@pc-14-251-120-200.cm.vtr.net] has quit [Ping timeout: 240 seconds]
20120114 21:26:09< alink> Alarantalara: this should work, but the new includes are really not wanted.
20120114 21:26:53< alink> my bad, the unit stuff is only accesible from game_display code, not display
20120114 21:27:48< Alarantalara> Indeed, I didn't have much choice about adding them in order to use existing functions, but it's a lot of unneeded code to include
20120114 21:28:38< alink> a possible way to fix that is to add a virtual simple function in display and specialize it in game_display
20120114 21:29:18< alink> this  could even allow editor to use different hex-cursor feature if/when needed
20120114 21:29:49< alink> the general cursor in display can simply draw always on top
20120114 21:30:36< alink> Alarantalara: the general policy about display/game_display/editor_display is unit stuff is only in game_display
20120114 21:30:50< Alarantalara> okay
20120114 21:31:40< alink> often a bit annoying and this comes from the time when editor was separated. But it's better for compile time
20120114 21:33:11< Alarantalara> I'm glad I asked about it first.
20120114 21:33:55< alink> Alarantalara: other simpler possibility move the drawing of the cursor in draw_hex which is already specialized in each display
20120114 21:35:35< Alarantalara> That may make more sense, since otherwise, I'd have to remove the always on top one in the presence of a unit
20120114 21:36:45< alink> mmh not sure what you mean, but you just want to modify its layer number, not remove it
20120114 21:37:28< alink> btw IIRC there was plan to color this cursor on enemy. There is even image ready for that. So, such change go in the good direction
20120114 21:38:31< Alarantalara> Yeah, I see it. Wouldn't it have to be split as well?
20120114 21:39:39< alink> it should indeed, I didn't do it to avoid creating even more unused files
20120114 21:40:05< alink> also I am lazy with Gimp ;p
20120114 21:40:45< alink> not sure why we didn't implemented this feature
20120114 21:41:24< alink> probably because the golden hex had some resistance from usres at first
20120114 21:41:28< alink> *users
20120114 21:42:24-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Ping timeout: 240 seconds]
20120114 21:42:48< alink> Alarantalara: I am going afk, but feel free to drop questions if any
20120114 21:43:13< Alarantalara> I'll probably post another diff in 10 minutes or so
20120114 21:43:30-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20120114 21:43:48< alink> ok, i will be back in +/- 30 min 
20120114 21:56:17< Alarantalara> alink: I ended up getting rid of the cursor entirely for the editor. The brush already has a golden hex surrounding it (brush.png) and adding the cursor just made it very thick
20120114 21:57:57-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120114 21:58:28< Alarantalara> this is the diff: http://pastebin.com/2hAhJJqi
20120114 21:59:43< Alarantalara> Removing the hover hex in the editor also keeps what appears to be a single hex from changing size when you paint the map border
20120114 22:04:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120114 22:08:27-!- SigurdFireDragon [189a49d2@gateway/web/freenode/ip.24.154.73.210] has joined #wesnoth-dev
20120114 22:08:52< Alarantalara> alink: it appears that you introduced the change that causes this: https://gna.org/bugs/?19284 (In r444203 and r44212)
20120114 22:09:25< Alarantalara> Ivanovic suggested I ping Soliton or another MP dev, but since you made the change, perhaps you know the cause
20120114 22:15:45-!- Octalot [~noct@host109-153-157-46.range109-153.btcentralplus.com] has joined #wesnoth-dev
20120114 22:18:57< alink> back
20120114 22:19:04< alink> Alarantalara: checking...
20120114 22:21:01-!- csarmi [csarmi@94-21-229-177.pool.digikabel.hu] has quit []
20120114 22:22:15< alink> well if it's indeed caused by this commit, it's easy to fix
20120114 22:22:43< alink> however I don't see how it creates this bug
20120114 22:22:50< alink> but I will test that
20120114 22:23:41< Alarantalara> The list of units is no longer passed in for tab completion after those commits. r44211 creates the list, but only provides it for chat messages
20120114 22:24:02< Alarantalara> s/units/players/
20120114 22:27:12< alink> ah you didn't mention r44211 at first. 
20120114 22:27:17< anonymissimus> wesbot: seen Noy
20120114 22:27:18< wesbot> anonymissimus: The person with the nick noy last spoke 11d 22h ago.  9h 55m ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: Quit: noy
20120114 22:27:48< alink> but indeed it seems that i considered that player name was only needed for chat
20120114 22:27:59< alink> (a reasonable assumption IMHO)
20120114 22:28:58< alink> Alarantalara: nice hunt ;)
20120114 22:30:10< Alarantalara> Your references to tab in your commit messages made it easy
20120114 22:30:56< anonymissimus> Noy: I hope you gonna read it; is it right the the Khalifate are supposed to enter the default era at some spot and that balancing them should be supported ?
20120114 22:31:07< alink> hehe sometimes it's a good thing to be verbose in my commit messages ;)
20120114 22:31:22< anonymissimus> I supposed you are the one to decide this, or perhaps Soliton knows ?
20120114 22:31:54< alink> Alarantalara: do we want unit names there too, I think they will add noise to the completion. Probably why I separated this
20120114 22:32:18< alink> but maybe it's also useful for some command?
20120114 22:32:54< Alarantalara> I think just player names: kick, control, mute, etc. all want players
20120114 22:33:16< Alarantalara> and units are usually identified in commands by hovering with the mouse, so...
20120114 22:33:17< alink> ok so it look like a simple fix
20120114 22:34:17< alink> well seeing these commit, checking how the code looks now
20120114 22:35:52< alink> ok just need to fuse the TEXTBOX_COMMAND and TEXTBOX_MESSAGE cases.
20120114 22:37:12< alink> I wonder if people will choose name close to commands to annoy admin ;p
20120114 22:38:07< Alarantalara> It would be tempting
20120114 22:38:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120114 22:38:33< Alarantalara> Unicode look-alikes especially
20120114 22:40:16< alink> Alarantalara: do you want to commit the fix ?
20120114 22:40:25< Alarantalara> for the cursor?
20120114 22:40:36< Alarantalara> sure
20120114 22:40:42< alink> ah yes about the cursor
20120114 22:41:09< alink> the patch is good, but unless you fix another glitch, I advice not modifying the editor look
20120114 22:41:58< alink> or check all the cases: esp. different brush size, and above selected hexes
20120114 22:42:08< alink> or next to selected hexes
20120114 22:42:22< alink> that's where visibility was an issue
20120114 22:42:25< Alarantalara> The cursor wasn't drawn for off-map locations in the editor before, so it does make the appearance more consistent
20120114 22:43:45< Alarantalara> The cursor does make it easier to see the center of large brushes
20120114 22:43:53< alink> indeed, but I am more concerned about readibility for normal cases
20120114 22:44:47< alink> *readability
20120114 22:44:50< Alarantalara> You're right, while I don't have much problem, I can see how it could be an issue over selected hexes with dimmer monitors
20120114 22:45:48< alink> IMO it was already not clear before, so I assume that removing the cursor doesn't help, but I didn't test it
20120114 22:46:58< alink> Alarantalara: btw to preserve the cursor behavior just add it in editor_display::draw_hex
20120114 22:47:12< alink> but always on top, of course
20120114 22:47:47< Alarantalara> Yes, I'm changing it to avoid having it vanish for off-map images while I'm at it
20120114 22:48:40< alink> ok that seems to be a valid glitch (RC freeze  etc)
20120114 22:49:12< alink> wait unless it help to indicate which hexes are off-map ?
20120114 22:49:34< Alarantalara> They're already covered by the shadowed border
20120114 22:50:01< Alarantalara> and changing the thickness of a golden shape is a terrible visual cue
20120114 22:51:07< alink> yes it's not perfect, but note that the case of hex half off-map is not clear without it
20120114 22:51:14< Alarantalara> at least I hadn't noticed it until I started writing this patch
20120114 22:52:37< alink> ah using grid clarify this
20120114 22:54:01< alink> so this thin cursor when off-map is a bit weird but almost look like a feature
20120114 22:55:23< alink> I never use the editor, so my opinion is probably irrelevant 
20120114 22:55:51< Alarantalara> Espreon, shadowmaster: do either of you have an opinion on this?
20120114 22:57:35< alink> it's not really important, just to check its bug status regarding RC freeze
20120114 22:58:04< Espreon> Alarantalara: Uh... wait... what am I commenting on?
20120114 22:58:10 * Espreon wasn't following this conversation
20120114 22:58:14< Alarantalara> Part of the reason I got rid of it was that the code is slightly simpler - there's already a check for on map with border
20120114 22:59:34< Alarantalara> Espreon: whether the golden hex representing the cursor in the map editor should vanish on map borders, leaving only the golden hex representing the brush
20120114 22:59:49< Alarantalara> so it appears slightly thinner on map borders
20120114 23:00:20< Alarantalara> It currently does this as a side effect of not drawing it there while playing
20120114 23:00:55< Alarantalara> I suggest it's a bug because it looks strange once you notice it, and alink is suggesting it's a good visual cue for off-map hexes in the editor
20120114 23:01:11-!- eirikvw [189a49d2@gateway/web/freenode/ip.24.154.73.210] has joined #wesnoth-dev
20120114 23:01:18< alink>  a visual cue, but not a good one
20120114 23:01:44< alink> Alarantalara: btw we are talking only about the editor, right ?
20120114 23:01:54< Alarantalara> yes
20120114 23:02:09< Alarantalara> In game, it still goes away since you can't select units there
20120114 23:02:32< alink> ok
20120114 23:02:47< Espreon> Alarantalara: Eh, I really don't have an opinion.
20120114 23:04:09< Alarantalara> Espreon: did you notice that it changes appearance?
20120114 23:04:44< Espreon> No.
20120114 23:05:47< alink> Alarantalara: that's also why I think it's not worth touching this, it's not really a clear glitch
20120114 23:06:26< alink> but it's also true that it's probably a very safe change
20120114 23:06:29< Alarantalara> My biggest reason for doing it was that the code is simpler
20120114 23:06:57< Alarantalara> since I can leave out one of the conditions
20120114 23:07:23< alink> then it's a bad reason, to modify the UI and break the freeze
20120114 23:07:31< alink> better wait 1.11
20120114 23:07:40-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120114 23:07:52< alink> also we are talking about 1 line of code, right?
20120114 23:08:10< Alarantalara> basically
20120114 23:08:49< Alarantalara> It's actually 2 since I have to draw the image as well
20120114 23:08:54< CIA-91> anonymissimus * r52593 /trunk/data/multiplayer/scenarios/2p_Hornshark_Island.cfg: (log message trimmed)
20120114 23:08:54< CIA-91> Added unit sets for the "not a default faction" case composed by Doc Paterson.
20120114 23:08:54< CIA-91> If any faction is not one of the default factions (e.g. Khalifate)
20120114 23:08:54< CIA-91> it gets these units now instead of both factions getting no units
20120114 23:08:54< CIA-91> at all. If the other faction is a default one it still gets the set
20120114 23:08:54< CIA-91> composed for it in particular in the same game.
20120114 23:08:54< CIA-91> (bug #19281)
20120114 23:09:23< alink> and this off-map check is repeated dozen of times in display code
20120114 23:09:43< Alarantalara> only once
20120114 23:10:06< Alarantalara> and not at all in the editor draw_hex
20120114 23:10:23< Alarantalara> where I will be adding it
20120114 23:11:44< Alarantalara> It's the difference between http://pastebin.com/XNdMaUMD and http://pastebin.com/7p2SaXt6
20120114 23:12:54< Alarantalara> bah, the second should be http://pastebin.com/zqp83rz1
20120114 23:14:43< alink> lol, this tiny code simplicity gain is really not a valid point here.
20120114 23:15:52-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Ping timeout: 268 seconds]
20120114 23:16:24< alink> i don't care enough about this, but if you do, go ahead ;)
20120114 23:16:45< alink> I also like deleting code :)
20120114 23:17:06< alink> esp to simplify condition
20120114 23:17:34< alink> or to micro-optimize short-circuit
20120114 23:20:21-!- oldtopmanserver [1000@unaffiliated/oldtopmanserver] has joined #wesnoth-dev
20120114 23:20:49-!- Octalot_ [~noct@host109-153-157-46.range109-153.btcentralplus.com] has joined #wesnoth-dev
20120114 23:25:11-!- Drakefriend [~kvirc@31-19-75-43-dynip.superkabel.de] has quit [Quit: I quit for now. Goodbye.]
20120114 23:25:31-!- Crendgrim [~crend@77-22-113-8-dynip.superkabel.de] has quit [Read error: Connection reset by peer]
20120114 23:28:20< alink> Soliton: Alarantalara:   from code //Exclude own nick from tab-completion.   Why ?
20120114 23:35:30-!- Alarantalara1 [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120114 23:37:38-!- Alarantalara1 [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Client Quit]
20120114 23:38:20-!- Alarantalara1 [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120114 23:38:30-!- Netsplit *.net <-> *.split quits: Octalot
20120114 23:38:37-!- Netsplit *.net <-> *.split quits: mjs-de, Alarantalara
20120114 23:38:43-!- Alarantalara1 [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Client Quit]
20120114 23:38:43-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20120114 23:38:55-!- Netsplit over, joins: Alarantalara
20120114 23:42:14-!- mjs-de [~mjs-de@f053188164.adsl.alicedsl.de] has joined #wesnoth-dev
20120114 23:42:15< Alarantalara> alink: no idea. It appears to have been there indefinitely
20120114 23:44:59-!- Kolbur [~die@89.204.139.157] has quit [Ping timeout: 252 seconds]
20120114 23:45:17< Alarantalara> alink: It looks like I lost some messages in a net split. Basically, I don't care that much either, but since I've now written it to keep the existing behaviour, there's no real reason to not use it
20120114 23:47:19< alink> as you wish
20120114 23:47:42-!- Kolbur [~die@89.204.139.157] has joined #wesnoth-dev
20120114 23:49:46< CIA-91> alarantalara * r52594 /trunk/src/ (display.cpp editor/editor_display.cpp game_display.cpp): 
20120114 23:49:46< CIA-91> Make gold hex cursor appear above all terrain when no unit visible
20120114 23:49:46< CIA-91> Fixes one of the issues identified in http://forums.wesnoth.org/viewtopic.php?f=4&t=35886
20120114 23:51:43< CIA-91> alink * r52595 /trunk/src/play_controller.cpp: Fix bug #19284: Autocomplete player names in commands
20120114 23:55:55< Alarantalara> I need to go shopping, so I'll be gone for now
20120114 23:55:58-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120114 23:56:27< alink> i am off too, gn
20120114 23:56:31-!- alink [~alink@wesnoth/developer/alink] has quit [Remote host closed the connection]
20120114 23:56:45-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
--- Log closed Sun Jan 15 00:00:31 2012