--- Log opened Thu Feb 23 00:00:51 2012
20120223 00:15:14-!- mjs-de [~mjs-de@d184052.adsl.hansenet.de] has quit [Remote host closed the connection]
20120223 00:19:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 00:28:04-!- StealthyCoin [~StealthyC@hawknet-wireless-gw-ext.cabrillo.edu] has joined #wesnoth-dev
20120223 00:33:09-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds]
20120223 00:33:10-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds]
20120223 00:47:53-!- hopman- [~chris@24-183-40-128.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20120223 00:48:13-!- ejls_ [~Epsilon01@88.190.228.230] has joined #wesnoth-dev
20120223 00:50:36-!- Rh0nda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20120223 00:51:23-!- CIA-134 [~CIA@cia.atheme.org] has joined #wesnoth-dev
20120223 00:52:12-!- s951 [~s951@dyn1064-176.hor.ic.ac.uk] has quit [Quit: Leaving]
20120223 00:53:11-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20120223 00:53:11-!- Upth is now known as Upthorn
20120223 00:53:34-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20120223 00:54:14-!- ejls [~Epsilon01@88.190.228.230] has quit [Ping timeout: 252 seconds]
20120223 00:54:18-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 252 seconds]
20120223 00:54:18-!- cjhopman [~chris@wesnoth/developer/cjhopman] has quit [Ping timeout: 252 seconds]
20120223 00:54:18-!- CIA-61 [~CIA@cia.atheme.org] has quit [Ping timeout: 252 seconds]
20120223 01:03:14< CIA-134> alarantalara * r53162 /trunk/src/terrain_translation.cpp: stop aligning columns in the map file format
20120223 01:05:05-!- {V} [~V@174-76-ftth.onsneteindhoven.nl] has quit [Read error: Connection reset by peer]
20120223 01:05:29-!- {V} [~V@174-76-ftth.onsneteindhoven.nl] has joined #wesnoth-dev
20120223 01:11:50-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120223 01:18:00< CIA-134> alarantalara * r53163 /trunk/projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: update Xcode project file
20120223 01:22:31-!- Netsplit *.net <-> *.split quits: CIA-134, Amu, yann, iwaim, knotwork
20120223 01:28:17-!- Netsplit over, joins: knotwork, Amu, iwaim, CIA-134, yann
20120223 01:31:24< CIA-134> alarantalara * r53164 /trunk/ (4 files in 3 dirs): Display invisible overlays on main map in map editor
20120223 01:33:23-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 244 seconds]
20120223 01:35:03-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20120223 01:41:26-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20120223 01:42:58-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: done building targets]
20120223 01:43:12-!- Blueblaze [~Blueblaze@adsl-76-202-23-45.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20120223 01:45:12-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 272 seconds]
20120223 01:57:15-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 240 seconds]
20120223 02:13:13-!- StealthyCoin [~StealthyC@hawknet-wireless-gw-ext.cabrillo.edu] has quit [Quit: StealthyCoin]
20120223 02:14:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120223 02:32:18-!- Gambit_ [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120223 02:32:31-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Read error: Connection reset by peer]
20120223 02:38:23< CIA-134> ai0867 * r53165 /trunk/data/tools/wesnoth/campaignserver_client.py: Update CampaignClient to know about 1.10 (instead of 1.9)
20120223 02:38:59-!- Blueblaze [~Blueblaze@adsl-76-202-23-45.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120223 02:43:02< CIA-134> alarantalara * r53166 /trunk/data/core/terrain-graphics.cfg: Improve wall transitions at map edge - should probably give off map terrains a non-empty string
20120223 02:48:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 02:55:22-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120223 03:06:06< fendrin> Alarantalara: One of the commits stopped wesnoth compiling for me.
20120223 03:07:44< Alarantalara> What do you mean by that?
20120223 03:08:56< Alarantalara> fendrin: are you building with Xcode?
20120223 03:12:40< fendrin> eclipse + cmake 
20120223 03:12:55< fendrin> their is a flag that makes warnings into errors
20120223 03:13:08< fendrin> It seems you put a function out of use.
20120223 03:14:03< fendrin> /static std::string number_to_string_(t_terrain terrain, const int start_position, const size_t min_size);
20120223 03:14:51< Alarantalara> ah, that makes sense
20120223 03:15:38-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Remote host closed the connection]
20120223 03:16:00< Alarantalara> I don't get that warning when I build
20120223 03:16:28< Alarantalara> I guess I'll just remove the function too
20120223 03:16:29< fendrin> Alarantalara: I don't really know if removing the aligning is a good idea.
20120223 03:17:57< Alarantalara> any particular reason? I don't think most people edit maps by hand anymore
20120223 03:18:37-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20120223 03:24:37-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120223 03:31:55< fendrin> Alarantalara: Hmmm, yes. Don't mind. It is okay so.
20120223 03:33:30< fendrin> Alarantalara: Are you still around for a few minutes?
20120223 03:33:34< Alarantalara> yes
20120223 03:33:51< CIA-134> alarantalara * r53167 /trunk/src/terrain_translation.cpp: remove newly unused function
20120223 03:33:56< fendrin> I am going to commit, would you test if it still compiles and works for you?
20120223 03:34:05< Alarantalara> sure
20120223 03:34:11< fendrin> okay
20120223 03:34:23< fendrin> Let's keep it all in one patch so it easy to revert.
20120223 03:39:24< CIA-134> fendrin * r53168 /trunk/ (changelog src/terrain_translation.cpp): Introduced new [map] format.
20120223 03:40:00< CIA-134> fendrin * r53169 /trunk/src/ (15 files in 2 dirs): Now realy introduced the new map format.
20120223 03:40:01< fendrin> damit
20120223 03:40:09< fendrin> I new I would do something wrong.
20120223 03:40:12< fendrin> Alarantalara: ^ 
20120223 03:40:31< Alarantalara> building
20120223 03:41:26< fendrin> I am sure there is some testcase I didn't manage to cover.
20120223 03:42:34-!- StealthyCoin [~StealthyC@adsl-108-200-140-185.dsl.pltn13.sbcglobal.net] has joined #wesnoth-dev
20120223 03:46:58< CIA-134> espreon * r53170 /branches/1.10/ (4 files in 3 dirs): Updated the British English translation.
20120223 03:48:27< Espreon> fendrin: Do I have to do stuff to make my maps work again?
20120223 03:50:06< fendrin> Espreon: No, not until the old syntax gets deprecated.
20120223 03:50:37< Espreon> And when will it be deprecated?
20120223 03:51:38< fendrin> 3 dev releases is the normal procedure.
20120223 03:52:53< fendrin> esr: around?
20120223 03:57:38< Alarantalara> well, it builds fine for me
20120223 03:59:10< Alarantalara> and crashes if I open a map in the old format
20120223 03:59:53< Alarantalara> Unexpected characters after variable name (expected , or =), value '^' at <unknown>:4
20120223 04:00:01< fendrin> Alarantalara: Ah yes.
20120223 04:03:31-!- Ivanovic_ [~ivanovic@dtmd-4db2a373.pool.mediaWays.net] has joined #wesnoth-dev
20120223 04:06:49-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds]
20120223 04:06:55< CIA-134> espreon * r53171 /trunk/src/addon/ (client.cpp client.hpp info.cpp): Ran umcpropfix.
20120223 04:07:27-!- Ivanovic_ is now known as Ivanovic
20120223 04:07:28< CIA-134> espreon * r53172 /trunk/data/core/terrain-graphics/editor.cfg: Ran umcpropfix.
20120223 04:15:17< CIA-134> fendrin * r53173 /trunk/src/editor/map_context.cpp: Implemented a better way to see if a file contains wml.
20120223 04:15:19< fendrin> Alarantalara: ^
20120223 04:20:52< esr> fendrin: What's up?
20120223 04:21:11< Espreon> fendrin: So, [map]'s a child of [scenario], yes?
20120223 04:21:32< fendrin> Espreon: yes
20120223 04:21:48< fendrin> esr: Who do I ask for a wmllint upgrade?
20120223 04:23:19< Alarantalara> It seems to work now, and it's preserving the mask/border_size attributes of loaded maps
20120223 04:24:04< fendrin> Alarantalara: It is a hell of a hack. I hope that we can find a way to keep compatibility with #ifver and I can remove the support for the old format soon. 
20120223 04:26:14< Alarantalara> now to check inside game play
20120223 04:26:26< Espreon> fendrin: And I guess [map]'s now a child of [replace_map], yes?
20120223 04:27:25< Alarantalara> Invalid WML found [map] not supported at scenario top level
20120223 04:28:00< Alarantalara> This was while testing one of the more complicated maps I've created
20120223 04:28:07< Alarantalara> so I'll see if I can narrow it down
20120223 04:28:45< Alarantalara> interestingly, everything still looks correct
20120223 04:29:21< Alarantalara> it appears to be associated with the cave generator
20120223 04:30:20< Alarantalara> a missed warning message?
20120223 04:30:30< Alarantalara> for scenarios that use the new format
20120223 04:31:55< esr> fendrin: Still me, I think. What do you need?
20120223 04:37:06< fendrin> esr: I have changed the map format. map_data= is now [map] border_size= usage= and data=
20120223 04:38:29< esr> Hm.  And you want wmllint to be able to up-translate?
20120223 04:38:44< fendrin> Alarantalara: That is just a lua warning. The lua syntax checker complains about the unknown tag.
20120223 04:39:37< fendrin> Alarantalara: And yes, the terrain generator already generates in the new format. Thus you get the warning even having no new syntax on the disk.
20120223 04:39:45< fendrin> esr: Yes, please.
20120223 04:40:01< esr> OK, I'll do it.
20120223 04:40:08< Espreon> fendrin: Then make it aware of [map]
20120223 04:40:21< fendrin> esr: It can also be done with the editor but it can't be scripted that easily.
20120223 04:41:26< esr> fendrin: Pleasew file an FR with examples of the old syntax and the new and how the translation should be done.  That way I'll have sometging to refer to when I write the Python.
20120223 04:41:46< fendrin> esr: Okay, I will do that.
20120223 04:44:14< fendrin> esr: yes indeed it is
20120223 04:44:21< fendrin> Espreon: ^ 
20120223 04:44:34< Espreon> OK.
20120223 04:45:33< CIA-134> alarantalara * r53174 /trunk/src/scripting/lua.cpp: Mark [map] as a handled tag to avoid Lua error
20120223 04:46:08< fendrin> Alarantalara: thanks
20120223 04:53:25-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 248 seconds]
20120223 04:56:05-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120223 04:56:16-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120223 04:58:05-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Remote host closed the connection]
20120223 05:18:47-!- ancestral [~ancestral@67-6-36-251.mpls.qwest.net] has joined #wesnoth-dev
20120223 05:26:14-!- Blueblaze [~Blueblaze@adsl-76-202-23-45.dsl.hstntx.sbcglobal.net] has quit [Ping timeout: 272 seconds]
20120223 05:31:57-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120223 05:35:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120223 05:38:32-!- Blueblaze [~Blueblaze@adsl-99-158-46-96.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120223 05:43:58-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20120223 06:30:24-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120223 06:37:25-!- noy [~Noy@S0106687f742b6bf5.vs.shawcable.net] has joined #wesnoth-dev
20120223 06:37:38-!- noy [~Noy@S0106687f742b6bf5.vs.shawcable.net] has quit [Changing host]
20120223 06:37:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 06:53:42-!- Gambit_ [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120223 06:57:51-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120223 07:22:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120223 07:38:54-!- Ivanovic [~ivanovic@dtmd-4db2a373.pool.mediaWays.net] has quit [Changing host]
20120223 07:38:54-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120223 07:41:13< Ivanovic> moin
20120223 07:42:35-!- knotwork_ is now known as knotwork
20120223 07:59:25< CIA-134> ivanovic * r53176 /trunk/ (14 files in 13 dirs): updated Irish translation
20120223 07:59:27< CIA-134> ivanovic * r53175 /branches/1.10/ (13 files in 12 dirs): updated Irish translation
20120223 08:02:57-!- StealthyCoin [~StealthyC@adsl-108-200-140-185.dsl.pltn13.sbcglobal.net] has quit [Quit: StealthyCoin]
20120223 08:05:39-!- Blueblaze [~Blueblaze@adsl-99-158-46-96.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20120223 08:35:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection]
20120223 08:43:18-!- Gallaecio [~quassel@84.120.113.193.dyn.user.ono.com] has quit [Remote host closed the connection]
20120223 08:47:49-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120223 08:54:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120223 09:07:40< shadowm> note to self: never let people not familiarized with STL algorithms hack on src/addon ever again
20120223 09:27:26< zookeeper> arr. i could use inkscape to create a single nice vector worldmap from which campaign maps could easily be exported at arbitrary crops and sizes, but mountains especially would be next to impossible to do well.
20120223 09:27:53< zookeeper> roads, labels, cities, coastlines, textures, fine, but mountains... urgh.
20120223 09:29:06< zookeeper> and i doubt we'd want to go back to mountains which don't look as nice as the current hand-drawn ones.
20120223 09:41:05-!- felher [~whitedrag@fasel.nerd2nerd.org] has quit [Remote host closed the connection]
20120223 10:07:47-!- Cookiee [~quassel@unaffiliated/cookiee] has joined #wesnoth-dev
20120223 10:09:02-!- Cookiee [~quassel@unaffiliated/cookiee] has quit [Remote host closed the connection]
20120223 10:09:05-!- loonybot [~loonybot@46.138.85.111] has joined #wesnoth-dev
20120223 10:09:05-!- loonybot [~loonybot@46.138.85.111] has quit [Changing host]
20120223 10:09:05-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120223 10:12:47-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120223 10:26:05-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20120223 10:41:16-!- stikonas [~gentoo@bcm-131-111-216-70.girton.cam.ac.uk] has joined #wesnoth-dev
20120223 10:41:16-!- stikonas [~gentoo@bcm-131-111-216-70.girton.cam.ac.uk] has quit [Changing host]
20120223 10:41:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120223 10:43:53-!- knotwork [~markm@unaffiliated/knotwork] has quit [Remote host closed the connection]
20120223 10:45:17-!- mjs-de [~mjs-de@f053190219.adsl.alicedsl.de] has joined #wesnoth-dev
20120223 10:57:11< CIA-134> ivanovic * r53178 /branches/1.10/po/wesnoth-tutorial/fr.po: updated French translation
20120223 10:57:12< CIA-134> ivanovic * r53177 /trunk/po/wesnoth-tutorial/fr.po: updated French translation
20120223 10:57:44-!- Haldric [~Haldric@wesnoth/translator/Haldric] has joined #wesnoth-dev
20120223 11:00:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120223 11:01:26-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20120223 11:09:33-!- Crab___ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20120223 11:23:03-!- Crab___ [~Crab_@wesnoth/developer/crab] has quit [Ping timeout: 252 seconds]
20120223 11:31:31-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120223 12:12:36-!- Upthorn [~ogmar@69.62.144.56] has quit [Read error: Operation timed out]
20120223 13:43:45-!- ancestral [~ancestral@67-6-36-251.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120223 13:45:21-!- Rh0nda is now known as Rhonda
20120223 13:45:26-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20120223 13:45:26-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20120223 14:03:35-!- Natasiel [~natasiel@wesnoth/mp-mod/natasiel] has quit [Ping timeout: 240 seconds]
20120223 14:04:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120223 14:09:58-!- Haldric [~Haldric@wesnoth/translator/Haldric] has quit [Remote host closed the connection]
20120223 14:14:40-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120223 14:22:42-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20120223 14:24:24-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120223 14:29:50-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Quit: BBL->]
20120223 14:42:46-!- negusnyul [~negusnyul@dsl4E5CCB0B.pool.t-online.hu] has joined #wesnoth-dev
20120223 15:15:22-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120223 15:18:41-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120223 15:25:30-!- LordNasty [~NaSTy@93-43-168-221.ip92.fastwebnet.it] has quit []
20120223 15:31:32-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120223 15:35:22-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house]
20120223 15:40:13-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120223 15:42:58-!- LordNasty [~NaSTy@93-43-168-221.ip92.fastwebnet.it] has joined #wesnoth-dev
20120223 15:45:00< anonymissimus> fendrin: you disappoint me; starting my most map-loading scenarios still works :P
20120223 15:46:23< anonymissimus> fendrin: however, the [generator] scenario throws a warning about [map] not supported at scenario toplevel; this is when loading a start-of-scenario save
20120223 15:47:47< anonymissimus> you probably need to add it lua.cpp:3805ff since you add such a child
20120223 15:48:43< anonymissimus> also, it throws an error gui/draw in stderr with the complete scenario wml
20120223 15:52:39< anonymissimus> fendrin: also, it would be great if questions such as "do we have a way to teach wmllint how to upgrade ?" could be solved *before* something is committed
20120223 16:05:04-!- Crendgrim [~crend@77-22-112-160-dynip.superkabel.de] has joined #wesnoth-dev
20120223 16:11:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 16:14:02< anonymissimus> fendrin: what's up with replace_map ? the tag is still at old syntax; looks like you forgot about it
20120223 16:26:21< Alarantalara> fendrin: there also seems to be problems with loading maps
20120223 16:26:47< Alarantalara> http://pastebin.com/MWtafrKM
20120223 16:27:02< Alarantalara> shows the offending lines from the autosave
20120223 16:27:21< Alarantalara> so I suppose the actual problem is saving them
20120223 16:27:33< Alarantalara> the text is from the snapshot
20120223 16:28:15-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120223 16:31:48< anonymissimus> fendrin: I get the gui/draw stderr output in HttT sceptre of fire as well; the lua warning ala fixed it
20120223 16:32:38< anonymissimus> yeah, and I cannot load a save from HttT::sceptre of fire, this was freshly started
20120223 16:33:14< anonymissimus> a turn save notably, the start-of.scenario save works
20120223 16:35:27< anonymissimus> fendrin: perhaps before you continue with this: do you have your git repo set up ? then probably create a branch for this, before we start having a mess in mainline
20120223 16:36:25< anonymissimus> a remote branch could also be tested with some of the map-loading heavy scenarios like me or a few other authors have
20120223 16:37:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120223 16:43:25< anonymissimus> shadowm: I'm getting a bit spammed with warnings such as "error filesystem: Could not open 'C:/wesnoth/userdata/saves/HttT-The_Elves_Besieged.gz' for reading." since recently; it seems some code tries to read start-of-scenario saves
20120223 16:44:46< anonymissimus> don't know whether it's caused by your feature or whether we decide to accept this warning, but it e.g. appears when playing a campaign freshly without existing saves for it
20120223 16:49:55-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120223 16:53:06-!- koutnji2 [~Miranda@koutnij.sh.cvut.cz] has joined #wesnoth-dev
20120223 17:09:14-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120223 17:11:34-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120223 17:13:56-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20120223 17:13:56-!- Upth is now known as Upthorn
20120223 17:19:49< koutnji2> Uhh..hello. I am new here and I was thinking about helping out with some unassigned bugs.
20120223 17:20:00-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120223 17:27:30-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer]
20120223 17:27:50-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120223 17:33:57-!- vcap [~vcap@AReims-551-1-72-131.w90-58.abo.wanadoo.fr] has quit [Quit: leaving]
20120223 17:37:42< koutnji2> soo, could anyone please give me some directions on how to proceed?
20120223 17:42:12-!- vcap [~vcap@AReims-551-1-72-131.w90-58.abo.wanadoo.fr] has joined #wesnoth-dev
20120223 17:47:17< anonymissimus> koutnji2: well, do you have a build environment ? look at http://gna.org/bugs/?group=wesnoth and choose something, then submit your work as a patch at http://gna.org/patch/?group=wesnoth
20120223 17:48:42< CIA-134> ivanovic * r53179 /trunk/ (28 files in 27 dirs): updated Chinese (Simplified) translation
20120223 17:48:44< CIA-134> ivanovic * r53180 /branches/1.10/ (29 files in 28 dirs): updated Chinese (Simplified) translation
20120223 17:55:17< koutnji2> well if that's all, then i will get to it, thank you
20120223 17:59:54-!- akzfowl [~Admin@1.186.9.215] has joined #wesnoth-dev
20120223 18:04:04< Ivanovic> koutnji2: once you find a bug you might want to talk to us first if we think that it might be doable as start
20120223 18:04:14< Ivanovic> since some of the bugs listed are known to be "hard to solve"
20120223 18:07:09-!- Blueblaze [~Blueblaze@adsl-76-202-19-244.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120223 18:12:28-!- Blueblaze [~Blueblaze@adsl-76-202-19-244.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20120223 18:13:40-!- akzfowl [~Admin@1.186.9.215] has quit [Read error: Connection reset by peer]
20120223 18:14:02-!- akzfowl [~Admin@1.186.9.215] has joined #wesnoth-dev
20120223 18:15:13-!- jemadux [~jemadux@athedsl-213439.home.otenet.gr] has joined #wesnoth-dev
20120223 18:15:13-!- jemadux [~jemadux@athedsl-213439.home.otenet.gr] has quit [Changing host]
20120223 18:15:13-!- jemadux [~jemadux@unaffiliated/jemadux] has joined #wesnoth-dev
20120223 18:17:22-!- Haldric [~Haldric@wesnoth/translator/Haldric] has joined #wesnoth-dev
20120223 18:18:15< koutnji2> oh, so is there some way i could distinguish the hard ones from those that are more suitable for newbies?
20120223 18:19:02< anonymissimus> "newbie" meaning just newbie to wesnoth, or also to coding ?
20120223 18:19:10< koutnji2> just wesnoth
20120223 18:20:25< anonymissimus> hm not really other than asking I think
20120223 18:21:23< koutnji2> ok
20120223 18:21:51< anonymissimus> for instance, this bug sounds like something I could perhaps handle: http://gna.org/bugs/?19343 since it has a precise how-to-reproduce
20120223 18:22:23< anonymissimus> and it has to do with the wml action engine
20120223 18:23:42< anonymissimus> while this one http://gna.org/bugs/?19430 is very vague and not worth looking at in it's current state; which is true for all "need info" ones, unless more info was provided since the last question for more info
20120223 18:24:59< koutnji2> uhuh
20120223 18:27:31< koutnji2> well then i guess i will try to look at the first one you posted, thanks a lot
20120223 18:39:54-!- ejls_ is now known as ejls
20120223 18:46:35-!- stikonas [~and@bcm-131-111-216-70.girton.cam.ac.uk] has joined #wesnoth-dev
20120223 18:46:36-!- stikonas [~and@bcm-131-111-216-70.girton.cam.ac.uk] has quit [Changing host]
20120223 18:46:36-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120223 18:46:58-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120223 18:49:48-!- wesbot changed the topic of #wesnoth-dev to: 1.10.1 planned for 25.2.; hard stringfreeze on branches/1.10 | 164 bugs, 327 feature requests, 17 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120223 18:52:48-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120223 18:53:10< shadowm> anonymissimus: ask Oleg 
20120223 18:54:18< shadowm> if you could prove that it was really my commit that would be helpful too
20120223 18:54:35< shadowm> git checkout `git svn find-rev r<whatever>`, recompile
20120223 18:56:57< anonymissimus> if I am proving that it is someone's commit I have gone half the way of fixing it which is the introducer's job :|
20120223 18:58:26< shadowm> I'm curious about the logic behind that.
20120223 18:59:52< anonymissimus> especially if I cannot just use git revert due to conflicts as in this case
20120223 19:01:57< shadowm> I never said git revert
20120223 19:05:09< anonymissimus> I know, but detached head checkout needs a rebuilt mostly
20120223 19:05:33< anonymissimus> and i got a clean diff now I soon know
20120223 19:08:46-!- Gallaecio [~quassel@84.120.113.193.dyn.user.ono.com] has joined #wesnoth-dev
20120223 19:13:10< anonymissimus> not as if I wouldn't use detached head checkouts all the time though
20120223 19:13:24< anonymissimus> but your suspicion is right, it's oleg's refactoring
20120223 19:14:28 * anonymissimus formally apologizes to shadowm
20120223 19:15:04< shadowm> an apology was never required in the first place
20120223 19:20:03< Oleg> anonymissimus: What the problem?
20120223 19:21:07< Oleg> shadowm: ping :)
20120223 19:22:03< shadowm> I see errors like the following at the start of turn 1 if I go and play HttT from the beginning, from the campaigns menu:
20120223 19:22:08< shadowm> 20120223 15:05:04 error filesystem: Could not open '/home/shadowm/.wesnoth-1.11/saves/HttT-The_Elves_Besieged' for reading.
20120223 19:22:30< Oleg> shadowm: Interesting
20120223 19:22:40< Oleg> shadowm: This is stable reproduced?
20120223 19:22:56< shadowm> yes (in trunk only, of course)
20120223 19:23:02< Oleg> shadowm: So, can you please trace where this file first time used? LD_PRELOAD for example.
20120223 19:23:14< shadowm> uhhhhhh
20120223 19:23:19< Oleg> shadowm: LD_PRELOAD => open/read/write => trace operations
20120223 19:23:29< Oleg> shadowm: Or ok, I will look to 
20120223 19:23:31< Oleg> shadowm: :)
20120223 19:23:43< shadowm> well, I'm busy working with uncommitted changes in a local branch and trying to meet a deadline, so ... :p
20120223 19:23:59< Oleg> shadowm: What the deadline?
20120223 19:24:14< Oleg> shadowm: In general in my refactoring I did just actions, which wesnoth did before refacroting
20120223 19:24:21< Oleg> shadowm: Behavior doesn't changes
20120223 19:24:24< Oleg> *changed
20120223 19:24:30< shadowm> It's the second step of my add-ons client refactoring, which I want to land before tomorrow
20120223 19:24:32< Oleg> shadowm: Aha, except one place
20120223 19:24:44< Oleg> shadowm: Hm.
20120223 19:24:52< Oleg> shadowm: One minute, can you please do following..
20120223 19:25:49< Oleg> shadowm: save_index_manager.rebuild(gamestate_.classification().label);
20120223 19:26:00< Oleg> shadowm: inside savegame::finish_save_game
20120223 19:26:09< Oleg> shadowm: Can you please comment this line? Just for check
20120223 19:26:39< Oleg> shadowm: If problem related to my changes - just this place...
20120223 19:26:52< shadowm> sigh, very well...
20120223 19:27:29< shadowm> but it *is* there already
20120223 19:27:44< shadowm> savegame.cpp:992
20120223 19:28:10< shadowm> ah, comment out, never mind
20120223 19:29:17< Oleg> shadowm: yes, comment out
20120223 19:29:55< shadowm> doesn't help
20120223 19:30:23< shadowm> never mind, I commented out before stashing my own changes
20120223 19:31:14< Oleg> :)
20120223 19:31:32< shadowm> okay, that skips the errors
20120223 19:33:28< Oleg> shadowm: Now no errors?
20120223 19:33:46< Oleg> shadowm: If yes - ok, I understand the problem and will fix. How soon you need the fix?
20120223 19:34:43< shadowm> yeah, I don't see any errors after commenting out that line
20120223 19:34:59< Oleg> shadowm: Ok.
20120223 19:35:06< Oleg> shadowm: If you want - I can explain what the problem
20120223 19:35:20< Oleg> shadowm: save_index should be rebuilded after save the game.
20120223 19:35:34< Oleg> shadowm: I did this by load the savegame from disk 
20120223 19:35:40< shadowm> I'm sure all trunk users are aware that temporary issues like that are common, and we are months away from the first development release, so there's no need to hurry with the fix
20120223 19:35:58< Oleg> shadowm: In one-two days is ok for you?
20120223 19:36:12< shadowm> sure. Besides, I'm not really the one who reported it first. :p
20120223 19:36:21< Oleg> shadowm: I will add methods for remove info from save_index
20120223 19:36:33< Oleg> shadowm: And will remove summary from index on finish_save_game
20120223 19:36:50< Oleg> shadowm: Next time when somebody wiil access to summary - it will read the correct summary
20120223 19:36:56< shadowm> okay, so why is it trying to load a saved game that doesn't exist?
20120223 19:37:12< shadowm> and AFAIK isn't requested by the engine to be written in the first place
20120223 19:37:53< Oleg> shadowm: Yes
20120223 19:38:04< Oleg> shadowm: Before my refactoring it was copy-pasted function
20120223 19:38:13< Oleg> shadowm: Which extract summary from full cfg file
20120223 19:38:18< Oleg> shadowm: I removed this copy-paste 
20120223 19:38:24< Oleg> shadowm: So, we have two way for solve
20120223 19:38:36< Oleg> shadowm: 1) just remove summary from save_index - it will be reloaded by-demand
20120223 19:38:51< Oleg> shadowm: 2) extract sub_function from "load_summary_from_file"
20120223 19:39:08< Oleg> shadowm: I will look into both ways
20120223 19:39:19< shadowm> what I don't understand is why it's attempting to extract a summary from a file that doesn't exist nor is expected to always exist
20120223 19:39:51< Oleg> shadowm: This is my mistake. I think file created already.
20120223 19:40:03< Oleg> shadowm: Or your changes introduced some behavior changes
20120223 19:40:35< Oleg> shadowm: Looks like last... 
20120223 19:41:01< shadowm> r52962
20120223 19:41:10< Oleg> let me look
20120223 19:41:31< shadowm> you'll notice it calls savegame::manager::save_game_exists() to check whether the start-of-scenario save exists before attempting to do anything with it
20120223 19:41:48< shadowm> in fact, nothing is done directly with it besides that call
20120223 19:42:06< fendrin> hello
20120223 19:42:20< Oleg> shadowm: Ok, I understand and I will fix this
20120223 19:42:20< shadowm> and this isn't a new addition either, since the same call is performed for every possible autosave for previous turns
20120223 19:43:09< Oleg> shadowm: ok, I understand :) thank you for a catch!
20120223 19:43:18< Oleg> shadowm: I will fix it in two days
20120223 19:43:28< Oleg> shadowm: Where I can get your changes for test? Just trunk?
20120223 19:43:34< Oleg> shadowm: Or it is separated branch?
20120223 19:43:48< shadowm> you mean the add-ons client changes?
20120223 19:44:08< Oleg> shadowm: I mean changes where this bug "error reading file" reproduced
20120223 19:44:21< shadowm> r52962 landed in trunk before your own changes
20120223 19:44:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120223 19:44:42< shadowm> wesbot: log 52962
20120223 19:44:43< wesbot> shadowmaster * r52962 : Added a "Back to Start" option to the game menu to load the curent scenario's start save if it is available (feature/bug #18027)
20120223 19:44:46< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=52962
20120223 19:45:19< Oleg> shadowm: It is actual for current trunk?
20120223 19:45:51< Oleg> *Is it actual for current trunk?
20120223 19:45:58< shadowm> yes
20120223 19:46:10< Oleg> shadowm: Ok, I will look
20120223 19:46:13< Oleg> shadowm: Sorry for a bug...
20120223 19:46:20< Oleg> shadowm: This is one of reason why we need CI
20120223 19:46:26< Oleg> shadowm: And tests, tests, tests...
20120223 19:47:20< shadowm> this kind of things doesn't sound that easy to automatize
20120223 19:47:56< fendrin> anonymissimus: I think the [map] not supported at scenario toplevel was already fixed by Alarantalara. I can't reproduce it. Which scenario did you use to test?
20120223 19:53:23-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds]
20120223 19:54:40-!- Danceman [~Danceman@a94-132-158-220.cpe.netcabo.pt] has joined #wesnoth-dev
20120223 19:55:17-!- koutnji2 [~Miranda@koutnij.sh.cvut.cz] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20120223 19:59:22< anonymissimus> Oleg: yes, shadowm pasted that error I got as well
20120223 19:59:34< Oleg> anonymissimus: Thank you for catch
20120223 19:59:38< Oleg> anonymissimus: I will fix this soon
20120223 19:59:43< Oleg> anonymissimus: And sorry for a bug
20120223 20:00:08< anonymissimus> Oleg: I detected r53111 and/or r53114 to be the cause
20120223 20:00:25-!- negusnyul [~negusnyul@dsl4E5CCB0B.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20120223 20:00:34< anonymissimus> you please fix your things without bothering other people with it (without bothering me, at least)
20120223 20:00:47< Oleg> anonymissimus: Yes, I understand the bug reason and my mistake already
20120223 20:01:05-!- negusnyul [~negusnyul@dsl4E5CCB0B.pool.t-online.hu] has joined #wesnoth-dev
20120223 20:01:05-!- negusnyul is now known as prkc
20120223 20:01:34< Oleg> anonymissimus: I will do this. Mistakes is normal part of process development. I try to minimize it, but in general every change can affect other people...
20120223 20:01:42< Oleg> anonymissimus: :)
20120223 20:02:04< anonymissimus> and please do *not highlight* me with updated about your progress
20120223 20:02:18< Oleg> anonymissimus: Ok...
20120223 20:02:22 * Oleg will return to chat soon
20120223 20:02:23-!- Oleg [~quassel@92.124.14.24] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20120223 20:03:05< anonymissimus> fendrin: "map not supported at toplevel": yes, ala shoudl have fixed it
20120223 20:04:47< anonymissimus> fendrin: what is the precise syntax in [scenario] for defining the map now ? it should be the same as in replace_map and terrain_mask (these three places are all I can think of which can make wml and/or lua load a map)
20120223 20:05:34< zookeeper> ...are you saying that the old way of specifying maps doesn't work anymore in trunk?
20120223 20:07:01< anonymissimus> it does as long as we keep backwards compat
20120223 20:07:09< anonymissimus> or is intended to work
20120223 20:07:16< zookeeper> yeah and not keeping compat for something like that is just silly
20120223 20:08:01< anonymissimus> yes, I feel as if we shouldn't deprecate the old syntax at all, unless there's a good reason for it; for instance, it could be costly code-wise to kee it
20120223 20:08:57< zookeeper> assuming the map syntax itself doesn't change, it can't be very costly to have the code just convert old syntax to new internally
20120223 20:09:43< anonymissimus> fendrin: is this right: http://pastebin.com/UaSRD2EM
20120223 20:09:46-!- s951 [~s951@dyn1064-176.hor.ic.ac.uk] has joined #wesnoth-dev
20120223 20:10:24< anonymissimus> if yes, then I imagine a way to combine it with #ifver, since the preprocessor can do string-concatenation of included files containing strings
20120223 20:10:43< zookeeper> i really think the major problem with wesnoth is beginning to be the unrestrained breaking of everything in dev versions
20120223 20:10:53< zookeeper> s/the/a, if you will
20120223 20:11:10< fendrin> anonymissimus: exactly
20120223 20:11:52< anonymissimus> not sure about linebreaks and such though, whether it will actually work
20120223 20:12:15< zookeeper> what _is_ the rationale for this particular change anyway? how does it help content makers/maintainers?
20120223 20:12:32< zookeeper> i'm sure you've explained it before, but i don't remember and can't find it
20120223 20:12:45< fendrin> I can parse map files with the wml parser.
20120223 20:13:26< anonymissimus> it probably doesn't help content makers/maintainers at all in the first place
20120223 20:13:26< zookeeper> why does a content maker/maintainer need to parse map files with the wml parser?
20120223 20:13:52< fendrin> zookeeper: You want to keep the support for embedded maps like it is done for the test scenario?
20120223 20:13:58< anonymissimus> but I imagine that it may simplify things on the engine side, although i don't understand it atm
20120223 20:14:31< zookeeper> fendrin, i don't know
20120223 20:14:33< zookeeper> your turn
20120223 20:14:57< anonymissimus> fendrin: does the change have to do wih whether it is embedded or not ?
20120223 20:14:59< fendrin> Okay, that means I will support them.
20120223 20:15:37< anonymissimus> if it's embedded I see no way to adapt the change to #ifver though
20120223 20:16:00< anonymissimus> that is, have one map file/data which is used no matter what wesnoth version
20120223 20:16:14< fendrin> it can be in a macro
20120223 20:16:20< fendrin> that would work
20120223 20:17:28< anonymissimus> well you should probably create some wml examples for testcases which you can also paste as demonstrations then
20120223 20:17:43< fendrin> Also I have made the engine to read an old format string that hits [map]data= and convert it.
20120223 20:18:00-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120223 20:18:13< zookeeper> could you answer my question, please?
20120223 20:18:43< fendrin> you == me?
20120223 20:18:47< zookeeper> yes
20120223 20:18:54< anonymissimus> which question ?
20120223 20:19:25< zookeeper> ...the only one i asked?
20120223 20:19:43< anonymissimus> the "why does a content maker/maintainer need to parse map files with the wml parser?" one ?
20120223 20:19:55< zookeeper> obviously
20120223 20:20:24< anonymissimus> well he doesn't need it, it's some sytax change forced upon content/wml authors for cloudy engine-implementation reasons xD
20120223 20:20:24< fendrin> Never
20120223 20:20:34< zookeeper> okay
20120223 20:20:36< fendrin> Most content makers won't even know what parsing is.
20120223 20:20:41< fendrin> silly question
20120223 20:21:37< anonymissimus> ok so what exactly do you gain from the change ? I don't understand it yet, your answer isn't comprehensive enough
20120223 20:22:04< anonymissimus> shadowm also wasn't too happy with it from what I can grasp in the log
20120223 20:22:15< zookeeper> point is, that please don't break existing WML of every scenario there is just so you can make some map parsing code a little bit nicer and prettier
20120223 20:22:16< fendrin> The map editor of wesnoth needs to parse and write valid wml files.
20120223 20:23:20< zookeeper> and it does so
20120223 20:23:44< fendrin> Yes, it does so.
20120223 20:25:23< zookeeper> sigh. so what's the rationale for this change we're talking about?
20120223 20:25:30< anonymissimus> hm ok that makes it a bit clearer; I imagine that it could simplify some things
20120223 20:25:51< anonymissimus> and/or allow for enxtending the map editor
20120223 20:26:05< fendrin> Beside of that, the change is a code cleanup. The old syntax was a hacky mess, and c++ code needs to be maintained as well. 
20120223 20:26:37< fendrin> anonymissimus: Exactly.
20120223 20:26:54< zookeeper> then do the cleanup in a backwards-compatible way
20120223 20:27:05< zookeeper> don't break WML for a code cleanup
20120223 20:27:17< anonymissimus> yes; I like it that your change is actually some refactoring rather than a feature
20120223 20:27:56< anonymissimus> zookeeper: sometimes this needs to be done if there's a good reason
20120223 20:28:13< anonymissimus> can we keep the backwards compatibility ?
20120223 20:28:23< fendrin> zookeeper: Don't worry, I have backwards compatibility in place. We can discuss how long it should last. 
20120223 20:28:42< fendrin> The normal procedure is 3 development releases. 
20120223 20:28:52< zookeeper> well, that's fine then
20120223 20:28:58< zookeeper> err
20120223 20:29:03< fendrin> But we could be more extreme.
20120223 20:29:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 20:29:15< zookeeper> if you mean 3 development branches then yeah, i agree
20120223 20:29:24< zookeeper> or s/branches/cycles
20120223 20:29:34< fendrin> no, of course not.
20120223 20:29:43< fendrin> 3 development releases.
20120223 20:29:48< fendrin> That is rather short.
20120223 20:30:16< fendrin> From 1.11.4 would not feature the old support any more.
20120223 20:30:32< fendrin> That is how we normally introduce wml syntax changes.
20120223 20:31:21< zookeeper> yeah, and it sucks because the thing which causes extra work for authors is breakage between stable versions, not how many dev versions it takes
20120223 20:31:28< fendrin> But maybe it can stay for the whole 1.11/1.12 cycle. Being 1.13 the first release that can't load the old format any longer or begins to spit out warnings.
20120223 20:31:55< zookeeper> if you keep the compat until 1.13 then i'd have no complaints at all
20120223 20:32:13< fendrin> It is hard work to get it right.
20120223 20:32:14< anonymissimus> a wmllint rule ? hmhm. how could wmllint detect/change/fix this: 	map_data="{~add-ons/A_Simple_Campaign/maps/01_Template.map}"
20120223 20:32:25< fendrin> So having it around for some time would make me feel better :-)
20120223 20:32:43< anonymissimus> it doesn't have macor expansion
20120223 20:33:17< fendrin> map_data="{~add-ons/A_Simple_Campaign/maps/01_Template.map}"    ---> {~add-ons/A_Simple_Campaign/maps/01_Template.map}
20120223 20:33:52< fendrin> very simple conversion needed here.
20120223 20:34:56< anonymissimus> and the data= key ?
20120223 20:35:05< zookeeper> i think wesnoth is at the point where we should start keeping backwards-compatibility as much as possible. the more difficult it is to port add-ons to new versions, the more add-ons get left behind, and that's not good
20120223 20:35:33< anonymissimus> well it could write it into the map file
20120223 20:36:28< anonymissimus> ok a wmllitn rule should be doable
20120223 20:36:35< fendrin> zookeeper: Maybe, if we had a better working addon server. If the healing forces of incompatibility wouldn't kill the bad content the addon server would be even more crowded.
20120223 20:36:54< fendrin> And running wmllint every new release on an addon is not too much.
20120223 20:37:34< fendrin> The new map format can be handled by wmllint completely and the editor is able to do the conversion as well.
20120223 20:37:41< zookeeper> i'm under the impression that shadowm would disagree with that
20120223 20:38:21< zookeeper> and me too, since i still couldn't be arsed to try to run wmllint
20120223 20:38:21< fendrin> Yeah, shadowm is a special case with his hate on wmllint.
20120223 20:38:33< anonymissimus> fendrin: I wouldn't expect esr to be quick with coding the rule, would be nice to do it yourself ;)
20120223 20:38:40< anonymissimus> and apply it
20120223 20:39:20 * anonymissimus attempts writing and applying a rule for all syntax changes he makes
20120223 20:39:57-!- Haldric [~Haldric@wesnoth/translator/Haldric] has quit [Remote host closed the connection]
20120223 20:40:05< anonymissimus> and check out that it works with #ifver; after fixing the bugs reported today of course
20120223 20:40:20< fendrin> The rule is not urgent. In fact I want to have the old format around as long as possible. To test to backwards compatibility good enough.
20120223 20:41:03< esr> fendrin: Sadly, anonyssimus is roght.  I have a houseguest arriving tomorrow and when he gets here we're going to be writing diagnostic software for the Internet time service for most of a week.  If I don't get to it today it will be rather delayed.
20120223 20:42:05< fendrin> esr: Well, I think wmllint will need to have the feature in 1.13, enough time till then.
20120223 20:42:56< anonymissimus> there'll be a lot of other features required or bug fixes till then
20120223 20:43:17< anonymissimus> to make sure it's complete, do it yourself
20120223 20:43:26< fendrin> Maybe.
20120223 20:43:47< fendrin> But I do not want to convert the maps to the new format right now.
20120223 20:43:54< fendrin> That would be much to urgent.
20120223 20:44:12< fendrin> s/to/too
20120223 20:47:48< fendrin> Converting the maps is the last step when I know that both formats are working fine. 
20120223 20:49:56< anonymissimus> also note that it's now rather common to load maps with lua; such as wml_actions.replace_map({map=wesnoth.dofile(~add-ons_...)})
20120223 20:50:26< anonymissimus> and that file returns a string containing a valid (old format) map string, these refernces need a hand fix
20120223 20:50:58< anonymissimus> mainline doesn't do this, but quite some addon I believe (including me)
20120223 20:51:13< fendrin> LoW is full of replace_map
20120223 20:51:41< anonymissimus> but they are wml occurences fixable by wmllint
20120223 20:51:50< anonymissimus> probably
20120223 20:53:12< fendrin> Okay, let me fix the bug that prevents savegames from being loaded. That one is very urgent.
20120223 21:02:29< anonymissimus> yes
20120223 21:02:34< anonymissimus> and this here works: http://pastebin.com/Qs7NsXaX
20120223 21:03:26-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120223 21:03:41< anonymissimus> it needs to be macroized for usage in multiple scenarios
20120223 21:05:58< anonymissimus> there could be a mainlien macro for it and a script for the conversion
20120223 21:11:42< fendrin> Well, our conversion script is per definition wmllint.
20120223 21:12:09< fendrin> If nobody likes it anymore we need a new solution.
20120223 21:13:28-!- jemadux [~jemadux@unaffiliated/jemadux] has quit [Read error: Operation timed out]
20120223 21:31:39-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20120223 21:32:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120223 21:41:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120223 21:47:11-!- s951 [~s951@dyn1064-176.hor.ic.ac.uk] has quit [Quit: Leaving]
20120223 21:48:15-!- StealthyCoin [~StealthyC@hawknet-wireless-gw-ext.cabrillo.edu] has joined #wesnoth-dev
20120223 21:51:48< anonymissimus> fendrin: for this particular purpose it shouldn#t be wmllint
20120223 21:52:09< anonymissimus> the mainline cfg files don't need this, it's just for addons
20120223 21:52:37< anonymissimus> mainline needs a wmllitn rule without #ifver
20120223 21:54:42-!- akzfowl [~Admin@1.186.9.215] has left #wesnoth-dev ["Leaving"]
20120223 21:55:06-!- Blueblaze [~Blueblaze@adsl-99-158-46-178.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120223 21:55:38< anonymissimus> the header should be simplified further; from what I've seen in the engine code, a normal wesnoth map which is intended for in [scenario] or [replace_map] has to always have usage=map and border_size=0
20120223 21:55:41< anonymissimus> =1 sry
20120223 21:55:53< anonymissimus> other than that it fails to load anyway
20120223 21:56:08< anonymissimus> if usage=mask, then border_size can be 0 or 1
20120223 21:56:21< anonymissimus> but only allowed in terrain_mask
20120223 21:57:46-!- Blueblaze [~Blueblaze@adsl-99-158-46-178.dsl.hstntx.sbcglobal.net] has quit [Client Quit]
20120223 21:58:19< CIA-134> fendrin * r53181 /trunk/src/map.cpp: Removed extra quoting for map strings.
20120223 21:59:49< CIA-134> fendrin * r53182 /trunk/src/cavegen.cpp: magic number
20120223 22:00:46< anonymissimus> hm well seems it could be put into replace_map usage=mask and border_size=0 in trying to force a map without a border :|
20120223 22:00:59< fendrin> anonymissimus: Yes, all the usage and border stuff is just non sense.
20120223 22:02:32< anonymissimus> agreed pretty much
20120223 22:02:52< anonymissimus> I was thinking it's left over from the <1.3 times
20120223 22:03:41-!- Blueblaze [~Blueblaze@adsl-99-148-245-116.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20120223 22:05:14< fendrin> I remember the times when there was no border.
20120223 22:06:15< anonymissimus> so you plan on coding the newbie dream, editing everything in the map editor ?
20120223 22:06:32< fendrin> no
20120223 22:06:45< fendrin> I will start with labels.
20120223 22:06:54< fendrin> That is much work and take a long time.
20120223 22:07:18< fendrin> The label system is very old and a hack. It could also benefit from a refactoring process.
20120223 22:07:25-!- Blueblaze [~Blueblaze@adsl-99-148-245-116.dsl.hstntx.sbcglobal.net] has quit [Client Quit]
20120223 22:07:29< anonymissimus> I recall a particular campaign which was apparently a campgen one; it was by far the worst I've ever seen
20120223 22:07:59< anonymissimus> the label system could be made similar to teh [item] one
20120223 22:08:16< fendrin> please tell me more
20120223 22:08:35< anonymissimus> well, items are handled in the lua file of that name
20120223 22:08:40< fendrin> by the way, r53181 should fix most bugs.
20120223 22:08:53< anonymissimus> it would also easily allow to add SLF to [label]
20120223 22:08:59-!- Crendgrim [~crend@77-22-112-160-dynip.superkabel.de] has quit [Quit: ...]
20120223 22:09:14< anonymissimus> but placing labels in the editor would endeed be nice
20120223 22:09:21< anonymissimus> same for items
20120223 22:09:27< fendrin> both is planned
20120223 22:09:38< anonymissimus> then perhaps start with items
20120223 22:09:48< fendrin> I have a working prototype that is segfaulting all the time but is feature complete.
20120223 22:10:02-!- mjs-de [~mjs-de@f053190219.adsl.alicedsl.de] has quit [Remote host closed the connection]
20120223 22:10:11< anonymissimus> it's supposedly easier; labels can be set by players as well, items are wml/lua only
20120223 22:10:42< fendrin> items is another problem, the display / game_display / editor_display hierarchy is quite messy at the moment.
20120223 22:11:49< anonymissimus> the lua file handles the interface to wml action and the re-setting upon loading a save/replay
20120223 22:12:09< anonymissimus> and the storing upon saving
20120223 22:12:22< anonymissimus> re-setting meaning re-placing it in the UI
20120223 22:12:50< anonymissimus> which needs to be re-done after a scenario load
20120223 22:12:58< anonymissimus> which has items
20120223 22:13:15< fendrin> ?
20120223 22:13:17< fendrin> hmmm
20120223 22:13:33< anonymissimus> however, the editor probably not loads the lua files at all I think
20120223 22:13:51< anonymissimus> well... forget it
20120223 22:14:37< fendrin> Then I plan unit placement.
20120223 22:14:54< fendrin> village ownership assignment.
20120223 22:15:51< fendrin> named areas
20120223 22:15:52< zookeeper> i just wish effort was directed at things which actually make it possible or considerably easier to make good content. no one's even been hindered by not being able to place units or village ownership in the editor, whereas adding such functionality will surely bloat and complicate the codebase quite a bit.
20120223 22:16:19< zookeeper> the bottleneck is always the skills of the author, not the capabilities of the editor or whatnot
20120223 22:16:29< Espreon> The village naming feature is an abortion.
20120223 22:16:45< fendrin> village naming feature?
20120223 22:17:14< Espreon> On random maps.
20120223 22:17:21< fendrin> ah yes
20120223 22:17:56-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Remote host closed the connection]
20120223 22:18:54< fendrin> zookeeper: The editor framework is easy to extend. Every new functionality can be dropped in separately. The editor itself is nearly untouched. 
20120223 22:19:35< fendrin> zookeeper: What do you suggest to add to make good content?
20120223 22:20:28< anonymissimus> it needs to be hard to make good content, otherwise the addons server is flooded with bad stuff
20120223 22:21:09< Espreon> Uh...
20120223 22:21:25< fendrin> Well, that reminds me to implement a publish button that adds the newly created stuff to the server.
20120223 22:21:36< zookeeper> fendrin, faster loading, more stable base to build on rather than compat breakage all the time, better add-on server, that sort of stuff.
20120223 22:21:40< Espreon> Sigh.
20120223 22:22:17< anonymissimus> fendrin: did you also fix the stderr message in HttT scepter of fire which I mentioned ?
20120223 22:23:00< zookeeper> ask reputable UMC makers what sort of features would make them more productive
20120223 22:24:00< fendrin> zookeeper: Well, all the features will certainly help me when doing Wesnoth stuff.
20120223 22:24:29< fendrin> anonymissimus: Let me test it.
20120223 22:26:04< fendrin> zookeeper: I did. inferno suggested to add support for the overlay graphics he uses in his campaign.
20120223 22:26:51< fendrin> That is on my TODO as well.
20120223 22:27:35-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 240 seconds]
20120223 22:32:38< CIA-134> anonymissimus * r53183 /trunk/src/editor/map_context.cpp: fix an MSVC warning about unreferenced local variable
20120223 22:32:39-!- csarmi [csarmi@94-21-133-102.pool.digikabel.hu] has joined #wesnoth-dev
20120223 22:38:50-!- prkc [~negusnyul@dsl4E5CCB0B.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20120223 22:42:54-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120223 22:47:52< CIA-134> fendrin * r53184 /trunk/src/playcampaign.cpp: Removed left over debug output.
20120223 22:47:57< fendrin> anonymissimus: ^
20120223 22:54:47< anonymissimus> ah ok, glad it was just that
20120223 22:55:34-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120223 22:55:56< anonymissimus> hm you could tie it to an appropriate log domain
20120223 22:56:19-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120223 23:00:59< fendrin> anonymissimus: Maybe, but this is not the right location for debug exactly that debug output.
20120223 23:01:06< fendrin> log output
20120223 23:08:23< AI0867> fendrin: there's also some comments in src/editor/editor_controller.cpp from r53169
20120223 23:29:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120223 23:34:03-!- csarmi [csarmi@94-21-133-102.pool.digikabel.hu] has quit [Quit: sleep]
20120223 23:37:55-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120223 23:39:15< shadowm> fendrin, zookeeper : My problem is not with wmllint, but #ifver
20120223 23:40:25< shadowm> I had planned to use #ifver to share a single codebase for AtS both for 1.10 and 1.12 for a while, and as I said the other night,  it just isn't feasible to use #ifver to make 1.10 maps with with 1.12 or viceversa because of the parsing differences
20120223 23:40:48< shadowm> *work with
20120223 23:48:09< fendrin> shadowm: I think there is no longer any problem. One possible solution is to feed [map]data= just with the old syntax.
20120223 23:49:18< shadowm> but will that flood the user with errors?
20120223 23:49:37< fendrin> No, it doesn't mind.
20120223 23:49:56< shadowm> more specifically, deprecation warnings, I mean
20120223 23:50:12< fendrin> There is none in place at the moment.
20120223 23:50:49< shadowm> because then there's no problem as far as I am concerned right now :) (I'm too busy to go and try to update AtS with 1.12 compatibility at this very moment)
20120223 23:52:07< shadowm> (that means I haven't tested anything outside of the add-ons management code lately)
20120223 23:52:42< fendrin> shadowm: I think the best is you just do nothing at the moment regarding the issue. The backwards compatibility needs to be tested.
20120223 23:53:04< fendrin> I mean no #ifver experiments.
20120223 23:54:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20120223 23:55:27< shadowm> very well
20120223 23:55:50< anonymissimus> shadowm: did you look at the draft I pastebinned ?
20120223 23:56:05< anonymissimus> why can't you do that ?
20120223 23:56:09< anonymissimus> or similar
20120223 23:56:14< shadowm> no, I usually only read my highlights only
20120223 23:56:31< anonymissimus> http://pastebin.com/Qs7NsXaX
20120223 23:57:07< anonymissimus> of course the header should be a global one instead, it's always the same
20120223 23:57:10< shadowm> I think I had suggested something similar in a pastebin the other day
20120223 23:58:03< anonymissimus> ok, and why can't you macrofy this so you could rather easily use it in all your scenarios ?
20120223 23:58:19< shadowm> the problem is that I wanted to work with the 1.10 map editor, which produces maps with the metadata/faux-WML in them
20120223 23:58:26< anonymissimus> I want to do the same actually
20120223 23:58:43< shadowm> and the 1.12 map editor AFAICU was going to write maps containing the full WML ([map] and its children)
20120223 23:59:31< shadowm> (As Far As I Could Understand)
--- Log closed Fri Feb 24 00:00:51 2012