--- Log opened Fri Mar 30 00:00:12 2012
20120330 00:01:01-!- loonybot [~loonybot@46.138.86.26] has joined #wesnoth-dev
20120330 00:01:01-!- loonybot [~loonybot@46.138.86.26] has quit [Changing host]
20120330 00:01:01-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120330 00:06:37-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120330 00:16:01-!- tyrannodogg [~tyrannodo@ip-33-19.travedsl.de] has left #wesnoth-dev []
20120330 00:17:40-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has quit [Ping timeout: 244 seconds]
20120330 00:21:24-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 252 seconds]
20120330 00:26:00-!- Johannes13 [~Johannes@p4FDEAF51.dip.t-dialin.net] has joined #wesnoth-dev
20120330 00:26:00-!- Johannes13 [~Johannes@p4FDEAF51.dip.t-dialin.net] has quit [Changing host]
20120330 00:26:00-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20120330 00:26:36-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120330 00:39:22-!- khoover [~crazy1010@69.159.23.64] has quit [Read error: Connection timed out]
20120330 00:53:06-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Excess Flood]
20120330 00:53:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120330 00:54:05-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev
20120330 00:59:44< anonymissimus> anyone know what team::see is good for ?
20120330 01:00:16< anonymissimus> is there some info kept about which side knows which other sides ? doesn't make any sense AFAIK, nto in wesnoth
20120330 01:06:50-!- trademark__ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Remote host closed the connection]
20120330 01:14:22-!- Aethaeryn is now known as LRonHubbard
20120330 01:14:28-!- LRonHubbard is now known as Aethaeryn
20120330 01:20:08-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20120330 01:20:27-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]]
20120330 01:32:13-!- khoover [~crazy1010@69.159.23.64] has joined #wesnoth-dev
20120330 01:33:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120330 01:36:23-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Quit: Hosted by rdlBNC (Server 3 - East Coast USA)]
20120330 01:47:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 01:49:49-!- wesbot changed the topic of #wesnoth-dev to: Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 170 bugs, 327 feature requests, 19 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120330 01:49:56-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev
20120330 01:50:11-!- s951 [~s951@cpc31-cmbg15-2-0-cust850.5-4.cable.virginmedia.com] has quit [Quit: Leaving]
20120330 01:53:04-!- gabba [~gabba@wesnoth/developer/gabba] has quit [Ping timeout: 245 seconds]
20120330 01:56:37-!- Nephro [~Dmitry@02de475b.bb.sky.com] has joined #wesnoth-dev
20120330 01:56:54-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20120330 01:57:37-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20120330 02:00:40-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20120330 02:07:49-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 260 seconds]
20120330 02:08:10-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20120330 02:09:20-!- vultraz_laptop [~chatzilla@124.109.10.221] has quit [Ping timeout: 272 seconds]
20120330 02:16:07-!- Gallaecio_ [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev
20120330 02:16:54-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Ping timeout: 248 seconds]
20120330 02:19:01-!- Nephro [~Dmitry@02de475b.bb.sky.com] has quit [Ping timeout: 276 seconds]
20120330 02:33:19-!- Gallaecio_ [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Ping timeout: 276 seconds]
20120330 02:38:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120330 02:40:32< ejls> gabba: Hey!
20120330 02:42:43< ejls> gabba: On the wb backend refactoring idea page, you wrote that there is a lot of duplicate code, do you have a chunk in mind?
20120330 02:43:40< gabba> Hey ejls
20120330 02:43:51< gabba> Let me try and get a concrete example
20120330 02:48:00< ejls> gabba: Also, it took me some time to tackle the mapbuilder problem, I would like to be sure that I understand it clearly: the problem with the highlighter is that it looks at all the actions through the visitor (and so, we should link hexes with actions), one of the problems with the validator is that the actions are tested before being built but in order to test them, they are built, right?
20120330 02:48:31< ejls> (*question time*) :)
20120330 02:58:27< gabba> ejls: about the highlighter, that's the main problem yes
20120330 02:58:45< gabba> Gonna answer the validator one after I find one of those code chunks you asked for 
20120330 02:59:30< ejls> ok, thanks. :)
20120330 03:03:28< gabba> ejls: Well, while browsing around I'm finding an example of a slightly different problem :P
20120330 03:03:48< gabba> One that fits into your project as well
20120330 03:04:02< gabba> if you look at whiteboard/move.cpp line 369
20120330 03:04:44< gabba> You'll see that I recover a reference to the unit from the hex it's supposed to be at
20120330 03:05:35< gabba> I did some work on that recently, but the wb backend really needs a uniform way of referencing its units
20120330 03:06:37< gabba> It used to be a mix of pointers + many checks, unit map finds on hexes and unit map iterators, not sure about the whole picture right now
20120330 03:07:43< ejls> If I remember correctly, the problem is that an unit's id can change right?
20120330 03:07:56< gabba> not saying that what happens at line 369 is bad, but rather that it needs to be compared to other uses and uniformized if possible
20120330 03:08:18< gabba> well the problem is that the unit can be completely erased out of our control
20120330 03:08:45< gabba> I don't think its ID can change, that's assigned at unit creation
20120330 03:09:17< gabba> unless of course it's replaced by another unit by some WML wizardry
20120330 03:11:20< ejls> Hum, so what is needed, is to uniformize the way units are used in the wb.
20120330 03:11:30-!- loonycyborg_ [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120330 03:12:29 * ejls notes it in his TODO list.
20120330 03:12:35< gabba> This is actually on topic for your question, after all. The code I just pointed at is redundant in the context of your project, since if you just did validation before, you'd be able to check and refresh all unit references of every planned action before applying this move to build the future state.
20120330 03:13:32-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has quit [Quit: I ATE'NT DEAD]
20120330 03:13:38-!- loonycyborg_ is now known as loonycyborg
20120330 03:13:42-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120330 03:14:03< gabba> If you compare to whiteboard/validate_visitor.cpp line 87, you'll see that it also does a unit map find to check for the unit's presence
20120330 03:15:07< ejls> Ok, I wasn't searching in the action hierarchy.
20120330 03:17:01< gabba> The mapbuilder mostly calls apply/remove_temp_modifier of each action, but it's not so easy to see at first because of all the indirection - which is something I'd like to see simplified btw.
20120330 03:19:45-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 246 seconds]
20120330 03:20:26< ejls> Hum, so you would like to cache data in the combined mapbuilder/validor? Can't these data be cached somewhere else (e.g. in the visitor)? Since, this will also be needed by the highlighter and merging all the classes in the mapbuilder doesn't looks good. I haven't thought a lot about it but I'm afraid that the result of the fusion will be a too big class…
20120330 03:20:35-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Quit: ZNC - http://znc.in]
20120330 03:21:26< gabba> ejls: Actually that's another aspect which could benefit from uniformization: we kind of have a mix of two approaches here, one where the object does the operations itself (mapbuilder with apply/remove_temp_modifier() ) and one where a friend class does all the work to keep the action classes smaller (validator is friend to all actions and I think it still accesses some of their fields directly)
20120330 03:21:44< gabba> About the caching, let me see...
20120330 03:23:38< gabba> ejls: well, the idea is not so much to cache data IN the combined mapbuilder/validator, but rather to cache it DURING the mapbuilding/validation
20120330 03:26:06< gabba> The "visitor" is actually kind of a misnomer since it doesn't follow the visitor pattern exactly anymore, I think. I guess you could keep it separate from the mapbuilder/visitor to keep the iterating logic separate from the rest if you want, but it at least needs to be renamed.
20120330 03:26:56< gabba> As to what you cache the data IN, it doesn't matter at all and is really up to you...
20120330 03:29:10< ejls> Ok, the main goal of the fusion would be to reduce the number of (duplicate) validation while the caching would allow faster look up of hexes and units?
20120330 03:31:40< gabba> Yes, that sounds correct.
20120330 03:32:53< gabba> I'm adding the code example I gave you to the wiki, as well as those secondary refactoring concernes I mentioned, btw
20120330 03:34:26< ejls> Ok, I'll also reread the logs to be sure, but thanks a lot that clarified the problem.
20120330 03:36:56< gabba> no problem :)
20120330 03:39:11< ejls> Well, it's 3.40am here, so good night. :)
20120330 03:40:42< gabba> 'night to you too :)
20120330 03:43:54-!- seahen [~chatzilla@bas13-toronto12-1167983830.dsl.bell.ca] has joined #wesnoth-dev
20120330 03:44:20-!- fendrin [~fabi@88-134-16-3-dynip.superkabel.de] has joined #wesnoth-dev
20120330 03:44:20-!- fendrin [~fabi@88-134-16-3-dynip.superkabel.de] has quit [Changing host]
20120330 03:44:20-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20120330 03:47:08< seahen> how do I build for gcov and gprof using ccmake?
20120330 03:47:08< seahen> I tried setting the build type to ReleaseWithDebugInfo, and adding -fprofile-arcs -ftest-coverage -pg to the c/cxx/linker flags
20120330 03:47:08< seahen> for that build type
20120330 03:47:08< seahen> but no gmon.out comes out
20120330 03:52:18< seahen> anyone? :(
20120330 03:57:18-!- seahen [~chatzilla@bas13-toronto12-1167983830.dsl.bell.ca] has quit [Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120310010316]]
20120330 03:57:35< gabba> seahen, I've never tried gcov or gprof, so I'm not sure I can help you there
20120330 03:58:04< gabba> I personally build wesnoth under Ubuntu Linux with cmake and it works fine
20120330 04:33:20-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Read error: Operation timed out]
20120330 04:34:47-!- fendrin_ [~fabi@88-134-16-3-dynip.superkabel.de] has joined #wesnoth-dev
20120330 04:34:47-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20120330 04:36:03-!- jamit [~james@pool-173-61-168-180.cmdnnj.east.verizon.net] has quit [Quit: Leaving.]
20120330 04:37:02-!- micole [~micole@unaffiliated/micole] has joined #wesnoth-dev
20120330 04:45:40-!- fendrin_ [~fabi@88-134-16-3-dynip.superkabel.de] has quit [Ping timeout: 260 seconds]
20120330 04:48:20-!- fendrin_ [~fabi@88-134-16-3-dynip.superkabel.de] has joined #wesnoth-dev
20120330 05:16:34-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120330 05:40:44-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 260 seconds]
20120330 05:45:31-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 260 seconds]
20120330 05:47:17-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120330 05:48:44-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120330 06:07:50-!- noy [~Noy@S0106602ad0727b65.vw.shawcable.net] has joined #wesnoth-dev
20120330 06:07:57-!- noy [~Noy@S0106602ad0727b65.vw.shawcable.net] has quit [Changing host]
20120330 06:07:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 06:13:45-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house]
20120330 06:19:37-!- vultraz_laptop [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120330 06:31:21-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20120330 06:36:54-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection]
20120330 06:40:17-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120330 06:55:09-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120330 07:23:53-!- avrilfanomar [~omar@91.202.129.150] has quit [Ping timeout: 265 seconds]
20120330 07:26:22-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120330 07:26:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120330 07:40:04-!- avrilfanomar [~omar@91.202.129.131] has joined #wesnoth-dev
20120330 07:43:40-!- faryshta [~faryshta@201.137.115.113] has quit [Ping timeout: 244 seconds]
20120330 07:56:06-!- faryshta [~faryshta@201.137.115.113] has joined #wesnoth-dev
20120330 07:56:25-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 260 seconds]
20120330 07:56:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20120330 07:56:55-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20120330 07:59:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 08:02:14-!- faryshta [~faryshta@201.137.115.113] has quit [Ping timeout: 245 seconds]
20120330 08:04:18-!- faryshta [~faryshta@201.137.115.113] has joined #wesnoth-dev
20120330 08:08:47-!- frank4591 [~funfrank4@175.100.168.197] has joined #wesnoth-dev
20120330 08:11:09< faryshta> http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/faryshta/12001
20120330 08:11:41-!- micole [~micole@unaffiliated/micole] has quit [Ping timeout: 250 seconds]
20120330 08:13:03-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev
20120330 08:15:55-!- neXyon [~neXyon@84-119-56-42.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120330 08:18:17-!- SeattleDad [322e753f@gateway/web/freenode/ip.50.46.117.63] has joined #wesnoth-dev
20120330 08:20:47< SeattleDad> Hi, I'm trying to get Wesnoth running on XCode.  Wondering if you could help.
20120330 08:23:42-!- Netsplit *.net <-> *.split quits: iwaim, Gallaecio, noy, crimson_penguin
20120330 08:23:45< vultraz> SeattleDad: compiling it?
20120330 08:33:17-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20120330 08:33:17-!- Upth is now known as Upthorn
20120330 08:39:27-!- neXyon [~neXyon@84-119-56-42.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20120330 08:43:16-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 08:43:17-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 08:43:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 08:44:42-!- Netsplit over, joins: crimson_penguin
20120330 08:49:27-!- bloodycoin [~bloodycoi@193.170.133.174] has quit [Read error: Operation timed out]
20120330 08:52:36-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 08:54:46-!- Cookie503 [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 08:55:45< faryshta> Where are the functions to recall declared (c++) ?
20120330 08:58:02-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 252 seconds]
20120330 09:00:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20120330 09:00:15-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 09:00:16-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 09:00:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 09:00:32-!- avrilfanomar [~omar@91.202.129.131] has left #wesnoth-dev []
20120330 09:01:02-!- Aethaeryn is now known as LRonHubbard
20120330 09:01:51-!- LRonHubbard is now known as Aethaeryn
20120330 09:02:35-!- frank4591 [~funfrank4@175.100.168.197] has left #wesnoth-dev []
20120330 09:21:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 09:28:07-!- Cookie503 [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Linkinus - http://linkinus.com]
20120330 09:28:09-!- mjs-de [~mjs-de@f053190198.adsl.alicedsl.de] has joined #wesnoth-dev
20120330 09:45:51-!- bloodycoin [~bloodycoi@193.170.124.203] has joined #wesnoth-dev
20120330 09:52:21-!- bloodycoin [~bloodycoi@193.170.124.203] has quit [Ping timeout: 248 seconds]
20120330 09:57:33-!- iwaim [~iwaim@124.146.179.9] has joined #wesnoth-dev
20120330 10:12:04-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120330 10:12:28-!- hankerspace [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev
20120330 10:15:59-!- enchilado [~enchilado@219-88-25-96.dialup.xtra.co.nz] has joined #wesnoth-dev
20120330 10:15:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20120330 10:16:04-!- stikonas_ [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 10:16:04-!- stikonas_ [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 10:16:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 10:18:00-!- enchilado [~enchilado@219-88-25-96.dialup.xtra.co.nz] has quit [Changing host]
20120330 10:18:00-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20120330 10:28:23-!- bloodycoin [~bloodycoi@193.170.124.203] has joined #wesnoth-dev
20120330 10:33:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120330 10:34:05-!- stikonas_ [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 10:34:05-!- stikonas_ [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 10:34:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 10:37:35-!- micole [~micole@unaffiliated/micole] has joined #wesnoth-dev
20120330 10:43:38-!- micole [~micole@unaffiliated/micole] has quit [Ping timeout: 252 seconds]
20120330 10:44:39-!- bloodycoin [~bloodycoi@193.170.124.203] has quit [Ping timeout: 260 seconds]
20120330 10:48:14-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120330 11:07:31< faryshta> Where are the functions to recall declared (c++) ?
20120330 11:17:24< faryshta> shadowm, you there?
20120330 11:36:03-!- mjs-de [~mjs-de@f053190198.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds]
20120330 11:36:29-!- bloodycoin [~bloodycoi@193.170.124.203] has joined #wesnoth-dev
20120330 11:48:41-!- mjs-de [~mjs-de@g224187165.adsl.alicedsl.de] has joined #wesnoth-dev
20120330 11:50:06-!- bloodycoin [~bloodycoi@193.170.124.203] has quit [Ping timeout: 260 seconds]
20120330 11:54:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120330 12:02:40-!- MeccaGod [majs@host189-199.bornet.net] has joined #wesnoth-dev
20120330 12:13:48< faryshta> guys
20120330 12:13:53< Rhonda> girls
20120330 12:14:56< faryshta> Who can help me to find where the recall and recruit functions are declared?
20120330 12:23:29-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120330 12:24:39-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120330 12:39:42-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120330 12:48:48-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 12:56:35-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120330 13:05:52-!- Cookie503 [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 13:09:54-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 272 seconds]
20120330 13:16:13-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev
20120330 13:19:02-!- uzyszkodnik [~uzyszkodn@aene66.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20120330 13:20:33< uzyszkodnik> hello is there a way to join a string map or should i write my own?
20120330 13:24:56-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Remote host closed the connection]
20120330 13:33:50-!- enchilad1 [~enchilado@219-88-25-96.dialup.xtra.co.nz] has joined #wesnoth-dev
20120330 13:33:52-!- enchilad1 [~enchilado@219-88-25-96.dialup.xtra.co.nz] has quit [Changing host]
20120330 13:33:52-!- enchilad1 [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20120330 13:34:40-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Disconnected by services]
20120330 13:34:43-!- enchilad1 is now known as enchilado
20120330 13:35:23-!- bloodycoin [~bloodycoi@193.170.124.203] has joined #wesnoth-dev
20120330 13:41:50-!- vultraz_laptop [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds]
20120330 13:43:00-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 13:43:14< fendrin_> faryshta: Search for them in menu_events
20120330 13:43:47-!- Cookie503 [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 252 seconds]
20120330 13:44:18< vultraz> fendrin_: can the items tool image just be like a cube?
20120330 13:45:33< fendrin_> vultraz: yes, i think so
20120330 13:46:21< fendrin_> uzyszkodnik: How would one join a string map? There is no order defined in a map, is it?
20120330 13:48:06-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Linkinus - http://linkinus.com]
20120330 13:48:20-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 13:49:45< uzyszkodnik> fendrin_:i was thinking about somthing like {key1,value1}{key2,value2} etc
20120330 13:50:36< uzyszkodnik> fendrin_:this can be acquired by iterating through map
20120330 13:51:04< fendrin_> uzyszkodnik: Sure, but that is only possible if your key class has some type of natural order defined on it. Otherwise you will not be able to sort them and call one of them the first or one of them the second key.
20120330 13:51:53-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20120330 13:52:13-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20120330 13:52:13-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev
20120330 13:54:05< uzyszkodnik> fendrin_:thats right but i'm thinking about map<string,string> which should allow me to do that
20120330 13:57:20-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Excess Flood]
20120330 13:57:32< fendrin_> uzyszkodnik: Yeah, but does the iterator provide the sorting?
20120330 13:58:08< fendrin_> uzyszkodnik: By just iterating over the map the order is more or less random, or maybe defined by when the items entered the map.
20120330 13:58:23< fendrin_> uzyszkodnik: I just want to ask what exactly you want to do. 
20120330 13:59:38< fendrin_> uzyszkodnik: You may want to use a different data structure. I remember that there is some sort of sorted map in java. The c++ stl will have something similar. Choosing the right datastructure is half the coding.
20120330 13:59:55-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev
20120330 14:02:04< uzyszkodnik> fendrin_: i'm coing Add possibility to give reason for "ignore" from the easy coding and i thought i'll save the reasons in a map[nick]=reason, so
20120330 14:02:04< uzyszkodnik> i need a way to save it later by the config class and by what i've seen in the code people use to save date as strings with it, 
20120330 14:02:04< uzyszkodnik> so i want to convert my map into a string for saving
20120330 14:02:08-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev
20120330 14:02:34< uzyszkodnik> *save data
20120330 14:03:57< vultraz> fendrin_: attempt 1 of items button: http://imagebin.org/205978
20120330 14:04:12-!- bloodycoin [~bloodycoi@193.170.124.203] has quit [Ping timeout: 252 seconds]
20120330 14:04:23< vultraz> yea, I know the black border has to be a different color
20120330 14:04:54-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120330 14:05:17< fendrin_> vultraz: Can you invert it? I mean the perspective. The foreground square to the left and the background to the right.
20120330 14:06:10-!- bloodycoin [~bloodycoi@193.170.124.203] has joined #wesnoth-dev
20120330 14:07:17< fendrin_> uzyszkodnik: I don't now about "ignor" from the easy coding page. But you could provide a link for me. In general, we save everything in WML.
20120330 14:08:27< vultraz> fendrin_: http://imagebin.org/205980
20120330 14:09:01-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120330 14:10:46< uzyszkodnik> fendrin_: https://gna.org/bugs/?16001
20120330 14:12:30< uzyszkodnik> fendrin_: the saving of the ignores list in the code looks like this http://devdocs.wesnoth.org/game__preferences_8cpp_source.html#l00213
20120330 14:12:58< fendrin_> vultraz: Much better :-)
20120330 14:13:42< vultraz> :)
20120330 14:13:53< vultraz> now to deal with the black border
20120330 14:15:15-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Quit: BBL->]
20120330 14:23:04< fendrin_> uzyszkodnik: Have you had a look at the code for the current ignore list? It might be easier to just make the current user into a pair of (user, reason) and keep most of the code around it as it is.
20120330 14:23:32< fendrin_> uzyszkodnik: Saying that without having had a look at the current ignore list implementation myself.
20120330 14:25:19< vultraz> fendrin_: http://imagebin.org/205983 done?
20120330 14:25:48< vultraz> it's the same palette as the soundsource one for consistency 
20120330 14:27:04< fendrin_> vultraz: Yeah, it's fine enough for the first thing, at least for me. But I am not an artist. Might be that it will have to be redone later but I am glad to have your work for now.
20120330 14:27:42< vultraz> :D I'll post it on the forum
20120330 14:27:45< vultraz> now
20120330 14:29:17< fendrin_> Thank you very much :-)
20120330 14:30:12< vultraz> actually, lemme see if I can add a shadow first
20120330 14:34:06-!- Ayne [5eae91ee@gateway/web/freenode/ip.94.174.145.238] has joined #wesnoth-dev
20120330 14:35:47< uzyszkodnik> fendrin_:hmm but  from what i see it still would require me to write a way to convert it into a string tho this way i'd need it to do on set<pair<string,string>>
20120330 14:35:48< CIA-69> fendrin * r53694 /trunk/src/ (12 files in 5 dirs): Map editor code cleanups.
20120330 14:36:46< fendrin_> uzyszkodnik: Please point me to the code in question.
20120330 14:37:06< fendrin_> vultraz: Would you test my latest commit?
20120330 14:37:18< vultraz> ok
20120330 14:37:24-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Ping timeout: 244 seconds]
20120330 14:38:19< fendrin_> vultraz: There is not much extra functionality (beside the map labels and the units which can only selected but not placed for now) but most of the editor should work again like before and all the palettes are in a good state now.
20120330 14:40:08 * vultraz builds
20120330 14:41:04< uzyszkodnik> fendrin_: saving is done this way http://devdocs.wesnoth.org/game__preferences_8cpp_source.html#l00213 , initalizing  - http://devdocs.wesnoth.org/game__preferences_8cpp_source.html#l00213. ignores list is defined here http://devdocs.wesnoth.org/game__preferences_8cpp_source.html#l00050
20120330 14:42:50< vultraz> hum....seems the shadow makes the image too dark
20120330 14:43:27-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120330 14:43:28< uzyszkodnik> fendrin_: so i still need a write a custom code for converting the data type into a string 
20120330 14:44:15< fendrin_> uzyszkodnik: Okay, looks like the ignore list is a single string argument to a wml attribute, right?
20120330 14:45:02< uzyszkodnik> fendrin_: yes
20120330 14:45:45< fendrin_> uzyszkodnik: That means you will either need to define some syntay like "(user,reason),(nextuser, andhisreason)...."
20120330 14:46:05< fendrin_> or user,reason;nextuser,andhisreason;...
20120330 14:46:55-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Excess Flood]
20120330 14:47:55-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev
20120330 14:48:00< fendrin_> uzyszkodnik: changing the signature of add ignore to "bool add_ignore(std::pair<const std::string& nick, const std::string& reason)" would be a solution.
20120330 14:48:08< vultraz> ima go with the no-shadow version
20120330 14:49:10< fendrin_> uzyszkodnik: Another thing could be to save each of the banned users in his own wml tag into the preferences file. That would be much more flexible.
20120330 14:49:49< fendrin_> [ban] userid= reason= date= and more maybe 
20120330 14:50:37< fendrin_> uzyszkodnik: Thus my suggestion is: Think about WML syntax first, then think about the c++ implementation.
20120330 14:52:12< uzyszkodnik> fendrin_: ok, thank you i'll try going with wml syntax then
20120330 14:53:00-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Read error: Connection reset by peer]
20120330 14:53:01< fendrin_> uzyszkodnik: Just have a look how the preferences file looks currently and how it is done. 
20120330 14:54:28< fendrin_> uzyszkodnik: And for handling the production of the strings we have those utils::join and split methods.
20120330 14:55:06< fendrin_> uzyszkodnik: I think they can also be used with iterators thus they could merge maps, if you still want to go with that internal data structure.
20120330 14:55:54-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 246 seconds]
20120330 14:55:58< fendrin_> uzyszkodnik: If you have an idea about how your wml syntax should look like, ask zookeeper and/or shadowm, they are the experts on wml syntax.
20120330 14:59:30< uzyszkodnik> fendrin_: i'd like to know first what is it capable of doing, i guess i should check the config class am i right?
20120330 15:02:00-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 15:08:08-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20120330 15:12:22-!- uzyszkodnik [~uzyszkodn@aene66.neoplus.adsl.tpnet.pl] has quit [Read error: Connection reset by peer]
20120330 15:14:27< vultraz> fendrin_: posted complete set: http://forums.wesnoth.org/viewtopic.php?p=525155#p525155
20120330 15:17:22-!- IvanSav [~IvanSav@ns2.ultranet.com.ua] has joined #wesnoth-dev
20120330 15:17:48< fendrin_> vultraz: Thanks. Is your build complete?
20120330 15:18:32< vultraz> nope. taking forever because of the hotkeys.cpp update ;)
20120330 15:18:52< vultraz> 139/165
20120330 15:20:39-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Quit: leaving]
20120330 15:24:34< vultraz> ok, build done :)
20120330 15:24:46-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20120330 15:28:32< vultraz> fendrin_: don't notice any problems
20120330 15:29:38< vultraz> :)
20120330 15:31:09-!- Crab____ [Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20120330 15:32:17< fendrin_> hi Crab____
20120330 15:32:23< Crab____> hi
20120330 15:32:32< fendrin_> vultraz: Good to hear. Thanks for testing it.
20120330 15:32:54< Crab____> fendrin_: I'm just here for a second, disappearing now, will be later today.
20120330 15:32:59-!- Crab____ [Crab_@wesnoth/developer/crab] has quit [Client Quit]
20120330 15:33:10< fendrin_> vultraz: It's taking forever because of the hotkeys.hpp not the cpp.
20120330 15:34:07-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Linkinus - http://linkinus.com]
20120330 15:34:10< vultraz> ah
20120330 15:34:18-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20120330 15:34:20-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 15:36:33-!- esr [~chatzilla@wesnoth/developer/esr] has quit [Remote host closed the connection]
20120330 15:39:16-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120330 15:39:16< fendrin_> vultraz: The hotkeys.hpp is included everywhere, thus leading to a nearly complete rebuild.
20120330 15:41:01< vultraz> ah. explains it
20120330 15:41:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120330 15:41:43< vultraz> fendrin_: I'm also trying to work on some terrain group-style icons for the unit groups :)
20120330 15:42:12< vultraz> unfortunately, only undead and part of elves are done
20120330 15:42:28< boucman> hey all
20120330 15:42:44< vultraz> hey
20120330 15:45:57< boucman> gabba: you pinged me ?
20120330 15:46:25< fendrin_> boucman: hi
20120330 15:46:39< fendrin_> vultraz: can you already show them?
20120330 15:48:35-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev
20120330 15:53:09-!- Akihara [~Klyto@dr.lv0.in] has joined #wesnoth-dev
20120330 15:53:21-!- Ayne [5eae91ee@gateway/web/freenode/ip.94.174.145.238] has quit [Quit: Page closed]
20120330 15:54:34< Akihara> Hi everyone, I would like to apply for GSoc :)
20120330 15:56:09-!- Johannes13 [~Johannes@p4FDEE4E2.dip.t-dialin.net] has joined #wesnoth-dev
20120330 15:56:09-!- Johannes13 [~Johannes@p4FDEE4E2.dip.t-dialin.net] has quit [Changing host]
20120330 15:56:09-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20120330 16:05:16< Rhonda> See topic ;)
20120330 16:05:44< Rhonda> And you apply through melange, the gsoc interface from google, not in here. ;)
20120330 16:08:10< Akihara> I already applied through melange
20120330 16:09:39< Akihara> o I came to introduce myself, that's all
20120330 16:09:50< gabba> boucman: I pinged you because you pinged me :P
20120330 16:12:58-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120330 16:18:19-!- bloodycoin [~bloodycoi@193.170.124.203] has quit [Ping timeout: 246 seconds]
20120330 16:19:06< vultraz> fendrin_: http://imagebin.org/205999 (Undead) it's the only one that's done; just a recolor of the poison icon
20120330 16:19:19< vultraz> I'm in the middle of Elves
20120330 16:22:20< fendrin_> vultraz: Okay, but I see a little problem with this. The current "solution" works for every user made unit set. But with buttons there needs to be one for every race.
20120330 16:22:48< fendrin_> And I might implement sorting them by other groups as well.
20120330 16:23:04-!- Crab_ [Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20120330 16:23:06< fendrin_> Like faction.
20120330 16:23:19< Crab_> Akihara: hello
20120330 16:23:37< Akihara> Crab_: hello
20120330 16:24:40< Crab_> Akihara: if you have any questions about GSoC, or if you want to know how we select students, you're welcome to ask
20120330 16:26:20< Akihara> Crab_: Thanks :) 
20120330 16:27:17< Crab_> and, you've said that you've applied through melange - can you tell me your melange username, so I'll be able to know that this is you? (I don't see Akihara mentioned as an IRC nickname in any of the proposals)
20120330 16:28:37< Espreon> faryshta: grep is your friend.
20120330 16:28:39< boucman> gabba: hehe
20120330 16:28:51< boucman> yes, I think there was a patch for you in the queue...
20120330 16:28:57< boucman> but I think you saw it since
20120330 16:34:43-!- Espreon [~espreon@wesnoth/developer/espreon] has quit [Remote host closed the connection]
20120330 16:34:43-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Remote host closed the connection]
20120330 16:34:43-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection]
20120330 16:34:43-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Read error: Connection reset by peer]
20120330 16:35:50-!- Crab_ [Crab_@wesnoth/developer/crab] has quit [Quit: Crab_]
20120330 16:38:07< fendrin_> wesbot: seen noy?
20120330 16:38:08< wesbot> fendrin_: The person with the nick noy last spoke 1d 8h ago.  4h 43m ago was here and on the channels #wesnoth and #wesnoth-umc-dev with the message: Quit: noy
20120330 16:38:18-!- Espreon [~espreon@wesnoth/developer/espreon] has joined #wesnoth-dev
20120330 16:39:01< gabba> ejls: around?
20120330 16:40:26-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has quit [Quit: Konversation terminated!]
20120330 16:42:30-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev
20120330 16:47:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120330 16:48:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 16:52:10< vultraz> fendrin_: hum....not sure I get what you mean
20120330 16:54:37-!- Jozrael [~croselius@209.133.52.231] has joined #wesnoth-dev
20120330 17:02:51< fendrin_> vultraz: Currently the units are grouped by their races. But that is only one possibility to group them. I could group them by their level, by factions, by alignments, and so on.
20120330 17:04:31< fendrin_> vultraz: Also, every UMC author needs to provide a new button if he introduces a new race.
20120330 17:05:43-!- micole [~micole@unaffiliated/micole] has joined #wesnoth-dev
20120330 17:07:33< ejls> ejls: yes
20120330 17:07:40< ejls> gabba: Hi.
20120330 17:07:49 * ejls answer to himself.
20120330 17:14:27< vultraz> fendrin_: ah. yeah.
20120330 17:14:36< vultraz> not very....practical
20120330 17:14:45< vultraz> but maybe there could be a fallback?
20120330 17:15:54< vultraz> like maybe use the current system (scaled unit image) if no button is supplied?
20120330 17:20:07< fendrin_> vultraz: Hmm, yeah. But I do not like the idea of merged icon styles. The whole interface needs a rethinking. 
20120330 17:21:23< vultraz> fendrin_: should I put off the unit group buttons until you get the interface down pat?
20120330 17:21:39< fendrin_> vultraz: yeah
20120330 17:21:54< vultraz> ok
20120330 17:23:21< vultraz> fendrin_: so, do you have any other editor-related art stuff you need?
20120330 17:23:55-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120330 17:23:57< fendrin_> vultraz: Yes, mouse overlays. Or did you already draw them?
20120330 17:24:24-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120330 17:24:37< vultraz> oh, the ones that appear inside the brush?
20120330 17:24:45< vultraz> when the tool is selected?
20120330 17:25:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120330 17:25:49< fendrin_> yes
20120330 17:27:39< gabba> noy: in case you read the log, the multiple CTK idea is mine's and boucman's... it's one of the features that got cut from the original whiteboard project because there was so much else to do.
20120330 17:28:19< gabba> Noy ^^ if you search for your name with the capital letter :P
20120330 17:28:46-!- SeattleDad [322e753f@gateway/web/freenode/ip.50.46.117.63] has quit [Ping timeout: 245 seconds]
20120330 17:30:05< gabba> ejls: I assume you checked if your patch compiled, but did you test it to see if it worked and nothing broke?
20120330 17:32:43< ejls> Hum, I tried to reproduce the bug after applying it
20120330 17:33:16< ejls> And I'm playing with the patch applied since… why do you find a problem?
20120330 17:33:44-!- Crab_ [~Crab___@nat4-10.ghnet.pl] has joined #wesnoth-dev
20120330 17:35:19-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120330 17:35:34-!- micole [~micole@unaffiliated/micole] has quit [Ping timeout: 245 seconds]
20120330 17:36:07-!- timotei [~timotei@188.24.4.67] has joined #wesnoth-dev
20120330 17:36:07-!- timotei [~timotei@188.24.4.67] has quit [Changing host]
20120330 17:36:07-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20120330 17:38:12-!- micole [~micole@unaffiliated/micole] has joined #wesnoth-dev
20120330 17:38:14-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120330 17:42:35< CIA-69> fendrin * r53695 /trunk/src/ (5 files in 3 dirs): 
20120330 17:42:35< CIA-69> Reenabled the select terrain from map feature.
20120330 17:42:35< CIA-69> More code cleanups.
20120330 17:43:19-!- micole [~micole@unaffiliated/micole] has quit [Ping timeout: 264 seconds]
20120330 17:44:37-!- liviuc [~liviu@p5.eregie.pub.ro] has joined #wesnoth-dev
20120330 17:44:38< CIA-69> anonymissimus * r53696 /branches/1.10/projectfiles/CodeBlocks/README.txt: 
20120330 17:44:38< CIA-69> add a note to README about -march=native
20120330 17:44:38< CIA-69> backported from trunk r53393
20120330 17:44:46-!- liviuc [~liviu@p5.eregie.pub.ro] has left #wesnoth-dev []
20120330 17:44:55< CIA-69> anonymissimus * r53697 /branches/1.10/src/unit.cpp: 
20120330 17:44:55< CIA-69> Fix usage of invalid iterators in [effect]apply_to=remove_attacks.
20120330 17:44:55< CIA-69> Revealed (not introduced) by r53470, causing the debugger to crash.
20120330 17:44:55< CIA-69> backported from trunk r53549
20120330 17:48:42< vultraz> fendrin_: not sure why, but when you made the first editor update (when we had 72,72 terrain tiles and no scrolling) the interface seemed a lot more elegant
20120330 17:49:05< gabba> ejls: nope, no problem - it's just that I'm not on my dev machine but I'd like to commit the patch
20120330 17:49:40< gabba> The code looks good and error-free, but I wanted to make sure you tested it sufficiently - you never know
20120330 17:52:04-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 252 seconds]
20120330 17:54:58< CIA-69> crab * r53698 /trunk/ (changelog data/core/about.cfg src/dialogs.cpp): Fixed bug #19538: Filters matching 0 saved games cause crash. Patch #3220 by trademark
20120330 17:56:45< fendrin_> vultraz: Yeah, I was fine with it as well. :-)
20120330 17:59:04-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120330 17:59:58< vultraz> fendrin_: well, shadowm did have a point about the extreme small size teh icons could get
20120330 17:59:58< vultraz> but I'm not sure, the interface seems to be not as nice, and not just because of that
20120330 18:00:36< CIA-69> gabba * r53699 /trunk/src/ (mouse_events.cpp whiteboard/manager.cpp): Fix bug #19581 (Leader can move after a planned recall). Recall and recruit are now treated the same way by the whiteboard when considering moving leaders. Patch #3201 by ejls.
20120330 18:02:42-!- jamit [~james@pool-173-61-168-180.cmdnnj.east.verizon.net] has joined #wesnoth-dev
20120330 18:10:02< gabba> Ivanovic: what's the policy on backporting patches with changes to translatable strings to the stable branch?
20120330 18:10:52-!- fendrin_ [~fabi@88-134-16-3-dynip.superkabel.de] has quit [Remote host closed the connection]
20120330 18:11:45-!- uzyszkodnik [~uzyszkodn@aene66.neoplus.adsl.tpnet.pl] has joined #wesnoth-dev
20120330 18:12:25-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20120330 18:12:31-!- fendrin [~fabi@88-134-16-3-dynip.superkabel.de] has joined #wesnoth-dev
20120330 18:12:31-!- fendrin [~fabi@88-134-16-3-dynip.superkabel.de] has quit [Changing host]
20120330 18:12:31-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20120330 18:13:26< anonymissimus> jamit: music is always determined by the scenario wml; so race-dependent music should be long gone
20120330 18:13:54-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 245 seconds]
20120330 18:14:05< anonymissimus> unless the scenario actually sets it to be like that but none of our MP scenario do it and just in case it can easily be fixed
20120330 18:14:27< anonymissimus> (everything fixable wml-only counts as easy)
20120330 18:14:28< jamit> That's what I began to suspect once I realized has_seen() was never called.
20120330 18:14:58-!- bloodycoin [~bloodycoi@193.170.134.219] has joined #wesnoth-dev
20120330 18:18:37< jamit> Just checked the SVN history. team::has_seen() was added by boucman way back in December 2005 (revision 9105), which happens to fit the timeline of those two bugs.
20120330 18:18:56< boucman> wesbot log 9105
20120330 18:18:57< wesbot> boucman * r9105 : add anonymous music for unknown teams
20120330 18:18:57< wesbot> URL: http://svn.gna.org/viewcvs/wesnoth?view=rev&rev=9105
20120330 18:19:28< boucman> mkay... so it's music related, I though it was about the unknown leader, but there probably is something else for that
20120330 18:20:03< jamit> Maybe the leader is not shown in that window unless the leader itself is seen?
20120330 18:20:16< boucman> probably, yes
20120330 18:23:12-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 18:26:13-!- Ceres [6d6d0707@gateway/web/freenode/ip.109.109.7.7] has joined #wesnoth-dev
20120330 18:31:18-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120330 18:31:51-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120330 18:35:40-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Excess Flood]
20120330 18:36:55-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev
20120330 18:40:10< gabba> boucman: do you know if I can backport my latest commit to 1.10 now? It changes one translateable string, but it's a pretty important fix.
20120330 18:40:51< boucman> gabba: IIRC we are not in string freeze, but Ivanovic is the authority in that regard
20120330 18:41:49< gabba> boucman: sure, I'm basically asking what's common practice... I'm not used to have a recent stable version around :P
20120330 18:42:35< boucman> 1) no compatibility break (i.e 1.10.0 should be network+savegame compatible with 1.10.1)
20120330 18:42:43< boucman> 2) respect the string freeze as usual
20120330 18:42:55< boucman> 3) no new features unless it fixes a critical bug
20120330 18:43:04< boucman> everything else is on your jugement
20120330 18:47:33< anonymissimus> Ivanovic recently backported a new string from a revision of mine; so some notification for both would be ok
20120330 18:49:05< anonymissimus> Crendgrim: so you got green as well now!? gratz
20120330 18:50:16-!- nagafono [~kvirc@178.19.254.1] has joined #wesnoth-dev
20120330 18:50:55< Crendgrim> anonymissimus: yeah, an evil shadowlord transformed me into a frog.
20120330 18:52:38< vultraz> Crendgrim: I see. Then where's the princess that will change you back
20120330 18:52:41< vultraz> ;)
20120330 18:53:23< Crendgrim> vultraz: still hope to meet her :p
20120330 18:53:30-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 18:53:30-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 18:53:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 18:57:07 * anonymissimus wishes a nice princess for Crendgrim
20120330 18:57:12-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev
20120330 18:57:42< Crendgrim> ;) thanks
20120330 18:58:14< anonymissimus> Crab_: how many GSoC students do you plan to mentor ? xD
20120330 19:03:03< uzyszkodnik> btw how many spots for GSoC students have you got? 
20120330 19:03:53-!- nagafono [~kvirc@178.19.254.1] has quit [Quit: KVIrc 4.1.3 Equilibrium http://www.kvirc.net/]
20120330 19:04:17< boucman> uzyszkodnik: not decided yet
20120330 19:04:33< boucman> don't expect dozens, though
20120330 19:05:34-!- loonybot [~loonybot@46.138.86.26] has joined #wesnoth-dev
20120330 19:05:35-!- loonybot [~loonybot@46.138.86.26] has quit [Changing host]
20120330 19:05:35-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120330 19:06:49< uzyszkodnik> boucman: tho can you throw an approximate number? last year you had 4, are you planning to invite more or less?
20120330 19:07:12< boucman> not sure, but it will probably be more or less the same
20120330 19:08:30< uzyszkodnik> thanks
20120330 19:09:23< anonymissimus> jamit: I remove that team::seen_ now
20120330 19:09:54-!- retr0virus [~vyrm@static-213-182-110-135-teleos.ewe-ip-backbone.de] has joined #wesnoth-dev
20120330 19:10:01-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120330 19:10:33< CIA-69> anonymissimus * r53700 /trunk/src/ (actions.cpp team.cpp team.hpp): 
20120330 19:10:33< CIA-69> remove unused varible team::seen_ and related functions (+calls)
20120330 19:10:33< CIA-69> This was holding data about which side has already seen which
20120330 19:10:33< CIA-69> other side. Probably a left over thing from someone
20120330 19:10:33< CIA-69> who wanted to implement something at some spot. It also wasn't saved
20120330 19:10:34< CIA-69> in the savegames (surely needed).
20120330 19:11:32< jamit> Nice, one complication removed from the movement routines.
20120330 19:14:09< jamit> Should I create a new patch for move_unit() without those lines?
20120330 19:14:48< anonymissimus> I just remove them from the patch
20120330 19:15:03< jamit> OK
20120330 19:21:24< anonymissimus> i edit it anyway; svn to git patch type conversion etc
20120330 19:22:11-!- nagafono [~kvirc@178.19.254.1] has joined #wesnoth-dev
20120330 19:30:00< anonymissimus> jamit: from what it looks like, the whole function could be a lot less complicated without unexpected stops
20120330 19:31:11< anonymissimus> not sure about what that will be like once that DSU is based upon the wb and whether it will be known that a move is possible
20120330 19:31:14< jamit> But you need unexpected stops. Ambushers are a prime example.
20120330 19:31:18-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has quit [Quit: Konversation terminated!]
20120330 19:31:30-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev
20120330 19:31:57< anonymissimus> yup; they were probably coded at some spot to add some cool new feature and now Mp balance relies havily onto it
20120330 19:33:08< anonymissimus> but this "press t to keep moving" stuff is something the engine doesn't need for instance
20120330 19:34:57-!- neXyon [~neXyon@84-119-56-42.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120330 19:36:07< anonymissimus> and AI0867 wanted to deprecate the whole sighted event; there's a suitable workaround macro, most usages in mainline and UMC should probably be gone by now due to the warning in the wiki and so on
20120330 19:36:11< jamit> Possibly not needed anymore, but it was handy when hexes were refogged mid-turn (and you were just re-discovering what you know was there).
20120330 19:36:32< jamit> The workaround macro has its flaws still.
20120330 19:36:53< anonymissimus> it's better than the engine event in any case
20120330 19:36:56< jamit> It does not properly catch sightings due to recruitments, for one example I recall.
20120330 19:37:21< anonymissimus> which is something the engine also doesn't
20120330 19:37:22< jamit> I can fix the sighted event, by the way.
20120330 19:37:33< anonymissimus> uh oh hohoh
20120330 19:37:48< anonymissimus> if you can do that you're really earned respect
20120330 19:37:50< jamit> Whether or not it is desirable is another question, of course, ;)
20120330 19:38:14< anonymissimus> it was always buggy since years and about every mainline dev fiddled with it
20120330 19:38:33< jamit> Heh. The way I would prefer to do it involves moving a bunch of code around. Not sure if that would be seen as helpful or not.
20120330 19:39:34< jamit> Not necessary to make such drastic changes, I suppose, but it would make it easier for me to have confidence in what I do.
20120330 19:40:01< anonymissimus> you should talk with Crab_ about it; he has some plan for it
20120330 19:40:10< anonymissimus> perhaps you can execute it
20120330 19:40:17< jamit> Perhaps.
20120330 19:40:39< jamit> Is there anyone who would be working with the undo functionality?
20120330 19:41:17< jamit> One not-totally-needed change I toyed with was changing the undo list to a proper class.
20120330 19:42:52< anonymissimus> that undo list is something Crab_ wants to remove completely I think
20120330 19:42:55< jamit> Less of a priority now, though, since clearing the undo stack is no longer associated with refogging the board.
20120330 19:43:07< anonymissimus> undoing will be the same as deleting a planned move
20120330 19:43:51< jamit> Hmmm.... as a player, I think I would prefer keeping the undo function. I don't always see a need for planning mode, but I do misclick sometimes.
20120330 19:45:15< jamit> Are there problems with the undo stack, or would this just be a simplification because of the whiteboard?
20120330 19:45:16< anonymissimus> well you would harld notice a difference
20120330 19:45:34< anonymissimus> you could look for bugs assigned to Crab_ 
20120330 19:45:48< anonymissimus> the largest group of them have something to do with the whole thing
20120330 19:46:51< anonymissimus> https://gna.org/bugs/index.php?14269 https://gna.org/bugs/index.php?14269 https://gna.org/bugs/index.php?16361
20120330 19:47:17< anonymissimus> for instance, and undos were also mentioned as problematic at some points
20120330 19:48:17< anonymissimus> AFAIK the idea is to no longer move real units as the undo/redo action, but base that onto the WB
20120330 19:48:27-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev []
20120330 19:49:06< anonymissimus> and it would look like the old DSU, except for in cas something unexpected happens
20120330 19:49:28< Vino> ftp://ftp.terraninfo.net/wesnoth/msvc9/external_19.zip  <-- is this still up somewhere?
20120330 19:49:49-!- wesbot changed the topic of #wesnoth-dev to: Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 168 bugs, 328 feature requests, 18 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120330 19:50:07< Crab_> there was an alternate set on sourceforge
20120330 19:50:25< Crendgrim> Crab_: just being curious, what were the reasons for unlocking the template?
20120330 19:50:40< jamit> For scenarios with fog/shroud, I can see the WB as a replacement for undo/redo, but it seems like redo/undo is nicer on other maps.
20120330 19:51:39< Vino> in the sourceforge files? can't find it there
20120330 19:52:07< Vino> but the only thing i need is for cmake to find boost properly, on windows
20120330 19:52:13< Crab_> Crendgrim: (1) I believe (I can be wrong) that the students can't easily click 'edit' if the template is locked
20120330 19:52:48< Crab_> Crendgrim: (2) it's interesting for me to see which students break the template or other pages :)
20120330 19:53:13< Crendgrim> Crab_: regarding (1), there is a link "view source" then; I actually checked it after locking with a guest acc (other browser).
20120330 19:53:21-!- Danceman [~Danceman@a94-132-158-220.cpe.netcabo.pt] has joined #wesnoth-dev
20120330 19:53:28< Crendgrim> Crab_: but regarding (2) ... that's of course interesting. I didn't think of that
20120330 19:53:34< Crendgrim> thanks for the explanation :)
20120330 19:54:03< Crab_> Crendgrim: ok, thanks about (1), see. still, that's not the only reason :)
20120330 19:54:44< Crendgrim> yeah, sure, I didn't think of that. ;)
20120330 19:54:50< anonymissimus> Vino: I suggest to disregard MSVC+cmake since it's not used since months
20120330 19:55:00< jamit> anonymissimus: I now recall seeing bug #17948 before, but never went to see the cause.
20120330 19:55:00< Vino> :(
20120330 19:55:08< Vino> anonymissimus, scons then?
20120330 19:55:36< Vino> or these project files i see lying around?
20120330 19:55:42< anonymissimus> Vino: the (2) guide here http://wiki.wesnoth.org/CompilingWesnothOnWindows
20120330 19:55:51< anonymissimus> is most up to date
20120330 19:56:05< Vino> the ftp links are down on that page
20120330 19:56:15< Crab_> Vino: I still have the external_19.zip, if you would need it and if you can download today or early tomorrow.
20120330 19:56:15< Vino> and uh, it says to use cmake
20120330 19:56:33< Vino> i can download it right now :)
20120330 19:57:03< Crab_> crab.terraninfo.net/data/misc/external_19.zip
20120330 19:57:23< Vino> wonderful! :D
20120330 19:57:25< anonymissimus> those links all work for me
20120330 19:57:57< Vino> strange. it must be broken for me only
20120330 19:58:13< Crab_> anonymissimus: for me, the FTP is up as of now (that would change tomorrow, actually, as I'm moving servers)
20120330 19:58:40< anonymissimus> and last checked sept 2010; forget it
20120330 19:58:59< anonymissimus> perhaps the lib zaroth added is still missing
20120330 19:59:06< Vino> so use method number 2?
20120330 19:59:25< anonymissimus> yes
20120330 19:59:30< Vino> works for me
20120330 20:00:42< Vino> Crab_, you maintain these project files?
20120330 20:01:38< Crab_> as of now, no. I used to, since there were gsoc students in previous year who had trouble compiling on windows. for now, it seems that there were no major problems, so far.
20120330 20:02:18< Vino> how do you build on windows now?
20120330 20:03:19< Crab_> I don't. my main development system is gnu/linux (I have windows and mac laptops on my desk, but I'm only using linux for development).
20120330 20:04:34< Vino> understood.
20120330 20:06:27< anonymissimus> AI0867: the sighted event was never "informally deprecated" AFAIK
20120330 20:11:00< jamit> anonymissimus, Crab_: I believe https://gna.org/bugs/index.php?17948 is fixed with my refactoring of move_unit().
20120330 20:11:48< jamit> Either that or it was fixed some time since 1.10 was released....
20120330 20:11:57< Crab_> jamit: how you've changed move_unit?
20120330 20:12:21< Crab_> jamit: or tell the commit #, and I'll take a look myself
20120330 20:12:33< jamit> https://gna.org/patch/?3133
20120330 20:13:35< Crab_> well, the problem (in most general form) won't be fixed if delayed shroud updates still exists
20120330 20:13:59< Crab_> but the conrete form mentioned in the bug might be fixed, yes.
20120330 20:14:48< jamit> DSU probably could be made to work if toggles of it got saved in the replays, which would mean saving them in the undo stack as well, I believe.
20120330 20:14:58-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120330 20:15:23< jamit> But I understand you (the team) have had problems with it and you are looking forward to replacing it with the WB.
20120330 20:15:44-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120330 20:15:58< jamit> For fogged/shrouded maps, I would agree the WB looks better than DSU.
20120330 20:18:18< Crab_> no, not exactly
20120330 20:18:30< Crab_> I plan to change the implementation of DSU to be based on WB
20120330 20:18:43< Crab_> while keeping the DSU interface
20120330 20:19:36< jamit> Sort of like DSU turns on the WB without looking like it turned on the WB?
20120330 20:20:09< Crab_> yes
20120330 20:21:26< jamit> That does appear to be a more reliable approach than making the current DSU work.
20120330 20:21:29-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20120330 20:21:35< jamit> First impressions, at least.
20120330 20:21:44< mordante> servus
20120330 20:21:58< mordante> vultraz, you were looking for me?
20120330 20:22:10-!- neXyon [~neXyon@84-119-56-42.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20120330 20:22:22< vultraz> mordante: :D yes, I was. 
20120330 20:22:43< vultraz> do you have any idea how to change pages in a multipage widget?
20120330 20:22:57< vultraz> lua-wise
20120330 20:23:02< mordante> no no idea
20120330 20:23:59< anonymissimus> jamit: it actually does, though I don't understand why :P
20120330 20:25:06< mordante> fendrin, I get compilation errors in src/editor/palette/terrain_palettes.cpp, guess it's your commit
20120330 20:25:39-!- Jozrael [~croselius@209.133.52.231] has quit [Ping timeout: 252 seconds]
20120330 20:27:16< mordante> fendrin, I'll commit a fix, but I just wonder whether the code is compile tested
20120330 20:28:22< CIA-69> mordante * r53702 /trunk/src/editor/palette/terrain_palettes.cpp: Remove an unused function.
20120330 20:28:27< CIA-69> mordante * r53701 /trunk/src/editor/palette/terrain_palettes.cpp: Fix a compilation error.
20120330 20:28:33< Ivanovic> hi
20120330 20:28:37< mordante> hi Ivanovic 
20120330 20:28:51-!- Ivanovic changed the topic of #wesnoth-dev to: 1.10.2 planned for April 6th | Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 168 bugs, 328 feature requests, 18 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120330 20:29:57< Ivanovic> gabba: the policy on backporting string changes is to do them ASAP after a new stable release as possible
20120330 20:30:24< Ivanovic> you know, your timing is in fact rather bad since i wanted to release next friday and i promised translators at least 7 days between announcing and tagging
20120330 20:30:37< Ivanovic> and i would have tagged early on the morning since i am away from the afternoon onwards...
20120330 20:34:20-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev
20120330 20:35:35< hankerspace> Hi Crab_, i'm working on a patch for a minimum duration for a message and while a pointer test i have a warning : src/events.cpp||In function ‘void events::pump(bool*)’:|
20120330 20:35:35< hankerspace> NULL utilisé en arithmétique [-Wpointer-arith]| ... My instruction : if((*inhibits_mouseclick)==NULL) ...
20120330 20:35:42< fendrin> mordante: Yes, it is. My setup is doing fine. I wonder what you use, seeing that you are busy cleaning after me all the time.
20120330 20:36:07< Crab_> hankerspace: hello
20120330 20:36:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20120330 20:36:50< mordante> fendrin, src/editor/palette/terrain_palettes.cpp:65:2: error: ‘template<class Item> class editor::editor_palette’ used without template parameters
20120330 20:37:18< mordante> IIRC that's ill-formed code and should be rejected by the compiler
20120330 20:37:29< mordante> (too lazy to look it up in the standard)
20120330 20:37:56< Crab_> hankerspace:  use "   if (!*inhibits_mouseclick)  " instead ? but, copypaste the code fragment to pastebin to let me see, if it'd not help.
20120330 20:38:22< hankerspace> Ok Crab_ i'll paste it
20120330 20:39:13< hankerspace> http://pastebin.com/8JNATPdX
20120330 20:40:10< Crab_> hankerspace: inhibits_mouseclick is bool*
20120330 20:40:19< Crab_> hankerspace: *inhibits_mouseclick is bool
20120330 20:40:31< hankerspace> Yes, it's my new variable Crab_
20120330 20:40:32< Crab_> hankerspace: the code is trying to compare bool with NULL
20120330 20:40:39< fendrin> mordante: The code did compile for vultraz as well, do you use gcc?
20120330 20:40:48< Crab_> hankerspace: to do that, it casts the NULL to 0, which produces a warning.
20120330 20:40:49< mordante> fendrin, yes
20120330 20:41:10< hankerspace> Oh yes, i'm stupid i have to test the pointer ...
20120330 20:41:15< Crab_> hankerspace: exactly
20120330 20:41:21< fendrin> I should switch to more strict compiling options.
20120330 20:41:33< hankerspace> Thanks Crab_
20120330 20:41:43< mordante> fendrin, gcc-4.4 fails even with normal flags, testing 4.5 now
20120330 20:41:44< Crab_> hankerspace: but the warning comes from the compiler trying to cast the NULL to 0, so it'd be comparable with bool value from your dereferenced pointer.
20120330 20:41:47< fendrin> mordante: What is your setup? Do you build with scons or cmake or x?
20120330 20:42:09< mordante> cmake, but that shouldn't matter, I'm quite sure the code is wrong
20120330 20:42:43< fendrin> mordante: 4.6.3 is my gcc version
20120330 20:42:46< hankerspace> Yes, i understand Crab_, this warning was so obvious ..
20120330 20:42:48-!- vultraz [~chatzilla@124.109.10.221] has quit [Read error: No route to host]
20120330 20:43:00< mordante> ok will test 4.6.3 after 4.5.x
20120330 20:44:16< Crab_> hankerspace: also I've left some minor notes on the patch page ( https://gna.org/patch/?3215 )
20120330 20:44:23< mordante> shadowm, I'm quite sure we encourage (demand) new devs to be on IRC, at least we used to do that
20120330 20:45:30< hankerspace> Alright i'll fix my patch Crab_, is there a wiki for wesnoth's C++ dev to avoid these misstakes ?
20120330 20:45:44< shadowm> mordante: encouraging isn't the same as demanding.
20120330 20:46:02< Crab_> hankerspace: http://wiki.wesnoth.org/CodingStandards
20120330 20:46:19< mordante> shadowm, hence the demand between braces
20120330 20:46:29< shadowm> if you really meant the latter, then I've got at least two cases since 2008 where either exceptions were made or there wasn't a real "demand"
20120330 20:47:20< mordante> just curious but who do you mean?
20120330 20:47:22< shadowm> or three if I count suokko post-AI
20120330 20:47:33< shadowm> some segfault guy and now brilliand
20120330 20:47:42-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has joined #wesnoth-dev
20120330 20:48:06< mordante> I wouldn't count suokko, he used to be on IRC
20120330 20:48:29< mordante> indeed don't know segfault
20120330 20:48:56< mordante> and yes I posted brilliand as reply on a message in the logs (a few days old...)
20120330 20:49:29< hankerspace> Thanks Crab_, and for your last request : tabs instead of spacing, maybe i don't have the same parameters but with tabs i can't reach the same indentation ... I'll use copy and paste it should be better :p
20120330 20:50:04< mordante> hankerspace, is the code around it then with spaces?
20120330 20:50:22< Crab_> hankerspace: it's strange, possible that the file contains spaces instead of tabs. but, events.cpp seem to contain tabs.
20120330 20:53:28< hankerspace> Yes but my last patch was in game_events.cpp
20120330 20:54:12< hankerspace> mordante: it seems
20120330 20:56:09< mordante> hankerspace, "<hankerspace_> I have the idea. But if i use my ways of  programming, is that a problem ?"
20120330 20:56:25< mordante> in general it's a good idea to mimic the code base you work in
20120330 20:56:32< mordante> especially for patches
20120330 20:57:03< hankerspace> Yes, i understand.
20120330 20:58:28-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has joined #wesnoth-dev
20120330 20:58:28-!- stikonas [~gentoo@ctv-79-132-176-196.vinita.lt] has quit [Changing host]
20120330 20:58:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 20:59:35-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120330 20:59:46< mordante> fendrin, seems gcc-4.5 also like the original code, so maybe a bug in gcc-4.4 
20120330 20:59:55< mordante> likes*
20120330 21:03:24< vultraz> mordante: I seem to have found a bug: http://imagebin.org/205743 that 'Shop' is a map label that gets drawn over the window when the tooltip is printed
20120330 21:03:31-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120330 21:03:45-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 246 seconds]
20120330 21:06:09< fendrin> mordante: My setup eclipse/gcc-4.6.3 gives me many warnings about the code. But I do not dare to fix them since it seams the validator checks against the new c++ specification.
20120330 21:06:55< fendrin> mordante: Maybe I should see if I can disable the new c++ somehow.
20120330 21:06:55< mordante> fendrin, can you pastebin the warnings, I'm curious
20120330 21:07:24< fendrin> It's trivial stuff.
20120330 21:07:37< fendrin> Like no break in every case of a switch statement.
20120330 21:08:13< mordante> fendrin, that's actually valid in C/C++
20120330 21:08:58< mordante> vultraz, is there a way to reproduce it?
20120330 21:09:16< Vino> is it me or does wesnoth take a really long time to compile
20120330 21:09:23< Vino> maybe my computer is getting old
20120330 21:09:44< fendrin> mordante: Yes, that is why I do not fix them.
20120330 21:09:44< mordante> Vino, it's not you Wesnoth takes quite some time
20120330 21:09:58< shadowm> Vino: no, it's not just you. A clean build without any cached objects usually takes more than 30 minutes here at -j1.
20120330 21:10:51< Vino> seems like each individual file takes a lot longer than individual files in my own projects. all those templates possibly
20120330 21:11:11< mordante> yep template instantiation takes quite a while
20120330 21:11:24< shadowm> the AI and GUI2 sections are the most resource-demanding code at compile-time, to the point that I had to buy more RAM for my previous laptop
20120330 21:11:33< Vino> from what i've seen so far wesnoth uses a lot of templates
20120330 21:11:34< Crab_> yes, gui/ and ai/ are most template heavy.
20120330 21:11:54< vultraz> mordante: well, that instance is in my addon. not sure if there's another case
20120330 21:12:04< vultraz> haven't run into one
20120330 21:12:32< fendrin> hi shadowm, please have a look at the editor, and how it pleases you.
20120330 21:13:06< shadowm> you mean whether the current state pleases me? I guess I will do that
20120330 21:13:39< shadowm> it'll take a while because I haven't built this thing in days
20120330 21:14:22< mordante> vultraz, do you create the label while the dialog is open or is it already there?
20120330 21:14:44< vultraz> mordante: already there
20120330 21:14:53< mordante> fendrin, more warnings/errors in eclipse?
20120330 21:15:07< vultraz> mordante: also interesting is that I don't remember this happening before 
20120330 21:15:19< mordante> vultraz, odd, I've never seen it before
20120330 21:15:41< fendrin> mordante: It's hard to find them because the eclipse internal sematic/syntax checker only works at the currently opened file.
20120330 21:16:12< vultraz> mordante: here's the relative file: http://wesnoth-umc-dev.svn.sourceforge.net/viewvc/wesnoth-umc-dev/trunk/NX-RPG/lua/inventory.lua?revision=14032&view=markup
20120330 21:16:22< mordante> fendrin, ah ok, I thought it would be able to create a list of issues
20120330 21:16:29< fendrin> mordante: 
20120330 21:16:31< fendrin> Description	Resource	Path	Location	Type
20120330 21:16:32< fendrin> Suggested parenthesis around expression 'SDL_EVENTMASK(temp_event.type)&INPUT_MASK'	events.cpp	/Project-Debug@trunk_build/[Source directory]/src	line 285	Code Analysis Problem
20120330 21:17:13< fendrin> events.cpp
20120330 21:18:06< CIA-69> gabba * r53703 /branches/1.10/src/ (mouse_events.cpp whiteboard/manager.cpp): Fix bug #19581 (Leader can move after a planned recall). Recall and recruit are now treated the same way by the whiteboard when considering moving leaders. Patch #3201 by ejls. Backported from rev #53699.
20120330 21:18:30< gabba> Ivanovic: ^ changes one translatable string, but it's worth it
20120330 21:18:48< Ivanovic> and there was no way to reuse an already existing string?
20120330 21:19:32< gabba> Ivanovic: not really, couldn't think of one... it's very situational
20120330 21:21:24< gabba> Ivanovic: should I take this opportunity to change another string that I wanted to improve (not as important as this one)? To avoid doing this too often.
20120330 21:21:27< mordante> fendrin, ah ok indeed not really interesting warnings
20120330 21:23:01< Ivanovic> of course, do changes in a batch!
20120330 21:28:16< Espreon> .awat
20120330 21:28:23< Espreon> Sorry.
20120330 21:32:16-!- MeccaGod [majs@host189-199.bornet.net] has quit []
20120330 21:32:50-!- gabba1 [~gabba@ip-96-43-227-197.dsl.netrevolution.com] has joined #wesnoth-dev
20120330 21:35:39-!- gabba [~gabba@wesnoth/developer/gabba] has quit [Ping timeout: 260 seconds]
20120330 21:37:46-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer]
20120330 21:38:04-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has joined #wesnoth-dev
20120330 21:38:14-!- Upth [~ogmar@public-nat1.scc.losrios.edu] has joined #wesnoth-dev
20120330 21:38:14-!- Upth is now known as Upthorn
20120330 21:39:56< CIA-69> gabba * r53704 /branches/1.10/ (changelog players_changelog): Changelog entries.
20120330 21:41:50< uzyszkodnik> hmm is there a nice way to remove from config child with given key of it and an attribute and value in it?
20120330 21:42:44< uzyszkodnik> i know there is find_child but it provides only a reference which i cant stick anywhere
20120330 21:45:41< gabba1> gah. For once I try to commit from Windows, and it proves a lot more annoying that under linux. What's the recommended EOL setting in TortoiseSVN?
20120330 21:47:02< mordante> native
20120330 21:47:13< gabba1> thanks mordante
20120330 21:47:20< mordante> at least it's the recommended setting in svn
20120330 21:48:02< loonycyborg> gabba1: Isn't eol style an svn prop and not tortoise setting?
20120330 21:48:21< gabba1> it *is* a prop, but...
20120330 21:49:19< loonycyborg> At least Espreon is constantly setting it for all newly added files :P
20120330 21:50:32< gabba1> There's also a TortoiseSVN setting for this (which obviously I can't find again when I want to explain), that continuously found changes even in a fresh checkout when I left it on default
20120330 21:52:58< gabba1> Or more likely, I'm getting mixed up with TortoiseGit's SafeCLR setting, lol. The horror.
20120330 21:53:37< gabba1> So anyways, eol being set to native means that files should be checked out under Windows with Windows line endings?
20120330 21:53:49< shadowm> I think so
20120330 21:54:12< gabba1> Ok, so I can beat some reason into my editor manually, at least
20120330 21:54:28< shadowm> I forgot all this stuff
20120330 21:54:32< shadowm> !!svnbook
20120330 21:54:42< shadowm> oh, shikadibot is missing
20120330 21:54:59-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has quit [Quit: Konversation terminated!]
20120330 21:55:11-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev
20120330 21:55:54< shadowm> http://svnbook.red-bean.com/en/1.7/svn.advanced.props.file-portability.html#svn.advanced.props.special.eol-style
20120330 21:56:43-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20120330 21:59:02< CIA-69> gabba * r53705 /trunk/ (changelog players_changelog): Changelog entries.
20120330 21:59:17< gabba1> Thanks for the link, will check out
20120330 22:02:15< gabba1> doing this famous move to git would probably save a few hair on Espreon's head by taking care of this EOL mess automatically :P
20120330 22:02:34< gabba1> even though I'm sure it would bring new fun and unexpected problems
20120330 22:05:10-!- Upthorn [~ogmar@public-nat1.scc.losrios.edu] has quit [Ping timeout: 260 seconds]
20120330 22:14:57< shadowm> fendrin: yes, I see you fixed the black background issue, which was never about pleasing me in particular. The tile icon overpainting regression is still there, though.
20120330 22:16:04< Vino> okay, wesnoth is built! time to do some hacking
20120330 22:16:21< shadowm> mordante: this is a reminder that it would be nice if the numbers in the titlescreen layout WML were documented
20120330 22:17:25< fendrin> shadowm: You mentioned you know why that happens.
20120330 22:17:28-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev
20120330 22:17:40< shadowm> fendrin: yep, and so should you because you did it on purpose, more or less.
20120330 22:19:18< shadowm> s/more or less/definitely/
20120330 22:20:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120330 22:22:02< shadowm> although now that I see the commented-out code handling that was removed in r53693, I'm very concerned again
20120330 22:24:40< shadowm> so I guess I'll play Captain Obvious again just in case: during your refactoring, you made individual editor palettes into composed aggregates of the palette manager, thus they lost their GUI1 widget powers. As a result, they no longer know how to restore the previous background when drawing individual tile icons
20120330 22:26:18< shadowm> that is, the gui::widget::bg_restore() call that I introduced during late 1.9.x to fix the overpainting issue is no longer feasible ineditor::editor_palette<...>::draw()
20120330 22:26:33-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20120330 22:26:39< shadowm> you commented it out, and recently removed it, which makes me suspect you missed its purpose at all
20120330 22:26:57< shadowm> since the commit message removing the commented out line makes no mention of what's going on in that field
20120330 22:29:23< mordante> I'm off night
20120330 22:29:31-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20120330 22:30:09< shadowm> in other news, you are still violating our coding guidelines in palette_manager.hpp
20120330 22:31:36-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20120330 22:35:07-!- nagafono [~kvirc@178.19.254.1] has quit [Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/]
20120330 22:40:30< ejls> gabba1: re
20120330 22:41:01< ejls> gabba1: For the visitor refactoring, I have this idea: replace enable_visit_all by an interface over all side_actions (i.e. all the actions of every team), then use multiple indexing in side_actions (for example, build an index on unit's id). With this design, the highlighter will only have to do query of the form the_new_action_interface->actions_on(mouseover_hex_);. Is it sounding good?
20120330 22:41:01< gabba1> ejls: I commited your patch and backported it to stable
20120330 22:41:40< ejls> gabba1: Ok, good, that is my first patch commited to wesnoth. :)
20120330 22:41:53< gabba1> yup :)
20120330 22:42:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120330 22:42:18< ejls> yup, this design looks good?
20120330 22:42:40< gabba1> yup for the patch, still reading the above
20120330 22:42:51< ejls> ah, ok. :)
20120330 22:43:10-!- micole [~micole@unaffiliated/micole] has joined #wesnoth-dev
20120330 22:43:29< anonymissimus> gabba1: I certainly recommend to use LF only
20120330 22:44:00< anonymissimus> and never let it do any EOL conversion, native ain't good
20120330 22:44:02< ejls> The idea is that the_new_action_interface_needing_a_name will only be a proxy to the side_actions of every team.
20120330 22:44:21< gabba1> ejls: hmm, not too sure I'm following you actually
20120330 22:44:47< anonymissimus> its just that wesnoth is a lot more Linux-friendly so of course it's harder on windows
20120330 22:44:50< gabba1> a side_actions object holds the actions for one team, that doesn't need to change
20120330 22:44:58-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev
20120330 22:44:59< anonymissimus> I wonder how you come to be on a windows system ??
20120330 22:45:25< gabba1> anonymissimus: well, by default SVN checks out every file with CRLF under windows, so I'm gonna let it do that
20120330 22:45:45< anonymissimus> don't let it do that
20120330 22:45:51< ejls> What I want to change is the access to this actions, in order to allow access by hex or unit's id.
20120330 22:45:54-!- uzyszkodnik [~uzyszkodn@aene66.neoplus.adsl.tpnet.pl] has quit [Read error: Connection reset by peer]
20120330 22:45:56< gabba1> anonymissimus: (not by default actually, but it does with the "native" property Espreon manually sets)
20120330 22:46:32< ejls> I mean, instead of keeping only the action in a sequence, they will also be kept in a set indexed by hex/unit's id.
20120330 22:46:37< anonymissimus> yup, and that native thing is bad
20120330 22:47:04< gabba1> ejls: sure, that can be part of your design
20120330 22:47:09< shadowm> anonymissimus: care to explain?
20120330 22:47:29< gabba1> anonymissimus: inconsistency is bad
20120330 22:47:53< anonymissimus> it is bad because it does automatic EOL changes
20120330 22:48:08< anonymissimus> and tends to cause pseudo-changes thereby
20120330 22:48:34< ejls> gabba1: Ok, I just wanted to know whether it looks good. Thank you again. :)
20120330 22:48:35< anonymissimus> of course if you are on a system which has native LF like in the remote repo one doesn't notice
20120330 22:48:53< gabba1> ejls: no problem :)
20120330 22:49:06< shadowm> anonymissimus: the point of that function is that the format changes are transparent to users
20120330 22:49:43< gabba1> anonymissimus: the auto-EOL change is not a problem if line endings are consistent in the first place. If you get problems after your edits, it means you're using retarded editors.
20120330 22:49:46< shadowm> they aren't supposed to find out there are any changes going on unless they are doing something wrong like sharing a checkout between a CR-LF and an LF platform
20120330 22:50:06< shadowm> or their editors cannot automatically detect the correct EOL format, yes
20120330 22:50:40< anonymissimus> sharing a checkout between CRLF and LF platform is what I do yep
20120330 22:50:51-!- micole [~micole@unaffiliated/micole] has quit [Ping timeout: 250 seconds]
20120330 22:51:01< shadowm> bad idea
20120330 22:51:04< anonymissimus> and I dont find it wrong; its useful for a cross-platform project
20120330 22:52:02< shadowm> IIRC, Subversion 1.7 breaks backwards compatibility with the checkout format.
20120330 22:52:07-!- arnem [~quassel@host-78-146-84-108.as13285.net] has joined #wesnoth-dev
20120330 22:52:24< gabba1> were I to do that, I'd save my changes into small git commits and use push/pull between my local windows and linux git repos to share files without eol problems... just saying
20120330 22:54:31< anonymissimus> I don't have eol problems any more since I always use LF
20120330 22:55:16< anonymissimus> I dont want redundant repose
20120330 22:55:53< gabba1> but sharing a checkout with linux means you're not even using a linux file system for the checkout, so it thinks all your files are executable and other horrors... bleh, dunno how you can bear with that
20120330 22:55:53-!- IvanSav [~IvanSav@ns2.ultranet.com.ua] has quit [Quit: IvanSav]
20120330 22:57:20< anonymissimus> yes, it's fat32, and I have set some further flags to make it work
20120330 22:57:43< gabba1> fat32, agh the pain :P
20120330 22:58:01< gabba1> Anyways how do you force svn to checkout LF despite the manual properties that are set?
20120330 22:58:38< anonymissimus> but AFAIK there are also tools for windows which allow reading/writing with the Linux file systems
20120330 22:58:43-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20120330 22:58:49< anonymissimus> so it *could* be done
20120330 22:59:01< gabba1> Nah, checked them all out, there are only readonly ones for Windows 7 AFAIK
20120330 22:59:07< anonymissimus> no idea about svn, it is git
20120330 22:59:56< gabba1> Ah ok, with git I know how to do it - here I set up svn since it's just faster and I want to make the occasional simple commit without rebooting
20120330 23:00:07< shadowm> so this conversation about git-svn was sparked by one about pure svn (tortoisesvn)? :p
20120330 23:00:36< gabba1> Well, I thought anonymissimus was speaking about svn almost the whole time
20120330 23:00:48< hankerspace> Crab_: Patch updated following your advices
20120330 23:00:53< anonymissimus> well...about both I think
20120330 23:01:10< Crab_> hankerspace: ok, great
20120330 23:01:16< anonymissimus> but I dont share and svn repo with win and Linux so no idea
20120330 23:01:20< shadowm> not quite, since my warnings about not breaking svn do not apply to git-svn
20120330 23:01:30< shadowm> s/svn/Subversion clients/
20120330 23:01:31< gabba1> so the "don't let it do that" above is probably impossible. SVN shall impose its CRLF on me
20120330 23:02:42-!- Danthar [~Narvek@ip3e833902.speed.planet.nl] has joined #wesnoth-dev
20120330 23:02:50< Danthar> Hi all
20120330 23:03:13< Crab_> hi, Danthar
20120330 23:03:28< Danthar> Can someone explain to me how share_view=yes works? team_name is the one that creates allies if the name is identical, right?
20120330 23:03:49< Danthar> For some reason I cannot see through the fog for my ally
20120330 23:05:27< Crab_> hankerspace:  max_duration should be  max_duration_ when it is a class variable
20120330 23:05:57< Crab_> hankerspace: same for max_lifetime - if it is a nonpublic member variable, let it be  max_lifetime_
20120330 23:06:10< Crab_> hankerspace: two more places to fix, sorry for that :)
20120330 23:07:16-!- gabba1 [~gabba@ip-96-43-227-197.dsl.netrevolution.com] has left #wesnoth-dev []
20120330 23:08:35< anonymissimus> gabba1: looks like it; I found this http://svn.haxx.se/tsvnusers/archive-2008-01/0015.shtml and they conclude that tortoisesvn forces CRLF upon the user when on windows and the snv property is native ...
20120330 23:08:57< Crab_> Danthar: according to the source, share_view makes allies share fog and shroud.
20120330 23:09:12< Crab_> if(!is_enemy(i + 1) && (&(teams[i]) == this || teams[i].share_view() || teams[i].share_maps())) { ...
20120330 23:09:18< Crab_> ( in team.cpp )
20120330 23:09:30< Crab_> so, you need to use team_name to make allies, as well.
20120330 23:09:38< anonymissimus> which means I have to use git for wesnoth in case I want to share a repo with Linux
20120330 23:09:40< Crab_> and you need the teams to be using fog/shroud in the first place
20120330 23:09:58< hankerspace> Ups, Crab_ i'm really sorry for this misstake, i'll fix that now
20120330 23:10:15< Crab_> Danthar: if the team is seeing the entire map without fog/shroud, it won't share with allies.
20120330 23:10:38-!- retr0virus [~vyrm@static-213-182-110-135-teleos.ewe-ip-backbone.de] has quit [Quit: Ein Nichts im Nichts und ins Nichts vertrieben!]
20120330 23:12:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20120330 23:12:52< Crab_> hankerspace: no, no reason to be sorry, it's not that important - just a few lines to fix :)
20120330 23:14:07< hankerspace> I think it's good now Crab_, my bad, i've remove all the "_"  without thinking ...
20120330 23:14:17< anonymissimus> Crab_: actually, share_view=yes/no affects only fog, while share_maps=yes/no affects only shroud
20120330 23:14:23< Crab_> hankerspace: the reason for that particular rule is that it allows to easily note the lifetime of the variable - if it ends in _, that's a class variable.
20120330 23:14:33< Crab_> anonymissimus: no. share_view affects both, so it overrides share_maps.
20120330 23:14:59< anonymissimus> that was empirical
20120330 23:15:01< Crab_> anonymissimus: check src/team.cpp
20120330 23:15:28< Crab_> anonymissimus: there is even a comment there '// Share_view and share_maps can't both be enabled, // so share_view overrides share_maps.'
20120330 23:15:58< hankerspace> I've took a bad habit with using "_" before my variables ... But now, it's ok
20120330 23:16:10< Crab_> anonymissimus: I haven't checked empirically, so you might be right - but in that case comments in the source are slightly wrong.
20120330 23:16:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120330 23:20:15-!- mjs-de [~mjs-de@g224187165.adsl.alicedsl.de] has quit [Remote host closed the connection]
20120330 23:20:18< Crab_> hankerspace: the patch gives me 'patching file src/game_events.cpp  patch: **** malformed patch at line 26: @@ -2773,7 +2780,7 @@' - what am I doing wrong?
20120330 23:20:27< Danthar> Crab_ thanks but when I test it out I still see fog over my ally
20120330 23:20:51< Danthar> and they're both on team_name=1
20120330 23:21:32< hankerspace> Maybe because i dont use svn_update since a while ? :s Crab_
20120330 23:22:08< Crab_> hankerspace: mayhap. but that usually gives 'patch ... failed at chunk ... ' messages.
20120330 23:22:39< hankerspace> Crab_:  this line seems to be good ...
20120330 23:25:16< loonycyborg> Crab_: Probably there are stray characters there.
20120330 23:25:27< loonycyborg> Or you need to apply dos2unix :P
20120330 23:26:57< Crab_> loonycyborg: no, it has unix line endings already. and nothing interesting in terms of characters
20120330 23:27:47-!- ianto [~chris@fsf/member/pdpc.student.ianto] has quit [Remote host closed the connection]
20120330 23:28:18< anonymissimus> Crab_: ok, looks like you are right
20120330 23:28:35-!- hagi [~hagi@cable-static-159-239.teleport.ch] has joined #wesnoth-dev
20120330 23:30:09< Danthar> Well I'll disable fog for now I want to continue with other stuff... which reminds me: I have made a custom schedule-image, for my unique time. But I cannot seem to get it displayed. I have this in scenario: http://pastebin.com/p2jGHDXA
20120330 23:30:36< Crab_> Danthar: can't help about the schedule image, sorry
20120330 23:31:07< Danthar> Ok... I tried a lot, with quotes, without, with {~add-ons/filepath...} 
20120330 23:31:29< Danthar> I couldn't find the syntax for it
20120330 23:31:40< zookeeper> remove images/
20120330 23:31:46< zookeeper> that's never needed in image paths
20120330 23:32:22< Danthar> ok! ty
20120330 23:33:10< Danthar> YES that did it, sweet
20120330 23:33:18< Danthar> thank you zookeeper
20120330 23:34:08< Crab_> Danthar: share_view works, btw
20120330 23:34:31< Crab_> I'll paste an example
20120330 23:35:00< Danthar> http://pastebin.com/YmNbc75N not like this
20120330 23:35:10< Danthar> for some reason
20120330 23:35:27< Crab_> http://pastebin.mozilla.org/1547001 - works
20120330 23:36:11< Crab_> fog=yes shroud=yes
20120330 23:36:34< Crab_> "Crab_ 23:09 and you need the teams to be using fog/shroud in the first place"
20120330 23:36:39< Danthar> hmm I should add that for the ai?
20120330 23:36:43< Crab_> yes
20120330 23:36:55< Crab_> it has no concept of 'locations unshrouded' if it's not using shroud
20120330 23:37:00< Danthar> ok, thanks, i mistook that for meaning that the human side should
20120330 23:37:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120330 23:37:35< Crab_> (let me know if it'd still not work)
20120330 23:38:01< Crab_> but it should. allies, fog/shroud enabled for both teams, share_view enabled for ai - that's it
20120330 23:38:51< Danthar> Crab_ it works, you guys are real lifesavers :D
20120330 23:38:54< anonymissimus> at least it makes sense to me now why it's share_view and not just share_fog and share_shroud
20120330 23:39:43< anonymissimus> but team.cpp:202 seems a bad condition; if share_view = true should force share_maps = true
20120330 23:40:03-!- hagi [~hagi@cable-static-159-239.teleport.ch] has quit []
20120330 23:42:50< Crab_> it's like 'should not both be enabled'
20120330 23:43:50< Crab_> team::copy_ally_shroud() would actually behave differently
20120330 23:44:58-!- arnem [~quassel@host-78-146-84-108.as13285.net] has quit [Remote host closed the connection]
20120330 23:45:55< anonymissimus> it is coded so that share_view=yes forces share_maps=no, *but* share_view=yes behaves like both are true
20120330 23:46:07< anonymissimus> so that is confusing ;)
--- Log closed Sat Mar 31 00:00:15 2012