--- Log opened Mon Apr 02 00:00:27 2012 20120402 00:05:49-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev 20120402 00:10:06-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 246 seconds] 20120402 00:21:35-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev 20120402 00:28:51-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]] 20120402 00:34:20< Danthar> Bye all :) 20120402 00:34:37-!- Danthar [~Narvek@ip3e833902.speed.planet.nl] has quit [] 20120402 00:53:56-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 00:56:30-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120402 00:57:41-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 01:16:19-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 264 seconds] 20120402 01:24:22-!- Jozrael [~croselius@209.133.52.233] has quit [Ping timeout: 250 seconds] 20120402 01:33:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120402 01:49:49-!- wesbot changed the topic of #wesnoth-dev to: 1.10.2 planned for April 7th, string freeze for branches/1.10 | Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 165 bugs, 328 feature requests, 15 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120402 01:50:46-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has joined #wesnoth-dev 20120402 01:52:27-!- Johannes13 [~Johannes@p4FDEF944.dip.t-dialin.net] has joined #wesnoth-dev 20120402 01:52:27-!- Johannes13 [~Johannes@p4FDEF944.dip.t-dialin.net] has quit [Changing host] 20120402 01:52:27-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20120402 01:54:10-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 01:57:33-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 02:30:44< CIA-69> jamit * r53751 /trunk/src/actions.cpp: 20120402 02:30:44< CIA-69> Refactoring move_unit(), making the algorithm more robust. 20120402 02:30:44< CIA-69> (Some obscure cases had weird results; patch #3133) 20120402 02:39:12-!- bloodycoin_m [~bloodycoi@193.170.135.78] has quit [Remote host closed the connection] 20120402 02:41:56-!- un214 [~un214@adsl-108-204-254-249.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev 20120402 02:49:36-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Leaving...] 20120402 02:53:17-!- jamit [~james@pool-173-61-168-180.cmdnnj.east.verizon.net] has left #wesnoth-dev [] 20120402 02:54:10-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 02:55:51-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 02:57:18-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 02:58:08-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 240 seconds] 20120402 03:01:15-!- un214 [~un214@adsl-108-204-254-249.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection] 20120402 03:03:07-!- ancestral [~ancestral@97-127-62-183.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120402 03:18:46-!- eirikvw [189a49d2@gateway/web/freenode/ip.24.154.73.210] has joined #wesnoth-dev 20120402 03:21:51-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has joined #wesnoth-dev 20120402 03:22:34-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has left #wesnoth-dev [] 20120402 03:22:47-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has joined #wesnoth-dev 20120402 03:22:53-!- ancestral [~ancestral@97-127-62-183.mpls.qwest.net] has joined #wesnoth-dev 20120402 03:22:58-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 252 seconds] 20120402 03:26:01-!- shadowm [~ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120402 03:34:27-!- tyrannodogg [~tyrannodo@ip-46-23.travedsl.de] has left #wesnoth-dev [] 20120402 03:37:20-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Quit: Leaving] 20120402 03:41:43-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 03:41:50-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.] 20120402 03:45:10-!- Vino [~Vino@ip72-199-74-186.sd.sd.cox.net] has left #wesnoth-dev ["Leaving"] 20120402 03:47:32-!- eirikvw [189a49d2@gateway/web/freenode/ip.24.154.73.210] has left #wesnoth-dev [] 20120402 03:54:16-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 03:59:01-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 276 seconds] 20120402 04:00:08-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 240 seconds] 20120402 04:05:31-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Excess Flood] 20120402 04:05:42-!- matthiaskrgr [matthiaskr@109.73.162.119] has joined #wesnoth-dev 20120402 04:12:53-!- vernon [~IceChat77@1F2E4534.catv.pool.telekom.hu] has quit [Quit: Do fish get thirsty?] 20120402 04:26:49-!- Johannes13_ [~Johannes@p4FDEAD49.dip.t-dialin.net] has joined #wesnoth-dev 20120402 04:26:49-!- Johannes13_ [~Johannes@p4FDEAD49.dip.t-dialin.net] has quit [Changing host] 20120402 04:26:49-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20120402 04:30:09-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 246 seconds] 20120402 04:35:45-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20120402 04:35:55-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev 20120402 04:41:08-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has quit [Read error: Connection reset by peer] 20120402 04:41:23-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has joined #wesnoth-dev 20120402 04:41:24-!- Johannes13_ [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 260 seconds] 20120402 04:54:22-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 04:58:09-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 04:59:01-!- Ivanovic_ [~ivanovic@dtmd-4db23e4b.pool.mediaWays.net] has joined #wesnoth-dev 20120402 05:02:47-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds] 20120402 05:03:45-!- Ivanovic_ [~ivanovic@dtmd-4db23e4b.pool.mediaWays.net] has quit [Ping timeout: 265 seconds] 20120402 05:14:36-!- Ivanovic [~ivanovic@dtmd-4db23e4b.pool.mediaWays.net] has joined #wesnoth-dev 20120402 05:29:56-!- enchilado [~enchilado@210-55-84-105.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 05:30:41-!- enchilado [~enchilado@210-55-84-105.dialup.xtra.co.nz] has quit [Changing host] 20120402 05:30:41-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20120402 05:35:13-!- enchilad1 [~enchilado@210-55-84-105.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 05:35:29-!- enchilad1 [~enchilado@210-55-84-105.dialup.xtra.co.nz] has quit [Changing host] 20120402 05:35:29-!- enchilad1 [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20120402 05:37:23-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Disconnected by services] 20120402 05:37:23-!- enchilad1 is now known as enchiladp 20120402 05:37:23-!- enchiladp [~enchilado@defocus/yummy/enchilado] has quit [Read error: Connection reset by peer] 20120402 05:43:59-!- SankaD [2e49970b@gateway/web/freenode/ip.46.73.151.11] has joined #wesnoth-dev 20120402 05:44:24-!- neph [~neph@02de475b.bb.sky.com] has quit [Ping timeout: 260 seconds] 20120402 05:48:29-!- Blueblaze [~Blueblaze@adsl-99-158-46-32.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20120402 05:51:16-!- SankaD [2e49970b@gateway/web/freenode/ip.46.73.151.11] has quit [Ping timeout: 245 seconds] 20120402 05:53:15-!- Blueblaze [~Blueblaze@99.158.46.32] has joined #wesnoth-dev 20120402 05:53:15-!- Blueblaze [~Blueblaze@99.158.46.32] has quit [Client Quit] 20120402 05:54:40-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 05:58:26-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 252 seconds] 20120402 06:00:16-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20120402 06:05:39-!- enchilado [~enchilado@219-88-25-15.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 06:12:56-!- enchilad1 [~enchilado@219-88-25-15.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 06:13:58-!- enchilado [~enchilado@219-88-25-15.dialup.xtra.co.nz] has quit [Disconnected by services] 20120402 06:14:00-!- enchilad1 is now known as enchilado 20120402 06:14:08-!- enchilado [~enchilado@219-88-25-15.dialup.xtra.co.nz] has quit [Changing host] 20120402 06:14:09-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20120402 06:14:20< faryshta> I have a question about the menu_events.cpp file. On line 952 there is an open '{' but I can't understand the syntax of what is it doing there. 20120402 06:16:13< shadowm> faryshta: it opens a stand-alone scope (not sure what the technical term is) 20120402 06:16:49< shadowm> variables created within that scope run out of scope on the matching closing brace; this is useful for temporary objects that implement locks or other temporary... things 20120402 06:19:39< shadowm> *eye twitch* okay, my explanation wasn't very helpful 20120402 06:21:53< shadowm> It seems other people call this block scope. 20120402 06:22:56< shadowm> The general idea is that this creates an inner scope without requiring a while, do/while, for, if block or a whole different function. 20120402 06:28:08< gabba> faryshta: shadowm's explanation is good, but I can probably explain it further if you don't understand 20120402 06:28:10< gabba> let me know 20120402 06:28:30-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 260 seconds] 20120402 06:30:42-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120402 06:38:51-!- enchilad1 [~enchilado@219-88-25-108.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 06:38:54-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Disconnected by services] 20120402 06:39:33-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has joined #wesnoth-dev 20120402 06:43:27-!- enchilad1 [~enchilado@219-88-25-108.dialup.xtra.co.nz] has quit [Ping timeout: 260 seconds] 20120402 06:54:44-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 06:58:33-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 07:01:48-!- tyrannodogg [~tyrannodo@ip-46-23.travedsl.de] has joined #wesnoth-dev 20120402 07:05:26-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has quit [Ping timeout: 245 seconds] 20120402 07:11:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120402 07:19:18-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev 20120402 07:30:36-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120402 07:31:45-!- Ivanovic [~ivanovic@dtmd-4db23e4b.pool.mediaWays.net] has quit [Changing host] 20120402 07:31:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120402 07:49:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120402 07:49:49-!- wesbot changed the topic of #wesnoth-dev to: 1.10.2 planned for April 7th, string freeze for branches/1.10 | Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 165 bugs, 328 feature requests, 14 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120402 07:54:42-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 07:56:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120402 07:58:23-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 08:19:55-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds] 20120402 08:26:48-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120402 08:29:32< faryshta> shadowm, gabba thanks it was a good explanation I was just AFK. 20120402 08:29:41< faryshta> That explains it very well. 20120402 08:42:43-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120402 08:47:51< faryshta> shadowm, gabba, what does the function vngettext do? 20120402 08:48:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120402 08:49:54-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Linkinus - http://linkinus.com] 20120402 08:50:33< shadowm> faryshta: it's a wrapper around interpolate_variables_into_string() that uses gettext plurals (ngettext()) IIRC 20120402 08:51:27< shadowm> the former is used to allow translators to work with strings such as "Add-on title: $addon_title", where $addon_title is a placeholder for string substitution in much the same way as found in WML events. 20120402 08:52:16< shadowm> That kind of internationalization strategies allow for more flexibility for translators in cases where other languages may require reordering of arguments. 20120402 08:52:44-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20120402 08:52:52< faryshta> shadowm, then its like the function t() in drupal. 20120402 08:52:59< faryshta> thanks 20120402 08:53:27< faryshta> shadowm, I am about to send a patch. Shall I send the changes to you first or something? 20120402 08:54:53-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 08:58:17< shadowm> faryshta: if t() is some generic translation mechanism, well, not quite; vngettext() is just one of many gettext wrappers we have for different use cases. 20120402 08:59:02< shadowm> note that you can consult src/gettext.hpp and src/formula_string_utils.hpp with the aid of GNU gettext's own documentation if you want to know more about them. 20120402 08:59:04-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 272 seconds] 20120402 09:00:18< shadowm> faryshta: as for sending patches to me, unless they are in some area I have extensively worked with that's not very likely to be a very productive course of action. I recommend patches.wesnoth.org instead, but first make sure you have read the PatchSubmissionGuidelines in the wiki. 20120402 09:00:27< shadowm> http://wiki.wesnoth.org/PatchSubmissionGuidelines 20120402 09:04:27-!- loonycyborg [loonycybor@wesnoth/developer/loonycyborg] has quit [Ping timeout: 252 seconds] 20120402 09:04:29< tyrannodogg> hi there, i just submitted my proposal to the wiki, is there anyone i have to tell about it, besides i goona talk to crab_ when he is back on since it's an ai topic 20120402 09:09:07-!- loonycyborg [~sergey@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20120402 09:12:35< faryshta> ok where do I submit my patch shadowm ? 20120402 09:12:57< shadowm> I said patches.wesnoth.org above, didn't I? Also, the wiki has more documentation on that matter. 20120402 09:17:56-!- stikonas [~gentoo@ctv-217-147-37-55.vinita.lt] has joined #wesnoth-dev 20120402 09:17:56-!- stikonas [~gentoo@ctv-217-147-37-55.vinita.lt] has quit [Changing host] 20120402 09:17:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120402 09:31:19-!- enchilado [~enchilado@219-88-47-126.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 09:31:37-!- tyrannodogg [~tyrannodo@ip-46-23.travedsl.de] has left #wesnoth-dev [] 20120402 09:31:47-!- enchilado [~enchilado@219-88-47-126.dialup.xtra.co.nz] has quit [Changing host] 20120402 09:31:47-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20120402 09:36:55-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev 20120402 09:50:03-!- SankaD [c0f8086a@gateway/web/freenode/ip.192.248.8.106] has joined #wesnoth-dev 20120402 09:51:34< faryshta> https://gna.org/patch/index.php?3234 my first patch. shadowm gabba Crab_ Espreon 20120402 09:52:58< shadowm> that's definitely a component I don't want to check 20120402 09:53:23< shadowm> my past experience with the unit class has been disastrous at best 20120402 09:55:01-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 09:58:55-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 264 seconds] 20120402 10:02:39< gabba> faryshta: I have to leave, but first observation: please submit a diff, not whole files 20120402 10:03:16< gabba> also, it's not clear for me what "allows you to open the recall menu if you have one gold  20120402 10:03:16< gabba> possibly will create a bug allowing recall units  20120402 10:03:16< gabba> even if you don't have enough gold (in which case will  20120402 10:03:16< gabba> cause you to have negative gold)" 20120402 10:03:27< shadowm> ugh, that's why I linked http://wiki.wesnoth.org/PatchSubmissionGuidelines in the first place 20120402 10:03:30< gabba> hmm, sorry for massive paste 20120402 10:03:56< shadowm> I hadn't realized those weren't diffs. 20120402 10:03:58< gabba> But if as I understand it's a bug that your modifications create, you have to find a way to solve it 20120402 10:07:06-!- SankaD [c0f8086a@gateway/web/freenode/ip.192.248.8.106] has quit [Ping timeout: 245 seconds] 20120402 10:08:52-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20120402 10:13:48-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20120402 10:16:29< faryshta> shadowm, gabba how do I create diff? 20120402 10:17:30< shadowm> the wiki page I linked says something about svn diff 20120402 10:17:59< shadowm> of course that assumes you either use the command line client or can find an equivalent in whatever front-end you use 20120402 10:20:05< faryshta> I know how to use the svn but never heard of svn diff. let me find. 20120402 10:21:12< shadowm> first of all, what operating system are you using? that will help you decide which svn client suits you best, probably 20120402 10:21:21-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev 20120402 10:21:24< shadowm> and depending on the answer I may not be able to help at all 20120402 10:21:25< faryshta> linux ubuntu. 20120402 10:21:34< faryshta> I use terminal. 20120402 10:21:55< shadowm> okay, then I advise svn diff --help 20120402 10:22:00< shadowm> it _is_ a command 20120402 10:22:12< shadowm> also this http://svnbook.red-bean.com/en/1.7/svn.ref.svn.c.diff.html 20120402 10:22:57< shadowm> in order to produce a patch for uploading you'll want to redirect the output of svn diff in your working copy to a file for you to upload later, e.g. svn diff > unit-recall-costs.patch 20120402 10:24:27-!- ancestral [~ancestral@97-127-62-183.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120402 10:29:42-!- Johannes13 [~Johannes@p4FDEB06A.dip.t-dialin.net] has joined #wesnoth-dev 20120402 10:29:42-!- Johannes13 [~Johannes@p4FDEB06A.dip.t-dialin.net] has quit [Changing host] 20120402 10:29:42-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20120402 10:32:59-!- mjs-de [~mjs-de@g224185024.adsl.alicedsl.de] has joined #wesnoth-dev 20120402 10:33:25< faryshta> shadowm, in this case which would be the proper command? Supposing I have both files (new and old) on my local drive. 20120402 10:35:59< shadowm> okay, you are not really required to have both files, and that would defeat the point of using svn 20120402 10:36:21< shadowm> svn can tell the differences in the working copy by itself since it tracks the original contents 20120402 10:38:33-!- faryshta [~faryshta@201.137.111.236] has quit [Ping timeout: 244 seconds] 20120402 10:49:23-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 260 seconds] 20120402 10:50:34-!- faryshta [~faryshta@201.137.107.113] has joined #wesnoth-dev 20120402 10:53:30-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has joined #wesnoth-dev 20120402 10:53:48< gravito> hello 20120402 10:54:04-!- enchilado [~enchilado@219-88-47-58.dialup.xtra.co.nz] has joined #wesnoth-dev 20120402 10:54:16-!- enchilado [~enchilado@219-88-47-58.dialup.xtra.co.nz] has quit [Changing host] 20120402 10:54:16-!- enchilado [~enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20120402 10:54:34< gravito> need certain help with easy lua ai development idea, please ping 20120402 10:54:59-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 10:58:39-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 11:10:10-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has quit [Quit: Page closed] 20120402 11:15:53-!- bloodycoin_m [~bloodycoi@193.170.135.78] has joined #wesnoth-dev 20120402 11:20:55-!- Crab_ [Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20120402 11:26:09< faryshta> shadowm, looks like svn can't do what I am intending. Do you know any other software to create .patch files? 20120402 11:27:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120402 11:27:45-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Ping timeout: 260 seconds] 20120402 11:27:46-!- hankerspace [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev 20120402 11:28:09-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has joined #wesnoth-dev 20120402 11:30:39-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120402 11:31:32< Crab_> faryshta: diff (you'll need two copies of the file(s) to compare) 20120402 11:32:09< Crab_> ejls: I've wanted to speak to you about 'Hunt down other validity check in the action hierarchy and move them to mapbuilder. ' item from your timeline 20120402 11:32:45< Crab_> ejls: please ping me when you'll have a few minutes for that. 20120402 11:36:05-!- mjs-de [~mjs-de@g224185024.adsl.alicedsl.de] has quit [Ping timeout: 246 seconds] 20120402 11:37:12-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120402 11:40:39-!- neph [~neph@02de475b.bb.sky.com] has joined #wesnoth-dev 20120402 11:41:43< Crab_> neph: hello 20120402 11:42:58< Crab_> neph: If you plan to apply, don't forget to submit your application to Google until 6th April (better do this before, i.e. now). We can only take applications submitted to google. 20120402 11:45:38-!- neph [~neph@02de475b.bb.sky.com] has quit [Ping timeout: 272 seconds] 20120402 11:46:27< Rhonda> lool, http://egoboo.sourceforge.net/phpBB3/viewtopic.php?p=61735#p61735 20120402 11:46:38< Rhonda> "It's woodmouse, I wouldn't listen to him about anything concerning the GPL 20120402 11:46:55< Rhonda> So he's already known as being a special person in the egoboo universe, too. :) 20120402 11:47:15-!- mihaineacsu [~Cookie503@p16.eregie.pub.ro] has quit [Quit: Linkinus - http://linkinus.com] 20120402 11:49:03-!- mjs-de [~mjs-de@g224185217.adsl.alicedsl.de] has joined #wesnoth-dev 20120402 11:53:05< Crendgrim> hehe 20120402 11:55:05-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 11:55:56-!- Tan_ [8984fa0d@gateway/web/freenode/ip.137.132.250.13] has joined #wesnoth-dev 20120402 11:56:22-!- Tan_ is now known as Guest34606 20120402 11:58:30-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 12:02:06-!- Guest34606 [8984fa0d@gateway/web/freenode/ip.137.132.250.13] has quit [Ping timeout: 245 seconds] 20120402 12:03:53-!- enchilado [~enchilado@defocus/yummy/enchilado] has quit [Quit: BBL->] 20120402 12:14:12-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has quit [Read error: Connection reset by peer] 20120402 12:16:17-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has joined #wesnoth-dev 20120402 12:22:22< hankerspace> Crab_: i've just read your comment on my Gsoc page ... I'm sorry i don't know it was your real name ... :s 20120402 12:22:29< Crab_> it's ok :) 20120402 12:24:04< Crab_> hankerspace: another important factor that I'd like to mention is the speed of responses - generally, if something is written on google-melange site, it's good if you answer quickly (So, you're doing well today :) ) 20120402 12:25:15< hankerspace> Alright Crab_, i've not reponded to Mark De Wever because i want to complete my wiki page before told him. 20120402 12:25:39< Crab_> hankerspace: ok. even a 'thanks I'll do it' is useful response, actually :) 20120402 12:25:43< hankerspace> But i'm pretty fast to awnser usually :) 20120402 12:26:42< Crab_> happygrue: yes. it's just that if a page has got a note from mentor and no answer from student in some days, it's not proper. So, it's best to answer quickly - that shows that you're indeed fast to answer :) 20120402 12:26:49< hankerspace> I understand Crab_ i'll didn't do this misstake again. 20120402 12:27:44< Crab_> hankerspace: ok, thanks. as usual, ask questions if there's any. 20120402 12:28:29-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120402 12:29:31< hankerspace> Sure Crab_, as i said, i have a lot of projects and homework this week so i'll take a while to totally complete my wiki page. 20120402 12:29:54< Crab_> yes, it's ok. it's good that you've done the patches already. 20120402 12:31:41< hankerspace> I hope my implementation of duration= patch is good ? I've updated it with the last svn version and mordant advises. Ask if you have any problems again 20120402 12:34:31< Crab_> yes, it's good. 20120402 12:34:37< Crab_> it'd be committed soon. 20120402 12:37:13< hankerspace> Alright, thanks a lot Crab_ 20120402 12:49:55< Crendgrim> does "AddOnName.pbl" instead of "AddOnName/_server.pbl" still work in 1.10 / 1.11? 20120402 12:55:11-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 12:59:02-!- thethomaseffect1 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 13:17:46-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 246 seconds] 20120402 13:21:43-!- faryshta [~faryshta@201.137.107.113] has quit [Remote host closed the connection] 20120402 13:22:19-!- faryshta [~faryshta@201.137.107.113] has joined #wesnoth-dev 20120402 13:30:05-!- hankerspace [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has quit [Ping timeout: 244 seconds] 20120402 13:43:11-!- matthiaskrgr [matthiaskr@109.73.162.119] has quit [Remote host closed the connection] 20120402 13:49:49-!- wesbot changed the topic of #wesnoth-dev to: 1.10.2 planned for April 7th, string freeze for branches/1.10 | Wesnoth accepted in GSoC 2012 | http://wiki.wesnoth.org/SummerOfCodeIdeas | 165 bugs, 328 feature requests, 15 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120402 13:50:10-!- SankaD [c0f8086a@gateway/web/freenode/ip.192.248.8.106] has joined #wesnoth-dev 20120402 13:55:28-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 13:59:14-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 14:03:46-!- SankaD [c0f8086a@gateway/web/freenode/ip.192.248.8.106] has quit [Ping timeout: 245 seconds] 20120402 14:08:42-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev 20120402 14:21:14-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 14:26:55-!- sanaris [~teupollam@46.147.243.138] has joined #wesnoth-dev 20120402 14:37:25< fendrin> hello 20120402 14:39:58< Crab_> hi, fendrin 20120402 14:46:49-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev 20120402 14:47:40< fendrin> Okay, for all the new gui elements is no space in the editor at 800 horizontal resolution. 20120402 14:48:04< fendrin> Thus I will go with smaller buttons and no infoboxes on that resolutions. 20120402 14:49:14< fendrin> This means, higher resolutions do feature a unit box like it is known from the game itself the user of the editor at lower resolutions does not have it. 20120402 14:49:38< Crab_> well, at small resolution you have to throw out something... 20120402 14:49:42< fendrin> Same for the infobox about the current active side. 20120402 14:49:50< fendrin> Crab_: Please throw :-) 20120402 14:50:26< Crab_> fendrin: have you seen how key in Dwarf Fortress work? 20120402 14:50:37< fendrin> I have played it once. 20120402 14:50:48< fendrin> Great game. But I don't know about the tab key. 20120402 14:50:51< Crab_> fendrin: it cycles between screen split modes (1-3 different palens) 20120402 14:50:56< Crab_> *panels 20120402 14:51:19< Crab_> so, it's possible to have a smaller or a larger map, depending on preference, and a larger or smaller control area 20120402 14:51:57< fendrin> I see. 20120402 14:52:43< fendrin> Theme wml + gui0 does not feature that. But if a developer wants to enhance it... The question is if work on gui0 is still a good idea, better to go for gui2. 20120402 14:53:25< fendrin> Another thing is that out of KISS things the gui should look the same at all times (with the exception of some reduction for small resolutions) 20120402 14:53:34< fendrin> I think you know my opinion about KISS :-) 20120402 14:54:51< fendrin> Crab_: Another not quite related interesting idea I discovered when looking at other games is how the map editor of ASC handles the palette problem. 20120402 14:55:25-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 14:55:55< Crab_> fendrin: try how it works in Dwarf Fortress - it's useful enough. In high-end editors such as eclipse, there's a ton more ways of organizing the windows/palettes, btw. 20120402 14:56:04< Crab_> fendrin: how it handles it? 20120402 14:56:08< fendrin> Crab_: You can install it with "apt-get install asc" on a debian based system. 20120402 14:56:22< Crab_> i'll take a look (but not now) 20120402 14:56:36< fendrin> Crab_: Then execute asc_mapedit 20120402 14:56:56< fendrin> Pressing the tab key does turn the map into a map of all available terrain. 20120402 14:57:19< fendrin> Then you can choose the terrain there, tab back and do the editing. 20120402 14:58:14< fendrin> Crab_: I will have a look at Dwarf Fortress right now. Do I have to enter a special editor mode? 20120402 14:58:30< Crab_> fendrin: no, it's the game interface, after embarking and starting play 20120402 14:58:51< Crab_> fendrin: i.e. it's not an editor, it's a text menu with various commands, or a map 20120402 14:59:14< Crab_> and 'tab' cycles through various menu arrangements 20120402 14:59:27-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 15:00:03< Crab_> fendrin: you can just compare http://afteractionreporter.files.wordpress.com/2009/02/dftutorial02.png?w=600 and http://afteractionreporter.files.wordpress.com/2009/02/dftutorial03.png?w=600 20120402 15:00:36< Crab_> (but they have more modes than those two) 20120402 15:00:42-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Quit: Leaving] 20120402 15:01:00-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 15:01:28-!- ancestral [~ancestral@97-127-62-183.mpls.qwest.net] has joined #wesnoth-dev 20120402 15:02:07-!- ancestral [~ancestral@97-127-62-183.mpls.qwest.net] has quit [Client Quit] 20120402 15:02:19-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Client Quit] 20120402 15:03:39< fendrin> Crab_: I see. Let's keep the idea in mind for later after another gui overhaul porting the theme wml to gui2. 20120402 15:03:43< Crab_> ok 20120402 15:04:19-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 15:08:04-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 245 seconds] 20120402 15:09:09-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 15:09:54-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120402 15:13:38-!- neph [~neph@02de475b.bb.sky.com] has joined #wesnoth-dev 20120402 15:13:47-!- liviuc [~liviu@p5.eregie.pub.ro] has joined #wesnoth-dev 20120402 15:13:59-!- liviuc [~liviu@p5.eregie.pub.ro] has left #wesnoth-dev [] 20120402 15:15:46-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 252 seconds] 20120402 15:19:59-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 15:21:00< CIA-69> zookeeper * r53752 /trunk/ (3 files in 2 dirs): Changes to the schedules of Fallenstar Lake and Silverhead Crossing, as requested by Doc Paterson. 20120402 15:24:22-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 244 seconds] 20120402 15:25:01< CIA-69> zookeeper * r53753 /branches/1.10/ (3 files in 2 dirs): Ported r53752 to 1.10. Shouldn't have any unwanted consequences. 20120402 15:25:53-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 15:30:37-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 276 seconds] 20120402 15:30:58-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 15:38:03-!- matthiaskrgr [matthiaskr@184.171.255.77] has joined #wesnoth-dev 20120402 15:38:19-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 244 seconds] 20120402 15:38:35-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 15:49:30-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 252 seconds] 20120402 15:55:35-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 15:59:17-!- thethomaseffect [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 16:01:41-!- bloodycoin_m [~bloodycoi@193.170.135.78] has quit [Remote host closed the connection] 20120402 16:04:12-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 16:08:29-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 245 seconds] 20120402 16:08:32-!- sanaris [~teupollam@46.147.243.138] has quit [Ping timeout: 265 seconds] 20120402 16:08:54-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120402 16:10:04-!- sanaris [~teupollam@37.113.146.102] has joined #wesnoth-dev 20120402 16:11:13< ejls> Crab_: Hi. :) 20120402 16:11:30< Crab_> ejls: hello 20120402 16:11:43-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 265 seconds] 20120402 16:12:12< Crab_> basically, I've wanted to note some things about the whiteboard 20120402 16:12:47< Crab_> whiteboard allows to plan actions and should have a way to simulate them and check their validity 20120402 16:13:08< Crab_> if those checks are implemented inside the whiteboard, it is doomed to play catchup with the game engine 20120402 16:13:35< Crab_> for example, when someone introduces per-leader recall lists or variable recall list costs, recall planning can/will break. 20120402 16:14:07< ejls> Hum, yeah but this code will be in the whiteboard anyway. 20120402 16:14:10< Crab_> a better solution would be to refactor the game engine itself to allow simulating actions (i.e. without events being fired and with different animation, etc) and checking their validity 20120402 16:14:24< ejls> oh... 20120402 16:14:26< Crab_> then, the whiteboard (and the AI, as well) would not need to know the details of the game rules. 20120402 16:14:59< Crab_> since the same code would be used both for executing the action and for validating/simulating it, no matter if it is AI, UI, or WB 20120402 16:15:39< Crab_> and those kinds of changes happen fairly often, i.e. see https://gna.org/patch/?3234 20120402 16:16:33< Crab_> And, even better, it'll allow better lua access to those actions (right now, some tags like harm_unit have some code duplication in them because they try to mimic the behavior of the game engine) 20120402 16:16:53< Crab_> That's what I've wanted to tell you (after reading your proposal and timeline) 20120402 16:17:00< Crab_> what do you think? 20120402 16:17:26< ejls> Ok, I see, I only (more or less) know the structure of the whiteboard right now, so I don't really have an idea on how to do this. 20120402 16:18:25< ejls> I mean, moving the action hierarchy out of the wb module can be done, but after this I don't yet know how I could integrate in other module. 20120402 16:18:54-!- horon [~horon@nttkyo322045.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120402 16:18:56< ejls> But, it looks like a good idea yeah. 20120402 16:20:16< Crab_> ejls: check src/game_events.cpp, usage of unit_creator, for an example of how the API might look like. http://pastebin.mozilla.org/1550671 20120402 16:20:31< ejls> Let's ask gabba the next time he shows up. :) 20120402 16:20:42< Crab_> do so) 20120402 16:26:44-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 16:35:21-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has quit [Remote host closed the connection] 20120402 16:37:10-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has joined #wesnoth-dev 20120402 16:38:23-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 252 seconds] 20120402 16:50:36-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 16:51:58-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20120402 16:54:47< Ayne> hey 20120402 16:55:12-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 244 seconds] 20120402 16:55:36-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 16:55:37< Ayne> Crab_: sorry I haven't managed to provide any patches yet, I had some computer issues I had to solve first before I could compile Wesnoth 20120402 16:56:04< Crab_> Ayne: let us know if there'll be questions about compilation that we might assist with. 20120402 16:56:48-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 16:56:54< Crab_> Ayne: you still have time to provide patches. 6th April is the student application submission deadline (which you have already submitted to google), and there might be up to one week after that where the students are not yet decided. 20120402 16:57:37< Crab_> Ayne: so, good luck but note that the project you have selected requires a lot of C++ coding, so we really want to see several patches. 20120402 16:57:50< Ayne> Crab_: I can compile it now, I'd just forgotten that my Windows has been refusing to compile C++ for the past 2 years and my Linux laptop had to be sent in to repairs, so I had to get another computer from somewhere first.. All solved now though 20120402 16:57:59< Crab_> Ayne: that's great. 20120402 16:59:30-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 16:59:57< Ayne> Crab_: By the "add comments task" you mean adding log outputs to playcampaign.cpp, right? 20120402 17:00:10< Crab_> yes 20120402 17:01:16< Crab_> basically, we want to take the config as early as possible after game ends, and then do some changes, and then begin/continue another game. 20120402 17:01:28< Crab_> and, playcampaign.cpp is where most of this stuff happens. 20120402 17:01:42< Ayne> Crab_: ok. I've seen a couple log outputs while looking through the code in general. Is there anywhere that has an overview of the different types of logs? 20120402 17:02:45< Crab_> not really. see the command line switches --logdomains and --log-level="domain" 20120402 17:02:52< Crab_> basically, you can invent log domains on the spot 20120402 17:03:09< Crab_> and they can be nested, so --log-debug='ai/*' would work 20120402 17:03:44< Crab_> you can also read the implementation, it's really small and good and is in src/log.?pp 20120402 17:05:43< Ayne> ok, thanks 20120402 17:06:56-!- sanaris [~teupollam@37.113.146.102] has quit [Ping timeout: 260 seconds] 20120402 17:11:57-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 265 seconds] 20120402 17:13:09-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 17:15:27-!- N_Pole93 [c7d4098a@gateway/web/freenode/ip.199.212.9.138] has joined #wesnoth-dev 20120402 17:15:38< N_Pole93> hi guys, I have a question about a comment i've received 20120402 17:15:45< N_Pole93> says i need to show you guys a replay 20120402 17:15:57-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has joined #wesnoth-dev 20120402 17:16:17< N_Pole93> does that mean I have to play a real-time strategy game and record myself playing defensively? 20120402 17:16:41< N_Pole93> using something such as fraps? 20120402 17:17:56< Crab_> N_Pole93: replays are built-in feature of wesnoth. 20120402 17:17:58< loonycyborg> Nope. A replay is basically a saved game. 20120402 17:18:10< Crab_> N_Pole93: a saved game can be loaded as a replay 20120402 17:18:24-!- gabba [~gabba@wesnoth/developer/gabba] has joined #wesnoth-dev 20120402 17:19:20< Crab_> N_Pole93: I've asked you to provide that replay via the comment in google's system because at this point it's probably too hard to provide a proper algorithm for the AI-defense-ideas, but it should be possible to play a game in the way you want the AI to play it 20120402 17:19:24-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 272 seconds] 20120402 17:19:29< gabba> Hi all 20120402 17:19:41< Crab_> and, this will show us, basically, what you're proposing the AI to do. 20120402 17:20:25-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 17:21:45< gravito> can someone provide me further clarifications regarding recruiting algorithm 20120402 17:21:55< Crab_> gravito: hello. I can 20120402 17:22:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120402 17:23:04< Crab_> gravito: any particular questions? or you just want me to explain the current problems in more detail? 20120402 17:23:19< Crab_> gravito: just ask 20120402 17:23:36< gravito> just the detailing 20120402 17:23:52< gravito> sorry for the naive question 20120402 17:23:53< gravito> especially, as to how or what we are required to do 20120402 17:25:47< Crab_> it's ok to ask 20120402 17:26:25< Crab_> so, what's recruitment from the C++ point-of-view? it is basically, a class with two public functions 20120402 17:26:40< Crab_> first function answers the 'should we recruit now?' question with yes or no. 20120402 17:26:55< Crab_> second function actually does the recruiting, if called 20120402 17:27:18< Crab_> it has access to full game state (all teams, all units, all recalls, all recruit lists, all terrain, etc) 20120402 17:27:30< Crab_> anything inside is a black box, and you can implement it as you want to. 20120402 17:27:39< Crab_> Is this part clear, so far? 20120402 17:27:51< gravito> yes 20120402 17:28:13< Crab_> ok. then, we have a recruit class now. it works, but we are not happy with it 20120402 17:28:37< Crab_> you can read the source and find out how it works, or you can ask questions. 20120402 17:29:01< gravito> i am reading the source as of typing, can u please point to the specific recruit classes and function in the source 20120402 17:29:36< Crab_> we want to code a new one during the summer; and we want to be more happy with the new one. 20120402 17:30:03< Crab_> the copy of the old one is in src/ai/testing/ca_testing_recruitment.cpp (and .hpp) 20120402 17:31:09< Crab_> (an no, sorry, in those (^) files there's a partial work-in-progress copy, disregard the above message) 20120402 17:32:41< gravito> So basically, we need to code a new public recruit class which would enhance the previous functionalities and add new ones. 20120402 17:33:56< gravito> Do point to the source file. And any further tips which i should know about that would help in the application. Really excited to work on this! 20120402 17:34:05-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 260 seconds] 20120402 17:34:53-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20120402 17:34:53-!- Upth is now known as Upthorn 20120402 17:35:16< Crab_> see src/ai/default/ai.cpp ai_default_recruitment_stage::do_play_stage() 20120402 17:35:32< Crab_> yes, we need to code a new public recruit class which would enhance the previous functionalities and add new ones. it's ok to rewrite from scratch. 20120402 17:36:42< Crab_> yes, that's a good project and quite exciting. 20120402 17:37:23-!- s951 [~s951@cpc31-cmbg15-2-0-cust850.5-4.cable.virginmedia.com] has joined #wesnoth-dev 20120402 17:37:32< Crab_> gravito: apart from studying the source, we need you to show how you code (by submitting 1-2 patches/bugfixes, even unrelated to recruitment) 20120402 17:38:03< Crab_> gravito: and, also we need to see your google application with lots of details and timelines/goals. 20120402 17:38:40-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 276 seconds] 20120402 17:39:24-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 17:39:33-!- mats_ [~mats@fw.hia.nrc.ca] has joined #wesnoth-dev 20120402 17:39:37< gravito> i am kinda new to this, but i am a passionate about gaming and development. so i might not be able to provide patches/bug fixes right now. Does it affect the application or recruitment? 20120402 17:40:34-!- mats_ [~mats@fw.hia.nrc.ca] has quit [Client Quit] 20120402 17:41:04< Crab_> Basically, this is summer of code, and so we want to accept students which can code C++. So, that's why we ask for patches. You have about 1.5-2 weeks for us to consider those patches during evaluation of your proposal. 20120402 17:41:28< Crab_> usually, it's possible to find some stupid bug or two which are easily fixable :) 20120402 17:41:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20120402 17:41:56< Crab_> Is there anything else you want to ask? 20120402 17:42:10< gravito> thanks a lot for the help! 20120402 17:42:17< gravito> you guys are really friendly! 20120402 17:43:14-!- stikonas [~gentoo@ctv-217-147-37-55.vinita.lt] has joined #wesnoth-dev 20120402 17:43:14-!- stikonas [~gentoo@ctv-217-147-37-55.vinita.lt] has quit [Changing host] 20120402 17:43:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120402 17:46:28< Crab_> gravito: I'll copypaste a description of the problem points to the idea page in a minute or two 20120402 17:46:55< s951> Hi, new SoC person here. What do I need to do to get started? 20120402 17:47:37< Crab_> s951: hello! 20120402 17:48:01< Crab_> s951: short list: pick a project, submit application to google about your project 20120402 17:49:21< Crab_> s951: then, persuade us to accept you. to do this: 1) compile wesnoth and submit 1-2 patches/bugfixes. 2) find out what is required in the project and write a good project description - see http://wiki.wesnoth.org/MP_Server_Ilor for an example of good description 3) talk with us if you have questions. 20120402 17:50:21< Crab_> s951: you have about a week to do it, plus a few extra days next week (but note that you must submit your application to google until 6th April, so do so NOW.) 20120402 17:50:27< gravito> ok 20120402 17:50:51< Crab_> (sometimes people just forget about the google's application, which is bad - we can't accept anyone who hasn't submitted an application to google) 20120402 17:51:12< gabba> faryshta: around? 20120402 17:52:25< Crab_> gravito: see the IRC transcript at http://wiki.wesnoth.org/SoC_Ideas_AI_Recruitment_2012#More_info_.28irc_transcript.29 20120402 17:53:01< gravito> thanks 20120402 17:54:33< s951> Ah, Crab_, you're the one to see about refactoring recruitment? 20120402 17:54:53< ejls> gabba: hey, have you read Crab_ message? 20120402 17:55:35< Crab_> s951: yes, that's me 20120402 17:55:48-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 17:56:50< Crab_> s951: If you want to know more about the recruitment algorithm project, please read http://www.wesnoth.org/irclogs/2012/04/%23wesnoth-dev.2012-04-02.log from "20120402 17:21:45" , and ask if you have any other questions. 20120402 17:59:21-!- thethomaseffect2 [thethomase@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 18:03:37< gabba> ejls: Hi! Nope, did he leave it for me on IRC? 20120402 18:04:42< ejls> gabba: Well, actually it was for me, but I think it's more your choice than mine. It was today around 16h. 20120402 18:04:58< gabba> ok, checking the log 20120402 18:04:58< Crab_> ( 20120402 16:11:13 - 20120402 16:20:42 ) 20120402 18:06:07< gabba> Oh Crab_, btw: what do you think about this wonderful line of code :P ? int cost = un.recall_cost() || current_team.recall_cost(); 20120402 18:06:35< ejls> Actually, the sole thing preventing the use of the wb's validation system is that the action hierarchy is not used outside of it. 20120402 18:06:40-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev 20120402 18:07:33-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has quit [Remote host closed the connection] 20120402 18:07:51-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev 20120402 18:07:55< Crab_> gabba: I think that it is a shortcut of int cost = (un.recall_cost() != default_recall_cost) ? un.recall_cost() : current_team.recall_cost(); with default_recall_cost set to 0 20120402 18:08:34-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has quit [Client Quit] 20120402 18:08:35< Crab_> gabba: so, if we are fine with not allowing the per-unit recall cost to be 0, the code would work. 20120402 18:08:51< Crab_> gabba: but, I'd prefer to allow per-unit recall cost of 0, if so desired. 20120402 18:08:58-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev 20120402 18:09:11< Crab_> gabba: so, a default such as -1 would make more sense, so the formula would have to be rewritten by the patch author. 20120402 18:09:46-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120402 18:10:30< gabba> ejls: ok, found it and reading 20120402 18:10:44-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 244 seconds] 20120402 18:11:27< gabba> Crab_: huh? Seriously a shortcut? Have to look at it again, but if it does work it's the most counter-intuitive piece of code I've come across so far. 20120402 18:11:50< gabba> Usually people keep binary logic operators like that for... binary logic? 20120402 18:13:00< ejls> Humm… actually in c++ the logical operators return boolean, so I don't think this expression is right. 20120402 18:14:11< Crab_> gabba: but yes, you're right, it won't work in c++ 20120402 18:15:12< Crab_> gabba: as it'll return 1 if any of the recall costs is non-zero. 20120402 18:16:04< gabba> Yeah, 1 or true isn't it. Well thanks for the confirmation, big wtf moment looking at that line =D ! 20120402 18:17:02< gabba> Actually the expression will return a bool with the true value which will then be casted to the int 1, I believe. 20120402 18:17:31< Crab_> yes, it'll be integer 1 20120402 18:18:09< gabba> Ok so about the action simulation thing: very interesting, hmm 20120402 18:19:14< Crab_> the basic idea is to avoid code duplication 20120402 18:19:25< ejls> gabba: To be sure that I understand correctly, the problem is that the action hierarchy isn't used outside of the whiteboard right? Otherwise, every other piece of code could use the mapbuilder right? 20120402 18:20:12< gabba> Crab_: basically, your proposal amounts to getting the verification code out of the whiteboard so that people have to update it when they change related stuff, isn't it? 20120402 18:20:28< Crab_> yes, and more 20120402 18:20:55< gabba> ejls: not really 20120402 18:21:04< Crab_> as both the game and the ai have to verify the actions (to a different degree of verification) 20120402 18:21:32< gabba> right now it's separate for design concerns, but you could use whiteboard pieces elsewehere if needed 20120402 18:21:33< ejls> Hum, so what would need to be changed? 20120402 18:21:35< Crab_> gabba: so, after getting the verification code out of the whiteboard, we can make the game engine use it instead for verification of actions (and for basic execution of actions, such as reducing gold after recall) 20120402 18:21:43-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.] 20120402 18:22:08< Crab_> we should probably start a new file in src for this, as src/actions is too messy 20120402 18:22:22< gabba> still trying to wrap my brain around Crab_'s idea myself :P (as usual, he he) 20120402 18:23:19< Crab_> gabba: imagine an api function to check if it is possible to recruit unit X on location Y. this function can be used by UI, by AI, and by whiteboard 20120402 18:24:03< Crab_> gabba: and, if someone changes the recruit cost calculation (i.e., giving leader X a 25% discount on trolls during the night), it'll only happen in one place, and both AI and UI and whiteboard would stay in sync. 20120402 18:24:30-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 18:24:49< gabba> Ok, sounds good. So the task for ejls to create that would be to gather the relevant code from whiteboard and AI and of course refactor so they use it. 20120402 18:25:00< Crab_> currently, src/actions.cpp has bool can_recruit_on(const gamemap& map, const map_location& leader, const map_location& loc); 20120402 18:25:16< Crab_> note how it is incomplete by not including the unit type 20120402 18:25:28< Crab_> from whiteboard, from AI, and from UI 20120402 18:25:31< Crab_> we have three users. 20120402 18:25:58< Crab_> or, even 4, if you count replays 20120402 18:26:33< Crab_> AIs code is in src/ai/actions.?pp 20120402 18:26:33< gabba> You mean we have to support them, or they already implement their own similar checks? 20120402 18:26:42< Crab_> both 20120402 18:26:45-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120402 18:27:09< Crab_> gabba: we would be able to unify the checks, leaving only one place 20120402 18:27:26< gabba> Crab_: I like the idea, but what about GSoC feasability? 20120402 18:27:42< ejls> Ok, so the mapbuilder would only have to call these check functions, which would take basic UDT as parameter (like map_location objects instead of a wb::move) ? 20120402 18:28:15< ejls> (I'm still trying to get the idea :) ) 20120402 18:28:26< gabba> Sorry, UDT? 20120402 18:28:39< ejls> User Defined Types 20120402 18:28:59< Crab_> gabba: I'll help, if necessary. it's not that hard. 20120402 18:29:10-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 18:29:16-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120402 18:29:22< gabba> I feel like an idiot, but I don't see what UDT means in this context. 20120402 18:29:24< ejls> (A more generic term for class) 20120402 18:29:41< gabba> Ahhh, see that helps. 20120402 18:29:47< Crab_> ejls: it's possible. but, why not extract wb::move to something like wesnoth_move and make an api which works with them ? 20120402 18:30:01< ejls> It's just that I don't know if map_location is a class, a struct or even a template, so I used UDT instead. :) 20120402 18:31:20< Crab_> ejls: i.e, instead of bool can_recruit_on(const gamemap& map, const map_location& leader, const map_location& loc); , we would have action recruit_action(leader, loc, unit_type); if (action.valid_now()) { ....; action.execute(); ... } 20120402 18:31:43< ejls> Crab_: I can certainly do this as part of a GSoC, but then updating the AI, UI and replays to use it might take some more time. 20120402 18:31:55< Crab_> I'll help, especially with the AI part. 20120402 18:32:17< Crab_> I think that there should not be a need to have multiple data transfer objects for moves/attacks/recalls/recruits 20120402 18:33:11< ejls> Hum, but this new API is only for checking a single action, not to build a future state with it? 20120402 18:33:47< Crab_> well, to build a future state, you do some whiteboard specific stuff that the engine should not be aware of, then do the usual action but without firing events or revealing shroud. 20120402 18:33:47< gabba> Yeah, generifying the wb actions and moving them to the engine makes sense as Crab_'s describing it. You can still store them in side_actions objects for the whiteboard. 20120402 18:33:49-!- akzfowl [~akzfowl@1.186.12.45] has joined #wesnoth-dev 20120402 18:34:14-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 18:34:28< Crab_> basically, a move can move unit from X to Y, or it can do the same while revealing shroud/causing ambush/sighted events, etc 20120402 18:34:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120402 18:34:45< ejls> Yes, that sound nice. 20120402 18:34:53-!- molgrum [~molgrum@h-189-21.a189.priv.bahnhof.se] has quit [Quit: Lämnar] 20120402 18:34:59< Crab_> the engine should not know about the whiteboard, as far as possible 20120402 18:35:20< Crab_> but it's totally ok to have some modes of operation which are useful for dummy moves 20120402 18:36:11< gabba> Crab_: but, while we're at it, can't we add several options to each action type: simulate, execute (with or without events or shroud), even perhaps undo/redo with some additional data (but that's stretching it) 20120402 18:36:23< Crab_> gabba: yes, exactly 20120402 18:36:58< gabba> It sounds great on paper, but the code isn't structured at all in this way right now 20120402 18:37:02< Crab_> gabba: see http://pastebin.mozilla.org/1550671 for an example of action-with-options 20120402 18:37:17< Crab_> (it's internal 'place unit on map' action) 20120402 18:37:37< Crab_> well, a refactoring is required 20120402 18:37:53< Crab_> as a side effect, we can take steps to separate the gui from the engine 20120402 18:38:17< gabba> For instance in the mouse handler code, right now clicking directly calls the attack triggering code, which interacts with many things 20120402 18:38:17< Crab_> i.e. to let the engine know less about the animations/screen effects, calling them indirectly 20120402 18:38:43< gabba> For this refactoring, you'd have to first create an attack object, then execute it 20120402 18:38:45-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 248 seconds] 20120402 18:38:49< Crab_> well, there's always a couple of messy places 20120402 18:38:57< Crab_> yes, you're right 20120402 18:39:20-!- Teugon [~Teugon__@2-234-35-21.ip221.fastwebnet.it] has joined #wesnoth-dev 20120402 18:39:40< gabba> But then you have to handle tough questions like, does the attack object handle refreshing various screen elements, unselecting stuff - things I kinda had to copy into the wb for lack of a better solution. 20120402 18:40:22< gabba> or not copy into the wb, but duplicate in part to with-wb and without-wb alternate code paths 20120402 18:40:32-!- s951 [~s951@cpc31-cmbg15-2-0-cust850.5-4.cable.virginmedia.com] has quit [Quit: Leaving] 20120402 18:40:41< Crab_> at least, the attack object should not do it directly 20120402 18:40:56< Crab_> there's a number of ways to separate those stuff 20120402 18:41:09< Crab_> but, to start, we just need to find a good name for a new file in src 20120402 18:41:30< Crab_> then, we can code some kind of API in there (but not use it, so far) 20120402 18:41:34< Ivanovic> gabba: could you join the mentor chan, too 20120402 18:41:39< gabba> sure 20120402 18:41:40< Crab_> and then gradually start moving things over 20120402 18:42:25< Teugon> Hi all, 20120402 18:42:26< Teugon> I'm looking for Iurii Chernyi. He/She left a comment on GSoC application. 20120402 18:42:45< gabba> ejls: you following so far? 20120402 18:43:45< ejls> gabba: yes, yes. I understood the idea. 20120402 18:43:55-!- HappyKsuh [~ksu.nyaka@host-58-152-66-217.spbmts.ru] has joined #wesnoth-dev 20120402 18:45:06< gabba> Crab_: can you elaborate on what you pastebined: is it an example from current code or what you have in mind? 20120402 18:45:17< Crab_> it's example from game_events.cpp 20120402 18:45:26< gabba> (Not at my dev machine, otherwise I'd search, sorry 'bout that) 20120402 18:45:42< gabba> Ok, and what is it supposed to exemplify? 20120402 18:45:59< Crab_> It's used to extract the common code placing units on map, to be used both during team construction and by [unit] tags in events. 20120402 18:46:27< Crab_> it's supposed to show an example of an API which allows to have a lot of optional parameters tuning the behavior of the action. 20120402 18:46:48< Crab_> basically, a builder pattern of sorts. 20120402 18:47:47< gabba> ok, got it. A bit miffed by the object.do().something().clever().with().returning().this(), but it seems handy 20120402 18:48:02< ejls> Looks like a Name Parameter pattern to me… 20120402 18:49:00-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: I'm asleep] 20120402 18:51:05-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120402 18:54:11< Teugon> can someone tell me which is the nick for Iurii Chernyi, he/she asked me to come irc to talk about GSoC application. 20120402 18:55:02< hankerspace_> It's Crab_ 20120402 18:55:19< Crab_> Hello, Teugon 20120402 18:55:48< Crab_> ejls: yes, you're right 20120402 18:55:48-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 18:56:24< Teugon> Crab_: should we talk in a private room, or in this public one ? 20120402 18:57:35< Crab_> Teugon: basically, I wanted to ask if you have any questions about the project, and note again that you'll have to do at least 1-2 patches. 20120402 18:57:42< Crab_> Teugon: Public is better, because other students would benefit from answers 20120402 18:57:50< Crab_> also, other mentors would see your activity on IRC 20120402 18:58:05< Crab_> but, if you want, you're welcome to use private chat. 20120402 18:58:44< hankerspace_> !seen mordante 20120402 18:59:33-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 246 seconds] 20120402 19:00:00< ejls> wesbot seen mordante 20120402 19:00:00< wesbot> ejls: The person with the nick mordante last spoke 19h 31m ago. 19h 31m ago was here and on the channel #wesnoth-de with the message: Quit: Leaving 20120402 19:00:04< ejls> hankerspace_: ^ :) 20120402 19:01:31-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120402 19:02:17-!- omg_scout [~krzysztof@031011180225.warszawa.vectranet.pl] has joined #wesnoth-dev 20120402 19:03:43-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 19:04:35< hankerspace_> thanks ejls :) 20120402 19:06:49-!- sankaD [~sanka@61.245.165.57] has joined #wesnoth-dev 20120402 19:08:30< Teugon> Crab_: I don't have question about the project. I've started today to learn C++, thus I've still not seen wesnoth source code. 20120402 19:08:30< Teugon> Crab_: I know my position not be that way good to say this, but I don't know if I'll ever have time to commit that 1-2 patches you talk about. I don't know because I'm studying hard to both graduate and save time for GSoC 20120402 19:08:30< Teugon> Crab_: how much time do I have to commit those patches if they are this required? I've read at http://wiki.wesnoth.org/SummerOfCodeIdeas it's not mandatory and it could be exchangeable with a draft of the project. what can you tell me? 20120402 19:09:36-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 272 seconds] 20120402 19:09:37-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20120402 19:09:51< mordante> servus 20120402 19:10:44< hankerspace_> Hello mordante, i've just awnser you on gna 20120402 19:10:44< Crab_> Teugon: yes and now. in general, some patches are really easy, i.e. people have found some bugs which required 1-2 lines to fix. 20120402 19:10:52< Crab_> *and no 20120402 19:11:07< mordante> hi hankerspace_ 20120402 19:11:09< Crab_> Teugon: you have around a week plus several days 20120402 19:11:17< mordante> hankerspace_, ok will have a look 20120402 19:11:37< mattsc> Hello all 20120402 19:11:48< Crab_> hi, mattsc 20120402 19:11:59-!- {V} [~V@139-79-ftth.onsneteindhoven.nl] has quit [Read error: Connection reset by peer] 20120402 19:12:09< mattsc> Hi Crab. 20120402 19:12:37< mattsc> I've been checking out the logs a few times lately because I'm interested in the SoC AI projects. 20120402 19:12:53< mattsc> I saw my name mentioned a couple times, so I thought I figure out how to check in here. 20120402 19:14:11< mattsc> I'll try to be online a couple times a day for the next week or two. 20120402 19:14:33-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 19:14:45< Teugon> Crab_: does worth something the link with my C code I provided at http://wiki.wesnoth.org/Soc2012_Teugon_Refactor_Recruitment_Algorithm ? 20120402 19:15:51< ejls> mordante: Hi, do you think using LaTeX was a good idea for the GUI2 design document? (I'm the student who proposed the Whiteboard Design Document) 20120402 19:16:34< gabba> ejls: Ok, so if you feel comfortable with a slighly enlarged scale and a bit tougher project, I'm favorable to doing it like Crab_ envisions. 20120402 19:16:55< gabba> ejls: as a bonus, you'll probably learn more, and you'll contribute to more than just the whiteboard 20120402 19:17:14< Crab_> Teugon: yes, it's worth something. Definitely better than nothing, and we can see your style in the code. 20120402 19:17:30< Crab_> Teugon: but, patches to wesnoth are better for our purposes. 20120402 19:17:59< Crab_> Teugon: because, patches to wesnoth also measure how you can deal with deadlines when you have a limited time to code something useful during GSoC application period. 20120402 19:18:14< ejls> gabba: Yeah, actually it sounds great, so of course I would like to do it. But well, I'll certainly need more help. 20120402 19:19:20< ejls> I'll also change my timetable to start coding during the community bounding period. 20120402 19:19:42< mordante> ejls, yes why? 20120402 19:19:54-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 19:20:13< ejls> mordante: Well, I don't really know what to use and since you wrote a similar document I wanted to have your view. :) 20120402 19:20:17< Teugon> Crab_: I do understand. It seems I'll have a good easter :D. 20120402 19:20:48< Crab_> we will consider all the work done on easter weekend when we'll evaluate proposals. 20120402 19:21:00< gabba> ejls: as far as preparing for GSoC, you still have to detail the mapbuilder part anyways, so you can start drafting it as we discussed - that'll give you a better idea of the work involved, and we can always revert to the original idea if it sounds a bit too insane after all. 20120402 19:21:00-!- mjs-de [~mjs-de@g224185217.adsl.alicedsl.de] has quit [Remote host closed the connection] 20120402 19:21:21< Crab_> Teugon: and, at this point, students are not yet selected - so, if your application would be among the best, it'll be in. 20120402 19:21:32< ejls> gabba: ok, yeah. 20120402 19:22:21< mordante> ejls, of course I'm biased, I picked it because I thought it was a good tool ;-) 20120402 19:22:27< ejls> mordante: I responded to your comment (http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/ejls/1) explaining why I wasn't sure about using LaTeX. 20120402 19:22:40< ejls> Ok. :) 20120402 19:22:46< mordante> ejls, haven't read it yet, catching up with all logs 20120402 19:22:49< gabba> ejls: remember to draft the architecture a bit, but also gather exemples of code you need to bring together from various areas - you could come up with draft united validation code for one of the actions, maybe. 20120402 19:25:07< mordante> hankerspace_, http://wesnoth.debian.net/%23wesnoth-dev-2012-03-31.log starting at 19:39 20120402 19:25:42< ejls> gabba: Yeah, but is there more action to plan for than what is already in the wb::action hierarchy? 20120402 19:25:59-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 19:26:17< ejls> 'Cause, if it's used by the UI, some action like "place unit" might make sense. 20120402 19:26:25< Teugon> Crab_:How do you classify students? I mean: when you are talking about the application to be among the best, are you talking about my patch/es, my past experience (I suppose) and what else? 20120402 19:26:30< ejls> (in which case we can derive recruit/recall from it) 20120402 19:26:35< ejls> That's just an example. 20120402 19:27:06< ejls> But I think there might be other cases like this one that I'm not aware of. 20120402 19:27:28-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20120402 19:27:56< hankerspace_> Alright mordante i've forgot it 20120402 19:28:24< Crab_> ejls: well, place_unit makes sense from debug interface of sorts. but, usually, player can't place units on map arbitrarily. 20120402 19:29:04< Crab_> Teugon: we are taking into account every relevant detail that we know of. to give a baseline, let's consider student patches, student IRC activity and his project implementation and timeline description. 20120402 19:29:23< ejls> I was thinking from a WML event, so I should stick to what is currently in the wb::action hierarchy? 20120402 19:29:37< gabba> ejls: that's pretty much something you'll have to find out with the help of Crab_ 20120402 19:30:16< ejls> ok :) 20120402 19:30:44< Crab_> ejls: well, WML events would need some functions/object like this, yes. but let's focus on our goal - our goal is, (un)fortunately not to clean out all the mess, but just remove the code duplication for attack/move/recruit/recall 20120402 19:30:50< gabba> I think what's in the action hierarchy is a good starting point, anyways. As you refactor you should be able to bring these in separately (ideally, hum) 20120402 19:31:19< Crab_> after that, the number of bugs in the whiteboard will go down. 20120402 19:31:21< gabba> ^this 20120402 19:31:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120402 19:31:44-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 246 seconds] 20120402 19:32:00< gabba> otherwise, your task would start turning into "rewrite wesnoth", which you definitely don't want :P 20120402 19:32:31-!- N_Pole93 [c7d4098a@gateway/web/freenode/ip.199.212.9.138] has quit [Ping timeout: 245 seconds] 20120402 19:32:32< ejls> hehe, yeah. 20120402 19:32:33< Teugon> Crab_; Thx for the answers 20120402 19:32:49-!- Teugon [~Teugon__@2-234-35-21.ip221.fastwebnet.it] has quit [Quit: Leaving] 20120402 19:33:30< ejls> Ok, I'll start thinking about it and I'll include in my proposal. 20120402 19:34:03< ejls> s/in /it &/ 20120402 19:34:07-!- gravito [0e8bd4e2@gateway/web/freenode/ip.14.139.212.226] has quit [Quit: Page closed] 20120402 19:34:08-!- neph [~neph@02de475b.bb.sky.com] has quit [Read error: Connection reset by peer] 20120402 19:34:12-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 19:34:13< Crab_> ejls: ok 20120402 19:34:49< omg_scout> Hello 20120402 19:35:31< hankerspace_> mordante: as i can read, i should use another name for max_duration variable ? But you (or another dev i can't remember) told me to use the prefix "max_" to add a "min_duration" later. 20120402 19:37:12< hankerspace_> and using "-1" instead of "0" didn't works ... Should i modify other files to be able to use "-1" instead of 0 ? mordante 20120402 19:37:33-!- Nephro [~Dmitry@02de475b.bb.sky.com] has joined #wesnoth-dev 20120402 19:37:36< gabba> hey omg_scout 20120402 19:37:49< mordante> hankerspace_, what do you mean with -1 doesn't work? 20120402 19:38:24< omg_scout> Gabba, I've read your email 20120402 19:38:55-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 246 seconds] 20120402 19:38:58< omg_scout> you mentioned some minor patches which would help dev's choose people with good code knowledge 20120402 19:39:12< gabba> omg_scout: yes 20120402 19:39:12< mordante> hankerspace_, regarding max/maximum we have different opions, however the variable in window.hpp is called auto_close_timeout 20120402 19:39:24< mordante> we as in the wesnoth developers* 20120402 19:41:29< hankerspace_> mordante: using "-1" when duration tag is not specified skip all ingame messages, using 0 makes them able to wait a key or a mouseclick 20120402 19:42:17< omg_scout> Could I for example do that multiple attacks performance problem as one of those minor patches? 20120402 19:43:27< hankerspace_> mordante: And i have to rename all my new variables in auto_close_timeout too ? 20120402 19:45:19< omg_scout> And another question - should I start with creating wiki page or the (more or less) complete idea should proposed to you first? 20120402 19:45:40< Crab_> hello, Nephro 20120402 19:45:53< Nephro> hi, Crab_ 20120402 19:46:05< mordante> hankerspace_, that should be documented in doxygen 20120402 19:46:27< Crab_> omg_scout: if you're picking an idea from our list, then submit your application to google (you have until Apr 6th to do that, the application can be a placeholder, but that way you won't forget), and link your wiki page from your google application 20120402 19:46:39< Crab_> omg_scout: then, ask the correct person about what's expected from the project 20120402 19:46:57< mordante> hankerspace_, also where is that implemented in the source? 20120402 19:47:00< Crab_> omg_scout: also, do 1-2 patches to wesnoth to let us know how you program. 20120402 19:47:17< mordante> hankerspace_, I prefer them renamed it looks odd when a variable gets renamed in the source 20120402 19:47:30-!- Danceman [~Danceman@a94-132-158-220.cpe.netcabo.pt] has joined #wesnoth-dev 20120402 19:47:51< Crab_> omg_scout: and, improve your proposal after learning the details from us and from reading the source. 20120402 19:48:42-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Remote host closed the connection] 20120402 19:50:11< hankerspace_> ok i'll renome the variable in my patch mordante. And i find : "if(auto_close_timeout)" so, when i use "-1", the condition is true, that's the line (window.cpp 597) 20120402 19:50:17< hankerspace_> rename* 20120402 19:50:41-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120402 19:50:59< gabba> omg_scout: what Crab_ said. As to what you pick for your first patches, you decide of course but we have appropriate-sized tasks on the wiki on the EasyCoding page, and you can try and solve some bugs - sometimes they're stupid and easy to fix. 20120402 19:51:21< gabba> http://wiki.wesnoth.org/EasyCoding 20120402 19:52:13< gabba> omg_scout: if you want to prototype the interface to show the multiple CTK calculations, that could be interesting as well 20120402 19:52:24< Crab_> if I'd go bugfixing, I'd go for recent bugs on bugs.wesnoth.org, about half of them are usually easy :) 20120402 19:52:35< Crab_> non-recent ones are usually harder 20120402 19:52:54< sankaD> Are the patches should be submitted before the end of application period (April 6th)? #GSoC 20120402 19:52:58< gabba> the algorithm already exists, so most of the work is designing the UI 20120402 19:53:17< omg_scout> Ok I will see the code for it 20120402 19:53:31< Crab_> sankaD: we can guarantee that submissions before-or-on 8th April would be taken into account by us when scoring applications. 20120402 19:53:34< Nephro> Crab_, did you want to discuss something? 20120402 19:53:38< omg_scout> Thanks for clearing, I will try to prepare something 20120402 19:53:57< Crab_> Nephro: was just wondering if you'll try to go for GSoC this year as a student or mentor 20120402 19:53:58-!- optics2 [~spitzj3TW@barton-467.dynamic2.rpi.edu] has quit [Ping timeout: 244 seconds] 20120402 19:54:16< mordante> hankerspace_, yeah so -1 sets a timeout 20120402 19:54:34< mordante> in a lot of places in WML -1 sets not used 20120402 19:54:38< Crab_> sankaD: afterwards, the patches are welcome, but we'll have to provide a student list to google sooner or later... 20120402 19:54:45< mordante> for example maximum turns 20120402 19:55:02< mordante> and the documentation in doxygen doesn't specify "not used" 20120402 19:55:33< mordante> and since you use an int variable guessing -1 being the magic value, has another effect 20120402 19:56:01< hankerspace_> So mordante, i should modify to allow "-1" to be the "unused" state ? 20120402 19:56:05-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has joined #wesnoth-dev 20120402 19:56:17< Nephro> Crab_, I wanted to go as a student, mainly because of last year's result. I want to get the "I've done it!" feeling :)... Also, I'm not quite sure, whether I'd be able to be a mentor at this moment, that would be a great experience, but later, when I get more confident 20120402 19:56:52< Crab_> then don't forget that April 6th is google's deadline for submitting proposals 20120402 19:57:21< Nephro> will do 20120402 19:57:22< Crab_> And you have to impress the dev team, as usual. but you've managed to do this once, so you still have a chance :) 20120402 19:58:04< mattsc> Hi, Nephro 20120402 19:58:19< Crab_> Nephro: also, note that the recruitment is the easiest-to-complete the AI project. but, for you, the 'improve debugging' should be easier as well since you've familiar with the LuaAI state (and coded parts of it yourself) 20120402 19:59:18< Nephro> Hi, mattsc, I just read your message. I will start tackling these problems right now. 20120402 19:59:19-!- optics2 [~spitzj3TW@rpi-wl-1363.dynamic.rpi.edu] has joined #wesnoth-dev 20120402 19:59:32-!- thethomaseffect1 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Client Quit] 20120402 19:59:41< mattsc> Great. Thanks. 20120402 20:00:16< Nephro> Crab_, I thought about recruitment mainly because I think it's the most useful for the project at the moment, it didn't cross my mind, that it's the easiest. 20120402 20:00:16-!- thethomaseffect2 [~thethomas@86-40-82-101-dynamic.b-ras1.mgr.mullingar.eircom.net] has quit [Ping timeout: 272 seconds] 20120402 20:00:40< Crab_> Nephro: recruitment is easy because it is "write whatever you want from scratch" 20120402 20:00:51< Crab_> Nephro: you just need to implement a candidate action, basically. 20120402 20:01:00< mordante> hankerspace_, do you know when you assign -1 to an unsigned value? 20120402 20:01:19-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has joined #wesnoth-dev 20120402 20:01:30< Crab_> Nephro: so, evaluate() to see if we should recruit, and execute() to see what we should recruit(). it's not hard to do better than current recruitment function. 20120402 20:02:18-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev 20120402 20:02:22< hankerspace_> Yes mordante but i don't want to let it unsigned ... I guess a signed int is enought for a duration time ... 20120402 20:03:02< hankerspace_> signed int : -65000, + 65000 i don't remember a lot 20120402 20:04:10-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 20:04:22< hankerspace_> oh, no signed int is a 32 bits value, so it's realy larger. 20120402 20:05:08< mordante> jup and not a 17 bit value 20120402 20:05:38< mordante> however the variable in window.hpp is unsigned 20120402 20:06:02< hankerspace_> I'm not allowed to switch it as a signed ? 20120402 20:06:28< Nephro> Crab_, that's true. I didn't notice the debug idea, to be honest. The rest two: "total defense" this idea we discussed a bit last year, when I suggested creating a layer of abstraction above candidate actions in the form of phases(defensive/offensive etc) and didn't give it much thought either, since it would be much easier to do this after recruitment is "smart"; "help ai play campaigns" I see as a feature that would be much easier to implement 20120402 20:06:29< Nephro> , when both defense and recruitment are complete 20120402 20:06:36< Nephro> when both defense and recruitment are complete 20120402 20:07:10< CIA-69> crab * r53754 /trunk/ (4 files in 3 dirs): Power projection improvement: use next turn with proper next-turn ToD if necessary. Patch #3185 by ejls 20120402 20:07:14-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has quit [Ping timeout: 272 seconds] 20120402 20:08:54-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 20:08:55< mordante> hankerspace_, I leave it up to you to decide what the proper fix is 20120402 20:09:04< HappyKsuh> Hi everyone 20120402 20:09:09< mordante> hi HappyKsuh 20120402 20:09:50-!- Elvish_Pillager [~eli@dhip-149.coburn.residences.colby.edu] has joined #wesnoth-dev 20120402 20:11:03< hankerspace_> Alright mordante. I don't want my patch to be contradictory with other tags so i'll use "-1" 20120402 20:13:03< HappyKsuh> One question about GSoC. Is it necessary to save the structure of Application (like Q&A 1.1 - 5.4) when submitting to Google or when creating a wiki page, or other adequate structure is possible?) 20120402 20:13:37< Crab_> HappyKsuh: is possible. generally, keep the questionnaire intact, but put technical details in any way you like them. 20120402 20:13:58< Crab_> HappyKsuh: you can just link to your wiki page from your gsoc application, keeping only a 2-3 sentence abstract from your applications. 20120402 20:14:24< Nephro> Crab_, could you describe the debug idea more? Especially the "add a way to debug lua code" part. Do you have any thoughts on how you would like to see that, or the student can unleash his fantasy, how he wants? 20120402 20:14:43< mordante> hankerspace_, what are the advantages of -1? 20120402 20:15:01< Crab_> Nephro: reduce the amount of boilerplate code as much as possible, make it easier to do stuff that works. 20120402 20:15:24< Crab_> Nephro: i.e., make it possible/easy to register a lua ai candidate action from [event] tag 20120402 20:16:01< hankerspace_> be like the other tag mordante. If a WML dev want to use this tag, he can use "-1" in the tag to specify to don't use the auto_close_timeout. I guess ... 20120402 20:16:09< Nephro> Crab_, ok, that part is pretty clear 20120402 20:16:22< Crab_> that's a half of gsoc in it's own :) 20120402 20:16:34< mordante> hankerspace_, what are the disadvantages of using -1? 20120402 20:17:29< hankerspace_> mordante: modify more source sode, that's all i think 20120402 20:17:35< Nephro> Crab_, designing a way to debug Lua seems the hard part. i don't quite see an easy way to do it, but could be fun 20120402 20:17:58< Crab_> it's possible (via sockets/etc), but it's not really important here 20120402 20:18:02< mordante> hankerspace_, what happens if you send -1 to show() in window.hpp 20120402 20:18:38< Crab_> Nephro: Most important is 'polish stuff first, and then, add some gui in-game windows to display stuff' 20120402 20:18:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120402 20:19:06< hankerspace_> mordante: right now, the window appears during about 10ms in game and then skip to the new window ... 20120402 20:19:14< Crab_> Nephro: i.e., people have used :inspect quite heavily with WML. a simple in-game tool to show various LuaAI decisions would be useful. 20120402 20:19:15< hankerspace_> *next window 20120402 20:20:05< Nephro> Crab_, do you think that I should try to apply to this idea instead of the recruitment alg? 20120402 20:20:54< Crab_> both are good. it is easier to make a good proposal with recruiting, but you're already familiar with internals of LuaAI, so the second would be good for you, as well 20120402 20:21:37< mordante> hankerspace_, so what do you propose to do? 20120402 20:21:37< Crab_> but, note that you're not guaranteed to be accepted - you should work quite hard to have a good chance, esp. since most of the application period is already over. 20120402 20:22:41< Nephro> Crab_, yes, I understand 20120402 20:23:17< Nephro> I'll give it more thought, while I fix bugs mattsc pointed out 20120402 20:23:28< hankerspace_> As i said mordante, i can modify the source code to allow it to use "-1" to specify an infinite "auto_close_timeout" 20120402 20:23:33-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 20:23:46< mordante> ejls, which LaTeX version do use? 20120402 20:24:02< mordante> hankerspace_, yeah but what part of the source, there are several locations to do that 20120402 20:24:38< ejls> mordante: pdfTeX 3.1415926-1.40.11-2.2 (TeX Live 2010-OpenBSD_Ports) 20120402 20:25:19< mordante> ejls, I use TeX Live 2009 probably you miss some packages 20120402 20:26:13< ejls> Yes, certainly. 20120402 20:26:21< hankerspace_> mordante: in window.hpp and windows.cpp, modify the show() argument to signed int and add an if() with if the variable equals to -1, makes it equal to "0". Like that, the user can specify "-1" in WML tag and it will be totally allowed. 20120402 20:26:23< mordante> I agree LaTeX makes it harder to access, however I find writing a lot of Documentation in Doxygen hard to keep the overview 20120402 20:27:01< mordante> hankerspace_, what if the user enters -2 in WML? 20120402 20:28:02-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!] 20120402 20:28:17< mordante> ejls, for example I added http://devdocs.wesnoth.org/event_dispatching.html 20120402 20:28:30< mordante> but I prefer LaTeX 20120402 20:28:49< mordante> however since you're going to write it you should pick the tool 20120402 20:29:19< hankerspace_> Alright mordante, if my variable is negative :) 20120402 20:30:01< Nephro> Crab_, about the vector object exposures to Lua. I decided that the heavy objects will be exposed to Lua as tables with metatables. Meaning, there will be a global(local for the AI) dstsrc, which will grant access to the actual object via metatables. After I expose all the needed things this way, I will get rid of the need to translate whole objects into Lua each time, and if that is still slow, we can add a cache layer in the C++ code, so that i 20120402 20:30:02< Nephro> f I iterate through dstsrc, e.g., C++ Lua handlers will use a cached copy instead of requesting it each time 20120402 20:30:14< Nephro> , so that if I iterate through dstsrc, e.g., C++ Lua handlers will use a cached copy instead of requesting it each time 20120402 20:30:18< sankaD> Does my patch need to be for a AI related Bug, if I'm applying for a GSoC idea on the AI? 20120402 20:30:21< Nephro> (sorry for xchat bugs) 20120402 20:30:37< mordante> hankerspace_, exactly, however my preference would be not to change window.hpp but sanitise the WML input 20120402 20:30:52< Crab_> sankaD: any patch, it's not required for it to be a AI-related bug. 20120402 20:31:13< sankaD> Thanks. :) 20120402 20:31:31< ejls> mordante: Well, I think I'll opt for doxygen. :) 20120402 20:31:34< hankerspace_> Oh, yes mordante i'll d othat 20120402 20:31:40< Crab_> Nephro: multiple layers of caching are fine. just figure out what's the fastest way. 20120402 20:31:47< mordante> ejls, ok 20120402 20:32:24< mordante> hankerspace_, in general it's a good idea to sanitise/validate input since the user can enter non-sense 20120402 20:32:43< Crab_> Nephro: the problem here is that sometimes user wants just 1 unit, sometimes he wants to iterate over all units ... 20120402 20:32:47< Nephro> Crab_, well, it all depends on the user. If he does "x = dstsrc[2].x", we're okay 20120402 20:32:54< Nephro> yes, I was just writing that :) 20120402 20:33:24< Crab_> Nephro: for C++, I've assumed that we always have at least 1 candidate action which does a full loop. 20120402 20:33:54< Crab_> Nephro: if there would be at least one lua candidate action which would do a full loop, then, in most cases, you'll have to translate at least the possible src values to lua 20120402 20:34:02< Nephro> Crab_, in that case, I provide a method in the metatable that will translate the whole object into Lua, so the user can do whatever he likes 20120402 20:34:53< gabba> ejls: while you're discussing tools, if you need a good free UML tool, http://www.bouml.fr/ is the only one out of dozens I found bearable to use and feature-complete. 20120402 20:34:56< Crab_> note that I'd prefer the srcdst management to be as automated as possible, even if it'd be slower. 20120402 20:35:24< Nephro> Crab_, right now it does only full translation, but since CA's are called more than once even in one move, it could lead to very many translations 20120402 20:36:39< gabba> ejls: please concentrate on the content and avoid wasting too much time on tools and formatting, though, especially at this early stage. Case in point: your wiki page looks awesome but the time you spent on templating and formatting is I suspect a bit too much ;) . 20120402 20:37:04< Crab_> Nephro: can you just cache the full translation? 20120402 20:37:16< Crab_> Nephro: i.e., cache it inside the function which is called by user 20120402 20:37:28< Crab_> Nephro: so, the function call would be very cheap on 2nd+ access 20120402 20:37:36< Ayne> Does anybody know anything about the village naming suggestion in the EasyCoding section? 20120402 20:38:12< Crab_> Ayne: afair it was done. 20120402 20:38:35< Crab_> Ayne: I think that the easycoding doesn't list interesting things now, unfortunately 20120402 20:39:03< Crab_> but we have easy bugs 20120402 20:39:07-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 264 seconds] 20120402 20:39:24< ejls> gabba: there is only binaries on their download page and none for my OS. :( So, I'll stick to ArgoUML. 20120402 20:39:25< Ayne> ok, that explains why I found bits of code that look like what was suggested there then 20120402 20:39:41< ejls> gabba: But wikitext is fun. :) 20120402 20:40:09< Crab_> i.e. https://gna.org/bugs/index.php?19599 https://gna.org/bugs/index.php?19280 (even not c++) 20120402 20:40:30< Ayne> it just looked like something could be fun implementing, so I thought I'd ask ;) 20120402 20:41:03< Crab_> yes, I agree, it's fun. but, you can always think out of a way to improve it (it's just I'm afraid it'll take too much time) :) 20120402 20:41:07< Crab_> also, see https://gna.org/bugs/index.php?19250 20120402 20:41:18< Nephro> Crab_, what function do you mean? If we are inside a Lua candidate action and we call get_dstsrc, we can either cache it manually(that's what you probably don't want), or we can make get_dstsrc a proxy Lua function, which will do the caching for us and call the C++ hook when needed 20120402 20:41:42< Crab_> Nephro: your second approach 20120402 20:42:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120402 20:42:07< Crab_> a proxy function (doesn't matter if it's lua or c++ proxy, if both are fast enough) 20120402 20:42:31< Crab_> Ayne: if you want interesting bugs, we have those as well. but those are generally harder :) 20120402 20:43:41< shadowm> faryshta: if svn couldn't do what we are asking you to do we wouldn't ask you to do that in the first place. 20120402 20:43:44< Nephro> Crab_, can You give me a hint on how to check when our cached object gets invalidated? 20120402 20:44:38-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20120402 20:45:20< Ayne> I seem to have missed those bugs when I looked through the list.. possibly a sign that I should stop switching between courseworks and Wesnoth like a single core processor on acid.. 20120402 20:45:53< Ayne> I think more interesting bugs will have to wait until I have more time unfortunately 20120402 20:46:06< gabba> ejls: which distro? Anyways, it seems BOUML isn't freeware anymore, too bad. Hopefully you can use ArgoUML without crashes, I seem to remember unfortunate tries with that software... or maybe it was just unable to do all the diagrams I wanted. 20120402 20:46:25< Crab_> Nephro: either aspect::invalidate() should do extra work, or you can add a way to check the valid_ || valid_variant_ || valid_lua_ status of an aspect 20120402 20:46:58< Nephro> Crab_, but the move maps aren't aspects at the moment 20120402 20:47:15< Crab_> ah, right. 20120402 20:47:40< Crab_> but they have something similar. 20120402 20:47:50< Crab_> (i.e., they can even be refactored to become an aspect) 20120402 20:47:54< Crab_> let me check 20120402 20:48:02< Crab_> Ayne: feature requests are fair game, as well. most feature requests can be implemented 20120402 20:48:36< Crab_> Nephro: look for invalidate_move_maps(), then 20120402 20:48:38< ejls> gabba: OpenBSD (and another laptop comming with FreeBSD by the end of the month) :) 20120402 20:48:46< Crab_> Nephro: it's their version of aspect::invalidate() 20120402 20:49:02< Crab_> Nephro: or make them an aspect, for lua sake :)) 20120402 20:50:43< Crab_> Ayne: the problem is, to get to several months of GSoC coding fun, you should make a good enough proposal first, so, it's better to go for several small bugfixes or to stuff which can be made easily, because usually at this time of year students have a lot of other fun, as well 20120402 20:50:54< Crab_> (like exams or courses) 20120402 20:52:32< Crab_> Nephro: note that, if you go with 'make it an aspect' there should be one unified aspect for all the srcdst, dstsrc, and possible_moves - those are calculated at the same time, (and another aspect for enemy moves) 20120402 20:53:17< Crab_> also note that you can add a new aspect to be used from lua without having to use it in c++ (as long as you do no extra calculations in the aspect, but just use available movement map getters) 20120402 20:53:44< Nephro> Crab_, I'm a bit scared of moving such big mainline things, to be honest, the current invalidation system should be sufficient for this task 20120402 20:54:27< Crab_> Nephro: well, don't be scared, it's easy enough. 20120402 20:54:37< Crab_> Nephro: if you want, it's a good learning experience, as well 20120402 20:54:47< Nephro> It should break a lot, if done improperly 20120402 20:54:51< Crab_> Nephro: who cares if you break something for a version or two? 20120402 20:55:15< Crab_> Nephro: most importantly, your design should be clean 20120402 20:55:51< Crab_> Nephro: if the design is clean, it should be possibly to refactor things clearly, and check if they're working or not. if there would be some glitches in the implementation, they'll be minor, if the design is correct. 20120402 20:56:22< Crab_> Nephro: also note that adding a new aspect cannot break anything, if this aspect is not used/read 20120402 20:56:53< Crab_> Nephro: so, if you make a proxy aspect of sorts, which would just proxy to existing C++ maps, you can't break anything by it because noone would be using this proxy aspect 20120402 20:57:19< Crab_> Nephro: and then, you'll let lua code use it - but this stuff you can check, and easily revert back if you don't like something. 20120402 20:58:11< Crab_> Ayne: let me know if I can help you wrt finding a good bug. But, basically, I'd search for something small and fun enough to track down and fix - you definitely need 1-2 patches in. 20120402 20:58:41< Ivanovic> ejls: congrats to getting commit access! 20120402 20:58:55< Ivanovic> ejls: please make sure to talk to shadowm for getting developer status in the boards 20120402 20:59:16< Crab_> ejls: great :) you're a wesnoth developer now :)) 20120402 20:59:26< Crab_> have fun :) 20120402 20:59:44< shadowm> ejls: you are now a Developer in the forums 20120402 20:59:54< shadowm> which means you also got access to stuff moderators normally have access to 20120402 21:00:41< ejls> Ivanovic, Crab_, shadowm: thanks :) 20120402 21:01:13< Ivanovic> ejls: hey, you earned the access by supporting the wesnoth development with your contributions! 20120402 21:01:14-!- aknahs [~aknahs@174.pool85-50-123.dynamic.orange.es] has joined #wesnoth-dev 20120402 21:01:35-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 21:02:42< ejls> Well, that's only a beginning. Crab_ already found me a lot of work. :) 20120402 21:03:25< Nephro> Crab_, I'll do it this way, if you don't object: I'll properly expose the maps as they are implemented now, create the proxy functions. Once it's done and tested, I'll add the Lua aspect for the maps, then the modifications to the proxies should be minimal 20120402 21:03:52< Crab_> ejls: yes, that's the evil plan :))) 20120402 21:04:09-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has quit [Ping timeout: 246 seconds] 20120402 21:04:17< Nephro> and that won't break anything and won't leave a mess 20120402 21:04:19< Nephro> for sure 20120402 21:04:19< Crab_> Nephro: ok. bonus points if you manage to finish before the end of 8th. 20120402 21:05:38< Nephro> I'll start that tomorrow, today I'll try to fix the minor bugs matt sent me(there's quite a few of them) and fix the existing get_(movemap) methods. since they crash the game now 20120402 21:05:42-!- hankerspace_ [~quassel@ip-10.net-81-220-251.rev.numericable.fr] has joined #wesnoth-dev 20120402 21:05:50< Nephro> just in case someone relies on these method 20120402 21:05:55< Crab_> great 20120402 21:07:20< Nephro> offtop: is there any good GUI tool for todo lists? I really need one, since I seem to forget things after I get excited about something 20120402 21:07:39-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has quit [Ping timeout: 246 seconds] 20120402 21:15:04-!- bloodycoin_m [~bloodycoi@193.170.135.78] has joined #wesnoth-dev 20120402 21:15:29< Crab_> a definite "don't know" :) I've got to go, bye. 20120402 21:16:03< Ayne> bye crab, thanks for the tips 20120402 21:16:12< Crab_> Nephro: I generally use some android apps for taking note lists 20120402 21:16:20-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has quit [Ping timeout: 260 seconds] 20120402 21:16:28< Crab_> Ayne: ask questions, if any, I'll read the log later. 20120402 21:16:40< Crab_> Ayne: and have a good time finding a good bug to fix :) 20120402 21:16:41-!- chpln [~chpln@ppp59-167-91-125.static.internode.on.net] has joined #wesnoth-dev 20120402 21:16:47-!- Crab_ [Crab_@wesnoth/developer/crab] has quit [Quit: Crab_] 20120402 21:17:56< CIA-69> ivanovic * r53755 /trunk/ (8 files in 7 dirs): updated Estonian translation 20120402 21:18:19-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 260 seconds] 20120402 21:18:43< CIA-69> ivanovic * r53756 /branches/1.10/ (8 files in 7 dirs): updated Estonian translation 20120402 21:28:29-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has joined #wesnoth-dev 20120402 21:36:42-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has quit [Ping timeout: 246 seconds] 20120402 21:36:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120402 21:53:58< gabba> Nephro: I like google tools for todo lists myself, such as the task list that integrates with gmail and google calendar, or simply a google doc for longer stuff... having it online is handy. That, or sending myself email that I mark as important until it's done :P . 20120402 21:56:17< mordante> congrats ejls 20120402 21:56:28-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds] 20120402 21:57:18-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 265 seconds] 20120402 21:57:29-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has joined #wesnoth-dev 20120402 22:00:28-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120402 22:00:51-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120402 22:05:08-!- gabba [~gabba@wesnoth/developer/gabba] has left #wesnoth-dev [] 20120402 22:10:58< mordante> I'm off night 20120402 22:11:18-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20120402 22:12:24-!- tyrannodogg [~tyrannodo@ip-74-22.travedsl.de] has joined #wesnoth-dev 20120402 22:17:15< anonymissimus> Crendgrim: AFAIK you are using mercurial with the wesnoth UMC repo ? 20120402 22:18:52< Crendgrim> anonymissimus: no. I used Mercurial before I switched to UMC-dev with my campaign. 20120402 22:19:17< anonymissimus> ?? hm "swichted" ? 20120402 22:19:38< anonymissimus> but from what I've read it is quite similar to git 20120402 22:20:11< anonymissimus> you mean you use svn to commit to the UMC repo now, and you lost your history ? 20120402 22:20:19< Crendgrim> right. 20120402 22:20:33< Crendgrim> as I was too lazy to import the history (what probably would have been possible in some way) 20120402 22:21:23< anonymissimus> well mercurial can interact with a svn remote repo as well; it may have been enough to set a few things perhaps 20120402 22:21:36< Crendgrim> as I said, I was too lazy :p 20120402 22:22:06< Nephro> anonymissimus, do you know a way(or maybe you wrote a tool for that) to find out the structure of a table? I have a very weird table right in lua, but I can't access it's values, since i don't recall how it's structured 20120402 22:22:08< anonymissimus> but anyway I ask since git repeatedly faisl to clone/checkout/whatever a certain svn repository for mw 20120402 22:22:24< Crendgrim> I never used git or mercurial to remotely control svn, sorry :( 20120402 22:22:47< anonymissimus> Nephro: if I understand the question correctly: yes 20120402 22:23:19< anonymissimus> if on the lua side, then it's the dbms function from the WLP; on the C++ side the stack dumper 20120402 22:23:32-!- mjs-de [~mjs-de@wh.uni-dortmund.de] has quit [Remote host closed the connection] 20120402 22:23:41< anonymissimus> which side do you need ? 20120402 22:23:43< Nephro> anonymissimus, what is WLP? 20120402 22:23:46< Nephro> Lua side 20120402 22:23:50< anonymissimus> wesnoth lua pack 20120402 22:23:53< Nephro> I see 20120402 22:24:22< anonymissimus> local loaded, debug_utils = pcall(wesnoth.dofile, "~add-ons/Wesnoth_Lua_Pack/debug_utils.lua") 20120402 22:24:24< anonymissimus> dbms = debug_utils.dbms 20120402 22:24:30< loonycyborg> anonymissimus: http://mercurial.selenic.com/wiki/HgSubversion 20120402 22:24:34< anonymissimus> then call dbms(some lua var) 20120402 22:24:36< Nephro> thanks, I'll check it out :) I created a table that is impossible to iterate through 20120402 22:24:52< anonymissimus> yup, then that will help you probably 20120402 22:25:29< anonymissimus> and I don't think there's a table impossible to iterate through; it should be doable with pairs() no matter what 20120402 22:26:10< mattsc> Nephro, are you talking about what ai.get_dstsrc() returns? 20120402 22:26:34< Nephro> mattsc, yes :) I remembered how I implemented that 20120402 22:26:43< Nephro> I should be able to iterate through it now 20120402 22:27:02< Nephro> I fixed the bug that made the both maps the same 20120402 22:27:16< Nephro> And I will fix the infinite loop bug in a second 20120402 22:27:25< Nephro> then I will push it all together 20120402 22:27:26< mattsc> I wrote a little function ai_helper.my_moves() that iterates over that table and puts it into a more intuitive (for me) format 20120402 22:27:42< mattsc> great 20120402 22:28:30< mattsc> I think that that function is part of WLP these days, so you can get it from there. But in any case, dbms is how I found out about the format, so that'll definitely do it. 20120402 22:28:32< Nephro> mattsc, if you can suggest a better format for these tables, I can redo them. move maps are basically multimaps and that was the only way I could think of, how to translate the maps into Lua last summer 20120402 22:28:32< anonymissimus> loonycyborg: yes thx...well I'm afraid that it wouldn't work with that remote repo as well; I sometimes have probs even with tortoiseSVN 20120402 22:29:14< anonymissimus> the problem seems with the connection settings of the remote repo; some mailing threads indicate that 20120402 22:30:23< mattsc> Nephro, well, the way I did it in my_moves is actually not how I'd do it any more (but it's an example of how to iterated over it) 20120402 22:30:40< Nephro> I managed to iterate over it now 20120402 22:30:41< loonycyborg> And how exactly git-svn clone fails for it? 20120402 22:30:58-!- Ingmar [~ingmar@exherbo/developer/ingmar] has quit [Ping timeout: 260 seconds] 20120402 22:30:58-!- erl [~erl@vetinte.spelaroll.se] has quit [Ping timeout: 260 seconds] 20120402 22:32:14< anonymissimus> loonycyborg: http://git.661346.n2.nabble.com/Re-git-svn-import-fails-td3252954.html this thread pretty much describes it 20120402 22:32:54< mattsc> Personally, I'd make the key a 1dim index, such as what location sets use. That way you can just access it directly by using the index without any loops. I don't know if that would be very popular though. 20120402 22:33:04-!- Ingmar [~ingmar@exherbo/developer/ingmar] has joined #wesnoth-dev 20120402 22:33:17< mattsc> (and I'd probably do the same for the value table) 20120402 22:33:24< anonymissimus> the remote hoster, the error message and the way it comes are the same 20120402 22:34:14-!- erl [~erl@vetinte.spelaroll.se] has joined #wesnoth-dev 20120402 22:34:20< anonymissimus> or at least very similar 20120402 22:34:49< anonymissimus> unfortunately, there's no solution or suggestion given there; same for other threads with similar topic I found 20120402 22:35:23< Nephro> mattsc, yes, that sounds reasonable. I must've wanted to make the tables as close as possible to multimaps. Didn't really think about how usable would that be 20120402 22:35:31< loonycyborg> anonymissimus: Does it support other protocols than http/https? 20120402 22:36:05< Nephro> mattsc, do you have a scenario that crashes when ai.get_dstsrc is used? (where it is empty of course) 20120402 22:36:12< loonycyborg> Pretty sure that svn: wouldn't be able to fail with 200 OK :P 20120402 22:36:48< mattsc> Nephro, in that case, would it be possible to make it exactly the same as what's used in location sets? That way all the LS tools can be used. 20120402 22:39:37< anonymissimus> loonycyborg: when I try tortoiseSVN's blame i get a very similar error message 20120402 22:39:47< mattsc> Nephro, I can get to crash every time simply by using ai.get_enemy_dstsrc(), as the enemies always have no moves left. 20120402 22:39:51< anonymissimus> no, doesn't look like it 20120402 22:40:18< mattsc> Just put 'local tmp = ai.get_enemy_dstsrc()' anywhere. It should hang up. 20120402 22:40:27< anonymissimus> but they recently added git support they say !? guess that only means the remote repo is in git instead of subversion 20120402 22:41:06< Nephro> mattsc, ok, I'll try it... The bug is very obvious there, but I need to test it. 20120402 22:41:07< loonycyborg> Don't think they offer automatic conversions. 20120402 22:41:13< anonymissimus> checking out with tortoiseSVN did work however 20120402 22:42:25< mattsc> Nephro, ok sounds good. I can also put a clean(ish) version of my test scenario together for this, just let me know. 20120402 22:42:52< anonymissimus> automatic conversions, no; but the project admin can choose what to use opun creating teh project+ 20120402 22:43:17< Nephro> mattsc, I should push it in, like, 5 minutes 20120402 22:43:21< loonycyborg> anonymissimus: Then your only resort seems to bug hoster itself. 20120402 22:44:18< loonycyborg> Since blame fails too it'll be easy for them to repro this issue :P 20120402 22:47:34< anonymissimus> well...codeplex seems to me a microsoft thing, perhaps they implicitly force people to use their own VCS team foundation of however 20120402 22:48:20< mattsc> Nephro: great. I probably won't have time to test it today any more though. 20120402 22:48:25< loonycyborg> This is not an excuse not to fix outright bugs, not even for microsoft. 20120402 22:48:54< anonymissimus> what does 200 OK mean ? 20120402 22:49:06< Nephro> mattsc, by the way, if I don't make moves with my units and just end the turn, the move maps will not be empty 20120402 22:49:15< Nephro> and, yes, I fixed the issue 20120402 22:49:21< loonycyborg> Successful http request. 20120402 22:49:39-!- sankaD [~sanka@61.245.165.57] has quit [Quit: Leaving] 20120402 22:49:54< mattsc> yes, that's true... Thanks for the fix. Will check it out as soon as I can. 20120402 22:50:43< anonymissimus> well from what it looks like it is really a problem with codeplex itself; since various people are getting it with various projects and source control clients 20120402 22:50:56< loonycyborg> Most likely the result returned weren't a valid svn+http response though :P 20120402 22:51:40< CIA-69> nephro * r53757 /trunk/ (data/ai/scenarios/scenario-lua-ai.cfg src/ai/lua/core.cpp): (1)Fixed an infinite loop bug (2) Fixed methods, that provided wrong objects to Lua 20120402 22:52:49-!- negusnyul [~negusnyul@BC0628D2.dsl.pool.telekom.hu] has quit [Quit: Konversation terminated!] 20120402 22:54:37< Nephro> mattsc, are you sure get_avoid() provides the wrong coordinates? I am looking at the method now, it pushes x and y in the exact same way. There might be a problem in the terrain_filter code, but I doubt that, since it should have been used for quite a while 20120402 22:55:07-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev 20120402 22:55:46< mattsc> Nephro, I checked that several times, so I'm pretty sure. Let me have a look again. 20120402 23:01:51-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120402 23:05:49-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has quit [Quit: ...] 20120402 23:05:50< Nephro> mattsc, I also fixed the weapon numbers for Lua. -1 will still be the best weapon, but the weapons indices will start at 1 instead of 0 20120402 23:05:57< anonymissimus> Nephro: on a general note; you should use the raw* variants 20120402 23:06:35< mattsc> Nephro, nice! Thanks. 20120402 23:06:36< Nephro> that is, the weapon numbers in C++ will remain the same, but you should call the attack method with weapon numbers shifted up by 1 20120402 23:07:01< mattsc> So I just tested get_avoid() again. Sorry, was being stupid, so it took a little longer. 20120402 23:07:03< anonymissimus> and in cfun_ai_get_avoid you could have used lua_rawseti 20120402 23:07:13< Nephro> anonymissimus, I know, don't know if I knew that last summer, but now I now 20120402 23:07:18< Nephro> :) 20120402 23:07:21< Nephro> anonymissimus, will fix 20120402 23:07:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20120402 23:07:27< mattsc> Unlike what I wrote you, both x and y are reduced by 1 compared to map coordinates. 20120402 23:08:12< mattsc> I set up an [avoid] tag with x,y=1,11 and get_avoid() returns 0 and 10 20120402 23:08:56< anonymissimus> when I write such function I usually check with the stack dumper on the C++ side and/or dbms on the lua side what gets returned then :) 20120402 23:09:11< Nephro> mattsc, yes, that is a known thing between c++ and lua coordinates. 20120402 23:09:15< mattsc> I think this is the difference between the C++ map index and the user map index 20120402 23:09:24< Nephro> even that 20120402 23:09:26< Nephro> yes 20120402 23:09:49< anonymissimus> ah yes thats correct indee, didnt see it; the C++ coords are 1 less than the wml/lua ones 20120402 23:09:51< mattsc> But then ai.leader_goal() with the same coordinates returns 1,11. At the very least it should be consistent 20120402 23:11:34< anonymissimus> that function is pushing a config, so not quite comparable 20120402 23:11:51< anonymissimus> or that is why it's correct there probably 20120402 23:12:40< mattsc> anonymissimus: I mean, on the user side, things should be consistent, not how it is handled internally. 20120402 23:13:03< anonymissimus> sure 20120402 23:13:39< anonymissimus> the coordinate difference is solely a stupid definition thing; nothing more 20120402 23:13:56< Nephro> I have a push_map_location method 20120402 23:14:04< Nephro> it will do things properly 20120402 23:14:13< Nephro> in the avoid method i did it by hand 20120402 23:15:31-!- HappyKsuh [~ksu.nyaka@host-58-152-66-217.spbmts.ru] has quit [] 20120402 23:16:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 272 seconds] 20120402 23:16:53< mattsc> Nephro: ok. Does that mean you'll use push_map_location for avoid now too? 20120402 23:17:03< Nephro> already doing that 20120402 23:19:05 * anonymissimus just relized he had svn commands in cmd.exe all teh time 20120402 23:19:15< mattsc> thanks 20120402 23:20:44-!- optics2 [~spitzj3TW@rpi-wl-1363.dynamic.rpi.edu] has quit [Ping timeout: 244 seconds] 20120402 23:20:56< Nephro> mattsc, could you, please, pastebin me the [avoid] tag syntax? I just need to test the fix, but I can't find how was I to set the avoid aspect 20120402 23:22:13-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120402 23:23:37-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 246 seconds] 20120402 23:24:05< mattsc> http://pastebin.com/q0G4ZcN4 20120402 23:24:44< mattsc> This is done in an event, because setting aspects in the [side] tag when using the Lua engine does not work for all aspects. It's on the list I sent you as well. :) 20120402 23:27:20< Nephro> yes, I noticed that too :) 20120402 23:27:46-!- optics2 [~spitzj3TW@barton-427.dynamic2.rpi.edu] has joined #wesnoth-dev 20120402 23:33:45< Nephro> anonymissimus, do I need to get something, before using the WLP? 20120402 23:33:58< Nephro> I can't seem to access the functions 20120402 23:36:12< mattsc> Nephro: local debug_utils = wesnoth.require "~add-ons/Wesnoth_Lua_Pack/debug_utils.lua" 20120402 23:37:36< Nephro> I did that, but seems I messed up the names, I'll try again 20120402 23:39:44< Nephro> still it seems to be nil 20120402 23:41:48-!- RiotJozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has joined #wesnoth-dev 20120402 23:42:02< mattsc> Umm, I don't know then. I assume the file exists, otherwise wesnoth.require would throw an error message ? 20120402 23:42:27< Nephro> I assume so too 20120402 23:42:33< mattsc> And you then used the syntax from my pastebin link? 20120402 23:42:58< Nephro> yes 20120402 23:43:06< Nephro> maybe it depends on where I make the call from 20120402 23:43:21-!- Jozrael [~croselius@76-216-244-178.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 252 seconds] 20120402 23:43:56< mattsc> you need to define the debug_utils variable in a place where it still exists when you try to use it (i.e. in the same block or on a level above that bock) 20120402 23:44:09< mattsc> *block 20120402 23:45:03< Nephro> well, I tried defining it in stage code 20120402 23:46:27< anonymissimus> possibly wesnoth.require fails there 20120402 23:46:37< Nephro> ah, yes, it says that the file is not found 20120402 23:46:48< anonymissimus> usually it gives an error if so, but it may not be 20120402 23:46:49-!- faryshta [~faryshta@201.137.107.113] has quit [Read error: Connection reset by peer] 20120402 23:47:16< anonymissimus> for instance, wesnoth.sync_choice fails silently in <= start events 20120402 23:47:34< Nephro> anonymissimus, it does say that the file is not found... 20120402 23:47:51< Nephro> where can I get that from? 20120402 23:48:04< anonymissimus> have you downloaded the addon ? 20120402 23:48:20< anonymissimus> you need to get it from the addons server 20120402 23:48:31< anonymissimus> or alternatively from wesnoth-umc-dev 20120402 23:49:18< anonymissimus> better umc-dev then you get latest fixes and features 20120402 23:50:07< anonymissimus> https://wesnoth-umc-dev.svn.sourceforge.net/svnroot/wesnoth-umc-dev/trunk/Wesnoth_Lua_Pack 20120402 23:50:16< Nephro> ok, I got it, thank you 20120402 23:50:26< Nephro> I'll run off now, pretty tired today 20120402 23:50:29< anonymissimus> is the url in my local git repo 20120402 23:50:31< Nephro> thanks for the help guys, good night 20120402 23:51:01< Nephro> I got it straight from the addon server 20120402 23:51:10< anonymissimus> alright 20120402 23:51:14< Nephro> gn 20120402 23:51:18< mattsc> Thanks. good night. 20120402 23:51:18< anonymissimus> bye 20120402 23:52:08< anonymissimus> brb 20120402 23:52:11-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.1 [Firefox 11.0/20120312181643]] 20120402 23:55:49-!- Nephro [~Dmitry@02de475b.bb.sky.com] has quit [Ping timeout: 246 seconds] 20120402 23:56:25-!- akzfowl [~akzfowl@1.186.12.45] has quit [Ping timeout: 260 seconds] 20120402 23:56:57-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye] 20120402 23:57:06-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev --- Log closed Tue Apr 03 00:00:34 2012