--- Log opened Sat May 26 00:00:05 2012
20120526 00:01:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120526 00:03:23-!- stikonas [~and@bcm-131-111-216-103.girton.cam.ac.uk] has joined #wesnoth-dev
20120526 00:03:27-!- stikonas [~and@bcm-131-111-216-103.girton.cam.ac.uk] has quit [Changing host]
20120526 00:03:28-!- stikonas [~and@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120526 00:08:00-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120526 00:10:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 00:13:10< CIA-61> espreon * r54294 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg: Fixed bug #19763.
20120526 00:24:18-!- Gallaecio [~quassel@135.152.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20120526 00:29:20< CIA-61> espreon * r54295 /branches/1.10/ (59 files in 3 dirs): Fixed bug #19763 in 1.10.
20120526 00:42:27-!- negusnyul [~negusnyul@dsl4E5CD84C.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20120526 00:45:59-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120526 00:49:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 00:49:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20120526 00:52:20-!- Gallaecio [~quassel@135.152.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20120526 00:54:45-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has joined #wesnoth-dev
20120526 00:55:02-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has quit [Read error: Connection reset by peer]
20120526 01:14:14-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 244 seconds]
20120526 01:19:01-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye]
20120526 01:49:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 01:49:50-!- wesbot changed the topic of #wesnoth-dev to: 177 bugs, 336 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120526 02:18:27< LovCAPONE> shadowm, are you around»?
20120526 02:19:17< shadowm> Yes.
20120526 02:19:55< LovCAPONE> ok about patch #3307. Since I was adding much more code than my other patchesm I feared about my coding style
20120526 02:21:25< LovCAPONE> for the camelCase issue. It's that you don't want "someMethod" but : "somemethod" for example???
20120526 02:22:13< shadowm> some_method(), which is what is used everywhere else. In general, it's a good idea to take a look at a significant amount of existing code and ask when in doubt (since some legacy code, such as the CVideo class, doesn't match our current conventions).
20120526 02:23:47< shadowm> Sam goes for Doxygen comments; we generally use implicit descriptions, /** to start a documentation comment block, and @commands as opposed to \commands.
20120526 02:24:40< LovCAPONE> ok I'll take note. Anything else regarding the style?
20120526 02:24:56< shadowm> But regardless of these style issues I don't really understand why you had to introduce new classes to (if I understood correctly) simply attach a description string to hotkey entries. Their names and documentation don't really explain much.
20120526 02:25:20< shadowm> I also thing I just saw a method taking an argument of type void*.
20120526 02:25:22< shadowm> *think
20120526 02:26:05< LovCAPONE> because as I understand, the issue was that the hotkey's description was used in different context. So my patch allows just that with much flexibility
20120526 02:27:00< shadowm> Wouldn't just allowing a hotkey entry to have separate menu and hotkey list strings be a much simpler approach?
20120526 02:28:27< LovCAPONE> and what if in the future there is a new context??? Always add another list? I think it wouldn't be elegant
20120526 02:29:06< shadowm> What do you mean by a new context, though?
20120526 02:29:59< shadowm> Hotkey descriptions currently only appear in menu entries and the hotkey list in Preferences. I can't really think of any possible new uses for them.
20120526 02:30:28< LovCAPONE> ok there is one context 1- in the preference menu... another context 2- in the map menu. Always notice how I changed the method command_executor::get_menu_image (ion hotkeys.cpp). It's much more readable now no?
20120526 02:30:56< LovCAPONE> also*
20120526 02:32:43< LovCAPONE> there was a "if" for the case where the hotkey ID was "HOTKEY_ENDTURN"
20120526 02:33:04< LovCAPONE> but if you think there will never be new contextes it's ok.
20120526 02:33:22< LovCAPONE> just want4ed to prepare for the future :-)
20120526 02:34:25< shadowm> I'd prefer refactoring for future possibilities and bug fixing to be done in separate patches, since that makes it much easier to tell what's going on.
20120526 02:35:40< shadowm> My primary concern though is not overengineering, especially not for a relatively simple issue like this. I don't really know whether it's the case or not since the new code isn't self-explanatory enough.
20120526 02:35:48< LovCAPONE> ok, so for the string list for each context. Will there be a developer doing the implementation, or can I submit a patch doing it?
20120526 02:36:55< shadowm> You can do the latter. But before you do that, I also have another concern.
20120526 02:37:10< LovCAPONE> ??
20120526 02:37:12< shadowm> I see a lot of new classes with data members that are pointers, but I don't see any destructors.
20120526 02:37:49< shadowm> Are they tracking existing objects?
20120526 02:38:12< LovCAPONE> existing objects yes. No allocation done
20120526 02:40:18-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.]
20120526 02:40:22< LovCAPONE> ok I have to go, anything else you would like to talk about?
20120526 02:40:24< shadowm> Okay. In either case I think I should let someone else handle the next iteration of the patch; I'm not very good at proofreading code.
20120526 02:40:36< shadowm> Yes, in fact, I see another problem.
20120526 02:41:10< shadowm> In the changes to src/editor/map/context_manager.cpp, you added three strings that appears to be UI strings, but they are not translatable (i.e. they are not retrieved via a gettext cal).
20120526 02:41:14< shadowm> *appear
20120526 02:41:54< LovCAPONE> yeah that's what I feared actually. I'm not familiar yet about how the translation goes
20120526 02:42:02< shadowm> UI strings are almost always translatable, and that is done by invoking gettext with one of our various macros in src/gettext.hpp; the underscore wrapper is the most common, e.g.  _("This is translatable")
20120526 02:42:52< shadowm> (That actually resolves to a function call that returns a C string.)
20120526 02:42:59< LovCAPONE> ok taking notes
20120526 02:43:52< shadowm> These macros are particularly important because the scripts we use to build the translation catalogues look for them and introduce the strings to the templates accordingly.
20120526 02:44:39< shadowm> Anyway, that's all for now.
20120526 02:45:05< LovCAPONE> ok thanks alot for taking time to review my patch. I hope the next one will get accepted :-)
20120526 02:45:16< shadowm> Also, there's this if you havent' checked it out yet: http://wiki.wesnoth.org/CodingStandards
20120526 02:46:42< LovCAPONE> ok thanks for everything. I'm off now, best regards
20120526 02:46:50< shadowm> Okay, bye.
20120526 02:46:53-!- LovCAPONE is now known as LovAFK
20120526 03:17:17-!- crimson_penguin [~ben@out-bc-151.wireless.telus.com] has joined #wesnoth-dev
20120526 03:24:10-!- crimson_pingvin [~ben@S0106602ad06b8003.vc.shawcable.net] has joined #wesnoth-dev
20120526 03:38:32-!- LovAFK [~weche@modemcable210.107-82-70.mc.videotron.ca] has left #wesnoth-dev ["Ex-Chat"]
20120526 03:41:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120526 03:52:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 04:03:30-!- crimson_pingvin_ [~ben@S0106602ad06b8003.vc.shawcable.net] has joined #wesnoth-dev
20120526 04:05:38-!- crimson_penguin [~ben@out-bc-151.wireless.telus.com] has quit [Ping timeout: 240 seconds]
20120526 04:05:38-!- crimson_pingvin is now known as crimson_penguin
20120526 04:05:38-!- crimson_penguin [~ben@S0106602ad06b8003.vc.shawcable.net] has quit [Changing host]
20120526 04:05:38-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20120526 04:10:56-!- crimson_pingvin_ [~ben@S0106602ad06b8003.vc.shawcable.net] has quit [Quit: Colloquy for iPhone - http://colloquy.mobi]
20120526 04:11:52-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20120526 04:11:52-!- Upth is now known as Upthorn
20120526 04:19:21-!- fendrin [~fabi@88-134-10-97-dynip.superkabel.de] has joined #wesnoth-dev
20120526 04:19:21-!- fendrin [~fabi@88-134-10-97-dynip.superkabel.de] has quit [Changing host]
20120526 04:19:21-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20120526 04:21:14-!- Ivanovic_ [~ivanovic@dtmd-4db2a94d.pool.mediaWays.net] has joined #wesnoth-dev
20120526 04:21:42-!- vultraz_laptop [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120526 04:24:29-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 244 seconds]
20120526 04:25:09-!- Ivanovic_ is now known as Ivanovic
20120526 04:38:54-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 245 seconds]
20120526 05:05:00-!- matthiaskrgr [matthiaskr@72.29.68.157] has quit [Ping timeout: 252 seconds]
20120526 05:16:57-!- stikonas [~and@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120526 05:29:39-!- shadowm_laptop is now known as evilshadowm
20120526 05:41:45-!- csarmi_home is now known as csarmi
20120526 06:14:38-!- evilshadowm [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: gui1 go to hell]
20120526 06:21:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120526 06:26:31-!- Gallaecio [~quassel@135.152.60.213.dynamic.mundo-r.com] has joined #wesnoth-dev
20120526 06:48:56< CIA-61> shadowmaster * r54296 /trunk/src/ (construct_dialog.cpp construct_dialog.hpp): 
20120526 06:48:57< CIA-61> gui1: Add and implement gui::dialog::BUTTON_TOP layout hint
20120526 06:48:57< CIA-61> This allows placing a button at the top-right corner in a stock gui1
20120526 06:48:57< CIA-61> dialog.
20120526 06:48:57< CIA-61> This implementation might not be bug-free (has only been tested against
20120526 06:48:57< CIA-61> the Add-ons Manager dialog for now), but it works and doesn't introduce
20120526 06:48:58< CIA-61> or fix bugs in other current dialogs.
20120526 06:49:12< CIA-61> shadowmaster * r54297 /trunk/src/addon/manager_ui.cpp: addon/mg: Make the View Mode button use the gui::dialog::BUTTON_TOP hint
20120526 06:53:29-!- Gallaecio [~quassel@135.152.60.213.dynamic.mundo-r.com] has quit [Remote host closed the connection]
20120526 07:09:45< CIA-61> shadowmaster * r54298 /trunk/src/construct_dialog.cpp: 
20120526 07:09:45< CIA-61> gui1: Add border case for gui::dialog::BUTTON_TOP
20120526 07:09:45< CIA-61> When there's only one button with this hint, and there's a textbox, try
20120526 07:09:45< CIA-61> to align the button to the textbox. This makes the Filter/View Mode row
20120526 07:09:45< CIA-61> in the Add-ons Manager dialog look tidier.
20120526 07:11:09-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120526 07:23:04-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
--- Log opened Sat May 26 08:11:25 2012
20120526 08:11:43-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20120526 08:11:43-!- Topic for #wesnoth-dev: 177 bugs, 336 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120526 08:11:43-!- Topic set by wesbot [~wesbot@asteria.debian.or.at] [Sat May 26 01:49:50 2012]
20120526 08:11:43[Users #wesnoth-dev]
20120526 08:11:43[ [Relic]        ] [ enchilado ] [ jamit      ] [ shadowm       ] 
20120526 08:11:43[ AI0867         ] [ erl       ] [ janebot    ] [ shikadibot    ] 
20120526 08:11:43[ Akihara        ] [ esr       ] [ knotwork   ] [ Smar          ] 
20120526 08:11:43[ apoi           ] [ fendrin   ] [ koan       ] [ Tigge         ] 
20120526 08:11:43[ Appleman1234   ] [ Guest33238] [ lobby      ] [ Upthorn       ] 
20120526 08:11:43[ CIA-61         ] [ happygrue ] [ loonycyborg] [ vcap          ] 
20120526 08:11:43[ Crab_          ] [ Ingeniumed] [ LordNasty  ] [ vultraz_laptop] 
20120526 08:11:43[ crimson_penguin] [ Ingmar    ] [ melinath   ] [ wesbot        ] 
20120526 08:11:43[ csarmi         ] [ isaac     ] [ noy        ] [ worduk        ] 
20120526 08:11:43[ ejls           ] [ Ivanovic  ] [ Rhonda     ] [ worduk_       ] 
20120526 08:11:43[ elias          ] [ iwaim     ] [ Samual     ] [ {V}           ] 
20120526 08:11:43-!- Irssi: #wesnoth-dev: Total of 44 nicks [0 ops, 0 halfops, 0 voices, 44 normal]
20120526 08:11:43!zelazny.freenode.net [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp
20120526 08:12:07-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009
20120526 08:12:08-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20120526 08:13:10-!- Irssi: Join to #wesnoth-dev was synced in 96 secs
20120526 08:20:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120526 08:23:49-!- _vdn [~nazgul-sa@80.250.162.179] has joined #wesnoth-dev
20120526 08:35:22-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120526 08:36:13-!- Ivanovic [~ivanovic@dtmd-4db2a94d.pool.mediaWays.net] has quit [Changing host]
20120526 08:36:13-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120526 08:37:00< Ivanovic> moin
20120526 08:42:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20120526 08:53:36-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20120526 08:53:36-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20120526 08:53:36-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20120526 08:53:51< mordante> servus
20120526 08:59:33-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev
20120526 09:01:45-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120526 09:08:28-!- _vdn [~nazgul-sa@80.250.162.179] has quit [Quit: Leaving.]
20120526 09:14:50-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120526 09:15:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120526 09:36:13< shadowm> Should I have any special considerations (other than avoiding off-by-one situations) when using an enum type member as an array subscript or size expression?
20120526 09:43:05-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev
20120526 10:04:08< mordante> depends on your use case, but if you use enum without explicitly assigning them values it should give no problems
20120526 10:04:33-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 10:05:26-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120526 10:10:45< CIA-61> mordante * r54299 /trunk/src/gui/auxiliary/ (window_builder.cpp window_builder.hpp): 
20120526 10:10:45< CIA-61> Made create_builder_widget a public function.
20120526 10:10:45< CIA-61> At the moment it's only used by the grid builder, but the pane builder will use
20120526 10:10:45< CIA-61> it later as well.
20120526 10:15:18-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 250 seconds]
20120526 10:19:17< CIA-61> shadowmaster * r54300 /trunk/src/addon/manager_ui.cpp: 
20120526 10:19:17< CIA-61> addon/mg: Fix inconsistent/unintuitive add-ons list column sorting behavior
20120526 10:19:17< CIA-61> It seems I forgot to take care of the sorter instance when rearranging
20120526 10:19:17< CIA-61> columns in r54277. As a result, some columns were sorted by inadequate
20120526 10:19:17< CIA-61> criteria (e.g. Type by numeric comparison).
20120526 10:29:55-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 10:30:23-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 10:43:18-!- MeccaGod [majs@host189-199.bornet.net] has joined #wesnoth-dev
20120526 10:46:06-!- mjs-de [~mjs-de@g224190025.adsl.alicedsl.de] has joined #wesnoth-dev
20120526 11:11:13-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 11:11:52-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 11:12:37-!- negusnyul [~negusnyul@dsl4E5CD84C.pool.t-online.hu] has joined #wesnoth-dev
20120526 11:18:25< shadowm> Would it be too hard to make gui2::tdialog::register_bool() take a reference to a std::vector<bool> item instead of an actual bool ref for the third argument?
20120526 11:18:53< shadowm> Or should I go back to my original plan of using an actual C array of bools? :/
20120526 11:25:52< shadowm> I guess alternatively I could do the checkbox checks by hand.
20120526 11:32:19< mordante> you can't take references to an item in std::vector<bool>
20120526 11:33:19< shadowm> I thought the relevant methods returned references to a wrapper object.
20120526 11:35:14-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 11:35:32< mordante> every std::vector<>::operator[]() returns a reference except std::vector<bool>
20120526 11:35:42< mordante> (it seemed a good idea at the time ;-) )
20120526 11:35:54-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 11:38:26-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Client Quit]
20120526 11:42:38-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 12:07:01-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 12:07:46-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 12:14:23-!- _vdn1 [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 12:14:46-!- _vdn [~nazgul-sa@ppp91-77-238-54.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer]
20120526 12:16:42-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120526 12:25:18-!- matthiaskrgr [matthiaskr@72.29.68.157] has joined #wesnoth-dev
20120526 12:37:24-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Read error: Connection reset by peer]
20120526 12:38:22-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev
20120526 12:38:56-!- matthiaskrgr [matthiaskr@72.29.68.157] has quit [Ping timeout: 246 seconds]
20120526 12:39:48-!- _vdn1 [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 12:40:24-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 12:41:54-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120526 12:50:58-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 12:52:31-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 12:58:45-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120526 13:04:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20120526 13:05:29-!- loonybot [~loonybot@46.138.73.237] has joined #wesnoth-dev
20120526 13:05:30-!- loonybot [~loonybot@46.138.73.237] has quit [Changing host]
20120526 13:05:30-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120526 13:06:54-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Read error: Connection reset by peer]
20120526 13:12:54-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20120526 13:19:11-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 13:19:51-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 13:24:12-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Client Quit]
20120526 13:24:46-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 13:27:17-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120526 13:38:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120526 13:40:14-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 13:40:54-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 13:51:17-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20120526 13:51:35-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 14:01:36-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 14:01:43-!- tie [~quassel@125.160.80.88] has joined #wesnoth-dev
20120526 14:02:09-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 14:03:10-!- tie is now known as atomicbomb
20120526 14:22:22-!- leonid [~leonid@114.248.233.157] has joined #wesnoth-dev
20120526 14:23:19-!- leonid [~leonid@114.248.233.157] has quit [Remote host closed the connection]
20120526 14:24:57-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 14:25:31-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 14:29:58< CIA-61> mordante * r54301 /trunk/ (9 files in 6 dirs): 
20120526 14:29:58< CIA-61> Add a builder for a viewport.
20120526 14:29:58< CIA-61> It allows to use a viewport in a grid. It's now also possible to own the
20120526 14:29:58< CIA-61> widget in the viewport.
20120526 14:29:58< CIA-61> The code is used to experiment with a different approach of the
20120526 14:29:59< CIA-61> implementation of a listbox.
20120526 14:30:53-!- atomicbomb [~quassel@125.160.80.88] has quit [Read error: Connection reset by peer]
20120526 14:34:38-!- tie [~quassel@125.160.80.88] has joined #wesnoth-dev
20120526 14:43:14-!- tie is now known as atomicbomb
20120526 14:43:45-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Connection reset by peer]
20120526 14:55:47-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds]
20120526 14:56:09-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120526 15:14:07-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 15:14:39-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 15:15:39-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120526 15:19:34< anonymissimus> mordante: if I have a int a[2] which cppcheck complains about that it should be initialized in the constructor, how can I do that in the initializer list ? only example I googled didn't compile, and wesnoth hardly has such arrays but uses std::vector or boost:: instead...
20120526 15:20:43< mordante> anonymissimus, where do you have that exact example?
20120526 15:29:58< anonymissimus> mordante: not wesnoth
20120526 15:31:27< anonymissimus> not in wesnoth, that is
20120526 15:42:31-!- matthiaskrgr [matthiaskr@72.29.68.157] has joined #wesnoth-dev
20120526 15:48:59-!- matthiaskrgr [matthiaskr@72.29.68.157] has quit [Ping timeout: 246 seconds]
20120526 15:58:31< anonymissimus> mordante: ^
20120526 15:59:54< CIA-61> anonymissimus * r54302 /trunk/projectfiles/VC9/wesnoth.vcproj: VC9 projetcfile update
20120526 16:00:08< CIA-61> anonymissimus * r54303 /trunk/projectfiles/CodeBlocks/wesnoth.cbp: cb project update
20120526 16:00:45-!- bloodyco_ [~bloodycoi@193.170.135.78] has joined #wesnoth-dev
20120526 16:00:46-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer]
20120526 16:01:16-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 16:01:42-!- bloodyco_ is now known as bloodycoin_m
20120526 16:05:41-!- anonymissimus_ [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120526 16:08:54-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120526 16:08:57-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Ping timeout: 246 seconds]
20120526 16:09:09-!- anonymissimus_ is now known as anonymissimus
20120526 16:15:40< CIA-61> alarantalara * r54304 /trunk/data/campaigns/Liberty/scenarios/01_The_Raid.cfg: Make a team name translatable
20120526 16:19:41-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 16:20:16-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 16:20:18-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20120526 16:28:05-!- H-Hour [~H-Hour@41.235.173.87] has joined #wesnoth-dev
20120526 16:28:56< H-Hour> Hi, I'm a developer for another open source game, UFO: Alien Invasion. I'm wondering if anyone can tell me who I could speak to about Wesnoth's translation system.
20120526 16:31:09< Rhonda> H-Hour: It's nothing specific, it uses gettext, and that's all to it. :)
20120526 16:31:41< Rhonda> If you be more specific about your question, I could give you more specific information.  Have you looked at http://gettext.wesnoth.org/ yet?
20120526 16:31:53< H-Hour> Thanks Rhonda.
20120526 16:32:21< H-Hour> I'm not a coder I'm just investigating solutions to a problem as we prepare to change translation systems.
20120526 16:32:50< H-Hour> My main concern now is that, in our game, if a modder wants to add a weapon, he must create and compile his own PO file to add it properly to the game.
20120526 16:33:27< H-Hour> When I have made addons for Wesnoth, I know that I don't have to compile anything myself (just provide the default string for other translators to translate).
20120526 16:34:02< H-Hour> do you know how this is accomplished? Is gettext.wesnoth.org all I need to take back to my coders for them to explore the solution? or is there an extra trick involved somewhere?
20120526 16:34:39< CIA-61> alarantalara * r54305 /trunk/projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update file list for Xcode project
20120526 16:35:15< CIA-61> alarantalara * r54306 /trunk/data/core/terrain-graphics.cfg: Fix bug#19753: missing transition
20120526 16:35:39< Rhonda> Ah, then you should ask one of the addon people who do have translations for their stuff already. :)
20120526 16:35:57< Rhonda> On how they get them and make them available too.
20120526 16:36:52-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120526 16:37:01< H-Hour> i'm more interested in how the game manages that behind the scenes...
20120526 16:38:35-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120526 16:39:51< CIA-61> alarantalara * r54307 /branches/1.10/data/core/terrain-graphics.cfg: backport fix for bug#19753 to 1.10
20120526 16:41:04< the_new_lipk> H-Hour: the translation stuff is a two-step process
20120526 16:41:21< the_new_lipk> firstly, you have to extract the translatable strings from the add-on
20120526 16:41:38< CIA-61> alarantalara * r54308 /trunk/changelog: update changelog
20120526 16:41:45< the_new_lipk> that is done via an external tool called WesCamp
20120526 16:41:56-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 16:42:02< the_new_lipk> it also compiles the .po files
20120526 16:42:37-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 16:42:39< CIA-61> alarantalara * r54309 /branches/1.10/ (4 files in 3 dirs): update changelog
20120526 16:42:45< the_new_lipk> secondly, once the .mo files are ready, you place it in the proper folder in the add-on, an the game engine reads the content
20120526 16:43:02< Alarantalara> ^ and apparently also the version number for Xcode
20120526 16:43:40< H-Hour> the_new_lipk: thanks. so perhaps this question will betray my ignorance on the subject, but there is one difference between my game and wesnoth i am trying to understand.
20120526 16:44:07< the_new_lipk> I know nothing about your game :P
20120526 16:44:23< H-Hour> in my game, all text has to be compiled to a MO file to be read. in wesnoth, if i have an addon with a [message], that text does not need to be compiled to a MO (unless it is then translated).
20120526 16:45:02< H-Hour> am i just missing something? does the game actually compile the MO behind the scenes for me without noticing?
20120526 16:45:48< H-Hour> or is it just that wesnoth can read the text and my game can not?
20120526 16:45:57< H-Hour> read the UNCOMPILED text
20120526 16:46:13< the_new_lipk> I think Wesnoth defaults to the text provided in [message] if it can't find it in the .mo
20120526 16:46:30< H-Hour> ok, that makes sense.
20120526 16:46:36< H-Hour> many thanks for your help
20120526 16:46:44< the_new_lipk> You're welcome
20120526 16:47:28< Gambit> Translatable strings are prefixed with an underscore
20120526 16:49:17-!- jamit [~james@pool-173-61-167-95.cmdnnj.east.verizon.net] has quit [Quit: Leaving.]
20120526 16:50:47-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has joined #wesnoth-dev
20120526 16:51:51< Rhonda> Thanks for stating the basics, Gambit :P
20120526 16:52:52< Gambit> Always happy to provide loading screen tips. :<
20120526 16:56:48< CIA-61> alarantalara * r54310 /branches/1.10/data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg: complete fix for bug #19763 in 1.10
20120526 16:57:24-!- atomicbomb [~quassel@125.160.80.88] has quit [Ping timeout: 250 seconds]
20120526 16:57:36 * Gambit starts spamming Rhonda with "Hey! Listen!"
20120526 17:00:01< anonymissimus> H-Hour: the UMC translations did, in historical context, about "never work" in wesnoth though xD
20120526 17:00:57< anonymissimus> it's become a lot better lately
20120526 17:01:38< H-Hour> because the translations weren't done or because the system was broken/
20120526 17:01:38< H-Hour> ?
20120526 17:01:41-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 248 seconds]
20120526 17:02:10< anonymissimus> system broken...the responsible script not run...and such
20120526 17:04:51-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 17:05:27-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 17:08:59-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Client Quit]
20120526 17:09:49-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 17:14:17-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20120526 17:17:39-!- Crab_ [Crab_@wesnoth/developer/crab] has left #wesnoth-dev []
20120526 17:19:39-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120526 17:20:00-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 17:20:46-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 17:36:05< Rhonda> -- Looking for dgettext - not found
20120526 17:36:20< Rhonda> Uhm, Ivanovic and mordante, is this new in 1.10.3?
20120526 17:38:27-!- zookeeper [~lmsnie@87-100-211-108.bb.dnainternet.fi] has joined #wesnoth-dev
20120526 17:38:27-!- zookeeper [~lmsnie@87-100-211-108.bb.dnainternet.fi] has quit [Changing host]
20120526 17:38:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120526 17:45:20< Rhonda> What is dgettext meant to be?  I don't find it in the Debian archive?
20120526 17:51:38-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120526 17:59:44-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120526 18:03:39-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 18:04:20-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 18:15:44-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 18:16:18-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 18:26:34-!- koan [~koan@unaffiliated/koan] has quit [Ping timeout: 272 seconds]
20120526 18:27:54-!- koan [~koan@unaffiliated/koan] has joined #wesnoth-dev
20120526 18:30:01-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 18:30:38-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 18:39:35< Ivanovic> cmake/FindLibintl.cmake:  check_function_exists(dgettext LIBINTL_LIBC_HAS_DGETTEXT)
20120526 18:39:45< Ivanovic> sounds like some feature in libc
20120526 18:39:58< Ivanovic> *but* it sounds unlikey that this file was changed lately...
20120526 18:40:44< Ivanovic> since this check is in the cmake recipe since it was created
20120526 18:45:24< mordante> anonymissimus, you could try with {int, int}, but might be C++11 style
20120526 18:45:39< Ivanovic> Rhonda: so has anything changed in your system?
20120526 18:53:46< Rhonda> I just started a 1.10.2 build to check, and that runs fine.
20120526 18:54:21< Rhonda> Yes, there is dgettext.c included with gettext, but that's the only thing I was able to find at all.
20120526 18:56:02-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120526 18:58:04< anonymissimus> Rhonda, un productive suggestion: what about just switching to a windows build system ? xD
20120526 19:00:27< Rhonda> Sure, what I do is a waste anyway because of the playdeb people, you are right!
20120526 19:18:59-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20120526 19:35:04-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 19:35:38-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 19:43:36-!- H-Hour [~H-Hour@41.235.173.87] has left #wesnoth-dev ["Leaving"]
20120526 19:49:00-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120526 19:49:50-!- wesbot changed the topic of #wesnoth-dev to: 175 bugs, 336 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120526 19:54:20< the_new_lipk> zookeeper: around?
20120526 19:54:42< zookeeper> yes
20120526 19:54:55-!- matthiaskrgr [matthiaskr@72.29.68.157] has joined #wesnoth-dev
20120526 19:56:08< the_new_lipk> Gambit made me realize an issue with the dependency system
20120526 19:56:18< the_new_lipk> imagine the following:
20120526 19:56:41< the_new_lipk> you create an era which turns wesnoth into a flight simulator or whatever
20120526 19:57:06< the_new_lipk> this era works with special scenarios only, of course
20120526 19:57:39< the_new_lipk> so, you add an allow_scenario=flight1,flight2 blahblah attribute
20120526 19:58:07< the_new_lipk> people like your era, and *they want to create extra scenarios for it!!!*
20120526 19:58:20< the_new_lipk> but your era won't allow those
20120526 19:58:52< zookeeper> right...
20120526 19:59:48< zookeeper> any clever ideas, besides just scrapping the dependencies?
20120526 20:00:01< the_new_lipk> I'm thinking about some sort of grouping
20120526 20:00:44< the_new_lipk> the era doesn't allow or disallow single scenarios, but scenario groups
20120526 20:01:12< the_new_lipk> and any scenario could be member of any group the author wishes it to be
20120526 20:01:54< the_new_lipk> (e.g [scenario] group=flight_sim_scen [/scenario] and [era] allow_scenario_group=flight_sim_scen [/era] )
20120526 20:04:34< zookeeper> or just allow a scenario to specify that it's compatible with this or that era, and then the game considers a scenario-era pair to be compatible if 1) the era allows the scenario or 2) the scenario allows the era?
20120526 20:05:18< zookeeper> allow_era= in a scenario would of course need to be inclusive, so using it would not prevent the scenario from being used with other eras
20120526 20:05:21< zookeeper> or something like that
20120526 20:06:29< the_new_lipk> so, in short, add-ons could overwrite eachother's preferences?
20120526 20:08:13< zookeeper> well, i think that if a scenario explicitly says that it's compatible with era X, then there's no reason to prevent it from being played with that era
20120526 20:08:41< the_new_lipk> yeah, this could be a solution too
20120526 20:08:54< the_new_lipk> and it requires less modification to the existing code
20120526 20:09:51< zookeeper> of course people can then make scenarios which claim to be compatible with an era but really aren't, but... people can already make broken add-ons which make a mess of everything, so i'm not that worried about it.
20120526 20:10:54< Alarantalara> I think I like the group version a bit better: it lets an era say it's not compatible with previous versions of itself
20120526 20:11:58< zookeeper> i have no opinion on the group idea really
20120526 20:15:27< the_new_lipk> I'll think about it... the group solution feels a bit more elegant for me, but if it needs a lot of coding...
20120526 20:33:40-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev
20120526 20:46:11-!- matthiaskrgr [matthiaskr@72.29.68.157] has quit [Ping timeout: 250 seconds]
20120526 21:00:52< mordante> I'm off bye
20120526 21:01:14-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20120526 21:11:28-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120526 21:23:01-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Ping timeout: 250 seconds]
20120526 21:25:17-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 21:25:49-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 21:29:35-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120526 21:40:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 21:51:32< Rhonda> hmm, strange.  Ivanovic, mordante, anonymissimus, it worked now on second try.  No clue why, nothing changed
20120526 21:52:25< Ivanovic> Rhonda: strange one...
20120526 22:08:26-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20120526 22:09:02-!- _vdn [~nazgul-sa@ppp91-77-225-18.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120526 22:13:02-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom]
20120526 22:15:09< Rhonda> indeed, because I always build with cowbuilder in a chroot, and that hasn't changed in between
20120526 22:26:43-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20120526 22:31:18-!- MeccaGod [majs@host189-199.bornet.net] has quit []
20120526 22:41:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120526 22:49:16-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120526 22:51:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120526 23:12:39-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Ping timeout: 245 seconds]
20120526 23:22:13-!- mjs-de [~mjs-de@g224190025.adsl.alicedsl.de] has quit [Remote host closed the connection]
20120526 23:41:29-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120526 23:44:11-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
--- Log closed Sun May 27 00:00:22 2012