--- Log opened Mon May 28 00:00:24 2012 20120528 00:01:58-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20120528 00:05:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20120528 00:14:39-!- csarmi [~csarmi@host-88-132-151-239.prtelecom.hu] has quit [Ping timeout: 246 seconds] 20120528 00:15:40-!- neph [~neph@80.233.231.12] has quit [Ping timeout: 260 seconds] 20120528 00:24:03-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Ping timeout: 252 seconds] 20120528 00:33:29-!- negusnyul [~negusnyul@dsl4E5CD84C.pool.t-online.hu] has quit [Quit: Konversation terminated!] 20120528 00:43:16-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has quit [Quit: ..] 20120528 00:46:59-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Connection reset by peer] 20120528 00:49:58-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120528 01:23:12-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120528 01:37:18-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Excess Flood] 20120528 01:38:13-!- Ivanovic [~ivanovic@dtmd-4db26bd1.pool.mediaWays.net] has joined #wesnoth-dev 20120528 01:46:05-!- Smar [~smar@freenet/translator/finnish/Smar] has quit [Ping timeout: 260 seconds] 20120528 01:46:12-!- Smar [~smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev 20120528 01:56:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120528 01:56:06-!- mjs-de [~mjs-de@g224190085.adsl.alicedsl.de] has quit [Remote host closed the connection] 20120528 01:56:47< AI0867> wesbot: bug #19565? 20120528 01:56:55< AI0867> wesbot: bug #19565 20120528 01:56:55< wesbot> Bug #19565 Assigned to: Fabian Müller Status: Fixed Priority: 1 - Later 20120528 01:56:58< wesbot> Summary: [LoW-10] Event triggered before the cause is visible 20120528 01:57:01< wesbot> Original submission: I attach two savegames. On the started one, if I move the 20120528 01:57:04< wesbot> Elf Exlorer on the right-most side forward (25,24), an event gets triggered abo 20120528 01:57:07< wesbot> URL: https://gna.org/bugs/?19565 20120528 01:57:09< wesbot> Attached file (1st): https://gna.org/bugs/download.php?file_id=15382 20120528 02:01:12< fendrin> hi AI0867 20120528 02:11:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 02:27:19-!- happygrue_ [~quassel@c-98-222-183-113.hsd1.il.comcast.net] has joined #wesnoth-dev 20120528 02:27:19-!- happygrue_ [~quassel@c-98-222-183-113.hsd1.il.comcast.net] has quit [Changing host] 20120528 02:27:19-!- happygrue_ [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev 20120528 02:29:50-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Ping timeout: 260 seconds] 20120528 02:36:39-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120528 02:37:50< AI0867> fendrin: hey 20120528 02:44:27< fendrin> :-) 20120528 03:08:52-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20120528 03:24:45-!- leonid [~leonid@124.65.134.54] has joined #wesnoth-dev 20120528 03:35:11-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20120528 03:39:12-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120528 03:44:52-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20120528 04:12:54-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20120528 04:16:00-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 244 seconds] 20120528 04:33:28-!- noy [~Noy@wesnoth/developer/noy] has left #wesnoth-dev [] 20120528 04:47:16-!- Ivanovic_ [~ivanovic@dtmd-4db2b72a.pool.mediaWays.net] has joined #wesnoth-dev 20120528 04:47:16-!- Ivanovic_ [~ivanovic@dtmd-4db2b72a.pool.mediaWays.net] has quit [Changing host] 20120528 04:47:16-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120528 04:49:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 04:50:34-!- Ivanovic [~ivanovic@dtmd-4db26bd1.pool.mediaWays.net] has quit [Ping timeout: 245 seconds] 20120528 04:50:58-!- Ivanovic_ is now known as Ivanovic 20120528 05:30:55-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20120528 05:34:59-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 265 seconds] 20120528 05:44:20-!- csarmi [~csarmi@host-88-132-150-207.prtelecom.hu] has joined #wesnoth-dev 20120528 06:12:25-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: smile, smile, smile!] 20120528 06:28:40-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120528 06:29:01-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection] 20120528 07:17:52-!- neph [~neph@80.233.231.12] has joined #wesnoth-dev 20120528 07:24:26-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20120528 07:28:05-!- light_mage [~chatzilla@59.161.104.100] has joined #wesnoth-dev 20120528 07:32:12-!- csarmi [~csarmi@host-88-132-150-207.prtelecom.hu] has quit [Ping timeout: 252 seconds] 20120528 07:36:22< light_mage> Hi, I need a little help with randomizing of recruiting. I read through all of the formula ai functions but couldn't figure out how to do it. Right now, I am recruiting an orcish grunt whenever possible. Pls take a look at the code, and tell me how this can be done. Thanks :) Orcish_ai: pastebin.com/3sw5115r 20120528 07:36:29-!- light_mage [~chatzilla@59.161.104.100] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 12.0/20120424094101]] 20120528 07:36:46< Espreon> Oh well. 20120528 07:37:42-!- neph [~neph@80.233.231.12] has quit [Ping timeout: 252 seconds] 20120528 07:44:38< Espreon> wesbot: seen Drakefriend? 20120528 07:44:38< wesbot> Espreon: The person with the nick Drakefriend last spoke 27d 23h ago. 23d 10h ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/ 20120528 07:44:41< Espreon> Meh. 20120528 07:53:39-!- vultraz_ [~chatzilla@124.109.10.221] has joined #wesnoth-dev 20120528 07:54:44-!- vultraz [~chatzilla@124.109.10.221] has quit [Disconnected by services] 20120528 07:54:49-!- vultraz_ is now known as vultraz 20120528 08:02:56-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 244 seconds] 20120528 08:03:15-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 08:09:39-!- light_mage [~chatzilla@14.98.166.23] has joined #wesnoth-dev 20120528 08:20:55-!- csarmi [~csarmi@88.132.179.197] has joined #wesnoth-dev 20120528 08:25:36-!- csarmi [~csarmi@88.132.179.197] has quit [Ping timeout: 265 seconds] 20120528 08:27:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120528 08:31:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120528 08:32:27-!- light_mage [~chatzilla@14.98.166.23] has quit [Remote host closed the connection] 20120528 08:37:25-!- _vdn1 [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 08:37:27-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer] 20120528 08:38:02< boucman> bloodycoin_m: around ? 20120528 08:39:34-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 08:51:37< vultraz> fendrin: you mentioned earlier that the palette thing would be available ingame for an inventory or such...how would that work? would it be another gui1/2 widget? or what 20120528 08:55:14-!- ancestral [~ancestral@97-127-66-8.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120528 08:57:10-!- _vdn1 [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 08:57:47-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 09:01:43-!- csarmi [~csarmi@88.132.179.197] has joined #wesnoth-dev 20120528 09:21:56-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 09:22:25-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 09:32:51< Ivanovic> moin 20120528 09:37:45< vultraz> hey 20120528 09:39:55-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev 20120528 09:52:15-!- neph [~neph@80.233.231.12] has joined #wesnoth-dev 20120528 09:52:50-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20120528 09:53:05< mordante> servus 20120528 09:54:31< CIA-61> mordante * r54320 /trunk/src/gui/widgets/viewport.cpp: 20120528 09:54:31< CIA-61> Properly set the parent of the viewport's widget. 20120528 09:54:31< CIA-61> The code is used to experiment with a different approach of the 20120528 09:54:31< CIA-61> implementation of a listbox. 20120528 09:54:33< CIA-61> mordante * r54321 /trunk/src/gui/widgets/viewport.cpp: 20120528 09:54:33< CIA-61> Let the viewport return a proper best size. 20120528 09:54:33< CIA-61> The code is used to experiment with a different approach of the 20120528 09:54:33< CIA-61> implementation of a listbox. 20120528 09:54:35< CIA-61> mordante * r54319 /trunk/src/gui/widgets/pane.cpp: 20120528 09:54:35< CIA-61> Properly ask for a resize when adding a new item. 20120528 09:54:35< CIA-61> This allows the parents of the pane to react to new items. 20120528 09:54:35< CIA-61> The code is used to experiment with a different approach of the 20120528 09:54:36< CIA-61> implementation of a listbox. 20120528 09:55:51< shadowm> How do you manage to paste the same blurb at t he end of every commit message? 20120528 09:56:22< mordante> copy paste 20120528 09:56:34-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom] 20120528 09:58:03-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20120528 10:01:30< neph> Crab_, hi, I know it's early, but I'm ready whenever you are 20120528 10:02:01< mordante> vultraz, will you be around for a while? I have some new files to commit later, would be nice if you could update X-Code 20120528 10:05:22< mordante> Ivanovic, do you have new plans for a trunk-release or not yet? 20120528 10:05:52-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 10:06:27-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 10:11:19< Ivanovic> not yet considering the problems with the editor 20120528 10:11:44< Ivanovic> maybe some time later in june, not sure though 20120528 10:12:40< mordante> ok so not really soon 20120528 10:13:02< mordante> I've a more experimental patch (can be easily reverted) which I'd like to give some time in trunk 20120528 10:16:55< Ivanovic> then do so 20120528 10:17:07< Ivanovic> as i said, currently the editor is the experimental part which needs most work 20120528 10:17:15< Ivanovic> map format and things like this included 20120528 10:17:59< mordante> ok I will, just preparing some other commits 20120528 10:18:51< mordante> the basics of the new listbox class seem to work :-) still need a lot of polishing and tuning, but at least something will be there 20120528 10:20:38< Ivanovic> nice 20120528 10:21:31< CIA-61> mordante * r54322 /trunk/ (16 files in 6 dirs): 20120528 10:21:31< CIA-61> Add a new instance dummy widget. 20120528 10:21:31< CIA-61> This widget is used to postpone instantiation of a widget. This will be used 20120528 10:21:31< CIA-61> in the new matrix widget where the definition needs a widget which will only 20120528 10:21:31< CIA-61> be available when the matrix widget is instantiated in a window. 20120528 10:21:32< CIA-61> The code is used to experiment with a different approach of the 20120528 10:21:33< CIA-61> implementation of a listbox. 20120528 10:23:16-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120528 10:24:01< vultraz> mordante: I should be around for awhile, but I may or may not be able to get on the mac to update xcode (I'm on my Windows laptop ATM) 20120528 10:24:36 * shadowm wonders if the grow_factor and border* attributes in GUI2 WML will ever be renamed to growth_factor and margin* . 20120528 10:25:18< mordante> vultraz, ok, there will be another commit with new files a little bit later 20120528 10:26:02-!- Elvish_Hunter [5ea39c45@gateway/web/freenode/ip.94.163.156.69] has joined #wesnoth-dev 20120528 10:26:16< boucman> bloodycoin_m: I really need to talk to you, i'll be here all day long... 20120528 10:26:20< Elvish_Hunter> Hi all 20120528 10:26:26< mordante> hi Elvish_Hunter 20120528 10:27:05< mordante> shadowm, not sure, but I will probably do a general code and naming review some time in the future 20120528 10:27:15< mordante> no idea however when 20120528 10:27:19-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 10:27:21< Crab_> hi, neph 20120528 10:27:30< Crab_> should be ready in ~1 hour 20120528 10:27:43-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120528 10:27:58-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 10:28:19< shadowm> For that matter, I tend to find the interaction of the *grow* and *alignment* attributes with rows/columns/cells rather confusing. 20120528 10:30:10< shadowm> Also, at the end of this section there's what appears to be a problem with the source syntax or the comments converter tool: http://wiki.wesnoth.org/GUIToolkitWML#Resolution_2 20120528 10:30:13< mordante> I agree, do you have a proposal for something better? 20120528 10:31:03< shadowm> Hm, no, I don't have one (other than a dedicated section in the documentation explaining those instead of the current, terse reference pages) 20120528 10:31:48< mordante> ok and I also agree the documentation could be improved as well 20120528 10:33:21< shadowm> There's another instance of the wiki page tool outputting its source syntax here: http://wiki.wesnoth.org/GUIWidgetDefinitionWML#Listbox 20120528 10:34:04< mordante> yeah I just noticed the same earlier today ;-) 20120528 10:36:27-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 10:36:59-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 10:41:25< vultraz> the GUI wiki pages are really confusing... 20120528 10:44:51-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 10:45:31-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 10:45:42< mordante> vultraz, confusing in what way? 20120528 10:52:50< CIA-61> mordante * r54323 /trunk/ (12 files in 8 dirs): 20120528 10:52:50< CIA-61> Add a new matrix widget. 20120528 10:52:50< CIA-61> This widget is slated to replace the current listbox in the future. The code 20120528 10:52:50< CIA-61> however is only ready as proof-of-concept code, and not usable in real code 20120528 10:52:50< CIA-61> yet. 20120528 10:52:51< CIA-61> The code is used to experiment with a different approach of the 20120528 10:52:51< CIA-61> implementation of a listbox. 20120528 10:54:35< CIA-61> mordante * r54324 /trunk/ (3 files in 2 dirs): 20120528 10:54:35< CIA-61> Use the new matrix code in the debug clock. 20120528 10:54:35< CIA-61> This is only used for testing. 20120528 10:54:35< CIA-61> The code is used to experiment with a different approach of the 20120528 10:54:35< CIA-61> implementation of a listbox. 20120528 10:57:09-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 10:57:38-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 11:00:50-!- Elvish_Hunter [5ea39c45@gateway/web/freenode/ip.94.163.156.69] has quit [Quit: Ciao!] 20120528 11:02:06< CIA-61> mordante * r54325 /trunk/changelog: Update changelog. 20120528 11:03:13-!- mjs-de [~mjs-de@g224190232.adsl.alicedsl.de] has joined #wesnoth-dev 20120528 11:04:16-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 11:05:01-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 11:05:15-!- Johannes13 [~Johannes@unaffiliated/johannes13] has joined #wesnoth-dev 20120528 11:10:56-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev 20120528 11:11:00< vultraz> mordante: they're unclear, and they sometimes seem to contradict each other 20120528 11:13:11< vultraz> and some of the stuff they mention (keys) don't seem to work....or they don't specify how to use them 20120528 11:13:43< mordante> vultraz, ok thanks 20120528 11:13:59< mordante> I guess I have to do a general code and documentation review later 20120528 11:14:36< shadowm> By the way, is it really necessary for a click_dimiss=true window to gain a Close button if it contains a listbox? 20120528 11:14:51< shadowm> *dismiss why do I keep making that typo 20120528 11:15:11< mordante> shadowm, is that with every listbox? 20120528 11:16:03< shadowm> Hm, no idea. What are the actual criteria for a click_dismiss=true window to gain a Close button? 20120528 11:16:48< mordante> the fact there is a widget that also likes a click, so for example a listbox with a scrollbar 20120528 11:17:48< shadowm> Well, a listbox with rows that are toggle buttons certainly qualifies then. I assume there'd be a problem with event handling then such as the window capturing the event first and closing itself before the actual widget does. 20120528 11:20:00< mordante> ah yes that's also a problem 20120528 11:20:44< mordante> click dismiss is mainly intended for dialogs that show a message 20120528 11:21:23< mordante> then the close is shown if the text is too big and a scrollbar is required 20120528 11:21:30< shadowm> Might be useful for implementing GUI2 comboboxes, though? 20120528 11:22:05< mordante> true but selecting a listbox item can also close a window 20120528 11:22:38< shadowm> Yeah, but that could change in the future. :p 20120528 11:22:57< mordante> but I'll take a look at that once I start to tackle comboboxes 20120528 11:23:46< mordante> for now I need to finish the matrix class since it's really a simple proof-of-concept piece of code at the moment 20120528 11:24:32< shadowm> The more immediate use case I had attempted to code involved emulating a combobox that actually displays a small popup window with options, aligned to the button just like a regular combobox popup. 20120528 11:25:03< shadowm> But yeah, I guess that just isn't possible yet. 20120528 11:25:23< mordante> nope it isn't 20120528 11:27:30< bloodycoin_m> boucman: yes, was sleeping ^^' 20120528 11:27:55< boucman> oh, ok, i havn't totally assimilated your timezone yet.. 20120528 11:28:34< bloodycoin_m> it's GMT+2, but I wake up late and go to sleep late.. 20120528 11:29:01< boucman> so, saw you added some code recently 20120528 11:29:27< bloodycoin_m> yea, I did some invalidations too, but haven't pushed yet 20120528 11:29:36< boucman> ok, good 20120528 11:30:05< boucman> you also are drawing relative to map coordinates which is good 20120528 11:31:39< bloodycoin_m> if you allow me few minutes of disconnecting, I will push invalidations 20120528 11:31:48< boucman> sure, no prob. 20120528 11:32:28-!- bloodycoin [~bloodycoi@193.170.133.228] has joined #wesnoth-dev 20120528 11:32:43-!- bloodycoin_m [~bloodycoi@193.170.135.78] has quit [Read error: Connection reset by peer] 20120528 11:33:09-!- bloodycoin_m [~bloodycoi@2002:c1aa:8513:a:f02d:ceba:4bb6:1f43] has joined #wesnoth-dev 20120528 11:33:22< bloodycoin_m> done 20120528 11:34:50< boucman> prrofreading your code (before invalidation) the formula in particle::draw seems quite complicated... 20120528 11:35:42< bloodycoin_m> yes, that's why I wanted to get posx_ and pos_y directly from display.. All I am doing there is calculating it. 20120528 11:35:45< Crab_> neph: ping, I'm available now 20120528 11:36:04< neph> Crab_, same 20120528 11:36:27< boucman> hmm 20120528 11:36:49-!- bloodycoin [~bloodycoi@193.170.133.228] has quit [Ping timeout: 245 seconds] 20120528 11:37:03< boucman> is that because the particle engine is the first one to work directly with surfaces ? 20120528 11:37:17< boucman> i am suprised there isn't a cleaner API for that yet... 20120528 11:38:19< boucman> the anim engine communicates image::locator to the display engine, so it's a bit different 20120528 11:38:43< boucman> bloodycoin_m: ok, I understand why you have to do that, then 20120528 11:39:01-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 11:39:25< boucman> that logic should probably be moved to display, since it's in no way specific to the particles, but appart for that i'm ok with it now 20120528 11:39:33-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 11:41:06< boucman> what is the point of the following line in particle_engine::particle_engine() 20120528 11:41:12< boucman> test_effect_.effect_surf_ 20120528 11:41:19< bloodycoin_m> boucman: ell, the only thing I need to avoid that calculations, is to get the values from display, because display stores it anyway 20120528 11:41:30< boucman> oh... 20120528 11:41:32< boucman> hmm 20120528 11:41:43< bloodycoin_m> but since they are private... 20120528 11:41:44< boucman> and I made you do it... sorry about that :P 20120528 11:41:57< boucman> well you might want to add const accessors then 20120528 11:42:24< bloodycoin_m> gladly :) 20120528 11:42:26< boucman> it's probably my fault for not understanding your need 20120528 11:42:29< boucman> sorry 20120528 11:42:49< bloodycoin_m> np, wasn't that hard 20120528 11:43:42< boucman> btw, the part_ hardwired particle in the particle_engine seems unused at this point 20120528 11:45:02< bloodycoin_m> with the test_effect_.effect_surf_ I think I intended to assign only one value in contructor, but then I had to reassign it update, and forgot to remove it. 20120528 11:45:25< boucman> ok 20120528 11:45:32< bloodycoin_m> true, forgot to do clean up 20120528 11:46:21-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120528 11:46:33< boucman> from a design point of view, is there a reason the code to calculate the new particle position is in particle_engine::draw and not in a particle::draw that would be called by the particle engine ? 20120528 11:46:40< boucman> or is it just debug code ? 20120528 11:48:01< bloodycoin_m> it's mostly debug code, wanted to have it all in one place... 20120528 11:48:12< boucman> same idea, invalidate_effect would make more sense as part of the effect class 20120528 11:51:16< bloodycoin_m> not sure how correct it is, but I would prefer to leave effect as data structure only.. 20120528 11:52:09< boucman> i'm not sure what you gain by that... you loose the possibiliity of using inheritence easily and I don't see much gain 20120528 11:52:10< Crab_> neph: so, what I want to do is to ensure, more-or-less as it was done last year, that you would 'agree' on a specific list of deliverables, writing them yourself 20120528 11:52:25< boucman> it's simple enough that I don't really mind, but I don't see the point 20120528 11:54:13< bloodycoin_m> well, with inheritance I would have to make accessors for almost everything in particle and effect, or make fields public, because friend class doesn't work with inheritance and I would need to specify every class 20120528 11:55:40< bloodycoin_m> I mean, if I wanted to use friend class and inheritance, I would need to specify every derived class as a friend 20120528 11:56:03< CIA-61> mordante * r54326 /trunk/src/gui/widgets/window.cpp: (log message trimmed) 20120528 11:56:03< CIA-61> Switch the default gui2 render engine. 20120528 11:56:03< CIA-61> In gui2 there are two render engines; one using the widget's position to 20120528 11:56:03< CIA-61> render and the other based on the requested coordinates. The later is 20120528 11:56:03< CIA-61> used in the new widgets (pane, viewport and matrix) exclusively, meaning 20120528 11:56:04< CIA-61> these widgets don't work with the old engine. 20120528 11:56:05< CIA-61> The new one has been tested a while under --new-widgets and seems to 20120528 11:56:05-!- loonybot_ [~loonybot@46.138.74.45] has joined #wesnoth-dev 20120528 11:56:05-!- loonybot_ [~loonybot@46.138.74.45] has quit [Changing host] 20120528 11:56:05-!- loonybot_ [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120528 11:56:37< boucman> mkay... i'm not really convinced but that's a valid point so let's do it your way 20120528 11:56:37< mordante> Ivanovic and anybody who else cares, in case there are huge rendering issues and I'm not around feel free to revert r54326 20120528 11:56:45-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Ping timeout: 246 seconds] 20120528 11:56:45-!- loonybot_ is now known as loonybot 20120528 11:56:51< boucman> if we feel the need for inheritence coming, we can change our mind 20120528 11:57:44< bloodycoin_m> ok, refactoring helps most of the time.. 20120528 11:58:00< fendrin> hi boucman, thanks for including the teleport animation. 20120528 11:58:16< neph> Crab_, ok. Basically, from this point I will try to stick to my own timeline. I was more "pessimistic" with the timeline this year, so I have a good buffer to keep up. There are 2-3 bugs hanging on me, I'll fix or mark them as ntbd after more research. Then I will do the two points in the timeline which where dated to be done in April, but one of them is basically done and the second falls under the next point, so it is buffered too 20120528 11:58:46< mordante> fendrin, you wanted to give an update on the editor yesterday evening, any news? 20120528 11:58:53< neph> Meaning, the attacks vector exposure is the missing functionality, I separated them, because I thought i'll manage to do it faster 20120528 11:59:49< boucman> fendrin: no prob 20120528 11:59:51< neph> Crab_, also, mattsc seems to have reusable code, but not in a reusable state, so I will have to read his code and extract the needed parts to store in trunk 20120528 12:00:15-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120528 12:00:17< fendrin> mordante: Yeah, I sorted and prioritized my bugs. 20120528 12:00:23-!- loonybot [~loonybot@46.138.74.45] has joined #wesnoth-dev 20120528 12:00:23-!- loonybot [~loonybot@46.138.74.45] has quit [Changing host] 20120528 12:00:23-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120528 12:01:03-!- leonid [~leonid@124.65.134.54] has quit [Remote host closed the connection] 20120528 12:01:07< fendrin> mordante: There are in fact 2 more release critical bugs to fix, I am working on the first one right now. The other issue is enabling the "pick terrain under color feature" again. 20120528 12:01:17< mordante> ok 20120528 12:01:27< mordante> any idea how long it will take to finish? 20120528 12:01:53< boucman> bloodycoin_m: did you try your invalidation with :sunset ? 20120528 12:02:08< neph> Crab_, next comes the removal of boilerplate. I have multiple solution designs and I am sure we will agree on one of them during the time I work on the functionality. During that same time, more detailed discussions will be held to get a proper idea on how the debugging tools should look like. 20120528 12:02:14< fendrin> During the ongoing week. 20120528 12:02:36< Crab_> neph: ok. as I've said earlier, I think that it's a good idea to actually start with the debugging tools 20120528 12:02:43< Crab_> then, they'll help you to do other stuff 20120528 12:02:50< bloodycoin_m> boucman: yep, it invalidates all hexes under effect surface 20120528 12:02:51< boucman> because it seems to be over-invalidating in the vertical plan to me... 20120528 12:03:00< boucman> is that normal ? 20120528 12:03:38< bloodycoin_m> because there are 2 (or 3) particles and one of them is faster in y direction 20120528 12:04:29< neph> Crab_, I must've missed that, otherwise I'd restructure my timeline. But that's not a problem. I will get in touch with mattsc during the next couple of days and we'll work it out. 20120528 12:04:50< neph> In the mean time, I'll sort out the bugs 20120528 12:04:52< Crab_> ok, good. 20120528 12:05:48< Crab_> then, I'll consider your 'pessimistic' timeline for midterm evaluation. 20120528 12:06:06< neph> Crab_, I can redo it 20120528 12:06:11< Crab_> also, I would ask you to have all the documentation for stuff finished until midterm, by midterm. 20120528 12:06:17< Crab_> yes, you can redo it. 20120528 12:06:26< neph> Crab_, of course 20120528 12:06:34< Crab_> it's exactly the point - you should make sure that the timeline would reflect your plans, as you see them 20120528 12:06:40< Crab_> it's the goals that you, yourself, take 20120528 12:06:43< boucman> bloodycoin_m: ok, I had missed that one, and since you invalidate at the effect level and not at the particle level, it makes perfect sense... 20120528 12:06:55< boucman> so, what's our next step ? :) 20120528 12:08:46< bloodycoin_m> not sure if invalidations are really done for, but I though, maybe I should concentrate on working with actual particle_engine structure. 20120528 12:09:19< bloodycoin_m> so that it could support few effects, with different movement patterns 20120528 12:09:30< boucman> bloodycoin_m: yes, now that we have a clunky engine to work from, it sounds like a good idea to look at that... 20120528 12:10:15< boucman> there are a few cleanups we've just discussed that you could do quickly (mainly so they arn't forgotten) but yes moving to the actual effects sounds like a good next step 20120528 12:13:04< zookeeper> boucman, btw, if you ever feel like you don't have enough things to work on: it'd be nice if story screens had proper support for animated images (such as the journey markers). currently (AFAIK) we can't animate them except by repeatedly placing images on top of each other, which is really ackward and very limiting. 20120528 12:13:33< mordante> fendrin, ok 20120528 12:13:38< Crab_> neph: any questions/blockers at this point? 20120528 12:13:39-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120528 12:13:49< Crab_> also, do you want me to code something, as well? :) 20120528 12:14:47< neph> Crab_, no questions atm. What do you mean by "do you want me to code something"? :) 20120528 12:15:06< bloodycoin_m> though, I am still not sure what is the best approach to movement functions, but I think I will work it out as continue working on it 20120528 12:15:58< Crab_> well, if you want, I can do something that can be of use to you (or what would make things better), i.e. if you spot a place in the AI which needs fixing or can use some refactoring, then you can ask me to take a look at it 20120528 12:16:38< vultraz> fendrin: do you need any art for the editor soon-ish? 20120528 12:16:54< Crab_> i.e., while doing your work, you can spot some *related* things that are outside of your project, or things that annoy you; thus, I can try to fix them :) 20120528 12:17:08< neph> Crab_, I was hoping that I can steal this work from you, do it badly, and then fix it after you have a look on my solution. :D 20120528 12:17:15< Crab_> :))) 20120528 12:17:30< Crab_> fair enough ) 20120528 12:17:41< boucman> bloodycoin_m: yeah, that's how it usually work 20120528 12:17:48< boucman> so when should I expect your next push ? 20120528 12:18:56< fendrin> vultraz: No, not that soon. Getting everything stable enough for the first dev release has priority now. 20120528 12:19:08< vultraz> ah 20120528 12:19:09< vultraz> ok 20120528 12:19:22< bloodycoin_m> well, I have already started on some refactoring in that direction, so, I guess late today, or worst case tomorrow.. 20120528 12:19:44< boucman> ok, i'll be around all day if you need me :) 20120528 12:19:51< neph> Crab_, but, on a serious, I'm fine right now, so I'll just get rid of the small bugs and start moving forwards. I haven't seen mattsc here for a while, he must've drifted away from IRC while I wasn't here during my session. I'll write him on the forums 20120528 12:19:51< bloodycoin_m> ok 20120528 12:19:59< neph> on a serious note* 20120528 12:21:38-!- Johannes13 [~Johannes@unaffiliated/johannes13] has quit [Ping timeout: 240 seconds] 20120528 12:21:43< vultraz> fendrin: also, how do you plan making the palette thingy available to wml coders and stuff? 20120528 12:24:50< fendrin> vultraz: The designer of the addon in question will need to provide his own theme wml config file. This needs to include the palette gui element. 20120528 12:24:57< Crab_> neph: ok, good luck then. please ping me when you'll want me to review something. (but I'll try to watch the commits anyway :) ) 20120528 12:25:06-!- negusnyul [~negusnyul@dsl4E5CD84C.pool.t-online.hu] has joined #wesnoth-dev 20120528 12:25:22< vultraz> fendrin: oh...so it wouldn't be a gui widget? 20120528 12:25:43< fendrin> Well, it is. 20120528 12:26:51< vultraz> I mean, could it be used in a custom window/dialog made in lua or something 20120528 12:29:52< neph> Crab_, ok thanks, I can keep the commit numbers somewhere on my SoC page 20120528 12:30:18< vultraz> fendrin: ^ 20120528 12:30:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120528 12:33:12< Crab_> neph: no need to, it's extra and unnecessary paperwork 20120528 12:33:33< Crab_> neph: git/svn track them just fine. it's just if you want to ping me about something, I'm always available 20120528 12:33:36-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 12:33:44< neph> ok 20120528 12:34:08-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 12:34:13< fendrin> vultraz: no, it's exactly like the palette in the editor. 20120528 12:34:51< vultraz> ah... 20120528 12:35:12< vultraz> it might be useful if it were a gui2 widget though....but that would probably be a lot of work 20120528 12:35:25< vultraz> (to make it both a theme thing and a widget) 20120528 12:36:28< fendrin> vultraz: It's a gui1 widget right now. 20120528 12:38:03< vultraz> hum.... 20120528 12:39:22< vultraz> can it be both? 20120528 12:39:38< vultraz> I mean like a gui2 version and a gui1 version 20120528 12:42:50< vultraz> fendrin: ^ 20120528 12:44:05-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 12:44:43-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 12:44:45< fendrin> vultraz: no 20120528 12:45:08< vultraz> ah 20120528 12:45:10< fendrin> vultraz: gui2 dialogs are modal, meaning the block the rest of the interface. 20120528 12:45:10< vultraz> ok 20120528 12:45:25< vultraz> ? 20120528 12:45:44< fendrin> You can not play on while a gui2 dialog is open, right? 20120528 12:46:20< fendrin> But the editor palette is around all the time, and you still can do the editing. 20120528 12:47:03< vultraz> ahh 20120528 12:48:07< vultraz> but the palette could be very useful in a custom gui2 dialog, but it can't be used unless it's a gui2 widget.... 20120528 12:48:16< vultraz> which is that problem 20120528 12:48:18< vultraz> the* 20120528 12:48:48< fendrin> I think you can already have a palette like dialog using gui2. 20120528 12:49:11< vultraz> really? 20120528 12:52:58< fendrin> no 20120528 12:53:10< fendrin> currently you have only a list of items. 20120528 12:53:33< fendrin> The difference to a palette is only the multiple items per row, right? 20120528 12:54:58-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20120528 12:58:42-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 246 seconds] 20120528 13:00:15< vultraz> fendrin: um...yeah 20120528 13:01:15< fendrin> vultraz: Adding that feature should be doable. 20120528 13:02:15< vultraz> I'm sorta confused... 20120528 13:02:19-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has quit [Remote host closed the connection] 20120528 13:02:23< vultraz> adding multiple items per row? 20120528 13:03:06< fendrin> The question is, what do you expect from a palette what the current gui2 listbox can't do? 20120528 13:07:48-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20120528 13:14:37< vultraz> fendrin: good point actually 20120528 13:22:11< vultraz> fendrin: another question: isn't the terrain palette generated in C++? so how would a WML coder make stuff appear in the palette 20120528 13:23:41-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 13:23:51< fendrin> vultraz: Currently my planing involves feeding units into the palette. This units can represent, well units, but also inventory items etc. 20120528 13:24:14< vultraz> but how would a WML coder do that 20120528 13:24:33< fendrin> Okay, let's have a concrete example: 20120528 13:25:02< fendrin> You want to define a shop, where the player's units can buy weapons. 20120528 13:25:32< fendrin> The shop itself is a building, it can be realized by defining a unit that has no movement points. 20120528 13:26:43< fendrin> This unit also defines what units can be loaded into it. 20120528 13:27:19< fendrin> In our case that would be "empty" units with just one attack for the weopon. 20120528 13:27:42< fendrin> weapon 20120528 13:28:46< vultraz> um..... 20120528 13:28:59< fendrin> Like you can define custom menu_entry when interacting with a hex field, we will have a mechanism to add menu entries for the interaction with the palette items. 20120528 13:29:42< vultraz> I'm sorta lost..... 20120528 13:35:01< Crab_> vultraz: even when is something is done by C++, the C++ code has access to config objects 20120528 13:35:40< Crab_> vultraz: so, even if something is done by C++, WML can pass those configs to it, so, C++ can look at them and act. that's how game events from DirectActionWML work - it's controlled from WML but done by C++ or lua 20120528 13:36:01-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 13:36:04< vultraz> oh 20120528 13:36:47< Crab_> so, fendrin can, for example, add a [palette] tag, or handle it via any other way (such as requiring a WML array variable to be made) 20120528 13:36:55< vultraz> ahh 20120528 13:37:10< vultraz> I just don't get what he's saying about units and such.... 20120528 13:37:22-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 13:38:26< fendrin> vultraz: Okay, let's have another example that might be more easy to understand. 20120528 13:39:12< Crab_> vultraz: about units - he says (if I understand correctly), that he intends to make it possible to make a palette from contents of [unit] tags and variables containing arrays of those (as well as from real units, since they can be stored via [store_unit] into a variable) 20120528 13:39:12< fendrin> You want to have a transporting unit, let's say a ship. 20120528 13:42:28< vultraz> Crab_: ahh....I hope we'll be able to add custom stuff that doesn't involve [unit] though... 20120528 13:42:43< fendrin> The ship itself defines what units can be loaded into it. 20120528 13:43:04< fendrin> Those units are contents of the palette after they have been loaded. 20120528 13:43:17< vultraz> ahh 20120528 13:43:24< fendrin> vultraz: What other stuff do you want to keep? 20120528 13:43:25< mordante> vultraz, the same with gui2, most things regarding the looks are determined by WML 20120528 13:44:38< vultraz> fendrin: say if you had an inventory, you could put items in the palette ( stuff you pick up on the map, etc) 20120528 13:45:04< fendrin> Okay, just model them with units. 20120528 13:45:43< vultraz> that seems sorta inelegant 20120528 13:45:57< fendrin> Crendgrim already did that in one of his addons iirc. 20120528 13:46:19< Crendgrim> no, not really. 20120528 13:46:44< Crendgrim> as that functionality does not yet exist 20120528 13:54:15< vultraz> fendrin: I think something like a [palette] tag (like Crab_ suggested) would work better....something like http://pastebin.com/c4L11G27 20120528 13:54:56< vultraz> there might be a more elegant/easier way, but I can't think of one right now 20120528 13:59:09< Crab_> well, we can just think of palette as a way of display for a WML array 20120528 13:59:33< Crab_> it can be made compatible with WML array of units, by picking correct attribute names for pictures/names 20120528 13:59:57< Crab_> then, when you need to display something, just do 'please display a palette based on WML variable with name FOO' 20120528 14:00:25< Crab_> then, to add/remove stuff from the palette, we can just use standard operations on WML variables 20120528 14:01:25< Crab_> then, when the user would select something from the palette, the 'selected' wml config (or it's index in the array) would be saved into another user-specified WML variable 20120528 14:03:28-!- Gambit [~gambit@pa-67-235-3-51.dhcp.embarqhsd.net] has joined #wesnoth-dev 20120528 14:03:33-!- Gambit [~gambit@pa-67-235-3-51.dhcp.embarqhsd.net] has quit [Changing host] 20120528 14:03:33-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120528 14:04:52< vultraz> Crab_: but if you add/remove an index from the array, wouldn't the palette have to be redrawn? 20120528 14:05:38< Crab_> yes, if we want to update the view 20120528 14:06:54< vultraz> hummm 20120528 14:07:07< vultraz> I think I like your way better than mine ;) 20120528 14:07:21< Crab_> I mean, if we have drawn the palette and are happy with it, then we can just ignore the changes to the variable 20120528 14:07:41< Crab_> or, we can add a way to 'ping' the UI that it needs to redraw from the new variable 20120528 14:11:23< vultraz> true.... 20120528 14:12:21< vultraz> I think maybe having the user define when the redraw should happen is better, though, for the first reason you stated 20120528 14:16:19< Crab_> ok, I agree 20120528 14:16:28< Crab_> fendrin: what do you think? 20120528 14:17:26< Crab_> fendrin: note that by making the required attributes in that WML variable match the attributes in [unit], you can use units as palette containers, as you wanted to. 20120528 14:38:22< fendrin> Crab_: Yeah, sounds good. 20120528 14:51:30-!- light_mage [~chatzilla@14.98.101.244] has joined #wesnoth-dev 20120528 15:01:18< vultraz> fendrin: so, when might this palette stuff be ready. 20120528 15:03:07-!- artisticdude [~benjamin@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120528 15:05:01< light_mage> hi everyone! can you guys tell me if there is a function for a random variable generator, in formula ai? If no, how can i write one? Thx :) 20120528 15:12:22-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has joined #wesnoth-dev 20120528 15:12:27< Crab_> light_mage: hello 20120528 15:13:16< mattsc> light_maage: it's 'd'; see http://wiki.wesnoth.org/FormulaAI#Formula_Basics 20120528 15:13:24< fendrin> vultraz: Well, it will take its time. Maybe 1.12 will feature it. 20120528 15:13:25< mattsc> *light_mage 20120528 15:14:08< mattsc> Hi, neph, Crab_: I'll be on "for real" in about an hour. 20120528 15:14:31< Crab_> hi, mattsc. glad to see you 20120528 15:17:28-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Remote host closed the connection] 20120528 15:18:01-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 15:33:09-!- neph [~neph@80.233.231.12] has quit [Ping timeout: 248 seconds] 20120528 15:38:07-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 15:39:38-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 15:46:54-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 250 seconds] 20120528 15:47:39< fendrin> boucman: Hmmm, the map generator related bug is strange. It looks like it was caused by my map format changes in the first place, but further investigation doesn't match that assumption. 20120528 15:48:03< boucman> fendrin: what bug ? 20120528 15:48:51-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 15:48:52< fendrin> https://gna.org/bugs/?19697 20120528 15:49:04< fendrin> I wonder if someone else did related stuff to the codebase. 20120528 15:49:19< boucman> did you try bisecting ? 20120528 15:49:26< fendrin> Not yet. 20120528 15:50:12-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 15:50:12< fendrin> Most problems related to the map format change are caused by missing usage= and border_size= attributes. But this bug is defined by the whole map string missing. 20120528 15:50:15< AI0867> wesbot: bug #19697 20120528 15:50:15< wesbot> Bug #19697 Assigned to: Fabian Müller Status: Confirmed Priority: 9 - Immediate 20120528 15:50:18< wesbot> Summary: Trying to create a game with a Random Map results in an error message 20120528 15:50:21< wesbot> Original submission: 20120502 16:33:39 error general: The scenario is invalid 20120528 15:50:24< wesbot> because it has no sides. 20120528 15:50:27< wesbot> URL: https://gna.org/bugs/?19697 20120528 15:50:44-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 15:58:52-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has quit [Quit: bye] 20120528 16:00:49< boucman> Crab_: around ? 20120528 16:05:01< Crab_> boucman: yes 20120528 16:05:22< boucman> Crab_: you have a huge number of patches assigned to you, some are more than one year old... 20120528 16:05:38< boucman> could you have a look at them and close the ones you won't deal with ? 20120528 16:05:52< boucman> just so I stop bugging you about them... 20120528 16:05:53< Crab_> ok, I'll do it. hopefully, today) 20120528 16:05:58< boucman> great, thx 20120528 16:06:05< boucman> mordante: you've got a few too :) 20120528 16:09:56< Crendgrim> hm.. do I see it correctly that there is no way to have custom menu items somewhere else than in the context menu? 20120528 16:10:28-!- molgrum [~molgrum@h-189-21.a189.priv.bahnhof.se] has joined #wesnoth-dev 20120528 16:10:55< mordante> Akihara, around? 20120528 16:11:42< Akihara> mordante: yes 20120528 16:13:25< mordante> boucman, I'll have a look at them later, need to look at the one of hankerspace, I don't expect updates anymore :-( 20120528 16:18:45-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20120528 16:21:21< vultraz> mordante: you did the file adding commit yet? 20120528 16:21:32< mordante> vultraz, jup 20120528 16:21:45< vultraz> k, I'll see if I can get on my mac 20120528 16:21:56< mordante> would be nice 20120528 16:27:21-!- ancestral [~ancestral@97-127-66-8.mpls.qwest.net] has joined #wesnoth-dev 20120528 16:29:05< fendrin> Crendgrim: Well, there is the possibility to define extra menu entries in the theme wml which are shown in the toplevel menu. But there is no way to define their purpose other than coding in c++ yet. 20120528 16:30:26-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120528 16:30:37-!- _vdn1 [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 16:32:22< Crendgrim> fendrin: there is a way to register new menus, yes, but I cannot set up new menu items 20120528 16:32:42< Crendgrim> not even by using "wml" as an item, as it is done with the context menu.. :( 20120528 16:33:19-!- _vdn [~nazgul-sa@ppp85-141-127-188.pppoe.mtu-net.ru] has quit [Ping timeout: 260 seconds] 20120528 16:36:53< fendrin> Crendgrim: New menus? You can do both, define new menus with new items. The functionality behind them is the problem. 20120528 16:37:49< Crendgrim> fendrin: well, not really. I cannot register any menu items; or rather, if I do so, they won't show up at all 20120528 16:39:37< fendrin> Crendgrim: Yes, that is connected with the functionality problem, they are disabled by default, because their is a mechanism that sees if they are valid in the current gamestate. 20120528 16:40:14< fendrin> If that default would change to visible you still have the problem that there is no c++ function bound to them. 20120528 16:46:42-!- artisticdude [~benjamin@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Ping timeout: 250 seconds] 20120528 16:48:19< Crendgrim> yes 20120528 16:48:36< Crendgrim> fendrin: so, I take it that there really is no way yet? 20120528 16:52:38< fendrin> Crendgrim: Yes, but there is hope. It should be doable to introduce a similar mechanism like is used for the [menu_entry] thing. 20120528 16:53:17< fendrin> Crendgrim: Or just address the same codepath from the 2 different sources. 20120528 16:54:19< Crendgrim> fendrin: it would be very nice if one could just list "wml_my_menu_item", and it would show the item registered with [set_menu_item]id=my_menu_item 20120528 16:55:10< Crendgrim> as menus with only one item automatically open that one, this would allow to place buttons in the menu bar for important custom actions (such as dialogues) 20120528 16:58:01< fendrin> Crendgrim: Why not [set_menu_item] location=topbar/context ? 20120528 16:58:30< Crendgrim> fendrin: it still would need to know where exactly it has to be placed 20120528 16:58:36< fendrin> right 20120528 16:58:49< Crendgrim> fendrin: which would have to be set in ThemeWML 20120528 16:59:01< fendrin> is that a problem? 20120528 16:59:08< Crendgrim> fendrin: so I don't see where the location= attribute would change anything.. 20120528 16:59:49< fendrin> What happens if you name a new entry defined with set_menu_item in ThemeWML? Does it show up? 20120528 16:59:57< Crendgrim> no, it doesn't. 20120528 17:00:01< Crendgrim> sadly :( 20120528 17:03:38< fendrin> That should be easy to implement, fill a feature request if you want. 20120528 17:04:02< fendrin> Makes a nice easy coding task for the next gsoc generation. 20120528 17:04:14< Crendgrim> I'll do. 20120528 17:04:21< fendrin> :-) 20120528 17:06:53-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 252 seconds] 20120528 17:07:03-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120528 17:09:50< mattsc> neph, I am around now, and will be for quite some while. 20120528 17:17:07-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 17:19:21< Crendgrim> fendrin: sent. 20120528 17:19:25-!- _vdn1 [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer] 20120528 17:19:26< Crendgrim> thanks :) 20120528 17:19:59-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 17:31:22< mattsc> Hello again, Crab_. I seem to have found a bug with setting AI aspects (in WML), but I am very confused, because I thought I had tested it before and it worked then. So if somebody could test this and let me know before I file a bug report... 20120528 17:31:43< mattsc> Setting a simple 'aggression' aspect like this: http://pastebin.com/1sgmrgZa 20120528 17:32:15< mattsc> does not seem to work when 'time_of_day' is set. By contrast using 'turns' (and commenting out the ToD line) works. 20120528 17:34:53< Crab_> hello, mattsc. a few mins... 20120528 17:35:04< mattsc> Crab_: thanks 20120528 17:35:51-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 17:36:29-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 17:39:19< mattsc> Btw, I am doing this in 1.10.2. It's very strange, because this is something very commonly used and I am almost certain that I have tried this before... 20120528 17:40:45-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20120528 17:44:58-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 17:45:30-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 17:47:09< mattsc> It does seem to be there correctly in the AI config: http://imagebin.org/214210, but looking at it in the 'ai overview', it does not show a changed value at those times of day (while it does when using 'turns=') 20120528 17:48:34< mattsc> (re-typed with different values to make sure I didn't have a stupid typo somewhere) 20120528 17:48:44-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120528 17:51:50< boucman> fendrin: around ? 20120528 17:52:06< boucman> or zookeeper, for that particular question... 20120528 18:05:17-!- Crend [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev 20120528 18:05:17-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has quit [Read error: Connection reset by peer] 20120528 18:05:47-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20120528 18:05:57< CIA-61> anonymissimus * r54327 /trunk/projectfiles/VC9/wesnoth.vcproj: vc9 project update 20120528 18:06:08< CIA-61> anonymissimus * r54328 /trunk/projectfiles/CodeBlocks/wesnoth.cbp: cb project update 20120528 18:06:36-!- Crend is now known as Crendgrim 20120528 18:06:42< anonymissimus> mordante: Warnung 1 warning C4373: 'gui2::tcontrol_NEW::set_active': Virtuelle Funktion überschreibt 'gui2::tcontrol::set_active'. Vorherige Compilerversionen werden nicht überschrieben, wenn sich die Parameter nur durch const/volatile-Qualifizierer unterscheiden. f:\wesnoth\src\gui\widgets\matrix.hpp 73 20120528 18:06:49-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 18:07:16< fendrin> boucman: yes 20120528 18:07:23< boucman> hey 20120528 18:07:34-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 18:07:40< boucman> could you give me some feedback about https://gna.org/patch/?3039 20120528 18:07:47< boucman> (just read the patch itself, it's quite simple 20120528 18:08:48< boucman> my guess is that it duplicates the funcitonality of ^Xo but i'm not 100% sure 20120528 18:11:20< fendrin> boucman: imho the ^Xo == impassable also blocks flying creatures while unwalkable is more like lava, don't walk in it if you want to life on but you can savely fly above it. 20120528 18:11:37< boucman> mkay... 20120528 18:11:41< boucman> usefull ? 20120528 18:12:10< fendrin> boucman: I think the current expert on terrain is the nice guy called alaralarantalaralara. 20120528 18:12:42< boucman> :) 20120528 18:12:48< boucman> ok, i'll wait for him 20120528 18:13:45< fendrin> But I think it is useful. At least for the purpose mentioned in the FR. 20120528 18:13:52< boucman> ok, thx 20120528 18:14:07< boucman> i'll discuss with alanantara and then commit if he's fine with it 20120528 18:14:21< fendrin> yeah :-) 20120528 18:14:28-!- neph_ [~neph@80.233.231.12] has joined #wesnoth-dev 20120528 18:17:41< mattsc> Oh, hi, neph_. I thought you were online earlier... I'm around if there's something you want to discuss. 20120528 18:18:41< boucman> hey neph_ 20120528 18:19:01< boucman> neph_: are you nephro on gna ? 20120528 18:19:14< neph_> hello mattsc boucman 20120528 18:19:19< neph_> boucman, yes, id Nephro 20120528 18:20:07< boucman> neph_: could you have a look at https://gna.org/patch/?1666 and https://gna.org/patch/?1577 ? they are assigned to you... 20120528 18:20:28-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 18:21:00-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 18:21:58< neph_> ah yes, thanks boucman. I completely forgot about these two. 20120528 18:22:05< boucman> :) 20120528 18:24:16< mordante> anonymissimus, interesting never seen that one before, will commit a fix soon 20120528 18:25:54< anonymissimus> mordante: @@ -68,11 +68,11 @@ public: 20120528 18:25:56< anonymissimus> : tcontrol(builder, STATE::COUNT, control_type) 20120528 18:25:57< anonymissimus> 20120528 18:25:58< anonymissimus> { 20120528 18:26:00< anonymissimus> } 20120528 18:26:02< anonymissimus> 20120528 18:26:03< anonymissimus> - void set_active(bool active) 20120528 18:26:05< anonymissimus> + void set_active(const bool active) 20120528 18:26:06< anonymissimus> { 20120528 18:26:07< anonymissimus> STATE::set_active(active); 20120528 18:26:08< mordante> anonymissimus, yeah I know what the problem is 20120528 18:26:09< anonymissimus> } 20120528 18:26:11< anonymissimus> 20120528 18:26:12< anonymissimus> bool get_active() const 20120528 18:26:23< mordante> the patch I have looks the same ;-) 20120528 18:26:36< anonymissimus> your commit 20120528 18:26:56< mordante> my commit? 20120528 18:27:25< anonymissimus> and you have seen that; in r49240 xd 20120528 18:27:40< anonymissimus> I mean I don't commit since I dont wanna interfere with yu 20120528 18:29:15< CIA-61> mordante * r54329 /trunk/src/gui/widgets/matrix.hpp: 20120528 18:29:15< CIA-61> Fixes MSVC compiler warning C4373. 20120528 18:29:15< CIA-61> Issue spotted by anonymissimus, who proposed the same fix. 20120528 18:29:34< mordante> thanks 20120528 18:29:51< mordante> ah yes I've seen it before... couldn't remember it 20120528 18:30:15< mordante> I also wonder whether the warning is valid ;-) 20120528 18:30:39-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.] 20120528 18:45:19-!- mjs-de [~mjs-de@g224190232.adsl.alicedsl.de] has quit [Remote host closed the connection] 20120528 18:45:32-!- rayblade3 [~chatzilla@124.109.10.221] has joined #wesnoth-dev 20120528 18:48:04< vultraz> mordante: working on updating XCode 20120528 18:48:14< mordante> thanks vultraz 20120528 18:50:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 18:54:49< anonymissimus> mordante: are there more new files to come ? 20120528 18:56:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120528 18:56:57< mordante> anonymissimus, not directly 20120528 19:02:31-!- gabba [d8623925@wesnoth/developer/gabba] has joined #wesnoth-dev 20120528 19:02:41< gabba> hey ejls 20120528 19:03:36-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 11.0/20120312181643]] 20120528 19:04:35-!- rayblade3 [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds] 20120528 19:04:57< Crab_> hi, mattsc. sorry, has got a small meeting :) 20120528 19:05:34< mattsc> Crab_, no worries, I have many hours of time difference advantage on you. 20120528 19:06:51< Crab_> mattsc: I see the facet for afternoon, right. I would be able to debug this. please make a bug out of it if it's not done yet, I'll fix it 20120528 19:08:02< mattsc> Will do. I think I have tested this enough that it is indeed a bug rather than me doing something stupid, but the latter is always possible... 20120528 19:09:46< vultraz> mordante: src/utils doesn't seem to be in the XCode proj, are they meant to be added? 20120528 19:10:35-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20120528 19:10:59< mordante> vultraz, not per se, the files are header only files 20120528 19:11:11-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120528 19:14:17< vultraz> k 20120528 19:15:18-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 19:16:05-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 19:25:44-!- vultraz is now known as vultraz_laptop 20120528 19:27:41< vultraz_laptop> mordante: http://pastebin.com/5g9qtrkj that should do it 20120528 19:29:12-!- neph_ [~neph@80.233.231.12] has quit [Read error: Connection reset by peer] 20120528 19:29:36-!- neph_ [~neph@80.233.231.12] has joined #wesnoth-dev 20120528 19:32:15< CIA-61> mordante * r54330 /trunk/projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project file (patch by vultraz). 20120528 19:32:31< mordante> thanks vultraz_laptop, commit it^ 20120528 19:32:37< vultraz_laptop> :) 20120528 19:39:16< mattsc> Crab_: bug's been reported (by somebody else, I just added a comment). I cannot assign it to you though. 20120528 19:39:25-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20120528 19:46:05-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds] 20120528 19:47:11-!- neph__ [~neph@80.233.231.12] has joined #wesnoth-dev 20120528 19:47:54< fendrin> boucman: I got it. And of course it was related to my map format changes... 20120528 19:49:34-!- molgrum [~molgrum@h-189-21.a189.priv.bahnhof.se] has quit [Quit: Lämnar] 20120528 19:49:50-!- wesbot changed the topic of #wesnoth-dev to: 175 bugs, 337 feature requests, 15 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120528 19:50:25-!- neph_ [~neph@80.233.231.12] has quit [Ping timeout: 250 seconds] 20120528 19:53:10-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 19:53:20< CIA-61> fendrin * r54331 /trunk/src/mapgen.cpp: 20120528 19:53:20< CIA-61> Add additional attributes usage and border_size to a generated [map]. 20120528 19:53:20< CIA-61> These are currently ignored (in case of a generated map) but that might change in the future. 20120528 19:53:46-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 19:56:00< CIA-61> fendrin * r54332 /trunk/src/playcampaign.cpp: 20120528 19:56:00< CIA-61> Fixed missing attributes usage and border_size when the map is autogenerated by the usage of the generate_map attribute. 20120528 19:56:00< CIA-61> This fixes bug #19642 20120528 19:58:44-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 19:59:02< boucman> afk, tel 20120528 19:59:43< neph__> mattsc, hi again 20120528 20:00:10< mattsc> Hi, neph__ 20120528 20:00:16< neph__> mattsc, do you want to discuss possible debug tools and methods ? 20120528 20:00:38< mattsc> sure 20120528 20:01:47< neph__> mattsc, in this case, it would be productive if you tell me what problems do you usually encounter during scripting and how you work around to debug things 20120528 20:03:35< mattsc> So, the way how I debug things is that I work with the side in human-controlled mode. I move units around, or get myself new units or change their values (HP, moves, ...) using debug commands. 20120528 20:04:08< mattsc> I then have a right-click option that calls code from a Lua file (so that I can change it on the fly) 20120528 20:04:45< mattsc> Usually, it is set up so that it executes exactly one of the CA eval or exec functions 20120528 20:05:16< mattsc> That way I can test how the AI reacts to the different situations, without having to wait for them to happen during an AI move. 20120528 20:05:42-!- gabba [d8623925@wesnoth/developer/gabba] has quit [Quit: Page closed] 20120528 20:06:18< mattsc> So, I think mostly what I need is access to the ai functions that provide information about the side, map, units etc., and it needs to be updated to the situation on the map, even if I change it by hand (by moving units or changing them with debug commands) 20120528 20:06:46< mattsc> Is that what you wanted to knnow? 20120528 20:07:31-!- _vdn1 [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 20:07:58-!- _vdn [~nazgul-sa@ppp85-141-112-40.pppoe.mtu-net.ru] has quit [Ping timeout: 245 seconds] 20120528 20:08:16< neph__> mattsc, how does the thing that calls Lua from a file work? 20120528 20:08:19< mattsc> How expensive (computationally) it is to update any of that is not important at all 20120528 20:08:55< mattsc> Hold on, I'll pastebin something ... 20120528 20:11:04< mattsc> neph__: http://pastebin.com/tjKhs59K 20120528 20:13:48< neph__> mattsc, either something is wrong with my internet, or that link is broke 20120528 20:13:51< neph__> broken* 20120528 20:14:07< neph__> ignore it 20120528 20:14:10< neph__> works now 20120528 20:15:11< neph__> mattsc, oh yes, I see the problem 20120528 20:15:18< neph__> it must really hurt to work this way 20120528 20:15:42< mattsc> Uh, no, it is super convenient (except for some missing info) 20120528 20:16:28-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom] 20120528 20:18:43< neph__> mattsc, so, basically, you need fast access to ai components. What if we make a small gui window, that will hang somewhere over the map. It will contain an automatically generated list of components and you will be able to launch them any time you want 20120528 20:18:57< neph__> without having 20120528 20:19:07< neph__> to create the events, menu items, etc 20120528 20:19:55< neph__> it will also preserve incapsulation, since I think, your approach exposes stuff to the global environment 20120528 20:19:59< mattsc> neph__: I am not sure that I understand. I don't need to be able to see them, I need my custom functions to be able to access them 20120528 20:20:35< mattsc> and they need to correctly represent the current situation on the map, even if it's not during an AI turn 20120528 20:20:40-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 20:21:55-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20120528 20:22:30< mattsc> In other words, what you have done previously with the debug tables (a few weeks ago) is exactly what (and all that) I need, as long as it is available for moves, attacks etc. 20120528 20:25:02< neph__> mattsc, right now I was suggesting to just automate the things you usually do by hand 20120528 20:25:15< neph__> like creating menu items and manual launchers 20120528 20:26:05< neph__> I 20120528 20:26:17< neph__> I'll make a little sketch 20120528 20:27:25< mattsc> Oh, I see. Ok - but since that one menu item is really all I need, that;s not such a big deal (at least for me). So that's why I've been concentrating on the functionality. 20120528 20:29:30< mattsc> And that needs to be able to call a custom file, so you'd need to make your window configurable etc. That seems like a lot of work for something that can be done with a one-line macro call. 20120528 20:29:56< neph__> mattsc, imagine if you write multiple versions of your CA and you want to see how each one evaluates the state. 20120528 20:30:54< neph__> mattsc, you can bypass the custom file step if I understand correctly 20120528 20:31:02< mattsc> Ok. So I have several menu options (each of which is one line in the WML code; since it calls a macro). 20120528 20:31:43< mattsc> How would you do that? Your code needs to be in a file somewhere doesn't it? And so you need to give it that filename somewhere. 20120528 20:32:17< mattsc> I probably just don't understand yet what you are imagining. :) 20120528 20:33:12< neph__> mattsc, but the code in the file does nothing but calls the eval and then exec if eval returned a positive integer. You can package such a function together with your CA 20120528 20:34:17< mattsc> Well, in my case the eval/exec functions are actually in the same file. So I only ever deal with one file. 20120528 20:34:27-!- ancestral [~ancestral@97-127-66-8.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120528 20:35:11< mattsc> If you want them in your AI, then you need those to be accessible even if you're not in AI mode (which I think you've told me is not a good thing) 20120528 20:35:36< the_new_lipk> boucman: ping 20120528 20:35:43< boucman> hey 20120528 20:35:56< neph__> mattsc and Crab_, I think I've written that down in my proposal page, but I think we could solve a couple of problems if we constrain the users a bit, with the lua scripting. Right now they have too much freedom :) 20120528 20:36:45< the_new_lipk> boucman: the patch is ready, so I pinged you 20120528 20:37:20< boucman> :) 20120528 20:37:31< boucman> ok, i'll look into it right away 20120528 20:37:33< mattsc> neph__: if you take testing in user-controlled mode away as a capability, I'll got back to Formula AI. ;) 20120528 20:37:52< mattsc> *go 20120528 20:38:10< neph__> mattsc, Crab_: what if: (1) a file contains a table with the name of the CA. Fields are eval, exec and debug[]. (2) the debug array contains a couple of testing launchers like mattsc uses in his workflow. 20120528 20:39:07-!- _vdn1 [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 20:39:40-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 20:40:19< neph__> mattsc, Crab_: now we can get rid of the engine definition(but still allow people to use it if they want to make something really fancy) - that's less boilerplate. Registering a CA will now be either the old way or the new syntax "[candidate_action] engine=lua location=filename [/ca]" 20120528 20:40:38< boucman> the_new_lipk: I don't really understand what the ignore_* do, could you rephrase for me ? 20120528 20:41:13< neph__> mattsc, Crab_ the debug tool will then collect all the CA's and provide access to launch them manually using the launcher scripts from debug[] 20120528 20:41:33< mattsc> neph__: getting rid of the engine definition is definitely good. 20120528 20:41:55< neph__> mattsc, this will give you access to the CA's without making them global, that is, in a clean way 20120528 20:42:05< the_new_lipk> boucman: let us have two add-ons, A and B. A somehow claims to be incompatible with B (blacklisting B, or not including it on the whitelist) 20120528 20:42:15< neph__> mattsc, and you will not have to add debug code to your scenarios 20120528 20:42:31< mattsc> How exactly I can use my debug tools doesn't matter to me, as long as it does not more difficult than it is right now. 20120528 20:42:42< the_new_lipk> boucman: then B can use an ignore_... key to force compatibility with A 20120528 20:42:49< boucman> hmm 20120528 20:42:59< neph__> mattsc, it will be simpler 20120528 20:43:04< neph__> that's the whole point 20120528 20:43:13< boucman> I'm not sure I like the idea, I think A and B's authors should work it out 20120528 20:43:17< boucman> do you have a use case 20120528 20:43:27< boucman> 20120528 20:43:38< mattsc> neph__: ok; I don't see that yet, but I'll take your word for it... 20120528 20:43:41< neph__> mattsc, you will skip the step of adding and removing debug code in the scenario(the thing that in my opinion is bad and annoying) 20120528 20:43:51< the_new_lipk> boucman: actually, this has come up to solve a rather realistic use case :) 20120528 20:43:52< boucman> why don't your setters return a bool indicating success rather than having a warning to check that they actually worked ? 20120528 20:44:17< neph__> mattsc, well, also, as they teach me in uni, software design is all about design, prototype, scrape and start over 20120528 20:44:20< neph__> :) 20120528 20:44:33< mattsc> :) 20120528 20:45:27< mattsc> neph__: The debug code (so far), is exactly the same as the real AI code, except for those 4 lines I pastebinned earler. And you do need a way of calling either only the eval or only the exec function, or both. 20120528 20:45:27< the_new_lipk> boucman: because in case of failure, you have to check what has got selected anyways 20120528 20:45:46< mattsc> so far: meaning, in the current version of Lua AI 20120528 20:45:47< boucman> hmm, I don't really like that, but ok... 20120528 20:46:09< the_new_lipk> boucman: but I can change that in about 2 seconds if it annoys you... 20120528 20:46:18< mattsc> neph_: let me give you a concrete example of what I care about (and what not): 20120528 20:46:32< boucman> no, we need to find a way that satisfies both of us... :P 20120528 20:46:54< boucman> would a "try_scenario" be ok with you ? 20120528 20:47:13< boucman> I don't like the idea of setters that can fail silently... it's calling for bugs 20120528 20:47:28< the_new_lipk> with nothing else changed? 20120528 20:47:36< boucman> so either rename them to something else, have them return success, raise an exception or something 20120528 20:47:37< mattsc> Let's look at the pass_defense AI I have written. I position units at the pass. After that is done, some bit of the code evaluates whether it is advantageous to attack one of the neighboring units. In order to evaluate that attack decision: 20120528 20:48:03< mattsc> I (manually; using debug commands), put a unit at the pass, and an enemy unit next to it. 20120528 20:48:05< boucman> the_new_lipk: or try_set_scenario, or another name if you have the idea 20120528 20:48:16< the_new_lipk> ok, I'll rename it 20120528 20:48:25< the_new_lipk> *them 20120528 20:48:31< boucman> it's just that setters have a logic that coders expect them to follow, so I don't like naming them like setters 20120528 20:49:09< mattsc> Then I call the attack CA, to see if whether it decides to attack. I am not actually having it execute the attack, just look at a bunch of debug info it gives me (using 'print' commands displayed in a terminal window). 20120528 20:49:21< boucman> style: you might want to declare a small enum for the parameter to insert_element, it's safer than a string 20120528 20:50:31< mattsc> Then I change the conditions (the unit type, the HP, whatever), again using debug tools, and have it evaluate again. That's how I trouble-shoot whether my functions do what I want them to do, rather than having it play through an AI move and hoping that all the right conditions present themselves. 20120528 20:51:39< mattsc> As long as I can do that, and "calling the attack CA" is not more than a mouse click (well, two), I'm happy and I don't really care about the rest. 20120528 20:52:08< mattsc> So if you're cleaner solution can do that, we'll all be happy. :) 20120528 20:52:19< neph__> mattsc, wait, do you modify and run the fresh versions of the scripts without restarting the game? 20120528 20:53:20< boucman> the_new_lipk: you still have a TODO in src/multiplayer_connect.cpp 20120528 20:53:39< the_new_lipk> kasídhbkasdhfsdf??? 20120528 20:53:46< mattsc> neph__: absolutely! That's the beauty of including a Lua file like that. 20120528 20:53:57< boucman> ? 20120528 20:54:12< boucman> the_new_lipk: cat on keyboard ? 20120528 20:54:19< mattsc> If I had to restart the game every time, I would have long given up... 20120528 20:55:06< the_new_lipk> boucman: ohhh I ended up implementing the error handling at a different place, just forgot to remove that comment 20120528 20:56:21< neph__> mattsc, can you show me the whole lua_manual.lua file, please? 20120528 20:56:30< boucman> the_new_lipk: I have something very weird in mp_depcheck.cpp in coy_keys the second test is for "disallow_scenario" instead of a "disallow_"+type I would expect 20120528 20:56:36< boucman> probably a copy/paste error 20120528 20:58:06< the_new_lipk> yes 20120528 20:58:42< mattsc> neph__: sure, here it is: http://pastebin.com/qX9MdqrL 20120528 20:59:19< mattsc> It's long and there's a lot of crap in it (it probably doesn't even work in its current version because I use it for all kinds of stuff), but will probably give you the information you need 20120528 20:59:21-!- _vdn1 [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 21:00:15< the_new_lipk> boucman, along the way I forgot to sketch you the use case for ignore_ keys... 20120528 21:00:34< boucman> the_new_lipk: that's ok, i'll ask for it eventually :) 20120528 21:01:48< neph__> matthiaskrgr, 20120528 21:01:48< boucman> the depinfo_ member of the manager, shouldn't it be a std::map< std::pair , info> ? 20120528 21:01:50< neph__> oops 20120528 21:02:15< neph__> mattsc, so the ai.table is in global context for that to work, right? 20120528 21:02:33-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Ping timeout: 245 seconds] 20120528 21:02:41< neph__> ai table * 20120528 21:03:06< the_new_lipk> boucman: config was very convenient to use, and I didn't feel like needing to reinvent the wheel 20120528 21:03:26< boucman> manager::contains definitely doesn't belong here, it's just some blind std manipulation, either move it to our utils or simply use the line directly (we are used to seeing it in our code) 20120528 21:03:31< boucman> the_new_lipk: ok, just asking 20120528 21:03:59< boucman> but the multimap would have been more efficient :P 20120528 21:05:14< mattsc> neph__: right. And I know you have told me that you don't like that (but that's how it was when I started using Lua AI) 20120528 21:06:29< boucman> a modification can't require other modifications ? 20120528 21:06:42< mattsc> As I said, I'm just a user, I really don't care how you code that internally, as long as I can use the procedure I described above. 20120528 21:06:54< neph__> mattsc, well, it is really convenient, that I can't argue with. 20120528 21:07:14< mattsc> :) 20120528 21:07:22< the_new_lipk> boucman: no, it can't. I've discussed this with zookeeper and he agreed that this isn't a must-have now 20120528 21:07:53< boucman> ok, it avoids circular dependencies too 20120528 21:09:53< mattsc> neph__: And when you're done testing, all you have to do is copy it into your AI engine (or you can even use the same file, if you want) and uncomment the 'return prune_cart' line and you're all set. 20120528 21:10:39< boucman> ok, in that case, you want to print an error in manager::get_required if a dependency is found, instead of just ignoring it (unless you do that in another place I havn't seen yet) 20120528 21:14:17< the_new_lipk> I don't see why is that necessary. [modification]-s can't have force_modification keys at all. 20120528 21:14:31< boucman> ok 20120528 21:15:39-!- _vdn1 [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 21:16:02-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 21:18:07< neph__> mattsc, I need to do some thinking now, but I think it is possible to do it in a clean manner 20120528 21:18:36-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20120528 21:18:56< Necrosporus> Hello. How do I find the developer of Era of Magic? 20120528 21:18:58< mattsc> neph__: Ok, sounds good. Btw, did you get my PM about the weapon number bug in ai.attacks() ? 20120528 21:19:04< Necrosporus> Maybe here? 20120528 21:19:25< neph__> mattsc, not sure about the PM, but I know that bug is haning on me, will be sorted 20120528 21:20:33< the_new_lipk> Necrosporus: don't think so. Rather on the forums. 20120528 21:20:38< mattsc> neph__: great, thanks. That one actually means that people cannot currently test the AI Mod scenarios in trunk, so it would be great to have it fixed. 20120528 21:20:53< Necrosporus> http://storage3.static.itmages.ru/i/12/0528/h_1338232619_7441835_d6c5f11c0c.png 20120528 21:21:03< Necrosporus> http://storage3.static.itmages.ru/i/12/0528/h_1338232250_9486764_5c139d4264.png 20120528 21:21:20< Necrosporus> Anyways, I got an artist to draw an Water God 20120528 21:21:28< mattsc> neph__: As for the debugging procedure, if that only works when debug mode is enabled, that's perfectly fine. As you see, I make heavy use of debug tools anyway, so it's always on. 20120528 21:21:33< Necrosporus> Which seem to lack a big portrait 20120528 21:21:39< boucman> the_new_lipk: in manager::change_scenario you have an untranslated string in the first failure_dialog 20120528 21:21:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 21:21:53< Necrosporus> How do I know, is it useful for the game? 20120528 21:22:08< boucman> and it would be better if you could give the name of the missing dependencies 20120528 21:22:19< boucman> more user-friendly 20120528 21:22:59< Necrosporus> I guess, there must be someone who may answer anyways 20120528 21:23:11< the_new_lipk> boucman: okay 20120528 21:25:03< boucman> the_new_lipk: another one in manager::change_era, you should have a quick look to all your strings to check that 20120528 21:25:19< boucman> check in the patch it's probably easier than finding them in the source code :P 20120528 21:27:01< the_new_lipk> meh... this happens if you don't care about the translation stuff during the actual development... 20120528 21:28:20< boucman> the_new_lipk: don't worry, in such a huge patch it can't be avoided, I asked you to check that because I can't focus on that while proofreading, so I probably missed a few myself 20120528 21:31:04< boucman> the_new_lipk: i'm done with proofreading, but that's one of the biggest (if not the biggest) patch I ever received. 20120528 21:31:25< boucman> it's still manageable, but I definitely want a second proofreader on it, preferably mordante. 20120528 21:31:48< boucman> so i'll try to get him to look at it quickly so we can get this great stuff in 20120528 21:31:53< boucman> mordante: around ? :) 20120528 21:36:06< the_new_lipk> boucman: something which I'm not sure I've done properly are the license headers of new files. They're currently either don't name a copyright bearer give the copyrights to Dave. 20120528 21:36:16< the_new_lipk> *or give the 20120528 21:37:06< boucman> i'm not sure what you are supposed to do, Ivanovic might know more on that... 20120528 21:37:20< boucman> or noy 20120528 21:38:21< noy> I don't think it matters.... 20120528 21:38:37< noy> or you can say that licensed under GPL V2 whatever 20120528 21:41:29< the_new_lipk> noy: yeah, that's clear but the other files name a concrete project member as well. 20120528 21:44:07< Ivanovic> the_new_lipk: new files belong to the creator 20120528 21:44:12< Ivanovic> just add the normal license header and your name 20120528 21:44:29< the_new_lipk> ok 20120528 21:57:15-!- worduk__ [~jon@77.76.205.90] has joined #wesnoth-dev 20120528 21:59:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120528 22:04:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 22:05:20-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 265 seconds] 20120528 22:05:42-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120528 22:08:25< mordante> boucman, I'm around now 20120528 22:09:08< boucman> mordante: the_new_lipk has submitted a huge patch, I did a first proofreading, but I'd gladly have a second one, and it uses gui2, do you have time to have a look at it ? 20120528 22:09:15< mordante> the_new_lipk, for new files copy the copyright from boilerplate.hpp and update the username and email address 20120528 22:09:55-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120528 22:12:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120528 22:14:10< mordante> the_new_lipk, I'm glimpsing over your patch and it can really use more comment 20120528 22:14:50< mordante> the_new_lipk, also for the gui2 stuff please use the wiki comment, it's used to generate the wiki documentation and the validation scheme's 20120528 22:16:19< the_new_lipk> errr... I think I've added wiki comment for the gui2 things 20120528 22:16:47-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120528 22:17:08< mordante> the_new_lipk, not for the wanted widget and what they do 20120528 22:17:48< mordante> for example /src/wesnoth/src/gui/dialogs/title_screen.cpp has a list of widgets 20120528 22:19:14< the_new_lipk> oh, I see now. I'll add the comments. 20120528 22:19:23< mordante> thanks 20120528 22:20:04< boucman> the_new_lipk: I said that earlier, but the bigger the patch the longer it takes to get in, so don't worry if it takes a little time... we are doing our best :) 20120528 22:20:32< mordante> it's indeed quite big 20120528 22:21:29< mordante> I think it also would allow for a changelog entry ;-) 20120528 22:22:29< mordante> and if you're not yet in about.cfg an entry there would also be nice 20120528 22:23:01< mordante> it's rather late here and I won't have time to review it tonight 20120528 22:23:03< shadowm> And if you get it accepted you should notify me so you can be added to the Code & WML Contributors group in the forums. 20120528 22:23:32< mordante> I'll be quite busy this week so not sure whether I have time to look at the patch (I fear not) 20120528 22:23:54< mordante> but I like to review it later 20120528 22:24:08< mordante> boucman, the_new_lipk has the patch been tested? 20120528 22:24:38< boucman> not yet afaik, i'll do it next 20120528 22:24:44< Necrosporus> shadowm, do you know about art contribution? 20120528 22:24:58< shadowm> Necrosporus: Depends on what you need to know about it 20120528 22:25:01< Necrosporus> What do the artist need to know to contribute char image 20120528 22:25:08< the_new_lipk> mordante: ok, just question now: what does & m & or & o& mean in the wiki comments 20120528 22:25:16< the_new_lipk> *quick question 20120528 22:25:22< the_new_lipk> ? 20120528 22:25:23< Necrosporus> http://storage3.static.itmages.ru/i/12/0528/h_1338232619_7441835_d6c5f11c0c.png http://storage3.static.itmages.ru/i/12/0528/h_1338232250_9486764_5c139d4264.png 20120528 22:25:46< shadowm> Necrosporus: Dependso n whether you are targetting mainline, or a user-made add-on. 20120528 22:25:48< Necrosporus> shadowm, does for example this pics qualify as unit portrait? 20120528 22:25:54< shadowm> No 20120528 22:25:56< Necrosporus> add-on 20120528 22:26:08< Necrosporus> Era of Magic 20120528 22:26:10< shadowm> Our technical requirements are described in here: http://forums.wesnoth.org/viewtopic.php?f=9&t=24555 20120528 22:26:12< Necrosporus> Quite popular 20120528 22:26:25< shadowm> If you want to contribute to an add-on, you'll need to get in touch with its author or maintainer instead 20120528 22:26:43< shadowm> Add-on maintainers don't have the same strict quality requirements as mainline, generally speaking 20120528 22:27:16< mordante> the_new_lipk, http://wiki.wesnoth.org/Wiki_grabber 20120528 22:27:18< shadowm> But for portraits, transparency is mandatory in any situation. 20120528 22:27:37< Necrosporus> shadowm, there's transparency in second pic 20120528 22:27:53< the_new_lipk> mordante: thanks 20120528 22:27:58< shadowm> Right, but it's facing left rather than right. 20120528 22:29:19< boucman> fendrin: author just replied to https://gna.org/patch/?3252 20120528 22:29:33< boucman> do we close the patch or is the fix you asked trivial enough ? 20120528 22:30:12< Necrosporus> shadowm, well, it's one second to mirror an pic 20120528 22:30:14-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Read error: Connection reset by peer] 20120528 22:31:29-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Quit: ZNC - http://znc.sourceforge.net] 20120528 22:31:32< mordante> I'm off bye 20120528 22:32:40-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20120528 22:35:14< Necrosporus> shadowm, why black background instead of transparent again? 20120528 22:36:03< shadowm> The primary portrait is supposed to be transparent. The secondary portrait is used only in the Help window for unit info pages. 20120528 22:36:56< shadowm> The format difference is due to technical limitations I wasn't allowed to lift at the time for some reason. 20120528 22:37:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120528 22:38:39-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev 20120528 22:40:54-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection] 20120528 22:55:17< Necrosporus> http://storage2.static.itmages.ru/i/12/0529/h_1338238293_6577812_b386ff296b.png 20120528 22:55:24< Necrosporus> shadowm, better? 20120528 22:55:36< Necrosporus> http://storage7.static.itmages.ru/i/12/0529/h_1338238214_8373155_a83d912701.png 20120528 22:55:40< Necrosporus> + this 20120528 22:56:30< shadowm> Yeah. 20120528 22:58:23-!- bloodycoin_m [~bloodycoi@2002:c1aa:8513:a:f02d:ceba:4bb6:1f43] has quit [Ping timeout: 245 seconds] 20120528 22:58:29-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120528 23:03:24-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye] 20120528 23:06:19-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer] 20120528 23:06:49-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 23:08:22-!- Ceres [6d6d0707@gateway/web/freenode/ip.109.109.7.7] has joined #wesnoth-dev 20120528 23:26:42-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 23:27:18-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 23:30:20-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has joined #wesnoth-dev 20120528 23:32:15-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Remote host closed the connection] 20120528 23:38:37-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 244 seconds] 20120528 23:40:26-!- negusnyul [~negusnyul@dsl4E5CD84C.pool.t-online.hu] has quit [Quit: Konversation terminated!] 20120528 23:47:11-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has quit [Quit: Leaving.] 20120528 23:47:32-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev 20120528 23:47:51-!- _vdn [~nazgul-sa@ppp91-77-239-123.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120528 23:50:37-!- bloodyco_ [~bloodycoi@193.170.135.78] has joined #wesnoth-dev 20120528 23:52:25-!- light_mage [~chatzilla@14.98.101.244] has quit [Ping timeout: 252 seconds] --- Log closed Tue May 29 00:00:24 2012