--- Log opened Fri Jun 01 00:00:32 2012 20120601 00:03:51-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120601 00:09:12-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20120601 00:18:43-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20120601 00:23:13-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120601 00:23:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 00:33:17-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has joined #wesnoth-dev 20120601 00:39:33-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has quit [Quit: Leaving] 20120601 00:45:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 00:48:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20120601 00:49:32-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye] 20120601 01:00:27-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 01:01:17-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 01:07:34-!- fabi [~fabi@88-134-11-228-dynip.superkabel.de] has joined #wesnoth-dev 20120601 01:07:34-!- fabi [~fabi@88-134-11-228-dynip.superkabel.de] has quit [Changing host] 20120601 01:07:34-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120601 01:16:18-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20120601 01:32:23-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze] 20120601 01:33:15-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has joined #wesnoth-dev 20120601 01:33:15-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has quit [Changing host] 20120601 01:33:15-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120601 01:33:45-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20120601 01:46:04-!- happygrue [~quassel@wesnoth/developer/wintermute] has quit [Read error: Connection reset by peer] 20120601 01:47:19-!- happygrue [~quassel@wesnoth/developer/wintermute] has joined #wesnoth-dev 20120601 01:50:35-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120601 01:54:52-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 01:55:22-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 02:04:08-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20120601 02:09:54-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has joined #wesnoth-dev 20120601 02:09:54-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has quit [Changing host] 20120601 02:09:54-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120601 02:12:33-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 02:13:19-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 02:21:00-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20120601 02:33:23-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 02:33:53-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 02:35:35-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has joined #wesnoth-dev 20120601 02:35:35-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has quit [Changing host] 20120601 02:35:35-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120601 02:37:55-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.] 20120601 02:38:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 02:49:37-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 02:50:12-!- wesbot [~wesbot@asteria.debian.or.at] has quit [Ping timeout: 252 seconds] 20120601 02:50:51-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 02:52:25-!- mjs-de [~mjs-de@d119158.adsl.hansenet.de] has quit [Remote host closed the connection] 20120601 03:01:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 03:05:48-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120601 03:13:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120601 03:25:42-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev 20120601 03:31:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 03:38:37-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 03:39:18-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 03:41:11-!- leonid [~leonid@124.65.134.54] has joined #wesnoth-dev 20120601 03:47:57-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120601 03:56:22-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 03:57:06-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 04:12:14-!- vultraz_laptop [~chatzilla@124.109.10.221] has quit [Read error: Connection reset by peer] 20120601 04:12:44-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 04:12:54-!- vultraz_laptop [~chatzilla@124.109.10.221] has joined #wesnoth-dev 20120601 04:16:30-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20120601 04:20:37-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Ping timeout: 248 seconds] 20120601 04:23:49-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 265 seconds] 20120601 04:24:29-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has joined #wesnoth-dev 20120601 04:24:29-!- fabi_ [~fabi@88-134-11-228-dynip.superkabel.de] has quit [Changing host] 20120601 04:24:29-!- fabi_ [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120601 04:30:46-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120601 04:42:31-!- Ivanovic_ [~ivanovic@dtmd-4d052799.pool.mediaWays.net] has joined #wesnoth-dev 20120601 04:46:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20120601 04:46:26-!- Ivanovic_ is now known as Ivanovic 20120601 04:48:07-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Remote host closed the connection] 20120601 05:20:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 05:22:56-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has joined #wesnoth-dev 20120601 05:27:11-!- jamit [~james@pool-173-61-156-210.cmdnnj.east.verizon.net] has quit [Quit: Leaving.] 20120601 05:32:51-!- s951 [~s951@dyn1064-132.hor.ic.ac.uk] has quit [Remote host closed the connection] 20120601 05:51:23-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house] 20120601 05:57:45-!- ancestral [~ancestral@97-127-66-8.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120601 06:18:22-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 06:23:18-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 06:26:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120601 06:46:15-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 256 seconds] 20120601 06:51:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20120601 07:13:50-!- Ivanovic [~ivanovic@dtmd-4d052799.pool.mediaWays.net] has quit [Changing host] 20120601 07:13:50-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120601 07:19:49-!- Ravi325 [~chatzilla@182.156.99.147] has joined #wesnoth-dev 20120601 07:23:08< Ravi325> I have found that this game eats a lot of CPU. Will it be fixed in v1.10.4? 20120601 07:24:31< Ravi325> ??] 20120601 07:30:36< Espreon> Hmmm... 20120601 07:31:00< Espreon> Ravi325: And when does this typically happen? 20120601 07:31:42< Ravi325> usually it happens when loading and playing game 20120601 07:32:41< Espreon> Hmmmmmm... no idea. 20120601 07:33:13< Espreon> I'd advise you to perhaps ask about it here when it's day in Europe. 20120601 07:40:16< Ravi325> Here is day...... man. ok I have to go. thanks anyway 20120601 07:41:10-!- Ravi325 [~chatzilla@182.156.99.147] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 12.0/20120420145725]] 20120601 07:48:28-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120601 07:51:41-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120601 07:58:13< Ivanovic> Espreon: don't just request "day" in europe but better evening hours 20120601 07:58:24< Ivanovic> since most people in here tend to work these days and not have irc access during work 20120601 07:58:45< Ivanovic> so something like 6pm european time is better than "daytime" 20120601 07:59:19< Ivanovic> and yeah, i am heading off to work now, so cu 20120601 08:00:54-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 248 seconds] 20120601 08:02:41-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120601 08:15:46-!- worduk [~jon@77.76.205.90] has quit [Read error: Connection timed out] 20120601 08:16:21-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120601 08:31:40-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120601 08:54:32-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev 20120601 08:59:35-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20120601 08:59:58-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20120601 08:59:58-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev 20120601 09:29:18-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20120601 09:42:09-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20120601 09:46:48-!- _vdn [~nazgul-sa@ppp91-77-250-77.pppoe.mtu-net.ru] has joined #wesnoth-dev 20120601 09:47:33-!- _vdn [~nazgul-sa@ppp91-77-250-77.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer] 20120601 10:11:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120601 10:28:26-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120601 10:33:20-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 10:50:25-!- fabi_ [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20120601 10:56:20-!- crab_ [~Crab_@wesnoth/developer/crab] has quit [Ping timeout: 244 seconds] 20120601 10:56:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20120601 10:57:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120601 11:32:20-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120601 11:51:00-!- edb [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev 20120601 11:52:01-!- edb [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Client Quit] 20120601 11:52:20-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev 20120601 11:57:28-!- vcap_ [~vcap@AReims-551-1-54-219.w86-192.abo.wanadoo.fr] has joined #wesnoth-dev 20120601 11:58:57-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120601 12:00:28-!- vcap [~vcap@AReims-551-1-188-16.w81-250.abo.wanadoo.fr] has quit [Ping timeout: 245 seconds] 20120601 12:05:04-!- MeccaGod [majs@host189-199.bornet.net] has joined #wesnoth-dev 20120601 12:17:57-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120601 12:31:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 12:31:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 12:40:08-!- mjs-de [~mjs-de@d190166.adsl.hansenet.de] has joined #wesnoth-dev 20120601 12:44:39-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer] 20120601 12:52:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 12:57:11-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev 20120601 13:00:11-!- loonybot [~loonybot@46.138.74.45] has joined #wesnoth-dev 20120601 13:00:11-!- loonybot [~loonybot@46.138.74.45] has quit [Changing host] 20120601 13:00:11-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120601 13:01:22-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 244 seconds] 20120601 13:08:33-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 20120601 13:16:12-!- Crab_ [Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20120601 13:19:16-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 13:33:53-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120601 13:49:19-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 245 seconds] 20120601 13:50:27-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120601 13:59:54< Nephro> How do I work with launch arguments in wesnoth? I need to add one, to be precise 20120601 14:02:03-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev 20120601 14:06:53< Crab_> Nephro: it was refactored in 2011, so it's really easy now. it uses program options from boost 20120601 14:07:15< Crab_> Nephro: find a command-line argument which resembles what you want to do in behavior (i.e. a boolean switch), then trace how it's called. 20120601 14:07:43< Crab_> Nephro: afair, the argument itself is defined in 1 place, then it's used in another place to set some C++ global variable 20120601 14:08:05< Crab_> Ayne: hello 20120601 14:08:11< Nephro> I'm currently investigating a filename called commandline_options.cpp 20120601 14:08:12< Ayne> hello 20120601 14:08:24< Crab_> Ayne: how it's going? any questions so far? 20120601 14:09:57< Ayne> I've moved the gold calculations and storing the recall lists after a scenario to playcampaign and it seems to be working. Would you mind taking a look at some point to see if I missed anything? 20120601 14:11:41< Crab_> definitely. you can send patches to patches.wesnoth.org or use email/forum PM. 20120601 14:12:23< Crab_> if it's working and clean, I think it would make sense to gradually start committing it to trunk, to avoid doing a large amount of work later 20120601 14:12:57< Akihara> hi Crab_ :) fine? do you have any news concerning my patch? :P 20120601 14:13:16< Ayne> Which way would you prefer? 20120601 14:13:20< Crab_> hi, Akihara :) no, lazy me :)) 20120601 14:13:34< Crab_> Ayne: email 20120601 14:14:25< Akihara> Crab_: okay :P just say it if there is a problem or something like that ;) 20120601 14:15:11-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120601 14:15:56< Ayne> It gives me the correct results with my test campaign at least. I'd like you to have a look at it and tell me if it's ok, then I'll commit it. I'm a bit worried that I might have missed something or broken some coding rules that I didn't realize existed since I discovered a few things they didn't mention when I was learning C++ back at uni over the last couple days 20120601 14:16:48< Crab_> Akihara: no, no problems yet :) 20120601 14:17:28< Crab_> Ayne: ok, send it, then, when you'll want me to take a look at it. 20120601 14:17:49< Ayne> as a patch file? 20120601 14:18:13< Akihara> Crab_: I cant wait to know your opinion concerning it ;) I hope you will test it soon ! 20120601 14:18:29< Crab_> I will 20120601 14:21:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120601 14:25:11-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!] 20120601 14:29:55< Nephro> Crab_, are there some hidden automacromagical steps that boost::program_options does? 20120601 14:31:46< Nephro> since there is a file game_config.* which contains the namespace via which the debug mode bool is accessed, and there is a commandline_options.* file, which register a bool called debug inside it 20120601 14:32:28< Nephro> argh, and it seems to cause full recompilation. Lucky me 20120601 14:32:54< Crab_> no hidden steps. but it's possible that the dependencies are somewhat messed up :) 20120601 14:37:58< Crab_> Ayne: looking... 20120601 14:38:31-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev 20120601 14:38:42-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has quit [Changing host] 20120601 14:38:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120601 14:49:25< boucman> hey all 20120601 14:49:35< boucman> bloodycoin_m: i'm around all day if you need to discuss something 20120601 14:49:41< Crab_> hi, boucman 20120601 14:49:58< boucman> Crab_: did you have time to clean up some patches o:-) 20120601 14:50:05< Crab_> no ) 20120601 14:54:57< boucman> :o) 20120601 14:55:09-!- negusnyul [~negusnyul@91EC4589.dsl.pool.telekom.hu] has joined #wesnoth-dev 20120601 14:57:16< CIA-61> nephro * r54354 /trunk/ (8 files in 4 dirs): LuaAI: (1) Lua CA_wrapper slightly refactored, in preparation for adding CA definitons using external files (2) --debug_lua command line argument added. Unused at the moment, but will be used for Lua debug mechanisms 20120601 14:57:54< Crab_> Nephro: is underscore (_) already used in wesnoth's arguments? 20120601 14:58:11< Crab_> Nephro: i.e, what's more frequent, style like --debug-lua or --debug_lua ? 20120601 14:58:36< Nephro> that I did not think of. Will fix 20120601 14:58:46< Crab_> Nephro: just check what's used more 20120601 14:58:54< Nephro> - is 20120601 14:58:56< Crab_> ok 20120601 14:59:11< Crab_> Ayne: ok, I've read the patch. I have some small comments, but those are not that important at the moment. But I have some larger comments, as well :) 20120601 14:59:16< Nephro> underscores aren't used at all tbh 20120601 14:59:36< Ayne> Crab_: I'm listening 20120601 15:01:02< Crab_> first of all, you should avoid adding more 'global' state (such as static std::vector carryover_sides ) - add it as a new variable that you'll pass around. then you won't have to clear it, it simply would live as long as you need it, but no longer. 20120601 15:01:13< Crab_> next, when you're fixing the config for the new level, it' 20120601 15:01:47< Crab_> it's better to operate on result passed to function as a pointer to config or as a reference to config, instead of copying the input and passing it out 20120601 15:02:17< Crab_> imagine that you'll have functions like 'team_gold', 'team_recalls', .... - if each of them would take the previous config and return a new one, you'll copy the level several times 20120601 15:02:37< Ayne> I was trying that, but pointers and reference gave me compiler errors 20120601 15:02:41< Ayne> but I can try again 20120601 15:03:25< Crab_> while, you should be using something like config init_level = level; // copy is done here init_gold(init_level, carryover_info); init_recalls(init_level, carryover_info); 20120601 15:04:14< Crab_> also note that both config init_level = config(level); and config init_level = level; are almost the same, and result in a copy being made. 20120601 15:04:20< Crab_> and, the most important point 20120601 15:05:21< Ayne> yes, I was copying on purpose, as level is const and I couldn't change it 20120601 15:05:40< Crab_> yes, copying is ok, I just pointed out that it's possible to copy without invoking the constructor explicitly 20120601 15:05:46< Ayne> ok 20120601 15:05:52< Crab_> also, I wanted you to avoid multiple copies here 20120601 15:06:19< Crab_> i.e. return init_level; is also a copy (unless a compiler is smart enough to optimize it) 20120601 15:06:38< Crab_> but, back to important stuff - in calculate_gold, you change gamestate.snapshot - why ? 20120601 15:07:05< Nephro> @ALL: if you want to avoid double full recompilation wait 5 minutes 20120601 15:09:27< Ayne> Crab_: You mean the side iterator? 20120601 15:09:40< Crab_> config &new_side = gamestate.snapshot.add_child("side"); 20120601 15:10:32< Ayne> That was the original code from playsingle_controller, I mostly just moved it to playcampaign and added the new class 20120601 15:11:07< Crab_> note the problem here: carryover information is stored 2 times, in slightly different formats 20120601 15:11:20< Crab_> firstly, you store it in carryover_sides 20120601 15:11:26< Crab_> secondly, you store it in gamestate.snapshot 20120601 15:12:02< Crab_> I think that's it's better to use only 1 source for the information 20120601 15:13:09< Crab_> you can do it by adding recall list to carryover, and adding another class 'carryover_info' to contain vector and end_level_data 20120601 15:13:48< Crab_> then, you can make sure that you collect everything from playcontroller to carryover_info (without changing the snapshot) 20120601 15:14:09< Crab_> then, you can do init_recalls to put it back in new level config 20120601 15:14:37-!- stikonas [~gentoo@bcm-131-111-216-103.girton.cam.ac.uk] has joined #wesnoth-dev 20120601 15:14:37-!- stikonas [~gentoo@bcm-131-111-216-103.girton.cam.ac.uk] has quit [Changing host] 20120601 15:14:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120601 15:15:18< Crab_> that way we'll have a clear transfer of info : old_playcontroller => carryover_info; .... carryover_info + new_level => init_level => new_playcontroller 20120601 15:15:35< Crab_> while current approach passes some information through game_state as well. 20120601 15:16:12< Ayne> so you suggest not storing these things in the snapshot then? I guess we were going to drop the snapshot for the end of scenario save anyway, so we don't need to update it anymore at that point, right? 20120601 15:16:20< Crab_> yes, like this 20120601 15:16:28< Ayne> ok 20120601 15:16:33< CIA-61> nephro * r54355 /trunk/src/ (commandline_options.cpp commandline_options.hpp): LuaAI: fixed naming misconsistency 20120601 15:16:35< Crab_> with this approach, eventually, the game_state would become local to play_controller 20120601 15:17:22< Crab_> i.e. if we explicitly carry over all stuff via carryover_info, we'll no longer need game_state outside of play_controller 20120601 15:17:38< Crab_> note the catch : 20120601 15:17:55< Crab_> if we have 3 scenarios, scenario 1 and scenario 3 has side with 'side_id' of 'FOO' 20120601 15:18:02< Crab_> scenario 2 has no such side 20120601 15:18:26< Crab_> yet, side FOO should be stored somewhere till scenario 3 20120601 15:18:31< Crab_> this was the original purpose of game_state 20120601 15:18:51< Crab_> yet, gradually, it failed, because game_state now contains a lot of stuff from *within* the game 20120601 15:20:34< Crab_> so, to untangle it now, I'd just make a new class just for the carryover info. 20120601 15:21:20< Crab_> it can be just a 'config', or it can be more structured. 20120601 15:21:39< Crab_> Ayne: btw, please note that + carryover_sides.push_back(*(new carryover(new_side))); is bad 20120601 15:22:22< Crab_> when you're using new, you're allocating a new object on the heap. this is safe only when you have a corresponding delete, or if the object is supposed to live for the entire lifetime of the program 20120601 15:22:52< Crab_> you can do carryover_sides.push_back(carryover(new_side)); , which would result in a copy 20120601 15:23:08< Crab_> or, you can make carryover_sides to be a vector of smart pointers (boost::shared_ptr) 20120601 15:23:09< Ayne> I checked, clear calls the destructor of all elements in the vector, so I assumed it would be ok. If we change it so we don't use clear I'll obviously have to change that as well though 20120601 15:23:28< Crab_> you call destructor, but you don't call delete 20120601 15:23:42< Crab_> delete both calls the destructor and gives the memory back 20120601 15:23:47< Crab_> clear only calls the destructor 20120601 15:24:11< Ayne> hm ok. I'll change it 20120601 15:24:16< Crab_> alternatively, you can make carryover_info just a 'config' 20120601 15:24:33-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 252 seconds] 20120601 15:24:53< Crab_> in that case, you'll just have a big config for all the carryover information, saving you from the trouble of saving/loading it (since you'll need to write carryover_info to start-of-scenario save) 20120601 15:25:17< Crab_> (in any case, you need a way to get carryover_info from config, and to save it to config) 20120601 15:25:51< Crab_> also, please, just as a matter of coding style, always use {} with if 20120601 15:26:28< Ayne> i usually do that. where did I forget it? 20120601 15:27:17< Crab_> probably in the code which you've copied, it has some one-liners like if (!t.persistent()) continue; 20120601 15:27:44< Crab_> the main advantage of having multi-line if's with {} is ease of reading and ease of debugging (when you step, you see if you will hit 'continue' or not) 20120601 15:28:08< Ayne> oh yeah, i'll change those when i come across them in the future 20120601 15:28:25< Crab_> also, looking at current approach, overall it looks good. 20120601 15:28:56< Ayne> ok, thank you 20120601 15:29:07< Crab_> when you'll add carryover_info (or whatever name you'll pick for the class/variable containing carryover for all teams) , you can store it in game_state. 20120601 15:29:08< Ayne> I will change the things you mentioned, give it another test run and then commit it 20120601 15:29:46< Crab_> Ok. or show it to me beforehand, if you'll have other questions. the main question to ask the code is 'does this belong here, according to our plan?' 20120601 15:30:50< Crab_> for example, see team_gold function 20120601 15:31:15< Crab_> it's purpose is to init the new level according to carry-over data. 20120601 15:31:48< Crab_> but, it writes stuff like side_cfg["gold_add"] = side.get_add(); to level config 20120601 15:32:16< Crab_> why? if it's supposed to set the side gold to correct value, who will ever need gold_add in the side config of level ? 20120601 15:33:12< Crab_> so, we can just write the gold value and not write any gold_add values (because we are responsible for using gold_add, and we should delete it afterwards from scenario config if it was there.) 20120601 15:33:40< Crab_> also, imagine we have 3 scenarios, and side BAR is present in scenarios 1,2,3 20120601 15:33:56< Crab_> when scenario 1 ends, BAR's gold is written to carryover. 20120601 15:34:11< Crab_> when scenario 2 starts, we use BAR's gold to set the gold for it in scenario 2. 20120601 15:34:27< Crab_> but, this means that we should delete this gold from carryover info 20120601 15:35:05-!- leonid [~leonid@124.65.134.54] has quit [Remote host closed the connection] 20120601 15:35:09< Crab_> i.e. we had 1200 gold in carryover and 100 gold in new side 20120601 15:35:28< Crab_> we should leave the team_gold function with 0 gold in carryover and 1300 gold in new side 20120601 15:35:56< Crab_> same with recalls - all recalls, if we store them in carryover, should be 'moved' to corresponding side if the side exists (or should be left waiting in carryover) 20120601 15:36:11< Ayne> so clear the data in carryover once we've initialized the new scenario? 20120601 15:36:17< Crab_> no 20120601 15:36:22< Crab_> move used data 20120601 15:36:45< Crab_> if there was a side FOO which was not used in scenario 2, but used in 1 and 3, then it would just sit in carryover during scenario 2, waiting 20120601 15:37:43< Ayne> sorry, that's what i meant. every time i initialize a side in the new scenario i then clear the data from the carryover for that side 20120601 15:37:43< Crab_> Imagine, for example, that later we'll allow scenario editors to say 'for side FOO, only allow undead recalls in this scenario, but keep the other recalls for future scenario' 20120601 15:37:55< Crab_> no, only clear what was 'used' 20120601 15:38:01< Ayne> yes 20120601 15:38:25< Crab_> i.e. if side had skeleton, skeleton, pikeman as recruits, we might want to move 2 skeleton's to scenario recall list, while leaving the pikeman in carryover 20120601 15:38:43< Crab_> or, if side has 100000 gold, we might want to move 10000 to the scenario, leaving 90000 'in the bank' 20120601 15:39:08< Ayne> ok 20120601 15:39:12< Crab_> basically, use the 'bank' analogy - carryover info is what the side has 'in the bank' 20120601 15:39:29< Crab_> if we withdraw something - then we should move it 20120601 15:39:42< Crab_> since it'll no longer be 'in the bank' , but would be with the side 20120601 15:43:49< Crab_> and, we prohib 20120601 15:47:02< Ayne> ok, I will be away for a moment, I have to cook, and after that I will start fixing the things you mentioned 20120601 15:53:43-!- ToBeFree [~tobefree@dslb-084-060-178-185.pools.arcor-ip.net] has joined #wesnoth-dev 20120601 15:53:45-!- ToBeFree [~tobefree@dslb-084-060-178-185.pools.arcor-ip.net] has quit [Changing host] 20120601 15:53:45-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev 20120601 15:58:12-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20120601 16:02:24-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 246 seconds] 20120601 16:07:00-!- mattsc [~mattsc@24.108.134.22] has joined #wesnoth-dev 20120601 16:07:12-!- mattsc [~mattsc@24.108.134.22] has left #wesnoth-dev [] 20120601 16:10:38< Crab_> Ayne: ok. it seems that my last msg was cut off, so repeating: "and, we prohibit any modifications 'to the bank' from within the game, and we prohibit any modifications of game state from outside the game, and we have two places where we move things from game to bank" 20120601 16:10:58< Crab_> .. and from bank to game. game to bank : places like calculate_gold and store_recalls 20120601 16:11:05< Crab_> bank to game: places like init_gold 20120601 16:11:45-!- mattsc [~mattsc@24.108.134.22] has joined #wesnoth-dev 20120601 16:12:13< Crab_> all saves will include 'the bank' (which might only contain stuff like 'next scenario' at the beginning) 20120601 16:14:09-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 16:15:32-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120601 16:58:06-!- Ingeniumed [u5855@gateway/web/irccloud.com/x-hzjaguskdjdxcnqx] has joined #wesnoth-dev 20120601 17:12:35-!- horon [~horon@nttkyo216070.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120601 17:27:02-!- mattsc [~mattsc@24.108.134.22] has quit [Quit: I'm asleep] 20120601 17:28:09-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has quit [Quit: Leaving] 20120601 17:32:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 17:33:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20120601 17:45:01-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 244 seconds] 20120601 17:56:33-!- iwaim__ [~iwaim@gateway.alib.jp] has quit [Quit: Tiarra 0.1+svn-38663: SIGTERM received; exit] 20120601 17:58:23-!- iwaim [~iwaim@gateway.alib.jp] has joined #wesnoth-dev 20120601 18:01:27-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 18:10:17-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Quit: Computer has gone to sleep.] 20120601 18:11:05-!- vultraz_laptop_ [~chatzilla@124.109.10.221] has joined #wesnoth-dev 20120601 18:12:00-!- vultraz_laptop [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds] 20120601 18:12:09-!- vultraz_laptop_ is now known as vultraz_laptop 20120601 18:15:33-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20120601 18:24:24-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 256 seconds] 20120601 18:27:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 18:39:01-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120601 18:41:56-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Read error: Connection reset by peer] 20120601 18:45:53-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20120601 18:55:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20120601 18:55:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120601 19:09:11-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Read error: No route to host] 20120601 19:18:25-!- trademark_ [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120601 19:21:38-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 240 seconds] 20120601 19:22:49-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120601 19:45:03-!- bloodycoin_m [~bloodycoi@193.170.135.78] has quit [Ping timeout: 245 seconds] 20120601 19:47:30-!- negusnyul_ [~negusnyul@dsl4E5CD224.pool.t-online.hu] has joined #wesnoth-dev 20120601 19:50:34-!- negusnyul [~negusnyul@91EC4589.dsl.pool.telekom.hu] has quit [Ping timeout: 245 seconds] 20120601 19:52:57-!- negusnyul_ [~negusnyul@dsl4E5CD224.pool.t-online.hu] has quit [Ping timeout: 252 seconds] 20120601 19:53:03-!- negusnyul__ [~negusnyul@dsl51B65D37.pool.t-online.hu] has joined #wesnoth-dev 20120601 19:54:03< Ivanovic> hi 20120601 20:07:59< vultraz_laptop> hi 20120601 20:27:10-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20120601 20:47:35-!- ancestral [~ancestral@50-78-227-230-static.hfc.comcastbusiness.net] has joined #wesnoth-dev 20120601 20:49:47-!- neXyon [~neXyon@84-119-56-54.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120601 20:51:09< Necrosporus> There is no animations for the Fire Dragon at all. Maybe there's a reason? 20120601 20:51:17< Necrosporus> Or just no artist? 20120601 20:56:26< the_new_lipk> what else could be the reason? :P 20120601 20:56:28-!- ancestral [~ancestral@50-78-227-230-static.hfc.comcastbusiness.net] has quit [Quit: i go sleeps kthxbai] 20120601 21:00:23< boucman> Necrosporus: there has been multiple attempts to animate the dragon, but all failed so far... 20120601 21:00:27< boucman> it's very hard 20120601 21:00:51< Necrosporus> Why? because of multitile? 20120601 21:01:44< boucman> that 20120601 21:01:47< boucman> and it's huge 20120601 21:01:57< boucman> and it's hard to make it look good in the middle of other units 20120601 21:02:15< boucman> and there are no animtion to copy, so only some one with a huge experience at spriting can do it 20120601 21:04:24< Necrosporus> http://storage3.static.itmages.ru/i/12/0531/h_1338478729_1959478_978fb87747.png 20120601 21:04:39< Necrosporus> There's a dragon-like saurus 20120601 21:05:06-!- ancestral [~ancestral@17.232.7.176] has joined #wesnoth-dev 20120601 21:05:08< Necrosporus> Maybe the dragon should be reduced back to one tile, but remain dragon like? 20120601 21:05:15-!- ancestral [~ancestral@17.232.7.176] has quit [Client Quit] 20120601 21:05:41< Espreon> No... 20120601 21:05:42< boucman> wouldn't look impressive enough, it has the size of a horse in wesnoth 20120601 21:06:34< Necrosporus> But this Shessinsaan must be six meters long. I have asked, should it be multitile, and the answer was "no" 20120601 21:11:01< the_new_lipk> there isn't really a formula how to convert "real life" sizes to sprite sizes 20120601 21:11:37< the_new_lipk> if you want to make a goddamn scary unique supermonster, you make it multihex. Otherwise, not. 20120601 21:18:39< Necrosporus> I wonder, why does the dragon have "leadership" 20120601 21:19:32< Necrosporus> Does it inspire other people in form like "ah, a dragon fight for our size, we will win!" or what? 20120601 21:21:23< Necrosporus> * side 20120601 21:26:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20120601 21:26:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120601 21:31:15< the_new_lipk> Do I recall correctly that there's a way to display a message with the image on the right side??? 20120601 21:33:28-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120601 21:35:13< mattsc> the_new_lipk: yes, use '~FL()~RIGHT()' 20120601 21:35:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 21:35:32< the_new_lipk> oh, thankies 20120601 21:39:23< the_new_lipk> hmmm... this ~right function doesn't appear anywhere in the wiki 20120601 21:45:22< mattsc> the_new_lipk: http://wiki.wesnoth.org/UnitTypeWML (look under 'profile') 20120601 21:48:58< the_new_lipk> Ahhh. Not a really intuitive place, though. 20120601 21:49:13-!- Nephro [~Dmitry@80.233.231.12] has joined #wesnoth-dev 20120601 21:49:23< the_new_lipk> If there're no objections, I'm going to add this to [message] too. 20120601 21:50:32< mattsc> Sounds good to me 20120601 21:53:12< boucman> go for it 20120601 21:54:28< Nephro> mattsc, hi, have you recompiled the latest trunk? There were some refactorings I hope your scenarios still work 20120601 21:55:14< the_new_lipk> done 20120601 21:56:41< mattsc> Nephro, hi. I have not compiled yet what you did this morning. So far, I'm not using any new fucntions that are post 1.10 in my scenarios. Should I test things anyway? 20120601 21:57:19< Nephro> mattsc, there was nothing new added, I refactored some of the internals of CA's, hopefully didn't screw anything up 20120601 21:57:58< mattsc> Ok, I'll compile and test a few things 20120601 21:58:15-!- MeccaGod [majs@host189-199.bornet.net] has quit [] 20120601 22:23:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120601 22:24:16< mattsc> Nephro: I compiled and had it play the Prune Cart scenario (which is the most complicated AI I have). No problems whatsoever. 20120601 22:24:25< Nephro> mattsc, ok, thanks 20120601 22:24:31< mattsc> and my AI won again. :D 20120601 22:25:23< Nephro> next thing will be the external file(supporting on-the-fly reloading) CA's, so you don't have to move things around too much 20120601 22:25:42< Nephro> and then I think we'll deprecate the need to define the engine 20120601 22:25:43< mattsc> great 20120601 22:28:35< Nephro> but i'm off to sleep today, got a match tomorrows 20120601 22:29:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 22:30:03< mattsc> gn 20120601 22:31:46-!- the_new_lipk [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: Távozom] 20120601 22:36:18-!- enchilado [~enchilado@woenwhoa.com] has quit [Ping timeout: 245 seconds] 20120601 22:36:49-!- CIA-61 [~CIA@cia.atheme.org] has quit [Ping timeout: 244 seconds] 20120601 22:39:39-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Read error: Operation timed out] 20120601 22:40:02< mattsc> Nephro: (if you're still there). I'll be away this weekend and might not have Internet access. I'll check the logs on Monday. 20120601 22:40:28-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has joined #wesnoth-dev 20120601 22:40:56-!- enchilado [~enchilado@woenwhoa.com] has joined #wesnoth-dev 20120601 22:44:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120601 22:47:55-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20120601 22:51:33-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120601 22:54:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20120601 22:56:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120601 22:59:45-!- CIA-88 [~CIA@cia.atheme.org] has joined #wesnoth-dev 20120601 23:12:34-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Operation timed out] 20120601 23:12:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120601 23:13:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20120601 23:25:29-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev 20120601 23:26:30-!- Blueblaze [~Blueblaze@adsl-76-202-17-144.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev 20120601 23:34:38-!- Nephro [~Dmitry@80.233.231.12] has quit [Ping timeout: 240 seconds] 20120601 23:35:43-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 244 seconds] 20120601 23:41:18-!- Appleman1234 [~Appleman1@ppp59-167-222-56.qld.adsl.internode.on.net] has quit [Ping timeout: 245 seconds] 20120601 23:49:55-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Connection reset by peer] --- Log closed Sat Jun 02 00:00:32 2012