--- Log opened Thu Jul 05 00:00:20 2012 20120705 00:11:10< zookeeper> shadowm, anyway, in case it wasn't obvious, i don't mind if the thread is moved back 20120705 00:14:39< Ceres> When I modify a unit's resistances with an object and then remove the object with [store_unit] [clear_variable] [unstore_unit], the object is gone but the resistances don't change back. Is that intentional? 20120705 00:15:51< zookeeper> yes 20120705 00:16:48< zookeeper> try also clearing unit.resistance (assuming you haven't made any direct modifications to it that you want to keep) 20120705 00:17:37< Ceres> Oh, thanks for the hint 20120705 00:18:39< Ceres> It's just because it doesn't work with resistance modifications, but it does work with other objects. But I guess there's a reason for that. 20120705 00:19:20< zookeeper> well, it might work with _some_ objects, sure 20120705 00:20:22-!- mjs-de [~mjs-de@d189063.adsl.hansenet.de] has quit [Remote host closed the connection] 20120705 00:20:45< zookeeper> when you apply for instance a resistance-modifying object, then the game applies the changes to unit.resistance and after that the object itself is essentially unneeded... when you remove it, the game doesn't know that you'd want it to re-calculate the resistances for the unit, unless you clear them 20120705 00:34:20-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev 20120705 00:40:25-!- mattsc [~mattsc@204.174.103.3] has quit [Quit: bye] 20120705 00:46:18-!- Ceres [6d6d0707@gateway/web/freenode/ip.109.109.7.7] has quit [Quit: Page closed] 20120705 00:57:03-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev 20120705 01:08:47-!- neXyon_ [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120705 01:10:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20120705 01:18:26-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer] 20120705 01:23:19-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120705 01:49:51-!- wesbot changed the topic of #wesnoth-dev to: 180 bugs, 338 feature requests, 17 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120705 02:04:19-!- Artemius23 [~Artemius2@139.179.205.93] has joined #wesnoth-dev 20120705 02:07:26-!- Artemius23 [~Artemius2@139.179.205.93] has quit [Client Quit] 20120705 02:07:41-!- Artemius23 [~Artemius2@139.179.205.93] has joined #wesnoth-dev 20120705 02:11:14-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 246 seconds] 20120705 02:12:04-!- Artemius23 [~Artemius2@139.179.205.93] has quit [Ping timeout: 252 seconds] 20120705 02:13:08-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120705 02:24:56-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 02:33:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 02:41:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 02:45:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 02:56:06< CIA-87> alarantalara * r54571 /trunk/ (3 files in 2 dirs): Taking the ring of speed is now optional 20120705 03:00:40-!- Artemius23 [~Artemius2@139.179.205.86] has joined #wesnoth-dev 20120705 03:04:04-!- Artemius23 [~Artemius2@139.179.205.86] has quit [Client Quit] 20120705 03:07:07< CIA-87> alarantalara * r54572 /branches/1.10/ (3 files in 2 dirs): backport r54571: Taking the ring of speed is now optional 20120705 03:10:05-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120705 03:25:56< CIA-87> alarantalara * r54573 /trunk/ (3 files in 2 dirs): Finding the map in scenario 3 now reveals the part of the map outside the cave in scenario 4 20120705 03:31:45< CIA-87> jamit * r54574 /trunk/src/ (pathutils.hpp terrain_filter.hpp): Adding const qualifiers to functions. 20120705 03:37:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 03:43:09< CIA-87> alarantalara * r54575 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg: 20120705 03:43:09< CIA-87> Change a sighted event to an attack event 20120705 03:43:09< CIA-87> This way dialog fires even if Panok starts visible because of map 20120705 03:48:29-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120705 04:00:55< CIA-87> alarantalara * r54576 /trunk/data/campaigns/Under_the_Burning_Suns/ (2 files in 2 dirs): 20120705 04:00:55< CIA-87> Get rid of code adding bottlenecks on harder difficulties 20120705 04:00:55< CIA-87> It makes the scenario easier and slower, not harder 20120705 04:00:55< CIA-87> Also use cave bridges over water to show off a rarely used terrain image in an appropriate place - added some extra dirt to deal with units moving slower as a result 20120705 04:12:17< CIA-87> jamit * r54577 /trunk/src/ (pathutils.cpp pathutils.hpp): More documentation updates, plus more meaningful parameter names and adding a const qualifier. 20120705 04:15:23-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has joined #wesnoth-dev 20120705 04:17:26-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20120705 04:18:09< CIA-87> alarantalara * r54578 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: Give the candidate actions unique names 20120705 04:31:42-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 04:33:07< CIA-87> alarantalara * r54579 /trunk/data/campaigns/Under_the_Burning_Suns/ai/messenger-escort_engine.lua: Make escorts not wander after messenger killed 20120705 04:37:01-!- Ivanovic_ [~ivanovic@dtmd-4db2364a.pool.mediaWays.net] has joined #wesnoth-dev 20120705 04:38:45-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 248 seconds] 20120705 04:40:44-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds] 20120705 04:40:52< CIA-87> alarantalara * r54580 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/02_Across_the_Harsh_Sands.cfg: move variable clear to where it is used 20120705 04:40:55-!- Ivanovic_ is now known as Ivanovic 20120705 04:42:04-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.] 20120705 04:49:46-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Read error: Connection reset by peer] 20120705 04:52:52-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has quit [Quit: bye] 20120705 04:54:46-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 05:01:18-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Read error: Connection reset by peer] 20120705 05:04:58-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 06:00:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 06:03:40-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: Read error: user has frozen to death] 20120705 06:20:44-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Read error: Connection reset by peer] 20120705 06:21:06-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 06:25:35-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 06:31:34-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120705 06:36:38-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120705 06:56:04-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Quit: Leaving.] 20120705 07:06:05-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house] 20120705 07:07:58-!- Ivanovic [~ivanovic@dtmd-4db2364a.pool.mediaWays.net] has quit [Changing host] 20120705 07:07:58-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120705 07:10:17-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120705 07:34:27-!- worduk [~jon@77.76.205.90] has quit [Remote host closed the connection] 20120705 07:47:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 07:51:05-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Ping timeout: 246 seconds] 20120705 07:55:00-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120705 08:10:07-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has joined #wesnoth-dev 20120705 08:27:01-!- mjs-de [~mjs-de@d189063.adsl.hansenet.de] has joined #wesnoth-dev 20120705 08:41:25-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120705 08:46:47-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev 20120705 09:23:29-!- mjs-de [~mjs-de@d189063.adsl.hansenet.de] has quit [Ping timeout: 246 seconds] 20120705 09:28:26-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120705 09:36:20-!- mjs-de [~mjs-de@g224180240.adsl.alicedsl.de] has joined #wesnoth-dev 20120705 09:47:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 09:48:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 09:51:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120705 10:07:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 10:51:06-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 264 seconds] 20120705 11:00:47-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev 20120705 11:00:47-!- Upth is now known as Upthorn 20120705 11:17:47< ancestral> OMG it works in Firefox 20120705 11:18:28-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.] 20120705 11:35:30-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120705 11:51:46-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120705 11:52:39-!- worduk [~jon@77.76.205.90] has quit [Client Quit] 20120705 12:01:26-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120705 12:15:45-!- EdB [~edb@37-8-174-146.coucou-networks.fr] has joined #wesnoth-dev 20120705 12:16:38-!- EdB [~edb@37-8-174-146.coucou-networks.fr] has quit [Client Quit] 20120705 12:17:07-!- worduk [~jon@77.76.205.90] has quit [Remote host closed the connection] 20120705 12:18:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20120705 12:49:01-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120705 13:19:01-!- horon [~horon@nttkyo331099.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120705 13:22:14-!- loonybot [~loonybot@46.138.74.131] has joined #wesnoth-dev 20120705 13:22:14-!- loonybot [~loonybot@46.138.74.131] has quit [Changing host] 20120705 13:22:14-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120705 13:29:02-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev 20120705 13:34:22-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120705 14:26:03-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120705 14:39:42-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Quit: bye] 20120705 15:01:20-!- worduk [~jon@77.76.205.90] has quit [Remote host closed the connection] 20120705 15:01:48-!- worduk [~jon@77.76.205.90] has joined #wesnoth-dev 20120705 15:03:20-!- worduk [~jon@77.76.205.90] has quit [Client Quit] 20120705 15:14:23-!- MeccaGod [majs@host189-199.bornet.net] has joined #wesnoth-dev 20120705 15:43:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120705 15:43:59-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Connection reset by peer] 20120705 15:47:04-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 15:49:54-!- artisticdude_iOS [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Remote host closed the connection] 20120705 16:05:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120705 16:09:30-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev 20120705 16:10:49-!- gabba [d8623925@wesnoth/developer/gabba] has joined #wesnoth-dev 20120705 16:20:10-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev 20120705 16:29:09-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120705 16:39:44< gabba> ejls: I'm around if you need anything 20120705 16:51:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120705 17:07:38-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev 20120705 17:51:45-!- horon [~horon@nttkyo331099.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120705 18:07:45-!- crab_ [~Crab_@wesnoth/developer/crab] has joined #wesnoth-dev 20120705 18:18:21-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev 20120705 18:19:45-!- timotei [~timotei@188.24.2.25] has joined #wesnoth-dev 20120705 18:19:45-!- timotei [~timotei@188.24.2.25] has quit [Changing host] 20120705 18:19:45-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20120705 18:34:13< ejls> gabba: Hey. 20120705 18:34:52< ejls> I renamed highlight_visitor highlighter (since it's not a visitor anymore) 20120705 18:40:22< ejls> gabba: I'm ready to commit the last part of phase 2 (visitor hierarchy refactoring). But I think I changed a behaviour with my last commit, I'm compiling an older version right now to check. 20120705 19:10:02-!- Smar [~smar@freenet/translator/finnish/Smar] has quit [Ping timeout: 245 seconds] 20120705 19:11:22-!- Smar [~smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev 20120705 19:20:16-!- lipkab [~lipk@apn-89-223-152-155.vodafone.hu] has joined #wesnoth-dev 20120705 19:24:05-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has joined #wesnoth-dev 20120705 19:25:03-!- csarmi [csarmi@94-21-114-135.pool.digikabel.hu] has quit [Ping timeout: 244 seconds] 20120705 19:28:27< gabba> sry ejls, was afk for a while 20120705 19:29:58-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20120705 19:30:38< Akihara> mordante: I'm here :) so don't hesitate to ping me! 20120705 19:37:52< gabba> How are things, Akihara? Your project doing well? 20120705 19:41:03< Akihara> gabba: hi gabba! weel, i have a biiiig delay because of university stuff... 20120705 19:41:19< gabba> exams and stuff I guess huh? 20120705 19:41:23< Akihara> yeah 20120705 19:41:33< Akihara> and bad teammates :( 20120705 19:41:58< gabba> I've had those too :/ - I call them "leeches" 20120705 19:42:25< Akihara> so i didn't really sleep for two weeks... :/ 20120705 19:43:01< gabba> Ah so that's why they said that the coffee industry was doing better in France ;) 20120705 19:43:25< Akihara> yeah :P but i prefer tea ;) works better on me 20120705 19:45:48< Akihara> but finally, I have a good semester ( o/) so I can work on my project :) 20120705 19:47:14< gabba> Great, congrats! Make those 6 remaining weeks count :) . 20120705 19:47:25< Akihara> yes, i will! 20120705 19:49:51-!- wesbot changed the topic of #wesnoth-dev to: 181 bugs, 338 feature requests, 17 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120705 19:53:53-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev 20120705 19:53:53-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host] 20120705 19:53:53-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev 20120705 19:54:08< mordante> servus 20120705 19:54:21< lipkab> hi mordante 20120705 19:54:30< mordante> hi lipkab 20120705 20:00:57-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120705 20:03:27-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120705 20:28:44< CIA-87> ejls * r54581 /trunk/ (23 files in 4 dirs): Refactoring of the whiteboard highlighter and removal of wb::enable_visit_all. 20120705 20:29:04-!- stikonas [~gentoo@dynamic16.vpdn.csx.cam.ac.uk] has joined #wesnoth-dev 20120705 20:29:04-!- stikonas [~gentoo@dynamic16.vpdn.csx.cam.ac.uk] has quit [Changing host] 20120705 20:29:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120705 20:29:10< ejls> gabba: phase 2 part 2 commited ^ 20120705 20:33:45< CIA-87> mordante * r54582 /trunk/src/config.hpp: 20120705 20:33:45< CIA-87> Change a forward declared type to a struct. 20120705 20:33:45< CIA-87> The issue was spotted by CLang. 20120705 20:33:49< CIA-87> mordante * r54583 /trunk/src/gui/auxiliary/placer.hpp: 20120705 20:33:49< CIA-87> Change a forward declared type to a struct. 20120705 20:33:49< CIA-87> The issue was spotted by CLang. 20120705 20:33:52< CIA-87> mordante * r54584 /trunk/src/gui/widgets/control.hpp: 20120705 20:33:52< CIA-87> Change a forward declared type to a struct. 20120705 20:33:52< CIA-87> The issue was spotted by CLang. 20120705 20:33:55< CIA-87> mordante * r54585 /trunk/src/gui/widgets/helper.hpp: 20120705 20:33:55< CIA-87> Change a forward declared type to a struct. 20120705 20:33:55< CIA-87> The issue was spotted by CLang. 20120705 20:33:58< CIA-87> mordante * r54586 /trunk/src/gui/widgets/pane.hpp: 20120705 20:33:58< CIA-87> Change a forward declared type to a struct. 20120705 20:33:58< CIA-87> The issue was spotted by CLang. 20120705 20:34:00< CIA-87> mordante * r54587 /trunk/src/gui/widgets/viewport.hpp: 20120705 20:34:00< CIA-87> Change a forward declared type to a struct. 20120705 20:34:00< CIA-87> The issue was spotted by CLang. 20120705 20:34:03< CIA-87> mordante * r54588 /trunk/src/gui/widgets/widget.hpp: 20120705 20:34:03< CIA-87> Change a forward declared type to a struct. 20120705 20:34:03< CIA-87> The issue was spotted by CLang. 20120705 20:34:15< mordante> wesbot, seen boucman 20120705 20:34:15< wesbot> mordante: The person with the nick boucman last spoke 22h 29m ago. 20h 37m ago they left with the message: Quit: Leaving. 20120705 20:34:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds] 20120705 20:34:30< gabba> ejls: thanks, will take a look 20120705 20:40:14< gabba> ejls: did you find what was altering the logic? 20120705 20:40:39< gabba> (if indeed it was altered) 20120705 20:44:39< ejls> I was wrong, everything was fine. (I wasn't sure if it was normal that an unit get 42 movement points when planning a multi-turn move) 20120705 20:46:35< gabba> 42 movement points? hmm, it doesn't sound right but I don't have the context 20120705 20:47:22< gabba> I'd rather expect it to have its full movement points, at best - if it's positioned at the start of a turn 20120705 20:47:29< ejls> s/42/more than it's maximum. 20120705 20:48:09< ejls> It's when you plan a move on multiple turn. 20120705 20:49:27< ejls> (let's say a unit has 5 mvt, if you do a 2-turn move with it, its mvt will be 10 so that we can "fakely" move it for two turns) 20120705 20:49:50< gabba> Well normally, let's say you mouseover a unit that has three moves which bring it to the middle of its second turn, it should display the amount of movement it will have left at that point 20120705 20:51:10< ejls> Yes, it's what is displayed in the GUI. 20120705 20:51:44< ejls> But in the log you have lines like : "setting mvt point of unit SANEUTH from 5 to 8". 20120705 20:52:45< gabba> If it only happens in the mapbuilding and is reverted afterwards, then it's probably ok 20120705 20:54:30< ejls> Yes, it's only during the mapbuilding. 20120705 20:55:48< mordante> gabba, 42 movement points is the answer ;-) 20120705 20:56:18< gabba> mordante, yes now everything is clear! 20120705 20:56:25< mordante> :-0 20120705 20:56:30< mordante> :-) 20120705 20:56:34< CIA-87> ejls * r54589 /trunk/src/whiteboard/highlighter.hpp: Rename a macro to reflect the new file name. 20120705 20:57:03< ejls> gabba: ^ (I forgot to rename WB_HIGHLIGHT_VISITOR_) 20120705 20:57:09< CIA-87> ejls * r54590 /trunk/src/whiteboard/side_actions.hpp: wb::side_actions documentation correction. 20120705 20:57:43< gabba> ejls: so, a few quick words about the looming midterm eval 20120705 20:58:55< gabba> ejls: we're two or three weeks late compared to the calendar, so where do you think you can be in a week? 20120705 20:59:26< ejls> gabba: Actually, I'm only 4 days late now. Wait, I'm checking. 20120705 20:59:49< gabba> Ok, maybe only one week 20120705 21:00:06< ejls> looming ? I had to look for this word in the dictionary. :) 20120705 21:00:49< gabba> Yay for dramatic words :P 20120705 21:00:56< ejls> In theory I only have to move the action hierarchy now, but validate_visitor need a bit of work too. 20120705 21:01:43< ejls> I think it's going with the action hierarchy refactoring since the new hierarchy should contains the validation logic too. 20120705 21:02:03< ejls> I'm not sure if it should be a visitor though. 20120705 21:02:52< gabba> We'll see, but I think you've under-estimated the task of working with the mapbuilder and validation 20120705 21:03:14< gabba> They need to be combined, and conserving/improving the current behavior is gonna be a challenge 20120705 21:04:18< ejls> Hum, actually I was planning to move the validation logic to the core first. 20120705 21:04:35< gabba> ejls: how about you spend the next week doing a draft of how the transferred validation logic would look like? 20120705 21:05:35< ejls> Hum, you mean how it'll be combined with the mapbuilder? 20120705 21:06:02< gabba> By that I mean concentrate on splitting up the logic like you intend it to be, but don't worry about where it is placed for now 20120705 21:07:25< ejls> Since the action hierarchy will certainly change, I should maybe begin by changing it before changing code that depend on it. 20120705 21:08:15< ejls> I think the validation I'll just be done with a simple "bool action::valid() =0". The problem is more how the mapbuilder use it. 20120705 21:09:42< ejls> What's weird with the current validate_visitor is that it inherit from the mapbuilder (or at least, have an helper inherit from it) where it should simply be part of it. 20120705 21:10:52< gabba> Well, "bool action::valid() =0" would likely just return a boolean, if validating basically means mapbuilding 20120705 21:11:42< gabba> Not sure anymore about what we concluded on that topic to be honest 20120705 21:12:23< ejls> Do you wan't me to write you an email explaining what I'm planning to do so that we can discuss it? 20120705 21:12:42< gabba> Yeah, it might be easier than an IRC discussion 20120705 21:13:16< gabba> I (kinda) have fixed my home internet now, so I should be able to check it out Real Soon(tm) 20120705 21:13:27< ejls> s/IRC discussion/IRC discussion in ejls'bad english/ 20120705 21:14:17< gabba> ha ha. Well, I understand you well enough :) . But french should help a bit. 20120705 21:15:06-!- crab_ [~Crab_@wesnoth/developer/crab] has quit [Quit: Do it for joy and you can do it forever] 20120705 21:17:14< gabba> ejls: so, send me your plan. But do at least consider the option of moving the validation code first. To me it sounds like the more difficult/risky part, and refactoring the hierarchy to send it into the core should be an easier task IMO. 20120705 21:18:52< gabba> (even though it involves merging with some of Crab's code's logic) 20120705 21:19:46< ejls> gabba: Ok, I'll send you an email this night (in Europe). I have to go now. 20120705 21:19:54< gabba> see ya 20120705 21:20:07< ejls> gabba: au revoir. 20120705 21:20:32-!- gabba [d8623925@wesnoth/developer/gabba] has quit [Quit: Page closed] 20120705 21:28:40< mordante> I'm off bye 20120705 21:28:48-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving] 20120705 21:32:25-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20120705 21:36:14-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Quit: Leaving.] 20120705 21:51:32-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120705 21:56:21-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Read error: Connection reset by peer] 20120705 22:07:42-!- lipkab [~lipk@apn-89-223-152-155.vodafone.hu] has quit [Quit: Whistling winds blow through the bay, alas, my friends, I sail away.] 20120705 22:19:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 255 seconds] 20120705 22:20:43-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120705 22:34:00-!- Artemius23 [~Artemius2@139.179.205.22] has joined #wesnoth-dev 20120705 22:34:03-!- Artemius23 [~Artemius2@139.179.205.22] has quit [Client Quit] 20120705 22:37:54-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 264 seconds] 20120705 22:43:09-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20120705 22:54:30-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120705 23:06:36-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Remote host closed the connection] 20120705 23:09:10-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev 20120705 23:23:39-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120705 23:45:33-!- fendrin [~fabi@88-134-11-250-dynip.superkabel.de] has joined #wesnoth-dev 20120705 23:45:42-!- fendrin [~fabi@88-134-11-250-dynip.superkabel.de] has quit [Changing host] 20120705 23:45:42-!- fendrin [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev --- Log closed Fri Jul 06 00:00:20 2012