--- Log opened Mon Jul 09 00:00:04 2012
--- Day changed Mon Jul 09 2012
20120709 00:00:04< anonymissimus> since the handler is disabled only if the all filters let the event pass
20120709 00:03:22< anonymissimus> I'd use filter_condition for the variable in both; or perhaps have_location so no variable needed
20120709 00:03:44< CIA-87> alarantalara * r54655 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/06b_In_the_Domain_of_Dwarves.cfg: Remove events and kill variable
20120709 00:04:07< Alarantalara> I think I like this solution
20120709 00:04:33< Alarantalara> It's clear that one disables the other and there is a minimum of checking
20120709 00:04:46< anonymissimus> and for the backup charges an event instead
20120709 00:05:32< anonymissimus> which you fire; unfortunately the sentence is different fro both cases
20120709 00:07:25< Alarantalara> As far as I know, that would only reduce the saved game size, so while there are a lot of #defines that could be events, I'm leaving them for last
20120709 00:11:32-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection]
20120709 00:23:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120709 00:34:19< anonymissimus> Alarantalara: btw I love how you talk about yourself in the third person ;)
20120709 00:34:51< Alarantalara> Are you talking about the patch comment?
20120709 00:35:00< anonymissimus> yeah
20120709 00:41:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120709 00:41:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120709 00:42:55-!- anakayub [~anakayub@175.136.163.48] has quit [Quit: anakayub]
20120709 00:44:45< CIA-87> alarantalara * r54656 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Allow undoing moves when moving to a location where an unrescued merfolk was after they were killed
20120709 01:00:02-!- knotwork_ is now known as knotwork
20120709 01:01:42-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20120709 01:01:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120709 01:07:06-!- negusnyul [~negusnyul@dsl4E5CD1DC.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20120709 01:16:50-!- MeccaGod [majs@host189-199.bornet.net] has quit []
20120709 01:21:11< CIA-87> anonymissimus * r54657 /trunk/src/multiplayer_create.cpp: fix an MSVC warning about unused local variable
20120709 01:26:07-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 11.0/20120312181643]]
20120709 01:31:31< CIA-87> alarantalara * r54658 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Use [filter_condition] in scenario 9
20120709 01:51:32< CIA-87> alarantalara * r54659 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/ (2 files): Use [filter_condition] in scenario 11 and 12
20120709 02:04:44-!- ToBeFree [~tobefree@unaffiliated/tobefree] has quit [Remote host closed the connection]
20120709 02:04:49< CIA-87> alarantalara * r54660 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/11_Battle_for_Zocthanol_Isle.cfg: Remove some redundant conditions
20120709 02:39:25-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 244 seconds]
20120709 02:53:45-!- markus__ [~mjs-de@d184017.adsl.hansenet.de] has joined #wesnoth-dev
20120709 02:54:30-!- jamit [~james@pool-173-61-167-63.cmdnnj.east.verizon.net] has quit [Quit: Leaving.]
20120709 02:57:42-!- mjs-de [~mjs-de@g224178037.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20120709 03:12:26-!- eirikvw [189a49d2@gateway/web/freenode/ip.24.154.73.210] has joined #wesnoth-dev
20120709 03:19:59-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120709 03:26:09-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120709 03:38:45-!- eirikvw [189a49d2@gateway/web/freenode/ip.24.154.73.210] has quit [Ping timeout: 245 seconds]
20120709 03:38:50< CIA-87> alarantalara * r54661 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Someone succumbed to temptation, making a comment no longer applicable
20120709 03:56:08-!- neph [~neph@80.233.231.12] has joined #wesnoth-dev
20120709 04:00:08-!- neph [~neph@80.233.231.12] has quit [Ping timeout: 245 seconds]
20120709 04:11:17< CIA-87> alarantalara * r54662 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Unduplicate some dialog text
20120709 04:32:03-!- Ivanovic_ [~ivanovic@dtmd-4db23f93.pool.mediaWays.net] has joined #wesnoth-dev
20120709 04:32:40-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120709 04:35:29-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 260 seconds]
20120709 04:35:56-!- Ivanovic_ is now known as Ivanovic
20120709 04:42:07< CIA-87> alarantalara * r54663 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: More duplicate dialog elimination. Also allow translators to distinguish between male/female speakers/addressees for this dialog.
20120709 04:52:54< CIA-87> alarantalara * r54664 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Keep Esanoo from referring to himself in the third person
20120709 05:00:25< CIA-87> espreon * r54665 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Killed extra space in a string.
20120709 05:10:38< CIA-87> alarantalara * r54666 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: delete pointless comment given new event name
20120709 05:23:42< CIA-87> alarantalara * r54667 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/09_Blood_is_Thicker_Than_Water.cfg: Remove test_counter variable.
20120709 05:31:38< CIA-87> alarantalara * r54668 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/ (13 files): delete a pile of pointless comments about snapshot=no means there is no snap shot in saved games and that the turns macro makes the number of turns vary by difficulty
20120709 05:41:47< CIA-87> alarantalara * r54669 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/04_Descending_into_Darkness.cfg: Variable free item pickup!
20120709 05:54:13-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120709 05:56:01< CIA-87> alarantalara * r54670 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/ (2 files): Remove variables for the rest of the optional item pickup events
20120709 06:06:14< CIA-87> alarantalara * r54671 /trunk/data/campaigns/Under_the_Burning_Suns/scenarios/ (4 files): The meaning of turns=-1 does not require a comment.
20120709 06:15:17-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 248 seconds]
20120709 06:16:00-!- shadowm_laptop [ignacio@190.91.92.163] has joined #wesnoth-dev
20120709 06:16:01-!- shadowm_laptop [ignacio@190.91.92.163] has quit [Changing host]
20120709 06:16:01-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120709 06:33:24-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120709 06:42:39-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120709 06:47:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120709 07:00:50-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer]
20120709 07:05:51-!- Ivanovic [~ivanovic@dtmd-4db23f93.pool.mediaWays.net] has quit [Changing host]
20120709 07:05:51-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120709 07:14:28-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120709 07:19:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120709 07:22:43-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20120709 07:36:44-!- Sapient [~sapient@wesnoth/developer/sapient] has joined #wesnoth-dev
20120709 07:40:18-!- natasiel [~natasiel@wesnoth/mp-mod/natasiel] has quit [Ping timeout: 264 seconds]
20120709 07:45:02< zookeeper> sapient!
20120709 07:45:10< Sapient> yo zooks
20120709 07:45:26< Sapient> my fine finnish friend
20120709 07:45:30< zookeeper> i had a question for you, but i don't recall what it was. gotta dig through some logs...
20120709 07:45:59< Sapient> o boy I hope its a good one
20120709 07:46:09 * Sapient puts on thinking cap
20120709 07:46:18< zookeeper> oh, found it
20120709 07:46:19< zookeeper> <zookeeper> sapient, AFAIK [store_locations] stores border hexes, and jamit told me that [filter_adjacent] excludes them (even if SLF in general doesn't). that's pretty problematic when you want to for instance place units on a random stored location or something, so i think we need an extra SLF key to specify whether to include the border or not.
20120709 07:46:36< Sapient> bah, that one. yes I read it in the log
20120709 07:46:36< zookeeper> so, uh, what do you think about that?
20120709 07:47:04< Sapient> I think storing border hexes is a real edge case
20120709 07:47:08< Sapient> pun intended
20120709 07:48:30< Sapient> the store_locations should have never been made to store border hexes in the first place IMO
20120709 07:48:46< Sapient> unless it was as an option, defaulted to no
20120709 07:49:18-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: oldtopman has left the house]
20120709 07:49:38< Sapient> from a gameplay perspective, border hexes are just eye candy
20120709 07:50:24< Sapient> the worst that comes from not storing them is you can't put overlays or change the terrain there
20120709 07:50:27-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has joined #wesnoth-dev
20120709 07:50:34< zookeeper> yeah, but if you need to for instance simulate snowfall or something, you'll want to store border hexes too so you can affect them
20120709 07:50:38< zookeeper> yup
20120709 07:50:55< zookeeper> so is there something particularly tricky about supporting such a key in SLF?
20120709 07:51:14< Sapient> no
20120709 07:51:28< zookeeper> cool. can we have it? :P
20120709 07:51:59< Sapient> I haven't added any features in a while now ;)
20120709 07:52:47< Sapient> but... I think it should be easy
20120709 07:53:27< zookeeper> would be great
20120709 07:53:36< Sapient> should it be in the [store_locations] or in the SLF itself?
20120709 07:53:53< zookeeper> SLF, i'd say
20120709 07:54:01< Sapient> if in the SLF, that gets weird when subtag specifies something different than parent tag
20120709 07:54:15< zookeeper> defaulting to no sounds like a good idea too. changes behaviour in [store_locations] but meh
20120709 07:54:34< Sapient> changes it back to making sense
20120709 07:54:35< zookeeper> how so?
20120709 07:55:23< Sapient> I guess it could work... outer tag accepts border, child tag does not
20120709 07:55:37-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has quit [Ping timeout: 244 seconds]
20120709 07:55:48< zookeeper> i mean... how is it more weird than when you use terrain= or x= or whatever?
20120709 07:55:55< Sapient> but then that raises the question of child defaulting to no
20120709 07:56:09< Sapient> or defaulting to parent's border preference
20120709 07:57:26< Sapient> so, which would be correct?
20120709 07:57:37 * Sapient ponders this
20120709 07:57:48< Sapient> wesbot: seen jamit
20120709 07:57:49< wesbot> Sapient: The person with the nick jamit last spoke 7h 59m ago.  5h 3m ago they left with the message: Quit: Leaving.
20120709 07:59:23< Sapient> jamit: just wanted to congratulate you on the get_tiles_radius work... very nice ^_^
20120709 07:59:45< Sapient> that one had been bugging me for a long time
20120709 07:59:59< zookeeper> x=1 [filter_adjacent_location] x=2
20120709 08:00:17< zookeeper> border=no [filter_adjacent_location] border=yes
20120709 08:00:25< zookeeper> what's the difference really?
20120709 08:01:05< Sapient> zookeeper: I'm not sure I understand your answer
20120709 08:01:53< Sapient> if the border attribute is not specified in the child tag, should it default to "no" or default to the border preference of the parent tag?
20120709 08:03:07< Sapient> anyway, I must go now sorry my friend
20120709 08:03:13< zookeeper> mmkay
20120709 08:03:18< zookeeper> i'll ponder on this too :p
20120709 08:03:22-!- Sapient [~sapient@wesnoth/developer/sapient] has quit [Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204]]
20120709 08:15:58-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds]
20120709 08:17:36-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120709 08:18:13< ancestral> Has it been decided if some races have only one gender?
20120709 08:18:50< ancestral> Obviously artwork is the barrier, but has it ever been agreed that, for example, there are no female Dwarvish Ulfserkers?
20120709 08:19:52-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120709 08:20:24< zookeeper> ancestral, i don't think so
20120709 08:20:50< ancestral> Followup question: Are the Drakes we see in the game male, female, or both? ;-)
20120709 08:21:08< ancestral> (if undecided, that's okay too)
20120709 08:21:34< shadowm> Male.
20120709 08:22:18< shadowm> Some guy decided females would be non-sentient or something, not sure if that idea met its rightful end yet or not.
20120709 08:22:23< zookeeper> for some distinctly non-human races, i think the idea is that the gender differences would not be apparent to humans therefore all of them appear as one gender in-game
20120709 08:22:39< zookeeper> but yeah, the drake lore is a bit messed up due to... that
20120709 08:23:11< ancestral> I was simply curious when creating a unit dynamically
20120709 08:23:43< ancestral> If it's possible to create a female Drake, or if any attempts to make one get changed to a male
20120709 08:24:07< shadowm> It is perfectly possible atm to spawn a unit with a gender that isn’t supported by its unit type, IIRC.
20120709 08:35:10-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20120709 08:38:17-!- mattsc [~mattsc@d50-92-196-35.bchsia.telus.net] has quit [Quit: bye]
20120709 08:49:39-!- stikonas [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 08:49:39-!- stikonas [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Changing host]
20120709 08:49:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120709 09:01:48-!- knotwork [~markm@142.68.63.54] has joined #wesnoth-dev
20120709 09:01:49-!- knotwork [~markm@142.68.63.54] has quit [Changing host]
20120709 09:01:49-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20120709 09:11:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120709 09:11:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20120709 09:16:38-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120709 09:19:02-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120709 09:19:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120709 09:21:59-!- neph [~neph@80.233.231.12] has joined #wesnoth-dev
20120709 09:31:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20120709 09:32:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120709 09:57:06-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20120709 10:00:56-!- boucman_mobile [~boucman@80.214.8.62] has joined #wesnoth-dev
20120709 10:01:03-!- boucman_mobile [~boucman@80.214.8.62] has quit [Changing host]
20120709 10:01:03-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 10:01:08-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20120709 10:01:21-!- boucman_mobile [~boucman@80.214.8.15] has joined #wesnoth-dev
20120709 10:01:21-!- boucman_mobile [~boucman@80.214.8.15] has quit [Changing host]
20120709 10:01:21-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 10:16:19-!- markus__ is now known as mjs-de
20120709 10:20:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120709 10:20:24-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:20:50-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Client Quit]
20120709 10:21:06-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:21:33-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Client Quit]
20120709 10:21:52-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:22:17-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Client Quit]
20120709 10:22:36-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:23:02-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Client Quit]
20120709 10:23:20-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:23:46-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Client Quit]
20120709 10:24:10-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 10:35:50-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120709 11:37:17-!- Upth is now known as Upthorn
20120709 11:40:46-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120709 12:09:49-!- ToBeFree [~tobefree@unaffiliated/tobefree] has joined #wesnoth-dev
20120709 12:10:52-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120709 12:19:32-!- anakayub [~anakayub@175.143.199.46] has joined #wesnoth-dev
20120709 12:40:34-!- anakayub [~anakayub@175.143.199.46] has quit [Quit: anakayub]
20120709 12:57:52-!- loonybot [~loonybot@46.138.74.131] has joined #wesnoth-dev
20120709 12:57:52-!- loonybot [~loonybot@46.138.74.131] has quit [Changing host]
20120709 12:57:52-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120709 13:19:53-!- negusnyul [~negusnyul@dsl4E5CD1DC.pool.t-online.hu] has joined #wesnoth-dev
20120709 13:42:49-!- MeccaGod [~majs@host189-199.bornet.net] has joined #wesnoth-dev
20120709 14:08:41-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120709 14:30:53-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120709 14:41:46-!- Ayne [~Ayne@cpc2-sgyl34-2-0-cust493.sgyl.cable.virginmedia.com] has joined #wesnoth-dev
20120709 14:42:27-!- stikonas [~gentoo@ctv-79-132-164-161.vinita.lt] has joined #wesnoth-dev
20120709 14:42:27-!- stikonas [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Changing host]
20120709 14:42:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120709 14:42:32-!- stikonas__ [~gentoo@ctv-79-132-164-161.vinita.lt] has quit [Read error: Connection reset by peer]
20120709 14:43:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20120709 14:43:21-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120709 14:58:44< bloodycoin_m> boucman_mobile: new code (since yesterday), drop an eye when you have time :)
20120709 15:06:59-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20120709 15:07:10-!- boucman_mobile [~boucman@80.214.8.61] has joined #wesnoth-dev
20120709 15:07:10-!- boucman_mobile [~boucman@80.214.8.61] has quit [Changing host]
20120709 15:07:10-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 15:07:44< boucman_mobile> Ok will do tonight 
20120709 15:19:40-!- neph_ [~neph@80.233.231.12] has joined #wesnoth-dev
20120709 15:22:56-!- neph [~neph@80.233.231.12] has quit [Ping timeout: 252 seconds]
20120709 15:33:12-!- neph_ [~neph@80.233.231.12] has quit [Ping timeout: 249 seconds]
20120709 15:35:02-!- elias [~allefant@allefant.com] has quit [Read error: Operation timed out]
20120709 15:43:02-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Quit: bye]
20120709 16:05:57-!- elias [~allefant@allefant.com] has joined #wesnoth-dev
20120709 16:18:37-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20120709 16:18:46-!- boucman_mobile [~boucman@80.214.8.37] has joined #wesnoth-dev
20120709 16:18:46-!- boucman_mobile [~boucman@80.214.8.37] has quit [Changing host]
20120709 16:18:46-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 16:19:35-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20120709 16:19:42-!- boucman_mobile [~boucman@80.214.8.65] has joined #wesnoth-dev
20120709 16:19:42-!- boucman_mobile [~boucman@80.214.8.65] has quit [Changing host]
20120709 16:19:42-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 16:33:33-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20120709 16:39:07-!- neph_ [~neph@80.233.231.12] has joined #wesnoth-dev
20120709 16:52:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120709 17:01:44-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20120709 17:01:54-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 17:07:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120709 17:07:56-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20120709 17:08:04-!- boucman_mobile [~boucman@80.214.8.10] has joined #wesnoth-dev
20120709 17:08:04-!- boucman_mobile [~boucman@80.214.8.10] has quit [Changing host]
20120709 17:08:04-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 17:13:36-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120709 17:15:35-!- boucman_mobile [~boucman@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20120709 17:15:42-!- boucman2 [~boucman@80.214.8.80] has joined #wesnoth-dev
20120709 17:20:28< neph_> mattsc, hi
20120709 17:20:37< neph_> I'm currently trying to get the enemy attacks up
20120709 17:20:42< neph_> it's a bit of struggle
20120709 17:21:05< mattsc> hi, neph.  anything I can help with?
20120709 17:21:33< neph_> no, not really, just saying
20120709 17:22:52< mattsc> ok, thanks.  I am currently trying to provide grunt backup for exposed orcish poisoners.  :)
20120709 17:22:56-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120709 17:23:10-!- boucman2 [~boucman@80.214.8.80] has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )]
20120709 17:23:27-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has joined #wesnoth-dev
20120709 17:49:14-!- vultraz [~chatzilla@124.109.10.221] has quit [Ping timeout: 252 seconds]
20120709 18:12:48< CIA-87> fendrin * r54672 /trunk/src/help.cpp: Support for displaying the costs of vision and jamming in the unit description.
20120709 18:18:15< CIA-87> fendrin * r54673 /trunk/ (5 files in 3 dirs): Made the editor brushbar configurable by theme wml instead of being hardcoded.
20120709 18:18:41-!- vultraz [~chatzilla@124.109.10.221] has joined #wesnoth-dev
20120709 18:21:17-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120709 18:22:40-!- lipkab [~lipk@apn-89-223-198-251.vodafone.hu] has joined #wesnoth-dev
20120709 18:36:47-!- Elvish_Pillager [~eli@71-10-229-241.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20120709 18:39:43-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has joined #wesnoth-dev
20120709 18:56:17-!- mjs-de [~mjs-de@d184017.adsl.hansenet.de] has quit [Remote host closed the connection]
20120709 19:04:21-!- timotei [~timotei@188.24.2.25] has joined #wesnoth-dev
20120709 19:04:21-!- timotei [~timotei@188.24.2.25] has quit [Changing host]
20120709 19:04:21-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20120709 19:06:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120709 19:07:24< boucman> hey all
20120709 19:07:35< lipkab> hi boucman
20120709 19:16:15-!- MeccaGod [~majs@host189-199.bornet.net] has quit []
20120709 19:30:58-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120709 19:44:11-!- negusnyul [~negusnyul@dsl4E5CD1DC.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20120709 20:06:49-!- MeccaGod [majs@host189-199.bornet.net] has joined #wesnoth-dev
20120709 20:15:07-!- mjs-de [~mjs-de@p579C824C.dip.t-dialin.net] has joined #wesnoth-dev
20120709 20:17:55< boucman> bloodycoin_m: around ?
20120709 20:18:12-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has quit [Remote host closed the connection]
20120709 20:18:31-!- neXyon [~neXyon@85-127-226-248.dynamic.xdsl-line.inode.at] has joined #wesnoth-dev
20120709 20:21:52< Ivanovic> grrr, i don't like the mail interface for the ML, it seems to not want to allow me to ban the spammer from the dev-ml
20120709 20:21:58< Ivanovic> though i already did a force unsubscribe
20120709 20:27:41-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20120709 20:27:55< bloodycoin_m> boucman: yep
20120709 20:27:58< mordante> servus
20120709 20:28:03< lipkab> hi mordante
20120709 20:28:07< boucman> just looked at your change, it sounds good
20120709 20:28:11< lipkab> Got a few minutes now?
20120709 20:28:14< mordante> hi lipkab 
20120709 20:28:39< mordante> lipkab, not at the moment, maybe later, will ping you
20120709 20:28:49< lipkab> ok
20120709 20:29:14< boucman> I thought the follow parameter would not exist, i.e it would be functions like test_move that would get x and y as extra params and would decide to use it or not
20120709 20:29:41< boucman> i'm not sure if my idea makes more or less sense...
20120709 20:29:53< boucman> but overal I'm ok with your way of doing stuff
20120709 20:30:29< boucman> however, it seems to me you don't use the new follow code you wrote, do you ?
20120709 20:31:25-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120709 20:31:48< bloodycoin_m> there is one thing, not sure if that is particularly wrong... when particles are following, every few hexes effects starts anew (when animation changes).. thus implies, that following effects should be be really short, and rarely can complete...
20120709 20:32:26< anonymissimus> Sapient, zookeeper not being able to store border hexes is very bad; if you wanna lift shroud for instance you would have to leave a very visible shroud edge
20120709 20:32:45< boucman> i'm not sure what you mean...
20120709 20:32:51< anonymissimus> but you already concluded that as far as I see
20120709 20:32:54< bloodycoin_m> boucman: if you comment out if block at particle_effect.cpp:48, you can see how it works w/o forcing to clean out particles of not finished effects
20120709 20:33:35< boucman> doing that now...
20120709 20:34:06< anonymissimus> if we change the default, then this of course belong into the important syntax changes thread...and it perhaps introduces quite some bugs
20120709 20:34:16< bloodycoin_m> boucman: which part do you have in mind, when saying "follow code"?
20120709 20:35:18< boucman> the concept of having "follow" as a member of the effect class
20120709 20:35:23< boucman> I hadn't imagined the code like that
20120709 20:35:24< bloodycoin_m> boucman: oh, to force effect follow unit, you have to uncomment "follow=yes" in cfg of horseman
20120709 20:37:16-!- ancestral [~ancestral@75-168-39-185.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120709 20:37:45< boucman> bloodycoin_m: yes, but at what point do you call update_efect_position ?
20120709 20:38:20< bloodycoin_m> boucman: on unit_anim::redraw
20120709 20:39:06-!- trademark [~trademark@mon69-1-82-67-23-185.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20120709 20:39:50< bloodycoin_m> I meant unit_animation:redraw
20120709 20:41:08< boucman> no, you only change the hex there, not the x and y
20120709 20:42:28< bloodycoin_m> oh... you mean mean x and y offsets for current hex?
20120709 20:42:47< boucman> yes
20120709 20:43:20< bloodycoin_m> yea... I didn't take it into account yet ^^'
20120709 20:43:49< boucman> ok, I didn't miss it, good...
20120709 20:43:51< boucman> :)
20120709 20:44:26< boucman> it can't be easily extracted from anim_frame at this point at this point anyway, we'll discuss that in a moment
20120709 20:44:37< boucman> I want to understand the issue you pointed earlier right now...
20120709 20:46:35< boucman> hmm
20120709 20:46:50< bloodycoin_m> should I try to explain again? :)
20120709 20:47:00< boucman> ok, I see your problem... should the particles survive their animation, and follow when changing animation...
20120709 20:47:05< boucman> that's a complicated question
20120709 20:47:20< boucman> bloodycoin_m: a small compile is worth a thousand words :)
20120709 20:47:32< bloodycoin_m> hehe...
20120709 20:48:38< boucman> ok, should particles survive their animations, it depends on the effect :P so probably needs to be another parameter
20120709 20:48:42< bloodycoin_m> if I want to make particles survive and follow animation... I find it particularly challenging
20120709 20:48:51< boucman> (that shouldn't complicate the design too much, at this point)
20120709 20:49:09< boucman> follow animations, I need to think about it a bit...
20120709 20:49:38< anonymissimus> timotei: where exactly was that file you pointed me to to restore the commits which I lost due to the broken dcommit ?
20120709 20:50:21< anonymissimus> I managed to somehow magically delete some commits
20120709 20:50:27< bloodycoin_m> it wouldn't be a problem, if there is only one effect created over the course of movement, but since, there are usually more than one effect created per movement, and they know nothing about each other... that is complicated
20120709 20:51:40< boucman> basically, for the running animation (which is the most complicated) I see two types of animations
20120709 20:51:59< boucman> create an effect of rising particles while we walk
20120709 20:52:32< boucman> the creation point should move along with us, but the particles themselves don't follow us, they follow their path independently once created
20120709 20:52:50< bloodycoin_m> that's easy and implemented :)
20120709 20:53:21< boucman> except for the x and y following the unit within a hex, yes it's implemented
20120709 20:53:31< boucman> but that's just a missing feature, no big deal
20120709 20:54:14< timotei> anonymissimus: .git/logs/HEAD
20120709 20:54:15< boucman> the second use case is a twister of particle circling around the unit (preferably going "behind"the unit if that's possible) and that's more complicated
20120709 20:54:50< timotei> anonymissimus: Or, I've learned a new way: git reflog
20120709 20:55:58< boucman> that second case is more complicated, we need to think about it some more...
20120709 20:57:02< boucman> i'd rather discuss the X and Y thing today, because I know what to do and just need to explain it, and come back to you with the second problem later after I have thought a bit more about it... you ok with that ?
20120709 20:57:04< bloodycoin_m> boucman: hmm... for twister... I could try cheating it, by spawning very short lived particles anywhere is defined region (hex) and moving them in some direction for few frames..
20120709 20:57:19< bloodycoin_m> amm... sure
20120709 20:57:48< boucman> i'll discuss the twister case a bit more, but i'd rather do the x y first so you have some stuff to do tomorow
20120709 20:58:00< boucman> basically what you want is the unit's position within the hex
20120709 20:58:01-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev
20120709 20:58:46< boucman> if you go to unit_animation::redraw it's the unit_anim_ subanimation that has that info
20120709 20:59:00< bloodycoin_m> yep... I am in there...
20120709 20:59:53< boucman> subanimations are a list of unit_frame class, each unit_frame allowing us to draw the unit's image at a given time
20120709 20:59:54< bloodycoin_m> ermm.. q: in subanimation::redraw src_ and dst_ are always adjecent or no?
20120709 21:00:10< boucman> no, not in case of teleport :P
20120709 21:00:43< bloodycoin_m> ughh...
20120709 21:00:45< boucman> though teleport is a bit special, let's forget that for the moment
20120709 21:00:54< bloodycoin_m> gladly
20120709 21:01:15< boucman> (it allows to have a sphere of light zapping from src to dst at high speed, but no unit does it for the moment)
20120709 21:01:37< boucman> though having an effect doing that and sparkling particles would be awsome :P
20120709 21:01:49< bloodycoin_m> I love features, which are not used anywhere xDD
20120709 21:01:51< boucman> ahem, lets get back to our main subject :)
20120709 21:02:22< bloodycoin_m> sure, *makes a serious facial expresion*
20120709 21:02:32< boucman> we want to extract the unit's position out of the unit_frame, which unfortunately doesn't have that info
20120709 21:02:45< boucman> more precisely, it calculates that info, uses it, and drops it right away
20120709 21:02:58< boucman> so there is a bit of refactoring to do in there...
20120709 21:05:10< bloodycoin_m> isn't it in unit_frame::redraw, that does interpolation calculation of offset between src dst?
20120709 21:05:29< boucman> yes, I was going to point you there
20120709 21:06:29< boucman> but that code is already sort of duplicated in unit_frame::get_overlaped_hex
20120709 21:06:46< anonymissimus> timotei: btw, did you build and MSVC release wesnoth.exe recently ?
20120709 21:07:13< timotei> anonymissimus: nope :(. I was involved with so many things this year... so no
20120709 21:07:21< anonymissimus> and executed it successfully such as launching the test scenario ?
20120709 21:07:21< timotei> Why? Do you want me to do that?
20120709 21:07:25< anonymissimus> yes
20120709 21:07:29< timotei> Ok. Will do now
20120709 21:07:32< boucman> so i'm going to use you to clean all that a bit :P
20120709 21:07:48< anonymissimus> since since I have the new hardware it crashes for me at start
20120709 21:08:15< anonymissimus> but its not so important since for normal execution I use the MinGw release which works, and MSVC debug works as well
20120709 21:09:06< timotei> No problem. I will do it.
20120709 21:09:13< anonymissimus> so I didnt investigate; just want to know whether there must be some problem on my side
20120709 21:09:16< timotei> MSVC has some weird workings on release mode.
20120709 21:09:26< timotei> IDK why exactly, probably wrong optimizations being made.
20120709 21:09:40< timotei> Btw, you might want to try Visual Assist X with MSVC :D
20120709 21:09:45< timotei> It's a wonderful thing
20120709 21:10:14< anonymissimus> what's it good for, I hear about it again
20120709 21:10:20< boucman> basically, you take all that code out of unit_frame::redraw and unit_frame::get_overlaped_hex and move it to a new function frame_parameters::get_frame_position (that returns a pair of int) and use that function instead
20120709 21:10:23< boucman> could you do that ?
20120709 21:10:25< bloodycoin_m> refactoring two 100 liner function dealing with core drawing... sounds fun
20120709 21:10:29< timotei> Just think about: MSVC++
20120709 21:10:29< timotei> :D
20120709 21:10:33< boucman> :)
20120709 21:10:34< timotei> In the coding way
20120709 21:10:48< timotei> Better intellisense, refactoring, a better find all references
20120709 21:10:51< timotei> Which actually works
20120709 21:11:02< timotei> Go to definition, let's you select if you want implementation/declaration
20120709 21:11:12< boucman> bloodycoin_m: it shouldn't be that complicated, it's mainly copy/paste out of redraw, testing it, then checking that get_o_h is doing the same thing
20120709 21:11:15< timotei> Since I've used that on the wesnoth codebase I couldn't get lost anymore
20120709 21:12:44< boucman> could you do that ?
20120709 21:13:07< bloodycoin_m> mm... should I also refactor, to keep up 80 chars limit? :)
20120709 21:13:28< boucman> bloodycoin_m: I don't mind that...
20120709 21:13:49< boucman> so don't bother, it's not worth it
20120709 21:14:13< bloodycoin_m> because... long... lines... don't... play... well... in my.. eyes...
20120709 21:14:37< boucman> bloodycoin_m: if you want to, feel free to do it, but if you don't I don't mind
20120709 21:14:41< timotei> bloodycoin_m: word wrap? :)_
20120709 21:15:05< bloodycoin_m> boucman: that makes things even less readable
20120709 21:15:12< timotei> anonymissimus: I'm looking to get new feedback about the current version of the UMC IDE with a poll, to see in which way I should direct my efforts. 
20120709 21:15:19< timotei> anonymissimus: Do you think I should create a new thread?
20120709 21:15:26< timotei> And link to the older one?
20120709 21:15:43< anonymissimus> no idea
20120709 21:16:49< bloodycoin_m> boucman: so then I guess I should return (x,y) pair by reference in function parameters, unless you know a magic way to force c++ return multiple values :)
20120709 21:17:09< timotei> anonymissimus: http://www.wholetomato.com/
20120709 21:17:18< boucman> return a stl::pair<int,int> ;)
20120709 21:17:55< bloodycoin_m> oww xD
20120709 21:18:40< anonymissimus> what, it's not open source ? :(
20120709 21:19:06< timotei> anonymissimus: I doubt you'll ever find such a tool being open source :)
20120709 21:19:16< timotei> No, you can try it for 30 days.
20120709 21:19:22< timotei> I bought it (Academic license)
20120709 21:19:25< timotei> Worth every cent :D
20120709 21:19:31< anonymissimus> okay
20120709 21:19:43< timotei> anonymissimus: MSVC9 or 10?
20120709 21:19:59< timotei> Which one you want me to build?
20120709 21:21:05< loonycyborg> timotei: You are confused. There's nothing preventing quality software from being open-source.
20120709 21:22:14< mordante> bloodycoin_m, I like 80 char lines ;-)
20120709 21:22:27< loonycyborg> However, it being closed source allows them to do really shitty coding. I think this should be forbidden..
20120709 21:22:35< timotei> loonycyborg: I agree. There is quality open source software. 
20120709 21:22:59< bloodycoin_m> mordante: glad I am not alone :)
20120709 21:23:18< timotei> I was merely refering more to the MSVC 3rd party tools thingy, in the way that the probability to create some enhancements for products like to be open source is small.
20120709 21:23:35< mordante> :-)
20120709 21:23:53< timotei> I wish it was open source too. But if I have to pay a price for something that helps me, why not? :)
20120709 21:24:05< anonymissimus> timotei: 9
20120709 21:24:23< timotei> Probably because MSVC's architecture is so cumbersome, they decided the efforts are not worth being free
20120709 21:24:27< timotei> Or something along those lines.
20120709 21:24:34< timotei> anonymissimus: ok
20120709 21:25:36< anonymissimus> however, there's also very buggy open source software such as wesnoth :P
20120709 21:27:22< boucman> bloodycoin_m: i'll give you a quick
20120709 21:27:46< boucman> overview of why we change animations so you can understand the problem and think about it too
20120709 21:28:20-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120709 21:28:28< boucman> basically when we start moving animation, we choose a valid one according to the current situation (terrain, unit, etc...) and we play it until
20120709 21:28:56< boucman> either the animation ends (in which case we suppose the artist made sure the animation will correctly loop)
20120709 21:29:37< anonymissimus> since none maintains the VC10 files we should better remove them
20120709 21:29:40< boucman> or the animation is invalid (example: we have a running animation but the unit reaches water, we stop the running animation to switch to a swimming animation)
20120709 21:30:13< anonymissimus> people come here and complain, only to be left alone since no windows dev is around
20120709 21:30:22< boucman> in the first case we probably want the effect to outlive the animation, because it's hard to expect the same continuity from effects than we do from animations
20120709 21:30:46< boucman> in the second case the effect must be stoped (and maybe killed) to be replaced by the effect of the new animation
20120709 21:30:57< mordante> anonymissimus, it would be nice to test whether MSVC works with CMake
20120709 21:31:14< anonymissimus> so people don't try to build using them but rather convert the vc9 files if they can't get MSVC9 which has much better chance of success
20120709 21:31:37< bloodycoin_m> boucman: hmm... but in the first case.. why is it, when animation ends, a new instance of animation is created instead, o keeping old one, and replaying frames again??
20120709 21:31:56< bloodycoin_m> /s/o/of
20120709 21:32:17< anonymissimus> mordante: not very eager to try...need installing cmake in the first place and all
20120709 21:32:33< mordante> :-(
20120709 21:32:42< boucman> bloodycoin_m: let me check the code
20120709 21:33:04< anonymissimus> perhaps after that patch you have pending
20120709 21:36:19< timotei> mordante: MSVC works with CMake in the way that Crab_ made CMake generate MSVC solution files.
20120709 21:36:41< boucman> ok, suppose we have multiple valid movement animations, we don't want to play the same one again and again, so when we reach the end, we look for a potentially other one
20120709 21:36:48< anonymissimus> also, I never know for sure whether all dependencies are reolved since I use the same MSVC installation for teh standalone build
20120709 21:36:53< boucman> if there is only one, then we still do as if it's a new one 
20120709 21:37:02< mordante> timotei, yes I know, the question is more is it still used and thus tested
20120709 21:37:12< timotei> Yes, the dependencies stuff is not ok.
20120709 21:37:26< boucman> which also makes things more complicated in the case of effects, which is why I want to give it some thoughts before telling you what to do...
20120709 21:42:32< bloodycoin_m> boucman: hmm... just my thoughts... if I were to do, say, running animation, which has three (for example) different frame sets for running. I would exchange last frame set with next frame set to play it, but not kill whole animation unit...
20120709 21:43:13< boucman> bloodycoin_m: you tend to like reusing a lot :)
20120709 21:43:29< bloodycoin_m> isn't that good? :)
20120709 21:44:12< boucman> not always, on some tructure copying data into an existing instance isn't much less expensive than copying all data into it
20120709 21:44:17< boucman> and much more error prone
20120709 21:44:27< bloodycoin_m> I would probably still kill animation unit for different kinds of animations
20120709 21:44:34< boucman> as a rule of thumb, you should avoid optimisation until your code is at least functionally done
20120709 21:45:15< boucman> bloodycoin_m: internally the engine doesn't have a notion of "animation kind" all animations are the same, and you could reuse an animation for multiple events
20120709 21:45:56< boucman> in that case, I would gain the malloc time, so one malloc at every animation change, that is : one malloc every couple of seconds. not worth it
20120709 21:46:19< boucman> tbh I am not convinced the complicated mechanic you put in place for effect reuse is worth its code complexity cost
20120709 21:47:22< bloodycoin_m> they aren't reused anymore.. -.-'
20120709 21:48:06< bloodycoin_m> only particles
20120709 21:48:52< boucman> oh, ok
20120709 21:51:34< mordante> lipkab, I've a few minutes now (emphasises on few)
20120709 21:51:56< bloodycoin_m> I am not against "optimize later", but just theoretically speaking, it's possible, that by writing code w/o optimizations in mind, you write code, which ends being unoptimizable (unless you write optimization mechanism, which ends being more complicated, than original code)
20120709 21:52:46< bloodycoin_m> .. while all of it could be done more optimal and less complex, while keeping optimizations and performance in mind :)
20120709 21:53:23< boucman> yes, you can keep optimisation in a corner of your mind when writing code but...
20120709 21:53:47< boucman> 1) you can prepare structure for it, but don't implement it at first when there is a simpler way
20120709 21:54:30< boucman> 2) years of experience have taught me that the bottlenecks are NEVER (heavy emphasis on NEVER) where you expect them to be, so all your optimisations usually end up moot
20120709 21:55:04< boucman> and that's the main reason for not optimizing early, you will learn through failure (it's the only real way to learn) that you can't predict where the bottlenecks will be
20120709 21:56:11< lipkab> mordante: Ok, I've gone through your meta-patch, and...
20120709 21:56:59< lipkab> What do you mean by "Parameter not documented"? What should be documented there?
20120709 21:57:24< mordante> the WML documentation
20120709 21:57:56< lipkab> In a bit more detail, please?
20120709 21:58:15< anonymissimus> mordante: okay, since you are my special friend I tried it now; the build may last a while though
20120709 21:58:35< lipkab> mordante: Should I specify which widgets will get that data or what?
20120709 21:58:46-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120709 21:59:00< anonymissimus> I got the same error I had the last time when generating the project file, the find_package(Libintl REQUIRED) line causes problems
20120709 21:59:04< mordante> lipkab, they are not documented in the wiki comment
20120709 21:59:13< mordante> thanks anonymissimus 
20120709 21:59:23< anonymissimus> lets see whether it works nontheless like it did the last time, I just commented out that line
20120709 21:59:31< lipkab> Ok, I'll look up something similar...
20120709 22:00:04< mordante> IIRC libintl is in libc on Linux, not sure what package provides on Windows
20120709 22:00:29< lipkab> mordante: Then, the "weird behavior" of the modifications dialog... yeah, you just can't cancel that dialog right now.
20120709 22:00:42< lipkab> There's only a "Close" button.
20120709 22:01:14< anonymissimus> when I investigated the error the last time I by all I know was sure to have suplied the correct location, and it's  there in package
20120709 22:01:39< anonymissimus> and since the build also succeeded I thought it's a false positive or something
20120709 22:02:25< lipkab> mordante: About fixed-size windows: both dialogs (confirm change and select new) contain variable length data, so I thought it'd be a good idea to maximize their dimensions, so that they can't grow too big.
20120709 22:03:34< lipkab> The tab thing mp_depcheck_confirm_change.cpp: it's just some fancy formatting.
20120709 22:04:07< mordante> lipkab, still it would be a good idea so code as-if there is a cancel button as well
20120709 22:04:27< mordante> that way when somebody provides it it will work out-of-the box
20120709 22:04:37< lipkab> Hmmm, okay.
20120709 22:04:55< mordante> also prefer a OK button to be named ok, with close I'm not sure what the dialogue will do
20120709 22:05:01< mordante> anonymissimus, odd
20120709 22:05:25< mordante> lipkab, is there a way to test the dialogues?
20120709 22:06:11< mordante> lipkab, the idea of GUI2 is to mainly let it determine the best window size by itself
20120709 22:06:21< CIA-87> ivanovic * r54674 /trunk/po/ (wesnoth/ja.po wesnoth-help/ja.po wesnoth-low/ja.po): updated Japanese translation
20120709 22:07:14< lipkab> mordante: so, I can safely remove that without having to worry that it would potentially crash the game on 800x480 resolution?
20120709 22:07:30< CIA-87> ivanovic * r54675 /branches/1.10/po/ (wesnoth/ja.po wesnoth-help/ja.po wesnoth-low/ja.po): updated Japanese translation
20120709 22:07:49< anonymissimus> mordante: what does the find_package(Libintl REQUIRED) line look for exactly ? I pass -DLIBINTL_INCLUDE_DIR=..\external\libintl-0.14.4\include and libintl.h is there
20120709 22:07:55< lipkab> mordante: testing: not really, other than creating "real life" situation in which they show up.
20120709 22:08:05< mordante> lipkab, will if it crashes it's a bug
20120709 22:08:28< mordante> lipkab, :-(
20120709 22:09:32< lipkab> mordante: The messages in Select New and Confirm Change: I switched to vgettext CC, but I don't really see a reason in SN.
20120709 22:09:43< anonymissimus> also, -DLIBINTL_LIBRARY=D%\external\libintl-0.14.4\lib\libintl.lib
20120709 22:10:08< lipkab> Currently there're no variables in the tranlatable strings, and I guess that's supposed to be good.
20120709 22:10:14< mordante> anonymissimus, ah just wanted to mention that as well
20120709 22:10:28< mordante> anonymissimus, should be libraries instead of library
20120709 22:11:17< mordante> lipkab, what dialogue is SN?
20120709 22:11:35< lipkab> mp_depcheck_select_new
20120709 22:12:02< lipkab> (And CC = mp_depcheck_confirm_change)
20120709 22:12:05< timotei> anonymissimus: still compiling :)
20120709 22:14:16< mordante> lipkab, it might be nice to factor out the common part, but not required per se
20120709 22:14:51< lipkab> Okay, then I think I'm done.
20120709 22:15:01< lipkab> ...with the questions.
20120709 22:15:20< mordante> good because I'm really about to leave
20120709 22:15:24< mordante> I'm off night
20120709 22:15:28< lipkab> Good night.
20120709 22:15:53-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20120709 22:17:05-!- lipkab [~lipk@apn-89-223-198-251.vodafone.hu] has quit [Quit: Whistling winds blow through the bay, alas, my friends, I sail away.]
20120709 22:22:18-!- lansiir [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120709 22:23:52-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Ping timeout: 252 seconds]
20120709 22:27:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20120709 22:28:30-!- lansiir is now known as oldtopman
20120709 22:39:03< anonymissimus> mordante: okay, that went fine, despite I commented line 30 in cmakelists.txt (find_package(Libintl REQUIRED)) so the generation succeeds
20120709 22:41:08< anonymissimus> even passing command line arguments works this time although I remember that never did if with MSVC+cmake before ...
20120709 22:44:03< timotei> anonymissimus: ok. compiling done
20120709 22:44:10< timotei> Let's see
20120709 22:44:14< timotei> wesnoth -t you say?
20120709 22:44:40< timotei> Umm... anonymissimus , that find_package are fine.
20120709 22:44:56< timotei> You just need to have pkg-config installed and a valid PKG_CONFIG_PATH so cmake can find it :)
20120709 22:45:25< timotei> Lately I've tried compiling on windows, a lot of stuff that was build for linux initially.
20120709 22:50:55< CIA-87> anonymissimus * r54676 /trunk/src/widgets/textbox.cpp: 
20120709 22:50:55< CIA-87> Do not attempt to copy from the command line if there is no selection.
20120709 22:50:55< CIA-87> This caused an out-of-bounds problem. Found by visual studio debugger.
20120709 22:51:38< timotei> anonymissimus: nope. Doesn't work.
20120709 22:51:45< timotei> Throws something in std::basic_string
20120709 22:52:10< anonymissimus> "You just need to have pkg-config installed and a valid PKG_CONFIG_PATH so cmake can find it" sure, "just" a little bit, right :P
20120709 22:52:37< anonymissimus> well but it worked anyway and I got no other dependency problems
20120709 22:59:57< timotei> night
20120709 22:59:58-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20120709 23:03:43< anonymissimus> timotei: okay, thanx for trying...so something with the MSVC release build seems wrong ? or with wesnoth since it worked in the past
20120709 23:10:07-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 240 seconds]
20120709 23:11:15-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection]
20120709 23:12:08-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120709 23:19:36-!- neph_ [~neph@80.233.231.12] has quit [Ping timeout: 252 seconds]
20120709 23:21:58-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120709 23:25:31-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer]
20120709 23:25:50-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120709 23:26:24-!- anakayub [~anakayub@175.143.199.46] has joined #wesnoth-dev
20120709 23:39:10< anonymissimus> timotei: interesting, my cmake+mscv release build works...this suggests a certain change in the project file may be the cause...
20120709 23:42:50-!- MeccaGod [majs@host189-199.bornet.net] has quit []
20120709 23:45:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
--- Log closed Tue Jul 10 00:00:20 2012