--- Log opened Sat Sep 15 00:00:35 2012
20120915 00:01:31-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has quit [Quit: ...]
20120915 00:02:04-!- janebot_ is now known as janebot
20120915 00:04:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120915 00:15:54< CIA-107> jamit * r55298 /trunk/src/ (tod_manager.cpp util.hpp): When multiple units illuminate a hex, use the strongest illumination, not merely the last one found.
20120915 00:33:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20120915 00:49:38-!- ancestral [~ancestral@75-168-42-97.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120915 00:50:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120915 00:50:38-!- ancestral [~ancestral@75-168-42-97.mpls.qwest.net] has joined #wesnoth-dev
20120915 00:50:53-!- ancestral [~ancestral@75-168-42-97.mpls.qwest.net] has quit [Client Quit]
20120915 00:59:08< CIA-107> jamit * r55299 /trunk/src/builder.cpp: Shorten some code. (No functional change, just easier to read.)
20120915 01:01:59-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 244 seconds]
20120915 01:24:35-!- prkc [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has quit [Ping timeout: 272 seconds]
20120915 01:32:09-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20120915 01:35:27< anonymissimus> jamit: re r55287, was that a reference to a temporary causing UB ?
20120915 01:36:13< jamit> Yes. The bug reporter even indicated that the behavior was different on Debian and Windows.
20120915 01:38:01< anonymissimus> but it was const
20120915 01:42:38< jamit> I don't know. It appears that for some reason it was binding to the wrong value on some compilers. And it's an int, so you aren't saving anything by having it be a reference.
20120915 01:43:31< anonymissimus> jamit: r55289 is nice one as well; 3 lines fix a fatal bug :)
20120915 01:43:33< shadowm> What does std::max/min return in that case, a reference?
20120915 01:43:58< shadowm> I remember there's a problem with const references being initialized using the ?: operator.
20120915 01:46:10< jamit> The nice thing about r55289 is that the "redo" version already was doing things in the right order, so it was only one place to fix. :)
20120915 01:46:50-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120915 01:48:52< anonymissimus> sounds like you could make the whole thing nicer by merging some code ?
20120915 01:49:52-!- wesbot changed the topic of #wesnoth-dev to: 185 bugs, 337 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120915 01:50:20< jamit> Possibly, but maybe not. The overlap for dismissing a recall is very small. The other redos might benefit from some merging though.
20120915 01:50:52< jamit> I may take a closer look at that later.
20120915 01:50:54-!- _vdn [~nazgul-sa@ppp91-77-232-65.pppoe.mtu-net.ru] has joined #wesnoth-dev
20120915 01:51:43< anonymissimus> awesome job, jamit!
20120915 01:51:57< jamit> Thanks.
20120915 01:52:08-!- _vdn [~nazgul-sa@ppp91-77-232-65.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer]
20120915 01:52:17-!- knotwork [~markm@142.68.86.202] has joined #wesnoth-dev
20120915 01:52:17-!- knotwork [~markm@142.68.86.202] has quit [Changing host]
20120915 01:52:17-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20120915 01:52:30< shadowm> Okay, std::min is implemented here using if instead of operator ?:, but to answer my question it returns a const reference.
20120915 01:53:00< shadowm> For whatever reason it has an ?: implementation commented out, though.
20120915 01:54:42< jamit> shadowm: what compiler/OS? The bug reporter was using gcc 4.7.1 on Debian.
20120915 01:55:09< shadowm> I was looking at libstdc++ 4.6 and 4.7 on Debian.
20120915 02:06:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120915 02:23:30< CIA-107> jamit * r55300 /trunk/ (5 files in 3 dirs): 
20120915 02:23:30< CIA-107> Add [terrain_type] max_light= and min_light=.
20120915 02:23:30< CIA-107> The defaults for these attributes fix bug #19250.
20120915 02:31:35-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 255 seconds]
20120915 02:39:04< AI0867> wesbot: bug #19250
20120915 02:39:05< wesbot> Bug #19250  Assigned to: J Tyne <jamit>  Status: Fixed  Priority: 5 - Normal
20120915 02:39:08< wesbot> Summary: Lit cave terrain gives cumulative bonus
20120915 02:39:10< wesbot> Original submission: If you put a lawful unit on a lit cave tile during the da
20120915 02:39:13< wesbot> y (so it can't be an underground map) you get a 50% bonus.  Curiously, putting a
20120915 02:39:16< wesbot> URL: https://gna.org/bugs/?19250
20120915 02:55:09-!- markus_ [~mjs-de@d184208.adsl.hansenet.de] has joined #wesnoth-dev
20120915 02:59:30-!- mjs-de [~mjs-de@f053189252.adsl.alicedsl.de] has quit [Ping timeout: 264 seconds]
20120915 03:13:53-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has joined #wesnoth-dev
20120915 03:16:00-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 11.0/20120312181643]]
20120915 03:31:03< fendrin> Hello
20120915 03:31:38< fendrin> shadowm: Are you in the mood to discuss some gui interface changes?
20120915 03:36:16-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20120915 03:48:31-!- markus_ [~mjs-de@d184208.adsl.hansenet.de] has quit [Quit: On the road again]
20120915 03:53:25-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has quit [Remote host closed the connection]
20120915 04:15:58-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has joined #wesnoth-dev
20120915 04:22:41-!- Smar [smar@dsl-hkibrasgw3-ff25c000-52.dhcp.inet.fi] has quit [Ping timeout: 240 seconds]
20120915 04:29:57-!- Smar [smar@dsl-hkibrasgw3-ff25c000-52.dhcp.inet.fi] has joined #wesnoth-dev
20120915 04:29:57-!- Smar [smar@dsl-hkibrasgw3-ff25c000-52.dhcp.inet.fi] has quit [Changing host]
20120915 04:29:57-!- Smar [smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev
20120915 04:41:50-!- Ivanovic_ [~ivanovic@dtmd-4d0bf786.pool.mediaWays.net] has joined #wesnoth-dev
20120915 04:44:01-!- ancestral [~ancestral@75-168-42-97.mpls.qwest.net] has joined #wesnoth-dev
20120915 04:45:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20120915 04:45:44-!- Ivanovic_ is now known as Ivanovic
20120915 04:50:27-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has quit [Remote host closed the connection]
20120915 05:05:34< shadowm> fendrin: I guess I'd be if the word 'mood' hadn't been mentioned in the first place, as though implying that anyone's 'mood' is relevant for discussing a hopefully objective matter.
20120915 05:06:48< shadowm> Whether I have time for that or not is different thing entirely. My availability is not guaranteed at any time unless I'm required to assist with an issue of immediate importance, such as a crashed database table.
20120915 05:08:44< shadowm> Generally speaking, it's better to ask me a more specific question.
20120915 05:16:41< fendrin> shadowm: I have a little patch witch binds unit selection to the left mouse button and unit movement/attacking to the right.
20120915 05:17:46< fendrin> If you select an empty hex the user interface highlights all units which are able to reach it.
20120915 05:18:21< fendrin> Right clicking on one of the highlighted units moves it to the selected location.
20120915 05:18:23< shadowm> Not my department, but I think one-button mouse users will be quite disappointed by the sudden complication of unit movements.
20120915 05:19:08< fendrin> There are still one-button mouse users left? I thought even apple ships with two button mice these days.
20120915 05:19:40< shadowm> I only know that the subject was discussed rather recently.
20120915 05:20:39< fendrin> shadowm: I see. Thank you for the information.
20120915 05:43:06< ancestral> FWIW, touch-enabled devices (phones, tablets) could also have issue with secondary clicks
20120915 06:44:57-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120915 07:03:24-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20120915 07:32:51-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120915 07:37:15-!- ancestral [~ancestral@75-168-42-97.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai]
20120915 07:49:52-!- wesbot changed the topic of #wesnoth-dev to: 184 bugs, 337 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120915 08:03:29-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer]
20120915 08:05:31-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120915 08:48:00-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev
20120915 09:17:55-!- SpoOkyMagician [~chatzilla@74-141-242-243.dhcp.insightbb.com] has joined #wesnoth-dev
20120915 09:26:55-!- MrBeast [~foo@pD95083A7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20120915 09:38:51-!- zookeeper [~lmsnie@87-100-211-108.bb.dnainternet.fi] has joined #wesnoth-dev
20120915 09:52:56-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120915 10:05:08-!- SpoOkyMagician [~chatzilla@74-141-242-243.dhcp.insightbb.com] has quit [Quit: .zZ]
20120915 10:07:33-!- Crendgrim is now known as Guest51104
20120915 10:23:31-!- Sapient [~sapient@wesnoth/developer/sapient] has joined #wesnoth-dev
20120915 10:24:12< Sapient> hi
20120915 10:28:28-!- Guest51104 is now known as Crendgrim
20120915 11:02:03-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120915 11:15:31-!- Crendgrim_ [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120915 11:16:45-!- Crendgrim_ [~crend@77-22-112-72-dynip.superkabel.de] has quit [Read error: Connection reset by peer]
20120915 11:17:07-!- Crendgrim_ [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120915 11:19:09-!- Crendgrim [~crend@77-22-112-72-dynip.superkabel.de] has quit [Ping timeout: 252 seconds]
20120915 11:28:26-!- crend [~crend@77-22-112-72-dynip.superkabel.de] has joined #wesnoth-dev
20120915 11:29:15-!- crend [~crend@77-22-112-72-dynip.superkabel.de] has quit [Client Quit]
20120915 11:30:09-!- Ivanovic [~ivanovic@dtmd-4d0bf786.pool.mediaWays.net] has quit [Changing host]
20120915 11:30:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120915 11:30:33< Ivanovic> hi Sapient
20120915 11:30:37< Ivanovic> nice to see you around!
20120915 11:30:48-!- zookeeper [~lmsnie@87-100-211-108.bb.dnainternet.fi] has quit [Changing host]
20120915 11:30:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120915 11:31:47-!- Crendgrim_ [~crend@77-22-112-72-dynip.superkabel.de] has quit [Ping timeout: 255 seconds]
20120915 11:51:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20120915 12:08:07-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go]
20120915 12:25:28< Sapient> hi Ivanovic 
20120915 12:26:44< Sapient> I guess not too many people are active at this time
20120915 12:31:12< Sapient> o_~  cya later
20120915 12:31:17-!- Sapient [~sapient@wesnoth/developer/sapient] has quit [Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204]]
20120915 12:35:59-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120915 12:41:08-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has joined #wesnoth-dev
20120915 12:47:03-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120915 13:02:20-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev
20120915 13:42:02-!- loonybot [~loonybot@46.138.72.79] has joined #wesnoth-dev
20120915 13:42:02-!- loonybot [~loonybot@46.138.72.79] has quit [Changing host]
20120915 13:42:02-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120915 14:12:35-!- mjs-de [~mjs-de@d184208.adsl.hansenet.de] has joined #wesnoth-dev
20120915 14:36:55-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120915 15:02:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120915 15:51:10-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go]
20120915 16:00:31-!- timotei [~timotei@188.24.2.172] has joined #wesnoth-dev
20120915 16:00:31-!- timotei [~timotei@188.24.2.172] has quit [Changing host]
20120915 16:00:32-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20120915 16:20:52-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120915 17:15:11-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Ping timeout: 252 seconds]
20120915 17:24:18-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120915 17:41:36-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has joined #wesnoth-dev
20120915 17:53:14-!- mjs-de [~mjs-de@d184208.adsl.hansenet.de] has quit [Remote host closed the connection]
20120915 17:57:28-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120915 18:09:10-!- oldtopman [~oldtopman@unaffiliated/oldtopman] has quit [Quit: *pouf*]
20120915 18:12:48-!- SeattleDad [~SeattleDa@50-46-117-63.evrt.wa.frontiernet.net] has joined #wesnoth-dev
20120915 18:13:39-!- Gambit [~gambit@pa-67-235-1-103.dhcp.embarqhsd.net] has joined #wesnoth-dev
20120915 18:13:40-!- Gambit [~gambit@pa-67-235-1-103.dhcp.embarqhsd.net] has quit [Changing host]
20120915 18:13:40-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120915 18:56:39-!- Samual_ is now known as DoNotDisturb
20120915 19:03:53-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-dev
20120915 19:08:41-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120915 19:11:43-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120915 19:14:12< Alarantalara> fendrin: Apple still sells one-button mice. They just allow them to function as two-button mice through software now.
20120915 19:18:43-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 272 seconds]
20120915 19:22:03< fendrin> Alarantalara: Yes, I have heard of that. Poor Apple users.
20120915 19:23:22< fendrin> Alarantalara: Although most touch screen devices will not benefit from a right click == movement solution. I am aware of the situation and thinking about a solution. Do you have any ideas?
20120915 19:26:12< Alarantalara> None that aren't excessively cumbersome.
20120915 19:27:54< fendrin> Alarantalara: My primary goal is to support unit movement from to a selected hex field, not necessarily the movement == right click thing. I just need an easy way to select a hex field without triggering a moveto. I had it working with the current behavior as well, it was just not handy to deselct the current unit before being able to select a hex field.
20120915 19:28:17< fendrin> s/from to/to
20120915 19:29:40-!- SeattleDad [~SeattleDa@50-46-117-63.evrt.wa.frontiernet.net] has quit [Ping timeout: 240 seconds]
20120915 19:30:17-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120915 19:31:00< zookeeper> so what are you going to do about the issue of your right-click movement thing being really confusing for anyone who doesn't know how it works?
20120915 19:32:09< fendrin> zookeeper: Updating the tutorial?
20120915 19:33:44< fendrin> zookeeper: Most modern games work this way nowadays, thus I don't really see the problem.
20120915 19:34:06< zookeeper> most modern games such as..?
20120915 19:34:14< lipkab> Settlers IV!!!
20120915 19:34:33< fendrin> Civilization5
20120915 19:34:33< lipkab> Well, it's not modern, but it works that way.
20120915 19:34:38< lipkab> And it's cute.
20120915 19:35:03< fendrin> Nearly all real-time strategy games do.
20120915 19:35:23< loonycyborg> fendrin: I've found that using RMB for moving units to be annoying in all games I played that had it.
20120915 19:35:23< fendrin> Civilization5 is also hex based.
20120915 19:35:35< loonycyborg> I like wesnoth way so much more.
20120915 19:35:49< zookeeper> wth. i played civ5 earlier this year, and in it i certainly didn't first choose the hex and then the unit.
20120915 19:35:53< Alarantalara> Most RTS games don't have context menus that appear on a right click
20120915 19:36:39< fendrin> loonycyborg: I plan to offer the old behavior as an option, to satisfy old school Wesnoth players.
20120915 19:37:12< zookeeper> how about offering your new behaviour as an option instead
20120915 19:37:26< fendrin> zookeeper: Sure, that is possible as well.
20120915 19:38:06< loonycyborg> Yeah. It'll probably interfere with context menu too.
20120915 19:38:27< fendrin> Alarantalara: Yes, but the new one is not hampering the right click context menu very much. Just deselect the unit/hex field and then the right click menu is working like expected.
20120915 19:39:17< fendrin> Alarantalara: I have played several scenarios now with the new thing and after a phase of learning I do not want to miss it anymore.
20120915 19:39:22< loonycyborg> What's the reason for using another mouse button for it, anyway?
20120915 19:39:52< fendrin> loonycyborg: There are several reasons, let me explain them in more detail please.
20120915 19:40:57< lipkab> boucman: Around?
20120915 19:41:38< fendrin> First, It is more error prove. It happens some times that I make a mistake when playing fast and instead of selecting another unit I move the currently selected on. Very bad if shroud fog was cleared or an event disallows undoing it.
20120915 19:42:48< fendrin> The new behavior makes sure that left clicking is for information gathering only. Nothing bad will happen as long as the right mouse button is not touched. I felt this as a great relief while playing, it makes me faster.
20120915 19:44:16< fendrin> Then, it is more easy to select a hex field with no unit standing on. Currently you need to deselect the current unit, otherwise it will move the unit there.
20120915 19:44:48< zookeeper> and seriously, you're implementing potentially confusing changes to the very core controls of the game without any sort of demand from more than maybe 1-2 veteran players.
20120915 19:45:28< loonycyborg> Yeah. That could be really bad surprise for a veteran player.
20120915 19:45:46< loonycyborg> Muscule memory and all that..
20120915 19:46:01< fendrin> You are kidding me. Humans are able to adapt if not, they should seek for professional help.
20120915 19:46:02< lipkab> Then it shall be an opt-in.
20120915 19:46:40< loonycyborg> Of course they are. But it takes time so people do it only if it's worth it.
20120915 19:47:05< fendrin> It is worth it.
20120915 19:47:37< fendrin> loonycyborg: Do you want to experiment with the thing? I can make a patch ready for you in only a few minutes.
20120915 19:48:49< zookeeper> unless you've noticed, your ideas are usually liked by a handful of people at most and very opposed by much more. no one just wants to argue about them forever.
20120915 19:49:06< jamit> Could there be a hotkey (or other preference) for "Action Click" -- choose either left or right mouse button (or maybe another mouse button) for issuing movement/attack commands?
20120915 19:49:32< fendrin> zookeeper: No, that is new to me.
20120915 19:50:11< loonycyborg> Why would you want to select a hex without a unit, anyway? It seems even impossible currently..
20120915 19:50:48< fendrin> loonycyborg: No it is not. The engine selects hex fields with no unit on it. The user interface does just not give any feedback on it.
20120915 19:51:42< fendrin> loonycyborg: Please read the post here: http://forums.wesnoth.org/viewtopic.php?p=537925#p537925
20120915 19:52:45< fendrin> zookeeper: Mostly my ideas are liked by a lots of players at the forum and only a few of the long term developers oppose against them.
20120915 19:56:52< loonycyborg> You better discuss it with real veteran players like Soliton or Doc Paterson, not wanabe like me.
20120915 19:57:16< loonycyborg> Though I don't consider your reasons to be very compelling.
20120915 19:59:14< fendrin> loonycyborg: How often do you know that you need to take the village or reach a certain hex field? It is a common problem in the game. Currently you need to click on every unit that could possibly reach the location and remember which is the best one for the job. The new interface makes this very easy. 
20120915 20:02:11< loonycyborg> You can just show reachable hexes on mouse over.
20120915 20:02:32< fendrin> loonycyborg: ?
20120915 20:02:39< loonycyborg> Like it's already done for hostile units.
20120915 20:03:23< fendrin> Still, you need to hover over every friendly unit see, and remember. 
20120915 20:03:45< fendrin> s/unit see,/unit, see 
20120915 20:04:49< jamit> fendrin: One problem with changing from one fixed control system to another is that there are always going to be people who prefer the one not in use.
20120915 20:05:08< jamit> fendrin: And typically, the ones who like a current system are not going to complain about a change until after the change is made, so a lack of opposition to before a change is made might not mean anything.
20120915 20:06:27< jamit> Some sort of configuration for mouse buttons might be a better approach.
20120915 20:07:53< fendrin> jamit: Sure, there is nothing wrong with a configuration tool. The whole point of the exercise is not the left/right click thing. It is the feature of selecting a hex field, seeing the units that can reach it and move one easily there.
20120915 20:08:13< jamit> Currently mouse buttons are used for: selection, action, context menu, scrolling, and cancel selection/menu. Anything else?
20120915 20:08:40< loonycyborg> fendrin: Those are two different issues. I suggest you to tackle them in isolation.
20120915 20:09:02< loonycyborg> That is right-left button vs reachability detection.
20120915 20:09:13< jamit> Well, for just the feature of selecting a hex field, you do not need to change the other clicks. Just make it so you have to deselect a unit first.
20120915 20:09:52< jamit> Not necessarily ideal, but it makes the feature available without messing with things more than necessary.
20120915 20:10:31< fendrin> loonycyborg: You are right, they are two different issues.
20120915 20:10:42< jamit> "deselect a unit first" -- if one was selected, of course.
20120915 20:11:22< loonycyborg> Pretty sure there are other ways to implement reachability detection than changing what mouse buttons do.
20120915 20:11:39-!- MrBeast [~foo@pD95083A7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20120915 20:14:16< fendrin> loonycyborg: Yes, but I would like to find a good solution, not only a suboptimal just because any change to the current gui is considered evil.
20120915 20:14:58< loonycyborg> That's just not 'any' change, but rather substantial one.
20120915 20:15:08< jamit> Go for the gold and lose it all....
20120915 20:17:00< fendrin> loonycyborg: You seem to ignore the error proffness of the new solution at all, alone this is worht the change.
20120915 20:18:04< jamit> There is no error-proofing involved in the ability to select a hex field.
20120915 20:19:11< fendrin> You do no more accidently move a unit while you wanted to select another one.
20120915 20:19:45< jamit> That is the right-left click thing, not the hex selection thing.
20120915 20:19:52< fendrin> Yes
20120915 20:20:48< jamit> So which issue do you think is more important? You seem to want the hex selection, yet your argument for it is that changing the meaning of clicks would be good.
20120915 20:20:55< fendrin> The concept of seperating selecting and action to different mouse buttons has become the standard in gaming for years now and there was a good reason behind it.
20120915 20:21:19< jamit> So do that first.
20120915 20:21:30-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120915 20:21:36< jamit> Or suggest that first.
20120915 20:22:18< loonycyborg> fendrin: The reason is to annoy me apparently.
20120915 20:22:46< loonycyborg> Games seem to be moving into gutter at full speed lately.
20120915 20:23:36-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120915 20:24:30< fendrin> loonycyborg: Why is it annoying you anyway? You just mentioned you don't like it. Maybe there is a point I can consider?
20120915 20:24:30-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has joined #wesnoth-dev
20120915 20:24:42< jamit> I think adding a preferences window for mouse button configuration might be helpful, then everyone could choose their controls. Do that first, then work on hex selection?
20120915 20:25:17< loonycyborg> It's just easier to move many units with a single button than with two.
20120915 20:25:38< fendrin> jamit: The hex selection is already finished. The screenshots in the thread are real ones, no fake involved.
20120915 20:25:59< loonycyborg> And all sane, non game apps have standardized to use RMB for conext menus.
20120915 20:27:12< jamit> So why do you insist on throwing in a change to how buttons work in addition to the hex selection? Those are two different issues. Tackling them in isolation makes sense to me.
20120915 20:28:04< fendrin> jamit: You are right.
20120915 20:28:24< jamit> Not that it would take long to implement the ability to configure mouse buttons. I think the hardest part (from my perspective) would be designing and implementing the way for the user to set the configuration.
20120915 20:29:10< jamit> As I recall, a few splits of existing functions could make it easy enough for the game to follow the configuration.
20120915 20:29:40< jamit> But still, a separate issue.
20120915 20:29:44< fendrin> jamit: And you are right again :-)
20120915 21:00:18-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has quit [Quit: Leaving.]
20120915 21:01:31< zookeeper> <fendrin> You do no more accidently move a unit while you wanted to select another one. <- yeah, but you accidentally move a unit when all you wanted to do is to open the context menu for it.
20120915 21:04:28< fendrin> zookeeper: Nope. You learn fast to be careful with the right mouse button. 
20120915 21:04:34< zookeeper> or more likely, you just wanted to get rid of the current unit selection
20120915 21:05:08< zookeeper> no one wants to have to learn fast just so you can have some kind of a random controls change
20120915 21:05:53< fendrin> Sure?
20120915 21:06:05< fendrin> I don't think so. 
20120915 21:06:30< loonycyborg> fendrin: You can learn fast to be careful with LMB too :P
20120915 21:06:52< fendrin> Yes, but that is not the same. I do not want to be careful when it comes to selection.
20120915 21:07:45< fendrin> Having all sorts of actions on one mouse button that needs to be careful with is a superior concept. 
20120915 21:08:44< loonycyborg> Actually there's MMB too. Why don't you make up a use for it instead of messing with LMB and RMB? :P
20120915 21:09:00< lipkab> Don't do that.
20120915 21:09:06< lipkab> I don't have MMB.
20120915 21:09:45< fendrin> loonycyborg: Because most modern mice have that clickable mouse wheel instead of the middle button. Wheel click is not a good idea for a often used function.
20120915 21:10:19< zookeeper> also you could make it work by holding LMB on a hex and then releasing it on a unit you want to move there. much less confusing, i'd imagine. although then the screen would turn mostly dark for a brief moment wheneve you click on an empty hex, so maybe not.
20120915 21:11:14< fendrin> zookeeper: That is more confusing in my opinion. That confusing argument is a very fishy one always, isn't it?
20120915 21:11:29< jamit> loonycyborg: MMB scrolls the map.
20120915 21:12:18< loonycyborg> jamit: Only scrolling does. The button can be pressed too :P
20120915 21:12:57< fendrin> loonycyborg: Yes, but most wheel clicks result in a scrolling event as well.
20120915 21:13:25< jamit> OK, I'll rephrase: MMB centers the map on the clicked location.
20120915 21:14:52< loonycyborg> It seems to move the selection in direction of clicked location.
20120915 21:15:02< loonycyborg> So it already has a use. Never mind then :)
20120915 21:18:28-!- un214 [~un214@adsl-63-205-9-149.dsl.scrm01.pacbell.net] has quit [Remote host closed the connection]
20120915 21:18:31< zookeeper> oh well. i don't mind it being in trunk assuming that it's still removable unless it's agreed to be a good thing universally enough.
20120915 21:21:14< loonycyborg> I still like the current approach of "LMB for moving, RMB for context menu". It's conceptually simpler.
20120915 21:23:13< fendrin> loonycyborg: That is a matter of the viewing point. Left mouse just selects is a simple concept. Right mouse click performs actions either by moving/attacking or via the context menu is simple as well or simple enough. I wish you would try my patch, maybe you fell in love with it by accident :-)
20120915 21:27:07< zookeeper> it's not so simple when the new concept is only an addition to the old one rather than replacing it.
20120915 21:27:08< loonycyborg> Unlikely. My RMB is failing right now. So I'd rather not even try it because it'll really screw my perspective.
20120915 21:27:40< fendrin> I see.
20120915 21:28:51< loonycyborg> (Maybe the RMB wasn't getting enough workout or something)
20120915 21:30:18< fendrin> loonycyborg: Hmmm, maybe that is the solution. I got an idea from your problem. Let me think for a minute and tell you.
20120915 21:32:45-!- SpoOkyMagician [~chatzilla@74-141-242-243.dhcp.insightbb.com] has joined #wesnoth-dev
20120915 21:33:05< fendrin> loonycyborg: Left mouse button moves/attacks. The right mouse button selects and brings up the context menu if clicked on an already selected unit.
20120915 21:33:46< fendrin> I will think about that some more.
20120915 21:34:28< loonycyborg> Having one button both for move and attack really reduces the cognitive overhead when moving lot of units IME.
20120915 21:34:41< loonycyborg> Move and select that is
20120915 21:35:19< fendrin> Are you sure? Or is it just years of practice?
20120915 21:36:25< loonycyborg> Wesnoth is just one of many games I've played. Some used RMB to move, some LMB.
20120915 21:36:47< loonycyborg> And LMB annoys me less.
20120915 21:37:50< fendrin> loonycyborg: Well, humans are different, no doubt. 
20120915 21:38:01< loonycyborg> IIRC my RMB megan failing after one game made me press it really often.
20120915 21:38:14< loonycyborg> So it appears that mice prefer LMB too :P
20120915 21:38:20< fendrin> :-)
20120915 21:38:28-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: Lost terminal]
20120915 21:38:50-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120915 21:45:25-!- iFuza [iFuza@usr-5-144-75-8.telix.ru] has joined #wesnoth-dev
20120915 21:46:29< iFuza> есть русские?
20120915 21:51:25< CIA-107> jamit * r55301 /trunk/src/dialogs.cpp: Reduce some overhead. (Use the new get_amla_unit() instead of get_advanced_unit() + extra processing.)
20120915 22:09:28 * Soliton notes that we have planning mode for people afraid of misclicks.
20120915 22:11:20< CIA-107> jamit * r55302 /trunk/src/actions/attack.cpp: 
20120915 22:11:20< CIA-107> Reorder some functions.
20120915 22:11:20< CIA-107> No code changes. Just grouping class functions together so that class
20120915 22:11:20< CIA-107> implementations are not intermingled with each other and with non-class
20120915 22:11:20< CIA-107> functions.
20120915 22:26:16< CIA-107> jamit * r55303 /trunk/src/actions/attack.cpp: 
20120915 22:26:16< CIA-107> Restrict the visibility of class attack to its own source file, and
20120915 22:26:16< CIA-107> use public/private designations instead of naming a friend function.
20120915 22:27:03< CIA-107> jamit * r55304 /trunk/src/actions/attack.cpp: Consistent indentation.
20120915 22:40:34-!- iFuza [iFuza@usr-5-144-75-8.telix.ru] has quit []
20120915 22:44:23-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go]
20120915 22:47:54< shadowm> boucman: Have you got time to look at bug #20099 ( https://gna.org/bugs/?20099 ) yet?
20120915 22:56:31-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer]
20120915 22:57:04-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120915 22:59:02< SpoOkyMagician> hey uh, i don't know if it's just me/my hearing but, could the turn bell sound be a bit higher in pitch/volume? i tent to never notice it because of how deep it is in tone.
20120915 22:59:47< shadowm> You can adjust the turn bell's volume in Preferences.
20120915 23:00:13< SpoOkyMagician> yeah its max.
20120915 23:00:19< SpoOkyMagician> its just the pitch IMO
20120915 23:00:22< SpoOkyMagician> its too low
20120915 23:00:44< SpoOkyMagician> a higher pitch would be noticed
20120915 23:01:11< SpoOkyMagician> if you dont wanna bother, i could replace it myself though
20120915 23:01:13< shadowm> And potentially kill my eardrums when using headphones.
20120915 23:01:34< SpoOkyMagician> i dont mean a high pitch. more like a medium
20120915 23:01:55 * vultraz remembers the complaints about the high-pitched wolf sounds
20120915 23:02:09< SpoOkyMagician> hm... true
20120915 23:02:17< SpoOkyMagician> well, ill just replace the sound then
20120915 23:03:21< SpoOkyMagician> actually, im gonna replace it with a drum-snare like sound.
20120915 23:03:25< SpoOkyMagician> would be better
20120915 23:04:13< SpoOkyMagician> or something
20120915 23:05:08< vultraz> maybe an actual bell sound?
20120915 23:05:24< SpoOkyMagician> true
20120915 23:05:30< SpoOkyMagician> fl studios has plenty of those
20120915 23:06:06< fendrin> Soliton: Yeah, but that planning mode never suited me. I would have vetoed the thing. Sadly I am only good enough to get vetoed but never asked about my opinion.
20120915 23:07:44< SpoOkyMagician> this sounds good
20120915 23:08:33< SpoOkyMagician> just need to find a good pitch
20120915 23:09:10< fendrin> Soliton: And I have good reasons for it. The Whiteboard is a horrible thing code wise. You need to code twice often, one version for the white board one for it being not in charge. Just look how it spoils the codebase.
20120915 23:10:14< zookeeper> SpoOkyMagician, yeah, i think the turn bell would be better if it wasn't so low-pitched
20120915 23:10:44< zookeeper> something with more mid frequencies would better catch your attention
20120915 23:10:48< SpoOkyMagician> this bell sounds good but its a bit long.
20120915 23:10:55< SpoOkyMagician> wanna hear it
20120915 23:11:16< SpoOkyMagician> (need to find somewhere to host)
20120915 23:11:34< zookeeper> http://www.hotfile.com/ isn't bad for temp hosting
20120915 23:11:42< vultraz> soundcloud?
20120915 23:12:40< SpoOkyMagician> have to sign up. eh, lemme use something else.
20120915 23:13:05< SpoOkyMagician> although, i can send files on here... is that ok?
20120915 23:13:16< SpoOkyMagician> directly to you
20120915 23:13:18< zookeeper> nah, dcc never works
20120915 23:13:22< SpoOkyMagician> oh
20120915 23:13:36< SpoOkyMagician> well, hm...
20120915 23:13:57< SpoOkyMagician> aim/msn?
20120915 23:13:59< SpoOkyMagician> skype?
20120915 23:14:12< zookeeper> what's wrong with hotfile?
20120915 23:14:12< SpoOkyMagician> or you using linux
20120915 23:14:23< SpoOkyMagician> eh fine ill just sign up
20120915 23:14:39< zookeeper> it doesn't require registration...
20120915 23:16:29< SpoOkyMagician> says it does
20120915 23:16:37< SpoOkyMagician> https://hotfile.com/dl/172280155/eefdfb0/bell.wav.html
20120915 23:17:00< SpoOkyMagician> wont let me upload otherwise
20120915 23:18:14< zookeeper> ohh. right, that's new then.
20120915 23:18:16< zookeeper> too bad
20120915 23:18:23< SpoOkyMagician> eh doesnt matter
20120915 23:18:30< SpoOkyMagician> ^ file above
20120915 23:18:49< zookeeper> but yes, something with frequencies somewhere halfway between that one and the current turn bell would be nice
20120915 23:19:08< zookeeper> maybe i should come up with a new sound
20120915 23:19:19< SpoOkyMagician> yeah i think a new one is needed
20120915 23:20:07< SpoOkyMagician> but thats at C6. i could go C5
20120915 23:20:49< SpoOkyMagician> or even any pitch
20120915 23:31:25-!- LordNasty [~NaSTy@93-43-163-192.ip92.fastwebnet.it] has quit [Ping timeout: 272 seconds]
20120915 23:32:01-!- LordNasty [~NaSTy@93-43-163-192.ip92.fastwebnet.it] has joined #wesnoth-dev
20120915 23:33:39-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20120915 23:38:06< zookeeper> SpoOkyMagician, well i think i'd rather have a bit more complex sound, like a more real-sounding bell of some kind, maybe with some other subtle sounds mixed in
20120915 23:38:35< SpoOkyMagician> yeah
20120915 23:38:57< SpoOkyMagician> i was thinking that as well
20120915 23:39:10< SpoOkyMagician> but i dunno what to use exactly
20120915 23:39:47< SpoOkyMagician> but this is the most realistic bell sound i found in FLS
20120915 23:40:45< SpoOkyMagician> if you wanna make something go ahead zookeeper. im gonna make a temp solution for my game anyway
20120915 23:41:09< zookeeper> i might
20120915 23:41:33< zookeeper> although we haven't had much complains from the current sound in all the time it's been in, so it can't be particularly bad either :p
20120915 23:42:09< SpoOkyMagician> the current one sounds decent. its just not high pitch enough... lemme try something.
20120915 23:42:38< SpoOkyMagician> whoops replaced it already
20120915 23:42:45< SpoOkyMagician> eh i got one in devel
20120915 23:44:05< SpoOkyMagician> tried to increase default pitch. doesnt sound right to me
20120915 23:44:22< SpoOkyMagician> sounds like hitting a trash can. lol
20120915 23:45:59< zookeeper> "change pitch" in audacity produces decent results
20120915 23:46:32< SpoOkyMagician> well, if it sounds "better" i suppose so
20120915 23:47:40< SpoOkyMagician> interesting... +200 pitch sounds good in FLS
20120915 23:48:03< SpoOkyMagician> maybe thats all thats needed
20120915 23:48:18< SpoOkyMagician> a pitch adjustment
20120915 23:50:34< SpoOkyMagician> in the meantime, ill use my bell though
20120915 23:50:49< zookeeper> hrhm. actually the current sound isn't as deep as i remembered.
20120915 23:52:11< SpoOkyMagician> might just be me. i have a bit bad hearing myself.
20120915 23:52:22< SpoOkyMagician> i listen to too much techno music.
20120915 23:52:24< SpoOkyMagician> :P
20120915 23:54:03< SpoOkyMagician> but my point in being higher in pitch would be like, just in case a player was afk
20120915 23:54:15< SpoOkyMagician> they have a better chance in hearing the sound.
20120915 23:54:37< SpoOkyMagician> but bad for if you use headphones
20120915 23:55:56< zookeeper> in any case, i'm too tired to think about that right now
20120915 23:56:04< SpoOkyMagician> ok
20120915 23:56:32< SpoOkyMagician> sounds good with my bell in game
20120915 23:56:38< SpoOkyMagician> but ill let you decide
20120915 23:56:41< SpoOkyMagician> when you have the time
--- Log closed Sun Sep 16 00:00:36 2012