--- Log opened Wed Sep 19 00:00:25 2012 20120919 00:02:59-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 252 seconds] 20120919 00:16:56-!- mjs-de [~mjs-de@g224178032.adsl.alicedsl.de] has quit [Remote host closed the connection] 20120919 00:39:38-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20120919 01:06:58-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 244 seconds] 20120919 01:16:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120919 02:14:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev --- Log opened Wed Sep 19 04:20:26 2012 20120919 04:26:12-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20120919 04:26:12-!- Topic for #wesnoth-dev: 185 bugs, 337 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120919 04:26:12-!- Topic set by wesbot [~wesbot@wesnoth/bot/wesbot] [Wed Sep 19 03:39:07 2012] 20120919 04:26:12[Users #wesnoth-dev] 20120919 04:26:12[ [Relic] ] [ elias ] [ iwaim_ ] [ shadowm ] 20120919 04:26:12[ AI0867 ] [ Elvish_Pillager] [ jamit ] [ shadowm_laptop] 20120919 04:26:12[ Akihara ] [ enchilado ] [ janebot ] [ shikadibot ] 20120919 04:26:12[ Anakonda ] [ Espreon ] [ knotwork ] [ Smar ] 20120919 04:26:12[ apoi ] [ fendrin ] [ leonid ] [ Tigge ] 20120919 04:26:12[ balrog ] [ Gallaecio ] [ lobby ] [ ToBeFree ] 20120919 04:26:12[ boucman_work ] [ Gambit ] [ loonycyborg] [ Upthorn ] 20120919 04:26:12[ CIA-108 ] [ happygrue ] [ melinath ] [ vultraz ] 20120919 04:26:12[ crimson_penguin] [ Ingmar ] [ mnewton1 ] [ wesbot ] 20120919 04:26:12[ csarmi_home ] [ isaac_ ] [ Rhonda ] [ yann ] 20120919 04:26:12[ ejls ] [ Ivanovic ] [ Samual ] [ {V} ] 20120919 04:26:12-!- Irssi: #wesnoth-dev: Total of 44 nicks [0 ops, 0 halfops, 0 voices, 44 normal] 20120919 04:26:22-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20120919 04:26:58-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev 20120919 04:27:19-!- Irssi: Join to #wesnoth-dev was synced in 77 secs 20120919 04:37:34-!- Ivanovic_ [~ivanovic@dtmd-4db2dccd.pool.mediaWays.net] has joined #wesnoth-dev 20120919 04:40:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds] 20120919 04:41:26-!- Ivanovic_ is now known as Ivanovic 20120919 04:57:16< CIA-108> jamit * r55318 /trunk/src/unit.hpp: Remove an unneeded friend declaration. 20120919 05:02:47-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has joined #wesnoth-dev 20120919 05:43:11-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection] 20120919 05:48:01< CIA-108> jamit * r55319 /trunk/src/unit_types.hpp: Remove the declaration of a non-existent function. 20120919 05:53:47-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120919 06:21:36< CIA-108> jamit * r55320 /trunk/src/unit_types.hpp: 20120919 06:21:36< CIA-108> Remove the non-const version of attack_type::get_cfg(). 20120919 06:21:36< CIA-108> It's not used and defeats the point of making cfg_ private. 20120919 06:38:37-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 252 seconds] 20120919 06:52:21< CIA-108> jamit * r55321 /trunk/src/unit_types.hpp: Change some fields and methods of attack_type from public to private. 20120919 06:52:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120919 07:28:46-!- CIA-108 [cia@cia.vc] has quit [Ping timeout: 244 seconds] 20120919 07:39:30-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20120919 07:44:30-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120919 07:57:49-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 252 seconds] 20120919 08:01:27-!- CIA-108 [cia@cia.vc] has joined #wesnoth-dev 20120919 08:03:10-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120919 08:15:21-!- Ivanovic [~ivanovic@dtmd-4db2dccd.pool.mediaWays.net] has quit [Changing host] 20120919 08:15:22-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120919 08:44:17-!- MrBeast [~foo@pD950879F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120919 08:52:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120919 08:52:25-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev 20120919 08:52:25-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host] 20120919 08:52:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120919 08:53:11-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 252 seconds] 20120919 08:58:44-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120919 09:43:19-!- Netsplit *.net <-> *.split quits: melinath 20120919 09:54:23-!- melinath [~melinath@li341-41.members.linode.com] has joined #wesnoth-dev 20120919 10:11:48-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20120919 10:25:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120919 10:41:28-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer] 20120919 10:45:29-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120919 10:49:59-!- Crendgrim [~crend@37-4-215-190-dynip.superkabel.de] has joined #wesnoth-dev 20120919 11:03:09-!- mjs-de [~mjs-de@d119008.adsl.hansenet.de] has joined #wesnoth-dev 20120919 11:04:27-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120919 11:06:17-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 252 seconds] 20120919 11:25:39-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120919 12:40:04-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev 20120919 12:47:11-!- leonid [~leonid@124.65.134.54] has quit [Ping timeout: 246 seconds] 20120919 13:22:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120919 13:28:01-!- MrBeast [~foo@pD950879F.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20120919 13:32:44-!- loonybot [~loonybot@46.138.72.79] has joined #wesnoth-dev 20120919 13:32:44-!- loonybot [~loonybot@46.138.72.79] has quit [Changing host] 20120919 13:32:44-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120919 13:56:23-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection] 20120919 13:58:54-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120919 14:01:20-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection] 20120919 14:03:41-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120919 14:05:46-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection] 20120919 14:08:23-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120919 14:42:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120919 14:46:16-!- Netsplit *.net <-> *.split quits: Gallaecio 20120919 14:47:35-!- leonid [~leonid@111.193.216.196] has joined #wesnoth-dev 20120919 14:47:56-!- Netsplit over, joins: Gallaecio 20120919 15:09:45-!- mattsc [~mattsc@216.123.55.165] has joined #wesnoth-dev 20120919 15:17:58-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Remote host closed the connection] 20120919 15:20:42-!- wesbot [~wesbot@wesnoth/bot/wesbot] has joined #wesnoth-dev 20120919 15:22:49-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has joined #wesnoth-dev 20120919 15:30:38-!- MrBeast [~foo@pD950879F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120919 15:41:42< CIA-108> jamit * r55323 /trunk/src/ (14 files in 4 dirs): 20120919 15:41:42< CIA-108> Do not always clear end_turn_ and hold_position_ in unit::set_movement(). 20120919 15:41:42< CIA-108> This allows the function to be called without side-effects, so it can be used 20120919 15:41:42< CIA-108> as a simple setter (as the name suggests). Since the previous behavior was 20120919 15:41:42< CIA-108> to have side-effects (which is bad style for a default), this commit 20120919 15:41:43< CIA-108> introduces a non-optional parameter, ensuring that I've looked at each place 20120919 15:41:44< CIA-108> where this function is called. 20120919 15:44:50< CIA-108> jamit * r55324 /trunk/src/ (5 files in 3 dirs): 20120919 15:44:50< CIA-108> Make the new parameter to unit::set_movement() optional, with the default to 20120919 15:44:50< CIA-108> not have side-effects (not the behavior before the parameter). 20120919 16:07:49-!- mattsc [~mattsc@216.123.55.165] has quit [Quit: bye] 20120919 16:30:59-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120919 16:33:07-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120919 16:45:47-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120919 16:47:24-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120919 17:55:51-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 252 seconds] 20120919 18:11:32-!- leonid [~leonid@111.193.216.196] has quit [Ping timeout: 248 seconds] 20120919 18:27:59< CIA-108> jamit * r55325 /trunk/src/ (unit.cpp unit.hpp): Adapt unit_movement_resetter so it no longer needs to access private fields of unit. 20120919 18:40:27< fendrin> jamit: hi 20120919 18:43:12< jamit> Hi fendrin 20120919 18:47:09< fendrin> jamit: I see you commiting like mad, I guess you didn't have any problems after my huge commit yesterday? 20120919 18:48:16-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120919 18:48:59< jamit> "Like mad"? :) I had compiled a list of things to clean up, and I had some time when I could let my computer do some long compiles to make sure each individual commit did not break compilation. So I ticked some things off the list. 20120919 18:49:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120919 18:49:42< jamit> No, no problems. 20120919 18:50:02< fendrin> cool :-) 20120919 18:50:59< jamit> Well, grain of salt: I did not specifically test any hotkeys. 20120919 18:52:35-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 268 seconds] 20120919 18:52:37< fendrin> jamit: Please do so, especially if you have a mouse with many additional keys. 20120919 18:53:48< jamit> Just two buttons plus a scroll wheel (usable as a third button). 20120919 18:54:13-!- ancestral [~ancestral@50-78-227-230-static.hfc.comcastbusiness.net] has joined #wesnoth-dev 20120919 18:56:56< fendrin> jamit: Oh, extra buttons begin above 7 buttons. 3 Normal ones including the press of the wheel, one for each mouse wheel direction (for in total if your wheel can do that right left thing). 20120919 18:57:09< fendrin> s/for/four 20120919 19:12:26-!- Upth [~ogmar@public-nat1.scc.losrios.edu] has joined #wesnoth-dev 20120919 19:12:26-!- Upth is now known as Upthorn 20120919 19:19:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120919 19:31:54-!- ancestral [~ancestral@50-78-227-230-static.hfc.comcastbusiness.net] has quit [Quit: i go sleeps kthxbai] 20120919 19:34:16-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120919 19:46:14< fendrin> boucman: Hello 20120919 19:54:43-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120919 20:01:42< CIA-108> mordante * r55326 /trunk/src/hotkeys.cpp: Fix a compiler warning. 20120919 20:19:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120919 20:46:38-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev 20120919 20:50:09-!- Upthorn [~ogmar@public-nat1.scc.losrios.edu] has quit [Ping timeout: 244 seconds] 20120919 21:07:38< CIA-108> jamit * r55327 /trunk/src/ (mouse_events.cpp whiteboard/move.cpp unit.cpp unit.hpp): 20120919 21:07:38< CIA-108> Give temporary_unit_mover the ability to set a unit's remaining moves as well as its position. 20120919 21:07:38< CIA-108> Gabba: This change may make a pair of whiteboard debugging messages superfluous, but I left 20120919 21:07:38< CIA-108> them in just in case. If they are not needed, someone may want to remove them. 20120919 21:12:11-!- Crendgrim [~crend@37-4-215-190-dynip.superkabel.de] has quit [Quit: Konversation terminated!] 20120919 21:26:26-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go] 20120919 21:43:18-!- SirBeast [~foo@pD950AAF2.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120919 21:44:12-!- MrBeast [~foo@pD950879F.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 20120919 22:20:11-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev 20120919 22:20:11-!- Upth is now known as Upthorn 20120919 22:27:29-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye] 20120919 22:32:22-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has joined #wesnoth-dev 20120919 22:37:29-!- SirBeast [~foo@pD950AAF2.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20120919 22:38:18< CIA-108> jamit * r55328 /trunk/src/whiteboard/move.cpp: 20120919 22:38:18< CIA-108> Suppress some processing when not debugging the whiteboard. 20120919 22:38:18< CIA-108> (This is for one of the debugging messages that might be superfluous now.) 20120919 22:39:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20120919 22:53:19-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has quit [Ping timeout: 245 seconds] 20120919 22:56:09< CIA-108> jamit * r55329 /trunk/src/whiteboard/move.cpp: Safer use of temporary_unit_mover. 20120919 23:06:52< CIA-108> jamit * r55330 /trunk/src/unit.cpp: Better handling of a corner case for temporary_unit_mover. 20120919 23:16:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120919 23:29:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120919 23:42:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120919 23:43:55-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120919 23:45:18-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 244 seconds] --- Log closed Thu Sep 20 00:00:18 2012