--- Log opened Thu Sep 20 00:00:18 2012 20120920 00:33:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.] 20120920 00:34:18< CIA-108> jamit * r55331 /trunk/src/ (unit.cpp unit.hpp): 20120920 00:34:18< CIA-108> Better way for temporary_unit_mover to change movement. 20120920 00:34:18< CIA-108> (It now handles negative movement the same way unit::set_movement() would.) 20120920 01:18:49< CIA-108> jamit * r55332 /trunk/src/ai/testing/aspect_attacks.cpp: 20120920 01:18:49< CIA-108> A slightly faster test for backstab and slow. 20120920 01:18:49< CIA-108> The previous version already did an imperfect test for UMC versions of these 20120920 01:18:49< CIA-108> specials (by ignoring some filters; mainline units have no filters anyway) 20120920 01:18:49< CIA-108> in order to increase performance. This version ignores all filters for a 20120920 01:18:49< CIA-108> larger performance boost. 20120920 01:26:17-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 245 seconds] 20120920 01:40:11< CIA-108> jamit * r55333 /trunk/src/sdl_utils.cpp: English convention: space after the colon. 20120920 01:42:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120920 01:49:35-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 02:01:21-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120920 02:07:19-!- Elvish_Pillager [~eli@137.146.144.218] has joined #wesnoth-dev 20120920 02:07:47-!- mjs-de [~mjs-de@d119008.adsl.hansenet.de] has quit [Remote host closed the connection] 20120920 02:09:24-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has joined #wesnoth-dev 20120920 02:15:42-!- Elvish_Pillager [~eli@137.146.144.218] has quit [Ping timeout: 264 seconds] 20120920 02:34:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 02:52:54-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev 20120920 02:54:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120920 03:06:16-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 244 seconds] 20120920 03:10:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 03:20:38-!- wesbot changed the topic of #wesnoth-dev to: 186 bugs, 337 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120920 03:23:41-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120920 03:28:44-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Ping timeout: 268 seconds] 20120920 03:48:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120920 03:49:33-!- leonid [~leonid@124.65.134.54] has joined #wesnoth-dev 20120920 03:51:37-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has joined #wesnoth-dev 20120920 03:52:00-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120920 04:04:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 04:36:19-!- Ivanovic_ [~ivanovic@dtmd-4db2ccc4.pool.mediaWays.net] has joined #wesnoth-dev 20120920 04:36:19-!- Ivanovic_ [~ivanovic@dtmd-4db2ccc4.pool.mediaWays.net] has quit [Changing host] 20120920 04:36:19-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20120920 04:40:30-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds] 20120920 04:42:16-!- Ivanovic_ is now known as Ivanovic 20120920 04:43:01-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Ping timeout: 260 seconds] 20120920 04:43:55-!- leonid [~leonid@124.65.134.54] has quit [Remote host closed the connection] 20120920 05:28:39-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20120920 06:34:04-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev 20120920 07:00:46-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120920 07:21:56-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 07:22:04-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120920 07:25:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120920 07:44:09-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has joined #wesnoth-dev 20120920 07:56:56-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20120920 08:31:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20120920 08:41:59-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120920 08:45:25-!- MrBeast [~foo@pD9508A3D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120920 09:04:14-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer] 20120920 09:13:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120920 09:28:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120920 09:50:18-!- boucman_work [~jerermy@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20120920 10:02:36-!- ancestral [~ancestral@65-128-227-213.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120920 10:03:24-!- MrBeast [~foo@pD9508A3D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20120920 10:06:07-!- boucman_work [~jerermy@wesnoth/developer/boucman] has joined #wesnoth-dev 20120920 10:36:18-!- Upthorn [~ogmar@69.62.144.56] has quit [Ping timeout: 244 seconds] 20120920 10:49:42-!- mjs-de [~mjs-de@g224177194.adsl.alicedsl.de] has joined #wesnoth-dev 20120920 11:17:00-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120920 11:48:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120920 12:53:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120920 13:05:47-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20120920 13:22:20-!- jerermy_ [~jerermy@193.56.60.160] has joined #wesnoth-dev 20120920 13:25:34-!- boucman_work [~jerermy@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds] 20120920 13:32:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 13:49:26-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120920 14:26:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120920 14:44:56-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev 20120920 14:46:47-!- jerermy_ is now known as boucman_work 20120920 14:46:59-!- boucman_work [~jerermy@193.56.60.160] has quit [Changing host] 20120920 14:47:00-!- boucman_work [~jerermy@wesnoth/developer/boucman] has joined #wesnoth-dev 20120920 14:55:16< CIA-108> jamit * r55334 /trunk/src/ (unit_types.hpp unit_types.cpp unit_abilities.cpp): Add some documentation and give some parameters more descriptive names. 20120920 15:05:51-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: No route to host] 20120920 15:09:49-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120920 15:10:15< CIA-108> jamit * r55335 /trunk/src/unit_types.hpp: Restore a comment that was (presumably accidentally) half-deleted in r10989. 20120920 15:19:31-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev 20120920 15:19:31-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host] 20120920 15:19:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120920 15:20:38-!- wesbot changed the topic of #wesnoth-dev to: 186 bugs, 338 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120920 15:48:02-!- MrBeast [~foo@pD9508A3D.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120920 16:14:41-!- boucman_work [~jerermy@wesnoth/developer/boucman] has quit [Ping timeout: 256 seconds] 20120920 16:18:14-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 16:26:47-!- boucman_work [~jerermy@wesnoth/developer/boucman] has joined #wesnoth-dev 20120920 16:27:38-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has joined #wesnoth-dev 20120920 16:38:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 16:43:53-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev 20120920 16:45:32-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Quit: ChatZilla 0.9.88.2 [Firefox 14.0.1/20120713224749]] 20120920 16:45:57-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20120920 16:46:41-!- esr [~chatzilla@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20120920 16:46:41-!- esr [~chatzilla@wesnoth/developer/esr] has joined #wesnoth-dev 20120920 16:46:52-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120920 16:56:22< AI0867> fendrin: cleared hotkeys aren't actually deleted, so you get a lot of __none__ hotkeys in your preferences 20120920 17:06:55-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev 20120920 17:06:55-!- Upth is now known as Upthorn 20120920 17:08:17< AI0867> wesnothd sends invalid WML (just a single key, lacking a node) as a response if it does not accept the client's version and doesn't a good [redirect] for it 20120920 17:08:44< AI0867> I doubt anything depends on this behaviour, but correct me if I'm wrong 20120920 17:10:57< CIA-108> jamit * r55336 /trunk/src/ (unit_types.hpp unit_abilities.cpp): Convert two private member functions to static non-member functions. 20120920 17:13:23-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120920 17:14:39-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 17:38:44-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye] 20120920 18:20:05< AI0867> okay, looks like the client actually uses it 20120920 18:20:34< AI0867> this code hasn't changed since 2005 20120920 18:21:49< AI0867> the bare version key is marked as being for backwards compatibility, but besides [redirect], there is no fallback 20120920 18:22:56-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds] 20120920 18:34:23-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev 20120920 18:50:12< fendrin> AI0867: hello 20120920 18:52:11< AI0867> fendrin: hey 20120920 18:54:29< fendrin> AI0867: Ah yes. Now I got it. 20120920 18:55:20< fendrin> AI0867: The saved preferences file contains that __none__ keys which can't be recognized thus you get error messages on the commandline. 20120920 18:55:35< fendrin> AI0867: Did you also spot problems with the gameplay? 20120920 18:57:18< AI0867> didn't see any error messages on stderr, but I did see lots of commas in my hotkey list 20120920 18:57:34< AI0867> haven't actually done any gameplay =P 20120920 18:58:24< fendrin> AI0867: Ah, okay. I don't get any commas, is your operating system a linux= 20120920 18:58:27< fendrin> ? 20120920 19:00:42< fendrin> AI0867: Okay, stupid me. I learned how to reproduce the behavior. 20120920 19:01:33< fendrin> AI0867: I won't fix the issue with the dialog but commit a new one that is no longer a window of its own. 20120920 19:07:30< AI0867> ? 20120920 19:07:45< AI0867> the dialog is a symptom, not the problem 20120920 19:10:14< fendrin> Yes, the problem is in hotkeys.cpp. 20120920 19:10:14< fendrin> If you want to get rid of them in the savefile. 20120920 19:21:57-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20120920 19:21:57-!- Topic for #wesnoth-dev: 186 bugs, 338 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120920 19:21:57-!- Topic set by wesbot [~wesbot@wesnoth/bot/wesbot] [Thu Sep 20 15:20:37 2012] 20120920 19:21:57[Users #wesnoth-dev] 20120920 19:21:57[ AI0867 ] [ enchilado] [ lobby ] [ Soliton ] 20120920 19:21:57[ Akihara ] [ Espreon ] [ loonybot ] [ stikonas ] 20120920 19:21:57[ Anakonda ] [ esr ] [ loonycyborg] [ Tigge ] 20120920 19:21:57[ apoi ] [ fendrin ] [ melinath ] [ timotei ] 20120920 19:21:57[ balrog ] [ Gallaecio] [ mjs-de ] [ ToBeFree ] 20120920 19:21:57[ boucman_work ] [ happygrue] [ mnewton1 ] [ Upthorn ] 20120920 19:21:57[ CIA-108 ] [ Ingmar ] [ MrBeast ] [ vultraz ] 20120920 19:21:57[ crimson_penguin] [ isaac_ ] [ negusnyul ] [ wesbot ] 20120920 19:21:57[ csarmi_home ] [ Ivanovic ] [ Rhonda ] [ yann ] 20120920 19:21:57[ EdB ] [ iwaim_ ] [ Samual ] [ zookeeper] 20120920 19:21:57[ ejls ] [ jamit ] [ shadowm ] [ {V} ] 20120920 19:21:57[ elias ] [ janebot ] [ shikadibot ] 20120920 19:21:57[ Elvish_Pillager] [ knotwork ] [ Smar ] 20120920 19:21:57-!- Irssi: #wesnoth-dev: Total of 50 nicks [0 ops, 0 halfops, 0 voices, 50 normal] 20120920 19:22:04-!- Channel #wesnoth-dev created Tue Jan 27 06:28:41 2009 20120920 19:23:06-!- Irssi: Join to #wesnoth-dev was synced in 80 secs 20120920 19:23:35< fendrin> AI0867: Yes, I don't know much about multiplayer. I don't even get how those things are related. 20120920 19:24:35< fendrin> AI0867: I would love if you take the time and explain a little further. 20120920 19:24:39< fendrin> please 20120920 19:25:02< AI0867> they aren't 20120920 19:25:19< AI0867> I was looking into the protocol between wesnoth and wesnothd 20120920 19:27:15< fendrin> You talked not to me. I need to get a coffee. 20120920 19:27:31< fendrin> :-) 20120920 19:28:34< AI0867> you need coffee *now*? Your sleep schedule may be worse than mine 20120920 19:29:59< CIA-108> ai0867 * r55337 /trunk/src/server/server.cpp: Explicitly [reject] clients we don't know what to do with, while sending them the full list of versions we do accept 20120920 19:30:00< CIA-108> ai0867 * r55338 /trunk/src/multiplayer.cpp: Add client support for [reject] 20120920 19:30:01< AI0867> if you're still interested ^ 20120920 19:31:46< fendrin> AI0867: Does that mean the player gets actually a useful error message? Like: "The server needs at lest version blah but you use blah -5! 20120920 19:32:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 19:32:48< fendrin> hi noy 20120920 19:34:10< AI0867> it tried to already do that, but to a very limited degree 20120920 19:34:52< AI0867> if you have two different wesnoth versions on the same machine, you can test it by running wesnothd in one (no arguments needed) and wesnoth -s localhost in the other 20120920 19:35:08< AI0867> if you don't, you'll need to write a tiny config file for wesnothd 20120920 19:46:57-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!] 20120920 19:52:03< fendrin> AI0867: I am going to test it. 20120920 19:54:18< fendrin> AI0867: Wich version must be the newer one? server or clie3nt? 20120920 20:02:51-!- csarmi [csarmi@94-21-80-118.pool.digikabel.hu] has joined #wesnoth-dev 20120920 20:05:24-!- csarmi_home [csarmi@85-238-89-123.pool.digikabel.hu] has quit [Ping timeout: 256 seconds] 20120920 20:15:33< CIA-108> fendrin * r55339 /trunk/src/hotkeys.cpp: 20120920 20:15:33< CIA-108> Handle cleared commands better. 20120920 20:15:33< CIA-108> Hide the "copy selected hex fields to clipboard" hotkey. 20120920 20:15:55< fendrin> AI0867:^ 20120920 20:45:39< AI0867> either one works 20120920 20:46:01< AI0867> as long as their version is not the same, they won't work together by default 20120920 20:46:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120920 20:52:53< CIA-108> jamit * r55340 /trunk/src/ (unit_types.hpp unit_abilities.cpp): Simplify the logic in attack_type::special_active(). 20120920 20:52:57< Soliton> AI0867: those changes are backwards compatible, right? i.e. an old client connecting still understands the reply? 20120920 20:54:56< AI0867> yes 20120920 20:54:59< AI0867> I only added to it 20120920 20:55:13< AI0867> and clients will also still understand old servers 20120920 20:55:24< Soliton> excellent. 20120920 20:55:41< AI0867> but maybe, in 3 years or so, we can make the server responses into valid WML ;) 20120920 20:58:15< Soliton> top level keys are not valid? 20120920 21:05:37-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120920 21:07:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 264 seconds] 20120920 21:11:03-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120920 21:14:10-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has quit [Remote host closed the connection] 20120920 21:16:34-!- Gallaecio [~quassel@84.120.114.134.dyn.user.ono.com] has joined #wesnoth-dev 20120920 21:28:36-!- lipk [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120920 21:31:56-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 244 seconds] 20120920 21:34:16-!- lipk is now known as lipkab 20120920 21:34:34< AI0867> according to some specs, there are only top-level tags 20120920 21:35:32-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120920 21:38:26-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 21:41:43-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has quit [Quit: Konversation terminated!] 20120920 21:43:45-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go] 20120920 21:53:39-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120920 22:09:28-!- Rhonda [~rhonda@86.59.21.37] has quit [Changing host] 20120920 22:09:29-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20120920 22:26:15< Soliton> the preferences file is not valid WML either then. seems unnecessarily strict. 20120920 22:44:09< CIA-108> jamit * r55341 /trunk/src/unit_abilities.cpp: Eliminate some overhead that was used to sometimes avoid a single string comparison. 20120920 22:48:36-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20120920 23:01:00< jamit> fendrin: If you clear a hotkey, an almost-empty tag (contains just the command= attribute) gets written to the preferences file. Not a big deal since it gets erased eventually (when going back into the hotkey window?), but it's still something not quite working right. 20120920 23:06:28-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn] 20120920 23:11:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20120920 23:21:35-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev 20120920 23:22:43< fendrin> jamit: You mean the file contains temporarily the hotkey tag with just command? 20120920 23:30:52< fendrin> jamit: Can you be more specific and tell me the value of the command attribute? 20120920 23:31:14< fendrin> Or is it for every cleared hotkey item? 20120920 23:41:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120920 23:44:12-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 252 seconds] 20120920 23:50:28< jamit> fendrin, right. In my file, I see (spread across multiple lines, obviously): [hotkey] command="animatemap" [/hotkey] 20120920 23:51:36< jamit> It happened for all the commands I tested, but I did not test that many. I was sticking to commands that did not have a hotkey by default (since it's easier to undo everything in that case). 20120920 23:54:17< fendrin> jamit: Thank you. I will have a look at it. 20120920 23:56:15< fendrin> Isn't a continue in a switch case continuing the outer for loop? --- Log closed Fri Sep 21 00:00:18 2012