--- Log opened Sun Sep 23 00:00:18 2012
20120923 00:04:09< Ivanovic> boucman: have you tried mailing him?
20120923 00:04:25< boucman> yeah
20120923 00:06:41-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has quit [Ping timeout: 260 seconds]
20120923 00:11:21-!- enchilado is now known as enchilado|status
20120923 00:11:59-!- enchilado|status is now known as enchilado
20120923 00:15:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120923 00:18:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20120923 01:07:58< CIA-108> alarantalara * r55360 /trunk/data/campaigns/Under_the_Burning_Suns/images/units/monsters/ (11 files): Remove redundant images. Fixes bug #20192
20120923 01:09:11-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-dev
20120923 01:39:00-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 248 seconds]
20120923 01:41:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120923 01:45:17-!- MrBeast [~foo@pD950A301.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20120923 01:53:43-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev
20120923 01:58:09-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 256 seconds]
20120923 02:05:15-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev
20120923 02:10:37-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 256 seconds]
20120923 02:16:24-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has quit [Quit: bye]
20120923 02:41:19-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20120923 03:09:22< CIA-108> ai0867 * r55361 /trunk/utils/wmlxgettext: Have wmlxgettext die when it encounters an empty translatable string
20120923 03:09:22< CIA-108> ai0867 * r55362 /trunk/utils/generate_git_tags.sh: Script to generate git tags for svn tags
20120923 03:14:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120923 03:20:39-!- wesbot changed the topic of #wesnoth-dev to: 187 bugs, 338 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120923 03:24:01-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 246 seconds]
20120923 03:25:51< CIA-108> ai0867 * r55363 /trunk/data/tools/wesnoth/campaignserver_client.py: Turn the mix of signed int and signed long into unsigned int
20120923 04:04:58-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-dev
20120923 04:16:33-!- Valk [9c0c6848@gateway/web/freenode/ip.156.12.104.72] has joined #wesnoth-dev
20120923 04:32:53-!- Ivanovic_ [~ivanovic@dtmd-4db27339.pool.mediaWays.net] has joined #wesnoth-dev
20120923 04:36:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 265 seconds]
20120923 04:36:43-!- Valk [9c0c6848@gateway/web/freenode/ip.156.12.104.72] has left #wesnoth-dev []
20120923 04:36:46-!- Ivanovic_ is now known as Ivanovic
20120923 05:00:56-!- jamit [~jamit@pool-173-61-162-52.cmdnnj.east.verizon.net] has joined #wesnoth-dev
20120923 05:31:09-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has quit [Quit: bye]
20120923 05:43:46-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit []
20120923 06:08:28-!- csarmi [~csarmi@host-88-132-150-133.prtelecom.hu] has joined #wesnoth-dev
20120923 06:17:50-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120923 07:16:57-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20120923 07:16:57-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20120923 07:16:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120923 07:34:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20120923 08:25:12-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20120923 08:26:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120923 08:30:32-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev
20120923 08:52:33-!- Netsplit *.net <-> *.split quits: melinath
20120923 09:04:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20120923 09:10:14-!- Netsplit over, joins: melinath
20120923 09:25:50-!- Ivanovic [~ivanovic@dtmd-4db27339.pool.mediaWays.net] has quit [Changing host]
20120923 09:25:50-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20120923 10:07:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20120923 10:41:54-!- lipkab [~lipk@apn-89-223-156-224.vodafone.hu] has joined #wesnoth-dev
20120923 10:49:47-!- negusnyul [~negusnyul@h45-129.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20120923 10:59:37-!- mjs-de [~mjs-de@p3EE2221E.dip.t-dialin.net] has joined #wesnoth-dev
20120923 11:39:03< CIA-108> fendrin * r55364 /trunk/src/widgets/menu.cpp: 
20120923 11:39:04< CIA-108> Fix the gui1 menu displaying the wrong help when the list got sorted.
20120923 11:39:04< CIA-108> Avoid drawing the help when the menu is hidden.
20120923 11:39:17< fendrin> shadowm: ^ Didn't you once complain about this bug?
20120923 12:12:56-!- Artemius23 [~Artemius2@139.179.207.173] has joined #wesnoth-dev
20120923 12:13:15-!- Artemius23 [~Artemius2@139.179.207.173] has quit [Client Quit]
20120923 12:13:29-!- Artemius23 [~Artemius2@139.179.207.173] has joined #wesnoth-dev
20120923 12:13:39-!- negusnyul [~negusnyul@h45-129.pool95-168.dyn.tolna.net] has quit [Read error: Operation timed out]
20120923 12:22:37-!- Artemius23 [~Artemius2@139.179.207.173] has quit [Ping timeout: 260 seconds]
20120923 12:42:04-!- negusnyul [~negusnyul@h45-129.pool95-168.dyn.tolna.net] has joined #wesnoth-dev
20120923 12:45:51-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!]
20120923 13:19:40-!- lipkab [~lipk@apn-89-223-156-224.vodafone.hu] has quit [Quit: And away we go]
20120923 13:21:25-!- negusnyul [~negusnyul@h45-129.pool95-168.dyn.tolna.net] has quit [Ping timeout: 246 seconds]
20120923 13:44:53-!- Elvish_Pillager [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev
20120923 13:49:22-!- Crendgrim [~crend@37-4-215-190-dynip.superkabel.de] has joined #wesnoth-dev
20120923 13:54:22-!- fendrin_ [~fabi@88-134-46-58-dynip.superkabel.de] has joined #wesnoth-dev
20120923 13:58:44-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20120923 14:15:59-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has joined #wesnoth-dev
20120923 14:17:05-!- markus__ [~mjs-de@p3EE23637.dip.t-dialin.net] has joined #wesnoth-dev
20120923 14:19:55-!- mjs-de [~mjs-de@p3EE2221E.dip.t-dialin.net] has quit [Ping timeout: 246 seconds]
20120923 14:27:04-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120923 14:37:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120923 14:47:09-!- lipkab [~lipk@apn-89-223-156-224.vodafone.hu] has joined #wesnoth-dev
20120923 14:57:40-!- lipkab [~lipk@apn-89-223-156-224.vodafone.hu] has quit [Ping timeout: 246 seconds]
20120923 15:01:40-!- loonybot [~loonybot@46.138.72.79] has joined #wesnoth-dev
20120923 15:01:40-!- loonybot [~loonybot@46.138.72.79] has quit [Changing host]
20120923 15:01:40-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20120923 15:33:20-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20120923 15:59:17-!- MrBeast [~foo@pD950AA01.dip0.t-ipconnect.de] has joined #wesnoth-dev
20120923 16:04:18-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 264 seconds]
20120923 16:16:33-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-dev
20120923 16:31:58-!- markus__ [~mjs-de@p3EE23637.dip.t-dialin.net] has quit [Remote host closed the connection]
20120923 17:50:26-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20120923 17:59:17-!- lipkab [~lipk@91.147.212.174] has joined #wesnoth-dev
20120923 18:03:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20120923 18:04:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20120923 18:05:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20120923 18:07:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20120923 18:11:01-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev
20120923 18:12:50-!- lipkab [~lipk@91.147.212.174] has quit [Quit: And away we go]
20120923 18:17:35-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20120923 18:17:36-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20120923 18:17:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120923 18:19:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120923 18:50:38-!- stikonas_ [~gentoo@5.20.200.50] has joined #wesnoth-dev
20120923 18:50:38-!- stikonas_ [~gentoo@5.20.200.50] has quit [Changing host]
20120923 18:50:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120923 18:50:59-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20120923 18:53:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20120923 19:00:35-!- MrBeast [~foo@pD950AA01.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20120923 19:01:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20120923 19:03:26-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20120923 19:03:26-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20120923 19:03:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20120923 19:40:54< fendrin_> loonycyborg: Hello, do you know what must in the header of a new c++ file. I fear to mess up that svn info string. shadowm once pointed me to a template but I can't find it anymore.
20120923 19:41:04< fendrin_> ?
20120923 19:43:53< loonycyborg> fendrin_: I just copy/pasted from other wesnoth sources.
20120923 19:46:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120923 19:47:34< fendrin_> loonycyborg: Okay, nice. Would you be so kind and run a test after my next commit? 
20120923 19:49:06< loonycyborg> Since I'm using git-svn that svn info thing doesn't really work for me :P
20120923 19:49:13< loonycyborg> I just see /* $Id$ */
20120923 19:49:23-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20120923 19:50:00-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20120923 19:50:23< loonycyborg> So when adding new sources I just copy the id thing, then copyright header modifying it appropriately
20120923 19:50:23< fendrin_> Oh
20120923 19:50:44< loonycyborg> and then add include guard if it's a .hpp file.
20120923 19:51:18< fendrin_> I only add a cpp file.
20120923 19:51:35< AI0867> $Id$ is enough for the svn stuff
20120923 19:51:42< AI0867> as long as you set the right svn property
20120923 19:52:00< fendrin_> Even more black magic.
20120923 19:52:06< AI0867> yeah =P
20120923 19:52:21< AI0867> svn:keywords should be set to... something
20120923 19:52:35< AI0867> svn propget svn:keyword(s?) another file to find out
20120923 19:52:39< fendrin_> That is not a evn var?
20120923 19:52:44< fendrin_> okay
20120923 19:52:53< AI0867> or svn proplist -v
20120923 19:53:07< AI0867> I can't do it for you as I don't have an svn checkout here
20120923 19:54:34< fendrin_> the revision-stamp thing?
20120923 19:55:27< AI0867> what does svn proplist -v src/whatever.cpp output?
20120923 19:56:17< jamit> fendrin_: boilerplate-header.cpp
20120923 19:56:20< fendrin_> AI0867: http://pastebin.com/EgmEZG1P
20120923 19:56:34< fendrin_> jamit: cool, thanks :-)
20120923 19:58:44< AI0867> fendrin_: well, then do svn propset svn:keywords "Author Date Id Revision" src/foo.cpp
20120923 19:58:56< AI0867> and svn propset svn:eol-style native src/foo.cpp
20120923 19:59:27< fendrin_> Id?
20120923 19:59:54< fendrin_> the filename
20120923 20:02:11< AI0867> ?
20120923 20:02:26< AI0867> your question doesn't parse
20120923 20:02:40< fendrin_> I first thought I must substitute that keywords. Non Sense.
20120923 20:02:52< fendrin_> :-)
20120923 20:13:56-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20120923 20:16:20< CIA-108> fendrin * r55365 /trunk/src/ (hotkeys.cpp hotkeys.hpp editor/editor_main.cpp): 
20120923 20:16:20< CIA-108> Removed the unused config variable,
20120923 20:16:20< CIA-108> it is a part of the removed support for scopes saving in different tag names.
20120923 20:24:31-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120923 20:33:29-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20120923 20:35:17< CIA-108> fendrin * r55366 /trunk/ (8 files in 2 dirs): 
20120923 20:35:17< CIA-108> New hotkey preferences dialog.
20120923 20:35:17< CIA-108> Have a look in the players_changelog for details.
20120923 20:36:18< shadowm> fendrin_: No, I don't recall anything like what you fixed.
20120923 20:37:00< fendrin_> I wonder nobody has noticed the bug before.
20120923 20:37:01< shadowm> Unless perhaps you meant tooltips instead of help?
20120923 20:37:21< fendrin_> yes
20120923 20:37:24< shadowm> The things that appear at the bottom on hover.
20120923 20:37:28< fendrin_> yeah
20120923 20:37:38< fendrin_> the method is called clear_help()
20120923 20:37:46< fendrin_> but it's more of a tooltip
20120923 20:38:11< shadowm> Okay, nobody has noticed it before because no GUI1 lists with the column sorting capability have tooltips associated with them at the moment.
20120923 20:38:25< fendrin_> wrong
20120923 20:38:31< shadowm> Or if there are any such, it's not in a frequently used component.
20120923 20:38:41< fendrin_> 55365 introduces one
20120923 20:38:52< shadowm> r55365 happened less than an hour ago.
20120923 20:38:53< fendrin_> 55366
20120923 20:39:01< shadowm> r55366 also happened less than an hour ago.
20120923 20:39:22< shadowm> And after the fix in question, no less.
20120923 20:39:35< fendrin_> I hope it is not breaking anything.
20120923 20:40:00< fendrin_> One could have workarounded the bug and this "fixed" code is now broken.
20120923 20:41:00< fendrin_> shadowm: Please note that there are still two icons sharing the same image file, the general from the general config tab is the general from the hotkey general scope tab.
20120923 20:42:20< fendrin_> shadowm: I guess the image can be replaced, the same name is still a little bit confusing. Also I couldn't make all the menus exactly the same geometry like you suggested.  I can only truncate at a certain character length but not specify a length in pixels.
20120923 20:43:03< shadowm> Sounds par for the course to me.
20120923 20:43:26< fendrin_> there is now a cancel button
20120923 20:44:13< fendrin_> I would love to give the okay and cancel buttons some help tooltips as well.
20120923 20:45:02< fendrin_> cancel does reset everything what happened in the dialog, I guess the player should now that.
20120923 20:45:50< shadowm> Exactly how is that not consistent withe everything else?
20120923 20:46:48< fendrin_> Well, I thought for myself the user could imagine that the cancel buttons just reverts what happened in the last current tab.
20120923 20:47:20< fendrin_> only
20120923 20:47:30-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Ping timeout: 264 seconds]
20120923 20:47:33< shadowm> Well, no.
20120923 20:48:11< fendrin_> Okay, fine. Then I call the thing ready.
20120923 20:49:10< shadowm> In Windows and KDE (except dialogs that use the control module architecture), the OK/Cancel/Apply control buttons are tied to all tabs.
20120923 20:52:22< jamit> I would expect "Cancel" to affect everything since that button appeared (unless there was an "Apply" button that I used). I would be rather surprised if changing tabs caused a commit of changes so far.
20120923 20:52:47< fendrin_> Yeah, but the old code did.
20120923 20:52:57< fendrin_> It saved every once in a while :-)
20120923 20:53:01< fendrin_> Literally.
20120923 20:53:02< shadowm> Preferences so far has followed GNOME's tradition of allowing the user to screw things up instantly.
20120923 20:53:41-!- PolarPanda [~quassel@unaffiliated/peterporty] has joined #wesnoth-dev
20120923 20:54:05< shadowm> It's not as instant as it should be in some cases because dialogs run synchronously, so e.g. team-color ellipses won't disappear/reappear while the dialog is still running.
20120923 20:54:17< jamit> I am looking at the preferences file without the most recent update, and I do not see a "Cancel" button.
20120923 20:54:36< fendrin_> right, but escape did save
20120923 20:54:59< fendrin_> or better the while loop around the event handler saved.
20120923 20:55:02< shadowm> The convention is that dialogs like that simply have a single Close button.
20120923 20:55:04< fendrin_> all around the time
20120923 20:55:19< jamit> That's a bit unusual, but not really surprising since there was no "Cancel" button.
20120923 20:55:28-!- PolarPanda [~quassel@unaffiliated/peterporty] has quit [Read error: Connection reset by peer]
20120923 20:55:39< jamit> "That" == "escape did save"
20120923 20:55:46< fendrin_> Yes, the old behavior was okay. The user can expect that.
20120923 20:55:56< fendrin_> The question is about the new one.
20120923 20:56:31< jamit> You brought up the old one. ;) --> fendrin_: Yeah, but the old code did.
20120923 20:56:32< fendrin_> The issue can also be handled with a "reset previous" extending the "reset defaults" button.
20120923 20:56:55< shadowm> fendrin_: Why does the players_changelog hunk contain more information than the changelog one?
20120923 20:57:25< shadowm> Also spelling mistakes and missing punctuation.
20120923 20:57:56< fendrin_> But my code has nice comments :-P
20120923 20:59:20< shadowm> +       // Lets change this hotkey......
20120923 20:59:35< fendrin_> Well, that was copy and paste.
20120923 20:59:41< fendrin_> I guess dave wrote it.
20120923 21:02:04 * shadowm runs this thing.
20120923 21:02:33< fendrin_> shadowm: Glad you spotted it. It is no longer true, the button now adds a binding.
20120923 21:03:59< shadowm> 20120923 16:02:11 error gui/draw: resulte ist-1
20120923 21:04:10< fendrin_> damn
20120923 21:04:48< shadowm> Is that from your own code, or mordante's? The GUI loggers are generally a GUI2 thing.
20120923 21:05:24< AI0867> it's new
20120923 21:05:27< shadowm> This is a terrible thing and needs to be fixed. The internal language is supposed to be English, not German.
20120923 21:05:41< AI0867> grep "resulte ist" doesn't return anything on my checkout
20120923 21:06:36< fendrin_> shadowm: It's debug leftover. I have read over the patch twice and still missed it.
20120923 21:07:36< shadowm> I personally prefer using the cerr stream directly when testing, so I can just grep for cerr in the diff before committing.
20120923 21:08:01< fendrin_> Good idea. I will do that in the future.
20120923 21:08:12< shadowm> So, I hear an additional click sound when the Hotkeys dialog first appear. Hm.
20120923 21:08:44< fendrin_> Oh, I haven't switched on sound :-)
20120923 21:09:16< shadowm> You haven't really learned about Doxygen, have you?
20120923 21:09:50< shadowm> The interface for hotkey_preferences_dialog has some faux-Doxygen-looking comments.
20120923 21:10:05< fendrin_> The preselection of the tab that represents the current scope is the possible cause for the second noise.
20120923 21:10:34< shadowm> Where does that preselection occur?
20120923 21:10:40< fendrin_> You may notice that opening the dialog in the editor opens the editor tab 
20120923 21:10:45< shadowm> Never mind, I think I found it.
20120923 21:11:06< shadowm> We also greatly prefer to use braces around single-statement blocks, by the way.
20120923 21:12:20< fendrin_> Sorry, I messed to much with that ancient code. It's not a spare thing there.
20120923 21:12:52-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go]
20120923 21:12:53< fendrin_> Is there a easy checking about the doxygen correctness?
20120923 21:13:17< shadowm> One possibility is running Doxygen yourself.
20120923 21:13:27< fendrin_> sounds great
20120923 21:13:48< shadowm> The other possibility (which is the one I prefer myself) is learning Doxygen syntax and/or using a text editor with a syntax highlighting schema that understands Doxygen comments and highlights them distinctly, such as Kate.
20120923 21:14:07< shadowm> Real Doxygen comments begin with /** or ///.
20120923 21:14:41< shadowm> Okay, so you call gui::menu::move_selection(), and that method supposedly passes a 'silent' value of true to set_selection_pos() and that isn't taken into account for some reason.
20120923 21:15:03< fendrin_> Sounds sound.
20120923 21:15:53< fendrin_> I have stumbled upon a bunch of bugs in the gui1 thing.
20120923 21:17:25< shadowm> Since there is a General section in Preferences already, it might be a good idea to mark the translatable string for Hotkeys with a different prefix, by the way.
20120923 21:18:00< shadowm> Okay, no, that's not the cause of the extra click sound.
20120923 21:18:34< fendrin_> shadowm: Well, what about having a short name for the item in the list and a more verbose description for the tooltip?
20120923 21:19:04< shadowm> No, that's not necessary. The names are self-descriptive enough. (We are still talking of the items on the left-side navigation bar, right?)
20120923 21:19:13< fendrin_> yes,
20120923 21:19:21< fendrin_> is my solution suiting your needs?
20120923 21:19:53< shadowm> You mean overall?
20120923 21:20:13< fendrin_> yeah
20120923 21:20:31< shadowm> Yes.
20120923 21:20:37-!- wesbot changed the topic of #wesnoth-dev to: 188 bugs, 338 feature requests, 16 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20120923 21:20:41< fendrin_> but also the particular point to truncate the description and use the tooltip to give the full information.
20120923 21:21:46< shadowm> Hang on.
20120923 21:21:53< shadowm> Why are you using tooltips in the first place?
20120923 21:22:01< fendrin_> Maybe one of the "General" can become a "Generic".
20120923 21:22:17< shadowm> No, 'generic' doesn't fit either context.
20120923 21:22:39< fendrin_> About the tooltips
20120923 21:23:11< fendrin_> Regarding the old dialog, languages like German already destroyed the layout and mode some values unreadable.
20120923 21:23:40< fendrin_> s/mode/made
20120923 21:23:43< shadowm> Ah, so I assume you are truncating strings...
20120923 21:23:47< fendrin_> I do
20120923 21:23:56< fendrin_> maybe that isn't visible in English
20120923 21:23:58< fendrin_> but try spain
20120923 21:24:02< fendrin_> Spanish
20120923 21:24:09< shadowm> I don't compile translations, unfortunately.
20120923 21:24:23< fendrin_> German is already truncated very much.
20120923 21:24:29< shadowm> Hopefully changing that won't result in a hour-long rebuild.
20120923 21:25:16< shadowm> fendrin_: What are the chances of the hotkey itself (e.g. "ctrl+g") being truncated?
20120923 21:25:30< fendrin_> if you stack them
20120923 21:25:36< fendrin_> that can happen
20120923 21:26:24< shadowm> Okay, so, I still have some UI concerns.
20120923 21:26:28< fendrin_> strg+shift+space, strg+Mouse0Btn8, Joy0key3
20120923 21:26:43< fendrin_> That is definitely too long.
20120923 21:27:48< fendrin_> I have some more plans myself.
20120923 21:28:05< shadowm> The "Reset All" button operates on not just the currently shown scope, but all of them instead.
20120923 21:28:15< fendrin_> yes
20120923 21:28:21< fendrin_> it should be below
20120923 21:28:22< shadowm> Therefore it doesn't belong in the same row as the buttons that operate on the current scope's selection.
20120923 21:28:27< fendrin_> yeah
20120923 21:28:38< shadowm> Yeah. Probably on the same row as the OK/Cancel buttons, perhaps at the left.
20120923 21:29:01< fendrin_> I will try the left first.
20120923 21:29:03< shadowm> Although that would be an abuse of the Help button geometry hint IIRC; that didn't stop anyone from doing something like that with the Delete option in Load Game.
20120923 21:29:27< fendrin_> well, the button is guarded
20120923 21:29:34< fendrin_> Do you really want this ugly thing?
20120923 21:29:45< fendrin_> The user is still able to cancel.
20120923 21:29:50< shadowm> Guarded?
20120923 21:29:56< fendrin_> The default loading doesn't save it.
20120923 21:30:23< shadowm> The user can cancel, but they can't go back a few days later and reset all the hotkeys without that option.
20120923 21:30:26< fendrin_> There is a guarding dialog questioning: "Do you really want to reset the buttons?" 
20120923 21:30:49< shadowm> Right. I implemented that when all changes took place immediately.
20120923 21:31:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120923 21:31:48< shadowm> If your changes also allow Reset's effects to be postponed until the user chooses OK, then the confirmation is not necessary.
20120923 21:32:00< fendrin_> I thought so.
20120923 21:32:52< fendrin_> Do you like the question about stealing a hotkey from another function?
20120923 21:33:18< fendrin_> I think that feature makes it much easier to get them managed.
20120923 21:34:00< shadowm> Yes, but this is unnecessary: text += "\n\n";
20120923 21:35:39< shadowm> Please let WML specify dialog geometry instead of playing with blank lines. I intend to try to revise (and officially standarize) the button row's top margin on message dialogs at some point in the future.
20120923 21:35:57< fendrin_> Agreed.
20120923 21:36:15< shadowm> Hm, also, there shouldn't really be a newline before the "Do you wish" part.
20120923 21:36:20< fendrin_> If the engine does formating and rendering for me why not.
20120923 21:36:53< shadowm> As for the pop-up's title, it's not correct and I'm not sure what to do about it.
20120923 21:37:56< shadowm> Dialog titles are supposed to be actual titles in title case, rather than sentences. This also means that they shouldn't be very long, and they should avoid verbs in non-infinitive.
20120923 21:38:08< fendrin_> Ah yes. The German translation did still fit :-)
20120923 21:38:35< shadowm> Perhaps "Reassign Hotkey" would be a more appropriate title.
20120923 21:39:00< fendrin_> Why not just "Bind Hotkey"
20120923 21:39:01< fendrin_> ?
20120923 21:39:36< fendrin_> You do not necesseraly reassign it. If you do so the dialog can be named "Reassign Hotkey".
20120923 21:40:16< shadowm> Hm, the prompt only appears when it is necessary to reassign it to continue, doesn't it?
20120923 21:40:26< fendrin_> I mean the dialog informing you about the action becoming a reassign can be named as you suggested.
20120923 21:40:38< shadowm> Yes, that's the dialog I'm talking about.
20120923 21:40:56< shadowm> "Hotkey is already in use." -> "Reassign Hotkey"
20120923 21:41:00< fendrin_> Indeed, a free hotkey will be assigned at once.
20120923 21:42:03< fendrin_> And this dialog still needs a sister.
20120923 21:42:39< shadowm> Okay, found a few cases of truncation and tooltips working as expected in the Spanish translation.
20120923 21:42:43< fendrin_> If you reassign a key to the general scope both possible assignments in game and the editor scope need to get deleted.
20120923 21:43:47< fendrin_> shadowm: You can also easily assign more than one hotkey sequence to see the list truncating at the right field.
20120923 21:44:39< shadowm> I also just realized that key names such as "shift" or "space" are not translatable.
20120923 21:44:54< shadowm> Not even in 1.10.
20120923 21:45:29< fendrin_> Well, I am fine with them.
20120923 21:45:51< fendrin_> Using German Words for Computer stuff confuses me.
20120923 21:46:06< fendrin_> My KDE is set to English.
20120923 21:46:07< Espreon> They still need to be translatable.
20120923 21:46:10< shadowm> Yes, same in Spanish, but I don't think that holds true for all people or all languages.
20120923 21:47:01< shadowm> Okay, so I think that's all. I'm still puzzled about the extra click sound thing.
20120923 21:47:03< fendrin_> Well, then you suggest that Joy0Btn2 to be translatable as well?
20120923 21:47:18< Espreon> Why not?
20120923 21:47:37< AI0867> I agree for dutch too. It still confuses me that there are people who want to translate units and si-prefixes
20120923 21:48:15< Espreon> Europe is not the entire world.
20120923 21:48:19< jamit> shadowm: Try 1.10. There seems to be an extra click there as well (if I understand what you are talking about).
20120923 21:48:19< Espreon> This may be shocking to you people.
20120923 21:48:47< AI0867> and as I told you before, units are not letters from your language.
20120923 21:49:03< AI0867> they may coincide, but that's all
20120923 21:49:25< Espreon> Yet many of the Slavs prefer to Cyrillicize them.
20120923 21:49:31< shadowm> fendrin_: "Joy0Btn2" probably makes absolutely no sense at all in Russian or Japanese.
20120923 21:49:48< shadowm> Or Hebrew.
20120923 21:49:50< AI0867> what about micro?
20120923 21:50:13< shadowm> It barely makes sense in English, too.
20120923 21:50:25< fendrin_> Yes
20120923 21:50:50< shadowm> One thing is abbreviating "Control" to match what's usually printed on the actual keys, but "Joy0Btn2" sounds like technobabble to Joe.
20120923 21:51:19-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20120923 21:51:21< shadowm> jamit: Yes, indeed.
20120923 21:52:07< fendrin_> shadowm: I have already gathered a free set of button icon images. I hope to map them instead.
20120923 21:52:08< shadowm> Which is strange. It doesn't happen with the wesnothd prompt in the Multiplayer page (GUI1) or the Themes prompt in Display (GUI2).
20120923 21:52:57< CIA-108> alarantalara * r55367 /trunk/projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Add new files to Xcode project
20120923 21:53:19< Espreon> AI0867: Yes, even micro.
20120923 21:53:37< shadowm> So Hotkeys is special for some reason.
20120923 21:54:01< fendrin_> Regarding the click sound?
20120923 21:54:14< AI0867> Espreon: what about pi?
20120923 21:54:15< shadowm> Found it, I think.
20120923 21:54:30< shadowm> It calls gui::menu::reset_selection() during initialization, which doesn't do silent selection changes.
20120923 21:54:47< shadowm> For soooome reason. Fix incoming.
20120923 21:55:32< Espreon> AI0867: Do you mean pico?
20120923 21:56:20< shadowm> Espreon: He means the ratio between a circle's area and the square of its radius.
20120923 21:56:33< shadowm> s/area/surface/
20120923 21:56:39< Espreon> Cyrillic already has pi.
20120923 21:56:50< Espreon> But I doubt they go that far.
20120923 21:57:06< Espreon> (to Cyrillicize mathematic symbols)
20120923 21:57:08< shadowm> (No, I think he meant pico, but I wanted to say that anyway.)
20120923 21:57:21< AI0867> Espreon: I fail to see the difference
20120923 21:57:34< Espreon> Some things are changed and some aren't.
20120923 21:57:37< Espreon> Accept it.
20120923 21:57:42< AI0867> these are symbols that refer to the real world, sure, but they're still symbols
20120923 21:58:12< AI0867> I already put in the work to make them translatable
20120923 21:58:26< AI0867> that doesn't mean I can't keep calling them silly
20120923 21:58:37< Espreon> Then let's stop talking about it.
20120923 21:59:43-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20120923 21:59:46< CIA-108> alarantalara * r55368 /trunk/data/ (3 files in 2 dirs): Remove the unusually good defense for Fire Guardians over frozen terrain. It was a holdover from when the UtBS walkable lava was aliased to it as it was an unused terrain type so could be repurposed.
20120923 22:08:38< CIA-108> mordante * r55369 /trunk/src/animated.i: 
20120923 22:08:38< CIA-108> Pre instead of post increment a variable.
20120923 22:08:38< CIA-108> Issue found by cppcheck.
20120923 22:08:39< CIA-108> mordante * r55370 /trunk/src/gamestatus.cpp: 
20120923 22:08:39< CIA-108> Pre instead of post increment a variable.
20120923 22:08:39< CIA-108> Issue found by cppcheck.
20120923 22:08:41< CIA-108> mordante * r55371 /trunk/src/gamestatus.cpp: 
20120923 22:08:41< CIA-108> Pre instead of post increment a variable.
20120923 22:08:41< CIA-108> Issue found by cppcheck.
20120923 22:08:43< CIA-108> mordante * r55372 /trunk/src/unit.cpp: 
20120923 22:08:43< CIA-108> Pre instead of post increment a variable.
20120923 22:08:43< CIA-108> Issue found by cppcheck.
20120923 22:08:44< CIA-108> mordante * r55373 /trunk/src/about.cpp: 
20120923 22:08:44< CIA-108> Limit variable scope.
20120923 22:08:44< CIA-108> Issue found by cppcheck.
20120923 22:08:45< CIA-108> mordante * r55374 /trunk/src/ai/composite/component.cpp: 
20120923 22:08:45< CIA-108> Limit variable scope.
20120923 22:08:57< CIA-108> mordante * r55381 /trunk/src/editor/action/action_unit.cpp: 
20120923 22:08:57< CIA-108> Remove an unused variable.
20120923 22:08:58< CIA-108> Issue found by cppcheck.
20120923 22:10:30< CIA-108> shadowmaster * r55382 /trunk/src/widgets/menu.cpp: 
20120923 22:10:30< CIA-108> gui1: gui::menu::reset_selection() should not emit the GUI clicking sound
20120923 22:10:30< CIA-108> This fixes and extra clicking sound when bringing up the Hotkey
20120923 22:10:30< CIA-108> Preferences and Create Unit dialogs.
20120923 22:10:39< shadowm> fendrin_, jamit ^
20120923 22:10:45< shadowm> s/and/a/
20120923 22:10:48< fendrin_> shadowm: Thanks :-)
20120923 22:10:50< shadowm> Ugh.
20120923 22:10:54< shadowm> I mean an. Not and. Nor a.
20120923 22:11:04-!- MrBeast [~foo@pD950AA01.dip0.t-ipconnect.de] has joined #wesnoth-dev
20120923 22:15:39< CIA-108> shadowmaster * r55383 /branches/1.10/src/widgets/menu.cpp: 
20120923 22:15:39< CIA-108> gui1: gui::menu::reset_selection() should not emit the GUI clicking sound
20120923 22:15:39< CIA-108> This fixes and extra clicking sound when bringing up the Hotkey
20120923 22:15:39< CIA-108> Preferences and Create Unit dialogs.
20120923 22:15:39< CIA-108> (Backported from trunk, r55382.)
20120923 22:18:26< Espreon> 20120923 16:16:20 error gui/draw: resulte ist-1
20120923 22:18:30< Espreon> This still exists.
20120923 22:49:10< CIA-108> jamit * r55384 /trunk/ (src/game_events.cpp changelog src/unit_types.cpp): Push [and],[or],[not] tags from event weapon filters to all weapon filters.
20120923 22:59:02-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120923 23:04:07< shadowm> boucman: Around?
20120923 23:04:15< boucman> a little
20120923 23:04:31< shadowm> Have you had time to look into https://gna.org/bugs/?20099 yet?
20120923 23:09:52-!- mjs-de [~mjs-de@g224178181.adsl.alicedsl.de] has joined #wesnoth-dev
20120923 23:15:00-!- negusnyul [~negusnyul@dsl4E5C46E2.pool.t-online.hu] has quit [Ping timeout: 248 seconds]
20120923 23:17:44< shadowm> Ivanovic: Do you know if galicae is an active translator?
20120923 23:17:58< Ivanovic> no idea
20120923 23:18:02< CIA-108> jamit * r55385 /trunk/src/ (5 files in 2 dirs): spaces to tabs
20120923 23:18:18< shadowm> He's basically spamming the forums with a request to be added to the relevant user group.
20120923 23:18:28< shadowm> That is, by making it part of his signature.
20120923 23:18:58< shadowm> I'm not entirely sure I want to comply in such case. It seems to me that denying him the right to join the group is a fair enough punishment for doing that _and_ using colors (point 3c).
20120923 23:19:11< Ivanovic> there is someone with this nick listed as greek translator in the credits
20120923 23:19:18< Ivanovic> so yeah, might be that he is a translator
20120923 23:19:36< shadowm> Oh, greek.
20120923 23:19:48< shadowm> I had misread in the diff that as german somehow.
20120923 23:20:02< shadowm> *misread that in the diff
20120923 23:20:19< Ivanovic> that is: i just looked up the credits since that page is based on the ingame credits and i assume that we hopefully don't have too many duplicated nicks
20120923 23:20:32< Ivanovic> http://wiki.wesnoth.org/Credits
20120923 23:20:38< Ivanovic> very useful for short searches
20120923 23:20:41< shadowm> I use git log -p instead.
20120923 23:20:45< Ivanovic> nayway, i am off to be, n8
20120923 23:21:13< Ivanovic> you could also just read data/core/about.cfg, no need for looking through log files
20120923 23:21:14< Ivanovic> ;)
20120923 23:21:29< Ivanovic> n8
20120923 23:21:59< shadowm> There's no history information in the file contents themselves.
20120923 23:22:36< shadowm> And in this case I really needed a date to refer to.
20120923 23:26:02-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20120923 23:26:45< Espreon> shadowm: http://svn.gna.org/viewcvs/wesnoth/trunk/data/core/about.cfg?r1=49074&r2=49075&
20120923 23:33:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20120923 23:37:13< boucman> shadowm no, sorry, it's on my todo list, but I have multiple stuff on it, 
20120923 23:37:20< boucman> real life is eating a lot of my time
20120923 23:39:11< shadowm> Espreon: That doesn't tell me anything I didn't already know.
20120923 23:39:22< shadowm> My question was whether he was active, not when he was first added to the credits.
20120923 23:39:55< Espreon> Ah
20120923 23:41:11< Espreon> Figuring that out'll probably be a PITA.
20120923 23:44:15< shadowm> I chose to go with whatever he says.
20120923 23:44:34< Espreon> 'K.
20120923 23:44:40-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120923 23:45:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20120923 23:46:24-!- Crendgrim [~crend@37-4-215-190-dynip.superkabel.de] has quit [Quit: ...]
20120923 23:49:34-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20120923 23:53:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20120923 23:54:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20120923 23:58:26-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20120923 23:59:10-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 246 seconds]
--- Log closed Mon Sep 24 00:00:18 2012