--- Log opened Thu Sep 27 00:00:26 2012 20120927 00:15:43-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 246 seconds] 20120927 00:18:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120927 00:21:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120927 00:22:13-!- noy_ [~Noy@S010600236999f399.vw.shawcable.net] has joined #wesnoth-dev 20120927 00:22:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer] 20120927 00:22:13-!- noy_ [~Noy@S010600236999f399.vw.shawcable.net] has quit [Changing host] 20120927 00:22:13-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120927 00:22:22-!- noy_ is now known as noy 20120927 00:27:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds] 20120927 00:30:39< fendrin> shadowm: updated the hotkey dialog. Would you have a look, please? 20120927 00:47:12-!- fendrin_ [~fabi@88-134-46-58-dynip.superkabel.de] has joined #wesnoth-dev 20120927 00:47:13-!- fendrin [~fabi@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer] 20120927 00:47:43< loonycyborg> fendrin_: How exactly do you access it? 20120927 00:49:18< loonycyborg> Ah. Yes. I see it. 20120927 00:49:26< fendrin_> loonycyborg: :-) 20120927 00:49:46< fendrin_> loonycyborg: The button to access it hasn't changed since ages :-) 20120927 00:50:12< loonycyborg> I never had a need to change hotkeys 20120927 00:50:26< fendrin_> me too 20120927 00:50:43< fendrin_> but I need the dialog to see how to do what from time to time 20120927 01:24:10< shadowm> I'm thinking that the hotkeys system could be rendered in a more useful help topic by marking certain actions as user-relevant; e.g. Next Unit, End Turn, Fullscreen. 20120927 01:24:53< shadowm> Then the topic could list the current bindings for only those user-relevant actions, instead of requiring the user to go and consult the incredibly flexible but horribly dense Hotkeys configuration dialog. 20120927 01:25:57< shadowm> And no, I haven't looked at your changes yet. I just came back and I'm only now compiling Wesnoth. 20120927 01:29:52-!- MrBeast [~foo@pD9508350.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20120927 01:31:02-!- MrBeast [~foo@pD9508350.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120927 01:38:14-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection] 20120927 01:50:57-!- MrBeast [~foo@pD9508350.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20120927 01:52:02-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev 20120927 01:52:03-!- Upth is now known as Upthorn 20120927 01:53:36< shadowm> fendrin_: I think it looks good atm. 20120927 02:08:01< shadowm> esr: How has your CIA replacement been doing as of late? Is it live already or anything? 20120927 02:14:03< fendrin_> shadowm: What about the second interface feature I commited? Did you already notice it? 20120927 02:14:35< shadowm> No. 20120927 02:16:59< fendrin_> Start wesnoth with "-t" and select a empty hex field. 20120927 02:20:52< shadowm> Okay, it's a little non-obvious. 20120927 02:21:01< shadowm> I can only select hexes which can be reached by any unit regardless of its team? 20120927 02:22:38< fendrin_> yes 20120927 02:23:03< fendrin_> you can also move into the selected hex. 20120927 02:33:31-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has joined #wesnoth-dev 20120927 02:33:47-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has quit [Client Quit] 20120927 02:34:05-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has joined #wesnoth-dev 20120927 02:48:49< AI0867> esr: because CIA just got deleted 20120927 02:49:16< shadowm> http://shadowm.rewound.net/blog/archives/245-CIA.vc-is-dead.html 20120927 02:49:23< shadowm> http://pastebin.com/9RBBniM1 20120927 02:49:52< AI0867> any part of the required infrastructure will be quite helpful as stuff is reconstructed 20120927 03:08:47< esr> Yow. I'll release tmorrow. 20120927 03:22:29-!- skyfaller [~skyfaller@ool-43551e75.dyn.optonline.net] has joined #wesnoth-dev 20120927 03:22:29-!- skyfaller [~skyfaller@ool-43551e75.dyn.optonline.net] has quit [Changing host] 20120927 03:22:29-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev 20120927 03:40:40-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection] 20120927 04:06:22-!- xchat_sux [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 246 seconds] 20120927 05:30:24-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [] 20120927 05:45:06-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 264 seconds] 20120927 05:48:12-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer] 20120927 05:48:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120927 05:52:37-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120927 06:05:07-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 06:13:54-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 264 seconds] 20120927 06:19:08-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 06:26:26-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120927 06:27:06-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 264 seconds] 20120927 06:34:39-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 07:14:33-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has joined #wesnoth-dev 20120927 08:03:27-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.] 20120927 08:53:39-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 244 seconds] 20120927 08:55:49-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120927 09:01:13-!- timotei [~timotei@ip4-89-238-226-118.euroweb.ro] has joined #wesnoth-dev 20120927 09:01:13-!- timotei [~timotei@ip4-89-238-226-118.euroweb.ro] has quit [Changing host] 20120927 09:01:13-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20120927 09:08:14-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120927 09:09:19-!- timotei21 [~timotei@86.124.100.155] has joined #wesnoth-dev 20120927 09:09:19-!- timotei21 [~timotei@86.124.100.155] has quit [Changing host] 20120927 09:09:19-!- timotei21 [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20120927 09:12:42-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 264 seconds] 20120927 09:15:46-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving] 20120927 09:18:44-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 248 seconds] 20120927 09:20:38-!- wesbot changed the topic of #wesnoth-dev to: 190 bugs, 332 feature requests, 15 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org 20120927 09:25:55-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 09:34:16-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 265 seconds] 20120927 09:35:37-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120927 09:36:26< Soliton> anonymissimus: you're welcome to volunteer for add-on server administration. revealing the names of said add-ons so an admin can remove them might work as well. 20120927 09:58:21-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev 20120927 09:58:22-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host] 20120927 09:58:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120927 09:58:29< shadowm> Out of curiosity, what needs to be done to get server2 and server3 back in shape? Compiling a more recent wesnothd version on both hosts and adjusting the configuration? 20120927 09:58:59< AI0867> I haven't run wesnothd on anything else than my own machine, but I think that's correct 20120927 09:59:47< shadowm> I mean, adjusting the config is quite presumably not the main roadblock. 20120927 10:00:26< AI0867> no, that should be a matter of copying a file and editing a few lines in both versions 20120927 10:01:23< AI0867> http://pastebin.com/eqnrArPJ <-- this is a functional config file 20120927 10:03:08< shadowm> Yeah, I remembered as much from the last time I fiddled around with a local instance using non-default configuration. 20120927 10:05:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120927 10:41:39< Soliton> shadowm: adjusting everything around wesnothd. updating symlinks, updating IRC bot config, checking scripts are uptodate, checking whether everything works afterwards and remembering what i forgot in this list if something doesn't work. 20120927 10:43:02< Soliton> it shouldn't be too much work really, but it needs some amount of consecutive free time... 20120927 10:44:18< shadowm> Ah well, too bad I have too much free time and approximately nil experience with wesnothd. :p 20120927 10:57:11< Soliton> we can change the latter if you like. all the stuff around wesnothd should be "documented" by existing scripts (which might not all be checked into svn yet) and i should be able to answer remaining questions. 20120927 10:59:21< shadowm> I guess I wouldn't be opposed. 20120927 11:00:06-!- mjs-de [~mjs-de@d117229.adsl.hansenet.de] has joined #wesnoth-dev 20120927 11:01:10-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev 20120927 11:35:30-!- MrBeast [~foo@pD950B274.dip0.t-ipconnect.de] has joined #wesnoth-dev 20120927 11:55:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20120927 12:17:29-!- EdB [~edb@37-8-184-10.coucou-networks.fr] has joined #wesnoth-dev 20120927 12:19:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120927 12:27:42-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 264 seconds] 20120927 12:33:52-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 246 seconds] 20120927 12:35:49-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20120927 12:38:41-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 12:38:58-!- EdB_ [~edb@37-8-184-10.coucou-networks.fr] has joined #wesnoth-dev 20120927 12:39:16-!- EdB [~edb@37-8-184-10.coucou-networks.fr] has quit [Ping timeout: 248 seconds] 20120927 12:43:34-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 240 seconds] 20120927 12:45:27-!- EdB_ [~edb@37-8-184-10.coucou-networks.fr] has quit [Ping timeout: 256 seconds] 20120927 12:45:29-!- EdB [~edb@37-8-184-10.coucou-networks.fr] has joined #wesnoth-dev 20120927 12:50:12-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 12:54:44-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 248 seconds] 20120927 12:59:44-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 13:05:51-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 256 seconds] 20120927 13:11:45-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 13:16:37-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 256 seconds] 20120927 13:22:16-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 13:28:23-!- balrog [~balrog@discferret/developer/balrog] has quit [Ping timeout: 255 seconds] 20120927 13:33:17-!- balrog [~balrog@discferret/developer/balrog] has joined #wesnoth-dev 20120927 13:58:13-!- xchat_sux [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev 20120927 14:27:47-!- Ayne [cblktwqt@62.157.182.162] has joined #wesnoth-dev 20120927 14:42:56-!- loonybot [~loonybot@46.138.72.79] has joined #wesnoth-dev 20120927 14:42:56-!- loonybot [~loonybot@46.138.72.79] has quit [Changing host] 20120927 14:42:56-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev 20120927 14:47:53-!- EdB_ [~edb@37-8-184-10.coucou-networks.fr] has joined #wesnoth-dev 20120927 14:48:02-!- EdB [~edb@37-8-184-10.coucou-networks.fr] has quit [Ping timeout: 255 seconds] 20120927 14:59:34-!- EdB_ [~edb@37-8-184-10.coucou-networks.fr] has quit [Quit: Konversation terminated!] 20120927 15:00:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120927 15:31:57-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-dev 20120927 16:16:16-!- timotei21 [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 256 seconds] 20120927 16:16:58-!- negusnyul [~negusnyul@dsl54020ABA.pool.t-online.hu] has joined #wesnoth-dev 20120927 16:33:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120927 16:43:05-!- artisticdude [~artisticd@126.sub-70-192-194.myvzw.com] has joined #wesnoth-dev 20120927 16:50:12-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...] 20120927 16:53:57-!- artisticdude [~artisticd@126.sub-70-192-194.myvzw.com] has quit [Quit: Leaving.] 20120927 17:08:08-!- SeattleDad [~SeattleDa@c-67-171-51-0.hsd1.wa.comcast.net] has joined #wesnoth-dev 20120927 17:10:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20120927 17:33:02-!- SeattleDad [~SeattleDa@c-67-171-51-0.hsd1.wa.comcast.net] has quit [Quit: The computer fell asleep] 20120927 17:35:24-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev 20120927 17:45:06-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has joined #wesnoth-dev 20120927 18:16:16-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 265 seconds] 20120927 18:21:04< mattsc> boucman_work: hi 20120927 18:21:22< boucman_work> hey 20120927 18:21:23< mattsc> I have 2 Micro AIs completed and documented here: http://wiki.wesnoth.org/Micro_AIs 20120927 18:22:04< mattsc> If you're interested enough, you can check out a pre-release version at the AI-Demos github site: https://github.com/mattsc/Wesnoth-AI-Demos 20120927 18:22:55< mattsc> Otherwise, I'll put out a release on the add-ons server as soon as I've work out some issues with the Grunt Rush AI. I hope to get that done on the weekend, but no promises. 20120927 18:23:06< Crab_> cool :) 20120927 18:23:34< boucman_work> yay 20120927 18:23:57< mattsc> Crab_: yeah, thanks. :) Obviously, any of this can be adapted easily, this is just the "first draft". 20120927 18:41:06-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev 20120927 19:00:14-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Read error: Operation timed out] 20120927 19:15:46-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has quit [Quit: bye] 20120927 19:53:35-!- csarmi_home [csarmi@94-21-80-164.pool.digikabel.hu] has joined #wesnoth-dev 20120927 19:55:34-!- csarmi [csarmi@94-21-114-224.pool.digikabel.hu] has quit [Ping timeout: 256 seconds] 20120927 19:55:51-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120927 19:58:54-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev 20120927 19:58:54-!- Upth is now known as Upthorn 20120927 20:15:23-!- Crab_ [Crab_@wesnoth/developer/crab] has left #wesnoth-dev [] 20120927 20:26:37-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev 20120927 20:26:38-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host] 20120927 20:26:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20120927 20:28:41-!- Gallifax [~IceChat77@ltea-178-013-172-019.pools.arcor-ip.net] has joined #wesnoth-dev 20120927 20:34:00-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-105.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev 20120927 20:36:22< anonymissimus> jamit: what's the advantage of static non-member functions over private member ones or why are you doing such conversions ? 20120927 20:49:14-!- Gallifax [~IceChat77@ltea-178-013-172-019.pools.arcor-ip.net] has quit [Quit: Beware of programmers who carry screwdrivers.] 20120927 20:55:58< shadowm> Hm. 20120927 20:58:04-!- mjs-de [~mjs-de@d117229.adsl.hansenet.de] has quit [Remote host closed the connection] 20120927 20:58:45< fendrin_> anonymissimus: sorry, can't reproduce the vector overrun you reported. Is it a Heisenbug? 20120927 21:02:30-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Quit: And away we go] 20120927 21:25:30< shadowm> wesbot: seen Crendgrim 20120927 21:25:30< wesbot> shadowm: The person with the nick Crendgrim 1d 22h ago was here and on the channels #wesnoth, #wesnoth-de and #wesnoth-umc-dev with the message: Quit: Konversation terminated! 20120927 21:28:06< anonymissimus> fendrin_: "Heisenbug" ?? 20120927 21:29:03< shadowm> http://www.catb.org/~esr/jargon/html/H/heisenbug.html 20120927 21:29:31< anonymissimus> fendrin_: it looked as if I could reproduce it only sometimes; and as I said, please insert an assertion to ensure the index is in range, or use std::vector::at() which throws an exception I guess 20120927 21:30:36< shadowm> IIRC std::vector::at() isn't standard before C++11. 20120927 21:32:05< anonymissimus> that was std::map::at() 20120927 21:32:10< anonymissimus> but for vector it is 20120927 21:32:29-!- timotei [~timotei@188.24.5.207] has joined #wesnoth-dev 20120927 21:32:29-!- timotei [~timotei@188.24.5.207] has quit [Changing host] 20120927 21:32:29-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20120927 21:32:44< anonymissimus> at least I've never seen it not working in the (few) compilers that I or we use here 20120927 21:32:59< anonymissimus> which likely means it's standard 20120927 21:33:18-!- Ayne [cblktwqt@62.157.182.162] has quit [Quit: ~ Trillian Astra - www.trillian.im ~] 20120927 22:14:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 245 seconds] 20120927 22:16:11-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev 20120927 22:44:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20120927 22:53:32< jamit> anonymissimus: One advantage of static non-member functions is that there is less work for the linker (since it doesn't need to know of static functions). 20120927 22:54:41< jamit> anonymissimus: But my real motivation is more encapsulation/neatness. In general, the less there is in header files, the less someone needs to know to use a class. 20120927 22:54:56-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL] 20120927 22:55:25< anonymissimus> fendrin_: I never know whether you read the logs so i wrote something further here: https://gna.org/bugs/index.php?20199 20120927 22:56:28< jamit> anonymissimus: And for the most recent one, it was because it was cleanest way to restore the ability to compile that file stand-alone. (The function in question is only used in attack_prediction.) 20120927 22:59:44< jamit> Not a huge gain, but little things add up. 20120927 22:59:59< anonymissimus> jamit: hm, if I use a class from outside, I sure don't look for anything below private: 20120927 23:03:01< jamit> Yeah, the reasons are not strong. 20120927 23:03:27< jamit> anonymissimus: Are you asking because you are curious, or because you think I should not be doing that? 20120927 23:07:11-!- negusnyul [~negusnyul@dsl54020ABA.pool.t-online.hu] has quit [Ping timeout: 244 seconds] 20120927 23:08:22< jamit> fendrin_: I had looked at bug #20199 briefly, and it is odd since the code does check for current_route_.steps being empty. I guess the mouse handler will sometimes change current_route when commands are disabled (i.e. while a move is animated)? 20120927 23:09:06< jamit> fendrin_: I did not see where/how the mouse handler could do that though. 20120927 23:09:09< anonymissimus> jamit: I don't critisize, I'm just curios and want to learn stuff 20120927 23:09:18< fendrin_> jamit: Well, the current_route_ is not a pointer. It can never be an invalid object. 20120927 23:10:38< jamit> anonymissimus: Understood, and just making sure. ;) 20120927 23:11:26< jamit> fendrin_: It cannot be invalid, but it can be cleared. 20120927 23:11:47< anonymissimus> jamit: when would you favor a private member function over a static non-member one then ? 20120927 23:12:47< fendrin_> jamit: Assume it is cleared, the size should return 0 and thus no wrong access of the vector. 20120927 23:13:36< fendrin_> I don' t even know what would be a good condition for the assert that anonymissimus suggested. 20120927 23:13:37< jamit> anonymissimus: If it needs access to private data or private functions then it would need to be a member function. Otherwise, there is a good chance that it could be static non-member. 20120927 23:14:17< anonymissimus> fendrin_: , jamit : the current_route_.steps is somehow emptied by the move_unit_along_route() call 20120927 23:15:01< jamit> anonymissimus: There is also a rather subjective criteria of whether or not the function describes the class, if that makes sense. But those functions tend to use private data anyway, so the other criteria would apply. 20120927 23:17:51< anonymissimus> an that shouldn't be as the parameter is const 20120927 23:17:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20120927 23:18:02< anonymissimus> so MSVC debugger is playing tricks with me probably 20120927 23:18:53< jamit> anonymissimus, fendrin_: I suspect it is not by the move_unit_along_route() call, but during the call. 20120927 23:20:03< jamit> That call takes time and one can click a new unit while it is in progress, so it might be possible to do something with the mouse that affects current_route_. 20120927 23:20:33< jamit> (Takes time == the time to animate the move) 20120927 23:22:50< fendrin_> jamit: anonymissimus is right. I suspect that the move_unit_along_route never had the side effect of resetting the current_route but I introduced it. 20120927 23:25:48< fendrin_> anonymissimus: It might be the move_unit_along_route call to select_hex. 20120927 23:27:08< anonymissimus> fendrin_: the assert would simply be assert(0 <= num_moves && num_moves < current_route_.steps.size()); but ::at() is better 20120927 23:27:39-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev 20120927 23:27:55< jamit> anonymissimus: fendrin_: Hmm... I would like to know where the route is being cleared, but I just noticed a detail that might make this my fault. 20120927 23:28:38-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has joined #wesnoth-dev 20120927 23:29:12< jamit> I think I added the line in question, basically pushing it up from move_unit_along_route(), but move_unit_along_route() makes a copy of the steps, not just stores a reference to it. 20120927 23:29:35< jamit> That would be safer, given the time it takes to animate the move. 20120927 23:29:52< fendrin_> I see. 20120927 23:30:22< jamit> Still, it is curious that fendrin's change would expose something. 20120927 23:30:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20120927 23:31:33< jamit> Do either of you want time to investigate more? I should correct that oversight, but there might still be another problem somewhere. 20120927 23:32:08< anonymissimus> I don't since I didn't change anythign there lately 20120927 23:32:29-!- EdB [~edb@tss37-1-89-82-194-231.dsl.sta.abo.bbox.fr] has quit [Quit: Konversation terminated!] 20120927 23:32:46< fendrin_> jamit: The code in mouse_events is needed for handling the joystick input as well. 20120927 23:34:38< anonymissimus> also, I test-reverted fendrin's revision as written in the bug report and that one seemed to be the cause; I can't say for sure though due to the bug being hard to reproduce 20120927 23:34:56< fendrin_> jamit: But joystick axes need to be configured in a similar dialog like the current hotkey one. Thus I will sooner or later refactor the menu_events file and it will be gone afterwards. 20120927 23:35:53< jamit> The file will be gone? 20120927 23:36:20< fendrin_> In exchange for a system that handles "input_item" similar how current "hotkey_item" are handled. 20120927 23:37:32< fendrin_> With the difference that hotkey_item binds function that only needs a single trigger (button) while input_item binds a function that needs a range from an input device. 20120927 23:38:35< fendrin_> jamit: In the file will still be the mouse button handling functions but those will wander into the hotkey system as well. 20120927 23:38:48< fendrin_> Thus the file will have vanished at the end. 20120927 23:44:58< jamit> It might not be a good idea organizationally to have the entire 1200+ line file wander into another file. Maybe into a new file that is more function-oriented, leaving the mouse-specific stuff behind. 20120927 23:45:59< jamit> Still, functions wandering does not cause the code to disappear, so I'll go with the fix some time after I see what the whiteboard is doing with move_unit_along_route(). 20120927 23:46:27-!- ancestral [~ancestral@75-161-178-116.mpls.qwest.net] has quit [Quit: i go sleeps kthxbai] 20120927 23:48:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20120927 23:49:58< jamit> wesbot: seen gabba 20120927 23:49:58< wesbot> jamit: The person with the nick gabba 18d 21h ago they left with the message: Ping timeout: 255 seconds 20120927 23:54:37-!- mjs-de [~mjs-de@d117229.adsl.hansenet.de] has joined #wesnoth-dev --- Log closed Fri Sep 28 00:00:40 2012