--- Log opened Mon Oct 08 00:00:18 2012
20121008 00:13:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20121008 00:17:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20121008 01:01:04-!- mattsc [~mattsc@d154-20-32-241.bchsia.telus.net] has joined #wesnoth-umc-dev
20121008 01:07:51-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20121008 01:16:19< mattsc> skyfaller: ugh  :)
20121008 01:16:29< skyfaller> ugh?
20121008 01:16:40< mattsc> Lots of commits, lots of work, but not done yet...
20121008 01:16:58< mattsc> But, as I thought, it's pretty straight forward
20121008 01:54:19< mattsc> skyfaller: I think I've done everything we discussed earlier
20121008 01:54:31< skyfaller> hoooray!
20121008 01:54:37< mattsc> When you get a chance, would you mind testing it a little?
20121008 01:55:34< mattsc> It won't work with your test case from yesterday.  I think I can fix up that savefile, but I don't want to do that util I know that this works as you want it to.
20121008 01:56:02< mattsc> So just play with it a little with some toy cases.
20121008 01:56:22< mattsc> I also haven't updated the wiki, but I think that it's reasonably self-explanatory.
20121008 01:58:48< mattsc> One thing that might not be obvious: if you choose "find highest scoring CA", it sets the CA for execution automatically.  You can just do "eval & exec single CA" next, and do not need to go through "choose CA" first
20121008 02:01:09< skyfaller> ah, nifty
20121008 02:01:20< skyfaller> I'm going to go eat dinner now, but when I come back I can test it
20121008 02:04:15< mattsc> Cool.  No rush.
20121008 02:16:58< mattsc> skyfaller: just made one more commit with slightly cleaner messages
20121008 03:12:35-!- vultraz [~vultraz@124.109.10.167] has quit [Ping timeout: 256 seconds]
20121008 03:33:26-!- vultraz [~vultraz@124.109.10.167] has joined #wesnoth-umc-dev
20121008 03:41:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-umc-dev
20121008 03:41:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Excess Flood]
20121008 03:43:24-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: system reboot in progress]
20121008 03:43:27< skyfaller> mattsc: alright, any tips on how to test / what to test?
20121008 03:45:02-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-umc-dev
20121008 03:53:58< mattsc> Just start an MP game in debug mode from the lobby and test out if the options work for you.
20121008 03:54:43< mattsc> skyfaller ^   I don't really care whether you do a meaningful test of Fred, I'd just like a test of the debugging functions themselves at this time.
20121008 03:55:53< mattsc> ... because I can backport this into your test case, but it's a bit of a PITA and I don't want to do that more than once.
20121008 03:59:12< skyfaller> ha, it is easy to accidentally right click one of the AI options when you are side 2 non-orcs :/
20121008 03:59:32< skyfaller> I accidentally clicked "play an entire AI turn" while playing the other side
20121008 03:59:36< skyfaller> and the game crashed
20121008 03:59:40< mattsc> Hmm, ok...
20121008 04:00:12< mattsc> I can disable them when the player's not in control of Side 1.  I think that's easy.
20121008 04:00:13< skyfaller> any chance you could disable that stuff, or do I just have to be more careful where I click?
20121008 04:00:53< skyfaller> yeah, might be a good idea to disable them if you can't just make it throw an error like "sorry, you're playing the wrong side"
20121008 04:01:04< skyfaller> crashing the game is a little annoying
20121008 04:01:33-!- irker429 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20121008 04:01:33< mattsc> Well, which of the two would you prefer?  Taking the menu options away, or throwing an error?
20121008 04:02:02< skyfaller> I guess eventually Fred will play both sides
20121008 04:02:18< skyfaller> so it might be worth leaving the menu options there but have them just throw an error so that the game doesn't crash
20121008 04:02:35< mattsc> ok
20121008 04:04:52< skyfaller> mattsc: I have a question... we're advancing the game 6 turns to get back to the same time of day
20121008 04:05:18< skyfaller> couldn't you just advance the game one turn to get what you want, and then automatically set the turn number and time of day back to what it was?
20121008 04:05:46< skyfaller> because I'm just manually setting the turn number back to what it was after it cycles through the 6 turns
20121008 04:06:10< mattsc> How are you doing that?
20121008 04:06:28< skyfaller> in debug mode? :turn 1
20121008 04:06:33< skyfaller> where 1 is the number of the turn that you want
20121008 04:07:09< mattsc> As far as I know, you cannot do that from WML (or Lua).  So you'd really have to do it manually.
20121008 04:07:13< skyfaller> oh
20121008 04:07:17< skyfaller> obnoxious
20121008 04:07:37< skyfaller> why would you be able to do it manually but not automatically?
20121008 04:07:38< mattsc> I'm pretty sure I have tried that.  Let me check something really quickly.
20121008 04:09:15< mattsc> Yeah, while it is possible to adjust the value of the 'turn_number'
20121008 04:09:51< mattsc> variable, it does not make a difference and is back to where it was before after you end the turn (to the next turn, I mean).
20121008 04:10:35< skyfaller> mattsc: OK, I'm also confused as to what the "reset vars" option does, and when I need to use it
20121008 04:12:01< mattsc> There are certain variables that get set during Fred's turn, such as where to set up a defensive line.
20121008 04:13:11< mattsc> These need to be set once per turn, otherwise you get some really weird (bad) behavior, and then should not change any more during that turn (or at least they should not change unless ... some condition is met)
20121008 04:13:31< mattsc> However, when you go to the next turn, they need to be reset.
20121008 04:14:25< mattsc> Thus, if you want to test a CA as if it were the beginning of the turn, you need to reset them first.  However, if you want to go through a series of CAs as they happen _during_ a turn, you do not want to reset them.
20121008 04:15:12< mattsc> Most of the time this won't make a difference, but there are some cases when it does.
20121008 04:15:32< mattsc> Does that make any sense?
20121008 04:20:36< skyfaller> oh, I see
20121008 04:21:10< skyfaller> wait, no, I don't see
20121008 04:21:40< skyfaller> so are the vars being reset at the beginning of each turn automatically, or must I always do it manually while CA debugging?
20121008 04:22:32< mattsc> Before I reply: the error message for when in control of Side 2 has been added
20121008 04:22:39< skyfaller> yay :)
20121008 04:23:13< mattsc> It _should_ be done at the beginning of each turn.  As well as at the beginning of "play AI turn".  But it isn't yet.
20121008 04:23:22< mattsc> I'll add that too.
20121008 04:23:22< skyfaller> ah
20121008 04:23:28< skyfaller> ok, please do make that happen :)
20121008 04:23:43< skyfaller> b/c that probably explains some bizarre / bad behavior I'm seeing from Fred at the moment
20121008 04:24:01< skyfaller> he's stopped moving forward on the left side, leaving his forward village open
20121008 04:24:02< mattsc> I'm not sure about that last statement.  :)
20121008 04:24:52< mattsc> I'd rather suspect that the reason for that is that the whole zone_control thing is still in disarray.
20121008 04:24:57< skyfaller> ok, maybe that statement is not true then
20121008 04:25:17< skyfaller> b/c I just ran reset the vars and ran the turn again and he is still not moving even though two units still have move points
20121008 04:26:00< mattsc> yep.  I'm aware of that problem.
20121008 04:26:26< mattsc> In "real Fred" mode, the RCA AI does something semi-useful with those units, but that's not part of debug-CA mode
20121008 04:26:45< mattsc> I just haven't gotten around to that yet
20121008 04:28:19< skyfaller> um, Fred moved to attack but did not actually attack any of my units, even though it is night
20121008 04:29:37< mattsc> I'm not taking complaints about Fred at this time, only about the debug mechanism.  :D
20121008 04:30:20< skyfaller> hahahaha
20121008 04:30:34< skyfaller> I guess it seems to be fine
20121008 04:30:43< skyfaller> aside from the complaints I've already made
20121008 04:30:44< mattsc> But seriously, the zone_control CA still has quite a few serious problems.  I'll get back to those as soon as I am done with the debug stuff.
20121008 04:30:57< skyfaller> having to remember to reset the vars manually will probably lead to human error :)
20121008 04:31:27< mattsc> I'm already done doing that for the "play ai turn" case
20121008 04:31:38< skyfaller> cool
20121008 04:31:38< mattsc> The beginning of turn case is slightly more work.
20121008 04:31:51< skyfaller> ok
20121008 04:32:12< mattsc> or at least I need to think about which of the gazillion ways to do this I like best  :)
20121008 04:32:35< mattsc> I will still leave the option to do it manually in there, because sometimes I will want to use that
20121008 04:33:05< skyfaller> yeah
20121008 04:34:51< mattsc> ok, it seems to work for "play ai turn".  Committed.
20121008 04:35:36< skyfaller> w00t
20121008 04:35:46< mattsc> So, doing it automatically at the beginning of a turn is the last thing to do, I think  I've already taken care of your other comments, right?
20121008 04:35:58< skyfaller> I think so
20121008 04:36:34< skyfaller> I guess you've been leaving the CA debug variable set to "true" in the repository, right?
20121008 04:37:03< mattsc> Accidentally.  It should be reset to false now.
20121008 04:37:11< mattsc> ... as of the latest commit
20121008 04:38:13< skyfaller> ok :)
20121008 04:38:47< skyfaller> I actually like leaving it true so that I don't have to keep manually putting it back
20121008 04:39:09< skyfaller> I mean, anyone who starts the game in debug mode shouldn't be upset about extra debugging options, right?
20121008 04:39:27< skyfaller> what normal human starts Wesnoth in debug mode?
20121008 04:39:34< mattsc> I do  :D
20121008 04:39:42< skyfaller> :P
20121008 04:39:52< skyfaller> you're claiming you're normal?
20121008 04:40:04< mattsc> Well, ok, you got a point there ...
20121008 04:40:22< mattsc> Anyway...
20121008 04:40:40< mattsc> I need to take care of something else (non-Wesnoth) for a little.  I'll get back to this later.  And then I'll see if I can fix your test case savefile as well.
20121008 04:40:49< skyfaller> ok, have fun :)
20121008 04:51:49< mattsc> skyfaller: one more question: in which order would you prefer the menu options to be?  Given what we said, moving "reset vars" to the very end makes sense, I think.  Something else?
20121008 04:56:48< skyfaller> mattsc: I dunno, the current order seems relatively logical to me
20121008 04:59:59< mattsc> skyfaller: sounds good.  In the meantime, I had another 15min and did the beginning-of-turn resetting also
20121008 05:00:33< mattsc> I'll try to do the savefile later.  And, of course, the wiki needs to be updated, but I won't do that today any more.
20121008 05:06:41< skyfaller> the colors of the rings in front of each option may not be idea, it looks to me like the first and last rings are both a white-ish blue
20121008 05:07:12< skyfaller> but that's a pretty minor nitpick
20121008 05:07:50< mattsc> So you'd rather have them all be the same color?
20121008 05:08:01< skyfaller> no, all different colors
20121008 05:08:09< skyfaller> like, maybe rainbow from top to bottom
20121008 05:08:26< skyfaller> I'm saying that I couldn't distinguish the first and last color from one another
20121008 05:08:34< skyfaller> and both are pretty close to the blue ring in the middle
20121008 05:08:41< mattsc> Problem with that is that there are only 5 different ring png's in mainline
20121008 05:08:46< skyfaller> ah, I see
20121008 05:08:48< skyfaller> ideally we'd have little icons for each thing that are different
20121008 05:08:56< skyfaller> but I have no idea how to illustrate some of these options
20121008 05:08:57< mattsc> That's because the first and last ring are the same color  
20121008 05:09:01< skyfaller> ah :)
20121008 05:09:38< mattsc> I just went with quick and easy.  If you have better images, by all means include them.
20121008 05:09:52< skyfaller> yeah, nevermind, I'll monkey with it if I get bored
20121008 05:10:02< mattsc> ok
20121008 05:10:05< skyfaller> maybe "play an entire AI turn" could be a general exerting leadership
20121008 05:10:14< skyfaller> and "reset" could be some kind of explosion
20121008 05:10:17< skyfaller> I don't know
20121008 05:10:27< skyfaller> where do you find the images / icons?
20121008 05:10:40< mattsc> You know where the core folder is?
20121008 05:10:56< skyfaller> no
20121008 05:11:07< mattsc> '/Applications/Wesnoth-1.10.app/Contents/Resources/data/core'
20121008 05:11:25< skyfaller> ok
20121008 05:11:34< mattsc> There's a directory images/ underneath with all the png's
20121008 05:12:08< mattsc> Note though that for the menu items we only want a 20x20 cut from those images, while a lot of them are larger
20121008 05:12:32< mattsc> This is done, for example, like this:
20121008 05:12:47< mattsc>             image=items/ring-red.png~CROP(26,26,20,20)
20121008 05:13:01< mattsc> in multiplayer/era.cfg
20121008 05:16:15< skyfaller> I see
20121008 05:49:31< mattsc> skyfaller: still here?
20121008 05:53:00< mattsc> I fixed the test case savefile so that it contains all the new right-click options.  I just PMed it to you.
20121008 05:54:24< mattsc> Could you test it and then either tell me if there are problems (it seemed to work for me) or otherwise replace the one in your post with the new version?
20121008 05:56:07< skyfaller> mattsc: OK, I'll take a look
20121008 06:00:36< skyfaller> mattsc: how do I tell if the resetting of vars is working correctly?
20121008 06:01:38< mattsc> there's no easy way.  but I did pretty intensive testing, so hopefully we're ok.
20121008 06:02:04< mattsc> all the ways to actually display that information are rather annoying...
20121008 06:02:31< mattsc> ... so I opted for not including it
20121008 06:03:56< skyfaller> ok, it seems to work fine
20121008 06:04:09< skyfaller> I guess I will repost it to the forum
20121008 06:04:32< skyfaller> so the old version will not work in the latest version of Fred?
20121008 06:05:01< skyfaller> mattsc: is it true that the old replay will not work in current Github Fred?
20121008 06:05:03< mattsc> that's correct
20121008 06:05:12< skyfaller> ok
20121008 06:05:29< mattsc> I had to shuffle around too many things, so the functions have different names etc.
20121008 06:05:57< mattsc> Ugh - of course that also means that the new version will not work with the current release version of Fred...
20121008 06:06:07< skyfaller> hahahaha
20121008 06:06:11< mattsc> But then, nobody but you and me will try to use this anyway.  :P
20121008 06:06:29< mattsc> So I am not going to push out another release right now unless somebody complains.
20121008 06:07:01< mattsc> Well, thanks for all the testing today.  I'm off then for tonight.  And tomorrow I'll get back to actually working on Fred himself.
20121008 06:07:06< skyfaller> ok :)
20121008 06:07:15< mattsc> ciao
20121008 06:07:21< skyfaller> what happens if you try to load the old savegame? no CA Debugger?
20121008 06:07:46< mattsc> it'll probably crash once you try to use one of the menu options.  Maybe even earlier.
20121008 06:07:52< skyfaller> ha, ok :)
20121008 06:10:09-!- Alarantalara [~Adium@173.33.158.188] has joined #wesnoth-umc-dev
20121008 06:39:12-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Quit: I'm a teapot.]
20121008 06:40:14< Alarantalara> mattsc: [modify_turns] supposedly lets you change the current turn with "current=x"
20121008 06:44:59-!- Alarantalara [~Adium@173.33.158.188] has quit [Quit: Leaving.]
20121008 08:21:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev
20121008 08:52:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20121008 09:20:48-!- irker809 [~irker@ai0867.net] has joined #wesnoth-umc-dev
20121008 09:20:48< irker809> wesnoth-umc-dev: faabumc * r16061 /trunk/Nightmares_of_Meloen/_main.cfg:
20121008 09:20:48< irker809> NoM WC: disable NoM WC due to changes in WC breaking compatibility
20121008 10:08:57-!- vultraz [~vultraz@124.109.10.167] has quit [Read error: Connection reset by peer]
20121008 10:59:58-!- vultraz [~vultraz@124.109.10.167] has joined #wesnoth-umc-dev
20121008 12:11:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev
20121008 13:39:01-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-umc-dev
20121008 13:39:04-!- mode/#wesnoth-umc-dev [+v loonybot] by ChanServ
20121008 16:24:48-!- csarmi [csarmi@94-21-114-26.pool.digikabel.hu] has joined #wesnoth-umc-dev
20121008 16:26:15-!- csarmi [csarmi@94-21-114-26.pool.digikabel.hu] has quit [Client Quit]
20121008 16:32:39< mattsc> Alarantalara, skyfaller: indeed that works.  Don't know how I missed that!
20121008 16:33:01< mattsc> So the latest version only plays through one turn and then resets the turn number.
20121008 17:02:28< mattsc> skyfaller: and now there's also a menu option for displaying the content of the 'self.data' variable, to see whether it has been (or needs to be) reset
20121008 17:02:45< mattsc> This is combined with the 'reset vars' option because there can only be 7 custom menu items.
20121008 17:45:49-!- vultraz_laptop [~chatzilla@124.109.10.167] has joined #wesnoth-umc-dev
20121008 17:48:52-!- vultraz [~vultraz@124.109.10.167] has quit [Ping timeout: 246 seconds]
20121008 17:57:38-!- vultraz [~vultraz@124.109.10.167] has joined #wesnoth-umc-dev
20121008 18:05:46-!- vultraz [~vultraz@124.109.10.167] has quit [Ping timeout: 246 seconds]
20121008 18:15:18-!- vultraz [~vultraz@124.109.10.167] has joined #wesnoth-umc-dev
20121008 18:15:27-!- irker809 [~irker@ai0867.net] has quit [Remote host closed the connection]
20121008 18:59:41-!- Alarantalara [~Adium@173.33.158.188] has joined #wesnoth-umc-dev
20121008 19:43:14< skyfaller> ah, cool
20121008 22:12:25< mattsc> skyfaller, Alarantalara: updated the CA debugger wiki page.  Feel free to change things if they are not clear enough.
20121008 22:17:54-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-umc-dev
20121008 22:52:00-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 260 seconds]
20121008 23:09:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
--- Log closed Tue Oct 09 00:00:16 2012