--- Log opened Thu Dec 13 00:00:36 2012
20121213 00:04:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20121213 00:05:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20121213 00:37:22-!- Blueblaze [~Blueblaze@adsl-76-202-17-213.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20121213 00:37:51-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20121213 00:37:51-!- Upth is now known as Upthorn
20121213 00:52:39-!- Blueblaze [~Blueblaze@adsl-76-202-17-213.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20121213 00:58:59-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has joined #wesnoth-dev
20121213 01:02:32-!- mjs-de [~mjs-de@d118217.adsl.hansenet.de] has quit [Remote host closed the connection]
20121213 01:05:31-!- mnewton1 [~mnewton1@c-76-99-170-226.hsd1.de.comcast.net] has quit [Quit: Rice and Corn]
20121213 01:17:32-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20121213 01:18:06-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20121213 01:18:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20121213 01:34:24-!- {V} [~V@139-79-ftth.on.nl] has quit [Read error: Connection reset by peer]
20121213 01:34:55-!- {V} [~V@139-79-ftth.on.nl] has joined #wesnoth-dev
20121213 01:47:18-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20121213 01:48:31-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has joined #wesnoth-dev
20121213 01:58:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20121213 02:15:51-!- wesbot_ [~wesbot@asteria.debian.or.at] has joined #wesnoth-dev
20121213 02:16:32-!- faabumc [~vcr@wesnoth/developer/faabumc] has joined #wesnoth-dev
20121213 02:18:17-!- wesbot [~wesbot@wesnoth/bot/wesbot] has quit [Ping timeout: 264 seconds]
20121213 02:18:17-!- wesbot_ is now known as wesbot
20121213 02:24:46-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20121213 02:41:04-!- irker669 [~irker@ai0867.net] has joined #wesnoth-dev
20121213 02:41:05< irker669> wesnoth: fendrin * r55850 /trunk/src/editor/editor_main.hpp: 
20121213 02:41:05< irker669> wesnoth: Typo fix in comment.
20121213 02:43:50< irker669> wesnoth: fendrin * r55851 /trunk/src/editor/editor_main.cpp: 
20121213 02:43:51< irker669> wesnoth: Reenabled the check for possibly leaked editor_action instances.
20121213 02:55:04< irker669> wesnoth: fendrin * r55852 /trunk/src/editor/map/editor_map.hpp: 
20121213 02:55:04< irker669> wesnoth: Fixed typo in a comment.
20121213 03:21:35-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has quit []
20121213 03:24:11-!- csarmi [~csarmi@host-93-92-56-147.comunique.hu] has quit []
20121213 03:28:40-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20121213 03:30:41< irker669> wesnoth: jamit * r55853 /trunk/src/shared_object.hpp: 
20121213 03:30:42< irker669> wesnoth: Provide an overload for assigning a shared_object from its template type.
20121213 03:30:42< irker669> wesnoth: This is a little more efficient (only one intermediate shared_object needs
20121213 03:30:43< irker669> wesnoth: to be created) and allows a constructor to be flagged explicit.
20121213 03:39:38< irker669> wesnoth: jamit * r55854 /trunk/src/shared_object.hpp: 
20121213 03:39:39< irker669> wesnoth: Was missing the first line with the $Id info.
20121213 03:51:45-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has joined #wesnoth-dev
20121213 03:56:43-!- mattsc [~mattsc@202.52.53.227] has joined #wesnoth-dev
20121213 04:07:53-!- un214 [~un214@adsl-108-204-254-2.dsl.scrm01.sbcglobal.net] has joined #wesnoth-dev
20121213 04:14:28< irker669> wesnoth: alarantalara * r55855 /trunk/data/_main.cfg: 
20121213 04:14:29< irker669> wesnoth: Move test/set for NO_TERRAIN_GRAPHICS before loading core since core/_main.cfg cares if it is set
20121213 04:20:02-!- gh0st [~gh0st@89.31.118.161] has joined #wesnoth-dev
20121213 04:24:30< irker669> wesnoth: jamit * r55856 /trunk/src/tstring.hpp: 
20121213 04:24:31< irker669> wesnoth: Flag some constructors "explicit".
20121213 04:45:21-!- Ivanovic_ [~ivanovic@dtmd-4db2b8bf.pool.mediaWays.net] has joined #wesnoth-dev
20121213 04:48:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20121213 04:55:34-!- aksshay [~aksshay@182.68.193.9] has joined #wesnoth-dev
20121213 04:55:40< aksshay> hi
20121213 04:57:40-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has left #wesnoth-dev []
20121213 04:57:51-!- Alarantalara [~Adium@CPEc0c1c09e8055-CM00252eac6d62.cpe.net.cable.rogers.com] has joined #wesnoth-dev
20121213 04:58:49< Espreon> aksshay: Hello.
20121213 05:02:01< aksshay> hi Espreon 
20121213 05:02:18< un214> yay Espreon is still alive
20121213 05:02:56< aksshay> i need little help, actually i am working on creating units.  
20121213 05:03:20< un214> isn't that what liches do? /ducks
20121213 05:07:13-!- aksshay [~aksshay@182.68.193.9] has quit [Ping timeout: 245 seconds]
20121213 05:13:17-!- Stallmanu [~gum@dsl-69-171-140-97.acanac.net] has joined #wesnoth-dev
20121213 05:17:40-!- Tx83 [~Tx83@dsl-173-206-32-155.tor.primus.ca] has joined #wesnoth-dev
20121213 05:22:31< Espreon> un214: BTW, someone translated Story of Wose to Hungarian, so you might wanna grab the mo for it off of WesCamp.
20121213 05:23:24< un214> yeah
20121213 05:23:34< un214> My working copy's kind of cut up right now though
20121213 05:24:12< Espreon> Oh?
20121213 05:24:31< un214> yeah I was working on a new feature and it's not quite working
20121213 05:24:50< Espreon> What feature would that be?
20121213 05:24:58< un214> difficulty "impossible"
20121213 05:26:09< gh0st> Alarantalara: ok, i cleaned up my code, looks much better i think. http://pastebin.com/Wg1TbLjg
20121213 05:38:03-!- Tack2 [~Tx83@dsl-173-206-13-170.tor.primus.ca] has joined #wesnoth-dev
20121213 05:40:20-!- Tx83 [~Tx83@dsl-173-206-32-155.tor.primus.ca] has quit [Read error: Operation timed out]
20121213 05:43:09-!- un214 [~un214@adsl-108-204-254-2.dsl.scrm01.sbcglobal.net] has quit [Remote host closed the connection]
20121213 05:48:29-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20121213 05:52:50-!- Stallmanu [~gum@dsl-69-171-140-97.acanac.net] has quit [Quit: Leaving]
20121213 06:04:50-!- Tack2 [~Tx83@dsl-173-206-13-170.tor.primus.ca] has quit [Quit: like a buttmad sonyfag]
20121213 06:24:26-!- faabumc [~vcr@wesnoth/developer/faabumc] has quit [Quit: Ex-Chat]
20121213 06:35:45-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20121213 07:07:21< mattsc> Hey, all.  Is there a way to set up (or fake) a campaign-wide global Lua variable?  (not scenario-wide, but campaign-wide)  Here's the reason for the question:
20121213 07:09:04< mattsc> In the AI code we're writing, there are a lot of places where we load local library files.  If I copy all the AI code into another campaign, I'd like to only change the path to those library function in one place, not having to change it everywhere.
20121213 07:09:41< mattsc> Macro substitution in preprocessing does not work for wesnoth.require() lines.
20121213 07:11:02< mattsc> Also, some of the code is outside scenarios (setting up AI wml tags), so preload events cannot be used.
20121213 07:11:37< mattsc> Or at least I haven't figured out how to do any of this.  I feel like I am missing something simple...
20121213 07:30:11< mattsc> I guess I could use a preload event for the scenario code, and a lua variable in the code block defining the tags.  I think that would work.
20121213 07:43:20-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has joined #wesnoth-dev
20121213 07:51:45-!- Ivanovic_ [~ivanovic@dtmd-4db2b8bf.pool.mediaWays.net] has quit [Changing host]
20121213 07:51:45-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20121213 07:53:37-!- Ivanovic_ is now known as Ivanovic
20121213 07:56:36-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has quit [Quit: Leaving]
20121213 08:50:27-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20121213 09:02:19-!- ancestral [~ancestral@65-128-234-158.mpls.qwest.net] has quit [Quit: ancestral]
20121213 09:19:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20121213 09:23:28-!- ejls [~Epsilon01@mszy.domu.7un.net] has quit [Ping timeout: 246 seconds]
20121213 09:30:41-!- ejls [~Epsilon01@mszy.domu.7un.net] has joined #wesnoth-dev
20121213 09:33:44-!- stikonas [~gentoo@5.20.200.50] has joined #wesnoth-dev
20121213 09:33:44-!- stikonas [~gentoo@5.20.200.50] has quit [Changing host]
20121213 09:33:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20121213 09:43:57-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has joined #wesnoth-dev
20121213 09:49:23-!- Smar [smar@freenet/translator/finnish/Smar] has quit [Read error: Operation timed out]
20121213 09:50:16< mattsc> Hmm, I can actually add a field to the wesnoth table (which, obviously, is global) and recall the value of that field later.
20121213 09:50:34< mattsc> Somehow it feels like I should not do that ...
20121213 09:57:22-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 265 seconds]
20121213 10:04:21-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20121213 10:17:55-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection]
20121213 11:06:55-!- Smar [~smar@dsl-hkibrasgw3-ffd4c300-197.dhcp.inet.fi] has joined #wesnoth-dev
20121213 11:06:55-!- Smar [~smar@dsl-hkibrasgw3-ffd4c300-197.dhcp.inet.fi] has quit [Changing host]
20121213 11:06:55-!- Smar [~smar@freenet/translator/finnish/Smar] has joined #wesnoth-dev
20121213 11:55:02-!- mjs-de [~mjs-de@d189029.adsl.hansenet.de] has joined #wesnoth-dev
20121213 12:02:35-!- irker669 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20121213 12:10:02-!- lipkab [~the_new_l@2001:738:5404:192:c40e:8420:ee64:58b2] has joined #wesnoth-dev
20121213 12:25:48< lipkab> mattsc: WML variables are all global and (I guess) you can access WML variables from within Lua.
20121213 12:27:11< mattsc> lipkab: thanks.  Yes, I should have said that I was looking for options other than using WML variables
20121213 12:28:22< lipkab> I don't know about that, sorry.
20121213 12:30:13< mattsc> Thanks.  As I wrote, I found out in the meantime that I can add things to the wesnoth variable itself (I would have expected that to be read-only), but that just feels wrong ...
20121213 12:36:36-!- mattsc [~mattsc@202.52.53.227] has quit [Quit: I'm asleep]
20121213 12:51:47-!- lipkab [~the_new_l@2001:738:5404:192:c40e:8420:ee64:58b2] has quit [Quit: - )]
20121213 13:03:37-!- mattsc [~mattsc@115.115.140.98] has joined #wesnoth-dev
20121213 13:05:53-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has joined #wesnoth-dev
20121213 13:51:45-!- loonybot [~loonybot@ppp91-78-91-3.pppoe.mtu-net.ru] has joined #wesnoth-dev
20121213 13:51:45-!- loonybot [~loonybot@ppp91-78-91-3.pppoe.mtu-net.ru] has quit [Changing host]
20121213 13:51:45-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20121213 13:57:41-!- mattsc [~mattsc@115.115.140.98] has quit [Quit: I'm asleep]
20121213 14:26:43-!- aksshay [~aksshay@182.68.110.198] has joined #wesnoth-dev
20121213 14:27:00< aksshay> hello everyone
20121213 14:29:01< boucman_work> hello
20121213 14:29:24< aksshay> hello boucman_work 
20121213 14:30:01< aksshay> i need a little help, i am designing some characters, and i want to those characters to be added in that game
20121213 14:30:11< aksshay> from whom should i connect?
20121213 14:30:26< aksshay> could you please tell me who is the right person?
20121213 14:32:50< zookeeper> aksshay, i think you need to explain what you want a bit better
20121213 14:33:04< aksshay> https://lh6.googleusercontent.com/-AmbttisNJ5w/UFim5FQIqBI/AAAAAAAAACE/dXzhDuF-1zQ/s548/character.jpg
20121213 14:34:01< aksshay> this is my character. and i am creating more, so that to make an complete team like rebels, dwarves (6 characters)
20121213 14:34:36< aksshay> sorry for bad english
20121213 14:34:56< aksshay> and i want to add them in game, so how to add? 
20121213 14:35:04< aksshay> what is the right procedure?
20121213 14:35:21< aksshay> thanks for help 
20121213 14:35:57< zookeeper> well... you need to make an era, which contains a faction which contains the new unit types you need to make, which use the images you've drawn.
20121213 14:36:19< zookeeper> for starters, i'd suggest downloading some simple MP era from the add-on server and use that as an example
20121213 14:36:54< zookeeper> the Default+Khalifate Era would be a good one to use as a base.
20121213 14:37:13< aksshay> i am done with the factions, have you seen the image link i added here?
20121213 14:37:28< zookeeper> yes
20121213 14:37:53< zookeeper> it will look terrible in-game though, because it'll appear in a white box.
20121213 14:38:04< zookeeper> (because your image has a white background)
20121213 14:38:08< aksshay> Well, i will make changes in it
20121213 14:38:31< aksshay> according to the requirements, but don't know what to do next.
20121213 14:38:32< zookeeper> ok, so. you have a portrait, and you want your unit(s) to use that portrait?
20121213 14:38:38< aksshay> i am done with six characters.
20121213 14:38:45< aksshay> yes
20121213 14:39:12< zookeeper> do you have any other custom images which work?
20121213 14:39:22< aksshay> yes, 
20121213 14:39:44< aksshay> the water girl, air girl .. i created myself
20121213 14:40:32< zookeeper> ok, well, if you have an image youraddon/images/portraits/x.png then you just add profile=portraits/x.png into your [unit_type]
20121213 14:40:34< aksshay> and 3 more
20121213 14:40:50< aksshay> okay, 
20121213 14:41:33< aksshay> and how to set attack and other stuff, (coding section) as i am only artist
20121213 14:42:20< aksshay> dont know much about that
20121213 14:43:01< zookeeper> look at how other units define their attacks and other stuff, and use http://wiki.wesnoth.org/ReferenceWML to look up things when necessary
20121213 14:43:45< aksshay> okay, thanks a lot
20121213 14:44:03< aksshay> hope i will be able to add soon. Thanks for your precious time :)
20121213 14:44:19< zookeeper> no problem
20121213 14:45:30< aksshay> your id is quite interesting .. zookeeper 
20121213 14:59:08-!- artisticdude [~artisticd@57.sub-70-192-193.myvzw.com] has joined #wesnoth-dev
20121213 15:09:18-!- mattsc [~mattsc@115.115.140.98] has joined #wesnoth-dev
20121213 15:22:52-!- irker685 [~irker@ai0867.net] has joined #wesnoth-dev
20121213 15:22:52< irker685> wesnoth: jamit * r55857 /trunk/src/ (tstring.hpp shared_object.hpp): 
20121213 15:22:52< irker685> wesnoth: Change some implicit conversions to return const references to objects instead of temporary objects.
20121213 15:22:52< irker685> wesnoth: Fixes bug #20360.
20121213 15:44:02-!- artisticdude [~artisticd@57.sub-70-192-193.myvzw.com] has left #wesnoth-dev []
20121213 15:58:31-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20121213 16:03:03-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Ping timeout: 245 seconds]
20121213 16:03:05-!- horon [~horon@nttkyo042189.tkyo.nt.ngn2.ppp.infoweb.ne.jp] has quit [Quit: Leaving...]
20121213 16:04:33-!- mattsc [~mattsc@115.115.140.98] has quit [Quit: bye]
20121213 16:09:38-!- skyfaller [~skyfaller@ool-43551edd.dyn.optonline.net] has joined #wesnoth-dev
20121213 16:09:39-!- skyfaller [~skyfaller@ool-43551edd.dyn.optonline.net] has quit [Changing host]
20121213 16:09:39-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20121213 16:17:13-!- knotwork [~markm@unaffiliated/knotwork] has quit [Read error: Connection reset by peer]
20121213 16:20:56-!- fiveop [~fiveop@p4FCDFFAA.dip.t-dialin.net] has joined #wesnoth-dev
20121213 16:23:06< fiveop> I have looked at it for a while, but couldn't figure it out: How does wesnoth scale the main menu, if you resize the window.
20121213 16:23:50< fiveop> are all SDL surfaces scaled appropriately?
20121213 16:28:29-!- knotwork [~markm@142.68.139.234] has joined #wesnoth-dev
20121213 16:28:29-!- knotwork [~markm@142.68.139.234] has quit [Changing host]
20121213 16:28:29-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20121213 16:34:31-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection]
20121213 16:36:08-!- aksshay [~aksshay@182.68.110.198] has quit [Ping timeout: 265 seconds]
20121213 16:52:12< irker685> wesnoth: jamit * r55858 /trunk/src/ (tstring.cpp tstring.hpp): 
20121213 16:52:12< irker685> wesnoth: Restore r44429, by removing r44567 and the follow-ups r44568 and r44935.
20121213 16:52:13< irker685> wesnoth: In theory, the underlying bug has been fixed, so no need for the special
20121213 16:52:14< irker685> wesnoth: code for MSC. If this is not the case (the symptom would be "the windows
20121213 16:52:14< irker685> wesnoth: executable crashes immediately before loading the main menu"), feel free
20121213 16:52:15< irker685> wesnoth: to revert this.
20121213 16:52:30-!- [Relic] [~relic@99-58-54-211.lightspeed.milwwi.sbcglobal.net] has joined #wesnoth-dev
20121213 16:54:00< jamit> I hope that doesn't break Windows. The theory is fairly sound though, and the symptom is a dead match for bug #20360.
20121213 16:56:43< fiveop> Is there anywhere a more comprehensive set of rules how code is supposed to look like than can be found at http://wiki.wesnoth.org/CodingStandards ?
20121213 16:56:58-!- prkc [~negusnyul@dsl4E5CCEF9.pool.t-online.hu] has joined #wesnoth-dev
20121213 17:01:02< jamit> fiveop: That's the only set of rules I know of. How would you want it to be more comprehensive?
20121213 17:07:18< fiveop> I have various questions, that aren't answered there.
20121213 17:07:28< fiveop> Like what c++ standard do you expect to follow.
20121213 17:07:39< fiveop> May one use c++11 features?
20121213 17:09:22< fiveop> First file I look at. (about.hpp), why aren't the respective header files included instead of declaring 'class display;' etc.? Why are the class declarations between includes (which does not seem necessary)? What's the policy? :)
20121213 17:09:40-!- martin_bede [~martin@dsl51B61D65.pool.t-online.hu] has joined #wesnoth-dev
20121213 17:09:56-!- aksshay [~aksshay@182.68.110.198] has joined #wesnoth-dev
20121213 17:10:38< fiveop> I'll write a forum post.
20121213 17:10:58< jamit> I believe C++11 features should be avoided since there are some platforms with insufficient C++11 support, but I forget where I picked that up.
20121213 17:11:44< jamit> Declaring a class instead of including a header file reduces the header file dependencies, which can lead to faster recompiles if one of the header files needs to be changed.
20121213 17:12:41< fiveop> so one should do this if possible?
20121213 17:12:43< jamit> For example, if a change is made to config.hpp, then with the current setup a file that includes about.hpp might not need to be recompiled. But if about.hpp included config.hpp, then it would need to be.
20121213 17:13:58< jamit> I don't know if the project has a standard covering that, but yes, minimal header files tend to make recompiles faster, which tends to be desirable. ;)
20121213 17:14:22< fiveop> Right, so one should only include the header respective, if the file (header/file) referes to members of a type?
20121213 17:14:43< jamit> The class declarations between the includes is probably just how someone felt like doing things at the time.
20121213 17:15:32< jamit> I go with the criteria of "if the compiler does not complain, I don't need the full #include".
20121213 17:15:37< fiveop> A few days ago, I thought about working a bit on wesnoth. But the code is such a mess, that I have the urge to 'clean it up'. My problem is, before I do that, I would need to know what the standard is.
20121213 17:15:47< fiveop> But if there is none, that would be something I could start with.
20121213 17:15:58< fiveop> Make a suggestion for a comprehensive style guide :)
20121213 17:17:09< jamit> Yes, a forum post might be good for that.
20121213 17:44:43-!- gh0st [~gh0st@89.31.118.161] has quit [Ping timeout: 245 seconds]
20121213 18:06:11< fiveop> the lines at the top of source files. Where do they come from?
20121213 18:09:48-!- aksshay [~aksshay@182.68.110.198] has quit [Ping timeout: 264 seconds]
20121213 18:28:37-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20121213 18:29:09< jamit> fiveop: There is a template for new files called boiler-plate-header.cpp (not that I remembered it when I was splitting files...)
20121213 18:31:54< irker685> wesnoth: jamit * r55859 /trunk/src/ (config.cpp config.hpp): 
20121213 18:31:55< irker685> wesnoth: Reordering some (attribute_value) functions, grouping functions with a similar
20121213 18:31:55< irker685> wesnoth: purpose, and making the orders of the header and implementation files match.
20121213 18:36:07< Soliton> fiveop: if you want people to adhere to more code style rules (in the sense of indentation and whatnot) then i suggest instead you work on a scripted solution (using astyle for example) that can be applied automatically.
20121213 18:36:25< Soliton> anything else is just asking for more work for little gain.
20121213 19:33:23< fiveop> I think, I don't want people to adhere to it, but rather have a set of rules that I may apply throughout the sources without anyone having a fit :)
20121213 19:34:34< fiveop> But according to that last revision message, jamit seems to be doing something quite similar ... cleaning up ;)
20121213 19:38:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20121213 19:39:29< jamit> Oh, I've been cleaning up sources for a while now. I just don't make it a point to seek out things to clean up for the sake of cleaning up. In this case, I have some revisions for the attribute_value class and the cleanup is just prep work.
20121213 19:39:55< jamit> The alternative would have been to cause the code to get even messier, and I do not want that.
20121213 19:40:39-!- timotei [~timotei@79.119.96.79] has joined #wesnoth-dev
20121213 19:40:40-!- timotei [~timotei@79.119.96.79] has quit [Changing host]
20121213 19:40:40-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20121213 19:40:51< jamit> Well, this next commit is not needed to prevent things from getting messier, but since I'm cleaning anyway....
20121213 19:40:57< fiveop> :)
20121213 19:42:49< irker685> wesnoth: jamit * r55860 /trunk/src/ (5 files in 3 dirs): 
20121213 19:42:49< irker685> wesnoth: End a private data member name with an underscore.
20121213 19:47:01< Soliton> "don't make it a point to seek out things to clean up for the sake of cleaning up" <- that's one point i was going for. a lot of commits shuffling things around is not helping. neither is making up rules that are not going to (at least tried to) get enforced.
20121213 19:47:38-!- martin_bede [~martin@dsl51B61D65.pool.t-online.hu] has quit [Quit: Bye]
20121213 19:49:07< Soliton> from what i can tell jamit is doing a good job of cleaning code up to actually fix bugs/make the code more robust. that's very helpful.
20121213 19:56:48< Soliton> (not saying there can't be useful additions to our coding standards. just wary of over enthusiastic rewriting of code while getting a handle on how wesnoth works.)
20121213 19:57:47< fiveop> That why I'm trying to get to know, what is and what isn't desired.
20121213 19:58:01< fiveop> before doing anything ;)
20121213 19:58:42< Soliton> certainly a clever approach. :-)
20121213 20:11:02-!- exciton [chuck-the-@89.208.169.104] has quit [Read error: Connection reset by peer]
20121213 20:11:15-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20121213 20:11:16-!- exciton [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20121213 20:11:49-!- anonymissimus [~chatzilla@HSI-KBW-078-042-163-136.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20121213 20:13:36-!- mordante [~mordante@roadie.xs4all.nl] has joined #wesnoth-dev
20121213 20:13:37-!- mordante [~mordante@roadie.xs4all.nl] has quit [Changing host]
20121213 20:13:37-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20121213 20:13:51< mordante> servus
20121213 20:14:52< anonymissimus> mattsc: the whole lua state is destructed upon scenario exit or reload, so no, there's no way to have a "campaign-wide lua variable"
20121213 20:15:44< anonymissimus> mattsc: you need to temporarily save it into the safile; you could use wesnoth.game_events.on_save /.on_load to save/retrieve whatever you need
20121213 20:16:18-!- Upthorn [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has quit [Ping timeout: 255 seconds]
20121213 20:16:44< anonymissimus> the lua state being destructed also "clears" everything saved into the wesnoth table and all global lua variables
20121213 20:17:27< irker685> wesnoth: mordante * r55861 /trunk/src/network.cpp: 
20121213 20:17:28< irker685> wesnoth: Fix a compiler warning.
20121213 20:20:03-!- Elvish_Pillager [~eli@66-189-34-122.dhcp.oxfr.ma.charter.com] has joined #wesnoth-dev
20121213 20:20:46-!- wesbot changed the topic of #wesnoth-dev to: released 1.11.1, announcing "soon" | 185 bugs, 330 feature requests, 15 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use a pastebin: http://pastebin.com | http://imagebin.org
20121213 20:24:36< anonymissimus> fiveop: c++11: pls don't (or I will way have probs to compile...); I think even gcc doesn't support all yet
20121213 20:25:39< mordante> gcc has experimental support for C++11
20121213 20:26:20< mordante> but not every distribution ships a version that can be used
20121213 20:29:11-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 252 seconds]
20121213 20:33:10< anonymissimus> jamit: btw, are you done with the sighted event bugs now, or would you still advise it to not be used ?
20121213 20:34:17-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20121213 20:34:23< anonymissimus> I was wondering about something like putting a redundant sighted event into the sighted event workaround, and whenever a case happens when the workaround fires, but the original does not, we annoy the player with a message to please report this bug
20121213 20:35:07< anonymissimus> now, hopefully there aren't any cases when the workaround fires but the original shouldn't
20121213 20:35:33< jamit> anonymissimus: Sighted events are still a little buggy if delayed shroud updates is used, but they are getting better.
20121213 20:36:42< jamit> I think the remaining issues involve replays and saving the game mid-turn while DSU is on.
20121213 20:37:16< jamit> Both should get fixed "soon".
20121213 20:39:21< jamit> The stuff I've been doing with the undo stack is related. I hope to have the undo stack do the bookkeeping for DSU .
20121213 20:44:30< irker685> wesnoth: jamit * r55863 /trunk/src/ (4 files in 3 dirs): 
20121213 20:44:31< irker685> wesnoth: Define attribute_value::apply_visitor().
20121213 20:44:33< irker685> wesnoth: This is for better encapsulation, leading to fewer friends.
20121213 20:44:33< irker685> wesnoth: fendrin * r55862 /trunk/src/editor/map/context_manager.cpp: 
20121213 20:44:33< irker685> wesnoth: Change the references to the unit map with each context switch in the editor.
20121213 20:44:34< irker685> wesnoth: Fixing bug #20329
20121213 20:46:08< jamit> "Fewer friends" sounds so awful... :)
20121213 20:48:47< fiveop> What editor do you use to edit wesnoth c++
20121213 20:51:08< jamit> I just use a text editor with syntax highlighting (gedit, to be precise).
20121213 20:53:17< fiveop> k
20121213 20:54:31< jamit> You might want to see what others say, though. There are probably more user-friendly options out there.
20121213 20:54:41< fiveop> I'm using emacs
20121213 20:54:56< fiveop> I just don't want to figure out how to change the settings for a certain set of files.
20121213 20:55:07< fiveop> (my default is no tabs and indent size 2 ... ;)
20121213 21:06:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20121213 21:09:29< anonymissimus> fiveop: then experience the disadvantages about using emacs I' say :P
20121213 21:09:44< fiveop> I just fixed the problem :P
20121213 21:10:10< anonymissimus> I'd expect investing, say, 2-3 hours to find out how to just change indentation settings
20121213 21:12:12< anonymissimus> jamit: how do you "got to the definition of a function" (the function body) from where it's called for instance ?
20121213 21:21:02< anonymissimus> jamit: I can run the VC debugger fine (that's all I can say)
20121213 21:21:59< anonymissimus> you would need upthorn to test, while he's still around sometimes, it's unlikely he could test under the same circumstances as he had 2010, and the project settings also changed since then
20121213 21:22:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20121213 21:26:04-!- anonymissimus_ [~chatzilla@HSI-KBW-078-042-163-136.hsi3.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20121213 21:26:42-!- skyfaller_ [~skyfaller@ool-43551edd.dyn.optonline.net] has joined #wesnoth-dev
20121213 21:27:05-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Disconnected by services]
20121213 21:27:08-!- skyfaller_ is now known as skyfaller
20121213 21:27:10-!- skyfaller [~skyfaller@ool-43551edd.dyn.optonline.net] has quit [Changing host]
20121213 21:27:10-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20121213 21:28:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20121213 21:29:43< anonymissimus_> did you fix your MSVC build system ?
20121213 21:29:50< anonymissimus_> timotei: ^
20121213 21:32:53-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has quit [Ping timeout: 276 seconds]
20121213 21:33:11-!- melinath_ [~melinath@li341-41.members.linode.com] has joined #wesnoth-dev
20121213 21:33:22-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has joined #wesnoth-dev
20121213 21:34:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20121213 21:34:44-!- Netsplit *.net <-> *.split quits: anonymissimus, melinath
20121213 21:34:44-!- melinath_ is now known as melinath
20121213 21:38:09< timotei> O hi anonymissimus_ 
20121213 21:38:31< timotei> Hmm... didn't compile wesnoth for 2-3 months xD
20121213 21:38:46< timotei> Do you want me to try compiling it again with mscv9?
20121213 21:41:47-!- cjhopman [~chris@50-193-32-122-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20121213 21:41:47-!- cjhopman [~chris@50-193-32-122-static.hfc.comcastbusiness.net] has quit [Changing host]
20121213 21:41:47-!- cjhopman [~chris@wesnoth/developer/cjhopman] has joined #wesnoth-dev
20121213 21:42:44-!- fiveop_ [~fiveop@p4FCDFFAA.dip.t-dialin.net] has joined #wesnoth-dev
20121213 21:45:30-!- DoNotDisturb_ [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has joined #wesnoth-dev
20121213 21:45:30-!- DoNotDisturb_ [diotecktec@c-71-195-88-69.hsd1.pa.comcast.net] has quit [Changing host]
20121213 21:45:30-!- DoNotDisturb_ [diotecktec@xonotic/core-team/Samual] has joined #wesnoth-dev
20121213 21:45:43-!- yann [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has quit [Disconnected by services]
20121213 21:46:11-!- yann_ [~dwitch@nan92-1-81-57-214-146.fbx.proxad.net] has joined #wesnoth-dev
20121213 21:47:35-!- Netsplit *.net <-> *.split quits: fiveop, Samual, hopman-
20121213 21:53:39-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20121213 21:53:39-!- Upth is now known as Upthorn
20121213 21:57:45< anonymissimus_> timotei: well...did you update boost or did you do that when you last tried ? then you can probably do it without sitting a lot at the computer
20121213 21:58:36< anonymissimus_> debugger runs for me at present
20121213 22:05:19< mordante> I'm off night
20121213 22:05:31-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20121213 22:12:28-!- DoNotDisturb_ is now known as Samual
20121213 22:15:58< jamit> anonymissimus_: I think I'm missing the context for 'how do you "got to the definition of a function" (the function body) from where it's called for instance ?'
20121213 22:16:05< timotei> anonymissimus_: I have to update it
20121213 22:31:58< anonymissimus_> timotei: then it probably won't work until you did that
20121213 22:33:01< anonymissimus_> jamit: the context is you said you're using gedit, which is a simple text editor, although I assume it's got a C++ plugin
20121213 22:33:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20121213 22:34:08< anonymissimus_> walking through the code by going to the function body of a function call (and back) is probably the most frequent use case for "intellisense"
20121213 22:34:45< jamit> Ah. I have no C++ plugin, just syntax highlighting. There is no quick way to jump to a function definition.
20121213 22:34:53< anonymissimus_> so, if I had to search each time that'd be much slower
20121213 22:35:16< anonymissimus_> even assuming I would be quick with grep or something
20121213 22:36:20< timotei> Awww man...
20121213 22:36:21< jamit> Yes, it can be slow. I figure it gives me time to think. :)
20121213 22:36:29< timotei> I got again a checksum mismatch while rebasing :(
20121213 22:38:00< irker685> wesnoth: jamit * r55864 /trunk/src/ (config.cpp config.hpp): 
20121213 22:38:00< irker685> wesnoth: Define assigment to attribute_value from all integer types (excluding short).
20121213 22:38:01< irker685> wesnoth: This should remove, for example, the need to cast time_t to a string before
20121213 22:38:01< irker685> wesnoth: assignment, regardless of the platform.
20121213 22:58:12-!- prkc [~negusnyul@dsl4E5CCEF9.pool.t-online.hu] has quit [Quit: Konversation terminated!]
20121213 23:22:10< irker685> wesnoth: jamit * r55865 /trunk/src/filesystem.cpp: 
20121213 23:22:10< irker685> wesnoth: As of r55864, these lexical casts are no longer needed, even on MSVC.
20121213 23:25:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20121213 23:27:03< irker685> wesnoth: alarantalara * r55866 /trunk/data/campaigns/The_Rise_Of_Wesnoth/maps/ (3 files): 
20121213 23:27:03< irker685> wesnoth: Use snowy mountains for winter maps. Effect on gameplay is almost nothing (only exception is orcs are potentially marginally slowed in scenario 8).
20121213 23:38:08-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20121213 23:43:31-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has quit [Ping timeout: 260 seconds]
20121213 23:44:36-!- LordNasty [~NaSTy@93-43-163-150.ip92.fastwebnet.it] has joined #wesnoth-dev
20121213 23:51:23-!- fiveop_ [~fiveop@p4FCDFFAA.dip.t-dialin.net] has quit [Quit: humhum]
20121213 23:56:07-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
--- Log closed Fri Dec 14 00:00:39 2012