--- Log opened Fri May 17 00:00:32 2013
20130517 00:11:51-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer]
20130517 00:16:00< fabi> LordBob_: still around?
20130517 00:16:08< LordBob_> yup
20130517 00:16:11< fabi> Hi
20130517 00:16:17< LordBob_> hey :)
20130517 00:16:34< fabi> In 30 minutes its my birthday.
20130517 00:16:41< fabi> I mean it is already my birthday.
20130517 00:16:49< fabi> But in 30 minutes the time is the right.
20130517 00:16:53-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130517 00:17:29< LordBob_> Hehe. Happy birthday then, go and have a drink for me ^^
20130517 00:19:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130517 00:19:50< fabi> LordBob_: Hihi, will do so but it has to wait for this evening.
20130517 00:20:04< fabi> LordBob_: I am going to a Ragga music life performance.
20130517 00:20:19< LordBob_> ôo What's your local time ?
20130517 00:20:31< fabi> 24::20
20130517 00:20:48< LordBob_> Same as here. And you're going like, right now ? 
20130517 00:21:11< fabi> No, the Raga starts at 22::00 this evening.
20130517 00:21:30< fabi> Saarbrücken isn't really suited to make party during the week.
20130517 00:21:58-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has joined #wesnoth-dev
20130517 00:22:35< LordBob_> Hmm...By "this evening", you mean on the 17th, right ? (I have a tendency to mix the concept of "evening" with "whichever hour until I sleep")
20130517 00:22:51< fabi> Yes
20130517 00:23:38< fabi> Indeed, in our day to day language usage all the night belongs to the former day.
20130517 00:23:48-!- stikonas [~gentoo@128.232.240.234] has joined #wesnoth-dev
20130517 00:23:48-!- stikonas [~gentoo@128.232.240.234] has quit [Changing host]
20130517 00:23:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130517 00:24:02< fabi> Even if the switch should be at 24
20130517 00:26:19< LordBob_> Which reminds me, I'll be in Berlin this weekend. Any notable events that I might want to attend whiile I'm there ? 
20130517 00:26:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20130517 00:29:00< fabi> LordBob_: Uh, I have been in Berlin 3 times. The first was with school in 1996. At this time it was Loveparady, by coincident.
20130517 00:29:19< fabi> LordBob_: Our teachers told us that it is dangerous ans we shouldn't go there. :-)
20130517 00:29:31< fabi> I assume nobody wasn't there.
20130517 00:29:43< LordBob_> :D
20130517 00:30:08< fabi> But sorry, Berlin is about 800 Kilometers from here, not exactly my playing ground.
20130517 00:30:49< fabi> LordBob_: I love about 5 Kilometers from the French border.
20130517 00:31:08< fabi> s/love/live
20130517 00:31:11< LordBob_> Heh, no worries. I'd figured so much, but who knows. You might have heard about stuff french medias don't bother to mention 
20130517 00:31:33< LordBob_> nevermind
20130517 00:31:41< fabi> LordBob_: I think the area around the Frauenkirche was exciting.
20130517 00:32:19< fabi> LordBob_: It's that ruined leftover from World War II.
20130517 00:33:11< fabi> LordBob_: Maybe your route is bringing you in the near of Saarbrücken?
20130517 00:33:19< LordBob_> Hmm...Isn't the ruined one the Gedächtniskirche ?
20130517 00:33:36< LordBob_> (memories of school)
20130517 00:34:22< LordBob_> No luck. Because it's such a long way from Bordeaux, we're flying
20130517 00:35:42< fabi> Let's ask google, but I think you are right, the Frauenkirche is the one in Dresden.
20130517 00:35:51-!- jetrel2 [~jetrel2@64.208.23.76] has quit [Quit: jetrel2]
20130517 00:36:42< fabi> LordBob_: Oh yes, I guess the peek oil issue will kill this opportunity very soon.
20130517 00:38:09< LordBob_> Heh, who knows, maybe before the end of our lives we'll see a time when cycling is the only affordable means of transportation :p
20130517 00:38:16< fabi> LordBob_: Right, Frauenkirche --> Dresden, Gedächtnis --> Berlin
20130517 00:39:06< fabi> LordBob_: I am more worried about the fact that our modern agriculture depends on fertilizers made from oil. 
20130517 00:39:19< fabi> LordBob_: Without them we can only support half of current world population.
20130517 00:40:15-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20130517 00:40:22< fabi> LordBob_: By the way, the peek oil point was in 2006 thus this is all nearer than "maybe at the end of our lives".
20130517 00:40:36< fabi> LordBob_: The problem will get noticable during the next 10 years.
20130517 00:41:01< LordBob_> True, these things always change a lot faster than expected
20130517 00:42:50< LordBob_> Either way, a stop in Dresde is unlikely as well, although it feels like the town next door compared to bordeaux-berlin
20130517 00:44:46< fabi> LordBob_: Okay, let's get back to buisness. You wanted to ask me something Wesnoth related?
20130517 00:46:19< LordBob_> yup
20130517 00:46:26< LordBob_> several things, in fact
20130517 00:47:24< LordBob_> fabi: first, I've committed the set of units groups icons
20130517 00:47:45< fabi> LordBob_: Yes, I saw them. I am currently working on them getting wired in.
20130517 00:47:58< fabi> LordBob_: And I must say, I like them.
20130517 00:48:20< LordBob_> cool. You'll see there are several alts for the northerners factions and mechanical race: I leave the choice up to you
20130517 00:48:43< fabi> LordBob_: Okay, maybe we alter them through to confuse the user. :-P
20130517 00:48:48< AI0867> 21:44 < anonymissimus> after all, the request is that someone else pushes one's changes due to lack of commit rights <-- it's a request to a maintainer to pull from your branch
20130517 00:49:11< LordBob_> hehe; icon = random (alts1-10) :p
20130517 00:49:13< fabi> LordBob_: I could use one at odd days of week, the second on non odd and the third on the weekend. 
20130517 00:49:52< LordBob_> Hehe, an easter egg. We've defintely got to plant one of these somewhere
20130517 00:50:54< fabi> LordBob_: When placing the berserker I can show his famous laughter.
20130517 00:52:24< LordBob_> That could do. And maybe we define a specific sequence of controls that will open a loony window, or a specific event triggered on the date of your birthday 
20130517 00:52:52< LordBob_> But let's first finish the serious stuff
20130517 00:54:03< fabi> Yeah :-)
20130517 00:54:22< LordBob_> Vultraz mentionned that he didn't see the "custom" terrain group icons ; I couldn't tell him wether this was a bug or we left their wiring up to UMC creators who might need them .
20130517 00:54:28< fabi> I need to bring the editor in a usable state before the bus hits me.
20130517 00:55:15< LordBob_> You're planning to get run over by one soon ? :p
20130517 00:55:38< fabi> LordBob_: My health wasn't the best lately but it is going to get better.
20130517 00:55:45-!- Upth [~ogmar@69.62.144.56] has joined #wesnoth-dev
20130517 00:55:45-!- Upth is now known as Upthorn
20130517 00:56:05< LordBob_> oh.
20130517 00:56:28< LordBob_> My bad
20130517 00:56:44< fabi> no problem
20130517 00:57:50< LordBob_> Back to the subject of icons, we've been adding a lot of them recently, more than we need in fact, and eventually there'll be some cleaning up to do
20130517 00:58:26< LordBob_> Thus, I wanted to check if we do or don't use "pressed" states for terrain group icons
20130517 00:59:46< fabi> LordBob_: My last commit did put them in place.
20130517 01:00:08-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has quit [Remote host closed the connection]
20130517 01:02:13< LordBob_> Hmm...Are you sure ? In the version I compiled tonight, I only see the normal state (the white one)
20130517 01:03:32< LordBob_> Which doesnt really matter anyway: it works fine as is, and if it allows to half the number of icons, all the better
20130517 01:03:53< fabi> LordBob_: Oh, well, the pressed version is used on the button since days, the usage to mark the current selected one is commited local, maybe I need to push it.
20130517 01:06:08< LordBob_> fabi: I've also comitted the new status icons, but there's probably a glitch in the low res theme
20130517 01:06:49< LordBob_> they appear normally in the 1024 screen, but there's only an empty status box in 800*600.
20130517 01:07:23< fabi> LordBob_: Yes, all the status boxes won't fit on 800. Thus I need to choice which ones to left out.
20130517 01:08:07< LordBob_> Oh, alright. So i wasn't caused by me trashing the "-t" redundant files ?
20130517 01:08:12< LordBob_> Good
20130517 01:08:24< fabi> Yepp
20130517 01:09:45< LordBob_> In other news, I'm testing new backgrounds & borders for the dialogs
20130517 01:10:56< fabi> LordBob_: Cool, that will replace the last old artwork shown in the editor.
20130517 01:11:30< LordBob_> There will probably be some coding required, of course, because their dimensions aren't exactly the same, but we're almost there :)
20130517 01:11:36< fabi> LordBob_: Except for unit and terrain art of course, but I guess Wesnoth does not need to hide because of them.
20130517 01:11:55< fabi> LordBob_: Do you feel confident to do terrain art as well?
20130517 01:12:04< LordBob_> ...Yeah, let's take it one step at a time :p
20130517 01:12:13< LordBob_> ...But yes
20130517 01:13:07< LordBob_> I'm beginning to get the hang of pixel art for icons, so applying this to terrain art feels quite possible
20130517 01:13:38< fabi> LordBob_: I have been told that our terrain graphics aren't pixel art.
20130517 01:14:13< fabi> LordBob_: In pixel art you restrict yourself to a small color palette, and we do not do that for the terrains, iirc.
20130517 01:14:22< LordBob_> So have I.
20130517 01:15:49< fabi> LordBob_: This is more of a personal request: Could you combine our bridges with the rails? I am working on a RPG Scenario where the elves have paid the dwarves to build a steam punk train system to connect their capital with the highlands.
20130517 01:15:56< LordBob_> But you still need to manage a low number of pixels, and placing one or two of them can make a world of difference. This is the part of the job I'm not used to yet, but am slowly making progress with
20130517 01:17:34< LordBob_> Sure. I'll need to take a look at how bridges work first, but it seems quite doable
20130517 01:19:20< fabi> LordBob_: Cool, currently I use some overlay to let the engine know that the train can cross the bridge, still it looks odd to the user.
20130517 01:20:07< LordBob_> fabi: While we're on terrain art, do you know if the engine can handle multi-hex scenery ?
20130517 01:20:47< fabi> LordBob_: Depends on what you mean with scenery. Multi-hex terrain is already in place, the mountains for example.
20130517 01:21:12< fabi> LordBob_: Did you ever try the campaign "To Lands Unknown"?
20130517 01:21:41< LordBob_> Vultraz showed some screens of it, yes
20130517 01:22:40< fabi> LordBob_: It's done with overlays, I plan to support them in the editor as well. Unlike ingame these overlays shall be drawn transparent to allow the designer to adjust the terrain beneath them easily.
20130517 01:23:31< LordBob_> I din't have something so ambitious as tLU in mind, but I might want to create large elements (castles, big farms, landmark mountains,...) that the user can place at will
20130517 01:23:48< LordBob_> *anything
20130517 01:24:38< fabi> LordBob_: Well, the WML used to define how terrains handle their artwork isn't easy and not exactly my place of knowledge. I think alarantalara or boucman could help there.
20130517 01:25:34< LordBob_> Oh well, each thing in due time. There are still a number of individual tiles to refresh before even considering that
20130517 01:25:43< LordBob_> And a UI to finish
20130517 01:26:21< fabi> LordBob_: If we proceed with current speed, at least the editor isn't far away from being finished...
20130517 01:26:59< fabi> LordBob_: The code for the new editor is maturing on my disc since years, giving the impressing that I can code like mad, but this isn't true. But you are very fast with the artwork.
20130517 01:28:44< LordBob_> Heh, I've dedicated an insane amount of time to it and I'd been itching to do that revamp for years. I don't know what you still have planned as far as new features are concerned, but there's a chance art might even be finished next week
20130517 01:30:34< fabi> LordBob_: Well, the soundsource (that needs some discussing about the representation), the item tool, the tLU like overlays, a time of day creator, pathtool and a simple side editor. 
20130517 01:31:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20130517 01:31:21-!- stikonas_ [~gentoo@128.232.240.234] has joined #wesnoth-dev
20130517 01:31:21-!- stikonas_ [~gentoo@128.232.240.234] has quit [Changing host]
20130517 01:31:21-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130517 01:31:45< fabi> LordBob_: Art-wise that means: A symbol for soundsources (or not, I am still not sure about the representation), some icons for item groups.
20130517 01:31:57< fabi> LordBob_: Thus, the art is mostly complete already.
20130517 01:32:15< LordBob_> See: I get the easy part. No wonder it looks like I work fast
20130517 01:33:22< fabi> LordBob_: Well, coding is fun. Especially if you code for a game where you can see results very soon.
20130517 01:34:51< LordBob_> By the way, I'm going to contact the iOS port maintainer and see if he'd like to introduce our work in a future version. I would very much like to see the high res version of our work on a Retina display 8)
20130517 01:35:18< fabi> LordBob_: I would rather like to see the codebase ofthe ios port being merged with our main codebase.
20130517 01:36:23< LordBob_> Ah, that's another delicate subject, from what I hear
20130517 01:39:21< fabi> why?
20130517 01:41:18< LordBob_> Well, for starters the work on the previous iOS port didn't make it back to the core codebase
20130517 01:41:57< fabi> Yes, but that is a good thing. The previous port was a hack. The resolutions were just hardcoded for example.
20130517 01:44:58< LordBob_> I wouldn't know what was or wasn't good in that port, but if the dev team back then didn't have the manpower/skill/will to merge at least the beneficial parts, it's not a given that we'll be able to do it now
20130517 01:46:30< fabi> LordBob_: I have talked to dailin and he is willing to do the merge himself.
20130517 01:47:45< LordBob_> Ah-aah...Interesting :)
20130517 01:48:15< fabi> LordBob_: It is for his own benefit. After the merge he will be able to offer a new version without much extra work.
20130517 01:48:31< fabi> LordBob_: Not doing so means the need to port every future version.
20130517 01:50:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20130517 01:53:11-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has joined #wesnoth-dev
20130517 01:53:15-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has quit [Client Quit]
20130517 01:53:27-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has joined #wesnoth-dev
20130517 01:55:43< LordBob_> Fabi: back to the subject of terrain icons, do we or do we not keep the "pressed" status for them ? 
20130517 01:57:39< fabi> LordBob_: They are used on buttons and thus the answer is yes. Only the ones that don't define a group but a type are not used on buttons yet.
20130517 01:57:51< fabi> LordBob_: But they do not have a pressed version iirc.
20130517 01:58:39< LordBob_> they do, in images/icons/terrain
20130517 01:59:29< LordBob_> oh wait. The groups do have a pressed state, the types don't. You're reight
20130517 01:59:36< LordBob_> $right
20130517 02:00:26< LordBob_> fabi: next, I'd like to make some cleaning up in the "arrows" icons. I did 4 different states each for 2 types of arrows, but maybe we only need one or two
20130517 02:03:43< fabi> LordBob_: hmmm, the arrow buttons are press or turbo buttons in most cases. Thus 4 states is fine.
20130517 02:04:28< LordBob_> fabi: Yes but not for all of them. I think we can keep the "ornate" arrows with normal/active/pressed states for scrollbars and buttons, and use the "blank" arrows with only normal state for the resize dialog
20130517 02:05:10< fabi> LordBob_: Yes, sure we can. But what is the benefit of reducing the used artwork?
20130517 02:07:01< fabi> LordBob_: I mean, the work is done. File size is not important compared to the huge amount of terrain / unit art, the small gui images don't matter much.
20130517 02:07:10< fabi> LordBob_: Not to speak about the music files.
20130517 02:08:13< LordBob_> I wouldn't want to crowd the repo with unused art, though. We're already going to double the amount of UI elements if we go full high res :s
20130517 02:08:37< fabi> LordBob_: Well, then let's put the art in use.
20130517 02:08:53< LordBob_> ^^ Sure
20130517 02:09:58< LordBob_> But once we're done, I'll still want to lock away the leftovers in a separate "resource" directory, if not the trash can for obsolete artwork
20130517 02:10:43< LordBob_> Anyway, that's not about to happen yet, considering what we have left to do.
20130517 02:10:56< fabi> LordBob_: Yes, but we still had unused artwork in the repo for a long time. I put some of them in use, while other stuff is still sitting there.
20130517 02:12:12< LordBob_> Oh well. We'll see
20130517 02:13:02< LordBob_> You still up for a facelift to the Game UI once we're done with the editor ? This might put more art to use
20130517 02:13:59-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 02:14:16< LordBob_> Anyway, now is the time for me to crash.
20130517 02:14:45< fabi> LordBob_: Sure, we will do the Game UI after the editor.
20130517 02:14:57< LordBob_> :D
20130517 02:15:05< LordBob_> Sweet
20130517 02:15:15< fabi> LordBob_: Some of the stuff can easily be transfered, I could do so already.
20130517 02:15:35< LordBob_> Heh, some of it already has
20130517 02:15:39< fabi> LordBob_: The new menu bar background for example. Or the minimap one.
20130517 02:16:14< LordBob_> Let's not be hasty :)
20130517 02:16:21< LordBob_> And now I sleep. Seeya
20130517 02:16:29< fabi> LordBob_: Bye
20130517 02:16:42-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Quit: off to bed]
20130517 02:33:15-!- Netsplit *.net <-> *.split quits: Ingmar
20130517 02:33:25-!- Netsplit *.net <-> *.split quits: Rhonda, jetrel2, irker832, DHost
20130517 02:33:34-!- Netsplit *.net <-> *.split quits: Espreon, rei4dan, Soliton, shadowm, AI0867, Samual
20130517 02:33:44-!- Netsplit *.net <-> *.split quits: Gambit, wesbot, Ivanovic, shikadibot, timotei_
20130517 02:33:50-!- Netsplit *.net <-> *.split quits: knotwork, Anakonda_, Smar, crimson_penguin
20130517 02:34:29-!- Netsplit *.net <-> *.split quits: iwaim____, bderooms, enchilado, harsh__, ToBeFree, loonycyborg, viku_, fabi, Gallaecio, janebot,  (+7 more, use /NETSPLIT to show all of them)
20130517 02:38:08-!- mjs-de [~mjs-de@g224180190.adsl.alicedsl.de] has quit [Remote host closed the connection]
20130517 02:41:54-!- loonybot [~loonybot@wesnoth/bot/loonybot] has quit [Remote host closed the connection]
20130517 02:51:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 02:51:56-!- Netsplit over, joins: elias, fabi, wesbot, AI0867, Espreon, Soliton, Rhonda, Ivanovic, happygrue, ToBeFree (+19 more)
20130517 02:51:56-!- Ingmar__ [~ingmar@tchaikovsky.exherbo.org] has joined #wesnoth-dev
20130517 02:51:56-!- mattsc [~mattsc@d154-20-34-165.bchsia.telus.net] has joined #wesnoth-dev
20130517 02:52:02-!- Netsplit over, joins: crimson_penguin, enchilado, melinath, exciton, harsh__, nurupo
20130517 02:53:30-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130517 02:53:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds]
20130517 02:54:00-!- Yukiria is now known as vultraz
20130517 02:54:30-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20130517 02:54:30-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 03:09:49-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130517 03:12:00-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has joined #wesnoth-dev
20130517 03:15:07-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Remote host closed the connection]
20130517 03:16:54-!- happygrue [~happygrue@c-76-119-97-171.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130517 03:16:54-!- happygrue [~happygrue@c-76-119-97-171.hsd1.ma.comcast.net] has quit [Changing host]
20130517 03:16:54-!- happygrue [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20130517 03:28:45-!- EliDupree2 [~eli@dhip-029.rrw.residences.colby.edu] has quit [Ping timeout: 276 seconds]
20130517 03:43:31-!- un214 [~un214@2602:304:37b8:cee9:224:8cff:fed2:ef57] has joined #wesnoth-dev
20130517 03:43:46< un214> so somebody is selling battle for wesnoth on android
20130517 03:44:02< un214> somebody was nice and left a comment saying "this may be illegal"
20130517 03:45:04< AI0867> you mean the 1.8 port cjhopman did over a year ago?
20130517 03:45:18< un214> is that the one?
20130517 03:46:38< un214> http://www.androthsoft.com/battle
20130517 03:57:40< Gambit> that's the one
20130517 03:57:52< Gambit> It has the project's full endorsement.
20130517 03:58:25< Gambit> Thank you for the report though.
20130517 03:59:15-!- un214 [~un214@2602:304:37b8:cee9:224:8cff:fed2:ef57] has quit [Remote host closed the connection]
20130517 04:03:26-!- Ivanovic_ [~ivanovic@x2f49069.dyn.telefonica.de] has joined #wesnoth-dev
20130517 04:04:29-!- Ivanovic [~ivanovic@x2f4faba.dyn.telefonica.de] has quit [Read error: Operation timed out]
20130517 04:05:20-!- Ivanovic_ is now known as Ivanovic
20130517 04:06:35-!- Ivanovic [~ivanovic@x2f49069.dyn.telefonica.de] has quit [Changing host]
20130517 04:06:35-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20130517 04:09:05-!- un214 [~un214@2602:304:37b8:cee9:224:8cff:fed2:ef57] has joined #wesnoth-dev
20130517 04:10:19-!- un214 [~un214@2602:304:37b8:cee9:224:8cff:fed2:ef57] has quit [Remote host closed the connection]
20130517 04:11:28-!- Blueblaze [~Blueblaze@adsl-99-158-45-47.dsl.hstntx.sbcglobal.net] has joined #wesnoth-dev
20130517 04:13:51< jleldridge> mattsc: Are you there?
20130517 04:14:04< mattsc> jleldridge: on and off
20130517 04:14:36< mattsc> what's up?
20130517 04:15:30< jleldridge> mattsc: I just have a quick question: If I wanted to add a new candidate action using the c++ engine, would it go into https://github.com/wesnoth/wesnoth-old/blob/master/src/ai/testing/ca.cpp ?
20130517 04:17:29< mattsc> jleldridge: yes, I believe that would work.
20130517 04:18:16< mattsc> jleldridge: you still need to include it in your WML later, just because you define it here doesn't mean that it will be used.
20130517 04:19:51< mattsc> jleldridge: https://github.com/wesnoth/wesnoth-old/blob/master/data/ai/ais/ai_default_rca.cfg
20130517 04:19:56< jleldridge> Right, I've just couldn't find where the cpp candidate actions were actually defined before.
20130517 04:20:08< jleldridge> I*
20130517 04:20:30< mattsc> ca.cpp should be the place, afaik
20130517 04:22:27< jleldridge> mattsc: ok, thank you :)
20130517 04:23:05< mattsc> jleldridge: no worries.
20130517 04:24:15< jleldridge> Going afk for a few minutes, bbl.
20130517 04:27:29-!- skyfaller [~skyfaller@ool-43551edd.dyn.optonline.net] has joined #wesnoth-dev
20130517 04:27:29-!- skyfaller [~skyfaller@ool-43551edd.dyn.optonline.net] has quit [Changing host]
20130517 04:27:29-!- skyfaller [~skyfaller@wikipedia/Skyfaller] has joined #wesnoth-dev
20130517 04:41:35-!- irker832 [~irker@ai0867.net] has quit [Quit: transmission timeout]
20130517 04:47:23-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20130517 04:56:16< jleldridge> I'm back
20130517 04:59:07-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has joined #wesnoth-dev
20130517 05:14:36-!- irker651 [~irker@ai0867.net] has joined #wesnoth-dev
20130517 05:14:36< irker651> wesnoth: mattsc wesnoth-old:master a44a9a / data/ai/ (3 files in 2 dirs): Recruiting AIs: add more combinations to terrain strings for finding castles http://git.io/b-2Gsg
20130517 05:21:57-!- J3ny [~IceChat77@client-86-25-190-176.bsh-bng-012.adsl.virginmedia.net] has joined #wesnoth-dev
20130517 05:22:02-!- J3ny [~IceChat77@client-86-25-190-176.bsh-bng-012.adsl.virginmedia.net] has quit [Client Quit]
20130517 05:22:22< irker651> wesnoth: mattsc wesnoth-old:master 29acfb / data/ai/lua/generic-rush_engine.lua: Recruiting AIs: add more combinations to terrain strings for finding keeps http://git.io/3EQLNA
20130517 05:22:38< mattsc> That could have really been the same commit  :P
20130517 05:25:26-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20130517 05:27:26-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 05:27:44< jleldridge> Lol, well, castles and keeps are different I guess
20130517 05:28:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds]
20130517 05:28:09-!- happygrue_ [~happygrue@c-76-119-97-171.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130517 05:28:09-!- happygrue_ [~happygrue@c-76-119-97-171.hsd1.ma.comcast.net] has quit [Changing host]
20130517 05:28:09-!- happygrue_ [~happygrue@wesnoth/developer/wintermute] has joined #wesnoth-dev
20130517 05:28:18< mattsc> They are, but TBH, I just missed the keep string the first time ...
20130517 05:29:26< mattsc> Anyways...  bumbadadabum: the rush recruiter MAI now recruits in your scenario
20130517 05:31:16-!- happygrue [~happygrue@wesnoth/developer/wintermute] has quit [Ping timeout: 256 seconds]
20130517 05:43:05-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 05:48:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 05:53:14-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has joined #wesnoth-dev
20130517 06:04:10-!- shadowm_laptop2 [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130517 06:04:18-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Read error: Connection reset by peer]
20130517 06:07:31-!- shadowm_laptop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 256 seconds]
20130517 06:09:41-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has joined #wesnoth-dev
20130517 06:29:42-!- Gambit [~gambit@wesnoth/developer/grickit] has quit [Remote host closed the connection]
20130517 06:55:02-!- shadowm_laptop2 [ignacio@wesnoth/developer/shadowmaster] has quit [Remote host closed the connection]
20130517 07:00:17-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds]
20130517 07:00:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 256 seconds]
20130517 07:05:06-!- mattsc [~mattsc@d154-20-34-165.bchsia.telus.net] has quit [Quit: bye]
20130517 07:11:06-!- exciton_ [chuck-the-@89.208.169.104] has joined #wesnoth-dev
20130517 07:14:59-!- exciton [chuck-the-@89.208.169.104] has quit [Ping timeout: 252 seconds]
20130517 07:34:20< irker651> wesnoth: fendrin wesnoth-old:master a98b1c / src/hotkeys.cpp: Updated the editor tool tooltips. http://git.io/4ZaC-w
20130517 07:34:28< irker651> wesnoth: fendrin wesnoth-old:master 6e399d / src/editor/editor_display.cpp: Clean up obsolete code. http://git.io/9m9F_w
20130517 07:34:36< irker651> wesnoth: fendrin wesnoth-old:master 6d54ca / src/editor/palette/ (6 files): Made use of the help string system to signal selected palette items. http://git.io/r_fPeQ
20130517 07:58:37-!- ancestral [~ancestral@65-128-236-198.mpls.qwest.net] has quit [Quit: And that’s the end of THAT chapter.]
20130517 07:59:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 08:13:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 245 seconds]
20130517 08:13:51-!- timotei [~timotei@86.124.100.155] has joined #wesnoth-dev
20130517 08:13:52-!- timotei [~timotei@86.124.100.155] has quit [Changing host]
20130517 08:13:52-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20130517 08:18:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 08:24:18-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 08:26:03-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130517 08:26:03-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20130517 08:26:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 08:33:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20130517 08:44:35-!- jleldridge [~jleldridg@cpe-098-026-227-236.triad.res.rr.com] has quit [Quit: Leaving]
20130517 08:50:17-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130517 08:59:50-!- trademark [~ptalbot@mne69-1-82-67-17-201.fbx.proxad.net] has joined #wesnoth-dev
20130517 08:59:56< irker651> wesnoth: fendrin wesnoth-old:master 19cc28 / src/editor/action/mouse/mouse_action_unit.cpp: Adjust the unit tooltip to the hex field size. http://git.io/u6257Q
20130517 09:00:07-!- Blueblaze [~Blueblaze@adsl-99-158-45-47.dsl.hstntx.sbcglobal.net] has quit [Quit: Blueblaze]
20130517 09:02:45< vultraz> fabi: btw did you fix the thing about custom terrail groups having no icon?
20130517 09:02:46< vultraz> terrain
20130517 09:03:00< fabi> vultraz: No, not yet.
20130517 09:03:04< vultraz> ok
20130517 09:03:14< fabi> vultraz: But I can have a look at it right now.
20130517 09:04:12-!- boucman_work1 [~rosen@193.56.60.161] has joined #wesnoth-dev
20130517 09:06:38-!- boucman_work [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds]
20130517 09:11:06-!- boucman_work1 is now known as boucman_work
20130517 09:11:13-!- boucman_work [~rosen@193.56.60.161] has quit [Changing host]
20130517 09:11:14-!- boucman_work [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130517 09:13:03-!- Blueblaze [~Blueblaze@99.158.45.47] has joined #wesnoth-dev
20130517 09:22:01-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 09:23:20< fabi> vultraz: Okay, it was just a matter of wrongly named image files.
20130517 09:25:40< vultraz> oh, nice
20130517 09:27:00< irker651> wesnoth: fendrin wesnoth-old:master 75c032 / images/icons/terrain/ (12 files): Renamed the custom terrain group icons. http://git.io/AWOctg
20130517 09:27:06< fabi> vultraz: ^
20130517 09:27:24< vultraz> :)
20130517 09:32:41< vultraz> fabi: is there anything simple I can fix, I want to test that I can commit ok
20130517 09:38:01-!- Anakonda_ [aomaal@linux.utu.fi] has quit [Remote host closed the connection]
20130517 09:40:20-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20130517 09:42:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 09:43:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 09:45:34< fabi> LordBob_: ping
20130517 09:46:03< fabi> vultraz: hmmm, sorry. I have no idea.
20130517 09:46:50< LordBob_> hi fabi
20130517 09:47:01< fabi> LordBob_: Good morning :-)
20130517 09:47:13-!- TheMonster [~TheMonste@41.69.136.196] has joined #wesnoth-dev
20130517 09:47:32< fabi> LordBob_: I found some still missing artwork.
20130517 09:47:42< LordBob_> Ah-ah :)
20130517 09:47:50< fabi> LordBob_: The unit group icons don't have active versions.
20130517 09:49:17< fabi> LordBob_: And there is no terrain type icon for "fog".
20130517 09:49:33< LordBob_> Ah, true. I had withheld them due to considerations we discussed yesterday evening
20130517 09:49:34< fabi> LordBob_: But I must admit: Fog might be hard to do.
20130517 09:49:52< LordBob_> Is it even a terrain type
20130517 09:49:54< LordBob_> ?
20130517 09:50:02< fabi> yes
20130517 09:50:20< LordBob_> the active units are an easy fix, I'll commit it in a minute
20130517 09:50:37< LordBob_> The fog as in fog of war ?
20130517 09:50:44< fabi> yes
20130517 09:51:43< fabi> LordBob_: And "Shroud".
20130517 09:52:06< LordBob_> HHmmmmm....Sounds even easier
20130517 09:52:11< vultraz_laptop> fabi: think I found a bug in the selection tool. if you select a previously selected hex, it becomes unselected
20130517 09:52:42< fabi> vultraz_laptop: That is intended. The right click which deselected before is now a context menu trigger.
20130517 09:53:04< LordBob_> fabi: what's "shroud" anyway, as far as terrains go ?
20130517 09:54:18< fabi> LordBob_: Well, you can set fog and shroud (which are in fact more some kind of overlays, being removed when you discover the hex fields) in the editor. I do not know why that is the case.
20130517 09:54:31< LordBob_> is it "shroud" for unrevealed-yet terrain and fog for revealed terrain that is currently out of any friendly unit's LoS ?
20130517 09:55:07< fabi> LordBob_: Still, the engine treats them like terrain types and such demands an icon for them.
20130517 09:55:34< vultraz_laptop> fabi: another bug: the icons in the center of the golden hax that tell you what tool you're on get drawn under overlay terrails
20130517 09:55:36< vultraz_laptop> terrains
20130517 09:55:39< fabi> LordBob_: Yes, shroud is never discovered terrain, while fog is terrain that is discovered but not currently seen.
20130517 09:56:03< fabi> vultraz_laptop: huh?
20130517 09:56:54< fabi> vultraz_laptop: How can I reproduce that?
20130517 09:58:16< LordBob_> Fabi: so, a question mark for shroud and a barred eye for fog, maybe ?
20130517 09:59:10-!- TheMonster [~TheMonste@41.69.136.196] has quit [Quit: Later]
20130517 09:59:45< fabi> LordBob_: Yes, that will work.
20130517 10:00:14< LordBob_> fabi: an unrelated question: do you know what SDL is ?
20130517 10:00:30< fabi> LordBob_: Simple Direct Media Layer.
20130517 10:00:41< LordBob_> (I assume you do. I should rather ask "can you explain to me what it does")
20130517 10:01:08< fabi> LordBob_: It is a multiplatform library that offers game related functions.
20130517 10:01:27< fabi> LordBob_: Like mouse, keyboard, joystick, image and sound handling.
20130517 10:01:33< LordBob_> Ok
20130517 10:01:37< LordBob_> thanks
20130517 10:01:44< vultraz_laptop> fabi: weirdly, it only seems to happen with custom terrains
20130517 10:02:34< fabi> LordBob_: The 2.0 version that comes with retina support is still not released but beta. If it is released we have to wait until it made its way into the linux distributions. Then we can start to port Wesnoth from 1.2 to 2.0
20130517 10:03:14< fabi> vultraz_laptop: hmmm, I do not dare to touch the terrain drawing engine, that is boucman_work's field.
20130517 10:03:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20130517 10:03:57-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130517 10:04:17-!- Yukiria is now known as vultraz
20130517 10:05:08< LordBob_> fabi: the reason I'm asking is because I asked Dailin about his possible needs for high res art. He says that he'll wait until the core game has upgraded to SDL 2.0 before switching to Retina displays. Apparently, he's tried to implement it in the port, but it caused too many problems
20130517 10:05:41< fabi> LordBob_: Yes, 2.0 is quite different from 1.2 and still buggy.
20130517 10:05:59< LordBob_> ok, I understand the situation better now :)
20130517 10:06:27< fabi> :-)
20130517 10:07:46< LordBob_> On a side note, Dailin also says he would welcome a fresher UI, so maybe while we're at it we can work with him to make sure that our own effort includes a layout that is compatible with the iPhone's display ratio 
20130517 10:07:53< vultraz_laptop> LordBob_: could you please replace this images/editor/tool-overlay-label.png? I cringe every time I see how horrible I made it ._.
20130517 10:08:04< vultraz_laptop> s/replace this/replace
20130517 10:08:24< vultraz_laptop> Plus it clashes horribly with the beautiful art
20130517 10:08:58< fabi> LordBob_: Yes, we should lure Dailin into being in this chat room permanently.
20130517 10:09:19< fabi> LordBob_: And the village tool does not have an tool overlay image yet.
20130517 10:09:42< fabi> LordBob_: And the soundsource + item tool.
20130517 10:09:48< LordBob_> Hmm... How about using the 60 pixel icons ?
20130517 10:10:17< LordBob_> They're already in the repo and they're the exact same image, only finer
20130517 10:10:30< fabi> LordBob_: Yes, I will do so.
20130517 10:12:08< LordBob_> I think the normal state will do nicely, but if needed I can provide the "blank" version similar to terrain & unit groups
20130517 10:12:56-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has quit [Quit: jetrel2]
20130517 10:13:24-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has joined #wesnoth-dev
20130517 10:13:25< vultraz_laptop> fabi: also I don't see the unit group images when I use the unit tool
20130517 10:17:14< irker651> wesnoth: fendrin wesnoth-old:master 0e384e / / (37 files in 2 dirs): Put the unit group icons into use. http://git.io/XYHEsQ
20130517 10:17:21< fabi> vultraz_laptop: ^
20130517 10:18:41< vultraz_laptop> fabi: another thing: the group selection button (where you select unit/terrain groups) retains the state from the last tool you used if you switch to a tool that does not use the button
20130517 10:20:37< LordBob_> vultraz_laptop: you're acting as beta-tester ? That's a welcome help :)
20130517 10:20:52< vultraz_laptop> eg, if im in paintbrush/caves, and switched to the label tool, the group button would still show the cave image and tooltip
20130517 10:21:36< vultraz_laptop> I suggest clearing the group button and setting it to a disabled state when switching to a tool that  does not use it
20130517 10:21:38< fabi> vultraz_laptop: Indeed, the testing is very valuable.
20130517 10:21:57< fabi> vultraz_laptop: Yes, I will do as you suggest.
20130517 10:22:15< fabi> LordBob_: The size of them might be a problem.
20130517 10:22:32< fabi> LordBob_: I think that I need to center the 60px images somehow.
20130517 10:23:30< fabi> LordBob_: Yes, that is the case. They are not centered, because the engine expects them to be the same size as our hexes, 72 px.
20130517 10:23:56< LordBob_> fabi: Shall I provide them in 72 pix squares ? That's easy enough
20130517 10:25:36< fabi> LordBob_: No. I will do the coding and we avoid duplicate artwork.
20130517 10:27:07< LordBob_> nice
20130517 10:29:32-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 10:29:49-!- Blueblaze [~Blueblaze@99.158.45.47] has quit [Quit: Blueblaze]
20130517 10:31:00-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 252 seconds]
20130517 10:33:44-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 10:33:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 10:35:15< vultraz_laptop> fabi: minor thing: closing the Editor Setting or Preferences dialog causes a redraw of the entire interface (all buttons + the topbar).
20130517 10:35:48< vultraz_laptop> awhile back shadowm made it so that closing the Editor Settings dialog only redrew the gamemap (because of possible TOD changes)
20130517 10:36:06< vultraz_laptop> and I don't think the Preferences dialog is supposed to redraw anything
20130517 10:38:10< fabi> vultraz_laptop: Okay, no idea what changed here.
20130517 10:40:19< vultraz_laptop> fabi: possible bug in the time area assignment: if you have a selection when creating a time area, that selection becomes the area (I think, or at least it implies that because it scrolls to the selection when you switch to that area). However, if you assign a TOD, that TOD gets applied to the whole map, not just the selected area
20130517 10:41:42< vultraz_laptop> also for some reason, the radiobuttons in the Area menu won't change state as I change areas, for some reason
20130517 10:42:05< fabi> vultraz_laptop: Yes, there will be an extra "assign tod schedule to selected area" menu entry in the "Areas" menu.
20130517 10:42:27< fabi> vultraz_laptop: And yes, the active area state check is not implemented yet.
20130517 10:43:21< vultraz_laptop> Also can't seem to create an area when there is no selection
20130517 10:43:54< fabi> vultraz_laptop: ? 
20130517 10:44:16< fabi> vultraz_laptop: How would you like to create an area without a selection?
20130517 10:44:42< vultraz_laptop> well, a user could possibly want to create a "blank" area, and edit it later
20130517 10:44:58< vultraz_laptop> But I assume a lot of this is WIP
20130517 10:45:16< vultraz_laptop> Since there also seems to be no way to "delete" an area
20130517 10:46:08< irker651> wesnoth: fendrin wesnoth-old:master 585fbd / src/editor/action/mouse/mouse_action_map_label.cpp: New overlay for the label tool. http://git.io/PLyscA
20130517 10:47:17< vultraz_laptop> fabi:tool overlays gets drawn under placed units: https://dl.dropboxusercontent.com/u/95558676/tool_overlays_bug.png is that intentional?
20130517 10:48:06< fabi> vultraz_laptop: Well, no. But I am not sure if I can easily fix it. Would you fill a bug report, please?
20130517 10:48:33< fabi> vultraz_laptop: And for the custom terrain overdrawing the overlays as well, please.
20130517 10:49:10< vultraz_laptop> ok
20130517 10:53:24< vultraz_laptop> huh...it's not even every custom overlay terrain
20130517 10:53:38< vultraz_laptop> so far it only happens with the AtS/NX Shroud and Gate terrains
20130517 10:54:30< fabi> LordBob_: Okay, the thing works.
20130517 10:56:39< vultraz_laptop> fabi: a map resize also results in a complete interface redraw instead of just tap
20130517 10:57:05< vultraz_laptop> gamemap
20130517 10:57:12< LordBob_> Fabi: the centered cursor tool overlay ?
20130517 10:58:18< irker651> wesnoth: fendrin wesnoth-old:master 671973 / src/editor/action/mouse/ (mouse_action.cpp mouse_action_village.cpp): New overlays for the starting position and village tool. http://git.io/M1oS5Q
20130517 11:01:33< fabi> LordBob_: Yes, those are working now. I am going to replace every old overlay with the new 60px icons.
20130517 11:02:26< fabi> LordBob_: But I am not sure with the select tool, what is your opinion?
20130517 11:03:59< LordBob_> fabi: selection is the one I would make an exception for. A dotted line cursor works better
20130517 11:04:21< fabi> LordBob_: Okay, thus the select overlay will stay.
20130517 11:05:08-!- Crendgrim [~quassel@f050094009.adsl.alicedsl.de] has quit [Ping timeout: 245 seconds]
20130517 11:05:34< irker651> wesnoth: fendrin wesnoth-old:master 61dc75 / src/editor/action/mouse/mouse_action.cpp: Overlay for the paste tool. http://git.io/Dr1vUQ
20130517 11:05:34< vultraz_laptop> alright those are all the issues I can find for now. Hope I've been helpful
20130517 11:07:05< irker651> wesnoth: fendrin wesnoth-old:master f9aec6 / images/editor/ (tool-overlay-label.png tool-overlay-starting-position.png): Delete now obsolte editor tool overlay images. http://git.io/nJ7xPg
20130517 11:07:13< fabi> vultraz_laptop: Thank you very much :-)
20130517 11:07:28-!- Crendgrim [~quassel@f050092229.adsl.alicedsl.de] has joined #wesnoth-dev
20130517 11:10:27-!- Upth [~ogmar@108-85-91-228.lightspeed.frokca.sbcglobal.net] has joined #wesnoth-dev
20130517 11:11:15< irker651> wesnoth: fendrin wesnoth-old:master 8f235f / images/icons/unit-groups/race_mechanical1.png: Renamed one of the mechanical race unit group icon. http://git.io/aheTNg
20130517 11:16:03-!- mjs-de [~mjs-de@g224182120.adsl.alicedsl.de] has joined #wesnoth-dev
20130517 11:17:38< fabi> LordBob_: still around?
20130517 11:18:38< LordBob_> yup
20130517 11:21:54< LordBob_> fabi: anything you want to discuss ?
20130517 11:22:05< fabi> LordBob_: For the tools that don't use the palette. 
20130517 11:22:52< LordBob_> Hmm...Such as label, selection, etc. ?
20130517 11:23:20< fabi> LordBob_: I can either disable (greying them out) the palette control buttons (group selection, swap fg/bg, scroll up/down) or I can hide them.
20130517 11:24:33< fabi> LordBob_: Hiding them is easier. Do you think hiding is okay or shall I disable them?
20130517 11:24:47< vultraz_laptop> fabi: Humans and Mechanical icons missing from the unit list
20130517 11:25:19< LordBob_> Hmm...I'd say disable
20130517 11:26:09< LordBob_> Fabi: since we don't hide the palette, there's not much point in hiding its controls
20130517 11:26:55< LordBob_> Fabi: oh wait, no. Try disabling
20130517 11:26:56< fabi> LordBob_: Well, technically, I hide the palette, just not its background image.
20130517 11:27:04< LordBob_> err, try hiding
20130517 11:27:29< fabi> LordBob_: Okay, why did you change your mind?
20130517 11:27:30< LordBob_> There might be leftover marks in the background, though. I'll have to remove them
20130517 11:27:50< LordBob_> Because we're already hiding the contents, as you said
20130517 11:28:03< vultraz_laptop> fabi: I support disabling. People might get confused if UI bits started disappearing
20130517 11:28:26< LordBob_> And it's better to try the easier solution first, then maybe change our minds, than the other way around
20130517 11:28:41-!- Kexoth [~kex@89.205.70.185] has joined #wesnoth-dev
20130517 11:29:22< LordBob_> Hmmm...Vultraz also has a point. I'm the one confused now 
20130517 11:29:53< LordBob_> Hmmm
20130517 11:29:55< LordBob_> Hmmm
20130517 11:30:07< vultraz_laptop> fabi: ok weird bug. turns out only the mechanical image is missing. but, if you select a unit group, then open the menu again, that group's image is gone from the list
20130517 11:30:08< fabi> LordBob_: Anyway, the frames in the background are not needed anymore.
20130517 11:30:32< LordBob_> Nuuuuh I don't know !
20130517 11:30:41< vultraz_laptop> select another, look again, and the previous image is back, but the current group's is gone
20130517 11:31:08< fabi> vultraz_laptop: The active icons are still missing, LordBob_ is working on them right now.
20130517 11:32:08< vultraz_laptop> oh, I see
20130517 11:32:18< vultraz_laptop> well the Mechanical image is still missing
20130517 11:33:08< fabi> vultraz_laptop: Is your clone up to date?
20130517 11:33:16< vultraz_laptop> yes
20130517 11:33:55< LordBob_> Fabi: let's go with disable. It already happens to the scroll arrows
20130517 11:34:15< fabi> LordBob_: Okay
20130517 11:36:03< LordBob_> (not to mention that every other tool does the same. We don't want different controls to start behaving differently)
20130517 11:37:08< fabi> Agreed.
20130517 11:37:59-!- Upthorn [~ogmar@c-98-208-31-231.hsd1.ca.comcast.net] has joined #wesnoth-dev
20130517 11:38:36< vultraz_laptop> fabi: are you going to add support for showing custom UMC factions in the editor?
20130517 11:39:41< fabi> vultraz_laptop: They should already work.
20130517 11:40:10< vultraz_laptop> well...I see no custom factions
20130517 11:40:53< vultraz_laptop> only mainline ones
20130517 11:40:58< LordBob_> fabi: did your latest commit delete the "mechanical1" unit group icon instead of renaming it ? I can't find it anymore
20130517 11:40:58< fabi> vultraz_laptop: http://forums.wesnoth.org/viewtopic.php?f=19&t=37290
20130517 11:41:43< vultraz_laptop> fabi: ah, ok
20130517 11:42:03< fabi> LordBob_: Must be the case, stupid me. Can you just add it again?
20130517 11:42:04< vultraz_laptop> also, BTW, why is there a context menu option named "editor-selection-name" ?
20130517 11:42:34< LordBob_> Yup. How did you want to rename it ?
20130517 11:43:14< fabi> LordBob_: Wait, it is still present in my filesystem, thus I should do it.
20130517 11:44:09< irker651> wesnoth: fendrin wesnoth-old:master 98a0fd / images/icons/unit-groups/race_mechanical_30.png: Add the mechanical race group icon again. http://git.io/wLv1vw
20130517 11:44:33< fabi> vultraz_laptop: It is a test case for a bug. Just ignore it for now.
20130517 11:49:02< LordBob_> fabi: did give the "_30" suffix to only some icons on purpose ? I'm renaming my home files, want to make sure I don't break anything when I commit the updated versions
20130517 11:49:10< LordBob_> *did you
20130517 11:50:54< fabi> LordBob_: All images addressed by the palette need the suffix.
20130517 11:53:38< vultraz_laptop> fabi: ok, it works :)
20130517 11:54:02< vultraz_laptop> but my custom race doesn't have an icon, how do I give it an icon
20130517 11:57:22< fabi> vultraz_laptop: add the item to your addon, keep the same path and add the [binary_path] thing to your addon.
20130517 11:57:55< vultraz_laptop> er...what?
20130517 11:59:46< irker651> wesnoth: Emilien Rotival wesnoth-old:master 7cc132 / images/icons/unit-groups/ (115 files): Update of the unit group icons with the "pressed" status http://git.io/9QZEog
20130517 12:00:50< LordBob_> Done. don't mind the number of files: I trashed the whole directory and pasted the updated one, hence a high number of changes for maybe half the actual icon count
20130517 12:00:58-!- flix [~flix@178.77.175.34] has quit [Ping timeout: 276 seconds]
20130517 12:02:01< vultraz_laptop> fabi: I don;t understand what you mean
20130517 12:02:50< fabi> vultraz_laptop: make a directory in your addon "images/icons/unit-groups/"
20130517 12:03:44< fabi> vultraz_laptop: Put your image in there, name it "race_<your_race's name>_30.png.
20130517 12:07:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 12:07:38-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 256 seconds]
20130517 12:08:27< LordBob_> fabi the next item I would like to update is the scrolling bars
20130517 12:10:17< fabi> LordBob_: Ah yes, note that you made the new scroll buttons which are not yet put to use for the scroll bar are bigger than the old. Thus you need to enlarge the bar as well.
20130517 12:10:58< LordBob_> fabi: duly noted. I'll make the bar 25 pix-wide
20130517 12:11:38< fabi> LordBob_: Let's make the palette background an extra item.
20130517 12:12:29< fabi> LordBob_: I mean, let's have a background, we can use in the game and in the editor. In the editor we put the palette background on top of it.
20130517 12:13:06< LordBob_> fabi: my latest commit must have broken something; now there are only the undead, mechanical and bats icons visible in the selection menu
20130517 12:13:25< fabi> LordBob_: Don't worry, I will repair it.
20130517 12:14:14-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 12:14:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 12:14:56-!- flix [~flix@dhcp-213-188.vpn.tu-berlin.de] has joined #wesnoth-dev
20130517 12:17:19< vultraz_laptop> fabi: are there some custom race icons to use in core?
20130517 12:17:34-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Ping timeout: 245 seconds]
20130517 12:18:02-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20130517 12:18:09< vultraz_laptop> I thought lordbob made some
20130517 12:18:35< fabi> vultraz_laptop: Yes
20130517 12:19:10< LordBob_> vultraz: I made 10 custom-thing icons, but all of them are named "era"
20130517 12:19:18< irker651> wesnoth: fendrin wesnoth-old:master 5a5f3d / src/ (editor/palette/empty_palette.hpp widgets/button.cpp): Disable most of the palette buttons for the empty palette. http://git.io/zQ1D9w
20130517 12:19:29< vultraz> alright, I'll raname them when adding to my addon
20130517 12:20:12< LordBob_> vultraz: now that you mention it, I'll include a couple smiley faces for custom races as well. It's quick to make
20130517 12:23:59< LordBob_> fabi: about the backgrounds, doesn't this take us back to the matter of wether we can overlay panels on top of each other ?
20130517 12:24:48< fabi> LordBob_: We can overlay panels on top of each other.
20130517 12:25:00< fabi> LordBob_: I was wrong when I stated otherwise.
20130517 12:26:56< LordBob_> fabi: oh, that's good. I'll do new sets of backgrounds with only the wooden panels, and isolate the background frames for tool groups, palettes etc.
20130517 12:27:35< vultraz> LordBob_: are we going to replace the general theme/dialog BG with one from your collection?
20130517 12:28:24-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: Leaving]
20130517 12:29:29< LordBob_> vultraz: absolutely. I've already got templates for several different styles of dialogs. Implementing them will come next right after the scrollbars
20130517 12:30:04< LordBob_> Some coding by mordante might be required, though, because I'd like to introduce thicker borders compared to the existing
20130517 12:30:19< LordBob_> wesbot: seen mordante ?
20130517 12:30:19< wesbot> LordBob_: The person with the nick mordante last spoke 2d 15h ago.  2d 15h ago was here and on the channel #wesnoth-de with the message: Quit: Leaving
20130517 12:30:44< irker651> wesnoth: fendrin wesnoth-old:master 15583f / images/icons/unit-groups/ (60 files): Renamed the unit group icons again. http://git.io/yFjU8w
20130517 12:30:49< LordBob_> And now, I'll go eat. Later guys
20130517 12:31:13< vultraz> LordBob_: last thing, are you working on Left and Right arrow buttons?
20130517 12:31:26< fabi> LordBob_: Guten Hunger!
20130517 12:35:00< vultraz> fabi: "good eating" ?
20130517 12:35:04-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Ping timeout: 245 seconds]
20130517 12:35:36< fabi> vultraz: Good hungry.
20130517 12:36:00< fabi> vultraz: Saarländisch for "Guten Appetit".
20130517 12:37:18-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 12:39:37-!- loonybot [~loonybot@ppp91-78-87-169.pppoe.mtu-net.ru] has joined #wesnoth-dev
20130517 12:39:37-!- loonybot [~loonybot@ppp91-78-87-169.pppoe.mtu-net.ru] has quit [Changing host]
20130517 12:39:37-!- loonybot [~loonybot@wesnoth/bot/loonybot] has joined #wesnoth-dev
20130517 12:39:58-!- shadowm_desktop [ignacio@wesnoth/developer/shadowmaster] has quit [Ping timeout: 276 seconds]
20130517 12:44:59< irker651> wesnoth: fendrin wesnoth-old:master 40774e / src/editor/ (editor_controller.cpp palette/common_palette.hpp palette/empty_palette.hpp): Disable the item swap button if the palette does not support it. http://git.io/48_v1A
20130517 12:50:56< irker651> wesnoth: fendrin wesnoth-old:master f3837a / images/icons/action/ (editor-switch-time_30-active.png editor-swith-time-active.png): Renamed an image file. http://git.io/dDFxVg
20130517 12:57:34< irker651> wesnoth: fendrin wesnoth-old:master 6b3182 / src/editor/palette/editor_palettes.cpp: Reset the position of the help string when resizeing. http://git.io/tNwVvQ
20130517 13:01:18-!- Yukiria [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20130517 13:01:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20130517 13:01:49< Yukiria> I'm running wesnoth-optipng on all these new images
20130517 13:01:52-!- Yukiria is now known as vultraz
20130517 13:02:55-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20130517 13:02:55-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 13:19:12< fabi> vultraz: yes, please
20130517 13:30:49-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20130517 13:35:59-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has joined #wesnoth-dev
20130517 13:45:52-!- EliDupree2 [~eli@dhip-029.rrw.residences.colby.edu] has joined #wesnoth-dev
20130517 13:46:15< vultraz_laptop> er...need some git help. compiling created/changed some files, and I don't want to commit them, but the github app is telling me to commit all my changes before I can push the optipng commit
20130517 13:51:54< bumbadadabum> wesbot: seen mattsc
20130517 13:51:55< wesbot> bumbadadabum: The person with the nick mattsc last spoke 8h 22m ago.  6h 46m ago was here and on the channel #wesnoth-umc-dev with the message: Quit: bye
20130517 13:55:36< irker651> wesnoth: Emilien Rotival wesnoth-old:master 3dc778 / images/icons/unit-groups/ (6 files): Added default unit group icons for up to three custom races http://git.io/rxBRbQ
20130517 13:56:38< LordBob_> Vultraz: have you tried reverting the changes you do not want to commit ?
20130517 13:57:10< LordBob_> Unless they're changes to the xcode project files ,
20130517 13:57:12< LordBob_> ?
20130517 13:57:24< vultraz_laptop> they're changes to the xcode file
20130517 13:57:30< vultraz_laptop> except I somehow deleted it...
20130517 13:57:38< vultraz_laptop> and can't get git revert to work
20130517 13:57:40< vultraz_laptop> ugh
20130517 13:58:10< vultraz_laptop> (also there's a change to src/text.cpp that I need until alarantalara uploads a new maccompile stuff)
20130517 13:58:49< LordBob_> Hmm, I think I ran into the same kind of problem earlier this week. Lemme try and remember what Mattsc said...
20130517 13:59:02< LordBob_> You 
20130517 13:59:10< vultraz_laptop> so if someone could tell me how to revert the xcode proj file to HEAD
20130517 13:59:17< vultraz_laptop> and stash the change to text.cpp
20130517 13:59:21< vultraz_laptop> that'd be great
20130517 13:59:57-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW]
20130517 14:05:10< LordBob_> vultraz_laptop: sorry I cannot help. Mattsc guided me through those exact same steps, but the conversation hasn't been logged
20130517 14:05:37< LordBob_> So I'm unable to provide the exact commands he had me use :s
20130517 14:06:46-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has joined #wesnoth-dev
20130517 14:09:08< LordBob_> vultraz_laptop: From what I remember, we used the git reset --hard command, after what I had to go once again through part of the compiling setup 
20130517 14:13:09-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has quit [Quit: leaving]
20130517 14:16:21< vultraz_laptop> ok I did that...now I need to redo the change to text.cpp :(
20130517 14:16:45< vultraz_laptop> and the settings tweaks I did to the xcode proj
20130517 14:17:36-!- apoi [~andi@85-126-180-242.volume.xdsl-line.inode.at] has joined #wesnoth-dev
20130517 14:18:03< irker651> wesnoth: Charles Dang wesnoth-old:master db032c / images/ (188 files in 5 dirs): Ran wesnoth-optipng http://git.io/11vlxg
20130517 14:18:40-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: bumbadadabum]
20130517 14:18:59< vultraz_laptop> yay it worked :D
20130517 14:28:48< LordBob_> Vultraz: that's cool :)
20130517 14:34:40< vultraz_laptop> except now xcode is freezing on startup X___X
20130517 14:43:47< vultraz_laptop> alright we're good
20130517 14:49:21< vultraz_laptop> ok, I need a way to stash my changes to the xcode proj and text.cpp for next time I commit
20130517 14:49:30-!- timotei [~timotei@79.119.100.244] has joined #wesnoth-dev
20130517 14:49:30-!- timotei [~timotei@79.119.100.244] has quit [Changing host]
20130517 14:49:30-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20130517 15:11:59-!- vultraz_android [~androirc@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 15:14:11< LordBob_> vultraz_laptop: have you setup a custom ignore list for these two files ?
20130517 15:14:32< LordBob_> Mattsc provided a setup for this, I can give you what notes I took
20130517 15:15:52< vultraz_android> LordBob_: could you do me a favor? I need an icon for a race in my campaign called the Northguard ( http://db.tt/mxmfaRd3 ) Currently i'm using one of the generic custom ones you committed, but it'd be nice to have a unique one. As for the ignore list, no i haven't
20130517 15:19:07-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 15:22:06-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has joined #wesnoth-dev
20130517 15:28:37< LordBob_> vultraz_android: icons and stuff will have to wait until next week, but here's the instructions for setting up your local exclude list: http://pastebin.com/iBZPukE8
20130517 15:29:58< LordBob_> vultraz_android: once everything is set up correctly, you only need to rebuild your app to account for any changes that might have occured in the repo
20130517 15:30:16-!- mattsc [~mattsc@207.230.251.234] has joined #wesnoth-dev
20130517 15:31:54< vultraz> yay mattsc!
20130517 15:32:13< mattsc> vultraz: good morning
20130517 15:32:30< bumbadadabum> mattsc: I made a workaround for the castle issue
20130517 15:32:36< bumbadadabum> pretty simple
20130517 15:32:37< bumbadadabum> it works
20130517 15:32:59< LordBob_> vultraz_android: erratum: there's a missing line in the "exclude" file I linked: you also need to paste "projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj" in there
20130517 15:33:05< mattsc> bumbadadabum: 20130517 05:29:26< mattsc> Anyways...  bumbadadabum: the rush recruiter MAI now recruits in your scenario
20130517 15:33:30< bumbadadabum> mattsc: Oh you changed it already
20130517 15:33:45< mattsc> bumbadadabum: I added more terrain codes to the castle string for the MAI, so it now covers custom terrains like yours also.
20130517 15:33:46< mattsc> yes
20130517 15:33:55< bumbadadabum> mattsc: Well I did something else
20130517 15:37:57< vultraz> LordBob_: thanks :)
20130517 15:40:04< mattsc> vultraz: do you still need help with that, or did LordBob_ tell you everything you need?
20130517 15:40:19< LordBob_> vultraz: let me know if it works.
20130517 15:41:18-!- DCW [~Thunderbi@cpc1-finc14-2-0-cust12.4-2.cable.virginmedia.com] has quit [Quit: DCW]
20130517 15:48:30< vultraz_laptop> LordBob_: seems to work :)
20130517 15:48:41< LordBob_> great :)
20130517 15:49:27< vultraz_laptop> don't think I need the last step about timestamps, since it already copies each time
20130517 15:51:07< LordBob_> yeah, maybe you don't. The copy wasn't taking place on my laptop so Mattsc suggested this, but I think he did mention that not every setup required it
20130517 15:52:32< mattsc> vultraz: yeah, you shouldn't need that.  I've never been able to figure out why it is required for my setup.
20130517 15:53:40-!- Crab_ [Crab_@wesnoth/developer/crab] has joined #wesnoth-dev
20130517 15:58:49< bumbadadabum> Hey, I'm making a luawml tag to replace HIGHLIGHT_ITEM in core
20130517 15:59:02< bumbadadabum> and I have 2 questions:
20130517 15:59:13< bumbadadabum> 1. Should I have it keep the item on the map by default or not
20130517 15:59:52< bumbadadabum> 2. How should I call it?
20130517 16:00:25< vultraz_laptop> 1. yes
20130517 16:01:09< bumbadadabum> (2 is for both the tag and the key)
20130517 16:01:09< vultraz_laptop> 2. tag name? [highlight_location]
20130517 16:04:44< bumbadadabum> I might keep [flash_image] there
20130517 16:06:07< vultraz_laptop> alright
20130517 16:06:40< vultraz_laptop> fabi: the 'Loyal' context option for units doesn't do anything, is it still unimplemented?
20130517 16:13:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 256 seconds]
20130517 16:13:07-!- vultraz_android [~androirc@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20130517 16:13:26-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20130517 16:16:09-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 16:16:22-!- jetrel2 [~jetrel2@c-71-195-42-37.hsd1.mn.comcast.net] has quit [Quit: jetrel2]
20130517 16:16:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 16:19:40< irker651> wesnoth: jleldridge wesnoth-old:master 4e6ecc / data/lua/location_set.lua: Fixed location_set().of_pairs() syntax to follow conventions. http://git.io/pGmsMg
20130517 16:19:49< irker651> wesnoth: anonymissimus wesnoth-old:master c3612b / data/lua/location_set.lua: Merge pull request #12 by jleldridge. http://git.io/Q1o4rw
20130517 16:34:20-!- mattsc [~mattsc@207.230.251.234] has quit [Ping timeout: 252 seconds]
20130517 16:43:28-!- LordBob_ [~chatzilla@2a01:e34:ee82:47e0:21e:c2ff:fe01:261f] has quit [Quit: back on tuesday]
20130517 16:43:36< flix> Crab_: Hi! https://github.com/flixx/wesnoth-old 
20130517 16:45:24< flix> Crab_: https://github.com/flixx/wesnoth-old/tree/game_theory/src/ai/flix This is a better link ;)
20130517 16:49:57-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20130517 16:56:50-!- Kexoth [~kex@89.205.70.185] has quit [Remote host closed the connection]
20130517 16:59:30< vultraz_laptop> wesbot: seen mordante
20130517 16:59:30< wesbot> vultraz_laptop: The person with the nick mordante last spoke 2d 19h ago.  2d 19h ago was here and on the channel #wesnoth-de with the message: Quit: Leaving
20130517 17:00:52-!- the_monster [~TheMonste@41.69.136.196] has joined #wesnoth-dev
20130517 17:04:33-!- the_monster [~TheMonste@41.69.136.196] has quit [Client Quit]
20130517 17:11:24< Crab_> flix: hello
20130517 17:11:32< Crab_> flix: thanks
20130517 17:13:54< Crab_> flix: do you have any questions at this point?
20130517 17:15:38< flix> Crab_: Not really, I've still this ai-parametrization to do.
20130517 17:16:17< Crab_> flix: ok. I'll be going on a small vacation starting on the evening of May 22, I'll take a look at everything done before that point, when I'll be doing the final student ranking.
20130517 17:18:29< flix> Crab_: ok. Will the final decisions published on May 27 like on googles timeline or earlier here?
20130517 17:18:51< Crab_> flix: Google asks us to not tell anything before google does it.
20130517 17:19:03< Crab_> flix: (as anything can change at the last moment)
20130517 17:19:10< flix> Crab_: ok
20130517 17:19:21< Crab_> flix: so, somewhen after the deadline google would start sending yes/no letters, and will publish a list somewhere.
20130517 17:19:50< Crab_> flix: it can be messy (e.g. last year they messed up and set preliminary list before the deadline, or the year before it took several hours for some students to get the messages)
20130517 17:20:28< Crab_> flix: usually, we'll say here as well, just after the deadline.
20130517 17:21:34-!- Ingmar__ [~ingmar@tchaikovsky.exherbo.org] has quit [Changing host]
20130517 17:21:35-!- Ingmar__ [~ingmar@exherbo/developer/ingmar] has joined #wesnoth-dev
20130517 17:22:14-!- Ingmar__ is now known as Ingmar
20130517 17:26:02< mattsc> Crab_, flix, others: just FYI, I will be traveling May 21 - June 2.  I think I'll be able to connect reasonably regularly, but I don't expect to have much time.
20130517 17:26:34< Crab_> mattsc: have a nice journey! 
20130517 17:27:20< mattsc> Crab_: Thanks.  Business trip, but to some nice places at least.
20130517 17:33:30-!- artisticdude [~artisticd@vsat-148-64-186-230.c005.g4.mrt.starband.net] has quit [Quit: Computer has gone to sleep.]
20130517 17:39:49< mattsc> Crab_: do you know if adding [target]/[goal] tags works in [modify_side]?
20130517 17:40:23< Crab_> probably not. but modify_ai should work.
20130517 17:40:53< mattsc> Crab_: ok, I'll try that.  Also, I found something that might or might not be considered a bug in the MtT CA
20130517 17:41:32< Crab_> mattsc: see MODIFY_AI_ADD_GOAL macro
20130517 17:42:05< mattsc> If there are two enemy leaders (both of them considered goals) and one is surrounded by impassable terrain, the CA considers it a target nevertheless and then might get blacklisted if it considers this one  more valuable target than the other.
20130517 17:42:42< mattsc> As in, it choses that one as a target, but cannot get there, and then nothing at all happens (rather than it going for the other leader)
20130517 17:43:07< mattsc> Crab_: I don't know if you'd consider that a bug or not.
20130517 17:43:33< Crab_> that's a bug
20130517 17:44:04< Crab_> units definitely should not consider targets which they can't hope to reach because of the terrain (not because of blocking enemy/friendly units)
20130517 17:44:17< Crab_> (as in 'reach to attack')
20130517 17:45:12< mattsc> Crab_: it should be relative easy to fix, we just need to add another condition to the removal of invalid targets, with find_path set to ignore enemy units.
20130517 17:45:39< mattsc> Do you want me to fill out a bug report for this?
20130517 17:45:46< Crab_> mattsc: for the fix - not sure. consider a map which has two caves, unreachable from each other
20130517 17:45:50< Crab_> mattsc: for bug report - sure
20130517 17:46:07< Crab_> mattsc: target might be valid for unit A but not for unit B due to movement type or location
20130517 17:46:27< mattsc> Crab_: can't we just loop over all units of the side?
20130517 17:46:49< Crab_> mattsc: maybe. I'll need to take a look at the code to see if that would help.
20130517 17:47:45< mattsc> Crab_: okay.  Btw, I found this by trying to figure out why the messenger side in UtBS:Out_of_the_Frying_Pan does not attack after the messenger is killed.
20130517 17:48:26< mattsc> The reason is that there's an ghost leader surround by cave walls that it is trying to go for.
20130517 17:57:13-!- vvp [~vvp@135-90-93-178.pool.ukrtel.net] has joined #wesnoth-dev
20130517 17:58:20-!- vvp [~vvp@135-90-93-178.pool.ukrtel.net] has quit [Client Quit]
20130517 17:58:55-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Quit: bumbadadabum]
20130517 18:00:29-!- jetrel2 [~jetrel2@64.208.23.76] has joined #wesnoth-dev
20130517 18:07:32< irker651> wesnoth: Charles Dang wesnoth-old:master 326a33 / src/gui/dialogs/ (editor_settings.cpp editor_settings.hpp): GUI2/Editor Settings: prevented gamemap being hue-shifted if dialog is closed wi http://git.io/IyhBtg
20130517 18:08:00< vultraz_laptop> ok, next time, shorter commit message
20130517 18:12:21-!- Crab_ [Crab_@wesnoth/developer/crab] has left #wesnoth-dev []
20130517 18:16:25< Soliton> just the first line needs to be shorter, you should not explain the change less.
20130517 18:16:27-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 18:17:57< Soliton> indentation looks broken in the commit though.
20130517 18:22:41< vultraz_laptop> Soliton: the src files use tab indent?
20130517 18:22:52 * Soliton nods.
20130517 18:24:00< vultraz_laptop> alright, lemme fix it
20130517 18:24:31-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20130517 18:27:54< irker651> wesnoth: Charles Dang wesnoth-old:master 419ca7 / src/gui/dialogs/editor_settings.cpp: Indent fix http://git.io/oBxGcw
20130517 18:31:47-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Read error: Connection reset by peer]
20130517 18:33:36-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20130517 18:33:36-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Client Quit]
20130517 18:33:46-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has joined #wesnoth-dev
20130517 18:34:00-!- dragos [~quassel@5-15-217-9.residential.rdsnet.ro] has joined #wesnoth-dev
20130517 18:36:45< lipkab> vultraz: Why does update_tod_display_fast ask for a twindow& argument if it does not use it?
20130517 18:37:43< lipkab> (This will also trigger an unused parameter warning which aborts the build process by default)
20130517 18:38:28< irker651> wesnoth: mattsc wesnoth-old:master 0e490e / data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: UtBS Out of the Frying Pan: set goals for messenger side units http://git.io/uQXJEg
20130517 18:45:37< vultraz_laptop> lipkab: er..probably because I'm still not that good at C++ ._.
20130517 18:51:23-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20130517 18:51:49-!- lipkab [~lipk@host-91-147-212-174.biatv.hu] has quit [Ping timeout: 248 seconds]
20130517 18:52:12-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20130517 18:52:28-!- Gallaecio [~quassel@84.120.218.224.dyn.user.ono.com] has quit [Ping timeout: 246 seconds]
20130517 18:54:35< Soliton> vultraz_laptop: did you discuss that change with anyone? how about doing pull requests?
20130517 18:55:20< anonymissimus> AI0867: the pull request auto-closed after I had pushed the manual merge; I wonder how it detected that; perhaps since I wrote "merge pull request #12" ?
20130517 18:55:32< AI0867> possibly
20130517 18:55:44< AI0867> also, it did merge the branch
20130517 18:55:56< AI0867> that's easily detectable
20130517 18:55:59< mattsc> Crab_, actually, this might not be a bug after all.  It is possible that the MtT CA only gets blacklisted if all goals are unreachable, which is what's supposed to happen, I think.  I need to do some more tests for that.
20130517 18:57:44< mattsc> anonymissimus: the issues with UtBS:Out_of_the_Frying_Pan should be fixed.  I'll reply to the forum post in a little while.
20130517 18:59:37< anonymissimus> AI0867: what do you mean by that it did merge the branch ? which branch where ?
20130517 19:00:24< anonymissimus> vultraz_laptop: needing 2 fix commits shortly after a small commit is bad developer karma :P
20130517 19:01:21< AI0867> well, I don't know if whoever made the pull request created his own branch or worked on his master
20130517 19:01:31< AI0867> but either way, you can interpret that as a branch
20130517 19:01:53< AI0867> after you merged that, it no longer had any commits that were "ahead of" wesnoth-old/master
20130517 19:02:00< AI0867> which is the target branch
20130517 19:03:41-!- prkc [~negusnyul@BC069D1D.dsl.pool.telekom.hu] has joined #wesnoth-dev
20130517 19:06:12-!- jleldridge [~jleldridg@cpe-098-026-227-236.triad.res.rr.com] has joined #wesnoth-dev
20130517 19:06:53-!- love1cat [~Adium@c-98-217-91-242.hsd1.ma.comcast.net] has joined #wesnoth-dev
20130517 19:07:18-!- love1cat [~Adium@c-98-217-91-242.hsd1.ma.comcast.net] has left #wesnoth-dev []
20130517 19:10:31< anonymissimus> mattsc: if the messenger side units were heading in the direction of the hidden keep at 28,37 then that exactly matches my observation from playing the scenario
20130517 19:10:52< anonymissimus> "side units" meaning units which support the messenger
20130517 19:11:34< mattsc> anonymissimus: yes, from my observations that is what happened - or they just sat there not moving at all.
20130517 19:12:01< anonymissimus> they were just moving into that direction and not attacking ...I think they respected being caught by ZoC though
20130517 19:12:45< mattsc> anonymissimus: attacks should not have been affected (attacks on units within their reach on the current move)
20130517 19:12:58< anonymissimus> but TBH the scenario was hard enough anyway
20130517 19:13:03< mattsc> anonymissimus: actually, if Kaleh was not on hidden, they'd head for him, but only then.
20130517 19:13:27< anonymissimus> from campaign design point of view, this fight at the end should be another scenario
20130517 19:13:44< mattsc> So what I did is set all Side 1 and 5 units as goals, not just their leaders.  That is the same as what is already done for Side 2 (Durstag).
20130517 19:14:27< anonymissimus> what is side 5 ? (I con't dare looking at UtbS)
20130517 19:14:52< mattsc> the ghosts
20130517 19:15:45< anonymissimus> hm, but they were allied
20130517 19:16:10< anonymissimus> durstag and the ghosts at least
20130517 19:16:44< anonymissimus> and the messenger side is allied with durstag so should be allied with the ghosts as well
20130517 19:16:53< mattsc> oh, hmm, so they are...  I just saw that they were set as targets for Durstag's side and did the same for the messenger side.
20130517 19:17:11< anonymissimus> despite that it makes little sense that the ghosts and humans are allied in the first place
20130517 19:17:24< mattsc> So this doesn't make any difference then, other than a few lines of unnecessary code.
20130517 19:17:41< anonymissimus> well, I didn't look it up in the code
20130517 19:17:51< nurupo> anonymissimus: oh, hi there. after you lest the other day i managed to get the same errors and warnings you got and fixed them. you can try building the new patch https://gna.org/patch/?3847 if you'd like
20130517 19:17:59< anonymissimus> just playing observation
20130517 19:18:07< nurupo> *left
20130517 19:18:21< mattsc> anonymissimus: I have looked it up now, and they are indeed allied.
20130517 19:18:38< mattsc> So we should either take those lines out, or make the sides not be allied.
20130517 19:19:02< mattsc> (the lines defining side 5 as a goal for durstag and the messenger)
20130517 19:22:26< vultraz_laptop> Soliton: no, it was just something I ended up fixing while trying to do something else
20130517 19:22:48< anonymissimus> nurupo: perhaps you want to transform that into a cool pull request ?
20130517 19:22:53-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has left #wesnoth-dev []
20130517 19:24:46< nurupo> anonymissimus: pm
20130517 19:27:19< anonymissimus> so that people (or I) are less bothered with things like #if defined _WIN32
20130517 19:27:21< anonymissimus> fatal: git apply: bad git-diff - expected /dev/null on line 137
20130517 19:27:23< anonymissimus> (not neccessarily a fault of yours
20130517 19:27:24< anonymissimus> )
20130517 19:27:49< nurupo> yeah, that's bad
20130517 19:28:16-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 19:29:09< anonymissimus> well yes; most of the time when I try git apply some patch I need to manually fix it
20130517 19:30:39< nurupo> will do the pull request then, sometime today
20130517 19:35:43< irker651> wesnoth: mattsc wesnoth-old:master 9dfe67 / data/campaigns/Under_the_Burning_Suns/scenarios/08_Out_of_the_Frying_Pan.cfg: UtBS Out of the Frying Pan: remove unnecessary goals for AI sides http://git.io/DgO-Aw
20130517 19:36:57-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has quit [Ping timeout: 252 seconds]
20130517 19:40:47-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has left #wesnoth-dev []
20130517 19:55:14-!- mattsc [~mattsc@fw.hia.nrc.ca] has quit [Quit: bye]
20130517 20:13:25-!- anonymissimus [~chatzilla@HSI-KBW-149-172-228-192.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20130517 20:14:05< anonymissimus> nurupo: sorry, did you say something after I disconnected ?
20130517 20:14:36< nurupo> anonymissimus: no
20130517 20:14:53< anonymissimus> in the pribate chat
20130517 20:15:03< anonymissimus> *private*
20130517 20:16:09< nurupo> no, haven't said anything after you have replied
20130517 20:16:14< nurupo> *i haven't
20130517 20:16:24< Soliton> vultraz_laptop: well, that does not sound useful. use pull requests if you want to do random code changes so someone can look over them.
20130517 20:17:47< anonymissimus> nurupo: in your patch, I see that it has CRLF line endings
20130517 20:18:20< anonymissimus> it definitely recommend to set in your gitconfig to only use LF
20130517 20:18:32< vultraz_laptop> Soliton: alright
20130517 20:18:39< anonymissimus> also on windows
20130517 20:19:57< anonymissimus> perhaps thats the problem; I have set to use LF everywhere for wesnoth
20130517 20:20:55< anonymissimus> in case you did checkout with [core]autocrlf not set to false you better do a recheckout, it only causes probs if you let git change EOLs automatically
20130517 20:22:05< anonymissimus> the default for that is to change the EOLs to CRLF when on windows IIRC which is very bad
20130517 20:28:56< anonymissimus> nurupo: it looks as if your patch contains a change to an *existing* file src/windows_tray_notification.cpp
20130517 20:29:52< anonymissimus> okay, finally it applies clean
20130517 20:29:57< nurupo> anonymissimus: yes, i have noticed this after i sent you a link earlier today and i have updated the patch
20130517 20:30:07< nurupo> finally :)
20130517 20:30:49< nurupo> *the link
20130517 20:36:13-!- vinipsmaker [~vinipsmak@187.65.51.81] has joined #wesnoth-dev
20130517 20:36:36< irker651> wesnoth: Favyen Bastani wesnoth-old:master 6263e9 / src/ (8 files in 3 dirs): Added optional reason to the ignore feature. http://git.io/t-4Oag
20130517 20:36:44< irker651> wesnoth: Favyen Bastani wesnoth-old:master d637be / src/ (6 files in 3 dirs): Improved friends storage system to store "acquaintances" as separate children. http://git.io/5SKjDA
20130517 20:36:51< anonymissimus> nurupo: well, I think that pull requests are easier to handle for all people envolved and that it's worth changing runninh work to it
20130517 20:36:53< irker651> wesnoth: Favyen Bastani wesnoth-old:master 118384 / src/game_preferences.cpp: Don't need to escape the reason anymore with new storage system. http://git.io/S5n3bA
20130517 20:37:01< irker651> wesnoth: Favyen Bastani wesnoth-old:master ed9a22 / src/ (7 files in 3 dirs): Added notes for friends. http://git.io/qPdBsA
20130517 20:37:06< anonymissimus> I'll test the next time it's there
20130517 20:37:09< irker651> wesnoth: soliton- wesnoth-old:master e82772 / src/ (8 files in 3 dirs): Merge pull request #1 from fbastani/master http://git.io/FGo_vg
20130517 20:37:38< nurupo> anonymissimus: <nurupo> will do the pull request then, sometime today
20130517 20:37:42-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 20:38:50< anonymissimus> yes, actually, I meant shadowm as I disagree with him on that
20130517 20:39:19-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Client Quit]
20130517 20:39:46< anonymissimus> AI0867: is there a way to "assign" a pull request to a dev ?
20130517 20:39:50-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 20:40:17-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Client Quit]
20130517 20:40:54< Soliton> anonymissimus: right below the subject line in the webinterface.
20130517 20:41:27-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has joined #wesnoth-dev
20130517 20:43:17< anonymissimus> thanks (why did I overlook that ?)
20130517 20:43:18-!- bumbadadabum [~bumbadada@d155109.upc-d.chello.nl] has quit [Read error: Connection reset by peer]
20130517 21:05:56< fabi> Hello, can someone confirm that current master is not compiling anymore?
20130517 21:06:24< jleldridge> I'll try, one sec
20130517 21:07:01< vultraz_laptop> Hang on
20130517 21:08:27< fabi> Soliton: Did you test the pull request?
20130517 21:08:50< anonymissimus> probably it's vultraz' unused parameter
20130517 21:10:15< fabi> http://pastebin.com/PU0zdt5X
20130517 21:10:19< Soliton> fabi: for quite a few days now.
20130517 21:10:21-!- Elvish_Hunter [802d3794@gateway/web/freenode/ip.128.45.55.148] has joined #wesnoth-dev
20130517 21:12:19< anonymissimus> my apologies
20130517 21:15:55< Soliton> fabi: looks like game_preferences was not recompiled properly?
20130517 21:17:11-!- stikonas [~gentoo@as932.girton.cam.ac.uk] has joined #wesnoth-dev
20130517 21:17:11-!- stikonas [~gentoo@as932.girton.cam.ac.uk] has quit [Changing host]
20130517 21:17:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20130517 21:17:57< fabi> Soliton: Maybe a scons -c will do it?
20130517 21:18:09< anonymissimus> mattsc: "I fixed that by adding [goal] tags that define all Side 1 units as goals for the move_to_target phase.": It feels pretty strange that this isn't the default
20130517 21:18:30< Soliton> fabi: hmm, never had issues with scons and that's what i used to test, too.
20130517 21:18:32< anonymissimus> mattsc: even for leaderless sides; is it different for sides with a leader ?
20130517 21:19:16< Soliton> fabi: but yeah, try that i guess.
20130517 21:19:23< irker651> wesnoth: Elvish_Hunter wesnoth-old:master bf6ec6 / data/core/units/elves/Marksman.cfg: Fixed some missing frames in female Elvish Marksman death animation http://git.io/sw2eLA
20130517 21:20:36< jleldridge> fabi, Soliton: It just failed to compile for me as well
20130517 21:20:58< Soliton> jleldridge: same error? also a debug build?
20130517 21:21:11< Soliton> i've just tested release builds.
20130517 21:21:17< anonymissimus> mattsc: Your post doesn't completely explain the behavior I saw, but since it was using an old version of the messenger ai I suppose everything else is irrelevant.
20130517 21:22:19< jleldridge> Soliton: I'm not entirely sure how to do a debug build, so I guess I was doing a release build, here is the error I got: http://pastebin.com/AABKks17
20130517 21:22:55< Soliton> jleldridge: ok, different and sadly expected error.
20130517 21:23:13< jleldridge> Soliton: Ok, my operating system is archlinux if that matters
20130517 21:24:03< jleldridge> Soliton: And I could do a debug compile if you need me to, and can help me figure out how to.
20130517 21:24:27< Soliton> fabi: please take a look at 326a338b0c5685c2e919bbed412bbde2ac91d9a2 and do it properly. i assume it's your area anyway.
20130517 21:25:59< Soliton> jleldridge: for scons it's just scons build=debug. no idea about cmake etc.
20130517 21:26:46< nurupo> anonymissimus: is it a good idea to include my whole windows_tray_notification.cpp/hpp in `#ifdef _WIN32`, so there is no need to set up each and every project file so that those files are included only for windows builds?
20130517 21:28:08< anonymissimus> nurupo: I would #ifdef out as little code as possible
20130517 21:28:42< anonymissimus> nurupo: so that files even if they are windows-specific are also test-compiled on Linux, even of the code isn't called
20130517 21:29:50< anonymissimus> nurupo: besides, you need to at least put it into sconsscript anyway which is used for win releases
20130517 21:42:28< anonymissimus> MSVC is linking fine here
20130517 21:43:17-!- mattsc [~mattsc@fw.hia.nrc.ca] has joined #wesnoth-dev
20130517 21:44:04< jleldridge> Soliton: I did a debug build with cmake and ended up with the same error.
20130517 21:44:37< jleldridge> Soliton: The same error I had before, not the same error fabi had (just to clarify)
20130517 21:44:47< Soliton> jleldridge: yes. as mentioned that error is expected. still needs to be fixed.
20130517 21:45:19< anonymissimus> perhaps fabi's error is a pseudo one caused by the build system being confused about the unused parameter
20130517 21:45:42< Soliton> jleldridge: as a quick fix you can comment out the parameter name.
20130517 21:47:02< jleldridge> Soliton: ok, I'm not too worried about building it for my own use (I have a working build from yesterday), I was just trying to provide more information if I could.
20130517 21:47:11< mattsc> anonymissimus: for the MtT CA, there are only 3 different types targets: enemy leaders, villages (for AI sides with a leader), and anything defined in [target]/[goal] tags.
20130517 21:48:15< mattsc> So that's what AI units are heading for when these things our out of range for the current move.  When something is within reach, other CAs take over.
20130517 21:48:16< Soliton> jleldridge: sure, and with that quick fix you could. ;-)
20130517 21:48:20-!- Gambit [~gambit@wesnoth/developer/grickit] has joined #wesnoth-dev
20130517 21:48:22< anonymissimus> mattsc: okay, so the default ai by default moves into the direction of my leader and not any units ?
20130517 21:48:32< jleldridge> Soliton: Oh ok, I'll try it then.
20130517 21:48:34< mattsc> anonymissimus: yes
20130517 21:48:48< anonymissimus> mattsc: okay, surprising I didn't know that
20130517 21:48:59< anonymissimus> mattsc: that is important for strategy in some scenarios
20130517 21:49:16< mattsc> anonymissimus: it's not that easy to notice, as almost always your units are in some way between your leader and the enemy.
20130517 21:50:02< mattsc> anonymissimus: and it only is the case when they cannot reach any of your units for attacking.  If that is the case, the combat CA takes over.
20130517 21:50:07 * anonymissimus needs to replay a certain scenario with that knowledge in mind
20130517 21:50:20< anonymissimus> mattsc: sure, that I knew
20130517 21:50:43< Soliton> jleldridge: i am quite certain it's just an incomplete (re-)build for fabi for some reason though. because the link error doesn't make sense. but verification can't hurt...
20130517 21:52:01< nurupo> anonymissimus: here https://github.com/wesnoth/wesnoth-old/pull/13
20130517 21:52:07-!- prkc [~negusnyul@BC069D1D.dsl.pool.telekom.hu] has quit [Quit: Konversation terminated!]
20130517 21:52:45< mattsc> anonymissimus: as for what you observed the AI units doing after the messenger died, it's hard for me to figure out if that's consistent with what I found since the replay doesn't work.
20130517 21:52:54< jleldridge> Soliton: ok, should I comment out the entire parameter declaration like this: void teditor_settings::update_tod_display_fast(/*twindow& window*/) ?
20130517 21:53:01< fabi> Soliton, jleldridge: Indeed, scons -c and rebuild solved the problem for me. Thanks :-)
20130517 21:53:16< nurupo> anonymissimus: can you test if it compiles right with mingw?
20130517 21:53:31< Soliton> jleldridge: nope, just comment out window.
20130517 21:54:09< mattsc> anonymissimus: but yes, either way it should be fixed now, so it's kind of a moot point.
20130517 21:54:46< anonymissimus> nurupo: I'll checkout it out, but loonycyborg will have to handle it
20130517 21:55:15< anonymissimus> nurupo: sconsscript and cmakelists are easy to edit, just look at some recent commit adding files
20130517 21:55:21 * nurupo pokes loonycyborg
20130517 21:55:52< nurupo> anonymissimus: add unconditionally (indifferent of OS)?
20130517 21:55:54< flix> mattsc: Hello :). Do you know the purpose of having this aspect_recruitment_phase ? It seems for me like an artifact of the old default-ai to don't break the recruitment aspect (for limiting the recruitments)
20130517 21:57:17< mattsc> flix: Hi.  No I don't, but I can confirm that there's no aspect called recruitment_phase in the AI right now.
20130517 21:57:24< anonymissimus> nurupo: what do you mean ?
20130517 22:00:27< flix> mattsc: but there is the aspect called "recruitment" which is defined in this fancy way (with "[limit]" ). And then there is a CA called aspect_recruitment_phase, which will recruit with the old default-ai and consider the "recruitment"-aspect while doing so. And it seems to me that this CA is only there as a workaround for keeping this "recruitment"-aspect
20130517 22:00:49< jleldridge> Soliton: The build succeeded with that fix.
20130517 22:01:04< nurupo> anonymissimus: i mean, just add w_t_n.cpp/hpp files unconditionally, without checking if it's windows os or some other os?
20130517 22:01:06< Soliton> jleldridge: excellent, thanks.
20130517 22:01:21< mattsc> flix: I'm having a look at the code ...
20130517 22:01:37< Soliton> fabi: will you take a look at that commit?
20130517 22:01:48< loonycyborg> I'm still waiting for repo situation to be sorted out :P
20130517 22:02:02< fabi> Soliton: Which one?
20130517 22:02:21< Soliton> "fabi: please take a look at 326a338b0c5685c2e919bbed412bbde2ac91d9a2 and do it properly. i assume it's your area anyway."
20130517 22:03:50< fabi> Soliton: Yes
20130517 22:04:03< Soliton> fabi: alright, thanks.
20130517 22:04:24-!- Elvish_Hunter [802d3794@gateway/web/freenode/ip.128.45.55.148] has quit [Quit: Ciao!]
20130517 22:04:35< Soliton> loonycyborg: unlikely that it'd get sorted out much more than it is now anytime soon.
20130517 22:06:10< anonymissimus> nurupo: I would add/included them unconditionally yes, so that people under Linux compile them for warnings
20130517 22:06:39< mattsc> flix: where do you see aspect_recruitment_phase being called from anywhere?
20130517 22:06:55< anonymissimus> unless something windows-specific makes this impossible of course
20130517 22:07:15-!- Kexoth [~kex@78.157.29.209] has joined #wesnoth-dev
20130517 22:08:42< nurupo> anonymissimus: like windows headers?
20130517 22:10:20< mattsc> flix: actually, this seems to be the recruiting that is currently being used by the RCA AI:
20130517 22:10:45< nurupo> anonymissimus: the wole two files are windows-specific because they use windows-defined structures and calls, that's why i wanted to ifdef both of them
20130517 22:10:53< flix> mattsc: yes, I noticed it too right now
20130517 22:10:53< mattsc> flix: https://github.com/wesnoth/wesnoth-old/blob/master/data/core/macros/ai_candidate_actions.cfg#L62
20130517 22:12:23< flix> mattsc: so this means that the recruitment from the old default-ai is actually in use all over the place?
20130517 22:13:30< mattsc> flix: yes - my guess is that people never got the new one to work quite as they wanted.  But that's really just a guess, you should ask Crab_ about that.
20130517 22:13:45< mattsc> Either that are it's a mistake ...
20130517 22:13:51< mattsc> s/are/or
20130517 22:18:02< AI0867> src/gui/dialogs/editor_settings.cpp:154:6: error: unused parameter ‘window’ [-Werror=unused-parameter]
20130517 22:18:06< AI0867> cc1plus: all warnings being treated as errors
20130517 22:18:08< AI0867> scons: *** [build/release/gui/dialogs/editor_settings.o] Error 1
20130517 22:18:11< AI0867> scons: building terminated because of errors.
20130517 22:18:30< flix> mattsc: hmm, it doesn't look like a mistake for me. I'll ask Crab_ about this tomorrow... all those different recruitment algorithms... it's really a mess. Now I see why the idea is called "REFACTORING recruitment AI" ;)
20130517 22:18:30< Soliton> fix is in the works.
20130517 22:22:14< anonymissimus> nurupo: git pull https://github.com/nurupo/wesnoth-old.git master
20130517 22:22:46< anonymissimus> nurupo: F:\wesnoth-code\src\windows_tray_notification.cpp|103|error: 'struct NOTIFYICONDATA' has no member named 'hBalloonIcon'|
20130517 22:22:48< anonymissimus> ||=== Build finished: 1 errors, 0 warnings ===|
20130517 22:22:57< anonymissimus> (sorry, was old clipvoard content)
20130517 22:23:32< anonymissimus> nurupo: it compiled under MinGw for you ?
20130517 22:23:46< anonymissimus> also, if I comment that line out it's fine
20130517 22:25:54< nurupo> anonymissimus: you are building for Wndows 98 and higher then, not Windows Xp and higher then
20130517 22:26:34-!- lipkab [~lipk@apn-151-0-94-7.vodafone.hu] has joined #wesnoth-dev
20130517 22:26:59< anonymissimus> nurupo: that might be
20130517 22:27:15< nurupo> anonymissimus: just remove that ifdef on line 9 https://github.com/nurupo/wesnoth-old/blob/a4b66b13e4c1c1559910cf0a1c916744eba956b2/src/windows_tray_notification.hpp
20130517 22:27:18< anonymissimus> although wesnoth does officially only target win xp and higher so no need to
20130517 22:28:11< nurupo> anonymissimus: hBalloonIcon is defined for _WIN32_IE >= 0x0600, which is windows xp and higher
20130517 22:28:32< anonymissimus> I am on xp
20130517 22:29:07< nurupo> anonymissimus: just try removing lines 9 and 11
20130517 22:32:38< fabi> Soliton: Is there a special procedure when reverting commits with git?
20130517 22:33:07< fabi> Soliton: Or do I just replace the version with an older one and mention the reverted commit in the changelog?
20130517 22:33:41< Soliton> "replace the version with an older on"?
20130517 22:33:47< Soliton> not sure what that means.
20130517 22:34:05< Soliton> i'd say just use git revert.
20130517 22:34:59< Soliton> fabi: note there is a follow-up commit fixing indentation.
20130517 22:35:18< anonymissimus> nurupo: well, no doesn't work
20130517 22:35:32< nurupo> anonymissimus: what is says?
20130517 22:35:50< anonymissimus> ||=== wesnoth, Release ===|
20130517 22:35:52< anonymissimus> F:\wesnoth-code\src\windows_tray_notification.cpp|103|error: 'struct NOTIFYICONDATA' has no member named 'hBalloonIcon'|
20130517 22:35:54< anonymissimus> ||=== Build finished: 1 errors, 0 warnings ===|
20130517 22:35:57< flix> mattsc: just fyi: 1. the old default ai is indeed used for recruiting by default 2. Both algorithms (in ai.cpp and ca.cpp) are very similar 
20130517 22:36:03< Soliton> fabi: so a simple revert will probably not work unfortunately.
20130517 22:36:05< anonymissimus> that doesn't mean everyone gets this though
20130517 22:36:19< fabi> Soliton: Okay, thanks.
20130517 22:36:21< anonymissimus> evil culprit of c++
20130517 22:36:40< mattsc> flix: okay, thanks.
20130517 22:37:22< lipkab> fabi: Better just remove the offending function argument, I'd say.
20130517 22:37:37< lipkab> Or yell at vultraz to fix it.
20130517 22:37:44< anonymissimus> nurupo: so, did it compile under MinGw for you ?
20130517 22:37:46< nurupo> anonymissimus: i didn't have that error. are you sure _WIN32_IE gets redefined with value of 0x0600? also, can you pastebin NOTIFYICONDATA from shellapi.h?
20130517 22:38:22< nurupo> anonymissimus: i did get the same errors and warnings you did, but them i fixed all of them
20130517 22:38:32< anonymissimus> where should shellapi.h be ?
20130517 22:38:51< nurupo> anonymissimus: it didn't compile because of some other errors, not related to my changes
20130517 22:38:54< jleldridge> mattsc: I have a question about the use of aggression in the healer support mai if you have time.
20130517 22:39:10< nurupo> anonymissimus: somewhere in mingw includes. just run a file search
20130517 22:39:33< nurupo> also, i'm pretty sure NOTIFYICONDATA is a redefine of another structure
20130517 22:39:35< mattsc> jleldridge: go ahead
20130517 22:40:37< anonymissimus> nurupo: found it
20130517 22:41:06< nurupo> and that structure should have `#ifdef _WIN32_IE >= 0x0600` `hBalloonIcon` `#endif`
20130517 22:41:11< fabi> lipkab: vultraz broke the dialog, just commenting the argument won't fix that. The commits need to get removed.
20130517 22:41:45< anonymissimus> nurupo: looks as if it is WIN_NT something not WIN_IE
20130517 22:41:48< fabi> Damn, now I broke my clone with some changes.
20130517 22:42:02< lipkab> fabi: Ah, ok.
20130517 22:42:36< nurupo> anonymissimus: that the problem then. i had WIN_IE with tdm-mingw 5.2.something
20130517 22:42:41< jleldridge> mattsc: where is aggression actually used to determine if healers can attack? It doesn't seem to be used in healer_support:healers_can_attack_eval() or exec(). I see that it is read in on line 159 of micro_ais_wml_tags.lua, it just doesnt seem to be used by the mai itself.
20130517 22:42:51< anonymissimus> nurupo: http://pastebin.com/X5Hm9EpK
20130517 22:44:14< mattsc> jleldridge: https://github.com/wesnoth/wesnoth-old/blob/master/data/ai/micro_ais/ais/micro_ais_wml_tags.lua#L179
20130517 22:44:43< jleldridge> mattsc: I feel dumb... I just didn't read down far enough, thank you.
20130517 22:45:00< mattsc> jleldridge: no worries, it's easy to miss
20130517 22:45:17< nurupo> anonymissimus: i see, it's indeed WIN_NT, i must have mistaken
20130517 22:45:20< nurupo> sorry :)
20130517 22:45:27< Soliton> fabi: if it's just about reverting the two commits i can do that.
20130517 22:45:41< fabi> Soliton: Yeah, but I need to learn that.
20130517 22:46:19< nurupo> anonymissimus: can you change lines 9 and 10 to _WIN32_WINNT in the w_t_n.hpp and check?
20130517 22:47:19< nurupo> anonymissimus: oh, don't do that
20130517 22:47:24< fabi> Soliton: Okay, please do it. My clone is completely broken now...
20130517 22:47:43< nurupo> anonymissimus: _WIN32_WINNT 0x0600 is Windows Vista and higher
20130517 22:47:55< Soliton> fabi: do you have local changes?
20130517 22:48:02< fabi> Soliton: Yes
20130517 22:48:07< nurupo> anonymissimus: then i will just remove the hBalloonIcon
20130517 22:48:22< fabi> Soliton: Two local commits that I didn't push yet.
20130517 22:48:27< anonymissimus> nurupo: actually, I think I pasted the wrong struct, here: http://pastebin.com/KqcsqM39
20130517 22:48:38< Soliton> fabi: ok, what seems to the issue now?
20130517 22:48:41< fabi> Soliton: I wish there were simply a git undu.
20130517 22:48:43< fabi> undo
20130517 22:48:50< nurupo> anonymissimus: or, better, ifdef it. in case Wesnoth will start supporting windows vista and higher someday
20130517 22:50:00< anonymissimus> fabi: for almost all of the commands you can do a --abort
20130517 22:50:25< anonymissimus> and it resores things; such as when you're lost in conflict resolution during a rebase etc
20130517 22:50:50< fabi> I used git revert -n master~2..master~1 in the directory with vultraz's changes. The result is just confusing.
20130517 22:51:16< Soliton> the directory you're in is meaningless.
20130517 22:51:25< fabi> It did not do anything to the files that vultraz changed but reverted my local stuff. 
20130517 22:51:37< fabi> The branch is now marked as merged.
20130517 22:51:45< Soliton> because you did not reference his commits.
20130517 22:52:01< anonymissimus> git revert <commit_hash>
20130517 22:52:23< Soliton> git reset --hard to get back to what you had before.
20130517 22:52:35 * anonymissimus never used those confusing ways of specifying commits
20130517 22:52:55< Soliton> then to revert the offending commits: git revert --no-commit 419ca782 326a338b0
20130517 22:53:12< Soliton> and then git commit...
20130517 22:53:20< vinipsmaker> mordante: I've updated the proposal again with the last feedback. I'm sorry for the long delay, this week was strangely busy to me: http://wiki.wesnoth.org/index.php?title=User:Vinipsmaker/GSoC13/Proposal&diff=51075&oldid=50964
20130517 22:54:33< anonymissimus> nurupo: well, if win xp doesn't support it then we better don't use it at all, can you do without ?
20130517 22:55:03< nurupo> anonymissimus: that's what i just said. also, i already updated the pull request
20130517 22:55:03< anonymissimus> this is since there are extremely few people testing or compiling on windows, yet alone win vista or higher
20130517 22:55:51< nurupo> anonymissimus: i'm doing git rebase squash right now
20130517 22:56:06< Soliton> fabi: tell us if there are further issues.
20130517 22:56:37< irker651> wesnoth: fendrin wesnoth-old:master cf8091 / src/editor/editor_controller.cpp: Clear the help string before entering the preferences dialog. http://git.io/iSF5BA
20130517 22:56:46< irker651> wesnoth: fendrin wesnoth-old:master f180e2 / src/theme.cpp: Fix bug in the auto tooltips and format them properly. http://git.io/tf6lrQ
20130517 22:57:00< irker651> wesnoth: fendrin wesnoth-old:master 560ae8 / src/gui/dialogs/ (editor_settings.cpp editor_settings.hpp): The commits broke the dialog, it just did not change the tod anymore. http://git.io/3z5p6Q
20130517 22:57:47< fabi> Soliton, anonymissimus: Thanks, seemed to have worked well. I just thought git would notice about the reverted commits, now my commit message is a little meaningless.
20130517 22:58:32< nurupo> anonymissimus: squashed
20130517 22:59:10< nurupo> now it should build successfully
20130517 22:59:24< anonymissimus> nurupo: interestingly though, under MSVC the ballonIcon was known
20130517 22:59:38< Soliton> fabi: yeah, if you use --no-commit you need to provide the commit message your self.
20130517 23:01:00-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 256 seconds]
20130517 23:01:15< nurupo> anonymissimus: what is interesting about that? we just figured out that balloonIcon is known only for windows vista and higher. since you are building for windows xp, no wonder it's unknown
20130517 23:01:21< fabi> Soliton: Okay, noted. Is it enough to just paste the commit hash to reference the reverted commit? Or does it need a # prefix or something similar for making it a link?
20130517 23:01:54< anonymissimus> nurupo: but I compile parallely with MSVC, it should also be unknown
20130517 23:02:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 246 seconds]
20130517 23:02:42< Soliton> fabi: in the github webinterface? no idea. i'd guess it can figure out commit hashes but i've no experience.
20130517 23:04:07< anonymissimus> nurupo: gettign different errors now since you removed the define for _WIN32_IE
20130517 23:04:08< nurupo> anonymissimus: read "known" as "unknown"
20130517 23:04:40< nurupo> anonymissimus: perhaps that define is not defined by mingw
20130517 23:04:50< nurupo> anonymissimus: then i should add it back...
20130517 23:04:56< anonymissimus> nurupo: but this kind of figuring out is actually your work, not mine
20130517 23:04:59< fabi> Soliton: Okay, thank you very much for helping me.
20130517 23:05:27< Soliton> fabi: you're welcome.
20130517 23:05:30< anonymissimus> you should have a build environemtn for MinGw and make sure it compiles, not let someone else check it for you; fixing things in "remote" is difficult
20130517 23:06:36< nurupo> anonymissimus: yes, i agree. i asked you to do a quick chech because i'm on linux right now
20130517 23:06:50< nurupo> you don't have if you don't want. i can do it later myself
20130517 23:07:15< nurupo> thought you didn't mind, but it seems otherwise :)
20130517 23:09:59-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 23:10:05< fabi> hi vultraz_laptop
20130517 23:10:06< anonymissimus> nurupo: well no, if you only though I don't mind it's okay
20130517 23:10:17< anonymissimus> just to be sure
20130517 23:10:53< anonymissimus> I just support people using MSVC due to pure selfishness
20130517 23:11:34-!- trademark [~ptalbot@mne69-1-82-67-17-201.fbx.proxad.net] has quit [Read error: Operation timed out]
20130517 23:12:27< fabi> vultraz_laptop: I just reverted your commit, it broke the dialog. If you did not check the "Automatically update map view" box and leave the dialog, the change was not applied. 
20130517 23:12:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20130517 23:13:26< fabi> vultraz_laptop: That is the problem with options: Every option doubles your test space (if it is just a boolean options like the mentioned checkbox). And the reason why "Options are bad" :-)
20130517 23:14:27< nurupo> anonymissimus: btw, after i somehow fixed issues with w_t_n in codeblocks, i got several other errors, so i wasn't able to build it with mingw
20130517 23:15:13< fabi> vultraz: And please, adjust your build settings with "strict=true". This will catch the unused parameters.
20130517 23:15:27< anonymissimus> nurupo: well, of course you should first compile an unmodified branch
20130517 23:15:58< anonymissimus> the project files and the build system as-is are up to date at least
20130517 23:16:10< nurupo> anonymissimus: if i remember right, the errors were in standard c++ library
20130517 23:16:16< anonymissimus> nurupo: you mustn't use the neweset version of that compiler perhaps that was the problem
20130517 23:16:36< nurupo> anonymissimus: i have used what README said
20130517 23:17:15< anonymissimus> okay, well, then try compiling an unmodified branch, paste what you get and perhaps someone can help
20130517 23:17:27< nurupo> not sure what errors were, will pastebin them later, maybe you would know something about them
20130517 23:17:42< anonymissimus> or more likely, loonycyborg 
20130517 23:17:52< nurupo> okays
20130517 23:19:02< anonymissimus> fabi: IMHO strict is nonesense
20130517 23:19:12< anonymissimus> one shouldn't need it
20130517 23:19:26< anonymissimus> more likely, he didn't even get the warning
20130517 23:20:36< fabi> anonymissimus: Oh, without strict=true, the unused parameter isn't causing an error with my setup. And the warning is just one of too many to notice it.
20130517 23:20:58< anonymissimus> and what do you do in situations such as this when there's some warning; it makes your build completely abort instead of using all the time when you're away from the computer
20130517 23:21:50< anonymissimus> or when you want to temporarily accept warnings when debugging
20130517 23:22:18< fabi> anonymissimus: Good point, there is some tradeoff.
20130517 23:22:32< fabi> anonymissimus: But I have to leave now, see you later :-)
20130517 23:22:39< anonymissimus> and there shouldn't be any warnings of course, one needs to suppress and/or fix all of them :(
20130517 23:22:45-!- vultraz_laptop [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 248 seconds]
20130517 23:23:12-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20130517 23:23:56< Soliton> unless you're constantly staring at the build output it's hard to make sure you're not missing some warning.
20130517 23:24:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20130517 23:24:31< Soliton> so if the compiler can do that work for me i'm all for it.
20130517 23:24:46< anonymissimus> vultraz: did you use MSVC to compile ? perhaps you should set warning level to 4 and/or use a debug build; IIRC it is set to 3 in release and that warning is a level 4 one
20130517 23:26:08< loonycyborg> nurupo: So, your latest work is in a github pull request for wesnoth-old?
20130517 23:26:28< nurupo> loonycyborg: correct
20130517 23:26:34< loonycyborg> kk
20130517 23:26:46< anonymissimus> well, I just need to look at the count of errors/warning only at least once before a commit
20130517 23:27:04< anonymissimus> it may be that MSVC displays this in a very user friendly way
20130517 23:28:11< anonymissimus> and since I brought down the warnings last year or somewhen there's only 3 "default" warnings left which I need to ignore
20130517 23:28:18< nurupo> there should be something like "treat warnings like errors: yes/no" in project properties in MSVC
20130517 23:28:37< nurupo> *as errors
20130517 23:29:18< nurupo> a single warning and it won't build
20130517 23:29:44< anonymissimus> yes, but that's unusable in MSVC since its warnings/errors are much worse than gcc's
20130517 23:30:10< anonymissimus> there are lots of unusable ones and a few tthat cannot be suppressed
20130517 23:32:23< anonymissimus> nurupo: okay, great; first check with the MinGw binary works
20130517 23:32:40< anonymissimus> and I checked MSVC some time ago already
20130517 23:33:27< nurupo> anonymissimus: do you see notifications on windows xp appearing?
20130517 23:35:14-!- lipkab [~lipk@apn-151-0-94-7.vodafone.hu] has quit [Quit: Konversation terminated!]
20130517 23:35:27< anonymissimus> nurupo: I started the test scenario and that message that comes at the beginning shows up in the tray area
20130517 23:35:56< anonymissimus> what kind of (other) test setups do you have or want me to check ?
20130517 23:36:17< nurupo> i thought notifications only work in multiplayer when wesnoth windows is not active
20130517 23:36:29< anonymissimus> it also switches to the window when clicked
20130517 23:36:35< anonymissimus> well, apparently not
20130517 23:37:41-!- wesbot changed the topic of #wesnoth-dev to: 1.11.4 released, announcing soon | current repo: https://github.com/wesnoth/wesnoth-old (still to be fixed) | http://wiki.wesnoth.org/SummerOfCodeIdeas | Will move the repo to github, please read the dev-ml! | 181 bugs, 332 feature requests, 31 patches | Logs: http://irclogs.wesnoth.org | Don't paste on IRC! Use
20130517 23:37:44< nurupo> anyway, that should be the correct behavior, since i plugged my notifications in the same place other OS have them 
20130517 23:38:32< nurupo> i previously only checked notifications in multiplayer, never tried any scenario test or regular
20130517 23:40:27< nurupo> anonymissimus: that's basically it, there is nothing else to check except invoking several notifications, one right after another, so that the first balloon won't have time to disappear
20130517 23:40:59< nurupo> it can be done by sending several messages in multiplayer
20130517 23:44:33-!- jleldridge [~jleldridg@cpe-098-026-227-236.triad.res.rr.com] has quit [Quit: Leaving]
20130517 23:46:29-!- flix [~flix@dhcp-213-188.vpn.tu-berlin.de] has left #wesnoth-dev []
20130517 23:50:35< anonymissimus> nurupo: does it display all kind of chat messages ?
20130517 23:51:07< anonymissimus> there is the wml tag [chat] and wesnoth.message, the former uses the latter
20130517 23:51:19< nurupo> anonymissimus: it displays regular chat messages, action and changed turns
20130517 23:51:27< anonymissimus> there are chat messages in teh test scenario
20130517 23:52:01< anonymissimus> action ? in the multiplayer test I recall a message about taking control
20130517 23:52:03-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Quit: SIGKILL]
20130517 23:52:16< anonymissimus> and ones about it is side x tunr
20130517 23:52:22< anonymissimus> *turn
20130517 23:53:11< nurupo> anonymissimus: it shows any messages that get passed into send_notification(...) https://github.com/wesnoth/wesnoth-old/blob/4a0db701ac4ab4547e4d0cb6d0544ff1f9a4e650/src/game_display.cpp#L977
20130517 23:57:53< anonymissimus> nurupo: okay well, I guess it's good to go as far as I'm concerned :)
20130517 23:59:05< nurupo> good to hear :)
20130517 23:59:29< anonymissimus> notably, it was very quick and easy to handle with the pull request
--- Log closed Sat May 18 00:00:41 2013